RE: [PATCH V4 01/10] accel/kvm: Extract common KVM vCPU {creation,parking} code

2023-10-11 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Wednesday, October 11, 2023 8:09 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; > imamm

Re: [PATCH v2 00/10] mirror: allow switching from background to active mode

2023-10-11 Thread Fiona Ebner
Am 10.10.23 um 19:55 schrieb Vladimir Sementsov-Ogievskiy: > On 09.10.23 12:46, Fiona Ebner wrote: >> >> Initially, I tried to go for a more general 'job-change' command, but >> I couldn't figure out a way to avoid mutual inclusion between >> block-core.json and job.json. >> > > What is the proble

Re: [PATCH RFC V2 00/37] Support of Virtual CPU Hotplug for ARMv8 Arch

2023-10-11 Thread Vishnu Pajjuri
Hi Salil, On 26-09-2023 15:33, Salil Mehta wrote: [ *REPEAT: Sent patches got held at internal server yesterday* ] PROLOGUE To assist in review and set the right expectations from this RFC, please first read below sections *APPENDED AT THE END* of this cover letter, 1. Important *DIS

RE: [PATCH RFC V2 00/37] Support of Virtual CPU Hotplug for ARMv8 Arch

2023-10-11 Thread Salil Mehta via
Hi Vishnu, > From: Vishnu Pajjuri > Sent: Wednesday, October 11, 2023 11:23 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org;

[PULL 19/25] gdbstub: Replace gdb_regs with an array

2023-10-11 Thread Alex Bennée
From: Akihiko Odaki An array is a more appropriate data structure than a list for gdb_regs since it is initialized only with append operation and read-only after initialization. Signed-off-by: Akihiko Odaki Reviewed-by: Alistair Francis Message-Id: <20230912224107.29669-13-akihiko.od...@daynix

[PULL 02/25] tests/avocado: remove flaky test marking for test_sbsaref_edk2_firmware

2023-10-11 Thread Alex Bennée
After testing locally I decided to revert a5754847e0 (tests/avocado: Disable the test_sbsaref_edk2_firmware by default) as the test seems pretty stable: env QEMU_TEST_FLAKY_TESTS=1 retry.py -n 50 -c -- \ ./tests/venv/bin/avocado run \ ./tests/avocado/machine_aarch64_sbsaref.py:Aarch6

[PULL 01/25] tests/avocado: update firmware to enable OpenBSD test on sbsa-ref

2023-10-11 Thread Alex Bennée
From: Marcin Juszkiewicz Update prebuilt firmware images: - Neoverse V1/N2 cpu support - non-secure EL2 virtual timer - XHCI controller in DSDT With those changes we can now run OpenBSD as part of sbsa-ref tests. Signed-off-by: Marcin Juszkiewicz Message-Id: <20230927120050.210187-2-marcin.jus

[PULL 00/25] testing, gdbstub and plugin updates

2023-10-11 Thread Alex Bennée
The following changes since commit 0ad0d9dcd16f2ea816a413008ac5191ebef45c95: Merge tag 'firmware/seabios-20231010-pull-request' of https://gitlab.com/kraxel/qemu into staging (2023-10-10 10:22:16 -0400) are available in the Git repository at: https://gitlab.com/stsquad/qemu.git tags/pull-om

[PULL 04/25] gitlab: shuffle some targets and reduce avocado noise

2023-10-11 Thread Alex Bennée
We move a couple of targets out of the avocado runs because there are no tests to run. Tricore already has some coverage. The cris target only really has check-tcg tests but its getting harder to find anything that packages the compiler. To reduce the noise of CANCEL messages we also set AVOCADO_

[PULL 14/25] hw/core/cpu: Return static value with gdb_arch_name()

2023-10-11 Thread Alex Bennée
From: Akihiko Odaki All implementations of gdb_arch_name() returns dynamic duplicates of static strings. It's also unlikely that there will be an implementation of gdb_arch_name() that returns a truly dynamic value due to the nature of the function returning a well-known identifiers. Qualify the

[PULL 09/25] gdbstub: Fix target.xml response

2023-10-11 Thread Alex Bennée
From: Akihiko Odaki It was failing to return target.xml after the first request. Fixes: 56e534bd11 ("gdbstub: refactor get_feature_xml") Signed-off-by: Akihiko Odaki Message-Id: <20230912224107.29669-3-akihiko.od...@daynix.com> Signed-off-by: Alex Bennée Message-Id: <20231009164104.369749-10-a

[PULL 11/25] contrib/plugins: Use GRWLock in execlog

2023-10-11 Thread Alex Bennée
From: Akihiko Odaki execlog had the following comment: > As we could have multiple threads trying to do this we need to > serialise the expansion under a lock. Threads accessing already > created entries can continue without issue even if the ptr array > gets reallocated during resize. However,

[PULL 08/25] gdbstub: Fix target_xml initialization

2023-10-11 Thread Alex Bennée
From: Akihiko Odaki target_xml is no longer a fixed-length array but a pointer to a variable-length memory. Fixes: 56e534bd11 ("gdbstub: refactor get_feature_xml") Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-Id: <20230912224107.29669-

[PULL 06/25] configure: allow user to override docker engine

2023-10-11 Thread Alex Bennée
If you have both engines installed but one is broken you are stuck with the automagic. Allow the user to override the engine for this case. Signed-off-by: Alex Bennée Reviewed-by: Alistair Francis Message-Id: <20231009164104.369749-7-alex.ben...@linaro.org> diff --git a/configure b/configure in

[PULL 03/25] tests/lcitool: add swtpm to the package list

2023-10-11 Thread Alex Bennée
We need this to test some TPM stuff. Reviewed-by: "Daniel P. Berrangé" Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20231009164104.369749-4-alex.ben...@linaro.org> diff --git a/.gitlab-ci.d/cirrus/macos-12.vars b/.gitlab-ci.d/cirrus/macos-12.vars index 80eadaab2

[PULL 13/25] target/arm: Move the reference to arm-core.xml

2023-10-11 Thread Alex Bennée
From: Akihiko Odaki Some subclasses overwrite gdb_core_xml_file member but others don't. Always initialize the member in the subclasses for consistency. This especially helps for AArch64; in a following change, the file specified by gdb_core_xml_file is always looked up even if it's going to be

[PULL 05/25] tests/docker: make docker engine choice entirely configure driven

2023-10-11 Thread Alex Bennée
Since 0b1a649047 (tests/docker: use direct RUNC call to build containers) we ended up with the potential for the remaining docker.py script calls to deviate from the direct RUNC calls. Fix this by dropping the use of ENGINE in the makefile and rely entirely on what we detect at configure time. We

[PULL 10/25] plugins: Check if vCPU is realized

2023-10-11 Thread Alex Bennée
From: Akihiko Odaki The created member of CPUState tells if the vCPU thread is started, and will be always false for the user space emulation that manages threads independently. Use the realized member of DeviceState, which is valid for both of the system and user space emulation. Fixes: 54cb65d

[PULL 12/25] gdbstub: Introduce GDBFeature structure

2023-10-11 Thread Alex Bennée
From: Akihiko Odaki Before this change, the information from a XML file was stored in an array that is not descriptive. Introduce a dedicated structure type to make it easier to understand and to extend with more fields. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Reviewed

[PULL 15/25] gdbstub: Use g_markup_printf_escaped()

2023-10-11 Thread Alex Bennée
From: Akihiko Odaki g_markup_printf_escaped() is a safer alternative to simple printf() as it automatically escapes values. Signed-off-by: Akihiko Odaki Message-Id: <20230912224107.29669-9-akihiko.od...@daynix.com> Signed-off-by: Alex Bennée Message-Id: <20231009164104.369749-16-alex.ben...@li

[PULL 07/25] configure: remove gcc version suffixes

2023-10-11 Thread Alex Bennée
The modern packaging of cross GCC's doesn't need the explicit version number at the end. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20231009164104.369749-8-alex.ben...@linaro.org> diff --git a/configure b/configure index 5c04e63bab..8fada85a71 100755 --- a/confi

[PULL 20/25] accel/tcg: Add plugin_enabled to DisasContextBase

2023-10-11 Thread Alex Bennée
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20230824181233.1568795-2-richard.hender...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20231009164104.369749-21-alex.ben...@linaro.org> diff --git a/include/exec/translator.h b/include/exec/translator.h index 9d9e980

[PULL 23/25] contrib/plugins: fix coverity warning in cache

2023-10-11 Thread Alex Bennée
Coverity complains that appends_stats_line can be fed a 0 leading to the undefined behaviour of a divide by 0. Fixes: CID 1519044 Fixes: CID 1519047 Signed-off-by: Alex Bennée Message-Id: <20231009164104.369749-24-alex.ben...@linaro.org> diff --git a/contrib/plugins/cache.c b/contrib/plugins/cac

[PULL 17/25] target/ppc: Remove references to gdb_has_xml

2023-10-11 Thread Alex Bennée
From: Akihiko Odaki GDB has XML support since 6.7 which was released in 2007. It's time to remove support for old GDB versions without XML support. Signed-off-by: Akihiko Odaki Message-Id: <20230912224107.29669-11-akihiko.od...@daynix.com> Signed-off-by: Alex Bennée Message-Id: <20231009164104

[PULL 25/25] contrib/plugins: fix coverity warning in hotblocks

2023-10-11 Thread Alex Bennée
Coverity complains that we have an unbalance use of mutex leading to potential deadlocks. Fixes: CID 1519048 Fixes: a208ba09bd ("tests/plugin: add a hotblocks plugin") Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20231009164104.369749-26-alex.ben...@linaro.org> di

[PULL 22/25] plugins: Set final instruction count in plugin_gen_tb_end

2023-10-11 Thread Alex Bennée
From: Matt Borgerson Translation logic may partially decode an instruction, then abort and remove the instruction from the TB. This can happen for example when an instruction spans two pages. In this case, plugins may get an incorrect result when calling qemu_plugin_tb_n_insns to query for the nu

[PULL 18/25] gdbstub: Remove gdb_has_xml variable

2023-10-11 Thread Alex Bennée
From: Akihiko Odaki GDB has XML support since 6.7 which was released in 2007. It's time to remove support for old GDB versions without XML support. Signed-off-by: Akihiko Odaki Reviewed-by: Alistair Francis Message-Id: <20230912224107.29669-12-akihiko.od...@daynix.com> Signed-off-by: Alex Benn

[PULL 24/25] contrib/plugins: fix coverity warning in lockstep

2023-10-11 Thread Alex Bennée
Coverity complains that e don't check for a truncation when copying in the path. Bail if we can't copy the whole path into sockaddr. Fixes: CID 1519045 Fixes: CID 1519046 Signed-off-by: Alex Bennée Message-Id: <20231009164104.369749-25-alex.ben...@linaro.org> diff --git a/contrib/plugins/lockste

[PULL 21/25] target/sh4: Disable decode_gusa when plugins enabled

2023-10-11 Thread Alex Bennée
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20230824181233.1568795-3-richard.hender...@linaro.org> [AJB: fixed s/cpu_env/tcg_env/ during re-base] Signed-off-by: Alex Bennée Message-Id: <20231009164104.369749-22-alex.ben...@linaro.org> diff --git a/target/sh4/translate

[PULL 16/25] target/arm: Remove references to gdb_has_xml

2023-10-11 Thread Alex Bennée
From: Akihiko Odaki GDB has XML support since 6.7 which was released in 2007. It's time to remove support for old GDB versions without XML support. Signed-off-by: Akihiko Odaki Acked-by: Alex Bennée Reviewed-by: Alistair Francis Message-Id: <20230912224107.29669-10-akihiko.od...@daynix.com> S

Re: wiki.qemu.org is experiencing technical difficulties

2023-10-11 Thread Stefan Hajnoczi
Hi Philippe, For some reason the database was not running. It's back now. Thanks, Stefan

[PATCH] hw/i386/cxl: ensure maxram is greater than ram size for calculating cxl range

2023-10-11 Thread Ani Sinha
pc_get_device_memory_range() finds the device memory size by calculating the difference between maxram and ram sizes. This calculation makes sense only when maxram is greater than the ram size. Make sure we check for that before calling pc_get_device_memory_range(). Signed-off-by: Ani Sinha ---

Re: [PATCH 00/22] block: Graph locking part 5 (protect children/parent links)

2023-10-11 Thread Kevin Wolf
Am 10.10.2023 um 22:48 hat Stefan Hajnoczi geschrieben: > On Fri, Sep 29, 2023 at 04:51:35PM +0200, Kevin Wolf wrote: > > After all the preparation in previous series, this series reaches an > > important milestone for the graph locking work: TSA can now verify that > > all accesses to the children

Re: [PATCH RFC V2 00/37] Support of Virtual CPU Hotplug for ARMv8 Arch

2023-10-11 Thread Vishnu Pajjuri
Hi Salil, On 11-10-2023 16:02, Salil Mehta wrote: [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.] Hi Vishnu, From: Vishnu Pajjuri Sent: Wednesday, October 11, 2023 11:23 AM To

[PULL 06/13] MAINTAINERS: Add include folder to the hw/char/ section

2023-10-11 Thread Michael Tokarev
From: Thomas Huth The "Character devices" section only covers hw/char/ but misses the corresponding include/hw/char/ folder. Add it now. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff -

[PULL 00/13] Trivial patches for 2023-10-11

2023-10-11 Thread Michael Tokarev
The following changes since commit 0ad0d9dcd16f2ea816a413008ac5191ebef45c95: Merge tag 'firmware/seabios-20231010-pull-request' of https://gitlab.com/kraxel/qemu into staging (2023-10-10 10:22:16 -0400) are available in the Git repository at: https://gitlab.com/mjt0k/qemu.git tags/pull-triv

[PULL 09/13] MAINTAINERS: Add section for overall sensors

2023-10-11 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Sensor devices depend on some bus, not a particular board. While merged for a particular board, sensor devices don't depend on it. They depend on a bus technology, and can be used by any board exposing such bus. In order to help merging sensor patches, when they fall

[PULL 01/13] Update AMD memory encryption document links.

2023-10-11 Thread Michael Tokarev
From: Jianlin Li The previous links for the white paper and programmer's manual are no longer available. Replace them with the new ones. Signed-off-by: Jianlin Li Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- docs/system/i386/amd-memory-encryption.rst | 6 +++--- 1 file cha

[PULL 02/13] hw/rdma/vmw/pvrdma_cmd: Use correct struct in query_port()

2023-10-11 Thread Michael Tokarev
From: Peter Maydell In query_port() we pass the address of a local pvrdma_port_attr struct to the rdma_query_backend_port() function. Unfortunately, rdma_backend_query_port() wants a pointer to a struct ibv_port_attr, and the two are not the same length. Coverity spotted this (CID 1507146): pvr

[PULL 13/13] cpus: Remove unused smp_cores/smp_threads declarations

2023-10-11 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Commit a5e0b33119 ("vl.c: Replace smp global variables with smp machine properties") removed the last uses of the smp_cores / smp_threads variables but forgot to remove their declarations. Do it now. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokar

[PULL 07/13] MAINTAINERS: Add the CI-related doc files to the CI section

2023-10-11 Thread Michael Tokarev
From: Thomas Huth The docs/devel/ci* were not covered yet, add them to MAINTAINERS so that the right people are put on CC: for related patches. Signed-off-by: Thomas Huth Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev --- MAINTAINERS | 1 + 1 fil

[PULL 10/13] MAINTAINERS: Add some unowned files to the SBSA-REF section

2023-10-11 Thread Michael Tokarev
From: Thomas Huth These files belong to the sbsa-ref machine and thus should be listed here. Signed-off-by: Thomas Huth Reviewed-by: Leif Lindholm Signed-off-by: Michael Tokarev --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b217080fee.

[PULL 05/13] MAINTAINERS: Add unowned RISC-V related files to the right sections

2023-10-11 Thread Michael Tokarev
From: Thomas Huth There are a bunch of RISC-V files that are currently not covered by the "get_maintainers.pl" script. Add them to the right sections in MAINTAINERS to fix this problem. Signed-off-by: Thomas Huth Acked-by: Christoph Müllner Reviewed-by: Daniel Henrique Barboza Reviewed-by: Ph

Re: [PATCH v2 05/10] mirror: implement mirror_change method

2023-10-11 Thread Fiona Ebner
Am 10.10.23 um 21:37 schrieb Vladimir Sementsov-Ogievskiy: > On 09.10.23 12:46, Fiona Ebner wrote: >>   +static void mirror_change(BlockJob *job, BlockJobChangeOptions *opts, >> +  Error **errp) >> +{ >> +    MirrorBlockJob *s = container_of(job, MirrorBlockJob, common); >>

[PULL 11/13] roms: use PYTHON to invoke python

2023-10-11 Thread Michael Tokarev
From: Olaf Hering python3 may not be the expected python version. Use PYTHON to invoke python. Fixes: 22e11539e1 ("edk2: replace build scripts") Signed-off-by: Olaf Hering Signed-off-by: Michael Tokarev --- roms/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rom

[PULL 08/13] MAINTAINERS: add standard-headers to Hosts/LINUX

2023-10-11 Thread Michael Tokarev
From: Cornelia Huck The files in there are updated via update-linux-headers.sh. Signed-off-by: Cornelia Huck Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAIN

Re: [PATCH v2] migration: refactor migration_completion

2023-10-11 Thread Juan Quintela
Wei Wang wrote: > Current migration_completion function is a bit long. Refactor the long > implementation into different subfunctions: > - migration_completion_precopy: completion code related to precopy > - migration_completion_postcopy: completion code related to postcopy > - close_return_path_o

[PULL 03/13] Fix compilation when UFFDIO_REGISTER is not set.

2023-10-11 Thread Michael Tokarev
From: Pierre Labatut Signed-off-by: Pierre Labatut Signed-off-by: Michael Tokarev --- subprojects/libvhost-user/libvhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/subprojects/libvhost-user/libvhost-user.c b/subprojects/libvhost-user/libvhost-user.c index 051a6

[PULL 12/13] scripts/xml-preprocess: Make sure this script is invoked via the right Python

2023-10-11 Thread Michael Tokarev
From: Thomas Huth If a script is executable and has a shebang line, Meson treats it as a normal executable, so that this script here is run via the "python3" binary in the $PATH. However, "python3" might not be in the $PATH at all, or it might be a wrong version, so we should make sure to run thi

[PULL 04/13] MAINTAINERS: Add g364fb and ds1225y to the Jazz section

2023-10-11 Thread Michael Tokarev
From: Thomas Huth These devices are only used by the Jazz machine, so they should be listed in the corresponding section in MAINTAINERS. Signed-off-by: Thomas Huth Acked-by: Philippe Mathieu-Daudé Signed-off-by: Michael Tokarev --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --

Re: [PATCH 6/6] hw/s390x: Clean up global variable shadowing in quiesce_powerdown_req()

2023-10-11 Thread Eric Farman
On Mon, 2023-10-09 at 11:47 +0200, Philippe Mathieu-Daudé wrote: > Fix: > >   hw/s390x/sclpquiesce.c:90:22: error: declaration shadows a variable > in the global scope [-Werror,-Wshadow] >   QuiesceNotifier *qn = container_of(n, QuiesceNotifier, > notifier); >    ^ >   hw/s

Re: wiki.qemu.org is experiencing technical difficulties

2023-10-11 Thread Philippe Mathieu-Daudé
On 11/10/23 12:53, Stefan Hajnoczi wrote: Hi Philippe, For some reason the database was not running. It's back now. Thanks Stefan!

Re: [PATCH v2] migration: Use g_autofree to simplify ram_dirty_bitmap_reload()

2023-10-11 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Fabiano Rosas

Re: [PATCH RFC v4 0/9] Add loongarch kvm accel support

2023-10-11 Thread Philippe Mathieu-Daudé
Hi, On 9/10/23 11:01, xianglai li wrote: This series add loongarch kvm support, mainly implement some interfaces used by kvm such as kvm_arch_get/set_regs, kvm_arch_handle_exit, kvm_loongarch_set_interrupt, etc. Currently, we are able to boot LoongArch KVM Linux Guests. In loongarch VM, mmio de

Re: [PATCH v2] migration: refactor migration_completion

2023-10-11 Thread Juan Quintela
Wei Wang wrote: > Current migration_completion function is a bit long. Refactor the long > implementation into different subfunctions: > - migration_completion_precopy: completion code related to precopy > - migration_completion_postcopy: completion code related to postcopy > - close_return_path_o

[PATCH 0/2] hw/ppc/ppc440_uc: Maintain and remove dead code

2023-10-11 Thread Philippe Mathieu-Daudé
- Cover ppc440_uc in MAINTAINERS - Remove dead code Philippe Mathieu-Daudé (2): MAINTAINERS: Cover hw/ppc/ppc440_uc.c with Sam460ex board hw/ppc/ppc440_uc: Remove dead l2sram_update_mappings() MAINTAINERS| 1 + hw/ppc/ppc440_uc.c | 40 2 file

[PATCH 2/2] hw/ppc/ppc440_uc: Remove dead l2sram_update_mappings()

2023-10-11 Thread Philippe Mathieu-Daudé
Apparently l2sram_update_mappings() bit-rotted over time, when defining MAP_L2SRAM we get: hw/ppc/ppc440_uc.c:83:17: error: no member named 'isarc' in 'struct ppc4xx_l2sram_t' if (l2sram->isarc != isarc || ~~ ^ hw/ppc/ppc440_uc.c:84:18: error: no member named 'isacntl' in

Re: [PATCH] vfio/pci: rename vfio_put_device to vfio_pci_put_device

2023-10-11 Thread Philippe Mathieu-Daudé
Hi, On 22/9/23 04:52, Zhenzhong Duan wrote: vfio_put_device() is a VFIO PCI specific function, rename it with 'vfio_pci' prefix to avoid confusing. Why not, but what about the other functions? $ git grep -F '(VFIOPCIDevice *' hw/vfio/pci.c | grep -vF ' vfio_pci_' hw/vfio/pci.c:51:static void

Re: [PULL 06/65] tests/qtest: migration: Add support for negative testing of qmp_migrate

2023-10-11 Thread Fabiano Rosas
Juan Quintela writes: > From: Fabiano Rosas > > There is currently no way to write a test for errors that happened in > qmp_migrate before the migration has started. > > Add a version of qmp_migrate that ensures an error happens. To make > use of it a test needs to set MigrateCommon.result as >

Re: [PATCH v1] migration: fix RAMBlock add NULL check

2023-10-11 Thread Juan Quintela
Dmitry Frolov wrote: > qemu_ram_block_from_host() may return NULL, which will be dereferenced w/o > check. Usualy return value is checked for this function. > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: c7c0e72408df5e7821c0e995122fb2fe0ac001f1 ("migration/ram: Hand

Re: [PATCH v4] migration: Allow user to specify available switchover bandwidth

2023-10-11 Thread Juan Quintela
Peter Xu wrote: > Migration bandwidth is a very important value to live migration. It's > because it's one of the major factors that we'll make decision on when to > switchover to destination in a precopy process. > > This value is currently estimated by QEMU during the whole live migration > pro

Re: [PATCH v2 1/6] migration: Add the configuration vmstate to the json writer

2023-10-11 Thread Juan Quintela
Fabiano Rosas wrote: > From: Nikolay Borisov > > Make the migration json writer part of MigrationState struct, allowing > the 'configuration' object be serialized to json. > > This will facilitate the parsing of the 'configuration' object in the > next patch that fixes analyze-migration.py for ar

[PATCH] hw/ide/ahci: trigger either error IRQ or regular IRQ, not both

2023-10-11 Thread Niklas Cassel
From: Niklas Cassel According to AHCI 1.3.1, 5.3.8.1 RegFIS:Entry, if ERR_STAT is set, we jump to state ERR:FatalTaskfile, which will raise a TFES IRQ unconditionally, regardless if the I bit is set in the FIS or not. Thus, we should never raise a normal IRQ after having sent an error IRQ. NOTE

Re: [PATCH v2 2/6] migration: Fix analyze-migration.py 'configuration' parsing

2023-10-11 Thread Juan Quintela
Fabiano Rosas wrote: > The 'configuration' state subsections are currently not being parsed > and the script fails when analyzing an aarch64 stream: > > Traceback (most recent call last): > File "./scripts/analyze-migration.py", line 625, in > dump.read(dump_memory = args.memory) > File "

[PATCH 1/2] MAINTAINERS: Cover hw/ppc/ppc440_uc.c with Sam460ex board

2023-10-11 Thread Philippe Mathieu-Daudé
hw/ppc/ppc440_uc.c implements the TYPE_PPC460EX_PCIE_HOST device, which is used by the aCube Sam460ex board. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9e7dec4a58..8c07d07927 100644 --- a/MAINTAINERS +

Re: [PATCH v1] migration: fix RAMBlock add NULL check

2023-10-11 Thread Дмитрий Фролов
On 10.10.2023 22:23, Peter Xu wrote: On Tue, Oct 10, 2023 at 01:48:53PM +0300, Dmitry Frolov wrote: qemu_ram_block_from_host() may return NULL, which will be dereferenced w/o AFAIU this path is only called from trusted sites, so I don't see why it can be NULL? Do you have any scenario that

Re: [PATCH v2 3/6] migration: Add capability parsing to analyze-migration.py

2023-10-11 Thread Juan Quintela
Fabiano Rosas wrote: > The script is broken when the configuration/capabilities section is > present. Add support for parsing the capabilities so we can fix it in > the next patch. > > Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela

Re: [PATCH v2 4/6] migration: Fix analyze-migration.py when ignore-shared is used

2023-10-11 Thread Juan Quintela
Fabiano Rosas wrote: > The script is currently broken when the x-ignore-shared capability is > used: > > Traceback (most recent call last): > File "./scripts/analyze-migration.py", line 656, in > dump.read(dump_memory = args.memory) > File "./scripts/analyze-migration.py", line 593, in re

[PATCH 0/5] hw/pci-host: Build ppc4xx_pci.c/ppc440_pcix.c once

2023-10-11 Thread Philippe Mathieu-Daudé
- Move ppc4xx_pci.c/ppc440_pcix.c from hw/ppc/ to hw/pci-host/ - Build them once for all targets Philippe Mathieu-Daudé (5): hw/ppc/ppc4xx_pci: Remove unused "hw/ppc/ppc.h" header hw/ppc/ppc4xx_pci: Extract PCI host definitions to hw/pci-host/ppc4xx.h hw/ppc/ppc4xx_pci: Declare PPC4XX_PC

[PATCH 2/5] hw/ppc/ppc4xx_pci: Extract PCI host definitions to hw/pci-host/ppc4xx.h

2023-10-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + include/hw/pci-host/ppc4xx.h | 17 + include/hw/ppc/ppc4xx.h | 5 - hw/ppc/ppc440_bamboo.c | 1 + hw/ppc/ppc440_pcix.c | 2 +- hw/ppc/ppc440_uc.c | 1 + hw/ppc/ppc4x

[PATCH 5/5] hw/ppc/ppc440_pcix: Move ppc440_pcix.c to hw/pci-host/

2023-10-11 Thread Philippe Mathieu-Daudé
ppc440_pcix.c is moved from the target specific ppc_ss[] meson source set to pci_ss[] which is common to all targets: the object is built once. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS| 2 +- hw/{ppc => pci-host}/ppc440_pcix.c | 0 hw/pci-host/Kconfig

[PATCH 4/5] hw/ppc/ppc4xx_pci: Move ppc4xx_pci.c to hw/pci-host/

2023-10-11 Thread Philippe Mathieu-Daudé
ppc4xx_pci.c is moved from the target specific ppc_ss[] meson source set to pci_ss[] which is common to all targets: the object is built once. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + hw/{ppc => pci-host}/ppc4xx_pci.c | 0 hw/pci-host/ppce500.c

[PATCH 1/5] hw/ppc/ppc4xx_pci: Remove unused "hw/ppc/ppc.h" header

2023-10-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/ppc440_pcix.c | 1 - hw/ppc/ppc4xx_pci.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ppc/ppc440_pcix.c b/hw/ppc/ppc440_pcix.c index 672090de94..e4dadbc84d 100644 --- a/hw/ppc/ppc440_pcix.c +++ b/hw/ppc/ppc440_pcix.c @@ -25,7 +25,6 @@

[PATCH 3/5] hw/ppc/ppc4xx_pci: Declare PPC4XX_PCI in Kconfig

2023-10-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/Kconfig | 4 hw/ppc/Kconfig | 2 +- hw/ppc/meson.build | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig index a07070eddf..a9030a433b 100644 --- a/hw/pci-host/Kconfig ++

Re: [PATCH v2 5/6] migration: Fix analyze-migration read operation signedness

2023-10-11 Thread Juan Quintela
Fabiano Rosas wrote: > The migration code uses unsigned values for 16, 32 and 64-bit > operations. Fix the script to do the same. > > This was causing an issue when parsing the migration stream generated > on the ppc64 target because one of instance_ids was larger than the > 32bit signed maximum:

Re: [PATCH] hw/ide/ahci: trigger either error IRQ or regular IRQ, not both

2023-10-11 Thread Philippe Mathieu-Daudé
On 11/10/23 15:12, Niklas Cassel wrote: From: Niklas Cassel According to AHCI 1.3.1, 5.3.8.1 RegFIS:Entry, if ERR_STAT is set, we jump to state ERR:FatalTaskfile, which will raise a TFES IRQ unconditionally, regardless if the I bit is set in the FIS or not. Thus, we should never raise a normal

Re: [PATCH v2] migration: Use g_autofree to simplify ram_dirty_bitmap_reload()

2023-10-11 Thread Juan Quintela
Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > Based-on: > v2: Do use g_autofree... Reviewed-by: Juan Quintela

Re: [PATCH v1 5/9] qapi: golang: Generate qapi's union types in Go

2023-10-11 Thread Victor Toso
Hi, On Fri, Sep 29, 2023 at 03:41:27PM +0200, Victor Toso wrote: > Hi, > > On Thu, Sep 28, 2023 at 03:21:59PM +0100, Daniel P. Berrangé wrote: > > On Wed, Sep 27, 2023 at 01:25:40PM +0200, Victor Toso wrote: > > > This patch handles QAPI union types and generates the equivalent data > > > structu

Re: [PATCH v2 6/6] tests/qtest/migration: Add a test for the analyze-migration script

2023-10-11 Thread Juan Quintela
Fabiano Rosas wrote: > Add a smoke test that migrates to a file and gives it to the > script. It should catch the most annoying errors such as changes in > the ram flags. > > After code has been merged it becomes way harder to figure out what is > causing the script to fail, the person making the

Running cross-compiled binary using QEMU results in segmentation fault error

2023-10-11 Thread Asad Javed
Hi, We have cross compiled a simple hello world program for QNX SDP 7.1.0 on Ubuntu Focal x86_64. Running the binary using qemu-aarch64 results in segmentation fault error. The qemu-aarch64 version is 5.2.0. Steps: 1. Source QNX SDP to set some environment variables. source ./qnx710/qnxs

Re: [PATCH 2/2] hw/ppc/ppc440_uc: Remove dead l2sram_update_mappings()

2023-10-11 Thread BALATON Zoltan
On Wed, 11 Oct 2023, Philippe Mathieu-Daudé wrote: Apparently l2sram_update_mappings() bit-rotted over time, when defining MAP_L2SRAM we get: hw/ppc/ppc440_uc.c:83:17: error: no member named 'isarc' in 'struct ppc4xx_l2sram_t' if (l2sram->isarc != isarc || ~~ ^ hw/ppc/ppc44

[PATCH] virtio-blk: don't start dataplane during the stop of dataplane

2023-10-11 Thread lv.mengzhao
From: hujian During the stop of dataplane for virtio-blk, virtio_bus_cleanup_host_notifier() is be called to clean up notifier at the end, if polled ioeventfd, virtio_blk_handle_output() is used to handle io request. But due to s->dataplane_disabled is false, it will be returned directly, whic

[PATCH] virtio-blk: don't start dataplane during the stop of dataplane

2023-10-11 Thread hujian
During the stop of dataplane for virtio-blk, virtio_bus_cleanup_host_notifier() is be called to clean up notifier at the end, if polled ioeventfd, virtio_blk_handle_output() is used to handle io request. But due to s->dataplane_disabled is false, it will be returned directly, which drops io requ

Re: [PATCH 1/2] MAINTAINERS: Cover hw/ppc/ppc440_uc.c with Sam460ex board

2023-10-11 Thread BALATON Zoltan
On Wed, 11 Oct 2023, Philippe Mathieu-Daudé wrote: hw/ppc/ppc440_uc.c implements the TYPE_PPC460EX_PCIE_HOST device, which is used by the aCube Sam460ex board. Signed-off-by: Philippe Mathieu-Daudé I guess there's nobody else to take these so Acked-by: BALATON Zoltan --- MAINTAINERS | 1 +

[PATCH] riscv, qemu_fw_cfg: Add support for RISC-V architecture

2023-10-11 Thread Björn Töpel
From: Björn Töpel Qemu fw_cfg support was missing for RISC-V, which made it hard to do proper vmcore dumps from qemu. Add the missing RISC-V arch-defines. You can now do vmcore dumps from qemu. Add "-device vmcoreinfo" to the qemu command-line. From the qemu montior: (qemu) dump-guest-memory

Re: [PATCH 1/5] hw/ppc/ppc4xx_pci: Remove unused "hw/ppc/ppc.h" header

2023-10-11 Thread BALATON Zoltan
On Wed, 11 Oct 2023, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: BALATON Zoltan --- hw/ppc/ppc440_pcix.c | 1 - hw/ppc/ppc4xx_pci.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ppc/ppc440_pcix.c b/hw/ppc/ppc440_pcix.c index 672090de94..e4dadbc8

[PATCH] virtio-blk: don't start dataplane during the stop of dataplane

2023-10-11 Thread lv.mengzhao
From: hujian During the stop of dataplane for virtio-blk, virtio_bus_cleanup_host_notifier() is be called to clean up notifier at the end, if polled ioeventfd, virtio_blk_handle_output() is used to handle io request. But due to s->dataplane_disabled is false, it will be returned directly, whic

Re: [PATCH] riscv, qemu_fw_cfg: Add support for RISC-V architecture

2023-10-11 Thread Clément Léger
Hi Björn, On 11/10/2023 13:47, Björn Töpel wrote: > From: Björn Töpel > > Qemu fw_cfg support was missing for RISC-V, which made it hard to do > proper vmcore dumps from qemu. > > Add the missing RISC-V arch-defines. > > You can now do vmcore dumps from qemu. Add "-device vmcoreinfo" to the

Re: [PATCH v2 4/6] migration: Fix analyze-migration.py when ignore-shared is used

2023-10-11 Thread Fabiano Rosas
Juan Quintela writes: > Fabiano Rosas wrote: >> The script is currently broken when the x-ignore-shared capability is >> used: >> >> Traceback (most recent call last): >> File "./scripts/analyze-migration.py", line 656, in >> dump.read(dump_memory = args.memory) >> File "./scripts/analy

Re: [PATCH v12 09/10] migration: Implement MigrateChannelList to hmp migration flow.

2023-10-11 Thread Het Gala
On 10/10/2023 2:38 AM, Fabiano Rosas wrote: Het Gala writes: Integrate MigrateChannelList with all transport backends (socket, exec and rdma) for both src and dest migration endpoints for hmp migration. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala --- migration/migration-hmp-cmd

Re: [PATCH v2 1/6] migration: Add the configuration vmstate to the json writer

2023-10-11 Thread Fabiano Rosas
Juan Quintela writes: > Fabiano Rosas wrote: >> From: Nikolay Borisov >> >> Make the migration json writer part of MigrationState struct, allowing >> the 'configuration' object be serialized to json. >> >> This will facilitate the parsing of the 'configuration' object in the >> next patch that

Re: [PATCH v2 6/6] tests/qtest/migration: Add a test for the analyze-migration script

2023-10-11 Thread Fabiano Rosas
Juan Quintela writes: > Fabiano Rosas wrote: >> Add a smoke test that migrates to a file and gives it to the >> script. It should catch the most annoying errors such as changes in >> the ram flags. >> >> After code has been merged it becomes way harder to figure out what is >> causing the script

Re: [PATCH 2/5] hw/ppc/ppc4xx_pci: Extract PCI host definitions to hw/pci-host/ppc4xx.h

2023-10-11 Thread BALATON Zoltan
On Wed, 11 Oct 2023, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: BALATON Zoltan Regards, BALATON Zoltan --- MAINTAINERS | 1 + include/hw/pci-host/ppc4xx.h | 17 + include/hw/ppc/ppc4xx.h | 5 - hw/ppc/ppc440_bam

Re: [PATCH 2/2] hw/ppc/ppc440_uc: Remove dead l2sram_update_mappings()

2023-10-11 Thread Philippe Mathieu-Daudé
Hi Zoltan, On 11/10/23 15:31, BALATON Zoltan wrote: On Wed, 11 Oct 2023, Philippe Mathieu-Daudé wrote: Apparently l2sram_update_mappings() bit-rotted over time, when defining MAP_L2SRAM we get:  hw/ppc/ppc440_uc.c:83:17: error: no member named 'isarc' in 'struct ppc4xx_l2sram_t' if (l2s

Re: [PATCH 4/5] hw/ppc/ppc4xx_pci: Move ppc4xx_pci.c to hw/pci-host/

2023-10-11 Thread BALATON Zoltan
On Wed, 11 Oct 2023, Philippe Mathieu-Daudé wrote: ppc4xx_pci.c is moved from the target specific ppc_ss[] meson source set to pci_ss[] which is common to all targets: the object is built once. At this point I'm not sure. This device is only used for PPC machines so it's kind of target specifi

Re: [PATCH 3/5] hw/ppc/ppc4xx_pci: Declare PPC4XX_PCI in Kconfig

2023-10-11 Thread BALATON Zoltan
On Wed, 11 Oct 2023, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Should this be squashed with next patch? It looks strange to have config defined in hw/pci-host/Kconfig but used in hw/ppc/meson.build. Regards, BALATON Zoltan --- hw/pci-host/Kconfig | 4 hw/ppc/

[PATCH v3 1/6] target/riscv: Without H-mode mask all HS mode inturrupts in mie.

2023-10-11 Thread Rajnesh Kanwal
Signed-off-by: Rajnesh Kanwal Reviewed-by: Alistair Francis --- target/riscv/csr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index 85a31dc420..0241c77719 100644 --- a/target/riscv/csr.c +++ b/target/riscv/csr.c @@ -1524,7 +1524,7

[PATCH v3 3/6] target/riscv: Set VS* bits to one in mideleg when H-Ext is enabled

2023-10-11 Thread Rajnesh Kanwal
With H-Ext supported, VS bits are all hardwired to one in MIDELEG denoting always delegated interrupts. This is being done in rmw_mideleg but given mideleg is used in other places when routing interrupts this change initializes it in riscv_cpu_realize to be on the safe side. Signed-off-by: Rajnesh

[PATCH v3 0/6] target/riscv: Add RISC-V Virtual IRQs and IRQ filtering support

2023-10-11 Thread Rajnesh Kanwal
This series adds M and HS-mode virtual interrupt and IRQ filtering support. This allows inserting virtual interrupts from M/HS-mode into S/VS-mode using mvien/hvien and mvip/hvip csrs. IRQ filtering is a use case of this change, i-e M-mode can stop delegating an interrupt to S-mode and instead enab

[PATCH v3 6/6] target/riscv: Add HS-mode virtual interrupt and IRQ filtering support.

2023-10-11 Thread Rajnesh Kanwal
This change adds support for inserting virtual interrupts from HS-mode into VS-mode using hvien and hvip csrs. This also allows for IRQ filtering from HS-mode. Also, the spec doesn't mandate the interrupt to be actually supported in hardware. Which allows HS-mode to assert virtual interrupts to VS

<    1   2   3   4   5   6   >