Re: [PATCH v5 3/3] hw/vfio: add ramfb migration support

2023-10-10 Thread Cédric Le Goater
On 10/9/23 12:19, Laszlo Ersek wrote: On 10/9/23 08:32, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Add a "VFIODisplay" subsection whenever "x-ramfb-migrate" is turned on. Turn it off by default on machines <= 8.1 for compatibility reasons. Signed-off-by: Marc-André Lureau Re

Re: [PATCH v5 3/3] hw/vfio: add ramfb migration support

2023-10-10 Thread Marc-André Lureau
Hi On Tue, Oct 10, 2023 at 11:03 AM Cédric Le Goater wrote: > > On 10/9/23 12:19, Laszlo Ersek wrote: > > On 10/9/23 08:32, marcandre.lur...@redhat.com wrote: > >> From: Marc-André Lureau > >> > >> Add a "VFIODisplay" subsection whenever "x-ramfb-migrate" is turned on. > >> > >> Turn it off by d

Re: [PATCH v2 6/6] tests/qtest/migration: Add a test for the analyze-migration script

2023-10-10 Thread Thomas Huth
On 09/10/2023 20.43, Fabiano Rosas wrote: Add a smoke test that migrates to a file and gives it to the script. It should catch the most annoying errors such as changes in the ram flags. After code has been merged it becomes way harder to figure out what is causing the script to fail, the person

Re: [PATCH v2 16/18] hw/sm501: allow compiling without PIXMAN

2023-10-10 Thread Marc-André Lureau
Hi Zoltan On Mon, Sep 18, 2023 at 9:59 PM BALATON Zoltan wrote: > > On Mon, 18 Sep 2023, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Drop the "x-pixman" property and use fallback path in such case. > > > > Signed-off-by: Marc-André Lureau > > --- > > hw/display/sm501.

Re: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-10 Thread Philippe Mathieu-Daudé
On 10/10/23 08:04, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: [...] If we have to clean that for -Wshadow=global, I'm tempted to rename the typedef as 'vaddr_t' and keep the 'vaddr' variable names. POSIX reserves suffix _t, see https://pubs.opengroup.org/onlinepubs/9699919799/f

Re: [PATCH V4 02/10] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

2023-10-10 Thread Shaoqin Huang
On 10/10/23 04:35, Salil Mehta via wrote: CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jo

[PATCH v3 01/18] build-sys: add a "pixman" feature

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau For now, pixman is mandatory, but we set config_host.h and Kconfig. Once compilation is fixed, "pixman" will become actually optional. Signed-off-by: Marc-André Lureau --- meson.build | 10 -- include/ui/qemu-pixman.h | 2 ++ Kconfig.host

[PATCH v3 00/18] Make Pixman an optional dependency

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau Hi, QEMU system emulators can be made to compile and work without Pixman. Only a few devices and options actually require it (VNC, Gtk, Spice for ex) and will have to be compiled out. However, most of QEMU graphics-related code is based on pixman_image_t and format. If

Re: [PATCH V4 03/10] hw/acpi: Add ACPI CPU hotplug init stub

2023-10-10 Thread Shaoqin Huang
On 10/10/23 04:35, Salil Mehta via wrote: ACPI CPU hotplug related initialization should only happen if ACPI_CPU_HOTPLUG support has been enabled for particular architecture. Add cpu_hotplug_hw_init() stub to avoid compilation break. Signed-off-by: Salil Mehta Reviewed-by: Jonathan Cameron

[PATCH v3 11/18] ui/vnc: VNC requires PIXMAN

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build| 6 +- ui/meson.build | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index c30da15ce6..291c2f1301 100644 --- a/meson.build +++ b/meson.build @@ -1530,7 +1530,11 @

[PATCH v3 15/18] arm/kconfig: XLNX_ZYNQMP_ARM depends on PIXMAN

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau The Display Port has some strong PIXMAN dependency. Signed-off-by: Marc-André Lureau --- hw/arm/Kconfig | 3 ++- hw/display/Kconfig | 5 + hw/display/meson.build | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/arm/Kconfig b/hw/a

[PATCH v3 07/18] virtio-gpu: replace PIXMAN for region/rect test

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau Use a simpler implementation for rectangle geometry & intersect, drop the need for (more complex) PIXMAN functions. Signed-off-by: Marc-André Lureau --- include/ui/rect.h | 55 + hw/display/virtio-gpu.c | 30 +---

[PATCH v3 04/18] ui/console: allow to override the default VC

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau If a display is backed by a specialized VC, allow to override the default "vc:80Cx24C". For that, set the dpy.type just before creating the default serial/parallel/monitor. As suggested by Paolo, if the display doesn't implement a VC (get_vc() returns NULL), use a fallbac

[PATCH v3 09/18] vhost-user-gpu: skip VHOST_USER_GPU_UPDATE when !PIXMAN

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau This simply means that 2d drawing updates won't be handled, but 3d should work. Signed-off-by: Marc-André Lureau --- hw/display/vhost-user-gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost-user-gpu.c index 1150521

[PATCH v3 02/18] ui: compile out some qemu-pixman functions when !PIXMAN

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau Those functions require the PIXMAN library. Signed-off-by: Marc-André Lureau --- include/ui/qemu-pixman.h | 7 +-- ui/qemu-pixman.c | 6 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.

[PATCH v3 18/18] build-sys: make pixman actually optional

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build | 3 --- 1 file changed, 3 deletions(-) diff --git a/meson.build b/meson.build index 64d2aca79b..a35eb8e2ee 100644 --- a/meson.build +++ b/meson.build @@ -817,9 +817,6 @@ if not get_option('pixman').auto() or have_system

[PATCH v3 17/18] hw/display: make ATI_VGA depend on PIXMAN

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- configs/devices/mips64el-softmmu/default.mak | 2 +- hw/display/Kconfig | 2 +- hw/display/meson.build | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configs/devi

[PATCH v3 05/18] ui/vc: console-vc requires PIXMAN

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau Add stubs for the fallback paths. get_vc() now returns NULL by default if !PIXMAN. Signed-off-by: Marc-André Lureau --- ui/console-vc-stubs.c | 32 ui/console.c | 3 +++ ui/meson.build| 2 +- 3 files changed, 36 inser

[PATCH v3 08/18] ui/console: when PIXMAN is unavailable, don't draw placeholder msg

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau When we can't draw text, simply show a blank display. Signed-off-by: Marc-André Lureau --- ui/console.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/console.c b/ui/console.c index a72c495b5a..8e688d3569 100644 --- a/ui/console.c +++ b/ui/console.c @@ -584,6

[PATCH v3 06/18] qmp/hmp: disable screendump if PIXMAN is missing

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau The command requires color conversion and line-by-line feeding. We could have a simple fallback for simple formats though. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- qapi/ui.json | 3 ++- ui/ui-hmp-cmds.c | 2 ++ ui/ui-qmp-cmds.c | 2 +

[PATCH v3 12/18] ui/spice: SPICE/QXL requires PIXMAN

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build| 6 +- hw/display/Kconfig | 2 +- ui/meson.build | 10 +- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/meson.build b/meson.build index 291c2f1301..a84a2f25d0 100644 --- a/meson.

[PATCH v3 14/18] ui/dbus: do not require PIXMAN

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau Implement a fallback path for region 2D update. Signed-off-by: Marc-André Lureau --- ui/dbus-listener.c | 88 -- ui/meson.build | 2 +- 2 files changed, 62 insertions(+), 28 deletions(-) diff --git a/ui/dbus-listener.c b

[PATCH v3 10/18] ui/gl: opengl doesn't require PIXMAN

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau The QEMU fallback covers the requirements. We still need the flags of header inclusion with CONFIG_PIXMAN. Signed-off-by: Marc-André Lureau --- ui/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/meson.build b/ui/meson.build index 3

[PATCH v3 13/18] ui/gtk: -display gtk requires PIXMAN

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index a84a2f25d0..64d2aca79b 100644 --- a/meson.build +++ b/meson.build @@ -1501,7 +1501,11 @@ gtkx11 = not_found vte = no

[PATCH v3 03/18] ui: add pixman-compat.h

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau This is a tiny subset of PIXMAN API that is used pervasively in QEMU codebase to manage images and identify the underlying format. It doesn't seems worth to wrap this in a QEMU-specific API. Signed-off-by: Marc-André Lureau --- include/ui/pixman-compat.h | 195

[PATCH v3 16/18] hw/sm501: allow compiling without PIXMAN

2023-10-10 Thread marcandre . lureau
From: Marc-André Lureau Drop the "x-pixman" property and use fallback path in such case. Signed-off-by: Marc-André Lureau --- hw/display/sm501.c | 46 +- 1 file changed, 37 insertions(+), 9 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/s

[PATCH 3/4] tests/libqtest: Introduce qtest_get_base_arch()

2023-10-10 Thread Philippe Mathieu-Daudé
While qtest_get_arch() returns the target architecture name, such "i386" or "x86_64", qtest_get_base_arch() return the "base" (or real underlying) architecture, in this example that is "x86". Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/libqtest.h | 7 +++ tests/qtest/libqtest.c |

[PATCH 2/4] tests/qtest: Use qtest_get_arch_bits()

2023-10-10 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/arm-cpu-features.c | 49 -- tests/qtest/bios-tables-test.c | 16 +-- 2 files changed, 30 insertions(+), 35 deletions(-) diff --git a/tests/qtest/arm-cpu-features.c b/tests/qtest/arm-cpu-features.c index

[PATCH 4/4] tests/qtest: Use qtest_get_base_arch()

2023-10-10 Thread Philippe Mathieu-Daudé
Additionally use qtest_get_arch_bits() when relevant. Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/ahci-test.c | 5 ++--- tests/qtest/am53c974-test.c | 4 +--- tests/qtest/bios-tables-test.c| 6 +++--- tests/qtest/boot-sector.c | 6 +++--- tests/qtest/dev

[PATCH 0/4] tests/qtest: Introduce qtest_get_base_arch() and qtest_get_arch_bits()

2023-10-10 Thread Philippe Mathieu-Daudé
When unifying some 32/64 architectures as a single binary (for example i386 & x86_64 -> x86), some qtests fail because we lose some information (the arch bits). This series introduce the tuple qtest_get_base_arch() / qtest_get_arch_bits() to allow the tests to keep passing. Eventually we should r

[PATCH 1/4] tests/libqtest: Introduce qtest_get_arch_bits()

2023-10-10 Thread Philippe Mathieu-Daudé
Add a method to return the architecture bits (currently 8/32/64). Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/libqtest.h | 8 tests/qtest/libqtest.c | 21 + 2 files changed, 29 insertions(+) diff --git a/tests/qtest/libqtest.h b/tests/qtest/libqtest.h ind

[RFC PATCH 02/11] tests/avocado: Add ppc pseries and powernv Hash MMU tests

2023-10-10 Thread Nicholas Piggin
The Hash MMU mode is supported along side Radix in POWER hardware, and Linux supports running in either mode. Radix is the default so to keep up testing of QEMU Hash MMU, add some explicit Hash MMU tests. Signed-off-by: Nicholas Piggin --- tests/avocado/ppc_powernv.py | 21 ++---

[RFC PATCH 05/11] testing/avocado: ppc add new BookE boot_linux_console.py tests

2023-10-10 Thread Nicholas Piggin
Add simple Linux kernel boot tests for BookE 64-bit and 32-bit CPUs using Guenter Roeck's rootfs images for Linux testing, and a gitlab repository with kernel images that I built since there are very few sources of modern BookE images now. Signed-off-by: Nicholas Piggin --- tests/avocado/boot_li

[RFC PATCH 00/11] ppc: avocado test additions and new defaults

2023-10-10 Thread Nicholas Piggin
Sorry for going missing for a while, had a few things on but have been working on figuring out testing and git setup to get some things merged. To start with I'd like to add a few more tests. Since most of my own tests for missing bits (like KVM backend) are mostly just ad hoc scripts, I thought a

[RFC PATCH 03/11] tests/avocado: Add pseries KVM boot_linux test

2023-10-10 Thread Nicholas Piggin
There is not much support for KVM backend. Add a KVM boot_linux.py test for pseries. Signed-off-by: Nicholas Piggin --- tests/avocado/boot_linux.py | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_linux.py index be30dcbd58..6ce08ff6aa

[RFC PATCH 11/11] ppc/pnv: Change powernv default to powernv10

2023-10-10 Thread Nicholas Piggin
POWER10 is the latest IBM Power machine. Although it is not offered in "OPAL mode" (i.e., powernv configuration), so there is a case that it should remain at powernv9, most of the development work is going into powernv10 at the moment. Signed-off-by: Nicholas Piggin --- hw/ppc/pnv.c | 4 ++-- 1

[RFC PATCH 06/11] tests/avocado: Add FreeBSD distro boot tests for ppc

2023-10-10 Thread Nicholas Piggin
FreeBSD project provides qcow2 images that work well for testing QEMU. Add pseries tests for HPT and Radix, KVM and TCG. Other architectures could be added so this does not get a ppc_ prefix but is instead named similarly to boot_linux. Cc: Warner Losh Signed-off-by: Nicholas Piggin CC'ing War

[RFC PATCH 01/11] tests/avocado: ppc add powernv10 boot_linux_console test

2023-10-10 Thread Nicholas Piggin
Add a powernv POWER10 variant for boot_linux_console.py. Signed-off-by: Nicholas Piggin --- tests/avocado/boot_linux_console.py | 8 1 file changed, 8 insertions(+) diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py index 01ee149812..9434304cd3 1006

[RFC PATCH 04/11] tests/avocado: ppc add hypervisor tests

2023-10-10 Thread Nicholas Piggin
The powernv and pseries machines both provide hypervisor facilities, which is a large and complicated set of features that don't get much system testing in CI. Add a new test case for these which runs QEMU KVM inside the target. --- tests/avocado/ppc_hv_tests.py | 173

[RFC PATCH 07/11] tests/avocado: Add ppc boot tests for non-free AIX images

2023-10-10 Thread Nicholas Piggin
An AIX image can be provided by setting AIX_IMAGE environment variable when running avocado. It's questionable whether we should carry these in upstream QEMU. It's convenient to see how to run these things, but simple enough to maintain in out of tree branch. I just wanted to see opinions about it

[RFC PATCH 08/11] tests/avocado: Add ppc MacOS tests

2023-10-10 Thread Nicholas Piggin
Similarly to the AIX test, this adds some tests that can boot MacOS9 and OSX images that are provided. --- tests/avocado/ppc/macos9.ppm | Bin 0 -> 921615 bytes tests/avocado/ppc_macos.py | 90 +++ 2 files changed, 90 insertions(+) create mode 100644 tests/avoca

[RFC PATCH 10/11] ppc/spapr: change pseries machine default to POWER10 CPU

2023-10-10 Thread Nicholas Piggin
POWER10 is the latest pseries CPU. Signed-off-by: Nicholas Piggin --- hw/ppc/spapr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index d4230d3647..9d3475d64b 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -4661,7 +4661,7 @@ static void

[RFC PATCH 09/11] tests/avocado: Use default CPU for pseries machine

2023-10-10 Thread Nicholas Piggin
Use the default CPU with the pseries machine unless there is a specific requirement. Signed-off-by: Nicholas Piggin --- tests/avocado/migration.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/avocado/migration.py b/tests/avocado/migration.py index fdc1d234fb..91ac33919b 100644 --- a/

Re: [PATCH v2 1/7] tap: Fix virtio-net header buffer size

2023-10-10 Thread Michael Tokarev
10.10.2023 05:59, Akihiko Odaki wrote: The largest possible virtio-net header is struct virtio_net_hdr_v1_hash. Fixes: fbbdbddec0 ("tap: allow extended virtio header with hash info") Signed-off-by: Akihiko Odaki --- net/tap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --

Re: [RFC PATCH 08/11] tests/avocado: Add ppc MacOS tests

2023-10-10 Thread Philippe Mathieu-Daudé
Hi Nicholas, On 10/10/23 09:52, Nicholas Piggin wrote: Similarly to the AIX test, this adds some tests that can boot MacOS9 and OSX images that are provided. --- tests/avocado/ppc/macos9.ppm | Bin 0 -> 921615 bytes tests/avocado/ppc_macos.py | 90 +++ 2 fi

Re: [RFC PATCH 00/11] ppc: avocado test additions and new defaults

2023-10-10 Thread Philippe Mathieu-Daudé
On 10/10/23 09:52, Nicholas Piggin wrote: Sorry for going missing for a while, had a few things on but have been working on figuring out testing and git setup to get some things merged. To start with I'd like to add a few more tests. Since most of my own tests for missing bits (like KVM backend)

Re: [PATCH v2 3/7] virtio-net: Disable RSS on reset

2023-10-10 Thread Michael Tokarev
10.10.2023 05:59, Akihiko Odaki wrote: RSS is disabled by default. Fixes: 590790297c ("virtio-net: implement RSS configuration command") Signed-off-by: Akihiko Odaki This one is difficult to review since it moves whole function around *and* adding a single statement to this function. I'd pre

Re: [RFC PATCH 05/11] testing/avocado: ppc add new BookE boot_linux_console.py tests

2023-10-10 Thread Philippe Mathieu-Daudé
On 10/10/23 09:52, Nicholas Piggin wrote: Add simple Linux kernel boot tests for BookE 64-bit and 32-bit CPUs using Guenter Roeck's rootfs images for Linux testing, and a gitlab repository with kernel images that I built since there are very few sources of modern BookE images now. Signed-off-by:

Re: [PATCH V4 07/10] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2023-10-10 Thread Shaoqin Huang
On 10/10/23 04:35, Salil Mehta via wrote: ACPI GED shall be used to convey to the guest kernel about any CPU hot-(un)plug events. Therefore, existing ACPI GED framework inside QEMU needs to be enhanced to support CPU hotplug state and events. Co-developed-by: Keqian Zhu Signed-off-by: Keqian

Re: [Virtio-fs] (no subject)

2023-10-10 Thread Hanna Czenczek
On 10.10.23 06:00, Yajun Wu wrote: On 10/9/2023 5:13 PM, Hanna Czenczek wrote: External email: Use caution opening links or attachments On 09.10.23 11:07, Hanna Czenczek wrote: On 09.10.23 10:21, Hanna Czenczek wrote: On 07.10.23 04:22, Yajun Wu wrote: [...] The main motivation of adding

Re: [PATCH 3/4] tests/libqtest: Introduce qtest_get_base_arch()

2023-10-10 Thread Philippe Mathieu-Daudé
On 10/10/23 09:49, Philippe Mathieu-Daudé wrote: While qtest_get_arch() returns the target architecture name, such "i386" or "x86_64", qtest_get_base_arch() return the "base" (or real underlying) architecture, in this example that is "x86". Signed-off-by: Philippe Mathieu-Daudé --- tests/qtes

Re: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-10 Thread Thomas Huth
On 10/10/2023 09.34, Philippe Mathieu-Daudé wrote: On 10/10/23 08:04, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: [...] If we have to clean that for -Wshadow=global, I'm tempted to rename the typedef as 'vaddr_t' and keep the 'vaddr' variable names. POSIX reserves suffix _t, se

[PATCH 03/18] target/riscv: Remove CPU_RESOLVING_TYPE from 'cpu-qom.h'

2023-10-10 Thread Philippe Mathieu-Daudé
CPU_RESOLVING_TYPE is a per-target definition, and is irrelevant for other targets. Move it to "cpu.h". Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/cpu-qom.h | 1 - target/riscv/cpu.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/target/riscv/cpu-qom.h b/ta

[PATCH 05/18] target/hexagon: Declare QOM definitions in 'cpu-qom.h'

2023-10-10 Thread Philippe Mathieu-Daudé
"target/foo/cpu.h" contains the target specific declarations. A heterogeneous setup need to access target agnostic declarations (at least the QOM ones, to instantiate the objects). Our convention is to add such target agnostic QOM declarations in the "target/foo/cpu-qom.h" header. Extract QOM de

[PATCH 07/18] target/nios2: Declare QOM definitions in 'cpu-qom.h'

2023-10-10 Thread Philippe Mathieu-Daudé
"target/foo/cpu.h" contains the target specific declarations. A heterogeneous setup need to access target agnostic declarations (at least the QOM ones, to instantiate the objects). Our convention is to add such target agnostic QOM declarations in the "target/foo/cpu-qom.h" header. Extract QOM de

[PATCH 01/18] target: Mention 'cpu-qom.h' is target agnostic

2023-10-10 Thread Philippe Mathieu-Daudé
"target/foo/cpu-qom.h" is supposed to be target agnostic (include-able by any target). Add such mention in the header. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu-qom.h| 2 +- target/hppa/cpu-qom.h | 2 +- target/microblaze/cpu-qom.h | 2 +- 3 files changed, 3 insertio

[PATCH 15/18] cpus: Open code OBJECT_DECLARE_TYPE() in OBJECT_DECLARE_CPU_TYPE()

2023-10-10 Thread Philippe Mathieu-Daudé
Since the OBJECT_DECLARE_CPU_TYPE() macro uses the abstract ArchCPU type, when declaring multiple CPUs of the same ArchCPU type we get an error related to the indirect G_DEFINE_AUTOPTR_CLEANUP_FUNC() use within OBJECT_DECLARE_TYPE(): target/mips/cpu-qom.h:31:1: error: redefinition of 'glib_auto

[PATCH 02/18] target/ppc: Remove CPU_RESOLVING_TYPE from 'cpu-qom.h'

2023-10-10 Thread Philippe Mathieu-Daudé
CPU_RESOLVING_TYPE is a per-target definition, and is irrelevant for other targets. Move it to "cpu.h". Signed-off-by: Philippe Mathieu-Daudé --- target/ppc/cpu-qom.h | 3 +-- target/ppc/cpu.h | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/target/ppc/cpu-qom.h b/targe

[PATCH 11/18] target/i386: Declare CPU QOM types using DEFINE_TYPES() macro

2023-10-10 Thread Philippe Mathieu-Daudé
When multiple QOM types are registered in the same file, it is simpler to use the the DEFINE_TYPES() macro. In particular because type array declared with such macro are easier to review. In few commits we are going to add more types, so replace the type_register_static() to ease further reviews.

[PATCH 10/18] target/riscv: Inline target specific TYPE_RISCV_CPU_BASE definition

2023-10-10 Thread Philippe Mathieu-Daudé
TYPE_RISCV_CPU_BASE depends on the TARGET_RISCV32/TARGET_RISCV64 definitions which are target specific. Such target specific definition taints "cpu-qom.h". Since "cpu-qom.h" must be target agnostic, remove its target specific definition uses by inlining TYPE_RISCV_CPU_BASE in the two machines usin

[PATCH 18/18] target/sparc: Make SPARC_CPU common to new SPARC32_CPU/SPARC64_CPU types

2023-10-10 Thread Philippe Mathieu-Daudé
"target/foo/cpu-qom.h" can not use any target specific definitions. Currently "target/sparc/cpu-qom.h" defines TYPE_SPARC_CPU depending on the sparc(32)/sparc64 build type. This doesn't scale in a heterogeneous context where we need to access both types concurrently. In order to do that, introduc

[PATCH 04/18] target: Declare FOO_CPU_TYPE_NAME/SUFFIX in 'cpu-qom.h'

2023-10-10 Thread Philippe Mathieu-Daudé
Hegerogeneous code needs access to the FOO_CPU_TYPE_NAME() macro to resolve target CPU types. Move the declaration (along with the required FOO_CPU_TYPE_SUFFIX) to "cpu-qom.h". Signed-off-by: Philippe Mathieu-Daudé --- target/alpha/cpu-qom.h | 5 - target/alpha/cpu.h | 2 -- target/a

[PATCH 16/18] target/i386: Make X86_CPU common to new I386_CPU / X86_64_CPU types

2023-10-10 Thread Philippe Mathieu-Daudé
"target/foo/cpu-qom.h" can not use any target specific definitions. Currently "target/i386/cpu-qom.h" defines TYPE_X86_CPU depending on the i386/x86_64 build type. This doesn't scale in a heterogeneous context where we need to access both types concurrently. In order to do that, introduce the new

[PATCH 17/18] target/mips: Make MIPS_CPU common to new MIPS32_CPU / MIPS64_CPU types

2023-10-10 Thread Philippe Mathieu-Daudé
"target/foo/cpu-qom.h" can not use any target specific definitions. Currently "target/mips/cpu-qom.h" defines TYPE_MIPS_CPU depending on the mips(32)/mips64 build type. This doesn't scale in a heterogeneous context where we need to access both types concurrently. In order to do that, introduce th

[PATCH 08/18] target/openrisc: Declare QOM definitions in 'cpu-qom.h'

2023-10-10 Thread Philippe Mathieu-Daudé
"target/foo/cpu.h" contains the target specific declarations. A heterogeneous setup need to access target agnostic declarations (at least the QOM ones, to instantiate the objects). Our convention is to add such target agnostic QOM declarations in the "target/foo/cpu-qom.h" header. Extract QOM de

[PATCH 14/18] target/sparc: Declare CPU QOM types using DEFINE_TYPES() macro

2023-10-10 Thread Philippe Mathieu-Daudé
When multiple QOM types are registered in the same file, it is simpler to use the the DEFINE_TYPES() macro. In particular because type array declared with such macro are easier to review. In few commits we are going to add more types, so replace the type_register_static() to ease further reviews.

[PATCH 13/18] target/ppc: Declare CPU QOM types using DEFINE_TYPES() macro

2023-10-10 Thread Philippe Mathieu-Daudé
When multiple QOM types are registered in the same file, it is simpler to use the the DEFINE_TYPES() macro. In particular because type array declared with such macro are easier to review. In few commits we are going to add more types, so replace the type_register_static() to ease further reviews.

[PATCH 09/18] target/i386: Inline target specific TARGET_DEFAULT_CPU_TYPE definition

2023-10-10 Thread Philippe Mathieu-Daudé
TARGET_DEFAULT_CPU_TYPE depends on the TARGET_X86_64 definition which is target specific. Such target specific definition taint "cpu-qom.h". Since "cpu-qom.h" must be target agnostic, remove this target specific definition uses by inlining TARGET_DEFAULT_CPU_TYPE in the two machines using it. "ta

[PATCH 12/18] target/mips: Declare CPU QOM types using DEFINE_TYPES() macro

2023-10-10 Thread Philippe Mathieu-Daudé
When multiple QOM types are registered in the same file, it is simpler to use the the DEFINE_TYPES() macro. In particular because type array declared with such macro are easier to review. In few commits we are going to add more types, so replace the type_register_static() to ease further reviews.

[PATCH 06/18] target/loongarch: Declare QOM definitions in 'cpu-qom.h'

2023-10-10 Thread Philippe Mathieu-Daudé
"target/foo/cpu.h" contains the target specific declarations. A heterogeneous setup need to access target agnostic declarations (at least the QOM ones, to instantiate the objects). Our convention is to add such target agnostic QOM declarations in the "target/foo/cpu-qom.h" header. Extract QOM de

Re: [PATCH 4/4] tests/qtest: Use qtest_get_base_arch()

2023-10-10 Thread Akihiko Odaki
On 2023/10/10 16:49, Philippe Mathieu-Daudé wrote: Additionally use qtest_get_arch_bits() when relevant. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Akihiko Odaki

Re: [PATCH 1/4] tests/libqtest: Introduce qtest_get_arch_bits()

2023-10-10 Thread Thomas Huth
On 10/10/2023 09.49, Philippe Mathieu-Daudé wrote: Add a method to return the architecture bits (currently 8/32/64). Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/libqtest.h | 8 tests/qtest/libqtest.c | 21 + 2 files changed, 29 insertions(+) diff --g

RE: [PATCH RFC V2 03/37] hw/arm/virt: Move setting of common CPU properties in a function

2023-10-10 Thread Salil Mehta via
Hi Shaoqin, > From: Shaoqin Huang > Sent: Tuesday, October 10, 2023 7:47 AM > > On 9/26/23 18:04, Salil Mehta via wrote: > > Factor out CPU properties code common for {hot,cold}-plugged CPUs. This > > allows > > code reuse. > > > > Signed-off-by: Salil Mehta > > --- > > hw/arm/virt.c

Re: [PATCH 1/4] tests/libqtest: Introduce qtest_get_arch_bits()

2023-10-10 Thread Philippe Mathieu-Daudé
On 10/10/23 11:46, Thomas Huth wrote: On 10/10/2023 09.49, Philippe Mathieu-Daudé wrote: Add a method to return the architecture bits (currently 8/32/64). Signed-off-by: Philippe Mathieu-Daudé ---   tests/qtest/libqtest.h |  8   tests/qtest/libqtest.c | 21 +   2 fi

[PATCH v2] hw/loongarch: remove global loaderparams variable

2023-10-10 Thread Thomas Weißschuh
garch_firmware_boot(lams); +loongarch_firmware_boot(lams, &loaderparams); } else { -loongarch_direct_kernel_boot(lams); +loongarch_direct_kernel_boot(lams, &loaderparams); } } fdt_add_flash_node(lams); --- base-commit: 2f3913f4b2ad74baeb5a6f1d36efbd9ecdf1057d change-id: 20231010-loongarch-loader-params-f0bc0b2cb5ea Best regards, -- Thomas Weißschuh

RE: [PATCH V4 02/10] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

2023-10-10 Thread Salil Mehta via
> From: Shaoqin Huang > Sent: Tuesday, October 10, 2023 8:34 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; > imamm...@redha

RE: [PATCH V4 03/10] hw/acpi: Add ACPI CPU hotplug init stub

2023-10-10 Thread Salil Mehta via
> From: Shaoqin Huang > Sent: Tuesday, October 10, 2023 8:39 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; > imamm...@redha

Re: [PATCH 2/4] tests/qtest: Use qtest_get_arch_bits()

2023-10-10 Thread Thomas Huth
On 10/10/2023 09.49, Philippe Mathieu-Daudé wrote: Some short patch description, please! Why is this necessary/useful? (I think I know, but other might not, and it is also important for the history) Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/arm-cpu-features.c | 49 +++

RE: [PATCH V4 07/10] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2023-10-10 Thread Salil Mehta via
> From: Shaoqin Huang > Sent: Tuesday, October 10, 2023 9:18 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; > imamm...@redha

Re: [PATCH 3/4] tests/libqtest: Introduce qtest_get_base_arch()

2023-10-10 Thread Thomas Huth
On 10/10/2023 10.42, Philippe Mathieu-Daudé wrote: On 10/10/23 09:49, Philippe Mathieu-Daudé wrote: While qtest_get_arch() returns the target architecture name, such "i386" or "x86_64", qtest_get_base_arch() return the "base" (or real underlying) architecture, in this example that is "x86". Sig

Re: [PATCH v2 16/18] hw/sm501: allow compiling without PIXMAN

2023-10-10 Thread BALATON Zoltan
On Tue, 10 Oct 2023, Marc-André Lureau wrote: Hi Zoltan On Mon, Sep 18, 2023 at 9:59 PM BALATON Zoltan wrote: On Mon, 18 Sep 2023, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Drop the "x-pixman" property and use fallback path in such case. Signed-off-by: Marc-André Lureau

Re: [PATCH 4/4] tests/qtest: Use qtest_get_base_arch()

2023-10-10 Thread Thomas Huth
On 10/10/2023 09.49, Philippe Mathieu-Daudé wrote: Additionally use qtest_get_arch_bits() when relevant. Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/ahci-test.c | 5 ++--- tests/qtest/am53c974-test.c | 4 +--- tests/qtest/bios-tables-test.c| 6 +++--- tests

Re: [PATCH v2 16/18] hw/sm501: allow compiling without PIXMAN

2023-10-10 Thread Marc-André Lureau
Hi On Tue, Oct 10, 2023 at 1:53 PM BALATON Zoltan wrote: > > On Tue, 10 Oct 2023, Marc-André Lureau wrote: > > Hi Zoltan > > > > On Mon, Sep 18, 2023 at 9:59 PM BALATON Zoltan wrote: > >> > >> On Mon, 18 Sep 2023, marcandre.lur...@redhat.com wrote: > >>> From: Marc-André Lureau > >>> > >>> Drop

Re: [PATCH 2/4] tests/qtest: Use qtest_get_arch_bits()

2023-10-10 Thread Ani Sinha
> On 10-Oct-2023, at 3:19 PM, Thomas Huth wrote: > > On 10/10/2023 09.49, Philippe Mathieu-Daudé wrote: > > Some short patch description, please! Why is this necessary/useful? > (I think I know, but other might not, and it is also important for the > history) Other than this, Reviewed-by: A

Re: [Virtio-fs] (no subject)

2023-10-10 Thread German Maglione
On Tue, Oct 10, 2023 at 4:57 AM Yajun Wu wrote: > > > On 10/9/2023 6:28 PM, German Maglione wrote: > > External email: Use caution opening links or attachments > > > > > > On Sat, Oct 7, 2023 at 4:23 AM Yajun Wu wrote: > >> > >> On 10/6/2023 6:34 PM, Michael S. Tsirkin wrote: > >>> External email

Re: [PATCH v2 16/18] hw/sm501: allow compiling without PIXMAN

2023-10-10 Thread BALATON Zoltan
On Tue, 10 Oct 2023, Marc-André Lureau wrote: On Tue, Oct 10, 2023 at 1:53 PM BALATON Zoltan wrote: On Tue, 10 Oct 2023, Marc-André Lureau wrote: Hi Zoltan On Mon, Sep 18, 2023 at 9:59 PM BALATON Zoltan wrote: On Mon, 18 Sep 2023, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau

Re: [PATCH for-8.2 2/2] arm/kvm: convert to kvm_get_one_reg

2023-10-10 Thread Cornelia Huck
[spooky season is coming up, so time for some thread necromancy!] On Thu, Jul 27 2023, Cornelia Huck wrote: > On Tue, Jul 25 2023, Gavin Shan wrote: > >> On 7/24/23 18:48, Cornelia Huck wrote: >>> On Mon, Jul 24 2023, Gavin Shan wrote: On 7/18/23 21:14, Cornelia Huck wrote: > We

Re: [PATCH v2 16/18] hw/sm501: allow compiling without PIXMAN

2023-10-10 Thread Marc-André Lureau
Hi On Tue, Oct 10, 2023 at 2:09 PM BALATON Zoltan wrote: > > On Tue, 10 Oct 2023, Marc-André Lureau wrote: > > On Tue, Oct 10, 2023 at 1:53 PM BALATON Zoltan wrote: > >> On Tue, 10 Oct 2023, Marc-André Lureau wrote: > >>> Hi Zoltan > >>> > >>> On Mon, Sep 18, 2023 at 9:59 PM BALATON Zoltan wrot

Re: [PATCH] hw/ufs: Fix incorrect register fields

2023-10-10 Thread Bin Meng
On Tue, Oct 10, 2023 at 1:11 PM Jeuk Kim wrote: > > From: Jeuk Kim > > This patch fixes invalid ufs register fields. > This fixes an issue reported by Bin Meng that > caused ufs to fail over riscv. > Fixes: bc4e68d362ec ("hw/ufs: Initial commit for emulated Universal-Flash-Storage") Reported-by:

Re: [PATCH v2 16/18] hw/sm501: allow compiling without PIXMAN

2023-10-10 Thread BALATON Zoltan
On Tue, 10 Oct 2023, Marc-André Lureau wrote: Hi On Tue, Oct 10, 2023 at 2:09 PM BALATON Zoltan wrote: On Tue, 10 Oct 2023, Marc-André Lureau wrote: On Tue, Oct 10, 2023 at 1:53 PM BALATON Zoltan wrote: On Tue, 10 Oct 2023, Marc-André Lureau wrote: Hi Zoltan On Mon, Sep 18, 2023 at 9:59 

Re: [PATCH 4/4] tests/qtest: Use qtest_get_base_arch()

2023-10-10 Thread Philippe Mathieu-Daudé
On 10/10/23 11:58, Thomas Huth wrote: On 10/10/2023 09.49, Philippe Mathieu-Daudé wrote: Additionally use qtest_get_arch_bits() when relevant. Signed-off-by: Philippe Mathieu-Daudé ---   tests/qtest/ahci-test.c   |  5 ++---   tests/qtest/am53c974-test.c   |  4 +---   tests/qtest/bi

Re: [Virtio-fs] (no subject)

2023-10-10 Thread Alex Bennée
Hanna Czenczek writes: > On 10.10.23 06:00, Yajun Wu wrote: >> >> On 10/9/2023 5:13 PM, Hanna Czenczek wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> On 09.10.23 11:07, Hanna Czenczek wrote: On 09.10.23 10:21, Hanna Czenczek wrote: > On 07.10.23 04:22,

[PATCH v1] migration: fix RAMBlock add NULL check

2023-10-10 Thread Dmitry Frolov
qemu_ram_block_from_host() may return NULL, which will be dereferenced w/o check. Usualy return value is checked for this function. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: c7c0e72408df5e7821c0e995122fb2fe0ac001f1 ("migration/ram: Handle RAM block resizes during pr

Re: [PATCH v2 1/2] target/s390x/kvm: Turn KVM_CAP_SYNC_REGS into a hard requirement

2023-10-10 Thread Christian Borntraeger
Am 09.10.23 um 19:07 schrieb Thomas Huth: Since we already require at least kernel 3.15 in the s390x KVM code, we can assume that the KVM_CAP_SYNC_REGS capability is always there. Thus turn this into a hard requirement now. Signed-off-by: Thomas Huth --- target/s390x/kvm/kvm.c | 20 +++

Re: [PATCH v2 1/2] target/s390x/kvm: Turn KVM_CAP_SYNC_REGS into a hard requirement

2023-10-10 Thread Thomas Huth
On 10/10/2023 13.02, Christian Borntraeger wrote: Am 09.10.23 um 19:07 schrieb Thomas Huth: Since we already require at least kernel 3.15 in the s390x KVM code, we can assume that the KVM_CAP_SYNC_REGS capability is always there. Thus turn this into a hard requirement now. Signed-off-by: Thom

[PULL 3/6] seabios: update submodule to git snapshot

2023-10-10 Thread Gerd Hoffmann
git shortlog Gerd Hoffmann (7): disable array bounds warning better kvm detection detect physical address space size move 64bit pci window to end of address space be less conservative with the 64bit pci io window qemu: log reservations in fw_cfg e82

Re: [PATCH v2] hw/loongarch: remove global loaderparams variable

2023-10-10 Thread gaosong
loongarch_direct_kernel_boot(lams); +loongarch_direct_kernel_boot(lams, &loaderparams); } } fdt_add_flash_node(lams); --- base-commit: 2f3913f4b2ad74baeb5a6f1d36efbd9ecdf1057d change-id: 20231010-loongarch-loader-params-f0bc0b2cb5ea Best regards,

[PULL 6/6] tests/acpi: disable tests/data/acpi/q35/DSDT.mmio64 updates

2023-10-10 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index a251b20a1bdd..dfb8523c8bf4 100644 --- a/tests/qtest/bios-tables-test-all

[PULL 2/6] tests/acpi: enable tests/data/acpi/q35/DSDT.mmio64 updates

2023-10-10 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8bf4..a251b20a1bdd 100644 --- a/tests/qtest/bios-tables-test-al

[PULL 0/6] Firmware/seabios 20231010 patches

2023-10-10 Thread Gerd Hoffmann
s/firmware/seabios-20231010-pull-request for you to fetch changes up to e83f3600f9ff7d9e0d014f328e64c49bb81b945c: tests/acpi: disable tests/data/acpi/q35/DSDT.mmio64 updates (2023-10-10 11:11:55 +0200) seabios: update to git snap

  1   2   3   4   >