Re: [PATCH] ppc/pnv: Add an I2C master controller model

2023-10-09 Thread Cédric Le Goater
Hello Glenn, On 10/9/23 20:05, Glenn Miles wrote: From: Cédric Le Goater Not supported : . 10 bit addresses . multimaster . slave Signed-off-by: Cédric Le Goater Signed-off-by: Glenn Miles [milesg: fixed formatting warning] Overall it looks good ;) Some suggestions for the respin

RE: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-09 Thread Brian Cain
> -Original Message- > From: Philippe Mathieu-Daudé > Sent: Monday, October 9, 2023 1:43 AM > To: Brian Cain ; qemu-devel@nongnu.org > Cc: arm...@redhat.com; richard.hender...@linaro.org; > peter.mayd...@linaro.org; Matheus Bernardino (QUIC) > ; stefa...@redhat.com; a...@rev.ng; > a...@r

Re: [PATCH 3/3] vfio/ccw: Remove redundant definition of TYPE_VFIO_CCW

2023-10-09 Thread Cédric Le Goater
On 10/9/23 20:58, Eric Farman wrote: On Mon, 2023-10-09 at 10:20 +0800, Zhenzhong Duan wrote: No functional changes. Signed-off-by: Zhenzhong Duan I see Cedric has already queued this, but FWIW: Reviewed-by: Eric Farman I will take the new tags when I rebase. Thanks, C. ---  incl

RE: [PATCH V4 10/10] target/arm/kvm: Write CPU state back to KVM on reset

2023-10-09 Thread Salil Mehta via
Hello, Perhaps I need to drop this patch from this patch-set as it is ARM specific. I pulled this from RFC V2 of Virtual CPU Hotplug Support on ARMv8 and is not required by other architectures trying to implement Virtual CPU Hotplug Support. https://lore.kernel.org/qemu-devel/20230926103654.34424-

[PATCH] hw/loongarch: remove global loaderparams variable

2023-10-09 Thread Thomas Weißschuh
Passing the struct around explicitly makes the control-flow more obvious. Signed-off-by: Thomas Weißschuh --- hw/loongarch/virt.c | 50 - 1 file changed, 27 insertions(+), 23 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index 26

Re: [PATCH v12 00/10] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration

2023-10-09 Thread Fabiano Rosas
Het Gala writes: > This is v12 patchset of modified 'migrate' and 'migrate-incoming' QAPI design > for upstream review. > > Would like to thank all the maintainers that actively participated in the v11 > patchset discussion and gave insightful suggestions to improve the patches. > > Link to previ

Re: [PATCH v2] misc/pca9552: Fix for pca9552 not getting reset

2023-10-09 Thread Cédric Le Goater
Hello Glenn, On 10/5/23 23:10, Glenn Miles wrote: Testing of the pca9552 device on the powernv platform showed that the reset method was not being called when an instance of the device was realized. This was causing the INPUT0/INPUT1 POR values to be incorrect. Fixed by overriding the parent p

Re: [PATCH v12 09/10] migration: Implement MigrateChannelList to hmp migration flow.

2023-10-09 Thread Fabiano Rosas
Het Gala writes: > Integrate MigrateChannelList with all transport backends > (socket, exec and rdma) for both src and dest migration > endpoints for hmp migration. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala > --- > migration/migration-hmp-cmds.c | 15 +-- > mig

Re: [PATCH v2 3/3] qom: Link multiple numa nodes to device using a new object

2023-10-09 Thread Alex Williamson
On Mon, 9 Oct 2023 13:30:48 +0100 Jonathan Cameron wrote: > On Sun, 8 Oct 2023 01:47:40 +0530 > wrote: > > > From: Ankit Agrawal > > > > NVIDIA GPU's support MIG (Mult-Instance GPUs) feature [1], which allows > > partitioning of the GPU device resources (including device memory) into > > seve

Re: [PATCH 1/3] via-ide: Fix legacy mode emulation

2023-10-09 Thread Mark Cave-Ayland
On 08/10/2023 12:08, BALATON Zoltan wrote: On Sun, 8 Oct 2023, Mark Cave-Ayland wrote: On 05/10/2023 23:13, BALATON Zoltan wrote: The initial value for BARs were set in reset method for emulating legacy mode at start but this does not work because PCI code resets BARs after calling device res

Re: [PATCH 2/3] hw/pci-host: Add emulation of Mai Logic Articia S

2023-10-09 Thread Mark Cave-Ayland
On 08/10/2023 19:08, BALATON Zoltan wrote: On Sun, 8 Oct 2023, Mark Cave-Ayland wrote: On 05/10/2023 23:13, BALATON Zoltan wrote: The Articia S is a generic chipset supporting several different CPUs that were used on some PPC boards. This is a minimal emulation of the parts needed for emulati

Re: [PATCH] target/sparc: Clean up global variable shadowing

2023-10-09 Thread Mark Cave-Ayland
On 09/10/2023 10:24, Philippe Mathieu-Daudé wrote: Fix: target/sparc/translate.c:2823:66: error: declaration shadows a variable in the global scope [-Werror,-Wshadow] static void gen_load_trap_state_at_tl(TCGv_ptr r_tsptr, TCGv_env tcg_env)

Re: [PATCH 2/3] hw/pci-host: Add emulation of Mai Logic Articia S

2023-10-09 Thread BALATON Zoltan
On Mon, 9 Oct 2023, Mark Cave-Ayland wrote: On 08/10/2023 19:08, BALATON Zoltan wrote: On Sun, 8 Oct 2023, Mark Cave-Ayland wrote: On 05/10/2023 23:13, BALATON Zoltan wrote: The Articia S is a generic chipset supporting several different CPUs that were used on some PPC boards. This is a minim

Re: [PATCH v4 03/10] hw/fsi: Introduce IBM's cfam,fsi-slave

2023-10-09 Thread Ninad Palsule
Hello Cedric, Thanks for the review. On 9/11/23 07:19, Cédric Le Goater wrote: On 9/9/23 00:28, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The Common FRU Access Macro (CFAM), an address space containing various "engines" that drive ac

Re: [PATCH 1/3] via-ide: Fix legacy mode emulation

2023-10-09 Thread BALATON Zoltan
On Mon, 9 Oct 2023, Mark Cave-Ayland wrote: On 08/10/2023 12:08, BALATON Zoltan wrote: On Sun, 8 Oct 2023, Mark Cave-Ayland wrote: On 05/10/2023 23:13, BALATON Zoltan wrote: The initial value for BARs were set in reset method for emulating legacy mode at start but this does not work because

Re: [PATCH 2/3] hw/pci-host: Add emulation of Mai Logic Articia S

2023-10-09 Thread Mark Cave-Ayland
On 09/10/2023 22:57, BALATON Zoltan wrote: On Mon, 9 Oct 2023, Mark Cave-Ayland wrote: On 08/10/2023 19:08, BALATON Zoltan wrote: On Sun, 8 Oct 2023, Mark Cave-Ayland wrote: On 05/10/2023 23:13, BALATON Zoltan wrote: The Articia S is a generic chipset supporting several different CPUs that

Re: [PATCH 2/3] hw/pci-host: Add emulation of Mai Logic Articia S

2023-10-09 Thread BALATON Zoltan
On Mon, 9 Oct 2023, Mark Cave-Ayland wrote: On 09/10/2023 22:57, BALATON Zoltan wrote: On Mon, 9 Oct 2023, Mark Cave-Ayland wrote: On 08/10/2023 19:08, BALATON Zoltan wrote: On Sun, 8 Oct 2023, Mark Cave-Ayland wrote: On 05/10/2023 23:13, BALATON Zoltan wrote: The Articia S is a generic chi

Re: [PATCH 1/3] via-ide: Fix legacy mode emulation

2023-10-09 Thread Mark Cave-Ayland
On 09/10/2023 23:23, BALATON Zoltan wrote: On Mon, 9 Oct 2023, Mark Cave-Ayland wrote: On 08/10/2023 12:08, BALATON Zoltan wrote: On Sun, 8 Oct 2023, Mark Cave-Ayland wrote: On 05/10/2023 23:13, BALATON Zoltan wrote: The initial value for BARs were set in reset method for emulating legacy

Re: [QEMU][PATCH v1 1/7] xen: when unplugging emulated devices skip virtio devices

2023-10-09 Thread Stefano Stabellini
On Thu, 5 Oct 2023, Vikram Garhwal wrote: > From: Juergen Gross > > Virtio devices should never be unplugged at boot time, as they are > similar to pci passthrough devices. > > Signed-off-by: Juergen Gross > Signed-off-by: Vikram Garhwal > --- > hw/i386/xen/xen_platform.c | 8 +++- > 1 fi

Re: [PATCH 1/3] via-ide: Fix legacy mode emulation

2023-10-09 Thread BALATON Zoltan
On Mon, 9 Oct 2023, Mark Cave-Ayland wrote: On 09/10/2023 23:23, BALATON Zoltan wrote: On Mon, 9 Oct 2023, Mark Cave-Ayland wrote: On 08/10/2023 12:08, BALATON Zoltan wrote: On Sun, 8 Oct 2023, Mark Cave-Ayland wrote: On 05/10/2023 23:13, BALATON Zoltan wrote: The initial value for BARs we

Re: [QEMU][PATCH v1 2/7] xen: add pseudo RAM region for grant mappings

2023-10-09 Thread Stefano Stabellini
On Thu, 5 Oct 2023, Vikram Garhwal wrote: > From: Juergen Gross > > Add a memory region which can be used to automatically map granted > memory. It is starting at 0x8000ULL in order to be able to > distinguish it from normal RAM. > > For this reason the xen.ram memory region is expan

Re: [PATCH v17 6/9] gfxstream + rutabaga: add initial support for gfxstream

2023-10-09 Thread Gurchetan Singh
On Mon, Oct 9, 2023 at 12:11 AM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > On Fri, Oct 6, 2023 at 5:09 AM Gurchetan Singh > wrote: > > > > This adds initial support for gfxstream and cross-domain. Both > > features rely on virtio-gpu blob resources and context types, which > > are

Re: [QEMU][PATCH v1 3/7] softmmu: let qemu_map_ram_ptr() use qemu_ram_ptr_length()

2023-10-09 Thread Stefano Stabellini
On Thu, 5 Oct 2023, Vikram Garhwal wrote: > From: Juergen Gross > > qemu_map_ram_ptr() and qemu_ram_ptr_length() share quite some code, so > modify qemu_ram_ptr_length() a little bit and use it for > qemu_map_ram_ptr(), too. > > Signed-off-by: Juergen Gross > Signed-off-by: Vikram Garhwal Thi

Re: [QEMU][PATCH v1 4/7] xen: let xen_ram_addr_from_mapcache() return -1 in case of not found entry

2023-10-09 Thread Stefano Stabellini
On Thu, 5 Oct 2023, Vikram Garhwal wrote: > From: Juergen Gross > > Today xen_ram_addr_from_mapcache() will either abort() or return 0 in > case it can't find a matching entry for a pointer value. Both cases > are bad, so change that to return an invalid address instead. > > Signed-off-by: Juerg

Re: [QEMU][PATCH v1 5/7] memory: add MemoryRegion map and unmap callbacks

2023-10-09 Thread Stefano Stabellini
On Thu, 5 Oct 2023, Vikram Garhwal wrote: > From: Juergen Gross > > In order to support mapping and unmapping guest memory dynamically to > and from qemu during address_space_[un]map() operations add the map() > and unmap() callbacks to MemoryRegionOps. > > Those will be used e.g. for Xen grant

Re: [QEMU][PATCH v1 6/7] xen: add map and unmap callbacks for grant region

2023-10-09 Thread Stefano Stabellini
On Thu, 5 Oct 2023, Vikram Garhwal wrote: > From: Juergen Gross > > Add the callbacks for mapping/unmapping guest memory via grants to the > special grant memory region. > > Signed-off-by: Juergen Gross > Signed-off-by: Vikram Garhwal This looks good. We need to add a check to make sure we do

Re: [QEMU][PATCH v1 7/7] hw: arm: Add grant mapping.

2023-10-09 Thread Stefano Stabellini
On Thu, 5 Oct 2023, Vikram Garhwal wrote: > Enable grant ram mapping support for Xenpvh machine on ARM. > > Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini > --- > hw/arm/xen_arm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/arm/xen_arm.c b/hw/arm/xen_arm.c

Re: [QEMU][PATCH v1 2/7] xen: add pseudo RAM region for grant mappings

2023-10-09 Thread Stefano Stabellini
On Mon, 9 Oct 2023, Stefano Stabellini wrote: > On Thu, 5 Oct 2023, Vikram Garhwal wrote: > > From: Juergen Gross > > > > Add a memory region which can be used to automatically map granted > > memory. It is starting at 0x8000ULL in order to be able to > > distinguish it from normal RA

[PULL 1/2] migration/calc-dirty-rate: millisecond-granularity period

2023-10-09 Thread Hyman Huang
From: Andrei Gudkov This patch allows to measure dirty page rate for sub-second intervals of time. An optional argument is introduced -- calc-time-unit. For example: {"execute": "calc-dirty-rate", "arguments": {"calc-time": 500, "calc-time-unit": "millisecond"} } Millisecond granularity allows

[PULL 0/2] Dirty page rate and dirty page limit 20231010 patches

2023-10-09 Thread Hyman Huang
The following changes since commit 2f3913f4b2ad74baeb5a6f1d36efbd9ecdf1057d: Merge tag 'for_upstream' of https://git.kernel.org/pub/scm/virt/kvm/mst/qemu into staging (2023-10-05 09:01:01 -0400) are available in the Git repository at: https://github.com/newfriday/qemu.git tags/dirtylimit-d

[PULL 2/2] migration/dirtyrate: use QEMU_CLOCK_HOST to report start-time

2023-10-09 Thread Hyman Huang
From: Andrei Gudkov Currently query-dirty-rate uses QEMU_CLOCK_REALTIME as the source for start-time field. This translates to clock_gettime(CLOCK_MONOTONIC), i.e. number of seconds since host boot. This is not very useful. The only reasonable use case of start-time I can imagine is to check whet

Re: qemu direct kernel boot on LoongArch

2023-10-09 Thread maobibo
Thomas, Thanks for reporting this issue. It is the problem of QEMU for LoongArch system, QEMU does not support booting vmlinux with elf format without UEFI bios now. We will add support to boot vmlinux directly on QEMU LoongArch side. Regards Bibo Mao 在 2023/10/10 上午4:13, Thomas Weißschuh 写

Re: [PULL 00/15] NBD patches through 2023-10-05

2023-10-09 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/32] -Wshadow=local patches patches for 2023-10-06

2023-10-09 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/20] Q800 for 8.2 patches

2023-10-09 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v2 00/25] Audio, source reorg, HVF changes for 2023-10-06

2023-10-09 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v2 0/6] vfio queue

2023-10-09 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

[PATCH v2 2/7] virtio-net: Copy header only when necessary

2023-10-09 Thread Akihiko Odaki
It is necessary to copy the header only for byte swapping. Worse, when byte swapping is not needed, the header can be larger than the buffer due to VIRTIO_NET_F_HASH_REPORT, which results in buffer overflow. Copy the header only when byte swapping is needed. Fixes: e22f0603fb ("virtio-net: refere

[PATCH v2 6/7] virtio-net: Do not clear VIRTIO_NET_F_RSS

2023-10-09 Thread Akihiko Odaki
Even if eBPF is not available, virtio-net can perform RSS on the user-space if vhost is disabled although such a configuration results in a warning. If vhost is enabled, the configuration will be rejected when realizing the device. Therefore, VIRTIO_NET_F_RSS should not be cleared even if eBPF is n

[PATCH v2 1/7] tap: Fix virtio-net header buffer size

2023-10-09 Thread Akihiko Odaki
The largest possible virtio-net header is struct virtio_net_hdr_v1_hash. Fixes: fbbdbddec0 ("tap: allow extended virtio header with hash info") Signed-off-by: Akihiko Odaki --- net/tap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/tap.c b/net/tap.c index c6639d9f2

[PATCH v2 4/7] virtio-net: Unify the logic to update NIC state for RSS

2023-10-09 Thread Akihiko Odaki
The code to attach or detach the eBPF program to RSS were duplicated so unify them into one function to save some code. Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 90 ++--- 1 file changed, 36 insertions(+), 54 deletions(-) diff --git a/hw/net/

[PATCH v2 3/7] virtio-net: Disable RSS on reset

2023-10-09 Thread Akihiko Odaki
RSS is disabled by default. Fixes: 590790297c ("virtio-net: implement RSS configuration command") Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 70 +++-- 1 file changed, 36 insertions(+), 34 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/

[PATCH v2 0/7] virtio-net RSS/hash report fixes

2023-10-09 Thread Akihiko Odaki
This series contains fixes and improvements for virtio-net RSS and hash reporting feature. V1 -> V2: Added patch "ebpf: Fix RSS error handling". Akihiko Odaki (7): tap: Fix virtio-net header buffer size virtio-net: Copy header only when necessary virtio-net: Disable RSS on reset virtio-

[PATCH v2 7/7] ebpf: Fix RSS error handling

2023-10-09 Thread Akihiko Odaki
calculate_rss_hash() was using hash value 0 to tell if it calculated a hash, but the hash value may be 0 on a rare occasion. Have a distinct bool value for correctness. Fixes: f3fa412de2 ("ebpf: Added eBPF RSS program.") Signed-off-by: Akihiko Odaki --- tools/ebpf/rss.bpf.c | 20 +++-

[PATCH v2 5/7] virtio-net: Return an error when vhost cannot enable RSS

2023-10-09 Thread Akihiko Odaki
vhost requires eBPF for RSS. Even when eBPF is not available, virtio-net reported RSS availability, and raised a warning only after the guest requested RSS, and the guest could not know that RSS is not available. Check RSS availability during device realization and return an error if RSS is reques

Re: [Virtio-fs] (no subject)

2023-10-09 Thread Yajun Wu
On 10/9/2023 6:28 PM, German Maglione wrote: External email: Use caution opening links or attachments On Sat, Oct 7, 2023 at 4:23 AM Yajun Wu wrote: On 10/6/2023 6:34 PM, Michael S. Tsirkin wrote: External email: Use caution opening links or attachments On Fri, Oct 06, 2023 at 11:47:55A

[PATCH v1 6/6] linux-user/loongarch64: Add LASX sigcontext save/restore

2023-10-09 Thread Song Gao
Signed-off-by: Song Gao --- linux-user/loongarch64/signal.c | 67 ++--- 1 file changed, 62 insertions(+), 5 deletions(-) diff --git a/linux-user/loongarch64/signal.c b/linux-user/loongarch64/signal.c index 4b09e50a5f..e5b7688a2e 100644 --- a/linux-user/loongarch64/sig

[PATCH v1 1/6] target/loongarch: Add env->extctx_flags for user-mode setup extcontext

2023-10-09 Thread Song Gao
extctx_flags only for user-mode, and the default value is EXTCTX_FLAGS_FPU, We only need save/restore fpu context, After a LSX or LASX instruction is execed, the value change to EXTCTX_FLAGS_LSX/LASX, and we need save/restore lsx/lasx context. So if the binary no LSX/LASX instruction We only need

[PATCH v1 3/6] linux-user/loongarch64: Fix setup_extcontext alloc wrong fpu_context size

2023-10-09 Thread Song Gao
See: https://github.com/torvalds/linux/blob/master/arch/loongarch/kernel/signal.c The alloc size is sizeof(struct target_fpu_context). Signed-off-by: Song Gao --- linux-user/loongarch64/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/loongarch64/signal.c

[PATCH v1 4/6] linux-user/loongarch64: setup_sigframe() set 'end' context size 0

2023-10-09 Thread Song Gao
See: https://github.com/torvalds/linux/blob/master/arch/loongarch/kernel/signal.c The kernel setup_sigcontext() set end context size 0. Signed-off-by: Song Gao --- linux-user/loongarch64/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/loongarch64/signal

[PATCH v1 2/6] target/loongarch: Add set_vec_extctx to set LSX/LASX instructions extctx_flags

2023-10-09 Thread Song Gao
Signed-off-by: Song Gao --- target/loongarch/insn_trans/trans_vec.c.inc | 12 target/loongarch/internals.h| 2 ++ 2 files changed, 14 insertions(+) diff --git a/target/loongarch/insn_trans/trans_vec.c.inc b/target/loongarch/insn_trans/trans_vec.c.inc index 98f856bb

[PATCH v1 5/6] linux-user/loongarch64: Add LSX sigcontext save/restore

2023-10-09 Thread Song Gao
Signed-off-by: Song Gao --- linux-user/loongarch64/signal.c | 107 ++-- 1 file changed, 87 insertions(+), 20 deletions(-) diff --git a/linux-user/loongarch64/signal.c b/linux-user/loongarch64/signal.c index 277e9f5757..4b09e50a5f 100644 --- a/linux-user/loongarch64/si

[PATCH v1 0/6] linux-user/loongarch64: Add LSX/LASX sigcontext

2023-10-09 Thread Song Gao
Hi, All. This series adds save/restore sigcontext. We use extctx_flags to choces which sigcontext need save/restore. The extctx_flags default value is EXTCTX_FLAGS_FPU, we need save/restore fpu context. After a LSX/LASX instruction is execed, extctx_flags value change to EXTCTX_FLAGS_LSX/LASX,

Re: [Virtio-fs] (no subject)

2023-10-09 Thread Yajun Wu
On 10/9/2023 5:13 PM, Hanna Czenczek wrote: External email: Use caution opening links or attachments On 09.10.23 11:07, Hanna Czenczek wrote: On 09.10.23 10:21, Hanna Czenczek wrote: On 07.10.23 04:22, Yajun Wu wrote: [...] The main motivation of adding VHOST_USER_SET_STATUS is to let ba

Re: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-09 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 9/10/23 08:09, Philippe Mathieu-Daudé wrote: >> Hi Brian, >> On 6/10/23 00:22, Brian Cain wrote: >>> The typedef `vaddr` is shadowed by `vaddr` identifiers, so we rename the >>> identifiers to avoid shadowing the type name. >> This one surprises me, since we ha

[PATCH] hw/ufs: Fix incorrect register fields

2023-10-09 Thread Jeuk Kim
From: Jeuk Kim This patch fixes invalid ufs register fields. This fixes an issue reported by Bin Meng that caused ufs to fail over riscv. Signed-off-by: Jeuk Kim --- include/block/ufs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/block/ufs.h b/include/block/

Re: [PATCH] hw/loongarch: remove global loaderparams variable

2023-10-09 Thread Philippe Mathieu-Daudé
Hi Thomas, On 9/10/23 23:00, Thomas Weißschuh wrote: Passing the struct around explicitly makes the control-flow more obvious. Signed-off-by: Thomas Weißschuh --- hw/loongarch/virt.c | 50 - 1 file changed, 27 insertions(+), 23 deletions(-) -s

Re: [PATCH v11 08/10] migration: Implement MigrateChannelList to qmp migration flow.

2023-10-09 Thread Het Gala
On 10/9/2023 7:59 PM, Fabiano Rosas wrote: Het Gala writes: On 10/4/2023 8:51 PM, Fabiano Rosas wrote: Het Gala writes: Integrate MigrateChannelList with all transport backends (socket, exec and rdma) for both src and dest migration endpoints for qmp migration. For current series, limit

Re: [PATCH v11 09/10] migration: Implement MigrateChannelList to hmp migration flow.

2023-10-09 Thread Het Gala
On 10/9/2023 8:05 PM, Fabiano Rosas wrote: Het Gala writes: On 10/4/2023 8:55 PM, Fabiano Rosas wrote: Het Gala writes: Integrate MigrateChannelList with all transport backends (socket, exec and rdma) for both src and dest migration endpoints for hmp migration. Suggested-by: Aravind Ret

Re: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-09 Thread Philippe Mathieu-Daudé
On 9/10/23 22:53, Brian Cain wrote: On 9/10/23 08:09, Philippe Mathieu-Daudé wrote: On 6/10/23 00:22, Brian Cain wrote: The typedef `vaddr` is shadowed by `vaddr` identifiers, so we rename the identifiers to avoid shadowing the type name. This one surprises me, since we have other occurences:

Re: [PATCH v2 08/58] i386/tdx: Adjust the supported CPUID based on TDX restrictions

2023-10-09 Thread Xiaoyao Li
On 10/10/2023 9:02 AM, Tina Zhang wrote: Hi, On 8/18/23 17:49, Xiaoyao Li wrote: According to Chapter "CPUID Virtualization" in TDX module spec, CPUID bits of TD can be classified into 6 types: 1 | As configured | configu

Re: [PATCH v12 00/10] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration

2023-10-09 Thread Het Gala
On 10/10/2023 2:34 AM, Fabiano Rosas wrote: Het Gala writes: This is v12 patchset of modified 'migrate' and 'migrate-incoming' QAPI design for upstream review. Would like to thank all the maintainers that actively participated in the v11 patchset discussion and gave insightful suggestions to

Re: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-09 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: [...] > If we have to clean that for -Wshadow=global, I'm tempted to rename > the typedef as 'vaddr_t' and keep the 'vaddr' variable names. POSIX reserves suffix _t, see https://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_02_02 Do we

[PATCH] targer/i386/cpu: Fix CPUID_HT exposure

2023-10-09 Thread Xiaoyao Li
When explicitly booting a multiple vcpus vm with "-cpu +ht", it gets warning of warning: host doesn't support requested feature: CPUID.01H:EDX.ht [bit 28] Make CPUID_HT as supported unconditionally can resolve the warning. However it introduces another issue that it also expose CPUID_HT to gues

[PATCH] virtio-serial-bus: Discard throttled VirtQueueElement when virtio-serial closed

2023-10-09 Thread Sun Feng
With commit d4c19cde("virtio-serial: add missing virtio_detach_element() call"), when virtio serial is throttled and closed by host, port->elem should be discard with virtqueue_push, otherwise virtqueue will not rewind, guest will blocked finally and cannot write anymore data. It can be reproduc

Re: [PATCH RFC V2 03/37] hw/arm/virt: Move setting of common CPU properties in a function

2023-10-09 Thread Shaoqin Huang
On 9/26/23 18:04, Salil Mehta via wrote: Factor out CPU properties code common for {hot,cold}-plugged CPUs. This allows code reuse. Signed-off-by: Salil Mehta --- hw/arm/virt.c | 220 ++ include/hw/arm/virt.h | 4 + 2 files changed, 140 i

<    1   2   3   4