Re: [PATCH v11 02/10] migration: convert migration 'uri' into 'MigrateAddress'

2023-10-09 Thread Fabiano Rosas
Het Gala writes: > On 10/4/2023 11:42 PM, Fabiano Rosas wrote: >> Daniel P. Berrangé writes: >> >>> On Wed, Oct 04, 2023 at 11:43:12AM -0300, Fabiano Rosas wrote: Het Gala writes: > This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri' > string containing migration c

Re: [PATCH V3 04/10] hw/acpi: Init GED framework with cpu hotplug events

2023-10-09 Thread David Hildenbrand
On 09.10.23 16:12, Salil Mehta wrote: From: David Hildenbrand Sent: Monday, October 9, 2023 1:27 PM To: Salil Mehta ; qemu-devel@nongnu.org; qemu- a...@nongnu.org Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron ; lpieral...@kernel.org; peter.mayd...@linaro.org; richard.hender...@

Re: [PULL 0/2] Dirty page rate and dirty page limit 20231009 patches

2023-10-09 Thread Stefan Hajnoczi
> > are available in the Git repository at: > > https://github.com/newfriday/qemu.git > tags/dirtylimit-dirtyrate-pull-request-20231009 > > for you to fetch changes up to 84719f6d0b75448400068adb78d85000e884f0cd: > > migration/dirtyrate: use QEMU_CLOCK_

Re: [PATCH v11 08/10] migration: Implement MigrateChannelList to qmp migration flow.

2023-10-09 Thread Fabiano Rosas
Het Gala writes: > On 10/4/2023 8:51 PM, Fabiano Rosas wrote: >> Het Gala writes: >> >>> Integrate MigrateChannelList with all transport backends >>> (socket, exec and rdma) for both src and dest migration >>> endpoints for qmp migration. >>> >>> For current series, limit the size of MigrateChan

Re: [PATCH v11 09/10] migration: Implement MigrateChannelList to hmp migration flow.

2023-10-09 Thread Fabiano Rosas
Het Gala writes: > On 10/4/2023 8:55 PM, Fabiano Rosas wrote: >> Het Gala writes: >> >>> Integrate MigrateChannelList with all transport backends >>> (socket, exec and rdma) for both src and dest migration >>> endpoints for hmp migration. >>> >>> Suggested-by: Aravind Retnakaran >>> Signed-off-b

[PATCH v12 01/10] migration: New QAPI type 'MigrateAddress'

2023-10-09 Thread Het Gala
This patch introduces well defined MigrateAddress struct and its related child objects. The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri' is of type string. The current implementation follows double encoding scheme for fetching migration parameters like 'uri' and this is not a

[PATCH v12 06/10] migration: New migrate and migrate-incoming argument 'channels'

2023-10-09 Thread Het Gala
MigrateChannelList allows to connect accross multiple interfaces. Add MigrateChannelList struct as argument to migration QAPIs. We plan to include multiple channels in future, to connnect multiple interfaces. Hence, we choose 'MigrateChannelList' as the new argument over 'MigrateChannel' to make m

[PATCH v12 00/10] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration

2023-10-09 Thread Het Gala
This is v12 patchset of modified 'migrate' and 'migrate-incoming' QAPI design for upstream review. Would like to thank all the maintainers that actively participated in the v11 patchset discussion and gave insightful suggestions to improve the patches. Link to previous upstream community patchset

[PATCH v12 04/10] migration: convert rdma backend to accept MigrateAddress

2023-10-09 Thread Het Gala
RDMA based transport backend for 'migrate'/'migrate-incoming' QAPIs accept new wire protocol of MigrateAddress struct. It is achived by parsing 'uri' string and storing migration parameters required for RDMA connection into well defined InetSocketAddress struct. Suggested-by: Aravind Retnakaran

[PATCH v12 10/10] migration: modify test_multifd_tcp_none() to use new QAPI syntax.

2023-10-09 Thread Het Gala
modify multifd tcp common test to incorporate the new QAPI syntax defined. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala --- tests/qtest/migration-test.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-tes

[PATCH v12 08/10] migration: Implement MigrateChannelList to qmp migration flow.

2023-10-09 Thread Het Gala
Integrate MigrateChannelList with all transport backends (socket, exec and rdma) for both src and dest migration endpoints for qmp migration. For current series, limit the size of MigrateChannelList to single element (single interface) as runtime check. Suggested-by: Aravind Retnakaran Signed-of

[PATCH v12 07/10] migration: modify migration_channels_and_uri_compatible() for new QAPI syntax

2023-10-09 Thread Het Gala
migration_channels_and_uri_compatible() check for transport mechanism suitable for multifd migration gets executed when the caller calls old uri syntax. It needs it to be run when using the modern MigrateChannel QAPI syntax too. After URI -> 'MigrateChannel' : migration_channels_and_uri_compatible

[PATCH v12 09/10] migration: Implement MigrateChannelList to hmp migration flow.

2023-10-09 Thread Het Gala
Integrate MigrateChannelList with all transport backends (socket, exec and rdma) for both src and dest migration endpoints for hmp migration. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala --- migration/migration-hmp-cmds.c | 15 +-- migration/migration.c | 5 ++-

[PATCH v12 03/10] migration: convert socket backend to accept MigrateAddress

2023-10-09 Thread Het Gala
Socket transport backend for 'migrate'/'migrate-incoming' QAPIs accept new wire protocol of MigrateAddress struct. It is achived by parsing 'uri' string and storing migration parameters required for socket connection into well defined SocketAddress struct. Suggested-by: Aravind Retnakaran Signed

[PATCH v12 02/10] migration: convert migration 'uri' into 'MigrateAddress'

2023-10-09 Thread Het Gala
This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri' string containing migration connection related information and stores them inside well defined 'MigrateAddress' struct. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala --- migration/exec.c | 1 - migration/exec.h

[PATCH v12 05/10] migration: convert exec backend to accept MigrateAddress.

2023-10-09 Thread Het Gala
Exec transport backend for 'migrate'/'migrate-incoming' QAPIs accept new wire protocol of MigrateAddress struct. It is achived by parsing 'uri' string and storing migration parameters required for exec connection into strList struct. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala ---

Re: [PATCH 2/3] vfio/ap: Remove pointless apdev variable

2023-10-09 Thread Tony Krowiak
Reviewed-by: Tony Krowiak On 10/8/23 22:20, Zhenzhong Duan wrote: No need to double-cast, call VFIO_AP_DEVICE() on DeviceState. No functional changes. Signed-off-by: Zhenzhong Duan --- hw/vfio/ap.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/vfio/ap.c b

Re: [PATCH v4 01/10] hw/fsi: Introduce IBM's Local bus

2023-10-09 Thread Ninad Palsule
Hello Cederic, On 9/9/23 03:25, Cédric Le Goater wrote: On 9/9/23 00:28, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The LBUS is modelled to maintain the qdev bus hierarchy and to take advantage of the object model to automatically gene

Re: [PATCH v11 02/10] migration: convert migration 'uri' into 'MigrateAddress'

2023-10-09 Thread Het Gala
On 10/9/2023 7:43 PM, Fabiano Rosas wrote: Het Gala writes: On 10/4/2023 11:42 PM, Fabiano Rosas wrote: Daniel P. Berrangé writes: On Wed, Oct 04, 2023 at 11:43:12AM -0300, Fabiano Rosas wrote: Het Gala writes: This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri' string c

Re: [PATCH] migration: Use g_autofree to simplify ram_dirty_bitmap_reload()

2023-10-09 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé > --- > Based-on: > --- > migration/ram.c | 15 ++- > 1 file changed, 6 insertions(+), 9 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 982fbbeee1..4cb948cfd0 100644 > --- a/migration/ra

Re: [PATCH v2 1/1] tests/avocado: update firmware to enable OpenBSD test on sbsa-ref

2023-10-09 Thread Philippe Mathieu-Daudé
On 27/9/23 14:00, Marcin Juszkiewicz wrote: Update prebuilt firmware images: - Neoverse V1/N2 cpu support - non-secure EL2 virtual timer - XHCI controller in DSDT With those changes we can now run OpenBSD as part of sbsa-ref tests. Signed-off-by: Marcin Juszkiewicz --- tests/avocado/machine_

RE: [PATCH V3 01/10] accel/kvm: Extract common KVM vCPU {creation,parking} code

2023-10-09 Thread Salil Mehta via
> From: David Hildenbrand > Sent: Monday, October 9, 2023 3:11 PM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; > imamm...@red

Re: [PATCH V3 01/10] accel/kvm: Extract common KVM vCPU {creation,parking} code

2023-10-09 Thread David Hildenbrand
kvm_precreate_vcpu pre-creation is very much specific to ARM right now. I am not sure if it is right to have an API with this name in the code which is common to other architectures. I don't like exposing the concept of "parking" CPUs externally, which is so far handled completely internal

Re: [PATCH v4 10/10] hw/fsi: Update MAINTAINER list

2023-10-09 Thread Ninad Palsule
Hello Cedric, On 9/11/23 07:33, Cédric Le Goater wrote: On 9/9/23 00:28, Ninad Palsule wrote: Added maintainer for IBM FSI model Signed-off-by: Ninad Palsule --- V4:    - Added separate commit for MAINTAINER change. ---   MAINTAINERS | 22 ++   1 file changed, 22 insertions

RE: [PATCH V3 01/10] accel/kvm: Extract common KVM vCPU {creation,parking} code

2023-10-09 Thread Salil Mehta via
> From: David Hildenbrand > Sent: Monday, October 9, 2023 4:21 PM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; > imamm...@red

Re: [PATCH v3] hw/cxl: Add QTG _DSM support for ACPI0017 device

2023-10-09 Thread Jonathan Cameron via
On Sat, 7 Oct 2023 17:17:44 -0400 "Michael S. Tsirkin" wrote: > On Fri, Oct 06, 2023 at 01:09:39PM +0100, Jonathan Cameron wrote: > > On Thu, 5 Oct 2023 12:32:11 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Oct 05, 2023 at 09:11:15AM -0700, Dave Jiang wrote: > > > > > > > > > >

Re: [PATCH] migration: Use g_autofree to simplify ram_dirty_bitmap_reload()

2023-10-09 Thread Philippe Mathieu-Daudé
On 9/10/23 17:07, Fabiano Rosas wrote: Philippe Mathieu-Daudé writes: Signed-off-by: Philippe Mathieu-Daudé --- Based-on: --- migration/ram.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 982fbbeee1..4cb948cfd0

RE: [PATCH V3 04/10] hw/acpi: Init GED framework with cpu hotplug events

2023-10-09 Thread Salil Mehta via
> From: David Hildenbrand > Sent: Monday, October 9, 2023 3:14 PM > > On 09.10.23 16:12, Salil Mehta wrote: > >> From: David Hildenbrand > >> Sent: Monday, October 9, 2023 1:27 PM > >> To: Salil Mehta ; qemu-devel@nongnu.org; > >> qemu-...@nongnu.org > >> Cc: m...@kernel.org; jean-phili...@lina

Re: [PATCH 3/6] hw/display/vga: Clean up global variable shadowing

2023-10-09 Thread Philippe Mathieu-Daudé
On 9/10/23 16:11, Ani Sinha wrote: On 09-Oct-2023, at 3:17 PM, Philippe Mathieu-Daudé wrote: Fix: hw/display/vga.c:2307:29: error: declaration shadows a variable in the global scope [-Werror,-Wshadow] MemoryRegion *address_space_io, bool init_vga_ports)

Re: [PATCH v3] hw/cxl: Add QTG _DSM support for ACPI0017 device

2023-10-09 Thread Jonathan Cameron via
On Fri, 6 Oct 2023 10:50:28 -0700 Dan Williams wrote: > Jonathan Cameron wrote: > [..] > > > > > > > > > > what does "a WORD" mean is unclear - do you match what hardware does > > > > > when you use aml_buffer? pls mention this in commit log, and > > > > > show actual hardware dump for compariso

RE: [PATCH V3 03/10] hw/acpi: Add ACPI CPU hotplug init stub

2023-10-09 Thread Salil Mehta via
> From: David Hildenbrand > Sent: Monday, October 9, 2023 2:55 PM > > On 09.10.23 15:49, Salil Mehta wrote: > >> From: David Hildenbrand > >> Sent: Monday, October 9, 2023 1:23 PM > >> To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > >> a...@nongnu.org > >> Cc: m...@kernel.org; jean-phili...@lin

Re: [PATCH v4] hw/cxl: Add QTG _DSM support for ACPI0017 device

2023-10-09 Thread Jonathan Cameron via
On Fri, 06 Oct 2023 15:15:56 -0700 Dave Jiang wrote: > Add a simple _DSM call support for the ACPI0017 device to return fake QTG > ID values of 0 and 1 in all cases. This for _DSM plumbing testing from the OS. > > Following edited for readability > > Device (CXLM) > { > Name (_HID, "ACPI001

Re: [PATCH v4] hw/cxl: Add QTG _DSM support for ACPI0017 device

2023-10-09 Thread Dave Jiang
On 10/9/23 08:47, Jonathan Cameron wrote: > On Fri, 06 Oct 2023 15:15:56 -0700 > Dave Jiang wrote: > >> Add a simple _DSM call support for the ACPI0017 device to return fake QTG >> ID values of 0 and 1 in all cases. This for _DSM plumbing testing from the >> OS. >> >> Following edited for rea

Re: [PATCH 4/6] hw/acpi/pcihp: Clean up global variable shadowing in acpi_pcihp_init()

2023-10-09 Thread Michael S. Tsirkin
On Mon, Oct 09, 2023 at 11:47:44AM +0200, Philippe Mathieu-Daudé wrote: > Fix: > > hw/acpi/pcihp.c:499:36: error: declaration shadows a variable in the global > scope [-Werror,-Wshadow] >MemoryRegion *address_space_io, > ^ > include

Re: [PATCH 5/6] hw/pci: Clean up global variable shadowing of address_space_io variable

2023-10-09 Thread Michael S. Tsirkin
On Mon, Oct 09, 2023 at 11:47:45AM +0200, Philippe Mathieu-Daudé wrote: > Fix: > > hw/pci/pci.c:504:54: error: declaration shadows a variable in the global > scope [-Werror,-Wshadow] > MemoryRegion *address_space_io, >

Re: [PATCH v2] hw/virtio/virtio-gpu: Fix compiler warning when compiling with -Wshadow

2023-10-09 Thread Michael S. Tsirkin
On Mon, Oct 09, 2023 at 10:45:59AM +0200, Thomas Huth wrote: > Avoid using trivial variable names in macros, otherwise we get > the following compiler warning when compiling with -Wshadow=local: > > In file included from ../../qemu/hw/display/virtio-gpu-virgl.c:19: > ../../home/thuth/devel/qemu/hw

[PATCH 02/25] tests/avocado: remove flaky test marking for test_sbsaref_edk2_firmware

2023-10-09 Thread Alex Bennée
After testing locally I decided to revert a5754847e0 (tests/avocado: Disable the test_sbsaref_edk2_firmware by default) as the test seems pretty stable: env QEMU_TEST_FLAKY_TESTS=1 retry.py -n 50 -c -- \ ./tests/venv/bin/avocado run \ ./tests/avocado/machine_aarch64_sbsaref.py:Aarch6

[PATCH 05/25] tests/docker: make docker engine choice entirely configure driven

2023-10-09 Thread Alex Bennée
Since 0b1a649047 (tests/docker: use direct RUNC call to build containers) we ended up with the potential for the remaining docker.py script calls to deviate from the direct RUNC calls. Fix this by dropping the use of ENGINE in the makefile and rely entirely on what we detect at configure time. We

[PATCH 00/25] October maintainer omnibus pre-PR (tests, gdbstub, plugins)

2023-10-09 Thread Alex Bennée
Hi, This wraps up my current testing, gdbstub and plugin trees in an attempt to do my part to reduce the qemu-devel fire hose. It is pretty much the same as the September tree except: - dropped RFC patches - dropped CRIS deprecation patches - dropped makefile dependency tweaks - tweaked R

[PATCH 23/25] contrib/plugins: fix coverity warning in cache

2023-10-09 Thread Alex Bennée
Coverity complains that appends_stats_line can be fed a 0 leading to the undefined behaviour of a divide by 0. Fixes: CID 1519044 Fixes: CID 1519047 Signed-off-by: Alex Bennée --- contrib/plugins/cache.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/cont

[PATCH 04/25] gitlab: shuffle some targets and reduce avocado noise

2023-10-09 Thread Alex Bennée
We move a couple of targets out of the avocado runs because there are no tests to run. Tricore already has some coverage. The cris target only really has check-tcg tests but its getting harder to find anything that packages the compiler. To reduce the noise of CANCEL messages we also set AVOCADO_

[PATCH 09/25] gdbstub: Fix target.xml response

2023-10-09 Thread Alex Bennée
From: Akihiko Odaki It was failing to return target.xml after the first request. Fixes: 56e534bd11 ("gdbstub: refactor get_feature_xml") Signed-off-by: Akihiko Odaki Message-Id: <20230912224107.29669-3-akihiko.od...@daynix.com> Signed-off-by: Alex Bennée --- gdbstub/gdbstub.c | 2 +- 1 file c

[PATCH 12/25] gdbstub: Introduce GDBFeature structure

2023-10-09 Thread Alex Bennée
From: Akihiko Odaki Before this change, the information from a XML file was stored in an array that is not descriptive. Introduce a dedicated structure type to make it easier to understand and to extend with more fields. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Reviewed

[PATCH 10/25] plugins: Check if vCPU is realized

2023-10-09 Thread Alex Bennée
From: Akihiko Odaki The created member of CPUState tells if the vCPU thread is started, and will be always false for the user space emulation that manages threads independently. Use the realized member of DeviceState, which is valid for both of the system and user space emulation. Fixes: 54cb65d

[PATCH 14/25] hw/core/cpu: Return static value with gdb_arch_name()

2023-10-09 Thread Alex Bennée
From: Akihiko Odaki All implementations of gdb_arch_name() returns dynamic duplicates of static strings. It's also unlikely that there will be an implementation of gdb_arch_name() that returns a truly dynamic value due to the nature of the function returning a well-known identifiers. Qualify the

[PATCH 08/25] gdbstub: Fix target_xml initialization

2023-10-09 Thread Alex Bennée
From: Akihiko Odaki target_xml is no longer a fixed-length array but a pointer to a variable-length memory. Fixes: 56e534bd11 ("gdbstub: refactor get_feature_xml") Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230912224107.29669-2-akihiko.od...@daynix.com> Sig

[PATCH 11/25] contrib/plugins: Use GRWLock in execlog

2023-10-09 Thread Alex Bennée
From: Akihiko Odaki execlog had the following comment: > As we could have multiple threads trying to do this we need to > serialise the expansion under a lock. Threads accessing already > created entries can continue without issue even if the ptr array > gets reallocated during resize. However,

[PATCH 06/25] configure: allow user to override docker engine

2023-10-09 Thread Alex Bennée
If you have both engines installed but one is broken you are stuck with the automagic. Allow the user to override the engine for this case. Signed-off-by: Alex Bennée --- configure | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 707132a3ae.

[PATCH 01/25] tests/avocado: update firmware to enable OpenBSD test on sbsa-ref

2023-10-09 Thread Alex Bennée
From: Marcin Juszkiewicz Update prebuilt firmware images: - Neoverse V1/N2 cpu support - non-secure EL2 virtual timer - XHCI controller in DSDT With those changes we can now run OpenBSD as part of sbsa-ref tests. Signed-off-by: Marcin Juszkiewicz Message-Id: <20230927120050.210187-2-marcin.jus

[PATCH 13/25] target/arm: Move the reference to arm-core.xml

2023-10-09 Thread Alex Bennée
From: Akihiko Odaki Some subclasses overwrite gdb_core_xml_file member but others don't. Always initialize the member in the subclasses for consistency. This especially helps for AArch64; in a following change, the file specified by gdb_core_xml_file is always looked up even if it's going to be

[PATCH 15/25] gdbstub: Use g_markup_printf_escaped()

2023-10-09 Thread Alex Bennée
From: Akihiko Odaki g_markup_printf_escaped() is a safer alternative to simple printf() as it automatically escapes values. Signed-off-by: Akihiko Odaki Message-Id: <20230912224107.29669-9-akihiko.od...@daynix.com> Signed-off-by: Alex Bennée --- gdbstub/gdbstub.c | 36 +---

[PATCH 25/25] contrib/plugins: fix coverity warning in hotblocks

2023-10-09 Thread Alex Bennée
Coverity complains that we have an unbalance use of mutex leading to potential deadlocks. Fixes: CID 1519048 Signed-off-by: Alex Bennée --- contrib/plugins/hotblocks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c in

[PATCH 22/25] plugins: Set final instruction count in plugin_gen_tb_end

2023-10-09 Thread Alex Bennée
From: Matt Borgerson Translation logic may partially decode an instruction, then abort and remove the instruction from the TB. This can happen for example when an instruction spans two pages. In this case, plugins may get an incorrect result when calling qemu_plugin_tb_n_insns to query for the nu

[PATCH 03/25] tests/lcitool: add swtpm to the package list

2023-10-09 Thread Alex Bennée
We need this to test some TPM stuff. Message-Id: <20230925144854.1872513-3-alex.ben...@linaro.org> Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé --- .gitlab-ci.d/cirrus/macos-12.vars| 2 +- tests/docker/dockerfiles/alpine.docker | 1 + tests/docker

[PATCH 24/25] contrib/plugins: fix coverity warning in lockstep

2023-10-09 Thread Alex Bennée
Coverity complains that e don't check for a truncation when copying in the path. Bail if we can't copy the whole path into sockaddr. Fixes: CID 1519045 Fixes: CID 1519046 Signed-off-by: Alex Bennée --- contrib/plugins/lockstep.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-

[PATCH 07/25] configure: remove gcc version suffixes

2023-10-09 Thread Alex Bennée
The modern packaging of cross GCC's doesn't need the explicit version number at the end. Signed-off-by: Alex Bennée --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index ebad155d9e..e83872571d 100755 --- a/configure +++ b/configure @@ -

[PATCH 17/25] target/ppc: Remove references to gdb_has_xml

2023-10-09 Thread Alex Bennée
From: Akihiko Odaki GDB has XML support since 6.7 which was released in 2007. It's time to remove support for old GDB versions without XML support. Signed-off-by: Akihiko Odaki Message-Id: <20230912224107.29669-11-akihiko.od...@daynix.com> Signed-off-by: Alex Bennée --- target/ppc/gdbstub.c |

[PATCH 19/25] gdbstub: Replace gdb_regs with an array

2023-10-09 Thread Alex Bennée
From: Akihiko Odaki An array is a more appropriate data structure than a list for gdb_regs since it is initialized only with append operation and read-only after initialization. Signed-off-by: Akihiko Odaki Message-Id: <20230912224107.29669-13-akihiko.od...@daynix.com> [AJB: fixed a checkpatch

[PATCH 20/25] accel/tcg: Add plugin_enabled to DisasContextBase

2023-10-09 Thread Alex Bennée
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20230824181233.1568795-2-richard.hender...@linaro.org> Signed-off-by: Alex Bennée --- include/exec/translator.h | 2 ++ accel/tcg/translator.c| 1 + 2 files changed, 3 insertions(+) diff --git a/include/exec/translator.

[PATCH 16/25] target/arm: Remove references to gdb_has_xml

2023-10-09 Thread Alex Bennée
From: Akihiko Odaki GDB has XML support since 6.7 which was released in 2007. It's time to remove support for old GDB versions without XML support. Signed-off-by: Akihiko Odaki Acked-by: Alex Bennée Message-Id: <20230912224107.29669-10-akihiko.od...@daynix.com> Signed-off-by: Alex Bennée ---

[PATCH 21/25] target/sh4: Disable decode_gusa when plugins enabled

2023-10-09 Thread Alex Bennée
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20230824181233.1568795-3-richard.hender...@linaro.org> [AJB: fixed s/cpu_env/tcg_env/ during re-base] Signed-off-by: Alex Bennée --- target/sh4/translate.c | 41 + 1 file changed, 29 i

[PATCH 18/25] gdbstub: Remove gdb_has_xml variable

2023-10-09 Thread Alex Bennée
From: Akihiko Odaki GDB has XML support since 6.7 which was released in 2007. It's time to remove support for old GDB versions without XML support. Signed-off-by: Akihiko Odaki Message-Id: <20230912224107.29669-12-akihiko.od...@daynix.com> Signed-off-by: Alex Bennée --- gdbstub/internals.h

[PATCH v2 2/2] target/s390x/kvm: Simplify the GPRs, ACRs, CRs and prefix synchronization code

2023-10-09 Thread Thomas Huth
KVM_SYNC_GPRS, KVM_SYNC_ACRS, KVM_SYNC_CRS and KVM_SYNC_PREFIX are available since kernel 3.10. Since we already require at least kernel 3.15 in the s390x KVM code, we can also assume that the KVM_CAP_SYNC_REGS sync code is always possible for these registers, and remove the related checks and fall

[PATCH] Revert "configure: Add workaround for ccache and clang"

2023-10-09 Thread Yonggang Luo
This reverts commit fd0e60530f10078f488fa3e9591cc7db5732989c. According to https://peter.eisentraut.org/blog/2014/12/01/ccache-and-clang-part-3 it's already fixed in new version of ccache According to https://ccache.dev/manual/4.8.html#config_run_second_cpp CCACHE_CPP2 are default to true for ne

[PATCH v2 0/2] target/s390x/kvm: Simplify the synchronization code

2023-10-09 Thread Thomas Huth
KVM_SYNC_GPRS, KVM_SYNC_ACRS, KVM_SYNC_CRS and KVM_SYNC_PREFIX are available since kernel 3.10. Since we already require at least kernel 3.15 in the s390x KVM code, we can also assume that the KVM_CAP_SYNC_REGS sync code is always possible for these registers, and remove the related checks and fall

[PATCH v2 1/2] target/s390x/kvm: Turn KVM_CAP_SYNC_REGS into a hard requirement

2023-10-09 Thread Thomas Huth
Since we already require at least kernel 3.15 in the s390x KVM code, we can assume that the KVM_CAP_SYNC_REGS capability is always there. Thus turn this into a hard requirement now. Signed-off-by: Thomas Huth --- target/s390x/kvm/kvm.c | 20 ++-- 1 file changed, 14 insertions(+),

[PATCH 0/3] hw/mips: Cleanup in preparation of heterogenous prototype

2023-10-09 Thread Philippe Mathieu-Daudé
Prepare few MIPS hardware to be integrated in a heterogeneous machine: - Restrict MIPS-specific HW declaration to target/mips/ - Replace MIPSCPU by ArchCPU in common HW Philippe Mathieu-Daudé (3): hw/mips: Merge 'hw/mips/cpudevs.h' with 'target/mips/cpu.h' hw/misc/mips_itu: Declare itc_reconfi

[PATCH 1/3] hw/mips: Merge 'hw/mips/cpudevs.h' with 'target/mips/cpu.h'

2023-10-09 Thread Philippe Mathieu-Daudé
"hw/mips/cpudevs.h" contains declarations which are specific to the MIPS architecture; it doesn't make sense for these to be called from a non-MIPS architecture. Move the declarations to "target/mips/cpu.h". Signed-off-by: Philippe Mathieu-Daudé --- include/hw/mips/cpudevs.h | 14 -

[PATCH 3/3] hw/misc/mips_itu: Make MIPSITUState target agnostic

2023-10-09 Thread Philippe Mathieu-Daudé
When prototyping a heterogenous machine including the ITU, we get: include/hw/misc/mips_itu.h:76:5: error: unknown type name 'MIPSCPU' MIPSCPU *cpu0; ^ MIPSCPU is declared in the target specific "cpu.h" header, but we don't want to include it, because "cpu.h" is target specific and

[PATCH 2/3] hw/misc/mips_itu: Declare itc_reconfigure() in 'hw/misc/mips_itu.h'

2023-10-09 Thread Philippe Mathieu-Daudé
We already provide "hw/misc/mips_itu.h" to declare prototype related to MIPSITUState. Move itc_reconfigure() declaration there. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/mips_itu.h | 2 ++ target/mips/cpu.h | 3 --- target/mips/tcg/sysemu/cp0_helper.c |

Re: [PATCH v4 02/10] hw/fsi: Introduce IBM's scratchpad

2023-10-09 Thread Ninad Palsule
Hello Cedric, On 9/9/23 03:37, Cédric Le Goater wrote: On 9/9/23 00:28, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The LBUS device is embeded inside the scratchpad. The scratchpad embedded Fixed provides a non-functional registe

Re: [PATCH v3 10/10] tests/migration-test: Add a test for postcopy hangs during RECOVER

2023-10-09 Thread Fabiano Rosas
Fabiano Rosas writes: > Peter Xu writes: > >> On Thu, Oct 05, 2023 at 06:10:20PM -0300, Fabiano Rosas wrote: >>> Peter Xu writes: >>> >>> > On Thu, Oct 05, 2023 at 10:37:56AM -0300, Fabiano Rosas wrote: >>> >> >> +/* >>> >> >> + * Make sure both QEMU instances will go into RECOVER stag

Re: [PATCH v4 02/10] hw/fsi: Introduce IBM's scratchpad

2023-10-09 Thread Ninad Palsule
Hello Cedric, On 9/11/23 07:19, Cédric Le Goater wrote: On 9/9/23 00:28, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The LBUS device is embeded inside the scratchpad. The scratchpad provides a non-functional registers. There is a 1-1 re

Re: [PATCH 2/3] target/riscv: Support discontinuous PMU counters

2023-10-09 Thread Atish Kumar Patra
On Sun, Oct 8, 2023 at 5:58 PM Alistair Francis wrote: > > On Wed, Oct 4, 2023 at 7:36 PM Rob Bradford wrote: > > > > Hi Atish, > > > > On Tue, 2023-10-03 at 13:25 -0700, Atish Kumar Patra wrote: > > > On Tue, Oct 3, 2023 at 5:51 AM Rob Bradford > > > wrote: > > > > > > > > There is no requireme

[PATCH] ppc/pnv: Add an I2C master controller model

2023-10-09 Thread Glenn Miles
From: Cédric Le Goater Not supported : . 10 bit addresses . multimaster . slave Signed-off-by: Cédric Le Goater Signed-off-by: Glenn Miles [milesg: fixed formatting warning] --- hw/ppc/meson.build | 1 + hw/ppc/pnv.c | 26 ++ hw/ppc/pnv_i2c.c | 678 +

[PATCH v2 5/6] migration: Fix analyze-migration read operation signedness

2023-10-09 Thread Fabiano Rosas
The migration code uses unsigned values for 16, 32 and 64-bit operations. Fix the script to do the same. This was causing an issue when parsing the migration stream generated on the ppc64 target because one of instance_ids was larger than the 32bit signed maximum: Traceback (most recent call last

[PATCH v2 4/6] migration: Fix analyze-migration.py when ignore-shared is used

2023-10-09 Thread Fabiano Rosas
The script is currently broken when the x-ignore-shared capability is used: Traceback (most recent call last): File "./scripts/analyze-migration.py", line 656, in dump.read(dump_memory = args.memory) File "./scripts/analyze-migration.py", line 593, in read section.read() File "./scr

[PATCH v2 6/6] tests/qtest/migration: Add a test for the analyze-migration script

2023-10-09 Thread Fabiano Rosas
Add a smoke test that migrates to a file and gives it to the script. It should catch the most annoying errors such as changes in the ram flags. After code has been merged it becomes way harder to figure out what is causing the script to fail, the person making the change is the most likely to know

[PATCH v2 2/6] migration: Fix analyze-migration.py 'configuration' parsing

2023-10-09 Thread Fabiano Rosas
The 'configuration' state subsections are currently not being parsed and the script fails when analyzing an aarch64 stream: Traceback (most recent call last): File "./scripts/analyze-migration.py", line 625, in dump.read(dump_memory = args.memory) File "./scripts/analyze-migration.py", li

[PATCH v2 1/6] migration: Add the configuration vmstate to the json writer

2023-10-09 Thread Fabiano Rosas
From: Nikolay Borisov Make the migration json writer part of MigrationState struct, allowing the 'configuration' object be serialized to json. This will facilitate the parsing of the 'configuration' object in the next patch that fixes analyze-migration.py for arm. Signed-off-by: Nikolay Borisov

[PATCH v2 3/6] migration: Add capability parsing to analyze-migration.py

2023-10-09 Thread Fabiano Rosas
The script is broken when the configuration/capabilities section is present. Add support for parsing the capabilities so we can fix it in the next patch. Signed-off-by: Fabiano Rosas --- scripts/analyze-migration.py | 38 1 file changed, 38 insertions(+) dif

[PATCH v2 0/6] scripts/migration: Fix analyze-migration.py and add a test

2023-10-09 Thread Fabiano Rosas
was: [PATCH] qtest/migration: Add a test for the analyze-migration script https://lore.kernel.org/r/20230927214756.14117-1-faro...@suse.de The analyze-migration.py script should be kept in sync with the code that generates the migration stream. The addition/removal of sections and flags from the s

Re: [PATCH 3/3] vfio/ccw: Remove redundant definition of TYPE_VFIO_CCW

2023-10-09 Thread Eric Farman
On Mon, 2023-10-09 at 10:20 +0800, Zhenzhong Duan wrote: > No functional changes. > > Signed-off-by: Zhenzhong Duan I see Cedric has already queued this, but FWIW: Reviewed-by: Eric Farman > --- >  include/hw/s390x/vfio-ccw.h | 2 -- >  1 file changed, 2 deletions(-) > > diff --git a/include/

RE: [PATCH v2 3/3] target/hexagon: avoid shadowing globals

2023-10-09 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Sunday, October 8, 2023 7:50 AM > To: ltaylorsimp...@gmail.com; qemu-devel@nongnu.org > Cc: arm...@redhat.com; richard.hender...@linaro.org; phi...@linaro.org; > peter.mayd...@linaro.org; Matheus Bernardino (QUIC) > ; stefa...@redhat.com;

Re: [PATCH] docs/about: Deprecate the 'next-cube' m68k machine

2023-10-09 Thread Mark Cave-Ayland
On 07/10/2023 08:23, Thomas Huth wrote: (added Natalia who was the GSoC mentor for the NeXT cube work) The machine is incomplete, and unfortunately the hoped-for improvements never happened. So it's maybe best if we mark this machine as deprecated and finally remove it again in case it gets int

[PATCH v2 1/3] via-ide: Fix legacy mode emulation

2023-10-09 Thread BALATON Zoltan
The initial value for BARs were set in reset method for emulating legacy mode at start but this does not work because PCI code resets BARs after calling device reset method. Remove this ineffective default to avoid confusion. Instead move setting the BARs to a callback on writing the PCI config re

[PATCH v2 3/3] hw/ppc: Add emulation of AmigaOne XE board

2023-10-09 Thread BALATON Zoltan
The AmigaOne is a rebranded MAI Teron board that uses U-Boot firmware with patches to support AmigaOS and is very similar to pegasos2 so can be easily emulated sharing most code with pegasos2. The reason to emulate it is that AmigaOS comes in different versions for AmigaOne and PegasosII which only

[PATCH v2 0/3] Add emulation of AmigaOne XE board

2023-10-09 Thread BALATON Zoltan
Changes in v2: - Update comment and commit message in patch 1 (Mark) - Fix irq mapping in patch 2 (Volker) Regards, BALATON Zoltan BALATON Zoltan (3): via-ide: Fix legacy mode emulation hw/pci-host: Add emulation of Mai Logic Articia S hw/ppc: Add emulation of AmigaOne XE board MAINTAINER

[PATCH v2 2/3] hw/pci-host: Add emulation of Mai Logic Articia S

2023-10-09 Thread BALATON Zoltan
The Articia S is a generic chipset supporting several different CPUs that were among others used on some PPC boards. This is a minimal emulation of the parts needed for emulating the AmigaOne board. Signed-off-by: BALATON Zoltan --- hw/pci-host/Kconfig | 5 + hw/pci-host/articia.c

[PATCH V4 00/10] Add architecture agnostic code to support vCPU Hotplug

2023-10-09 Thread Salil Mehta via
Virtual CPU hotplug support is being added across various architectures[1][3]. This series adds various code bits common across all architectures: 1. vCPU creation and Parking code refactor [Patch 1] 2. Update ACPI GED framework to support vCPU Hotplug [Patch 4,6,7] 3. ACPI CPUs AML code change [P

[PATCH V4 04/10] hw/acpi: Init GED framework with CPU hotplug events

2023-10-09 Thread Salil Mehta via
ACPI GED(as described in the ACPI 6.2 spec) can be used to generate ACPI events when OSPM/guest receives an interrupt listed in the _CRS object of GED. OSPM then maps or demultiplexes the event by evaluating _EVT method. This change adds the support of CPU hotplug event initialization in the exist

[PATCH V4 01/10] accel/kvm: Extract common KVM vCPU {creation, parking} code

2023-10-09 Thread Salil Mehta via
KVM vCPU creation is done once during the initialization of the VM when Qemu thread is spawned. This is common to all the architectures. Hot-unplug of vCPU results in destruction of the vCPU object in QOM but the corresponding KVM vCPU object in the Host KVM is not destroyed and its representative

[PATCH V4 03/10] hw/acpi: Add ACPI CPU hotplug init stub

2023-10-09 Thread Salil Mehta via
ACPI CPU hotplug related initialization should only happen if ACPI_CPU_HOTPLUG support has been enabled for particular architecture. Add cpu_hotplug_hw_init() stub to avoid compilation break. Signed-off-by: Salil Mehta Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan --- hw/acpi/acpi-cpu-

[PATCH V4 02/10] hw/acpi: Move CPU ctrl-dev MMIO region len macro to common header file

2023-10-09 Thread Salil Mehta via
CPU ctrl-dev MMIO region length could be used in ACPI GED and various other architecture specific places. Move ACPI_CPU_HOTPLUG_REG_LEN macro to more appropriate common header file. Signed-off-by: Salil Mehta Reviewed-by: Alex Bennée Reviewed-by: Jonathan Cameron Reviewed-by: Gavin Shan Review

[PATCH V4 05/10] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

2023-10-09 Thread Salil Mehta via
CPUs Control device(\\_SB.PCI0) register interface for the x86 arch is based on PCI and is IO port based and hence existing CPUs AML code assumes _CRS objects would evaluate to a system resource which describes IO Port address. But on ARM arch CPUs control device(\\_SB.PRES) register interface is m

[PATCH V4 06/10] hw/acpi: Update GED _EVT method AML with CPU scan

2023-10-09 Thread Salil Mehta via
OSPM evaluates _EVT method to map the event. The CPU hotplug event eventually results in start of the CPU scan. Scan figures out the CPU and the kind of event(plug/unplug) and notifies it back to the guest. Update the GED AML _EVT method with the call to \\_SB.CPUS.CSCN Also, macro CPU_SCAN_METHOD

[PATCH V4 07/10] hw/acpi: Update ACPI GED framework to support vCPU Hotplug

2023-10-09 Thread Salil Mehta via
ACPI GED shall be used to convey to the guest kernel about any CPU hot-(un)plug events. Therefore, existing ACPI GED framework inside QEMU needs to be enhanced to support CPU hotplug state and events. Co-developed-by: Keqian Zhu Signed-off-by: Keqian Zhu Signed-off-by: Salil Mehta Reviewed-by:

[PATCH V4 08/10] physmem: Add helper function to destroy CPU AddressSpace

2023-10-09 Thread Salil Mehta via
Virtual CPU Hot-unplug leads to unrealization of a CPU object. This also involves destruction of the CPU AddressSpace. Add common function to help destroy the CPU AddressSpace. Signed-off-by: Salil Mehta --- include/exec/cpu-common.h | 8 include/hw/core/cpu.h | 1 + softmmu/physm

[PATCH V4 09/10] gdbstub: Add helper function to unregister GDB register space

2023-10-09 Thread Salil Mehta via
Add common function to help unregister the GDB Register Space. This shall be done in context to the CPU unrealization. Signed-off-by: Salil Mehta --- gdbstub/gdbstub.c | 15 +++ include/exec/gdbstub.h | 5 + 2 files changed, 20 insertions(+) diff --git a/gdbstub/gdbstub.c

[PATCH V4 10/10] target/arm/kvm: Write CPU state back to KVM on reset

2023-10-09 Thread Salil Mehta via
From: Jean-Philippe Brucker When a KVM vCPU is reset following a PSCI CPU_ON call, its power state is not synchronized with KVM at the moment. Because the vCPU is not marked dirty, we miss the call to kvm_arch_put_registers() that writes to KVM's MP_STATE. Force mp_state synchronization. Signed-

<    1   2   3   4   >