On 05/10/2023 18.14, Philippe Mathieu-Daudé wrote:
On 4/10/23 01:01, Richard Henderson wrote:
On 10/3/23 06:07, Philippe Mathieu-Daudé wrote:
+++ b/linux-user/s390x/vdso.ld
@@ -0,0 +1,69 @@
+/*
+ * Linker script for linux x86-64 replacement vdso.
Should that be s390x instead of x86-64 ?
+ *
QEMU has validations to make sure that a VM is not started with more memory
(static and hotpluggable memory) than what the guest processor can address
directly with its addressing bits. This change adds a test to make sure QEMU
fails to start with a specific error message when an attempt is made to
On 05.10.23 19:15, Michael S. Tsirkin wrote:
On Thu, Oct 05, 2023 at 01:08:52PM -0400, Stefan Hajnoczi wrote:
On Wed, Oct 04, 2023 at 02:58:57PM +0200, Hanna Czenczek wrote:
There is no clearly defined purpose for the virtio status byte in
vhost-user: For resetting, we already have RESET_DEVICE
On 04/10/2023 15.53, Daniel P. Berrangé wrote:
On Wed, Oct 04, 2023 at 03:49:31PM +0200, Paolo Bonzini wrote:
On Wed, Oct 4, 2023 at 3:41 PM Claudio Fontana wrote:
On 10/4/23 14:37, Thomas Huth wrote:
On 04/10/2023 14.33, Daniel P. Berrangé wrote:
Am I mis-understanding what you mean by 'fi
As we've seen in the past, it's useful for deprecating old machine
types to finally be able to get of legacy code or do other clean-ups
(see e.g. commit ea985d235b868047 that was used to drop the PCI code in
the 128k bios binaries to free some precious space in those binaries).
So let's continue d
On 05.10.23 19:38, Stefan Hajnoczi wrote:
On Wed, Oct 04, 2023 at 02:58:58PM +0200, Hanna Czenczek wrote:
GET_VRING_BASE does not mention that it stops the respective ring. Fix
that.
Furthermore, it is not fully clear what the "base offset" these
commands' documentation refers to is; an offset
On Wed, Oct 4, 2023 at 4:54 PM Jag Raman wrote:
>
>
> > On Sep 20, 2023, at 4:06 AM, Mattias Nissler
> wrote:
> >
> > Wire up support for DMA for the case where the vfio-user client does not
> > provide mmap()-able file descriptors, but DMA requests must be performed
> > via the VFIO-user protoc
On 05/10/2023 18.01, Nina Schoetterl-Glausch wrote:
From: Pierre Morel
On interception of STSI(15.1.x) the System Information Block
(SYSIB) is built from the list of pre-ordered topology entries.
Signed-off-by: Pierre Morel
Reviewed-by: Nina Schoetterl-Glausch
Co-developed-by: Nina Schoetter
On 10/6/23 08:47, Philippe Mathieu-Daudé wrote:
QEMU consumes some device tree blobs, so these have been committed
to the tree in as firmware, along with the device tree source used
to generate them. We know the blobs are "good enough" to have QEMU
boot a system, so we don't really maintain and r
Hi Nicolas,
On 6/10/23 09:41, Nicolas Eder wrote:
SUMMARY
===
This patch-set introduces the first version of the mcdstub.
The mcdstub is a debug interface, which enables debugging QEMU
using the MCD (Multi-Core Debug) API.
The mcdstub uses TCP to communicate with the host debug software. Ho
On 6/10/23 09:52, Thomas Huth wrote:
As we've seen in the past, it's useful for deprecating old machine
types to finally be able to get of legacy code or do other clean-ups
(see e.g. commit ea985d235b868047 that was used to drop the PCI code in
the 128k bios binaries to free some precious space i
On 6/10/23 10:13, Cédric Le Goater wrote:
On 10/6/23 08:47, Philippe Mathieu-Daudé wrote:
QEMU consumes some device tree blobs, so these have been committed
to the tree in as firmware, along with the device tree source used
to generate them. We know the blobs are "good enough" to have QEMU
boot
On 6/10/23 08:47, Philippe Mathieu-Daudé wrote:
QEMU consumes some device tree blobs, so these have been committed
to the tree in as firmware, along with the device tree source used
to generate them. We know the blobs are "good enough" to have QEMU
boot a system, so we don't really maintain and r
On 05/10/2023 18.01, Nina Schoetterl-Glausch wrote:
From: Pierre Morel
The modification of the CPU attributes are done through a monitor
command.
It allows to move the core inside the topology tree to optimize
the cache usage in the case the host's hypervisor previously
moved the CPU.
The sam
On 10/6/23 10:18, Philippe Mathieu-Daudé wrote:
On 6/10/23 10:13, Cédric Le Goater wrote:
On 10/6/23 08:47, Philippe Mathieu-Daudé wrote:
QEMU consumes some device tree blobs, so these have been committed
to the tree in as firmware, along with the device tree source used
to generate them. We kn
On 6/10/23 10:32, Cédric Le Goater wrote:
On 10/6/23 10:18, Philippe Mathieu-Daudé wrote:
On 6/10/23 10:13, Cédric Le Goater wrote:
On 10/6/23 08:47, Philippe Mathieu-Daudé wrote:
QEMU consumes some device tree blobs, so these have been committed
to the tree in as firmware, along with the devi
On 02/10/2023 16:12, Cédric Le Goater wrote:
> Hello Joao,
>
> On 6/22/23 23:48, Joao Martins wrote:
>> From: Yi Liu
>>
>> Add a pci_setup_iommu_ops() that uses a newly added structure
>> (PCIIOMMUOps) instead of using PCIIOMMUFunc. The old pci_setup_iommu()
>> that uses PCIIOMMUFunc is still kep
On 02/10/2023 16:22, Cédric Le Goater wrote:
> On 6/22/23 23:48, Joao Martins wrote:
>> From: Yi Liu
>>
>> Refactor pci_device_iommu_address_space() and move the
>> code that fetches the device bus and iommu bus into its
>> own private helper pci_device_get_iommu_bus_devfn().
>>
>> This is in p
On 06/10/2023 09:39, Joao Martins wrote:
>
>
> On 02/10/2023 16:22, Cédric Le Goater wrote:
>> On 6/22/23 23:48, Joao Martins wrote:
>>> From: Yi Liu
>>>
>>> Refactor pci_device_iommu_address_space() and move the
>>> code that fetches the device bus and iommu bus into its
>>> own private help
On 02/10/2023 16:23, Cédric Le Goater wrote:
> On 6/22/23 23:48, Joao Martins wrote:
>> Implement IOMMU MR get_attr() method and use the dma_translation
>> property to report the IOMMU_ATTR_DMA_TRANSLATION attribute.
>> Additionally add the necessary get_iommu_attr into the PCIIOMMUOps to
>> sup
On 02/10/2023 16:42, Cédric Le Goater wrote:
> On 7/10/23 15:44, Joao Martins wrote:
>>
>>
>> On 09/07/2023 16:17, Avihai Horon wrote:
>>>
>>> On 23/06/2023 0:48, Joao Martins wrote:
External email: Use caution opening links or attachments
From: Avihai Horon
Implem
On Fri, Oct 06, 2023 at 09:48:14AM +0200, Hanna Czenczek wrote:
> On 05.10.23 19:15, Michael S. Tsirkin wrote:
> > On Thu, Oct 05, 2023 at 01:08:52PM -0400, Stefan Hajnoczi wrote:
> > > On Wed, Oct 04, 2023 at 02:58:57PM +0200, Hanna Czenczek wrote:
> > > > There is no clearly defined purpose for t
Hi Joao,
On 6/22/23 23:48, Joao Martins wrote:
> From: Yi Liu
>
> Add a pci_setup_iommu_ops() that uses a newly added structure
> (PCIIOMMUOps) instead of using PCIIOMMUFunc. The old pci_setup_iommu()
> that uses PCIIOMMUFunc is still kept for other IOMMUs to get an
> an address space for a PCI
On Fri, Oct 06, 2023 at 09:53:53AM +0200, Hanna Czenczek wrote:
> On 05.10.23 19:38, Stefan Hajnoczi wrote:
> > On Wed, Oct 04, 2023 at 02:58:58PM +0200, Hanna Czenczek wrote:
> > > GET_VRING_BASE does not mention that it stops the respective ring. Fix
> > > that.
> > >
> > > Furthermore, it is n
On 10/6/23 10:38, Joao Martins wrote:
On 02/10/2023 16:12, Cédric Le Goater wrote:
Hello Joao,
On 6/22/23 23:48, Joao Martins wrote:
From: Yi Liu
Add a pci_setup_iommu_ops() that uses a newly added structure
(PCIIOMMUOps) instead of using PCIIOMMUFunc. The old pci_setup_iommu()
that uses PCI
Hi Joao,
On 6/22/23 23:48, Joao Martins wrote:
> From: Yi Liu
>
> Refactor pci_device_iommu_address_space() and move the
> code that fetches the device bus and iommu bus into its
> own private helper pci_device_get_iommu_bus_devfn().
>
> This is in preparation to introduce pci_device_iommu_get_
Michael Tokarev writes:
> Applied to my trivial-patches tree, thanks!
>
> Marcus, you picked up previous patches of this theme, --
> you can continue this tradition if you like :)
I intend to post a pull request for the -Wshadow patches that have
R-bys. I'm also tracking the unreviewed ones, an
Am 05.10.2023 um 21:55 hat Vladimir Sementsov-Ogievskiy geschrieben:
> On 11.09.23 12:46, Kevin Wolf wrote:
> > When the permission related BlockDriver callbacks are called, we are in
> > the middle of an operation traversing the block graph. Polling in such a
> > place is a very bad idea because t
On 03/10/2023 15:01, Michael S. Tsirkin wrote:
> On Wed, Sep 27, 2023 at 12:14:28PM +0100, Joao Martins wrote:
>> On setups with one or more virtio-net devices with vhost on,
>> dirty tracking iteration increases cost the bigger the number
>> amount of queues are set up e.g. on idle guests migratio
Conflicts with recent commit ad75a51e84a (tcg: Rename cpu_env to
tcg_env). Please rebase.
From: neder
---
include/exec/mcdstub.h | 31 +
mcdstub/mcd_softmmu.c| 85 +++
mcdstub/mcd_syscalls.c | 0
mcdstub/mcd_tcp_server.c | 95
mcdstub/mcdstub.c| 0
softmmu/vl.c | 4 ++
From: neder
---
gdbstub/gdbstub.c | 2 +-
include/exec/mcdstub.h | 21 +-
include/mcdstub/syscalls.h | 6 +
mcdstub/internals.h| 135 ++
mcdstub/mcd_softmmu.c | 218 +++-
mcdstub/mcd_syscalls.c | 20 ++
mcdstub/mcd_tcp_server.c | 2 +-
From: neder
---
mcdstub/internals.h | 54 -
mcdstub/mcd_shared_defines.h | 13 ++
mcdstub/mcdstub.c| 229 ---
3 files changed, 249 insertions(+), 47 deletions(-)
diff --git a/mcdstub/internals.h b/mcdstub/internals.h
index 0de8d8fd0
SUMMARY
===
This patch-set introduces the first version of the mcdstub.
The mcdstub is a debug interface, which enables debugging QEMU
using the MCD (Multi-Core Debug) API.
The mcdstub uses TCP to communicate with the host debug software. However,
because MCD is merely an API, the TCP communic
From: neder
---
mcdstub/internals.h| 55 +--
mcdstub/mcdstub.c | 320 ++---
target/arm/meson.build | 1 +
3 files changed, 344 insertions(+), 32 deletions(-)
diff --git a/mcdstub/internals.h b/mcdstub/internals.h
index 8df535e92a..45ba1ca8cb 1
From: neder
---
mcdstub/internals.h | 9 ++-
mcdstub/mcd_shared_defines.h | 2 +-
mcdstub/mcdstub.c| 124 +++
3 files changed, 89 insertions(+), 46 deletions(-)
diff --git a/mcdstub/internals.h b/mcdstub/internals.h
index a85173d0d1..871a
From: neder
Signed-off-by: neder
---
mcdstub/meson.build | 10 +-
qemu-options.hx | 13 +++--
2 files changed, 4 insertions(+), 19 deletions(-)
diff --git a/mcdstub/meson.build b/mcdstub/meson.build
index ebd47b0725..6b2f970eae 100644
--- a/mcdstub/meson.build
+++ b/mcdstub
From: neder
---
softmmu/cpus.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/softmmu/cpus.c b/softmmu/cpus.c
index b1807e6d7b..5d0657bbe5 100644
--- a/softmmu/cpus.c
+++ b/softmmu/cpus.c
@@ -306,7 +306,10 @@ void cpu_handle_guest_debug(CPUState *cpu)
cpu_si
From: neder
---
gdbstub/gdbstub.c |2 +-
include/exec/mcdstub.h |3 +-
include/mcdstub/syscalls.h |2 +-
mcdstub/mcd_shared_defines.h | 17 +-
mcdstub/mcd_softmmu.c | 171 -
mcdstub/mcd_syscalls.c |7 +-
m
From: neder
---
MAINTAINERS | 3 +
debug/debug-common.c | 42
debug/debug-gdb.c | 24 +++
debug/debug-mcd.c | 25 +++
gdbstub/meson.build | 4 +-
gdbstub/softmmu.c | 4 ++
gdbstub/user.c
From: neder
---
mcdstub/internals.h| 64 -
mcdstub/mcd_syscalls.c | 11 +
mcdstub/mcdstub.c | 541 +++--
3 files changed, 596 insertions(+), 20 deletions(-)
diff --git a/mcdstub/internals.h b/mcdstub/internals.h
index 7b0f4b0b36..5af705a12a 100
From: neder
---
mcdstub/mcdstub.c | 26 ++
mcdstub/mcdstub.h | 3 ++-
2 files changed, 24 insertions(+), 5 deletions(-)
diff --git a/mcdstub/mcdstub.c b/mcdstub/mcdstub.c
index 4327703bca..8fc95d96a4 100644
--- a/mcdstub/mcdstub.c
+++ b/mcdstub/mcdstub.c
@@ -434,6 +434,
From: neder
---
mcdstub/mcd_shared_defines.h | 2 +-
mcdstub/mcdstub.c| 101 +--
mcdstub/mcdstub.h| 29 ++
3 files changed, 82 insertions(+), 50 deletions(-)
diff --git a/mcdstub/mcd_shared_defines.h b/mcdstub/mcd_shared_defines
From: neder
---
mcdstub/internals.h | 11 ++-
mcdstub/mcd_shared_defines.h | 7 ++
mcdstub/mcdstub.c| 129 +++
target/arm/mcdstub.c | 75
target/arm/mcdstub.h | 7 ++
5 files changed, 228 insertions(+
From: neder
---
mcdstub/internals.h | 9 +
mcdstub/mcdstub.c | 19 ++-
2 files changed, 27 insertions(+), 1 deletion(-)
diff --git a/mcdstub/internals.h b/mcdstub/internals.h
index 5af705a12a..ce3bffe7e6 100644
--- a/mcdstub/internals.h
+++ b/mcdstub/internals.h
@@ -1
From: neder
---
mcdstub/mcd_shared_defines.h | 2 ++
mcdstub/mcdstub.c| 35 +--
2 files changed, 23 insertions(+), 14 deletions(-)
diff --git a/mcdstub/mcd_shared_defines.h b/mcdstub/mcd_shared_defines.h
index 5cfda4121d..5fbd732252 100644
--- a/mcds
From: neder
---
mcdstub/mcdstub.c| 131 +++
mcdstub/mcdstub.h| 4 +-
target/arm/mcdstub.c | 14 +
target/arm/mcdstub.h | 1 +
4 files changed, 100 insertions(+), 50 deletions(-)
diff --git a/mcdstub/mcdstub.c b/mcdstub/mcdstub.c
index 377
From: neder
---
target/arm/mcdstub.h => include/mcdstub/arm_mcdstub.h | 2 +-
{mcdstub => include/mcdstub}/mcd_shared_defines.h | 0
{mcdstub => include/mcdstub}/mcdstub.h| 0
{mcdstub => include/mcdstub}/mcdstub_common.h | 0
mcdstub/mcd_syscalls.c
From: neder
---
mcdstub/internals.h | 4 +-
mcdstub/mcd_shared_defines.h | 24
mcdstub/mcdstub.c| 72 ++--
3 files changed, 62 insertions(+), 38 deletions(-)
create mode 100644 mcdstub/mcd_shared_defines.h
diff --git a/mcdstub/
From: neder
---
mcdstub/mcd_shared_defines.h | 1 +
mcdstub/mcdstub.c| 117 ++--
mcdstub/mcdstub.h| 18 ++-
target/arm/mcdstub.c | 265 ++-
target/arm/mcdstub.h | 16 ++-
5 files changed, 330 insertions(+), 8
From: neder
---
mcdstub/mcd_shared_defines.h | 8
mcdstub/mcdstub.c| 74
mcdstub/mcdstub.h| 33 +---
target/arm/mcdstub.c | 2 +-
4 files changed, 60 insertions(+), 57 deletions(-)
diff --git a/mcdstub/mcd_s
From: neder
---
include/exec/mcdstub.h | 6 +-
include/mcdstub/syscalls.h | 4 +-
mcdstub/internals.h | 77 +++
mcdstub/mcd_shared_defines.h | 3 +-
mcdstub/mcdstub.c| 428 ++-
softmmu/cpus.c | 2 +-
target/a
From: neder
---
mcdstub/mcd_shared_defines.h | 8 +++
mcdstub/mcdstub.c| 124 ++-
mcdstub/mcdstub.h| 4 ++
softmmu/cpus.c | 2 +-
4 files changed, 135 insertions(+), 3 deletions(-)
diff --git a/mcdstub/mcd_shared_define
From: neder
---
include/exec/mcdstub.h | 7 -
include/mcdstub/syscalls.h | 2 +-
mcdstub/mcd_shared_defines.h | 1 +
mcdstub/mcdstub.c| 61 ++--
mcdstub/mcdstub.h| 579 ++-
mcdstub/mcdstub_common.h | 18 ++
target/arm/mc
From: neder
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 81625f036b..b6bc8201bb 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2832,6 +2832,15 @@ F: tests/tcg/multiarch/gdbstub/
F: scripts/feature_to_c.sh
F: scripts/probe-gdb-supp
From: neder
---
mcdstub/internals.h | 29 +++---
mcdstub/mcdstub.c | 240
2 files changed, 147 insertions(+), 122 deletions(-)
diff --git a/mcdstub/internals.h b/mcdstub/internals.h
index ce3bffe7e6..8df535e92a 100644
--- a/mcdstub/internals.h
+++
From: neder
---
mcdstub/mcdstub.c| 244 ++-
mcdstub/mcdstub.h| 64 +-
mcdstub/mcdstub_common.h | 46
target/arm/mcdstub.c | 231
target/arm/mcdstub.h | 22
5 files changed, 3
From: neder
---
mcdstub/internals.h | 35 +++-
mcdstub/mcdstub.c | 382 ++--
2 files changed, 215 insertions(+), 202 deletions(-)
diff --git a/mcdstub/internals.h b/mcdstub/internals.h
index 45ba1ca8cb..2f9a768038 100644
--- a/mcdstub/internals.h
+++ b
Hi Joao,
On 6/22/23 23:48, Joao Martins wrote:
> From: Yi Liu
>
> Refactor pci_device_iommu_address_space() and move the
> code that fetches the device bus and iommu bus into its
> own private helper pci_device_get_iommu_bus_devfn().
>
> This is in preparation to introduce pci_device_iommu_get_
From: neder
---
mcdstub/internals.h | 63 +++-
mcdstub/mcd_shared_defines.h | 43 ++-
mcdstub/mcdstub.c| 693 ++-
3 files changed, 533 insertions(+), 266 deletions(-)
diff --git a/mcdstub/internals.h b/mcdstub/internals.h
index 4c79ff7674..
From: neder
---
mcdstub/internals.h | 14
mcdstub/mcd_shared_defines.h | 4 +++
mcdstub/mcdstub.c| 65
3 files changed, 63 insertions(+), 20 deletions(-)
diff --git a/mcdstub/internals.h b/mcdstub/internals.h
index a4d49a4a84..
Alex Bennée writes:
> Philippe Mathieu-Daudé writes:
>
>> Fix:
>>
>> semihosting/arm-compat-semi.c: In function ‘do_common_semihosting’:
>> semihosting/arm-compat-semi.c:379:13: warning: declaration of ‘ret’
>> shadows a previous local [-Wshadow=local]
>> 379 | int ret, err = 0;
On 06.10.23 10:45, Michael S. Tsirkin wrote:
On Fri, Oct 06, 2023 at 09:48:14AM +0200, Hanna Czenczek wrote:
On 05.10.23 19:15, Michael S. Tsirkin wrote:
On Thu, Oct 05, 2023 at 01:08:52PM -0400, Stefan Hajnoczi wrote:
On Wed, Oct 04, 2023 at 02:58:57PM +0200, Hanna Czenczek wrote:
There is n
On Fri, Oct 06, 2023 at 11:15:55AM +0200, Hanna Czenczek wrote:
> On 06.10.23 10:45, Michael S. Tsirkin wrote:
> > On Fri, Oct 06, 2023 at 09:48:14AM +0200, Hanna Czenczek wrote:
> > > On 05.10.23 19:15, Michael S. Tsirkin wrote:
> > > > On Thu, Oct 05, 2023 at 01:08:52PM -0400, Stefan Hajnoczi wro
On 04/10/2023 14.00, Philippe Mathieu-Daudé wrote:
Fix:
hw/audio/soundhw.c:86:33: error: declaration shadows a variable in the
global scope [-Werror,-Wshadow]
void select_soundhw(const char *optarg, const char *audiodev)
^
/Library/Developer/CommandL
On 03.10.23 15:39, Michael S. Tsirkin wrote:
On Tue, Sep 26, 2023 at 08:57:20PM +0200, David Hildenbrand wrote:
Quoting from patch #16:
Having large virtio-mem devices that only expose little memory to a VM
is currently a problem: we map the whole sparse memory region into the
gu
On 25/4/23 15:38, Thomas Huth wrote:
Aside from not supporting KVM on 32-bit hosts, the qemu-system-x86_64
binary is a proper superset of the qemu-system-i386 binary. And with
the 32-bit x86 host support being deprecated now, it is possible to
deprecate the qemu-system-i386 binary now, too.
With
On 06.10.23 11:26, Michael S. Tsirkin wrote:
On Fri, Oct 06, 2023 at 11:15:55AM +0200, Hanna Czenczek wrote:
On 06.10.23 10:45, Michael S. Tsirkin wrote:
On Fri, Oct 06, 2023 at 09:48:14AM +0200, Hanna Czenczek wrote:
On 05.10.23 19:15, Michael S. Tsirkin wrote:
On Thu, Oct 05, 2023 at 01:08:
On Fri, Oct 06, 2023 at 09:58:30AM +0100, Joao Martins wrote:
> On 03/10/2023 15:01, Michael S. Tsirkin wrote:
> > On Wed, Sep 27, 2023 at 12:14:28PM +0100, Joao Martins wrote:
> >> On setups with one or more virtio-net devices with vhost on,
> >> dirty tracking iteration increases cost the bigger
On 6/10/23 11:05, Nicolas Eder wrote:
SUMMARY
===
This patch-set introduces the first version of the mcdstub.
The mcdstub is a debug interface, which enables debugging QEMU
using the MCD (Multi-Core Debug) API.
[...]
neder (29):
mcdstub initial commit, mcdstub file structure added
On 6/10/23 11:14, Markus Armbruster wrote:
Alex Bennée writes:
Philippe Mathieu-Daudé writes:
Fix:
semihosting/arm-compat-semi.c: In function ‘do_common_semihosting’:
semihosting/arm-compat-semi.c:379:13: warning: declaration of ‘ret’ shadows
a previous local [-Wshadow=local]
3
On 06/10/2023 07.35, Cédric Le Goater wrote:
Remove extra 'i' variable to fix this warning :
../target/ppc/kvm.c: In function ‘kvm_arch_put_registers’:
../target/ppc/kvm.c:963:13: warning: declaration of ‘i’ shadows a previous
local [-Wshadow=compatible-local]
963 | int i;
On 25/09/2023 17.10, Laurent Vivier wrote:
Fix following warnings:
.../linux-user/flatload.c: In function 'load_flt_binary':
.../linux-user/flatload.c:758:23: warning: declaration of 'p' shadows a
previous local [-Wshadow=compatible-local]
758 | abi_ulong p;
|
On 25/09/2023 17.10, Laurent Vivier wrote:
Fix following warnings:
.../linux-user/mmap.c: In function 'target_mremap':
.../linux-user/mmap.c:913:13: warning: declaration of 'prot' shadows a previous
local [-Wshadow=compatible-local]
913 | int prot = 0;
| ^~~~
../..
On 06.10.23 01:53, Paolo Bonzini wrote:
On Thu, Oct 5, 2023 at 4:04 PM Vladimir Sementsov-Ogievskiy
wrote:
+/*
+ * Assure Coverity (and ourselves) that we are not going to OVERRUN
+ * the buffer by following ldn_he_p().
+ */
+assert((l
On 06.10.23 13:27, Vladimir Sementsov-Ogievskiy wrote:
On 06.10.23 01:53, Paolo Bonzini wrote:
On Thu, Oct 5, 2023 at 4:04 PM Vladimir Sementsov-Ogievskiy
wrote:
+ /*
+ * Assure Coverity (and ourselves) that we are not going to OVERRUN
+ * the buffer by follo
https://github.com/legoater/qemu/ tags/pull-vfio-20231006
for you to fetch changes up to 6e86aaef9ac57066aa923211a164df95b7b3cdf7:
vfio/common: Move legacy VFIO backend code into separate container.c
(2023-10-05 22:04:52 +0200)
---
On Fri, Oct 06, 2023 at 11:47:55AM +0200, Hanna Czenczek wrote:
> On 06.10.23 11:26, Michael S. Tsirkin wrote:
> > On Fri, Oct 06, 2023 at 11:15:55AM +0200, Hanna Czenczek wrote:
> > > On 06.10.23 10:45, Michael S. Tsirkin wrote:
> > > > On Fri, Oct 06, 2023 at 09:48:14AM +0200, Hanna Czenczek wrot
06.10.2023 11:55, Markus Armbruster пишет:
Michael Tokarev writes:
Applied to my trivial-patches tree, thanks!
Marcus, you picked up previous patches of this theme, --
you can continue this tradition if you like :)
I intend to post a pull request for the -Wshadow patches that have
R-bys. I
Cédric Le Goater writes:
> Remove extra 'i' variable to fix this warning :
>
> ../target/ppc/kvm.c: In function ‘kvm_arch_put_registers’:
> ../target/ppc/kvm.c:963:13: warning: declaration of ‘i’ shadows a previous
> local [-Wshadow=compatible-local]
> 963 | int i;
> |
04.10.2023 16:13, Thomas Huth:
Rename a variable to make this code compilable with -Wshadow.
Signed-off-by: Thomas Huth
Reviewed-By: Michael Tokarev
dump/dump.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/dump/dump.c b/dump/dump.c
index d4ef713cd0..d3578d
04.10.2023 16:08, Thomas Huth:
Rename variables or remove nested definitions where it makes sense,
so that we can finally compile the USB code with "-Wshadow", too.
Signed-off-by: Thomas Huth
Reviewed-by: Michael Tokarev
/mjt
Michael Tokarev writes:
> 06.10.2023 11:55, Markus Armbruster пишет:
>> Michael Tokarev writes:
>>
>>> Applied to my trivial-patches tree, thanks!
>>>
>>> Marcus, you picked up previous patches of this theme, --
>>> you can continue this tradition if you like :)
>> I intend to post a pull reque
Thanks a lot for reviewing!
On 05.10.23 23:29, Eric Blake wrote:
On Thu, Oct 05, 2023 at 04:55:50PM +0300, Vladimir Sementsov-Ogievskiy wrote:
In many cases we just want an effect of qmp command and want to raise on
failure. Use vm.cmd() method which does exactly this.
Signed-off-by: Vladimir
On 06/10/2023 10:48, Michael S. Tsirkin wrote:
> On Fri, Oct 06, 2023 at 09:58:30AM +0100, Joao Martins wrote:
>> On 03/10/2023 15:01, Michael S. Tsirkin wrote:
>>> On Wed, Sep 27, 2023 at 12:14:28PM +0100, Joao Martins wrote:
On setups with one or more virtio-net devices with vhost on,
>>>
Queued, thanks!
On 06/10/2023 09:45, Eric Auger wrote:
> Hi Joao,
>
> On 6/22/23 23:48, Joao Martins wrote:
>> From: Yi Liu
>>
>> Add a pci_setup_iommu_ops() that uses a newly added structure
>> (PCIIOMMUOps) instead of using PCIIOMMUFunc. The old pci_setup_iommu()
>> that uses PCIIOMMUFunc is still kept for
Le 04/10/2023 à 10:37, Mark Cave-Ayland a écrit :
This series contains the remaining patches needed to allow QEMU's q800
machine to boot MacOS Classic when used in conjunction with a real
Quadra 800 ROM image. In fact with this series applied it is possible
to boot all of the following OSs:
-
On 25/09/2023 17.10, Laurent Vivier wrote:
Fix following warnings:
.../linux-user/syscall.c: In function 'do_ioctl_dm':
.../linux-user/syscall.c:5053:23: warning: declaration of 'arg_type' shadows a
previous local [-Wshadow=local]
5053 | const argtype arg_type[] = { MK_STRUCT(STRUCT_d
On 06/10/2023 09:50, Cédric Le Goater wrote:
> On 10/6/23 10:38, Joao Martins wrote:
>> On 02/10/2023 16:12, Cédric Le Goater wrote:
>>> Hello Joao,
>>>
>>> On 6/22/23 23:48, Joao Martins wrote:
From: Yi Liu
Add a pci_setup_iommu_ops() that uses a newly added structure
(PCII
On 25/09/2023 17.10, Laurent Vivier wrote:
Fix following warnings:
.../linux-user/syscall.c: In function 'do_syscall1':
.../linux-user/syscall.c:11180:22: warning: declaration of 'cpu' shadows a
previous local [-Wshadow=local]
11180 | unsigned cpu, node;
|
On Wed, Sep 13, 2023 at 11:50:58PM -0400, Xiaoyao Li wrote:
> From: Chao Peng
>
> Add KVM gmem support to RAMBlock so both normal hva based memory
> and kvm gmem fd based private memory can be associated in one RAMBlock.
>
> Introduce new flag RAM_KVM_GMEM. It calls KVM ioctl to create private
>
On 06/10/2023 09:52, Eric Auger wrote:
> Hi Joao,
>
> On 6/22/23 23:48, Joao Martins wrote:
>> From: Yi Liu
>>
>> Refactor pci_device_iommu_address_space() and move the
>> code that fetches the device bus and iommu bus into its
>> own private helper pci_device_get_iommu_bus_devfn().
>>
>> This is
On 25/09/2023 17.10, Laurent Vivier wrote:
p is a generic variable in syscall() and can be used by any syscall
case, so this patch removes the useless local variable declaration for
the following syscalls: TARGET_NR_llistxattr, TARGET_NR_listxattr,
TARGET_NR_setxattr, TARGET_NR_lsetxattr, TARGET_
On 04/10/2023 14.00, Philippe Mathieu-Daudé wrote:
Fix:
net/net.c:1680:35: error: declaration shadows a variable in the global scope
[-Werror,-Wshadow]
bool netdev_is_modern(const char *optarg)
^
net/net.c:1714:38: error: declaration shadows a varia
From: Philippe Mathieu-Daudé
hvf_get_supported_cpuid() is only defined for x86 targets
(in target/i386/hvf/x86_cpuid.c).
Its declaration is pointless on all other targets.
All the calls to it in target/i386/cpu.c are guarded by
a call on hvf_enabled(), so are elided when HVF is not
built in. The
From: Philippe Mathieu-Daudé
Since we *might* have user emulation with softmmu,
replace the system emulation check by !user emulation one.
(target/ was cleaned from invalid CONFIG_SOFTMMU uses at
commit cab35c73be, but these files were merged few days
after, thus missed the cleanup.)
Signed-off
The following changes since commit da1034094d375afe9e3d8ec8980550ea0f06f7e0:
Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging
(2023-10-03 07:43:44 -0400)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git tags/for-upstream
for you to fetch c
Setting --bindir= to an absolute path that is shorter than the
prefix causes GCC to complain about array accesses out of bounds.
The code however is safe, so disable the warning and explain why
we are doing so.
Signed-off-by: Paolo Bonzini
---
util/cutils.c | 9 +
1 file changed, 9 inser
It will be used soon to define a default audio device from the
command line.
Signed-off-by: Paolo Bonzini
---
audio/audio.c | 19 ---
audio/audio.h | 1 +
2 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index 67a7e25254d..887219e0ce4
1 - 100 of 288 matches
Mail list logo
