Re: [PULL 38/56] hw/acpi: changes towards enabling -Wshadow=local

2023-09-30 Thread Markus Armbruster
Ani Sinha writes: >> On 29-Sep-2023, at 2:20 PM, Markus Armbruster wrote: >> >> From: Ani Sinha >> >> Code changes in acpi that addresses all compiler complaints coming from >> enabling >> -Wshadow flags. Enabling -Wshadow catches cases of local variables shadowing >> other local variables o

Re: [PATCH v11 6/9] gfxstream + rutabaga: add initial support for gfxstream

2023-09-30 Thread Thomas Huth
On 29/09/2023 17.06, Bernhard Beschow wrote: Am 21. September 2023 23:44:42 UTC schrieb Gurchetan Singh : On Tue, Sep 19, 2023 at 3:07 PM Akihiko Odaki wrote: On 2023/09/20 3:36, Bernhard Beschow wrote: Am 15. September 2023 02:38:02 UTC schrieb Gurchetan Singh < gurchetansi...@chromiu

Re: [PATCH v3 05/20] q800: add IOSB subsystem

2023-09-30 Thread BALATON Zoltan
On Fri, 29 Sep 2023, Mark Cave-Ayland wrote: It is needed because it defines the BIOSConfig area. Co-developed-by: Laurent Vivier Signed-off-by: Mark Cave-Ayland --- MAINTAINERS| 2 + hw/m68k/Kconfig| 1 + hw/m68k/q800.c | 9 +++ hw/misc/Kconfig| 3 + hw

[PATCH] target/loongarch: fix ASXE flag conflict

2023-09-30 Thread Jiajie Chen
HW_FLAGS_EUEN_ASXE acccidentally conflicts with HW_FLAGS_CRMD_PG, enabling LASX instructions even when CSR_EUEN.ASXE=0. Closes: https://gitlab.com/qemu-project/qemu/-/issues/1907 Signed-off-by: Jiajie Chen --- target/loongarch/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [PATCH 1/7] tcg: Add C_N2_I1

2023-09-30 Thread Jiajie Chen
On 2023/9/17 06:01, Richard Henderson wrote: Constraint with two outputs, both in new registers. Signed-off-by: Richard Henderson --- tcg/tcg.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tcg/tcg.c b/tcg/tcg.c index 604fa9bf3e..fdbf79689a 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @

Re: [PATCH 3/7] util: Add cpuinfo for loongarch64

2023-09-30 Thread Jiajie Chen
On 2023/9/17 06:01, Richard Henderson wrote: Signed-off-by: Richard Henderson --- host/include/loongarch64/host/cpuinfo.h | 21 +++ util/cpuinfo-loongarch.c| 35 + util/meson.build| 2 ++ 3 files changed, 58 inse

Re: [PATCH 2/7] tcg/loongarch64: Use C_N2_I1 for INDEX_op_qemu_ld_a*_i128

2023-09-30 Thread Jiajie Chen
On 2023/9/17 06:01, Richard Henderson wrote: Use new registers for the output, so that we never overlap the input address, which could happen for user-only. This avoids a "tmp = addr + 0" in that case. Signed-off-by: Richard Henderson --- tcg/loongarch64/tcg-target-con-set.h | 2 +- tcg/l

Re: [PATCH 4/7] tcg/loongarch64: Use cpuinfo.h

2023-09-30 Thread Jiajie Chen
On 2023/9/17 06:01, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/loongarch64/tcg-target.h | 8 tcg/loongarch64/tcg-target.c.inc | 8 +--- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/tcg/loongarch64/tcg-target.h b/tcg/loongarch64/tcg

[PATCH 0/5] m68k: Instantiate ESP and next-net in the next-cube machine

2023-09-30 Thread Thomas Huth
Mark Cave-Ayland recently asked me about the ESP patches for the next-cube machine that I once posted a long time ago, but never got it merged (since Mark is currently working on improving the ESP device). With his help, I dusted off the ESP patch, but we had to discover that the firmware also want

Re: [PATCH v7 12/12] nbd/server: Add FLAG_PAYLOAD support to CMD_BLOCK_STATUS

2023-09-30 Thread Vladimir Sementsov-Ogievskiy
On 25.09.23 22:22, Eric Blake wrote: Allow a client to request a subset of negotiated meta contexts. For example, a client may ask to use a single connection to learn about both block status and dirty bitmaps, but where the dirty bitmap queries only need to be performed on a subset of the disk;

[PATCH 3/5] m68k: Instantiate the ESP SCSI controller for the NeXTcube machine

2023-09-30 Thread Thomas Huth
The NeXTcube uses a NCR 53C90 SCSI interface for its disks, so we should be able to use the ESP controller from QEMU here. The code here has been basically taken from Bryce Lanham's GSoC 2011 contribution, except for the next_scsi_init() function which has been rewritte as a replacement for the esp

[PATCH 1/5] hw/m68k/next-cube: Mirror BIOS to address 0

2023-09-30 Thread Thomas Huth
The ROM is also available at address 0, so add a proper mirror for this address. Signed-off-by: Thomas Huth --- hw/m68k/next-cube.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index 5d244b3b95..4ab9a5ec98 100644 --- a/hw/m68k/n

[PATCH 5/5] m68k: Add NeXTcube network controller

2023-09-30 Thread Thomas Huth
The device is based on Bryce's code from GSoC 2011 that can be found here: https://github.com/blanham/qemu-NeXT/blob/next-cube/hw/next-net.c The network boot unfortunately does not work yet (the firmware successfully can send out packets, but still have problems receiving the answer of the BOOTP

[PATCH 2/5] hw/scsi/esp: Work around problem with PIO data read for the NeXT-Cube machine

2023-09-30 Thread Thomas Huth
The NeXT-Cube bios uses this mode in its selftest, and without decreasing the amount of bytes in the fifo here, the selftest fails. Signed-off-by: Thomas Huth --- hw/scsi/esp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index e52188d022..0d5

[PATCH 4/5] hw/m68k/next-cube: Remove unused NEXTDMA_EN code

2023-09-30 Thread Thomas Huth
The network code should reside in a separate file, so remove the related handlers from next-cube.c. Signed-off-by: Thomas Huth --- hw/m68k/next-cube.c | 42 -- 1 file changed, 42 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index 50

Re: [PATCH v7 01/12] nbd/server: Support a request payload

2023-09-30 Thread Vladimir Sementsov-Ogievskiy
On 25.09.23 22:22, Eric Blake wrote: Upcoming additions to support NBD 64-bit effect lengths allow for the possibility to distinguish between payload length (capped at 32M) and effect length (64 bits, although we generally assume 63 bits because of off_t limitations). Without that extension, onl

Re: [PATCH] target/sh4: fix crashes on signal delivery

2023-09-30 Thread Yoshinori Sato
On Fri, 29 Sep 2023 01:42:08 +0900, Mikulas Patocka wrote: > > sh4 uses gUSA (general UserSpace Atomicity) to provide atomicity on CPUs > that don't have atomic instructions. A gUSA region that adds 1 to an > atomic variable stored in @R2 looks like this: > > 4004b6: 03 c7 mova

Re: [PATCH] target/loongarch: fix ASXE flag conflict

2023-09-30 Thread Richard Henderson
On 9/30/23 04:28, Jiajie Chen wrote: HW_FLAGS_EUEN_ASXE acccidentally conflicts with HW_FLAGS_CRMD_PG, enabling LASX instructions even when CSR_EUEN.ASXE=0. Closes: https://gitlab.com/qemu-project/qemu/-/issues/1907 Signed-off-by: Jiajie Chen --- target/loongarch/cpu.h | 2 +- 1 file changed

Re: [PATCH v4 15/18] virtio-mem: Update state to match bitmap as soon as it's been migrated

2023-09-30 Thread Maciej S. Szmigiero
On 26.09.2023 20:57, David Hildenbrand wrote: It's cleaner and future-proof to just have other state that depends on the bitmap state to be updated as soon as possible when restoring the bitmap. So factor out informing RamDiscardListener into a functon and call it in case of early migration righ

Re: [PATCH v4 16/18] virtio-mem: Expose device memory dynamically via multiple memslots if enabled

2023-09-30 Thread Maciej S. Szmigiero
On 26.09.2023 20:57, David Hildenbrand wrote: Having large virtio-mem devices that only expose little memory to a VM is currently a problem: we map the whole sparse memory region into the guest using a single memslot, resulting in one gigantic memslot in KVM. KVM allocates metadata for the whole

[PATCH] build: Remove --enable-gprof

2023-09-30 Thread Richard Henderson
This build option has been deprecated since 8.0. Remove all CONFIG_GPROF code that depends on that, including one errant check using TARGET_GPROF. Signed-off-by: Richard Henderson --- docs/about/deprecated.rst | 14 -- meson.build| 12 bsd-user/b

Re: [PATCH 0/7] tcg/loongarch64: Improvements for 128-bit load/store

2023-09-30 Thread WANG Xuerui
On 9/30/23 10:13, Richard Henderson wrote: Ping. r~ On 9/16/23 15:01, Richard Henderson wrote: For tcg generated code, use new registers with load so that we never overlap the input address, so that we can simplify address build for 64-bit user-only. For tcg out-of-line code, implement the ho

[PATCH 1/1] qemu-img: do not erase destination file in qemu-img dd command

2023-09-30 Thread Mike Maslenkin
Add a check that destination file exists and do not call bdrv_create for this case. Currently `qemu-img dd` command destroys content of destination file. Effectively this means that parameters (geometry) of destination image file are changing. This can be undesirable behavior for user especially i

Re: On integrating LoongArch EDK2 firmware into QEMU build process

2023-09-30 Thread WANG Xuerui
On 3/31/23 08:54, maobibo wrote: Xuerui, Thanks for your mail, it is a good suggestion. Now we are planing to move LoongArch uefi bios from edk2-platform to edk2 repo, so that uefi bios supporting LoongArch can be auto compiled and uploaded to qemu repo. Only that process is somwhat slow sinc

[PATCH v2 1/1] qemu-img: do not erase destination file in qemu-img dd command

2023-09-30 Thread Mike Maslenkin
Add a check that destination file exists and do not call bdrv_create for this case. Currently `qemu-img dd` command destroys content of destination file. Effectively this means that parameters (geometry) of destination image file are changing. This can be undesirable behavior for user especially i

[PATCH] linux-user/hppa: Fix struct target_sigcontext layout

2023-09-30 Thread Richard Henderson
Use abi_ullong not uint64_t so that the alignment of the field and therefore the layout of the struct is correct. Signed-off-by: Richard Henderson --- linux-user/hppa/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/hppa/signal.c b/linux-user/hppa/signal.c

Re: [PATCH 0/4] ui/console: multihead: fix crash, simplify logic

2023-09-30 Thread Laszlo Ersek
On 9/29/23 09:57, Mark Cave-Ayland wrote: > On 26/09/2023 09:00, Marc-André Lureau wrote: > >> Hi Laszlo >> >> On Mon, Sep 25, 2023 at 7:36 PM Laszlo Ersek wrote: >>> Has this been queued by someone? Both Gerd and Marc-André are "odd >>> fixers", so I'm not sure who should be sending a PR with th

Re: [PATCH] hw/display/ramfb: plug slight guest-triggerable leak on mode setting

2023-09-30 Thread Laszlo Ersek
On 9/29/23 13:17, Marc-André Lureau wrote: > Hi > > On Wed, Sep 27, 2023 at 7:46 PM Laszlo Ersek wrote: >> >> On 9/19/23 15:19, Laszlo Ersek wrote: >>> The fw_cfg DMA write callback in ramfb prepares a new display surface in >>> QEMU; this new surface is put to use ("swapped in") upon the next di

[PATCH 2/2] elf2dmp: check array bounds in pdb_get_file_size

2023-09-30 Thread Viktor Prutyanov
Index in file_size array must be checked against num_files, because the entries we are looking for may be absent in the PDB. Signed-off-by: Viktor Prutyanov --- contrib/elf2dmp/pdb.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/contrib/elf2dmp/pdb.c b/contrib

[PATCH 0/2] elf2dmp: fixes of code analysis warnings

2023-09-30 Thread Viktor Prutyanov
This series is dedicated to fixes of Coverity warnings. Viktor Prutyanov (2): elf2dmp: limit print length for sign_rsds elf2dmp: check array bounds in pdb_get_file_size contrib/elf2dmp/main.c | 2 +- contrib/elf2dmp/pdb.c | 13 + 2 files changed, 10 insertions(+), 5 deletions(-

[PATCH 1/2] elf2dmp: limit print length for sign_rsds

2023-09-30 Thread Viktor Prutyanov
From: Viktor Prutyanov String sign_rsds isn't terminated, so the print length must be limited. Signed-off-by: Viktor Prutyanov --- contrib/elf2dmp/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/elf2dmp/main.c b/contrib/elf2dmp/main.c index 5db163bdbe..6de5c9

[PATCH v2 0/2] elf2dmp: fixes of code analysis warnings

2023-09-30 Thread Viktor Prutyanov
This series tries to fix Coverity warnings. v2: fix commit authorship, add CIDs Viktor Prutyanov (2): elf2dmp: limit print length for sign_rsds elf2dmp: check array bounds in pdb_get_file_size contrib/elf2dmp/main.c | 2 +- contrib/elf2dmp/pdb.c | 13 + 2 files changed, 10 ins

[PATCH v2 2/2] elf2dmp: check array bounds in pdb_get_file_size

2023-09-30 Thread Viktor Prutyanov
Index in file_size array must be checked against num_files, because the entries we are looking for may be absent in the PDB. Fixes: Coverity CID 1521597 Signed-off-by: Viktor Prutyanov --- contrib/elf2dmp/pdb.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/con

[PATCH v2 1/2] elf2dmp: limit print length for sign_rsds

2023-09-30 Thread Viktor Prutyanov
String sign_rsds isn't terminated, so the print length must be limited. Fixes: Coverity CID 1521598 Signed-off-by: Viktor Prutyanov --- contrib/elf2dmp/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/elf2dmp/main.c b/contrib/elf2dmp/main.c index 5db163bdbe..6de

Re: [PATCH] hw/display/ramfb: plug slight guest-triggerable leak on mode setting

2023-09-30 Thread Laszlo Ersek
On 10/1/23 00:14, Laszlo Ersek wrote: > On 9/29/23 13:17, Marc-André Lureau wrote: >> Hi >> >> On Wed, Sep 27, 2023 at 7:46 PM Laszlo Ersek wrote: >>> >>> On 9/19/23 15:19, Laszlo Ersek wrote: The fw_cfg DMA write callback in ramfb prepares a new display surface in QEMU; this new surface

Re: [PATCH 0/4] ui/console: multihead: fix crash, simplify logic

2023-09-30 Thread Mark Cave-Ayland
On 30/09/2023 22:28, Laszlo Ersek wrote: On 9/29/23 09:57, Mark Cave-Ayland wrote: On 26/09/2023 09:00, Marc-André Lureau wrote: Hi Laszlo On Mon, Sep 25, 2023 at 7:36 PM Laszlo Ersek wrote: Has this been queued by someone? Both Gerd and Marc-André are "odd fixers", so I'm not sure who sho