[PATCH 06/31] configure: allow user to override docker engine

2023-09-25 Thread Alex Bennée
If you have both engines installed but one is broken you are stuck with the automagic. Allow the user to override the engine for this case. Signed-off-by: Alex Bennée --- configure | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 707132a3ae.

[PATCH] target/i386/kvm: eliminate shadowed local variables

2023-09-25 Thread Paolo Bonzini
These are harmless are they die immediately after their use. Signed-off-by: Paolo Bonzini --- target/i386/kvm/kvm.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index e5cd7cc8061..db10ed13e8c 100644 --- a/target/i386/kvm/

[PATCH 09/31] gdbstub: Fix target_xml initialization

2023-09-25 Thread Alex Bennée
From: Akihiko Odaki target_xml is no longer a fixed-length array but a pointer to a variable-length memory. Fixes: 56e534bd11 ("gdbstub: refactor get_feature_xml") Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230912224107.29669-2-akihiko.od...@daynix.com> Sig

[PATCH 14/31] target/arm: Move the reference to arm-core.xml

2023-09-25 Thread Alex Bennée
From: Akihiko Odaki Some subclasses overwrite gdb_core_xml_file member but others don't. Always initialize the member in the subclasses for consistency. This especially helps for AArch64; in a following change, the file specified by gdb_core_xml_file is always looked up even if it's going to be

[PATCH] target/i386/seg_helper: introduce tss_set_busy

2023-09-25 Thread Paolo Bonzini
Eliminate a shadowed local variable in the process. Signed-off-by: Paolo Bonzini --- target/i386/tcg/seg_helper.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/target/i386/tcg/seg_helper.c b/target/i386/tcg/seg_helper.c index e8d19c65fdc..b

[PATCH 12/31] contrib/plugins: Use GRWLock in execlog

2023-09-25 Thread Alex Bennée
From: Akihiko Odaki execlog had the following comment: > As we could have multiple threads trying to do this we need to > serialise the expansion under a lock. Threads accessing already > created entries can continue without issue even if the ptr array > gets reallocated during resize. However,

[RFC PATCH 29/31] sysemu: generalise qtest_warp_clock as qemu_clock_advance_virtual_time

2023-09-25 Thread Alex Bennée
Move the key functionality of moving time forward into the clock sub-system itself. This will allow us to plumb in time control into plugins. Signed-off-by: Alex Bennée Message-Id: <20230519170454.2353945-7-alex.ben...@linaro.org> --- v2 - rename arg to target_ns --- include/qemu/timer.h | 15

[PATCH 21/31] accel/tcg: Add plugin_enabled to DisasContextBase

2023-09-25 Thread Alex Bennée
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20230824181233.1568795-2-richard.hender...@linaro.org> Signed-off-by: Alex Bennée --- include/exec/translator.h | 2 ++ accel/tcg/translator.c| 1 + 2 files changed, 3 insertions(+) diff --git a/include/exec/translator.

[RFC PATCH 31/31] contrib/plugins: add iops plugin example for cost modelling

2023-09-25 Thread Alex Bennée
This plugin uses the new time control interface to make decisions about the state of time during the emulation. The algorithm is currently very simple. The user specifies an iops rate which applies per core. If the core runs ahead of its allocated execution time the plugin sleeps for a bit to let r

[RFC PATCH 27/31] sysemu: add set_virtual_time to accel ops

2023-09-25 Thread Alex Bennée
We are about to remove direct calls to individual accelerators for this information and will need a central point for plugins to hook into time changes. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230519170454.2353945-5-alex.ben...@linaro.org> --- v2 - more k

[PATCH 20/31] gdbstub: Replace gdb_regs with an array

2023-09-25 Thread Alex Bennée
From: Akihiko Odaki An array is a more appropriate data structure than a list for gdb_regs since it is initialized only with append operation and read-only after initialization. Signed-off-by: Akihiko Odaki Message-Id: <20230912224107.29669-13-akihiko.od...@daynix.com> [AJB: fixed a checkpatch

[PATCH 22/31] target/sh4: Disable decode_gusa when plugins enabled

2023-09-25 Thread Alex Bennée
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20230824181233.1568795-3-richard.hender...@linaro.org> Signed-off-by: Alex Bennée --- target/sh4/translate.c | 41 + 1 file changed, 29 insertions(+), 12 deletions(-) diff --git a/tar

[RFC PATCH 28/31] qtest: use cpu interface in qtest_clock_warp

2023-09-25 Thread Alex Bennée
This generalises the qtest_clock_warp code to use the AccelOps handlers for updating its own sense of time. This will make the next patch which moves the warp code closer to pure code motion. Signed-off-by: Alex Bennée Acked-by: Thomas Huth Message-Id: <20230519170454.2353945-6-alex.ben...@linar

[PATCH 18/31] target/ppc: Remove references to gdb_has_xml

2023-09-25 Thread Alex Bennée
From: Akihiko Odaki GDB has XML support since 6.7 which was released in 2007. It's time to remove support for old GDB versions without XML support. Signed-off-by: Akihiko Odaki Message-Id: <20230912224107.29669-11-akihiko.od...@daynix.com> Signed-off-by: Alex Bennée --- target/ppc/gdbstub.c |

[PATCH 16/31] gdbstub: Use g_markup_printf_escaped()

2023-09-25 Thread Alex Bennée
From: Akihiko Odaki g_markup_printf_escaped() is a safer alternative to simple printf() as it automatically escapes values. Signed-off-by: Akihiko Odaki Message-Id: <20230912224107.29669-9-akihiko.od...@daynix.com> Signed-off-by: Alex Bennée --- gdbstub/gdbstub.c | 36 +---

[RFC PATCH 30/31] plugins: add time control API

2023-09-25 Thread Alex Bennée
Expose the ability to control time through the plugin API. Only one plugin can control time so it has to request control when loaded. There are probably more corner cases to catch here. Signed-off-by: Alex Bennée Message-Id: <20230519170454.2353945-8-alex.ben...@linaro.org> --- v2 - ifdef for

[PATCH 24/31] contrib/plugins: fix coverity warning in cache

2023-09-25 Thread Alex Bennée
Coverity complains that appends_stats_line can be fed a 0 leading to the undefined behaviour of a divide by 0. Fixes: CID 1519044 Fixes: CID 1519047 Signed-off-by: Alex Bennée --- contrib/plugins/cache.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/cont

[PATCH 26/31] contrib/plugins: fix coverity warning in hotblocks

2023-09-25 Thread Alex Bennée
Coverity complains that we have an unbalance use of mutex leading to potential deadlocks. Fixes: CID 1519048 Signed-off-by: Alex Bennée --- contrib/plugins/hotblocks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/plugins/hotblocks.c b/contrib/plugins/hotblocks.c in

[PATCH 17/31] target/arm: Remove references to gdb_has_xml

2023-09-25 Thread Alex Bennée
From: Akihiko Odaki GDB has XML support since 6.7 which was released in 2007. It's time to remove support for old GDB versions without XML support. Signed-off-by: Akihiko Odaki Acked-by: Alex Bennée Message-Id: <20230912224107.29669-10-akihiko.od...@daynix.com> Signed-off-by: Alex Bennée ---

[PATCH 25/31] contrib/plugins: fix coverity warning in lockstep

2023-09-25 Thread Alex Bennée
Coverity complains that e don't check for a truncation when copying in the path. Bail if we can't copy the whole path into sockaddr. Fixes: CID 1519045 Fixes: CID 1519046 Signed-off-by: Alex Bennée --- contrib/plugins/lockstep.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-

Re: [PATCH] virtio: use shadow_avail_idx while checking number of heads

2023-09-25 Thread Ilya Maximets
On 9/25/23 16:23, Stefan Hajnoczi wrote: > On Fri, 25 Aug 2023 at 13:04, Ilya Maximets wrote: >> >> We do not need the most up to date number of heads, we only want to >> know if there is at least one. >> >> Use shadow variable as long as it is not equal to the last available >> index checked. Th

qemu-gtk clipboard crash fixes

2023-09-25 Thread edmund.raile
In response to [gemu-gtk-clipboard freezing and crashing guests](https://gitlab.com/qemu-project/qemu/-/issues/1150). I think I might have a solution for the gtk clipboard sometimes crashing guests. @kolAflash I couldn't have done it without you, figuring out `gtk_clipboard_wait_is_text_availab

Re: [PATCH] m48t59-test: remove shadowed variables and cleanup

2023-09-25 Thread Thomas Huth
On 25/09/2023 16.47, Paolo Bonzini wrote: Rename the variable "s" and, while at it, avoid the chance of an overflow in the computation of ABS(t - s). Signed-off-by: Paolo Bonzini --- tests/qtest/m48t59-test.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) I've got

[PATCH 0/5] linux-user: clean up local variable shadowing

2023-09-25 Thread Laurent Vivier
Laurent Vivier (5): linux-user/flatload: clean up local variable shadowing linux-user/mmap.c: clean up local variable shadowing linux-user/syscall.c: clean up local variable shadowing in do_ioctl_dm() linux-user/syscall.c: clean up local variable shadowing in TARGET_NR_getcpu

[PATCH 1/5] linux-user/flatload: clean up local variable shadowing

2023-09-25 Thread Laurent Vivier
Fix following warnings: .../linux-user/flatload.c: In function 'load_flt_binary': .../linux-user/flatload.c:758:23: warning: declaration of 'p' shadows a previous local [-Wshadow=compatible-local] 758 | abi_ulong p; | ^ ../../../Projects/qemu/linux-user/f

[PATCH 2/5] linux-user/mmap.c: clean up local variable shadowing

2023-09-25 Thread Laurent Vivier
Fix following warnings: .../linux-user/mmap.c: In function 'target_mremap': .../linux-user/mmap.c:913:13: warning: declaration of 'prot' shadows a previous local [-Wshadow=compatible-local] 913 | int prot = 0; | ^~~~ ../../../Projects/qemu/linux-user/mmap.c:871:9: note

[PATCH 3/5] linux-user/syscall.c: clean up local variable shadowing in do_ioctl_dm()

2023-09-25 Thread Laurent Vivier
Fix following warnings: .../linux-user/syscall.c: In function 'do_ioctl_dm': .../linux-user/syscall.c:5053:23: warning: declaration of 'arg_type' shadows a previous local [-Wshadow=local] 5053 | const argtype arg_type[] = { MK_STRUCT(STRUCT_dm_target_spec) }; |

[PATCH 4/5] linux-user/syscall.c: clean up local variable shadowing in TARGET_NR_getcpu

2023-09-25 Thread Laurent Vivier
Fix following warnings: .../linux-user/syscall.c: In function 'do_syscall1': .../linux-user/syscall.c:11180:22: warning: declaration of 'cpu' shadows a previous local [-Wshadow=local] 11180 | unsigned cpu, node; | ^~~ .../linux-user/syscall.c:8963:15: note:

[PATCH 5/5] linux-user/syscall.c: clean up local variable shadowing in xattr syscalls

2023-09-25 Thread Laurent Vivier
p is a generic variable in syscall() and can be used by any syscall case, so this patch removes the useless local variable declaration for the following syscalls: TARGET_NR_llistxattr, TARGET_NR_listxattr, TARGET_NR_setxattr, TARGET_NR_lsetxattr, TARGET_NR_getxattr, TARGET_NR_lgetxattr, TARGET_NR_r

Re: [PATCH] hw/i386: changes towards enabling -Wshadow=local

2023-09-25 Thread Peter Xu
On Sat, Sep 23, 2023 at 08:03:34AM +0530, Ani Sinha wrote: > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > index c0ce896668..c1fb69170f 100644 > --- a/hw/i386/intel_iommu.c > +++ b/hw/i386/intel_iommu.c > @@ -3770,9 +3770,9 @@ static void vtd_address_space_unmap(VTDAddressSpace > *a

Re: [PATCH] virtio: use shadow_avail_idx while checking number of heads

2023-09-25 Thread Stefan Hajnoczi
On Mon, 25 Sept 2023 at 11:02, Ilya Maximets wrote: > > On 9/25/23 16:23, Stefan Hajnoczi wrote: > > On Fri, 25 Aug 2023 at 13:04, Ilya Maximets wrote: > >> > >> We do not need the most up to date number of heads, we only want to > >> know if there is at least one. > >> > >> Use shadow variable a

[PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs

2023-09-25 Thread Jonathan Cameron via
Rename the version not burried in the macro to cap_h. Signed-off-by: Jonathan Cameron --- I had another instance of this in a series I'll post later today. Cleaned that up the same way. hw/cxl/cxl-device-utils.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/cxl

Re: [PATCH 02/31] tests/lcitool: add swtpm to the package list

2023-09-25 Thread Daniel P . Berrangé
On Mon, Sep 25, 2023 at 03:48:25PM +0100, Alex Bennée wrote: > We need this to test some TPM stuff. > > Signed-off-by: Alex Bennée > --- > .gitlab-ci.d/cirrus/macos-12.vars| 2 +- > tests/docker/dockerfiles/alpine.docker | 1 + > tests/docker/dockerfiles/centos8

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

2023-09-25 Thread Laszlo Ersek
Ping -- Michael, any comments please? This set (now at v2) has been waiting on your answer since Aug 30th. Laszlo On 9/5/23 08:30, Laszlo Ersek wrote: > Michael, > > On 8/30/23 17:37, Stefan Hajnoczi wrote: >> On Wed, 30 Aug 2023 at 09:30, Laszlo Ersek wrote: >>> >>> On 8/30/23 14:10, Stefan Ha

Re: [PATCH v6 09/10] migration/yank: Keep track of registered yank instances

2023-09-25 Thread Lukas Straub
On Mon, 25 Sep 2023 09:20:58 -0300 Fabiano Rosas wrote: > CC: Daniel for the QIOChannel discussion > > Lukas Straub writes: > > On Thu, 14 Sep 2023 10:57:47 -0400 > > Peter Xu wrote: > > > >> On Thu, Sep 14, 2023 at 10:23:38AM -0300, Fabiano Rosas wrote: > >> > Peter Xu writes: > >> >

Re: [PULL v2 0/9] i386, audio changes for 2023-09-22

2023-09-25 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/30] target-arm queue

2023-09-25 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] virtio: use shadow_avail_idx while checking number of heads

2023-09-25 Thread Ilya Maximets
On 9/25/23 17:12, Stefan Hajnoczi wrote: > On Mon, 25 Sept 2023 at 11:02, Ilya Maximets wrote: >> >> On 9/25/23 16:23, Stefan Hajnoczi wrote: >>> On Fri, 25 Aug 2023 at 13:04, Ilya Maximets wrote: We do not need the most up to date number of heads, we only want to know if there is

Re: [PATCH 0/4] ui/console: multihead: fix crash, simplify logic

2023-09-25 Thread Laszlo Ersek
On 9/15/23 13:50, Marc-André Lureau wrote: > Hi Laszlo > > On Wed, Sep 13, 2023 at 6:50 PM Laszlo Ersek wrote: >> >> Fix a recent regression (crash) in the multihead check; clean up the >> code some more. >> >> Cc: "Marc-André Lureau" (odd fixer:Graphics) >> Cc: Gerd Hoffmann (odd fixer:Graphic

Re: [PULL 0/7] qtest and misc patches

2023-09-25 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] virtio: use shadow_avail_idx while checking number of heads

2023-09-25 Thread Stefan Hajnoczi
On Mon, 25 Sept 2023 at 11:36, Ilya Maximets wrote: > > On 9/25/23 17:12, Stefan Hajnoczi wrote: > > On Mon, 25 Sept 2023 at 11:02, Ilya Maximets wrote: > >> > >> On 9/25/23 16:23, Stefan Hajnoczi wrote: > >>> On Fri, 25 Aug 2023 at 13:04, Ilya Maximets wrote: > > We do not need the mo

Re: [PATCH] ui/vnc: fix enabling of VNC_FEATURE_XVP

2023-09-25 Thread Daniel P . Berrangé
On Mon, Sep 25, 2023 at 04:50:34PM +0200, Paolo Bonzini wrote: > VNC_FEATURE_XVP was not shifted left before adding it to vs->features, > so it was never enabled. > > Signed-off-by: Paolo Bonzini > --- > ui/vnc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) /facepalm I definitely te

Re: [PATCH] ui/vnc: fix debug output for invalid audio message

2023-09-25 Thread Daniel P . Berrangé
On Mon, Sep 25, 2023 at 04:50:51PM +0200, Paolo Bonzini wrote: > The debug message was cut and pasted from the invalid audio format > case, but the audio message is at bytes 2-3. > > Signed-off-by: Paolo Bonzini > --- > ui/vnc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

Re: [PATCH v4 06/28] bsd-user: Implement target_to_host_resource conversion function

2023-09-25 Thread Warner Losh
On Sun, Sep 24, 2023 at 8:36 PM Karim Taha wrote: > From: Stacey Son > > Signed-off-by: Stacey Son > Signed-off-by: Karim Taha > --- > bsd-user/bsd-proc.c | 40 > bsd-user/bsd-proc.h | 4 > bsd-user/meson.build | 6 ++ > 3 files changed, 5

Re: [PATCH] vl: remove shadowed local variables

2023-09-25 Thread Daniel P . Berrangé
On Mon, Sep 25, 2023 at 04:47:41PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > softmmu/vl.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.c

Re: [PATCH v4 12/28] bsd-user: Implement umask(2), setlogin(2) and getlogin(2)

2023-09-25 Thread Warner Losh
On Sun, Sep 24, 2023 at 8:36 PM Karim Taha wrote: > From: Stacey Son > > Signed-off-by: Stacey Son > Signed-off-by: Karim Taha > --- > bsd-user/bsd-proc.h | 39 +++ > bsd-user/freebsd/os-syscall.c | 12 +++ > 2 files changed, 51 insertions(+)

Re: [PATCH v4 21/28] bsd-user: Implement procctl(2) along with necessary conversion functions.

2023-09-25 Thread Warner Losh
On Sun, Sep 24, 2023 at 8:36 PM Karim Taha wrote: > From: Stacey Son > > Implement t2h_procctl_cmd, h2t_reaper_status, h2t_reaper_pidinfo and > h2t/t2h reaper_kill conversion functions. > > Signed-off-by: Stacey Son > Signed-off-by: Karim Taha > --- > bsd-user/freebsd/os-proc.c| 222 +

Re: [PATCH v4 23/28] bsd-user: Implement wait4(2) and wait6(2) system calls.

2023-09-25 Thread Warner Losh
On Sun, Sep 24, 2023 at 8:36 PM Karim Taha wrote: > From: Stacey Son > > Signed-off-by: Stacey Son > Signed-off-by: Karim Taha > --- > bsd-user/freebsd/os-proc.h| 84 +++ > bsd-user/freebsd/os-syscall.c | 15 +++ > 2 files changed, 99 insertions(+) > R

Re: [PATCH v4 24/28] bsd-user: Implement setloginclass(2) and getloginclass(2) system calls.

2023-09-25 Thread Warner Losh
On Sun, Sep 24, 2023 at 8:37 PM Karim Taha wrote: > From: Stacey Son > > Signed-off-by: Stacey Son > Signed-off-by: Karim Taha > --- > bsd-user/freebsd/os-proc.h| 32 > bsd-user/freebsd/os-syscall.c | 8 > 2 files changed, 40 insertions Reviewe

Re: [PATCH v4 25/28] bsd-user: Implement pdgetpid(2) and the undocumented setugid.

2023-09-25 Thread Warner Losh
On Sun, Sep 24, 2023 at 8:37 PM Karim Taha wrote: > From: Stacey Son > > Signed-off-by: Stacey Son > Signed-off-by: Karim Taha > Reviewed-by: Richard Henderson > --- > bsd-user/freebsd/os-proc.h| 23 +++ > bsd-user/freebsd/os-syscall.c | 8 > 2 files changed

Re: [PATCH] ui/vnc: fix enabling of VNC_FEATURE_XVP

2023-09-25 Thread Paolo Bonzini
On 9/25/23 17:43, Daniel P. Berrangé wrote: On Mon, Sep 25, 2023 at 04:50:34PM +0200, Paolo Bonzini wrote: VNC_FEATURE_XVP was not shifted left before adding it to vs->features, so it was never enabled. Signed-off-by: Paolo Bonzini --- ui/vnc.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH v1 3/4] hw/arm/virt-acpi-build: patch guest SRAT for NUMA nodes

2023-09-25 Thread Jason Gunthorpe
On Mon, Sep 25, 2023 at 03:53:51PM +0100, Jonathan Cameron wrote: > On Mon, 25 Sep 2023 11:03:28 -0300 > Jason Gunthorpe wrote: > > > On Mon, Sep 25, 2023 at 02:54:40PM +0100, Jonathan Cameron wrote: > > > > > Possible the ASWG folk would say this is fine and I'm reading too much > > > into > >

Re: [PATCH v23 08/20] qapi/s390x/cpu topology: set-cpu-topology qmp command

2023-09-25 Thread Nina Schoetterl-Glausch
On Wed, 2023-09-20 at 13:36 +0200, Markus Armbruster wrote: > Nina Schoetterl-Glausch writes: > > > From: Pierre Morel > > > > The modification of the CPU attributes are done through a monitor > > command. > > > > It allows to move the core inside the topology tree to optimize > > the cache us

[PATCH v2] ui/vnc: fix handling of VNC_FEATURE_XVP

2023-09-25 Thread Paolo Bonzini
VNC_FEATURE_XVP was not shifted left before adding it to vs->features, so it was never enabled; but it was also checked the wrong way with a logical AND instead of vnc_has_feature. Fix both places. Signed-off-by: Paolo Bonzini --- ui/vnc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

Re: [PATCH v23 01/20] CPU topology: extend with s390 specifics

2023-09-25 Thread Nina Schoetterl-Glausch
On Tue, 2023-09-19 at 14:47 +0200, Markus Armbruster wrote: > Nina Schoetterl-Glausch writes: > > > From: Pierre Morel > > > > S390 adds two new SMP levels, drawers and books to the CPU > > topology. > > S390 CPUs have specific topology features like dedication and > > entitlement. These indica

Re: [PATCH v2] ui/vnc: fix handling of VNC_FEATURE_XVP

2023-09-25 Thread Daniel P . Berrangé
On Mon, Sep 25, 2023 at 06:05:06PM +0200, Paolo Bonzini wrote: > VNC_FEATURE_XVP was not shifted left before adding it to vs->features, > so it was never enabled; but it was also checked the wrong way with > a logical AND instead of vnc_has_feature. Fix both places. > > Signed-off-by: Paolo Bonzi

Re: [PATCH 05/31] tests/docker: make docker engine choice entirely configure driven

2023-09-25 Thread Paolo Bonzini
On 9/25/23 16:48, Alex Bennée wrote: Since 0b1a649047 (tests/docker: use direct RUNC call to build containers) we ended up with the potential for the remaining docker.py script calls to deviate from the direct RUNC calls. Fix this by dropping the use of ENGINE in the makefile and rely entirely on

[PATCH 00/19] QEMU: CXL mailbox rework and features

2023-09-25 Thread Jonathan Cameron via
Based on: [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs Based on: [PATCH v2 0/3] hw/cxl: Add dummy ACPI QTG DSM Based on: [PATCH V2] hw/pci-bridge/cxl-upstream: Add serial number extended capability support Based on: [PATCH v3 0/4] hw/cxl: Line length reduction and related Based on: [PA

[PATCH 01/19] hw/cxl/mbox: Pull the payload out of struct cxl_cmd and make instances constant

2023-09-25 Thread Jonathan Cameron via
Putting the pointer in the structure for command handling puts a single variable element inside an otherwise constant structure. Move it out as a directly passed variable and take the cxl_cmd structures constant. Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 13 hw/cxl/

[PATCH 02/19] hw/cxl/mbox: Split mailbox command payload into separate input and output

2023-09-25 Thread Jonathan Cameron via
New CCI types that will be supported shortly do not have a single buffer used in both directions. As such, split it up. For CXL mailboxes the two pointers will be aliases of the same memory so all callbacks must allow for that. Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h |

[PATCH 04/19] hw/cxl/mbox: Generalize the CCI command processing

2023-09-25 Thread Jonathan Cameron via
By moving the parts of the mailbox command handling that are CCI type specific out to the caller, make the main handling code generic. Rename it to cxl_process_cci_message() to reflect this new generality. Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 5 +++- hw/cxl/cxl-devi

[PATCH 03/19] hw/cxl/mbox: Pull the CCI definition out of the CXLDeviceState

2023-09-25 Thread Jonathan Cameron via
Enables having multiple CCIs per devices. Each CCI (mailbox) has it's own state and command list, so they can't share a single structure. Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 45 ++ hw/cxl/cxl-device-utils.c | 31 +--- hw/cxl/cxl-mailbox-uti

[PATCH 05/19] hw/pci-bridge/cxl_upstream: Move defintion of device to header.

2023-09-25 Thread Jonathan Cameron via
To avoid repetition of switch upstream port specific data in the CXLDeviceState structure it will be necessary to access the switch USP specific data from mailbox callbacks. Hence move it to cxl_device.h so it is no longer an opaque structure. Signed-off-by: Jonathan Cameron --- include/hw/pci-b

[PATCH 06/19] hw/cxl/i2c_mctp_cxl: Initial device emulation

2023-09-25 Thread Jonathan Cameron via
The CCI and Fabric Manager APIs are used to configure CXL switches and devices. DMTF has defined an MCTP binding specification to carry these messages. The end goal of this work is to hook this up to emulated CXL switches and devices to allow control of the configuration. Since this relies on i2c

[PATCH 07/19] hw/cxl/mbox: Add Information and Status / Identify command

2023-09-25 Thread Jonathan Cameron via
Add this command that is only available via out of band CCIs. It replicates information that can be discovered inband via PCI config space. Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 48 ++ 1 file changed, 48 insertions(+) diff --git a/h

Re: [PATCH 08/31] configure: ensure dependency for cross-compile setup

2023-09-25 Thread Paolo Bonzini
On 9/25/23 16:48, Alex Bennée wrote: If we update configure we should make sure we regenerate all the compiler details. We should also ensure those details are upto date before building the TCG tests. Signed-off-by: Alex Bennée --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --gi

[PATCH 08/19] docs: cxl: Add example commandline for MCTP CXL CCIs

2023-09-25 Thread Jonathan Cameron via
Add initial documentation for the MCTP over I2C management device. At current time this can only be used with the Aspeed I2C controller which is only available in aspeed SoCs, though can be added to other emulated boards. Signed-off-by: Jonathan Cameron --- docs/system/devices/cxl.rst | 27 +

[PATCH 09/19] hw/cxl/mbox: Add Physical Switch Identify command.

2023-09-25 Thread Jonathan Cameron via
Enable it for MCTP CCI for the switch. Will shortly be enabled for switch CCI as well. Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl.h | 6 hw/cxl/cxl-mailbox-utils.c | 65 ++ hw/pci-bridge/cxl_downstream.c | 4 +-- 3 files changed, 7

[PATCH 10/19] hw/cxl: Add a switch mailbox CCI function

2023-09-25 Thread Jonathan Cameron via
CXL switch CCIs were added in CXL r3.0. They are a PCI function, identified by class code that provides a CXL mailbox (identical to that previously defined for CXL type 3 memory devices) over which various FM-API commands may be used. Whilst the intent of this feature is enable switch control from

[PATCH 11/19] hw/pci-bridge/cxl_downstream: Set default link width and link speed

2023-09-25 Thread Jonathan Cameron via
Without these being set the PCIE Link Capabilities register has invalid values in these two fields. Signed-off-by: Jonathan Cameron --- hw/pci-bridge/cxl_downstream.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/pci-bridge/cxl_downstream.c b/hw/pci-bridge/cxl_downstream

[PATCH 12/19] hw/cxl: Implement Physical Ports status retrieval

2023-09-25 Thread Jonathan Cameron via
Add this command for both the Switch CCI and the MCTP CCI found in switch upstream ports. Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 121 + 1 file changed, 121 insertions(+) diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-ut

[PATCH 13/19] hw/cxl/mbox: Add Get Background Operation Status Command

2023-09-25 Thread Jonathan Cameron via
For now, provide this command on type 3 main mailbox only. Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 33 + 1 file changed, 33 insertions(+) diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c index 26fb0192a9..d9785f324a 10

[PATCH 14/19] hw/cxl/mbox: Add support for background operations

2023-09-25 Thread Jonathan Cameron via
From: Davidlohr Bueso Support background commands in the mailbox, and update cmd_infostat_bg_op_sts() accordingly. This patch does not implement mbox interrupts upon completion, so the kernel driver must rely on polling to know when the operation is done. Signed-off-by: Davidlohr Bueso Signed-o

[PATCH 15/19] hw/cxl/mbox: Wire up interrupts for background completion

2023-09-25 Thread Jonathan Cameron via
From: Davidlohr Bueso Notify when the background operation is done. Note that for now background commands are only supported on the main Type 3 mailbox. Signed-off-by: Davidlohr Bueso Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl_device.h | 1 + hw/cxl/cxl-device-utils.c | 10

[PATCH 16/19] hw/cxl: Add support for device sanitation

2023-09-25 Thread Jonathan Cameron via
From: Davidlohr Bueso Make use of the background operations through the sanitize command, per CXL 3.0 specs. Traditionally run times can be rather long, depending on the size of the media. Estimate times based on: https://pmem.io/documents/NVDIMM_DSM_Interface-V1.8.pdf Signed-off-by: D

[PATCH 17/19] hw/cxl/type3: Cleanup multiple CXL_TYPE3() calls in read/write functions

2023-09-25 Thread Jonathan Cameron via
From: Gregory Price Call CXL_TYPE3 once at top of function to avoid multiple invocations. Signed-off-by: Gregory Price Signed-off-by: Jonathan Cameron --- hw/mem/cxl_type3.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c

[PATCH 18/19] hw/cxl: Add dummy security state get

2023-09-25 Thread Jonathan Cameron via
Needed to allow the santize comamnds to be tested with proposed Linux Kernel support. Default value + no control of the security state will work for now. Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 17 + 1 file changed, 17 insertions(+) diff --git a/hw/cxl/

[PATCH 19/19] hw/cxl: Add tunneled command support to mailbox for switch cci/mctp.

2023-09-25 Thread Jonathan Cameron via
The implementation of tunneling makes the choice that our Type 3 device is a Logical Device (LD) of a Multi-Logical Device (MLD) that just happens to only have one LD for now. Tunneling is supported from a Switch Mailbox CCI or via MCTP over I2C connected to the switch mctp CCI via an outer level

Re: [PATCH v2] hw/sd/sdhci: Block Size Register bits [14:12] is lost

2023-09-25 Thread Philippe Mathieu-Daudé
On 22/9/23 04:03, Lu Gao wrote: Block Size Register bits [14:12] is SDMA Buffer Boundary, it is missed in register write, but it is needed in SDMA transfer. e.g. it will be used in sdhci_sdma_transfer_multi_blocks to calculate boundary_ variables. Missing this field will cause wrong operation fo

Re: [PATCH 04/31] docs: mark CRIS support as deprecated

2023-09-25 Thread Daniel P . Berrangé
On Mon, Sep 25, 2023 at 03:48:27PM +0100, Alex Bennée wrote: > This might be premature but while streamling the avocado tests I > realised the only tests we have are "check-tcg" ones. The aging > fedora-criss-cross image works well enough for developers but can't be > used in CI as we need supporte

Re: [PATCH 0/4] aspeed: Clean up local variable shadowing

2023-09-25 Thread Cédric Le Goater
On 9/23/23 09:13, Markus Armbruster wrote: Cédric Le Goater writes: On 9/22/23 20:20, Philippe Mathieu-Daudé wrote: On 22/9/23 17:59, Cédric Le Goater wrote: Hello, Here are cleanups for local variable shadowing warnings in aspeed models. Joel, Andrew, Could you please double check patch

Re: [PATCH 04/31] docs: mark CRIS support as deprecated

2023-09-25 Thread Daniel P . Berrangé
On Mon, Sep 25, 2023 at 03:48:27PM +0100, Alex Bennée wrote: > This might be premature but while streamling the avocado tests I > realised the only tests we have are "check-tcg" ones. The aging > fedora-criss-cross image works well enough for developers but can't be > used in CI as we need supporte

Re: Help wanted for enabling -Wshadow=local

2023-09-25 Thread Warner Losh
On Sat, Sep 23, 2023 at 6:33 AM Peter Maydell wrote: > On Fri, 22 Sept 2023 at 19:59, Warner Losh wrote: > > The third one, though, makes me ask the question: When should we > > pass in cpu_env to functions and when should we use the global value? > > > > I have a lot of changes that look like:

Re: [PATCH v2 13/15] hw/qdev: Remove DEFINE_PROP_DMAADDR() and 'hw/qdev-dma.h'

2023-09-25 Thread Paolo Bonzini
On 9/25/23 13:03, Markus Armbruster wrote: +David Markus Armbruster writes: Philippe Mathieu-Daudé writes: DEFINE_PROP_DMAADDR() is only used once. Since it doesn't add much value, simply remove it, along with the header defining it. Signed-off-by: Philippe Mathieu-Daudé DEFINE_PROP_DM

Re: [PATCH 08/31] configure: ensure dependency for cross-compile setup

2023-09-25 Thread Alex Bennée
Paolo Bonzini writes: > On 9/25/23 16:48, Alex Bennée wrote: >> If we update configure we should make sure we regenerate all the >> compiler details. We should also ensure those details are upto date >> before building the TCG tests. >> Signed-off-by: Alex Bennée >> --- >> configure | 2 ++ >

Re: [PATCH 00/19] QEMU: CXL mailbox rework and features

2023-09-25 Thread Jonathan Cameron via
On Mon, 25 Sep 2023 17:11:05 +0100 Jonathan Cameron wrote: > Based on: [PATCH] hw/cxl: Fix local variable shadowing of cap_hdrs > Based on: [PATCH v2 0/3] hw/cxl: Add dummy ACPI QTG DSM Missed one. Based on: [PATCH v4 0/4] hw/cxl: Support emulating 4 HDM decoders throughout topology > Based on

Re: [PATCH 04/31] docs: mark CRIS support as deprecated

2023-09-25 Thread Alex Bennée
Daniel P. Berrangé writes: > On Mon, Sep 25, 2023 at 03:48:27PM +0100, Alex Bennée wrote: >> This might be premature but while streamling the avocado tests I >> realised the only tests we have are "check-tcg" ones. The aging >> fedora-criss-cross image works well enough for developers but can't

Re: [PATCH v1 3/4] hw/arm/virt-acpi-build: patch guest SRAT for NUMA nodes

2023-09-25 Thread Jonathan Cameron via
On Mon, 25 Sep 2023 13:00:43 -0300 Jason Gunthorpe wrote: > On Mon, Sep 25, 2023 at 03:53:51PM +0100, Jonathan Cameron wrote: > > On Mon, 25 Sep 2023 11:03:28 -0300 > > Jason Gunthorpe wrote: > > > > > On Mon, Sep 25, 2023 at 02:54:40PM +0100, Jonathan Cameron wrote: > > > > > > > Possible

Re: [PATCH 04/31] docs: mark CRIS support as deprecated

2023-09-25 Thread Alex Bennée
Alex Bennée writes: > This might be premature but while streamling the avocado tests I > realised the only tests we have are "check-tcg" ones. The aging > fedora-criss-cross image works well enough for developers but can't be > used in CI as we need supported build platforms to build QEMU. > >

Re: [PATCH v2 01/20] q800-glue.c: convert to Resettable interface

2023-09-25 Thread Laurent Vivier
Le 09/09/2023 à 11:48, Mark Cave-Ayland a écrit : Convert the GLUE device to 3-phase reset. The legacy method doesn't do anything that's invalid in the hold phase, so the conversion is simple and not a behaviour change. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé ---

Re: [PATCH 08/31] configure: ensure dependency for cross-compile setup

2023-09-25 Thread Paolo Bonzini
Il lun 25 set 2023, 18:45 Alex Bennée ha scritto: > Paolo Bonzini writes: > > On 9/25/23 16:48, Alex Bennée wrote: > >> echo "HOST_GDB_SUPPORTS_ARCH=y" >> "$config_target_mak" > >> fi > >> + echo "$config_target_mak: configure" >> Makefile.prereqs > > > > This in pract

Re: [PATCH 08/31] configure: ensure dependency for cross-compile setup

2023-09-25 Thread Peter Maydell
On Mon, 25 Sept 2023 at 17:45, Alex Bennée wrote: > > > Paolo Bonzini writes: > > > On 9/25/23 16:48, Alex Bennée wrote: > >> If we update configure we should make sure we regenerate all the > >> compiler details. We should also ensure those details are upto date > >> before building the TCG test

Re: [PATCH v7 6/7] qapi: Add HV_BALLOON_STATUS_REPORT event and its QMP query command

2023-09-25 Thread Maciej S. Szmigiero
On 25.09.2023 13:49, Markus Armbruster wrote: "Maciej S. Szmigiero" writes: From: "Maciej S. Szmigiero" Used by the hv-balloon driver for (optional) guest memory status reports. Signed-off-by: Maciej S. Szmigiero [...] static void hv_balloon_handle_unballoon_response(HvBalloon *ballo

[PATCH RFC V2 00/37] Support of Virtual CPU Hotplug for ARMv8 Arch

2023-09-25 Thread Salil Mehta via
PROLOGUE To assist in review and set the right expectations from this RFC, please first read below sections *APPENDED AT THE END* of this cover letter, 1. Important *DISCLAIMER* [Section (X)] 2. Work presented at KVMForum Conference (slides available) [Section (V)F] 3. Organization of pa

RE: [PATCH RFC V2 00/37] Support of Virtual CPU Hotplug for ARMv8 Arch

2023-09-25 Thread Salil Mehta via
Hello, Please ignore this series. Forgot to add RFC V2 Tag in all of the patches. Will send again shortly. Sorry for inconvenience. Thanks Salil. > From: Salil Mehta > Sent: Monday, September 25, 2023 6:12 PM > To: qemu-devel@nongnu.org; qemu-...@nongnu.org > Cc: Salil Mehta ; m...@kernel.org;

Re: [PATCH 04/31] docs: mark CRIS support as deprecated

2023-09-25 Thread Edgar E. Iglesias
On Mon, Sep 25, 2023 at 7:00 PM Alex Bennée wrote: > > Daniel P. Berrangé writes: > > > On Mon, Sep 25, 2023 at 03:48:27PM +0100, Alex Bennée wrote: > >> This might be premature but while streamling the avocado tests I > >> realised the only tests we have are "check-tcg" ones. The aging > >> fed

Re: [PATCH v23 01/20] CPU topology: extend with s390 specifics

2023-09-25 Thread Markus Armbruster
Nina Schoetterl-Glausch writes: > On Tue, 2023-09-19 at 14:47 +0200, Markus Armbruster wrote: >> Nina Schoetterl-Glausch writes: >> >> > From: Pierre Morel >> > >> > S390 adds two new SMP levels, drawers and books to the CPU >> > topology. >> > S390 CPUs have specific topology features like d

Re: [PATCH v2 08/20] asc: generate silence if FIFO empty but engine still running

2023-09-25 Thread Laurent Vivier
Le 09/09/2023 à 11:48, Mark Cave-Ayland a écrit : MacOS (un)helpfully leaves the FIFO engine running even when all the samples have been written to the hardware, and expects the FIFO status flags and IRQ to be updated continuously. There is an additional problem in that not all audio backends g

[PATCH v3 0/4] Add BHRB Facility Support

2023-09-25 Thread Glenn Miles
This is a series of patches for adding support for the Branch History Rolling Buffer (BHRB) facility. This was added to the Power ISA starting with version 2.07. Changes were subsequently made in version 3.1 to limit BHRB recording to instructions run in problem state only and to add a control bi

[PATCH v3 1/4] target/ppc: Add new hflags to support BHRB

2023-09-25 Thread Glenn Miles
This commit is preparatory to the addition of Branch History Rolling Buffer (BHRB) functionality, which is being provided today starting with the P8 processor. BHRB uses several SPR register fields to control whether or not a branch instruction's address (and sometimes target address) should be re

  1   2   3   4   >