Re: mips system emulation failure with virtio

2023-09-05 Thread Richard Purdie
On Tue, 2023-09-05 at 14:59 +0100, Alex Bennée wrote: > Richard Purdie writes: > > > With qemu 8.1.0 we see boot hangs fox x86-64 targets.  > > > > These are fixed by 0d58c660689f6da1e3feff8a997014003d928b3b (softmmu: > > Use async_run_on_cpu in tcg_commit) but if I add that commit, mips and > >

[PATCH 1/2] vmstate: Mark VMStateInfo.get/put() coroutine_mixed_fn

2023-09-05 Thread Kevin Wolf
Migration code can run both in coroutine context (the usual case) and non-coroutine context (at least savevm/loadvm for snapshots). This also affects the VMState callbacks, and devices must consider this. Change the callback definition in VMStateInfo to be explicit about it. Signed-off-by: Kevin W

[PATCH 0/2] virtio: Drop out of coroutine context in virtio_load()

2023-09-05 Thread Kevin Wolf
This fixes a recently introduced assertion failure that was reported to happen when migrating virtio-net with a failover. The latent bug that we're executing code in coroutine context that was never supposed to run there has existed for a long time. However, the new assertion that callers of bdrv_g

[PATCH] hw/i386: Rename kvmvapic.c -> vapic.c

2023-09-05 Thread Philippe Mathieu-Daudé
vAPIC isn't KVM specific, so having its name prefixed 'kvm' is misleading. Rename it simply 'vapic'. Rename the single function prefixed 'kvm'. Signed-off-by: Philippe Mathieu-Daudé --- Interestingly there is a strong dependency on (Kconfig) APIC, but I couldn't get a single x86 machine building

[PATCH] hw/intc/arm_gicv3: Simplify gicv3_class_name() logic

2023-09-05 Thread Philippe Mathieu-Daudé
Simplify gicv3_class_name() logic. No functional change intended. Signed-off-by: Philippe Mathieu-Daudé --- hw/intc/arm_gicv3_common.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/intc/arm_gicv3_common.c b/hw/intc/arm_gicv3_common.c index 2ebf880ead..8863f06b67

Re: [PATCH 1/2] hw/cxl: Add utility functions decoder interleave ways and target count.

2023-09-05 Thread Jonathan Cameron via
On Mon, 4 Sep 2023 20:26:59 +0200 Philippe Mathieu-Daudé wrote: > On 4/9/23 18:47, Jonathan Cameron wrote: > > As an encoded version of these key configuration parameters is > > a register, provide functions to extract it again so as to avoid > > the need for duplicating the storage. > > > > Sig

Re: [PATCH v2 2/2] i386: Fix MCE support for AMD hosts

2023-09-05 Thread John Allen via
On Thu, Aug 31, 2023 at 11:54:56PM +0200, William Roche wrote: > John, > > I also noticed something important about this specific code: > > Qemu commit cb48748af7dfd7654323eb839d1f853ffa873652 introduced the use of > the MCG_STATUS_RIPV in the case of a BUS_MCEERR_AR error, but it looks like > yo

PCI Hotplug ACPI device names only 3 characters long

2023-09-05 Thread Marcello Sylverster Bauer
Greetings, I'm currently working on a project to support Intel IPU6 in QEMU via VFIO so that the guest system can access the camera. This requires extending the ACPI device definition so that the guest knows how to access the camera. However, I cannot extend the PCI devices because their nam

Re: [PATCH v2 1/2] i386: Add support for SUCCOR feature

2023-09-05 Thread John Allen
On Fri, Sep 01, 2023 at 11:30:53AM +0100, Joao Martins wrote: > On 26/07/2023 21:41, John Allen wrote: > > Add cpuid bit definition for the SUCCOR feature. This cpuid bit is required > > to > > be exposed to guests to allow them to handle machine check exceptions on AMD > > hosts. > > > > Reporte

Re: [PATCH 1/2] hw/cxl: Add utility functions decoder interleave ways and target count.

2023-09-05 Thread Jonathan Cameron via
On Tue, 5 Sep 2023 15:56:39 +0100 Jonathan Cameron via wrote: > On Mon, 4 Sep 2023 20:26:59 +0200 > Philippe Mathieu-Daudé wrote: > > > On 4/9/23 18:47, Jonathan Cameron wrote: > > > As an encoded version of these key configuration parameters is > > > a register, provide functions to extract

Re: [PATCH 1/2] vmstate: Mark VMStateInfo.get/put() coroutine_mixed_fn

2023-09-05 Thread Peter Xu
On Tue, Sep 05, 2023 at 04:50:01PM +0200, Kevin Wolf wrote: > Migration code can run both in coroutine context (the usual case) and > non-coroutine context (at least savevm/loadvm for snapshots). This also > affects the VMState callbacks, and devices must consider this. Change > the callback defini

Re: PCI Hotplug ACPI device names only 3 characters long

2023-09-05 Thread Philippe Mathieu-Daudé
Hi Marcello, On 5/9/23 17:05, Marcello Sylverster Bauer wrote: Greetings, I'm currently working on a project to support Intel IPU6 in QEMU via VFIO so that the guest system can access the camera. This requires extending the ACPI device definition so that the guest knows how to access the cam

Re: [PATCH for-8.1] vfio/display: Fix missing update to set backing fields

2023-09-05 Thread Alex Williamson
On Mon, 4 Sep 2023 21:00:53 +0400 Marc-André Lureau wrote: > Hi > > On Mon, Sep 4, 2023 at 6:11 PM Alex Williamson > wrote: > > > > On Mon, 4 Sep 2023 15:06:21 +0400 > > Marc-André Lureau wrote: > > > > > Hi > > > > > > On Thu, Aug 17, 2023 at 8:29 PM Kim, Dongwon > > > wrote: > > > > >

Re: mips system emulation failure with virtio

2023-09-05 Thread Philippe Mathieu-Daudé
Hi Richard, On 5/9/23 16:50, Richard Purdie wrote: On Tue, 2023-09-05 at 14:59 +0100, Alex Bennée wrote: Richard Purdie writes: With qemu 8.1.0 we see boot hangs fox x86-64 targets. These are fixed by 0d58c660689f6da1e3feff8a997014003d928b3b (softmmu: Use async_run_on_cpu in tcg_commit) but

Re: [PATCH v2 0/2] Fix MCE handling on AMD hosts

2023-09-05 Thread John Allen via
On Thu, Aug 31, 2023 at 11:40:08PM +0200, William Roche wrote: > Hello John, > > I could test your fixes and I can confirm that the BUS_MCEERR_AR is now > working on AMD: > > Before the fix, the VM panics with: > > qemu-system-x86_64: Guest MCE Memory Error at QEMU addr 0x7f89573ce000 and > GUES

Re: PCI Hotplug ACPI device names only 3 characters long

2023-09-05 Thread Marcello Sylverster Bauer
Hi Philippe, On 9/5/23 17:09, Philippe Mathieu-Daudé wrote: Hi Marcello, On 5/9/23 17:05, Marcello Sylverster Bauer wrote: Greetings, I'm currently working on a project to support Intel IPU6 in QEMU via VFIO so that the guest system can access the camera. This requires extending the ACPI de

Re: [PATCH v22 03/20] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-09-05 Thread Nina Schoetterl-Glausch
On Tue, 2023-09-05 at 15:26 +0200, Thomas Huth wrote: > On 01/09/2023 17.57, Nina Schoetterl-Glausch wrote: > > From: Pierre Morel > > > > On interception of STSI(15.1.x) the System Information Block > > (SYSIB) is built from the list of pre-ordered topology entries. > > > > Signed-off-by: Pierr

Re: [PATCH 17/21] block: Take graph rdlock in bdrv_drop_intermediate()

2023-09-05 Thread Kevin Wolf
Am 22.08.2023 um 21:35 hat Stefan Hajnoczi geschrieben: > On Thu, Aug 17, 2023 at 02:50:16PM +0200, Kevin Wolf wrote: > > The function reads the parents list, so it needs to hold the graph lock. > > > > Signed-off-by: Kevin Wolf > > --- > > block.c | 2 ++ > > 1 file changed, 2 insertions(+) > >

Re: [PATCH for-8.2 v2 2/2] migration: Allow user to specify migration switchover bandwidth

2023-09-05 Thread Peter Xu
On Fri, Sep 01, 2023 at 07:39:07PM +0100, Joao Martins wrote: > > > On 01/09/2023 18:59, Joao Martins wrote: > > On 03/08/2023 16:53, Peter Xu wrote: > >> @@ -2694,7 +2694,17 @@ static void > >> migration_update_counters(MigrationState *s, > >> transferred = current_bytes - s->iteration_ini

Re: [PATCH v5 8/8] migration: Add a wrapper to cleanup migration files

2023-09-05 Thread Peter Xu
On Fri, Sep 01, 2023 at 03:29:51PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Thu, Aug 31, 2023 at 03:39:16PM -0300, Fabiano Rosas wrote: > >> @@ -1166,16 +1183,9 @@ static void migrate_fd_cleanup(MigrationState *s) > >> qemu_mutex_lock_iothread(); > >> > >> multi

Re: [PULL v2 00/40] Misc patches for 2023-08-31

2023-09-05 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH 2/2] hw/cxl: Support 4 HDM decoders at all levels of topology

2023-09-05 Thread Jonathan Cameron via
On Mon, 4 Sep 2023 20:36:02 +0200 Philippe Mathieu-Daudé wrote: > Hi Jonathan, > > Few style comments inlined. > > On 4/9/23 18:47, Jonathan Cameron wrote: > > Support these decoders in CXL host bridges (pxb-cxl), CXL Switch USP > > and CXL Type 3 end points. > > > > Signed-off-by: Jonathan Ca

Re: [PULL 0/7] s390x and qtest patches

2023-09-05 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] iothread: Set the GSource "name" field

2023-09-05 Thread Peter Xu
On Mon, Sep 04, 2023 at 11:48:11AM -0300, Fabiano Rosas wrote: > @@ -189,11 +193,14 @@ static void iothread_init(EventLoopBase *base, Error > **errp) > return; > } > > +thread_name = g_strdup_printf("IO %s", > +object_get_canonical_path_component(OBJECT(

Re: [PATCH v2 21/22] softmmu/memory: Clean up local variable shadowing

2023-09-05 Thread Peter Xu
On Mon, Sep 04, 2023 at 06:12:33PM +0200, Philippe Mathieu-Daudé wrote: > Fix: > > softmmu/memory.c: In function ‘mtree_print_mr’: > softmmu/memory.c:3236:27: warning: declaration of ‘ml’ shadows a previous > local [-Wshadow=compatible-local] >3236 | MemoryRegionList *ml; >

Re: [RFC PATCH v2 22/22] softmmu/physmem: Clean up local variable shadowing

2023-09-05 Thread Peter Xu
On Mon, Sep 04, 2023 at 05:31:30PM +0100, Daniel P. Berrangé wrote: > On Mon, Sep 04, 2023 at 06:12:34PM +0200, Philippe Mathieu-Daudé wrote: > > Fix: > > > > softmmu/physmem.c: In function > > ‘cpu_physical_memory_snapshot_and_clear_dirty’: > > softmmu/physmem.c:916:27: warning: declaration

Re: mips system emulation failure with virtio

2023-09-05 Thread Richard Purdie
On Tue, 2023-09-05 at 17:12 +0200, Philippe Mathieu-Daudé wrote: > Hi Richard, > > On 5/9/23 16:50, Richard Purdie wrote: > > On Tue, 2023-09-05 at 14:59 +0100, Alex Bennée wrote: > > > Richard Purdie writes: > > > > > > > With qemu 8.1.0 we see boot hangs fox x86-64 targets. > > > > > > > > Th

Re: [PATCH v2 3/5] migration: Add .save_prepare() handler to struct SaveVMHandlers

2023-09-05 Thread Cédric Le Goater
On 9/1/23 17:49, Peter Xu wrote: On Thu, Aug 31, 2023 at 03:57:00PM +0300, Avihai Horon wrote: Add a new .save_prepare() handler to struct SaveVMHandlers. This handler is called early, even before migration starts, and can be used by devices to perform early checks. Suggested-by: Peter Xu Sign

Re: [PATCH] hw/pci-bridge/cxl-upstream: Add serial number extended capability support

2023-09-05 Thread Jonathan Cameron via
On Tue, 5 Sep 2023 05:02:47 -0400 "Michael S. Tsirkin" wrote: > On Tue, Sep 05, 2023 at 10:48:54AM +0200, Philippe Mathieu-Daudé wrote: > > Hi Jonathan, > > > > On 4/9/23 19:57, Jonathan Cameron wrote: > > > Will be needed so there is a defined serial number for > > > information queries via t

Re: [PATCH] hw/pci-bridge/cxl-upstream: Add serial number extended capability support

2023-09-05 Thread Jonathan Cameron via
On Tue, 5 Sep 2023 10:48:54 +0200 Philippe Mathieu-Daudé wrote: > Hi Jonathan, > > On 4/9/23 19:57, Jonathan Cameron wrote: > > Will be needed so there is a defined serial number for > > information queries via the Switch CCI. > > > > Signed-off-by: Jonathan Cameron > > --- > > No ordering dep

[PATCH v3 2/4] tests/migration-test: Add a test for null parameter setups

2023-09-05 Thread Peter Xu
Add a test for StrOrNull parameters (tls-*). Reviewed-by: Fabiano Rosas Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Peter Xu --- tests/qtest/migration-test.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-

[PATCH v3 4/4] migration/qapi: Drop @MigrationParameter enum

2023-09-05 Thread Peter Xu
Drop the enum in qapi because it is never used in QMP APIs. Instead making it an internal definition for QEMU so that we can decouple it from QAPI, and also we can deduplicate the QAPI documentations. Reviewed-by: Daniel P. Berrangé Signed-off-by: Peter Xu --- qapi/migration.json|

[PATCH v3 3/4] migration/qapi: Replace @MigrateSetParameters with @MigrationParameters

2023-09-05 Thread Peter Xu
Quotting from Markus in his replies: migrate-set-parameters sets migration parameters, and query-migrate-parameters gets them. Unsurprisingly, the former's argument type MigrateSetParameters is quite close to the latter's return type MigrationParameters. The differences are subtle: 1.

[PATCH v3 0/4] qapi/migration: Dedup migration parameter objects and fix tls-authz crash

2023-09-05 Thread Peter Xu
v3: - Collected R-bs - Patch 2: some reindents, use ARRAY_SIZE (Thomas) v2: - Collected R-bs - Patch 3: convert to use StrOrNull rather than str for the tls_fields (it contains a lot of changes, I'll skip listing details, but please refer to the commit message) Patch 1 fixes the tls-authz cr

[PATCH v3 1/4] migration/qmp: Fix crash on setting tls-authz with null

2023-09-05 Thread Peter Xu
QEMU will crash if anyone tries to set tls-authz (which is a type StrOrNull) with 'null' value. Fix it in the easy way by converting it to qstring just like the other two tls parameters. Cc: qemu-sta...@nongnu.org # v4.0+ Fixes: d2f1d29b95 ("migration: add support for a "tls-authz" migration par

Re: [PATCH] docs/devel/loads-stores: Fix git grep regexes

2023-09-05 Thread Peter Maydell
On Tue, 5 Sept 2023 at 15:31, Eric Blake wrote: > > On Mon, Sep 04, 2023 at 05:17:03PM +0100, Peter Maydell wrote: > > The loads-and-stores documentation includes git grep regexes to find > > occurrences of the various functions. Some of these regexes have > > errors, typically failing to escape

Re: [PATCH 05/21] block: Introduce bdrv_schedule_unref()

2023-09-05 Thread Kevin Wolf
Am 22.08.2023 um 21:01 hat Stefan Hajnoczi geschrieben: > On Thu, Aug 17, 2023 at 02:50:04PM +0200, Kevin Wolf wrote: > > bdrv_unref() is called by a lot of places that need to hold the graph > > lock (it naturally happens in the context of operations that change the > > graph). However, bdrv_unref

Re: PCI Hotplug ACPI device names only 3 characters long

2023-09-05 Thread Michael S. Tsirkin
On Tue, Sep 05, 2023 at 05:05:33PM +0200, Marcello Sylverster Bauer wrote: > Greetings, > > I'm currently working on a project to support Intel IPU6 in QEMU via VFIO so > that the guest system can access the camera. This requires extending the > ACPI device definition so that the guest knows how t

Re: [PATCH for-8.2 v2 2/2] migration: Allow user to specify migration switchover bandwidth

2023-09-05 Thread Peter Xu
On Fri, Sep 01, 2023 at 09:37:32AM +0100, Daniel P. Berrangé wrote: > > > When the user wants to have migration only use 5Gbps out of that 10Gbps, > > > one can set max-bandwidth to 5Gbps, along with max-switchover-bandwidth to > > > 5Gbps so it'll never use over 5Gbps too (so the user can have the

Re: mips system emulation failure with virtio

2023-09-05 Thread Philippe Mathieu-Daudé
On 5/9/23 17:53, Richard Purdie wrote: On Tue, 2023-09-05 at 17:12 +0200, Philippe Mathieu-Daudé wrote: Hi Richard, On 5/9/23 16:50, Richard Purdie wrote: On Tue, 2023-09-05 at 14:59 +0100, Alex Bennée wrote: Richard Purdie writes: With qemu 8.1.0 we see boot hangs fox x86-64 targets. The

Re: [PATCH] iothread: Set the GSource "name" field

2023-09-05 Thread Philippe Mathieu-Daudé
On 5/9/23 17:45, Peter Xu wrote: On Mon, Sep 04, 2023 at 11:48:11AM -0300, Fabiano Rosas wrote: @@ -189,11 +193,14 @@ static void iothread_init(EventLoopBase *base, Error **errp) return; } +thread_name = g_strdup_printf("IO %s", +object_get_canoni

Re: mips system emulation failure with virtio

2023-09-05 Thread Richard Purdie
On Tue, 2023-09-05 at 18:46 +0200, Philippe Mathieu-Daudé wrote: > On 5/9/23 17:53, Richard Purdie wrote: > > On Tue, 2023-09-05 at 17:12 +0200, Philippe Mathieu-Daudé wrote: > > > Hi Richard, > > > > > > On 5/9/23 16:50, Richard Purdie wrote: > > > > On Tue, 2023-09-05 at 14:59 +0100, Alex Bennée

Re: [PATCH 1/2] hw/cxl: Add utility functions decoder interleave ways and target count.

2023-09-05 Thread Philippe Mathieu-Daudé
On 5/9/23 17:06, Jonathan Cameron wrote: On Tue, 5 Sep 2023 15:56:39 +0100 Jonathan Cameron via wrote: On Mon, 4 Sep 2023 20:26:59 +0200 Philippe Mathieu-Daudé wrote: On 4/9/23 18:47, Jonathan Cameron wrote: As an encoded version of these key configuration parameters is a register, provide

Re: [PATCH v3 07/20] virtio: add vhost-user-base and a generic vhost-user-device

2023-09-05 Thread Alex Bennée
Matias Ezequiel Vara Larsen writes: > On Mon, Jul 10, 2023 at 04:35:09PM +0100, Alex Bennée wrote: >> In theory we shouldn't need to repeat so much boilerplate to support >> vhost-user backends. This provides a generic vhost-user-base QOM >> object and a derived vhost-user-device for which the

Re: [PATCH] hw/intc/arm_gicv3: Simplify gicv3_class_name() logic

2023-09-05 Thread Richard Henderson
On 9/5/23 07:56, Philippe Mathieu-Daudé wrote: Simplify gicv3_class_name() logic. No functional change intended. Signed-off-by: Philippe Mathieu-Daudé --- hw/intc/arm_gicv3_common.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v5 8/8] migration: Add a wrapper to cleanup migration files

2023-09-05 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Sep 01, 2023 at 03:29:51PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Thu, Aug 31, 2023 at 03:39:16PM -0300, Fabiano Rosas wrote: >> >> @@ -1166,16 +1183,9 @@ static void migrate_fd_cleanup(MigrationState *s) >> >> qemu_mutex_lock_iothread();

Re: [PATCH for-8.2 v2 2/2] migration: Allow user to specify migration switchover bandwidth

2023-09-05 Thread Daniel P . Berrangé
On Tue, Sep 05, 2023 at 12:46:03PM -0400, Peter Xu wrote: > On Fri, Sep 01, 2023 at 09:37:32AM +0100, Daniel P. Berrangé wrote: > > > > When the user wants to have migration only use 5Gbps out of that 10Gbps, > > > > one can set max-bandwidth to 5Gbps, along with max-switchover-bandwidth > > > > t

Re: PCI Hotplug ACPI device names only 3 characters long

2023-09-05 Thread Marcello Sylverster Bauer
Hi Michael, On 9/5/23 18:44, Michael S. Tsirkin wrote: On Tue, Sep 05, 2023 at 05:05:33PM +0200, Marcello Sylverster Bauer wrote: Greetings, I'm currently working on a project to support Intel IPU6 in QEMU via VFIO so that the guest system can access the camera. This requires extending the ACP

[PATCH v2] iothread: Set the GSource "name" field

2023-09-05 Thread Fabiano Rosas
Having a name in the source helps with debugging core dumps when one might not have access to TLS data to cross-reference AioContexts with their addresses. Signed-off-by: Fabiano Rosas --- v2: used g_autofree where appropriate --- iothread.c | 14 -- 1 file changed, 8 insertions(+),

Re: [PATCH] iothread: Set the GSource "name" field

2023-09-05 Thread Stefan Hajnoczi
On Tue, 5 Sept 2023 at 12:51, Philippe Mathieu-Daudé wrote: > > On 5/9/23 17:45, Peter Xu wrote: > > On Mon, Sep 04, 2023 at 11:48:11AM -0300, Fabiano Rosas wrote: > >> @@ -189,11 +193,14 @@ static void iothread_init(EventLoopBase *base, Error > >> **errp) > >> return; > >> } > >>

Re: [PATCH 00/13] VIRTIO-IOMMU/VFIO: Don't assume 64b IOVA space

2023-09-05 Thread Alex Williamson
On Mon, 4 Sep 2023 10:03:43 +0200 Eric Auger wrote: > On x86, when assigning VFIO-PCI devices protected with virtio-iommu > we encounter the case where the guest tries to map IOVAs beyond 48b > whereas the physical VTD IOMMU only supports 48b. This ends up with > VFIO_MAP_DMA failures at qemu le

[PATCH v3] iothread: Set the GSource "name" field

2023-09-05 Thread Fabiano Rosas
Having a name in the source helps with debugging core dumps when one might not have access to TLS data to cross-reference AioContexts with their addresses. Signed-off-by: Fabiano Rosas --- v3: used const v2: used g_autofree where appropriate --- iothread.c | 14 -- 1 file changed, 8

Re: [PATCH v3] iothread: Set the GSource "name" field

2023-09-05 Thread Philippe Mathieu-Daudé
On 5/9/23 20:03, Fabiano Rosas wrote: Having a name in the source helps with debugging core dumps when one might not have access to TLS data to cross-reference AioContexts with their addresses. Signed-off-by: Fabiano Rosas --- v3: used const v2: used g_autofree where appropriate --- iothread.

[PATCH v3 0/1] migration: Add avail-switchover-bandwidth parameter

2023-09-05 Thread Peter Xu
This single-patch series is based on: [PATCH v3 0/4] qapi/migration: Dedup migration parameter objects and fix tls-authz crash Based-on: <20230905162335.235619-1-pet...@redhat.com> I still added a cover letter to make sure the "Based-on" will be parsed all right for e.g. patchew. v3: - Rebased

[PATCH v3 1/1] migration: Allow user to specify available switchover bandwidth

2023-09-05 Thread Peter Xu
Migration bandwidth is a very important value to live migration. It's because it's one of the major factors that we'll make decision on when to switchover to destination in a precopy process. This value is currently estimated by QEMU during the whole live migration process by monitoring how fast

[PATCH v1 5/7] qapi: fix example of set-vcpu-dirty-limit command

2023-09-05 Thread Victor Toso
Example output has extra end curly bracket. Remove it. Signed-off-by: Victor Toso --- qapi/migration.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/migration.json b/qapi/migration.json index 9385b9f87c..2658cdbcbe 100644 --- a/qapi/migration.json +++ b/qapi/migrati

[PATCH v1 3/7] qapi: fix example of dumpdtb command

2023-09-05 Thread Victor Toso
Example output has extra end curly bracket. Switch with comma. Signed-off-by: Victor Toso --- qapi/machine.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/machine.json b/qapi/machine.json index a08b6576ca..9eb76193e0 100644 --- a/qapi/machine.json +++ b/qapi/machine

[PATCH v1 6/7] qapi: fix example of calc-dirty-rate command

2023-09-05 Thread Victor Toso
Example output has property name with single quotes. Fix it. Signed-off-by: Victor Toso --- qapi/migration.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/migration.json b/qapi/migration.json index 2658cdbcbe..45dac41f67 100644 --- a/qapi/migration.json +++ b/qapi/m

[PATCH v1 0/7] Validate and test qapi examples

2023-09-05 Thread Victor Toso
Hi, This is a follow up from the RFC sent in the end of 08-2022: https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg04525.html The generator code was rebased, without conflicts. The commit log was improved as per Markus suggestion [0], altough I'm sure it can be improved further. To cl

[PATCH v1 2/7] qapi: fix example of get-win32-socket command

2023-09-05 Thread Victor Toso
Example output lacks double quotes. Fix it. Fixes: 4cda177c60 "qmp: add 'get-win32-socket'" Signed-off-by: Victor Toso --- qapi/misc.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/misc.json b/qapi/misc.json index cda2effa81..be302cadeb 100644 --- a/qapi/misc.json +

[PATCH v1 1/7] qapi: scripts: add a generator for qapi's examples

2023-09-05 Thread Victor Toso
This generator has two goals: 1. Mechanical validation of QAPI examples 2. Generate the examples in a JSON format to be consumed for extra validation. The generator iterates over every Example section, parsing both server and client messages. The generator prints any inconsistency found, for

[PATCH v1 7/7] qapi: fix example of NETDEV_STREAM_CONNECTED event

2023-09-05 Thread Victor Toso
Example output was using single quotes. Fix it. Signed-off-by: Victor Toso --- qapi/net.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qapi/net.json b/qapi/net.json index 313c8a606e..81988e499a 100644 --- a/qapi/net.json +++ b/qapi/net.json @@ -930,9 +930,9 @@ #

[PATCH v1 4/7] qapi: fix example of cancel-vcpu-dirty-limit command

2023-09-05 Thread Victor Toso
Example output has extra end curly bracket. Remove it. Signed-off-by: Victor Toso --- qapi/migration.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/migration.json b/qapi/migration.json index 8843e74b59..9385b9f87c 100644 --- a/qapi/migration.json +++ b/qapi/migrati

Re: [PATCH 65/67] ppc/kconfig: make SAM460EX depend on PPC & PIXMAN

2023-09-05 Thread Marc-André Lureau
Hi On Wed, Aug 30, 2023 at 4:35 PM BALATON Zoltan wrote: > > On Wed, 30 Aug 2023, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > SM501 is going to depend on PIXMAN next. > > Why is this patch needed when SM501 is the one that depends on PIXMAN and > should pull in the dep

[RFC Patch 3/5] hw/display: Allwinner A10 Display Engine Backend emulation

2023-09-05 Thread Strahinja Jankovic
This patch adds Display Engine Backend 0 (DEBE0) support. This peripheral will hold runtime configuration for the display size and framebuffer offset which will be used by other components. Signed-off-by: Strahinja Jankovic --- hw/arm/allwinner-a10.c | 9 + hw/display/allwinne

[RFC Patch 1/5] hw/display: Allwinner A10 HDMI controller emulation

2023-09-05 Thread Strahinja Jankovic
This patch adds basic Allwinner A10 HDMI controller support. Emulated HDMI component will always show that a display is connected and provide default EDID info. Signed-off-by: Strahinja Jankovic --- hw/arm/allwinner-a10.c | 7 + hw/display/allwinner-a10-hdmi.c | 214 ++

[RFC Patch 0/5] Allwinner A10 input/output peripherals

2023-09-05 Thread Strahinja Jankovic
This patch set adds minimal support for PS2 input and HDMI output for Allwinner A10 and Cubieboard. For the display part, minimal emulation of HDMI, MALI GPU, Display Engine Backend and LCD controller is added. For the PS2 both keyboard and mouse support is added and attached to the two PS2 conto

[RFC Patch 2/5] hw/display: Allwinner basic MALI GPU emulation

2023-09-05 Thread Strahinja Jankovic
This patch adds minimal MALI GPU emulation needed so emulated system thinks GPU is working. Signed-off-by: Strahinja Jankovic --- hw/arm/allwinner-a10.c | 7 + hw/display/allwinner-gpu.c | 212 + hw/display/meson.build | 3 +- hw/di

[RFC Patch 5/5] hw/input: Add Allwinner-A10 PS2 emulation

2023-09-05 Thread Strahinja Jankovic
Add emulation for PS2-0 and PS2-1 for keyboard/mouse. Signed-off-by: Strahinja Jankovic --- hw/arm/allwinner-a10.c | 18 ++ hw/input/allwinner-a10-ps2.c | 345 +++ hw/input/meson.build | 2 + include/hw/arm/allwinner-a10.h |

[RFC Patch 4/5] hw/display: Allwinner A10 LCDC emulation

2023-09-05 Thread Strahinja Jankovic
This patch adds support for Allwinner A10 LCD controller. Current emulation supports only RGB32 colorspace and interacts with DEBE0 to obtain framebuffer address and screen size. Signed-off-by: Strahinja Jankovic --- hw/arm/allwinner-a10.c | 10 + hw/display/allwinner-a10-lcdc.

Re: PCI Hotplug ACPI device names only 3 characters long

2023-09-05 Thread Michael S. Tsirkin
On Tue, Sep 05, 2023 at 07:45:12PM +0200, Marcello Sylverster Bauer wrote: > Hi Michael, > > On 9/5/23 18:44, Michael S. Tsirkin wrote: > > On Tue, Sep 05, 2023 at 05:05:33PM +0200, Marcello Sylverster Bauer wrote: > > > Greetings, > > > > > > I'm currently working on a project to support Intel I

Re: [PATCH v5 0/4] Virtio shared dma-buf

2023-09-05 Thread Michael S. Tsirkin
I was hoping for some acks from Gerd or anyone else with a clue about graphics, but as that doesn't seem to happen I'll merge. Thanks! On Mon, Aug 21, 2023 at 02:37:56PM +0200, Albert Esteve wrote: > Hi all, > > A little bump for this patch, sorry for the extra noise. > > Regards, > Albert > >

Re: [Qemu-devel] [PATCH] ahci: enable pci bus master MemoryRegion before loading ahci engines

2023-09-05 Thread Michael S. Tsirkin
On Tue, Sep 10, 2019 at 10:08:20AM -0400, John Snow wrote: > > > On 9/10/19 9:58 AM, Michael S. Tsirkin wrote: > > On Tue, Sep 10, 2019 at 09:50:41AM -0400, John Snow wrote: > >> > >> > >> On 9/10/19 3:04 AM, Michael S. Tsirkin wrote: > >>> On Tue, Sep 10, 2019 at 01:18:37AM +0800, andychiu wrote

Re: [PATCH v3] iothread: Set the GSource "name" field

2023-09-05 Thread Stefan Hajnoczi
On Tue, Sep 05, 2023 at 03:03:59PM -0300, Fabiano Rosas wrote: > Having a name in the source helps with debugging core dumps when one > might not have access to TLS data to cross-reference AioContexts with > their addresses. > > Signed-off-by: Fabiano Rosas > --- > v3: > used const > v2: > used g

Re: [PATCH v3] iothread: Set the GSource "name" field

2023-09-05 Thread Stefan Hajnoczi
On Tue, 5 Sept 2023 at 16:57, Stefan Hajnoczi wrote: > > On Tue, Sep 05, 2023 at 03:03:59PM -0300, Fabiano Rosas wrote: > > Having a name in the source helps with debugging core dumps when one > > might not have access to TLS data to cross-reference AioContexts with > > their addresses. > > > > Si

Re: [PATCH v13 0/9] rutabaga_gfx + gfxstream

2023-09-05 Thread Gurchetan Singh
On Wed, Aug 30, 2023 at 7:26 PM Huang Rui wrote: > On Tue, Aug 29, 2023 at 08:36:20AM +0800, Gurchetan Singh wrote: > > From: Gurchetan Singh > > > > Changes since v12: > > - Added r-b tags from Antonio Caggiano and Akihiko Odaki > > - Removed review version from commit messages > > - I think we

Re: [PATCH for-8.2 v2 2/2] migration: Allow user to specify migration switchover bandwidth

2023-09-05 Thread Wang, Lei
On 9/6/2023 0:46, Peter Xu wrote: > On Fri, Sep 01, 2023 at 09:37:32AM +0100, Daniel P. Berrangé wrote: When the user wants to have migration only use 5Gbps out of that 10Gbps, one can set max-bandwidth to 5Gbps, along with max-switchover-bandwidth to 5Gbps so it'll never use over 5G

[PATCH] hw/loongarch: Add virtio-mmio bus support

2023-09-05 Thread Tianrui Zhao
Add virtio-mmio bus support for LoongArch, so that devices could be added in the virtio-mmio bus. Signed-off-by: Tianrui Zhao --- hw/loongarch/Kconfig | 1 + hw/loongarch/virt.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/hw/loongarch/Kconfig b/hw/loongarch/Kconfig index 1e7c5b43c5.

Re: [PATCH] hw/loongarch: Add virtio-mmio bus support

2023-09-05 Thread bibo mao
在 2023/9/6 10:50, Tianrui Zhao 写道: > Add virtio-mmio bus support for LoongArch, so that devices > could be added in the virtio-mmio bus. > > Signed-off-by: Tianrui Zhao > --- > hw/loongarch/Kconfig | 1 + > hw/loongarch/virt.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/hw/

Re: [QEMU PATCH v4 09/13] virtio-gpu: Handle resource blob commands

2023-09-05 Thread Huang Rui
On Tue, Sep 05, 2023 at 05:20:43PM +0800, Akihiko Odaki wrote: > On 2023/09/05 18:08, Huang Rui wrote: > > On Thu, Aug 31, 2023 at 06:24:32PM +0800, Akihiko Odaki wrote: > >> On 2023/08/31 18:32, Huang Rui wrote: > >>> From: Antonio Caggiano > >>> > >>> Support BLOB resources creation, mapping and

Re: [QEMU PATCH v4 09/13] virtio-gpu: Handle resource blob commands

2023-09-05 Thread Akihiko Odaki
On 2023/09/06 12:09, Huang Rui wrote: On Tue, Sep 05, 2023 at 05:20:43PM +0800, Akihiko Odaki wrote: On 2023/09/05 18:08, Huang Rui wrote: On Thu, Aug 31, 2023 at 06:24:32PM +0800, Akihiko Odaki wrote: On 2023/08/31 18:32, Huang Rui wrote: From: Antonio Caggiano Support BLOB resources creat

Re: [PATCH 1/7] migration/rdma: Fix save_page method to fail on polling error

2023-09-05 Thread Zhijian Li (Fujitsu)
On 31/08/2023 21:25, Markus Armbruster wrote: > qemu_rdma_save_page() reports polling error with error_report(), then > succeeds anyway. This is because the variable holding the polling > status *shadows* the variable the function returns. The latter > remains zero. > > Broken since day one, a

Re: [PATCH v3 4/4] migration/qapi: Drop @MigrationParameter enum

2023-09-05 Thread Philippe Mathieu-Daudé
On 5/9/23 18:23, Peter Xu wrote: Drop the enum in qapi because it is never used in QMP APIs. Instead making it an internal definition for QEMU so that we can decouple it from QAPI, and also we can deduplicate the QAPI documentations. Reviewed-by: Daniel P. Berrangé Signed-off-by: Peter Xu ---

Re: [RFC Patch 1/5] hw/display: Allwinner A10 HDMI controller emulation

2023-09-05 Thread Philippe Mathieu-Daudé
Hi Strahinja, On 5/9/23 22:14, Strahinja Jankovic wrote: This patch adds basic Allwinner A10 HDMI controller support. Emulated HDMI component will always show that a display is connected and provide default EDID info. Signed-off-by: Strahinja Jankovic --- hw/arm/allwinner-a10.c

[PATCH RESEND 01/15] ppc: spapr: Introduce Nested PAPR API related macros

2023-09-05 Thread Harsh Prateek Bora
Adding new macros for the new hypercall op-codes, their return codes, Guest State Buffer (GSB) element IDs and few registers which shall be used in following patches to support Nested PAPR API. Signed-off-by: Michael Neuling Signed-off-by: Shivaprasad G Bhat Signed-off-by: Harsh Prateek Bora --

[PATCH RESEND 08/15] ppc: spapr: Implement nested PAPR hcall - H_GUEST_CREATE

2023-09-05 Thread Harsh Prateek Bora
This hcall is used by L1 to indicate to L0 that a new nested guest needs to be created and therefore necessary resource allocation shall be made. The L0 uses a hash table for nested guest specific resource management. This data structure is further utilized by other hcalls to operate on related mem

[PATCH RESEND 06/15] ppc: spapr: Implement nested PAPR hcall - H_GUEST_GET_CAPABILITIES

2023-09-05 Thread Harsh Prateek Bora
This patch implements nested PAPR hcall H_GUEST_GET_CAPABILITIES and also enables registration of nested PAPR hcalls whenever an L0 is launched with cap-nested-papr=true. The common registration routine shall be used by future patches for registration of related hcall support being added. This hcal

[PATCH RESEND 12/15] ppc: spapr: Use correct source for parttbl info for nested PAPR API.

2023-09-05 Thread Harsh Prateek Bora
For nested PAPR API, we use SpaprMachineStateNestedGuest struct to store partition table info. Therefore, use the same in spapr_get_pate() as well. Signed-off-by: Michael Neuling Signed-off-by: Harsh Prateek Bora --- hw/ppc/spapr.c | 14 ++ hw/ppc/spapr_nested.c | 1 - inc

[PATCH RESEND 02/15] ppc: spapr: Add new/extend structs to support Nested PAPR API

2023-09-05 Thread Harsh Prateek Bora
This patch introduces new data structures to be used with Nested PAPR API. Also extends kvmppc_hv_guest_state with additional set of registers supported with nested PAPR API. Signed-off-by: Michael Neuling Signed-off-by: Shivaprasad G Bhat Signed-off-by: Harsh Prateek Bora --- include/hw/ppc/s

[PATCH RESEND 07/15] ppc: spapr: Implement nested PAPR hcall - H_GUEST_SET_CAPABILITIES

2023-09-05 Thread Harsh Prateek Bora
This patch implements nested PAPR hcall H_GUEST_SET_CAPABILITIES. This is used by L1 to set capabilities of the nested guest being created. The capabilities being set are subset of the capabilities returned from the previous call to H_GUEST_GET_CAPABILITIES hcall. Currently, it only supports P9/P10

[PATCH RESEND 14/15] ppc: spapr: Implement nested PAPR hcall - H_GUEST_DELETE

2023-09-05 Thread Harsh Prateek Bora
This hcall is used by L1 to delete a guest entry in L0 or can also be used to delete all guests if needed (usually in shutdown scenarios). Signed-off-by: Michael Neuling Signed-off-by: Harsh Prateek Bora --- hw/ppc/spapr_nested.c | 32 include/hw/ppc/spa

[PATCH RESEND 13/15] ppc: spapr: Implement nested PAPR hcall - H_GUEST_RUN_VCPU

2023-09-05 Thread Harsh Prateek Bora
Once the L1 has created a nested guest and its associated VCPU, it can request for the execution of nested guest by setting its initial state which can be done either using the h_guest_set_state or using the input buffers along with the call to h_guest_run_vcpu(). On guest exit, L0 uses output buff

[PATCH RESEND 03/15] ppc: spapr: Use SpaprMachineStateNested's ptcr instead of nested_ptcr

2023-09-05 Thread Harsh Prateek Bora
Use nested guest state specific struct for storing related info. Signed-off-by: Michael Neuling Signed-off-by: Harsh Prateek Bora --- hw/ppc/spapr.c | 4 ++-- hw/ppc/spapr_nested.c | 4 ++-- include/hw/ppc/spapr.h | 3 ++- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/

Re: [RFC Patch 4/5] hw/display: Allwinner A10 LCDC emulation

2023-09-05 Thread Philippe Mathieu-Daudé
+Gerd & Marc-André for the ui/fb parts. On 5/9/23 22:14, Strahinja Jankovic wrote: This patch adds support for Allwinner A10 LCD controller. Current emulation supports only RGB32 colorspace and interacts with DEBE0 to obtain framebuffer address and screen size. Signed-off-by: Strahinja Jankovic

Re: [PATCH v5 1/4] uuid: add a hash function

2023-09-05 Thread Philippe Mathieu-Daudé
On 2/8/23 11:08, Albert Esteve wrote: Add hash function to uuid module using the djb2 hash algorithm. ^ This info ... Add a couple simple unit tests for the hash function, checking collisions for similar UUIDs. Signed-off-by: Albert Esteve --- include/qemu/uuid.h| 2 ++ tests/unit/t

Re: [RFC 0/1] virtio-net: add support for SR-IOV emulation

2023-09-05 Thread Yui Washizu
Hi Jason, On 2023/08/30 14:28, Yui Washizu wrote: On 2023/07/24 15:58, Jason Wang wrote: On Mon, Jul 24, 2023 at 10:32 AM Yui Washizu wrote: On 2023/07/20 11:20, Jason Wang wrote: On Wed, Jul 19, 2023 at 9:59 AM Yui Washizu wrote: This patch series is the first step towards enabling h

[PATCH RESEND 05/15] ppc: spapr: Introduce cap-nested-papr for nested PAPR API

2023-09-05 Thread Harsh Prateek Bora
This patch introduces a new cmd line option cap-nested-papr to enable support for nested PAPR API by setting the nested.api version accordingly. It requires the user to launch the L0 Qemu in TCG mode and then L1 Linux can then launch the nested guest in KVM mode. Unlike cap-nested-hv, this is meant

[PATCH 00/15] Nested PAPR API (KVM on PowerVM)

2023-09-05 Thread Harsh Prateek Bora
There is an existing Nested-HV API to enable nested guests on powernv machines. However, that is not supported on pseries/PowerVM LPARs. This patch series implements required hcall interfaces to enable nested guests with KVM on PowerVM. Unlike Nested-HV, with this API, entire L2 state is retained b

[PATCH RESEND 09/15] ppc: spapr: Implement nested PAPR hcall - H_GUEST_CREATE_VCPU

2023-09-05 Thread Harsh Prateek Bora
This patch implements support for hcall H_GUEST_CREATE_VCPU which is used to instantiate a new VCPU for a previously created nested guest. The L1 provide the guest-id (returned by L0 during call to H_GUEST_CREATE) and an associated unique vcpu-id to refer to this instance in future calls. It is ass

Re: [PATCH v5 2/4] virtio-dmabuf: introduce virtio-dmabuf

2023-09-05 Thread Philippe Mathieu-Daudé
Hi Albert, On 2/8/23 11:08, Albert Esteve wrote: This API manages objects (in this iteration, dmabuf fds) that can be shared along different virtio devices, associated to a UUID. The API allows the different devices to add, remove and/or retrieve the objects by simply invoking the public functi

<    1   2   3   >