RE: [PATCH v3] arm/kvm: Enable support for KVM_CAP_ARM_EAGER_SPLIT_CHUNK_SIZE

> -Original Message- > From: Gavin Shan [mailto:gs...@redhat.com] > Sent: 31 August 2023 02:43 > To: Shameerali Kolothum Thodi ; > qemu-devel@nongnu.org; qemu-...@nongnu.org > Cc: peter.mayd...@linaro.org; ricar...@google.com; Jonathan Cameron > ; k...@vger.kernel.org; Linuxarm > > Subje

[PATCH v3] migration/calc-dirty-rate: millisecond-granularity period

This patch allows to measure dirty page rate for sub-second intervals of time. An optional argument is introduced -- calc-time-unit. For example: {"execute": "calc-dirty-rate", "arguments": {"calc-time": 500, "calc-time-unit": "millisecond"} } Millisecond granularity allows to make predictions w

Re: [PATCH v8 10/12] virtio-sound: implement audio output (TX)

Am 04.09.23 um 23:34 schrieb Volker Rümelin: Am 04.09.23 um 12:34 schrieb Manos Pitsidianakis: On Mon, 04 Sep 2023 13:26, Philippe Mathieu-Daudé wrote: +/* + * AUD_* output callback. + * + * @data: VirtIOSoundPCMStream stream + * @available: number of bytes that can be written with AUD_write

Re: [PATCH v2 1/4] softmmu: Support concurrent bounce buffers

On Fri, Sep 1, 2023 at 3:41 PM Markus Armbruster wrote: > > Stefan Hajnoczi writes: > > > On Wed, Aug 23, 2023 at 04:54:06PM -0400, Peter Xu wrote: > >> On Wed, Aug 23, 2023 at 10:08:08PM +0200, Mattias Nissler wrote: > >> > On Wed, Aug 23, 2023 at 7:35 PM Peter Xu wrote: > >> > > On Wed, Aug 23

Re: [PATCH 00/13] VIRTIO-IOMMU/VFIO: Don't assume 64b IOVA space

I have runned the following two tests, but both tests failed: [1] start a VM with virtio-iommu + 2 ice PFs only via qemu-kvm 8.1.5 Test result : the qemu-kvm keeps throwing the error: VFIO_MAP_DMA failed: File exists. vfio_dma_map(0x56443d20fbe0, 0xe000, 0x1000, 0x7fb545709000) = -17 (File exi

[PATCH v5 0/3] hw/{i2c,nvme}: mctp endpoint, nvme management interface model

This adds a generic MCTP endpoint model that other devices may derive from. Also included is a very basic implementation of an NVMe-MI device, supporting only a small subset of the required commands. Since this all relies on i2c target mode, this can currently only be used with an SoC that includ

Re: [RFC PATCH 1/3] Python: Drop support for Python 3.7

On 5/9/23 08:00, Paolo Bonzini wrote: Il lun 4 set 2023, 12:34 Philippe Mathieu-Daudé > ha scritto: > Since it is safe to under our supported platform policy, bump our Is 'under' a verb? This sentence is not obvious to me. No, just drop "to". Argh, now

[PATCH v5 1/3] hw/i2c: add smbus pec utility function

From: Klaus Jensen Add i2c_smbus_pec() to calculate the SMBus Packet Error Code for a message. Reviewed-by: Jonathan Cameron Signed-off-by: Klaus Jensen --- hw/i2c/smbus_master.c | 26 ++ include/hw/i2c/smbus_master.h | 2 ++ 2 files changed, 28 insertions(+)

[PATCH v5 3/3] hw/nvme: add nvme management interface model

From: Klaus Jensen Add the 'nmi-i2c' device that emulates an NVMe Management Interface controller. Initial support is very basic (Read NMI DS, Configuration Get). This is based on previously posted code by Padmakar Kalghatgi, Arun Kumar Agasar and Saurav Kumar. Signed-off-by: Klaus Jensen ---

[PATCH v5 2/3] hw/i2c: add mctp core

From: Klaus Jensen Add an abstract MCTP over I2C endpoint model. This implements MCTP control message handling as well as handling the actual I2C transport (packetization). Devices are intended to derive from this and implement the class methods. Parts of this implementation is inspired by code

Re: [PATCH] hw/pci-bridge/cxl-upstream: Add serial number extended capability support

Hi Jonathan, On 4/9/23 19:57, Jonathan Cameron wrote: Will be needed so there is a defined serial number for information queries via the Switch CCI. Signed-off-by: Jonathan Cameron --- No ordering dependencies wrt to other CXL patch sets. Whilst we 'need' it for the Switch CCI set it is valid

Re: [PATCH 1/5] cxl/mailbox: move mailbox effect definitions to a header

On 1/9/23 03:29, Gregory Price wrote: Preparation for allowing devices to define their own CCI commands Signed-off-by: Gregory Price --- hw/cxl/cxl-mailbox-utils.c | 35 +++ include/hw/cxl/cxl_mailbox.h | 18 ++ 2 files changed, 37 insertion

Re: [PATCH 2/5] cxl/type3: Cleanup multiple CXL_TYPE3() calls in read/write functions

On 1/9/23 03:29, Gregory Price wrote: Call CXL_TYPE3 once at top of function to avoid multiple invocations. Signed-off-by: Gregory Price --- hw/mem/cxl_type3.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 0/1] qom: fix setting of qdev array properties

Am 04.09.2023 um 18:25 hat Daniel P. Berrangé geschrieben: > By the time of the 8.2.0 release, it will have been 2 years and 6 > releases since we accidentally broke setting of array properties > for user creatable devices: > > https://gitlab.com/qemu-project/qemu/-/issues/1090 Oh, nice! Well,

Re: [PATCH 3/5] cxl/type3: Expose ct3 functions so that inheriters can call them

Hi Gregory, On 1/9/23 03:29, Gregory Price wrote: For devices built on top of ct3, we need the init, realize, and exit functions exposed to correctly start up and tear down. You shouldn't need this. Your device class can inherit from the CT3 base class by setting its .parent to TYPE_CXL_TYPE3:

Re: [PATCH v22 01/20] CPU topology: extend with s390 specifics

On 01/09/2023 17.57, Nina Schoetterl-Glausch wrote: From: Pierre Morel S390 adds two new SMP levels, drawers and books to the CPU topology. S390 CPUs have specific topology features like dedication and entitlement. These indicate to the guest information on host vCPU scheduling and help the gue

Re: [PATCH] hw/pci-bridge/cxl-upstream: Add serial number extended capability support

On Tue, Sep 05, 2023 at 10:48:54AM +0200, Philippe Mathieu-Daudé wrote: > Hi Jonathan, > > On 4/9/23 19:57, Jonathan Cameron wrote: > > Will be needed so there is a defined serial number for > > information queries via the Switch CCI. > > > > Signed-off-by: Jonathan Cameron > > --- > > No orderi

Re: [PATCH 0/5 v2] CXL: SK hynix Niagara MHSLD Device

On 1/9/23 03:29, Gregory Price wrote: v2: - 5 patch series, first 4 are pull-aheads that can be merged separately - cci: rebased on 8-30 branch from jic23, dropped cci patches - mailbox: dropped MHD commands, integrated into niagara (for now) - mailbox: refactor CCI defines to avoid redefinition

Re: [PATCH v2 05/19] host-utils: Add muldiv64_round_up

On 5/9/23 05:56, Nicholas Piggin wrote: On Mon Sep 4, 2023 at 11:30 PM AEST, Cédric Le Goater wrote: Someone really ought to take over PPC. Daniel and I are real busy on other subsystems. Volunteers ? I suppose I should. I could try do the next PR after this one is merged. Thanks a lot for

Re: [QEMU PATCH v4 09/13] virtio-gpu: Handle resource blob commands

On Thu, Aug 31, 2023 at 06:24:32PM +0800, Akihiko Odaki wrote: > On 2023/08/31 18:32, Huang Rui wrote: > > From: Antonio Caggiano > > > > Support BLOB resources creation, mapping and unmapping by calling the > > new stable virglrenderer 0.10 interface. Only enabled when available and > > via the

[PATCH v4] arm/kvm: Enable support for KVM_CAP_ARM_EAGER_SPLIT_CHUNK_SIZE

Now that we have Eager Page Split support added for ARM in the kernel, enable it in Qemu. This adds, -eager-split-size to -accel sub-options to set the eager page split chunk size. -enable KVM_CAP_ARM_EAGER_SPLIT_CHUNK_SIZE. The chunk size specifies how many pages to break at a time, using a sin

Re: [QEMU PATCH v4 07/13] softmmu/memory: enable automatic deallocation of memory regions

On Thu, Aug 31, 2023 at 06:10:08PM +0800, Akihiko Odaki wrote: > On 2023/08/31 18:32, Huang Rui wrote: > > From: Xenia Ragiadakou > > > > When the memory region has a different life-cycle from that of her parent, > > could be automatically released, once has been unparent and once all of her > >

Re: [PATCH 00/13] VIRTIO-IOMMU/VFIO: Don't assume 64b IOVA space

Hi Yanghang, On 9/5/23 10:22, YangHang Liu wrote: > I have runned the following two tests, but both tests failed: > [1] start a VM with virtio-iommu + 2 ice PFs only via qemu-kvm 8.1.5 > Test result : the qemu-kvm keeps throwing the error: VFIO_MAP_DMA > failed: File exists. vfio_dma_map(0x56443d

Re: [QEMU PATCH v4 07/13] softmmu/memory: enable automatic deallocation of memory regions

On 2023/09/05 18:07, Huang Rui wrote: On Thu, Aug 31, 2023 at 06:10:08PM +0800, Akihiko Odaki wrote: On 2023/08/31 18:32, Huang Rui wrote: From: Xenia Ragiadakou When the memory region has a different life-cycle from that of her parent, could be automatically released, once has been unparent

[PATCH] migration/dirtyrate: use QEMU_CLOCK_HOST to report start-time

Currently query-dirty-rate uses QEMU_CLOCK_REALTIME as the source for start-time field. This translates to clock_gettime(CLOCK_MONOTONIC), i.e. number of seconds since host boot. This is not very useful. The only reasonable use case of start-time I can imagine is to check whether previously complet

Re: [QEMU PATCH v4 09/13] virtio-gpu: Handle resource blob commands

On 2023/09/05 18:08, Huang Rui wrote: On Thu, Aug 31, 2023 at 06:24:32PM +0800, Akihiko Odaki wrote: On 2023/08/31 18:32, Huang Rui wrote: From: Antonio Caggiano Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when av

Re: [PATCH v5 01/20] tests/docker: Update docker-loongarch-cross toolchain

Richard Henderson writes: > Update from clfs 5.0 to clfs 8.1, which includes updates > to binutils 2.41, gcc 13.2, and glibc 2.38. > > See https://github.com/loongson/build-tools > > Signed-off-by: Richard Henderson > --- > tests/docker/dockerfiles/debian-loongarch-cross.docker | 2 +- > 1 fi

Re: [PATCH 0/1] qom: fix setting of qdev array properties

On Tue, 5 Sept 2023 at 09:59, Kevin Wolf wrote: > > Am 04.09.2023 um 18:25 hat Daniel P. Berrangé geschrieben: > > By the time of the 8.2.0 release, it will have been 2 years and 6 > > releases since we accidentally broke setting of array properties > > for user creatable devices: > > > > https:

Re: [PATCH] migration/dirtyrate: use QEMU_CLOCK_HOST to report start-time

Hi Andrei, On 5/9/23 11:18, Andrei Gudkov via wrote: Currently query-dirty-rate uses QEMU_CLOCK_REALTIME as the source for start-time field. This translates to clock_gettime(CLOCK_MONOTONIC), i.e. number of seconds since host boot. This is not very useful. The only reasonable use case of start-t

Re: [virtio-dev] [RFC PATCH v2] docs/interop: define PROBE feature for vhost-user VirtIO devices

Albert Esteve writes: > This looks great! Thanks for this proposal. > > On Fri, Sep 1, 2023 at 1:00 PM Alex Bennée wrote: > > Currently QEMU has to know some details about the VirtIO device > supported by a vhost-user daemon to be able to setup the guest. This > makes it hard for QEMU to ad

RE: [RFC PATCH v2 00/12] Confidential guest-assisted live migration

> -Original Message- > From: Qemu-devel > [mailto:qemu-devel-bounces+shameerali.kolothum.thodi=huawei.com@nong > nu.org] On Behalf Of Dov Murik > Sent: 23 August 2021 15:16 > To: qemu-devel@nongnu.org > Cc: Tom Lendacky ; Ashish Kalra > ; Brijesh Singh ; Michael > S. Tsirkin ; Steve Ruthe

Re: [PATCH 00/13] VIRTIO-IOMMU/VFIO: Don't assume 64b IOVA space

Hi, On 9/5/23 10:22, YangHang Liu wrote: > I have runned the following two tests, but both tests failed: > [1] start a VM with virtio-iommu + 2 ice PFs only via qemu-kvm 8.1.5 > Test result : the qemu-kvm keeps throwing the error: VFIO_MAP_DMA > failed: File exists. vfio_dma_map(0x56443d20fbe0, 0

Re: [risu PATCH 2/4] s390x: Add simple s390x.risu file

On 04/09/2023 16.20, Ilya Leoshkevich wrote: On Mon, 2023-09-04 at 16:00 +0200, Thomas Huth wrote: This only adds a limited set of s390x instructions for initial testing. More instructions will be added later. Signed-off-by: Thomas Huth ---  s390x.risu | 48 +++

deadlock when using iothread during backup_clean()

Hi, as the title says, a deadlock is possible in backup_clean() when using a drive with an IO thread. The main thread keeps waiting in bdrv_graph_wrlock() for reader_count() to become 0, while the IO thread waits for its AioContext lock, which the main thread holds (because it also is the backup j

Re: [virtio-dev] [RFC PATCH v2] docs/interop: define PROBE feature for vhost-user VirtIO devices

On Tue, Sep 5, 2023 at 11:43 AM Alex Bennée wrote: > > Albert Esteve writes: > > > This looks great! Thanks for this proposal. > > > > On Fri, Sep 1, 2023 at 1:00 PM Alex Bennée > wrote: > > > > Currently QEMU has to know some details about the VirtIO device > > supported by a vhost-user daem

[PATCH] docs/system/replay: do not show removed command line option

Cc: qemu-triv...@nongnu.org Signed-off-by: Paolo Bonzini --- docs/system/replay.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/replay.rst b/docs/system/replay.rst index 3105327423c..ca7c17c63da 100644 --- a/docs/system/replay.rst +++ b/docs/system/replay.rst @

Re: QEMU features useful for Xen development?

Ayan Kumar Halder writes: > Hi Peter/Alex, > > Appreciate your help. :) > > On 31/08/2023 11:03, Peter Maydell wrote: >> On Thu, 31 Aug 2023 at 10:53, Alex Bennée wrote: >>> >>> Peter Maydell writes: >>> On Thu, 31 Aug 2023 at 01:57, Stefano Stabellini wrote: > As Xen is gaini

[PATCH] audio: remove QEMU_AUDIO_* and -audio-help support

These have been deprecated for a long time, and the introduction of -audio in 7.1.0 has cemented the new way of specifying an audio backend. Remove all the associated baggage, including the concept of default audio backends. Signed-off-by: Paolo Bonzini --- audio/alsaaudio.c | 1

Re: [PATCH] docs/system/replay: do not show removed command line option

On 05/09/2023 12.07, Paolo Bonzini wrote: Cc: qemu-triv...@nongnu.org Signed-off-by: Paolo Bonzini --- docs/system/replay.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/replay.rst b/docs/system/replay.rst index 3105327423c..ca7c17c63da 100644 --- a/docs/sy

Re: [PATCH] audio: remove QEMU_AUDIO_* and -audio-help support

On 05/09/2023 12.19, Paolo Bonzini wrote: These have been deprecated for a long time, and the introduction of -audio in 7.1.0 has cemented the new way of specifying an audio backend. Remove all the associated baggage, including the concept of default audio backends. Signed-off-by: Paolo Bonzini

Re: 'check-avocado' fails after c03f57fd5b ("Revert "tests: Use separate ...")

On Fri, Sep 1, 2023 at 4:36 PM Daniel Henrique Barboza wrote: > > Hi, > > FWIW I am unable to run 'check-avocado' after commit c03f57fd5b ("Revert > "tests: Use > separate virtual environment for avocado"). The error being thrown: > > [20/20] Generating docs/QEMU man pages with a custom command >

Re: [PATCH] docs/system/replay: do not show removed command line option

On 5/9/23 12:07, Paolo Bonzini wrote: Cc: qemu-triv...@nongnu.org Signed-off-by: Paolo Bonzini --- docs/system/replay.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: CXL Namespaces of ACPI disappearing in Qemu demo

Hi, Jonathan On 2023-09-04 20:43, jonathan.cameron wrote: > > At the system design level, MMIO space of Root complex register space via RCRB > does not map in a similar fashion to PCIE MMIO space (which is handled via > address decoding in the PCIE fabric). It is much more similar to MMIO for >

Re: [PATCH v4 00/14] simpletrace: refactor and general improvements

> On 23 Aug 2023, at 10.54, Mads Ynddal wrote: > > From: Mads Ynddal > > I wanted to use simpletrace.py for an internal project, so I tried to update > and polish the code. Some of the commits resolve specific issues, while some > are more subjective. > > I've tried to divide it into commits

Re: 'check-avocado' fails after c03f57fd5b ("Revert "tests: Use separate ...")

On Tue, Sep 5, 2023 at 12:39 PM Paolo Bonzini wrote: > > /home/danielhb/work/test/qemu/build/pyvenv/bin/python3 -B > > python/scripts/mkvenv.py ensuregroup --online > > /home/danielhb/work/test/qemu/pythondeps.toml avocado > > mkvenv: checking for avocado-framework(>=88.1, <93.0) > > mkvenv: che

Re: [PATCH] audio: remove QEMU_AUDIO_* and -audio-help support

On 9/5/23 12:39, Thomas Huth wrote: +    dolog("Device %s: audiodev default parameter is deprecated, please " +  "specify audiodev=%s\n", name, +  QTAILQ_FIRST(&audio_states)->dev->id); You said that you removed the default handling ... so this log message looks

Re: deadlock when using iothread during backup_clean()

Am 05.09.23 um 12:01 schrieb Fiona Ebner: > > Can we assume block_job_remove_all_bdrv() to always hold the job's > AioContext? And if yes, can we just tell bdrv_graph_wrlock() that it > needs to release that before polling to fix the deadlock? > I tried a doing something similar as a proof-of-co

Re: [PATCH v4 05/14] simpletrace: update code for Python 3.11

On 23/8/23 10:54, Mads Ynddal wrote: From: Mads Ynddal The call to `getargspec` was deprecated and in Python 3.11 it has been removed in favor of `getfullargspec`. `getfullargspec` is compatible with QEMU's requirement of at least Python version 3.6. Signed-off-by: Mads Ynddal Reviewed-by: St

Re: [PATCH v4 06/14] simpletrace: improved error handling on struct unpack

On 23/8/23 10:54, Mads Ynddal wrote: From: Mads Ynddal A failed call to `read_header` wouldn't be handled the same for the two different code paths (one path would try to use `None` as a list). Changed to raise exception to be handled centrally. This also allows for easier unpacking, as errors

Re: [PATCH v4 11/14] simpletrace: move event processing to Analyzer class

On 23/8/23 10:54, Mads Ynddal wrote: From: Mads Ynddal Moved event processing to the Analyzer class to separate specific analyzer "Move" Reviewed-by: Philippe Mathieu-Daudé logic (like caching and function signatures) from the _process function. This allows for new types of Analyzer-based

Re: [PATCH v4 13/14] MAINTAINERS: add maintainer of simpletrace.py

On 23/8/23 10:54, Mads Ynddal wrote: From: Mads Ynddal In my work to refactor simpletrace.py, I noticed that there's no maintainer of it, and has the status of "odd fixes". I'm using it from time to time, so I'd like to maintain the script. I've added myself as reviewer under "Tracing" to be i

Re: [PATCH v4 14/14] scripts/analyse-locks-simpletrace.py: changed iteritems() to items()

On 23/8/23 10:54, Mads Ynddal wrote: From: Mads Ynddal Python 3 removed `dict.iteritems()` in favor of `dict.items()`. This means the script curerntly doesn't work on Python 3. "currently" Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Mads Ynddal --- scripts/analyse-locks-simplet

Re: [PATCH] audio: remove QEMU_AUDIO_* and -audio-help support

On 05/09/2023 12.55, Paolo Bonzini wrote: On 9/5/23 12:39, Thomas Huth wrote: +    dolog("Device %s: audiodev default parameter is deprecated, please " +  "specify audiodev=%s\n", name, +  QTAILQ_FIRST(&audio_states)->dev->id); You said that you removed the defau

Re: deadlock when using iothread during backup_clean()

On 9/5/23 12:01, Fiona Ebner wrote: Can we assume block_job_remove_all_bdrv() to always hold the job's AioContext? I think so, see job_unref_locked(), job_prepare_locked() and job_finalize_single_locked(). These call the callbacks that ultimately get to block_job_remove_all_bdrv().

[risu PATCH v2 4/4] s390x: Update the configure script for s390x support

Auto-detect s390x hosts and add s390x information to the help text. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index ca2d7db..2f7c580 100755 --- a/configure +++ b/confi

[risu PATCH v2 2/4] s390x: Add simple s390x.risu file

This only adds a limited set of s390x instructions for initial testing. More instructions will be added later. Acked-by: Ilya Leoshkevich Signed-off-by: Thomas Huth --- s390x.risu | 48 1 file changed, 48 insertions(+) create mode 100644 s390x.r

[risu PATCH v2 3/4] s390x: Add basic risugen perl module for s390x

This implements support for simple 16-bit and 32-bit instructions. Support for 48-bit instructions and support for load/store memory instructions is not implemented yet. Signed-off-by: Thomas Huth --- risugen_s390x.pm | 186 +++ 1 file changed, 186 ins

[risu PATCH v2 0/4] Add support for s390x to RISU

Hi Peter! Here are some patches that add basic support for s390x to RISU. It's still quite limited, e.g. no support for load/store memory operations yet, but the basics with simple 16-bit or 32-bit instructions work already fine. v2: - Removed the code to avoid r14 (return address) and r15 (stac

[risu PATCH v2 1/4] s390x: Add basic s390x support to the C code

With these changes, it is now possible to compile the "risu" binary for s390x hosts. Acked-by: Ilya Leoshkevich Signed-off-by: Thomas Huth --- risu_reginfo_s390x.c | 140 +++ risu_reginfo_s390x.h | 23 +++ risu_s390x.c | 48 +++

Re: [risu PATCH 0/4] Add support for s390x to RISU

On 04/09/2023 16.30, Ilya Leoshkevich wrote: On Mon, 2023-09-04 at 16:00 +0200, Thomas Huth wrote:  Hi Peter! Here are some patches that add basic support for s390x to RISU. It's still quite limited, e.g. no support for load/store memory operations yet, but the basics with simple 16-bit or 32-

Re: [PATCH v4 12/14] simpletrace: added simplified Analyzer2 class

> On 23 Aug 2023, at 10.54, Mads Ynddal wrote: > > From: Mads Ynddal > > By moving the dynamic argument construction to keyword-arguments, > we can remove all of the specialized handling, and streamline it. > If a tracing method wants to access these, they can define the > kwargs, or ignore i

[PATCH v4 0/3] sysemu/accel: Simplify sysemu/xen.h

Trivial cleanups which simplify "sysemu/xen.h". Philippe Mathieu-Daudé (3): sysemu/xen: Remove unuseful CONFIG_USER_ONLY header guard sysemu/xen: Remove unreachable xen_ram_alloc() code sysemu/xen: Allow elision of xen_hvm_modified_memory() include/exec/ram_addr.h | 8 ++-- include/sy

[PATCH 2/3] sysemu/xen: Remove unreachable xen_ram_alloc() code

The xen_ram_alloc() call in softmmu/physmem.c is guarded by checking for xen_enabled(), which evaluate to 'false' when XEN is not built in. The compiler elide the function call, and thus the inlined function is not used. Remove it. Inspired-by: Daniel Henrique Barboza Signed-off-by: Philippe Math

[PATCH 1/3] sysemu/xen: Remove unuseful CONFIG_USER_ONLY header guard

In commit da278d58a0 ("accel: Move Xen accelerator code under accel/xen/") we used include/sysemu/kvm.h as a template for include/sysemu/xen.h, using the CONFIG_USER_ONLY header guard. In retrospective, it is not used / useful, so remove it. Signed-off-by: Philippe Mathieu-Daudé --- include/syse

[PATCH 3/3] sysemu/xen: Allow elision of xen_hvm_modified_memory()

Call xen_enabled() before xen_hvm_modified_memory() to let the compiler elide its call. Have xen_enabled() return a boolean to match its declaration in the CONFIG_XEN_IS_POSSIBLE case. Suggested-by: Daniel Henrique Barboza Signed-off-by: Philippe Mathieu-Daudé --- include/exec/ram_addr.h | 8

[PATCH 0/3] sysemu/accel: Simplify sysemu/xen.h

Trivial cleanups which simplify "sysemu/xen.h". Philippe Mathieu-Daudé (3): sysemu/xen: Remove unuseful CONFIG_USER_ONLY header guard sysemu/xen: Remove unreachable xen_ram_alloc() code sysemu/xen: Allow elision of xen_hvm_modified_memory() include/exec/ram_addr.h | 8 ++-- include/sy

Re: [PATCH v4 0/3] sysemu/accel: Simplify sysemu/xen.h

On 5/9/23 14:20, Philippe Mathieu-Daudé wrote: Trivial cleanups which simplify "sysemu/xen.h". Philippe Mathieu-Daudé (3): sysemu/xen: Remove unuseful CONFIG_USER_ONLY header guard sysemu/xen: Remove unreachable xen_ram_alloc() code sysemu/xen: Allow elision of xen_hvm_modified_memory()

Re: [PATCH v22 02/20] s390x/cpu topology: add topology entries on CPU hotplug

On 01/09/2023 17.57, Nina Schoetterl-Glausch wrote: From: Pierre Morel The topology information are attributes of the CPU and are specified during the CPU device creation. On hot plug we: - calculate the default values for the topology for drawers, books and sockets in the case they are not

[PATCH 1/2] target/i386/hvf: Remove unused includes in 'hvf-i386.h'

The only non standard type -- CPUArchState -- is forward declared in "qemu/typedefs.h", so no particular header is required here. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hvf/hvf-i386.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/target/i386/hvf/hvf-i386.h b/target/i386

[PATCH 0/2] sysemu/accel: Simplify sysemu/hvf.h

Trivial cleanups which simplify "sysemu/hvf.h". Philippe Mathieu-Daudé (2): target/i386/hvf: Remove unused includes in 'hvf-i386.h' sysemu/kvm: Restrict hvf_get_supported_cpuid() to x86 targets include/sysemu/hvf.h | 3 --- target/i386/hvf/hvf-i386.h | 6 +- target/i386/cpu.c

[PATCH 2/2] sysemu/kvm: Restrict hvf_get_supported_cpuid() to x86 targets

hvf_get_supported_cpuid() is only defined for x86 targets (in target/i386/hvf/x86_cpuid.c). Its declaration is pointless on all other targets. All the calls to it in target/i386/cpu.c are guarded by a call on hvf_enabled(), so are elided when HVF is not built in. Therefore we can remove the unnece

[PATCH v1 1/1] target/loongarch: Add preldx instruction

Resolve the issue of starting the Loongnix 20.5[1] system failure. Logs: Loading Linux 4.19.0-19-loongson-3 ... Loading initial ramdisk ... PROGRESS CODE: V02010004 I0 PROGRESS CODE: V03101019 I0 Error: unknown opcode. 903a3e6c: 0x382c6d82 [1] http://pkg.loongnix.cn/l

Re: [PATCH v4 12/14] simpletrace: added simplified Analyzer2 class

On Wed, Aug 23, 2023 at 10:54:27AM +0200, Mads Ynddal wrote: > From: Mads Ynddal > > By moving the dynamic argument construction to keyword-arguments, > we can remove all of the specialized handling, and streamline it. > If a tracing method wants to access these, they can define the > kwargs, or

[PATCH 1/2] block/meson.build: Restore alphabetical order of files

When commit 5e5733e5999 created block/meson.build, the list of unconditionally added files was in alphabetical order. Later commits added new files in random places. Reorder the list to be alphabetical again. (As for ordering foo.c against foo-*.c, there are both ways used currently; standardise on

[PATCH 2/2] block: Make more BlockDriver definitions static

Most block driver implementations don't have any reason for their BlockDriver to be public. The only exceptions are bdrv_file, bdrv_raw and bdrv_qcow2, which are actually used in other source files. Make all other BlockDriver definitions static if they aren't yet. Signed-off-by: Kevin Wolf ---

[PATCH 0/2] block: Minor cleanups

I had to go through all block drivers and noticed some details that aren't as expected, so I thought I might as well fix them... Kevin Wolf (2): block/meson.build: Restore alphabetical order of files block: Make more BlockDriver definitions static block/copy-before-write.c | 2 +- block/pre

[PATCH v2] qcow2: keep reference on zeroize with discard-no-unref enabled

When the discard-no-unref flag is enabled, we keep the reference for normal discard requests. But when a discard is executed on a snapshot/qcow2 image with backing, the discards are saved as zero clusters in the snapshot image. When committing the snapshot to the backing file, not discard_in_l2_sl

Re: [PATCH] qcow2: keep reference on zeroize with discard-no-unref enabled

Replaced by PATCH v2. On 4/09/2023 17:09, Jean-Louis Dupond wrote: When the discard-no-unref flag is enabled, we keep the reference for normal discard requests. But when a discard is executed on a snapshot/qcow2 image with backing, the discards are saved as zero clusters in the snapshot image.

Re: [PATCH v1 1/1] target/loongarch: Add preldx instruction

On 5/9/23 14:39, Song Gao wrote: Resolve the issue of starting the Loongnix 20.5[1] system failure. Logs: Loading Linux 4.19.0-19-loongson-3 ... Loading initial ramdisk ... PROGRESS CODE: V02010004 I0 PROGRESS CODE: V03101019 I0 Error: unknown opcode. 903a3e6c: 0

Re: 'check-avocado' fails after c03f57fd5b ("Revert "tests: Use separate ...")

Hi, I managed to work around it. I'll post here the debugs for future reference. - Here's all the steps after a clean qemu clone: [danielhb@grind build]$ make check-avocado AVOCADO tests/avocado /home/danielhb/work/test/qemu/build/pyvenv/bin/python3: No module named avocado.__main__; 'avocad

mips system emulation failure with virtio

With qemu 8.1.0 we see boot hangs fox x86-64 targets.  These are fixed by 0d58c660689f6da1e3feff8a997014003d928b3b (softmmu: Use async_run_on_cpu in tcg_commit) but if I add that commit, mips and mips64 break, hanging at boot unable to find a rootfs.  We use virtio for network and disk and both o

Re: [PATCH v10 00/10] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration

Het Gala writes: > Hi qemu-devel community, > > A gentle reminder and request for all migration maintainers - Peter, > Juan, Dr. Gilbert and others too for review of the patchset series. > Received reviewed-by from Daniel on migration implementation patches but > need final approval from migra

Re: [PATCH v22 03/20] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

On 01/09/2023 17.57, Nina Schoetterl-Glausch wrote: From: Pierre Morel On interception of STSI(15.1.x) the System Information Block (SYSIB) is built from the list of pre-ordered topology entries. Signed-off-by: Pierre Morel Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Nina Schoett

Re: [PATCH 1/2] block/meson.build: Restore alphabetical order of files

On 5/9/23 15:06, Kevin Wolf wrote: When commit 5e5733e5999 created block/meson.build, the list of unconditionally added files was in alphabetical order. Later commits added new files in random places. Reorder the list to be alphabetical again. (As for ordering foo.c against foo-*.c, there are bot

Re: [QEMU PATCH v4 07/13] softmmu/memory: enable automatic deallocation of memory regions

On Tue, Sep 05, 2023 at 05:17:32PM +0800, Akihiko Odaki wrote: > On 2023/09/05 18:07, Huang Rui wrote: > > On Thu, Aug 31, 2023 at 06:10:08PM +0800, Akihiko Odaki wrote: > >> On 2023/08/31 18:32, Huang Rui wrote: > >>> From: Xenia Ragiadakou > >>> > >>> When the memory region has a different life-

Re: [PATCH 4/5] cxl/type3: add an optional mhd validation function for memory accesses

On Mon, Sep 04, 2023 at 06:02:14PM +0100, Jonathan Cameron wrote: > On Thu, 31 Aug 2023 21:29:13 -0400 > Gregory Price wrote: > > > When memory accesses are made, some MHSLD's would validate the address > > is within the scope of allocated sections. To do this, the base device > > must call an o

Re: [PATCH 2/2] block: Make more BlockDriver definitions static

On 5/9/23 15:06, Kevin Wolf wrote: Most block driver implementations don't have any reason for their BlockDriver to be public. The only exceptions are bdrv_file, bdrv_raw and bdrv_qcow2, which are actually used in other source files. Make all other BlockDriver definitions static if they aren't y

Re: [PATCH 3/5] cxl/type3: Expose ct3 functions so that inheriters can call them

On Tue, Sep 05, 2023 at 10:59:15AM +0200, Philippe Mathieu-Daudé wrote: > Hi Gregory, > > On 1/9/23 03:29, Gregory Price wrote: > > For devices built on top of ct3, we need the init, realize, and > > exit functions exposed to correctly start up and tear down. > > You shouldn't need this. Your dev

Re: [PATCH v2 1/4] softmmu: Support concurrent bounce buffers

On Tue, Sep 05, 2023 at 09:38:39AM +0200, Mattias Nissler wrote: > It would be nice to use a property on the device that originates the > DMA operation to configure this. However, I don't see how to do this > in a reasonable way without bigger changes: A typical call path is > pci_dma_map -> dma_me

Re: [PATCH 0/5 v2] CXL: SK hynix Niagara MHSLD Device

On Tue, Sep 05, 2023 at 11:04:56AM +0200, Philippe Mathieu-Daudé wrote: > On 1/9/23 03:29, Gregory Price wrote: > > v2: > > - 5 patch series, first 4 are pull-aheads that can be merged separately > > > > This patch set includes an emulation of the SK hynix Niagara MHSLD > > platform with custom CC

Re: mips system emulation failure with virtio

Richard Purdie writes: > With qemu 8.1.0 we see boot hangs fox x86-64 targets.  > > These are fixed by 0d58c660689f6da1e3feff8a997014003d928b3b (softmmu: > Use async_run_on_cpu in tcg_commit) but if I add that commit, mips and > mips64 break, hanging at boot unable to find a rootfs.  (Widen CC

Re: [PATCH v3 07/20] virtio: add vhost-user-base and a generic vhost-user-device

On Mon, Jul 10, 2023 at 04:35:09PM +0100, Alex Bennée wrote: > In theory we shouldn't need to repeat so much boilerplate to support > vhost-user backends. This provides a generic vhost-user-base QOM > object and a derived vhost-user-device for which the user needs to > provide the few bits of infor

Re: [PATCH v6 04/17] nbd: Prepare for 64-bit request effect lengths

On Mon, Sep 04, 2023 at 07:15:04PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 29.08.23 20:58, Eric Blake wrote: > > Widen the length field of NBDRequest to 64-bits, although we can > > assert that all current uses are still under 32 bits: either because > > of NBD_MAX_BUFFER_SIZE which is even

Re: [PATCH] docs/devel/loads-stores: Fix git grep regexes

On Mon, Sep 04, 2023 at 05:17:03PM +0100, Peter Maydell wrote: > The loads-and-stores documentation includes git grep regexes to find > occurrences of the various functions. Some of these regexes have > errors, typically failing to escape the '?', '(' and ')' when they > should be metacharacters (

Re: [PATCH 0/8] move softmmu options processing from os-posix.c to vl.c

On Fri, Sep 01, 2023 at 11:44:42PM +0200, Paolo Bonzini wrote: > Queued, thanks. > > Paolo I also had these on my plate for an upcoming NBD pull request; I'm fine whichever tree they show up through. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs

Re: CXL Namespaces of ACPI disappearing in Qemu demo

On Tue, 5 Sep 2023 18:45:02 +0800 Yuquan Wang wrote: > Hi, Jonathan > On 2023-09-04 20:43, jonathan.cameron wrote: > > > > At the system design level, MMIO space of Root complex register space via > > RCRB > > does not map in a similar fashion to PCIE MMIO space (which is handled via > > addre

Re: [PATCH v6 06/17] nbd/server: Support a request payload

On 29.08.23 20:58, Eric Blake wrote: Upcoming additions to support NBD 64-bit effect lengths allow for the possibility to distinguish between payload length (capped at 32M) and effect length (64 bits, although we generally assume 63 bits because of off_t limitations). Without that extension, onl

Re: [PATCH v6 04/17] nbd: Prepare for 64-bit request effect lengths

On 05.09.23 17:24, Eric Blake wrote: On Mon, Sep 04, 2023 at 07:15:04PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 29.08.23 20:58, Eric Blake wrote: Widen the length field of NBDRequest to 64-bits, although we can assert that all current uses are still under 32 bits: either because of NBD_MA

Re: 'check-avocado' fails after c03f57fd5b ("Revert "tests: Use separate ...")

On 5/9/23 15:13, Daniel Henrique Barboza wrote: Hi, I managed to work around it. I'll post here the debugs for future reference. - I got suspicious after the above command failure, and noticed that 'avocado' didn't work even outside of the QEMU tree: [danielhb@grind ~]$ avocado --help Tr

[PATCH 2/2] virtio: Drop out of coroutine context in virtio_load()

virtio_load() as a whole should run in coroutine context because it reads from the migration stream and we don't want this to block. However, it calls virtio_set_features_nocheck() and devices don't expect their .set_features callback to run in a coroutine and therefore call functions that may not

  1   2   3   >