Re: [qemu]: How to use qemu to emulate MCTP Over SMBus devices?

2023-08-30 Thread Klaus Jensen
On Aug 30 08:54, Cédric Le Goater wrote: > Hello Byron, > > On 8/30/23 06:05, www wrote: > > Dear Sir, > > > > I have a few questions for you to ask. > > 1. According to my data collection, MCTP function should not be implemented > > in qemu. > > I would like to ask you how to simulate MCTP Over

Re: [PATCH 5/6] vfio/migration: Block VFIO migration with postcopy migration

2023-08-30 Thread Avihai Horon
On 29/08/2023 21:27, Peter Xu wrote: External email: Use caution opening links or attachments On Tue, Aug 29, 2023 at 07:20:47PM +0300, Avihai Horon wrote: On 29/08/2023 17:53, Peter Xu wrote: External email: Use caution opening links or attachments On Mon, Aug 28, 2023 at 06:18:41PM +030

Re: [PATCH v3 8/8] hw/fsi: Documentation and testing

2023-08-30 Thread Thomas Huth
On 30/08/2023 04.26, Ninad Palsule wrote: Added FSI document Added basic qtests for FSI model. Added MAINITAINER for FSI Replaced some qemu logs to traces. Sorry, that's not how we rework patch series in the QEMU development process. Please squash the log traces changes into the patches that

Re: [PATCH v3 8/8] hw/fsi: Documentation and testing

2023-08-30 Thread Cédric Le Goater
On 8/30/23 09:05, Thomas Huth wrote: On 30/08/2023 04.26, Ninad Palsule wrote: Added FSI document Added basic qtests for FSI model. Added MAINITAINER for FSI Replaced some qemu logs to traces. Sorry, that's not how we rework patch series in the QEMU development process. Please squash the log

RE: [PATCH v1 1/4] vfio/pci: detect the support of dynamic MSI-X allocation

2023-08-30 Thread Liu, Jing2
Hi Cédric, Thank you for your reviewing. On 8/29/2023 9:33 PM, Cédric Le Goater wrote: > Hello Jing, > > On 8/22/23 09:29, Jing Liu wrote: > > Kernel provides the guidance of dynamic MSI-X allocation support of > > passthrough device, by clearing the VFIO_IRQ_INFO_NORESIZE flag to > > guide user

Re: [PATCH v2 3/8] machine: Print supported CPU models instead of typenames

2023-08-30 Thread Gavin Shan
Hi Igor, On 8/29/23 19:03, Igor Mammedov wrote: On Tue, 29 Aug 2023 16:28:45 +1000 Gavin Shan wrote: On 8/29/23 00:46, Igor Mammedov wrote: On Mon, 31 Jul 2023 15:07:30 +1000 Gavin Shan wrote: On 7/27/23 19:00, Igor Mammedov wrote: On Thu, 27 Jul 2023 15:16:18 +1000 Gavin Shan wrote:

[PATCH] target/i386: Add support for AMX-COMPLEX in CPUID enumeration

2023-08-30 Thread Tao Su
Latest Intel platform GraniteRapids-D introduces AMX-COMPLEX, which adds two instructions to perform matrix multiplication of two tiles containing complex elements and accumulate the results into a packed single precision tile. AMX-COMPLEX is enumerated via CPUID.(EAX=7,ECX=1):EDX[bit 8]. Add the

Re: [PATCH v2 41/58] i386/tdx: handle TDG.VP.VMCALL

2023-08-30 Thread Daniel P . Berrangé
On Wed, Aug 30, 2023 at 01:57:59PM +0800, Xiaoyao Li wrote: > On 8/30/2023 1:18 PM, Chenyi Qiang wrote: > > > > > > On 8/29/2023 6:25 PM, Daniel P. Berrangé wrote: > > > On Tue, Aug 29, 2023 at 01:31:37PM +0800, Chenyi Qiang wrote: > > > > > > > > > > > > On 8/22/2023 4:24 PM, Daniel P. Berrang

Re: [PATCH v2 4/4] io: follow coroutine AioContext in qio_channel_yield()

2023-08-30 Thread Daniel P . Berrangé
On Tue, Aug 29, 2023 at 02:32:46PM -0500, Eric Blake wrote: > On Tue, Aug 29, 2023 at 12:06:22PM -0400, Stefan Hajnoczi wrote: > > The ongoing QEMU multi-queue block layer effort makes it possible for > > multiple > > threads to process I/O in parallel. The nbd block driver is not compatible > >

Re: PCIe: SLT attribute mismatch: 0xFF020100 instead of 0x20100

2023-08-30 Thread Marcin Juszkiewicz
W dniu 29.08.2023 o 22:46, Michael S. Tsirkin pisze: On Tue, Aug 29, 2023 at 10:44:08PM +0200, Marcin Juszkiewicz wrote: W dniu 29.08.2023 o 22:40, Michael S. Tsirkin pisze: It passes with sbsa-ref (which is not using QEMU versioning). Fails (as expected) when used new property for each pcie-r

Re: [PATCH 1/7] vhost-user: strip superfluous whitespace

2023-08-30 Thread Stefano Garzarella
On Sun, Aug 27, 2023 at 08:29:31PM +0200, Laszlo Ersek wrote: Cc: "Michael S. Tsirkin" (supporter:vhost) Cc: Eugenio Perez Martin Cc: German Maglione Cc: Liu Jiang Cc: Sergio Lopez Pascual Cc: Stefano Garzarella Signed-off-by: Laszlo Ersek --- hw/virtio/vhost-user.c | 2 +- 1 file changed,

Re: [PATCH 2/7] vhost-user: tighten "reply_supported" scope in "set_vring_addr"

2023-08-30 Thread Stefano Garzarella
On Sun, Aug 27, 2023 at 08:29:32PM +0200, Laszlo Ersek wrote: In the vhost_user_set_vring_addr() function, we calculate "reply_supported" unconditionally, even though we'll only need it if "wait_for_reply" is also true. Restrict the scope of "reply_supported" to the minimum. This is purely refa

Re: [PATCH 3/7] vhost-user: factor out "vhost_user_write_msg"

2023-08-30 Thread Stefano Garzarella
On Sun, Aug 27, 2023 at 08:29:33PM +0200, Laszlo Ersek wrote: The tails of the "vhost_user_set_vring_addr" and "vhost_user_set_u64" functions are now byte-for-byte identical. Factor the common tail out to a new function called "vhost_user_write_msg". This is purely refactoring -- no observable c

Re: [PATCH 5/7] vhost-user: hoist "write_msg", "get_features", "get_u64"

2023-08-30 Thread Stefano Garzarella
On Sun, Aug 27, 2023 at 08:29:35PM +0200, Laszlo Ersek wrote: In order to avoid a forward-declaration for "vhost_user_write_msg" in a subsequent patch, hoist "vhost_user_write_msg" -> "vhost_user_get_features" -> "vhost_user_get_u64" just above "vhost_set_vring". This is purely code movement --

Re: [PATCH 4/7] vhost-user: flatten "enforce_reply" into "vhost_user_write_msg"

2023-08-30 Thread Stefano Garzarella
On Sun, Aug 27, 2023 at 08:29:34PM +0200, Laszlo Ersek wrote: At this point, only "vhost_user_write_msg" calls "enforce_reply"; embed the latter into the former. This is purely refactoring -- no observable change. Cc: "Michael S. Tsirkin" (supporter:vhost) Cc: Eugenio Perez Martin Cc: German

Re: [PATCH for-8.2 3/3] hw/arm: Set number of MPU regions correctly for an505, an521, an524

2023-08-30 Thread Philippe Mathieu-Daudé
On 24/7/23 19:43, Peter Maydell wrote: The IoTKit, SSE200 and SSE300 all default to 8 MPU regions. The MPS2/MPS3 FPGA images don't override these except in the case of AN547, which uses 16 MPU regions. Define properties on the ARMSSE object for the MPU regions (using the same names as the docum

Re: [PATCH 6/7] vhost-user: allow "vhost_set_vring" to wait for a reply

2023-08-30 Thread Stefano Garzarella
On Sun, Aug 27, 2023 at 08:29:36PM +0200, Laszlo Ersek wrote: The "vhost_set_vring" function already centralizes the common parts of "vhost_user_set_vring_num", "vhost_user_set_vring_base" and "vhost_user_set_vring_enable". We'll want to allow some of those callers to wait for a reply. Therefore

Re: [PATCH 5/6] vfio/migration: Block VFIO migration with postcopy migration

2023-08-30 Thread Cédric Le Goater
On 8/30/23 09:01, Avihai Horon wrote: On 29/08/2023 21:27, Peter Xu wrote: External email: Use caution opening links or attachments On Tue, Aug 29, 2023 at 07:20:47PM +0300, Avihai Horon wrote: On 29/08/2023 17:53, Peter Xu wrote: External email: Use caution opening links or attachments O

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

2023-08-30 Thread Stefano Garzarella
On Sun, Aug 27, 2023 at 08:29:37PM +0200, Laszlo Ersek wrote: (1) The virtio-1.0 specification writes: What about referring the latest spec available now (1.2)? 3 General Initialization And Device Operation 3.1 Device In

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

2023-08-30 Thread Laszlo Ersek
I'm adding Stefan to the CC list, and an additional piece of explanation below: On 8/27/23 20:29, Laszlo Ersek wrote: > (1) The virtio-1.0 specification > writes: > >> 3 General Initialization And Device Operation >> 3.1 Devic

Re: [PATCH v3 1/2] vhost-user: Fix lost reconnect

2023-08-30 Thread Raphael Norwitz
> On Aug 30, 2023, at 12:57 AM, Li Feng wrote: > > When the vhost-user is reconnecting to the backend, and if the vhost-user > fails > at the get_features in vhost_dev_init(), then the reconnect will fail > and it will not be retriggered forever. > > The reason is: > When the vhost-user fail

Re: [PATCH 0/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

2023-08-30 Thread Stefano Garzarella
On Sun, Aug 27, 2023 at 08:29:30PM +0200, Laszlo Ersek wrote: The last patch in the series states and fixes the problem; prior patches only refactor the code. Thanks for the fix and great cleanup! I fully reviewed the series and LGTM. An additional step that we can take (not in this series) c

[PATCH v4 08/48] target/loongarch: Implement xvneg

2023-08-30 Thread Song Gao
This patch includes: - XVNEG.{B/H/W/D}. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/insns.decode| 5 + target/loongarch/disas.c | 10 ++ target/loongarch/insn_trans/trans_lasx.c.inc | 5 + target/loongarch/ins

[PATCH v4 04/48] target/loongarch: Add avail_LASX to check LASX instructions

2023-08-30 Thread Song Gao
Signed-off-by: Song Gao --- target/loongarch/translate.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/loongarch/translate.h b/target/loongarch/translate.h index 89b49a859e..195f53573a 100644 --- a/target/loongarch/translate.h +++ b/target/loongarch/translate.h @@ -23,6 +23,7 @@ #de

[PATCH v4 06/48] target/loongarch: Implement xvreplgr2vr

2023-08-30 Thread Song Gao
This patch includes: - XVREPLGR2VR.{B/H/W/D}. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/insns.decode| 5 + target/loongarch/disas.c | 10 ++ target/loongarch/insn_trans/trans_lasx.c.inc | 5 + target/loongar

[PATCH v4 00/48] Add LoongArch LASX instructions

2023-08-30 Thread Song Gao
Hi, This series adds LoongArch LASX instructions. About test: We use RISU test the LoongArch LASX instructions. QEMU: https://github.com/loongson/qemu/tree/tcg-old-abi-support-lasx RISU: https://github.com/loongson/risu/tree/loongarch-suport-lasx Please review, Thanks. Changes for v4:

[PATCH v4 34/48] target/loongarch: Implement xvclo xvclz

2023-08-30 Thread Song Gao
This patch includes: - XVCLO.{B/H/W/D}; - XVCLZ.{B/H/W/D}. Signed-off-by: Song Gao --- target/loongarch/vec.h | 9 + target/loongarch/insns.decode| 9 + target/loongarch/disas.c | 9 + target/loongarch/vec_helpe

[PATCH v4 18/48] target/loongarch: Implement xvmadd/xvmsub/xvmaddw{ev/od}

2023-08-30 Thread Song Gao
This patch includes: - XVMADD.{B/H/W/D}; - XVMSUB.{B/H/W/D}; - XVMADDW{EV/OD}.{H.B/W.H/D.W/Q.D}[U]; - XVMADDW{EV/OD}.{H.BU.B/W.HU.H/D.WU.W/Q.DU.D}. Signed-off-by: Song Gao --- target/loongarch/vec.h | 3 + target/loongarch/insns.decode| 34 ++ target/

[PATCH v4 27/48] target/loongarch: Implement xvsll xvsrl xvsra xvrotr

2023-08-30 Thread Song Gao
This patch includes: - XVSLL[I].{B/H/W/D}; - XVSRL[I].{B/H/W/D}; - XVSRA[I].{B/H/W/D}; - XVROTR[I].{B/H/W/D}. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/insns.decode| 33 ++ target/loongarch/disas.c | 36 ++

[PATCH v4 05/48] target/loongarch: Implement xvadd/xvsub

2023-08-30 Thread Song Gao
This patch includes: - XVADD.{B/H/W/D/Q}; - XVSUB.{B/H/W/D/Q}. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/vec.h | 17 + target/loongarch/insns.decode| 14 + target/loongarch/disas.c | 23 + target/loon

[PATCH v4 07/48] target/loongarch: Implement xvaddi/xvsubi

2023-08-30 Thread Song Gao
This patch includes: - XVADDI.{B/H/W/D}U; - XVSUBI.{B/H/W/D}U. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/insns.decode| 9 ++ target/loongarch/disas.c | 14 ++ target/loongarch/insn_trans/trans_lasx.c.inc | 9 ++ target/l

[PATCH v4 30/48] target/loongarch: Implement xvsrln xvsran

2023-08-30 Thread Song Gao
This patch includes: - XVSRLN.{B.H/H.W/W.D}; - XVSRAN.{B.H/H.W/W.D}; - XVSRLNI.{B.H/H.W/W.D/D.Q}; - XVSRANI.{B.H/H.W/W.D/D.Q}. Signed-off-by: Song Gao --- target/loongarch/vec.h | 2 + target/loongarch/insns.decode| 16 ++ target/loongarch/disas.c

[PATCH v4 35/48] target/loongarch: Implement xvpcnt

2023-08-30 Thread Song Gao
This patch includes: - VPCNT.{B/H/W/D}. Signed-off-by: Song Gao --- target/loongarch/insns.decode| 5 + target/loongarch/disas.c | 5 + target/loongarch/vec_helper.c| 4 ++-- target/loongarch/insn_trans/trans_lasx.c.inc | 5 + 4 fil

[PATCH v4 17/48] target/loongarch: Implement xvmul/xvmuh/xvmulw{ev/od}

2023-08-30 Thread Song Gao
This patch includes: - XVMUL.{B/H/W/D}; - XVMUH.{B/H/W/D}[U]; - XVMULW{EV/OD}.{H.B/W.H/D.W/Q.D}[U]; - XVMULW{EV/OD}.{H.BU.B/W.HU.H/D.WU.W/Q.DU.D}. Signed-off-by: Song Gao --- target/loongarch/vec.h | 2 + target/loongarch/insns.decode| 38 + tar

[PATCH v4 19/48] target/loongarch; Implement xvdiv/xvmod

2023-08-30 Thread Song Gao
This patch includes: - XVDIV.{B/H/W/D}[U]; - XVMOD.{B/H/W/D}[U]. Signed-off-by: Song Gao --- target/loongarch/vec.h | 7 +++ target/loongarch/insns.decode| 17 + target/loongarch/disas.c | 17 + target

[PATCH v4 26/48] target/loongarch: Implement LASX logic instructions

2023-08-30 Thread Song Gao
This patch includes: - XV{AND/OR/XOR/NOR/ANDN/ORN}.V; - XV{AND/OR/XOR/NOR}I.B. Signed-off-by: Song Gao --- target/loongarch/insns.decode| 12 target/loongarch/disas.c | 12 target/loongarch/vec_helper.c| 4 ++-- targe

[PATCH v4 36/48] target/loongarch: Implement xvbitclr xvbitset xvbitrev

2023-08-30 Thread Song Gao
This patch includes: - XVBITCLR[I].{B/H/W/D}; - XVBITSET[I].{B/H/W/D}; - XVBITREV[I].{B/H/W/D}. Signed-off-by: Song Gao --- target/loongarch/vec.h | 4 ++ target/loongarch/insns.decode| 27 +++ target/loongarch/disas.c | 25 +

[PATCH v4 03/48] target/loongarch: Add CHECK_ASXE maccro for check LASX enable

2023-08-30 Thread Song Gao
Reviewed-by: Richard Henderson Signed-off-by: Song Gao --- target/loongarch/cpu.h | 2 ++ target/loongarch/cpu.c | 2 ++ target/loongarch/insn_trans/trans_lasx.c.inc | 10 ++ 3 files changed, 14 insertions(+) diff --git a/target/loongarch/cp

[PATCH v4 09/48] target/loongarch: Implement xvsadd/xvssub

2023-08-30 Thread Song Gao
This patch includes: - XVSADD.{B/H/W/D}[U]; - XVSSUB.{B/H/W/D}[U]. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/insns.decode| 18 ++ target/loongarch/disas.c | 17 + target/loongarch/insn_trans/tr

[PATCH v4 47/48] target/loongarch: Implement xvld xvst

2023-08-30 Thread Song Gao
This patch includes: - XVLD[X], XVST[X]; - XVLDREPL.{B/H/W/D}; - XVSTELM.{B/H/W/D}. Signed-off-by: Song Gao --- target/loongarch/insns.decode| 18 + target/loongarch/disas.c | 24 ++ target/loongarch/insn_trans/trans_lasx.c.inc | 80 +++

[PATCH v4 23/48] target/loongarch: Implement xvsigncov

2023-08-30 Thread Song Gao
This patch includes: - XVSIGNCOV.{B/H/W/D}. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/vec.h | 2 ++ target/loongarch/insns.decode| 5 + target/loongarch/disas.c | 5 + target/loongarch/vec_helper

[PATCH v4 41/48] target/loongarch: Implement xvfcmp

2023-08-30 Thread Song Gao
This patch includes: - XVFCMP.cond.{S/D}. Signed-off-by: Song Gao --- target/loongarch/helper.h| 8 +- target/loongarch/insns.decode| 3 + target/loongarch/disas.c | 94 target/loongarch/vec_helper.c|

[PATCH v4 01/48] target/loongarch: Add LASX data support

2023-08-30 Thread Song Gao
Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/cpu.h | 24 -- target/loongarch/internals.h| 22 target/loongarch/vec.h | 33 ++ linux-user/loongarch64/signal.c | 1 + target/l

[PATCH v4 43/48] target/loongarch: Implement xvinsgr2vr xvpickve2gr

2023-08-30 Thread Song Gao
This patch includes: - XVINSGR2VR.{W/D}; - XVPICKVE2GR.{W/D}[U]. Signed-off-by: Song Gao --- target/loongarch/insns.decode| 7 +++ target/loongarch/disas.c | 18 target/loongarch/insn_trans/trans_lasx.c.inc | 48 3 files changed,

[PATCH v4 25/48] target/loognarch: Implement xvldi

2023-08-30 Thread Song Gao
This patch includes: - XVLDI. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/insns.decode| 2 ++ target/loongarch/disas.c | 7 +++ target/loongarch/insn_trans/trans_lasx.c.inc | 2 ++ target/loongarch/insn_trans/trans_lsx.c.in

[PATCH v4 20/48] target/loongarch: Implement xvsat

2023-08-30 Thread Song Gao
This patch includes: - XVSAT.{B/H/W/D}[U]. Signed-off-by: Song Gao --- target/loongarch/insns.decode| 9 target/loongarch/disas.c | 9 target/loongarch/vec_helper.c| 48 ++-- target/loongarch/insn_trans/trans_lasx.c.

[PATCH v4 02/48] target/loongarch: meson.build support build LASX

2023-08-30 Thread Song Gao
Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/translate.c | 1 + target/loongarch/insn_trans/trans_lasx.c.inc | 6 ++ 2 files changed, 7 insertions(+) create mode 100644 target/loongarch/insn_trans/trans_lasx.c.inc diff --git a/target/loongarch

[PATCH v4 31/48] target/loongarch: Implement xvsrlrn xvsrarn

2023-08-30 Thread Song Gao
This patch includes: - XVSRLRN.{B.H/H.W/W.D}; - XVSRARN.{B.H/H.W/W.D}; - XVSRLRNI.{B.H/H.W/W.D/D.Q}; - XVSRARNI.{B.H/H.W/W.D/D.Q}. Signed-off-by: Song Gao --- target/loongarch/insns.decode| 16 ++ target/loongarch/disas.c | 16 ++ target/loongarch/vec_helper

[PATCH v4 11/48] target/loongarch: Implement xvhaddw/xvhsubw

2023-08-30 Thread Song Gao
This patch includes: - XVHADDW.{H.B/W.H/D.W/Q.D/HU.BU/WU.HU/DU.WU/QU.DU}; - XVHSUBW.{H.B/W.H/D.W/Q.D/HU.BU/WU.HU/DU.WU/QU.DU}. Signed-off-by: Song Gao --- target/loongarch/vec.h | 3 ++ target/loongarch/insns.decode| 18 ++ target/loongarch/disas.c

[PATCH v4 28/48] target/loongarch: Implement xvsllwil xvextl

2023-08-30 Thread Song Gao
This patch includes: - XVSLLWIL.{H.B/W.H/D.W}; - XVSLLWIL.{HU.BU/WU.HU/DU.WU}; - XVEXTL.Q.D, VEXTL.QU.DU. Signed-off-by: Song Gao --- target/loongarch/insns.decode| 9 target/loongarch/disas.c | 9 target/loongarch/vec_helper.c| 44

[PATCH v4 16/48] target/loongarch: Implement xvmax/xvmin

2023-08-30 Thread Song Gao
This patch includes: - XVMAX[I].{B/H/W/D}[U]; - XVMIN[I].{B/H/W/D}[U]. Signed-off-by: Song Gao --- target/loongarch/vec.h | 3 ++ target/loongarch/insns.decode| 36 target/loongarch/disas.c | 34 ++ t

[PATCH v4 38/48] target/loongarch: Implement LASX fpu arith instructions

2023-08-30 Thread Song Gao
This patch includes: - XVF{ADD/SUB/MUL/DIV}.{S/D}; - XVF{MADD/MSUB/NMADD/NMSUB}.{S/D}; - XVF{MAX/MIN}.{S/D}; - XVF{MAXA/MINA}.{S/D}; - XVFLOGB.{S/D}; - XVFCLASS.{S/D}; - XVF{SQRT/RECIP/RSQRT}.{S/D}. Signed-off-by: Song Gao --- target/loongarch/insns.decode| 41 ++ target/

[PATCH v4 32/48] target/loongarch: Implement xvssrln xvssran

2023-08-30 Thread Song Gao
This patch includes: - XVSSRLN.{B.H/H.W/W.D}; - XVSSRAN.{B.H/H.W/W.D}; - XVSSRLN.{BU.H/HU.W/WU.D}; - XVSSRAN.{BU.H/HU.W/WU.D}; - XVSSRLNI.{B.H/H.W/W.D/D.Q}; - XVSSRANI.{B.H/H.W/W.D/D.Q}; - XVSSRLNI.{BU.H/HU.W/WU.D/DU.Q}; - XVSSRANI.{BU.H/HU.W/WU.D/DU.Q}. Signed-off-by: Song Gao --- target/loonga

Re: [PATCH v3 2/2] vhost: Add Error parameter to vhost_scsi_common_start()

2023-08-30 Thread Raphael Norwitz
> On Aug 30, 2023, at 12:57 AM, Li Feng wrote: > > Add a Error parameter to report the real error, like vhost-user-blk. > Reviewed-by: Raphael Norwitz > Signed-off-by: Li Feng > --- > hw/scsi/vhost-scsi-common.c | 16 +--- > hw/scsi/vhost-scsi.c | 5

[PATCH v4 45/48] target/loongarch: Implement xvpack xvpick xvilv{l/h}

2023-08-30 Thread Song Gao
This patch includes: - XVPACK{EV/OD}.{B/H/W/D}; - XVPICK{EV/OD}.{B/H/W/D}; - XVILV{L/H}.{B/H/W/D}. Signed-off-by: Song Gao --- target/loongarch/insns.decode| 27 target/loongarch/disas.c | 27 target/loongarch/vec_helper.c| 138

[PATCH v4 29/48] target/loongarch: Implement xvsrlr xvsrar

2023-08-30 Thread Song Gao
This patch includes: - XVSRLR[I].{B/H/W/D}; - XVSRAR[I].{B/H/W/D}. Signed-off-by: Song Gao --- target/loongarch/insns.decode| 17 + target/loongarch/disas.c | 18 ++ target/loongarch/vec_helper.c| 12

[PATCH v4 44/48] target/loongarch: Implement xvreplve xvinsve0 xvpickve xvb{sll/srl}v

2023-08-30 Thread Song Gao
This patch includes: - XVREPLVE.{B/H/W/D}; - XVREPL128VEI.{B/H/W/D}; - XVREPLVE0.{B/H/W/D/Q}; - XVINSVE0.{W/D}; - XVPICKVE.{W/D}; - XVBSLL.V, XVBSRL.V. Signed-off-by: Song Gao --- target/loongarch/helper.h| 5 + target/loongarch/insns.decode| 25 targe

[PATCH v4 48/48] target/loongarch: CPUCFG support LASX

2023-08-30 Thread Song Gao
Signed-off-by: Song Gao --- target/loongarch/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c index 4deae22104..e03f71222a 100644 --- a/target/loongarch/cpu.c +++ b/target/loongarch/cpu.c @@ -392,6 +392,7 @@ static void loongarch_la464_init

[PATCH v4 37/48] target/loongarch: Implement xvfrstp

2023-08-30 Thread Song Gao
This patch includes: - XVFRSTP[I].{B/H}. Signed-off-by: Song Gao --- target/loongarch/insns.decode| 5 ++ target/loongarch/disas.c | 5 ++ target/loongarch/vec_helper.c| 48 target/loongarch/insn_trans/trans_lasx.c.inc |

[PATCH v4 39/48] target/loongarch: Implement LASX fpu fcvt instructions

2023-08-30 Thread Song Gao
This patch includes: - XVFCVT{L/H}.{S.H/D.S}; - XVFCVT.{H.S/S.D}; - XVFRINT[{RNE/RZ/RP/RM}].{S/D}; - XVFTINT[{RNE/RZ/RP/RM}].{W.S/L.D}; - XVFTINT[RZ].{WU.S/LU.D}; - XVFTINT[{RNE/RZ/RP/RM}].W.D; - XVFTINT[{RNE/RZ/RP/RM}]{L/H}.L.S; - XVFFINT.{S.W/D.L}[U]; - X[CVFFINT.S.L, VFFINT{L/H}.D.W. Signed-off

[PATCH v4 12/48] target/loongarch: Implement xvaddw/xvsubw

2023-08-30 Thread Song Gao
This patch includes: - XVADDW{EV/OD}.{H.B/W.H/D.W/Q.D}[U]; - XVSUBW{EV/OD}.{H.B/W.H/D.W/Q.D}[U]; - XVADDW{EV/OD}.{H.BU.B/W.HU.H/D.WU.W/Q.DU.D}. Signed-off-by: Song Gao --- target/loongarch/insns.decode| 45 +++ target/loongarch/disas.c | 43 +++ targ

[PATCH v4 33/48] target/loongarch: Implement xvssrlrn xvssrarn

2023-08-30 Thread Song Gao
This patch includes: - XVSSRLRN.{B.H/H.W/W.D}; - XVSSRARN.{B.H/H.W/W.D}; - XVSSRLRN.{BU.H/HU.W/WU.D}; - XVSSRARN.{BU.H/HU.W/WU.D}; - XVSSRLRNI.{B.H/H.W/W.D/D.Q}; - XVSSRARNI.{B.H/H.W/W.D/D.Q}; - XVSSRLRNI.{BU.H/HU.W/WU.D/DU.Q}; - XVSSRARNI.{BU.H/HU.W/WU.D/DU.Q}. Signed-off-by: Song Gao --- targe

[PATCH v4 46/48] target/loongarch: Implement xvshuf xvperm{i} xvshuf4i xvextrins

2023-08-30 Thread Song Gao
This patch includes: - XVSHUF.{B/H/W/D}; - XVPERM.W; - XVSHUF4i.{B/H/W/D}; - XVPERMI.{W/D/Q}; - XVEXTRINS.{B/H/W/D}. Signed-off-by: Song Gao --- target/loongarch/helper.h| 3 + target/loongarch/vec.h | 2 + target/loongarch/insns.decode

[PATCH v4 22/48] target/loongarch: Implement vext2xv

2023-08-30 Thread Song Gao
This patch includes: - VEXT2XV.{H/W/D}.B, VEXT2XV.{HU/WU/DU}.BU; - VEXT2XV.{W/D}.B, VEXT2XV.{WU/DU}.HU; - VEXT2XV.D.W, VEXT2XV.DU.WU. Signed-off-by: Song Gao --- target/loongarch/helper.h| 13 + target/loongarch/insns.decode| 13 + target/loong

[PATCH v4 15/48] target/loongarch: Implement xvadda

2023-08-30 Thread Song Gao
This patch includes: - XVADDA.{B/H/W/D}. Signed-off-by: Song Gao --- target/loongarch/vec.h | 2 ++ target/loongarch/insns.decode| 5 target/loongarch/disas.c | 5 target/loongarch/vec_helper.c| 24 ++-

[PATCH v4 24/48] target/loongarch: Implement xvmskltz/xvmskgez/xvmsknz

2023-08-30 Thread Song Gao
This patch includes: - XVMSKLTZ.{B/H/W/D}; - XVMSKGEZ.B; - XVMSKNZ.B. Signed-off-by: Song Gao --- target/loongarch/insns.decode| 7 ++ target/loongarch/disas.c | 7 ++ target/loongarch/vec_helper.c| 80 ++-- target/loongarch/i

[PATCH v4 40/48] target/loongarch: Implement xvseq xvsle xvslt

2023-08-30 Thread Song Gao
This patch includes: - XVSEQ[I].{B/H/W/D}; - XVSLE[I].{B/H/W/D}[U]; - XVSLT[I].{B/H/W/D/}[U]. Signed-off-by: Song Gao --- target/loongarch/vec.h | 4 + target/loongarch/insns.decode| 43 +++ target/loongarch/disas.c | 43 +++ target/l

[PATCH v4 14/48] target/loongarch: Implement xvabsd

2023-08-30 Thread Song Gao
This patch includes: - XVABSD.{B/H/W/D}[U]. Signed-off-by: Song Gao Reviewed-by: Richard Henderson --- target/loongarch/vec.h | 2 ++ target/loongarch/insns.decode| 9 + target/loongarch/disas.c | 9 + target/loongarch/ve

[PATCH v4 42/48] target/loongarch: Implement xvbitsel xvset

2023-08-30 Thread Song Gao
This patch includes: - XVBITSEL.V; - XVBITSELI.B; - XVSET{EQZ/NEZ}.V; - XVSETANYEQZ.{B/H/W/D}; - XVSETALLNEZ.{B/H/W/D}. Signed-off-by: Song Gao --- target/loongarch/helper.h| 16 +++ target/loongarch/insns.decode| 15 +++ target/loongarch/disas.c

[PATCH v4 13/48] target/loongarch: Implement xavg/xvagr

2023-08-30 Thread Song Gao
This patch includes: - XVAVG.{B/H/W/D/}[U]; - XVAVGR.{B/H/W/D}[U]. Signed-off-by: Song Gao --- target/loongarch/vec.h | 3 +++ target/loongarch/insns.decode| 17 + target/loongarch/disas.c | 17 + target/loongarch

[PATCH v4 21/48] target/loongarch: Implement xvexth

2023-08-30 Thread Song Gao
This patch includes: - XVEXTH.{H.B/W.H/D.W/Q.D}; - XVEXTH.{HU.BU/WU.HU/DU.WU/QU.DU}. Signed-off-by: Song Gao --- target/loongarch/insns.decode| 9 + target/loongarch/disas.c | 9 + target/loongarch/vec_helper.c| 36 +--

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

2023-08-30 Thread Laszlo Ersek
On 8/30/23 10:41, Laszlo Ersek wrote: > I'm adding Stefan to the CC list, and an additional piece of explanation > below: > > On 8/27/23 20:29, Laszlo Ersek wrote: >> (1) The virtio-1.0 specification >> writes: >> >>> 3 General I

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

2023-08-30 Thread Laszlo Ersek
On 8/30/23 10:59, Laszlo Ersek wrote: > On 8/30/23 10:41, Laszlo Ersek wrote: >> I'm adding Stefan to the CC list, and an additional piece of explanation >> below: >> >> On 8/27/23 20:29, Laszlo Ersek wrote: >>> (1) The virtio-1.0 specification >>>

Re: [PATCH 3/7] vhost-user: factor out "vhost_user_write_msg"

2023-08-30 Thread Laszlo Ersek
On 8/30/23 10:31, Stefano Garzarella wrote: > On Sun, Aug 27, 2023 at 08:29:33PM +0200, Laszlo Ersek wrote: >> The tails of the "vhost_user_set_vring_addr" and "vhost_user_set_u64" >> functions are now byte-for-byte identical. Factor the common tail out >> to a >> new function called "vhost_user_wr

Re: [PATCH 5/6] vfio/migration: Block VFIO migration with postcopy migration

2023-08-30 Thread Avihai Horon
On 30/08/2023 11:37, Cédric Le Goater wrote: External email: Use caution opening links or attachments On 8/30/23 09:01, Avihai Horon wrote: On 29/08/2023 21:27, Peter Xu wrote: External email: Use caution opening links or attachments On Tue, Aug 29, 2023 at 07:20:47PM +0300, Avihai Horon

Re: [Qemu-devel] [PATCH] acpi: Add emulated sleep button

2023-08-30 Thread Igor Mammedov
On Tue, 1 Aug 2023 13:00:02 -0400 "Annie.li" wrote: > Hi Igor, > > On 7/14/2023 10:04 AM, Igor Mammedov wrote: > > On Fri, 7 Jul 2023 13:43:36 -0400 > > "Annie.li" wrote: > > > >> Hi Igor, > >> > >> Revisiting this thread and have more questions, please clarify, thank you! > >> > >> On 9/20/2

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

2023-08-30 Thread Laszlo Ersek
On 8/30/23 10:39, Stefano Garzarella wrote: > On Sun, Aug 27, 2023 at 08:29:37PM +0200, Laszlo Ersek wrote: >> (1) The virtio-1.0 specification >> writes: > > What about referring the latest spec available now (1.2)? I didn't want t

Re: [PATCH 0/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

2023-08-30 Thread Laszlo Ersek
On 8/30/23 10:48, Stefano Garzarella wrote: > On Sun, Aug 27, 2023 at 08:29:30PM +0200, Laszlo Ersek wrote: >> The last patch in the series states and fixes the problem; prior patches >> only refactor the code. > > Thanks for the fix and great cleanup! > > I fully reviewed the series and LGTM. >

Re: [PATCH 2/2] hw/riscv/virt.c: fix non-KVM --enable-debug build

2023-08-30 Thread Daniel Henrique Barboza
On 8/29/23 22:26, Richard Henderson wrote: On 8/29/23 16:51, Daniel Henrique Barboza wrote: The compiler certainly does eliminate 0 && foo(), even at -O0. There must be something else going on. Pointer to your tree? It's this tree: https://github.com/alistair23/qemu/tree/riscv-to-apply.ne

[PATCH 00/67] Make pixman an optional dependency

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau Hi, QEMU system emulators can be made to compile and work without pixman. Given how pervasively pixman types and API is used in all the code base, it was a bit difficult to figure out how to cut the dependency. I decided that it was important to keep VGA and graphics de

[PATCH 03/67] ui/qmp: move screendump to ui-qmp-cmds.c

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau console.c unit is over-crowded. This code is specific to the handling of the QMP screendump command, so move it in ui-qmp-cmds. Signed-off-by: Marc-André Lureau --- include/ui/console.h | 1 + ui/console.c | 212 --- ui/

[PATCH 10/67] ui/console: new_console() cannot fail

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau There is no code path that could allow a NULL return there. Signed-off-by: Marc-André Lureau --- ui/console.c | 5 - 1 file changed, 5 deletions(-) diff --git a/ui/console.c b/ui/console.c index ba79c735b7..8c4626f255 100644 --- a/ui/console.c +++ b/ui/console.c @@

[PATCH 01/67] ui: remove qemu_pixman_color() helper

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau Usage removed in commit e27bd65a72d ("console: switch color_table_rgb to pixman_color_t") Signed-off-by: Marc-André Lureau --- include/ui/qemu-pixman.h | 1 - ui/qemu-pixman.c | 11 --- 2 files changed, 12 deletions(-) diff --git a/include/ui/qemu-pix

[PATCH 04/67] ui/vc: replace vc_chr_write() with generic qemu_chr_write()

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau We shouldn't call the callback directly, but use the chardev API, unless there is a clear reason. Signed-off-by: Marc-André Lureau --- ui/console.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/console.c b/ui/console.c index 9c17024dbc..a4

[PATCH 05/67] ui/vc: drop have_text

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau If there are no "text" listener, the callback will simply be ignored. The rest of text handling can be done cheaply. This allows to remove some dependency on DisplayState from VC implementation. Signed-off-by: Marc-André Lureau --- ui/console.c | 42 +--

[PATCH 02/67] ui: remove qemu_pixman_linebuf_copy()

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau Since commit 43c7d8bd449 ("console: add qemu_pixman_linebuf_copy"), it seems it was never used. Signed-off-by: Marc-André Lureau --- include/ui/qemu-pixman.h | 2 -- ui/qemu-pixman.c | 8 2 files changed, 10 deletions(-) diff --git a/include/ui/qemu-pi

[PATCH 08/67] ui/console: drop have_gfx

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau All usages have been removed. Signed-off-by: Marc-André Lureau --- ui/console.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/ui/console.c b/ui/console.c index 2bc4c153de..fc1836782d 100644 --- a/ui/console.c +++ b/ui/console.c @@ -132,7 +132,6 @@ struct Dis

[PATCH 11/67] ui/vc: VC always has a DisplayState now

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/console.c | 4 1 file changed, 4 deletions(-) diff --git a/ui/console.c b/ui/console.c index 8c4626f255..2b8022dfbe 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1067,10 +1067,6 @@ static int vc_chr_write(Chardev *chr, con

[PATCH 07/67] ui/console: call dpy_gfx_update() regardless of have_gfx

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau The function will handle the case when no listeners are gfx, without extra meaningful cost. This allows to get rid of DisplayState dependency in VC implementation. Signed-off-by: Marc-André Lureau --- ui/console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 17/67] ui/console: use OBJECT_DEFINE_TYPE for QemuConsole

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau The following patch will move some object initialization to the corresponding handlers. Signed-off-by: Marc-André Lureau --- ui/console.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/ui/console.c b/ui/console.c in

[PATCH 21/67] ui/console: register the console from qemu_console_init()

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/console.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ui/console.c b/ui/console.c index dd8e8db525..02a24eaf5d 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1366,6 +1366,7 @@ qemu_console_init(Object *o

[PATCH 13/67] ui/vc: replace variable with static text attributes default

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/console.c | 30 +- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/ui/console.c b/ui/console.c index ad6fbb1d0f..9d8406f2a2 100644 --- a/ui/console.c +++ b/ui/console.c @@ -52,6 +52,11 @@

[PATCH 12/67] ui/vc: move VCChardev declaration at the top

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau To allow easier refactoring in following patches. Signed-off-by: Marc-André Lureau --- ui/console.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ui/console.c b/ui/console.c index 2b8022dfbe..ad6fbb1d0f 100644 --- a/ui/console.c +++ b/

Re: [PATCH v2 1/4] nbd: drop unused nbd_receive_negotiate() aio_context argument

2023-08-30 Thread Philippe Mathieu-Daudé
On 29/8/23 18:06, Stefan Hajnoczi wrote: aio_context is always NULL, so drop it. Suggested-by: Fabiano Rosas Signed-off-by: Stefan Hajnoczi --- include/block/nbd.h | 3 +-- nbd/client-connection.c | 3 +-- nbd/client.c| 5 ++--- qemu-nbd.c | 4 ++-- 4 files c

[PATCH 16/67] ui/vc: move VCCharDev specific fields out of QemuConsole

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/console.c | 147 +-- 1 file changed, 73 insertions(+), 74 deletions(-) diff --git a/ui/console.c b/ui/console.c index 8fe39aa5e3..b9b545fa3d 100644 --- a/ui/console.c +++ b/ui/consol

[PATCH 20/67] ui/console: instantiate a specific console type

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau This will allow to move code/data to the specific console types. Replace console_type_t with object type check. QemuConsole can be abstract. Signed-off-by: Marc-André Lureau --- ui/console.c | 47 +++ 1 file changed, 19 inse

[PATCH 18/67] ui/console: change new_console() to use object initialization

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau Object construction should be done in respective object instance and class handlers. Introduce qemu_console_register() to split out the registration logic. Signed-off-by: Marc-André Lureau --- ui/console.c | 93 +++- 1 fi

[PATCH 14/67] ui/vc: fold text_update_xy()

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/console.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/ui/console.c b/ui/console.c index 9d8406f2a2..e96f154cc0 100644 --- a/ui/console.c +++ b/ui/console.c @@ -425,14 +425,6 @@ static void text

[PATCH 06/67] ui/console: console_select() regardless of have_gfx

2023-08-30 Thread marcandre . lureau
From: Marc-André Lureau Even if we don't have a gfx listener, we should call displaychangelistener_display_console() which handle that case correctly. Signed-off-by: Marc-André Lureau --- ui/console.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/ui/console.c b

Re: [PATCH v2 2/4] nbd: drop unused nbd_start_negotiate() aio_context argument

2023-08-30 Thread Philippe Mathieu-Daudé
On 29/8/23 18:06, Stefan Hajnoczi wrote: aio_context is always NULL, so drop it. Suggested-by: Fabiano Rosas Signed-off-by: Stefan Hajnoczi --- nbd/client.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

  1   2   3   4   5   >