On Aug 11 18:47, Peter Maydell wrote:
> The QEMU codebase has very few C variable length arrays, and if we can
> get rid of them all we can make the compiler error on new additions.
> This is a defensive measure against security bugs where an on-stack
> dynamic allocation isn't correctly size-check
14.08.2023 10:01, Claudio Imbrenda wrote:
I think we could guard the offending item with CONFIG_SOFTMMU for now,
to immediately fix the issues you raised, and do the refactoring you
proposed later (e.g. next cycle).
I don't think rushing for the last-minute fix is necessary in this case.
It ha
On Sat, 12 Aug 2023 12:48:14 +0300
Michael Tokarev wrote:
> 12.08.2023 12:38, Michael Tokarev wrote:
> ...
> > It smells like, at the very least, os-posix.c should be split. We shouldn't
> > include
> > a ton of qemu-system functionality (like very specific option parsing) into
> > qemu-nbd
> >
On 10/08/2023 17.36, Alex Bennée wrote:
Even with --quiet docker will spam the sha256 to the console. Avoid
this by redirecting stdout. While we are at it fix the name we echo
which was broken during 0b1a649047 (tests/docker: use direct RUNC call
to build containers).
Signed-off-by: Alex Bennée
Hi Babu,
On Fri, Aug 04, 2023 at 10:48:29AM -0500, Moger, Babu wrote:
> Date: Fri, 4 Aug 2023 10:48:29 -0500
> From: "Moger, Babu"
> Subject: Re: [PATCH v3 14/17] i386: Use CPUCacheInfo.share_level to encode
> CPUID[4]
>
> Hi Zhao,
>
> On 8/4/23 04:48, Zhao Liu wrote:
> > Hi Babu,
> >
> > On
On Mon, 14 Aug 2023 10:12:35 +0300
Michael Tokarev wrote:
> 14.08.2023 10:01, Claudio Imbrenda wrote:
>
> > I think we could guard the offending item with CONFIG_SOFTMMU for now,
> > to immediately fix the issues you raised, and do the refactoring you
> > proposed later (e.g. next cycle).
>
>
在 2023/8/11 下午11:23, Richard Henderson 写道:
On 8/11/23 03:02, Song Gao wrote:
The default check parmeter is ALL, remove TRANS_64 marco.
Suggested-by: Richard Henderson
Signed-off-by: Song Gao
If you're going to remove TRANS_64, you should simply drop the patch
that added it, and be careful
在 2023/8/12 上午12:13, Richard Henderson 写道:
On 8/11/23 03:02, Song Gao wrote:
Signed-off-by: Song Gao
---
target/loongarch/insn_trans/trans_atomic.c.inc | 12
target/loongarch/translate.h | 1 +
2 files changed, 13 insertions(+)
diff --git a/target/loongarch/
Hi, Richard
在 2023/8/12 上午12:00, Richard Henderson 写道:
On 8/11/23 03:02, Song Gao wrote:
The la32 manual from [1], and it is not the final version.
[1]:
https://www.loongson.cn/uploads/images/2023041918122813624.%E9%BE%99%E8%8A%AF%E6%9E%B6%E6%9E%8432%E4%BD%8D%E7%B2%BE%E7%AE%80%E7%89%88%E5%8F%
在 2023/8/12 上午12:09, Richard Henderson 写道:
On 8/11/23 03:02, Song Gao wrote:
Signed-off-by: Song Gao
---
.../loongarch/insn_trans/trans_farith.c.inc | 96 ---
target/loongarch/insn_trans/trans_fcmp.c.inc | 8 ++
target/loongarch/insn_trans/trans_fcnv.c.inc | 56 +
Hi Pawan, hi Daniel
Thanks for the patch.
I tried similar patch on Icelake server:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 57 bits virtual
14.08.2023 10:27, Claudio Imbrenda wrote:
On Mon, 14 Aug 2023 10:12:35 +0300
Michael Tokarev wrote:
14.08.2023 10:01, Claudio Imbrenda wrote:
I think we could guard the offending item with CONFIG_SOFTMMU for now,
to immediately fix the issues you raised, and do the refactoring you
proposed l
Hi, all.
I've researched an issue a bit. And what can we do?
In the case of an "old" kernel 5.4, we need to load RSS eBPF without
BPF_F_MAPPABLE
and use bpf syscall to update the maps. This requires additional capabilities,
and the libvirtd will never give any capabilities to Qemu.
So, the only ca
W dniu 10.08.2023 o 19:12, Peter Maydell pisze:
On Thu, 10 Aug 2023 at 18:05, Richard Henderson
On 8/10/23 08:49, Peter Maydell wrote:
On Thu, 10 Aug 2023 at 03:36, Richard Henderson
Will sbsa-ref want this core ?
It only has 40 PA bits, and I think sbsa-ref requires 48.
Yes, it does w
To configure the zoned format feature on the qcow2 driver, it
requires following arguments: the device size, zoned profile,
zoned model, zone size, zone capacity, number of conventional
zones, limits on zone resources (max append sectors, max open
zones, and max_active_zones). The zoned profile opt
By adding zone operations and zoned metadata, the zoned emulation
capability enables full emulation support of zoned device using
a qcow2 file. The zoned device metadata includes zone type,
zoned device state and write pointer of each zone, which is stored
to an array of unsigned integers.
Each zo
在 2023/8/11 下午11:18, Richard Henderson 写道:
On 8/11/23 01:12, gaosong wrote:
+TRANS_64(sra_d, gen_rrr, EXT_NONE, EXT_NONE, EXT_NONE, gen_sra_d)
TRANS(rotr_w, gen_rrr, EXT_ZERO, EXT_NONE, EXT_SIGN, gen_rotr_w)
TRANS_64(rotr_w, ...)
...
TRANS(rotri_w, gen_rri_v, EXT_NONE, EXT_NONE, gen_rotr_
Add the specs for the zoned format feature of the qcow2 driver. If
the zoned_profile is set to `zbc`, then the qcow2 file can be taken
as zoned device and passed through by virtio-blk device to the guest.
If it's `zns`, then it can be passed through by virtio-blk device or
NVMe ZNS device as a ZNS
This patch series add a new extension - zoned format - to the
qcow2 driver thereby allowing full zoned storage emulation on
the qcow2 img file. Users can attach such a qcow2 file to the
guest as a zoned device.
To create a qcow2 file with zoned format, use command like this:
$ qemu-img create -f q
The zoned format feature can be tested by:
$ tests/qemu-iotests/check zoned-qcow2
Signed-off-by: Sam Li
---
tests/qemu-iotests/tests/zoned-qcow2 | 135 ++
tests/qemu-iotests/tests/zoned-qcow2.out | 140 +++
2 files changed, 275 insertions(+)
create mo
Hi Jonathan,
On Tue, Aug 08, 2023 at 12:57:09PM +0100, Jonathan Cameron via wrote:
> Date: Tue, 8 Aug 2023 12:57:09 +0100
> From: Jonathan Cameron via
> Subject: [RFC PATCH 1/5] hw/acpi: Add PPTT cache descriptions
> X-Mailer: git-send-email 2.39.2
>
> Current PPTT tables generated by QEMU only
Richard Henderson writes:
> It's time for another round on implementing the VDSO for linux-user.
> We are now seeing applications built that absolutely require it,
> and have no fallback for the VDSO to be absent.
Something broke configure for me:
../../configure --disable-docs --disable-s
Jonathan Cameron writes:
> Used to drive the MPAM cache intialization and to exercise more
> of the PPTT cache entry generation code. Perhaps a default
> L3 cache is acceptable for max?
>
> Signed-off-by: Jonathan Cameron
> ---
> target/arm/tcg/cpu64.c | 12
> 1 file changed, 12
Mikhail Tyutin writes:
> From: Aleksandr Anenkov
>
> This commit:
> - adds a plugin API to read the registers of the current CPU
> - introduces qemu_plugin_reg_ctx structure for faster data gathering of
> a set of registers without memory reallocation
> - adds an example plugin showing how t
Akihiko Odaki writes:
> execlog had the following comment:
>> As we could have multiple threads trying to do this we need to
>> serialise the expansion under a lock. Threads accessing already
>> created entries can continue without issue even if the ptr array
>> gets reallocated during resize.
On 13/08/2023 09.46, Waldemar Brodkorb wrote:
Hi,
I am using Qemu 8.0.3 and getting this error:
qemu-system-m68k: ../hw/scsi/scsi-disk.c:557: scsi_write_data: Assertion
`r->req.aiocb == NULL' failed.
It happens f.e. when I extract the glibc source code inside Linux.
Linux 6.1.44, glibc 2.38 is
Akihiko Odaki writes:
> Before this change, the information from a XML file was stored in an
> array that is not descriptive. Introduce a dedicated structure type to
> make it easier to understand and to extend with more fields.
>
> Signed-off-by: Akihiko Odaki
with Phillipe's suggested updat
Akihiko Odaki writes:
> Currently the number of registers exposed to GDB is written as magic
> numbers in code. Derive the number of registers GDB actually see from
> XML files to replace the magic numbers in code later.
>
> Signed-off-by: Akihiko Odaki
Reviewed-by: Alex Bennée
--
Alex Ben
Akihiko Odaki writes:
> This function is useful to determine the number of registers exposed to
> GDB from the XML name.
>
> Signed-off-by: Akihiko Odaki
> ---
> include/exec/gdbstub.h | 2 ++
> gdbstub/gdbstub.c | 13 +
> 2 files changed, 15 insertions(+)
>
> diff --git a/i
Currently, when using `-display dbus,gl=on` all updates to the client
become "full scanout" updates, meaning there is no way for the client to
limit damage regions to the display server.
Instead of using an "update count", this patch tracks the damage region
and propagates it to the client.
This
Thanks for the cleanup! A few comments.
> On Aug 4, 2023, at 1:29 AM, Li Feng wrote:
>
> Add a Error parameter to report the real error, like vhost-user-blk.
>
> Signed-off-by: Li Feng
> ---
> hw/scsi/vhost-scsi-common.c | 17 ++---
> hw/scsi/vhost-scsi.c
Why can’t we rather fix this by adding a “event_cb” param to
vhost_user_async_close and then call qemu_chr_fe_set_handlers in
vhost_user_async_close_bh()?
Even if calling vhost_dev_cleanup() twice is safe today I worry future changes
may easily stumble over the reconnect case and introduce cras
On 03/08/2023 16:28, David Woodhouse wrote:
From: David Woodhouse
A previous implementation of this stuff used a 64-bit field for all of
the port information (vcpu/type/type_val) and did atomic exchanges on
them. When I implemented that in Qemu I regretted my life choices and
just kept it simpl
On 08/08/2023 18:08, David Woodhouse wrote:
From: David Woodhouse
XENFEAT_supervisor_mode_kernel shouldn't be set for HVM guests. It
confuses lscpu into thinking it's running in PVH mode.
No non-cosmetic effects have been observed so far.
Signed-off-by: David Woodhouse
---
Only really cosmet
Hi
On Mon, Aug 14, 2023 at 4:10 PM Bilal Elmoussaoui wrote:
>
> Currently, when using `-display dbus,gl=on` all updates to the client
> become "full scanout" updates, meaning there is no way for the client to
> limit damage regions to the display server.
>
> Instead of using an "update count", th
When running a KVM enabled qemu inside a qemu instance, I get these warnings:
$ qemu-system-riscv64 -cpu host -machine virt,accel=kvm
qemu-system-riscv64: warning: disabling h extension for hart 0x
because privilege spec version does not match
qemu-system-riscv64: warning: disabli
Akihiko Odaki writes:
> This is a tree-wide change to replace gdb_core_xml_file, the path to
> GDB XML file with gdb_core_feature, the pointer to GDBFeature. This
> also replaces the values assigned to gdb_num_core_regs with the
> num_regs member of GDBFeature where applicable to remove magic n
Currently, when using `-display dbus,gl=on` all updates to the client
become "full scanout" updates, meaning there is no way for the client to
limit damage regions to the display server.
Instead of using an "update count", this patch tracks the damage region
and propagates it to the client.
This
Thanks for the quick review! I have sent a v2 with the requested changes.
On Mon, Aug 14, 2023 at 2:41 PM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Hi
>
> On Mon, Aug 14, 2023 at 4:10 PM Bilal Elmoussaoui
> wrote:
> >
> > Currently, when using `-display dbus,gl=on` all updates to
Hi
On Mon, Aug 14, 2023 at 4:58 PM Bilal Elmoussaoui wrote:
>
> Currently, when using `-display dbus,gl=on` all updates to the client
> become "full scanout" updates, meaning there is no way for the client to
> limit damage regions to the display server.
>
> Instead of using an "update count", th
That is fine, it is not something we need urgently as we still need a
kernel patch to make virtio gpu use the KMS atomic API in Mutter. Am I
supposed to send a new patch with the "Reviewed-by" part in the commit
message or?
On Mon, Aug 14, 2023 at 3:02 PM Marc-André Lureau <
marcandre.lur...@redha
Akihiko Odaki writes:
> In preparation for a change to use GDBFeature as a parameter of
> gdb_register_coprocessor(), convert the internal representation of
> dynamic feature from plain XML to GDBFeature.
FWIW one of the aims I had with my stalled rewrite of the register API
was to move all th
Akihiko Odaki writes:
> This is a tree-wide change to introduce GDBFeature parameter to
> gdb_register_coprocessor(). The new parameter just replaces num_regs
> and xml parameters for now. GDBFeature will be utilized to simplify XML
> lookup in a following change.
>
> Signed-off-by: Akihiko Oda
Akihiko Odaki writes:
> This is a tree-wide change to replace gdb_core_xml_file, the path to
> GDB XML file with gdb_core_feature, the pointer to GDBFeature. This
> also replaces the values assigned to gdb_num_core_regs with the
> num_regs member of GDBFeature where applicable to remove magic n
Akihiko Odaki writes:
> This function is no longer used.
>
> Signed-off-by: Akihiko Odaki
Reviewed-by: Alex Bennée
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
Akihiko Odaki writes:
> Now we know all instances of GDBFeature that is used in CPU so we can
> traverse them to find XML. This removes the need for a CPU-specific
> lookup function for dynamic XMLs.
>
> Signed-off-by: Akihiko Odaki
> ---
> gdbstub/gdbstub.c | 28 +---
Akihiko Odaki writes:
> These members will be used to help plugins to identify registers.
I'm wary of exposing gdb'isms directly to plugins. However making stuff
easier for the gdbstub internals is ok. I shall reserve judgement until
I've read the rest of the series.
> The added members in i
Am 06.07.2023 um 16:43 hat Paolo Bonzini geschrieben:
> Queued, thanks.
This patch broke qemu-iotests 109 (for raw images), some block jobs get
now paused once more. This is probably okay, but please double check and
fix either the reference output or the code.
Kevin
Am 17.07.2023 um 16:55 hat Denis V. Lunev geschrieben:
> Commit e6df58a5578fee7a50bbf36f4a50a2781cff855d
> Author: Hanna Reitz
> Date: Wed May 8 23:18:18 2019 +0200
> qemu-nbd: Do not close stderr
> has introduced an interesting regression. Original behavior of
> ssh somehost qem
Sorry, I should have mentioned this for v1 already, but better late than
never: We need to replace this patch with a proper header update later (via
the scripts/update-linux-headers.sh script) - so in case you respin, please
mark it with NOTFORMERGE or PLACEHOLDER or something similar in the
When running "make check-block SPEED=slow -j$(nproc)", the test 183
fails due to the very low default timeout value since the system is
quite loaded and thus slower in this case. We need a much higher
value when running tests in parallel, so let's try to detect this
situation by looking for "-j..."
"chenyuhui (A)" via writes:
> On 2023/7/26 0:53, Peter Xu wrote:
>> On Tue, Jul 25, 2023 at 04:43:28PM +0800, chenyuhui (A) wrote:
>>> @Peter Xu @Fabiano Rosas
>>> Kindly ping on this.
>>
>> Ah I see what's missing - please copy maintainer (Juan) for any migration
>> patches, especially multifd
Akihiko Odaki writes:
> These members will be used to help plugins to identify registers.
>
> Signed-off-by: Akihiko Odaki
> ---
> target/arm/gdbstub.c | 46 +++---
> target/arm/gdbstub64.c | 42 +-
> 2 files changed, 5
Hi
On Mon, Aug 14, 2023 at 5:08 PM Bilal Elmoussaoui wrote:
>
> That is fine, it is not something we need urgently as we still need a kernel
> patch to make virtio gpu use the KMS atomic API in Mutter. Am I supposed to
> send a new patch with the "Reviewed-by" part in the commit message or?
>
Akihiko Odaki writes:
> It is based on GDB protocol to ensure interface stability.
See comments bellow.
> The timing of the vcpu init hook is also changed so that the hook will
> get called after GDB features are initialized.
This might be worth splitting to a separate patch for cleaner bise
Akihiko Odaki writes:
> This demonstrates how a register can be read from a plugin.
I think it would be a little more useful as a demo if it tracked changes
to the register state rather than dumping it for every line executed.
>
> Signed-off-by: Akihiko Odaki
> ---
> docs/devel/tcg-plugins.
Akihiko Odaki writes:
> This demonstrates how to write a plugin in C++.
>
> Signed-off-by: Akihiko Odaki
> ---
> docs/devel/tcg-plugins.rst | 8
> configure | 15 ---
> contrib/plugins/Makefile | 5 +
> contrib/plugins/cc.cc | 15
Akihiko Odaki writes:
> I and other people in the University of Tokyo, where I research processor
> design, found TCG plugins are very useful for processor design
> exploration.
Thanks for the submission - I've finished my initial review pass.
I think introducing register introspection into t
On 04/08/2023 10.04, Cédric Le Goater wrote:
Output message are slightly modified to ease selection with wildcards
and to report extra parameters.
Signed-off-by: Cédric Le Goater
---
...
diff --git a/hw/s390x/trace-events b/hw/s390x/trace-events
index
8b9213eab90c31d1eb37816d350bf76e902ccd10
Hi Zhao,
On 8/14/23 03:22, Zhao Liu wrote:
> Hi Babu,
>
> On Fri, Aug 04, 2023 at 10:48:29AM -0500, Moger, Babu wrote:
>> Date: Fri, 4 Aug 2023 10:48:29 -0500
>> From: "Moger, Babu"
>> Subject: Re: [PATCH v3 14/17] i386: Use CPUCacheInfo.share_level to encode
>> CPUID[4]
>>
>> Hi Zhao,
>>
>> O
On Fri, Aug 11, 2023 at 10:31:51AM +0800, Yong Huang wrote:
> Hi, Stefan, thank you for your interest in this series.
> I'm trying to explain my point, if you think my explanation
> doesn't stand up, please let me know.
>
> On Fri, Aug 11, 2023 at 2:33 AM Stefan Hajnoczi wrote:
>
> > On Thu, Au
On Fri, Aug 11, 2023 at 04:34:23PM +0200, Ilya Maximets wrote:
> Lots of virtio functions that are on a hot path in data transmission
> are initializing indirect descriptor cache at the point of stack
> allocation. It's a 112 byte structure that is getting zeroed out on
> each call adding unnecess
Hi,
These are a few small things I have found helpful while trying to
implement and test rr changes. Patch 2 depends on 1, but otherwise
the patches are independent.
Thanks,
Nick
Nicholas Piggin (4):
scripts/replay_dump.sh: Update to current rr record format
tests/avocado: replay_linux.py ad
This runs replay-dump.py after recording a trace, and fails the test if
the script fails.
replay-dump.py is modified to exit with non-zero if an error is
encountered while parsing.
Signed-off-by: Nicholas Piggin
---
It's possible this could introduce failures to existing test if an
unimplemented
record makes an initial snapshot when the machine is created, to enable
reverse-debugging. Often the issue being debugged appears near the end of
the trace, so it is important for performance to keep snapshots close to
the end.
This implements a periodic snapshot mode that keeps a rolling set of
r
This thing seems to have fallen by the wayside. This gets it working with
the current format, although does not quite implement all events.
Signed-off-by: Nicholas Piggin
---
My python skills are not good. Any help on this or patch 2 is
appreciated.
Thanks,
Nick
scripts/replay-dump.py | 107 ++
When replaying a trace, it is possible to go from shutdown to
running with a reverse-debugging step. This can be useful if the
problem being debugged triggers a reset or shutdown.
Signed-off-by: Nicholas Piggin
---
include/sysemu/runstate.h | 1 +
replay/replay.c | 2 ++
softmmu/runs
The file has been converted to .rst a while ago - make sure that the
references in the trace-events files are pointing to the right location
now.
Signed-off-by: Thomas Huth
---
bsd-user/trace-events | 2 +-
ebpf/trace-events | 2 +-
hw/nubus/trace-events | 2 +-
targe
On 7/26/2023 4:18 PM, Peter Xu wrote:
> On Fri, Jun 30, 2023 at 09:50:41AM -0400, Steven Sistare wrote:
>> On 6/26/2023 2:27 PM, Peter Xu wrote:
>>> On Fri, Jun 23, 2023 at 02:25:05PM -0400, Steven Sistare wrote:
On 6/21/2023 4:28 PM, Peter Xu wrote:
> On Wed, Jun 21, 2023 at 03:15:42PM -0
Restoring a snapshot can break a suspended guest.
If a guest is suspended and saved to a snapshot using savevm, and qemu
is terminated and restarted with the -S option, then loadvm does not
restore the guest. The runstate is running, but the guest is not, because
vm_start was not called. The roo
If qemu starts and loads a VM in the suspended state, then a later wakeup
request directly sets the state to running. This skips vm_start() and its
initialization steps, which is fatal for the guest. See
qemu_system_wakeup_request(), and qemu_system_wakeup() in
main_loop_should_exit().
Remember
Add a test case to verify that the suspended state is handled correctly by
live migration postcopy. The test suspends the src, migrates, then wakes
the dest.
Signed-off-by: Steve Sistare
---
tests/qtest/migration-test.c | 26 --
1 file changed, 24 insertions(+), 2 deleti
Add an option to suspend the src in a-b-bootblock.S, which puts the guest
in S3 state after one round of writing to memory. The option is enabled by
poking a 1 into the suspend_me word in the boot block prior to starting the
src vm. Generate symbol offsets in a-b-bootblock.h so that the suspend_m
Add a test case to verify that the suspended state is handled correctly by
a background migration. The test suspends the src, migrates, then wakes
the dest.
Signed-off-by: Steve Sistare
---
tests/qtest/migration-test.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/t
Create a subroutine for preserving the runstate after migration,
to be used in a subsequent patch. No functional change.
Signed-off-by: Steve Sistare
Reviewed-by: Fabiano Rosas
---
migration/migration.c | 14 ++
migration/migration.h | 1 +
migration/savevm.c| 11 +--
A guest that is migrated in the suspended state automaticaly wakes and
continues execution. This is wrong; the guest should end migration in
the same state it started. The root causes is that the outgoing migration
code automatically wakes the guest, then saves the RUNNING runstate in
global_stat
Add a test case to verify that the suspended state is handled correctly
during live migration precopy. The test suspends the src, migrates, then
wakes the dest.
Signed-off-by: Steve Sistare
---
tests/qtest/migration-helpers.c | 3 ++
tests/qtest/migration-helpers.h | 3 +-
tests/qtest/migrati
Migration of a guest in the suspended runstate is broken. The incoming
migration code automatically tries to wake the guest, which is wrong;
the guest should end migration in the same runstate it started. Further,
for a restored snapshot, the automatic wakeup fails. The runstate is
RUNNING, but
Do not wake a suspended guest during bg_migration.
Signed-off-by: Steve Sistare
---
migration/migration.c | 12 +---
softmmu/runstate.c| 1 +
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 1a5484a..e6b8024 100644
--
Define a state object to capture events seen by migration tests, to allow
more events to be captured in a subsequent patch, and simplify event
checking in wait_for_migration_pass. No functional change.
Signed-off-by: Steve Sistare
Reviewed-by: Fabiano Rosas
---
tests/qtest/migration-helpers.c
KVM_SYNC_GPRS, KVM_SYNC_ACRS, KVM_SYNC_CRS and KVM_SYNC_PREFIX are
available since kernel 3.10. Since we already require at least kernel
3.15 in the s390x KVM code, we can assume that the KVM_CAP_SYNC_REGS
sync code is always possible for these registers, and remove the
related checks and fallbacks
From: Marc-André Lureau
If the PCI BAR isn't yet mapped or was unmapped, QXL_IO_SET_MODE will
assert(). Instead, report a guest bug and keep going.
This can be reproduced with:
cat << EOF | ./qemu-system-x86_64 -vga qxl -m 2048 -nodefaults -qtest stdio
outl 0xcf8 0x8000101c
outl 0xcfc 0xc000
ou
On Mon, Aug 14, 2023 at 02:53:56PM -0400, Steven Sistare wrote:
> > Can we just call vm_state_notify() earlier?
>
> We cannot. The guest is not running yet, and will not be until later.
> We cannot call notifiers that perform actions that complete, or react to,
> the guest entering a running sta
On Thu, Aug 10, 2023 at 10:58:09AM -0500,
Michael Roth via wrote:
> On Tue, Aug 01, 2023 at 09:45:41AM +0800, Xiaoyao Li wrote:
> > On 8/1/2023 12:51 AM, Daniel P. Berrangé wrote:
> > > On Mon, Jul 31, 2023 at 12:21:42PM -0400, Xiaoyao Li wrote:
> > > > This is the first RFC version of enabling K
On Fri, Aug 04, 2023 at 05:30:53PM +0800,
Wei Wang wrote:
> Current migration_completion function is a bit long. Refactor the long
> implementation into different subfunctions:
> - migration_completion_precopy: completion code related to precopy
> - migration_completion_postcopy: completion code
Patch 1 fixes the tls-authz crashing when someone specifies "null"
parameter for tls-authz.
Patch 2 added a test case for all three tls-auth parameters specifying
"null" to make sure nothing will crash ever with 'null' passed into it.
Patch 3-4 are the proposed patches to deduplicate the three mi
QEMU will crash if anyone tries to set tls-authz (which is a type
StrOrNull) with 'null' value. Fix it in the easy way by converting it to
qstring just like the other two tls parameters.
Cc: qemu-sta...@nongnu.org # v4.0+
Fixes: d2f1d29b95 ("migration: add support for a "tls-authz" migration
par
Drop the enum in qapi because it is never used in QMP APIs. Instead making
it an internal definition for QEMU so that we can decouple it from QAPI.
One of the important things is we can deduplicate the documentations on the
various migration parameters.
Signed-off-by: Peter Xu
---
qapi/migratio
Add a test for StrOrNull parameters (tls-*).
Signed-off-by: Peter Xu
---
tests/qtest/migration-test.c | 24
1 file changed, 24 insertions(+)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 62d3f37021..12e72580a6 100644
--- a/tests/qtest/mi
These two structs are mostly identical besides some fields (quote from
Daniel P. Berrangé in his reply):
1c1
< { 'struct': 'MigrationParameters',
---
> { 'struct': 'MigrateSetParameters',
14,16c14,16
< '*tls-creds': 'str',
< '*tls-hostname': 'str',
<
On Tue, Aug 08, 2023 at 04:03:46PM -0400, Peter Xu wrote:
> On Sun, Aug 06, 2023 at 11:49:46AM -0400, Peter Xu wrote:
> > > I think we have a tradeoff here. If perpetuating the unclean and ugly
> > > use of "" is what it takes to de-triplicate migration parameters, we may
> > > decide to accept th
On Fri, 4 Aug 2023 09:35:25 +0200
Thomas Huth wrote:
> The check for nd->model being NULL was originally required, but in
> commit e11f463295d95aba ("s390x/virtio: use qemu_check_nic_model()")
> the corresponding code had been replaced by a call to the function
> qemu_check_nic_model() - and thi
From: Antonio Caggiano
This adds preparatory functions needed to:
- decode blob cmds
- tracking iovecs
Signed-off-by: Antonio Caggiano
Signed-off-by: Dmitry Osipenko
Signed-off-by: Gurchetan Singh
Tested-by: Alyssa Ross
---
hw/display/virtio-gpu.c | 10 +++---
in
From: Antonio Caggiano
The feature can be enabled when a backend wants it.
Signed-off-by: Antonio Caggiano
Reviewed-by: Marc-André Lureau
Signed-off-by: Gurchetan Singh
Tested-by: Alyssa Ross
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Akihiko Odaki
---
hw/display/virtio-gpu-base.c
This modifies the common virtio-gpu.h file have the fields and
defintions needed by gfxstream/rutabaga, by VirtioGpuRutabaga.
The command to run these would be:
Signed-off-by: Gurchetan Singh
Tested-by: Alyssa Ross
---
-device virtio-vga-rutabaga,capset_names=gfxstream-vulkan:cross-domain, \
From: "Dr. David Alan Gilbert"
Define a new capability type 'VIRTIO_PCI_CAP_SHARED_MEMORY_CFG' to allow
defining shared memory regions with sizes and offsets of 2^32 and more.
Multiple instances of the capability are allowed and distinguished
by a device-specific 'id'.
Signed-off-by: Dr. David A
From: Gerd Hoffmann
Use VIRTIO_GPU_SHM_ID_HOST_VISIBLE as id for virtio-gpu.
Signed-off-by: Antonio Caggiano
Tested-by: Alyssa Ross
Acked-by: Michael S. Tsirkin
---
hw/display/virtio-gpu-pci.c| 14 ++
hw/display/virtio-gpu.c| 1 +
hw/display/virtio-vga.c| 33
This adds basic documentation for virtio-gpu.
Suggested-by: Akihiko Odaki
Signed-off-by: Gurchetan Singh
---
v2: - Incorporated suggestions by Akihiko Odaki
- Listed the currently supported capset_names (Bernard)
v3: - Incorporated suggestions by Akihiko Odaki and Alyssa Ross
v4: - Incorpo
From: Gurchetan Singh
Prior versions:
v4:
https://lists.gnu.org/archive/html/qemu-devel/2023-08/msg01566.html
v3:
https://lists.gnu.org/archive/html/qemu-devel/2023-08/msg00565.html
v2:
https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg05801.html
v1:
https://lists.gnu.org/archive/html/
- Add meson detection of rutabaga_gfx
- Build virtio-gpu-rutabaga.c + associated vga/pci files when
present
Signed-off-by: Gurchetan Singh
Tested-by: Alyssa Ross
---
v3: Fix alignment issues (Akihiko)
hw/display/meson.build| 22 ++
meson.build |
1 - 100 of 112 matches
Mail list logo
