[PATCH 29/44] Impl GENET MDIO

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 109 - 1 file changed, 107 insertions(+), 2 deletions(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index 01e6819df4..e633323d17 100644 --- a/hw/net/bcm2838_genet.c +++ b/hw/net/

[PATCH 40/44] Add mailbox property tests. Part 1

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mbox-property-test.c | 179 +++ tests/qtest/meson.build | 2 +- 2 files changed, 180 insertions(+), 1 deletion(-) create mode 100644 tests/qtest/bcm2838-mbox-property-test.c diff --git a/tests/qtest/bc

[PATCH 12/44] Temporary disable unimplemented rpi4b devices

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/raspi.c | 2 +- hw/arm/raspi4b.c| 63 + include/hw/arm/raspi_platform.h | 1 + 3 files changed, 65 insertions(+), 1 deletion(-) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index da1e9e7c

[PULL v2 3/5] qapi/qdev: Tidy up device_add documentation

2023-07-26 Thread Markus Armbruster
The notes section comes out like this: Notes Additional arguments depend on the type. 1. For detailed information about this command, please refer to the ‘docs/qdev-device-use.txt’ file. 2. It’s possible to list device properties by running QEMU with the “-device D

[PATCH 32/44] Enable BCM2838 GENET controller

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_peripherals.c | 16 hw/arm/raspi4b.c | 17 - include/hw/arm/bcm2838_peripherals.h | 2 ++ 3 files changed, 18 insertions(+), 17 deletions(-) diff --git a/hw/arm/bcm2838_peripherals.c b

[PATCH 08/44] Connect SD controller to BCM2838 GPIO

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/gpio/bcm2838_gpio.c | 52 +- include/hw/gpio/bcm2838_gpio.h | 6 2 files changed, 57 insertions(+), 1 deletion(-) diff --git a/hw/gpio/bcm2838_gpio.c b/hw/gpio/bcm2838_gpio.c index cc9f4f74a0..7291e473dc 100644 -

[PATCH 36/44] Add mailbox test constants

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.h | 140 ++ 1 file changed, 140 insertions(+) diff --git a/tests/qtest/bcm2838-mailbox.h b/tests/qtest/bcm2838-mailbox.h index a81b325af9..df223f2cf7 100644 --- a/tests/qtest/bcm2838-mailbox.h +++ b/te

[PATCH 01/44] Split out common part of BCM283X classes

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2836.c | 102 ++- hw/arm/raspi.c | 2 +- include/hw/arm/bcm2836.h | 26 +- 3 files changed, 83 insertions(+), 47 deletions(-) diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c index 166dc

[PATCH 00/44] Raspberry Pi 4B machine

2023-07-26 Thread Sergey Kambalin
Introducing Raspberry Pi 4B model. It contains new BCM2838 SoC, PCIE subsystem, RNG200, Thermal sensor and Genet network controller. It can work with recent linux kernels 6.x.x. Two avocado tests was added to check that. Unit tests has been made as read/write operations via mailbox properties. G

[PATCH 37/44] Add mailbox tests tags. Part 1

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.h | 185 ++ 1 file changed, 185 insertions(+) diff --git a/tests/qtest/bcm2838-mailbox.h b/tests/qtest/bcm2838-mailbox.h index df223f2cf7..1fc34d092d 100644 --- a/tests/qtest/bcm2838-mailbox.h +++ b/te

[PATCH 24/44] Add GENET register structs. Part 2

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- include/hw/net/bcm2838_genet.h | 218 + 1 file changed, 218 insertions(+) diff --git a/include/hw/net/bcm2838_genet.h b/include/hw/net/bcm2838_genet.h index 89b45eb39f..4542f27eba 100644 --- a/include/hw/net/bcm2838_genet.h +++ b

[PATCH 19/44] Add RNG200 timer

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_peripherals.c | 14 hw/arm/raspi4b.c | 1 - hw/misc/bcm2838_rng200.c | 105 --- include/hw/arm/bcm2838_peripherals.h | 2 + 4 files changed, 111 insertions(+), 11 deletions(

[PATCH 22/44] Add GENET stub

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 100 + hw/net/meson.build | 2 + hw/net/trace-events| 17 ++ include/hw/net/bcm2838_genet.h | 40 + 4 files changed, 159 insertions(+) create mode 10064

[PATCH 30/44] Impl GENET TX path

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 170 - include/hw/net/bcm2838_genet.h | 26 + 2 files changed, 195 insertions(+), 1 deletion(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index e633323d17..98030216f4 10064

[PATCH 34/44] Add Rpi4b boot tests

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/avocado/boot_linux_console.py | 92 + 1 file changed, 92 insertions(+) diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py index 6eab515718..62aac02bbb 100644 --- a/tests/avocado/boot_linux_c

[PATCH 33/44] Connect RNG200, PCIE and GENET to GIC

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/hw/arm/bcm2838.c b/hw/arm/bcm2838.c index a1980cc181..83bfbc2cae 100644 --- a/hw/arm/bcm2838.c +++ b/hw/arm/bcm2838.c @@ -217,6 +217,10 @@ static void bcm2838_realize(Devic

[PATCH 28/44] Impl GENET register ops.

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 183 +++-- include/hw/net/bcm2838_genet.h | 2 + 2 files changed, 175 insertions(+), 10 deletions(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index c3e7d90451..01e6819df4 100644

[PATCH 15/44] Add BCM2838 PCIE host

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_pcie.c | 232 +- include/hw/arm/bcm2838_pcie.h | 23 2 files changed, 253 insertions(+), 2 deletions(-) diff --git a/hw/arm/bcm2838_pcie.c b/hw/arm/bcm2838_pcie.c index 522e19f3cf..dd9629ff79 100644 -

[PATCH 42/44] Add mailbox property tests. Part 3

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mbox-property-test.c | 213 ++- 1 file changed, 212 insertions(+), 1 deletion(-) diff --git a/tests/qtest/bcm2838-mbox-property-test.c b/tests/qtest/bcm2838-mbox-property-test.c index bcee9971c6..e833529a00 100644 --- a/

[PATCH 06/44] Add BCM2838 GPIO stub

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/gpio/bcm2838_gpio.c | 136 + hw/gpio/meson.build| 5 +- include/hw/gpio/bcm2838_gpio.h | 39 ++ 3 files changed, 179 insertions(+), 1 deletion(-) create mode 100644 hw/gpio/bcm2838_gpio.c create

[PATCH 20/44] Implement BCM2838 thermal sensor

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_peripherals.c | 12 hw/arm/raspi4b.c | 1 - hw/misc/bcm2838_thermal.c| 96 hw/misc/meson.build | 3 +- include/hw/arm/bcm2838_peripherals.h | 2 + includ

[PATCH 25/44] Add GENET register structs. Part 3

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- include/hw/net/bcm2838_genet.h | 206 + 1 file changed, 206 insertions(+) diff --git a/include/hw/net/bcm2838_genet.h b/include/hw/net/bcm2838_genet.h index 4542f27eba..4cf70a17d3 100644 --- a/include/hw/net/bcm2838_genet.h +++ b

[PATCH 16/44] Enable BCM2838 PCIE

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838_peripherals.c | 25 + hw/arm/meson.build | 7 --- hw/arm/raspi4b.c | 1 - include/hw/arm/bcm2838_peripherals.h | 3 +++ 4 files changed, 32 insertions(+), 4 deletions(-)

[PATCH v10 05/10] migration: convert exec backend to accept MigrateAddress.

2023-07-26 Thread Het Gala
Exec transport backend for 'migrate'/'migrate-incoming' QAPIs accept new wire protocol of MigrateAddress struct. It is achived by parsing 'uri' string and storing migration parameters required for exec connection into strList struct. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala Revi

[PATCH v10 04/10] migration: convert rdma backend to accept MigrateAddress

2023-07-26 Thread Het Gala
RDMA based transport backend for 'migrate'/'migrate-incoming' QAPIs accept new wire protocol of MigrateAddress struct. It is achived by parsing 'uri' string and storing migration parameters required for RDMA connection into well defined InetSocketAddress struct. Suggested-by: Aravind Retnakaran

[PATCH 05/44] Add GIC-400 to BCM2838 SoC

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2838.c | 167 +++ hw/arm/trace-events | 2 + include/hw/arm/bcm2838.h | 2 + include/hw/arm/bcm2838_peripherals.h | 39 +++ 4 files changed, 210 insertions(+) diff --git

Re: [PULL 04/19] virtio-gpu: replace the surface with null surface when resetting

2023-07-26 Thread Marc-André Lureau
Hi Dongwon On Mon, Jul 17, 2023 at 4:46 PM wrote: > > From: Dongwon Kim > > The primary guest scanout shows the booting screen right after reboot > but additional guest displays (i.e. max_ouptuts > 1) will keep displaying > the old frames until the guest virtio gpu driver gets initialized, which

[PATCH 38/44] Add mailbox tests tags. Part 2

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mailbox.h | 152 ++ 1 file changed, 152 insertions(+) diff --git a/tests/qtest/bcm2838-mailbox.h b/tests/qtest/bcm2838-mailbox.h index 1fc34d092d..2231c2c596 100644 --- a/tests/qtest/bcm2838-mailbox.h +++ b/te

[PATCH v10 09/10] migration: Implement MigrateChannelList to hmp migration flow.

2023-07-26 Thread Het Gala
Integrate MigrateChannelList with all transport backends (socket, exec and rdma) for both src and dest migration endpoints for hmp migration. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala --- migration/migration-hmp-cmds.c | 15 +-- migration/migration.c | 5 ++-

[PATCH v10 02/10] migration: convert migration 'uri' into 'MigrateAddress'

2023-07-26 Thread Het Gala
This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri' string containing migration connection related information and stores them inside well defined 'MigrateAddress' struct. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala Reviewed-by: Daniel P. Berrangé --- migration/exec.c

Re: [PATCH] Open file as read only on private mapping in qemu_ram_alloc_from_file

2023-07-26 Thread Igor Mammedov
On Wed, 26 Jul 2023 10:11:44 +0200 David Hildenbrand wrote: > On 25.07.23 18:01, ThinerLogoer wrote: > > > > At 2023-07-25 19:42:30, "David Hildenbrand" wrote: > >> Hi, > >> > >> patch subject should start with "softmmu/physmem: Open ..." > > > > Sorry I am newbie to the patch submission p

[PATCH 31/44] Impl GENET RX path

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/net/bcm2838_genet.c | 222 - include/hw/net/bcm2838_genet.h | 1 + 2 files changed, 222 insertions(+), 1 deletion(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index 98030216f4..0686cb5002 100644 --

[PATCH v10 06/10] migration: New migrate and migrate-incoming argument 'channels'

2023-07-26 Thread Het Gala
MigrateChannelList allows to connect accross multiple interfaces. Add MigrateChannelList struct as argument to migration QAPIs. We plan to include multiple channels in future, to connnect multiple interfaces. Hence, we choose 'MigrateChannelList' as the new argument over 'MigrateChannel' to make m

[PATCH 43/44] Add missed BCM2835 properties

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/misc/bcm2835_property.c| 170 ++ include/hw/misc/raspberrypi-fw-defs.h | 11 ++ 2 files changed, 181 insertions(+) diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c index 4ed9faa54a..7d2d6e518d 100644 -

[PATCH v10 08/10] migration: Implement MigrateChannelList to qmp migration flow.

2023-07-26 Thread Het Gala
Integrate MigrateChannelList with all transport backends (socket, exec and rdma) for both src and dest migration endpoints for qmp migration. For current series, limit the size of MigrateChannelList to single element (single interface) as runtime check. Suggested-by: Aravind Retnakaran Signed-of

Re: How to tame CI?

2023-07-26 Thread Daniel P . Berrangé
On Wed, Jul 26, 2023 at 04:36:32PM +0200, Juan Quintela wrote: > Daniel P. Berrangé wrote: > > On Wed, Jul 26, 2023 at 02:00:03PM +0100, Peter Maydell wrote: > >> On Wed, 26 Jul 2023 at 13:06, Juan Quintela wrote: > >> > To make things easier, this is the part that show how it breaks (this is > >

[PATCH v10 01/10] migration: New QAPI type 'MigrateAddress'

2023-07-26 Thread Het Gala
This patch introduces well defined MigrateAddress struct and its related child objects. The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri' is of type string. The current implementation follows double encoding scheme for fetching migration parameters like 'uri' and this is not a

Re: How to tame CI?

2023-07-26 Thread Daniel P . Berrangé
On Wed, Jul 26, 2023 at 02:00:03PM +0100, Peter Maydell wrote: > On Wed, 26 Jul 2023 at 13:06, Juan Quintela wrote: > > To make things easier, this is the part that show how it breaks (this is > > the gcov test): > > > > 357/423 qemu:block / io-qcow2-copy-before-write >

[PATCH v10 00/10] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration

2023-07-26 Thread Het Gala
This is v10 patchset of modified 'migrate' and 'migrate-incoming' QAPI design for upstream review. Would like to thank all the maintainers that actively participated in the v9 patchset discussion and gave insightful suggestions to improve the patches. Link to previous upstream community patchset

[PATCH v10 07/10] migration: modify migration_channels_and_uri_compatible() for new QAPI syntax

2023-07-26 Thread Het Gala
migration_channels_and_uri_compatible() check for transport mechanism suitable for multifd migration gets executed when the caller calls old uri syntax. It needs it to be run when using the modern MigrateChannel QAPI syntax too. After URI -> 'MigrateChannel' : migration_channels_and_uri_compatible

Re: [PATCH v10 06/10] migration: New migrate and migrate-incoming argument 'channels'

2023-07-26 Thread Daniel P . Berrangé
On Wed, Jul 26, 2023 at 02:18:29PM +, Het Gala wrote: > MigrateChannelList allows to connect accross multiple interfaces. > Add MigrateChannelList struct as argument to migration QAPIs. > > We plan to include multiple channels in future, to connnect > multiple interfaces. Hence, we choose 'Mig

[PATCH 18/44] Add RNG200 RNG and RBG

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/misc/bcm2838_rng200.c | 218 ++- 1 file changed, 217 insertions(+), 1 deletion(-) diff --git a/hw/misc/bcm2838_rng200.c b/hw/misc/bcm2838_rng200.c index a17e8f2cda..bfc40658e2 100644 --- a/hw/misc/bcm2838_rng200.c +++ b/hw

[PATCH 26/44] Add GENET register structs. Part 4

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- include/hw/net/bcm2838_genet.h | 40 ++ 1 file changed, 40 insertions(+) diff --git a/include/hw/net/bcm2838_genet.h b/include/hw/net/bcm2838_genet.h index 4cf70a17d3..4b549ed431 100644 --- a/include/hw/net/bcm2838_genet.h +++ b/

Re: [PATCH v10 09/10] migration: Implement MigrateChannelList to hmp migration flow.

2023-07-26 Thread Daniel P . Berrangé
On Wed, Jul 26, 2023 at 02:18:32PM +, Het Gala wrote: > Integrate MigrateChannelList with all transport backends > (socket, exec and rdma) for both src and dest migration > endpoints for hmp migration. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala > --- > migration/migratio

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-07-26 Thread Peter Xu
On Wed, Jul 26, 2023 at 08:21:35AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Hi, Markus, > > > > On Tue, Jul 25, 2023 at 01:10:01PM +0200, Markus Armbruster wrote: > > [...] > > >> For better or worse, we duplicate full documentation between > >> MigrationParameter, MigrateSetPar

[PATCH 27/44] Add GENET register access macros

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- include/hw/net/bcm2838_genet.h | 76 ++ 1 file changed, 76 insertions(+) diff --git a/include/hw/net/bcm2838_genet.h b/include/hw/net/bcm2838_genet.h index 4b549ed431..bfe5e3ab31 100644 --- a/include/hw/net/bcm2838_genet.h +++ b/

[PATCH v10 03/10] migration: convert socket backend to accept MigrateAddress

2023-07-26 Thread Het Gala
Socket transport backend for 'migrate'/'migrate-incoming' QAPIs accept new wire protocol of MigrateAddress struct. It is achived by parsing 'uri' string and storing migration parameters required for socket connection into well defined SocketAddress struct. Suggested-by: Aravind Retnakaran Signed

[PATCH v10 10/10] migration: modify test_multifd_tcp_none() to use new QAPI syntax.

2023-07-26 Thread Het Gala
modify multifd tcp common test to incorporate the new QAPI syntax defined. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala Reviewed-by: Daniel P. Berrangé --- tests/qtest/migration-test.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/qtest/migration-t

[PATCH 44/44] Append added properties to mailbox test

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- tests/qtest/bcm2838-mbox-property-test.c | 82 1 file changed, 82 insertions(+) diff --git a/tests/qtest/bcm2838-mbox-property-test.c b/tests/qtest/bcm2838-mbox-property-test.c index e833529a00..68e2b11db6 100644 --- a/tests/qtest/bcm2

Re: How to tame CI?

2023-07-26 Thread Thomas Huth
On 26/07/2023 15.00, Peter Maydell wrote: On Wed, 26 Jul 2023 at 13:06, Juan Quintela wrote: To make things easier, this is the part that show how it breaks (this is the gcov test): 357/423 qemu:block / io-qcow2-copy-before-write ERROR 6.38s exit status

Re: [RFC PATCH] target/i386: Truncate ESP when exiting from long mode

2023-07-26 Thread Richard Henderson
On 7/26/23 01:17, Ard Biesheuvel wrote: While working on some EFI boot changes for Linux/x86, I noticed that TCG deviates from bare metal when it comes to how it handles the value of the stack pointer register RSP when dropping out of long mode. On bare metal, RSP is truncated to 32 bits, even

Re: How to tame CI?

2023-07-26 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Wed, Jul 26, 2023 at 02:00:03PM +0100, Peter Maydell wrote: >> On Wed, 26 Jul 2023 at 13:06, Juan Quintela wrote: >> > To make things easier, this is the part that show how it breaks (this is >> > the gcov test): >> > >> > 357/423 qemu:block / io-qcow2-copy-before-w

Re: [virtio-dev] [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user

2023-07-26 Thread Erik Schilling
On Tue Jul 4, 2023 at 4:54 PM CEST, Stefano Garzarella wrote: > On Tue, Jul 04, 2023 at 01:36:00PM +0100, Alex Bennée wrote: > >Currently QEMU has to know some details about the back-end to be able > >to setup the guest. While various parts of the setup can be delegated > >to the backend (for examp

[PATCH 11/44] Introduce Raspberry PI 4 machine

2023-07-26 Thread Sergey Kambalin
Signed-off-by: Sergey Kambalin --- hw/arm/bcm2835_peripherals.c| 20 +++- hw/arm/bcm2836.c| 2 + hw/arm/bcm2838.c| 2 + hw/arm/meson.build | 2 +- hw/arm/raspi.c | 28 +++-- hw/arm/raspi4b.c| 182 +++

[PULL v2 5/5] qapi: Reformat recent doc comments to conform to current conventions

2023-07-26 Thread Markus Armbruster
Since commit a937b6aa739 (qapi: Reformat doc comments to conform to current conventions), a number of comments not conforming to the current formatting conventions were added. No problem, just sweep the entire documentation once more. To check the generated documentation does not change, I compar

Re: [PATCH v10 08/10] migration: Implement MigrateChannelList to qmp migration flow.

2023-07-26 Thread Daniel P . Berrangé
On Wed, Jul 26, 2023 at 02:18:31PM +, Het Gala wrote: > Integrate MigrateChannelList with all transport backends > (socket, exec and rdma) for both src and dest migration > endpoints for qmp migration. > > For current series, limit the size of MigrateChannelList > to single element (single int

Re: [PATCH] migration: Allow user to specify migration available bandwidth

2023-07-26 Thread Peter Xu
On Tue, Jul 25, 2023 at 06:10:18PM +0100, Daniel P. Berrangé wrote: > On Tue, Jul 25, 2023 at 12:38:23PM -0400, Peter Xu wrote: > > I see you used "convergance" explicitly even after PeterM's reply, is that > > what you prefer over "convergence"? I do see more occurances of > > "convergence" as a

[PATCH 1/1] qemu-nbd: regression with arguments passing into nbd_client_thread()

2023-07-26 Thread Denis V. Lunev
Unfortunately commit 03b67621445d601c9cdc7dfe25812e9f19b81488 Author: Denis V. Lunev Date: Mon Jul 17 16:55:40 2023 +0200 qemu-nbd: pass structure into nbd_client_thread instead of plain char* has introduced a regression. struct NbdClientOpts resides on stack inside 'if' block. T

[PATCH] ui/dbus: fix clang compilation issue

2023-07-26 Thread marcandre . lureau
From: Marc-André Lureau ../ui/dbus-listener.c:236:9: error: expected expression Error *err = NULL; See: https://gitlab.com/qemu-project/qemu/-/issues/1782#note_1488517427 Signed-off-by: Marc-André Lureau --- ui/dbus-listener.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) d

[PATCH v2] softmmu/physmem: try opening file readonly before failure in file_ram_open

2023-07-26 Thread Thiner Logoer
Users may give "-mem-path" a read only file and expect the file to be mapped read-write privately. Allow this but give a warning since other users may surprise when the ram file is readonly and qemu suddenly aborts elsewhere. Suggested-by: David Hildenbrand Signed-off-by: Thiner Logoer --- See

Re: [PATCH] semihosting/uaccess.c: Replaced a malloc call with g_malloc.

2023-07-26 Thread Richard Henderson
On 7/26/23 02:43, Peter Maydell wrote: (Something went wrong with the quoting in your email. I've fixed it up.) On Wed, 26 Jul 2023 at 05:38, wrote: Peter Maydell wrote: The third part here, is that g_malloc() does not ever fail -- it will abort() on out of memory. However the code here is st

Re: [PATCH 1/2] block/blkio: fix opening virtio-blk drivers

2023-07-26 Thread Stefan Hajnoczi
On Wed, Jul 26, 2023 at 09:26:45AM +0200, Stefano Garzarella wrote: > On Tue, Jul 25, 2023 at 04:00:38PM -0400, Stefan Hajnoczi wrote: > > On Mon, Jul 24, 2023 at 05:46:10PM +0200, Stefano Garzarella wrote: > > > libblkio 1.3.0 added support of "fd" property for virtio-blk-vhost-vdpa > > > driver.

Re: [PATCH] ui/dbus: fix clang compilation issue

2023-07-26 Thread Thomas Huth
On 26/07/2023 17.12, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau ../ui/dbus-listener.c:236:9: error: expected expression Error *err = NULL; See: https://gitlab.com/qemu-project/qemu/-/issues/1782#note_1488517427 Signed-off-by: Marc-André Lureau --- ui/dbus-listener.

Re: [PATCH v2] block/blkio: do not use open flags in qemu_open()

2023-07-26 Thread Stefan Hajnoczi
On Wed, Jul 26, 2023 at 09:48:07AM +0200, Stefano Garzarella wrote: > qemu_open() in blkio_virtio_blk_common_open() is used to open the > character device (e.g. /dev/vhost-vdpa-0 or /dev/vfio/vfio) or in > the future eventually the unix socket. > > In all these cases we cannot open the path in rea

[PATCH 0/3] Complete i.MX6UL and i.MX7 processor for bare metal application.

2023-07-26 Thread Jean-Christophe Dubois
This patch adds a few unimplemented TZ devices (TZASC and CSU) to i.MX6UL and i.MX7 processors to avoid bare metal application to experiment "bus error" when acccessing these devices. It also adds some internal memory segments (OCRAM) to the i.MX7 to allow bare metal application to use them. Last

[PATCH 1/3] Rework i.MX6UL device implementation/instantiation

2023-07-26 Thread Jean-Christophe Dubois
From: jcdubois * Add Addr and size definition for all i.MX6UL devices in i.MX6UL header file. * Use those newly defined named constants whenever possible. * Standardize the way we init a familly of unimplemented devices - SAI - PWM (add missing PWM instances) - CAN * Add TZASC as unimplemen

[PATCH 3/3] Add i.MX7 SRC device implementation

2023-07-26 Thread Jean-Christophe Dubois
From: jcdubois The SRC device is normaly used to start the secondary CPU. When running Linux directly, Qemu is emulating a PSCI interface that UBOOT is installing at boot time and therefore the fact that the SRC device is unimplemented is hidden as Qemu respond directly to PSCI requets without u

Re: [PATCH 1/2] block/blkio: fix opening virtio-blk drivers

2023-07-26 Thread Stefano Garzarella
On Wed, Jul 26, 2023 at 11:32:10AM -0400, Stefan Hajnoczi wrote: On Wed, Jul 26, 2023 at 09:26:45AM +0200, Stefano Garzarella wrote: On Tue, Jul 25, 2023 at 04:00:38PM -0400, Stefan Hajnoczi wrote: > On Mon, Jul 24, 2023 at 05:46:10PM +0200, Stefano Garzarella wrote: > > libblkio 1.3.0 added sup

[PATCH 2/3] Rework i.MX7 device implementation/instantiation

2023-07-26 Thread Jean-Christophe Dubois
From: jcdubois * Add Addr and size definition for all i.MX7 devices in i.MX7 header file. * Use those newly defined named constants whenever possible. * Standardize the way we init a familly of unimplemented devices - SAI - PWM - CAN * Add TZASC as unimplemented device. - Allow bare metal

Re: [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user

2023-07-26 Thread Michael S. Tsirkin
On Mon, Jul 24, 2023 at 02:08:39PM -0400, Stefan Hajnoczi wrote: > On Thu, Jul 20, 2023 at 06:22:08PM -0400, Michael S. Tsirkin wrote: > > On Thu, Jul 20, 2023 at 05:31:03PM -0400, Stefan Hajnoczi wrote: > > > On Thu, 20 Jul 2023 at 17:15, Michael S. Tsirkin wrote: > > > > > > > > On Thu, Jul 20,

Re: [virtio-dev] [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user

2023-07-26 Thread Stefan Hajnoczi
On Wed, 26 Jul 2023 at 11:42, Erik Schilling wrote: > > On Tue Jul 4, 2023 at 4:54 PM CEST, Stefano Garzarella wrote: > > On Tue, Jul 04, 2023 at 01:36:00PM +0100, Alex Bennée wrote: > > >Currently QEMU has to know some details about the back-end to be able > > >to setup the guest. While various p

Re: [virtio-dev] [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user

2023-07-26 Thread Michael S. Tsirkin
On Thu, Jul 20, 2023 at 03:36:01PM -0400, Stefan Hajnoczi wrote: > On Fri, Jul 07, 2023 at 12:27:39PM +0200, Stefano Garzarella wrote: > > On Tue, Jul 04, 2023 at 04:02:42PM +0100, Alex Bennée wrote: > > > > > > Stefano Garzarella writes: > > > > > > > On Tue, Jul 04, 2023 at 01:36:00PM +0100, A

Re: [PULL v2 0/5] QAPI patches patches for 2023-07-26

2023-07-26 Thread Richard Henderson
On 7/26/23 05:57, Markus Armbruster wrote: The following changes since commit 6cb2011fedf8c4e7b66b4a3abd6b42c1bae99ce6: Update version for v8.1.0-rc1 release (2023-07-25 20:09:05 +0100) are available in the Git repository at: https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2023-07-26-

Re: [PULL 0/2] Misc next patches

2023-07-26 Thread Richard Henderson
On 7/25/23 09:23, Daniel P. Berrangé wrote: The following changes since commit a279ca4ea07383314b2d2b2f1d550be9482f148e: Merge tag 'pull-target-arm-20230725' ofhttps://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-07-25 12:44:39 +0100) are available in the Git repository at:

Re: [Qemu PATCH v2 5/9] hw/mem/cxl_type3: Add host backend and address space handling for DC regions

2023-07-26 Thread ni...@outlook.com
The 07/26/2023 07:53, Nathan Fontenot wrote: > On 7/25/23 13:39, Fan Ni wrote: > > From: Fan Ni > > > > Add (file/memory backed) host backend, all the dynamic capacity regions > > will share a single, large enough host backend. Set up address space for > > DC regions to support read/write operati

[PATCH] gitlab: remove duplication between msys jobs

2023-07-26 Thread Daniel P . Berrangé
Although they share a common parent, the two msys jobs still have massive duplication in their script definitions that can easily be collapsed. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/windows.yml | 132 +++ 1 file changed, 49 insertions(+), 83 delet

Re: [PULL 00/25] Migration 20230726 patches

2023-07-26 Thread Richard Henderson
-20230726-pull-request for you to fetch changes up to 697c4c86ab515a728ffb2adc2c3c04b22fa9210f: migration/rdma: Split qemu_fopen_rdma() into input/output functions (2023-07-26 10:55:56 +0200) Migration Pull request Hi This is the

Re: [PATCH v10 09/10] migration: Implement MigrateChannelList to hmp migration flow.

2023-07-26 Thread Het Gala
On 26/07/23 8:25 pm, Daniel P. Berrangé wrote: On Wed, Jul 26, 2023 at 02:18:32PM +, Het Gala wrote: Integrate MigrateChannelList with all transport backends (socket, exec and rdma) for both src and dest migration endpoints for hmp migration. Suggested-by: Aravind Retnakaran Signed-off-b

Re: intel-iommu: Report interrupt remapping faults, fix return value

2023-07-26 Thread Peter Xu
On Tue, Jul 25, 2023 at 11:01:16AM +0100, David Woodhouse wrote: > From: David Woodhouse > > A generic X86IOMMUClass->int_remap function should not return VT-d > specific values; fix it to return 0 if the interrupt was successfully > translated or -EINVAL if not. > > The VTD_FR_IR_xxx values are

Re: [RFC PATCH] docs/interop: define STANDALONE protocol feature for vhost-user

2023-07-26 Thread Stefan Hajnoczi
On Wed, Jul 26, 2023 at 12:02:33PM -0400, Michael S. Tsirkin wrote: > On Mon, Jul 24, 2023 at 02:08:39PM -0400, Stefan Hajnoczi wrote: > > On Thu, Jul 20, 2023 at 06:22:08PM -0400, Michael S. Tsirkin wrote: > > > On Thu, Jul 20, 2023 at 05:31:03PM -0400, Stefan Hajnoczi wrote: > > > > On Thu, 20 Ju

Re: i386/xen: prevent guest from binding loopback event channel to itself

2023-07-26 Thread Bernhard Beschow
Am 26. Juli 2023 09:24:28 UTC schrieb Paul Durrant : >On 26/07/2023 10:07, David Woodhouse wrote: >> On Wed, 2023-07-26 at 09:44 +0100, Paul Durrant wrote: >>> On 25/07/2023 11:05, David Woodhouse wrote: From: David Woodhouse Fuzzing showed that a guest could bind an interdomain

Re: [PATCH] migration/ram: Refactor precopy ram loading code

2023-07-26 Thread Peter Xu
On Tue, Jul 25, 2023 at 10:26:51AM -0300, Fabiano Rosas wrote: > From: Nikolay Borisov > > Extract the ramblock parsing code into a routine that operates on the > sequence of headers from the stream and another the parses the > individual ramblock. This makes ram_load_precopy() easier to > compre

Re: [PATCH v2 4/6] python/machine: use socketpair() for console connections

2023-07-26 Thread John Snow
On Wed, Jul 26, 2023, 6:50 AM Ani Sinha wrote: > > > > On 25-Jul-2023, at 11:33 PM, John Snow wrote: > > > > Create a socketpair for the console output. This should help eliminate > > race conditions around console text early in the boot process that might > > otherwise have been dropped on the

Re: [PATCH v2 0/7] migration: Better error handling in return path thread

2023-07-26 Thread Peter Xu
Hi, Fabiano, Sorry to be late on responding. On Tue, Jul 25, 2023 at 03:24:26PM -0300, Fabiano Rosas wrote: > Fabiano Rosas writes: > > > Peter Xu writes: > > > >> v2: > >> - Patch "migration: Provide explicit error message for file shutdowns" > >> - Touched up qapi doc [Fabiano] > >> - Ad

Re: [PATCH v10 09/10] migration: Implement MigrateChannelList to hmp migration flow.

2023-07-26 Thread Het Gala
On 26/07/23 10:11 pm, Daniel P. Berrangé wrote: On Wed, Jul 26, 2023 at 10:08:05PM +0530, Het Gala wrote: On 26/07/23 8:25 pm, Daniel P. Berrangé wrote: On Wed, Jul 26, 2023 at 02:18:32PM +, Het Gala wrote: Integrate MigrateChannelList with all transport backends (socket, exec and rdma)

[PATCH 1/2] virtio-gpu: free BHs, by implementing unrealize

2023-07-26 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- include/hw/virtio/virtio-gpu.h | 1 + hw/display/virtio-gpu-base.c | 2 +- hw/display/virtio-gpu.c| 10 ++ 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/

[PATCH 6/7] tests/avocado: reverse-debugging cope with re-executing breakpoints

2023-07-26 Thread Nicholas Piggin
The reverse-debugging test creates a trace, then replays it and: 1. Steps the first 10 instructions and records their addresses. 2. Steps backward and verifies their addresses match. 3. Runs to (near) the end of the trace. 4. Sets breakpoints on the first 10 instructions. 5. Continues backward and

[PATCH 7/7] tests/avocado: ppc64 reverse debugging tests for pseries and powernv

2023-07-26 Thread Nicholas Piggin
These machines run reverse-debugging well enough to pass basic tests. Wire them up. Cc: Pavel Dovgalyuk Signed-off-by: Nicholas Piggin --- tests/avocado/reverse_debugging.py | 29 + 1 file changed, 29 insertions(+) diff --git a/tests/avocado/reverse_debugging.py b/

Re: [PATCH 1/1] qemu-nbd: regression with arguments passing into nbd_client_thread()

2023-07-26 Thread Eric Blake
On Wed, Jul 26, 2023 at 04:52:47PM +0200, Denis V. Lunev wrote: > Unfortunately > commit 03b67621445d601c9cdc7dfe25812e9f19b81488 > Author: Denis V. Lunev > Date: Mon Jul 17 16:55:40 2023 +0200 > qemu-nbd: pass structure into nbd_client_thread instead of plain char* > has introdu

[PATCH for-8.1] target/arm: Fix MemOp for STGP

2023-07-26 Thread Richard Henderson
When converting to decodetree, the code to rebuild mop for the pair only made it into trans_STP and not into trans_STGP. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1790 Fixes: 8c212eb6594 ("target/arm: Convert load/store-pair to decodetree") Signed-off-by: Richard Henderson --- targ

[PATCH 0/6] ppc fixes possibly for 8.1

2023-07-26 Thread Nicholas Piggin
Sorry for the delay following up on the fixes, I got sucked down the decrementer rabbit hole that took longer than expected. Question about what is suitable for merge at this time and what should be stable. The first 3 have caused crashes or hangs running Linux and other software. Second 3 fix som

Re: [PATCH] gitlab: remove duplication between msys jobs

2023-07-26 Thread Marc-André Lureau
Hi On Wed, Jul 26, 2023 at 10:21 PM Thomas Huth wrote: > > On 26/07/2023 18.19, Daniel P. Berrangé wrote: > > Although they share a common parent, the two msys jobs still have > > massive duplication in their script definitions that can easily be > > collapsed. > > > > Signed-off-by: Daniel P. Be

[PATCH 0/7] ppc: record-replay fixes and enablement

2023-07-26 Thread Nicholas Piggin
Here is a series that gets ppc pseries and powernv machines into better shape for record-replay, maybe for 8.2. It's likely got a few deficiencies but it does run test cases and helped find bugs in migration already. It requires previous decrementer fixes to work well. I think we can get away with

Re: [PATCH v10 09/10] migration: Implement MigrateChannelList to hmp migration flow.

2023-07-26 Thread Daniel P . Berrangé
On Wed, Jul 26, 2023 at 10:08:05PM +0530, Het Gala wrote: > > On 26/07/23 8:25 pm, Daniel P. Berrangé wrote: > > On Wed, Jul 26, 2023 at 02:18:32PM +, Het Gala wrote: > > > Integrate MigrateChannelList with all transport backends > > > (socket, exec and rdma) for both src and dest migration >

[PATCH 3/7] spapr: Fix machine reset deadlock from replay-record

2023-07-26 Thread Nicholas Piggin
When the machine is reset to load a new snapshot while being debugged with replay-record, it is done from another thread, so the CPU does not run the register setting operations. Set CPU registers directly in machine reset. Cc: Pavel Dovgalyuk Signed-off-by: Nicholas Piggin --- hw/ppc/spapr.c

[PATCH 0/2] virtio-gpu: reset gfx resources in main thread

2023-07-26 Thread marcandre . lureau
From: Marc-André Lureau Hi, See the second patch for details. thanks Marc-André Lureau (2): virtio-gpu: free BHs, by implementing unrealize virtio-gpu: reset gfx resources in main thread include/hw/virtio/virtio-gpu.h | 4 +++ hw/display/virtio-gpu-base.c | 2 +- hw/display/virtio-gpu

[PATCH 1/7] target/ppc: Fix CPU reservation migration for record-replay

2023-07-26 Thread Nicholas Piggin
ppc only migrates reserve_addr, so the destination machine can get a valid reservation with an incorrect reservation value of 0. Prior to commit 392d328abe753 ("target/ppc: Ensure stcx size matches larx"), this could permit a stcx. to incorrectly succeed. That commit inadvertently fixed that bug be

[PATCH 5/6] hw/ppc: Always store the decrementer value

2023-07-26 Thread Nicholas Piggin
When writing a value to the decrementer that raises an exception, the irq is raised, but the value is not stored so the store doesn't appear to have changed the register when it is read again. Always store the write value to the register. Fixes: e81a982aa53 ("PPC: Clean up DECR implementation") S

[PATCH 2/2] virtio-gpu: reset gfx resources in main thread

2023-07-26 Thread marcandre . lureau
From: Marc-André Lureau Calling OpenGL from different threads can have bad consequences if not carefully reviewed. It's not generally supported. In my case, I was debugging a crash in glDeleteTextures from OPENGL32.DLL, where I asked qemu for gl=es, and thus ANGLE implementation was expected. lib

[PATCH 2/6] target/ppc: Fix VRMA page size for ISA v3.0

2023-07-26 Thread Nicholas Piggin
Until v2.07s, the VRMA page size (L||LP) was encoded in LPCR[VRMASD]. In v3.0 that moved to the partition table PS field. The powernv machine can now run KVM HPT guests on POWER9/10 CPUs with this fix and the patch to add ASDR. Fixes: 3367c62f522b ("target/ppc: Support for POWER9 native hash") Si

<    1   2   3   >