Re: Boot failure after QEMU's upgrade to OpenSBI v1.3 (was Re: [PATCH for-8.2 6/7] target/riscv: add 'max' CPU type)

2023-07-19 Thread Conor Dooley
On Wed, Jul 19, 2023 at 11:32:55AM +1000, Alistair Francis wrote: > If there is no OpenSBI 1.3.1 release we should add something to the > release notes. @Conor Dooley are you able to give a clear sentence on > how the boot fails? Uhh, I'll give it a shot, but hopefully it is not required :) In v

[PULL 0/1] hw/nvme fixes

2023-07-19 Thread Klaus Jensen
From: Klaus Jensen Hi, The following changes since commit 361d5397355276e3007825cc17217c1e4d4320f7: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2023-07-17 15:49:27 +0100) are available in the Git repository at: https://gitlab.com/birkelund/qemu.git ta

[PULL 1/1] hw/nvme: fix endianness issue for shadow doorbells

2023-07-19 Thread Klaus Jensen
From: Klaus Jensen In commit 2fda0726e514 ("hw/nvme: fix missing endian conversions for doorbell buffers"), we fixed shadow doorbells for big-endian guests running on little endian hosts. But I did not fix little-endian guests on big-endian hosts. Fix this. Resolves: https://gitlab.com/qemu-proj

[PATCH 4/4] vdpa: Allow VIRTIO_NET_F_CTRL_VLAN in SVQ

2023-07-19 Thread Hawkins Jiawei
Enable SVQ with VIRTIO_NET_F_CTRL_VLAN feature. Co-developed-by: Eugenio Pérez Signed-off-by: Eugenio Pérez Signed-off-by: Hawkins Jiawei --- net/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index 0787dd933b..dfd271c456 100644 --- a/net/v

[PATCH 3/4] vdpa: Restore vlan filtering state

2023-07-19 Thread Hawkins Jiawei
This patch introduces vhost_vdpa_net_load_single_vlan() and vhost_vdpa_net_load_vlan() to restore the vlan filtering state at device's startup. Co-developed-by: Eugenio Pérez Signed-off-by: Eugenio Pérez Signed-off-by: Hawkins Jiawei --- net/vhost-vdpa.c | 49 ++

[PATCH 0/4] Vhost-vdpa Shadow Virtqueue VLAN support

2023-07-19 Thread Hawkins Jiawei
This series enables shadowed CVQ to intercept VLAN commands through shadowed CVQ, update the virtio NIC device model so qemu send it in a migration, and the restore of that VLAN state in the destination. TestStep 1. test the migration using vp-vdpa device - For L0 guest, boot QEMU with

[QEMU PATCH v3 0/1] virtgpu: do not destroy resources when guest suspend

2023-07-19 Thread Jiqian Chen
After suspending and resuming guest VM, you will get a black screen, and the display can't come back. This is because when guest did suspending, it called into qemu to call virtio_gpu_gl_reset. In function virtio_gpu_gl_reset, it destroyed resources and reset renderer, which were used for display.

[PATCH 1/4] virtio-net: do not reset vlan filtering at set_features

2023-07-19 Thread Hawkins Jiawei
From: Eugenio Pérez This function is called after virtio_load, so all vlan configuration is lost in migration case. Just allow all the vlan-tagged packets if vlan is not configured, and trust device reset to clear all filtered vlans. Fixes: 0b1eaa8803 ("virtio-net: Do not filter VLANs without F

[PATCH 2/4] virtio-net: Expose MAX_VLAN

2023-07-19 Thread Hawkins Jiawei
vhost-vdpa shadowed CVQ needs to know the maximum number of vlans supported by the virtio-net device, so QEMU can restore the VLAN state in a migration. Co-developed-by: Eugenio Pérez Signed-off-by: Eugenio Pérez Signed-off-by: Hawkins Jiawei --- hw/net/virtio-net.c| 2 -- include/

[QEMU PATCH v3 0/1] S3 support

2023-07-19 Thread Jiqian Chen
v3: Hi all, Thanks for Michael S. Tsirkin's advice. V3 makes below changes: * Remove changes in file include/standard-headers/linux/virtio_gpu.h I am not supposed to edit this file and it will be imported after the patches of linux kernel was merged. Best regards, Jiqian Chen. v2: link, https

[PATCH v3 0/8] vdpa: Send all CVQ state load commands in parallel

2023-07-19 Thread Hawkins Jiawei
This patchset allows QEMU to delay polling and checking the device used buffer until either the SVQ is full or control commands shadow buffers are full, instead of polling and checking immediately after sending each SVQ control command, so that QEMU can send all the SVQ control commands in parallel

[PATCH v3 1/8] vhost: Add argument to vhost_svq_poll()

2023-07-19 Thread Hawkins Jiawei
Next patches in this series will no longer perform an immediate poll and check of the device's used buffers for each CVQ state load command. Instead, they will send CVQ state load commands in parallel by polling multiple pending buffers at once. To achieve this, this patch refactoring vhost_svq_po

[PATCH v3 2/8] vdpa: Use iovec for vhost_vdpa_net_cvq_add()

2023-07-19 Thread Hawkins Jiawei
Next patches in this series will no longer perform an immediate poll and check of the device's used buffers for each CVQ state load command. Consequently, there will be multiple pending buffers in the shadow VirtQueue, making it a must for every control command to have its own buffer. To achieve t

[PATCH v3 4/8] vdpa: Avoid using vhost_vdpa_net_load_*() outside vhost_vdpa_net_load()

2023-07-19 Thread Hawkins Jiawei
Next patches in this series will refactor vhost_vdpa_net_load_cmd() to iterate through the control commands shadow buffers, allowing QEMU to send CVQ state load commands in parallel at device startup. Considering that QEMU always forwards the CVQ command serialized outside of vhost_vdpa_net_load()

[PATCH v3 8/8] vdpa: Send cvq state load commands in parallel

2023-07-19 Thread Hawkins Jiawei
This patch enables sending CVQ state load commands in parallel at device startup by following steps: * Refactor vhost_vdpa_net_load_cmd() to iterate through the control commands shadow buffers. This allows different CVQ state load commands to use their own unique buffers. * Delay the polling

[PATCH v3 3/8] vhost: Expose vhost_svq_available_slots()

2023-07-19 Thread Hawkins Jiawei
Next patches in this series will delay the polling and checking of buffers until either the SVQ is full or control commands shadow buffers are full, no longer perform an immediate poll and check of the device's used buffers for each CVQ state load command. To achieve this, this patch exposes vhost

[PATCH v3 5/8] vdpa: Check device ack in vhost_vdpa_net_load_rx_mode()

2023-07-19 Thread Hawkins Jiawei
Considering that vhost_vdpa_net_load_rx_mode() is only called within vhost_vdpa_net_load_rx() now, this patch refactors vhost_vdpa_net_load_rx_mode() to include a check for the device's ack, simplifying the code and improving its maintainability. Signed-off-by: Hawkins Jiawei --- net/vhost-vdpa.

[PATCH v3 6/8] vdpa: Move vhost_svq_poll() to the caller of vhost_vdpa_net_cvq_add()

2023-07-19 Thread Hawkins Jiawei
This patch moves vhost_svq_poll() to the caller of vhost_vdpa_net_cvq_add() and introduces a helper funtion. By making this change, next patches in this series is able to refactor vhost_vdpa_net_load_x() only to delay the polling and checking process until either the SVQ is full or control command

[PATCH v3 7/8] vdpa: Add cursors to vhost_vdpa_net_loadx()

2023-07-19 Thread Hawkins Jiawei
This patch adds `out_cursor` and `in_cursor` arguments to vhost_vdpa_net_loadx(). By making this change, next patches in this series can refactor vhost_vdpa_net_load_cmd() directly to iterate through the control commands shadow buffers, allowing QEMU to send CVQ state load commands in parallel at

Re: [RFC PATCH 10/17] misc/i2c_mctp_cxl: Initial device emulation

2023-07-19 Thread Jonathan Cameron via
On Tue, 18 Jul 2023 17:30:57 -0400 Gregory Price wrote: > On Mon, Jul 17, 2023 at 06:16:39PM +0100, Jonathan Cameron wrote: > > @@ -397,8 +401,9 @@ struct CXLType3Dev { > > AddressSpace hostpmem_as; > > CXLComponentState cxl_cstate; > > CXLDeviceState cxl_dstate; > > -CXLCCI cc

Re: [PATCH 01/14] target/s390x: Make CKSM raise an exception if R2 is odd

2023-07-19 Thread David Hildenbrand
On 18.07.23 23:21, Ilya Leoshkevich wrote: R2 designates an even-odd register pair; the instruction should raise a specification exception when R2 is not even. Cc: qemu-sta...@nongnu.org Fixes: e023e832d0ac ("s390x: translate engine for s390x CPU") Signed-off-by: Ilya Leoshkevich --- target/s

Re: [PATCH 02/14] target/s390x: Fix CLM with M3=0

2023-07-19 Thread David Hildenbrand
On 18.07.23 23:21, Ilya Leoshkevich wrote: When the mask is zero, access exceptions should still be recognized for 1 byte at the second-operand address. CC should be set to 0. Cc: qemu-sta...@nongnu.org Fixes: defb0e3157af ("s390x: Implement opcode helpers") Signed-off-by: Ilya Leoshkevich ---

Re: [PATCH 03/14] target/s390x: Fix CONVERT TO LOGICAL/FIXED with out-of-range inputs

2023-07-19 Thread David Hildenbrand
On 18.07.23 23:21, Ilya Leoshkevich wrote: CONVERT TO LOGICAL/FIXED deviate from IEEE 754 in that they raise an inexact exception on out-of-range inputs. float_flag_invalid_cvti aligns nicely with that behavior, so convert it to S390_IEEE_MASK_INEXACT. Cc: qemu-sta...@nongnu.org Fixes: defb0e315

Re: [PATCH 04/14] target/s390x: Fix ICM with M3=0

2023-07-19 Thread David Hildenbrand
On 18.07.23 23:21, Ilya Leoshkevich wrote: When the mask is zero, access exceptions should still be recognized for 1 byte at the second-operand address. CC should be set to 0. Cc: qemu-sta...@nongnu.org Fixes: e023e832d0ac ("s390x: translate engine for s390x CPU") Signed-off-by: Ilya Leoshkevich

Re: [PATCH 07/14] target/s390x: Fix assertion failure in VFMIN/VFMAX with reserved type

2023-07-19 Thread David Hildenbrand
On 18.07.23 23:21, Ilya Leoshkevich wrote: Passing reserved type to VFMIN/VFMAX causes an assertion failure in vfmin_res() and vfmax_res(). These instructions should raise a specification exception in this case. Cc: qemu-sta...@nongnu.org Fixes: da4807527f3b ("s390x/tcg: Implement VECTOR FP (MAX

Re: [PATCH 05/14] target/s390x: Make MC raise specification exception when class >= 16

2023-07-19 Thread David Hildenbrand
On 18.07.23 23:21, Ilya Leoshkevich wrote: MC requires bit positions 8-11 (upper 4 bits of class) to be zeros, otherwise it must raise a specification exception. Cc: qemu-sta...@nongnu.org Fixes: 20d143e2cab8 ("s390x/tcg: Implement MONITOR CALL") Signed-off-by: Ilya Leoshkevich --- target/s39

Re: [PATCH] Wrong unpacked structure for epoll_event on qemu-or1k (openrisc user-space)

2023-07-19 Thread Laurent Vivier
Le 18/07/2023 à 17:06, Luca Bonissi a écrit : On 18/07/23 16:40, Peter Maydell wrote: Hi; thanks for this patch. Unfortunately we need patches to include a Signed-off-by: line that says you're legally OK with it being contributed to QEMU, or we can't take them. Sorry for the missing "signed-of

Re: [PATCH QEMU v8 4/9] migration: Introduce dirty-limit capability

2023-07-19 Thread Markus Armbruster
Yong Huang writes: > On Wed, Jul 19, 2023 at 1:26 PM Markus Armbruster wrote: > >> Yong Huang writes: >> >> > On Tue, Jul 18, 2023 at 7:04 PM Markus Armbruster >> wrote: >> > >> >> Yong Huang writes: >> >> >> >> > On Thu, Jul 13, 2023 at 8:44 PM Markus Armbruster >> >> > wrote: [...] >> >

Re: [PATCH v3 0/8] vdpa: Send all CVQ state load commands in parallel

2023-07-19 Thread Michael S. Tsirkin
On Wed, Jul 19, 2023 at 03:53:45PM +0800, Hawkins Jiawei wrote: > This patchset allows QEMU to delay polling and checking the device > used buffer until either the SVQ is full or control commands shadow > buffers are full, instead of polling and checking immediately after > sending each SVQ control

Re: [PATCH v21 14/20] tests/avocado: s390x cpu topology core

2023-07-19 Thread Pierre Morel
On 7/4/23 15:14, Thomas Huth wrote: On 30/06/2023 11.17, Pierre Morel wrote: Introduction of the s390x cpu topology core functions and basic tests. We test the corelation between the command line and the QMP results in query-cpus-fast for various CPU topology. Signed-off-by: Pierre Morel --

Re: [PATCH QEMU v8 4/9] migration: Introduce dirty-limit capability

2023-07-19 Thread Yong Huang
On Wed, Jul 19, 2023 at 5:03 PM Markus Armbruster wrote: > Yong Huang writes: > > > On Wed, Jul 19, 2023 at 1:26 PM Markus Armbruster > wrote: > > > >> Yong Huang writes: > >> > >> > On Tue, Jul 18, 2023 at 7:04 PM Markus Armbruster > >> wrote: > >> > > >> >> Yong Huang writes: > >> >> > >>

Re: [PATCH 07/14] target/s390x: Fix assertion failure in VFMIN/VFMAX with reserved type

2023-07-19 Thread Ilya Leoshkevich
On Wed, 2023-07-19 at 10:40 +0200, David Hildenbrand wrote: > On 18.07.23 23:21, Ilya Leoshkevich wrote: > > Passing reserved type to VFMIN/VFMAX causes an assertion failure in > > vfmin_res() and vfmax_res(). These instructions should raise a > > specification exception in this case. > > > > Cc:

Re: [PATCH 07/14] target/s390x: Fix assertion failure in VFMIN/VFMAX with reserved type

2023-07-19 Thread David Hildenbrand
On 19.07.23 11:34, Ilya Leoshkevich wrote: On Wed, 2023-07-19 at 10:40 +0200, David Hildenbrand wrote: On 18.07.23 23:21, Ilya Leoshkevich wrote: Passing reserved type to VFMIN/VFMAX causes an assertion failure in vfmin_res() and vfmax_res(). These instructions should raise a specification exce

[PATCH v2 04/14] target/s390x: Fix ICM with M3=0

2023-07-19 Thread Ilya Leoshkevich
When the mask is zero, access exceptions should still be recognized for 1 byte at the second-operand address. CC should be set to 0. Cc: qemu-sta...@nongnu.org Fixes: e023e832d0ac ("s390x: translate engine for s390x CPU") Reviewed-by: David Hildenbrand Signed-off-by: Ilya Leoshkevich --- target

[PATCH v2 13/14] tests/tcg/s390x: Test STPQ

2023-07-19 Thread Ilya Leoshkevich
Add a small test to prevent regressions. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.softmmu-target | 1 + tests/tcg/s390x/stpq.S | 20 2 files changed, 21 insertions(+) create mode 100644 tests/tcg/s390x/stpq.S diff --git a/tests/tcg/s39

[PATCH v2 12/14] tests/tcg/s390x: Test MC

2023-07-19 Thread Ilya Leoshkevich
Add a small test to prevent regressions. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.softmmu-target | 1 + tests/tcg/s390x/mc.S| 56 + 2 files changed, 57 insertions(+) create mode 100644 tests/tcg/s390x/mc.S diff --git a/tests/tcg/

[PATCH v2 03/14] target/s390x: Fix CONVERT TO LOGICAL/FIXED with out-of-range inputs

2023-07-19 Thread Ilya Leoshkevich
CONVERT TO LOGICAL/FIXED deviate from IEEE 754 in that they raise an inexact exception on out-of-range inputs. float_flag_invalid_cvti aligns nicely with that behavior, so convert it to S390_IEEE_MASK_INEXACT. Cc: qemu-sta...@nongnu.org Fixes: defb0e3157af ("s390x: Implement opcode helpers") Revie

[PATCH v2 05/14] target/s390x: Make MC raise specification exception when class >= 16

2023-07-19 Thread Ilya Leoshkevich
MC requires bit positions 8-11 (upper 4 bits of class) to be zeros, otherwise it must raise a specification exception. Cc: qemu-sta...@nongnu.org Fixes: 20d143e2cab8 ("s390x/tcg: Implement MONITOR CALL") Reviewed-by: David Hildenbrand Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/excp_he

[PATCH v2 11/14] tests/tcg/s390x: Test ICM

2023-07-19 Thread Ilya Leoshkevich
Add a small test to prevent regressions. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.softmmu-target | 1 + tests/tcg/s390x/icm.S | 32 + 2 files changed, 33 insertions(+) create mode 100644 tests/tcg/s390x/icm.S diff --git a/tests/tcg

[PATCH v2 06/14] tcg/{i386, s390x}: Add earlyclobber to the op_add2's first output

2023-07-19 Thread Ilya Leoshkevich
i386 and s390x implementations of op_add2 require an earlyclobber, which is currently missing. This breaks VCKSM in s390x guests. E.g., on x86_64 the following op: add2_i32 tmp2,tmp3,tmp2,tmp3,tmp3,tmp2 dead: 0 2 3 4 5 pref=none,0x is translated to: addl %ebx, %r12d adcl

[PATCH v2 07/14] target/s390x: Fix assertion failure in VFMIN/VFMAX with type 13

2023-07-19 Thread Ilya Leoshkevich
Type 13 is reserved, so using it should result in specification exception. Due to an off-by-1 error the code triggers an assertion at a later point in time instead. Cc: qemu-sta...@nongnu.org Fixes: da4807527f3b ("s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)") Signed-off-by: Ilya Leoshkevich

[PATCH v2 01/14] target/s390x: Make CKSM raise an exception if R2 is odd

2023-07-19 Thread Ilya Leoshkevich
R2 designates an even-odd register pair; the instruction should raise a specification exception when R2 is not even. Cc: qemu-sta...@nongnu.org Fixes: e023e832d0ac ("s390x: translate engine for s390x CPU") Reviewed-by: David Hildenbrand Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/trans

[PATCH v2 02/14] target/s390x: Fix CLM with M3=0

2023-07-19 Thread Ilya Leoshkevich
When the mask is zero, access exceptions should still be recognized for 1 byte at the second-operand address. CC should be set to 0. Reviewed-by: David Hildenbrand Cc: qemu-sta...@nongnu.org Fixes: defb0e3157af ("s390x: Implement opcode helpers") Signed-off-by: Ilya Leoshkevich --- target/s390x

[PATCH v2 00/14] target/s390x: Miscellaneous TCG fixes, part 2

2023-07-19 Thread Ilya Leoshkevich
v1: https://lists.gnu.org/archive/html/qemu-devel/2023-07/msg03648.html v1 -> v2: Move the case in 04/14 (David). Simplify the reserved type checking in 07/14 (David). Add R-bs. Hi, Here is another set of fixes for issues found by randomized testing. Most of them have to do w

[PATCH v2 08/14] tests/tcg/s390x: Test CKSM

2023-07-19 Thread Ilya Leoshkevich
Add a small test to prevent regressions. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.softmmu-target | 1 + tests/tcg/s390x/cksm.S | 29 + 2 files changed, 30 insertions(+) create mode 100644 tests/tcg/s390x/cksm.S diff --git a/tests/tc

[PATCH v2 10/14] tests/tcg/s390x: Test CLM

2023-07-19 Thread Ilya Leoshkevich
Add a small test to prevent regressions. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.softmmu-target | 1 + tests/tcg/s390x/clm.S | 29 + 2 files changed, 30 insertions(+) create mode 100644 tests/tcg/s390x/clm.S diff --git a/tests/tcg

[PATCH v2 14/14] tests/tcg/s390x: Test VCKSM

2023-07-19 Thread Ilya Leoshkevich
Add a small test to prevent regressions. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/vcksm.c | 31 +++ tests/tcg/s390x/vx.h| 2 ++ 3 files changed, 34 insertions(+) create mode 100644 tests/tcg/s390

Re: [PATCH v2 07/14] target/s390x: Fix assertion failure in VFMIN/VFMAX with type 13

2023-07-19 Thread David Hildenbrand
On 19.07.23 11:44, Ilya Leoshkevich wrote: Type 13 is reserved, so using it should result in specification exception. Due to an off-by-1 error the code triggers an assertion at a later point in time instead. Cc: qemu-sta...@nongnu.org Fixes: da4807527f3b ("s390x/tcg: Implement VECTOR FP (MAXIMUM

[PATCH v2 09/14] tests/tcg/s390x: Test CLGEBR and CGEBRA

2023-07-19 Thread Ilya Leoshkevich
Add a small test to prevent regressions. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target | 5 + tests/tcg/s390x/cgebra.c| 32 tests/tcg/s390x/clgebr.c| 32 3 files changed, 69 insertions(+)

Re: [PATCH v8 1/9] migration: New QAPI type 'MigrateAddress'

2023-07-19 Thread Daniel P . Berrangé
On Thu, Jul 13, 2023 at 10:57:05AM +, Het Gala wrote: > This patch introduces well defined MigrateAddress struct > and its related child objects. > > The existing argument of 'migrate' and 'migrate-incoming' QAPI > - 'uri' is of type string. The current implementation follows > double encoding

Re: Boot failure after QEMU's upgrade to OpenSBI v1.3 (was Re: [PATCH for-8.2 6/7] target/riscv: add 'max' CPU type)

2023-07-19 Thread Alistair Francis
On Wed, Jul 19, 2023 at 3:39 PM Anup Patel wrote: > > On Wed, Jul 19, 2023 at 7:03 AM Alistair Francis wrote: > > > > On Sat, Jul 15, 2023 at 7:14 PM Atish Patra wrote: > > > > > > On Fri, Jul 14, 2023 at 5:29 AM Conor Dooley wrote: > > > > > > > > On Fri, Jul 14, 2023 at 11:19:34AM +0100, Cono

Re: [PATCH v8 2/9] migration: convert migration 'uri' into 'MigrateAddress'

2023-07-19 Thread Daniel P . Berrangé
On Thu, Jul 13, 2023 at 10:57:06AM +, Het Gala wrote: > This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri' > string containing migration connection related information > and stores them inside well defined 'MigrateAddress' struct. > > Misc: limit line width in exec.c to 80 char re

Re: [PATCH v8 3/9] migration: convert socket backend to accept MigrateAddress

2023-07-19 Thread Daniel P . Berrangé
On Thu, Jul 13, 2023 at 10:57:07AM +, Het Gala wrote: > Socket transport backend for 'migrate'/'migrate-incoming' QAPIs accept > new wire protocol of MigrateAddress struct. > > It is achived by parsing 'uri' string and storing migration parameters > required for socket connection into well def

Re: [PATCH v8 4/9] migration: convert rdma backend to accept MigrateAddress

2023-07-19 Thread Daniel P . Berrangé
On Thu, Jul 13, 2023 at 10:57:08AM +, Het Gala wrote: > RDMA based transport backend for 'migrate'/'migrate-incoming' QAPIs > accept new wire protocol of MigrateAddress struct. > > It is achived by parsing 'uri' string and storing migration parameters > required for RDMA connection into well d

Re: [PATCH v8 5/9] migration: convert exec backend to accept MigrateAddress.

2023-07-19 Thread Daniel P . Berrangé
On Thu, Jul 13, 2023 at 10:57:09AM +, Het Gala wrote: > Exec transport backend for 'migrate'/'migrate-incoming' QAPIs accept > new wire protocol of MigrateAddress struct. > > It is achived by parsing 'uri' string and storing migration parameters > required for exec connection into strList stru

Re: [PATCH v8 6/9] migration: New migrate and migrate-incoming argument 'channels'

2023-07-19 Thread Daniel P . Berrangé
On Thu, Jul 13, 2023 at 10:57:10AM +, Het Gala wrote: > MigrateChannelList allows to connect accross multiple interfaces. > Add MigrateChannelList struct as argument to migration QAPIs. > > We plan to include multiple channels in future, to connnect > multiple interfaces. Hence, we choose 'Mig

Re: [PATCH v8 7/9] migration: modify migration_channels_and_uri_compatible() for new QAPI syntax

2023-07-19 Thread Daniel P . Berrangé
On Thu, Jul 13, 2023 at 10:57:11AM +, Het Gala wrote: > migration_channels_and_uri_compatible() check for transport mechanism > suitable for multifd migration gets executed when the caller calls old > uri syntax. It needs it to be run when using the modern MigrateChannel > QAPI syntax too. > >

Re: [PATCH v8 8/9] migration: Implement MigrateChannelList to migration flow.

2023-07-19 Thread Daniel P . Berrangé
On Thu, Jul 13, 2023 at 10:57:12AM +, Het Gala wrote: > Integrate MigrateChannelList with all transport backends > (socket, exec and rdma) for both src and dest migration > endpoints. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala > --- > migration/migration.c | 77 +

Re: [PATCH v8 9/9] migration: Add test case for modified QAPI syntax

2023-07-19 Thread Daniel P . Berrangé
On Thu, Jul 13, 2023 at 10:57:13AM +, Het Gala wrote: > Add multifd tcp common test case for new QAPI syntax defined. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala > --- > tests/qtest/migration-test.c | 45 > 1 file changed, 45 insertion

Re: Reducing vdpa migration downtime because of memory pin / maps

2023-07-19 Thread Eugenio Perez Martin
On Mon, Jul 17, 2023 at 9:57 PM Si-Wei Liu wrote: > > Hey, > > I am now back from the break. Sorry for the delayed response, please see > in line. > > On 7/9/2023 11:04 PM, Eugenio Perez Martin wrote: > > On Sat, Jul 8, 2023 at 11:14 AM Si-Wei Liu wrote: > >> > >> > >> On 7/5/2023 10:46 PM, Eugen

Re: [PATCH v3 0/8] misc AHCI cleanups

2023-07-19 Thread Niklas Cassel
On Fri, Jun 09, 2023 at 04:08:36PM +0200, Niklas Cassel wrote: > From: Niklas Cassel > > Hello John, > > Here comes some misc AHCI cleanups. > > Most are related to error handling. > > Please review. > > Changes since v2: > -Squashed in the test commits that were sent out as a separate series

Re: [PATCH 0/4] Vhost-vdpa Shadow Virtqueue VLAN support

2023-07-19 Thread Hawkins Jiawei
在 2023/7/19 15:47, Hawkins Jiawei 写道: > This series enables shadowed CVQ to intercept VLAN commands > through shadowed CVQ, update the virtio NIC device model > so qemu send it in a migration, and the restore of that > VLAN state in the destination. This patch series is based on "[PATCH 0/3] Vhost

Re: [PATCH v21 14/20] tests/avocado: s390x cpu topology core

2023-07-19 Thread Pierre Morel
On 7/12/23 22:00, Nina Schoetterl-Glausch wrote: On Fri, 2023-06-30 at 11:17 +0200, Pierre Morel wrote: Introduction of the s390x cpu topology core functions and basic tests. We test the corelation between the command line and corRelation the QMP results in query-cpus-fast for various CPU

Re: [PATCH v21 15/20] tests/avocado: s390x cpu topology polarisation

2023-07-19 Thread Pierre Morel
On 7/5/23 10:53, Thomas Huth wrote: On 30/06/2023 11.17, Pierre Morel wrote: Polarization is changed on a request from the guest. Let's verify the polarization is accordingly set by QEMU. Signed-off-by: Pierre Morel ---   tests/avocado/s390_topology.py | 46 ++

Re: [PATCH 0/6] linux-user: brk() syscall fixes and armhf static binary fix

2023-07-19 Thread Michael Tokarev
18.07.2023 11:30, Michael Tokarev wrote: 18.07.2023 06:03, Song Gao пишет: Hi,  Helge Could you see the following bugs: https://gitlab.com/qemu-project/qemu/-/issues/1707 This issue is also caused by  the commit  86f04735ac. This issue has been fixed in master already and even in 8.0.3 stabl

Re: [PATCH v3 2/8] hw/ide/core: set ERR_STAT in unsupported command completion

2023-07-19 Thread Philippe Mathieu-Daudé
On 9/6/23 16:08, Niklas Cassel wrote: From: Niklas Cassel Currently, the first time sending an unsupported command (e.g. READ LOG DMA EXT) will not have ERR_STAT set in the completion. Sending the unsupported command again, will correctly have ERR_STAT set. When ide_cmd_permitted() returns fal

Re: [PATCH v3 5/8] hw/ide/ahci: PxSACT and PxCI is cleared when PxCMD.ST is cleared

2023-07-19 Thread Philippe Mathieu-Daudé
On 9/6/23 16:08, Niklas Cassel wrote: From: Niklas Cassel According to AHCI 1.3.1 definition of PxSACT: This field is cleared when PxCMD.ST is written from a '1' to a '0' by software. This field is not cleared by a COMRESET or a software reset. Interesting, since its origin in commit f6ad2e32

Re: [PATCH 17/18] host/include/i386: Implement clmul.h

2023-07-19 Thread Ilya Leoshkevich
On Thu, 2023-07-13 at 22:14 +0100, Richard Henderson wrote: > Detect PCLMUL in cpuinfo; implement the accel hooks. > > Signed-off-by: Richard Henderson > --- >  host/include/i386/host/cpuinfo.h    |   1 + >  host/include/i386/host/crypto/clmul.h   | 187 > >  host/incl

Re: [PATCH v3 7/8] hw/ide/ahci: fix ahci_write_fis_sdb()

2023-07-19 Thread Philippe Mathieu-Daudé
On 9/6/23 16:08, Niklas Cassel wrote: From: Niklas Cassel When there is an error, we need to raise a TFES error irq, see AHCI 1.3.1, 5.3.13.1 SDB:Entry. If ERR_STAT is set, we jump to state ERR:FatalTaskfile, which will raise a TFES IRQ unconditionally, regardless if the I bit is set in the FI

Re: [PATCH v3 8/8] hw/ide/ahci: fix broken SError handling

2023-07-19 Thread Philippe Mathieu-Daudé
On 9/6/23 16:08, Niklas Cassel wrote: From: Niklas Cassel When encountering an NCQ error, you should not write the NCQ tag to the SError register. This is completely wrong. The SError register has a clear definition, where each bit represents a different error, see PxSERR definition in AHCI 1.

Re: [PATCH v3 8/8] hw/ide/ahci: fix broken SError handling

2023-07-19 Thread Michael Tokarev
19.07.2023 14:59, Philippe Mathieu-Daudé wrote: On 9/6/23 16:08, Niklas Cassel wrote: From: Niklas Cassel When encountering an NCQ error, you should not write the NCQ tag to the SError register. This is completely wrong. The SError register has a clear definition, where each bit represents a

Re: [PATCH v2 06/14] tcg/{i386, s390x}: Add earlyclobber to the op_add2's first output

2023-07-19 Thread Philippe Mathieu-Daudé
Hi Ilya, On 19/7/23 11:44, Ilya Leoshkevich wrote: i386 and s390x implementations of op_add2 require an earlyclobber, which is currently missing. This breaks VCKSM in s390x guests. E.g., on x86_64 the following op: add2_i32 tmp2,tmp3,tmp2,tmp3,tmp3,tmp2 dead: 0 2 3 4 5 pref=none,0x

Re: [PATCH v3 8/8] hw/ide/ahci: fix broken SError handling

2023-07-19 Thread Philippe Mathieu-Daudé
On 19/7/23 14:06, Michael Tokarev wrote: 19.07.2023 14:59, Philippe Mathieu-Daudé wrote: On 9/6/23 16:08, Niklas Cassel wrote: From: Niklas Cassel When encountering an NCQ error, you should not write the NCQ tag to the SError register. This is completely wrong. The SError register has a clea

Re: [PATCH v2 06/14] tcg/{i386, s390x}: Add earlyclobber to the op_add2's first output

2023-07-19 Thread Ilya Leoshkevich
On Wed, 2023-07-19 at 14:08 +0200, Philippe Mathieu-Daudé wrote: > Hi Ilya, > > On 19/7/23 11:44, Ilya Leoshkevich wrote: > > i386 and s390x implementations of op_add2 require an earlyclobber, > > which is currently missing. This breaks VCKSM in s390x guests. > > E.g., on > > x86_64 the following

Re: [PATCH v3 0/8] vdpa: Send all CVQ state load commands in parallel

2023-07-19 Thread Hawkins Jiawei
在 2023/7/19 17:11, Michael S. Tsirkin 写道: > On Wed, Jul 19, 2023 at 03:53:45PM +0800, Hawkins Jiawei wrote: >> This patchset allows QEMU to delay polling and checking the device >> used buffer until either the SVQ is full or control commands shadow >> buffers are full, instead of polling and checki

Re: [PATCH] Wrong unpacked structure for epoll_event on qemu-or1k (openrisc user-space)

2023-07-19 Thread Luca Bonissi
On 19/07/23 10:49, Laurent Vivier wrote: According to linux/glibc sourced, epoll is only packed for x86_64. And, in recent glibc, also for i386, even it seems not necessary: even if the __alignof__(long long) is 8, structures like epoll_event are only 12 bytes, maybe "packed" for historical

Re: [PULL 0/8] s390x, qtest and misc patches for QEMU 8.1 rc1

2023-07-19 Thread Peter Maydell
On Tue, 18 Jul 2023 at 10:31, Thomas Huth wrote: > > The following changes since commit 361d5397355276e3007825cc17217c1e4d4320f7: > > Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into > staging (2023-07-17 15:49:27 +0100) > > are available in the Git repository at: > > h

Re: [PATCH v2 06/14] tcg/{i386, s390x}: Add earlyclobber to the op_add2's first output

2023-07-19 Thread Philippe Mathieu-Daudé
On 19/7/23 14:30, Ilya Leoshkevich wrote: On Wed, 2023-07-19 at 14:08 +0200, Philippe Mathieu-Daudé wrote: Hi Ilya, On 19/7/23 11:44, Ilya Leoshkevich wrote: i386 and s390x implementations of op_add2 require an earlyclobber, which is currently missing. This breaks VCKSM in s390x guests. E.g.,

Re: [PATCH v3 0/8] vdpa: Send all CVQ state load commands in parallel

2023-07-19 Thread Lei Yang
Hello Hawkins and Michael Looks like there are big changes about vp_vdpa, therefore, if needed, QE can test this series in QE's environment before the patch is merged, and provide the result. BR Lei On Wed, Jul 19, 2023 at 8:37 PM Hawkins Jiawei wrote: > > 在 2023/7/19 17:11, Michael S. Tsirkin

Re: [PATCH v3 0/8] vdpa: Send all CVQ state load commands in parallel

2023-07-19 Thread Michael S. Tsirkin
On Wed, Jul 19, 2023 at 08:35:50PM +0800, Hawkins Jiawei wrote: > 在 2023/7/19 17:11, Michael S. Tsirkin 写道: > > On Wed, Jul 19, 2023 at 03:53:45PM +0800, Hawkins Jiawei wrote: > >> This patchset allows QEMU to delay polling and checking the device > >> used buffer until either the SVQ is full or co

Re: [PULL 10/66] tests/qtest: enable tests for virtio-scmi

2023-07-19 Thread Thomas Huth
On 18/07/2023 14.55, Milan Zamazal wrote: Thomas Huth writes: On 11/07/2023 01.02, Michael S. Tsirkin wrote: From: Milan Zamazal We don't have a virtio-scmi implementation in QEMU and only support a vhost-user backend. This is very similar to virtio-gpio and we add the same set of tests,

Re: [PATCH v2 04/12] qtest: bump npcm7xx_pwn-test timeout to 5 minutes

2023-07-19 Thread Thomas Huth
On 17/07/2023 20.28, Daniel P. Berrangé wrote: The npcm7xx_pwn-test takes 3 & 1/2 minutes in a --enable-debug build. Bumping to 5 minutes will give more headroom. Signed-off-by: Daniel P. Berrangé --- tests/qtest/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH v2 05/12] qtest: bump test-hmp timeout to 4 minutes

2023-07-19 Thread Thomas Huth
On 17/07/2023 20.28, Daniel P. Berrangé wrote: The npcm7xx_pwn-test takes just under 3 minutes in a --enable-debug s/npcm7xx_pwn-test/test-hmp/ With that copy-n-paste error fixed: Reviewed-by: Thomas Huth build. Bumping to 4 minutes will give more headroom. Signed-off-by: Daniel P. Berra

Re: [PATCH v2 06/12] qtest: bump pxe-test timeout to 3 minutes

2023-07-19 Thread Thomas Huth
On 17/07/2023 20.28, Daniel P. Berrangé wrote: The pxe-test takes about 1 + 1/2 minutes in a --enable-debug build. Bumping to 3 minutes will give more headroom. Signed-off-by: Daniel P. Berrangé --- tests/qtest/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/meson

Re: [PATCH v2 07/12] qtest: bump prom-env-test timeout to 3 minutes

2023-07-19 Thread Thomas Huth
On 17/07/2023 20.28, Daniel P. Berrangé wrote: The prom-env-test takes about 1 + 1/2 minutes in a --enable-debug build. Bumping to 3 minutes will give more headroom. Signed-off-by: Daniel P. Berrangé --- tests/qtest/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/

Re: [PATCH v2 08/12] qtest: bump boot-serial-test timeout to 3 minutes

2023-07-19 Thread Thomas Huth
On 17/07/2023 20.28, Daniel P. Berrangé wrote: The boot-serial-test takes about 1 + 1/2 minutes in a --enable-debug build. Bumping to 3 minutes will give more headroom. Signed-off-by: Daniel P. Berrangé --- tests/qtest/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qte

Re: [PATCH v2 06/12] qtest: bump pxe-test timeout to 3 minutes

2023-07-19 Thread Thomas Huth
On 17/07/2023 20.28, Daniel P. Berrangé wrote: The pxe-test takes about 1 + 1/2 minutes in a --enable-debug build. Bumping to 3 minutes will give more headroom. Signed-off-by: Daniel P. Berrangé --- tests/qtest/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/meson

Re: [PATCH v2 09/12] qtest: bump qos-test timeout to 2 minutes

2023-07-19 Thread Thomas Huth
On 17/07/2023 20.28, Daniel P. Berrangé wrote: The qos-test takes just under 1 minute in a --enable-debug build. Bumping to 2 minutes will give more headroom. Signed-off-by: Daniel P. Berrangé --- tests/qtest/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/meson.b

Re: [PATCH] vhost-user.rst: Clarify enabling/disabling vrings

2023-07-19 Thread Hanna Czenczek
On 18.07.23 17:26, Stefan Hajnoczi wrote: On Wed, Jul 12, 2023 at 11:17:04AM +0200, Hanna Czenczek wrote: Currently, the vhost-user documentation says that rings are to be initialized in a disabled state when VHOST_USER_F_PROTOCOL_FEATURES is negotiated. However, by the time of feature negotiat

Re: [PATCH v2 10/12] qtest: bump aspeed_smc-test timeout to 4 minutes

2023-07-19 Thread Thomas Huth
On 17/07/2023 20.28, Daniel P. Berrangé wrote: On a reasonably old laptop this test takes 2 minutes 20 seconds with the arm emulator. Raising the timeout to 4 minutes gives greater headroom for slowdown. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- tests/qtest/meson.build |

Re: [PATCH v2 07/12] qtest: bump prom-env-test timeout to 3 minutes

2023-07-19 Thread Thomas Huth
On 19/07/2023 15.22, Thomas Huth wrote: On 17/07/2023 20.28, Daniel P. Berrangé wrote: The prom-env-test takes about 1 + 1/2 minutes in a --enable-debug build. Bumping to 3 minutes will give more headroom. Signed-off-by: Daniel P. Berrangé ---   tests/qtest/meson.build | 1 +   1 file changed,

Re: [PATCH v2 04/12] qtest: bump npcm7xx_pwn-test timeout to 5 minutes

2023-07-19 Thread Peter Maydell
On Wed, 19 Jul 2023 at 14:06, Thomas Huth wrote: > > On 17/07/2023 20.28, Daniel P. Berrangé wrote: > > The npcm7xx_pwn-test takes 3 & 1/2 minutes in a --enable-debug build. > > Bumping to 5 minutes will give more headroom. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > tests/qtest/meson

Re: [PATCH v2 07/12] qtest: bump prom-env-test timeout to 3 minutes

2023-07-19 Thread Daniel P . Berrangé
On Wed, Jul 19, 2023 at 03:22:30PM +0200, Thomas Huth wrote: > On 17/07/2023 20.28, Daniel P. Berrangé wrote: > > The prom-env-test takes about 1 + 1/2 minutes in a --enable-debug > > build. Bumping to 3 minutes will give more headroom. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > test

[RFC 1/1] virtio-pci: add SR-IOV capability

2023-07-19 Thread Yui Washizu
This enables SR-IOV emulation on virtio-pci devices by adding SR-IOV capability It also introduces a newly added property 'sriov_max_vfs' to enable or disable the SR-IOV feature on the virtio-pci device in guest, as well as to specify the maximum number of VFs that can be created in the guest. Cur

[RFC 0/1] virtio-net: add support for SR-IOV emulation

2023-07-19 Thread Yui Washizu
This patch series is the first step towards enabling hardware offloading of the L2 packet switching feature on virtio-net device to host machine. We are considering that this hardware offloading enables the use of high-performance networks in virtual infrastructures, such as container infrastructu

Re: [PATCH 1/6] vhost-user.rst: Add suspend/resume

2023-07-19 Thread Hanna Czenczek
On 18.07.23 16:25, Stefan Hajnoczi wrote: On Tue, Jul 11, 2023 at 05:52:23PM +0200, Hanna Czenczek wrote: When stopping the VM, qemu wants all devices to fully cease any operation, too. Currently, we can only have vhost-user back-ends stop processing vrings, but not background operations. Add

Re: [PATCH] vhost-user.rst: Clarify enabling/disabling vrings

2023-07-19 Thread Stefan Hajnoczi
On Wed, 19 Jul 2023 at 09:34, Hanna Czenczek wrote: > > On 18.07.23 17:26, Stefan Hajnoczi wrote: > > On Wed, Jul 12, 2023 at 11:17:04AM +0200, Hanna Czenczek wrote: > >> Currently, the vhost-user documentation says that rings are to be > >> initialized in a disabled state when VHOST_USER_F_PROTOC

Re: [PATCH v2 06/14] tcg/{i386, s390x}: Add earlyclobber to the op_add2's first output

2023-07-19 Thread Philippe Mathieu-Daudé
On 19/7/23 11:44, Ilya Leoshkevich wrote: i386 and s390x implementations of op_add2 require an earlyclobber, which is currently missing. This breaks VCKSM in s390x guests. E.g., on x86_64 the following op: add2_i32 tmp2,tmp3,tmp2,tmp3,tmp3,tmp2 dead: 0 2 3 4 5 pref=none,0x is transl

Re: [PATCH v21 16/20] tests/avocado: s390x cpu topology entitlement tests

2023-07-19 Thread Pierre Morel
On 7/14/23 18:30, Nina Schoetterl-Glausch wrote: On Wed, 2023-07-12 at 22:11 +0200, Thomas Huth wrote: On 12/07/2023 21.37, Nina Schoetterl-Glausch wrote: On Wed, 2023-07-05 at 12:22 +0200, Thomas Huth wrote: On 30/06/2023 11.17, Pierre Morel wrote: This test takes care to check the changes

Re: [PATCH v21 17/20] tests/avocado: s390x cpu topology test dedicated CPU

2023-07-19 Thread Pierre Morel
Same as for the previous test. I rewrite this to check the guest view. On 6/30/23 11:17, Pierre Morel wrote: A dedicated CPU in vertical polarization can only have a high entitlement. Let's check this. Signed-off-by: Pierre Morel --- tests/avocado/s390_topology.py | 28 ++

  1   2   3   >