Re: [PATCH] tcg/ppc: Fix race in goto_tb implementation

On 7/17/23 06:53, Jordan Niethe wrote: Commit 20b6643324 ("tcg/ppc: Reorg goto_tb implementation") modified goto_tb to ensure only a single instruction was patched to prevent incorrect behaviour if a thread was in the middle of multiple instructions when they were replaced. However this introdu

Re: [PATCH] tcg/ppc: Fix race in goto_tb implementation

On 7/17/23 02:23, Jordan Niethe wrote: Commit 20b6643324 ("tcg/ppc: Reorg goto_tb implementation") modified goto_tb to ensure only a single instruction was patched to prevent incorrect behaviour if a thread was in the middle of multiple instructions when they were replaced. However this introduce

Re: [PATCH] vnc,ps2: fix the PS/2 mouse work badly when connect VNC

Hi Shiyuan On Mon, Jul 17, 2023 at 7:16 AM Shiyuan Gao wrote: > When only use PS/2 mouse without usb-tablet, the mouse pointer of the > guest on the VNC will work badly that the cursor of VNC is inconsistent > with the mouse pointer of guest. > > Afaik, VNC doesn't support client-side drawing of

Re: [PATCH][PING] linux-user/elfload: Fix /proc/cpuinfo features: on s390x

On 7/14/23 13:16, Ilya Leoshkevich wrote: On Wed, 2023-06-28 at 09:49 +0200, Richard Henderson wrote: On 6/27/23 17:13, Ilya Leoshkevich wrote: elf_hwcap_str() takes a bit number, but compares it for equality with the HWCAP_S390_* masks. This causes /proc/cpuinfo to display incorrect hwcaps. F

Re: [PATCH] tcg/ppc: Fix race in goto_tb implementation

On 7/17/23 09:35, Richard Henderson wrote: On 7/17/23 02:23, Jordan Niethe wrote: Commit 20b6643324 ("tcg/ppc: Reorg goto_tb implementation") modified goto_tb to ensure only a single instruction was patched to prevent incorrect behaviour if a thread was in the middle of multiple instructions whe

Re: x86 custom apicid assignments [Was: Re: [PATCH v7 0/2] Remove EPYC mode apicid decode and use generic decode]

Hello Igor, thanks for getting back to me on this, On 7/14/23 11:51, Igor Mammedov wrote: > On Wed, 5 Jul 2023 10:12:40 +0200 > Claudio Fontana wrote: > >> Hi all, partially resurrecting an old thread. >> >> I've seen how for Epyc something special was done in the past in terms of >> apicid as

Re: x86 custom apicid assignments [Was: Re: [PATCH v7 0/2] Remove EPYC mode apicid decode and use generic decode]

On 7/17/23 10:32, Claudio Fontana wrote: > Hello Igor, > > thanks for getting back to me on this, > > On 7/14/23 11:51, Igor Mammedov wrote: >> On Wed, 5 Jul 2023 10:12:40 +0200 >> Claudio Fontana wrote: >> >>> Hi all, partially resurrecting an old thread. >>> >>> I've seen how for Epyc somethin

Missing cache information on x86-64 under Intel TDX (glibc bug 30643)

This is a continuation of glibc bug 30037, whose root cause was not fixed: Missing cache information on x86-64 under Intel TDX glibc 2.34 and newer segfault if CPUID leaf 0x2 reports zero

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

Am 5. Juli 2023 10:01:21 UTC schrieb Olaf Hering : >Tue, 4 Jul 2023 08:38:33 +0200 Paolo Bonzini : > >> I agree that calling pci_device_reset() would be a better match for >> pci_xen_ide_unplug(). > >This change works as well: > >--- a/hw/i386/xen/xen_platform.c >+++ b/hw/i386/xen/xen_platform.

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

Mon, 17 Jul 2023 08:46:16 + Bernhard Beschow : > Would you mind sending this patch as well? Sure, I was waiting for the other change to appear in the master branch, so I can reference it in the new commit message. Olaf pgpICjazXPmwt.pgp Description: Digitale Signatur von OpenPGP

Re: [PATCH] vnc,ps2: fix the PS/2 mouse work badly when connect VNC

Hi, > Hi Shiyuan > > On Mon, Jul 17, 2023 at 7:16 AM Shiyuan Gao wrote: > > > When only use PS/2 mouse without usb-tablet, the mouse pointer of the > > guest on the VNC will work badly that the cursor of VNC is inconsistent > > with the mouse pointer of guest. > > > > > Afaik, VNC doesn't support

Re: [PATCH] tcg/ppc: Fix race in goto_tb implementation

17.07.2023 04:23, Jordan Niethe wrote: Commit 20b6643324 ("tcg/ppc: Reorg goto_tb implementation") modified goto_tb to ensure only a single instruction was patched to prevent incorrect behaviour if a thread was in the middle of multiple instructions when they were replaced. However this introduce

Re: [PATCH] vnc,ps2: fix the PS/2 mouse work badly when connect VNC

Hi On Mon, Jul 17, 2023 at 12:54 PM Gao,Shiyuan wrote: > Hi, > > Hi Shiyuan > > > > On Mon, Jul 17, 2023 at 7:16 AM Shiyuan Gao > wrote: > > > > > When only use PS/2 mouse without usb-tablet, the mouse pointer of the > > > guest on the VNC will work badly that the cursor of VNC is inconsistent

Re: [PATCH] virtio-gpu-udmabuf: correct naming of QemuDmaBuf size properties

On Thu, Jul 13, 2023 at 8:28 AM Dongwon Kim wrote: > Replace 'width' and 'height' in QemuDmaBuf with 'backing_widht' > and 'backing_height' as these commonly indicate the size of the > whole surface (e.g. guest's Xorg extended display). Then use > 'width' and 'height' for sub region in there (e.g

Re: [PATCH] ui/gtk: set scanout-mode right before scheduling draw

On Thu, Jul 6, 2023 at 10:57 PM Dongwon Kim wrote: > Setting scanout mode is better to be done very last minute > right because the mode can be reset anytime after it is set in > dpy_gl_scanout_texture by any asynchronouse dpy_refresh call, > which eventually cancels drawing of the guest scanout

Re: [PATCH] ui/gtk: skip refresh if new dmabuf has been submitted

On Thu, Jul 6, 2023 at 10:57 PM Dongwon Kim wrote: > Skip refresh if a new dmabuf (guest scanout frame) has already been > submitted and ready to be drawn because the scanout will be updated > with new frame anyway. > > Cc: Gerd Hoffmann > Cc: Marc-André Lureau > Cc: Vivek Kasireddy > Signed-o

[PATCH] vhost: disable VHOST_OPS_DEBUG by default

This commit disables VHOST_OPS_DEBUG by default These information are ususally only required in development environment Signed-off-by: Zhu Lingshan --- hw/virtio/vhost.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 82394331

Re: [PATCH 0/6] trivial-patches for 2023-07-16

16.07.2023 18:58, Philippe Mathieu-Daudé wrote: ... Michael Tokarev (5):    tree-wide spelling fixes in comments and some messages: migration/    tree-wide spelling fixes in comments and some messages: s390x    tree-wide spelling fixes in comments and some messages: arm    tree-wide spelling fixe

Re: [PATCH] vnc,ps2: fix the PS/2 mouse work badly when connect VNC

On Mon, Jul 17, 2023 at 10:59:36AM +0800, Shiyuan Gao wrote: > When only use PS/2 mouse without usb-tablet, the mouse pointer of the > guest on the VNC will work badly that the cursor of VNC is inconsistent > with the mouse pointer of guest. > > The reason is the PS/2 mouse use relative coordinate

Re: [PATCH] vnc,ps2: fix the PS/2 mouse work badly when connect VNC

On Mon, Jul 17, 2023 at 01:16:41PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Jul 17, 2023 at 12:54 PM Gao,Shiyuan wrote: > > > Hi, > > > Hi Shiyuan > > > > > > On Mon, Jul 17, 2023 at 7:16 AM Shiyuan Gao > > wrote: > > > > > > > When only use PS/2 mouse without usb-tablet, the mouse poin

Re: [PATCH] hw/nvram: Avoid unnecessary Xilinx eFuse backstore write

On Wed, 26 Apr 2023 at 22:16, Tong Ho wrote: > > Add a check in the bit-set operation to write the backstore > only if the affected bit is 0 before. > > With this in place, there will be no need for callers to > do the checking in order to avoid unnecessary writes. > > Signed-off-by: Tong Ho > --

Re: [PATCH for-8.1] accel/tcg: Take mmap_lock in load_atomic16_or_exit

On Sun, 16 Jul 2023 at 18:03, Richard Henderson wrote: > > For user-only, the probe for page writability may race with another > thread's mprotect. Take the mmap_lock around the operation. This > is still faster than the start/end_exclusive fallback. > > Remove the write probe in load_atomic8_or

Re: [PATCH] vhost: disable VHOST_OPS_DEBUG by default

Hi, On 17/7/23 19:44, Zhu Lingshan wrote: This commit disables VHOST_OPS_DEBUG by default These information are ususally only required in development environment Signed-off-by: Zhu Lingshan --- hw/virtio/vhost.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/vi

[PATCH v2] target/sparc: Handle FPRS correctly on big-endian hosts

In CPUSparcState we define the fprs field as uint64_t. However we then refer to it in translate.c via a TCGv_i32 which we set up with tcg_global_mem_new_ptr(). This means that on a big-endian host when the guest does something to writo te the FPRS register this value ends up in the wrong half of

Re: x86 custom apicid assignments [Was: Re: [PATCH v7 0/2] Remove EPYC mode apicid decode and use generic decode]

On Mon, 17 Jul 2023 10:32:33 +0200 Claudio Fontana wrote: > Hello Igor, > > thanks for getting back to me on this, > > On 7/14/23 11:51, Igor Mammedov wrote: > > On Wed, 5 Jul 2023 10:12:40 +0200 > > Claudio Fontana wrote: > > > >> Hi all, partially resurrecting an old thread. > >> > >> I'v

Re: [PATCH] block/nvme: invoke blk_io_plug_call() outside q->lock

Thank you, Stefan, I tested this one as well and it boots now and seems to behave correctly under the load as well. Regards, Lukáš Tested-by: Lukas Doktor Dne 12. 07. 23 v 21:16 Stefan Hajnoczi napsal(a): > blk_io_plug_call() is invoked outside a blk_io_plug()/blk_io_unplug() > section while o

Re: [PATCH for-8.1] accel/tcg: Take mmap_lock in load_atomic16_or_exit

Richard Henderson writes: > For user-only, the probe for page writability may race with another > thread's mprotect. Take the mmap_lock around the operation. This > is still faster than the start/end_exclusive fallback. Did we have a bug report or replication for this? > > Remove the write

Re: [PATCH v6 4/5] intel_iommu: allow Extended Interrupt Mode when using userspace APIC

+Peter, +Jason (intel-iommu maintainer/reviewer) On 15/07/2023 16:22, Bui Quang Minh wrote: > As userspace APIC now supports x2APIC, intel interrupt remapping > hardware can be set to EIM mode when userspace local APIC is used. > > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Bui Quang Minh

Re: [PATCH v2] io: remove io watch if TLS channel is closed during handshake

12.07.2023 19:55, Daniel P. Berrangé wrote: The TLS handshake make take some time to complete, during which time an I/O watch might be registered with the main loop. If the owner of the I/O channel invokes qio_channel_close() while the handshake is waiting to continue the I/O watch must be remove

Re: [PULL 46/66] virtio-iommu: Fix 64kB host page size VFIO device assignment

On Tue, 11 Jul 2023 at 00:04, Michael S. Tsirkin wrote: > > From: Eric Auger > > When running on a 64kB page size host and protecting a VFIO device > with the virtio-iommu, qemu crashes with this kind of message: > > qemu-kvm: virtio-iommu page mask 0xf000 is incompatible > with mask

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

Mon, 17 Jul 2023 08:46:16 + Bernhard Beschow : > The PIIX fix alone just fixes the syptom, not the underlying problem. The > underlying problem is that the BAR isn't deactivated, and with the PIIX patch > it will stay at address zero rather than in the USB function address range. Did you me

Re: [PULL 4/9] target/i386: Adjust feature level according to FEAT_7_1_EDX

07.07.2023 17:04, Paolo Bonzini wrote: From: Tao Su If FEAT_7_1_EAX is 0 and FEAT_7_1_EDX is non-zero, as is the case with a Granite Rapids host and '-cpu host,-avx-vnni,-avx512-bf16,-fzrm,-fsrs,-fsrc,-amx-fp16', we can't get CPUID_7_1 leaf even though CPUID_7_1_EDX has non-zero value. Update

Re: [PATCH 0/3] vhost-user-gpu: support dmabuf modifiers

On Fri, Jul 14, 2023 at 05:38:57PM +0200, Erico Nunes wrote: > virglrenderer recently added virgl_renderer_resource_get_info_ext as a > new api, which gets resource information, including dmabuf modifiers. > https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/1024 > > We have to su

Re: [PATCH v2] target/sparc: Handle FPRS correctly on big-endian hosts

On 17/7/23 12:35, Peter Maydell wrote: In CPUSparcState we define the fprs field as uint64_t. However we then refer to it in translate.c via a TCGv_i32 which we set up with tcg_global_mem_new_ptr(). This means that on a big-endian host when the guest does something to writo te the FPRS register

Re: [PATCH v2] target/sparc: Handle FPRS correctly on big-endian hosts

On 17/7/23 13:30, Philippe Mathieu-Daudé wrote: On 17/7/23 12:35, Peter Maydell wrote: In CPUSparcState we define the fprs field as uint64_t.  However we then refer to it in translate.c via a TCGv_i32 which we set up with tcg_global_mem_new_ptr().  This means that on a big-endian host when the g

Re: [PATCH v2] target/sparc: Handle FPRS correctly on big-endian hosts

On Mon, 17 Jul 2023 at 12:32, Philippe Mathieu-Daudé wrote: > > On 17/7/23 13:30, Philippe Mathieu-Daudé wrote: > > On 17/7/23 12:35, Peter Maydell wrote: > >> In CPUSparcState we define the fprs field as uint64_t. However we > >> then refer to it in translate.c via a TCGv_i32 which we set up wit

Re: [PATCH v4 3/4] vhost-user: add shared_object msg

Hi Michael, True. It may be a good idea to impose a limit in the number of entries that can be added to the table. And fail to add new entries once it reaches the limit. Not sure what would be a good limit though. For example, https://www.kernel.org/doc/html/v4.9/media/uapi/v4l/vidioc-reqbufs.htm

Re: [PATCH] target/sparc: Handle FPRS correctly on big-endian hosts

On 16/7/23 19:32, Peter Maydell wrote: On Fri, 14 Jul 2023 at 18:52, Philippe Mathieu-Daudé wrote: Hi Peter, On 14/7/23 19:26, Peter Maydell wrote: In CPUSparcState we define the fprs field as uint64_t. However we then refer to it in translate.c via a TCGv_i32 which we set up with tcg_globa

Re: [PULL 46/66] virtio-iommu: Fix 64kB host page size VFIO device assignment

On Mon, Jul 17, 2023 at 11:50:54AM +0100, Peter Maydell wrote: > On Tue, 11 Jul 2023 at 00:04, Michael S. Tsirkin wrote: > > > > From: Eric Auger > > > > When running on a 64kB page size host and protecting a VFIO device > > with the virtio-iommu, qemu crashes with this kind of message: > > > > q

Re: [PATCH v3 0/4] tests/vm/freebsd: Get up-to-date package list from lcitool

On 11/07/2023 16.49, Philippe Mathieu-Daudé wrote: Inspired by this patch from Thomas: https://lore.kernel.org/qemu-devel/20230531090415.40421-1-th...@redhat.com/ Instead of updating the package list manually, use lcitool vars file. Since v2: - Commit generated json (Daniel) Since v1: - Addres

Re: [PATCH v3 0/4] tests/vm/freebsd: Get up-to-date package list from lcitool

On Mon, Jul 17, 2023 at 02:18:34PM +0200, Thomas Huth wrote: > On 11/07/2023 16.49, Philippe Mathieu-Daudé wrote: > > Inspired by this patch from Thomas: > > https://lore.kernel.org/qemu-devel/20230531090415.40421-1-th...@redhat.com/ > > > > Instead of updating the package list manually, use lcito

Re: [PATCH][PING] linux-user/elfload: Fix /proc/cpuinfo features: on s390x

On 17/07/2023 09.44, Richard Henderson wrote: On 7/14/23 13:16, Ilya Leoshkevich wrote: On Wed, 2023-06-28 at 09:49 +0200, Richard Henderson wrote: On 6/27/23 17:13, Ilya Leoshkevich wrote: elf_hwcap_str() takes a bit number, but compares it for equality with the HWCAP_S390_* masks. This cause

Re: [PATCH 0/3] hw/arm/virt: Use generic CPU invalidation

On Fri, 14 Jul 2023 13:56:00 +0100 Peter Maydell wrote: > On Fri, 14 Jul 2023 at 12:50, Igor Mammedov wrote: > > > > On Thu, 13 Jul 2023 12:59:55 +0100 > > Peter Maydell wrote: > > > > > On Thu, 13 Jul 2023 at 12:52, Marcin Juszkiewicz > > > wrote: > > > > > > > > W dniu 13.07.2023 o 13:44

[PULL 00/19] UI & audio patches

From: Marc-André Lureau The following changes since commit ed8ad9728a9c0eec34db9dff61dfa2f1dd625637: Merge tag 'pull-tpm-2023-07-14-1' of https://github.com/stefanberger/qemu-tpm into staging (2023-07-15 14:54:04 +0100) are available in the Git repository at: https://gitlab.com/marcandre.

[PULL 07/19] ui/gtk: skip refresh if new dmabuf has been submitted

From: Dongwon Kim Skip refresh if a new dmabuf (guest scanout frame) has already been submitted and ready to be drawn because the scanout will be updated with new frame anyway. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Vivek Kasireddy Signed-off-by: Dongwon Kim Acked-by: Marc-André Lureau

[PULL 01/19] virtio-gpu: fix potential divide-by-zero regression

From: Marc-André Lureau Commit 9462ff4695aa0 ("virtio-gpu/win32: allocate shareable 2d resources/images") introduces a division, which can lead to crashes when "height" is 0. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1744 Reviewed-by: Alexander Bulekov Signed-off-by: Marc-André Lurea

[PULL 02/19] ui/vnc-clipboard: fix infinite loop in inflate_buffer (CVE-2023-3255)

From: Mauro Matteo Cascella A wrong exit condition may lead to an infinite loop when inflating a valid zlib buffer containing some extra bytes in the `inflate_buffer` function. The bug only occurs post-authentication. Return the buffer immediately if the end of the compressed data has been reache

[PULL 14/19] audio/pw: add more details on error

From: Marc-André Lureau PipeWire uses errno to report error details. Signed-off-by: Marc-André Lureau Reviewed-by: Volker Rümelin Message-Id: <20230506163735.3481387-8-marcandre.lur...@redhat.com> --- audio/pwaudio.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/a

[PULL 06/19] ui/gtk: set scanout-mode right before scheduling draw

From: Dongwon Kim Setting scanout mode is better to be done very last minute right because the mode can be reset anytime after it is set in dpy_gl_scanout_texture by any asynchronouse dpy_refresh call, which eventually cancels drawing of the guest scanout texture. Cc: Gerd Hoffmann Cc: Marc-And

[PULL 03/19] ui/gtk: Make sure the right EGL context is currently bound

From: Dongwon Kim Observed a wrong context is bound when changing the scanout mode. To prevent problem, it is needed to make sure to bind the right context in gtk_egl_set_scanout_mode/gtk_gl_area_set_scanout_mode as well as unbind one in the end of gd_egl_update/gd_gl_area_update. Cc: Gerd Hoffm

[PULL 10/19] audio/pw: Pipewire->PipeWire case fix for user-visible text

From: Marc-André Lureau "PipeWire" is the correct case. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Volker Rümelin Message-Id: <20230506163735.3481387-4-marcandre.lur...@redhat.com> --- meson.build | 2 +- qapi/audio.json

[PULL 16/19] audio/pw: add more error reporting

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Volker Rümelin Message-Id: <20230506163735.3481387-10-marcandre.lur...@redhat.com> --- audio/pwaudio.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/audio/pwaudio.c b/audio/pwaudio.c index 70f0c46

[PULL 17/19] audio/pw: simplify error reporting in stream creation

From: Marc-André Lureau create_stream() now reports on all error paths. Signed-off-by: Marc-André Lureau Reviewed-by: Volker Rümelin Message-Id: <20230506163735.3481387-11-marcandre.lur...@redhat.com> --- audio/pwaudio.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff

[PULL 11/19] audio/pw: drop needless case statement

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Volker Rümelin Message-Id: <20230506163735.3481387-5-marcandre.lur...@redhat.com> --- audio/pwaudio.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/audio/pwaudio.c b/audio/pwaudio.c index 9eb69bfd18..51cfc0b

[PULL 0/7] target-arm queue

ository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20230717 for you to fetch changes up to c2c1c4a35c7c2b1a4140b0942b9797c857e476a4: hw/nvram: Avoid unnecessary Xilinx eFuse backstore write (2023-07-17 11:05

[PULL 6/7] accel/tcg: Zero-pad PC in TCG CPU exec trace lines

In commit f0a08b0913befbd we changed the type of the PC from target_ulong to vaddr. In doing so we inadvertently dropped the zero-padding on the PC in trace lines (the second item inside the [] in these lines). They used to look like this on AArch64, for instance: Trace 0: 0x7f226100 [00

[PULL 19/19] audio/pw: improve channel position code

From: Marc-André Lureau Follow PulseAudio backend comment and code, and only implement the channels QEMU actually supports at this point, and add the same comment about limits and future mappings. Simplify a bit the code. Signed-off-by: Marc-André Lureau Reviewed-by: Volker Rümelin Message-Id:

Re: [PATCH v2] plugins: Set final instruction count in plugin_gen_tb_end

Matt Borgerson writes: > Translation logic may partially decode an instruction, then abort and > remove the instruction from the TB. This can happen for example when an > instruction spans two pages. In this case, plugins may get an incorrect > result when calling qemu_plugin_tb_n_insns to quer

[PULL 08/19] libvirt-ci: update submodule to cover pipewire

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20230506163735.3481387-2-marcandre.lur...@redhat.com> --- tests/lcitool/libvirt-ci | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/lcitool/libvirt-ci b/tests/lcitool/libvirt-ci index b0f44f929a..9bff

[PULL 2/7] linux-user: Remove pointless NULL check in clock_adjtime handling

In the code for TARGET_NR_clock_adjtime, we set the pointer phtx to the address of the local variable htx. This means it can never be NULL, but later in the code we check it for NULL anyway. Coverity complains about this (CID 1507683) because the NULL check comes after a call to clock_adjtime() t

[PULL 3/7] target/arm/ptw.c: Add comments to S1Translate struct fields

Add comments to the in_* fields in the S1Translate struct that explain what they're doing. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20230710152130.3928330-2-peter.mayd...@linaro.org --- target/arm/ptw.c | 40 1 file changed

[PULL 5/7] target/arm/ptw.c: Account for FEAT_RME when applying {N}SW, SA bits

In get_phys_addr_twostage() the code that applies the effects of VSTCR.{SA,SW} and VTCR.{NSA,NSW} only updates result->f.attrs.secure. Now we also have f.attrs.space for FEAT_RME, we need to keep the two in sync. These bits only have an effect for Secure space translations, not for Root, so use th

[PULL 12/19] audio/pw: needless check for NULL

From: Marc-André Lureau g_clear_pointer() already checks for NULL. Signed-off-by: Marc-André Lureau Reviewed-by: Volker Rümelin Message-Id: <20230506163735.3481387-6-marcandre.lur...@redhat.com> --- audio/pwaudio.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/au

Re: [PATCH] vnc,ps2: fix the PS/2 mouse work badly when connect VNC

> > > > > > > So move the guest mouse pointer to (0, 0) of the screen when connect the > > > > VNC, and then move the mouse pointer to the cursor of VNC(absolute > > > > coordinates are also relative coordinates). > > > > > > > > > > > It's hardly a solution, you still have no clue what will be the

[PULL 7/7] hw/nvram: Avoid unnecessary Xilinx eFuse backstore write

From: Tong Ho Add a check in the bit-set operation to write the backstore only if the affected bit is 0 before. With this in place, there will be no need for callers to do the checking in order to avoid unnecessary writes. Signed-off-by: Tong Ho Reviewed-by: Alistair Francis Reviewed-by: Fran

[PULL 04/19] virtio-gpu: replace the surface with null surface when resetting

From: Dongwon Kim The primary guest scanout shows the booting screen right after reboot but additional guest displays (i.e. max_ouptuts > 1) will keep displaying the old frames until the guest virtio gpu driver gets initialized, which could cause some confusion. A better way is to to replace the

[PULL 4/7] target/arm: Fix S1_ptw_translate() debug path

In commit fe4a5472ccd6 we rearranged the logic in S1_ptw_translate() so that the debug-access "call get_phys_addr_*" codepath is used both when S1 is doing ptw reads from stage 2 and when it is doing ptw reads from physical memory. However, we didn't update the calculation of s2ptw->in_space and s

[PULL 18/19] audio/pw: remove wrong comment

From: Marc-André Lureau The stream is actually created connected. Signed-off-by: Marc-André Lureau Reviewed-by: Volker Rümelin Message-Id: <20230506163735.3481387-12-marcandre.lur...@redhat.com> --- audio/pwaudio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/audio/pwaudio.c b/audio/pwa

[PULL 1/7] hw/arm/sbsa-ref: set 'slots' property of xhci

From: Yuquan Wang This extends the slots of xhci to 64, since the default xhci_sysbus just supports one slot. Signed-off-by: Wang Yuquan Signed-off-by: Chen Baozi Reviewed-by: Richard Henderson Reviewed-by: Marcin Juszkiewicz Tested-by: Marcin Juszkiewicz Message-id: 20230710063750.473510-2

Re: [PATCH] vnc,ps2: fix the PS/2 mouse work badly when connect VNC

> On Mon, Jul 17, 2023 at 10:59:36AM +0800, Shiyuan Gao wrote: > > When only use PS/2 mouse without usb-tablet, the mouse pointer of the > > guest on the VNC will work badly that the cursor of VNC is inconsistent > > with the mouse pointer of guest. > > > > The reason is the PS/2 mouse use relative

[PULL 13/19] audio/pw: trace during init before calling pipewire API

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Volker Rümelin Message-Id: <20230506163735.3481387-7-marcandre.lur...@redhat.com> --- audio/pwaudio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/audio/pwaudi

[PULL 15/19] audio/pw: factorize some common code

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Volker Rümelin Message-Id: <20230506163735.3481387-9-marcandre.lur...@redhat.com> --- audio/pwaudio.c | 85 - 1 file changed, 34 insertions(+), 51 deletions(-) diff --git a/au

[PULL 09/19] tests/lcitool: add pipewire

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230506163735.3481387-3-marcandre.lur...@redhat.com> --- tests/docker/dockerfiles/alpine.docker| 1 + tests/docker/dockerfiles/centos8.docker | 1 + tests/do

[PULL 05/19] virtio-gpu-udmabuf: correct naming of QemuDmaBuf size properties

From: Dongwon Kim Replace 'width' and 'height' in QemuDmaBuf with 'backing_widht' and 'backing_height' as these commonly indicate the size of the whole surface (e.g. guest's Xorg extended display). Then use 'width' and 'height' for sub region in there (e.g. guest's scanouts). Cc: Gerd Hoffmann

[PATCH v2] tcg/ppc: Fix race in goto_tb implementation

Commit 20b6643324 ("tcg/ppc: Reorg goto_tb implementation") modified goto_tb to ensure only a single instruction was patched to prevent incorrect behavior if a thread was in the middle of multiple instructions when they were replaced. However this introduced a race between loading the jmp target in

Re: [PATCH] vnc,ps2: fix the PS/2 mouse work badly when connect VNC

Hi On Mon, Jul 17, 2023 at 4:53 PM Gao,Shiyuan wrote: > > > > > > > > > So move the guest mouse pointer to (0, 0) of the screen when connect > the > > > > > VNC, and then move the mouse pointer to the cursor of VNC(absolute > > > > > coordinates are also relative coordinates). > > > > > > > > >

[PATCH] tcg/ppc: Fix race in goto_tb implementation

Commit 20b6643324 ("tcg/ppc: Reorg goto_tb implementation") modified goto_tb to ensure only a single instruction was patched to prevent incorrect behaviour if a thread was in the middle of multiple instructions when they were replaced. However this introduced a race between loading the jmp target i

Re: [PATCH] tcg/ppc: Fix race in goto_tb implementation

On Mon, Jul 17, 2023 at 11:24 AM Jordan Niethe wrote: [snip] > > Reported-by: Anushree Mathur > Co-developed-by: Benjamin Gray > Signed-off-by: Jordan Niethe Sorry, should also have: Signed-off-by: Benjamin Gray [snip]

Re: [PATCH v3 0/4] tests/vm/freebsd: Get up-to-date package list from lcitool

On Mon, Jul 17, 2023 at 02:30:03PM +0200, Erik Skultety wrote: > On Mon, Jul 17, 2023 at 02:18:34PM +0200, Thomas Huth wrote: > > On 11/07/2023 16.49, Philippe Mathieu-Daudé wrote: > > > Inspired by this patch from Thomas: > > > https://lore.kernel.org/qemu-devel/20230531090415.40421-1-th...@redhat

[PATCH for-8.1] hw/arm/smmu: Handle big-endian hosts correctly

The implementation of the SMMUv3 has multiple places where it reads a data structure from the guest and directly operates on it without doing a guest-to-host endianness conversion. Since all SMMU data structures are little-endian, this means that the SMMU doesn't work on a big-endian host. In par

Re: x86 custom apicid assignments [Was: Re: [PATCH v7 0/2] Remove EPYC mode apicid decode and use generic decode]

On 7/17/23 12:37, Igor Mammedov wrote: > On Mon, 17 Jul 2023 10:32:33 +0200 > Claudio Fontana wrote: > >> Hello Igor, >> >> thanks for getting back to me on this, >> >> On 7/14/23 11:51, Igor Mammedov wrote: >>> On Wed, 5 Jul 2023 10:12:40 +0200 >>> Claudio Fontana wrote: >>> Hi all, par

Re: [PATCH] vnc,ps2: fix the PS/2 mouse work badly when connect VNC

> Hi > > On Mon, Jul 17, 2023 at 4:53 PM Gao,Shiyuan wrote: > > > > > > > > > > > > So move the guest mouse pointer to (0, 0) of the screen when connect > > the > > > > > > VNC, and then move the mouse pointer to the cursor of VNC(absolute > > > > > > coordinates are also relative coordinates). >

Re: [PATCH v2 06/11] tpm_crb: move ACPI table building to device interface

On Fri, 14 Jul 2023 13:21:33 -0400 Stefan Berger wrote: > On 7/14/23 03:09, Joelle van Dyne wrote: > > This logic is similar to TPM TIS ISA device. Since TPM CRB can only > > support TPM 2.0 backends, we check for this in realize. > > > > Signed-off-by: Joelle van Dyne > > This patch changes

Re: [PATCH 1/1] qemu-nbd: fix regression with qemu-nbd --fork run over ssh

On 7/14/23 17:35, Eric Blake wrote: On Thu, Jul 06, 2023 at 09:15:45PM +0200, Denis V. Lunev wrote: Commit e6df58a5578fee7a50bbf36f4a50a2781cff855d Author: Hanna Reitz Date: Wed May 8 23:18:18 2019 +0200 qemu-nbd: Do not close stderr has introduced an interesting regression. Or

Re: [PATCH v2 05/11] tpm_crb: use the ISA bus

On Fri, 14 Jul 2023 00:09:21 -0700 Joelle van Dyne wrote: > Since this device is gated to only build for targets with the PC > configuration, we should use the ISA bus like with TPM TIS. does it affect migration in any way? From guest pov it looks like there a new ISA device will appear and then

Re: [PATCH v4 2/4] virtio-dmabuf: introduce virtio-dmabuf

Hi, > > M: Stefan Hajnoczi > > S: Supported > > Hmm new functionality that no one seems to care > about enough to review, > > Gerd you suggested this - ready to be a maintainer? > co-maintain with Albert? Quite busy with firmware, I don't really have the time to take more qemu stuff, I'm a

Re: [PATCH v2 07/11] hw/arm/virt: add plug handler for TPM on SysBus

On Fri, 14 Jul 2023 00:09:23 -0700 Joelle van Dyne wrote: > TPM needs to know its own base address in order to generate its DSDT > device entry. > > Signed-off-by: Joelle van Dyne > --- > hw/arm/virt.c | 37 + > 1 file changed, 37 insertions(+) > > diff --g

Re: [PATCH] vnc,ps2: fix the PS/2 mouse work badly when connect VNC

Hi On Mon, Jul 17, 2023 at 5:43 PM Gao,Shiyuan wrote: > > Hi > > > > On Mon, Jul 17, 2023 at 4:53 PM Gao,Shiyuan > wrote: > > > > > > > > > > > > > > > So move the guest mouse pointer to (0, 0) of the screen when > connect > > > the > > > > > > > VNC, and then move the mouse pointer to the curs

Re: [PATCH v2 09/11] tpm_tis_sysbus: move DSDT AML generation to device

On Fri, 14 Jul 2023 10:29:31 -0700 Joelle van Dyne wrote: > On Fri, Jul 14, 2023 at 9:19 AM Stefan Berger wrote: > > > > > > > > > > I don't know whether we would want multiple devices. tpm_find() usage is > > certainly not prepared for multiple devices. > Sorry, "multiple TPM interfaces" her

Re: [PATCH v4 3/4] vhost-user: add shared_object msg

On Mon, Jul 17, 2023 at 01:42:02PM +0200, Albert Esteve wrote: > Hi Michael, > > True. It may be a good idea to impose a limit in the number of entries that > can be added to the table. > And fail to add new entries once it reaches the limit. > > Not sure what would be a good limit though. For ex

Re: [PATCH v4 3/4] vhost-user: add shared_object msg

On Mon, Jul 17, 2023 at 01:42:02PM +0200, Albert Esteve wrote: > Hi Michael, > > True. It may be a good idea to impose a limit in the number of entries that > can > be added to the table. > And fail to add new entries once it reaches the limit. > > Not sure what would be a good limit though

Re: [PATCH for-8.1] hw/arm/smmu: Handle big-endian hosts correctly

On 17/07/2023 15.26, Peter Maydell wrote: The implementation of the SMMUv3 has multiple places where it reads a data structure from the guest and directly operates on it without doing a guest-to-host endianness conversion. Since all SMMU data structures are little-endian, this means that the SMM

Re: [PATCH v2 10/11] tpm_crb_sysbus: introduce TPM CRB SysBus device

On Fri, 14 Jul 2023 00:09:26 -0700 Joelle van Dyne wrote: > This SysBus variant of the CRB interface supports dynamically locating > the MMIO interface so that Virt machines can use it. This interface > is currently the only one supported by QEMU that works on Windows 11 > ARM64. We largely follo

Re: [PATCH v2 11/11] tpm_crb: support restoring older vmstate

On Fri, 14 Jul 2023 11:49:03 -0700 Joelle van Dyne wrote: > On Fri, Jul 14, 2023 at 11:41 AM Stefan Berger wrote: > > > > > > > > On 7/14/23 14:22, Stefan Berger wrote: > > > On 7/14/23 13:04, Joelle van Dyne wrote: > > >> On Fri, Jul 14, 2023 at 7:51 AM Stefan Berger > > >> wrote: > > >

[PULL for-8.1 1/1] block/nvme: invoke blk_io_plug_call() outside q->lock

blk_io_plug_call() is invoked outside a blk_io_plug()/blk_io_unplug() section while opening the NVMe drive from: nvme_file_open() -> nvme_init() -> nvme_identify() -> nvme_admin_cmd_sync() -> nvme_submit_command() -> blk_io_plug_call() blk_io_plug_call() immediately invokes the given

[PULL for-8.1 0/1] Block patches

The following changes since commit ed8ad9728a9c0eec34db9dff61dfa2f1dd625637: Merge tag 'pull-tpm-2023-07-14-1' of https://github.com/stefanberger/qemu-tpm into staging (2023-07-15 14:54:04 +0100) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-re

Re: [PATCH v2 11/11] tpm_crb: support restoring older vmstate

On Fri, 14 Jul 2023 at 20:13, Stefan Berger wrote: > Unfortunately the CRB device is being used by x86 on some distros > and the expectation is that this existing device can also downgrade > to a previous version of QEMU I would say. I have read people migrating > from RHEL 9.x even to RHEL 8.x an

Re: [PULL 20/47] linux-user: Make sure initial brk(0) is page-aligned

On 7/16/23 19:15, Michael Tokarev wrote: 15.07.2023 16:52, Richard Henderson wrote: From: Andreas Schwab Fixes: 86f04735ac ("linux-user: Fix brk() to release pages") Signed-off-by: Andreas Schwab Message-Id: Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson This smells like

Re: [PULL 45/47] linux-user/arm: Do not allocate a commpage at all for M-profile CPUs

On 7/16/23 19:13, Michael Tokarev wrote: 15.07.2023 16:53, Richard Henderson wrote: From: Philippe Mathieu-Daudé Since commit fbd3c4cff6 ("linux-user/arm: Mark the commpage executable") executing bare-metal (linked with rdimon.specs) cortex-M code fails as:    $ qemu-arm -cpu cortex-m3 ~/hell

[PATCH 4/5] qemu-nbd: properly report error if qemu_daemon() is failed

errno has been overwritten by dup2() just below qemu_daemon() and thus improperly returned to the caller. Fix accordingly. Signed-off-by: Denis V. Lunev CC: Eric Blake CC: Vladimir Sementsov-Ogievskiy --- qemu-nbd.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qemu-n

  1   2   3   >