RE: [PATCH v3 1/3] vfio/pci: Fix resource leak in vfio_realize

>-Original Message- >From: Duan, Zhenzhong >Sent: Sunday, June 25, 2023 2:01 PM >To: Joao Martins >Cc: alex.william...@redhat.com; c...@redhat.com; qemu-devel@nongnu.org; >avih...@nvidia.com; Peng, Chao P >Subject: RE: [PATCH v3 1/3] vfio/pci: Fix resource leak in vfio_realize > >>-Or

Re: [SPAM] [PATCH v4] 9pfs: deprecate 'proxy' backend

On Fri, 23 Jun 2023 14:41:15 +0200 Christian Schoenebeck wrote: > As recent CVE-2023-2861 once again showed, the 9p 'proxy' fs driver is in > bad shape. Using the 'proxy' backend was already discouraged for safety > reasons before and we recommended to use the 'local' backend (preferably > in con

[PATCH v4 1/4] uuid: add a hash function

Add hash function to uuid module using the djb2 hash algorithm. Add a couple simple unit tests for the hash function, checking collisions for similar UUIDs. Signed-off-by: Albert Esteve --- include/qemu/uuid.h| 2 ++ tests/unit/test-uuid.c | 27 +++ util/uuid.c

[PATCH v4 3/4] vhost-user: add shared_object msg

Add three new vhost-user protocol `VHOST_USER_BACKEND_SHARED_OBJECT_* messages`. These new messages are sent from vhost-user back-ends to interact with the virtio-dmabuf table in order to add, remove, or lookup for virtio dma-buf shared objects. The action taken in the front-end depends on the typ

[PATCH v4 2/4] virtio-dmabuf: introduce virtio-dmabuf

This API manages objects (in this iteration, dmabuf fds) that can be shared along different virtio devices. The API allows the different devices to add, remove and/or retrieve the objects by simply invoking the public functions that reside in the virtio-dmabuf file. Suggested-by: Gerd Hoffmann S

[PATCH v4 4/4] vhost-user: refactor send_resp code

Refactor code to send response message so that all common parts both for the common REPLY_ACK case, and other data responses, can call it and avoid code repetition. Signed-off-by: Albert Esteve --- hw/virtio/vhost-user.c | 44 -- 1 file changed, 17 inserti

[PATCH v4 0/4] Virtio shared dma-buf

v1 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00598.html v2 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04530.html v3 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg06126.html v3 -> v4: - Split the different message types for shared o

Re: [PATCH v1] virtio-mem: Simplify bitmap handling and virtio_mem_set_block_state()

On 25.06.23 23:06, Michael S. Tsirkin wrote: On Fri, Jun 23, 2023 at 02:51:11PM +0200, David Hildenbrand wrote: On 23.05.23 20:30, David Hildenbrand wrote: Let's separate plug and unplug handling to prepare for future changes and make the code a bit easier to read -- working on block states (pl

Re: [PATCH v2 5/5] hw/pci: ensure PCIE devices are plugged into only slot 0 of PCIE port

> On 26-Jun-2023, at 2:41 AM, Michael S. Tsirkin wrote: > > On Fri, Jun 23, 2023 at 04:57:20PM +0200, Julia Suvorova wrote: >> On Thu, Jun 22, 2023 at 7:48 PM Michael S. Tsirkin wrote: >>> >>> On Thu, Jun 22, 2023 at 05:46:40PM +0200, Julia Suvorova wrote: On Thu, Jun 22, 2023 at 12:34 

Re: [PATCH 1/7] target/ppc: Fix CPU reservation migration for record-replay

Acked-by: Pavel Dovgalyuk On 23.06.2023 15:57, Nicholas Piggin wrote: ppc only migrates reserve_addr, so the destination machine can get a valid reservation with an incorrect reservation value of 0. Prior to commit 392d328abe753 ("target/ppc: Ensure stcx size matches larx"), this could permit a

Re: [PATCH 7/7] tests/avocado: ppc64 pseries reverse debugging test

On 23.06.2023 15:57, Nicholas Piggin wrote: pseries can run reverse-debugging well enough to pass basic tests. There is strangeness with reverse-continue possibly relating to a bp being set on the first instruction or on a snapshot, that causes the PC to be reported on the first instruction rath

Re: [PATCH v3 04/11] target/i386: do not accept RDSEED if CPUID bit absent

On 6/23/23 15:17, Paolo Bonzini wrote: Suggested-by: Richard Henderson Signed-off-by: Paolo Bonzini --- target/i386/tcg/translate.c | 8 1 file changed, 8 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH 5/7] target/ppc: Fix timebase reset with record-replay

Reviewed-by: Pavel Dovgalyuk On 23.06.2023 15:57, Nicholas Piggin wrote: Timebase save uses a random number for a legacy vmstate field, which makes rr snapshot loading unbalanced. The easiest way to deal with this is just to skip the rng if record-replay is active. Signed-off-by: Nicholas Pigg

[PATCH 1/1] hw/arm/sbsa-ref: add PCIe node into DT

Add PCI Express information into DeviceTree as part of SBSA-REF versioning. Trusted Firmware will read it and provide to next firmware level. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 20 1 file changed, 20 insertions(+) diff --git a/hw/arm/sbsa-ref.c b/hw/

Re: [PATCH v3 08/11] target/i386: AMD only supports SYSENTER/SYSEXIT in 32-bit mode

On 6/23/23 15:17, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- target/i386/tcg/translate.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) I guess we have no other vendors except Intel and AMD... Acked-by: Richard Henderson r~ diff --git a/target/i386/tcg/tr

Re: [PATCH v3 11/11] target/i386: implement SYSCALL/SYSRET in 32-bit emulators

On 6/23/23 15:17, Paolo Bonzini wrote: AMD supports both 32-bit and 64-bit SYSCALL/SYSRET, but the TCG only exposes it for 64-bit targets. For system emulation just reuse the helper; for user-mode emulation the ABI is the same as "int $80". The BSDs does not support any fast system call mechani

Re: [PATCH 01/26] gitlab: explicit set artifacts publishing criteria

On 6/23/23 14:20, Alex Bennée wrote: From: Daniel P. Berrangé If not set explicitly, gitlab assumes 'when: on_success" as the publishing criteria for artifacts. This is reasonable if the artifact is an output deliverable of the job. This is useless if the artifact is a log file to be used for d

Re: [PATCH 02/26] gitlab: ensure coverage job also publishes meson log

On 6/23/23 14:20, Alex Bennée wrote: From: Daniel P. Berrangé The coverage job wants to publish a coverage report on success, but the tests might fail and in that case we need the meson logs for debugging. Signed-off-by: Daniel P. Berrangé Message-Id: <20230503145535.91325-3-berra...@redhat.c

Re: [PATCH 03/26] gitlab: reduce testing scope of check-gcov

On 6/23/23 14:20, Alex Bennée wrote: This keeps timing out on gitlab due to some qtests taking a long time. As this is just ensuring the gcov machinery is working and not attempting to be comprehensive lets skip qtest in this run. Signed-off-by: Alex Bennée --- .gitlab-ci.d/buildtest.yml | 2

Re: [PATCH 08/26] scripts/oss-fuzz: add a suppression for keymap

On 6/23/23 14:20, Alex Bennée wrote: When updating to the latest fedora the santizer found more leaks inside xkbmap: FAILED: pc-bios/keymaps/ar /builds/stsquad/qemu/build-oss-fuzz/qemu-keymap -f pc-bios/keymaps/ar -l ara =

Re: [PATCH v4 10/17] target/riscv: Add Zvkned ISA extension support

On 2023/6/23 3:33 PM, Richard Henderson wrote: On 6/22/23 18:16, Max Chou wrote: --- a/target/riscv/vcrypto_helper.c +++ b/target/riscv/vcrypto_helper.c @@ -22,6 +22,7 @@   #include "qemu/bitops.h"   #include "qemu/bswap.h"   #include "cpu.h" +#include "crypto/aes.h"   #include "exec/memop.h"  

Re: [PATCH v2 8/8] disas/riscv: Add support for XThead* instructions

On Thu, Jun 15, 2023 at 8:53 AM Weiwei Li wrote: > > > On 2023/6/12 19:10, Christoph Muellner wrote: > > From: Christoph Müllner > > > > Support for emulating XThead* instruction has been added recently. > > This patch adds support for these instructions to the RISC-V disassembler. > > > > Co-dev

Re: [PATCH 09/26] tests/qtests: clean-up and fix leak in generic_fuzz

On 6/23/23 14:20, Alex Bennée wrote: An update to the clang tooling detects more issues with the code including a memory leak from the g_string_new() allocation. Clean up the code with g_autoptr and use ARRAY_SIZE while we are at it. Signed-off-by: Alex Bennée --- tests/qtest/fuzz/generic_fuz

Re: [PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events

e500 has the same problem, I think, according to this issue: https://gitlab.com/qemu-project/qemu/-/issues/1634 Btw, ARM virt platform rebuilds fdt only at initialization phase, not when reset. Isn't this behavior correct? Shouldn't PPC platforms do the similar thing? On 23.06.2023 15:57, Nic

Re: [PATCH 12/26] tests/lcitool: update to latest version

On 6/23/23 14:20, Alex Bennée wrote: We need this for the riscv64 and gcc-native mappings. As the older alpine release has been dropped from the mappings we also need to bump the version of alpine we use. Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/alpine.docker | 4 ++-- tests/l

Re: [PATCH v4 17/17] target/riscv: Expose Zvk* and Zvb[b,c] cpu properties

On 2023/6/23 1:41 AM, Daniel Henrique Barboza wrote: On 6/22/23 13:16, Max Chou wrote: From: Nazar Kazakov Exposes earlier CPU flags allowing the use of the vector cryptography extensions. Signed-off-by: Nazar Kazakov Signed-off-by: Max Chou ---   target/riscv/cpu.c | 10 ++   1

Re: [PATCH 13/26] tests/lcitool: Bump fedora container versions

On 6/23/23 14:20, Alex Bennée wrote: From: Erik Skultety Fedora 37 -> 38 Signed-off-by: Erik Skultety Message-Id: [AJB: Dropped alpine (in prev commit), reflow commit msg] Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/fedora-win32-cross.docker | 4 ++-- tests/docker/dockerfile

Re: [PATCH 14/26] tests/lcitool: add an explicit gcc-native package

On 6/23/23 14:20, Alex Bennée wrote: We need a native compiler to build the hexagon codegen tools. In our current images we already have a gcc as a side effect of a broken dependency between gcovr and lcov but this will be fixed when we move to bookworm. See https://bugs.debian.org/cgi-bin/bugrep

Re: [PATCH 15/26] tests/lcitool: introduce qemu-minimal

On 6/23/23 14:20, Alex Bennée wrote: This is a very bare bones set of dependencies for a minimal build of QEMU. This will be useful for bootstrapping cross compile images based on things like Debian Sid where stuff isn't always in sync. Signed-off-by: Alex Bennée --- tests/lcitool/projects/qe

[PULL 2/9] gitlab: centralize the container tag name

From: Daniel P. Berrangé We use a fixed container tag of 'latest' so that contributors' forks don't end up with an ever growing number of containers as they work on throwaway feature branches. This fixed tag causes problems running CI upstream in stable staging branches, however, because the sta

[PULL 6/9] gitlab: support disabling job auto-run in upstream

From: Daniel P. Berrangé In forks QEMU_CI=1 can be used to create a pipeline but not auto-run any jobs. In upstream jobs always auto-run, which is equiv of QEMU_CI=2. This supports setting QEMU_CI=1 in upstream, to disable job auto-run. This can be used to preserve CI minutes if repushing a bran

[PULL 1/9] tests/qtest: Fix a comment typo in vhost-user-test.c

From: Milan Zamazal Signed-off-by: Milan Zamazal Reviewed-by: Thomas Huth Message-Id: <20230621101710.297975-4-mzama...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/vhost-user-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/vhost-user-test.c b/

[PULL 4/9] gitlab: stable staging branches publish containers in a separate tag

From: Daniel P. Berrangé If the stable staging branches publish containers under the 'latest' tag they will clash with containers published on the primary staging branch, as well as with each other. This introduces logic that overrides the container tag when jobs run against the stable staging b

[PULL 3/9] gitlab: allow overriding name of the upstream repository

From: Daniel P. Berrangé The CI rules have special logic for what happens in upstream. To enable contributors who modify CI rules to test this logic, however, they need to be able to override which repo is considered upstream. This introduces the 'QEMU_CI_UPSTREAM' variable git push gitlab -o

[PULL 5/9] gitlab: avoid extra pipelines for tags and stable branches

From: Daniel P. Berrangé In upstream context we only run pipelines on staging branches, and limited publishing jobs on the default branch. We don't want to run pipelines on stable branches, or tags, because the content will have already been tested on a staging branch before getting pushed. Rev

[PULL 8/9] gitlab-ci: add msys2 meson test to junit report

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20230620153720.514882-3-marcandre.lur...@redhat.com> Signed-off-by: Thomas Huth --- .gitlab-ci.d/windows.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/windows.yml index d45

Re: [PATCH 16/26] tests/docker: convert riscv64-cross to lcitool

On 6/23/23 14:20, Alex Bennée wrote: --- a/tests/lcitool/projects/qemu-minimal.yml +++ b/tests/lcitool/projects/qemu-minimal.yml @@ -4,6 +4,8 @@ packages: - bash - bc - bison + - ccache + - findutils - flex - g++ - gcc @@ -21,3 +23,5 @@ packages: - pkg-config - python3

[PULL 7/9] gitlab-ci: grab msys2 meson-logs as artifacts

From: Marc-André Lureau Rename build directory to "build", like most other CI builds. Signed-off-by: Marc-André Lureau Message-Id: <20230620153720.514882-2-marcandre.lur...@redhat.com> Signed-off-by: Thomas Huth --- .gitlab-ci.d/windows.yml | 13 + 1 file changed, 9 insertions(+),

[PULL 9/9] tests/qtest/cxl-test: Clean up temporary directories after testing

It's good style to clean up temporary directories when they are not needed anymore. Message-Id: <20230622114132.372898-1-th...@redhat.com> Acked-by: Jonathan Cameron Signed-off-by: Thomas Huth --- tests/qtest/cxl-test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qtest/cxl-test.

[PULL 0/9] Testing / CI patches

The following changes since commit 79dbd910c9ea6ca38f8e1b2616b1e5e885b85bd3: Merge tag 'hppa-boot-reboot-fixes-pull-request' of https://github.com/hdeller/qemu-hppa into staging (2023-06-25 08:58:49 +0200) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-r

[PATCH 2/3] vfio/migration: Reset bytes_transferred properly

Currently, VFIO bytes_transferred is not reset properly: 1. bytes_transferred is not reset after a VM snapshot (so a migration following a snapshot will report incorrect value). 2. bytes_transferred is a single counter for all VFIO devices, however upon migration failure it is reset multiple

[PATCH 3/3] vfio/migration: Make VFIO migration non-experimental

The major parts of VFIO migration are supported today in QEMU. This includes basic VFIO migration, device dirty page tracking and precopy support. Thus, at this point in time, it seems appropriate to make VFIO migration non-experimental: remove the x prefix from enable_migration property, change i

Re: [PATCH 19/26] plugins: fix memory leak while parsing options

On 6/23/23 14:20, Alex Bennée wrote: It was hard to track down this leak as it was an internal allocation by glib and the backtraces did not give much away. The autofree was freeing the allocation with g_free() but not taking care of the individual strings. They should have been freed with g_strf

Re: [PATCH 20/26] plugins: update lockstep to use g_memdup2

On 6/23/23 14:20, Alex Bennée wrote: The old g_memdup is deprecated, use the replacement. Signed-off-by: Alex Bennée --- contrib/plugins/lockstep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [PATCH] vdpa: Increase out buffer size for CVQ commands

On 2023/6/25 18:48, Eugenio Perez Martin wrote: > On Thu, Jun 22, 2023 at 3:07 AM Hawkins Jiawei wrote: >> >> According to the VirtIO standard, "Since there are no guarantees, >> it can use a hash filter or silently switch to >> allmulti or promiscuous mode if it is given too many addresses." >> T

Re: [PATCH] linux-user: Remove pointless NULL check in clock_adjtime handling

On 6/23/23 16:44, Peter Maydell wrote: In the code for TARGET_NR_clock_adjtime, we set the pointer phtx to the address of the local variable htx. This means it can never be NULL, but later in the code we check it for NULL anyway. Coverity complains about this (CID 1507683) because the NULL chec

Re: RFC: bsd-user broken a while ago, is this the right fix?

Just CC'ing Richard to make sure it catches his attention. On Sat, Jun 24, 2023 at 12:40:33AM -0600, Warner Losh wrote: > This change: > > commit f00506aeca2f6d92318967693f8da8c713c163f3 > Merge: d37158bb242 87e303de70f > Author: Peter Maydell > Date: Wed Mar 29 11:19:19 2023 +0100 > > Me

[PATCH 1/3] vfio/migration: Move from STOP_COPY to STOP in vfio_save_cleanup()

Changing the device state from STOP_COPY to STOP can take time as the device may need to free resources and do other operations as part of the transition. Currently, this is done in vfio_save_complete_precopy() and therefore it is counted in the migration downtime. To avoid this, change the device

[PATCH 0/3] vfio/migration: Make VFIO migration non-experimental

Hello, The major parts of VFIO migration are supported today in QEMU. This includes basic VFIO migration, device dirty page tracking and precopy support. Thus, at this point in time, it seems appropriate to make VFIO migration non-experimental. This short series (which is based on the precopy ser

Re: [PATCH 2/2] accel: Re-enable WHPX cross-build on case sensitive filesystems

On Sat, Jun 24, 2023 at 04:22:11PM +0200, Philippe Mathieu-Daudé wrote: > Since MinGW commit 395dcfdea ("rename hyper-v headers and def > files to lower case") [*], WinHvPlatform.h and WinHvEmulation.h > got respectively renamed as winhvplatform.h / winhvemulation.h. > > The mingw64-headers packag

Re: [PATCH 1/2] docs/devel/testing: Update the 'Docker Debugging' section

On Sat, Jun 24, 2023 at 04:22:10PM +0200, Philippe Mathieu-Daudé wrote: > Since commit 93cc0506f6 ("tests/docker: Use Fedora containers > for MinGW cross-builds in the gitlab-CI") the MinGW toolchain > is packaged inside the fedora-win[32/64]-cross images. > > Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH] target/nios2 : Explicitly ask for target-endian loads and stores

On 6/23/23 19:25, Peter Maydell wrote: When we generate code for guest loads and stores, at the moment they end up being requests for a host-endian access. So for target-system-nios2 (little endian) a load like ldwr3,0(r4) results on an x86 host in the TCG IR qemu_ld_a32_i32 r3,lo

[PATCH v2 1/3] target/i386: ignore ARCH_CAPABILITIES features in user mode emulation

ARCH_CAPABILITIES is only accessible through a read-only MSR, so it has no impact on any user-mode operation (user-mode cannot read the MSR). So do not bother printing warnings about it in user mode emulation. Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 7 +++ 1 file changed, 7 inse

Re: [RFC PATCH-for-8.1] accel: Remove HAX accelerator

On 6/24/23 01:08, Philippe Mathieu-Daudé wrote: HAX is deprecated since commits 73741fda6c ("MAINTAINERS: Abort HAXM maintenance") and 90c167a1da ("docs/about/deprecated: Mark HAXM in QEMU as deprecated"), released in v8.0.0. Per the QEMU deprecation policy, we shouldn't remove it before QEMU re

[PATCH v2 0/3] target/i386: allow using named CPU modeles with user mode emulation

When running qemu-i386 even with -cpu Nehalem (aka x86_64-v2), it raises the warning TCG doesn't support requested feature: CPUID.8001H:EDX.lm [bit 29] Likewise using qemu-x86_64 with -cpu Haswell, it raises warnings for TCG doesn't support requested feature: CPUID.01H:ECX.pcid [bit 17]

[PATCH v2 3/3] target/i386: emulate 64-bit ring 0 for linux-user if LM feature is set

32-bit binaries can run on a long mode processor even if the kernel is 64-bit, of course, and this can have slightly different behavior; for example, SYSCALL is allowed on Intel processors. Allow reporting LM to programs running under user mode emulation, so that "-cpu" can be used with named CPU

[PATCH v2 2/3] target/i386: ignore CPL0-specific features in user mode emulation

Features such as PCID are only accessible through privileged operations, and therefore have no impact on any user-mode operation. Allow reporting them to programs running under user mode emulation, so that "-cpu" can be used with more named CPU models. XSAVES would be similar, but it doesn't make

Re: [PULL 00/30] ppc queue

ository at: https://github.com/legoater/qemu/ tags/pull-ppc-20230626 for you to fetch changes up to 5eb63b88d0ac259c2f49e62b6dcc6527a5caf255: tests/avocado: ppc test VOF bios Linux boot (2023-06-25 22:41:31 +0200) ppc que

Re: [PATCH RFC 1/3] vdpa: Restore MAC address filtering state

On 2023/6/25 18:37, Eugenio Perez Martin wrote: > On Thu, Jun 22, 2023 at 5:02 AM Hawkins Jiawei wrote: >> >> This patch refactors vhost_vdpa_net_load_mac() to >> restore the MAC address filtering state at device's startup. >> >> Signed-off-by: Hawkins Jiawei >> --- >> net/vhost-vdpa.c | 39 +++

Re: [PATCH RFC 2/3] vdpa: Restore packet receive filtering state relative with _F_CTRL_RX feature

On 2023/6/25 18:56, Eugenio Perez Martin wrote: > On Thu, Jun 22, 2023 at 5:02 AM Hawkins Jiawei wrote: >> >> This patch introduces vhost_vdpa_net_load_rx_mode() >> and vhost_vdpa_net_load_rx() to restore the packet >> receive filtering state in relation to >> VIRTIO_NET_F_CTRL_RX feature at devic

Re: [PATCH RFC 1/2] vdpa: Restore packet receive filtering state relative with _F_CTRL_RX_EXTRA feature

On 2023/6/25 18:54, Eugenio Perez Martin wrote: > On Fri, Jun 23, 2023 at 3:26 PM Hawkins Jiawei wrote: >> >> This patch refactors vhost_vdpa_net_load_rx() to >> restore the packet receive filtering state in relation to >> VIRTIO_NET_F_CTRL_RX_EXTRA feature at device's startup. >> >> Signed-off-by

Re: [PATCH] vdpa: Increase out buffer size for CVQ commands

On Mon, Jun 26, 2023 at 10:26 AM Hawkins Jiawei wrote: > > On 2023/6/25 18:48, Eugenio Perez Martin wrote: > > On Thu, Jun 22, 2023 at 3:07 AM Hawkins Jiawei wrote: > >> > >> According to the VirtIO standard, "Since there are no guarantees, > >> it can use a hash filter or silently switch to > >>

[PATCH v5 1/2] vhost: register and change IOMMU flag depending on Device-TLB state

The guest can disable or never enable Device-TLB. In these cases, it can't be used even if enabled in QEMU. So, check Device-TLB state before registering IOMMU notifier and select unmap flag depending on that. Also, implement a way to change IOMMU notifier flag if Device-TLB state is changed. Bugl

[PATCH v5 2/2] virtio-net: pass Device-TLB enable/disable events to vhost

If vhost is enabled for virtio-net, Device-TLB enable/disable events must be passed to vhost for proper IOMMU unmap flag selection. Signed-off-by: Viktor Prutyanov Acked-by: Jason Wang --- hw/net/virtio-net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/virtio-net.c b/hw/net/virti

[PATCH v5 0/2] vhost: register and change IOMMU flag depending on ATS state

When IOMMU and vhost are enabled together, QEMU tracks IOTLB or Device-TLB unmap events depending on whether Device-TLB is enabled. But even if Device-TLB and PCI ATS is enabled, the guest can reject to use it. For example, this situation appears when Windows Server 2022 is running with intel-iommu

Re: [PATCH v2 0/3] target/i386: allow using named CPU modeles with user mode emulation

On Mon, Jun 26, 2023 at 10:33:14AM +0200, Paolo Bonzini wrote: > When running qemu-i386 even with -cpu Nehalem (aka x86_64-v2), it raises the > warning > > TCG doesn't support requested feature: CPUID.8001H:EDX.lm [bit 29] > > Likewise using qemu-x86_64 with -cpu Haswell, it raises warnings

Re: [PATCH v2 0/3] target/i386: allow using named CPU modeles with user mode emulation

On Mon, Jun 26, 2023 at 11:20 AM Daniel P. Berrangé wrote: > > - for qemu-i386, the issue is that this emulator is restricted to running > > programs on a 32-bit processor, even though it is actually emulating > > programs that use the 32-bit kernel ABI on any processor. The behavior > > th

Re: [PATCH 7/7] tests/avocado: ppc64 pseries reverse debugging test

On Mon Jun 26, 2023 at 5:49 PM AEST, Pavel Dovgalyuk wrote: > On 23.06.2023 15:57, Nicholas Piggin wrote: > > pseries can run reverse-debugging well enough to pass basic tests. > > > > There is strangeness with reverse-continue possibly relating to a bp > > being set on the first instruction or on

Re: [PATCH v3 3/3] vfio/migration: vfio/migration: Refactor and fix print of "Migration disabled"

On 21/06/2023 11:02, Zhenzhong Duan wrote: External email: Use caution opening links or attachments This patch refactors vfio_migration_realize() and its dependend code as follows: 1. It's redundant in vfio_migration_realize() to registers multiple blockers, e.g: vIOMMU blocker can be re

Re: [PATCH v2 0/3] target/i386: allow using named CPU modeles with user mode emulation

On Mon, Jun 26, 2023 at 11:27:54AM +0200, Paolo Bonzini wrote: > On Mon, Jun 26, 2023 at 11:20 AM Daniel P. Berrangé > wrote: > > > - for qemu-i386, the issue is that this emulator is restricted to running > > > programs on a 32-bit processor, even though it is actually emulating > > > progra

Re: [PATCH v2 0/3] target/i386: allow using named CPU modeles with user mode emulation

On Mon, Jun 26, 2023 at 11:36 AM Daniel P. Berrangé wrote: > > > If someone wants Nehalem then they should be using qemu-x86_64. > > > If someone wants qemu-i386 then they should be using an older > > > named CPU model predating 'lm'. > > > > What you write is true for qemu-system-*, but the probl

[PATCH] pnv/xive2: Allow indirect TIMA accesses of all sizes

Booting linux on the powernv10 machine logs a few errors like: Invalid read at addr 0x38, size 1, region 'xive-ic-tm-indirect', reason: invalid size (min:8 max:8) Invalid write at addr 0x38, size 1, region 'xive-ic-tm-indirect', reason: invalid size (min:8 max:8) Invalid read at addr 0x38, size

Re: [PATCH v8] Emulate dip switch language layout settings on SUN keyboard

On Fri, Jun 23, 2023 at 08:30:07PM +0200, Henrik Carlqvist wrote: > SUN Type 4, 5 and 5c keyboards have dip switches to choose the language > layout > of the keyboard. Solaris makes an ioctl to query the value of the dipswitches > and uses that value to select keyboard layout. Also the SUN bios

Re: [PATCH] pnv/xive2: Allow indirect TIMA accesses of all sizes

On 26/6/23 11:40, Frederic Barrat wrote: Booting linux on the powernv10 machine logs a few errors like: Invalid read at addr 0x38, size 1, region 'xive-ic-tm-indirect', reason: invalid size (min:8 max:8) Invalid write at addr 0x38, size 1, region 'xive-ic-tm-indirect', reason: invalid size (mi

Re: Tips for local testing guestfwd

CC'ing SLIRP and net maintainer. On Sun, 25 Jun 2023 22:58:36 -0700 Felix Wu wrote: > Hi all, > > TL,DR: I am working on QEMU ipv6 guestfwd feature and finished coding, and > would like to learn the best practice to test it. > Context: in slirp side this task is tracking by [1]. > Currently, I

Re: RFC: bsd-user broken a while ago, is this the right fix?

On 6/26/23 10:28, Daniel P. Berrangé wrote: Just CC'ing Richard to make sure it catches his attention. On Sat, Jun 24, 2023 at 12:40:33AM -0600, Warner Losh wrote: This change: commit f00506aeca2f6d92318967693f8da8c713c163f3 Merge: d37158bb242 87e303de70f Author: Peter Maydell Date: Wed Mar

Re: [PATCH 2/3] vfio/migration: Reset bytes_transferred properly

Hello Avihai, On 6/26/23 10:23, Avihai Horon wrote: Currently, VFIO bytes_transferred is not reset properly: 1. bytes_transferred is not reset after a VM snapshot (so a migration following a snapshot will report incorrect value). 2. bytes_transferred is a single counter for all VFIO devices,

Re: [PULL 19/21] target/hexagon: import parser for idef-parser

On 6/23/23 14:50, Peter Maydell wrote: On Fri, 16 Dec 2022 at 20:51, Taylor Simpson wrote: +lvalue : FAIL + { + @1.last_column = @1.last_column; ...we have coded an "x = x" assignment that has no effect. Was this supposed to be something else, or should it just be deleted

Re: [PATCH 1/3] vfio/migration: Move from STOP_COPY to STOP in vfio_save_cleanup()

On 6/26/23 10:23, Avihai Horon wrote: Changing the device state from STOP_COPY to STOP can take time as the device may need to free resources and do other operations as part of the transition. Currently, this is done in vfio_save_complete_precopy() and therefore it is counted in the migration dow

Re: [PATCH v3 2/3] vfio/pci: Fix a segfault in vfio_realize

On 25/06/2023 07:01, Duan, Zhenzhong wrote: >> -Original Message- >> From: Joao Martins >> Sent: Wednesday, June 21, 2023 7:09 PM >> To: Duan, Zhenzhong >> Cc: alex.william...@redhat.com; c...@redhat.com; qemu-devel@nongnu.org; >> avih...@nvidia.com; Peng, Chao P >> Subject: Re: [PATCH v

Re: [PATCH 4/7] spapr: Fix record-replay machine reset consuming too many events

On Mon Jun 26, 2023 at 6:07 PM AEST, Pavel Dovgalyuk wrote: > e500 has the same problem, I think, according to this issue: > https://gitlab.com/qemu-project/qemu/-/issues/1634 Same symptoms. e500 looks like it does the dt build in machine_init_done notifier, though. Maybe I miss something. I'll t

Re: [PATCH v2 2/3] target/i386: ignore CPL0-specific features in user mode emulation

On 6/26/23 10:33, Paolo Bonzini wrote: Features such as PCID are only accessible through privileged operations, and therefore have no impact on any user-mode operation. Allow reporting them to programs running under user mode emulation, so that "-cpu" can be used with more named CPU models. XSA

Re: [PATCH v2 1/3] target/i386: ignore ARCH_CAPABILITIES features in user mode emulation

On 6/26/23 10:33, Paolo Bonzini wrote: ARCH_CAPABILITIES is only accessible through a read-only MSR, so it has no impact on any user-mode operation (user-mode cannot read the MSR). So do not bother printing warnings about it in user mode emulation. Signed-off-by: Paolo Bonzini --- target/i386/

Re: [PATCH v2 0/3] target/i386: allow using named CPU modeles with user mode emulation

On 6/26/23 11:37, Paolo Bonzini wrote: On Mon, Jun 26, 2023 at 11:36 AM Daniel P. Berrangé wrote: If someone wants Nehalem then they should be using qemu-x86_64. If someone wants qemu-i386 then they should be using an older named CPU model predating 'lm'. What you write is true for qemu-syste

Re: [PATCH v3 1/3] vfio/pci: Fix resource leak in vfio_realize

On 26/06/2023 08:02, Duan, Zhenzhong wrote: >> -Original Message- >> From: Duan, Zhenzhong >> Sent: Sunday, June 25, 2023 2:01 PM >> To: Joao Martins >> Cc: alex.william...@redhat.com; c...@redhat.com; qemu-devel@nongnu.org; >> avih...@nvidia.com; Peng, Chao P >> Subject: RE: [PATCH v3 1/

Re: Tips for local testing guestfwd

Hello, Felix Wu wrote: > 2. I want to understand what ip I should use. Currently I have following > formats for the QEMU invocation in ipv6: > ``` > guestfwd=tcp:[::1]:1234-tcp:[my:host:ip:from:ifconfig]:22 > ``` > I know the general form is `guestfwd=tcp:server:port-dev`, where > server:port is

Re: [PATCH v3 07/16] accel: Rename HAX 'struct hax_vcpu_state' -> AccelCPUState

On 6/24/23 19:41, Philippe Mathieu-Daudé wrote: We want all accelerators to share the same opaque pointer in CPUState. Start with the HAX context, renaming its forward declarated structure 'hax_vcpu_state' as 'AccelCPUState'. Document the CPUState field. Directly use the typedef. Remove the amus

Re: [PATCH 1/2] target/ppc: Fix icount access for some hypervisor instructions

On 6/25/23 12:36, Nicholas Piggin wrote: Several instructions and register access require icount reads and are missing translator_io_start(). Signed-off-by: Nicholas Piggin --- target/ppc/translate.c | 7 +++ 1 file changed, 7 insertions(+) Acked-by: Richard Henderson r~

Re: [PATCH v3 3/3] vfio/migration: vfio/migration: Refactor and fix print of "Migration disabled"

On 26/06/2023 10:34, Avihai Horon wrote: > > On 21/06/2023 11:02, Zhenzhong Duan wrote: >> External email: Use caution opening links or attachments >> >> >> This patch refactors vfio_migration_realize() and its dependend code >> as follows: >> >> 1. It's redundant in vfio_migration_realize() to

Re: [PATCH] pnv/xive2: Allow indirect TIMA accesses of all sizes

On 6/26/23 11:40, Frederic Barrat wrote: Booting linux on the powernv10 machine logs a few errors like: Invalid read at addr 0x38, size 1, region 'xive-ic-tm-indirect', reason: invalid size (min:8 max:8) Invalid write at addr 0x38, size 1, region 'xive-ic-tm-indirect', reason: invalid size (mi

Re: [PULL 0/9] Testing / CI patches

On 6/26/23 10:14, Thomas Huth wrote: The following changes since commit 79dbd910c9ea6ca38f8e1b2616b1e5e885b85bd3: Merge tag 'hppa-boot-reboot-fixes-pull-request' ofhttps://github.com/hdeller/qemu-hppa into staging (2023-06-25 08:58:49 +0200) are available in the Git repository at: http

Re: [PATCH v3 0/5] tcg: Issue memory barriers for guest memory model

On 6/19/23 16:23, Richard Henderson wrote: v1: https://lore.kernel.org/qemu-devel/20210316220735.2048137-1-richard.hender...@linaro.org/ v2: https://lore.kernel.org/qemu-devel/20230306015710.1868853-1-richard.hender...@linaro.org/ Changes for v3: * Update for tcg-built-once. * Require TC

Re: [PATCH v2] target/riscv: Restrict KVM-specific fields from ArchCPU

On 24/6/23 21:29, Philippe Mathieu-Daudé wrote: These fields shouldn't be accessed when KVM is not available. Restrict the KVM timer migration state. Rename the KVM timer post_load() handler accordingly, because cpu_post_load() is too generic. Signed-off-by: Philippe Mathieu-Daudé --- Since v1

Re: [PATCH 2/3] tests/acpi/bios-tables-test: use the correct slot on the pcie-root-port

On Wed, 21 Jun 2023 19:37:22 +0530 Ani Sinha wrote: > PCIE ports only have one slot, slot 0. Hence, non-zero slots are not available > for PCIE devices on PCIE root ports. Fix test_acpi_q35_tcg_no_acpi_hotplug() > so that the test does not use them. > > Signed-off-by: Ani Sinha Reviewed-by: Ig

Re: [PATCH 1/3] tests/acpi: allow changes in DSDT.noacpihp table blob

On Wed, 21 Jun 2023 19:37:21 +0530 Ani Sinha wrote: > We are going to fix bio-tables-test in the next patch and hence need to > make sure the acpi tests continue to pass. > > Signed-off-by: Ani Sinha Acked-by: Igor Mammedov > --- > tests/qtest/bios-tables-test-allowed-diff.h | 1 + > 1 file

Re: [PATCH RFC] icount: don't adjust virtual time backwards after warp

Queued, thanks. Paolo

Re: [PATCH 3/3] tests/acpi/bios-tables-test: update acpi blob q35/DSDT.noacpihp

On Wed, 21 Jun 2023 19:37:23 +0530 Ani Sinha wrote: > Some fixes were committed in bios-tables-test in the previous commit. Update > the acpi blob and clear bios-tables-test-allowed-diff.h so that the test > continues to pass with the changes in the bios-tables-test. > > Following is the asl dif

Re: [PATCH RFC] icount: don't adjust virtual time backwards after warp

On Mon, Jun 26, 2023 at 1:08 PM Paolo Bonzini wrote: > Queued, thanks. Hmm, almost, can you provide the Signed-off-by? Thanks, Paolo

Re: [PATCH] target/i386: Export MSR_ARCH_CAPABILITIES bits to guests

Queued, thanks. Paolo

[PULL 00/18] Misc, i386 patches for 2023-06-26

The following changes since commit 79dbd910c9ea6ca38f8e1b2616b1e5e885b85bd3: Merge tag 'hppa-boot-reboot-fixes-pull-request' of https://github.com/hdeller/qemu-hppa into staging (2023-06-25 08:58:49 +0200) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-

  1   2   3   4   5   6   >