On 6/21/23 18:03, Frederic Barrat wrote:
Fix the TIMA special ops detection regression, as spotted by Coverity.
Tested by running a pseries guest on top of a powernv9 and powernv10 host.
FYI,
It is possible to force Gen1 on XIVE2 also. It you set the "capabilities"
property on the command lin
On Wed, Jun 21, 2023 at 7:28 AM Igor Mammedov wrote:
> On Tue, 20 Jun 2023 13:24:36 -0400
> Joel Upham wrote:
>
> > On Q35 we still need to assign BSEL property to bus(es) for PCI device
> > add/hotplug to work.
> > Extend acpi_set_pci_info() function to support Q35 as well. This patch
> adds ne
On Wed, Jun 21, 2023 at 7:28 AM Igor Mammedov wrote:
> On Tue, 20 Jun 2023 13:24:37 -0400
> Joel Upham wrote:
>
> > This patch allows to use ACPI PCI hotplug functionality for Xen on Q35.
> > All added code depends on xen_enabled(), so no functionality change for
> > non-Xen usage.
> >
> > We ne
On 21/06/2023 19:23, Cédric Le Goater wrote:
FYI,
It is possible to force Gen1 on XIVE2 also. It you set the "capabilities"
property on the command line :
-global driver=pnv-xive2,property=capabilities,value=0x1000120076f000FC
Thanks, I hadn't noticed. And "config" too! Good to know...
On Wed, Jun 21, 2023 at 7:34 AM Igor Mammedov wrote:
> On Tue, 20 Jun 2023 13:24:57 -0400
> Joel Upham wrote:
>
> > Resetting pci devices after s3 causes guest freezes, as xen usually
> > likes to handle resetting devices.
>
> I'd prefer Xen side being fixed instead of hacking reset logic in qem
On 6/21/23 19:08, Denis V. Lunev wrote:
On 6/7/23 17:26, Andrey Drobyshev wrote:
Functions qcow2_get_host_offset(), get_cluster_offset() explicitly
report compressed cluster types when data is compressed. However, this
information is never passed further. Let's make use of it by adding new
BDRV
Signed-off-by: Richard Henderson
---
target/sparc/translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/sparc/translate.c b/target/sparc/translate.c
index bad2ec90a0..28d4cdb8b4 100644
--- a/target/sparc/translate.c
+++ b/target/sparc/translate.c
@@ -318,10 +3
When resolving JUMP_PC, we know this is for a plain branch
with no other side effects.
Signed-off-by: Richard Henderson
---
target/sparc/translate.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/sparc/translate.c b/target/sparc/translate.c
index d12f2ac423..bd3
During translation, npc == address, DYNAMIC_PC, or JUMP_PC.
It is only the encoding between here and sparc_restore_state_to_opc
that considers JUMP_PC to be a bit within a larger value.
Signed-off-by: Richard Henderson
---
target/sparc/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deleti
Create a new artificial "next pc" which also indicates
that nothing has changed within the cpu state which
requires returning to the main loop.
Pipe this new value though all pc/npc checks.
Do not produce this new value yet.
Signed-off-by: Richard Henderson
---
target/sparc/translate.c | 155 ++
Let the compiler decide about inlining.
Signed-off-by: Richard Henderson
---
target/sparc/translate.c | 237 ++-
1 file changed, 111 insertions(+), 126 deletions(-)
diff --git a/target/sparc/translate.c b/target/sparc/translate.c
index eec6f9ca67..1312c3e94d
Changes from v1:
* Split into teeny weeny pieces.
* It turns out the sparc_tr_tb_stop hunk of v1 was buggy,
in that things that are not simple branches use DYNAMIC_PC,
e.g. the RETT (return from trap) instruction.
Introduce DYNAMIC_PC_LOOKUP to distinguish the couple of
places
We incorporate %asi into tb->flags so that we may generate
inline code for the many ASIs for which it is easy to do so.
Setting %asi is common for e.g. memcpy and memset performing
block copy and clear, so it is worth noticing this case.
We must end the TB but do not need to return to the main loo
This is for a plain indirect branch with no other side effects.
Signed-off-by: Richard Henderson
---
target/sparc/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/sparc/translate.c b/target/sparc/translate.c
index bd3feed72e..9ed235d26d 100644
--- a/target/s
After the register window unwind, this is for a plain indirect
branch with no further side effects.
Signed-off-by: Richard Henderson
---
target/sparc/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/sparc/translate.c b/target/sparc/translate.c
index 9ed235d2
On 6/21/23 20:46, Denis V. Lunev wrote:
> On 6/21/23 19:08, Denis V. Lunev wrote:
>> On 6/7/23 17:26, Andrey Drobyshev wrote:
>>> Functions qcow2_get_host_offset(), get_cluster_offset() explicitly
>>> report compressed cluster types when data is compressed. However, this
>>> information is never pa
On 6/7/23 17:26, Andrey Drobyshev wrote:
Right now "qemu-img map" reports compressed blocks as containing data
but having no host offset. This is not very informative. Instead,
let's add another boolean field named "compressed" in case JSON output
mode is specified. This is achieved by utilizi
On Wed, 21 Jun 2023 08:09:12 +0100
Daniel P. Berrangé wrote:
> If you're using one of the common Linux distros, you'll find a list of
> the full set of packages you need to enable QEMU feuatres in the
> dockerfiles at tests/docker/dockerfiles/. Those all have enough to
> enable the docs build.
T
On 6/1/23 21:28, Andrey Drobyshev wrote:
Since commit bb1c05973cf ("qemu-img: Use qemu_blockalign"), buffers for
the data read from the old and new backing files are aligned using
BlockDriverState (or BlockBackend later on) referring to the target image.
However, this isn't quite right, because t
On 21.06.2023 12:32, David Hildenbrand wrote:
On 20.06.23 22:13, Maciej S. Szmigiero wrote:
On 19.06.2023 17:58, David Hildenbrand wrote:
[...]
Sorry for the late reply!
Still trying to make up my mind what the right way forward with this is.
This usage is still problematic I suspect (well
On 6/1/23 21:28, Andrey Drobyshev wrote:
If we rebase an image whose backing file has compressed clusters, we
might end up wasting disk space since the copied clusters are now
uncompressed. In order to have better control over this, let's add
"--compress" option to the "qemu-img rebase" command.
On 6/1/23 21:28, Andrey Drobyshev wrote:
In case when we're rebasing within one backing chain, and when target image
is larger than old backing file, bdrv_is_allocated_above() ends up setting
*pnum = 0. As a result, target offset isn't getting incremented, and we
get stuck in an infinite for loo
On 6/1/23 21:28, Andrey Drobyshev wrote:
Before previous commit, rebase was getting infitely stuck in case of
rebasing within the same backing chain and when overlay_size > backing_size.
Let's add this case to the rebasing test 024 to make sure it doesn't
break again.
Signed-off-by: Andrey Droby
On 6/1/23 21:28, Andrey Drobyshev wrote:
When rebasing an image from one backing file to another, we need to
compare data from old and new backings. If the diff between that data
happens to be unaligned to the target cluster size, we might end up
doing partial writes, which would lead to copy-on
Peter Xu wrote:
> On Wed, Jun 21, 2023 at 12:07:20PM +0200, Juan Quintela wrote:
>> Peter Xu wrote:
>> > On Fri, Jun 09, 2023 at 12:49:14AM +0200, Juan Quintela wrote:
>> >> Makes things easier and cleaner.
>> >>
>> >> Signed-off-by: Juan Quintela
>> >> ---
>> >> tests/qtest/migration-test.c |
On 6/20/2023 5:46 PM, Peter Xu wrote:
> On Thu, Jun 15, 2023 at 01:26:39PM -0700, Steve Sistare wrote:
>> Migration of a guest in the suspended state is broken. The incoming
>> migration code automatically tries to wake the guest, which IMO is
>> wrong -- the guest should end migration in the same
On 6/1/23 21:28, Andrey Drobyshev wrote:
The test cases considered so far:
1. Check that compression mode isn't compatible with "-f raw" (raw
format doesn't support compression).
2. Check that rebasing an image onto no backing file preserves the data
and writes the copied clusters actual
On Wed, 21 Jun 2023 at 11:00, Alex Bennée wrote:
>
>
> Peter Maydell writes:
>
> > On Wed, 21 Jun 2023 at 09:05, Alex Bennée wrote:
> >> - I suspect the plugin core stuff could be build once (or maybe twice,
> >> system and user)
> >
> > It is already build-once, that's why it goes wrong..
Tejus GK wrote:
> Hi everyone,
>
> This is the v5 patchset which has been rebased on the current
> master. Requesting this to be queued for merge as this has already been
> reviewed.
queued.
thanks.
>
> Regards,
> Tejus
>
> Tejus GK (2):
> migration: Update error description whenever migrat
On Wed, 21 Jun 2023 14:11:53 +0300
Avihai Horon wrote:
> Hello everyone,
>
> The latest changes to migration qtest made the tests run non-live by
> default. I am posting this v6 to change back the switchover-ack
> migration test to run live as it used to (because the source VM needs to
> be runn
Alex Bennée wrote:
> Mention that QOM-ified devices already have support for registering
> the description.
>
> Signed-off-by: Alex Bennée
Reviewed-by: Juan Quintela
I really remove that function in a future series (well, I substitute it
with vmstate_register_id() and vmstate_register_any(), b
Peter Xu wrote:
> On Fri, Jun 09, 2023 at 12:49:13AM +0200, Juan Quintela wrote:
>> It failed on aarch64 tcg, lets see if that is still the case.
>>
>> Signed-off-by: Juan Quintela
>
> According to the history:
>
> https://lore.kernel.org/all/20190305180635.GA3803@work-vm/
>
> It's never enabled
On 6/21/2023 12:45 PM, Peter Xu wrote:
> On Thu, Jun 15, 2023 at 01:26:40PM -0700, Steve Sistare wrote:
>> Add a test case to verify that the suspended state is handled correctly in
>> live migration. The test suspends the src, migrates, then wakes the dest.
>>
>> Add an option to suspend the src
Wei Wang wrote:
> qemu_start_incoming_migration needs to check the number of multifd
> channels or postcopy ram channels to configure the backlog parameter (i.e.
> the maximum length to which the queue of pending connections for sockfd
> may grow) of listen(). So enforce the usage of postcopy-pree
Chuang Xu wrote:
> Hi,Juan,
>
> On 2023/1/30 下午4:09, Juan Quintela wrote:
>> Current code asumes that all pages are whole. That is not true for
>> example for compression already. Fix it for creating a new field
>> ->sent_bytes that includes it.
>>
>> All ram_counters are used only from the migr
On Wed, Jun 21, 2023 at 09:38:08PM +0200, Juan Quintela wrote:
> Peter Xu wrote:
> > On Fri, Jun 09, 2023 at 12:49:13AM +0200, Juan Quintela wrote:
> >> It failed on aarch64 tcg, lets see if that is still the case.
> >>
> >> Signed-off-by: Juan Quintela
> >
> > According to the history:
> >
> >
On Wed, Jun 21, 2023 at 03:39:44PM -0400, Steven Sistare wrote:
> >> -jmp mainloop
> >> +# should this test suspend?
> >> +mov (suspend_me),%eax
> >> +cmp $0,%eax
> >> +je mainloop
> >> +
> >> +# are we waking after suspend? do not suspend again.
> >
On Wed, Jun 21, 2023 at 10:20:25AM +0200, Albert Esteve wrote:
> Hi!
>
> It has been a month since I sent this patch, so I'll give it a bump to get
> some
> attention back.
>
> @mst and @Fam any comments? What would be the next steps to take to move this
> forward?
>
> BR,
> Albert
>
>
I'd r
On Wed, Jun 21, 2023 at 03:15:42PM -0400, Steven Sistare wrote:
> On 6/20/2023 5:46 PM, Peter Xu wrote:
> > On Thu, Jun 15, 2023 at 01:26:39PM -0700, Steve Sistare wrote:
> >> Migration of a guest in the suspended state is broken. The incoming
> >> migration code automatically tries to wake the gu
Wei Wang wrote:
> qemu_start_incoming_migration needs to check the number of multifd
> channels or postcopy ram channels to configure the backlog parameter (i.e.
> the maximum length to which the queue of pending connections for sockfd
> may grow) of listen(). So enforce the usage of postcopy-pree
gdbstub cannot meaningfully handle QEMU_ERESTARTSYS, and it doesn't
need to. Add a parameter to do_guest_openat() that makes it use
openat() instead of safe_openat(), so that it becomes usable from
gdbstub.
Signed-off-by: Ilya Leoshkevich
Reviewed-by: Richard Henderson
---
linux-user/qemu.h
/proc/self/smaps is an extension of /proc/self/maps: it provides the
same lines, plus additional information about each range.
GDB uses /proc/self/smaps when available, which means that
generate-core-file tries it first before falling back to
/proc/self/maps. This, in turn, causes it to dump the h
These functions will be required by the GDB stub in order to provide
the guest view of /proc to GDB.
Reviewed-by: Alex Bennée
Signed-off-by: Ilya Leoshkevich
Reviewed-by: Richard Henderson
---
linux-user/qemu.h| 3 +++
linux-user/syscall.c | 54
These functions will be needed by user-target.c in order to retrieve
the name of the executable.
Reviewed-by: Alex Bennée
Signed-off-by: Ilya Leoshkevich
---
gdbstub/gdbstub.c | 16
gdbstub/internals.h | 2 ++
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/g
Currently the GDB's generate-core-file command doesn't work well with
qemu-user: the resulting dumps are huge [1] and at the same time
incomplete (argv and envp are missing). The reason is that GDB has no
access to proc mappings and therefore has to fall back to using
heuristics for discovering the
Now that the GDB stub explicitly implements reading host files (note
that it was already possible by changing the emulated code to open and
read those files), concerns may arise that it undermines security.
Document the status quo, which is that the users are already
responsible for securing the G
v3: https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg01311.html
v3 -> v4: Fix the 32-bit build (Alex).
Enable the test on all architectures and ignore certain
expected failures (Alex). I tried this with the latest
gdb-multiarch and it works. The only skip is on
Add a small test to prevent regressions.
Signed-off-by: Ilya Leoshkevich
---
tests/tcg/multiarch/Makefile.target | 9 ++-
.../multiarch/gdbstub/test-proc-mappings.py | 65 +++
2 files changed, 73 insertions(+), 1 deletion(-)
create mode 100644 tests/tcg/multiarch/gd
Currently qemu-user reports pid 1 to GDB. Resolve the TODO and report
the actual PID. Using getpid() relies on the assumption that there is
only one GDBProcess. Add an assertion to make sure that future changes
don't break it.
Reviewed-by: Alex Bennée
Signed-off-by: Ilya Leoshkevich
---
gdbstub
Peter Xu wrote:
> On Wed, Jun 21, 2023 at 09:38:08PM +0200, Juan Quintela wrote:
>> Peter Xu wrote:
>> > On Fri, Jun 09, 2023 at 12:49:13AM +0200, Juan Quintela wrote:
>> >> It failed on aarch64 tcg, lets see if that is still the case.
>> >>
>> >> Signed-off-by: Juan Quintela
>> >
>> > Accordin
n/qemu.git tags/pull-tricore-20230621-1
for you to fetch changes up to a9c37abdff65a07d0191123a21d318c4d8cc7f33:
target/tricore: Fix ICR.IE offset in RESTORE insn (2023-06-21 18:09:54 +0200)
- Implement privilege levels for Tri
Hi Joel,
Nice! I've been working on making the PIIX south bridge Xen agnostic, partly to
show how Xen enablement in Q35 could look like. Not that I'd have any use case
for it but great to see that you've actually done that!
I know you didn't intend to send this patch but I'll give you some e
Respond with VIRTIO_GPU_RESP_ERR_OUT_OF_MEMORY if it fails to create
an udmabuf for the blob resource.
Cc: Gerd Hoffmann
Cc: Marc-André Lureau
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
hw/display/virtio-gpu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/d
x and y offsets and width and height of the scanout texture
is not correctly configured in case guest scanout frame is
dmabuf.
Cc: Gerd Hoffmann
Cc: Marc-André Lureau
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
ui/gtk-egl.c | 3 ++-
ui/gtk-gl-area.c | 3 ++-
2 files changed, 4 inse
Peter Xu wrote:
> On Wed, Jun 21, 2023 at 09:38:08PM +0200, Juan Quintela wrote:
>> Peter Xu wrote:
>> > On Fri, Jun 09, 2023 at 12:49:13AM +0200, Juan Quintela wrote:
>> >> It failed on aarch64 tcg, lets see if that is still the case.
>> >>
>> >> Signed-off-by: Juan Quintela
>> >
>> > Accordin
Peter Xu wrote:
> On Tue, Jun 13, 2023 at 06:02:05PM +0200, Juan Quintela wrote:
>> Peter Xu wrote:
>> > On Tue, May 30, 2023 at 08:39:25PM +0200, Juan Quintela wrote:
>> >> Remove the increase in qemu_file_fill_buffer() and add asserts to
>> >> qemu_file_transferred* functions.
>> >>
>> >> Sign
Set vc->gfx.guest_fb.dmabuf to NULL to prevent any further access
to it after the dmabuf is released.
Cc: Gerd Hoffmann
Cc: Marc-André Lureau
Cc: Vivek Kasireddy
Signed-off-by: Dongwon Kim
---
ui/gtk.c | 4
1 file changed, 4 insertions(+)
diff --git a/ui/gtk.c b/ui/gtk.c
index e50f950f2
There were often cases where a scanout blob sometimes has just 1 entry
that is linked to many pages in it. So just checking whether iov_cnt is 1
is not enough for screening small, non-scanout blobs. Therefore adding
iov_len check as well to make sure it creates an udmabuf only for a scanout
blob, w
Peter Xu wrote:
> On Tue, May 30, 2023 at 08:39:27PM +0200, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela
>> ---
>> migration/qemu-file.c | 4
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/migration/qemu-file.c b/migration/qemu-file.c
>> index eb0497e532..6b6deea19b 100644
>>
I also have this problem, with the 3D acceleration enabled, it would be
great if the situation improves as the VM often not stable after the
host restores from sleep state.
** Changed in: qemu
Status: Expired => Confirmed
--
You received this bug notification because you are a member of q
On Mon, Jun 12, 2023 at 9:11 PM Christoph Muellner
wrote:
>
> From: Christoph Müllner
>
> This series adds vendor extension support to the QEMU disassembler
> for RISC-V. The following vendor extensions are covered:
> * XThead{Ba,Bb,Bs,Cmo,CondMov,FMemIdx,Fmv,Mac,MemIdx,MemPair,Sync}
> * XVentana
According to the VirtIO standard, "Since there are no guarantees,
it can use a hash filter or silently switch to
allmulti or promiscuous mode if it is given too many addresses."
To achive this, QEMU ignores MAC addresses and marks `mac_table.x_overflow`
in the device internal state in virtio_net_ha
On Wed, Jun 14, 2023 at 7:00 AM Daniel Henrique Barboza
wrote:
>
> We're going to change the handling of mvendorid/marchid/mimpid by the
> KVM driver. Since these are always present in all CPUs let's put the
> same validation for everyone.
>
> It doesn't make sense to allow 'mvendorid' to be diffe
On Wed, Jun 14, 2023 at 7:01 AM Daniel Henrique Barboza
wrote:
>
> Following the same logic used with 'mvendorid' let's also restrict
> 'mimpid' for named CPUs. Generic CPUs keep setting the value freely.
>
> Note that we're getting rid of the default RISCV_CPU_MARCHID value. The
> reason is that
On Wed, Jun 14, 2023 at 7:03 AM Daniel Henrique Barboza
wrote:
>
> 'marchid' shouldn't be set to a different value as previously set for
> named CPUs.
>
> For all other CPUs it shouldn't be freely set either - the spec requires
> that 'marchid' can't have the MSB (most significant bit) set and eve
On Wed, Jun 14, 2023 at 7:00 AM Daniel Henrique Barboza
wrote:
>
> After changing user validation for mvendorid/marchid/mimpid to guarantee
> that the value is validated on user input time, coupled with the work in
> fetching KVM default values for them by using a scratch CPU, we're
> certain that
On Wed, Jun 14, 2023 at 7:02 AM Daniel Henrique Barboza
wrote:
>
> Update to commit ac9a78681b92 ("Linux 6.4-rc1").
>
> Signed-off-by: Daniel Henrique Barboza
Acked-by: Alistair Francis
Alistair
> ---
> include/standard-headers/linux/const.h| 2 +-
> include/standard-headers/linux/v
On Wed, Jun 14, 2023 at 7:00 AM Daniel Henrique Barboza
wrote:
>
> At this moment we're retrieving env->misa_ext during
> kvm_arch_init_cpu(), leaving env->misa_ext_mask behind.
>
> We want to set env->misa_ext_mask, and we want to set it as early as
> possible. The reason is that we're going to u
On Mon, Jun 19, 2023 at 7:24 PM Peter Maydell wrote:
>
> On Mon, 12 Jun 2023 at 05:12, Alistair Francis wrote:
> >
> > On Fri, Jun 9, 2023 at 4:01 PM Tommy Wu wrote:
> > >
> > > According to the `The RISC-V Advanced Interrupt Architecture`
> > > document, if register `mmsiaddrcfgh` of the domain
On Sat, Jun 3, 2023 at 11:43 PM Weiwei Li wrote:
>
> This patchset tries to fix some problems in the fields of mstatus, such as
> make MPV only work when MPP != PRM.
>
> The port is available here:
> https://github.com/plctlab/plct-qemu/tree/plct-mpv-upstream-v2
>
> v2:
> * Drop patch 3 (remove c
On Fri, Jun 9, 2023 at 2:47 AM Tommy Wu wrote:
>
> The watchdog timer is in the always-on domain device of HiFive 1 rev b,
> so this patch added the AON device to the sifive_e machine. This patch
> only implemented the functionality of the watchdog timer.
>
> Signed-off-by: Tommy Wu
> Reviewed-by
On Fri, Jun 9, 2023 at 2:46 AM Tommy Wu wrote:
>
> Create the AON device when we realize the sifive_e machine.
> This patch only implemented the functionality of the watchdog timer,
> not all the functionality of the AON device.
>
> Signed-off-by: Tommy Wu
> Reviewed-by: Frank Chang
Reviewed-by
On Fri, Jun 9, 2023 at 2:46 AM Tommy Wu wrote:
>
> Add some simple tests of the watchdog timer in the always-on domain device
> of HiFive 1 rev b.
>
> Signed-off-by: Tommy Wu
> Reviewed-by: Frank Chang
> Acked-by: Thomas Huth
Acked-by: Alistair Francis
Alistair
> ---
> tests/qtest/meson.bu
On Fri, Jun 9, 2023 at 2:46 AM Tommy Wu wrote:
>
> The HiFive 1 rev b includes a watchdog module based on a 32-bit
> counter. The watchdog timer is in the always-on domain device of
> HiFive 1 rev b, so this patch added the AON device to the sifive_e
> machine. This patch only implemented the func
From: Hyman Huang(黄勇)
dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid
if less than 0, so add parameter check for it.
Note that this patch also delete the unsolicited help message and
clean up the code.
Signed-off-by: Hyman Huang(黄勇)
Reviewed-by: Markus Armbruster
Reviewe
The following changes since commit 67fe6ae41da64368bc4936b196fee2bf61f8c720:
Merge tag 'pull-tricore-20230621-1' of https://github.com/bkoppelmann/qemu
into staging (2023-06-21 20:08:48 +0200)
are available in the Git repository at:
https://gitlab.com/juan.quintela/qemu.git tags
From: Fabiano Rosas
We're about to add more functions to this file so make it use the same
coding style as the rest of the code.
Signed-off-by: Fabiano Rosas
Reviewed-by: Juan Quintela
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Xu
Message-Id: <20230607161306.31425-2-faro...@suse.
From: Hyman Huang(黄勇)
This commit is prepared for the implementation of dirty-limit
convergence algo.
The detection logic of throttling condition can apply to both
auto-converge and dirty-limit algo, putting it's position
before the checking logic for auto-converge feature.
Signed-off-by: Hyman
From: Hyman Huang(黄勇)
Introduce "x-vcpu-dirty-limit-period" migration experimental
parameter, which is in the range of 1 to 1000ms and used to
make dirtyrate calculation period configurable.
Currently with the "x-vcpu-dirty-limit-period" varies, the
total time of live migration changes, test res
From: Fabiano Rosas
This doubly linked list is common for all the multifd and migration
threads so we need to avoid concurrent access.
Add a mutex to protect the data from concurrent access. This fixes a
crash when removing two MigrationThread objects from the list at the
same time during cleanu
From: Hyman Huang(黄勇)
Extend query-migrate to provide throttle time and estimated
ring full time with dirty-limit capability enabled, through which
we can observe if dirty limit take effect during live migration.
Signed-off-by: Hyman Huang(黄勇)
Reviewed-by: Markus Armbruster
Reviewed-by: Juan Q
Reviewed-by: Peter Xu
Signed-off-by: Juan Quintela
Message-ID: <20230608224943.3877-5-quint...@redhat.com>
---
tests/qtest/migration-test.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index c5e0c69c6b.
From: Hyman Huang(黄勇)
Implement dirty-limit convergence algo for live migration,
which is kind of like auto-converge algo but using dirty-limit
instead of cpu throttle to make migration convergent.
Enable dirty page limit if dirty_rate_high_cnt greater than 2
when dirty-limit capability enabled,
So no need to assert we are in x86_64.
Once there, refactor the function to remove useless variables.
Reviewed-by: Peter Xu
Message-ID: <20230608224943.3877-11-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
tests/qtest/migration-test.c | 5 +
1 file changed, 1 insertion(+), 4 deletio
From: Hyman Huang(黄勇)
Introduce "vcpu-dirty-limit" migration parameter used
to limit dirty page rate during live migration.
"vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are
two dirty-limit-related migration parameters, which can
be set before and during live migration by qmp
migrate-set-pa
It makes no sense that we don't have the same configuration on both sides.
Reviewed-by: Laurent Vivier
Message-ID: <20230608224943.3877-2-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
tests/qtest/migration-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/
The bootsector code is read only from the guest (otherwise we are
going to have problems with it being read from both source and
destination).
Create a single copy for all the tests.
Reviewed-by: Peter Xu
Message-ID: <20230608224943.3877-10-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
Fast don't say much. Noflush indicates more clearly that it is like
qemu_file_transferred but without the flush.
Reviewed-by: Philippe Mathieu-Daudé
Message-ID: <20230530183941.7223-2-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
migration/qemu-file.h | 11 +--
migration/qemu-f
Reviewed-by: Peter Xu
Message-ID: <20230608224943.3877-4-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
tests/qtest/migration-test.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index fbe9db23cf..e3e
So just make it a global variable.
Reviewed-by: Peter Xu
Message-ID: <20230608224943.3877-9-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
tests/qtest/migration-test.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/tests/qtest/migration-test.c b
From: Tejus GK
In the function qmp_migrate(), yank_unregister_instance() gets called
twice which isn't required. Hence, refactoring it so that it gets called
during the local_error cleanup.
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Juan Quintela
Acked-by: Peter Xu
Signed-off-by: Tejus GK
Reviewed-by: Peter Xu
Message-ID: <20230530183941.7223-20-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
migration/qemu-file.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 9a89e17924..4c577bdff8 100644
--- a/
So arch_dirty_ring option becomes one option like the others.
Reviewed-by: Peter Xu
Message-ID: <20230608224943.3877-8-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
tests/qtest/migration-test.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/tests/qtest/m
And it needs to be in both source and target, so put it on arch_opts.
Reviewed-by: Peter Xu
Message-ID: <20230608224943.3877-7-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
tests/qtest/migration-test.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/te
From: Hyman Huang(黄勇)
Check if block migration is running before throttling
guest down in auto-converge way.
Note that this modification is kind of like code clean,
because block migration does not depend on auto-converge
capability, so the order of checks can be adjusted.
Signed-off-by: Hyman
This will contain the options needed for both source and target.
Reviewed-by: Peter Xu
Message-ID: <20230608224943.3877-6-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
tests/qtest/migration-test.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
di
We only care about the amount of bytes transferred. Flushing is done
by the system somewhere else.
Reviewed-by: Fabiano Rosas
Signed-off-by: Juan Quintela
Message-ID: <20230530183941.7223-4-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
migration/block.c | 4 ++--
1 file changed, 2 ins
From: Wei Wang
qemu_start_incoming_migration needs to check the number of multifd
channels or postcopy ram channels to configure the backlog parameter (i.e.
the maximum length to which the queue of pending connections for sockfd
may grow) of listen(). So enforce the usage of postcopy-preempt and
We do a qemu_fclose() just after that, that also does a qemu_fflush(),
so remove one qemu_fflush().
Reviewed-by: Philippe Mathieu-Daudé
Message-ID: <20230530183941.7223-3-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
migration/savevm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
This is how everything else in QEMUFile is structured.
As a bonus they are three less lines of code.
Reviewed-by: Peter Xu
Message-ID: <20230530183941.7223-17-quint...@redhat.com>
Signed-off-by: Juan Quintela
---
migration/qemu-file.h | 1 -
migration/qemu-file.c | 12
migration/r
301 - 400 of 415 matches
Mail list logo
