Re: [PULL 0/1] Seabios hppa v7 patches

2023-06-21 Thread Richard Henderson
On 6/20/23 21:58, Helge Deller wrote: The following changes since commit 327ec8d6c2a2223b78d311153a471036e474c5c5: Merge tag 'pull-tcg-20230423' of https://gitlab.com/rth7680/qemu into staging (2023-04-23 11:20:37 +0100) are available in the Git repository at: https://github.com/hdeller

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-21 Thread Thomas Huth
On 12/06/2023 21.33, Juan Quintela wrote: Only "defer" is recommended. After setting all migation parameters, start incoming migration with "migrate-incoming uri" command. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ softmmu/vl.c | 2 ++ 2 files chan

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-21 Thread Paolo Bonzini
Il mer 21 giu 2023, 02:21 John Snow ha scritto: > Hi, this is ... a fairly incomplete series about trying to get iotests > to run out of the configure-time venv. I'm looking for some feedback, so > out to the list it goes. > > Primarily, I'm having doubts about these points: > > 1) I think I need

Re: [PATCH v7] Emulate dip switch language layout settings on SUN keyboard

2023-06-21 Thread Daniel P . Berrangé
On Tue, Jun 20, 2023 at 09:50:43PM +0200, Henrik Carlqvist wrote: > On Tue, 20 Jun 2023 10:22:40 +0100 > Daniel P. Berrangé wrote: > > Thanks for your feedback! > > > Assuming you have docutils installed, QEMU will build the manual by > > default and print any issues on console during build. Yo

Re: [PATCH v4 1/1] hw/arm/sbsa-ref: use XHCI to replace EHCI

2023-06-21 Thread Marcin Juszkiewicz
W dniu 21.06.2023 o 05:46, Yuquan Wang pisze: On 2023-06-21 01:24, Leif wrote: > > Leif, do you think we should bump the minor version here? > I think that makes sense, yes. There is a new confusion: Which minor version should I bump to (2 or 3) ? As I found that Marcin’s latest patch (add 

Re: [RFC 6/6] migration: Deprecated old compression method

2023-06-21 Thread Thomas Huth
On 12/06/2023 21.33, Juan Quintela wrote: Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 8 qapi/migration.json | 92 --- migration/options.c | 13 ++ 3 files changed, 79 insertions(+), 34 deletions(-) diff --git a/doc

Re: [PATCH v1 01/23] pc/xen: Xen Q35 support: provide IRQ handling for PCI devices

2023-06-21 Thread Daniel P . Berrangé
On Tue, Jun 20, 2023 at 01:24:34PM -0400, Joel Upham wrote: > > Signed-off-by: Alexey Gerasimenko This isn't a valid email address for Alexey - I presume you grabbed these patches from the xen-devel mail archives, which have mangled the addresses for anti-spam reasons. Fortunately there are alt

Re: [PULL 05/29] pnv/xive2: Handle TIMA access through all ports

2023-06-21 Thread Cédric Le Goater
On 6/20/23 16:31, Frederic Barrat wrote: On 20/06/2023 13:20, Cédric Le Goater wrote: On 6/20/23 12:45, Peter Maydell wrote: On Sat, 10 Jun 2023 at 14:31, Daniel Henrique Barboza wrote: From: Frederic Barrat The Thread Interrupt Management Area (TIMA) can be accessed through 4 ports, tar

[PATCH QEMU v6 0/9] migration: introduce dirtylimit capability

2023-06-21 Thread ~hyman
Thanks Juan for the review, in case to keep the modifications consistent with the old versions, i posted the full series for review. Feel free to pull the first 5 commits if it help speeding up the process. The version 6 do the following modifications: v6: 1. Rebase on master 2. Split the commit "

[PATCH QEMU v6 2/9] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter

2023-06-21 Thread ~hyman
From: Hyman Huang(黄勇) Introduce "x-vcpu-dirty-limit-period" migration experimental parameter, which is in the range of 1 to 1000ms and used to make dirtyrate calculation period configurable. Currently with the "x-vcpu-dirty-limit-period" varies, the total time of live migration changes, test res

[PATCH QEMU v6 7/9] migration: Implement dirty-limit convergence algo

2023-06-21 Thread ~hyman
From: Hyman Huang(黄勇) Implement dirty-limit convergence algo for live migration, which is kind of like auto-converge algo but using dirty-limit instead of cpu throttle to make migration convergent. Enable dirty page limit if dirty_rate_high_cnt greater than 2 when dirty-limit capability enabled,

[PATCH QEMU v6 3/9] qapi/migration: Introduce vcpu-dirty-limit parameters

2023-06-21 Thread ~hyman
From: Hyman Huang(黄勇) Introduce "vcpu-dirty-limit" migration parameter used to limit dirty page rate during live migration. "vcpu-dirty-limit" and "x-vcpu-dirty-limit-period" are two dirty-limit-related migration parameters, which can be set before and during live migration by qmp migrate-set-pa

[PATCH QEMU v6 1/9] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit"

2023-06-21 Thread ~hyman
From: Hyman Huang(黄勇) dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid if less than 0, so add parameter check for it. Note that this patch also delete the unsolicited help message and clean up the code. Signed-off-by: Hyman Huang(黄勇) Signed-off-by: Markus Armbruster Revie

[PATCH QEMU v6 6/9] migration: Put the detection logic before auto-converge checking

2023-06-21 Thread ~hyman
From: Hyman Huang(黄勇) This commit is prepared for the implementation of dirty-limit convergence algo. The detection logic of throttling condition can apply to both auto-converge and dirty-limit algo, putting it's position before the checking logic for auto-converge feature. Signed-off-by: Hyman

[PATCH QEMU v6 5/9] migration: Refactor auto-converge capability logic

2023-06-21 Thread ~hyman
From: Hyman Huang(黄勇) Check if block migration is running before throttling guest down in auto-converge way. Note that this modification is kind of like code clean, because block migration does not depend on auto-converge capability, so the order of checks can be adjusted. Signed-off-by: Hyman

[PATCH QEMU v6 9/9] tests: Add migration dirty-limit capability test

2023-06-21 Thread ~hyman
From: Hyman Huang(黄勇) Add migration dirty-limit capability test if kernel support dirty ring. Migration dirty-limit capability introduce dirty limit capability, two parameters: x-vcpu-dirty-limit-period and vcpu-dirty-limit are introduced to implement the live migration with dirty limit. The te

[PATCH QEMU v6 4/9] migration: Introduce dirty-limit capability

2023-06-21 Thread ~hyman
From: Hyman Huang(黄勇) Introduce migration dirty-limit capability, which can be turned on before live migration and limit dirty page rate durty live migration. Introduce migrate_dirty_limit function to help check if dirty-limit capability enabled during live migration. Meanwhile, refactor vcpu_d

Re: [PATCH] hw/mips: Improve the default USB settings in the loongson3-virt machine

2023-06-21 Thread Thomas Huth
On 08/06/2023 20.31, Michael Tokarev wrote: 07.06.2023 13:26, Thomas Huth wrote: On 25/05/2023 08.47, Thomas Huth wrote: It's possible to compile QEMU without the USB devices (e.g. when using "--without-default-devices" as option for the "configure" script). To be still able to run the loongson

[PATCH QEMU v6 8/9] migration: Extend query-migrate to provide dirty page limit info

2023-06-21 Thread ~hyman
From: Hyman Huang(黄勇) Extend query-migrate to provide throttle time and estimated ring full time with dirty-limit capability enabled, through which we can observe if dirty limit take effect during live migration. Signed-off-by: Hyman Huang(黄勇) Signed-off-by: Markus Armbruster Reviewed-by: Juan

[PATCH v2] hw/mips: Improve the default USB settings in the loongson3-virt machine

2023-06-21 Thread Thomas Huth
It's possible to compile QEMU without the USB devices (e.g. when using "--without-default-devices" as option for the "configure" script). To be still able to run the loongson3-virt machine in default mode with such a QEMU binary, we have to check here for the availability of the USB devices first b

Re: [qemu-web PATCH] include Dockerfile used to proxy qemu.org to gitlab.io

2023-06-21 Thread Thomas Huth
On 16/06/2023 14.08, Paolo Bonzini wrote: The server configuration used to actually publish qemu-web.git to qemu.org together with the sphinx documentation, right now, is hidden in the machine that runs qemu.org. Include it in the qemu-web.git website for documentation purpose, in the format of

[PATCH v3 0/3] hw/ufs: Add Universal Flash Storage (UFS) support

2023-06-21 Thread Jeuk Kim
Since v2: Addressed review comment from Stefan Hajnoczi. The main fixes are as follows. - Use of SPDX licence identifiers - fixed endianness error - removed memory leak - fixed DMA error handling logic This patch series adds support for a new PCI-based UFS device. The UFS pci device id (PCI_DEVI

[PATCH v3 1/3] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-06-21 Thread Jeuk Kim
Universal Flash Storage (UFS) is a high-performance mass storage device with a serial interface. It is primarily used as a high-performance data storage device for embedded applications. This commit contains code for UFS device to be recognized as a UFS PCI device. Patches to handle UFS logical un

Re: [PATCH v3 1/6] ebpf: Added eBPF map update through mmap.

2023-06-21 Thread Daniel P . Berrangé
On Thu, Jun 15, 2023 at 01:10:21AM +0300, Andrew Melnychenko wrote: > Changed eBPF map updates through mmaped array. > Mmaped arrays provide direct access to map data. > It should omit using bpf_map_update_elem() call, > which may require capabilities that are not present. > > Signed-off-by: Andre

Re: [PATCH v3 2/6] ebpf: Added eBPF initialization by fds.

2023-06-21 Thread Daniel P . Berrangé
On Thu, Jun 15, 2023 at 01:10:22AM +0300, Andrew Melnychenko wrote: > It allows using file descriptors of eBPF provided > outside of QEMU. > QEMU may be run without capabilities for eBPF and run > RSS program provided by management tool(g.e. libvirt). > > Signed-off-by: Andrew Melnychenko > --- >

Re: [PATCH v3 6/6] ebpf: Updated eBPF program and skeleton.

2023-06-21 Thread Daniel P . Berrangé
On Thu, Jun 15, 2023 at 01:10:26AM +0300, Andrew Melnychenko wrote: > Updated section name, so libbpf should init/gues proper > program type without specifications during open/load. > > Signed-off-by: Andrew Melnychenko > --- > ebpf/rss.bpf.skeleton.h | 1469 -

Re: [PATCH v3 3/6] virtio-net: Added property to load eBPF RSS with fds.

2023-06-21 Thread Daniel P . Berrangé
On Thu, Jun 15, 2023 at 01:10:23AM +0300, Andrew Melnychenko wrote: > eBPF RSS program and maps may now be passed during initialization. > Initially was implemented for libvirt to launch qemu without permissions, > and initialized eBPF program through the helper. > > Signed-off-by: Andrew Melnyche

Re: [PATCH v3 4/6] ebpf: Added declaration/initialization routines.

2023-06-21 Thread Daniel P . Berrangé
On Thu, Jun 15, 2023 at 01:10:24AM +0300, Andrew Melnychenko wrote: > Now, the binary objects may be retrieved by id. > It would require for future qmp commands that may require specific > eBPF blob. > > Signed-off-by: Andrew Melnychenko > --- > ebpf/ebpf.c | 70

[PATCH v3 2/3] hw/ufs: Support for Query Transfer Requests

2023-06-21 Thread Jeuk Kim
This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off-by: Jeuk Kim --- hw/ufs/trace-events |1 + hw/ufs/ufs.c| 1005 ++-

Re: [PATCH v3 5/6] qmp: Added new command to retrieve eBPF blob.

2023-06-21 Thread Daniel P . Berrangé
On Thu, Jun 15, 2023 at 01:10:25AM +0300, Andrew Melnychenko wrote: > Added command "request-ebpf". This command returns > eBPF program encoded base64. The program taken from the > skeleton and essentially is an ELF object that can be > loaded in the future with libbpf. > > Signed-off-by: Andrew M

[PATCH v3 3/3] hw/ufs: Support for UFS logical unit

2023-06-21 Thread Jeuk Kim
This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed-off-by: Jeuk Kim --- hw/ufs/lu.c | 1441 ++ hw/ufs/mes

Re: 'make check-tcg' fails with an assert in qemu_plugin_vcpu_init_hook

2023-06-21 Thread Alex Bennée
Peter Maydell writes: > On Tue, 20 Jun 2023 at 17:56, Peter Maydell wrote: >> >> $ make -C build/x86 check-tcg >> make: Entering directory >> '/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/x86' >> [...] >> TESTmunmap-pthread on arm >> ** >> ERROR:../../plugins/core.c:221:qemu_plugin_

[PATCH v3 2/3] vfio/pci: Fix a segfault in vfio_realize

2023-06-21 Thread Zhenzhong Duan
In case irqchip_change_notifier isn't added, removing it triggers segfault. Signed-off-by: Zhenzhong Duan --- hw/vfio/pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index c71b0955d81c..82c4cf4f7609 100644 --- a/hw/vfio/pci.c +++ b/hw/vf

[PATCH v3 1/3] vfio/pci: Fix resource leak in vfio_realize

2023-06-21 Thread Zhenzhong Duan
When adding migration blocker failed in vfio_migration_realize(), hotplug will fail and we see below: (qemu) device_add vfio-pci,host=81:11.1,id=vfio1,bus=root1,x-enable-migration=true :81:11.1: VFIO migration is not supported in kernel Error: disallowing migration blocker (--only-migratable)

[PATCH v3 0/3] VFIO migration related refactor and bug fix

2023-06-21 Thread Zhenzhong Duan
PATCH3 refactors the VFIO migration blocker related code based on suggestions from Joao and Cedric, so that code is simpler and "Migration disabled" printed in right case. But before that works, also found some hotplug bugs when testing blocker adding failed case. PATCH1 and PATCH2 fix them. See

[PATCH v3 3/3] vfio/migration: vfio/migration: Refactor and fix print of "Migration disabled"

2023-06-21 Thread Zhenzhong Duan
This patch refactors vfio_migration_realize() and its dependend code as follows: 1. It's redundant in vfio_migration_realize() to registers multiple blockers, e.g: vIOMMU blocker can be refactored as per device blocker. 2. Change vfio_block_giommu_migration() to be only a per device checker. 3.

Re: [PATCH 1/1] A new virtio pci device named virtio-vcpu-stall-watchdog-pci

2023-06-21 Thread Daniel P . Berrangé
On Thu, Jun 15, 2023 at 02:13:02PM +0800, zhanghao1 wrote: > Each vcpu creates a corresponding timer task. The watchdog > is driven by a timer according to a certain period. Each time > the timer expires, the counter is decremented. When the counter > is "0", the watchdog considers the vcpu to be s

[PATCH v6 4/5] parallels: Add checking and repairing duplicate offsets in BAT

2023-06-21 Thread Alexander Ivanov
Cluster offsets must be unique among all the BAT entries. Find duplicate offsets in the BAT and fix it by copying the content of the relevant cluster to a newly allocated cluster and set the new cluster offset to the duplicated entry. Add host_cluster_index() helper to deduplicate the code. When

Re: [PATCH v2 15/18] target/riscv: make riscv_isa_string_ext() KVM compatible

2023-06-21 Thread Andrew Jones
On Tue, Jun 20, 2023 at 07:05:18PM -0300, Daniel Henrique Barboza wrote: > > > On 6/19/23 06:54, Andrew Jones wrote: > > On Tue, Jun 13, 2023 at 05:58:54PM -0300, Daniel Henrique Barboza wrote: > > > The isa_edata_arr[] is used by riscv_isa_string_ext() to create the > > > riscv,isa DT attribute.

Re: [PATCH v3 0/4] Virtio shared dma-buf

2023-06-21 Thread Albert Esteve
Hi! It has been a month since I sent this patch, so I'll give it a bump to get some attention back. @mst and @Fam any comments? What would be the next steps to take to move this forward? BR, Albert On Wed, May 24, 2023 at 11:13 AM Albert Esteve wrote: > v1 link -> > https://lists.gnu.org/arc

[PATCH v6 1/5] parallels: Incorrect data end calculation in parallels_open()

2023-06-21 Thread Alexander Ivanov
The BDRVParallelsState structure contains data_end field that is measured in sectors. In parallels_open() initially this field is set by data_off field from parallels image header. According to the parallels format documentation, data_off field contains an offset, in sectors, from the start of the

[PATCH v6 2/5] parallels: Check if data_end greater than the file size

2023-06-21 Thread Alexander Ivanov
Initially data_end is set to the data_off image header field and must not be greater than the file size. Signed-off-by: Alexander Ivanov --- block/parallels.c | 5 + 1 file changed, 5 insertions(+) diff --git a/block/parallels.c b/block/parallels.c index 1ec98c722b..4b7eafba1e 100644 --- a/

[PATCH v6 3/5] parallels: Add change_info argument to parallels_check_leak()

2023-06-21 Thread Alexander Ivanov
In the next patch we need to repair leaks without changing leaks and leaks_fixed info in res. Add change_info argument to skip info changing if the argument is false. Signed-off-by: Alexander Ivanov --- block/parallels.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --

[PATCH v6 0/5] parallels: Add duplication check, repair at open, fix bugs

2023-06-21 Thread Alexander Ivanov
Fix incorrect data end calculation in parallels_open(). Check if data_end greater than the file size. Add change_info argument to parallels_check_leak(). Add checking and repairing duplicate offsets in BAT Image repairing in parallels_open(). v6: 2: Different patch. Refused to split image leak

[PATCH v6 5/5] parallels: Image repairing in parallels_open()

2023-06-21 Thread Alexander Ivanov
Repair an image at opening if the image is unclean or out-of-image corruption was detected. Signed-off-by: Alexander Ivanov --- block/parallels.c | 65 +++ 1 file changed, 38 insertions(+), 27 deletions(-) diff --git a/block/parallels.c b/block/parall

Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

2023-06-21 Thread Gerd Hoffmann
On Tue, Jun 20, 2023 at 01:26:15PM +0100, Robert Beckett wrote: > > On 20/06/2023 10:41, Gerd Hoffmann wrote: > >Hi, > > > > > > The guest driver should be able to restore resources after resume. > > > Thank you for your suggestion! > > > As far as I know, resources are created on host side a

[PATCH v4 04/24] q800: rename q800_init() to q800_machine_init()

2023-06-21 Thread Mark Cave-Ayland
This will enable us later to distinguish between QOM initialisation and machine initialisation. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- hw/m68k/q800.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/m68k/q8

[PATCH v4 14/24] hw/net/dp8393x.c: move TYPE_DP8393X and dp8393xState into dp8393x.h

2023-06-21 Thread Mark Cave-Ayland
This is to enable them to be used outside of dp8393x.c. Signed-off-by: Mark Cave-Ayland CC: Jason Wang Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- hw/net/dp8393x.c | 32 + include/hw/net/dp8393x.h | 60 +++

[PATCH v4 02/24] q800: add missing space after parent object in GLUEState

2023-06-21 Thread Mark Cave-Ayland
This brings GLUEState in line with our current QOM guidelines. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/m68k/q800.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c index dda57c60bf..465c510c18 100

[PATCH v4 00/24] q800: add support for booting MacOS Classic - part 1

2023-06-21 Thread Mark Cave-Ayland
[MCA: the original series has now been split into 2 separate parts based upon Phil's comments re: QOM parenting for objects in Q800MachineState. Part 1 consists of the Q800MachineState patches along with QOM parenting fixes and the 2 mac_via RTC patches.] This series contains the remaining patches

[PATCH v4 16/24] q800: move ESCC device to Q800MachineState

2023-06-21 Thread Mark Cave-Ayland
Also change the instantiation of the ESCC device to use object_initialize_child(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/m68k/q800.c | 6 -- include/hw/m68k/q800.h | 2 ++ 2 files changed, 6 insertions(+), 2 deletion

[PATCH v4 01/24] q800: fix up minor spacing issues in hw_compat_q800 GlobalProperty array

2023-06-21 Thread Mark Cave-Ayland
Ensure there is a space before the final closing brace for all global properties. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- hw/m68k/q800.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/m68k/q800.c b/h

[PATCH v4 06/24] q800: move ROM memory region to Q800MachineState

2023-06-21 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/m68k/q800.c | 13 + include/hw/m68k/q800.h | 2 ++ 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c index 2b651de3c1..9f9668c

[PATCH v4 07/24] q800: move GLUE device into separate q800-glue.c file

2023-06-21 Thread Mark Cave-Ayland
This will allow the q800-glue.h header to be included separately so that the GLUE device can be referenced externally. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier --- MAINTAINERS | 2 + hw/m68k/meson.build | 2 +- hw/m68k/q800-glue.c | 252 +++

Re: 'make check-tcg' fails with an assert in qemu_plugin_vcpu_init_hook

2023-06-21 Thread Peter Maydell
On Wed, 21 Jun 2023 at 09:05, Alex Bennée wrote: > > > Peter Maydell writes: > > > On Tue, 20 Jun 2023 at 17:56, Peter Maydell > > wrote: > >> > >> $ make -C build/x86 check-tcg > >> make: Entering directory > >> '/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/x86' > >> [...] > >> TEST

[PATCH v4 15/24] q800: move dp8393x device to Q800MachineState

2023-06-21 Thread Mark Cave-Ayland
Also change the instantiation of the dp8393x device to use object_initialize_child(). Signed-off-by: Mark Cave-Ayland CC: Jason Wang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/m68k/q800.c | 6 -- include/hw/m68k/q800.h | 2 ++ 2 files changed, 6 insert

[PATCH v4 03/24] q800: introduce Q800MachineState

2023-06-21 Thread Mark Cave-Ayland
This provides an overall container and owner for Machine-related objects such as MemoryRegions. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS| 1 + hw/m68k/q800.c | 2 ++ include/hw/m68k/q800.h | 40 +++

[PATCH v4 22/24] q800: move macfb device to Q800MachineState

2023-06-21 Thread Mark Cave-Ayland
Also change the instantiation of the macfb device to use object_initialize_child(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/m68k/q800.c | 6 -- include/hw/m68k/q800.h | 2 ++ 2 files changed, 6 insertions(+), 2 deletio

[PATCH v4 05/24] q800: move CPU object into Q800MachineState

2023-06-21 Thread Mark Cave-Ayland
Also change the instantiation of the CPU to use object_initialize_child() followed by a separate realisation. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- hw/m68k/q800.c | 18 +- include/hw/m68k/q800.h | 3 +++ 2 f

[PATCH v4 11/24] q800: reimplement mac-io region aliasing using IO memory region

2023-06-21 Thread Mark Cave-Ayland
The current use of aliased memory regions causes us 2 problems: firstly the output of "info qom-tree" is absolutely huge and difficult to read, and secondly we have already reached the internal limit for memory regions as adding any new memory region into the mac-io region causes QEMU to assert wit

[PATCH v4 21/24] q800: don't access Nubus bus directly from the mac-nubus-bridge device

2023-06-21 Thread Mark Cave-Ayland
Instead use the qdev_get_child_bus() function which is intended for this exact purpose. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- hw/m68k/q800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/m68k/q800.c b/hw/m68

[PATCH v4 09/24] q800: move GLUE device to Q800MachineState

2023-06-21 Thread Mark Cave-Ayland
Also change the instantiation of the GLUE device to use object_initialize_child(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/m68k/q800.c | 24 ++-- include/hw/m68k/q800.h | 2 ++ 2 files changed, 16 inse

[PATCH v4 08/24] q800-glue.c: switch TypeInfo registration to use DEFINE_TYPES() macro

2023-06-21 Thread Mark Cave-Ayland
The use of the DEFINE_TYPES() macro will soon be recommended over the use of calling type_init() directly. Signed-off-by: Mark Cave-Ayland --- hw/m68k/q800-glue.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/hw/m68k/q800-glue.c b/hw/m68k/q80

[PATCH v4 10/24] q800: introduce mac-io container memory region

2023-06-21 Thread Mark Cave-Ayland
Move all devices from the IO region to within the container in preparation for updating the IO aliasing mechanism. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- hw/m68k/q800.c | 6 ++ include/hw/m68k/q800.h | 1 + 2 files change

[PATCH v4 20/24] q800: move mac-nubus-bridge device to Q800MachineState

2023-06-21 Thread Mark Cave-Ayland
Also change the instantiation of the mac-nubus-bridge device to use object_initialize_child() and map the Nubus address space using memory_region_add_subregion() instead of sysbus_mmio_map(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé --- hw

[PATCH v4 18/24] q800: move ESP device to Q800MachineState

2023-06-21 Thread Mark Cave-Ayland
Also change the instantiation of the ESP device to use object_initialize_child(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/m68k/q800.c | 9 + include/hw/m68k/q800.h | 2 ++ 2 files changed, 7 insertions(+), 4 deleti

[PATCH v4 13/24] q800: move VIA2 device to Q800MachineState

2023-06-21 Thread Mark Cave-Ayland
Also change the instantiation of the VIA2 device to use object_initialize_child(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/m68k/q800.c | 27 --- include/hw/m68k/q800.h | 1 + 2 files changed, 17 in

[PATCH v4 23/24] mac_via: fix rtc command decoding from PRAM addresses 0x0 to 0xf

2023-06-21 Thread Mark Cave-Ayland
A comparison between the rtc command table included in the comment and the code itself shows that the decoding for PRAM addresses 0x0 to 0xf is being done on the raw command, and not the shifted version held in value. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier --- hw/misc/mac_v

[PATCH v4 17/24] q800: move escc_orgate device to Q800MachineState

2023-06-21 Thread Mark Cave-Ayland
Also change the instantiation of the escc_orgate device to use object_initialize_child(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/m68k/q800.c | 16 +--- include/hw/m68k/q800.h | 2 ++ 2 files changed, 11 inser

[PATCH v4 12/24] q800: move VIA1 device to Q800MachineState

2023-06-21 Thread Mark Cave-Ayland
Also change the instantiation of the VIA1 device to use object_initialize_child(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/m68k/q800.c | 16 +--- include/hw/m68k/q800.h | 2 ++ 2 files changed, 11 insertions(+

[PATCH v4 24/24] mac_via: fix rtc command decoding for the PRAM seconds registers

2023-06-21 Thread Mark Cave-Ayland
Analysis of the MacOS toolbox ROM code shows that on startup it attempts 2 separate reads of the seconds registers with commands 0x9d...0x91 followed by 0x8d..0x81 without resetting the command to its initial value. The PRAM seconds value is only accepted when the values of the 2 separate reads mat

[PATCH v4 19/24] q800: move SWIM device to Q800MachineState

2023-06-21 Thread Mark Cave-Ayland
Also change the instantiation of the SWIM device to use object_initialize_child(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier --- hw/m68k/q800.c | 8 +--- include/hw/m68k/q800.h | 2 ++ 2 files changed, 7 insertions(+), 3 deleti

Re: [RFC PATCH 00/19] hugetlb support for KVM guest_mem

2023-06-21 Thread Vishal Annapurve
On Fri, Jun 16, 2023 at 11:28 AM Mike Kravetz wrote: > > On 06/06/23 19:03, Ackerley Tng wrote: > > Hello, > > > > This patchset builds upon a soon-to-be-published WIP patchset that Sean > > published at https://github.com/sean-jc/linux/tree/x86/kvm_gmem_solo, > > mentioned > > at [1]. > > > > Th

Re: [PATCH] target/ppc: Add ISA v3.1 LEV indication in SRR1 for system call interrupts

2023-06-21 Thread Harsh Prateek Bora
On 6/20/23 18:43, Nicholas Piggin wrote: System call interrupts in ISA v3.1 CPUs add a LEV indication in SRR1 that corresponds with the LEV field of the instruction that caused the interrupt. Did we encounter any issue without this patch leading to this fix? If so, it will be great to talk

Re: [PATCH 0/4] fpu: Add float64_to_int{32,64}_modulo

2023-06-21 Thread Richard Henderson
On 5/27/23 16:19, Richard Henderson wrote: Extract some common code from Alpha and Arm, and which will shortly also be required by the RISC-V Zfa extension. Added a new test for Alpha; I already had a RISU test for Arm. r~ Richard Henderson (4): fpu: Add float64_to_int{32,64}_modulo tes

Re: [PATCH 2/2] tpm_crb: mark memory as protected

2023-06-21 Thread David Hildenbrand
On 20.06.23 21:50, Laurent Vivier wrote: This memory is not correctly aligned and cannot be registered by vDPA and VFIO. An error is reported for vhost-vdpa case: qemu-kvm: vhost_vdpa_listener_region_add received unaligned region To make it ignored by VFIO and vDPA devices, mark it as RAM_PROTE

Re: [PATCH v2 15/18] target/riscv: make riscv_isa_string_ext() KVM compatible

2023-06-21 Thread Andrew Jones
On Wed, Jun 21, 2023 at 10:20:37AM +0200, Andrew Jones wrote: > On Tue, Jun 20, 2023 at 07:05:18PM -0300, Daniel Henrique Barboza wrote: > > > > > > On 6/19/23 06:54, Andrew Jones wrote: > > > On Tue, Jun 13, 2023 at 05:58:54PM -0300, Daniel Henrique Barboza wrote: > > > > The isa_edata_arr[] is

Re: [PATCH for-8.1] target/sparc: Use tcg_gen_lookup_and_goto_ptr

2023-06-21 Thread Mark Cave-Ayland
On 19/06/2023 16:41, Richard Henderson wrote: On 5/11/23 13:02, Richard Henderson wrote: On 5/11/23 09:40, Mark Cave-Ayland wrote: Obviously nothing notionally against this patch, however if you could give me a few days to run my OpenBIOS SPARC32/SPARC64 boot tests against git master with thi

[PATCH v2] tests/plugin: Remove duplicate insn log from libinsn.so

2023-06-21 Thread Richard Henderson
This is a perfectly natural occurrence for x86 "rep movb", where the "rep" prefix forms a counted loop of the one insn. During the tests/tcg/multiarch/memory test, this logging is triggered over 35 times. Within the context of cross-i386-tci build, which is already slow by nature, the logging

Re: [PATCH v1 01/46] target/loongarch: Add LASX data type XReg

2023-06-21 Thread Song Gao
Hi, Richard 在 2023/6/20 下午8:09, Richard Henderson 写道: On 6/20/23 11:37, Song Gao wrote: diff --git a/target/loongarch/cpu.h b/target/loongarch/cpu.h index b23f38c3d5..347950b4d0 100644 --- a/target/loongarch/cpu.h +++ b/target/loongarch/cpu.h @@ -259,9 +259,23 @@ typedef union VReg {   Int1

Re: [PATCH v1 04/46] target/loongarch: Implement xvadd/xvsub

2023-06-21 Thread Song Gao
在 2023/6/20 下午8:25, Richard Henderson 写道: On 6/20/23 11:37, Song Gao wrote: +static bool gvec_xxx(DisasContext *ctx, arg_xxx *a, MemOp mop, + void (*func)(unsigned, uint32_t, uint32_t, +  uint32_t, uint32_t, uint32_t)) +{ +    uint32_t xd_of

Re: [PATCH QEMU v6 6/9] migration: Put the detection logic before auto-converge checking

2023-06-21 Thread Juan Quintela
~hyman wrote: > From: Hyman Huang(黄勇) > > This commit is prepared for the implementation of dirty-limit > convergence algo. > > The detection logic of throttling condition can apply to both > auto-converge and dirty-limit algo, putting it's position > before the checking logic for auto-converge f

Re: [PATCH v1 04/46] target/loongarch: Implement xvadd/xvsub

2023-06-21 Thread Richard Henderson
On 6/21/23 11:19, Song Gao wrote: 在 2023/6/20 下午8:25, Richard Henderson 写道: On 6/20/23 11:37, Song Gao wrote: +static bool gvec_xxx(DisasContext *ctx, arg_xxx *a, MemOp mop, + void (*func)(unsigned, uint32_t, uint32_t, +  uint32_t, uint32_t,

Re: [PATCH QEMU v6 8/9] migration: Extend query-migrate to provide dirty page limit info

2023-06-21 Thread Juan Quintela
~hyman wrote: > From: Hyman Huang(黄勇) > > Extend query-migrate to provide throttle time and estimated > ring full time with dirty-limit capability enabled, through which > we can observe if dirty limit take effect during live migration. > > Signed-off-by: Hyman Huang(黄勇) > Signed-off-by: Markus

Re: [PATCH] Revert "cputlb: Restrict SavedIOTLB to system emulation"

2023-06-21 Thread Philippe Mathieu-Daudé
On 21/6/23 07:19, Richard Henderson wrote: On 6/20/23 19:57, Peter Maydell wrote: This reverts commit d7ee93e24359703debf4137f4cc632563aa4e8d1. That commit tries to make a field in the CPUState struct not be present when CONFIG_USER_ONLY is set.  Unfortunately, you can't conditionally omit fiel

Re: [PATCH 03/42] migration-test: simplify shmem_opts handling

2023-06-21 Thread Juan Quintela
Peter Xu wrote: > On Fri, Jun 09, 2023 at 12:49:04AM +0200, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> tests/qtest/migration-test.c | 9 - >> 1 file changed, 4 insertions(+), 5 deletions(-) >> >> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.

Re: [PATCH v4 00/24] q800: add support for booting MacOS Classic - part 1

2023-06-21 Thread Philippe Mathieu-Daudé
On 21/6/23 10:53, Mark Cave-Ayland wrote: [MCA: the original series has now been split into 2 separate parts based upon Phil's comments re: QOM parenting for objects in Q800MachineState. Part 1 consists of the Q800MachineState patches along with QOM parenting fixes and the 2 mac_via RTC patches.]

Re: [PATCH v2 15/18] target/riscv: make riscv_isa_string_ext() KVM compatible

2023-06-21 Thread Daniel Henrique Barboza
On 6/21/23 05:20, Andrew Jones wrote: On Tue, Jun 20, 2023 at 07:05:18PM -0300, Daniel Henrique Barboza wrote: On 6/19/23 06:54, Andrew Jones wrote: On Tue, Jun 13, 2023 at 05:58:54PM -0300, Daniel Henrique Barboza wrote: The isa_edata_arr[] is used by riscv_isa_string_ext() to create the

Re: [PATCH v4 08/24] q800-glue.c: switch TypeInfo registration to use DEFINE_TYPES() macro

2023-06-21 Thread Philippe Mathieu-Daudé
On 21/6/23 10:53, Mark Cave-Ayland wrote: The use of the DEFINE_TYPES() macro will soon be recommended over the use of calling type_init() directly. Signed-off-by: Mark Cave-Ayland --- hw/m68k/q800-glue.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-)

Re: [PATCH v4 07/24] q800: move GLUE device into separate q800-glue.c file

2023-06-21 Thread Philippe Mathieu-Daudé
On 21/6/23 10:53, Mark Cave-Ayland wrote: This will allow the q800-glue.h header to be included separately so that the GLUE device can be referenced externally. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier --- MAINTAINERS | 2 + hw/m68k/meson.build |

Re: 'make check-tcg' fails with an assert in qemu_plugin_vcpu_init_hook

2023-06-21 Thread Philippe Mathieu-Daudé
On 21/6/23 10:53, Peter Maydell wrote: On Wed, 21 Jun 2023 at 09:05, Alex Bennée wrote: Peter Maydell writes: On Tue, 20 Jun 2023 at 17:56, Peter Maydell wrote: $ make -C build/x86 check-tcg make: Entering directory '/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/x86' [...] TEST

Re: [PATCH v1 04/46] target/loongarch: Implement xvadd/xvsub

2023-06-21 Thread Song Gao
在 2023/6/21 下午5:27, Richard Henderson 写道: On 6/21/23 11:19, Song Gao wrote: 在 2023/6/20 下午8:25, Richard Henderson 写道: On 6/20/23 11:37, Song Gao wrote: +static bool gvec_xxx(DisasContext *ctx, arg_xxx *a, MemOp mop, + void (*func)(unsigned, uint32_t, uint32_t, +   

Re: [PATCH 11/42] migration-test: Update test_ignore_shared to use args

2023-06-21 Thread Juan Quintela
Peter Xu wrote: > On Fri, Jun 09, 2023 at 12:49:12AM +0200, Juan Quintela wrote: >> It missed this treatment: >> >> commit 11f1a4ce14803f15d59cff42a4cfb7ac50d36bd0 >> Author: Juan Quintela >> Date: Mon Nov 29 18:57:51 2021 +0100 >> >> migration-test: Check for shared memory like for every

Re: 'make check-tcg' fails with an assert in qemu_plugin_vcpu_init_hook

2023-06-21 Thread Alex Bennée
Peter Maydell writes: > On Wed, 21 Jun 2023 at 09:05, Alex Bennée wrote: >> >> >> Peter Maydell writes: >> >> > On Tue, 20 Jun 2023 at 17:56, Peter Maydell >> > wrote: >> >> >> >> $ make -C build/x86 check-tcg >> >> make: Entering directory >> >> '/mnt/nvmedisk/linaro/qemu-from-laptop/qemu

Re: [PATCH 13/42] migration-test: Check for shared memory like for everything else

2023-06-21 Thread Juan Quintela
Peter Xu wrote: > On Fri, Jun 09, 2023 at 12:49:14AM +0200, Juan Quintela wrote: >> Makes things easier and cleaner. >> >> Signed-off-by: Juan Quintela >> --- >> tests/qtest/migration-test.c | 20 >> 1 file changed, 12 insertions(+), 8 deletions(-) >> >> diff --git a/tests

Re: [PATCH] target/ppc: Add ISA v3.1 LEV indication in SRR1 for system call interrupts

2023-06-21 Thread Nicholas Piggin
On Wed Jun 21, 2023 at 6:31 PM AEST, Harsh Prateek Bora wrote: > > > On 6/20/23 18:43, Nicholas Piggin wrote: > > System call interrupts in ISA v3.1 CPUs add a LEV indication in SRR1 > > that corresponds with the LEV field of the instruction that caused the > > interrupt. > > > > Did we encounter

Re: [PATCH v2] tests/plugin: Remove duplicate insn log from libinsn.so

2023-06-21 Thread Alex Bennée
Richard Henderson writes: > This is a perfectly natural occurrence for x86 "rep movb", > where the "rep" prefix forms a counted loop of the one insn. > > During the tests/tcg/multiarch/memory test, this logging is > triggered over 35 times. Within the context of cross-i386-tci > build, whi

[PATCH v2 2/4] hw/virtio: Add vhost-user-scmi-pci boilerplate

2023-06-21 Thread Milan Zamazal
This allows is to instantiate a vhost-user-scmi device as part of a PCI bus. It is mostly boilerplate similar to the other vhost-user-*-pci boilerplates of similar devices. Signed-off-by: Milan Zamazal --- hw/virtio/meson.build | 1 + hw/virtio/vhost-user-scmi-pci.c | 68 +

[PATCH v2 0/4] Add SCMI vhost-user VIRTIO device

2023-06-21 Thread Milan Zamazal
This patch series adds a vhost-user VIRTIO device for SCMI. It's similar to other similar vhost-user VIRTIO devices. I'm aware of the work in progress by Alex Bennée to simplify similar devices and avoid excessive code duplication. I think the SCMI device support doesn't bring anything special an

[PATCH v2 3/4] tests/qtest: Fix a comment typo in vhost-user-test.c

2023-06-21 Thread Milan Zamazal
Signed-off-by: Milan Zamazal Reviewed-by: Thomas Huth --- tests/qtest/vhost-user-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c index e4f95b2858..dfb8003597 100644 --- a/tests/qtest/vhost-user-test.c +++ b/

  1   2   3   4   5   >