Re: [PATCH v14 08/10] Adding info [tb-list|tb] commands to HMP (WIP)

2023-06-06 Thread Wu, Fei
On 6/1/2023 8:12 PM, Wu, Fei wrote: > On 6/1/2023 10:40 AM, Richard Henderson wrote: >> On 5/30/23 01:35, Fei Wu wrote: >>> +static void do_dump_tbs_info(int total, int sort_by) >>> +{ >>> +    id = 1; >>> +    GList *i; >>> +    int count = total; >>> + >>> +    g_list_free(last_search); >>> +   

Re: [PATCH v4 2/3] hw/i386/pc: Default to use SMBIOS 3.0 for newer machine models

2023-06-06 Thread Igor Mammedov
On Mon, 5 Jun 2023 16:39:05 -0500 Suravee Suthikulpanit wrote: > Currently, pc-q35 and pc-i44fx machine models are default to use SMBIOS 2.8 > (32-bit entry point). Since SMBIOS 3.0 (64-bit entry point) is now fully > supported since QEMU 7.0, default to use SMBIOS 3.0 for newer machine > models.

Re: [PATCH v4 1/3] hw/i386/pc: Refactor logic to set SMBIOS set defaults

2023-06-06 Thread Igor Mammedov
On Mon, 5 Jun 2023 16:39:04 -0500 Suravee Suthikulpanit wrote: > In preparation for subsequent code to upgrade default SMBIOS > entry point type. There is no functional change. > > Signed-off-by: Suravee Suthikulpanit > --- > hw/i386/pc.c | 12 > hw/i386/pc_piix.c | 9 --

Re: [PATCH v4 3/3] pc: q35: Bump max_cpus to 1024

2023-06-06 Thread Igor Mammedov
On Mon, 5 Jun 2023 16:39:06 -0500 Suravee Suthikulpanit wrote: > Since KVM_MAX_VCPUS is currently defined to 1024 for x86 as shown in > arch/x86/include/asm/kvm_host.h, update QEMU limits to the same number. > > In case KVM could not support the specified number of vcpus, QEMU would > return the

Re: [PULL 02/17] block: Collapse padded I/O vecs exceeding IOV_MAX

2023-06-06 Thread Michael Tokarev
05.06.2023 18:45, Hanna Czenczek wrote: When processing vectored guest requests that are not aligned to the storage request alignment, we pad them by adding head and/or tail buffers for a read-modify-write cycle. The guest can submit I/O vectors up to IOV_MAX (1024) in length, but with this padd

Re: [PATCH v4 2/3] hw/i386/pc: Default to use SMBIOS 3.0 for newer machine models

2023-06-06 Thread Igor Mammedov
On Tue, 6 Jun 2023 09:35:41 +0200 Igor Mammedov wrote: > On Mon, 5 Jun 2023 16:39:05 -0500 > Suravee Suthikulpanit wrote: [...] > > +/* For pc-i44fx-8.0 and older, use SMBIOS 2.8 by default */ > > +pcmc->default_smbios_ep_type = SMBIOS_ENTRY_POINT_TYPE_32; > > } [...] > > static void p

[PATCH] mkvenv: always pass locally-installed packages to pip

2023-06-06 Thread Paolo Bonzini
Let pip decide whether a new version should be installed or the current one is okay. This ensures that the virtual environment is updated (either upgraded or downgraded) whenever a new version of a package is requested. The hardest part here is figuring out if a package is installed in the venv (

[PATCH] target/riscv/vector_helper.c: Remove the check for extra tail elements

2023-06-06 Thread Xiao Wang
Commit 752614cab8e6 ("target/riscv: rvv: Add tail agnostic for vector load / store instructions") added an extra check for LMUL fragmentation, intended for setting the "rest tail elements" in the last register for a segment load insn. Actually, the max_elements derived in vext_ld*() won't be a fra

Re: [PULL 02/17] block: Collapse padded I/O vecs exceeding IOV_MAX

2023-06-06 Thread Hanna Czenczek
On 06.06.23 10:00, Michael Tokarev wrote: 05.06.2023 18:45, Hanna Czenczek wrote: When processing vectored guest requests that are not aligned to the storage request alignment, we pad them by adding head and/or tail buffers for a read-modify-write cycle. The guest can submit I/O vectors up to I

Re: [PATCH v2 3/5] qemu/uri: Use QueryParams type definition

2023-06-06 Thread Peter Maydell
On Mon, 5 Jun 2023 at 18:57, Philippe Mathieu-Daudé wrote: > > Follow QEMU CODING_STYLE, use the type definition. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/qemu/uri.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/qemu/uri.h b/include/qemu/uri.h

Re: [PATCH v2 4/5] bulk: Do not declare function prototypes using 'extern' keyword

2023-06-06 Thread Peter Maydell
On Mon, 5 Jun 2023 at 18:58, Philippe Mathieu-Daudé wrote: > > By default, C function prototypes declared in headers are visible, > so there is no need to declare them as 'extern' functions. > Remove this redundancy in a single bulk commit; do not modify: > > - meson.build (used to check functio

Re: [PATCH v3 1/1] hw/arm/sbsa-ref: use XHCI to replace EHCI

2023-06-06 Thread Marcin Juszkiewicz
W dniu 5.06.2023 o 11:55, Yuquan Wang pisze: The current sbsa-ref cannot use EHCI controller which is only able to do 32-bit DMA, since sbsa-ref doesn't have RAM below 4GB. Hence, this uses XHCI to provide a usb controller with 64-bit DMA capablity instead of EHCI. Signed-off-by: Yuquan Wang R

[PULL 09/42] hw: arm: Add bananapi M2-Ultra and allwinner-r40 support

2023-06-06 Thread Peter Maydell
From: qianfan Zhao Allwinner R40 (sun8i) SoC features a Quad-Core Cortex-A7 ARM CPU, and a Mali400 MP2 GPU from ARM. It's also known as the Allwinner T3 for In-Car Entertainment usage, A40i and A40pro are variants that differ in applicable temperatures range (industrial and military). Signed-off

[PULL 14/42] hw/arm/allwinner-r40: add SDRAM controller device

2023-06-06 Thread Peter Maydell
From: qianfan Zhao Types of memory that the SDRAM controller supports are DDR2/DDR3 and capacities of up to 2GiB. This commit adds emulation support of the Allwinner R40 SDRAM controller. This driver only support 256M, 512M and 1024M memory now. Signed-off-by: qianfan Zhao Signed-off-by: Peter

[PULL 25/42] target/arm: Use tcg_gen_qemu_st_i128 for STZG, STZ2G

2023-06-06 Thread Peter Maydell
From: Richard Henderson This fixes a bug in that these two insns should have been using atomic 16-byte stores, since MTE is ARMv8.5 and LSE2 is mandatory from ARMv8.4. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-7-richard.hender...@linaro.org S

[PULL 06/42] xlnx-versal: Connect Xilinx VERSAL CANFD controllers

2023-06-06 Thread Peter Maydell
From: Vikram Garhwal Connect CANFD0 and CANFD1 on the Versal-virt machine and update xlnx-versal-virt document with CANFD command line examples. Signed-off-by: Vikram Garhwal Reviewed-by: Peter Maydell Reviewed-by: Francisco Iglesias Signed-off-by: Peter Maydell --- docs/system/arm/xlnx-ver

[PULL 31/42] target/arm: Pass memop to gen_mte_check1*

2023-06-06 Thread Peter Maydell
From: Richard Henderson Pass the completed memop to gen_mte_check1_mmuidx. For the moment, do nothing more than extract the size. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-13-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- tar

[PULL 15/42] hw: sd: allwinner-sdhost: Add sun50i-a64 SoC support

2023-06-06 Thread Peter Maydell
From: qianfan Zhao A64's sd register was similar to H3, and it introduced a new register named SAMP_DL_REG location at 0x144. The dma descriptor buffer size of mmc2 is only 8K and the other mmc controllers has 64K. Also fix allwinner-r40's mmc controller type. Signed-off-by: qianfan Zhao Signe

[PULL 24/42] target/arm: Use tcg_gen_qemu_{st, ld}_i128 for do_fp_{st, ld}

2023-06-06 Thread Peter Maydell
From: Richard Henderson While we don't require 16-byte atomicity here, using a single larger operation simplifies the code. Introduce finalize_memop_asimd for this. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-6-richard.hender...@linaro.org Sig

[PULL 03/42] hvf: add breakpoint handlers

2023-06-06 Thread Peter Maydell
From: Francesco Cagnin Required for guest debugging. The code has been structured like the KVM counterpart. Signed-off-by: Francesco Cagnin Message-id: 20230601153107.81955-4-fcag...@quarkslab.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- include/sysemu/hvf.h | 22 +++

[PULL 17/42] hw: arm: allwinner-sramc: Add SRAM Controller support for R40

2023-06-06 Thread Peter Maydell
From: qianfan Zhao Only a few important registers are added, especially the SRAM_VER register. Signed-off-by: qianfan Zhao Reviewed-by: Niek Linnenbank Signed-off-by: Peter Maydell --- include/hw/arm/allwinner-r40.h| 3 + include/hw/misc/allwinner-sramc.h | 69 +++ hw/arm/allw

[PULL 02/42] hvf: handle access for more registers

2023-06-06 Thread Peter Maydell
From: Francesco Cagnin Required for guest debugging. Signed-off-by: Francesco Cagnin Message-id: 20230601153107.81955-3-fcag...@quarkslab.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/hvf/hvf.c | 213 +++ 1 file changed, 21

[PULL 29/42] target/arm: Hoist finalize_memop out of do_gpr_{ld, st}

2023-06-06 Thread Peter Maydell
From: Richard Henderson We are going to need the complete memop beforehand, so let's not compute it twice. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-11-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/translate-a

[PULL 00/42] target-arm queue

2023-06-06 Thread Peter Maydell
5 13:16:56 -0700) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20230606 for you to fetch changes up to f9ac778898cb28307e0f91421aba34d43c34b679: target/arm: trap DCC access in user mode emulation (2023-06-06 10:1

[PULL 30/42] target/arm: Hoist finalize_memop out of do_fp_{ld, st}

2023-06-06 Thread Peter Maydell
From: Richard Henderson We are going to need the complete memop beforehand, so let's not compute it twice. Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-12-richard.hender...@linaro.org Signed-off-by: Peter May

[PULL 27/42] target/arm: Sink gen_mte_check1 into load/store_exclusive

2023-06-06 Thread Peter Maydell
From: Richard Henderson No need to duplicate this check across multiple call sites. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-9-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/translate-a64.c | 44 ++

[PULL 16/42] hw: arm: allwinner-r40: Add emac and gmac support

2023-06-06 Thread Peter Maydell
From: qianfan Zhao R40 has two ethernet controllers named as emac and gmac. The emac is compatibled with A10, and the GMAC is compatibled with H3. Signed-off-by: qianfan Zhao Signed-off-by: Peter Maydell --- include/hw/arm/allwinner-r40.h | 6 hw/arm/allwinner-r40.c | 50 +++

[PULL 11/42] hw: allwinner-r40: Complete uart devices

2023-06-06 Thread Peter Maydell
From: qianfan Zhao R40 has eight UARTs, support both 16450 and 16550 compatible modes. Signed-off-by: qianfan Zhao Signed-off-by: Peter Maydell --- include/hw/arm/allwinner-r40.h | 8 hw/arm/allwinner-r40.c | 34 +++--- 2 files changed, 39 inserti

[PULL 42/42] target/arm: trap DCC access in user mode emulation

2023-06-06 Thread Peter Maydell
From: Zhuojia Shen Accessing EL0-accessible Debug Communication Channel (DCC) registers in user mode emulation is currently enabled. However, it does not match Linux behavior as Linux sets MDSCR_EL1.TDCC on startup to disable EL0 access to DCC (see __cpu_setup() in arch/arm64/mm/proc.S). This p

[PULL 41/42] tests/tcg/aarch64: add DC CVA[D]P tests

2023-06-06 Thread Peter Maydell
From: Zhuojia Shen Test execution of DC CVAP and DC CVADP instructions under user mode emulation. Signed-off-by: Zhuojia Shen Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson Signed-off-by: Peter Maydell --- tests/tcg/aarch64/dcpodp.c| 63 +++ te

[PULL 23/42] target/arm: Use tcg_gen_qemu_ld_i128 for LDXP

2023-06-06 Thread Peter Maydell
From: Richard Henderson While we don't require 16-byte atomicity here, using a single larger load simplifies the code, and makes it a closer match to STXP. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-5-richard.hender...@linaro.org Signed-off-by

[PULL 13/42] hw/misc: Rename axp209 to axp22x and add support AXP221 PMU

2023-06-06 Thread Peter Maydell
From: qianfan Zhao This patch adds minimal support for AXP-221 PMU and connect it to bananapi M2U board. Signed-off-by: qianfan Zhao Signed-off-by: Peter Maydell --- hw/arm/bananapi_m2u.c | 6 + hw/misc/axp209.c | 238 --- hw/misc/axp2xx.c | 283 +++

[PULL 10/42] hw/arm/allwinner-r40: add Clock Control Unit

2023-06-06 Thread Peter Maydell
From: qianfan Zhao The CCU provides the registers to program the PLLs and the controls most of the clock generation, division, distribution, synchronization and gating. This commit adds support for the Clock Control Unit which emulates a simple read/write register interface. Signed-off-by: qian

[PULL 22/42] target/arm: Introduce finalize_memop_{atom,pair}

2023-06-06 Thread Peter Maydell
From: Richard Henderson Let finalize_memop_atom be the new basic function, with finalize_memop and finalize_memop_pair testing FEAT_LSE2 to apply the appropriate atomicity. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 202305301914

[PULL 37/42] tests/tcg/aarch64: Use stz2g in mte-7.c

2023-06-06 Thread Peter Maydell
From: Richard Henderson We have many other instances of stg in the testsuite; change these to provide an instance of stz2g. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-19-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- tests/tcg

[PULL 36/42] target/arm: Move mte check for store-exclusive

2023-06-06 Thread Peter Maydell
From: Richard Henderson Push the mte check behind the exclusive_addr check. Document the several ways that we are still out of spec with this implementation. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-18-richard.hender...@linaro.org Signed-off

[PULL 05/42] hw/net/can: Introduce Xilinx Versal CANFD controller

2023-06-06 Thread Peter Maydell
From: Vikram Garhwal The Xilinx Versal CANFD controller is developed based on SocketCAN, QEMU CAN bus implementation. Bus connection and socketCAN connection for each CAN module can be set through command lines. Signed-off-by: Vikram Garhwal Reviewed-by: Francisco Iglesias Signed-off-by: Peter

[PULL 04/42] hvf: add guest debugging handlers for Apple Silicon hosts

2023-06-06 Thread Peter Maydell
From: Francesco Cagnin Guests can now be debugged through the gdbstub. Support is added for single-stepping, software breakpoints, hardware breakpoints and watchpoints. The code has been structured like the KVM counterpart. While guest debugging is enabled, the guest can still read and write the

[PULL 26/42] target/arm: Use tcg_gen_qemu_{ld, st}_i128 in gen_sve_{ld, st}r

2023-06-06 Thread Peter Maydell
From: Richard Henderson Round len_align to 16 instead of 8, handling an odd 8-byte as part of the tail. Use MO_ATOM_NONE to indicate that all of these memory ops have only byte atomicity. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-8-richard.h

[PULL 01/42] arm: move KVM breakpoints helpers

2023-06-06 Thread Peter Maydell
From: Francesco Cagnin These helpers will be also used for HVF. Aside from reformatting a couple of comments for 'checkpatch.pl' and updating meson to compile 'hyp_gdbstub.c', this is just code motion. Signed-off-by: Francesco Cagnin Reviewed-by: Alex Bennée Reviewed-by: Peter Maydell Message

[PULL 38/42] tests/tcg/multiarch: Adjust sigbus.c

2023-06-06 Thread Peter Maydell
From: Richard Henderson With -cpu max and FEAT_LSE2, the __aarch64__ section will only raise an alignment exception when the load crosses a 16-byte boundary. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-20-richard.hender...@linaro.org Signed-off

[PULL 35/42] target/arm: Relax ordered/atomic alignment checks for LSE2

2023-06-06 Thread Peter Maydell
From: Richard Henderson FEAT_LSE2 only requires that atomic operations not cross a 16-byte boundary. Ordered operations may be completely unaligned if SCTLR.nAA is set. Because this alignment check is so special, do it by hand. Make sure not to keep TCG temps live across the branch. Signed-off

[PULL 12/42] hw: arm: allwinner-r40: Add i2c0 device

2023-06-06 Thread Peter Maydell
From: qianfan Zhao TWI(i2c) is designed to be used as an interface between CPU host and the serial 2-Wire bus. It can support all standard 2-Wire transfer, can be operated in standard mode(100kbit/s) or fast-mode, supporting data rate up to 400kbit/s. Signed-off-by: qianfan Zhao Reviewed-by: Ni

[PULL 07/42] MAINTAINERS: Include canfd tests under Xilinx CAN

2023-06-06 Thread Peter Maydell
From: Vikram Garhwal Signed-off-by: Vikram Garhwal Reviewed-by: Peter Maydell Reviewed-by: Francisco Iglesias Signed-off-by: Peter Maydell --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 55668d63368..4b2639def6d 100644 --- a

[PULL 21/42] target/arm: Add feature test for FEAT_LSE2

2023-06-06 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-3-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/cpu.h | 5 + 1 file changed, 5 insertions(+) diff --git a/

[PULL 39/42] target/arm: Enable FEAT_LSE2 for -cpu max

2023-06-06 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-21-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- docs/system/arm/emulation.rst | 1 + target/arm/tcg/cpu64.c| 1 + 2 files changed, 2 insertions(+) di

[PULL 34/42] target/arm: Add SCTLR.nAA to TBFLAG_A64

2023-06-06 Thread Peter Maydell
From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-16-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/cpu.h | 3 ++- target/arm/tcg/translate.h | 2 ++ target/arm/tcg/hflags.c

[PULL 33/42] target/arm: Check alignment in helper_mte_check

2023-06-06 Thread Peter Maydell
From: Richard Henderson Fixes a bug in that with SCTLR.A set, we should raise any alignment fault before raising any MTE check fault. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-15-richard.hender...@linaro.org Signed-off-by: Peter Maydell ---

[PULL 28/42] target/arm: Load/store integer pair with one tcg operation

2023-06-06 Thread Peter Maydell
From: Richard Henderson This is required for LSE2, where the pair must be treated atomically if it does not cross a 16-byte boundary. But it simplifies the code to do this always. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-10-richard.hender..

[PULL 40/42] target/arm: allow DC CVA[D]P in user mode emulation

2023-06-06 Thread Peter Maydell
From: Zhuojia Shen DC CVAP and DC CVADP instructions can be executed in EL0 on Linux, either directly when SCTLR_EL1.UCI == 1 or emulated by the kernel (see user_cache_maint_handler() in arch/arm64/kernel/traps.c). This patch enables execution of the two instructions in user mode emulation. Sig

[PULL 19/42] docs: system: arm: Introduce bananapi_m2u

2023-06-06 Thread Peter Maydell
From: qianfan Zhao Add documents for Banana Pi M2U Signed-off-by: qianfan Zhao Reviewed-by: Niek Linnenbank [PMM: Minor format fixes to correct sphinx errors] Signed-off-by: Peter Maydell --- docs/system/arm/bananapi_m2u.rst | 139 +++ docs/system/target-arm.rst

[PULL 18/42] tests: avocado: boot_linux_console: Add test case for bpim2u

2023-06-06 Thread Peter Maydell
From: qianfan Zhao Add test case for booting from initrd and sd card. Signed-off-by: qianfan Zhao Reviewed-by: Niek Linnenbank Tested-by: Niek Linnenbank Signed-off-by: Peter Maydell --- tests/avocado/boot_linux_console.py | 176 1 file changed, 176 insertions(+

[PULL 32/42] target/arm: Pass single_memop to gen_mte_checkN

2023-06-06 Thread Peter Maydell
From: Richard Henderson Pass the individual memop to gen_mte_checkN. For the moment, do nothing with it. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-14-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/translate-a64

[PULL 08/42] tests/qtest: Introduce tests for Xilinx VERSAL CANFD controller

2023-06-06 Thread Peter Maydell
From: Vikram Garhwal The QTests perform three tests on the Xilinx VERSAL CANFD controller: Tests the CANFD controllers in loopback. Tests the CANFD controllers in normal mode with CAN frame. Tests the CANFD controllers in normal mode with CANFD frame. Signed-off-by: Vikram Garhwal A

[PULL 20/42] target/arm: Add commentary for CPUARMState.exclusive_high

2023-06-06 Thread Peter Maydell
From: Richard Henderson Document the meaning of exclusive_high in a big-endian context, and why we can't change it now. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20230530191438.411344-2-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/cpu

Re: [PATCH 05/10] meson: subprojects: replace submodules with wrap files

2023-06-06 Thread Daniel P . Berrangé
On Mon, Jun 05, 2023 at 11:52:18AM +0200, Paolo Bonzini wrote: > Compared to submodules, .wrap files have several advantages: > > * option parsing and downloading is delegated to meson > > * the commit is stored in a text file instead of a magic entry in the > git tree object > > * we could st

Re: [PATCH v3 0/3] Trivial cleanups

2023-06-06 Thread BALATON Zoltan
On Tue, 6 Jun 2023, Mark Cave-Ayland wrote: On 05/06/2023 07:58, Bernhard Beschow wrote: Am 1. Juni 2023 12:45:47 UTC schrieb Mark Cave-Ayland : On 01/06/2023 13:07, Michael S. Tsirkin wrote: On Thu, May 25, 2023 at 05:03:15PM +0100, Mark Cave-Ayland wrote: On 23/05/2023 20:56, Bernhard Besc

Re: [PATCH 06/10] configure: move SLOF submodule handling to pc-bios/s390-ccw

2023-06-06 Thread Daniel P . Berrangé
On Mon, Jun 05, 2023 at 11:52:19AM +0200, Paolo Bonzini wrote: > Move the handling of the roms/SLOF submodule out of the main Makefile, > since we are going to remove submodules from the build process of QEMU. > > Signed-off-by: Paolo Bonzini > --- > .gitlab-ci.d/buildtest-template.yml | 2 +- >

Re: [PATCH 07/10] pc-bios/s390-ccw: always build network bootloader

2023-06-06 Thread Daniel P . Berrangé
On Mon, Jun 05, 2023 at 11:52:20AM +0200, Paolo Bonzini wrote: > In the beginning, the network bootloader was considered experimental and > thus optional, but it is well established nowadays and configure always > checks for roms/SLOF before compiling pc-bios/s390-ccw. > > Therefore, it makes sens

Re: [PATCH 08/10] meson: subprojects: replace berkeley-{soft,test}float-3 with wraps

2023-06-06 Thread Daniel P . Berrangé
On Mon, Jun 05, 2023 at 11:52:21AM +0200, Paolo Bonzini wrote: > Unlike other subprojects, these require an overlay directory to include > meson rules to build the libraries. The rules are basically lifted > from tests/fp/meson.build, with a few changes to create platform.h > and publish a depende

Re: [PATCH 09/10] build: remove git submodule handling from main makefile

2023-06-06 Thread Daniel P . Berrangé
On Mon, Jun 05, 2023 at 11:52:22AM +0200, Paolo Bonzini wrote: > The only remaining user of submodules at build time is roms/SLOF, > which is handled in pc-bios/s390-ccw/Makefile. Remove the relevant > code from the main makefile. > > Signed-off-by: Paolo Bonzini > --- > .gitlab-ci.d/buildtest-

Re: [PATCH 10/10] configure: remove --with-git-submodules=

2023-06-06 Thread Daniel P . Berrangé
On Mon, Jun 05, 2023 at 11:52:23AM +0200, Paolo Bonzini wrote: > Reuse --enable/--disable-download to control git submodules as well. > Adjust the error messages of git-submodule.sh to refer to the new > option. > > Signed-off-by: Paolo Bonzini > --- > configure

Re: [PATCH v3 1/1] hw/arm/sbsa-ref: use XHCI to replace EHCI

2023-06-06 Thread Peter Maydell
On Tue, 6 Jun 2023 at 10:47, Marcin Juszkiewicz wrote: > > W dniu 5.06.2023 o 11:55, Yuquan Wang pisze: > > The current sbsa-ref cannot use EHCI controller which is only > > able to do 32-bit DMA, since sbsa-ref doesn't have RAM below 4GB. > > Hence, this uses XHCI to provide a usb controller with

Re: [PATCH 06/10] configure: move SLOF submodule handling to pc-bios/s390-ccw

2023-06-06 Thread Thomas Huth
On 05/06/2023 11.52, Paolo Bonzini wrote: Move the handling of the roms/SLOF submodule out of the main Makefile, since we are going to remove submodules from the build process of QEMU. Signed-off-by: Paolo Bonzini --- .gitlab-ci.d/buildtest-template.yml | 2 +- configure

Re: [PATCH 07/10] pc-bios/s390-ccw: always build network bootloader

2023-06-06 Thread Thomas Huth
On 05/06/2023 11.52, Paolo Bonzini wrote: In the beginning, the network bootloader was considered experimental and thus optional, but it is well established nowadays and configure always checks for roms/SLOF before compiling pc-bios/s390-ccw. Therefore, it makes sense to always build it together

[PATCH v6 3/9] migration: convert socket backend to accept MigrateAddress struct

2023-06-06 Thread Het Gala
Socket transport backend for 'migrate'/'migrate-incoming' QAPIs accept new wire protocol of MigrateAddress struct. It is achived by parsing 'uri' string and storing migration parameters required for socket connection into well defined SocketAddress struct. Suggested-by: Aravind Retnakaran Signed

[PATCH v6 8/9] migration: Introduced MigrateChannelList struct to migration code flow.

2023-06-06 Thread Het Gala
Integrated MigrateChannelList with all transport backends (socket, exec and rdma) for both source and destination migration code flow. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala --- migration/migration.c | 77 --- migration/socket.c| 5

[PATCH v6 4/9] migration: convert rdma backend to accept MigrateAddress struct

2023-06-06 Thread Het Gala
RDMA based transport backend for 'migrate'/'migrate-incoming' QAPIs accept new wire protocol of MigrateAddress struct. It is achived by parsing 'uri' string and storing migration parameters required for RDMA connection into well defined InetSocketAddress struct. Suggested-by: Aravind Retnakaran

[PATCH v6 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-06-06 Thread Het Gala
This patch introduces well defined MigrateAddress struct and its related child objects. The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri' is of string type. The current migration flow follows double encoding scheme for fetching migration parameters such as 'uri' and this is n

[PATCH v6 9/9] migration: adding test case for modified QAPI syntax

2023-06-06 Thread Het Gala
Adding multifd tcp common test case for modified QAPI syntax defined. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala --- tests/qtest/migration-test.c | 45 1 file changed, 45 insertions(+) diff --git a/tests/qtest/migration-test.c b/tests/qtest/mi

[PATCH v6 7/9] migration: modify migration_channels_and_uri_compatible() to incorporate newer migration QAPI syntax

2023-06-06 Thread Het Gala
migration_channels_and_uri_compatible() check for transport mechanism suitable for multifd migration gets executed when the caller calls old uri syntax. It needs it to be run when using the mordern MigrateCHannel QAPI syntax too. After URI -> 'MigrateChannel' object conversion, migration_channels_

[PATCH v6 2/9] migration: convert uri parameter into 'MigrateAddress' struct

2023-06-06 Thread Het Gala
This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri' parameter with all the migration connection related information and stores them inside well defined 'MigrateAddress' struct. Misc: limit line width in exec.c to 80 characters recommended by Qemu. Suggested-by: Aravind Retnakaran Sig

[PATCH v6 6/9] migration: modified migration QAPIs to accept 'channels' argument for migration

2023-06-06 Thread Het Gala
MigrateChannelList allows to connect accross multiple interfaces. Added MigrateChannelList struct as argument to migration QAPIs. Future patchset series plans to include multiple MigrateChannels for multiple interfaces to be connected. That is the reason, 'MigrateChannelList' is the preferred choi

[PATCH v6 0/9] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration

2023-06-06 Thread Het Gala
This is v6 patchset of modified 'migrate' and 'migrate-incoming' QAPI design for upstream review. Would like to thank all the maintainers that actively participated in the v5 patchset discussion and gave insightful suggestions to improve the patches. Link to previous upstream community patchset

[PATCH v6 5/9] migration: convert exec backend to accept MigrateAddress struct.

2023-06-06 Thread Het Gala
Exec transport backend for 'migrate'/'migrate-incoming' QAPIs accept new wire protocol of MigrateAddress struct. It is achived by parsing 'uri' string and storing migration parameters required for exec connection into strList struct. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala ---

[PATCH v2 1/2] migration: enfocre multifd and postcopy preempt to be set before incoming

2023-06-06 Thread Wei Wang
qemu_start_incoming_migration needs to check the number of multifd channels or postcopy ram channels to configure the backlog parameter (i.e. the maximum length to which the queue of pending connections for sockfd may grow) of listen(). So enforce the usage of postcopy-preempt and multifd as below:

[PATCH v2 2/2] qtest/migration-tests.c: use "-incoming defer" for postcopy tests

2023-06-06 Thread Wei Wang
The Postcopy preempt capability is expected to be set before incoming starts, so change the postcopy tests to start with deferred incoming and call migrate-incoming after the cap has been set. Why the existing tests (without this patch) didn't fail? There could be two reasons: 1) "backlog" specifi

[PATCH RESEND v2 0/2] Enfore multifd and postcopy preempt setting

2023-06-06 Thread Wei Wang
Setting the cap/params of multifd and postcopy preempt is expected to be done before incoming starts, as the number of multifd channels or postcopy ram channels is used by qemu_start_incoming_migration (to listen on the number of pending connections). Enfocre the cap/params of multifd and postcopy

Re: [PATCH v3 1/1] hw/arm/sbsa-ref: use XHCI to replace EHCI

2023-06-06 Thread Marcin Juszkiewicz
W dniu 6.06.2023 o 12:04, Peter Maydell pisze: On Tue, 6 Jun 2023 at 10:47, Marcin Juszkiewicz wrote: W dniu 5.06.2023 o 11:55, Yuquan Wang pisze: The current sbsa-ref cannot use EHCI controller which is only able to do 32-bit DMA, since sbsa-ref doesn't have RAM below 4GB. Hence, this uses X

Re: [PATCH] target/riscv/vector_helper.c: Remove the check for extra tail elements

2023-06-06 Thread Daniel Henrique Barboza
Hi, On 6/6/23 05:34, Xiao Wang wrote: Commit 752614cab8e6 ("target/riscv: rvv: Add tail agnostic for vector load / store instructions") added an extra check for LMUL fragmentation, intended for setting the "rest tail elements" in the last register for a segment load insn. Actually, the max_ele

Re: [PULL 31/35] hw/intc/allwinner-a10-pic: Don't use set_bit()/clear_bit()

2023-06-06 Thread Peter Maydell
On Mon, 5 Jun 2023 at 14:35, Guenter Roeck wrote: > > On 6/5/23 02:40, Peter Maydell wrote: > > If you can provide a link to the zImage and the dtb to reproduce > > as well, that would be helpful. > > > Please see http://server.roeck-us.net/qemu/arm-v7/. Thanks. I've identified the cause of the r

[PATCH 2/2] hw/sd/allwinner-sdhost: Don't send non-boolean IRQ line levels

2023-06-06 Thread Peter Maydell
QEMU allows qemu_irq lines to transfer arbitrary integers. However the convention is that for a simple IRQ line the values transferred are always 0 and 1. The A10 SD controller device instead assumes a 0-vs-non-0 convention, which happens to work with the interrupt controller it is wired up to.

[PATCH 1/2] hw/intc/allwinner-a10-pic: Handle IRQ levels other than 0 or 1

2023-06-06 Thread Peter Maydell
In commit 2c5fa0778c3b430 we fixed an endianness bug in the Allwinner A10 PIC model; however in the process we introduced a regression. This is because the old code was robust against the incoming 'level' argument being something other than 0 or 1, whereas the new code was not. In particular, the

[PATCH 0/2] allwinner-a10: Fix interrupt controller regression

2023-06-06 Thread Peter Maydell
In commit 2c5fa0778c3b430 we fixed an endianness bug in the Allwinner A10 PIC model; however in the process we introduced a regression. This is because the old code was robust against the incoming 'level' argument being something other than 0 or 1, whereas the new code was not. In particular, the

Re: [PULL 02/17] block: Collapse padded I/O vecs exceeding IOV_MAX

2023-06-06 Thread Michael Tokarev
06.06.2023 11:45, Hanna Czenczek wrote: On 06.06.23 10:00, Michael Tokarev wrote: .. This seems to be over-complicated, both of them, no? I would have preferred to have this discussion while the patch was still on-list for review (this specific version was for two months, counting from the f

Re: [PATCH v3 03/15] hw/pci: Add a pci_device_iommu_memory_region() helper

2023-06-06 Thread Joao Martins
On 05/06/2023 17:57, Peter Xu wrote: > On Tue, May 30, 2023 at 06:59:25PM +0100, Joao Martins wrote: >> Much like pci_device_iommu_address_space() fetches the IOMMU AS, add a >> pci_device_iommu_memory_region() which lets it return an the IOMMU MR >> associated with it. The IOMMU MR is returned cor

[PATCH] Add epmp to extensions list and rename it to smepmp

2023-06-06 Thread Himanshu Chauhan
Smepmp is a ratified extension which qemu refers to as epmp. Rename epmp to smepmp and add it to extension list so that it is added to the isa string. Signed-off-by: Himanshu Chauhan --- target/riscv/cpu.c | 9 + target/riscv/cpu_cfg.h | 2 +- target/riscv/csr.c | 6 +++--- ta

[PATCH 01/21] ui/egl: export qemu_egl_get_error_string()

2023-06-06 Thread marcandre . lureau
From: Marc-André Lureau It will be used from other units. Signed-off-by: Marc-André Lureau --- include/ui/egl-helpers.h | 2 ++ ui/egl-helpers.c | 12 +--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/ui/egl-helpers.h b/include/ui/egl-helpers.h index

[PATCH 00/21] -display dbus: add win32 support

2023-06-06 Thread marcandre . lureau
From: Marc-André Lureau Hi, The D-Bus display doesn't work on Windows, since it relies on FDs transfer over Unix domain socket. This isn't (yet) supported on Windows. To make it work, the interfaces are adapted to use 'ay' WSASocketW data instead of 'h' (in a similar fashion as QMP 'get-win32-so

[PATCH 07/21] tests: make dbus-display-test work on win32

2023-06-06 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tests/qtest/dbus-display-test.c | 43 ++--- tests/qtest/meson.build | 2 +- 2 files changed, 41 insertions(+), 4 deletions(-) diff --git a/tests/qtest/dbus-display-test.c b/tests/qtest/dbus-displa

[PATCH 12/21] ui: add egl-headless support on win32

2023-06-06 Thread marcandre . lureau
From: Marc-André Lureau Make GBM optional for EGL code, and enable the build for win32. Signed-off-by: Marc-André Lureau --- qapi/ui.json | 5 ++--- include/ui/egl-helpers.h | 7 ++- ui/egl-headless.c| 20 +--- ui/egl-helpers.c | 38 +++

[PATCH 06/21] qtest: add qtest_pid()

2023-06-06 Thread marcandre . lureau
From: Marc-André Lureau Used in the following test on win32, to share sockets with the QEMU process. Signed-off-by: Marc-André Lureau --- tests/qtest/libqtest.h | 9 + tests/qtest/libqtest.c | 5 + 2 files changed, 14 insertions(+) diff --git a/tests/qtest/libqtest.h b/tests/qtest

[PATCH 14/21] ui: add egl_fb_read_rect()

2023-06-06 Thread marcandre . lureau
From: Marc-André Lureau Similar to egl_fb_read(), same limitations, but with extra arguments to read a subset of the framebuffer. Used in following commits. Signed-off-by: Marc-André Lureau --- include/ui/egl-helpers.h | 1 + ui/egl-helpers.c | 14 ++ 2 files changed, 15 i

[PATCH 16/21] ui/dbus: add some GL traces

2023-06-06 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/dbus-listener.c | 6 ++ ui/trace-events| 3 +++ 2 files changed, 9 insertions(+) diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c index e92eff66e3..8605dffd8a 100644 --- a/ui/dbus-listener.c +++ b/ui/dbus-listener.c @@

Re: [PATCH v5 8/9] vfio/migration: Add x-allow-pre-copy VFIO device property

2023-06-06 Thread Avihai Horon
On 05/06/2023 17:56, Alex Williamson wrote: External email: Use caution opening links or attachments On Sun, 4 Jun 2023 12:33:43 +0300 Avihai Horon wrote: On 01/06/2023 23:22, Alex Williamson wrote: External email: Use caution opening links or attachments On Tue, 30 May 2023 17:48:20 +0

[PATCH 08/21] ui/dbus: introduce "Interfaces" properties

2023-06-06 Thread marcandre . lureau
From: Marc-André Lureau This property is similar to ``org.freedesktop.DBus.Interfaces`` property on the bus interface: it's an array of strings listing the extra interfaces and capabilities available, in a convenient way. Most interfaces are implicit, as they are required. For ``org/qemu/Display

[PATCH 10/21] virtio-gpu/win32: allocate shareable 2d resources/images

2023-06-06 Thread marcandre . lureau
From: Marc-André Lureau Allocate pixman bits for scanouts with qemu_win32_map_alloc() so we can set a shareable handle on the associated display surface. Note: when bits are provided to pixman_image_create_bits(), you must also give the rowstride (the argument is ignored when bits is NULL) Sign

[PATCH 05/21] ui/dbus: win32 support

2023-06-06 Thread marcandre . lureau
From: Marc-André Lureau D-Bus doesn't support fd-passing on Windows (AF_UNIX doesn't have SCM_RIGHTS yet, but there are other means to share objects. I have proposed various solutions upstream, but none seem fitting enough atm). To make the "-display dbus" work on Windows, implement an alternati

[PATCH 13/21] ui/egl: default to GLES on windows

2023-06-06 Thread marcandre . lureau
From: Marc-André Lureau Windows GL drivers are notoriously not very good. Otoh, ANGLE provides rock solid GLES implementation on top of direct3d. We should recommend it and default to ES when using EGL (users can easily override this if necessary) Signed-off-by: Marc-André Lureau --- ui/egl-he

[PATCH 17/21] virtio-gpu-virgl: teach it to get the QEMU EGL display

2023-06-06 Thread marcandre . lureau
From: Marc-André Lureau virgl offers a few features that require to have access to the underlying EGLDisplay. This is the case for the D3D texture sharing support. The API callback is merged for virgl 1.0: https://gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/1113 Signed-off-by: M

  1   2   3   4   >