Re: [PATCH v5 6/6] hw/cxl: Add clear poison mailbox command support.

2023-05-19 Thread Michael S. Tsirkin
On Sun, Apr 23, 2023 at 05:20:13PM +0100, Jonathan Cameron wrote: > Current implementation is very simple so many of the corner > cases do not exist (e.g. fragmenting larger poison list entries) > > Reviewed-by: Fan Ni > Signed-off-by: Jonathan Cameron > --- > v5: > - Much simpler identification

Re: [PATCH v5 7/7] hw/cxl/events: Add injection of Memory Module Events

2023-05-19 Thread Michael S. Tsirkin
On Sun, Apr 23, 2023 at 05:51:40PM +0100, Jonathan Cameron wrote: > These events include a copy of the device health information at the > time of the event. Actually using the emulated device health would > require a lot of controls to manipulate that state. Given the aim > of this injection code

Re: gitlab shared runner time expired

2023-05-19 Thread Mark Cave-Ayland
On 18/05/2023 20:26, Richard Henderson wrote: So, here we are again, out of runner time with 13 days left in the month. Did we come to any resolution since last time?  Holding development for that long just isn't right, so I'll continue processing the hard way -- testing on private runners an

[PATCH] [query-memory-size-summary] Report page size

2023-05-19 Thread Andrei Gudkov via
Some commands (query-migrate and calc-dirty-rate) report values in units of pages. However, currently the only place where we can get page size is through query-migrate and only after migration has started. query-memory-size-summary seems like an appropritate place where it should be reported inste

[PATCH] mkvenv: replace distlib.database with importlib.metadata/pkg_resources

2023-05-19 Thread Paolo Bonzini
importlib.metadata is just as good as distlib.database and a bit more battle-proven for "egg" based distributions, and in fact that is exactly why mkvenv.py is not using distlib.database to find entry points: it simply does not work for eggs. The only disadvantage of importlib.metadata is that it

[PATCH] mkvenv: pass first missing package to diagnose()

2023-05-19 Thread Paolo Bonzini
If sphinx is present but the theme is not, mkvenv will print an inaccurate diagnostic: ERROR: Could not find a version that satisfies the requirement sphinx-rtd-theme>=0.5.0 (from versions: none) ERROR: No matching distribution found for sphinx-rtd-theme>=0.5.0 'sphinx>=1.6.0' not found: • Pyth

Re: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming

2023-05-19 Thread Daniel P . Berrangé
On Thu, May 18, 2023 at 03:20:02PM -0400, Peter Xu wrote: > On Fri, May 19, 2023 at 12:00:26AM +0800, Wei Wang wrote: > > qemu_start_incoming_migration needs to check the number of multifd > > channels or postcopy ram channels to configure the backlog parameter (i.e. > > the maximum length to which

Re: [PULL 00/68] i386, build system, KVM changes for 2023-05-18

2023-05-19 Thread Paolo Bonzini
On 5/19/23 05:06, Yang Zhong wrote: Paolo, please help add below queued sgx fix into this PULL request, which was missed from last time, thanks a lot! https://lists.nongnu.org/archive/html/qemu-devel/2023-04/msg00841.html https://lists.nongnu.org/archive/html/qemu-devel/2023-04/msg00896.html I

Re: Configure no longer works after pulling in the latest QEMU commits

2023-05-19 Thread Paolo Bonzini
On 5/19/23 05:00, Hao Xiang wrote: Hi, After pulling in the QEMU latest commits, I can no longer run the "configure" command. Below is the error message I am seeing. I believe this is related to this change "configure: create a python venv unconditionally". I am running on Debian GNU/Linux 1

Re: gitlab shared runner time expired

2023-05-19 Thread Paolo Bonzini
On 5/18/23 21:26, Richard Henderson wrote: So, here we are again, out of runner time with 13 days left in the month. Did we come to any resolution since last time?  Holding development for that long just isn't right, so I'll continue processing the hard way -- testing on private runners and lo

[PATCH v1] target/loongarch: Fix the vinsgr2vr/vpickve2gr instructions cause system coredump

2023-05-19 Thread Song Gao
The vinsgr2vr/vpickve2gr instructions need use get_src/get_dst to get gpr registers value, not cpu_gpr[]. The $zero register does not have cpu_gpr[0] allocated. Signed-off-by: Song Gao --- target/loongarch/insn_trans/trans_lsx.c.inc | 36 ++--- 1 file changed, 24 insertions(+), 1

Re: [PATCH 1/6] block: add blk_io_plug_call() API

2023-05-19 Thread Stefano Garzarella
On Wed, May 17, 2023 at 06:10:17PM -0400, Stefan Hajnoczi wrote: Introduce a new API for thread-local blk_io_plug() that does not traverse the block graph. The goal is to make blk_io_plug() multi-queue friendly. Instead of having block drivers track whether or not we're in a plugged section, pro

Re: [PATCH 2/6] block/nvme: convert to blk_io_plug_call() API

2023-05-19 Thread Stefano Garzarella
On Wed, May 17, 2023 at 06:10:18PM -0400, Stefan Hajnoczi wrote: Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi --- block/nvme.c | 44 ---

Re: [PATCH 3/6] block/blkio: convert to blk_io_plug_call() API

2023-05-19 Thread Stefano Garzarella
On Wed, May 17, 2023 at 06:10:19PM -0400, Stefan Hajnoczi wrote: Stop using the .bdrv_co_io_plug() API because it is not multi-queue block layer friendly. Use the new blk_io_plug_call() API to batch I/O submission instead. Signed-off-by: Stefan Hajnoczi --- block/blkio.c | 40 ++

[PATCH 0/2] PC: Create RTC controllers in south bridges

2023-05-19 Thread Bernhard Beschow
This series contains two patches originating from the PIIX consolidation series [1]. Since the two patches represent general PC code modernization (ICH9 is modernized as well) and since the PIIX consolidation series is still under discussion it made sense to split off these patches. Testing done:

[PATCH 2/2] hw/i386/pc: No need for rtc_state to be an out-parameter

2023-05-19 Thread Bernhard Beschow
Now that the RTC is created as part of the southbridges it doesn't need to be an out-parameter any longer. Signed-off-by: Bernhard Beschow Reviewed-by: Peter Maydell Reviewed-by: Michael S. Tsirkin Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20221022150508.26830-

[PATCH 1/2] hw/i386/pc: Create RTC controllers in south bridges

2023-05-19 Thread Bernhard Beschow
Just like in the real hardware (and in PIIX4), create the RTC controllers in the south bridges. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin Reviewed-by: Thomas Huth Message-Id: <20221022150508.26830-11-shen...@gmail.com> --- include/hw/southbridge/ich9.h | 2 ++ include/hw

Re: gitlab shared runner time expired

2023-05-19 Thread Camilla Conte
Hi! On Fri, May 19, 2023 at 9:35 AM Paolo Bonzini wrote: > You should be able to run pipelines almost as usual, just with > > git push -o ci.variable=RUNNER_TAG=k8s ... > > Camilla, please confirm that this is correct. Looks good.

Re: gitlab shared runner time expired

2023-05-19 Thread Daniel P . Berrangé
On Thu, May 18, 2023 at 12:26:33PM -0700, Richard Henderson wrote: > So, here we are again, out of runner time with 13 days left in the month. > > Did we come to any resolution since last time? Holding development for that > long just isn't right, so I'll continue processing the hard way -- testi

Re: [PATCH v5 0/6] hw/cxl: Poison get, inject, clear

2023-05-19 Thread Michael S. Tsirkin
On Sun, Apr 23, 2023 at 05:20:07PM +0100, Jonathan Cameron wrote: > v5: More details in each patch. > - Simpler algorithm to find entry when clearing. > - Improvements to debugability and docs for 24 bit endian functions. > - Use of ROUND_DOWN() to simplify the various alignment questions. > -

Re: [PATCH v8 00/23] Consolidate PIIX south bridges

2023-05-19 Thread Bernhard Beschow
Am 18. Mai 2023 21:28:12 UTC schrieb "Michael S. Tsirkin" : >On Wed, May 10, 2023 at 06:39:49PM +, Bernhard Beschow wrote: >> >> >> Am 21. April 2023 16:40:47 UTC schrieb Bernhard Beschow : >> > >> > >> >Am 21. April 2023 07:15:18 UTC schrieb "Michael S. Tsirkin" >> >: >> >>On Thu, Mar 02

Re: [PATCH 1/2] hw/i386/pc: Create RTC controllers in south bridges

2023-05-19 Thread Michael S. Tsirkin
On Fri, May 19, 2023 at 10:47:33AM +0200, Bernhard Beschow wrote: > Just like in the real hardware (and in PIIX4), create the RTC > controllers in the south bridges. > > Signed-off-by: Bernhard Beschow > Reviewed-by: Michael S. Tsirkin > Reviewed-by: Thomas Huth > Message-Id: <20221022150508.26

[PATCH 1/6] remove remaining traces of meson submodule

2023-05-19 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- .gitlab-ci.d/buildtest-template.yml | 4 scripts/archive-source.sh | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-template.yml index 7edb50b76035..c9f2e737c09a 1006

[PATCH 6/6] meson: subprojects: replace submodules with wrap files

2023-05-19 Thread Paolo Bonzini
Compared to submodules, .wrap files have several advantages: * option parsing and downloading is delegated to meson * the commit is stored in a text file instead of a magic entry in the git tree object * we could stop shipping external dependencies that are only used as a fallback, but not b

[PATCH 3/6] meson: use subproject for internal libfdt

2023-05-19 Thread Paolo Bonzini
Recent dtc/libfdt can use either Make or meson as the build system. By using a subproject, our own meson.build can remove the hard coded list of source files. This is also the first step towards managing downloads with .wrap files instead of submodule. Signed-off-by: Paolo Bonzini --- .gitmodul

[PATCH 2/6] meson: simplify logic for -Dfdt

2023-05-19 Thread Paolo Bonzini
fdt_opt == 'disabled' is going to give an error if libfdt is required by any target, so catch that immediately. For fdt_opt == 'enabled', instead, do not check immediately whether the internal libfdt is present. Instead do the check after ascertaining that libfdt is absent or too old. Signed-off-

[PATCH v2 0/6] meson: use subprojects for bundled projects

2023-05-19 Thread Paolo Bonzini
QEMU bundles a copy of dtc and keycodemapdb. They both support meson, so we can run their build system via subproject() instead of hardcoding their contents. In fact, now that QEMU's configure script knows how to install missing Python dependencies, we can replace submodules altogether with .wrap

[PATCH 4/6] meson: use subproject for keycodemapdb

2023-05-19 Thread Paolo Bonzini
By using a subproject, our own meson.build can use variables from the subproject instead of hard-coded paths. This is also the first step towards managing downloads with .wrap files instead of submodule. Signed-off-by: Paolo Bonzini --- .gitmodules | 4 ++-- configure

[PATCH 5/6] configure: rename --enable-pypi to --enable-download, control subprojects too

2023-05-19 Thread Paolo Bonzini
The behavior of --{enable,disable}-pypi is similar to that of -Dwrapmode={default,nodownload} respectively. In particular, in both cases a feature needs to be explicitly enabled for the dependency to be downloaded. So, use a single option to control both cases. Now, --enable-slirp will trigger c

Re: [PATCH 1/2] Add CI configuration for Kubernetes

2023-05-19 Thread Daniel P . Berrangé
On Fri, Apr 07, 2023 at 03:52:51PM +0100, Camilla Conte wrote: > Configure Gitlab CI to run on Kubernetes > according to the official documentation. > https://docs.gitlab.com/ee/ci/docker/using_docker_build.html#docker-in-docker-with-tls-enabled-in-kubernetes > > These changes are needed because o

Re: [PATCH 1/6] remove remaining traces of meson submodule

2023-05-19 Thread Daniel P . Berrangé
On Fri, May 19, 2023 at 10:56:41AM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > .gitlab-ci.d/buildtest-template.yml | 4 > scripts/archive-source.sh | 2 +- > 2 files changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Dan

Re: [PATCH 2/6] meson: simplify logic for -Dfdt

2023-05-19 Thread Daniel P . Berrangé
On Fri, May 19, 2023 at 10:56:42AM +0200, Paolo Bonzini wrote: > fdt_opt == 'disabled' is going to give an error if libfdt is required > by any target, so catch that immediately. For fdt_opt == 'enabled', > instead, do not check immediately whether the internal libfdt is present. > Instead do the

Re: [PATCH 3/6] meson: use subproject for internal libfdt

2023-05-19 Thread Daniel P . Berrangé
On Fri, May 19, 2023 at 10:56:43AM +0200, Paolo Bonzini wrote: > Recent dtc/libfdt can use either Make or meson as the build system. > By using a subproject, our own meson.build can remove the hard > coded list of source files. > > This is also the first step towards managing downloads with .wrap

Re: [PATCH 4/6] meson: use subproject for keycodemapdb

2023-05-19 Thread Daniel P . Berrangé
On Fri, May 19, 2023 at 10:56:44AM +0200, Paolo Bonzini wrote: > By using a subproject, our own meson.build can use variables from > the subproject instead of hard-coded paths. This is also the first step > towards managing downloads with .wrap files instead of submodule. > > Signed-off-by: Paolo

Re: [PATCH 5/6] configure: rename --enable-pypi to --enable-download, control subprojects too

2023-05-19 Thread Daniel P . Berrangé
On Fri, May 19, 2023 at 10:56:45AM +0200, Paolo Bonzini wrote: > The behavior of --{enable,disable}-pypi is similar to that of > -Dwrapmode={default,nodownload} respectively. In particular, > in both cases a feature needs to be explicitly enabled for the > dependency to be downloaded. > > So, use

Re: gitlab shared runner time expired

2023-05-19 Thread Peter Maydell
On Thu, 18 May 2023 at 20:27, Richard Henderson wrote: > > So, here we are again, out of runner time with 13 days left in the month. This is quite early -- have you been processing pull requests strictly one at a time, or in (small) batches ? -- PMM

Re: [PATCH v2 0/6] meson: use subprojects for bundled projects

2023-05-19 Thread Peter Maydell
On Fri, 19 May 2023 at 09:56, Paolo Bonzini wrote: > > QEMU bundles a copy of dtc and keycodemapdb. They both support meson, > so we can run their build system via subproject() instead of hardcoding > their contents. > > In fact, now that QEMU's configure script knows how to install missing > Pyt

Re: [PATCH v5 6/6] hw/cxl: Add clear poison mailbox command support.

2023-05-19 Thread Jonathan Cameron via
> > diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c > > index ab600735eb..a247f506b7 100644 > > --- a/hw/mem/cxl_type3.c > > +++ b/hw/mem/cxl_type3.c > > @@ -947,6 +947,42 @@ static void set_lsa(CXLType3Dev *ct3d, const void > > *buf, uint64_t size, > > */ > > } > > > > +static boo

Re: [PULL 18/18] tested: add test for nested aio_poll() in poll handlers

2023-05-19 Thread Kevin Wolf
Am 17.05.2023 um 21:10 hat Richard Henderson geschrieben: > On 5/17/23 09:51, Kevin Wolf wrote: > > From: Stefan Hajnoczi > > > > Signed-off-by: Stefan Hajnoczi > > Message-Id: <20230502184134.534703-3-stefa...@redhat.com> > > Tested-by: Kevin Wolf > > Signed-off-by: Kevin Wolf > > --- > > t

Re: [PATCH 6/6] meson: subprojects: replace submodules with wrap files

2023-05-19 Thread Daniel P . Berrangé
On Fri, May 19, 2023 at 10:56:46AM +0200, Paolo Bonzini wrote: > Compared to submodules, .wrap files have several advantages: > > * option parsing and downloading is delegated to meson > > * the commit is stored in a text file instead of a magic entry in the > git tree object This avoids one o

Re: [PATCH v2 0/6] meson: use subprojects for bundled projects

2023-05-19 Thread Paolo Bonzini
On Fri, May 19, 2023 at 11:21 AM Peter Maydell wrote: > > On Fri, 19 May 2023 at 09:56, Paolo Bonzini wrote: > > > > QEMU bundles a copy of dtc and keycodemapdb. They both support meson, > > so we can run their build system via subproject() instead of hardcoding > > their contents. > > > > In fa

Re: [PATCH v2 0/6] meson: use subprojects for bundled projects

2023-05-19 Thread Peter Maydell
On Fri, 19 May 2023 at 09:56, Paolo Bonzini wrote: > It is possible to use subprojects also for berkeley-softfloat-3 > and berkeley-testfloat-3. This would require moving the corresponding > parts of tests/fp/meson.build to an overlay file. I think we also talked about simply putting those direc

Re: [PATCH v2 0/6] meson: use subprojects for bundled projects

2023-05-19 Thread Daniel P . Berrangé
On Fri, May 19, 2023 at 10:21:03AM +0100, Peter Maydell wrote: > On Fri, 19 May 2023 at 09:56, Paolo Bonzini wrote: > > > > QEMU bundles a copy of dtc and keycodemapdb. They both support meson, > > so we can run their build system via subproject() instead of hardcoding > > their contents. > > > >

Re: [PATCH 6/6] meson: subprojects: replace submodules with wrap files

2023-05-19 Thread Paolo Bonzini
On 5/19/23 11:25, Daniel P. Berrangé wrote: * dtc - the distro should always have it anyway * libvfio-user - don't think this has found its way into any distros yet. So if we don't bundle it, distros have to pacakge it or re-bundle with

Re: [PATCH v2 0/6] meson: use subprojects for bundled projects

2023-05-19 Thread Peter Maydell
On Fri, 19 May 2023 at 10:32, Daniel P. Berrangé wrote: > > On Fri, May 19, 2023 at 10:21:03AM +0100, Peter Maydell wrote: > > On Fri, 19 May 2023 at 09:56, Paolo Bonzini wrote: > > > > > > QEMU bundles a copy of dtc and keycodemapdb. They both support meson, > > > so we can run their build syst

Re: [PATCH v2 0/6] meson: use subprojects for bundled projects

2023-05-19 Thread Paolo Bonzini
On Fri, May 19, 2023 at 11:32 AM Daniel P. Berrangé wrote: > Maybe we can none the less wire up libvirt-ci into wrap, or alternatively > since its python, could we make our new venv setup tools put libvirt-ci > into the venv ? libvirt-ci is used from the source tree so I think it doesn't even fit

[PATCH v5 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

2023-05-19 Thread Het Gala
This patch introduces well defined MigrateAddress struct and its related child objects. The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri' is of string type. The current migration flow follows double encoding scheme for fetching migration parameters such as 'uri' and this is no

[PATCH v5 3/9] migration: convert socket backend to accept MigrateAddress struct

2023-05-19 Thread Het Gala
Socket transport backend for 'migrate'/'migrate-incoming' QAPIs accept new wire protocol of MigrateAddress struct. It is achived by parsing 'uri' string and storing migration parameters required for socket connection into well defined SocketAddress struct. Suggested-by: Aravind Retnakaran Signed

[PATCH v5 0/9] migration: Modify 'migrate' and 'migrate-incoming' QAPI commands for migration

2023-05-19 Thread Het Gala
This is v5 patchset of modified 'migrate' and 'migrate-incoming' QAPI design for upstream review. Would like to thank all the maintainers that actively participated in the v4 patchset discussion and gave insightful suggestions to improve the patches. Link to previous upstream community patchset l

[PATCH v5 7/9] migration: modify migration_channels_and_uri_compatible() to incorporate newer migration QAPI syntax

2023-05-19 Thread Het Gala
migration_channels_and_uri_compatible() check for transport mechanism suitable for multifd migration gets executed when the caller calls old uri syntax. It needs it to be run when using the mordern MigrateCHannel QAPI syntax too. After URI -> 'MigrateChannel' object conversion, migration_channels_

[PATCH v5 6/9] migration: modified migration QAPIs to accept 'channels' argument for migration

2023-05-19 Thread Het Gala
MigrateChannelList allows to connect accross multiple interfaces. Added MigrateChannelList struct as argument to migration QAPIs. Future patchset series plans to include multiple MigrateChannels for multiple interfaces to be connected. That is the reason, 'MigrateChannelList' is the preferred cho

[PATCH v5 8/9] migration: Introduced MigrateChannelList struct to migration code flow.

2023-05-19 Thread Het Gala
Integrated MigrateChannelList with all transport backends (socket, exec and rdma) for both source and destination migration code flow. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala --- migration/migration.c | 75 --- migration/socket.c| 5

[PATCH v5 9/9] migration: adding test case for modified QAPI syntax

2023-05-19 Thread Het Gala
Adding multifd tcp common test case for modified QAPI syntax defined. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala --- tests/qtest/migration-test.c | 47 1 file changed, 47 insertions(+) diff --git a/tests/qtest/migration-test.c b/tests/qtest/mi

[PATCH v5 4/9] migration: convert rdma backend to accept MigrateAddress struct

2023-05-19 Thread Het Gala
RDMA based transport backend for 'migrate'/'migrate-incoming' QAPIs accept new wire protocol of MigrateAddress struct. It is achived by parsing 'uri' string and storing migration parameters required for RDMA connection into well defined InetSocketAddress struct. Suggested-by: Aravind Retnakaran

[PATCH v5 2/9] migration: convert uri parameter into 'MigrateAddress' struct

2023-05-19 Thread Het Gala
This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri' parameter with all the migration connection related information and stores them inside well defined 'MigrateAddress' struct. Misc: limit line width in exec.c to 80 characters recommended by Qemu. Suggested-by: Aravind Retnakaran Sig

[PATCH v5 5/9] migration: convert exec backend to accept MigrateAddress struct.

2023-05-19 Thread Het Gala
Exec transport backend for 'migrate'/'migrate-incoming' QAPIs accept new wire protocol of MigrateAddress struct. It is achived by parsing 'uri' string and storing migration parameters required for exec connection into strList struct. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala ---

Re: [PATCH v5 9/9] migration: adding test case for modified QAPI syntax

2023-05-19 Thread Het Gala
On 19/05/23 3:16 pm, Het Gala wrote: Adding multifd tcp common test case for modified QAPI syntax defined. Suggested-by: Aravind Retnakaran Signed-off-by: Het Gala --- tests/qtest/migration-test.c | 47 1 file changed, 47 insertions(+) diff --git a/te

Re: [PATCH v5 5/9] migration: convert exec backend to accept MigrateAddress struct.

2023-05-19 Thread Het Gala
On 19/05/23 3:16 pm, Het Gala wrote: Exec transport backend for 'migrate'/'migrate-incoming' QAPIs accept new wire protocol of MigrateAddress struct. It is achived by parsing 'uri' string and storing migration parameters required for exec connection into strList struct. Suggested-by: Aravind

Re: [PATCH 2/2] Raise crash-test-debian timeout to 90 minutes

2023-05-19 Thread Daniel P . Berrangé
On Tue, Apr 11, 2023 at 10:22:51AM +0200, Thomas Huth wrote: > On 07/04/2023 16.52, Camilla Conte wrote: > > When running on the Kubernetes runner, this CI job is timing out. > > Raise the limit to give the job enough time to run. > > > > Signed-off-by: Camilla Conte > > --- > > .gitlab-ci.d/bu

[PULL v2 00/21] Block layer patches

2023-05-19 Thread Kevin Wolf
The following changes since commit 6972ef1440a9d685482d78672620a7482f2bd09a: Merge tag 'pull-tcg-20230516-3' of https://gitlab.com/rth7680/qemu into staging (2023-05-16 21:30:27 -0700) are available in the Git repository at: https://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fe

Re: [PATCH v5 0/6] hw/cxl: Poison get, inject, clear

2023-05-19 Thread Jonathan Cameron via
On Fri, 19 May 2023 04:49:46 -0400 "Michael S. Tsirkin" wrote: > On Sun, Apr 23, 2023 at 05:20:07PM +0100, Jonathan Cameron wrote: > > v5: More details in each patch. > > - Simpler algorithm to find entry when clearing. > > - Improvements to debugability and docs for 24 bit endian functions. >

Re: [PATCH] multifd: Set a higher "backlog" default value for listen()

2023-05-19 Thread Juan Quintela
"Wang, Wei W" wrote: > On Friday, May 19, 2023 9:31 AM, Wang, Lei4 wrote: >> On 5/18/2023 17:16, Juan Quintela wrote: >> > Lei Wang wrote: >> >> When destination VM is launched, the "backlog" parameter for listen() >> >> is set to 1 as default in socket_start_incoming_migration_internal(), >> >>

Re: [RFC PATCH] Add support for RAPL MSRs in KVM/Qemu

2023-05-19 Thread Philippe Mathieu-Daudé
Hi Anthony, On 17/5/23 15:07, Anthony Harivel wrote: Starting with the "Sandy Bridge" generation, Intel CPUs provide a RAPL interface (Running Average Power Limit) for advertising the accumulated energy consumption of various power domains (e.g. CPU packages, DRAM, etc.). The consumption is rep

Re: [PATCH] multifd: Set a higher "backlog" default value for listen()

2023-05-19 Thread Juan Quintela
"Wang, Wei W" wrote: > On Friday, May 19, 2023 10:52 AM, Wang, Lei4 wrote: >> > We can change it to uint16_t or uint32_t, but need to see if listening >> > on a larger value is OK to everyone. >> >> Is there any use case to use >256 migration channels? If not, then I suppose >> it's no need to in

Re: [PATCH v5 3/6] bswap: Add the ability to store to an unaligned 24 bit field

2023-05-19 Thread Jonathan Cameron via
On Sun, 23 Apr 2023 17:20:10 +0100 Jonathan Cameron wrote: > From: Ira Weiny > > CXL has 24 bit unaligned fields which need to be stored to. CXL is > specified as little endian. > > Define st24_le_p() and the supporting functions to store such a field > from a 32 bit host native value. > > T

Re: [PATCH v2 0/6] meson: use subprojects for bundled projects

2023-05-19 Thread Paolo Bonzini
On 5/19/23 11:32, Daniel P. Berrangé wrote: Feels like we should be able to figure out some way to get rid of all the submodules though, except for the roms, which are special and ok to leave IMHO Hmm, almost. roms/SLOF is used to build pc-bios/s390-ccw/s390-netboot.img, so right now GIT_SUBM

Re: [RFC PATCH] Add support for RAPL MSRs in KVM/Qemu

2023-05-19 Thread Anthony Harivel
Philippe Mathieu-Daudé, May 19, 2023 at 13:32: Hi Philippe, > > +/* > > + * Package statistic > > + * @ e_start: package energy counter before the sleep > > + * @ e_end: package energy counter after the sleep > > + * @ e_delta: delta of package energy counter > > + * @ e_ratio: store the energy r

Re: [PATCH 1/2] Add CI configuration for Kubernetes

2023-05-19 Thread Camilla Conte
On Fri, May 19, 2023 at 10:00 AM Daniel P. Berrangé wrote: > > On Fri, Apr 07, 2023 at 03:52:51PM +0100, Camilla Conte wrote: > > Configure Gitlab CI to run on Kubernetes > > according to the official documentation. > > https://docs.gitlab.com/ee/ci/docker/using_docker_build.html#docker-in-docker-

Re: [PATCH 1/2] Add CI configuration for Kubernetes

2023-05-19 Thread Daniel P . Berrangé
On Fri, May 19, 2023 at 01:33:50PM +0100, Camilla Conte wrote: > On Fri, May 19, 2023 at 10:00 AM Daniel P. Berrangé > wrote: > > > > On Fri, Apr 07, 2023 at 03:52:51PM +0100, Camilla Conte wrote: > > > Configure Gitlab CI to run on Kubernetes > > > according to the official documentation. > > >

Re: [PULL 04/29] arm/kvm: add support for MTE

2023-05-19 Thread Alex Bennée
Peter Maydell writes: > From: Cornelia Huck > > Extend the 'mte' property for the virt machine to cover KVM as > well. For KVM, we don't allocate tag memory, but instead enable the > capability. > > If MTE has been enabled, we need to disable migration, as we do not > yet have a way to migrate

Re: gitlab shared runner time expired

2023-05-19 Thread Richard Henderson
On 5/19/23 02:18, Peter Maydell wrote: On Thu, 18 May 2023 at 20:27, Richard Henderson wrote: So, here we are again, out of runner time with 13 days left in the month. This is quite early -- have you been processing pull requests strictly one at a time, or in (small) batches ? Mostly one a

Re: [PULL 04/29] arm/kvm: add support for MTE

2023-05-19 Thread Peter Maydell
On Fri, 19 May 2023 at 13:55, Alex Bennée wrote: > > > Peter Maydell writes: > > > From: Cornelia Huck > > > > Extend the 'mte' property for the virt machine to cover KVM as > > well. For KVM, we don't allocate tag memory, but instead enable the > > capability. > > > > If MTE has been enabled, w

[PATCH 3/6] tests/tcg/tricore: Add first C program

2023-05-19 Thread Bastian Koppelmann
this allows us to exercise the startup code used by GCC to call main(). Signed-off-by: Bastian Koppelmann --- configure | 1 + tests/tcg/tricore/Makefile.softmmu-target | 13 + tests/tcg/tricore/c/crt0-tc2x.S | 335 ++ tests/tcg/tr

[PATCH 4/6] target/tricore: Refactor PCXI/ICR register fields

2023-05-19 Thread Bastian Koppelmann
starting from ISA version 1.6.1 (previously known as 1.6P/E), some bitfields in PCXI and ICR have changed. We also refactor these registers using the register fields API. Signed-off-by: Bastian Koppelmann Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1453 --- target/tricore/cpu.h

[PATCH 0/6] TriCore PCXI/ICR register fixes

2023-05-19 Thread Bastian Koppelmann
Hi, the main motivator for this series was https://gitlab.com/qemu-project/qemu/-/issues/1453. To test that I'm not screwing up this refactor I also extended the tests by C programs so we can test the PCXI/ICR registers by recursive function call. Through these tests I also found a problem, where

[PATCH 1/6] tests/tcg/tricore: Move asm tests into 'asm' directory

2023-05-19 Thread Bastian Koppelmann
this seperates these tests from the upcoming tests written in C. Also rename the compiled test to 'test_.asm.tst'. Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile.softmmu-target | 35 --- tests/tcg/tricore/{ => asm}/macros.h | 0 tests/tcg/tricore/{ =>

[PATCH 5/6] target/tricore: Fix wrong PSW for call insns

2023-05-19 Thread Bastian Koppelmann
we were copying PSW into a local variable, updated PSW.CDE in the local and never wrote it back. So when we called save_context_upper() we were using the non-local version of PSW which did not contain the updated PSW.CDE. Signed-off-by: Bastian Koppelmann --- target/tricore/op_helper.c | 2 ++ 1

[PATCH 6/6] tests/tcg/tricore: Add recursion test for CSAs

2023-05-19 Thread Bastian Koppelmann
Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/Makefile.softmmu-target | 3 ++- tests/tcg/tricore/c/test_context_save_areas.c | 15 +++ 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 tests/tcg/tricore/c/test_context_save_areas.c diff --git a/tests/

[PATCH 2/6] tests/tcg/tricore: Uses label for memory addresses

2023-05-19 Thread Bastian Koppelmann
the linker might rearrange sections, so lets reference memory by label name instead of addr + off. Signed-off-by: Bastian Koppelmann --- tests/tcg/tricore/asm/macros.h | 1 - tests/tcg/tricore/asm/test_ld_bu.S | 4 ++-- tests/tcg/tricore/asm/test_ld_h.S | 8 3 files changed, 6 inse

Re: [PATCH v5 3/6] bswap: Add the ability to store to an unaligned 24 bit field

2023-05-19 Thread Jonathan Cameron via
On Fri, 19 May 2023 12:33:53 +0100 Jonathan Cameron wrote: > On Sun, 23 Apr 2023 17:20:10 +0100 > Jonathan Cameron wrote: > > > From: Ira Weiny > > > > CXL has 24 bit unaligned fields which need to be stored to. CXL is > > specified as little endian. > > > > Define st24_le_p() and the suppo

Re: [PATCH 1/2] Add CI configuration for Kubernetes

2023-05-19 Thread Camilla Conte
On Fri, May 19, 2023 at 1:51 PM Daniel P. Berrangé wrote: > > On Fri, May 19, 2023 at 01:33:50PM +0100, Camilla Conte wrote: > > On Fri, May 19, 2023 at 10:00 AM Daniel P. Berrangé > > wrote: > > > > > > On Fri, Apr 07, 2023 at 03:52:51PM +0100, Camilla Conte wrote: > > > > Configure Gitlab CI t

Re: [PATCH 1/2] Add CI configuration for Kubernetes

2023-05-19 Thread Daniel P . Berrangé
On Fri, May 19, 2023 at 03:06:41PM +0100, Camilla Conte wrote: > On Fri, May 19, 2023 at 1:51 PM Daniel P. Berrangé > wrote: > > > > On Fri, May 19, 2023 at 01:33:50PM +0100, Camilla Conte wrote: > > > On Fri, May 19, 2023 at 10:00 AM Daniel P. Berrangé > > > wrote: > > > > > > > > On Fri, Apr

[PATCH v6 0/4] hw/cxl: Poison get, inject, clear

2023-05-19 Thread Jonathan Cameron via
Note that Michael Tsirkin replied to v5 to say he has first 3 queued - the bswap one is buggy so should be dropped and replaced with this v6. Note changes in that patch were large enough that I've dropped Fan Ni's tag. Tested the problematic cross compiles using docker. v6: - Fix 24 bit bswap o

[PATCH v6 1/4] bswap: Add the ability to store to an unaligned 24 bit field

2023-05-19 Thread Jonathan Cameron via
From: Ira Weiny CXL has 24 bit unaligned fields which need to be stored to. CXL is specified as little endian. Define st24_le_p() and the supporting functions to store such a field from a 32 bit host native value. The use of b, w, l, q as the size specifier is limiting. So "24" was used for t

[PATCH v6 2/4] hw/cxl: QMP based poison injection support

2023-05-19 Thread Jonathan Cameron via
Inject poison using qmp command cxl-inject-poison to add an entry to the poison list. For now, the poison is not returned CXL.mem reads, but only via the mailbox command Get Poison List. So a normal memory read to an address that is on the poison list will not yet result in a synchronous exception

[PATCH v6 3/4] hw/cxl: Add poison injection via the mailbox.

2023-05-19 Thread Jonathan Cameron via
Very simple implementation to allow testing of corresponding kernel code. Note that for now we track each 64 byte section independently. Whilst a valid implementation choice, it may make sense to fuse entries so as to prove out more complex corners of the kernel code. Reviewed-by: Ira Weiny Revi

Re: [PATCH] hw/dma/xilinx_axidma: Check DMASR.HALTED to prevent infinite loop.

2023-05-19 Thread Tommy Wu
Thank Edgar E. Iglesias for the advice. I can submit another patch to do that. On Fri, May 19, 2023 at 2:39 PM Edgar E. Iglesias wrote: > > On Fri, May 19, 2023 at 8:21 AM Tommy Wu wrote: > >> When we receive a packet from the xilinx_axienet and then try to s2mem >> through the xilinx_axidma, i

[PATCH v6 4/4] hw/cxl: Add clear poison mailbox command support.

2023-05-19 Thread Jonathan Cameron via
Current implementation is very simple so many of the corner cases do not exist (e.g. fragmenting larger poison list entries) Reviewed-by: Fan Ni Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 82 + hw/mem/cxl_type3.c | 37 +

Re: [PATCH v2 04/19] test-cutils: Test more integer corner cases

2023-05-19 Thread Hanna Czenczek
On 12.05.23 04:10, Eric Blake wrote: We have quite a few undertested and underdocumented integer parsing corner cases. To ensure that any changes we make in the code are intentional rather than accidental semantic changes, it is time to add more unit tests of existing behavior. In particular, t

Re: [PATCH v2] hw/arm/sbsa-ref: add GIC node into DT

2023-05-19 Thread Leif Lindholm
On 2023-05-17 11:53, Marcin Juszkiewicz wrote: Let add GIC information into DeviceTree as part of SBSA-REF versioning. Trusted Firmware will read it and provide to next firmware level. Bumps platform version to 0.1 one so we can check is node is present. Signed-off-by: Marcin Juszkiewicz Re

[PATCH v6 0/7] QEMU CXL Provide mock CXL events and irq support

2023-05-19 Thread Jonathan Cameron via
v6: Rebase + no longer have any comments on patch v6 that should be below the --- cut mark, so issue from v5 fixes. Michael has queued all but last set of dependencies but listing everything here that isn't yet upstream for completeness. Note comemnt on the second to last series where only part of

[PATCH v6 1/7] hw/cxl/events: Add event status register

2023-05-19 Thread Jonathan Cameron via
From: Ira Weiny The device status register block was defined. However, there were no individual registers nor any data wired up. Define the event status register [CXL 3.0; 8.2.8.3.1] as part of the device status register block. Wire up the register and initialize the event status for each log.

[PATCH v6 2/7] hw/cxl: Move CXLRetCode definition to cxl_device.h

2023-05-19 Thread Jonathan Cameron via
Following patches will need access to the mailbox return code type so move it to the header. Reviewed-by: Ira Weiny Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 28 include/hw/cxl/cxl_device.h | 28 2 files changed,

[PATCH v6 3/7] hw/cxl/events: Wire up get/clear event mailbox commands

2023-05-19 Thread Jonathan Cameron via
From: Ira Weiny CXL testing is benefited from an artificial event log injection mechanism. Add an event log infrastructure to insert, get, and clear events from the various logs available on a device. Replace the stubbed out CXL Get/Clear Event mailbox commands with commands that operate on the

[PATCH v6 4/7] hw/cxl/events: Add event interrupt support

2023-05-19 Thread Jonathan Cameron via
From: Ira Weiny Replace the stubbed out CXL Get/Set Event interrupt policy mailbox commands. Enable those commands to control interrupts for each of the event log types. Skip the standard input mailbox length on the Set command due to DCD being optional. Perform the checks separately. Signed-

[PATCH v6 5/7] hw/cxl/events: Add injection of General Media Events

2023-05-19 Thread Jonathan Cameron via
From: Ira Weiny To facilitate testing provide a QMP command to inject a general media event. The event can be added to the log specified. Signed-off-by: Ira Weiny Signed-off-by: Jonathan Cameron --- hw/mem/cxl_type3.c | 111 hw/mem/cxl_type3_stub

[PATCH v6 6/7] hw/cxl/events: Add injection of DRAM events

2023-05-19 Thread Jonathan Cameron via
Defined in CXL r3.0 8.2.9.2.1.2 DRAM Event Record, this event provides information related to DRAM devices. Example injection command in QMP: { "execute": "cxl-inject-dram-event", "arguments": { "path": "/machine/peripheral/cxl-mem0", "log": "informational", "flags": 1

[PATCH v6 7/7] hw/cxl/events: Add injection of Memory Module Events

2023-05-19 Thread Jonathan Cameron via
These events include a copy of the device health information at the time of the event. Actually using the emulated device health would require a lot of controls to manipulate that state. Given the aim of this injection code is to just test the flows when events occur, inject the contents of the de

Re: [PULL v3 00/68] i386, build system, KVM changes for 2023-05-18

2023-05-19 Thread Peter Maydell
On Thu, 18 May 2023 at 12:41, Paolo Bonzini wrote: > > * kvm: enable dirty ring for arm64 > * target/i386: new features > * target/i386: AVX fixes > * configure: create a python venv unconditionally > * meson: bump to 0.63.0 and move

Re: [PATCH v2 05/19] cutils: Fix wraparound parsing in qemu_strtoui

2023-05-19 Thread Hanna Czenczek
On 12.05.23 04:10, Eric Blake wrote: While we were matching 32-bit strtol in qemu_strtoi, our use of a 64-bit parse was leaking through for some inaccurate answers in qemu_strtoui in comparison to a 32-bit strtoul. Fix those, and update the testsuite now that our bounds checks are correct. Our

  1   2   3   >