Re: [PATCH] Revert "hw/sparc64/niagara: Use blk_name() instead of open-coding it"

On 15/05/2023 16:11, Markus Armbruster wrote: This reverts commit 1881f336a33a8a99cb17ab1c57ed953682e8e107. This commit breaks "-drive if=pflash,readonly=on,file=image.iso". It claims to merely replace an open-coded version of blk_name() by a call, but that's not the case. Sorry for the incon

Re: [PATCH v3 1/9] target/ppc: Fix width of some 32-bit SPRs

On 15/05/2023 16:19, Nicholas Piggin wrote: On Mon May 15, 2023 at 10:03 PM AEST, Mark Cave-Ayland wrote: On 15/05/2023 10:26, Nicholas Piggin wrote: Some 32-bit SPRs are incorrectly implemented as 64-bits on 64-bit targets. This changes VRSAVE, DSISR, HDSISR, DAWRX0, PIDR, LPIDR, DEXCR, HDE

Re: [PULL 00/21] Tests, docs, s390x and misc patches

On 15/05/2023 22.53, Richard Henderson wrote: On 5/15/23 06:02, Thomas Huth wrote:   Hi Richard! The following changes since commit 8844bb8d896595ee1d25d21c770e6e6f29803097:    Merge tag 'or1k-pull-request-20230513' ofhttps://github.com/stffrdhrn/qemu  into staging (2023-05-13 11:23:14 +0100)

Re: [PATCH 1/3] ACPI: bios-tables-test.c step 2 (allowed-diff entries)

On Tue, May 16, 2023 at 2:03 AM Eric DeVolder wrote: > > Following the guidelines in tests/qtest/bios-tables-test.c, > set up bios-tables-test-allowed-diff.h to exclude the > imminent changes to the APIC tables, per step 2. > > Signed-off-by: Eric DeVolder Acked-by: Ani Sinha > --- > tests/qt

Re: [PATCH 2/3] ACPI: i386: bump to MADT to revision 3

On Tue, May 16, 2023 at 2:04 AM Eric DeVolder wrote: > > Currently i386 QEMU generates MADT revision 3, and reports > MADT revision 1. Set .revision to 3 to match reality. > > Link: > https://lore.kernel.org/linux-acpi/20230327191026.3454-1-eric.devolder@ora > cle.com/T/#t > Signed-off-by: Eric D

Re: [PATCH 3/3] ACPI: bios-tables-test.c step 5 (update expected table binaries)

On Tue, May 16, 2023 at 2:03 AM Eric DeVolder wrote: > > Following the guidelines in tests/qtest/bios-tables-test.c, this > is step 5 and 6. > > The MADT/APIC table diffs show (for pc, q35 and microvm) bumping > revision from 1 to 3 (and checksum changing accordingly): > > Using expected file 'te

[PULL SUBSYSTEM arm 0/8] TivaC Implementation

*** This is an implementation for the TivaC board. For now it models the system control block, the general purpose I/O, the general purpose timers, the watchdog timers and the usart module. The code is available at https://github.com/moesay/qemu_TivaC.git *** Mohamed ElSayed (8): the tivac mac

[PULL 1/8] the tivac machine def init commit

Signed-off-by: Mohamed ElSayed --- hw/arm/tivac.c| 56 ++ hw/arm/tm4c123gh6pm_soc.c | 274 ++ include/hw/arm/tm4c123gh6pm_soc.h | 71 3 files changed, 401 insertions(+) create mode 100644 hw/arm/tivac.c create mode 100644 hw

[PULL 4/8] tivac system control implementation

Signed-off-by: Mohamed ElSayed --- hw/misc/tm4c123_sysctl.c | 989 +++ include/hw/misc/tm4c123_sysctl.h | 307 ++ 2 files changed, 1296 insertions(+) create mode 100644 hw/misc/tm4c123_sysctl.c create mode 100644 include/hw/misc/tm4c123_sysctl.h diff

[PULL 6/8] tivac watchdog timers implementation

Signed-off-by: Mohamed ElSayed --- hw/watchdog/tm4c123_watchdog.c | 298 + include/hw/watchdog/tm4c123_watchdog.h | 97 2 files changed, 395 insertions(+) create mode 100644 hw/watchdog/tm4c123_watchdog.c create mode 100644 include/hw/watchdog/tm4c123_w

[PULL 7/8] editing the meson and KConfig files to add tivac to qemu build system

Signed-off-by: Mohamed ElSayed --- .gitignore | 1 + README.rst | 150 ++-- configs/devices/arm-softmmu/default.mak | 1 + hw/arm/Kconfig | 13 ++ hw/arm/meson.build |

[PULL 2/8] tivac usart module implementation

Signed-off-by: Mohamed ElSayed --- hw/char/tm4c123_usart.c | 387 include/hw/char/tm4c123_usart.h | 124 ++ 2 files changed, 511 insertions(+) create mode 100644 hw/char/tm4c123_usart.c create mode 100644 include/hw/char/tm4c123_usart.h diff --g

[PULL 8/8] code style fixes

Signed-off-by: Mohamed ElSayed --- hw/arm/tm4c123gh6pm_soc.c | 14 ++-- hw/char/tm4c123_usart.c| 28 +++ hw/misc/tm4c123_sysctl.c | 6 +- hw/timer/tm4c123_gptm.c| 134 - hw/watchdog/tm4c123_watchdog.c | 25 +++--- 5 files changed

[PULL 5/8] tivac general purpose timers implementation

Signed-off-by: Mohamed ElSayed --- hw/timer/tm4c123_gptm.c | 529 include/hw/timer/tm4c123_gptm.h | 131 2 files changed, 660 insertions(+) create mode 100644 hw/timer/tm4c123_gptm.c create mode 100644 include/hw/timer/tm4c123_gptm.h diff --git

[PULL 3/8] tivac gpio module implementation

Signed-off-by: Mohamed ElSayed --- hw/gpio/tm4c123_gpio.c | 372 + include/hw/gpio/tm4c123_gpio.h | 127 +++ 2 files changed, 499 insertions(+) create mode 100644 hw/gpio/tm4c123_gpio.c create mode 100644 include/hw/gpio/tm4c123_gpio.h diff --git

Re: [PATCH 0/3] ACPI: i386: bump MADT to revision 3

On Tue, May 16, 2023 at 2:03 AM Eric DeVolder wrote: > > The following Linux kernel change broke CPU hotplug for MADT revision > less than 5. > > e2869bd7af60 ("x86/acpi/boot: Do not register processors that cannot be > onlined for x2APIC") > > Discussion on this topic can be located here: > >

Re: [PATCH v4] target/ppc: Add POWER9 DD2.2 model

On 15/05/2023 18:02, Nicholas Piggin wrote: POWER9 DD2.1 and earlier had significant limitations when running KVM, including lack of "mixed mode" MMU support (ability to run HPT and RPT mode on threads of the same core), and a translation prefetch issue which is worked around by disabling "AIL

Re: [PATCH v4] target/ppc: Add POWER9 DD2.2 model

On 15/05/2023 18:02, Nicholas Piggin wrote: POWER9 DD2.1 and earlier had significant limitations when running KVM, including lack of "mixed mode" MMU support (ability to run HPT and RPT mode on threads of the same core), and a translation prefetch issue which is worked around by disabling "AIL

Re: [PATCH] Revert "hw/sparc64/niagara: Use blk_name() instead of open-coding it"

Mark Cave-Ayland writes: > On 15/05/2023 16:11, Markus Armbruster wrote: > >> This reverts commit 1881f336a33a8a99cb17ab1c57ed953682e8e107. >> This commit breaks "-drive if=pflash,readonly=on,file=image.iso". It >> claims to merely replace an open-coded version of blk_name() by a >> call, but th

[PATCH v2] cryptodev-vhost-user: add asymmetric crypto support

Add asymmetric crypto support in vhost_user backend. Signed-off-by: Gowrishankar Muthukrishnan --- v2: - added buffer length check before memcpy. --- backends/cryptodev-vhost-user.c | 9 ++-- hw/virtio/vhost-user.c | 75 +++-- 2 files changed, 66 insertion

[PATCH] memory: stricter checks prior to unsetting engaged_in_io

engaged_in_io could be unset by an MR with re-entrancy checks disabled. Ensure that only MRs that can set the engaged_in_io flag can unset it. Closes: https://gitlab.com/qemu-project/qemu/-/issues/1563 Reported-by: Thomas Huth Signed-off-by: Alexander Bulekov --- softmmu/memory.c | 4 +++- 1 fi

Re: [PATCH] target/ppc: Use SMT4 small core chip type in POWER9/10 PVRs

On 5/15/23 21:31, Nicholas Piggin wrote: QEMU's PVR value for POWER9 DD2.0 has chip type 1, which is the SMT4 "small core" type that OpenPOWER processors use. QEMU's PVR for all other POWER9/10 have chip type 0, which "enterprise" systems use. The difference does not really matter to QEMU (bec

Re: [PATCH v4] target/ppc: Add POWER9 DD2.2 model

On 5/15/23 18:02, Nicholas Piggin wrote: POWER9 DD2.1 and earlier had significant limitations when running KVM, including lack of "mixed mode" MMU support (ability to run HPT and RPT mode on threads of the same core), and a translation prefetch issue which is worked around by disabling "AIL" mode

Re: [PATCH] target/ppc: Use SMT4 small core chip type in POWER9/10 PVRs

On 5/15/23 18:01, Nicholas Piggin wrote: QEMU's PVR value for POWER9 DD2.0 has chip type 1, which is the SMT4 "small core" type that OpenPOWER processors use. QEMU's PVR for all other POWER9/10 have chip type 0, which "enterprise" systems use. The difference does not really matter to QEMU (becau

Re: [PATCH v2 5/6] qmp: Added new command to retrieve eBPF blob.

Daniel P. Berrangé writes: > Question for Markus at the bottom > > On Fri, May 12, 2023 at 03:29:01PM +0300, Andrew Melnychenko wrote: >> Added command "request-ebpf". This command returns >> eBPF program encoded base64. The program taken from the >> skeleton and essentially is an ELF object

Re: [RFC PATCH 0/1] virtio-balloon: Add Working Set Reporting feature

I can look at how the QAPI interface is done, but before I do that, I'd like to see a review of feature as a whole by subject matter experts. Any takers?

Re: [PATCH v2 5/6] qmp: Added new command to retrieve eBPF blob.

On Tue, May 16, 2023 at 10:47:52AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > Question for Markus at the bottom > > > > On Fri, May 12, 2023 at 03:29:01PM +0300, Andrew Melnychenko wrote: > >> Added command "request-ebpf". This command returns > >> eBPF program encoded

Re: [PATCH] vfio/pci: Fix a use-after-free issue

On 5/16/23 05:43, Zhenzhong Duan wrote: We should free the duplicated variant of vbasedev->name plus uuid rather than vbasedev->name itself. Fixes: 2dca1b37a7 ("vfio/pci: add support for VF toke") "toke" -> "token" Signed-off-by: Zhenzhong Duan --- hw/vfio/pci.c | 4 +++- 1 file changed,

Re: [PATCH v4 6/8] migration: modified 'migrate' QAPI to accept 'channels' argument for migration

On Tue, May 16, 2023 at 11:18:16AM +0530, Het Gala wrote: > > On 15/05/23 4:06 pm, Daniel P. Berrangé wrote: > > On Fri, May 12, 2023 at 02:32:38PM +, Het Gala wrote: > > > MigrateChannelList ideally allows to connect accross multiple interfaces. > > > > > > Added MigrateChannelList struct as

[PATCH] lsi53c895a: disable reentrancy detection for MMIO region, too

While trying to use a SCSI disk on the LSI controller with an older version of Fedora (25), I'm getting: qemu: warning: Blocked re-entrant IO on MemoryRegion: lsi-mmio at addr: 0x34 and the SCSI controller is not usable. Seems like we have to disable the reentrancy checker for the MMIO region, t

Re: [PULL SUBSYSTEM arm 0/8] TivaC Implementation

Mohamed ElSayed writes: > *** > This is an implementation for the TivaC board. > For now it models the system control block, the general purpose I/O, the > general purpose timers, the watchdog timers and the usart module. > > The code is available at https://github.com/moesay/qemu_TivaC.git >

Re: [PULL 0/9] Linux user for 8.1 patches

Le 15/05/2023 à 17:50, Laurent Vivier a écrit : Le 15/05/2023 à 15:55, Richard Henderson a écrit : On 5/15/23 01:31, Laurent Vivier wrote: The following changes since commit 7c18f2d663521f1b31b821a13358ce38075eaf7d:    Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2

Re: [PATCH v2 01/16] migration: Don't use INT64_MAX for unlimited rate

Juan Quintela writes: > Define and use RATE_LIMIT_MAX instead. Suggest "RATE_LIMIT_MAX_NONE". > > Signed-off-by: Juan Quintela > --- > migration/migration-stats.h | 6 ++ > migration/migration.c | 4 ++-- > migration/qemu-file.c | 6 +- > 3 files changed, 13 insertions(+),

Re: Gpio in vexpress

On Tue, 16 May 2023 at 07:36, ido berenbaum wrote: > > Hi, I was trying to understand the architecture of the vexpress virtual > machine in regards to adding new gpios that are going to be external. > First, is it right to act as if I am developing on a physical board and add > the gpios to the

Re: [PATCH v4] target/ppc: Add POWER9 DD2.2 model

On 5/15/23 21:32, Nicholas Piggin wrote: POWER9 DD2.1 and earlier had significant limitations when running KVM, including lack of "mixed mode" MMU support (ability to run HPT and RPT mode on threads of the same core), and a translation prefetch issue which is worked around by disabling "AIL" mo

Re: [PATCH v2 01/16] migration: Don't use INT64_MAX for unlimited rate

David Edmondson wrote: > Juan Quintela writes: > >> Define and use RATE_LIMIT_MAX instead. > > Suggest "RATE_LIMIT_MAX_NONE". Then even better RATE_LIMIT_DISABLED? RATE_LIMIT_NONE? Using MAX and NONE at the same time looks strange. >> Signed-off-by: Juan Quintela >> --- >> migration/migrati

Re: [PATCH] lsi53c895a: disable reentrancy detection for MMIO region, too

On 230516 1105, Thomas Huth wrote: > While trying to use a SCSI disk on the LSI controller with an > older version of Fedora (25), I'm getting: > > qemu: warning: Blocked re-entrant IO on MemoryRegion: lsi-mmio at addr: 0x34 Do you have a gdb backtrace for this one or is there some easy way to r

Re: [PATCH v3 2/9] target/ppc: Fix PMU MMCR0[PMCjCE] bit in hflags calculation

On 5/15/23 06:26, Nicholas Piggin wrote: A store to MMCR0 with PMCjCE=1 fails to update hflags correctly and results in hflags mismatch: qemu: fatal: TCG hflags mismatch (current:0x2408003d rebuilt:0x240a003d) This can be reproduced by running perf on a recent machine. Signed-off-by: Nic

Re: [PATCH v2 02/16] migration: Correct transferred bytes value

Juan Quintela writes: > We forget several places to add to trasferred amount of data. With "transferred". > this fixes I get: > >qemu_file_transferred() + multifd_bytes == transferred > > The only place whrer this is not true is during devices sending. But "where" > going all through th

Re: [PATCH v3 1/9] target/ppc: Fix width of some 32-bit SPRs

On Tue May 16, 2023 at 5:02 PM AEST, Mark Cave-Ayland wrote: > On 15/05/2023 16:19, Nicholas Piggin wrote: > > > On Mon May 15, 2023 at 10:03 PM AEST, Mark Cave-Ayland wrote: > >> On 15/05/2023 10:26, Nicholas Piggin wrote: > >> > >>> Some 32-bit SPRs are incorrectly implemented as 64-bits on 64-bi

Re: [PATCH v4] target/ppc: Add POWER9 DD2.2 model

On Tue May 16, 2023 at 5:58 PM AEST, Frederic Barrat wrote: > > > On 15/05/2023 18:02, Nicholas Piggin wrote: > > POWER9 DD2.1 and earlier had significant limitations when running KVM, > > including lack of "mixed mode" MMU support (ability to run HPT and RPT > > mode on threads of the same core),

Re: [PATCH] target/ppc: Use SMT4 small core chip type in POWER9/10 PVRs

On Tue May 16, 2023 at 6:43 PM AEST, Harsh Prateek Bora wrote: > > > On 5/15/23 21:31, Nicholas Piggin wrote: > > QEMU's PVR value for POWER9 DD2.0 has chip type 1, which is the SMT4 > > "small core" type that OpenPOWER processors use. QEMU's PVR for all > > other POWER9/10 have chip type 0, which

Re: [PATCH v2 03/16] migration: Move setup_time to mig_stats

Juan Quintela writes: > It is a time that needs to be cleaned each time cancel migration. > Once there create migration_time_since() to calculate how time since a > time in the past. > > Signed-off-by: Juan Quintela > > --- > > Rename to migration_time_since (cédric) > --- > migration/migration

Re: [PATCH v4] target/ppc: Add POWER9 DD2.2 model

On Tue May 16, 2023 at 5:56 PM AEST, Frederic Barrat wrote: > > > On 15/05/2023 18:02, Nicholas Piggin wrote: > > POWER9 DD2.1 and earlier had significant limitations when running KVM, > > including lack of "mixed mode" MMU support (ability to run HPT and RPT > > mode on threads of the same core),

Re: [PATCH v5 31/54] tcg/loongarch64: Check the host supports unaligned accesses

On Mon, 15 May 2023 at 15:39, Richard Henderson wrote: > > This should be true of all loongarch64 running Linux. > > Signed-off-by: Richard Henderson > --- > tcg/loongarch64/tcg-target.c.inc | 9 + > 1 file changed, 9 insertions(+) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] scsi/lsi53c895a: restrict DMA engine to memory regions (CVE-2023-0330)

On 16/01/2023 21.42, Mauro Matteo Cascella wrote: This prevents the well known DMA-MMIO reentrancy problem (upstream issue #556) leading to memory corruption bugs like stack overflow or use-after-free. Fixes: CVE-2023-0330 Signed-off-by: Mauro Matteo Cascella Reported-by: Zheyu Ma --- Since

Re: [PATCH v2 01/16] migration: Don't use INT64_MAX for unlimited rate

Juan Quintela writes: > David Edmondson wrote: >> Juan Quintela writes: >> >>> Define and use RATE_LIMIT_MAX instead. >> >> Suggest "RATE_LIMIT_MAX_NONE". > > Then even better > > RATE_LIMIT_DISABLED? > RATE_LIMIT_NONE? RATE_LIMIT_NONE sounds good to me. > > Using MAX and NONE at the same tim

Re: [PATCH v4] target/ppc: Add POWER9 DD2.2 model

On Tue May 16, 2023 at 6:44 PM AEST, Cédric Le Goater wrote: > On 5/15/23 18:02, Nicholas Piggin wrote: > > POWER9 DD2.1 and earlier had significant limitations when running KVM, > > including lack of "mixed mode" MMU support (ability to run HPT and RPT > > mode on threads of the same core), and a

RE: [PATCH] vfio/pci: Fix a use-after-free issue

>-Original Message- >From: Cédric Le Goater >Sent: Tuesday, May 16, 2023 4:58 PM >To: Duan, Zhenzhong ; qemu- >de...@nongnu.org >Cc: minwoo...@samsung.com; alex.william...@redhat.com; Peng, Chao P > >Subject: Re: [PATCH] vfio/pci: Fix a use-after-free issue > >On 5/16/23 05:43, Zhenzhong

Re: [PATCH v5 36/54] tcg: Introduce tcg_out_movext3

On Mon, 15 May 2023 at 15:43, Richard Henderson wrote: > > With x86_64 as host, we do not have any temporaries with which to > resolve cycles, but we do have xchg. As a side bonus, the set of > graphs that can be made with 3 nodes and all nodes conflicting is > small: two. We can solve the cycl

RE: [PATCH v11 05/11] vfio/migration: Block multiple devices migration

> -Original Message- > From: > qemu-devel-bounces+shameerali.kolothum.thodi=huawei@nongnu.org > [mailto:qemu-devel-bounces+shameerali.kolothum.thodi=huawei.com@nong > nu.org] On Behalf Of Avihai Horon > Sent: 16 February 2023 14:36 > To: qemu-devel@nongnu.org > Cc: Alex Williamson ; J

Re: [PATCH v5 37/54] tcg: Merge tcg_out_helper_load_regs into caller

On Mon, 15 May 2023 at 15:38, Richard Henderson wrote: > > Now that tcg_out_helper_load_regs is not recursive, we can > merge it into its only caller, tcg_out_helper_load_slots. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] target/ppc: Use SMT4 small core chip type in POWER9/10 PVRs

On Tue May 16, 2023 at 6:44 PM AEST, Cédric Le Goater wrote: > On 5/15/23 18:01, Nicholas Piggin wrote: > > QEMU's PVR value for POWER9 DD2.0 has chip type 1, which is the SMT4 > > "small core" type that OpenPOWER processors use. QEMU's PVR for all > > other POWER9/10 have chip type 0, which "enter

Re: [PATCH v2 03/16] migration: Move setup_time to mig_stats

David Edmondson wrote: > Juan Quintela writes: > >> It is a time that needs to be cleaned each time cancel migration. >> Once there create migration_time_since() to calculate how time since a >> time in the past. >> >> Signed-off-by: Juan Quintela >> >> --- >> >> Rename to migration_time_since (

Re: [PATCH] lsi53c895a: disable reentrancy detection for MMIO region, too

On 16/05/2023 11.27, Alexander Bulekov wrote: On 230516 1105, Thomas Huth wrote: While trying to use a SCSI disk on the LSI controller with an older version of Fedora (25), I'm getting: qemu: warning: Blocked re-entrant IO on MemoryRegion: lsi-mmio at addr: 0x34 Do you have a gdb backtrace

Re: [PATCH v5 39/54] tcg: Introduce atom_and_align_for_opc

On Mon, 15 May 2023 at 15:43, Richard Henderson wrote: > > Examine MemOp for atomicity and alignment, adjusting alignment > as required to implement atomicity on the host. > > Signed-off-by: Richard Henderson > --- > v5: Dropped r-b because of MO_ATOM_* reorg > Return a struct with the result

Re: [PATCH v5 40/54] tcg/i386: Use atom_and_align_for_opc

On Mon, 15 May 2023 at 15:40, Richard Henderson wrote: > > No change to the ultimate load/store routines yet, so some atomicity > conditions not yet honored, but plumbs the change to alignment through > the relevant functions. > > Signed-off-by: Richard Henderson > --- > v5: Removed r-b for chang

Re: [PATCH v5 45/54] tcg/ppc: Use atom_and_align_for_opc

On Mon, 15 May 2023 at 15:42, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > tcg/ppc/tcg-target.c.inc | 19 ++- > 1 file changed, 18 insertions(+), 1 deletion(-) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v4] target/ppc: Add POWER9 DD2.2 model

On Tue May 16, 2023 at 7:23 PM AEST, Harsh Prateek Bora wrote: > > > On 5/15/23 21:32, Nicholas Piggin wrote: > > POWER9 DD2.1 and earlier had significant limitations when running KVM, > > including lack of "mixed mode" MMU support (ability to run HPT and RPT > > mode on threads of the same core),

Re: [PATCH v5 46/54] tcg/riscv: Use atom_and_align_for_opc

On Mon, 15 May 2023 at 15:39, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > tcg/riscv/tcg-target.c.inc | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v4 6/8] migration: modified 'migrate' QAPI to accept 'channels' argument for migration

On 16/05/23 2:27 pm, Daniel P. Berrangé wrote: On Tue, May 16, 2023 at 11:18:16AM +0530, Het Gala wrote: On 15/05/23 4:06 pm, Daniel P. Berrangé wrote: On Fri, May 12, 2023 at 02:32:38PM +, Het Gala wrote: MigrateChannelList ideally allows to connect accross multiple interfaces. @@ -51,

Re: [PATCH v5 48/54] tcg/sparc64: Use atom_and_align_for_opc

On Mon, 15 May 2023 at 15:39, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > tcg/sparc64/tcg-target.c.inc | 21 - > 1 file changed, 12 insertions(+), 9 deletions(-) Reviewed-by: Peter Maydell thanks -- PMM

[PATCH] hw/scsi/lsi53c895a: Fix reentrancy issues in the LSI controller (CVE-2023-0330)

We cannot use the generic reentrancy guard in the LSI code, so we have to manually prevent endless reentrancy here. The problematic lsi_execute_script() function has already a way to detect whether too many instructions have been executed - we just have to slightly change the logic here that it als

Re: [PULL 0/9] Linux user for 8.1 patches

Hey Laurent, I was having some issues reproducing this bug, but that looks like a likely explanation! Should I resubmit the patch with that diff applied? Thanks! On 5/16/2023 10:11 AM, Laurent Vivier wrote: Le 15/05/2023 à 17:50, Laurent Vivier a écrit : Le 15/05/2023 à 15:55, Richard Hend

Re: [PATCH v2 5/6] qmp: Added new command to retrieve eBPF blob.

Daniel P. Berrangé writes: > On Tue, May 16, 2023 at 10:47:52AM +0200, Markus Armbruster wrote: [...] >> So, this is basically a way to retrieve an eBPF program by some >> well-known name. >> >> Ignorant question: how are these programs desposited? > > The eBPF code blob is linked into QEMU at

Re: [PATCH v2 5/6] qmp: Added new command to retrieve eBPF blob.

On Tue, May 16, 2023 at 12:23:28PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, May 16, 2023 at 10:47:52AM +0200, Markus Armbruster wrote: > > [...] > > >> So, this is basically a way to retrieve an eBPF program by some > >> well-known name. > >> > >> Ignorant que

Re: [PATCH v4 0/8] migration: Modified 'migrate' and 'migrate-incoming' QAPI commands for migration

Doesn't apply to current master anymore, and patchew couldn't apply it, either[*]. I'll look at v5. Thanks! [*] https://patchew.org/QEMU/20230512143240.192504-1-het.g...@nutanix.com/

Re: [PATCH v5 10/54] accel/tcg: Use have_atomic16 in ldst_atomicity.c.inc

On Mon, 15 May 2023 at 15:37, Richard Henderson wrote: > > Hosts using Intel and AMD AVX cpus are quite common. > Add fast paths through ldst_atomicity using this. > > Only enable with CONFIG_INT128; some older clang versions do not > support __int128_t, and the inline assembly won't work on struc

Re: [PATCH v3 2/9] target/ppc: Fix PMU MMCR0[PMCjCE] bit in hflags calculation

On Tue May 16, 2023 at 7:32 PM AEST, Daniel Henrique Barboza wrote: > > > On 5/15/23 06:26, Nicholas Piggin wrote: > > A store to MMCR0 with PMCjCE=1 fails to update hflags correctly and > > results in hflags mismatch: > > > >qemu: fatal: TCG hflags mismatch (current:0x2408003d rebuilt:0x240a0

[RFC PATCH] target/arm: add RAZ/WI handling for DBGDTR[TX|RX]

The commit b3aa2f2128 (target/arm: provide stubs for more external debug registers) was added to handle HyperV's unconditional usage of Debug Communications Channel. It turns out that Linux will similarly break if you enable CONFIG_HVC_DCC "ARM JTAG DCC console". Extend the registers we RAZ/WI set

Re: [PULL 0/9] Linux user for 8.1 patches

Le 16/05/2023 à 12:20, Afonso Bordado a écrit : Hey Laurent, I was having some issues reproducing this bug, but that looks like a likely explanation! Should I resubmit the patch with that diff applied? No, I'm going to update it. Thanks, Laurent Thanks! On 5/16/2023 10:11 AM, Laurent Vi

Re: [PATCH v5 29/54] tcg/sparc64: Use standard slow path for softmmu

On Mon, 15 May 2023 at 15:38, Richard Henderson wrote: > > Drop the target-specific trampolines for the standard slow path. > This lets us use tcg_out_helper_{ld,st}_args, and handles the new > atomicity bits within MemOp. > > At the same time, use the full load/store helpers for user-only mode. >

[PATCH v2 00/27] configure: create a python venv and ensure meson, sphinx

This patch series creates a mandatory python virtual environment ("venv") during configure time and uses it to ensure the availability of meson and sphinx. See https://www.qemu.org/2023/03/24/python/ for motivations. The summary is that the goal of this series is to ensure that the `python` used t

[PATCH v2 02/27] python: update pylint configuration

From: John Snow Pylint 2.17.x decided that SocketAddrT was a bad name for a Type Alias for some reason. Sure, fine, whatever. Signed-off-by: John Snow Reviewed-by: Daniel P. Berrangé Message-Id: <20230511035435.734312-3-js...@redhat.com> Signed-off-by: Paolo Bonzini --- python/setup.cfg | 1

[PATCH v2 07/27] mkvenv: add --diagnose option to explain "ensure" failures

From: John Snow This is a routine that is designed to print some usable info for human beings back out to the terminal if/when "mkvenv ensure" fails to locate or install a package during configure time, such as meson or sphinx. Since we are requiring that "meson" and "sphinx" are installed to th

[PATCH v2 01/27] python: shut up "pip install" during "make check-minreqs"

"make check-minreqs" runs pip without the --disable-pip-version-check option, which causes the obnoxious "A new release of pip available" message. Recent versions of pip also complain that some of the dependencies in our virtual environment rely on "setup.py install" instead of providing a pyproje

[PATCH v2 13/27] tests/vm: Configure netbsd to use Python 3.10

From: John Snow NetBSD removes some packages from the Python stdlib, but only re-packages them for Python 3.10. Switch to using Python 3.10. Signed-off-by: John Snow Reviewed-by: Daniel P. Berrangé Message-Id: <20230511035435.734312-13-js...@redhat.com> Signed-off-by: Paolo Bonzini --- tests

[PATCH v2 09/27] mkvenv: use pip's vendored distlib as a fallback

From: John Snow distlib is usually not installed on Linux distribution, but it is vendored into pip. Because the virtual environment has pip via ensurepip, we can piggy-back on pip's vendored version. This could break if they move our cheese in the future, but the fix would be simply to require

[PATCH v2 05/27] mkvenv: add nested venv workaround

From: John Snow Python virtual environments do not typically nest; they may inherit from the top-level system packages or not at all. For our purposes, it would be convenient to emulate "nested" virtual environments to allow callers of the configure script to install specific versions of python

[PATCH v2 18/27] configure: use 'mkvenv ensure meson' to bootstrap meson

From: John Snow This commit changes how we detect and install meson. It notably removes '--meson='. Currently, configure creates a lightweight Python virtual environment unconditionally using the user's configured $python that inherits system packages. Temporarily, we forced the use of meson sou

[PATCH v2 27/27] python: bump some of the dependencies

The version of pyflakes that is listed in python/tests/minreqs.txt breaks on Python 3.8 with the following message: AttributeError: 'FlakesChecker' object has no attribute 'CONSTANT' Now that we do not support EOL'd Python versions anymore, we can update to newer, fixed versions. It is a good

[PATCH v2 11/27] mkvenv: work around broken pip installations on Debian 10

From: John Snow This is a workaround intended for Debian 10, where the debian-patched pip does not function correctly if accessed from within a virtual environment. We don't support Debian 10 as a build platform any longer, though we do still utilize it for our build-tricore-softmmu CI test. It'

[PATCH v2 12/27] tests/docker: add python3-venv dependency

From: John Snow Several debian-based tests need the python3-venv dependency as a consequence of Debian debundling the "ensurepip" module normally included with Python. As mkvenv.py stands as of this commit, Debian requires EITHER: (A) setuptools and pip, or (B) ensurepip mkvenv is a few second

[PATCH v2 26/27] mkvenv: mark command as required

This is only available in Python 3.7+. Signed-off-by: Paolo Bonzini Signed-off-by: John Snow Message-Id: <20230511035435.734312-26-js...@redhat.com> Signed-off-by: Paolo Bonzini --- python/scripts/mkvenv.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/scripts/mkvenv.py b/python/s

[PATCH v2 15/27] python: add vendor.py utility

From: John Snow This is a teeny-tiny script that just downloads any packages we want to vendor from PyPI and stores them in qemu.git/python/wheels/. If I'm hit by a meteor, it'll be easy to replicate what I have done in order to udpate the vendored source. We don't really care which python runs

[PATCH v2 14/27] tests/vm: add py310-expat to NetBSD

From: John Snow NetBSD cannot successfully run "ensurepip" without access to the pyexpat module, which NetBSD debundles. Like the Debian patch, it would be strictly faster long term to install pip/setuptools, and I recommend developers at their workstations take that approach instead. For the pu

[PATCH v2 23/27] configure: add --enable-pypi and --disable-pypi

From: John Snow In the event that there's no vendored source present and no sufficient version of $package can be found, we will attempt to connect to PyPI to install the package if '--disable-pypi' was not passed. This means that PyPI access is "enabled by default", but there are some subtletie

[PATCH v2 22/27] configure: bootstrap sphinx with mkvenv

From: John Snow When docs are explicitly requested, require Sphinx>=1.6.0. When docs are explicitly disabled, don't bother to check for Sphinx at all. If docs are set to "auto", attempt to locate Sphinx, but continue onward if it wasn't located. Signed-off-by: Paolo Bonzini Signed-off-by: John

Re: [RFC PATCH 1/1] virtio-balloon: Add Working Set Reporting feature

* T.J. Alumbaugh (talum...@google.com) wrote: > Working Set Reporting supported in virtio-balloon. > - adds working set reporting and notification vqueues > - QMP API additions: >- guest-ws property on balloon >- generates QMP WS_EVENT when new reports available >- ws_config, ws_requ

[PATCH v2 08/27] mkvenv: add console script entry point generation

From: John Snow When creating a virtual environment that inherits system packages, script entry points (like "meson", "sphinx-build", etc) are not re-generated with the correct shebang. When you are *inside* of the venv, this is not a problem, but if you are *outside* of it, you will not have a s

[PATCH v2 20/27] tests: Use configure-provided pyvenv for tests

From: John Snow This patch changes how the avocado tests are provided, ever so slightly. Instead of creating a new testing venv, use the configure-provided 'pyvenv' instead, and install optional packages into that. Signed-off-by: John Snow Message-Id: <20230511035435.734312-20-js...@redhat.com>

[PATCH v2 16/27] configure: create a python venv unconditionally

From: John Snow This patch changes the configure script so that it always creates and uses a python virtual environment unconditionally. Meson bootstrapping is temporarily altered to force the use of meson from git or vendored source (as packaged in our source tarballs). A subsequent commit rest

[PATCH v2 25/27] configure: Add courtesy hint to Python version failure message

From: John Snow If we begin requiring Python 3.7+, a few platforms are going to need to install an additional Python interpreter package. As a courtesy to the user, suggest the optional package they might need to install. This will hopefully minimize any downtime caused by the change in Python d

[PATCH v2 06/27] mkvenv: add ensure subcommand

From: John Snow This command is to be used to add various packages (or ensure they're already present) into the configure-provided venv in a modular fashion. Examples: mkvenv ensure --online --dir "${source_dir}/python/wheels/" "meson>=0.61.5" mkvenv ensure --online "sphinx>=1.6.0" mkvenv ensur

[PATCH v2 04/27] mkvenv: add better error message for broken or missing ensurepip

From: John Snow Debian debundles ensurepip for python; NetBSD debundles pyexpat but ensurepip needs pyexpat. Try our best to offer a helpful error message instead of just failing catastrophically. Signed-off-by: John Snow Message-Id: <20230511035435.734312-5-js...@redhat.com> Signed-off-by: Pao

[PATCH v2 10/27] mkvenv: avoid ensurepip if pip is installed

From: John Snow Signed-off-by: Paolo Bonzini --- python/scripts/mkvenv.py | 67 ++-- 1 file changed, 64 insertions(+), 3 deletions(-) diff --git a/python/scripts/mkvenv.py b/python/scripts/mkvenv.py index 9e50bfb1778b..7fc30dc1b3e8 100644 --- a/python/script

[PATCH v2 24/27] Python: Drop support for Python 3.6

Python 3.6 was EOL 2021-12-31. Newer versions of upstream libraries have begun dropping support for this version and it is becoming more cumbersome to support. Avocado-framework and qemu.qmp each have their own reasons for wanting to drop Python 3.6, but won't until QEMU does. Versions of Python a

[PATCH v2 21/27] configure: move --enable-docs and --disable-docs back to configure

From: John Snow Move this option back from meson into configure for the purposes of using the configuration value to bootstrap Sphinx in different ways based on this value. Signed-off-by: John Snow Message-Id: <20230511035435.734312-21-js...@redhat.com> Signed-off-by: Paolo Bonzini --- config

[PATCH v2 19/27] qemu.git: drop meson git submodule

From: John Snow Now that meson is installed from a vendored wheel, we don't need the git submodule anymore. Drop it. Signed-off-by: John Snow Message-Id: <20230511035435.734312-19-js...@redhat.com> Signed-off-by: Paolo Bonzini --- .gitmodules | 3 --- meson | 1 - 2 files changed, 4 del

[PATCH v2 03/27] python: add mkvenv.py

From: John Snow This script will be responsible for building a lightweight Python virtual environment at configure time. It works with Python 3.6 or newer. It has been designed to: - work *offline*, no PyPI required. - work *quickly*, The fast path is only ~65ms on my machine. - work *robustly*,

  1   2   3   4   >