Re: [PATCH 2/2] hw/arm/vexpress: Avoid trivial memory leak of 'flashalias'

On 12/5/23 19:02, Peter Maydell wrote: In the vexpress board code, we allocate a new MemoryRegion at the top of vexpress_common_init() but only set it up and use it inside the "if (map[VE_NORFLASHALIAS] != -1)" conditional, so we leak it if not. This isn't a very interesting leak as it's a tiny a

Re: [PATCH 2/4] hw/arm/omap: Remove unused omap_uart_attach()

On 13/5/23 12:09, Bernhard Beschow wrote: The function is unused since commit bdad3654d3c55f478e538037d9eccd204e5fc8ee ('hw/arm/nseries: Remove invalid/unnecessary n8x0_uart_setup()'). Signed-off-by: Bernhard Beschow --- include/hw/arm/omap.h | 1 - hw/char/omap_uart.c | 9 - 2 fi

Re: [PATCH 1/4] hw/timer/i8254_common: Share "iobase" property via base class

On 13/5/23 12:09, Bernhard Beschow wrote: Both TYPE_KVM_I8254 and TYPE_I8254 have their own but same implementation of the "iobase" property. The storage for the property already resides in PITCommonState, so also move the property definition there. Signed-off-by: Bernhard Beschow --- hw/i386

Re: [PATCH v3] tests/avocado: Add LoongArch machine start test

On 5/13/23 03:27, Song Gao wrote: Add a new test in tests/avocado to check LoongArch virt machine start. Reviewed-by: Thomas Huth Signed-off-by: Song Gao Reviewed-by: Cédric Le Goater Thanks, C. --- MAINTAINERS| 1 + tests/avocado/machine_loongarch.py | 58 ++

[PATCH] hw: Fix format for comments

Simply fix the #vcpus_count to @vcpus_count in CPUArchId comments. Since we are at here, resort the parameters in comments to match the sequence of parameters which defined in the CPUArchId. CC: Igor Mammedov Signed-off-by: Shaoqin Huang --- include/hw/boards.h | 4 ++-- 1 file changed, 2 inser

Re: [PATCH v7 1/1] util/async-teardown: wire up query-command-line-options

On 05/05/2023 14.00, Claudio Imbrenda wrote: Add new -run-with option with an async-teardown=on|off parameter. It is visible in the output of query-command-line-options QMP command, so it can be discovered and used by libvirt. The option -async-teardown is now redundant, deprecate it. ... diff

[PATCH] qcow2: add discard-no-unref option

When we for example have a sparse qcow2 image and discard: unmap is enabled, there can be a lot of fragmentation in the image after some time. Surely on VM's that do a lot of writes/deletes. This causes the qcow2 image to grow even over 110% of its virtual size, because the free gaps in the image g

Re: [PATCH] block: Add zeroes discard option

Uploaded a new patch which might be better/cleaner :) "[PATCH] qcow2: add discard-no-unref option" That patch only applies to qcow2 and also passes unmap further down the storage stack. On 10/05/2023 16:27, Jean-Louis Dupond wrote: When we for example have a sparse qcow2 image and discard: un

Re: [PATCH v2 05/12] simpletrace: Changed Analyzer class to become context-manager

> > Bearing in mind compatibility with existing simpletrace analysis > scripts, how about the following default method implementations? > > def __enter__(self): > self.begin() > > def __exit__(self, exc_type, exc_val, exc_tb): > if exc_type is None: > self.end() > ret

Re: [PATCH] net: stream: test reconnect option with an unix socket

On 03/05/2023 11.41, Laurent Vivier wrote: We can have failure with the inet type test because the port address is not allocated atomically and can be taken by another test between its selection and the start of QEMU. To avoid that, use an unix socket with a path that is unique Signed-off-by: La

Re: [PATCH 2/8] migration: Add precopy initial data handshake

On 14/05/2023 19:42, Cédric Le Goater wrote: External email: Use caution opening links or attachments Hello Avihai, +static int loadvm_handle_initial_data_enable(MigrationIncomingState *mis) +{ +    InitialDataInfo buf; +    SaveStateEntry *se; +    ssize_t read_size; + +    read_size = qe

Re: [PATCH v2 06/12] simpletrace: Simplify construction of tracing methods

> > This is nice but breaking existing analysis scripts should be avoided. > > I suggest preserving the Analyzer class the way it is and adding a new > Analyzer2 class that follows the new method signature for trace event > methods. You're right. This has too large effects on the API. I could

Re: [PATCH v2 2/4] migration/calc-dirty-rate: detailed stats in sampling mode

wrote: > On Wed, May 10, 2023 at 07:36:33PM +0200, Juan Quintela wrote: >> Andrei Gudkov wrote: >> > Collect number of dirty pages for progresseively increasing time >> > periods starting with 125ms up to number of seconds specified with >> > calc-dirty-rate. Report through qmp and hmp: 1) vector

Re: [PATCH v2 2/4] migration/calc-dirty-rate: detailed stats in sampling mode

wrote: > On Wed, May 10, 2023 at 07:36:33PM +0200, Juan Quintela wrote: >> Andrei Gudkov wrote: >> > Collect number of dirty pages for progresseively increasing time >> > periods starting with 125ms up to number of seconds specified with >> > calc-dirty-rate. Report through qmp and hmp: 1) vector

Re: [PATCH 6/6] target/ppc: Implement HEIR SPR

On Tue May 9, 2023 at 7:51 PM AEST, Harsh Prateek Bora wrote: > On Thu, Mar 23, 2023 at 12:22:37PM +1000, Nicholas Piggin wrote: > > The hypervisor emulation assistance interrupt modifies HEIR to > > contain the value of the instruction which caused the exception. > > > > Signed-off-by: Nicholas P

[PULL 3/9] linux-user: Add move_mount() syscall

From: Thomas Weißschuh Signed-off-by: Thomas Weißschuh Reviewed-by: Laurent Vivier [lv: define syscall] Message-Id: <20230424153429.276788-1-tho...@t-8ch.de> Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 33 + 1 file changed, 33 insertions(+) diff -

[PULL 0/9] Linux user for 8.1 patches

The following changes since commit 7c18f2d663521f1b31b821a13358ce38075eaf7d: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-04-29 23:07:17 +0100) are available in the Git repository at: https://github.com/vivier/qemu.git tags/linux-user-for-8.1-pull-request

[PULL 6/9] linux-user: Add new flag VERIFY_NONE

From: Thomas Weißschuh This can be used to validate that an address range is mapped but without being readable or writable. It will be used by an updated implementation of mincore(). Signed-off-by: Thomas Weißschuh Reviewed-by: Laurent Vivier Message-Id: <20230422100314.1650-2-tho...@t-8ch.de

[PULL 1/9] linux-user: Emulate /proc/cpuinfo output for riscv

From: Afonso Bordado RISC-V does not expose all extensions via hwcaps, thus some userspace applications may want to query these via /proc/cpuinfo. Currently when querying this file the host's file is shown instead which is slightly confusing. Emulate a basic /proc/cpuinfo file with mmu info and

[PULL 2/9] linux-user: report ENOTTY for unknown ioctls

From: Thomas Weißschuh The correct error number for unknown ioctls is ENOTTY. ENOSYS would mean that the ioctl() syscall itself is not implemented, which is very improbable and unexpected for userspace. ENOTTY means "Inappropriate ioctl for device". This is what the kernel returns on unknown io

[PULL 9/9] linux-user: fix getgroups/setgroups allocations

From: Michael Tokarev linux-user getgroups(), setgroups(), getgroups32() and setgroups32() used alloca() to allocate grouplist arrays, with unchecked gidsetsize coming from the "guest". With NGROUPS_MAX being 65536 (linux, and it is common for an application to allocate NGROUPS_MAX for getgroups

[PULL 4/9] linux-user: Add open_tree() syscall

From: Thomas Weißschuh Signed-off-by: Thomas Weißschuh Reviewed-by: Laurent Vivier Message-Id: <20230424153429.276788-2-tho...@t-8ch.de> [lv: move declaration at the beginning of the block, define syscall] Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 33 ++

[PULL 7/9] linux-user: Don't require PROT_READ for mincore

From: Thomas Weißschuh The kernel does not require PROT_READ for addresses passed to mincore. For example the fincore(1) tool from util-linux uses PROT_NONE and currently does not work under qemu-user. Example (with fincore(1) from util-linux 2.38): $ fincore /proc/self/exe RES PAGES SIZE FILE

[PATCH v3 0/3] Migration documentation

Hi Continuing on my saga to not have a pointer about how migration works/should work, this are the doc for the long mails that I had to do last week: 1 - Document how backwards compatibility is supposed to work (that is what it was on v1 and v2) 2 - Document how to handle features that depe

[PULL 8/9] linux-user: Fix mips fp64 executables loading

From: Daniil Kovalev If a program requires fr1, we should set the FR bit of CP0 control status register and add F64 hardware flag. The corresponding `else if` branch statement is copied from the linux kernel sources (see `arch_check_elf` function in linux/arch/mips/kernel/elf.c). Signed-off-by:

[PATCH v3 1/3] migration: Add documentation for backwards compatiblity

State what are the requeriments to get migration working between qemu versions. And once there explain how one is supposed to implement a new feature/default value and not break migration. Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20230511082701.12828-1-quint...@redhat.com> Signed-o

[PATCH v3 3/3] migration/doc: We broke backwards compatibility

When we detect that we have broken backwards compantibility in a released version, we can't do anything for that version. But once we fix that bug on the next released version, we can "mitigate" that problem when migrating to new versions to give a way out of that machine until it does a hard rebo

[PULL 5/9] linux-user/main: Use list_cpus() instead of cpu_list()

From: Thomas Huth This way we can get rid of the if'deffery and the XXX comment here (it's repeated in the list_cpus() function anyway). Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230424122126.236586-1-th...@redhat.com> Signed-

Re: [PATCH 02/21] migration: Don't use INT64_MAX for unlimited rate

On 5/9/23 13:51, Juan Quintela wrote: Harsh Prateek Bora wrote: On 5/8/23 18:38, Juan Quintela wrote: Use 0 instead. Signed-off-by: Juan Quintela --- migration/migration.c | 4 ++-- migration/qemu-file.c | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/migration/m

[PATCH v3 2/3] migration/docs: How to migrate when hosts have different features

Sometimes devices have different features depending of things outside of qemu. For instance the kernel. Document how to handle that cases. Signed-off-by: Juan Quintela --- If you have some example to put here, I am all ears. I guess that virtio-* with some features that are on qemu but not o

Re: [PATCH 01/21] migration: A rate limit value of 0 is valid

On 5/8/23 15:08, Juan Quintela wrote: And it is the best way to not have rate_limit. Signed-off-by: Juan Quintela Reviewed-by: Cédric Le Goater C. --- migration/migration.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/migration/migration.c b/migration/migra

Re: [PATCH] docs: build-system: rename "default-configs" to "configs"

On Fri, May 12, 2023 at 04:09:20PM +0800, Wang, Lei wrote: > There are also several "default-configs" in docs/devel/kconfig.rst, I think > they > can also be updated in this patch. Good catch, I'll respin it. > BR, > Lei > > On 10/4/2021 15:12, Kashyap Chamarthy wrote: > > Commit 812b31d3f9 (co

Re: [RFC PATCH v3 04/10] hw/arm/smmuv3: Add page table walk for stage-2

Hi Mostafa, On 4/1/23 12:49, Mostafa Saleh wrote: > In preparation for adding stage-2 support, add Stage-2 PTW code. > Only Aarch64 format is supported as stage-1. > > Nesting stage-1 and stage-2 is not supported right now. > > HTTU is not supported, SW is expected to maintain the Access flag. > T

Re: [PATCH 03/21] migration: We set the rate_limit by a second

On 5/8/23 15:08, Juan Quintela wrote: That the implementation does the check every 100 milliseconds is an implementation detail that shouldn't be seen on the interfaz. Si. Pero, "interface" es mejor aqui. Notice that all callers of qemu_file_set_rate_limit() used the division or pass 0, so th

Re: [PATCH v4 1/8] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

Het Gala wrote: > This patch introduces well defined MigrateAddress struct and its related child > objects. > > The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri' is of > string type. The current migration flow follows double encoding scheme for > fetching migration parameters

Re: [PATCH 04/21] qemu-file: make qemu_file_[sg]et_rate_limit() use an uint64_t

On 5/8/23 15:08, Juan Quintela wrote: It is really size_t. Everything else uses uint64_t, so move this to uint64_t as well. A size can't be negative anyways. Signed-off-by: Juan Quintela Message-Id: <20230504113841.23130-4-quint...@redhat.com> Reviewed-by: Cédric Le Goater C. * --- D

Re: [PATCH 05/21] qemu-file: Make rate_limit_used an uint64_t

On 5/8/23 15:08, Juan Quintela wrote: Change all the functions that use it. It was already passed as uint64_t. Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrangé Message-Id: <20230504113841.23130-5-quint...@redhat.com> Reviewed-by: Cédric Le Goater C. --- migration/qemu-fil

Re: [RFC PATCH v3 02/10] hw/arm/smmuv3: Update translation config to hold stage-2

Hi Mostafa, On 4/1/23 12:49, Mostafa Saleh wrote: > In preparation for adding stage-2 support, add a S2 config > struct(SMMUS2Cfg), composed of the following fields and embedded in > the main SMMUTransCfg: > -tsz: Size of IPA input region (S2T0SZ) > -sl0: Start level of translation (S2SL0) > -af

Re: [PATCH 6/6] target/ppc: Implement HEIR SPR

On 5/15/23 13:56, Nicholas Piggin wrote: On Tue May 9, 2023 at 7:51 PM AEST, Harsh Prateek Bora wrote: On Thu, Mar 23, 2023 at 12:22:37PM +1000, Nicholas Piggin wrote: The hypervisor emulation assistance interrupt modifies HEIR to contain the value of the instruction which caused the excepti

Re: [PATCH v4 2/8] migration: Converts uri parameter into 'MigrateAddress' struct

Het Gala wrote: > This patch introduces code that can parse 'uri' string parameter and > spit out 'MigrateAddress' struct. All the required migration parameters > are stored in the struct. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala Markus, could you comment? > --- > migrat

Re: [PATCH v2 1/1] s390x/pv: Fix spurious warning with asynchronous teardown

On 10/05/2023 12.55, Claudio Imbrenda wrote: Kernel commit 292a7d6fca33 ("KVM: s390: pv: fix asynchronous teardown for small VMs") causes the KVM_PV_ASYNC_CLEANUP_PREPARE ioctl to fail if the VM is not larger than 2GiB. QEMU would attempt it and fail, print an error message, and then proceed with

Re: [PATCH V2] hw/arm: enable qxl for aarch64

On Fri, May 12, 2023 at 05:31:08PM +0800, Hao Zeng wrote: > Qemu does not support qxl graphics cards in arm, it is recommended to enable Who recommends this and why ? The recommendations from Gerd are what I tend to point poeple to for display devices: https://www.kraxel.org/blog/2019/09/displ

Re: [PATCH 10/21] migration: Move rate_limit_max and rate_limit_used to migration_stats

On 5/9/23 16:40, Juan Quintela wrote: Harsh Prateek Bora wrote: On 5/8/23 18:38, Juan Quintela wrote: This way we can make them atomic and use this functions from any s/this/these Fixed. Sure, providing ack from ppc/spapr perspective. Reviewed-by: Harsh Prateek Bora Thanks.

Re: [PATCH v4 3/8] migration: converts socket backend to accept MigrateAddress struct

Het Gala wrote: > Socket transport backend for 'migrate'/'migrate-incoming' QAPIs accept > new wire protocol of MigrateAddress struct. > > It is achived by parsing 'uri' string and storing migration parameters > required for socket connection into well defined SocketAddress struct. > > Suggested-b

Re: [PATCH v2 1/1] s390x/pv: Fix spurious warning with asynchronous teardown

On 10/05/2023 12.55, Claudio Imbrenda wrote: Kernel commit 292a7d6fca33 ("KVM: s390: pv: fix asynchronous teardown for small VMs") causes the KVM_PV_ASYNC_CLEANUP_PREPARE ioctl to fail if the VM is not larger than 2GiB. QEMU would attempt it and fail, print an error message, and then proceed with

Re: Machine x-remote property auto-shutdown

Jag Raman writes: > Hi Markus, > > Please see the comments inline below. > >> On May 5, 2023, at 10:58 AM, Markus Armbruster wrote: >> >> I stumbled over this property, looked closer, and now I'm confused. >> >> Like most QOM properties, x-remote.auto-shutdown is virtually >> undocumented. Al

Re: [PULL 00/44] Hexagon update

On 5/13/23 12:22, Richard Henderson wrote: On 5/12/23 22:46, Taylor Simpson wrote: The following changes since commit 278238505d28d292927bff7683f39fb4fbca7fd1:    Merge tag 'pull-tcg-20230511-2' ofhttps://gitlab.com/rth7680/qemu  into staging (2023-05-11 11:44:23 +0100) are available in t

[PATCH v3 1/9] target/ppc: Fix width of some 32-bit SPRs

Some 32-bit SPRs are incorrectly implemented as 64-bits on 64-bit targets. This changes VRSAVE, DSISR, HDSISR, DAWRX0, PIDR, LPIDR, DEXCR, HDEXCR, CTRL, TSCR, MMCRH, and PMC[1-6] from to be 32-bit registers. This only goes by the 32/64 classification in the architecture, it does not try to implem

[PATCH v3 7/9] target/ppc: Implement HEIR SPR

The hypervisor emulation assistance interrupt modifies HEIR to contain the value of the instruction which caused the exception. Signed-off-by: Nicholas Piggin --- Since v2: - Fix ordering of prefix/suffix words in the register, as pointed out by Mikey. target/ppc/cpu.h | 1 + target/

[PATCH v3 3/9] target/ppc: Fix instruction loading endianness in alignment interrupt

powerpc ifetch endianness depends on MSR[LE] so it has to byteswap after cpu_ldl_code(). This corrects DSISR bits in alignment interrupts when running in little endian mode. Reviewed-by: Fabiano Rosas Signed-off-by: Nicholas Piggin --- Since v2: no change. target/ppc/excp_helper.c | 20 +++

[PATCH v3 0/9] target/ppc: Assorted ppc target fixes

Hopefully these are getting close to ready now. There is still the question about doing better with adding test cases for all this, I haven't exactly got a good answer yet but I do have kvm-unit-tests for most at least. Thanks, Nick Nicholas Piggin (9): target/ppc: Fix width of some 32-bit SPRs

[PATCH v3 9/9] target/ppc: Better CTRL SPR implementation

The CTRL register is able to write bit zero, and that is reflected in a bit field in the register that reflects the state of all threads in the core. TCG does not implement SMT, so this just requires mirroring that bit into the first bit of the thread state field. Signed-off-by: Nicholas Piggin

[PATCH v3 4/9] target/ppc: Alignment faults do not set DSISR in ISA v3.0 onward

This optional behavior was removed from the ISA in v3.0, see Summary of Changes preface: Data Storage Interrupt Status Register for Alignment Interrupt: Simplifies the Alignment interrupt by remov- ing the Data Storage Interrupt Status Register (DSISR) from the set of registers modified by

[PATCH v3 5/9] target/ppc: Change partition-scope translate interface

Rather than always performing partition scope page table translation with access type of 0 (MMU_DATA_LOAD), pass through the processor access type which first initiated the translation sequence. Process- scoped page table loads are then set to MMU_DATA_LOAD access type in the xlate function. This

[PATCH v3 2/9] target/ppc: Fix PMU MMCR0[PMCjCE] bit in hflags calculation

A store to MMCR0 with PMCjCE=1 fails to update hflags correctly and results in hflags mismatch: qemu: fatal: TCG hflags mismatch (current:0x2408003d rebuilt:0x240a003d) This can be reproduced by running perf on a recent machine. Signed-off-by: Nicholas Piggin --- Since v2: new patch. target

[PATCH v3 6/9] target/ppc: Add SRR1 prefix indication to interrupt handlers

ISA v3.1 introduced prefix instructions. Among the changes, various synchronous interrupts report whether they were caused by a prefix instruction in (H)SRR1. The case of instruction fetch that causes an HDSI due to access of a process-scoped table faulting on the partition scoped translation is t

[PATCH v3 8/9] target/ppc: Add ISA v3.1 LEV indication in SRR1 for system call interrupts

System call interrupts in ISA v3.1 CPUs add a LEV indication in SRR1 that corresponds with the LEV field of the instruction that caused the interrupt. Signed-off-by: Nicholas Piggin --- Since v2: new patch. target/ppc/excp_helper.c | 4 1 file changed, 4 insertions(+) diff --git a/target/

Re: [PATCH 6/6] target/ppc: Implement HEIR SPR

On 5/15/23 14:02, Harsh Prateek Bora wrote: That would be wrong for the other HSRR fallthroughs above it. Oh yeh, in that case, may be move it to top of the EXCP_HISI, it would need duplicating one line of assignment though (relatively better?). correcting myself, no duplication needed if

Re: [PATCH 06/21] qemu-file: Remove total from qemu_file_total_transferred_*()

On 5/8/23 15:08, Juan Quintela wrote: Function is already quite long. Signed-off-by: Juan Quintela Reviewed-by: Cédric Le Goater C. --- migration/block.c | 4 ++-- migration/migration.c | 2 +- migration/qemu-file.c | 4 ++-- migration/qemu-file.h | 10 +- migration

Re: [PATCH v2 1/6] ebpf: Added eBPF map update through mmap.

On Fri, May 12, 2023 at 03:28:57PM +0300, Andrew Melnychenko wrote: > Changed eBPF map updates through mmaped array. > Mmaped arrays provide direct access to map data. > It should omit using bpf_map_update_elem() call, > which may require capabilities that are not present. > > Signed-off-by: Andre

Re: [PATCH v2 2/6] ebpf: Added eBPF initialization by fds.

On Fri, May 12, 2023 at 03:28:58PM +0300, Andrew Melnychenko wrote: > It allows using file descriptors of eBPF provided > outside of QEMU. > QEMU may be run without capabilities for eBPF and run > RSS program provided by management tool(g.e. libvirt). > > Signed-off-by: Andrew Melnychenko > --- >

Re: [PATCH v2 3/6] virtio-net: Added property to load eBPF RSS with fds.

On Fri, May 12, 2023 at 03:28:59PM +0300, Andrew Melnychenko wrote: > eBPF RSS program and maps may now be passed during initialization. > Initially was implemented for libvirt to launch qemu without permissions, > and initialized eBPF program through the helper. > > Signed-off-by: Andrew Melnyche

Re: [PATCH V2] hw/arm: enable qxl for aarch64

On Mon, 15 May 2023 at 09:52, Daniel P. Berrangé wrote: > > On Fri, May 12, 2023 at 05:31:08PM +0800, Hao Zeng wrote: > > Qemu does not support qxl graphics cards in arm, it is recommended to enable > > Who recommends this and why ? > > The recommendations from Gerd are what I tend to point poeple

Re: [PATCH v2 4/6] ebpf: Added declaration/initialization routines.

On Fri, May 12, 2023 at 03:29:00PM +0300, Andrew Melnychenko wrote: > Now, the binary objects may be retrieved by id. > It would require for future qmp commands that may require specific > eBPF blob. > > Signed-off-by: Andrew Melnychenko > --- > ebpf/ebpf.c | 54

Re: [PATCH 16/18] tests/qtest/meson.build: Run the net filter tests only with default devices

On 14/05/2023 22.31, Paolo Bonzini wrote: Il ven 12 mag 2023, 14:41 Thomas Huth > ha scritto: These tests rely on a default NIC to be available. Skip them if we used the "--without-default-devices" configure option. Signed-off-by: Thomas Huth mailto:th...

Re: [PATCH v2 5/6] qmp: Added new command to retrieve eBPF blob.

Question for Markus at the bottom On Fri, May 12, 2023 at 03:29:01PM +0300, Andrew Melnychenko wrote: > Added command "request-ebpf". This command returns > eBPF program encoded base64. The program taken from the > skeleton and essentially is an ELF object that can be > loaded in the future wi

[PATCH] fsl-imx6: Add SNVS support for i.MX6 boards

SNVS is supported on both i.MX6 and i.MX6UL and is needed to support shutdown on the board. Cc: Peter Maydell (odd fixer:SABRELITE / i.MX6) Cc: Jean-Christophe Dubois (reviewer:SABRELITE / i.MX6) Cc: qemu-...@nongnu.org (open list:SABRELITE / i.MX6) Cc: qemu-devel@nongnu.org (open list:All patch

Re: [PATCH v4 4/8] migration: converts rdma backend to accept MigrateAddress struct

Het Gala wrote: > RDMA based transport backend for 'migrate'/'migrate-incoming' QAPIs > accept new wire protocol of MigrateAddress struct. > > It is achived by parsing 'uri' string and storing migration parameters > required for RDMA connection into well defined InetSocketAddress struct. > > Sugge

Re: [PATCH v2 6/6] ebpf: Updated eBPF program and skeleton.

On Fri, May 12, 2023 at 03:29:02PM +0300, Andrew Melnychenko wrote: > Updated section name, so libbpf should init/gues proper > program type without specifications during open/load. > > Signed-off-by: Andrew Melnychenko > --- > ebpf/rss.bpf.skeleton.h | 1469 -

Re: [PATCH V2] hw/arm: enable qxl for aarch64

On Mon, 2023-05-15 at 09:52 +0100, Daniel P. Berrangé wrote: > On Fri, May 12, 2023 at 05:31:08PM +0800, Hao Zeng wrote: > > Qemu does not support qxl graphics cards in arm, it is recommended > > to enable > > Who recommends this and why ? > > The recommendations from Gerd are what I tend to po

Re: [PATCH v4 5/8] migration: converts exec backend to accept MigrateAddress struct.

Het Gala wrote: > Exec transport backend for 'migrate'/'migrate-incoming' QAPIs accept > new wire protocol of MigrateAddress struct. > > It is achived by parsing 'uri' string and storing migration parameters > required for exec connection into strList struct. > > Suggested-by: Aravind Retnakaran

Re: [PATCH V2] hw/arm: enable qxl for aarch64

On Mon, 15 May 2023 at 10:57, Hao Zeng wrote: > > > On Mon, 2023-05-15 at 09:52 +0100, Daniel P. Berrangé wrote: > > Overall, IMHO, we should keep QXL restricted to as few build > > scenarios > > as possible. Given the status of SPICE, possibly we'll even want to > > deprecate it on x86 eventually

Re: [PATCH v4 7/8] migration: modified 'migrate-incoming' QAPI to accept 'channels' argument for migration.

Het Gala wrote: > MigrateChannelList ideally allows to have multiple listener interfaces up for > connection. > > Added MigrateChannelList struct as argument to 'migrate-incoming' qapi. > Introduced > MigrateChannelList in hmp_migrate_incoming() and qmp_migrate_incoming() > functions. > > Future

Re: [PATCH v4 8/8] migration: Introduced MigrateChannelList struct to migration code flow.

Het Gala wrote: > Integrated MigrateChannelList with all transport backends (socket, exec > and rdma) for both source and destination migration code flow. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala Nothing especially wrong appears here, will wait for 2nd submission with the

Re: [PATCH V2] hw/arm: enable qxl for aarch64

On Mon, May 15, 2023 at 10:59:16AM +0100, Peter Maydell wrote: > On Mon, 15 May 2023 at 10:57, Hao Zeng wrote: > > > > > > On Mon, 2023-05-15 at 09:52 +0100, Daniel P. Berrangé wrote: > > > Overall, IMHO, we should keep QXL restricted to as few build > > > scenarios > > > as possible. Given the st

[PATCH] hw/arm/sbsa-ref: add GIC node into DT

Let add GIC information into DeviceTree as part of SBSA-REF versioning. Trusted Firmware will read it and provide to next firmware level. Bumps platform version to 0.1 one so we can check is node is present. --- hw/arm/sbsa-ref.c | 38 +- 1 file changed, 37 in

Re: [PATCH v4 1/8] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

On Fri, May 12, 2023 at 02:32:33PM +, Het Gala wrote: > This patch introduces well defined MigrateAddress struct and its related child > objects. > > The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri' is of > string type. The current migration flow follows double encoding s

Re: [PATCH v3 1/1] block/blkio: use qemu_open() to support fd passing for virtio-blk

On Thu, May 11, 2023 at 11:03:22AM -0500, Jonathon Jongsma wrote: On 5/11/23 4:15 AM, Stefano Garzarella wrote: The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the new 'fd' property. Let's expose this to the user, so the management layer can pass the file descriptor of an already ope

Re: [PATCH v3] target/ppc: Fix fallback to MFSS for MFFS* instructions on pre 3.0 ISAs

Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks, Daniel On 5/10/23 08:19, Richard Purdie wrote: The following commits changed the code such that the fallback to MFSS for MFFSCRN, MFFSCRNI, MFFSCE and MFFSL on pre 3.0 ISAs was removed and became an illegal instruction: bf8adfd88b

Re: [PATCH v4 2/8] migration: Converts uri parameter into 'MigrateAddress' struct

On Fri, May 12, 2023 at 02:32:34PM +, Het Gala wrote: > This patch introduces code that can parse 'uri' string parameter and > spit out 'MigrateAddress' struct. All the required migration parameters > are stored in the struct. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala >

Re: [PATCH v3 1/9] target/ppc: Fix width of some 32-bit SPRs

On 5/15/23 14:56, Nicholas Piggin wrote: Some 32-bit SPRs are incorrectly implemented as 64-bits on 64-bit targets. This changes VRSAVE, DSISR, HDSISR, DAWRX0, PIDR, LPIDR, DEXCR, HDEXCR, CTRL, TSCR, MMCRH, and PMC[1-6] from to be 32-bit registers. This only goes by the 32/64 classification

Re: [PATCH] hw/arm/sbsa-ref: add GIC node into DT

On Mon, 15 May 2023 at 11:04, Marcin Juszkiewicz wrote: > > Let add GIC information into DeviceTree as part of SBSA-REF versioning. > > Trusted Firmware will read it and provide to next firmware level. > > Bumps platform version to 0.1 one so we can check is node is present. (Missing signed-off-b

Re: [PATCH v4 3/8] migration: converts socket backend to accept MigrateAddress struct

On Fri, May 12, 2023 at 02:32:35PM +, Het Gala wrote: > Socket transport backend for 'migrate'/'migrate-incoming' QAPIs accept > new wire protocol of MigrateAddress struct. > > It is achived by parsing 'uri' string and storing migration parameters > required for socket connection into well def

Re: [PATCH] hw/arm/sbsa-ref: add GIC node into DT

W dniu 15.05.2023 o 12:15, Peter Maydell pisze:> On Mon, 15 May 2023 at 11:04, Marcin Juszkiewicz > wrote: >> >> Let add GIC information into DeviceTree as part of SBSA-REF versioning. >> >> Trusted Firmware will read it and provide to next firmware level. >> >> Bumps platform version to 0.1 one

Re: [PATCH v4 4/8] migration: converts rdma backend to accept MigrateAddress struct

On Fri, May 12, 2023 at 02:32:36PM +, Het Gala wrote: > RDMA based transport backend for 'migrate'/'migrate-incoming' QAPIs > accept new wire protocol of MigrateAddress struct. > > It is achived by parsing 'uri' string and storing migration parameters > required for RDMA connection into well d

Re: [PATCH] hw/arm/sbsa-ref: add GIC node into DT

On 2023-05-15 11:15, Peter Maydell wrote: On Mon, 15 May 2023 at 11:04, Marcin Juszkiewicz wrote: Let add GIC information into DeviceTree as part of SBSA-REF versioning. Trusted Firmware will read it and provide to next firmware level. Bumps platform version to 0.1 one so we can check is nod

Re: [PATCH v4 5/8] migration: converts exec backend to accept MigrateAddress struct.

On Fri, May 12, 2023 at 02:32:37PM +, Het Gala wrote: > Exec transport backend for 'migrate'/'migrate-incoming' QAPIs accept > new wire protocol of MigrateAddress struct. > > It is achived by parsing 'uri' string and storing migration parameters > required for exec connection into strList stru

Re: [PATCH] hw/arm/sbsa-ref: add GIC node into DT

W dniu 15.05.2023 o 12:27, Leif Lindholm pisze: On 2023-05-15 11:15, Peter Maydell wrote: Why do we need to provide a full GIC DTB node ? Longer-term, I want to be able to present different specific gic implementations through this interface. I believe the 0.1 variant needs only the Distrib

Re: [PATCH 08/21] migration: Move setup_time to mig_stats

On 5/8/23 15:08, Juan Quintela wrote: It is a time that needs to be cleaned each time cancel migration. Once there ccreate calculate_time_since() to calculate how time since a time in the past. Signed-off-by: Juan Quintela --- migration/migration-stats.c | 7 +++ migration/migration-sta

Re: [PATCH v4 6/8] migration: modified 'migrate' QAPI to accept 'channels' argument for migration

On Fri, May 12, 2023 at 02:32:38PM +, Het Gala wrote: > MigrateChannelList ideally allows to connect accross multiple interfaces. > > Added MigrateChannelList struct as argument to 'migrate' qapi. Introduced > MigrateChannelList in hmp_migrate() and qmp_migrate() functions. > > Future patchse

Re: [PATCH v4 7/8] migration: modified 'migrate-incoming' QAPI to accept 'channels' argument for migration.

On Fri, May 12, 2023 at 02:32:39PM +, Het Gala wrote: > MigrateChannelList ideally allows to have multiple listener interfaces up for > connection. > > Added MigrateChannelList struct as argument to 'migrate-incoming' qapi. > Introduced > MigrateChannelList in hmp_migrate_incoming() and qmp_m

Re: [PATCH v4 8/8] migration: Introduced MigrateChannelList struct to migration code flow.

On Fri, May 12, 2023 at 02:32:40PM +, Het Gala wrote: > Integrated MigrateChannelList with all transport backends (socket, exec > and rdma) for both source and destination migration code flow. > > Suggested-by: Aravind Retnakaran > Signed-off-by: Het Gala > --- > migration/migration.c | 95

Re: [PATCH 16/18] tests/qtest/meson.build: Run the net filter tests only with default devices

On Mon, May 15, 2023 at 11:46 AM Thomas Huth wrote: > On 14/05/2023 22.31, Paolo Bonzini wrote: > > We can perhaps > > try to use QMP to check if the machines have a usable default NIC, and if > > not skip the test, but this should not block the bulk of your work from > > being merged. > > I'm cur

Re: [PATCH 6/6] target/ppc: Implement HEIR SPR

On Mon May 15, 2023 at 7:32 PM AEST, Harsh Prateek Bora wrote: > > > On 5/15/23 14:02, Harsh Prateek Bora wrote: > >> > >> That would be wrong for the other HSRR fallthroughs above it. > >> > > Oh yeh, in that case, may be move it to top of the EXCP_HISI, it would > > need duplicating one line of

Re: [PATCH V2] hw/arm: enable qxl for aarch64

> > > On Mon, 2023-05-15 at 09:52 +0100, Daniel P. Berrangé wrote: > > > > Overall, IMHO, we should keep QXL restricted to as few build > > > > scenarios > > > > as possible. Given the status of SPICE, possibly we'll even want to > > > > deprecate it on x86 eventually, not add it to more arches. >

Re: [PATCH 6/6] target/ppc: Implement HEIR SPR

On 5/15/23 16:15, Nicholas Piggin wrote: On Mon May 15, 2023 at 7:32 PM AEST, Harsh Prateek Bora wrote: On 5/15/23 14:02, Harsh Prateek Bora wrote: That would be wrong for the other HSRR fallthroughs above it. Oh yeh, in that case, may be move it to top of the EXCP_HISI, it would need d

Re: Question about QMP and BQL

Kevin, any advice? Fabiano Rosas writes: > Is there a way to execute a long-standing QMP command outside of the > BQL? > > The situation we're seeing is a slow query-block due to a slow system > call (fstat over NFS) causing the main thread to spend too long > holding the global mutex and lockin

Re: [PATCH v2 3/6] virtio-net: Added property to load eBPF RSS with fds.

Hi all, On Mon, May 15, 2023 at 12:38 PM Daniel P. Berrangé wrote: > > On Fri, May 12, 2023 at 03:28:59PM +0300, Andrew Melnychenko wrote: > > eBPF RSS program and maps may now be passed during initialization. > > Initially was implemented for libvirt to launch qemu without permissions, > > and i

Re: [PATCH v3 1/9] target/ppc: Fix width of some 32-bit SPRs

On Mon May 15, 2023 at 8:14 PM AEST, Harsh Prateek Bora wrote: > > > On 5/15/23 14:56, Nicholas Piggin wrote: > > Some 32-bit SPRs are incorrectly implemented as 64-bits on 64-bit > > targets. > > > > This changes VRSAVE, DSISR, HDSISR, DAWRX0, PIDR, LPIDR, DEXCR, > > HDEXCR, CTRL, TSCR, MMCRH, an

Re: [PATCH 02/21] migration: Don't use INT64_MAX for unlimited rate

Cédric Le Goater wrote: > On 5/9/23 13:51, Juan Quintela wrote: >> Harsh Prateek Bora wrote: >>> On 5/8/23 18:38, Juan Quintela wrote: Use 0 instead. Signed-off-by: Juan Quintela --- migration/migration.c | 4 ++-- migration/qemu-file.c | 3 +++ 2 files chang

  1   2   3   4   5   >