Re: [PATCH 21/22] tests/avocado: use http for mipsdistros.mips.com

2023-05-10 Thread Jiaxun Yang
> 2023年5月3日 10:12,Alex Bennée 写道: > > As the cached assets have fallen out of our cache new attempts to > fetch these binaries fail hard due to certificate expirty. It's hard > to find a contact email for the domain as the root page of mipsdistros > throws up some random XML. I suspect Amazon

[PATCH] chardev: report the handshake error

2023-05-10 Thread marcandre . lureau
From: Marc-André Lureau This can help to debug connection issues. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=2196182 Signed-off-by: Marc-André Lureau --- chardev/char-socket.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/chardev/char-socket.c

Re: [PATCH v2] target/ppc: Fix fallback to MFSS for MFFS* instructions on pre 3.0 ISAs

2023-05-10 Thread Philippe Mathieu-Daudé
On 6/5/23 08:52, Richard Purdie wrote: The following commits changed the code such that the fallback to MFSS for MFFSCRN, MFFSCRNI, MFFSCE and MFFSL on pre 3.0 ISAs was removed and became an illegal instruction: bf8adfd88b547680aa857c46098f3a1e94373160 - target/ppc: Move mffscrn[i] to deco

Re: [PATCH] scsi: check inquiry buffer length to prevent crash

2023-05-10 Thread Théo Maillart
This crash appeared on the latest linux guests, most likely because of this commit from the linux kernel: v5.18-rc1-157-gc92a6b5d6335 On Wed, Apr 26, 2023 at 7:13 PM Théo Maillart wrote: > > Le mer. 26 avr. 2023 à 15:38, Théo Maillart a > écrit : > >> Using linux 6.x guest, at boot time, an i

Re: [PATCH 12/17] qapi: Rewrite parsing of doc comment section symbols and tags

2023-05-10 Thread Markus Armbruster
Markus Armbruster writes: > To recognize a line starting with a section symbol and or tag, we > first split it at the first space, then examine the part left of the > space. We can just as well examine the unsplit line, so do that. > > Signed-off-by: Markus Armbruster > --- > scripts/qapi/pars

Re: [PATCH v1 1/1] s390x/pv: Fix spurious warning with asynchronous teardown

2023-05-10 Thread Claudio Imbrenda
On Wed, 10 May 2023 08:47:08 +0200 Thomas Huth wrote: > On 09/05/2023 18.27, Claudio Imbrenda wrote: > > When rebooting a small VM using asynchronous teardown, a spurious > > warning is emitted when the KVM_PV_ASYNC_CLEANUP_PREPARE ioctl fails. > > Why does the _PREPARE fail in that case? Why

Re: [PATCH v4 00/48] igb: Fix for DPDK

2023-05-10 Thread Jason Wang
在 2023/5/5 14:46, Jason Wang 写道: On Thu, May 4, 2023 at 2:45 PM Akihiko Odaki wrote: Hi Jason, Can you have a look at this series as well as the patch pointed to by Based-on: tag? Just come back from vacation, I will have a look at it. I've queued them. Thanks Thanks Regards, Aki

Re: [PATCH 02/12] tests/lcitool: add pipewire

2023-05-10 Thread Philippe Mathieu-Daudé
On 6/5/23 18:37, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Maybe a bit more verbose: "Add pipewire dependency to the lcitool mapping and run 'make lcitool-refresh' to generate the updated files." Signed-off-by: Marc-André Lureau --- tests/docker/dockerfiles/alpine.docke

Re: [PATCH 03/12] audio/pw: Pipewire->PipeWire case fix for user-visible text

2023-05-10 Thread Philippe Mathieu-Daudé
On 6/5/23 18:37, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau "PipeWire" is the correct case. Signed-off-by: Marc-André Lureau --- meson.build | 2 +- qapi/audio.json | 12 ++-- audio/pwaudio.c | 10 +- audio/tr

Re: [PATCH 06/12] audio/pw: trace during init before calling pipewire API

2023-05-10 Thread Philippe Mathieu-Daudé
On 6/5/23 18:37, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- audio/pwaudio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v1 1/1] s390x/pv: Fix spurious warning with asynchronous teardown

2023-05-10 Thread Thomas Huth
On 10/05/2023 09.32, Claudio Imbrenda wrote: On Wed, 10 May 2023 08:47:08 +0200 Thomas Huth wrote: On 09/05/2023 18.27, Claudio Imbrenda wrote: When rebooting a small VM using asynchronous teardown, a spurious warning is emitted when the KVM_PV_ASYNC_CLEANUP_PREPARE ioctl fails. Why does th

Re: [PATCH v2 5/5] disas: Move disas.c into the target-independent source set

2023-05-10 Thread Richard Henderson
On 5/10/23 07:53, Thomas Huth wrote: On 09/05/2023 18.33, Richard Henderson wrote: From: Thomas Huth By using target_words_bigendian() instead of an ifdef, we can build this code once. Signed-off-by: Thomas Huth [rth: Type change done in a separate patch] Signed-off-by: Richard Henderson --

Re: [PATCH v3 06/10] trace: remove code that depends on setting vcpu

2023-05-10 Thread Philippe Mathieu-Daudé
On 5/5/23 17:53, Alex Bennée wrote: Now we no longer have any events that are for vcpus we can start excising the code from the trace control. As the vcpu parameter is encoded as part of QMP we just stub out the has_vcpu/vcpu parameters rather than alter the API. Message-Id: <20230420150009.1675

Re: [PATCH 11/11] cutils: Improve qemu_strtosz handling of fractions

2023-05-10 Thread Hanna Czenczek
On 09.05.23 23:28, Eric Blake wrote: On Tue, May 09, 2023 at 07:54:30PM +0200, Hanna Czenczek wrote: On 08.05.23 22:03, Eric Blake wrote: We have several limitations and bugs worth fixing; they are inter-related enough that it is not worth splitting this patch into smaller pieces: * ".5k" shou

Re: [PATCH v2] piix: fix regression during unplug in Xen HVM domUs

2023-05-10 Thread Olaf Hering
Wed, 10 May 2023 00:58:27 +0200 Olaf Hering : > In my debugging (with v8.0.0) it turned out the three pci_set_word > causes the domU to hang. In fact, it is just the last one: > >pci_set_byte(pci_conf + 0x20, 0x01); /* BMIBA: 20-23h */ > > It changes the value from 0xc121 to 0x1. If I disa

Re: [PATCH v3 08/10] tcg: remove the final vestiges of dstate

2023-05-10 Thread Philippe Mathieu-Daudé
On 5/5/23 17:53, Alex Bennée wrote: Now we no longer have dynamic state affecting things we can remove the additional fields in cpu.h and simplify the TB hash calculation. For the benchmark: hyperfine -w 2 -m 20 \ "./arm-softmmu/qemu-system-arm -cpu cortex-a15 \ -machine ty

Re: [PATCH 11/11] cutils: Improve qemu_strtosz handling of fractions

2023-05-10 Thread Hanna Czenczek
On 10.05.23 09:46, Hanna Czenczek wrote: On 09.05.23 23:28, Eric Blake wrote: [...] But I think the solution to that is not to treat underflow as valf = 0, but rather to alter this snippet: -    valf = (uint64_t)(fraction * 0x1p64); +    /* + * If fraction was non

Re: [PATCH v2 3/5] hw/display/virtio-gpu-virgl: define callbacks in realize function

2023-05-10 Thread Philippe Mathieu-Daudé
On 30/4/23 23:48, Bernhard Beschow wrote: Am 28. April 2023 16:48:21 UTC schrieb Gurchetan Singh : From: Gurchetan Singh This reduces the amount of renderer backend specific needed to be exposed to the GL device. We only need one realize function per renderer backend. Signed-off-by: Gurch

Re: [PATCH v2] target/ppc: Fix fallback to MFSS for MFFS* instructions on pre 3.0 ISAs

2023-05-10 Thread Richard Henderson
On 5/8/23 13:11, Matheus K. Ferst wrote: On 06/05/2023 03:52, Richard Purdie wrote: The following commits changed the code such that the fallback to MFSS for MFFSCRN, MFFSCRNI, MFFSCE and MFFSL on pre 3.0 ISAs was removed and became an illegal instruction:    bf8adfd88b547680aa857c46098f3a1e9

Re: [PATCH v2 5/5] disas: Move disas.c into the target-independent source set

2023-05-10 Thread Thomas Huth
On 10/05/2023 09.46, Richard Henderson wrote: On 5/10/23 07:53, Thomas Huth wrote: On 09/05/2023 18.33, Richard Henderson wrote: From: Thomas Huth By using target_words_bigendian() instead of an ifdef, we can build this code once. Signed-off-by: Thomas Huth [rth: Type change done in a separ

[PULL v2 12/17] qapi: Rewrite parsing of doc comment section symbols and tags

2023-05-10 Thread Markus Armbruster
To recognize a line starting with a section symbol and or tag, we first split it at the first space, then examine the part left of the space. We can just as well examine the unsplit line, so do that. Signed-off-by: Markus Armbruster Message-Id: <20230428105429.1687850-13-arm...@redhat.com> Revie

[PULL v2 14/17] qapi: Section parameter @indent is no longer used, drop

2023-05-10 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Message-Id: <20230428105429.1687850-15-arm...@redhat.com> Reviewed-by: Juan Quintela --- scripts/qapi/parser.py | 31 ++- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py i

[PULL v2 13/17] qapi: Relax doc string @name: description indentation rules

2023-05-10 Thread Markus Armbruster
The QAPI schema doc comment language provides special syntax for command and event arguments, struct and union members, alternate branches, enumeration values, and features: descriptions starting with "@name:". By convention, we format them like this: # @name: Lorem ipsum dolor sit amet, cons

[PULL v2 00/17] QAPI patches patches for 2023-05-09

2023-05-10 Thread Markus Armbruster
The following changes since commit 792f77f376adef944f9a03e601f6ad90c2f891b2: Merge tag 'pull-loongarch-20230506' of https://gitlab.com/gaosong/qemu into staging (2023-05-06 08:11:52 +0100) are available in the Git repository at: https://repo.or.cz/qemu/armbru.git tags/pull-qapi-2023-05-09-v

Re: [PATCH v2 5/5] disas: Move disas.c into the target-independent source set

2023-05-10 Thread Richard Henderson
On 5/10/23 09:10, Thomas Huth wrote: On 10/05/2023 09.46, Richard Henderson wrote: On 5/10/23 07:53, Thomas Huth wrote: On 09/05/2023 18.33, Richard Henderson wrote: From: Thomas Huth By using target_words_bigendian() instead of an ifdef, we can build this code once. Signed-off-by: Thomas H

Re: [PATCH v3 0/3] ACPI: i386: bump MADT to revision 5

2023-05-10 Thread Igor Mammedov
On Fri, 5 May 2023 16:53:22 -0500 Eric DeVolder wrote: > Thoughts? I still don't think we need to bump x86 to rev 5 in QEMU. > eric > > On 4/21/23 16:48, Eric DeVolder wrote: > > The following Linux kernel change broke CPU hotplug for MADT revision > > less than 5. > > > > e2869bd7af60 ("x

[PATCH v5 1/6] igb: remove TCP ACK detection

2023-05-10 Thread Tomasz Dzieciol
TCP ACK detection is no longer present in igb. Signed-off-by: Tomasz Dzieciol --- hw/net/igb_core.c | 5 - 1 file changed, 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 96b7335b31..012eb1e1b9 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -1327,11 +1327,

[PATCH v5 5/6] igb: add IPv6 extended headers traffic detection

2023-05-10 Thread Tomasz Dzieciol
Signed-off-by: Tomasz Dzieciol --- hw/net/igb_core.c | 4 +++- hw/net/igb_regs.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 0eabe7106e..6d95cccea3 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -1415,7 +1415,9 @@ igb

[PATCH v5 0/6] igb: packet-split descriptors support

2023-05-10 Thread Tomasz Dzieciol
Based-on: <20230423041833.5302-1-akihiko.od...@daynix.com> ("[PATCH v3 00/47] igb: Fix for DPDK") Purposes of this series of patches: * introduce packet-split RX descriptors support. This feature is used by Linux VF driver for MTU values from 2048. * refactor RX descriptor handling for introduct

[PATCH v5 6/6] igb: packet-split descriptors support

2023-05-10 Thread Tomasz Dzieciol
Packet-split descriptors are used by Linux VF driver for MTU values from 2048 Signed-off-by: Tomasz Dzieciol --- hw/net/e1000e_core.c | 10 +- hw/net/igb_core.c| 403 ++- hw/net/igb_regs.h| 7 + hw/net/trace-events | 2 +- 4 files changed, 37

Re: [PATCH 1/8] migration: Add precopy initial data capability

2023-05-10 Thread Juan Quintela
Avihai Horon wrote: > Migration downtime estimation is calculated based on bandwidth and > remaining migration data. This assumes that loading of migration data in > the destination takes a negligible amount of time and that downtime > depends only on network speed. > > While this may be true for

[PATCH v5 4/6] igb: RX payload guest writting refactoring

2023-05-10 Thread Tomasz Dzieciol
Refactoring is done in preparation for support of multiple advanced descriptors RX modes, especially packet-split modes. Signed-off-by: Tomasz Dzieciol --- hw/net/e1000e_core.c | 18 ++-- hw/net/igb_core.c| 216 +-- tests/qtest/libqos/igb.c | 5

[PATCH v5 2/6] igb: rename E1000E_RingInfo_st

2023-05-10 Thread Tomasz Dzieciol
Rename E1000E_RingInfo_st and E1000E_RingInfo according to qemu typdefs guide. Signed-off-by: Tomasz Dzieciol --- hw/net/e1000e_core.c | 34 +- hw/net/igb_core.c| 42 +- 2 files changed, 38 insertions(+), 38 deletions(-)

[PATCH v5 3/6] igb: RX descriptors guest writting refactoring

2023-05-10 Thread Tomasz Dzieciol
Refactoring is done in preparation for support of multiple advanced descriptors RX modes, especially packet-split modes. Signed-off-by: Tomasz Dzieciol --- hw/net/igb_core.c | 176 ++-- hw/net/igb_regs.h | 10 +-- hw/net/trace-events | 6 +- 3 files

Re: [PATCH v5 01/30] tcg/i386: Introduce prepare_host_addr

2023-05-10 Thread Alex Bennée
Richard Henderson writes: > Merge tcg_out_tlb_load, add_qemu_ldst_label, > tcg_out_test_alignment, and some code that lived in both > tcg_out_qemu_ld and tcg_out_qemu_st into one function > that returns HostAddress and TCGLabelQemuLdst structures. > > Signed-off-by: Richard Henderson Reviewed

Re: [PATCH 2/8] migration: Add precopy initial data handshake

2023-05-10 Thread Juan Quintela
Avihai Horon wrote: > Add precopy initial data handshake between source and destination upon > migration setup. The purpose of the handshake is to notify the > destination that precopy initial data is used and which migration users > (i.e., SaveStateEntry) are going to use it. > > The handshake is

Re: [PATCH v5 02/30] tcg/i386: Use indexed addressing for softmmu fast path

2023-05-10 Thread Alex Bennée
Richard Henderson writes: > Since tcg_out_{ld,st}_helper_args, the slow path no longer requires > the address argument to be set up by the tlb load sequence. Use a > plain load for the addend and indexed addressing with the original > input address register. > > Signed-off-by: Richard Henderso

Re: [PATCH v5 03/30] tcg/aarch64: Introduce prepare_host_addr

2023-05-10 Thread Alex Bennée
Richard Henderson writes: > Merge tcg_out_tlb_load, add_qemu_ldst_label, tcg_out_test_alignment, > and some code that lived in both tcg_out_qemu_ld and tcg_out_qemu_st > into one function that returns HostAddress and TCGLabelQemuLdst structures. > > Signed-off-by: Richard Henderson Reviewed-b

[PING][PATCH v5] qapi/qmp: Add timestamps to qmp command responses

2023-05-10 Thread Denis Plotnikov
Hi all! It seems that this series has come through a number of reviews and got some "reviewed-by". Is there any flaws to fix preventing to merge this series? Thanks, Denis On 26.04.2023 17:08, Denis Plotnikov wrote: Add "start" & "end" time values to QMP command responses. These time value

Re: [PATCH 3/8] migration: Add precopy initial data loaded ACK functionality

2023-05-10 Thread Juan Quintela
Avihai Horon wrote: > Add the core functionality of precopy initial data, which allows the > destination to ACK that initial data has been loaded and the source to > wait for this ACK before completing the migration. > > A new return path command MIG_RP_MSG_INITIAL_DATA_LOADED_ACK is added. > It i

Re: [PATCH 4/8] migration: Enable precopy initial data capability

2023-05-10 Thread Juan Quintela
Avihai Horon wrote: > Now that precopy initial data logic has been implemented, enable the > capability. > > Signed-off-by: Avihai Horon Reviewed-by: Juan Quintela For when the time comes O:-)

Re: [PATCH 5/8] tests: Add migration precopy initial data capability test

2023-05-10 Thread Juan Quintela
Avihai Horon wrote: > Add migration precopy initial data capability test. The test runs > without migration users that support this capability, but is still > useful to make sure it didn't break anything. > > Signed-off-by: Avihai Horon Reviewed-by: Juan Quintela

Re: [PATCH v5 04/30] tcg/arm: Introduce prepare_host_addr

2023-05-10 Thread Alex Bennée
Richard Henderson writes: > Merge tcg_out_tlb_load, add_qemu_ldst_label, and some code that lived > in both tcg_out_qemu_ld and tcg_out_qemu_st into one function that > returns HostAddress and TCGLabelQemuLdst structures. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Ale

Re: [PATCH 6/8] vfio/migration: Refactor vfio_save_block() to return saved data size

2023-05-10 Thread Juan Quintela
Avihai Horon wrote: > Refactor vfio_save_block() to return the size of saved data on success > and -errno on error. > > This will be used in next patch to implement VFIO migration pre-copy > support. > > Signed-off-by: Avihai Horon > Reviewed-by: Cédric Le Goater Reviewed-by: Juan Quintela An

Re: [PATCH v10 1/8] memory: prevent dma-reentracy issues

2023-05-10 Thread Song Gao
Hi, Thomas 在 2023/5/8 下午9:12, Thomas Huth 写道: Oh, another spot that needs special handling ... I see Alexander already sent a patch (thanks!), but anyway, this is a good indication that we're missing some test coverage in the CI. Are there any loongarch kernel images available for public do

Re: [PATCH v5 05/30] tcg/loongarch64: Introduce prepare_host_addr

2023-05-10 Thread Alex Bennée
Richard Henderson writes: > Merge tcg_out_tlb_load, add_qemu_ldst_label, tcg_out_test_alignment, > tcg_out_zext_addr_if_32_bit, and some code that lived in both > tcg_out_qemu_ld and tcg_out_qemu_st into one function that returns > HostAddress and TCGLabelQemuLdst structures. > > Signed-off-by:

Re: [PATCH v5 06/30] tcg/mips: Introduce prepare_host_addr

2023-05-10 Thread Alex Bennée
Richard Henderson writes: > Merge tcg_out_tlb_load, add_qemu_ldst_label, tcg_out_test_alignment, > and some code that lived in both tcg_out_qemu_ld and tcg_out_qemu_st > into one function that returns HostAddress and TCGLabelQemuLdst structures. > > Signed-off-by: Richard Henderson Reviewed-b

Re: [PATCH v5 07/30] tcg/ppc: Introduce prepare_host_addr

2023-05-10 Thread Alex Bennée
Richard Henderson writes: > Merge tcg_out_tlb_load, add_qemu_ldst_label, tcg_out_test_alignment, > and some code that lived in both tcg_out_qemu_ld and tcg_out_qemu_st > into one function that returns HostAddress and TCGLabelQemuLdst structures. > > Signed-off-by: Richard Henderson Reviewed-b

Re: [PATCH] docs/devel: remind developers to run CI container pipeline when updating images

2023-05-10 Thread Daniel P . Berrangé
On Sat, May 06, 2023 at 12:50:12PM +0530, Ani Sinha wrote: > When new dependencies and packages are added to containers, its important to > run CI container generation pipelines on gitlab to make sure that there are no > obvious conflicts between packages that are being added and those that are > a

Re: [PATCH v5 08/30] tcg/riscv: Introduce prepare_host_addr

2023-05-10 Thread Alex Bennée
Richard Henderson writes: > Merge tcg_out_tlb_load, add_qemu_ldst_label, tcg_out_test_alignment, > and some code that lived in both tcg_out_qemu_ld and tcg_out_qemu_st > into one function that returns TCGReg and TCGLabelQemuLdst. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée

Re: [PATCH 0/8] migration: Add precopy initial data capability and VFIO precopy support

2023-05-10 Thread Juan Quintela
Avihai Horon wrote: > On 03/05/2023 1:49, Peter Xu wrote: >> External email: Use caution opening links or attachments >> Only until READY msg received on src could src switchover the precopy to >> dst. >> >> Then it only needs 1 more field in SaveVMHandlers rather than 3, and only 1 >> more msg (

Re: [PATCH] chardev: report the handshake error

2023-05-10 Thread Daniel P . Berrangé
On Wed, May 10, 2023 at 11:25:31AM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This can help to debug connection issues. > > Related to: > https://bugzilla.redhat.com/show_bug.cgi?id=2196182 > > Signed-off-by: Marc-André Lureau > --- > chardev/char-socket.c | 12 ++

Re: [PATCH v5 08/30] tcg/riscv: Introduce prepare_host_addr

2023-05-10 Thread Alex Bennée
Richard Henderson writes: > Merge tcg_out_tlb_load, add_qemu_ldst_label, tcg_out_test_alignment, > and some code that lived in both tcg_out_qemu_ld and tcg_out_qemu_st > into one function that returns TCGReg and TCGLabelQemuLdst. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée

Re: [PATCH v5 09/30] tcg/s390x: Introduce prepare_host_addr

2023-05-10 Thread Alex Bennée
Richard Henderson writes: > Merge tcg_out_tlb_load, add_qemu_ldst_label, tcg_out_test_alignment, > tcg_prepare_user_ldst, and some code that lived in both tcg_out_qemu_ld > and tcg_out_qemu_st into one function that returns HostAddress and > TCGLabelQemuLdst structures. > > Signed-off-by: Richa

Question about issue #1576: Migration from v8.0.0-rc2 to v7.2.0 with pcie-root-port device fails

2023-05-10 Thread Fiona Ebner
Hi, I'm trying to fix issue #1576 [0], but having a bit of a hard time. The issue was introduced by commit 010746ae1d ("hw/pci/aer: Implement PCI_ERR_UNCOR_MASK register") and the migration error is: > qemu-system-x86_64: get_pci_config_device: Bad config data: i=0x10a read: 40 > device: 0 cmask:

Re: [PATCH] chardev: report the handshake error

2023-05-10 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > This can help to debug connection issues. > > Related to: > https://bugzilla.redhat.com/show_bug.cgi?id=2196182 > > Signed-off-by: Marc-André Lureau > --- > chardev/char-socket.c | 12 ++-- > 1 file changed, 10 insertions

Re: [PATCH HOTFIX] target/loongarch: Terminate vmstate subsections list

2023-05-10 Thread Song Gao
在 2023/5/10 下午2:24, Richard Henderson 写道: This list requires a NULL terminator. Fixes: 16f5396cec23 ("target/loongarch: Add LSX data type VReg") Signed-off-by: Richard Henderson --- This failure can be seen https://gitlab.com/qemu-project/qemu/-/jobs/4253259728#L5579 5/789 qemu:qtest+q

Re: [PATCH] chardev: report the handshake error

2023-05-10 Thread Marc-André Lureau
Hi On Wed, May 10, 2023 at 1:31 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > This can help to debug connection issues. > > > > Related to: > > https://bugzilla.redhat.com/show_bug.cgi?id=2196182 > > > > Signed-off-by: Marc-André Lureau

Re: [PATCH v2 3/3] pci: ROM preallocation for incoming migration

2023-05-10 Thread Vladimir Sementsov-Ogievskiy
On 09.05.23 18:54, Michael S. Tsirkin wrote: On Wed, May 03, 2023 at 02:39:15PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 03.05.23 13:05, Michael S. Tsirkin wrote: On Wed, May 03, 2023 at 12:50:09PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 03.05.23 12:20, David Hildenbrand wrote: On

Re: [PATCH] chardev: report the handshake error

2023-05-10 Thread Daniel P . Berrangé
On Wed, May 10, 2023 at 11:31:40AM +0200, Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > This can help to debug connection issues. > > > > Related to: > > https://bugzilla.redhat.com/show_bug.cgi?id=2196182 > > > > Signed-off-by: Marc-André Lu

Re: [PATCH v2 01/12] accel: Replace target_ulong in tlb_*()

2023-05-10 Thread Richard Henderson
On 5/5/23 15:13, Anton Johansson wrote: Replaces target_ulong with vaddr for guest virtual addresses in tlb_*() functions and auxilliary structs. Signed-off-by: Anton Johansson --- accel/stubs/tcg-stub.c | 2 +- accel/tcg/cputlb.c | 177 +--

Re: [PATCH v2 02/12] accel/tcg/translate-all.c: Widen pc and cs_base

2023-05-10 Thread Richard Henderson
On 5/5/23 15:13, Anton Johansson wrote: Signed-off-by: Anton Johansson --- accel/tcg/internal.h | 6 +++--- accel/tcg/translate-all.c | 10 +- 2 files changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 03/12] target: Widen pc/cs_base in cpu_get_tb_cpu_state

2023-05-10 Thread Richard Henderson
On 5/5/23 15:13, Anton Johansson wrote: Signed-off-by: Anton Johansson --- accel/tcg/cpu-exec.c | 9 ++--- accel/tcg/translate-all.c | 3 ++- target/alpha/cpu.h| 4 ++-- target/arm/cpu.h | 4 ++-- target/arm/helper.c | 4 ++-- target/avr/cpu.h | 4 +

Re: [PATCH v2 04/12] accel/tcg/cputlb.c: Widen CPUTLBEntry access functions

2023-05-10 Thread Richard Henderson
On 5/5/23 15:13, Anton Johansson wrote: Signed-off-by: Anton Johansson --- accel/tcg/cputlb.c | 8 include/exec/cpu_ldst.h | 10 +- 2 files changed, 9 insertions(+), 9 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH] chardev: report the handshake error

2023-05-10 Thread Marc-André Lureau
Hi On Wed, May 10, 2023 at 1:39 PM Daniel P. Berrangé wrote: > On Wed, May 10, 2023 at 11:31:40AM +0200, Markus Armbruster wrote: > > marcandre.lur...@redhat.com writes: > > > > > From: Marc-André Lureau > > > > > > This can help to debug connection issues. > > > > > > Related to: > > > https:/

Re: [PATCH v2 05/12] accel/tcg/cputlb.c: Widen addr in MMULookupPageData

2023-05-10 Thread Richard Henderson
On 5/5/23 15:13, Anton Johansson wrote: Functions accessing MMULookupPageData are also updated. Signed-off-by: Anton Johansson --- accel/tcg/cputlb.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 06/12] accel/tcg/cpu-exec.c: Widen pc to vaddr

2023-05-10 Thread Richard Henderson
On 5/5/23 15:13, Anton Johansson wrote: Signed-off-by: Anton Johansson --- accel/tcg/cpu-exec.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 07/12] accel/tcg: Widen pc to vaddr in CPUJumpCache

2023-05-10 Thread Richard Henderson
On 5/5/23 15:13, Anton Johansson wrote: Related functions dealing with the jump cache are also updated. Signed-off-by: Anton Johansson --- accel/tcg/cputlb.c | 2 +- accel/tcg/tb-hash.h | 12 ++-- accel/tcg/tb-jmp-cache.h | 2 +- 3 files changed, 8 insertions(+), 8 dele

Re: [PATCH v2 11/12] accel/tcg: Replace target_ulong with vaddr in page_*()

2023-05-10 Thread Richard Henderson
On 5/5/23 15:14, Anton Johansson wrote: Use vaddr for guest virtual addresses for functions dealing with page flags. Signed-off-by: Anton Johansson --- accel/tcg/user-exec.c| 44 +--- include/exec/cpu-all.h | 10 include/exec/translate-a

Re: [PATCH v2 12/12] cpu: Replace target_ulong with hwaddr in tb_invalidate_phys_addr()

2023-05-10 Thread Richard Henderson
On 5/5/23 15:14, Anton Johansson wrote: Signed-off-by: Anton Johansson --- cpu.c | 2 +- include/exec/exec-all.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

[PATCH v2] hw/riscv: qemu crash when NUMA nodes exceed available CPUs

2023-05-10 Thread Yin Wang
Command "qemu-system-riscv64 -machine virt -m 2G -smp 1 -numa node,mem=1G -numa node,mem=1G" would trigger this problem.Backtrace with: #0 0x55b5b1a4 in riscv_numa_get_default_cpu_node_id at ../hw/riscv/numa.c:211 #1 0x558ce510 in machine_numa_finish_cpu_init at ../hw/core/m

Re: [PATCH 3/3] hw/loongarch/virt: Set max 256 cpus support on loongarch virt machine

2023-05-10 Thread Richard Henderson
On 4/26/23 02:37, Song Gao wrote: ping~ 在 2023/4/6 下午6:00, Song Gao 写道: Add separate macro EXTIOI_CPUS for extioi interrupt controller, extioi only supports 4 cpu. And set macro LOONGARCH_MAX_CPUS as 256 so that loongarch virt machine supports more cpus. Interrupts from external devices can on

Re: [PULL 45/51] hw/acpi/aml-build: Only generate cluster node in PPTT when specified

2023-05-10 Thread Philippe Mathieu-Daudé
Hi Yang, On 5/1/23 10:16, Michael S. Tsirkin wrote: From: Yicong Yang Currently we'll always generate a cluster node no matter user has specified '-smp clusters=X' or not. Cluster is an optional level and will participant the building of Linux scheduling domains and only appears on a few platf

Re: [PULL 00/10] Migration 20230509 patches

2023-05-10 Thread Richard Henderson
On 5/9/23 20:17, Juan Quintela wrote: The following changes since commit 271477b59e723250f17a7e20f139262057921b6a: Merge tag 'compression-code-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-05-08 20:38:05 +0100) are available in the Git repository at: https://

Re: [PATCH for-8.1] target/sparc: Use tcg_gen_lookup_and_goto_ptr

2023-05-10 Thread Richard Henderson
Ping. r~ On 4/5/23 19:59, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/sparc/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 137bdc5159..47940fd85e 100644 --- a/target/s

Re: [PATCH for-8.1 00/12] tcg/mips: Backend improvements

2023-05-10 Thread Richard Henderson
Ping. r~ On 4/8/23 04:03, Richard Henderson wrote: I've posted some of these before, perhaps a year or more ago, but then failed to follow up and get them merged. I don't think there are any real dependencies, but it has been rebased upon today's load/store helpers patch set, so there might be

[PATCH v4 08/11] hw: arm: allwinner-r40: Add emac and gmac support

2023-05-10 Thread qianfanguijin
From: qianfan Zhao R40 has two ethernet controllers named as emac and gmac. The emac is compatibled with A10, and the GMAC is compatibled with H3. Signed-off-by: qianfan Zhao --- hw/arm/allwinner-r40.c | 50 -- hw/arm/bananapi_m2u.c | 3 ++ inc

[PATCH v4 09/11] hw: arm: allwinner-sramc: Add SRAM Controller support for R40

2023-05-10 Thread qianfanguijin
From: qianfan Zhao Only a few important registers are added, especially the SRAM_VER register. Signed-off-by: qianfan Zhao --- hw/arm/Kconfig| 1 + hw/arm/allwinner-r40.c| 7 +- hw/misc/Kconfig | 3 + hw/misc/allwinner-sramc.c | 1

[PATCH v4 03/11] hw: allwinner-r40: Complete uart devices

2023-05-10 Thread qianfanguijin
From: qianfan Zhao R40 has eight UARTs, support both 16450 and 16550 compatible modes. Signed-off-by: qianfan Zhao --- hw/arm/allwinner-r40.c | 31 --- include/hw/arm/allwinner-r40.h | 8 2 files changed, 36 insertions(+), 3 deletions(-) diff --gi

[PATCH v4 10/11] tests: avocado: boot_linux_console: Add test case for bpim2u

2023-05-10 Thread qianfanguijin
From: qianfan Zhao Add test case for booting from initrd and sd card. Signed-off-by: qianfan Zhao --- tests/avocado/boot_linux_console.py | 176 1 file changed, 176 insertions(+) diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.

[PATCH v4 02/11] hw/arm/allwinner-r40: add Clock Control Unit

2023-05-10 Thread qianfanguijin
From: qianfan Zhao The CCU provides the registers to program the PLLs and the controls most of the clock generation, division, distribution, synchronization and gating. This commit adds support for the Clock Control Unit which emulates a simple read/write register interface. Signed-off-by: qian

[PATCH v4 11/11] docs: system: arm: Introduce bananapi_m2u

2023-05-10 Thread qianfanguijin
From: qianfan Zhao Add documents for Banana Pi M2U Signed-off-by: qianfan Zhao --- docs/system/arm/bananapi_m2u.rst | 138 +++ 1 file changed, 138 insertions(+) create mode 100644 docs/system/arm/bananapi_m2u.rst diff --git a/docs/system/arm/bananapi_m2u.rst b/doc

[PATCH v4 05/11] hw/misc: Rename axp209 to axp22x and add support AXP221 PMU

2023-05-10 Thread qianfanguijin
From: qianfan Zhao This patch adds minimal support for AXP-221 PMU and connect it to bananapi M2U board. Signed-off-by: qianfan Zhao --- hw/arm/Kconfig| 3 +- hw/arm/bananapi_m2u.c | 6 + hw/misc/Kconfig | 2 +- hw/misc/axp209.c | 238 --

[PATCH v4 00/11] *** Add allwinner r40 support ***

2023-05-10 Thread qianfanguijin
From: qianfan Zhao *** history *** # v1: 2023-03-21 The first version which add allwinner-r40 support, supported features: + ccu + dram controller + uart + i2c and pmic(axp221) + sdcard + emac/gmac Also provide a test case under avocado, running quickly test: $ AVOCADO_ALLOW_LARGE_STORAGE=y

[PATCH v4 07/11] hw: sd: allwinner-sdhost: Add sun50i-a64 SoC support

2023-05-10 Thread qianfanguijin
From: qianfan Zhao A64's sd register was similar to H3, and it introduced a new register named SAMP_DL_REG location at 0x144. The dma descriptor buffer size of mmc2 is only 8K and the other mmc controllers has 64K. Also fix allwinner-r40's mmc controller type. Signed-off-by: qianfan Zhao ---

[PATCH v4 06/11] hw/arm/allwinner-r40: add SDRAM controller device

2023-05-10 Thread qianfanguijin
From: qianfan Zhao Types of memory that the SDRAM controller supports are DDR2/DDR3 and capacities of up to 2GiB. This commit adds emulation support of the Allwinner R40 SDRAM controller. This driver only support 256M, 512M and 1024M memory now. Signed-off-by: qianfan Zhao --- hw/arm/allwinne

[PATCH v4 01/11] hw: arm: Add bananapi M2-Ultra and allwinner-r40 support

2023-05-10 Thread qianfanguijin
From: qianfan Zhao Allwinner R40 (sun8i) SoC features a Quad-Core Cortex-A7 ARM CPU, and a Mali400 MP2 GPU from ARM. It's also known as the Allwinner T3 for In-Car Entertainment usage, A40i and A40pro are variants that differ in applicable temperatures range (industrial and military). Signed-off

[PATCH v4 04/11] hw: arm: allwinner-r40: Add i2c0 device

2023-05-10 Thread qianfanguijin
From: qianfan Zhao TWI(i2c) is designed to be used as an interface between CPU host and the serial 2-Wire bus. It can support all standard 2-Wire transfer, can be operated in standard mode(100kbit/s) or fast-mode, supporting data rate up to 400kbit/s. Signed-off-by: qianfan Zhao --- hw/arm/all

Re: [PATCH] chardev: report the handshake error

2023-05-10 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, May 10, 2023 at 11:31:40AM +0200, Markus Armbruster wrote: >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > This can help to debug connection issues. >> > >> > Related to: >> > https://bugzilla.redhat.com/show_bug.cgi?id=21961

Re: [PATCH] chardev: report the handshake error

2023-05-10 Thread Daniel P . Berrangé
On Wed, May 10, 2023 at 12:34:59PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Wed, May 10, 2023 at 11:31:40AM +0200, Markus Armbruster wrote: > >> marcandre.lur...@redhat.com writes: > >> > >> > From: Marc-André Lureau > >> > > >> > This can help to debug connection i

Re: [RFC PATCH] QCOW2: Add zeroes discard option

2023-05-10 Thread Hanna Czenczek
Thanks for the patch! As a note for hopefully many future patches ( :) ), you should run scripts/checkpatch.pl on them to check for coding style issues. Here, it reports two lines that are longer than 80 characters. Second, ideally, patches are not just sent to the qemu-devel list, but also

[PATCH v2 1/1] s390x/pv: Fix spurious warning with asynchronous teardown

2023-05-10 Thread Claudio Imbrenda
Kernel commit 292a7d6fca33 ("KVM: s390: pv: fix asynchronous teardown for small VMs") causes the KVM_PV_ASYNC_CLEANUP_PREPARE ioctl to fail if the VM is not larger than 2GiB. QEMU would attempt it and fail, print an error message, and then proceed with a normal teardown. Avoid attempting to use as

[PATCH v2 0/1] s390x/pv: Fix spurious warning with asynchronous teardown

2023-05-10 Thread Claudio Imbrenda
Kernel commit 292a7d6fca33 ("KVM: s390: pv: fix asynchronous teardown for small VMs") causes the KVM_PV_ASYNC_CLEANUP_PREPARE ioctl to fail if the VM is not larger than 2GiB. QEMU would attempt it and fail, print an error message, and then proceed with a normal teardown. Avoid attempting to use as

Re: [PATCH v8 1/5] blockdev: refactor transaction to use Transaction API

2023-05-10 Thread Kevin Wolf
Am 21.04.2023 um 13:53 hat Vladimir Sementsov-Ogievskiy geschrieben: > We are going to add more block-graph modifying transaction actions, > and block-graph modifying functions are already based on Transaction > API. > > Next, we'll need to separately update permissions after several > graph-modif

Re: [PATCH v2] hw/riscv: qemu crash when NUMA nodes exceed available CPUs

2023-05-10 Thread LIU Zhiwei
On 2023/5/10 18:09, Yin Wang wrote: Command "qemu-system-riscv64 -machine virt -m 2G -smp 1 -numa node,mem=1G -numa node,mem=1G" would trigger this problem.Backtrace with: #0 0x55b5b1a4 in riscv_numa_get_default_cpu_node_id at ../hw/riscv/numa.c:211 #1 0x558ce510 in mach

Re: [PATCH] target/riscv: Move zc* out of the experimental properties

2023-05-10 Thread LIU Zhiwei
On 2023/5/10 11:00, Weiwei Li wrote: Zc* extensions (version 1.0) are ratified. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/cpu.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index d

Re: [PATCH v8 2/5] blockdev: transactions: rename some things

2023-05-10 Thread Kevin Wolf
Am 21.04.2023 um 13:53 hat Vladimir Sementsov-Ogievskiy geschrieben: > Look at qmp_transaction(): dev_list is not obvious name for list of > actions. Let's look at qapi spec, this argument is "actions". Let's > follow the common practice of using same argument names in qapi scheme > and code. > >

Re: [PATCH 00/16] tcg: Remove TARGET_ALIGNED_ONLY

2023-05-10 Thread Richard Henderson
Ping for mips, nios2, sh4. The portions for alpha, hppa and sparc have been merged. r~ On 5/2/23 17:08, Richard Henderson wrote: Based-on: 20230502135741.1158035-1-richard.hender...@linaro.org ("[PATCH 0/9] tcg: Remove compatability helpers for qemu ld/st") Add MO_ALIGN where required, so that

Re: [PULL v2 00/45] loongarch-to-apply queue

2023-05-10 Thread Paolo Bonzini
On 5/6/23 08:34, Song Gao wrote: The following changes since commit eb5c3932a383ba1ef3a911232c644f2e053ef66c: Merge tag 'pw-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2023-05-05 19:18:05 +0100) are available in the Git repository at: https://gitlab.com/gaoso

Re: [PATCH v8 3/5] blockdev: qmp_transaction: refactor loop to classic for

2023-05-10 Thread Kevin Wolf
Am 21.04.2023 um 13:53 hat Vladimir Sementsov-Ogievskiy geschrieben: > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf

  1   2   3   4   >