[RFC 0/1] migration: Update error description whenever migration fails

2023-05-03 Thread tejus.gk
Hi everyone, Currently, in QEMU, whenever a migration fails, its state is set to MIGRATION_STATUS_FAILED via the function migrate_set_state. However, there are places in the code where the migration is marked as a failed migration; however, the error description is never updated in the migration s

[RFC 1/1] migration: Update error description whenever migration fails

2023-05-03 Thread tejus.gk
There are places in the code where the migration is marked failed with MIGRATION_STATUS_FAILED, but the failiure reason is never updated. Hence libvirt doesn't know why the migration failed when it queries for it. Signed-off-by: tejus.gk --- migration/migration.c | 8 1 file changed, 8

[PATCH v4 2/2] meson: Deserialize the man pages and html builds

2023-05-03 Thread Fabiano Rosas
For the documentation builds (man pages & manual), we let Sphinx decide when to rebuild and use a depfile to know when to trigger the make target. We currently use a trick of having the man pages custom_target take as input the html pages custom_target object, which causes both targets to be execu

[PATCH v4 0/2] docs: Speedup docs build

2023-05-03 Thread Fabiano Rosas
We currently have two documentation targets to build: - 'man' for the man pages; - 'html' for the web page. There are two bottlenecks in the process: 1) sphinx runs with a single process; 2) the two targets are serialized. For (1), we can just add the "-j auto" to sphinx_build and that should br

[PATCH v4 1/2] meson: Pass -j option to sphinx

2023-05-03 Thread Fabiano Rosas
Save a bit of build time by passing the number of jobs option to sphinx. We cannot use the -j option from make because meson does not support setting build time parameters for custom targets. Use nproc instead or the equivalent sphinx option "-j auto", if that is available (version >=1.7.0). A

Re: [PATCH v3 1/2] ppc: spapr: cleanup cr get/set with helpers.

2023-05-03 Thread Daniel Henrique Barboza
This patch breaks linux-user build as follows: [23/214] Compiling C object libqemu-ppc64-linux-user.fa.p/linux-user_elfload.c.o FAILED: libqemu-ppc64-linux-user.fa.p/linux-user_elfload.c.o cc -m64 -mcx16 -Ilibqemu-ppc64-linux-user.fa.p -I. -I.. -Itarget/ppc -I../target/ppc -I../common-user/host/

Re: [PATCH v4 03/10] build: move COLO under CONFIG_REPLICATION

2023-05-03 Thread Vladimir Sementsov-Ogievskiy
On 02.05.23 19:41, Peter Xu wrote: ## # @query-colo-status: @@ -1674,7 +1676,8 @@ # Since: 3.1 ## { 'command': 'query-colo-status', - 'returns': 'COLOStatus' } + 'returns': 'COLOStatus', + 'if': 'CONFIG_REPLICATION' } I still see a bunch of other colo related definitions around in t

Re: [PATCH v4 07/10] migration: split migration_incoming_co

2023-05-03 Thread Vladimir Sementsov-Ogievskiy
On 02.05.23 23:48, Peter Xu wrote: On Fri, Apr 28, 2023 at 10:49:25PM +0300, Vladimir Sementsov-Ogievskiy wrote: Originally, migration_incoming_co was introduced by 25d0c16f625feb3b6 "migration: Switch to COLO process after finishing loadvm" to be able to enter from COLO code to one specific

Re: [PATCH v3 01/11] hw: arm: Add bananapi M2-Ultra and allwinner-r40 support

2023-05-03 Thread qianfan
在 2023/5/3 4:01, Niek Linnenbank 写道: Hi Qianfan, Sorry for my late response, I had a holiday in between. On Tue, Apr 18, 2023 at 1:21 PM wrote: From: qianfan Zhao Allwinner R40 (sun8i) SoC features a Quad-Core Cortex-A7 ARM CPU, and a Mali400 MP2 GPU from ARM. It's also known

Re: [RFC PATCH v4 00/44] Add LoongArch LSX instructions

2023-05-03 Thread Song Gao
在 2023/5/2 上午2:43, Richard Henderson 写道: On 4/25/23 08:02, Song Gao wrote: Hi, This series adds LoongArch LSX instructions, Since the LoongArch Vol2 is not open, So we use 'RFC' title. I'm not sure when the manual will be open. After these patches are reviewed, how about merging them? About

Re: [PATCH RFC v2 3/9] target/loongarch: Supplement vcpu env initial when vcpu reset

2023-05-03 Thread Tianrui Zhao
在 2023年05月02日 19:04, Richard Henderson 写道: On 4/27/23 08:26, Tianrui Zhao wrote: Supplement vcpu env initial when vcpu reset, including init vcpu mp_state value to KVM_MP_STATE_RUNNABLE and init vcpu CSR_CPUID,CSR_TID to cpu->cpu_index. Signed-off-by: Tianrui Zhao --- target/loongarch/cpu.

Re: [PATCH RFC v2 4/9] target/loongarch: Implement kvm get/set registers

2023-05-03 Thread Tianrui Zhao
在 2023年05月02日 19:24, Richard Henderson 写道: On 4/27/23 08:26, Tianrui Zhao wrote: Implement kvm_arch_get/set_registers interfaces, many regs can be get/set in the function, such as core regs, csr regs, fpu regs, mp state, etc. Signed-off-by: Tianrui Zhao --- meson.build |

Re: [PATCH RFC v2 6/9] target/loongarch: Implement kvm_arch_init_vcpu

2023-05-03 Thread Tianrui Zhao
在 2023年05月02日 19:32, Richard Henderson 写道: On 4/27/23 08:26, Tianrui Zhao wrote: +static void kvm_loongarch_vm_stage_change(void *opaque, bool running, Typo: state +uint64_t counter_value; I know naming is hard, but this is so generic it is difficult to de

Re: [PATCH v2] vhost-user: send SET_STATUS 0 after GET_VRING_BASE

2023-05-03 Thread Yajun Wu
On 5/2/2023 7:04 AM, Stefan Hajnoczi wrote: Setting the VIRTIO Device Status Field to 0 resets the device. The device's state is lost, including the vring configuration. vhost-user.c currently sends SET_STATUS 0 before GET_VRING_BASE. This risks confusion about the lifetime of the vhost-user s

Re: [PATCH 2/2] tests: tcg: ppc64: Add tests for Vector Extract Mask Instructions

2023-05-03 Thread Shivaprasad G Bhat
On 5/2/23 12:35, Cédric Le Goater wrote: On 4/13/23 21:01, Shivaprasad G Bhat wrote: Add test for vextractbm, vextractwm, vextractdm and vextractqm instructions. Test works for both qemu-ppc64 and qemu-ppc64le. Based on the test case written by John Platts posted at [1] References: [1]: https:

Re: [PATCH] softfloat: Fix the incorrect computation in float32_exp2()

2023-05-03 Thread Shivaprasad G Bhat
Hi Richard, On 5/3/23 01:11, Richard Henderson wrote: On 5/2/23 16:25, Shivaprasad G Bhat wrote: The float32_exp2() is computing wrong exponent of 2. For example, with the following set of values {0.1, 2.0, 2.0, -1.0}, the expected output would be {1.071773, 4.00, 4.00, 0.50}. Inst

Re: [PULL v3 0/10] xenpvh3-tag

2023-05-03 Thread Vikram Garhwal
Hi Richard, On 5/3/23 12:47 AM, Richard Henderson wrote: On 5/3/23 01:12, Stefano Stabellini wrote: Hi Peter, Vikram fixed the gitlab test problem, so now all the tests should succeed. There were no changes to the QEMU code. I am resending the pull request (I rebased it on staging, no conflict

[PATCH v2 1/2] tcg: ppc64: Fix mask generation for vextractdm

2023-05-03 Thread Shivaprasad G Bhat
In function do_extractm() the mask is calculated as dup_const(1 << (element_width - 1)). '1' being signed int works fine for MO_8,16,32. For MO_64, on PPC64 host this ends up becoming 0 on compilation. The vextractdm uses MO_64, and it ends up having mask as 0. Explicitly use 1ULL instead of signe

[PATCH v2 0/2] tcg: ppc64: Fix mask generation for vextractdm

2023-05-03 Thread Shivaprasad G Bhat
While debugging gitlab issue[1] 1536, I happen to try the vextract[X]m instructions on the real hardware. The test used in [1] is failing for vextractdm. On debugging it is seen, in function do_extractm() the mask is calculated as dup_const(1 << (element_width - 1)). '1' being signed int works fin

[PATCH v2 2/2] tests: tcg: ppc64: Add tests for Vector Extract Mask Instructions

2023-05-03 Thread Shivaprasad G Bhat
Add test for vextractbm, vextractwm, vextractdm and vextractqm instructions. Test works for both qemu-ppc64 and qemu-ppc64le. Based on the test case written by John Platts posted at [1] References: [1] - https://gitlab.com/qemu-project/qemu/-/issues/1536 Signed-off-by: John Platts Signed-off-by

Re: [PATCH v3 1/2] ppc: spapr: cleanup cr get/set with helpers.

2023-05-03 Thread Harsh Prateek Bora
On 5/4/23 02:19, Daniel Henrique Barboza wrote: I squashed in this change to fix it: diff --git a/target/ppc/cpu.c b/target/ppc/cpu.c index 241d9e27e5..424f2e1741 100644 --- a/target/ppc/cpu.c +++ b/target/ppc/cpu.c @@ -75,7 +75,7 @@ void ppc_set_cr(CPUPPCState *env, uint64_t cr)   }  

Re: [PATCH v2 1/2] tcg: ppc64: Fix mask generation for vextractdm

2023-05-03 Thread Cédric Le Goater
On 5/4/23 11:35, Shivaprasad G Bhat wrote: In function do_extractm() the mask is calculated as dup_const(1 << (element_width - 1)). '1' being signed int works fine for MO_8,16,32. For MO_64, on PPC64 host this ends up becoming 0 on compilation. The vextractdm uses MO_64, and it ends up having mas

Re: [PATCH v2 2/2] tests: tcg: ppc64: Add tests for Vector Extract Mask Instructions

2023-05-03 Thread Cédric Le Goater
On 5/4/23 11:36, Shivaprasad G Bhat wrote: Add test for vextractbm, vextractwm, vextractdm and vextractqm instructions. Test works for both qemu-ppc64 and qemu-ppc64le. Based on the test case written by John Platts posted at [1] References: [1] - https://gitlab.com/qemu-project/qemu/-/issues/15

Re: [PULL v3 0/10] xenpvh3-tag

2023-05-03 Thread Richard Henderson
On 5/4/23 06:18, Vikram Garhwal wrote: Hi Richard, On 5/3/23 12:47 AM, Richard Henderson wrote: On 5/3/23 01:12, Stefano Stabellini wrote: Hi Peter, Vikram fixed the gitlab test problem, so now all the tests should succeed. There were no changes to the QEMU code. I am resending the pull reque

Re: [PATCH 0/2] Add mformat and xorriso dependencies in containers

2023-05-03 Thread Thomas Huth
On 03/05/2023 16.55, Ani Sinha wrote: mformat and xorriso tools are needed by biosbits avocado tests. This patchset adds those two tools in the docker container images. tests/qtest/cdrom-test.c already uses genisoimage to create ISO images, and the containers already have that tool installed.

Re: [PATCH] linux-user: Fix mips fp64 executables loading

2023-05-03 Thread Daniil Kovalev
Hello, On Tue, 2 May 2023 14:41:31 +0300 Michael Tokarev wrote: > Is it a -stable material? Yes, this `else if` branch is present in the latest linux-stable. It was actually introduced in 46490b572544fa908be051f7872beb2941e55ede in 2015 and never changed since then. I suppose that just a dummy

Re: [PATCH v4 00/48] igb: Fix for DPDK

2023-05-03 Thread Akihiko Odaki
Hi Jason, Can you have a look at this series as well as the patch pointed to by Based-on: tag? Regards, Akihiko Odaki On 2023/04/26 19:36, Akihiko Odaki wrote: Based-on: <366bbcafdb6e0373f0deb105153768a8c0bded87.ca...@gmail.com> ("[PATCH 0/1] e1000e: Fix tx/rx counters") This series has fix

Re: [PATCH] Add information how to fix common build error on Windows in symlink-install-tree

2023-05-03 Thread Thomas Huth
On 03/05/2023 17.08, Mateusz Krawczuk wrote: By default, Windows doesn't allow to create soft links for user account and only administrator is allowed to do this. To fix this problem you have to raise your permissions or enable Developer Mode, which available since Windows 10. Additional expla

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-03 Thread Thomas Huth
On 03/05/2023 20.32, Peter Maydell wrote: On Wed, 3 May 2023 at 18:06, Paolo Bonzini wrote: On 5/3/23 17:35, Alex Bennée wrote: You should select a device only if you cannot even start the machine without --nodefaults. Which is the case here right? We could skip tests that explicitly instan

<    1   2   3   4   5   6