Re: [RFC PATCH 0/6] Setting memory policy for restrictedmem file

On Fri 14-04-23 00:11:49, Ackerley Tng wrote: > Hello, > > This patchset builds upon the memfd_restricted() system call that was > discussed in the 'KVM: mm: fd-based approach for supporting KVM' patch > series [1]. > > The tree can be found at: > https://github.com/googleprodkernel/linux-cc/tree

[RFC PATCH] vhost-vdpa: cache Virtio states

Repetitive ioctls makes vdpa devices initialization and startup slow. This patch is to cache Virtio status, features, and config. Testing with vdpa-sim-net as my vdpa device, the numbers of ioctl is reduced from 47 to 37. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1579 Signed-off-by

[RFC 0/1] add support of `--initrd` for ELF-ARM kernels

We are developing an ELF-based kernel for ARM processor and would like to use the flag "—initrd". An initial ramdisk simplifies the boot process, but as far as I know, it is currently not support by Qemu for ARM processors. The flag is only available for pure Linux kernels. This patch enables the

[RFC 1/1] add support of `--initrd` for ELF-ARM kernels

Currently, the flag `--initrd` is only support for Linux ARM kernels. However, also other ELF kernels could depend on an initial ramdisk. This PR loads also the initrd for ELF kernels and announce the location by the nodes "/chosen/initrd-start" and "/chosen/initrd-end" within the device tree. Sig

Re: [PATCH] target/i386: Fix exception classes for SSE/AVX instructions.

Another ping for this patch: Patchew link: https://patchew.org/QEMU/20230212082812.55101-1-ri...@rzhou.org/ Thanks, Ricky On Mon, Mar 20, 2023 at 6:21 AM Ricky Zhou wrote: > > On Sun, Feb 12, 2023 at 12:28 AM Ricky Zhou wrote: > > Fix the exception classes for some SSE/AVX instructions to matc

Re: [PATCH 0/3] SDL2 usability fixes

Am 13.04.23 um 22:43 schrieb Bernhard Beschow: Am 13. April 2023 17:54:34 UTC schrieb "Volker Rümelin" : I'm trying to use QEMU on Windows hosts for fun and for profit. While the GTK GUI doesn't seem to support OpenGL under Windows the SDL2 GUI does. Hence I used the SDL2 GUI where I ran into s

Re: [RFC 1/1] add support of `--initrd` for ELF-ARM kernels

Stefan Lankes writes: > Currently, the flag `--initrd` is only support for Linux ARM kernels. > However, also other ELF kernels could depend on an initial ramdisk. > This PR loads also the initrd for ELF kernels and announce the > location by the nodes "/chosen/initrd-start" and > "/chosen/init

Re: [PATCH] tests/avocado: require netdev 'user' for kvm_xen_guest

On Thu, 13 Apr 2023 at 22:43, John Snow wrote: > > The tests will fail mysteriously with EOFError otherwise, because the VM > fails to boot and quickly disconnects from the QMP socket. Skip these > tests when we didn't compile with slirp. > > Fixes: c8cb603293fd (tests/avocado: Test Xen guest supp

Re: [RFC 1/1] add support of `--initrd` for ELF-ARM kernels

On Fri, 14 Apr 2023 at 08:35, Stefan Lankes wrote: > > Currently, the flag `--initrd` is only support for Linux ARM kernels. > However, also other ELF kernels could depend on an initial ramdisk. > This PR loads also the initrd for ELF kernels and announce the > location by the nodes "/chosen/initr

[PATCH] docs: Remove obsolete descriptions of SR-IOV support

The documentation used to say there is no device implemented with SR-IOV, but igb and nvme support SR-IOV today. Signed-off-by: Akihiko Odaki --- docs/pcie_sriov.txt | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/docs/pcie_sriov.txt b/docs/pcie_sriov.txt index 11158dbf88

Re: [PULL 19/54] acpi: pc: isa bridge: use AcpiDevAmlIf interface to build ISA device descriptors

Am 14.04.23 um 02:07 schrieb Mike Maslenkin: > Hibernate is disabled by default, that is why "shutdown /h" fails. > It can be enabled by 'powercfg.exe /h /size 100; powercfg.exe /h on' > > anyway, my hypotheses can be checked easily: just run the VM with > changed RAM size (±1). This should have t

Re: [PATCH] rtl8139: fix large_send_mss divide-by-zero

13.04.2023 20:19, Stefan Hajnoczi wrote: If the driver sets large_send_mss to 0 then a divide-by-zero occurs. Even if the division wasn't a problem, the for loop that emits MSS-sized packets would never terminate. Solve these issues by skipping offloading when large_send_mss=0. Cc: qemu-sta...

Re: [RFC 1/1] add support of `--initrd` for ELF-ARM kernels

Hello Peter, I totally agree. We are developing a unikernel (https://github.com/hermitcore/rusty-hermit). On x86, we are using the multiboot specification. I thought that this specification is only available on x86. In principle, a unikernel is a single application, which runs directly on the

Re: [PATCH] tests: lcitool: Switch to OpenSUSE Leap 15.4

On 3/31/23 15:11, Peter Krempa wrote: The 15.3 version is EOL now: https://get.opensuse.org/leap/15.3 Switch the dockerfile to 15.4. As far as I know, 15.4 still has Python 3.6 as the default Python, so you need to rename tests/lcitool/targets/opensuse-leap-153.yml and adjust tests/lcitool/

Re: [PATCH] replication: compile out some staff when replication is not configured

On 14.04.23 04:24, Zhang, Chen wrote: So, if I want to have an option to disable all COLO modules, do you mean it should be additional --disable-colo option? Or better keep one option -- disable-replication (and, maybe just rename to to --disable-colo)? I think keep the option --disable-replicat

Re: [PATCH] rtl8139: fix large_send_mss divide-by-zero

On 230413 1319, Stefan Hajnoczi wrote: > If the driver sets large_send_mss to 0 then a divide-by-zero occurs. > Even if the division wasn't a problem, the for loop that emits MSS-sized > packets would never terminate. > > Solve these issues by skipping offloading when large_send_mss=0. > > This i

Re: [RFC PATCH] vhost-vdpa: cache Virtio states

On Fri, Apr 14, 2023 at 9:26 AM Shao-Chien Chiang wrote: > > Repetitive ioctls makes vdpa devices initialization and startup slow. > This patch is to cache Virtio status, features, and config. > Testing with vdpa-sim-net as my vdpa device, the numbers of ioctl is > reduced from 47 to 37. > Hi Sha

Re: [PATCH v1 0/2] Update CXL documentation

Thanks Jonathan! I assume it will be merged sometime later with your other patches in the 8.x version! On Thu, Apr 13, 2023 at 2:58 PM Jonathan Cameron wrote: > > On Thu, 6 Apr 2023 18:58:37 +0530 > Raghu H wrote: > > > Thanks Jonathan for quick review/comments on earlier patch, as suggested >

[PATCH 00/40] igb: Fix for DPDK

This series has fixes and feature additions to pass DPDK Test Suite with igb. It also includes a few minor changes related to networking. Patch [01, 09] are bug fixes. Patch [10, 13] delete code which is unnecessary and affected by later changes. Patch [14, 28] are minor changes. Patch [29, 38] im

[PATCH 02/40] e1000x: Fix BPRC and MPRC

Before this change, e1000 and the common code updated BPRC and MPRC depending on the matched filter, but e1000e and igb decided to update those counters by deriving the packet type independently. This inconsistency caused a multicast packet to be counted twice. Updating BPRC and MPRC depending on

[PATCH 04/40] igb: Include the second VLAN tag in the buffer

Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 55de212447..f725ab97ae 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -1590,7 +1590,7 @@ static ssize_t igb_receive_intern

[PATCH 03/40] igb: Fix Rx packet type encoding

igb's advanced descriptor uses a packet type encoding different from one used in e1000e's extended descriptor. Fix the logic to encode Rx packet type accordingly. Fixes: 3a977deebe ("Intrdocue igb device emulation") Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 38 +++-

[PATCH 11/40] tests/avocado: Remove test_igb_nomsi_kvm

It is unlikely to find more bugs with KVM so remove test_igb_nomsi_kvm to save time to run it. Signed-off-by: Akihiko Odaki --- tests/avocado/netdev-ethtool.py | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/tests/avocado/netdev-ethtool.py b/tests/avocado/netdev-

[PATCH 12/40] hw/net/net_tx_pkt: Remove net_rx_pkt_get_l4_info

This function is not used. Signed-off-by: Akihiko Odaki --- hw/net/net_rx_pkt.c | 5 - hw/net/net_rx_pkt.h | 9 - 2 files changed, 14 deletions(-) diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c index 63be6e05ad..6125a063d7 100644 --- a/hw/net/net_rx_pkt.c +++ b/hw/net/net_rx

[PATCH 13/40] net/eth: Rename eth_setup_vlan_headers_ex

The old eth_setup_vlan_headers has no user so remove it and rename eth_setup_vlan_headers_ex. Signed-off-by: Akihiko Odaki --- hw/net/net_tx_pkt.c | 2 +- include/net/eth.h | 9 + net/eth.c | 2 +- 3 files changed, 3 insertions(+), 10 deletions(-) diff --git a/hw/net/net_tx_

[PATCH 05/40] igb: Do not require CTRL.VME for tx VLAN tagging

While the datasheet of e1000e says it checks CTRL.VME for tx VLAN tagging, igb's datasheet has no such statements. It also says for "CTRL.VLE": > This register only affects the VLAN Strip in Rx it does not have any > influence in the Tx path in the 82576. (Appendix A. Changes from the 82575) There

[PATCH 20/40] e1000e: Reset packet state after emptying Tx queue

Keeping Tx packet state after the transmit queue is emptied has some problems: - The datasheet says the descriptors can be reused after the transmit queue is emptied, but the Tx packet state may keep references to them. - The Tx packet state cannot be migrated so it can be reset anytime the mig

[PATCH 25/40] net/eth: Use void pointers

The uses of uint8_t pointers were misleading as they are never accessed as an array of octets and it even require more strict alignment to access as struct eth_header. Signed-off-by: Akihiko Odaki --- include/net/eth.h | 4 ++-- net/eth.c | 6 +++--- 2 files changed, 5 insertions(+), 5 d

[PATCH 01/40] hw/net/net_tx_pkt: Decouple from PCI

This also fixes the leak of memory mapping when the specified memory is partially mapped. Fixes: e263cd49c7 ("Packet abstraction for VMWARE network devices") Signed-off-by: Akihiko Odaki --- hw/net/e1000e_core.c | 13 + hw/net/igb_core.c| 13 - hw/net/net_tx_pkt.c | 65 +

[PATCH 21/40] vmxnet3: Reset packet state after emptying Tx queue

Keeping Tx packet state after the transmit queue is emptied but this behavior is unreliable as the state can be reset anytime the migration happens. Always reset Tx packet state always after the queue is emptied. Signed-off-by: Akihiko Odaki --- hw/net/vmxnet3.c | 3 ++- 1 file changed, 2 inser

[PATCH 18/40] igb: Remove goto

The goto is a bit confusing as it changes the control flow only if L4 protocol is not recognized. It is also different from e1000e, and noisy when comparing e1000e and igb. Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/n

[PATCH 14/40] e1000x: Share more Rx filtering logic

This saves some code and enables tracepoint for e1000's VLAN filtering. Signed-off-by: Akihiko Odaki --- hw/net/e1000.c | 35 +-- hw/net/e1000e_core.c | 47 +- hw/net/e1000x_common.c | 44 ++

[PATCH 16/40] e1000e: Always log status after building rx metadata

Without this change, the status flags may not be traced e.g. if checksum offloading is disabled. Signed-off-by: Akihiko Odaki --- hw/net/e1000e_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 743b36ddfb..dfa896adef 10

[PATCH 06/40] net/net_rx_pkt: Use iovec for net_rx_pkt_set_protocols()

igb does not properly ensure the buffer passed to net_rx_pkt_set_protocols() is contiguous for the entire L2/L3/L4 header. Allow it to pass scattered data to net_rx_pkt_set_protocols(). Fixes: 3a977deebe ("Intrdocue igb device emulation") Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 2

[PATCH 24/40] igb: Fix igb_mac_reg_init alignment

Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 96 +++ 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 350462c40c..429b0ebc03 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -40

Re: [PATCH 1/5] ppc: spapr: cleanup cr get/store with helper routines.

Harsh Prateek Bora writes: A bit vague on the subject line. I would expect to see some mention to nested at least. > The bits in cr reg are grouped into eight 4-bit fields represented > by env->crf[8] and the related calculations should be abstracted to > keep the calling routines simpler to rea

[PATCH 23/40] igb: Share common VF constants

The constants need to be consistent between the PF and VF. Signed-off-by: Akihiko Odaki --- hw/net/igb.c| 10 +- hw/net/igb_common.h | 8 hw/net/igbvf.c | 7 --- 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/hw/net/igb.c b/hw/net/igb.c index

[PATCH 32/40] igb: Implement Rx SCTP CSO

Signed-off-by: Akihiko Odaki --- hw/net/e1000e_core.c | 5 hw/net/igb_core.c | 15 +- hw/net/net_rx_pkt.c | 64 +++ include/net/eth.h | 4 ++- include/qemu/crc32c.h | 1 + net/eth.c | 4 +++ util/crc32c.c | 8

[PATCH 31/40] igb: Use UDP for RSS hash

e1000e does not support using UDP for RSS hash, but igb does. Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 16 hw/net/igb_regs.h | 3 +++ 2 files changed, 19 insertions(+) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 569897fb99..3ad81b15d0 100644 --- a/hw/n

[PATCH v3] test: Fix test-crypto-secret when compiling without keyring support

Linux keyring support is protected by CONFIG_KEYUTILS. We also need CONFIG_SECRET_KEYRING. Signed-off-by: Juan Quintela --- - Previous version of this patch changed the meson build rules. Daniel told me that the proper fix was to change the #ifdef test. - Change rule again. We need both def

[PATCH 36/40] igb: Implement Rx PTP2 timestamp

Signed-off-by: Akihiko Odaki --- hw/net/igb_common.h | 16 +++--- hw/net/igb_core.c | 129 hw/net/igb_regs.h | 23 3 files changed, 127 insertions(+), 41 deletions(-) diff --git a/hw/net/igb_common.h b/hw/net/igb_common.h index f2a90657

[PATCH 07/40] e1000e: Always copy ethernet header

e1000e_receive_internal() used to check the iov length to determine copy the iovs to a contiguous buffer, but the check is flawed in two ways: - It does not ensure that iovcnt > 0. - It does not take virtio-net header into consideration. The size of this copy is just 18 octets, which can be even l

[PATCH 29/40] igb: Implement MSI-X single vector mode

Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 429b0ebc03..2013a9a53d 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -1870,7 +1870,7 @@ igb_update_interrupt_stat

Re: [PATCH v2] test: Fix test-crypto-secret when compiling without keyring support

Thomas Huth wrote: >> -#endif /* CONFIG_KEYUTILS */ >> +#endif /* CONFIG_SECRET_KEYRING */ > > Nit: The comment after the "#endif" should mention both switches now, > like the one earlier in the patch. You are right. Sent next version with it included. Later, Juan.

[PATCH 38/40] vmxnet3: Do not depend on PC

vmxnet3 has no dependency on PC, and VMware Fusion actually makes it available on Apple Silicon according to: https://kb.vmware.com/s/article/90364 Signed-off-by: Akihiko Odaki --- hw/net/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/Kconfig b/hw/net/Kconfig

[PATCH 34/40] igb: Strip the second VLAN tag for extended VLAN

Signed-off-by: Akihiko Odaki --- hw/net/e1000e_core.c | 3 ++- hw/net/igb_core.c| 14 ++-- hw/net/net_rx_pkt.c | 15 + hw/net/net_rx_pkt.h | 19 include/net/eth.h| 4 ++-- net/eth.c| 52 6 fi

[PATCH 19/40] igb: Read DCMD.VLE of the first Tx descriptor

Section 7.2.2.3 Advanced Transmit Data Descriptor says: > For frames that spans multiple descriptors, all fields apart from > DCMD.EOP, DCMD.RS, DCMD.DEXT, DTALEN, Address and DTYP are valid only > in the first descriptors and are ignored in the subsequent ones. Signed-off-by: Akihiko Odaki ---

[PATCH 37/40] igb: Implement Tx timestamp

Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 7 +++ hw/net/igb_regs.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index c716f400fd..38b53676d4 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -614,6 +614,13 @@ igb_process_tx_

[PATCH 35/40] igb: Filter with the second VLAN tag for extended VLAN

Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 6e8de9d878..70acc86834 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -1017,9 +1017,17 @@ static uint16_t i

[PATCH 15/40] e1000x: Take CRC into consideration for size check

Section 13.7.15 Receive Length Error Count says: > Packets over 1522 bytes are oversized if LongPacketEnable is 0b > (RCTL.LPE). If LongPacketEnable (LPE) is 1b, then an incoming packet > is considered oversized if it exceeds 16384 bytes. > These lengths are based on bytes in the received packet

[PATCH 39/40] MAINTAINERS: Add a reviewer for network packet abstractions

I have made significant changes for network packet abstractions so add me as a reviewer. Signed-off-by: Akihiko Odaki --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c31d2279ab..8b2ef5943c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2214,6 +

[PATCH 33/40] igb: Implement Tx SCTP CSO

Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 12 +++- hw/net/net_tx_pkt.c | 18 ++ hw/net/net_tx_pkt.h | 8 3 files changed, 33 insertions(+), 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 0e1b681613..955db1b1dc 100644 --- a/h

[PATCH 09/40] Fix references to igb Avocado test

Fixes: 9f95111474 ("tests/avocado: re-factor igb test to avoid timeouts") Signed-off-by: Akihiko Odaki --- MAINTAINERS| 2 +- docs/system/devices/igb.rst| 2 +- scripts/ci/org.centos/stream/8/x86_64/test-avocado | 2 +- 3 files chang

[PATCH 22/40] igb: Add more definitions for Tx descriptor

Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 2 +- hw/net/igb_regs.h | 32 +++- 2 files changed, 28 insertions(+), 6 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index e5a7021c0e..350462c40c 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_c

[PATCH 28/40] tests/qtest/libqos/igb: Set GPIE.Multiple_MSIX

GPIE.Multiple_MSIX is not set by default, and needs to be set to get interrupts from multiple MSI-X vectors. Signed-off-by: Akihiko Odaki --- tests/qtest/libqos/igb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/libqos/igb.c b/tests/qtest/libqos/igb.c index 12fb531bf0..a603468

[PATCH 30/40] igb: Implement igb-specific oversize check

igb has a configurable size limit for LPE, and uses different limits depending on whether the packet is treated as a VLAN packet. Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 41 +++-- 1 file changed, 27 insertions(+), 14 deletions(-) diff --git a/hw/

[PATCH 10/40] tests/avocado: Remove unused imports

Signed-off-by: Akihiko Odaki --- tests/avocado/netdev-ethtool.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/avocado/netdev-ethtool.py b/tests/avocado/netdev-ethtool.py index f7e9464184..8de118e313 100644 --- a/tests/avocado/netdev-ethtool.py +++ b/tests/avocado/netdev-ethtool.py @@

[PATCH 27/40] hw/net/net_rx_pkt: Enforce alignment for eth_header

eth_strip_vlan and eth_strip_vlan_ex refers to ehdr_buf as struct eth_header. Enforce alignment for the structure. Signed-off-by: Akihiko Odaki --- hw/net/net_rx_pkt.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c index

[PATCH 17/40] igb: Always log status after building rx metadata

Without this change, the status flags may not be traced e.g. if checksum offloading is disabled. Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 5fdc8bc42d..ccc5a626b4 100644 ---

[PATCH 40/40] docs/system/devices/igb: Note igb is tested for DPDK

Signed-off-by: Akihiko Odaki --- docs/system/devices/igb.rst | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/docs/system/devices/igb.rst b/docs/system/devices/igb.rst index afe036dad2..60c10bf7c7 100644 --- a/docs/system/devices/igb.rst +++ b/docs/system/devices/i

[PATCH 08/40] igb: Always copy ethernet header

igb_receive_internal() used to check the iov length to determine copy the iovs to a contiguous buffer, but the check is flawed in two ways: - It does not ensure that iovcnt > 0. - It does not take virtio-net header into consideration. The size of this copy is just 22 octets, which can be even less

[PATCH 26/40] net/eth: Always add VLAN tag

It is possible to have another VLAN tag even if the packet is already tagged. Signed-off-by: Akihiko Odaki --- hw/net/net_tx_pkt.c | 16 +++- include/net/eth.h | 4 ++-- net/eth.c | 22 ++ 3 files changed, 15 insertions(+), 27 deletions(-) diff --git

Re: [PATCH 2/5] ppc: spapr: cleanup h_enter_nested() with helper routines.

Harsh Prateek Bora writes: > h_enter_nested() currently does a lot of register specific operations > which should be abstracted logically to simplify the code for better > readability. This patch breaks down relevant blocks into respective > helper routines to make use of them for better readabil

Re: [PATCH] migration: mark mixed functions that can suspend

Paolo Bonzini wrote: > There should be no paths from a coroutine_fn to aio_poll, however in > practice coroutine_mixed_fn will call aio_poll in the !qemu_in_coroutine() > path. By marking mixed functions, we can track accurately the call paths > that execute entirely in coroutine context, and fin

Re: [PATCH 3/5] ppc: spapr: assert early rather late in h_enter_nested()

Harsh Prateek Bora writes: > Currently, it asserts very late in the code flow if lpid is already > initialized. That's not about initializing. It is about making sure the LPIDR is 0. Which has a specific meaning according to the ISA. > Ideally, it should assert in the beginning if that is the

Re: [PATCH 5/5] MAINTAINERS: Adding myself in the list for ppc/spapr

On 3/31/23 03:53, Harsh Prateek Bora wrote: Would like to get notified of changes in this area and review them. Signed-off-by: Harsh Prateek Bora --- All reviewers are welcome. Reviewed-by: Daniel Henrique Barboza MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAI

Re: [PATCH 4/5] ppc: spapr: cleanup spapr_exit_nested() with helper routines.

Harsh Prateek Bora writes: > Currently, in spapr_exit_nested(), it does a lot of register state > restoring from ptregs/hvstate after mapping each of those before > restoring the L1 host state. This patch breaks down those set of ops > to respective helper routines for better code readability/mai

Re: [RFC PATCH 0/1] Implement entropy leak reporting for virtio-rng

On Thu, 2023-04-13 at 15:36 +0200, Babis Chalios wrote: > > On 11/4/23 18:20, Jason A. Donenfeld wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the sender and know > > the content is safe. > > > > >

Re: [PATCH 0/5] Cleanup [h_enter|spapr_exit]_nested routines

Harsh Prateek Bora writes: > This patchset introduces helper routines to enable (and does) cleaning > up of h_enter_nested() and spapr_exit_nested() routines in existing api > for nested virtualization on Power/SPAPR for better code readability / > maintenance. No functional changes intended wit

Re: [RFC PATCH] migration: Handle block device inactivation failures better

Eric Blake wrote: > Consider what happens when performing a migration between two host > machines connected to an NFS server serving multiple block devices to > the guest, when the NFS server becomes unavailable. The migration > attempts to inactivate all block devices on the source (a necessary

Re: [RFC 1/1] add support of `--initrd` for ELF-ARM kernels

> Am 14.04.2023 um 10:54 schrieb Alex Bennée : > Hello Alex, > > Where are these DTB nodes documented? Yes, it is currently missing. > > Also could you not achieve the same thing using the guest-loader which > uses the multiboot spec and sets: > >const char *compat[2] = { "multiboo

Re: [PATCH 0/3] SDL2 usability fixes

Am 13. April 2023 21:40:29 UTC schrieb "Volker Rümelin" : >Am 13.04.23 um 22:43 schrieb Bernhard Beschow: >> >> Am 13. April 2023 17:54:34 UTC schrieb "Volker Rümelin" >> : I'm trying to use QEMU on Windows hosts for fun and for profit. While the GTK GUI doesn't seem to support

Re: [RFC PATCH] migration: Handle block device inactivation failures better

On Fri, Apr 14, 2023 at 02:15:45PM +0200, Juan Quintela wrote: > Eric Blake wrote: > > Consider what happens when performing a migration between two host > > machines connected to an NFS server serving multiple block devices to > > the guest, when the NFS server becomes unavailable. The migration

Re: [PATCH 0/3] SDL2 usability fixes

Am 14. April 2023 06:53:18 UTC schrieb "Volker Rümelin" : >Am 13.04.23 um 22:43 schrieb Bernhard Beschow: >> >> Am 13. April 2023 17:54:34 UTC schrieb "Volker Rümelin" >> : I'm trying to use QEMU on Windows hosts for fun and for profit. While the GTK GUI doesn't seem to support

Re: [PATCH] hw/core: Move numa.c into the target independent source set

On 13/4/23 20:26, Thomas Huth wrote: There is nothing that depends on target specific macros in this file, so we can move it to the common source set to avoid that we have to compile this file multiple times (one time for each target). Signed-off-by: Thomas Huth --- hw/core/meson.build | 2 +-

Re: [PATCH] rtl8139: fix large_send_mss divide-by-zero

On 13/4/23 19:19, Stefan Hajnoczi wrote: If the driver sets large_send_mss to 0 then a divide-by-zero occurs. Even if the division wasn't a problem, the for loop that emits MSS-sized packets would never terminate. Solve these issues by skipping offloading when large_send_mss=0. This issue was f

Re: [PATCH 2/2] chardev: Allow setting file chardev input file on the command line

On 13/4/23 17:07, Peter Maydell wrote: Our 'file' chardev backend supports both "output from this chardev is written to a file" and "input from this chardev should be read from a file" (except on Windows). However, you can only set up the input file if you're using the QMP interface -- there is n

Re: [RFC PATCH v2 02/10] tests: add python3-venv dependency

On 14/4/23 07:54, John Snow wrote: Several debian-based tests need the python3-venv dependency as a consequence of Debian debundling the "ensurepip" module normally included with Python. As mkvenv.py stands as of this commit, Debian requires EITHER: (A) setuptools and pip, or (B) ensurepip mkv

Re: [PATCH 2/2] chardev: Allow setting file chardev input file on the command line

On Fri, 14 Apr 2023 at 15:03, Philippe Mathieu-Daudé wrote: > > On 13/4/23 17:07, Peter Maydell wrote: > > --- a/qemu-options.hx > > +++ b/qemu-options.hx > > > > -``-chardev file,id=id,path=path`` > > +``-chardev file,id=id,path=path[,input-path=input-path]`` > > Log all traffic received fr

Re: [PATCH 01/40] hw/net/net_tx_pkt: Decouple from PCI

On 14/4/23 13:36, Akihiko Odaki wrote: This also fixes the leak of memory mapping when the specified memory is partially mapped. Fixes: e263cd49c7 ("Packet abstraction for VMWARE network devices") Signed-off-by: Akihiko Odaki --- hw/net/net_tx_pkt.c | 65 +++--

Re: [PATCH 04/40] igb: Include the second VLAN tag in the buffer

On 14/4/23 13:37, Akihiko Odaki wrote: Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 55de212447..f725ab97ae 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -1590,7 +1

Re: [PATCH 04/40] igb: Include the second VLAN tag in the buffer

On 14/4/23 16:28, Philippe Mathieu-Daudé wrote: On 14/4/23 13:37, Akihiko Odaki wrote: Signed-off-by: Akihiko Odaki ---   hw/net/igb_core.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 55de212447..f725ab97ae 100644 --- a/hw/net

Re: [PATCH 04/40] igb: Include the second VLAN tag in the buffer

On 14/4/23 16:32, Philippe Mathieu-Daudé wrote: On 14/4/23 16:28, Philippe Mathieu-Daudé wrote: On 14/4/23 13:37, Akihiko Odaki wrote: Signed-off-by: Akihiko Odaki ---   hw/net/igb_core.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c

Re: [PATCH 08/40] igb: Always copy ethernet header

On 14/4/23 13:37, Akihiko Odaki wrote: igb_receive_internal() used to check the iov length to determine copy the iovs to a contiguous buffer, but the check is flawed in two ways: - It does not ensure that iovcnt > 0. - It does not take virtio-net header into consideration. The size of this copy

Re: [PATCH 09/40] Fix references to igb Avocado test

On 14/4/23 13:37, Akihiko Odaki wrote: Fixes: 9f95111474 ("tests/avocado: re-factor igb test to avoid timeouts") Signed-off-by: Akihiko Odaki --- MAINTAINERS| 2 +- docs/system/devices/igb.rst| 2 +- scripts/ci/org.centos/stream

[PATCH] accel/tcg/tcg-accel-ops-rr: ensure fairness with icount

The round-robin scheduler will iterate over the CPU list with an assigned budget until the next timer expiry and may exit early because of a TB exit. This is fine under normal operation but with icount enabled and SMP it is possible for a CPU to be starved of run time and the system live-locks. F

Re: [PATCH 1/2] qtest: Don't assert on "-qtest chardev:myid"

On 13/04/2023 17.07, Peter Maydell wrote: If the -qtest command line argument is passed a string that says "use this chardev for I/O", then it will assert: $ ./build/clang/qemu-system-i386 -chardev file,path=/dev/null,id=myid -qtest chardev:myid Unexpected error in qtest_set_chardev() at ../../

Re: [PATCH 2/2] chardev: Allow setting file chardev input file on the command line

On 13/04/2023 17.07, Peter Maydell wrote: Our 'file' chardev backend supports both "output from this chardev is written to a file" and "input from this chardev should be read from a file" (except on Windows). However, you can only set up the input file if you're using the QMP interface -- there i

[PATCH 0/2] Improvements for the device-crash-test jobs

Improve the runtime of the device-crash-test jobs by avoiding to run "configure" again and by forcing to test with TCG only (instead of testing twice, with TCG and KVM). Thomas Huth (2): gitlab-ci: Avoid to re-run "configure" in the device-crash-test jobs scripts/device-crash-test: Add a param

[PATCH 2/2] scripts/device-crash-test: Add a parameter to run with TCG only

We're currently facing the problem that the device-crash-test script runs twice as long in the CI when a runner supports KVM - which sometimes results in a timeout of the CI job. To get a more deterministic runtime here, add an option to the script that allows to run it with TCG only. Reported-by:

[PATCH 1/2] gitlab-ci: Avoid to re-run "configure" in the device-crash-test jobs

After "make check-venv" had been added to these jobs, they started to re-run "configure" each time since our logic in the makefile thinks that some files are out of date here. Avoid it with the same trick that we are using in buildtest-template.yml already by disabling the up-to-date check via NINJ

Re: [PATCH 15/40] e1000x: Take CRC into consideration for size check

On 14/4/23 13:37, Akihiko Odaki wrote: Section 13.7.15 Receive Length Error Count says: Packets over 1522 bytes are oversized if LongPacketEnable is 0b (RCTL.LPE). If LongPacketEnable (LPE) is 1b, then an incoming packet is considered oversized if it exceeds 16384 bytes. These lengths are b

Re: [PATCH 16/40] e1000e: Always log status after building rx metadata

On 14/4/23 13:37, Akihiko Odaki wrote: Without this change, the status flags may not be traced e.g. if checksum offloading is disabled. Signed-off-by: Akihiko Odaki --- hw/net/e1000e_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 17/40] igb: Always log status after building rx metadata

On 14/4/23 13:37, Akihiko Odaki wrote: Without this change, the status flags may not be traced e.g. if checksum offloading is disabled. Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé diff --g

Re: [PATCH 23/40] igb: Share common VF constants

On 14/4/23 13:37, Akihiko Odaki wrote: The constants need to be consistent between the PF and VF. Signed-off-by: Akihiko Odaki --- hw/net/igb.c| 10 +- hw/net/igb_common.h | 8 hw/net/igbvf.c | 7 --- 3 files changed, 13 insertions(+), 12 deletions(-)

Re: [PATCH 24/40] igb: Fix igb_mac_reg_init alignment

On 14/4/23 13:37, Akihiko Odaki wrote: Signed-off-by: Akihiko Odaki --- hw/net/igb_core.c | 96 +++ 1 file changed, 48 insertions(+), 48 deletions(-) "Fix igb_mac_reg_init() coding style alignment" to clarify this isn't about data alignment. Revi

Re: [PATCH 25/40] net/eth: Use void pointers

On 14/4/23 13:37, Akihiko Odaki wrote: The uses of uint8_t pointers were misleading as they are never accessed as an array of octets and it even require more strict alignment to access as struct eth_header. Signed-off-by: Akihiko Odaki --- include/net/eth.h | 4 ++-- net/eth.c | 6 ++

Re: [PATCH 38/40] vmxnet3: Do not depend on PC

On 14/4/23 13:37, Akihiko Odaki wrote: vmxnet3 has no dependency on PC, and VMware Fusion actually makes it available on Apple Silicon according to: https://kb.vmware.com/s/article/90364 Signed-off-by: Akihiko Odaki --- hw/net/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) R

Re: [PATCH 39/40] MAINTAINERS: Add a reviewer for network packet abstractions

On 14/4/23 13:37, Akihiko Odaki wrote: I have made significant changes for network packet abstractions so add me as a reviewer. Signed-off-by: Akihiko Odaki --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé

Re: virtio-iommu hotplug issue

On Thu, Apr 13, 2023 at 08:01:54PM +0900, Akihiko Odaki wrote: > Yes, that's right. The guest can dynamically create and delete VFs. The > device is emulated by QEMU: igb, an Intel NIC recently added to QEMU and > projected to be released as part of QEMU 8.0. Ah great, that's really useful, I'll a

  1   2   >