Re: Audio playback speed issue on sam460ex and pegasos2

2023-03-20 Thread Volker Rümelin
Am 19.03.23 um 21:18 schrieb BALATON Zoltan: On Sun, 19 Mar 2023, Volker Rümelin wrote: Am 19.03.23 um 18:49 schrieb BALATON Zoltan: On Sun, 12 Mar 2023, Volker Rümelin wrote: Am 12.03.23 um 15:09 schrieb Rene Engel: Tested with -audiodev coreaudio,id=audio0,out.buffer-count=1 to 12 1 is too

[PATCH] vfio/pci: add support for VF token

2023-03-20 Thread Minwoo Im
VF token was introduced [1] to kernel vfio-pci along with SR-IOV support [2]. This patch adds support VF token among PF and VF(s). To passthu PCIe VF to a VM, kernel >= v5.7 needs this. It can be configured with UUID like: -device vfio-pci,host=:BB:DD:F,vf-token=,... [1] https://lore.ker

[PATCH v1 1/1] util/async-teardown: wire up query-command-line-options

2023-03-20 Thread Claudio Imbrenda
The recently introduced -async-teardown commandline option was not wired up properly and did not show up in the output of the QMP command query-command-line-options. This means that libvirt will have no way to discover whether the feature is supported. This patch fixes the issue by correctly wirin

Re: [PATCH] qtests: avoid printing comments before g_test_init()

2023-03-20 Thread Thomas Huth
On 17/03/2023 18.05, Daniel P. Berrangé wrote: The TAP protocol version line must be the first thing printed on stdout. The migration test failed that requirement in certain scenarios: # Skipping test: Userfault not available (builtdtime) TAP version 13 # random seed: R02Sc120c807f11053

Re: [PATCH for 8.0] qemu/osdep: Switch position of "extern" and "G_NORETURN"

2023-03-20 Thread Thomas Huth
On 18/03/2023 21.23, Bernhard Beschow wrote: + Thomas, Daniel (gitlab issue) and Stefan (Windows) Thanks, I'll pick the patch for my next pull request. Thomas Am 18. März 2023 18:59:31 UTC schrieb Bernhard Beschow : Fixes the Windows build under msys2 using GCC 12 which fails with the fol

Re: [RFC PATCH v1 00/12] *** Add allwinner R40 device support ***

2023-03-20 Thread qianfan
在 2023/3/9 4:47, Niek Linnenbank 写道: Hello Qianfan Zhao, Thanks for contributing this work to Qemu! With your contribution, we would get yet another Allwinner SoC supported, making it three in total (A10/H3/R40). That's great. My thoughts are that maybe we should try to re-use commonality b

Re: [PATCH v1 1/1] util/async-teardown: wire up query-command-line-options

2023-03-20 Thread Thomas Huth
On 20/03/2023 08.48, Claudio Imbrenda wrote: The recently introduced -async-teardown commandline option was not wired up properly and did not show up in the output of the QMP command query-command-line-options. This means that libvirt will have no way to discover whether the feature is supported.

Re: [PATCH v1 1/1] util/async-teardown: wire up query-command-line-options

2023-03-20 Thread Claudio Imbrenda
On Mon, 20 Mar 2023 09:56:05 +0100 Thomas Huth wrote: > On 20/03/2023 08.48, Claudio Imbrenda wrote: > > The recently introduced -async-teardown commandline option was not > > wired up properly and did not show up in the output of the QMP command > > query-command-line-options. This means that li

[PATCH v3 0/2] Use f-strings and black code style

2023-03-20 Thread Marco Liebel
Replaces python 2 format strings with f-strings and applies black code style to all python files in target/hexagon. Marco Liebel (2): Use f-strings in python scripts Use black code style for python scripts target/hexagon/dectree.py | 396 +++-- target/hexagon/gen_analyz

[PATCH v3 1/2] Use f-strings in python scripts

2023-03-20 Thread Marco Liebel
Replace python 2 format string with f-strings Signed-off-by: Marco Liebel --- target/hexagon/gen_analyze_funcs.py | 115 - target/hexagon/gen_helper_funcs.py | 54 ++-- target/hexagon/gen_helper_protos.py | 10 +- target/hexagon/gen_idef_parser_funcs.py | 8 +- target/he

[PATCH v3 2/2] Use black code style for python scripts

2023-03-20 Thread Marco Liebel
Signed-off-by: Marco Liebel --- target/hexagon/dectree.py | 396 --- target/hexagon/gen_analyze_funcs.py | 135 +++--- target/hexagon/gen_helper_funcs.py | 338 +++-- target/hexagon/gen_helper_protos.py | 165 --- target/hexagon/gen_idef_parser_f

Re: [PATCH] replace TABs with spaces

2023-03-20 Thread Thomas Huth
On 15/03/2023 04.26, Yeqi Fu wrote: Bring the files in line with the QEMU coding style, with spaces for indentation. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/378 Signed-off-by: Yeqi Fu --- chardev/baum.c| 66 +- hw/char/parallel.c| 24 +- hw/ch

About the instance_finalize callback in VFIO PCI

2023-03-20 Thread Yang Zhong
Hello Alex and Paolo, There is one instance_finalize callback definition in hw/vfio/pci.c, but i find this callback(vfio_instance_finalize()) never be called during the VM shutdown with close VM or "init 0" command in guest. The Qemu related command: .. -device vfio-pci,host=d9:00.0

Re: [Virtio-fs] [RFC 2/2] vhost-user-fs: Implement stateful migration

2023-03-20 Thread Hanna Czenczek
On 17.03.23 19:37, Anton Kuchin wrote: On 17/03/2023 19:52, Hanna Czenczek wrote: On 17.03.23 18:19, Anton Kuchin wrote: On 13/03/2023 19:48, Hanna Czenczek wrote: A virtio-fs device's VM state consists of: - the virtio device (vring) state (VMSTATE_VIRTIO_DEVICE) - the back-end's (virtiofsd's

[PULL 1/6] acpi: enable tests/data/acpi updates

2023-03-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8bf4..b5ed0904b5ff 100644 --- a/tests/qtest/bios-tables-test-al

[PULL 0/6] Edk2 stable202302 20230320 patches

2023-03-20 Thread Gerd Hoffmann
.git tags/edk2-stable202302-20230320-pull-request for you to fetch changes up to 86305e864191123dcf87c3af639fddfc59352ac6: edk2: update firmware binaries (2023-03-20 10:36:31 +0100) update edk2 to 202302

[PULL 3/6] acpi: disable tests/data/acpi updates

2023-03-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index b5ed0904b5ff..dfb8523c8bf4 100644 --- a/tests/qtest/bios-tables-test-all

[PULL 5/6] edk2: replace build scripts

2023-03-20 Thread Gerd Hoffmann
Remove Makefile.edk2 and the edk2*.sh scripts and replace them with a python script (which already handles fedora rpm builds) and a config file for it. Signed-off-by: Gerd Hoffmann --- roms/edk2-build.py | 380 + roms/Makefile | 29 +--- roms

[PULL 4/6] edk2: update submodule to edk2-stable202302

2023-03-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé --- pc-bios/README | 4 ++-- roms/edk2 | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pc-bios/README b/pc-bios/README index 3702ed485c63..c555dd324ea1 100644 --- a/pc-bios/README +++ b/pc-bios/README @@

[PULL 2/6] bios-tables-test: use 128M numa nodes on aarch64

2023-03-20 Thread Gerd Hoffmann
Recent edk2 versions don't boot with very small numa nodes. Bump the size from 64M to 128M. Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test.c | 6 +++--- tests/data/acpi/virt/SRAT.acpihmatvirt | Bin 240 -> 240 bytes tests/data/acpi/virt/SSDT.memhp| Bin 1817 -> 18

Re: [RFC PATCH v1 00/12] *** Add allwinner R40 device support ***

2023-03-20 Thread Strahinja Jankovic
Hi, Could you try maybe running OpenWRT instead of Armbian? Link to the stable image for M2 Ultra is is https://downloads.openwrt.org/releases/22.03.3/targets/sunxi/cortexa7/openwrt-22.03.3-sunxi-cortexa7-sinovoip_bananapi-m2-ultra-ext4-sdcard.img.gz Best reregards , Strahinja On Mon, Mar 20,

Re: [PATCH 1/4] util/iov: Make qiov_slice() public

2023-03-20 Thread Vladimir Sementsov-Ogievskiy
On 17.03.23 20:50, Hanna Czenczek wrote: We want to inline qemu_iovec_init_extended() in block/io.c for padding requests, and having access to qiov_slice() is useful for this. (We will need to count the number of I/O vector elements of a slice there, and then later process this slice. Without q

Re: [PATCH] vfio/pci: add support for VF token

2023-03-20 Thread Cédric Le Goater
On 3/20/23 08:35, Minwoo Im wrote: VF token was introduced [1] to kernel vfio-pci along with SR-IOV support [2]. This patch adds support VF token among PF and VF(s). To passthu PCIe VF to a VM, kernel >= v5.7 needs this. It can be configured with UUID like: -device vfio-pci,host=:BB:DD:

[PATCH 07/10] accel/tcg: use QEMU_IOTHREAD_LOCK_GUARD to cover the exit

2023-03-20 Thread Alex Bennée
This avoids us having to make sure each exit path does an unlock. Signed-off-by: Alex Bennée --- accel/tcg/cpu-exec.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index ea2e7004fe..daa6e24daf 100644 --- a/accel/tcg/c

[PATCH 00/10] accel/tcg: refactor the cpu-exec loop

2023-03-20 Thread Alex Bennée
This is an RFC for something I was playing with over the weekend to try and reduce target specific details polluting cpu-exec. In the end it does get rid of TARGET_I386 #ifdef'ery but I couldn't go further to just building one version of cpu-exec-user and cpu-exec-softmmu because there are still pe

[PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu

2023-03-20 Thread Alex Bennée
This doesn't save much as cpu-exec-common still needs to be built per-target for its knowledge of CPUState but this helps with keeping things organised. Signed-off-by: Alex Bennée --- accel/tcg/cpu-exec-common.c | 30 -- accel/tcg/cpu-exec-softmmu.c | 50

[PATCH 09/10] accel/tcg: re-inline the filtering of virtual IRQs but data driven

2023-03-20 Thread Alex Bennée
Although only I386 currently uses it it is not inconceivable that other arches might find this facility useful. Signed-off-by: Alex Bennée --- include/hw/core/tcg-cpu-ops.h | 5 + accel/tcg/cpu-exec.c | 29 + target/i386/tcg/tcg-cpu.c | 1 + 3 files

[PATCH 03/10] accel/tcg: move i386 halt handling to sysemu_ops

2023-03-20 Thread Alex Bennée
We don't want to be polluting the core run loop code with target specific handling, punt it to sysemu_ops where it belongs. Signed-off-by: Alex Bennée --- include/hw/core/sysemu-cpu-ops.h | 5 + target/i386/cpu-internal.h | 1 + accel/tcg/cpu-exec.c | 14 +++--- t

[PATCH 01/10] metadata: add .git-blame-ignore-revs

2023-03-20 Thread Alex Bennée
Someone mentioned this on IRC so I thought I would try it out with a few commits that are pure code style fixes. Signed-off-by: Alex Bennée --- .git-blame-ignore-revs | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 .git-blame-ignore-revs diff --git a/.git-blame-ign

[PATCH 08/10] accel/tcg: push i386 specific hacks into handle_cpu_interrupt callback

2023-03-20 Thread Alex Bennée
Signed-off-by: Alex Bennée --- include/hw/core/sysemu-cpu-ops.h | 11 +++ target/i386/cpu-internal.h | 1 + accel/tcg/cpu-exec-softmmu.c | 16 accel/tcg/cpu-exec.c | 31 ++- target/i386/cpu-sysemu.c | 17 +

[PATCH 05/10] accel/tcg: remove the fake_user_interrupt guards

2023-03-20 Thread Alex Bennée
At the cost of an empty tcg_ops field for most targets we can avoid target specific hacks in cpu-exec.c Signed-off-by: Alex Bennée --- include/hw/core/tcg-cpu-ops.h | 2 +- accel/tcg/cpu-exec.c | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/

[PATCH 04/10] accel/tcg: don't bother with ifdef for CPU_DUMP_CCOP

2023-03-20 Thread Alex Bennée
While only i386 dumps anything useful for the flag it could potentially be used by others. Front ends that don't understand the flag will ignore it anyway. Signed-off-by: Alex Bennée --- accel/tcg/cpu-exec.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/accel/tcg/cpu-ex

[PATCH 10/10] accel/tcg: remove unused includes

2023-03-20 Thread Alex Bennée
Signed-off-by: Alex Bennée --- accel/tcg/cpu-exec.c | 4 1 file changed, 4 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 56be7956e7..90e327c3bb 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -19,20 +19,16 @@ #include "qemu/osdep.h" #include

[PATCH 06/10] includes: move irq definitions out of cpu-all.h

2023-03-20 Thread Alex Bennée
These are common across all versions of the system so it would help if we could use them for common code. Signed-off-by: Alex Bennée --- include/exec/cpu-all.h | 52 +- include/exec/cpu-irq.h | 83 ++ include/exec/poison.h | 13 ---

Re: [PATCH v2 6/6] ui/gtk: enable backend to send multi-touch events

2023-03-20 Thread Sergio Lopez
On Fri, Mar 17, 2023 at 12:02:41PM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Mar 16, 2023 at 4:07 PM Sergio Lopez wrote: > > > > GTK3 provides the infrastructure to receive and process multi-touch > > events through the "touch-event" signal and the GdkEventTouch type. > > Make use of it to

Re: [PATCH 2/4] block: Split padded I/O vectors exceeding IOV_MAX

2023-03-20 Thread Vladimir Sementsov-Ogievskiy
On 17.03.23 20:50, Hanna Czenczek wrote: When processing vectored guest requests that are not aligned to the storage request alignment, we pad them by adding head and/or tail buffers for a read-modify-write cycle. The guest can submit I/O vectors up to IOV_MAX (1024) in length, but with this pad

[PATCH] python: honour message limit when using pre-opened socket

2023-03-20 Thread Daniel P . Berrangé
The default message recv limit in asyncio is smaller than our needs, so when opening connections we override it. This was done when opening a connection using a socket address, but was missed when using a pre-opened socket file descriptor. This latent bug was exposed when the QEMUMachine class was

Re: [PATCH] python: honour message limit when using pre-opened socket

2023-03-20 Thread Marc-André Lureau
On Mon, Mar 20, 2023 at 2:54 PM Daniel P. Berrangé wrote: > The default message recv limit in asyncio is smaller than our needs, so > when opening connections we override it. This was done when opening a > connection using a socket address, but was missed when using a > pre-opened socket file des

Re: [RFC PATCH v1 00/12] *** Add allwinner R40 device support ***

2023-03-20 Thread qianfan
在 2023/3/20 17:50, Strahinja Jankovic 写道: Hi, Could you try maybe running OpenWRT instead of Armbian? Link to the stable image for M2 Ultra is is https://downloads.openwrt.org/releases/22.03.3/targets/sunxi/cortexa7/openwrt-22.03.3-sunxi-cortexa7-sinovoip_bananapi-m2-ultra-ext4-sdcard.img.g

Re: [PATCH v3 3/3] python/qemu/machine: use socketpair() for QMP by default

2023-03-20 Thread Daniel P . Berrangé
On Fri, Mar 17, 2023 at 10:36:37PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi! > > By my investigation, this commit (bd4c0ef409140bd1be393407c04005ac077d4574) > breaks long qmp output again. > > ./test.py 1000 /tmp/sock > > - works, but if use default behavior (socketpair) we get: > >

Re: [PATCH v3 10/14] migration/ram: Introduce 'fixed-ram' migration stream capability

2023-03-20 Thread Claudio Fontana
On 2/10/23 18:11, Daniel P. Berrangé wrote: > On Fri, Oct 28, 2022 at 01:39:10PM +0300, Nikolay Borisov wrote: >> Implement 'fixed-ram' feature. The core of the feature is to ensure that >> each ram page of the migration stream has a specific offset in the >> resulting migration stream. The reason

Re: [PATCH v3 10/14] migration/ram: Introduce 'fixed-ram' migration stream capability

2023-03-20 Thread Claudio Fontana
Added Fabiano to the thread, CLaudio On 3/20/23 12:05, Claudio Fontana wrote: > On 2/10/23 18:11, Daniel P. Berrangé wrote: >> On Fri, Oct 28, 2022 at 01:39:10PM +0300, Nikolay Borisov wrote: >>> Implement 'fixed-ram' feature. The core of the feature is to ensure that >>> each ram page of the mig

[PATCH 1/3] win32: add qemu_close_to_socket()

2023-03-20 Thread marcandre . lureau
From: Marc-André Lureau Close the given file descriptor, but returns the underlying SOCKET. Signed-off-by: Marc-André Lureau --- include/sysemu/os-win32.h | 1 + util/oslib-win32.c| 68 +-- 2 files changed, 38 insertions(+), 31 deletions(-) diff --

[PATCH 2/3] ui/spice: fix SOCKET handling regression

2023-03-20 Thread marcandre . lureau
From: Marc-André Lureau Spice uses SOCKET on win32, but QEMU now uses file-descriptors. Fixes "8.0.0rc0 Regression: spicy windows doesn't open": https://gitlab.com/qemu-project/qemu/-/issues/1549 Fixes: commit abe34282b ("win32: avoid mixing SOCKET and file descriptor space") Signed-off-by: Mar

Re: [PATCH v3 00/14] File-based migration support and fixed-ram features

2023-03-20 Thread Claudio Fontana
(adding Fabiano to the thread) On 2/10/23 16:35, Daniel P. Berrangé wrote: > On Thu, Feb 09, 2023 at 02:32:01PM +0100, Claudio Fontana wrote: >> Hello Daniel and all, >> >> resurrecting this series from end of last year, >> >> do we think that this is the right approach and first step to >> be abl

[PATCH 0/3] Fix Spice regression on win32

2023-03-20 Thread marcandre . lureau
From: Marc-André Lureau Marc-André Lureau (3): win32: add qemu_close_to_socket() ui/spice: fix SOCKET handling regression ui/dbus: fix passing SOCKET to GSocket API & leak include/sysemu/os-win32.h | 1 + ui/dbus.c | 8 + ui/spice-core.c | 29

[PATCH 3/3] ui/dbus: fix passing SOCKET to GSocket API & leak

2023-03-20 Thread marcandre . lureau
From: Marc-André Lureau -display dbus is not currently available to win32 users, so it's not considered a regression. Note also the close() leak fix in case of error. Signed-off-by: Marc-André Lureau --- ui/dbus.c | 8 1 file changed, 8 insertions(+) diff --git a/ui/dbus.c b/ui/dbus

Re: [PATCH] target/s390x/tcg/mem_helper: Remove bad assert() statement

2023-03-20 Thread David Hildenbrand
On 17.03.23 14:57, Thomas Huth wrote: The "assert(!nonfault)" statement can be triggered by running the "mvpg" s390x kvm-unit-test with TCG. According to Richard: "... the assert looks backward. We should only arrive there if nonfault was true for the probe (otherwise the probe would have raised

Re: [PATCH v3 00/14] File-based migration support and fixed-ram features

2023-03-20 Thread Daniel P . Berrangé
On Mon, Mar 20, 2023 at 12:14:53PM +0100, Claudio Fontana wrote: > (adding Fabiano to the thread) > > On 2/10/23 16:35, Daniel P. Berrangé wrote: > > On Thu, Feb 09, 2023 at 02:32:01PM +0100, Claudio Fontana wrote: > >> Hello Daniel and all, > >> > >> resurrecting this series from end of last year

[PATCH] ui/gtk: fix cursor moved to lower-left corner

2023-03-20 Thread marcandre . lureau
From: Marc-André Lureau Do not attempt to move the pointer if the widget is not yet realized. (this is reproducible with X11) Fixes: 6effaa16ac98 ("ui: set cursor position upon listener registration") Reported-by: Bernhard Beschow Signed-off-by: Marc-André Lureau --- ui/gtk.c | 3 ++- 1 file

Re: [PATCH 3/4] util/iov: Remove qemu_iovec_init_extended()

2023-03-20 Thread Vladimir Sementsov-Ogievskiy
On 17.03.23 20:50, Hanna Czenczek wrote: bdrv_pad_request() was the main user of qemu_iovec_init_extended(). HEAD^ has removed that use, so we can remove qemu_iovec_init_extended() now. The only remaining user is qemu_iovec_init_slice(), which can easily inline the small part it really needs. N

Re: [PATCH v1] hw/pvrdma: Protect against buggy or malicious guest driver

2023-03-20 Thread Yuval Shaia
Hi, Patch is currently under review. >From my end, it was tested and proved to solve the problem. To follow up you may need to check qemu-devel@nongnu.org from time to time. Marcel, any feedback? Yuval On Mon, 13 Mar 2023 at 18:56, Red Hat Product Security wrote: > Hello! > > INC2534320 ([PAT

Re: [PATCH v1] hw/pvrdma: Protect against buggy or malicious guest driver

2023-03-20 Thread Red Hat Product Security
Hello! INC2534320 ([PATCH v1] hw/pvrdma: Protect against buggy or malicious guest driver) has been updated. Opened for: yuval.shaia...@gmail.com Followers: qemu-devel@nongnu.org, soulchen8...@gmail.com, Mauro Matteo Cascella, qemu-secur...@nongnu.org, yuval.shaia...@gmail.com, marcel.apfelb...

Re: [PATCH 1/3] win32: add qemu_close_to_socket()

2023-03-20 Thread Daniel P . Berrangé
On Mon, Mar 20, 2023 at 03:14:10PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Close the given file descriptor, but returns the underlying SOCKET. > > Signed-off-by: Marc-André Lureau > --- > include/sysemu/os-win32.h | 1 + > util/oslib-win32.c| 68 +++

Re: [PATCH 2/3] ui/spice: fix SOCKET handling regression

2023-03-20 Thread Daniel P . Berrangé
On Mon, Mar 20, 2023 at 03:14:11PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Spice uses SOCKET on win32, but QEMU now uses file-descriptors. > > Fixes "8.0.0rc0 Regression: spicy windows doesn't open": > https://gitlab.com/qemu-project/qemu/-/issues/1549 > > Fixes:

Re: [PATCH 4/4] iotests/iov-padding: New test

2023-03-20 Thread Vladimir Sementsov-Ogievskiy
On 17.03.23 20:50, Hanna Czenczek wrote: Test that even vectored IO requests with 1024 vector elements that are not aligned to the device's request alignment will succeed. Signed-off-by: Hanna Czenczek Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 3/3] ui/dbus: fix passing SOCKET to GSocket API & leak

2023-03-20 Thread Daniel P . Berrangé
On Mon, Mar 20, 2023 at 03:14:12PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > -display dbus is not currently available to win32 users, so it's not > considered a regression. > > Note also the close() leak fix in case of error. > > Signed-off-by: Marc-André Lureau >

Re: [PATCH] ui/gtk: fix cursor moved to lower-left corner

2023-03-20 Thread Daniel P . Berrangé
On Mon, Mar 20, 2023 at 03:47:56PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Do not attempt to move the pointer if the widget is not yet realized. > (this is reproducible with X11) What is reproducible ? Can you describe the problem that was reported by Bernhard ?

Re: [PATCH] python: honour message limit when using pre-opened socket

2023-03-20 Thread Vladimir Sementsov-Ogievskiy
On 20.03.23 13:54, Daniel P. Berrangé wrote: The default message recv limit in asyncio is smaller than our needs, so when opening connections we override it. This was done when opening a connection using a socket address, but was missed when using a pre-opened socket file descriptor. This latent

Re: [Virtio-fs] [RFC 2/2] vhost-user-fs: Implement stateful migration

2023-03-20 Thread Anton Kuchin
On 20/03/2023 11:33, Hanna Czenczek wrote: On 17.03.23 19:37, Anton Kuchin wrote: On 17/03/2023 19:52, Hanna Czenczek wrote: On 17.03.23 18:19, Anton Kuchin wrote: On 13/03/2023 19:48, Hanna Czenczek wrote: A virtio-fs device's VM state consists of: - the virtio device (vring) state (VMSTATE_

Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu

2023-03-20 Thread Claudio Fontana
How is this conditional on CONFIG_TCG? To me it looks like this breaks !CONFIG_TCG. Careful, the meson.build in accel/tcg/meson.build is always recursed. This code was in tcg_ss before, why not simply add it to tcg_ss and then to specific_ss along with the other tcg pieces? Ciao, C On 3/20/2

[PULL 04/24] tests/tcg/s390x: Add PSW modification tests

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Add several small tests that check the PSW modification instructions: * lpsw.S checks whether LPSW works correctly in the "happy" case. * lpswe-early.S checks whether early exceptions are recognized and whether the correct ILC and old PSW are stored when they happen. *

[PULL 17/24] target/s390x: Handle STRL to non-aligned addresses

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Message-Id: <20230316164428.275147-10-...@linux.ibm.

[PULL 10/24] target/s390x: Handle EXECUTE of odd addresses

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Generate a specification exception in the helper before trying to fetch the instruction. Reported-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Message-Id: <20230316164428.275147-3-...@linux.ibm.com> Signed-off-by: Thomas Hut

[PULL 19/24] target/s390x: Update do_unaligned_access() comment

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Relative long instructions now depend on do_unaligned_access() too. Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Message-Id: <20230316164428.275147-12-...@linux.ibm.com> Signed-off-by: Thomas Huth --- target/s390x/tcg/excp_helper.c | 4 ++-- 1 file ch

[PULL 21/24] target/s390x/tcg/mem_helper: Remove bad assert() statement

2023-03-20 Thread Thomas Huth
The "assert(!nonfault)" statement can be triggered by running the "mvpg" s390x kvm-unit-test with TCG. According to Richard: "... the assert looks backward. We should only arrive there if nonfault was true for the probe (otherwise the probe would have raised the exception directly). I would think

[PULL 01/24] MAINTAINERS: Mark the Nios II CPU as orphan

2023-03-20 Thread Thomas Huth
Marek and Chris haven't been active for Nios II since years (the last time seems to have been in 2017), and we've got unhandled severe Nios II bug tickets in the bug tracker since a long time, so to avoid wrong expectations of people who are looking at the MAINTAINERS file, it's maybe best to mark

[PULL 12/24] target/s390x: Handle LRL and LGFRL from non-aligned addresses

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Message-Id: <20230316164428.275147-5-...@linux.ibm.c

[PULL 07/24] target/s390x: Fix EXECUTE of relative long instructions

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich The code uses the wrong base for relative addressing: it should use the target instruction address and not the EXECUTE's address. Fix by storing the target instruction address in the new CPUS390XState member and loading it from the code generated by gen_ri2(). Reported-by

[PULL 03/24] target/s390x: Implement Early Exception Recognition

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Generate a specification exception if a reserved bit is set in the PSW mask or if the PSW address is out of bounds dictated by the addressing mode. Reported-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich Reviewed-by: David Hildenbrand Message-Id: <202303150

[PULL 02/24] target/s390x: Fix LPSW

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Currently LPSW does not invert the mask bit 12 and incorrectly copies the BA bit into the address. Fix by generating code similar to what s390_cpu_load_normal() does. Reported-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leosh

[PULL 05/24] target/s390x: Fix R[NOX]SBG with T=1

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich RXSBG usage in the "filetests" test from the wasmtime testsuite makes tcg_reg_alloc_op() attempt to temp_load() a TEMP_VAL_DEAD temporary, causing an assertion failure: 0x01000a70: ec14 b040 3057 rxsbg%r1, %r4, 0xb0, 0x40, 0x30 OP after optimization and live

[PULL 18/24] target/s390x: Handle STGRL to non-aligned addresses

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Message-Id: <20230316164428.275147-11-...@linux.ibm.

[PULL 22/24] tests/unit/test-blockjob: Disable complete_in_standby test

2023-03-20 Thread Thomas Huth
From: Peter Maydell The blockjob/complete_in_standby test is flaky and fails intermittently in CI: 172/621 qemu:unit / test-blockjob ERROR 0.26s killed by signal 6 SIGABRT 11:03:46 MALLOC_PERTURB_=176 G_TEST_SRCDIR=/Users/pm215/src/qemu-for-merges/tests/unit G_TEST_BUILDDI

[PULL 09/24] target/s390x: Handle branching to odd addresses

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Let branching happen and try to generate a new translation block with an odd address. Generate a specification exception in cpu_get_tb_cpu_state(). Reported-by: Harold Grovesteen Reported-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard H

[PULL 00/24] s390x and misc patches for 8.0-rc1

2023-03-20 Thread Thomas Huth
Hi Peter! The following changes since commit 74c581b6452394e591f13beba9fea2ec0688e2f5: Merge tag 'trivial-branch-for-8.0-pull-request' of https://gitlab.com/laurent_vivier/qemu into staging (2023-03-17 14:22:01 +) are available in the Git repository at: https://gitlab.com/thuth/qemu.g

[PULL 11/24] target/s390x: Handle LGRL from non-aligned addresses

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Message-Id: <20230316164428.275147-4-...@linux.ibm.c

[PULL 14/24] target/s390x: Handle CRL and CGFRL with non-aligned addresses

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Message-Id: <20230316164428.275147-7-...@linux.ibm.c

[PULL 15/24] target/s390x: Handle CGRL and CLGRL with non-aligned addresses

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Message-Id: <20230316164428.275147-8-...@linux.ibm.c

[PULL 13/24] target/s390x: Handle LLGFRL from non-aligned addresses

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Message-Id: <20230316164428.275147-6-...@linux.ibm.c

[PULL 23/24] qemu/osdep: Switch position of "extern" and "G_NORETURN"

2023-03-20 Thread Thomas Huth
From: Bernhard Beschow Fixes the Windows build under msys2 using GCC 12 which fails with the following error: [184/579] Compiling C++ object qga/vss-win32/qga-vss.dll.p/install.cpp.obj FAILED: qga/vss-win32/qga-vss.dll.p/install.cpp.obj "c++" "-m64" "-mcx16" "-Iqga/vss-win32/qga-vss.dll.p"

[PULL 16/24] target/s390x: Handle CLRL and CLGFRL with non-aligned addresses

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Message-Id: <20230316164428.275147-9-...@linux.ibm.c

[PULL 20/24] tests/tcg/s390x: Test unaligned accesses

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Add a number of small test that check whether accessing unaligned addresses in various ways leads to a specification exception. Run these test both in softmmu and user configurations; expect a PGM in one case and SIGILL in the other. Signed-off-by: Ilya Leoshkevich Revie

[PULL 08/24] tests/tcg/s390x: Add ex-relative-long.c

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Test EXECUTE and EXECUTE RELATIVE LONG with relative long instructions as targets. Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Reviewed-by: Nina Schoetterl-Glausch Message-Id: <20230316210751.302423-3-...@linux.ibm.com> Signed-off-by: Thomas Huth ---

[PULL 06/24] tests/tcg/s390x: Add rxsbg.c

2023-03-20 Thread Thomas Huth
From: Ilya Leoshkevich Add a small test for RXSBG with T=1 to prevent regressions. Signed-off-by: Ilya Leoshkevich Message-Id: <20230316172205.281369-3-...@linux.ibm.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/tcg/s390x/rxsbg.c | 46

[PATCH-for-8.0] qemu/osdep.h: Do not declare function prototypes using extern keyword

2023-03-20 Thread Philippe Mathieu-Daudé
By default, C function prototypes declared in headers are visible, so there is no need to declare them as 'extern' functions. Remove this redundancy. This also fixes when building under MSYS2: C:/msys64/mingw64/include/glib-2.0/glib/gmacros.h:1075:21: error: standard attributes in middle of dec

[PATCH v2 1/1] util/async-teardown: wire up query-command-line-options

2023-03-20 Thread Claudio Imbrenda
The recently introduced -async-teardown commandline option was not wired up properly and did not show up in the output of the QMP command query-command-line-options. This means that libvirt will have no way to discover whether the feature is supported. This patch fixes the issue by correctly wirin

[PATCH v2 0/1] util/async-teardown: wire up query-command-line-options

2023-03-20 Thread Claudio Imbrenda
The recently introduced -async-teardown commandline option was not wired up properly and did not show up in the output of the QMP command query-command-line-options. This means that libvirt will have no way to discover whether the feature is supported. This patch fixes the issue by correctly wirin

[PATCH] hw/acpi: limit warning on acpi table size to pc machines older than version 2.3

2023-03-20 Thread Ani Sinha
i440fx machine versions 2.3 and newer and q35 machines supports dynamic ram resizing. Please see commit a1666142db6233 ("acpi-build: make ROMs RAM blocks resizeable") . Hence the warning when the ACPI table size exceeds a pre-defined value does not apply to those machines. Add a check limiting the

[PATCH] Add my old and new work email mapping and use work email to support biosbits

2023-03-20 Thread Ani Sinha
From: Ani Sinha Update mailmap to indicate a...@anisinha.ca and anisi...@redhat.com are one and the same person. Additionally update MAINTAINERS and bits documentation to use my work (redhat) email. Signed-off-by: Ani Sinha --- .mailmap | 1 + MAINTAINERS | 2 +- d

[PATCH] hw/nvme: Change alignment in dma functions for nvme_blk_*

2023-03-20 Thread Mateusz Kozlowski
Since the nvme_blk_read/write are used by both the data and metadata portions of the IO, it can't have the 512B alignment requirement. Without this change any metadata transfer, which length isn't a multiple of 512B and which is bigger than 512B, will result in only a partial transfer. Signed-off-

Re: [PATCH] target/i386: Fix exception classes for SSE/AVX instructions.

2023-03-20 Thread Ricky Zhou
On Sun, Feb 12, 2023 at 12:28 AM Ricky Zhou wrote: > Fix the exception classes for some SSE/AVX instructions to match what is > documented in the Intel manual. Friendly ping :-) Does this change seem reasonable to folks? Patchew link: https://patchew.org/QEMU/20230212082812.55101-1-ri...@rzhou.or

Intent to add a VirtIO SCMI device

2023-03-20 Thread Milan Zamazal
Hi, FYI, I intend to create patches to add a VirtIO SCMI vhost user device to QEMU. As for the vhost user daemon part, I wonder whether there is already something publicly available, which could be used or benefit from cooperation. If not then I'll start making my own implementation. At the mom

[PATCH v2] ui/gtk: fix cursor moved to left corner

2023-03-20 Thread marcandre . lureau
From: Marc-André Lureau Do not attempt to move the pointer if the widget is not yet realized. The mouse cursor is placed to the corner of the screen, on X11 at least, as x_root and y_root are then miscalculated. (this is not reproducible on Wayland, because Gtk doesn't implement device warping th

Re: [PATCH-for-8.0] qemu/osdep.h: Do not declare function prototypes using extern keyword

2023-03-20 Thread Daniel P . Berrangé
On Mon, Mar 20, 2023 at 02:14:26PM +0100, Philippe Mathieu-Daudé wrote: > By default, C function prototypes declared in headers are visible, > so there is no need to declare them as 'extern' functions. Remove > this redundancy. This also fixes when building under MSYS2: > > C:/msys64/mingw64/inc

Re: [PATCH v2] ui/gtk: fix cursor moved to left corner

2023-03-20 Thread Daniel P . Berrangé
On Mon, Mar 20, 2023 at 05:26:24PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Do not attempt to move the pointer if the widget is not yet realized. > The mouse cursor is placed to the corner of the screen, on X11 at least, > as x_root and y_root are then miscalculated

[PATCH v2 0/3] Fix Spice regression on win32

2023-03-20 Thread marcandre . lureau
From: Marc-André Lureau Hi, v2: (suggestions from Daniel Berrange) - change function qemu_close_socket_osfhandle() - add some documentation for it - simplify a bit the dbus-related code Marc-André Lureau (3): win32: add qemu_close_socket_osfhandle() ui/spice: fix SOCKET handling regression

[PATCH v2 1/3] win32: add qemu_close_socket_osfhandle()

2023-03-20 Thread marcandre . lureau
From: Marc-André Lureau Close the given file descriptor, but returns the underlying SOCKET. Signed-off-by: Marc-André Lureau --- include/sysemu/os-win32.h | 15 ++-- util/oslib-win32.c| 75 +-- 2 files changed, 53 insertions(+), 37 deletions(-)

[PATCH v2 3/3] ui/dbus: fix passing SOCKET to GSocket API & leak

2023-03-20 Thread marcandre . lureau
From: Marc-André Lureau -display dbus is not currently available to win32 users, so it's not considered a regression. Note also the close() leak fix in case of error. Signed-off-by: Marc-André Lureau --- ui/dbus.c | 9 + 1 file changed, 9 insertions(+) diff --git a/ui/dbus.c b/ui/dbu

[PATCH v2 2/3] ui/spice: fix SOCKET handling regression

2023-03-20 Thread marcandre . lureau
From: Marc-André Lureau Spice uses SOCKET on win32, but QEMU now uses file-descriptors. Fixes "8.0.0rc0 Regression: spicy windows doesn't open": https://gitlab.com/qemu-project/qemu/-/issues/1549 Fixes: commit abe34282b ("win32: avoid mixing SOCKET and file descriptor space") Signed-off-by: Mar

  1   2   3   >