On 15/03/2023 18.43, Alex Bennée wrote:
A couple of clean-ups here:
- inherit from the custom runners job for artefacts
I know, it's a difference between BE and AE, but in case you want to be
consistent with the yml: s/artefacts/artifacts/
- call check-avocado directly
- add some
On 15/03/2023 18.43, Alex Bennée wrote:
I've only added the names explicitly acked.
Signed-off-by: Alex Bennée
Cc: Bernhard Beschow
Cc: Amarjargal Gundjalam
Cc: Bin Meng
Cc: Jason A. Donenfeld
Cc: Strahinja Jankovic
Acked-by: Bernhard Beschow
Message-Id: <20230310180332.2274827-10-alex.be
On 2023/3/5 22:34, ~abordado wrote:
From: Afonso Bordado
RISC-V does not expose all extensions via hwcaps, thus some userspace
applications may want to query these via /proc/cpuinfo.
Currently when querying this file the host's file is shown instead
which is slightly confusing. Emulate a bas
On 16/03/2023 18.22, Ilya Leoshkevich wrote:
Add a small test for RXSBG with T=1 to prevent regressions.
Signed-off-by: Ilya Leoshkevich
---
tests/tcg/s390x/Makefile.target | 3 +++
tests/tcg/s390x/rxsbg.c | 46 +
2 files changed, 49 insertions(+)
From: Marc-André Lureau
Since commit 6effaa16 ("ui: set cursor position upon listener
registration") a new error message shows up when starting qemu with gtk
backend:
qemu: Gdk: gdk_window_get_root_coords: assertion 'GDK_IS_WINDOW (window)' failed
Like many display listener callbacks, skip code
Hi
On Thu, Mar 16, 2023 at 4:07 PM Sergio Lopez wrote:
>
> GTK3 provides the infrastructure to receive and process multi-touch
> events through the "touch-event" signal and the GdkEventTouch type.
> Make use of it to transpose events from the host to the guest.
>
> This allows users of machines w
Hi
On Thu, Mar 16, 2023 at 4:07 PM Sergio Lopez wrote:
>
> Add the required infrastructure to support generating multitouch events.
>
> Signed-off-by: Sergio Lopez
> ---
> include/ui/input.h| 3 +++
> qapi/ui.json | 45 ---
> replay/replay-i
On Thu, Mar 16, 2023 at 4:07 PM Sergio Lopez wrote:
>
> Add a virtio-multitouch device to the family of devices emulated by
> virtio-input implementing the Multi-touch protocol as descripted here:
>
> https://www.kernel.org/doc/html/latest/input/multi-touch-protocol.html?highlight=multi+touch
>
>
чт, 16 мар. 2023 г., 15:35 Daniel P. Berrangé :
> On Thu, Mar 16, 2023 at 02:11:08PM +0300, Andrew Randrianasulu wrote:
> > чт, 16 мар. 2023 г., 14:02 Thomas Huth :
> >
> > > On 16/03/2023 11.22, Andrew Randrianasulu wrote:
> > > >
> > > >
> > > > чт, 16 мар. 2023 г., 12:17 Andrew Randrianasulu <
On Thu, Mar 16, 2023 at 4:07 PM Sergio Lopez wrote:
>
> Add virtio-multitouch-pci, a Multitouch-capable input device, to the
> list of devices that can be provided by virtio-input-pci.
>
> Signed-off-by: Sergio Lopez
Reviewed-by: Marc-André Lureau
> ---
> hw/virtio/virtio-input-pci.c | 25 ++
On 16.03.23 18:44, Vladimir Sementsov-Ogievskiy wrote:
On 15.03.23 15:13, Hanna Czenczek wrote:
When processing vectored guest requests that are not aligned to the
storage request alignment, we pad them by adding head and/or tail
buffers for a read-modify-write cycle.
The guest can submit I/O v
The duration of loading non-iterable vmstate accounts for a significant
portion of downtime (starting with the timestamp of source qemu stop and
ending with the timestamp of target qemu start). Most of the time is spent
committing memory region changes repeatedly.
This patch packs all the changes
In last patch, we wrap vm_load with begin/commit, here we introduce
address_space_to_flatview_rcu() to avoid unnecessary enforce commit
during vm_load.
Signed-off-by: Chuang Xu
---
include/exec/memory.h | 17 +
softmmu/memory.c | 2 +-
2 files changed, 18 insertions(+), 1 d
In next patch, we wrap the vm_load into a whole mr transaction to speed
up vm_load. This brings a problem, old flatviews may be referenced
during the vm_load. vm_load contains far more memory updates than
referencing to a specific flatview, hence we introduce do_commit to
make sure address_space_to
From: Peter Xu
Calling RCU variants of address_space_get|to_flatview() during memory
commit (flatview updates, triggering memory listeners, or updating
ioeventfds, etc.) is not 100% accurate, because commit() requires BQL
rather than RCU read lock, so the context exclusively owns current_map and
Add rcu_read_is_locked() to detect holding of rcu lock.
Signed-off-by: Chuang Xu
---
include/qemu/rcu.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/qemu/rcu.h b/include/qemu/rcu.h
index 313fc414bc..7bf45602e1 100644
--- a/include/qemu/rcu.h
+++ b/include/qemu/rcu.h
@@ -115
In this version:
- delete useless line change.
- update comments and commit messages.
The duration of loading non-iterable vmstate accounts for a significant
portion of downtime (starting with the timestamp of source qemu stop and
ending with the timestamp of target qemu start). Most of the tim
Split memory_region_transaction_do_commit() from
memory_region_transaction_commit().
We'll call do_commit() in address_space_to_flatview() in the later patch.
Signed-off-by: Chuang Xu
---
softmmu/memory.c | 47 +++
1 file changed, 27 insertions(+), 20
On 14/03/2023 18.30, Cornelia Huck wrote:
Add 8.1 machine types for arm/i440fx/m68k/q35/s390x/spapr.
Signed-off-by: Cornelia Huck
---
hw/arm/virt.c | 9 -
hw/core/machine.c | 3 +++
hw/i386/pc.c | 3 +++
hw/i386/pc_piix.c | 16 +++
On 16/03/2023 17.44, Ilya Leoshkevich wrote:
Add a number of small test that check whether accessing unaligned
addresses in various ways leads to a specification exception.
Run these test both in softmmu and user configurations; expect a PGM
in one case and SIGILL in the other.
Signed-off-by: I
On 2023/3/12 20:05, Yi Chen wrote:
- Trap satp/hgatp accesses from HS-mode when MSTATUS.TVM is enabled.
- Trap satp accesses from VS-mode when HSTATUS.VTVM is enabled.
- Raise RISCV_EXCP_ILLEGAL_INST when U-mode executes SFENCE.VMA/SINVAL.VMA.
- Raise RISCV_EXCP_VIRT_INSTRUCTION_FAULT when VU-m
> -Original Message-
> From: Akihiko Odaki
> Sent: Friday, 17 March 2023 06:46
> To: Sriram Yagnaraman
> Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry
> Fleytman ; quint...@redhat.com; Philippe
> Mathieu-Daudé
> Subject: Re: [PATCH for 8.0 v2] igb: Save the entire Tx context descripto
On 3/17/23 12:49 AM, Guenter Roeck wrote:
The i.MX USB Phy driver does not check register ranges, resulting in out of
bounds accesses if an attempt is made to access non-existing PHY registers.
Add range check and conditionally report bad accesses to fix the problem.
While at it, also conditiona
Fix code style.
Signed-off-by: 李皆俊
---
migration/ram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index 96e8a19a58..46c0c8dbb9 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -3295,7 +3295,7 @@ static int ram_save_setup(QEMUFile *f
On Mon, 6 Mar 2023 at 11:16, Peter Maydell wrote:
>
> On Fri, 3 Mar 2023 at 18:36, Peter Maydell wrote:
> >
> > I've noticed that test-blockjob seems to fail intermittently
> > on the msys2-64bit job:
> >
> > https://gitlab.com/qemu-project/qemu/-/jobs/3872508803
> > https://gitlab.com/qemu-proje
On 15.03.23 20:18, Durrant, Paul wrote:
-Original Message-
From: Alex Bennée
Sent: 15 March 2023 17:43
To: qemu-devel@nongnu.org
Cc: Akihiko Odaki ; Marc-André Lureau
; qemu-ri...@nongnu.org; Riku Voipio
; Igor Mammedov ; Xiao Guangrong
; Thomas Huth ; Wainer dos
Santos Moschetta ; Dr.
On 16/03/2023 17.44, Ilya Leoshkevich wrote:
Add a number of small test that check whether accessing unaligned
addresses in various ways leads to a specification exception.
Run these test both in softmmu and user configurations; expect a PGM
in one case and SIGILL in the other.
Signed-off-by: I
On 17/03/2023 11.54, Thomas Huth wrote:
On 16/03/2023 17.44, Ilya Leoshkevich wrote:
Add a number of small test that check whether accessing unaligned
addresses in various ways leads to a specification exception.
Run these test both in softmmu and user configurations; expect a PGM
in one case a
On Fri, 2023-03-17 at 12:00 +0100, Thomas Huth wrote:
> On 17/03/2023 11.54, Thomas Huth wrote:
> > On 16/03/2023 17.44, Ilya Leoshkevich wrote:
> > > Add a number of small test that check whether accessing unaligned
> > > addresses in various ways leads to a specification exception.
> > >
> > > R
On 2023/03/17 18:19, Sriram Yagnaraman wrote:
-Original Message-
From: Akihiko Odaki
Sent: Friday, 17 March 2023 06:46
To: Sriram Yagnaraman
Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry
Fleytman ; quint...@redhat.com; Philippe
Mathieu-Daudé
Subject: Re: [PATCH for 8.0 v2] igb: Sav
> -Original Message-
> From: Akihiko Odaki
> Sent: Friday, 17 March 2023 12:13
> To: Sriram Yagnaraman
> Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry
> Fleytman ; quint...@redhat.com; Philippe
> Mathieu-Daudé
> Subject: Re: [PATCH for 8.0 v2] igb: Save the entire Tx context descripto
Hi Mostafa,
On 2/26/23 23:06, Mostafa Saleh wrote:
> In preparation for adding stage-2 support, add a S2 config
> struct(SMMUS2Cfg), composed of the following fields and embedded in
> the main SMMUTransCfg:
> -tsz: Input range
> -sl0: start level of translation
> -affd: AF fault disable
> -gra
On 3/17/23 00:04, liweiwei wrote:
On 2023/3/16 04:37, Daniel Henrique Barboza wrote:
On 3/15/23 02:25, liweiwei wrote:
On 2023/3/15 00:49, Daniel Henrique Barboza wrote:
write_misa() must use as much common logic as possible. We want to open
code just the bits that are exclusive to the
I have a mild dislike of abbreviations like "env var". Perhaps:
qapi: Support updating expected test output via make
Daniel P. Berrangé writes:
> It is possible to pass --update to tests/qapi-schema/test-qapi.py
> to make it update the output files on error. This is inconvient
> to achieve
On 15/03/2023 18.43, Alex Bennée wrote:
It seems we also need to pass DOCKER_BUILDKIT as an argument to docker
itself to get the full benefit of caching.
Signed-off-by: Alex Bennée
Suggested-by: Fabiano Rosas
---
tests/docker/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deleti
Daniel P. Berrangé writes:
> When describing member types always include the context of the
> containing type. Although this is often redundant, in some cases
> it will help to reduce ambiguity.
Unfortunately, it can also be confusing, as we shall see below.
> Signed-off-by: Daniel P. Berrangé
On 15/03/2023 18.43, Alex Bennée wrote:
So you can do:
cd tests/tcg/aarch64-linux-user
make -f ../Makefile.target help
To see the list of tests. You can then run each one individually.
Signed-off-by: Alex Bennée
---
tests/tcg/Makefile.target | 7 +++
1 file changed, 7 insertions(
On 15/03/2023 18.43, Alex Bennée wrote:
Some API documentation was missed, rectify that.
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1497
Signed-off-by: Alex Bennée
---
include/qemu/qemu-plugin.h | 47 ++
1 file changed, 43 insertions(+), 4 deleti
On Friday, March 17, 2023 5:36:37 AM CET Shi, Guohuai wrote:
[...]
> > > > > > +do {
> > > > > > +full_dir_entry = get_full_path_win32(hDir,
> > > > > > + dd_data.name);
> > > > > > +
> > > > > > +if (full_dir_entry == NULL) {
> > > > > > +err = ENOMEM;
> > > > > > +
The current implementation of igb uses only part of a advanced Tx
context descriptor and first data descriptor because it misses some
features and sniffs the trait of the packet instead of respecting the
packet type specified in the descriptor. However, we will certainly
need the entire Tx context
On Fri, Mar 17, 2023 at 07:10:52AM +0100, Markus Armbruster wrote:
> Eric Blake writes:
>
> > On Thu, Mar 16, 2023 at 08:13:22AM +0100, Markus Armbruster wrote:
> >> Union TestIfUnion is conditional on macros TEST_IF_UNION and
> >> TEST_IF_STRUCT. It uses TestIfEnum, which is conditional on macr
On 17/03/2023 11.17, Peter Maydell wrote:
On Mon, 6 Mar 2023 at 11:16, Peter Maydell wrote:
On Fri, 3 Mar 2023 at 18:36, Peter Maydell wrote:
I've noticed that test-blockjob seems to fail intermittently
on the msys2-64bit job:
https://gitlab.com/qemu-project/qemu/-/jobs/3872508803
https://
> -Original Message-
> From: Akihiko Odaki
> Sent: Friday, 17 March 2023 13:25
> Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry
> Fleytman ; quint...@redhat.com; Philippe
> Mathieu-Daudé ; Sriram Yagnaraman
> ; Akihiko Odaki
> Subject: [PATCH for 8.0] igb: Save more Tx states
>
> The c
On Thu, 16 Mar 2023 at 10:41, Gerd Hoffmann wrote:
>
> The following changes since commit 652737c8090eb3792f8b4c4b22ab12d7cc32073f:
>
> Update version for v8.0.0-rc0 release (2023-03-14 19:25:05 +)
>
> are available in the Git repository at:
>
> https://gitlab.com/kraxel/qemu.git tags/seab
On Thu, 16 Mar 2023 at 15:13, Juan Quintela wrote:
>
> The following changes since commit 9636e513255362c4a329e3e5fb2c97dab3c5ce47:
>
> Merge tag 'misc-next-pull-request' of https://gitlab.com/berrange/qemu into
> staging (2023-03-15 17:20:04 +)
>
> are available in the Git repository at:
>
Hi all,
We are using obmc-phosphor-image on an ast2500 board which is trying to
communicate with other devices over serial port /dev/ttyS2.
As we are trying to emulate the machine on qemu we need to redirect the
request to the host machine so that it can handle this request and return
appropriatel
ping
https://patchew.org/QEMU/cover.1677589218.git.gudkov.and...@huawei.com/
-Original Message-
From: Gudkov Andrei
Sent: Tuesday, February 28, 2023 16:16
To: qemu-devel@nongnu.org
Cc: quint...@redhat.com; dgilb...@redhat.com; Gudkov Andrei
Subject: [PATCH 0/2] Migration time predictio
On Thu, 16 Mar 2023 at 16:48, Viktor Prutyanov
wrote:
>
>
>
> > Hi,
> >
> > For now, elf2dmp is unable to convert ELF-dump to DMP-dump made of
> > Windows Server 2022 guest. This patch series fixes it.
> >
> > v1: improve code-style fix
> > v2: don't remove data directory entry RVA print and DOS h
On Thu, 16 Mar 2023 at 23:49, Guenter Roeck wrote:
>
> The i.MX USB Phy driver does not check register ranges, resulting in out of
> bounds accesses if an attempt is made to access non-existing PHY registers.
> Add range check and conditionally report bad accesses to fix the problem.
>
> While at
The "assert(!nonfault)" statement can be triggered by running the
"mvpg" s390x kvm-unit-test with TCG. According to Richard: "... the
assert looks backward. We should only arrive there if nonfault was
true for the probe (otherwise the probe would have raised the
exception directly). I would think
On 3/16/23 19:57, LIU Zhiwei wrote:
Hi Richard,
When I read the tcg code, I find a corner case which may be a bug in
liveness_pass_1.
I see all TEMP_TBs or global temps are set to TS_DEAD | TS_MEM when enter liveness_pass_1.
Think about the sequence.
1)Write_global_temp_0 // 0->TS_DEAD, b
Hello Ben,
thanks for update.
On Thursday 16 of March 2023 13:41:13 Ben Dooks wrote:
> From: Ben Dooks
>
> Add support for Microchip MCP25625 SPI based CAN controller which is
> very similar to the MCP2515 (and covered by the same Linux driver).
>
> This can be added to any machine with SPI supp
Eric Blake writes:
> On Fri, Mar 17, 2023 at 07:10:52AM +0100, Markus Armbruster wrote:
>> Eric Blake writes:
>>
>> > On Thu, Mar 16, 2023 at 08:13:22AM +0100, Markus Armbruster wrote:
>> >> Union TestIfUnion is conditional on macros TEST_IF_UNION and
>> >> TEST_IF_STRUCT. It uses TestIfEnum,
From: Ilya Leoshkevich
When using QEMU_LOG=cpu on sh4, QEMU_LOG_FILENAME is partially ignored.
Fix by using qemu_fprintf() instead of qemu_printf() in the respective
places.
Fixes: 90c84c560067 ("qom/cpu: Simplify how CPUClass:cpu_dump_state() prints")
Reviewed-by: Peter Maydell
Reviewed-by: Yo
changes up to 364206640c6b34bae3bb9e428817e51d23a794d0:
docs/sphinx/kerneldoc.py: Honour --enable-werror (2023-03-16 14:39:10 +0100)
Trivial branch pull request 20230317
Fix doc
Fix sh4 cpu log output
From: Bernhard Beschow
During build the kernel-doc script complains about the following issue:
src/docs/../include/exec/memory.h:1741: warning: Function parameter or member
'n' not described in 'memory_region_unmap_iommu_notifier_range'
src/docs/../include/exec/memory.h:1741: warning: Exces
From: Peter Maydell
Currently, the kerneldoc Sphinx plugin doesn't honour the
--enable-werror configure option, so its warnings are never fatal.
This is because although we do pass sphinx-build the -W switch, the
warnings from kerneldoc are produced by the scripts/kernel-doc script
directly and d
On 2023/03/17 22:08, Sriram Yagnaraman wrote:
-Original Message-
From: Akihiko Odaki
Sent: Friday, 17 March 2023 13:25
Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry
Fleytman ; quint...@redhat.com; Philippe
Mathieu-Daudé ; Sriram Yagnaraman
; Akihiko Odaki
Subject: [PATCH for 8.0] ig
On 3/17/23 06:57, Thomas Huth wrote:
The "assert(!nonfault)" statement can be triggered by running the
"mvpg" s390x kvm-unit-test with TCG. According to Richard: "... the
assert looks backward. We should only arrive there if nonfault was
true for the probe (otherwise the probe would have raised t
The blockjob/complete_in_standby test is flaky and fails
intermittently in CI:
172/621 qemu:unit / test-blockjob
ERROR 0.26s killed by signal 6 SIGABRT
11:03:46 MALLOC_PERTURB_=176
G_TEST_SRCDIR=/Users/pm215/src/qemu-for-merges/tests/unit
G_TEST_BUILDDIR=/Users/pm215/src/qe
Hi Eric,
Thanks for reviewing the patch.
On Fri, Mar 17, 2023 at 12:37:11PM +0100, Eric Auger wrote:
> Hi Mostafa,
>
> On 2/26/23 23:06, Mostafa Saleh wrote:
> > In preparation for adding stage-2 support, add a S2 config
> > struct(SMMUS2Cfg), composed of the following fields and embedded in
> >
On 3/7/23 02:17, Peter Maydell wrote:
It looks like we (inadvertently) broke "-R 0 means turn off"
in 2019 with commit dc18baaef36d95e5; prior to that the
64-on-32 default was set by the initial value of the global
variable and could be overridden on the command line. After
that we ended up doing
It is always 0 and it is not useful to route call through file
descriptor.
Signed-off-by: Eugenio Pérez
---
hw/virtio/vhost-vdpa.c | 2 +-
hw/virtio/trace-events | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index bc6bad23d
Evaluating it at start time instead of initialization time may make the
guest capable of dynamically adding or removing migration blockers.
Also, moving to initialization reduces the number of ioctls in the
migration, reducing failure possibilities.
Signed-off-by: Eugenio Pérez
---
net/vhost-vd
This allows to reset a vhost-vdpa device from external subsystems like
vhost-net. It is used in subsequent patches to negotiate features and
probe for CVQ ASID isolation.
Signed-off-by: Eugenio Pérez
---
include/hw/virtio/vhost-vdpa.h | 1 +
hw/virtio/vhost-vdpa.c | 58
QEMU v8.0.0-rc0 is able to switch dynamically between vhost-vdpa passthrough
and SVQ mode as long as the net device does not have CVQ. The net device
state followed (and migrated) by CVQ requires special care.
A pre-requisite to add CVQ to that framework is to determine if devices with
CVQ are mi
Continue the move of code that interacts with the device from control
virtqueue start to control virtqueue init.
As with previous patches, it reduces the number of ioctls in the
migration, reducing failure possibilities.
Signed-off-by: Eugenio Pérez
---
net/vhost-vdpa.c | 40 +++
This allows to set the features of a vhost-vdpa device from external
subsystems like vhost-net. It is used in subsequent patches to
negotiate features and probe for CVQ ASID isolation.
Signed-off-by: Eugenio Pérez
---
include/hw/virtio/vhost-vdpa.h | 1 +
hw/virtio/vhost-vdpa.c | 20 ++
We need to tell in the caller, as some errors are expected in a normal
workflow. In particular, parent drivers in recent kernels with
VHOST_BACKEND_F_IOTLB_ASID may not support vring groups. In that case,
-ENOTSUP is returned.
This is the case of vp_vdpa in Linux 6.2.
Next patches in this serie
On Fri, 17 Mar 2023 at 14:46, Richard Henderson
wrote:
>
> On 3/7/23 02:17, Peter Maydell wrote:
> > It looks like we (inadvertently) broke "-R 0 means turn off"
> > in 2019 with commit dc18baaef36d95e5; prior to that the
> > 64-on-32 default was set by the initial value of the global
> > variable
On Fri, 17 Mar 2023 at 14:57, Peter Maydell wrote:
>
> On Fri, 17 Mar 2023 at 14:46, Richard Henderson
> wrote:
> >
> > On 3/7/23 02:17, Peter Maydell wrote:
> > > It looks like we (inadvertently) broke "-R 0 means turn off"
> > > in 2019 with commit dc18baaef36d95e5; prior to that the
> > > 64-o
Thank you! Personally, I agree with any way to get the elf2dmp patch series
into the tree.
Best regards,
Viktor Prutyanov
> -Original Message-
> From: Akihiko Odaki
> Sent: Friday, 17 March 2023 15:21
> To: Sriram Yagnaraman
> Cc: qemu-devel@nongnu.org; Jason Wang ; Dmitry
> Fleytman ; quint...@redhat.com; Philippe
> Mathieu-Daudé
> Subject: Re: [PATCH for 8.0] igb: Save more Tx states
>
> On 2023/03/17 2
Daniel P. Berrangé writes:
> This extends the QAPI schema validation to permit unions inside unions,
> provided the checks for clashing fields pass.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> scripts/qapi/schema.py| 6 +-
> tests/qapi-schema/meson.build
Pass the address of the last byte to be changed, rather than
the first address past the last byte. This avoids overflow
when the last page of the address space is involved.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
include/exec/exec-all.h | 2 +-
accel/tcg/tb-
We have been enforcing host page alignment for the non-R
fallback of MAX_RESERVED_VA, but failing to enforce for -R.
Signed-off-by: Richard Henderson
---
linux-user/main.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/linux-user/main.c b/linux-user/main.c
index 4b18461969..39d9bd4d7a
Pass the address of the last byte to be changed, rather than
the first address past the last byte. This avoids overflow
when the last page of the address space is involved.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
accel/tcg/tb-maint.c | 28 --
Pass the address of the last byte to be changed, rather than
the first address past the last byte. This avoids overflow
when the last page of the address space is involved.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1528
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Hen
Pass the address of the last byte to be changed, rather than
the first address past the last byte. This avoids overflow
when the last page of the address space is involved.
Properly truncate tb_last to the end of the page; the comment about
tb_end being past the end of the page being ok is not co
Daniel P. Berrangé writes:
> Currently it is not possible for a union type to contain a
> further union as one (or more) of its branches. This relaxes
> that restriction and adds the calls needed to validate field
> name uniqueness as unions are flattened.
I apologize for the long delay. Sick c
Pass the address of the last byte to be changed, rather than
the first address past the last byte. This avoids overflow
when the last page of the address space is involved.
Fixes a bug in the loop comparision where "<= end" would lock
one more page than required.
Reviewed-by: Philippe Mathieu-Da
Rename to local_max_rva, to avoid a conflict with the next patch.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
linux-user/main.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index 39d9bd4d7a..165fcb
In addition to the rename, change the semantics to be the
last byte of the guest va, rather than the following byte.
This avoids some overflow conditions.
Signed-off-by: Richard Henderson
---
include/exec/cpu-all.h | 11 ++-
linux-user/arm/target_cpu.h | 2 +-
bsd-user/main.c
The primary issue is that of overflow, where "end" for the last
page of the 32-bit address space overflows to 0. The fix is to
use "last" instead, which can always be represented.
Changes for v2:
* Leave -R 0 unchanged; whether it's currently broken,
or unusable by design is unchanged by th
Pass the address of the last byte to be changed, rather than
the first address past the last byte. This avoids overflow
when the last page of the address space is involved.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
include/exec/cpu-all.h | 2 +-
accel/tcg/user-e
Abhishek Singh Dagur writes:
(cc aspeed maintainers)
> Hi all,
>
> We are using obmc-phosphor-image on an ast2500 board which is trying to
> communicate with other devices
> over serial port /dev/ttyS2.
> As we are trying to emulate the machine on qemu we need to redirect the
> request to th
Hello,
On 3/16/23 17:20, Akihiko Odaki wrote:
A guest may request ask a memory-mapped device to perform DMA. If the
address specified for DMA is the device performing DMA, it will create
recursion. It is very unlikely that device implementations are prepared
for such an abnormal access, which ca
On Thu, 16 Mar 2023 at 16:21, Akihiko Odaki wrote:
>
> A guest may request ask a memory-mapped device to perform DMA. If the
> address specified for DMA is the device performing DMA, it will create
> recursion. It is very unlikely that device implementations are prepared
> for such an abnormal acc
On Wed, 15 Mar 2023 at 09:51, Luis Machado wrote:
> On 3/13/23 11:44, Luis Machado wrote:
> > On 3/13/23 11:22, Peter Maydell via Gdb wrote:
> >> Luis and I came up with two options:
> >>
> >> (1) leave QEMU outputting the pauth xml as-is, and tell people
> >> whose gdb 12 crashes that they should
On Fri, 17 Mar 2023 00:11:10 +0530
Maverickk 78 wrote:
> Hi
>
> I am trying mctp & mctpd with aspeed +buildroot(master) + linux v6.2
> with Qemu 7.2.
>
>
> I have added necessary FMAPI related patches into QEMU to support CLX
> switch emulation
>
> RFC-1-2-misc-i2c_mctp_cxl_fmapi-Initial-dev
Unfortunately a bug in older versions of gdb means that they will
crash if QEMU sends them the aarch64-pauth.xml. This bug is fixed in
gdb commit 1ba3a3222039eb25, and there are plans to backport that to
affected gdb release branches, but since the bug affects gdb 9
through 12 it is very widely de
Michael Tsirkin raised that we have recently had churn in the bios-tables-test
and perhaps it was worth factoring some parts of DSDT out as SSDT files.
This is an attempt to do that for the entries from pxb-pcie and pxb-cxl
PCI root bridges.
The main PCI root bridge and related elements are left i
This allows the same code to be used for two purposes.
1) To fill in the crs_range_set as is later used to
generate the actual AML for the primary PCI host bridge.
2) Create the _CRS AML for the PXB bridges.
The separation is need to allow for DSDT to be generated
before an SSDT for any PXB instan
This reverts commit 1d0a8eba38c028ea02c6e0b68f0a4c9a3cbf.
The commit made the wrong assumption that 64-bit distros are most
common these days on arm devices, but as Liviu Ionescu pointed out,
the recommended OS for the very popular Raspberry Pi boards is still
the 32-bit variant, and thus like
Splitting the PXB parts out of DSDT will change these files.
Signed-off-by: Jonathan Cameron
---
tests/data/acpi/q35/SSDT.cxl| 0
tests/data/acpi/q35/SSDT.viot | 0
tests/qtest/bios-tables-test-allowed-diff.h | 4
3 files changed, 4 insertions(+)
diff --git a/
On 3/17/23 16:37, Peter Maydell wrote:
On Wed, 15 Mar 2023 at 09:51, Luis Machado wrote:
On 3/13/23 11:44, Luis Machado wrote:
On 3/13/23 11:22, Peter Maydell via Gdb wrote:
Luis and I came up with two options:
(1) leave QEMU outputting the pauth xml as-is, and tell people
whose gdb 12 crash
The dependencies between the CRS entries and bus numbers due to
PCI eXpander Bridges taking resources from the primary bus make this
a slightly complex dance.
The rules we have to fit into are:
1) FACP is first table in RSDT and points to the DSDT.
2) Thus DSDT is created before FACP
3) SSDT must
Signed-off-by: Jonathan Cameron
---
tests/data/acpi/q35/DSDT.cxl| Bin 9673 -> 8474 bytes
tests/data/acpi/q35/DSDT.viot | Bin 9470 -> 8429 bytes
tests/data/acpi/q35/SSDT.cxl| Bin 0 -> 1235 bytes
tests/data/acpi/q35/SSDT.viot | Bin 0 ->
The TAP protocol version line must be the first thing printed on
stdout. The migration test failed that requirement in certain
scenarios:
# Skipping test: Userfault not available (builtdtime)
TAP version 13
# random seed: R02Sc120c807f11053eb90bfea845ba1e368
1..32
# Start of x86_64 tests
On Fri, 17 Mar 2023 at 16:55, Luis Machado wrote:
> On 3/17/23 16:37, Peter Maydell wrote:
> > Having run into this problem in another couple of situations, one of
> > which involved gdb 10, I think I'm increasingly favouring option
> > 2 here. The affected gdbs seem to be quite widely deployed, a
1 - 100 of 137 matches
Mail list logo