Re: dropping 32-bit host support

Hi Andrew, On 16/3/23 01:57, Andrew Randrianasulu wrote: Looking at https://wiki.qemu.org/ChangeLog/8.0 === System emulation on 32-bit x86 and ARM hosts has been deprecated. The QEMU project no longer considers 32-bit x86 and ARM support for system emula

[PATCH 05/14] qapi: Improve error message for unexpected array types

We reject array types in certain places with "cannot be an array". Deleting this check improves the error message to "should be a type name" or "should be an object or type name", depending on context, so do that. Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py | 6

[PATCH 03/14] qapi: Clean up after removal of simple unions

Commit 4e99f4b12c0 (qapi: Drop simple unions) missed a bit of code dealing with simple union branches. Drop it. Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py index ca01ea6

[PATCH 01/14] qapi: Fix error message format regression

Commit 52a474180ae3 changed reporting of errors connected to a source location without mentioning it in the commit message. For instance, $ python scripts/qapi-gen.py tests/qapi-schema/unknown-escape.json tests/qapi-schema/unknown-escape.json:3:21: unknown escape \x became scripts/q

[PATCH 14/14] qapi: Require boxed for conditional command and event arguments

The C code generator fails to honor 'if' conditions of command and event arguments. For instance, tests/qapi-schema/qapi-schema-test.json has { 'event': 'TEST_IF_EVENT', 'data': { 'foo': 'TestIfStruct', 'bar': { 'type': ['str'], 'if': 'TEST_IF_EVT_ARG' } }, 'if': {

[PATCH 00/14] qapi: Fix minor bugs, require boxed for conditional arguments

PATCH 01-08 fix a few minor bugs I found on the way. Could be a separate series, but keeping them here seems simpler. PATCH 09-12 improve tests for 'if' conditionals. PATCH 13 fixes a code generation regression, and PATCH 14 rejects uses conditionals that never worked and aren't worth fixing. M

[PATCH 04/14] qapi: Split up check_type()

check_type() can check type names, arrays, and implicit struct types. Callers pass flags to select from this menu. This makes the function somewhat hard to read. Moreover, a few minor bugs are hiding in there, as we'll see shortly. Split it into check_type_name(), check_type_name_or_implicit().

[PATCH 08/14] qapi: Fix to reject 'data': 'mumble' in struct

A struct's 'data' must be a JSON object defining the struct's members. The QAPI code generator incorrectly accepts a JSON string instead, and then crashes in QAPISchema._make_members() called from ._def_struct_type(). Fix to reject it, and add a test case. Signed-off-by: Markus Armbruster --- s

[PATCH 09/14] tests/qapi-schema: Improve union discriminator coverage

A union's 'discriminator' must name a one of the common members. QAPISchemaVariants.check() looks it up by its c_name(), then checks the name matches exactly (because c_name() is not injective). Tests union-base-empty and union-invalid-discriminator both cover the case where lookup fails. Repurpo

[PATCH 07/14] qapi: Fix error message when type name or array is expected

We incorrectly report "FOO should be a type name" when it could also be an array. Fix that. Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py| 15 +++ tests/qapi-schema/event-nest-struct.err | 2 +- tests/qapi-schema/nested-struct-data.err|

[PATCH 12/14] tests/qapi-schema: Cover optional conditional struct member

Signed-off-by: Markus Armbruster --- tests/qapi-schema/qapi-schema-test.json | 3 ++- tests/qapi-schema/qapi-schema-test.out | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/qapi-schema/qapi-schema-test.json b/tests/qapi-schema/qapi-schema-test.json index 8f0ee95d23..

[PATCH 02/14] qapi/schema: Use super()

Commit 2cae67bcb5e (qapi: Use super() now we have Python 3) converted the code to super(). Shortly after, commit f965e8fea6a (qapi: New special feature flag "deprecated") neglected to use super(). Convert it now. Signed-off-by: Markus Armbruster --- scripts/qapi/schema.py | 2 +- 1 file change

[PATCH 13/14] qapi: Fix code generated for optional conditional struct member

The generated member visit neglects to emit #if around a conditional struct member's has_ variable. For instance, tests/qapi-schema/qapi-schema-test.json generates #if defined(TEST_IF_STRUCT) bool visit_type_TestIfStruct_members(Visitor *v, TestIfStruct *obj, Error **errp) { --->

[PATCH 11/14] tests/qapi-schema: Clean up positive test for conditionals

Union TestIfUnion is conditional on macros TEST_IF_UNION and TEST_IF_STRUCT. It uses TestIfEnum, which is conditional on macro TEST_IF_ENUM. If TEST_IF_ENUM and TEST_IF_STRUCT are defined, but TEST_IF_ENUM isn't, the generated code won't compile. Command test-if-cmd is conditional an macros TEST

[PATCH 06/14] qapi: Simplify code a bit after previous commit

Signed-off-by: Markus Armbruster --- scripts/qapi/expr.py | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py index 5abeaa19dd..8a8de9e3aa 100644 --- a/scripts/qapi/expr.py +++ b/scripts/qapi/expr.py @@ -335,21 +335,13 @@

[PATCH 10/14] tests/qapi-schema: Rename a few conditionals

Positive test case { 'enum': 'TestIfEnum', 'data': [ 'foo', { 'name' : 'bar', 'if': 'TEST_IF_ENUM_BAR' } ], 'if': 'TEST_IF_ENUM' } generates #if defined(TEST_IF_ENUM) typedef enum TestIfEnum { TEST_IF_ENUM_FOO, #if defined(TEST_IF_ENUM_BAR) TEST_IF_ENU

Re: dropping 32-bit host support

чт, 16 мар. 2023 г., 10:05 Philippe Mathieu-Daudé : > Hi Andrew, > > On 16/3/23 01:57, Andrew Randrianasulu wrote: > > Looking at https://wiki.qemu.org/ChangeLog/8.0 > > > > > > === > > System emulation on 32-bit x86 and ARM hosts has been deprecated. The > >

Re: dropping 32-bit host support

Hi Liviu, On 16/3/23 07:19, Liviu Ionescu wrote: On 16 Mar 2023, at 02:57, Andrew Randrianasulu wrote: Looking at https://wiki.qemu.org/ChangeLog/8.0 === System emulation on 32-bit x86 and ARM hosts has been deprecated. The QEMU project no longer considers 32-bit x86 and ARM support for s

Re: dropping 32-bit host support

On 16/3/23 08:17, Andrew Randrianasulu wrote: чт, 16 мар. 2023 г., 10:05 Philippe Mathieu-Daudé >: Hi Andrew, On 16/3/23 01:57, Andrew Randrianasulu wrote: > Looking at https://wiki.qemu.org/ChangeLog/8.0 >

Re: [PATCH 02/14] qapi/schema: Use super()

On 16/3/23 08:13, Markus Armbruster wrote: Commit 2cae67bcb5e (qapi: Use super() now we have Python 3) converted the code to super(). Shortly after, commit f965e8fea6a (qapi: New special feature flag "deprecated") neglected to use super(). Convert it now. Signed-off-by: Markus Armbruster ---

Re: [PATCH 05/14] qapi: Improve error message for unexpected array types

On 16/3/23 08:13, Markus Armbruster wrote: We reject array types in certain places with "cannot be an array". Deleting this check improves the error message to "should be a type name" or "should be an object or type name", depending on context, so do that. Signed-off-by: Markus Armbruster ---

Re: dropping 32-bit host support

чт, 16 мар. 2023 г., 10:36 Philippe Mathieu-Daudé : > On 16/3/23 08:17, Andrew Randrianasulu wrote: > > > > > > чт, 16 мар. 2023 г., 10:05 Philippe Mathieu-Daudé > >: > > > > Hi Andrew, > > > > On 16/3/23 01:57, Andrew Randrianasulu wrote: > > > Looking at h

Re: [PATCH 10/14] tests/qapi-schema: Rename a few conditionals

On 16/3/23 08:13, Markus Armbruster wrote: Positive test case { 'enum': 'TestIfEnum', 'data': [ 'foo', { 'name' : 'bar', 'if': 'TEST_IF_ENUM_BAR' } ], 'if': 'TEST_IF_ENUM' } generates #if defined(TEST_IF_ENUM) typedef enum TestIfEnum { TEST_IF_ENUM_FOO,

Re: [PATCH 12/14] tests/qapi-schema: Cover optional conditional struct member

On 16/3/23 08:13, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- tests/qapi-schema/qapi-schema-test.json | 3 ++- tests/qapi-schema/qapi-schema-test.out | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2] target/sh4: Honor QEMU_LOG_FILENAME with QEMU_LOG=cpu

On 16/3/23 01:34, Ilya Leoshkevich wrote: When using QEMU_LOG=cpu on sh4, QEMU_LOG_FILENAME is partially ignored. Fix by using qemu_fprintf() instead of qemu_printf() in the respective places. Fixes: 90c84c560067 ("qom/cpu: Simplify how CPUClass:cpu_dump_state() prints") Reviewed-by: Peter Mayde

Re: [PULL 0/3] Edk2 stable202302 20230309 patches

On Wed, Mar 15, 2023 at 05:16:10PM +0100, Laszlo Ersek wrote: > On 3/15/23 16:56, Gerd Hoffmann wrote: > > Hi, > > > >> ▶ 206/206 > >> ERROR:../tests/qtest/acpi-utils.c:158:acpi_find_rsdp_address_uefi: > >> code should not be reached ERROR > >> 206/206 qemu:qtest+qtest-aarch64 / qtest-aarch64/b

Re: dropping 32-bit host support

> On 16 Mar 2023, at 09:29, Philippe Mathieu-Daudé wrote: > > Hi Liviu, > >> or the countless 32-bit Raspberry Pi? >> my xPack binary tools, which include qemu arm & qemu riscv, are also >> available for arm 32-bit, and the analytics show about the same number of >> downloads for 32-bit as

Re: dropping 32-bit host support

> On 16 Mar 2023, at 09:57, Liviu Ionescu wrote: > > I'm not targeting RPi2; there are a lot of RPi4 with less than 8GB RAM (most > of them, actually), and even more RPi3, with even less RAM), and people > prefer to continue using the 32-bit OS on them, which works quite fine; Like it or no

Re: dropping 32-bit host support

On 16/03/2023 08.36, Philippe Mathieu-Daudé wrote: On 16/3/23 08:17, Andrew Randrianasulu wrote: чт, 16 мар. 2023 г., 10:05 Philippe Mathieu-Daudé >:     Hi Andrew,     On 16/3/23 01:57, Andrew Randrianasulu wrote: > Looking at https://wiki.qemu.org/ChangeLog/8

Re: dropping 32-bit host support

On 16/03/2023 09.07, Liviu Ionescu wrote: On 16 Mar 2023, at 09:57, Liviu Ionescu wrote: I'm not targeting RPi2; there are a lot of RPi4 with less than 8GB RAM (most of them, actually), and even more RPi3, with even less RAM), and people prefer to continue using the 32-bit OS on them, whic

Re: [PATCH v2 1/2] target/s390x: Fix R[NOX]SBG with T=1

On 16/3/23 00:56, Ilya Leoshkevich wrote: RXSBG usage in the "filetests" test from the wasmtime testsuite makes tcg_reg_alloc_op() attempt to temp_load() a TEMP_VAL_DEAD temporary, causing an assertion failure: 0x01000a70: ec14 b040 3057 rxsbg%r1, %r4, 0xb0, 0x40, 0x30 OP after

Re: dropping 32-bit host support

> On 16 Mar 2023, at 10:36, Thomas Huth wrote: > > ... It will take another year (or maybe more) until the deprecation will turn > into a real unsupported state. I assume by that point in time, more and more > RPi users will have switched to a 64-bit OS instead. There is an easy and accurat

Re: [PATCH for 8.0] exec/memory: Fix kernel-doc warning

Le 15/03/2023 à 08:57, Bernhard Beschow a écrit : + qemu-trivial Am 15. März 2023 07:25:52 UTC schrieb Bernhard Beschow : During build the kernel-doc script complains about the following issue: src/docs/../include/exec/memory.h:1741: warning: Function parameter or member 'n' not described i

Re: [PATCH v2] target/sh4: Honor QEMU_LOG_FILENAME with QEMU_LOG=cpu

Le 16/03/2023 à 08:52, Philippe Mathieu-Daudé a écrit : On 16/3/23 01:34, Ilya Leoshkevich wrote: When using QEMU_LOG=cpu on sh4, QEMU_LOG_FILENAME is partially ignored. Fix by using qemu_fprintf() instead of qemu_printf() in the respective places. Fixes: 90c84c560067 ("qom/cpu: Simplify how CP

Re: [PATCH] migration/rdma: Remove deprecated variable rdma_return_path

Not clear why it doesn't appear in the archive(https://lists.gnu.org/archive/html/qemu-devel/2023-03/threads.html) nop... On 15/03/2023 09:22, Li Zhijian wrote: > It's no longer needed since commit > 44bcfd45e98 ("migration/rdma: destination: create the return patch after the > first accept")

Re: [PATCH 02/10] python: drop pipenv

On 16/3/23 00:02, John Snow wrote: On Wed, Mar 15, 2023 at 5:17 PM Philippe Mathieu-Daudé wrote: +Jan On 22/2/23 15:37, Paolo Bonzini wrote: From: John Snow The pipenv tool was nice in theory, but in practice it's just too hard to update selectively, and it makes using it a pain. The qemu.

Re: [PATCH for 8.0] exec/memory: Fix kernel-doc warning

On 15.03.23 08:25, Bernhard Beschow wrote: During build the kernel-doc script complains about the following issue: src/docs/../include/exec/memory.h:1741: warning: Function parameter or member 'n' not described in 'memory_region_unmap_iommu_notifier_range' src/docs/../include/exec/memory.

Re: dropping 32-bit host support

чт, 16 мар. 2023 г., 11:31 Thomas Huth : > On 16/03/2023 08.36, Philippe Mathieu-Daudé wrote: > > On 16/3/23 08:17, Andrew Randrianasulu wrote: > >> > >> чт, 16 мар. 2023 г., 10:05 Philippe Mathieu-Daudé >> >: > >> > >> Hi Andrew, > >> > >> On 16/3/23 01:57, Andr

Re: [PULL 0/3] Misc next patches

On Tue, 14 Mar 2023 at 16:26, Daniel P. Berrangé wrote: > > The following changes since commit 5cfda4ce79dd455f1726874a555260a70f84b2ec: > > Merge tag 'pull-request-2023-03-13' of https://gitlab.com/thuth/qemu into > staging (2023-03-13 17:09:33 +) > > are available in the Git repository at

Re: [PULL v2 0/4] Misc fixes for 2023-03-15

On Wed, 15 Mar 2023 at 10:57, Paolo Bonzini wrote: > > The following changes since commit 652737c8090eb3792f8b4c4b22ab12d7cc32073f: > > Update version for v8.0.0-rc0 release (2023-03-14 19:25:05 +) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git tags/for

Re: [RFC 1/2] block: Split padded I/O vectors exceeding IOV_MAX

On 15.03.23 19:25, Eric Blake wrote: On Wed, Mar 15, 2023 at 01:13:29PM +0100, Hanna Czenczek wrote: When processing vectored guest requests that are not aligned to the storage request alignment, we pad them by adding head and/or tail buffers for a read-modify-write cycle. The guest can submit

[PATCH 4/6] edk2: update submodule to edk2-stable202302

Signed-off-by: Gerd Hoffmann --- pc-bios/README | 4 ++-- roms/edk2 | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pc-bios/README b/pc-bios/README index 3702ed485c63..c555dd324ea1 100644 --- a/pc-bios/README +++ b/pc-bios/README @@ -50,8 +50,8 @@ variable store tem

[PATCH 1/6] acpi: enable tests/data/acpi updates

Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8bf4..b5ed0904b5ff 100644 --- a/tests/qtest/bios-tables-test-al

[PATCH 5/6] edk2: replace build scripts

Remove Makefile.edk2 and the edk2*.sh scripts and replace them with a python script (which already handles fedora rpm builds) and a config file for it. Signed-off-by: Gerd Hoffmann --- roms/edk2-build.py | 380 + roms/Makefile | 29 +--- roms

[PATCH 0/6] edk2: update to 2023-02 stable tag

Turned out to be a bit more complicated than just "update submodule + binaries, done". One acpi test case needs a fix to not use too small numa nodes. So posting this as patch series for review first. The patch updating the binaries will probably not make it to to the list. So for testing the t

[PATCH 2/6] bios-tables-test: use 128M numa nodes on aarch64

Recent edk2 versions don't boot with very small numa nodes. Bump the size from 64M to 128M. Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test.c | 6 +++--- tests/data/acpi/virt/SRAT.acpihmatvirt | Bin 240 -> 240 bytes tests/data/acpi/virt/SSDT.memhp| Bin 1817 -> 18

[PATCH 3/6] acpi: disable tests/data/acpi updates

Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index b5ed0904b5ff..dfb8523c8bf4 100644 --- a/tests/qtest/bios-tables-test-all

Re: [PATCH] migration/rdma: Remove deprecated variable rdma_return_path

"lizhij...@fujitsu.com" wrote: > Not clear why it doesn't appear in the > archive(https://lists.gnu.org/archive/html/qemu-devel/2023-03/threads.html) No clue either. > nop... > > > On 15/03/2023 09:22, Li Zhijian wrote: >> It's no longer needed since commit >> 44bcfd45e98 ("migration/rdma:

Re: dropping 32-bit host support

Thomas Huth writes: [...] > The problem is really that we don't have unlimited resources in the > QEMU project. Currently we're heavily struggling with the load in the > CI, but also pure man power is always very scarce. So at one point in > time, you have to decide to say good bye to some old a

Re: [PATCH] migration/rdma: Fix return-path case

"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The RDMA code has return-path handling code, but it's only enabled > if postcopy is enabled; if the 'return-path' migration capability > is enabled, the return path is NOT setup but the core migration > code still tries to

Re: dropping 32-bit host support

чт, 16 мар. 2023 г., 13:01 Markus Armbruster : > Thomas Huth writes: > > [...] > > > The problem is really that we don't have unlimited resources in the > > QEMU project. Currently we're heavily struggling with the load in the > > CI, but also pure man power is always very scarce. So at one point

Re: [RFC 1/2] block: Split padded I/O vectors exceeding IOV_MAX

On 15.03.23 19:48, Stefan Hajnoczi wrote: On Wed, Mar 15, 2023 at 01:13:29PM +0100, Hanna Czenczek wrote: When processing vectored guest requests that are not aligned to the storage request alignment, we pad them by adding head and/or tail buffers for a read-modify-write cycle. The guest can su

Re: [PATCH v4] target/arm: Add Neoverse-N1 registers

On Mon, 13 Mar 2023 at 03:39, Chen Baozi wrote: > > Add implementation defined registers for neoverse-n1 which > would be accessed by TF-A. Since there is no DSU in Qemu, > CPUCFR_EL1.SCU bit is set to 1 to avoid DSU registers definition. > > Signed-off-by: Chen Baozi > --- > target/arm/cpu64.c

Re: dropping 32-bit host support

чт, 16 мар. 2023 г., 12:17 Andrew Randrianasulu : > > > чт, 16 мар. 2023 г., 11:31 Thomas Huth : > >> On 16/03/2023 08.36, Philippe Mathieu-Daudé wrote: >> > On 16/3/23 08:17, Andrew Randrianasulu wrote: >> >> >> >> чт, 16 мар. 2023 г., 10:05 Philippe Mathieu-Daudé > >> >

Re: [PATCH v3 12/12] tests/tcg/s390x: Test unaligned accesses

On 16/03/2023 00.26, Ilya Leoshkevich wrote: Add a number of small test that check whether accessing unaligned addresses in various ways leads to a specification exception. Run these test both in softmmu and user configurations; expect a PGM in one case and SIGILL in the other. Signed-off-by: I

[PULL 0/2] Seabios 1.16.2 20230316 patches

The following changes since commit 652737c8090eb3792f8b4c4b22ab12d7cc32073f: Update version for v8.0.0-rc0 release (2023-03-14 19:25:05 +) are available in the Git repository at: https://gitlab.com/kraxel/qemu.git tags/seabios-1.16.2-20230316-pull-request for you to fetch changes up to

[PULL 1/2] update seabios submodule to 1.16.2

git shortlog rel-1.16.1..rel-1.16.2 --- David Woodhouse (1): xen: require Xen info structure at 0x1000 to detect Xen Qi Zhou (1): usb: fix wrong init of keyboard/mouse's if first interface is not boot protocol Signed-off-by: Gerd Hoffmann --- roms/s

Re: [PATCH v7 5/6] migration: Reduce time of loading non-iterable vmstate

Chuang Xu wrote: > The duration of loading non-iterable vmstate accounts for a significant > portion of downtime (starting with the timestamp of source qemu stop and > ending with the timestamp of target qemu start). Most of the time is spent > committing memory region changes repeatedly. > > This

Re: [PATCH 4/6] edk2: update submodule to edk2-stable202302

On 16/3/23 10:54, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- pc-bios/README | 4 ++-- roms/edk2 | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 02/10] python: drop pipenv

On 3/16/23 09:54, Philippe Mathieu-Daudé wrote: On 16/3/23 00:02, John Snow wrote: On Wed, Mar 15, 2023 at 5:17 PM Philippe Mathieu-Daudé wrote: +Jan On 22/2/23 15:37, Paolo Bonzini wrote: From: John Snow The pipenv tool was nice in theory, but in practice it's just too hard to update

Re: dropping 32-bit host support

On 16/3/23 11:22, Andrew Randrianasulu wrote: чт, 16 мар. 2023 г., 12:17 Andrew Randrianasulu >: чт, 16 мар. 2023 г., 11:31 Thomas Huth mailto:th...@redhat.com>>: On 16/03/2023 08.36, Philippe Mathieu-Daudé wrote: > On 16/3/23 08:17, Andrew Ran

[PATCH for-8.0] docs/system/arm/cpu-features.rst: Fix formatting

The markup for the Arm CPU feature documentation is incorrect, and results in the HTML not rendering correctly -- the first line of each description is rendered in boldface as if it were part of the option name. Reformat to match the styling used in cpu-models-x86.rst.inc. Resolves: https://gitla

Re: dropping 32-bit host support

On 16/03/2023 11.22, Andrew Randrianasulu wrote: чт, 16 мар. 2023 г., 12:17 Andrew Randrianasulu >: чт, 16 мар. 2023 г., 11:31 Thomas Huth mailto:th...@redhat.com>>: On 16/03/2023 08.36, Philippe Mathieu-Daudé wrote: > On 16/3/23 08:17,

Re: dropping 32-bit host support

чт, 16 мар. 2023 г., 13:56 Philippe Mathieu-Daudé : > On 16/3/23 11:22, Andrew Randrianasulu wrote: > > чт, 16 мар. 2023 г., 12:17 Andrew Randrianasulu > >: > > чт, 16 мар. 2023 г., 11:31 Thomas Huth > >: > > On 16/03/2023

Re: [PATCH v5 04/16] hw/9pfs: Implement Windows specific xxxdir() APIs

On Wednesday, March 15, 2023 8:05:34 PM CET Shi, Guohuai wrote: > > > -Original Message- > > From: Christian Schoenebeck > > Sent: Wednesday, March 15, 2023 00:06 > > To: Greg Kurz ; qemu-devel@nongnu.org > > Cc: Shi, Guohuai ; Meng, Bin > > > > Subject: Re: [PATCH v5 04/16] hw/9pfs: Imp

Re: dropping 32-bit host support

чт, 16 мар. 2023 г., 14:02 Thomas Huth : > On 16/03/2023 11.22, Andrew Randrianasulu wrote: > > > > > > чт, 16 мар. 2023 г., 12:17 Andrew Randrianasulu > >: > > > > > > > > чт, 16 мар. 2023 г., 11:31 Thomas Huth > >: > > > >

Re: [PATCH for-8.0] docs/system/arm/cpu-features.rst: Fix formatting

On Thu, Mar 16 2023, Peter Maydell wrote: > The markup for the Arm CPU feature documentation is incorrect, > and results in the HTML not rendering correctly -- the first > line of each description is rendered in boldface as if it > were part of the option name. > > Reformat to match the styling u

Re: dropping 32-bit host support

On 16/03/2023 12.04, Andrew Randrianasulu wrote: Also, for CI thing may be lessen compiler optimization levels at least for some runs? And/or tweak ccache compression Please stop blindly making suggestions for our CI if you don't really know it (e.g. we don't use ccache). That's really n

Re: [PATCH for-8.0] docs/system/arm/cpu-features.rst: Fix formatting

On Thu, 16 Mar 2023 at 11:11, Cornelia Huck wrote: > > On Thu, Mar 16 2023, Peter Maydell wrote: > > > The markup for the Arm CPU feature documentation is incorrect, > > and results in the HTML not rendering correctly -- the first > > line of each description is rendered in boldface as if it > >

[PATCH v2 0/6] Implement virtio-multitouch and enable GTK3 to use it

This series adds a virtio-multitouch device to the family of devices emulated by virtio-input implementing the Multi-touch protocol as descripted here: https://www.kernel.org/doc/html/latest/input/multi-touch-protocol.html?highlight=multi+touch It also extends the GTK UI backend to be able to rec

[PATCH v2 5/6] ui: add helpers for virtio-multitouch events

Add helpers for generating Multi-touch events from the UI backends that can be sent to the guest through a virtio-multitouch device. Signed-off-by: Sergio Lopez Reviewed-by: Marc-André Lureau --- include/ui/input.h | 5 + ui/input.c | 36 2 file

[PATCH v2 3/6] virtio-input: add a virtio-mulitouch device

Add a virtio-multitouch device to the family of devices emulated by virtio-input implementing the Multi-touch protocol as descripted here: https://www.kernel.org/doc/html/latest/input/multi-touch-protocol.html?highlight=multi+touch This patch just add the device itself, without connecting it to a

[PATCH v2 4/6] virtio-input-pci: add virtio-multitouch-pci

Add virtio-multitouch-pci, a Multitouch-capable input device, to the list of devices that can be provided by virtio-input-pci. Signed-off-by: Sergio Lopez --- hw/virtio/virtio-input-pci.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/hw/virtio/vir

[PATCH v2 2/6] ui: add the infrastructure to support MT events

Add the required infrastructure to support generating multitouch events. Signed-off-by: Sergio Lopez --- include/ui/input.h| 3 +++ qapi/ui.json | 45 --- replay/replay-input.c | 18 + ui/input.c| 6 ++ ui/tra

[PATCH v2 6/6] ui/gtk: enable backend to send multi-touch events

GTK3 provides the infrastructure to receive and process multi-touch events through the "touch-event" signal and the GdkEventTouch type. Make use of it to transpose events from the host to the guest. This allows users of machines with hardware capable of receiving multi-touch events to run guests t

[PATCH v2 1/6] virtio-input: generalize virtio_input_key_config()

As there are other bitmap-based config properties that need to be dealt in a similar fashion as VIRTIO_INPUT_CFG_EV_BITS, generalize the function to receive select and subsel as arguments, and rename it to virtio_input_extend_config() Signed-off-by: Sergio Lopez Reviewed-by: Marc-André Lureau --

Re: [PATCH] docs/sphinx/kerneldoc.py: Honour --enable-werror

On 14/03/2023 12.44, Peter Maydell wrote: Currently, the kerneldoc Sphinx plugin doesn't honour the --enable-werror configure option, so its warnings are never fatal. This is because although we do pass sphinx-build the -W switch, the warnings from kerneldoc are produced by the scripts/kernel-doc

Re: [PATCH 4/4] ui/gtk: enable backend to send multi-touch events

On Sun, Feb 19, 2023 at 12:28:22PM +0400, Marc-André Lureau wrote: > Hi Sergio > > On Sat, Feb 18, 2023 at 8:23 PM Sergio Lopez wrote: > > > > GTK3 provides the infrastructure to receive and process multi-touch > > events through the "touch-event" signal and the GdkEventTouch type. > > Make use o

[PATCH for 8.0] memory: Prevent recursive memory access

A guest may request ask a memory-mapped device to perform DMA. If the address specified for DMA is the device performing DMA, it will create recursion. It is very unlikely that device implementations are prepared for such an abnormal access, which can result in unpredictable behavior. In particula

[PATCH for 8.0 v2] memory: Prevent recursive memory access

A guest may request ask a memory-mapped device to perform DMA. If the address specified for DMA is the device performing DMA, it will create recursion. It is very unlikely that device implementations are prepared for such an abnormal access, which can result in unpredictable behavior. In particula

[PATCH for 8.0] hw/net/net_tx_pkt: Align l3_hdr

Align the l3_hdr member of NetTxPkt by defining it as a union of ip_header, ip6_header, and an array of octets. Fixes: e263cd49c7 ("Packet abstraction for VMWARE network devices") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1544 Signed-off-by: Akihiko Odaki --- hw/net/net_tx_pkt.c |

[PATCH for 8.0] hw/net/net_tx_pkt: Ignore ECN bit

No segmentation should be performed if gso type is VIRTIO_NET_HDR_GSO_NONE even if ECN bit is set. Fixes: e263cd49c7 ("Packet abstraction for VMWARE network devices") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1544 Signed-off-by: Akihiko Odaki --- hw/net/net_tx_pkt.c | 6 -- 1 f

[PATCH for 8.0] igb: Save the entire Tx context descriptor

The current implementation of igb uses only part of a advanced Tx context descriptor because it misses some features and sniffs the trait of the packet instead of respecting the packet type specified in the descriptor. However, we will certainly need the entire Tx context descriptor when we update

[PATCH for 8.0] igb: Fix DMA requester specification for Tx packet

igb used to specify the PF as DMA requester when reading Tx packets. This made Tx requests from VFs to be performed on the address space of the PF, defeating the purpose of SR-IOV. Add some logic to change the requester depending on the queue, which can be assigned to a VF. Fixes: 3a977deebe ("Int

Re: [PATCH v3 2/3] qapi: Do not generate empty enum

Philippe Mathieu-Daudé writes: > Per the C++ standard, empty enum are ill-formed. Do not generate > them in order to avoid: > > In file included from qga/qga-qapi-emit-events.c:14: > qga/qga-qapi-emit-events.h:20:1: error: empty enum is invalid > 20 | } qga_QAPIEvent; > | ^ > > R

Re: dropping 32-bit host support

On Thu, Mar 16, 2023 at 02:11:08PM +0300, Andrew Randrianasulu wrote: > чт, 16 мар. 2023 г., 14:02 Thomas Huth : > > > On 16/03/2023 11.22, Andrew Randrianasulu wrote: > > > > > > > > > чт, 16 мар. 2023 г., 12:17 Andrew Randrianasulu > > >: > > > > > > > > > > > >

Re: [PATCH for 8.0] igb: Save the entire Tx context descriptor

On 16/3/23 13:28, Akihiko Odaki wrote: The current implementation of igb uses only part of a advanced Tx context descriptor because it misses some features and sniffs the trait of the packet instead of respecting the packet type specified in the descriptor. However, we will certainly need the ent

Re: [PATCH for 8.0] igb: Save the entire Tx context descriptor

On 2023/03/16 21:36, Philippe Mathieu-Daudé wrote: On 16/3/23 13:28, Akihiko Odaki wrote: The current implementation of igb uses only part of a advanced Tx context descriptor because it misses some features and sniffs the trait of the packet instead of respecting the packet type specified in the

[PATCH v2] hw/net/can: Add mcp25625 model

From: Ben Dooks Add support for Microchip MCP25625 SPI based CAN controller which is very similar to the MCP2515 (and covered by the same Linux driver). This can be added to any machine with SPI support in the machine model file. Example for using this when configured into a machine: -

Re: [PATCH for 8.0] igb: Save the entire Tx context descriptor

On 16/3/23 13:40, Akihiko Odaki wrote: On 2023/03/16 21:36, Philippe Mathieu-Daudé wrote: On 16/3/23 13:28, Akihiko Odaki wrote: The current implementation of igb uses only part of a advanced Tx context descriptor because it misses some features and sniffs the trait of the packet instead of res

Re: [PATCH for 8.0 v2] memory: Prevent recursive memory access

On 3/16/23 13:24, Akihiko Odaki wrote: +static const Object **accessed_region_owners; +static size_t accessed_region_owners_capacity; +static size_t accessed_region_owners_num; + These should be thread-local variables at least, because the memory access API is thread-safe. Paolo

Re: dropping 32-bit host support

чт, 16 мар. 2023 г., 15:35 Daniel P. Berrangé : > On Thu, Mar 16, 2023 at 02:11:08PM +0300, Andrew Randrianasulu wrote: > > чт, 16 мар. 2023 г., 14:02 Thomas Huth : > > > > > On 16/03/2023 11.22, Andrew Randrianasulu wrote: > > > > > > > > > > > > чт, 16 мар. 2023 г., 12:17 Andrew Randrianasulu <

seabios 1.16.2 release tagged (was: Re: [SeaBIOS] Re: [SeaBIOS PATCH] xen: require Xen info structure at). 0x1000 to detect Xen

Hi, > Ok, we have as of today two changes: > > kraxel@sirius ~/projects/seabios (master)# git log --oneline rel-1.16.1.. > ea1b7a073390 xen: require Xen info structure at 0x1000 to detect Xen > 645a64b4911d usb: fix wrong init of keyboard/mouse's if first interface is > not boot protocol

Re: dropping 32-bit host support

On 16/03/2023 14.01, Andrew Randrianasulu wrote: ... Well, this language about "market" and "investment"  not just figures of the speech, sadly? Because paid developers work on  areas they paid to develop, by boss with big bucks. Sorry for getting more explicit now, but: Can you please stop ma

Re: [PATCH] docs/sphinx/kerneldoc.py: Honour --enable-werror

Le 14/03/2023 à 12:44, Peter Maydell a écrit : Currently, the kerneldoc Sphinx plugin doesn't honour the --enable-werror configure option, so its warnings are never fatal. This is because although we do pass sphinx-build the -W switch, the warnings from kerneldoc are produced by the scripts/kerne

Re: [PATCH v3 1/5] hw/usb: Add basic i.MX USB Phy support

On Fri, 13 Mar 2020 at 01:45, Guenter Roeck wrote: > > Add basic USB PHY support as implemented in i.MX23, i.MX28, i.MX6, > and i.MX7 SoCs. > > The only support really needed - at least to boot Linux - is support > for soft reset, which needs to reset various registers to their initial > value. Ot

Re: [PATCH] docs/sphinx/kerneldoc.py: Honour --enable-werror

On Thu, 16 Mar 2023 at 13:40, Laurent Vivier wrote: > > Le 14/03/2023 à 12:44, Peter Maydell a écrit : > > Currently, the kerneldoc Sphinx plugin doesn't honour the > > --enable-werror configure option, so its warnings are never fatal. > > This is because although we do pass sphinx-build the -W sw

Re: [PATCH v3 2/3] qapi: Do not generate empty enum

On Thu, Mar 16, 2023 at 01:31:04PM +0100, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > > > Per the C++ standard, empty enum are ill-formed. Do not generate > > them in order to avoid: > > > > In file included from qga/qga-qapi-emit-events.c:14: > > qga/qga-qapi-emit-events.h:20

Re: [PATCH v3 1/5] hw/usb: Add basic i.MX USB Phy support

Hi Peter, On 3/16/23 06:41, Peter Maydell wrote: On Fri, 13 Mar 2020 at 01:45, Guenter Roeck wrote: Add basic USB PHY support as implemented in i.MX23, i.MX28, i.MX6, and i.MX7 SoCs. The only support really needed - at least to boot Linux - is support for soft reset, which needs to reset var

Re: [PATCH v2 2/2] linux-user/m68k: Handle EXCP_ADDRESS in cpu_loop

On 3/15/23 11:16, Laurent Vivier wrote: I've tested tests/tcg/m68k/excp-address.c on a real hardware (Q800), and the result differs from the one from QEMU: On Q800 (etch m68k, kernel 5.14.0): $ ./excp-address Illegal instruction $ strace ./excp-address ... rt_sigaction(SIGBUS, {0x8478, [],

  1   2   3   >