[PATCH for 8.0] exec/memory: Fix kernel-doc warning

2023-03-15 Thread Bernhard Beschow
During build the kernel-doc script complains about the following issue: src/docs/../include/exec/memory.h:1741: warning: Function parameter or member 'n' not described in 'memory_region_unmap_iommu_notifier_range' src/docs/../include/exec/memory.h:1741: warning: Excess function parameter 'no

Re: [PATCH] Use f-strings in python scripts

2023-03-15 Thread Philippe Mathieu-Daudé
Hi Marco, (+Python experts) On 13/3/23 18:25, Marco Liebel wrote: Replace python 2 format string with f-strings Signed-off-by: Marco Liebel --- target/hexagon/gen_helper_funcs.py | 54 ++-- target/hexagon/gen_helper_protos.py | 10 +- target/hexagon/gen_idef_parser_funcs.py |

Re: [PATCH v2] Use f-strings in python scripts

2023-03-15 Thread Philippe Mathieu-Daudé
On 14/3/23 22:24, Marco Liebel wrote: Replace python 2 format string with f-strings Signed-off-by: Marco Liebel --- target/hexagon/gen_analyze_funcs.py | 115 - target/hexagon/gen_helper_funcs.py | 54 ++-- target/hexagon/gen_helper_protos.py | 10 +- target/hexagon/

Re: [PATCH] tests/tcg/xtensa: add linker.ld to CLEANFILES

2023-03-15 Thread Philippe Mathieu-Daudé
On 14/3/23 23:08, Max Filippov wrote: Linker script for xtensa tests must be preprocessed for a specific target, remove it as a part of make clean. Fixes: be5cac175a ("tests/tcg/xtensa: enable system tests") Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Max Filippov --- tests/tcg/xt

Re: [PATCH for 8.0] exec/memory: Fix kernel-doc warning

2023-03-15 Thread Philippe Mathieu-Daudé
On 15/3/23 08:25, Bernhard Beschow wrote: During build the kernel-doc script complains about the following issue: src/docs/../include/exec/memory.h:1741: warning: Function parameter or member 'n' not described in 'memory_region_unmap_iommu_notifier_range' src/docs/../include/exec/memory.h

Re: [PATCH for 8.0] exec/memory: Fix kernel-doc warning

2023-03-15 Thread Bernhard Beschow
+ qemu-trivial Am 15. März 2023 07:25:52 UTC schrieb Bernhard Beschow : >During build the kernel-doc script complains about the following issue: > > src/docs/../include/exec/memory.h:1741: warning: Function parameter or > member 'n' not described in 'memory_region_unmap_iommu_notifier_range' >

Re: [PATCH] linux-user/mips: Low down switchable NaN2008 requirement

2023-03-15 Thread Philippe Mathieu-Daudé
On 11/3/23 13:39, Jiaxun Yang wrote: 2023年3月9日 12:32,Philippe Mathieu-Daudé 写道: Hi Jiaxun, On 11/2/23 18:34, Jiaxun Yang wrote: Previously switchable NaN2008 requires fcsr31.nan2008 to be writable for guest. However as per MIPS arch spec this bit can never be writable. This cause NaN2008 E

Re: [PATCH for-8.0] hw/char/cadence_uart: Fix guards on invalid BRGR/BDIV settings

2023-03-15 Thread Philippe Mathieu-Daudé
On 14/3/23 18:08, Peter Maydell wrote: The cadence UART attempts to avoid allowing the guset to set invalid baud rate register values in the uart_write() function. However it does the "mask to the size of the register field" and "check for invalid values" in the wrong order, which means that a m

Re: [PATCH v2] vl: defuse PID file path resolve error

2023-03-15 Thread Fiona Ebner
Am 24.01.23 um 14:55 schrieb Fiona Ebner: > Am 31.10.22 um 10:47 schrieb Fiona Ebner: >> Commit 85c4bf8aa6 ("vl: Unlink absolute PID file path") introduced a >> critical error when the PID file path cannot be resolved. Before this >> commit, it was possible to invoke QEMU when the PID file was a fi

Re: [PATCH v2 1/3] target/s390x: Fix LPSW

2023-03-15 Thread David Hildenbrand
On 15.03.23 03:04, Ilya Leoshkevich wrote: Currently LPSW does not invert the mask bit 12 and incorrectly copies the BA bit into the address. Fix by generating code similar to what s390_cpu_load_normal() does. Reported-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Signe

Re: [PATCH v2 2/3] target/s390x: Implement Early Exception Recognition

2023-03-15 Thread David Hildenbrand
On 15.03.23 03:04, Ilya Leoshkevich wrote: Generate a specification exception if a reserved bit is set in the PSW mask or if the PSW address is out of bounds dictated by the addressing mode. Reported-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich --- Make sure to not drop Acks/R

Re: [PATCH v2 1/2] target/s390x: Fix EXECUTE of relative long instructions

2023-03-15 Thread David Hildenbrand
On 15.03.23 01:11, Ilya Leoshkevich wrote: The code uses the wrong base for relative addressing: it should use the target instruction address and not the EXECUTE's address. Fix by storing the target instruction address in the new CPUS390XState member and loading it from the code generated by gen

Re: [PATCH 1/2] target/s390x: Fix R[NOX]SBG with T=1

2023-03-15 Thread David Hildenbrand
On 15.03.23 00:34, Ilya Leoshkevich wrote: RXSBG usage in the "filetests" test from the wasmtime testsuite makes tcg_reg_alloc_op() attempt to temp_load() a TEMP_VAL_DEAD temporary, causing an assertion failure: 0x01000a70: ec14 b040 3057 rxsbg%r1, %r4, 0xb0, 0x40, 0x30 OP after

Re: [PATCH for-8.0] hw/char/cadence_uart: Fix guards on invalid BRGR/BDIV settings

2023-03-15 Thread Qiang Liu
On 3/14/23 6:08 PM, Peter Maydell wrote: The cadence UART attempts to avoid allowing the guset to set invalid baud rate register values in the uart_write() function. However it does the "mask to the size of the register field" and "check for invalid values" in the wrong order, which means that

Re: [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests

2023-03-15 Thread Luis Machado
Hi, On 3/13/23 11:44, Luis Machado wrote: On 3/13/23 11:22, Peter Maydell via Gdb wrote: On Fri, 10 Mar 2023 at 18:20, Alex Bennée wrote: (adding some more gdb types to CC) Fabiano Rosas writes: Peter Maydell writes: On Fri, 10 Mar 2023 at 10:31, Alex Bennée wrote: You need a very

Re: [PATCH 2/2] qapi: Generate enum count as definition in gen_enum_lookup()

2023-03-15 Thread Philippe Mathieu-Daudé
On 27/2/23 14:10, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: QAPI's gen_enum() generates QAPI enum values and the number of this values (as foo__MAX). The number of entries in an enum type is not part of the enumerated values, but we generate it as such. See for example: typed

Re: [PATCH v2] vl: defuse PID file path resolve error

2023-03-15 Thread Paolo Bonzini
Queued, thanks. Paolo

[PULL 4/4] vl: defuse PID file path resolve error

2023-03-15 Thread Paolo Bonzini
From: Fiona Ebner Commit 85c4bf8aa6 ("vl: Unlink absolute PID file path") introduced a critical error when the PID file path cannot be resolved. Before this commit, it was possible to invoke QEMU when the PID file was a file created with mkstemp that was already unlinked at the time of the invoca

[PULL 3/4] hw/intc/ioapic: Update KVM routes before redelivering IRQ, on RTE update

2023-03-15 Thread Paolo Bonzini
From: David Woodhouse A Linux guest will perform IRQ migration after the IRQ has happened, updating the RTE to point to the new destination CPU and then unmasking the interrupt. However, when the guest updates the RTE, ioapic_mem_write() calls ioapic_service(), which redelivers the pending level

[PULL 0/4] Misc fixes for 2023-03-15

2023-03-15 Thread Paolo Bonzini
The following changes since commit 652737c8090eb3792f8b4c4b22ab12d7cc32073f: Update version for v8.0.0-rc0 release (2023-03-14 19:25:05 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to 7be89e077d20eb81aae79a0

[PULL 1/4] Fix build without CONFIG_XEN_EMU

2023-03-15 Thread Paolo Bonzini
From: Miroslav Rezanina Upstream commit ddf0fd9ae1 "hw/xen: Support HVM_PARAM_CALLBACK_TYPE_GSI callback" added kvm_xen_maybe_deassert_callback usage to target/i386/kvm/kvm.c file without conditional preprocessing check. This breaks any build not using CONFIG_XEN_EMU. Protect call by condition

[PULL 2/4] docs/devel: clarify further the semantics of RMW operations

2023-03-15 Thread Paolo Bonzini
--- docs/devel/atomics.rst | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/docs/devel/atomics.rst b/docs/devel/atomics.rst index 633df65a97bc..81ec26be1771 100644 --- a/docs/devel/atomics.rst +++ b/docs/devel/atomics.rst @@ -469,13 +469,19 @@ and memory barr

[PULL v2 0/4] Misc fixes for 2023-03-15

2023-03-15 Thread Paolo Bonzini
The following changes since commit 652737c8090eb3792f8b4c4b22ab12d7cc32073f: Update version for v8.0.0-rc0 release (2023-03-14 19:25:05 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to dee2a4d4d2f6adc3c664e37

Re: [PULL 1/4] Fix build without CONFIG_XEN_EMU

2023-03-15 Thread Philippe Mathieu-Daudé
On 15/3/23 11:51, Paolo Bonzini wrote: From: Miroslav Rezanina Upstream commit ddf0fd9ae1 "hw/xen: Support HVM_PARAM_CALLBACK_TYPE_GSI callback" added kvm_xen_maybe_deassert_callback usage to target/i386/kvm/kvm.c file without conditional preprocessing check. This breaks any build not using C

[PATCH v2 0/3] qapi: Simplify enum generation

2023-03-15 Thread Philippe Mathieu-Daudé
QAPI generating enum count as part of the enum forces handling impossible switch cases. Modify qapi/types.py to generate the enum count as a definition. Do not try to cover the unreachable 'default' case. Clean files covering unreachable foo__MAX case. Since v1: - Update documentation (Markus) - D

[PATCH v2 2/3] qapi: Do not generate empty enum

2023-03-15 Thread Philippe Mathieu-Daudé
Per the C++ standard, empty enum are ill-formed. Do not generate them in order to avoid: In file included from qga/qga-qapi-emit-events.c:14: qga/qga-qapi-emit-events.h:20:1: error: empty enum is invalid 20 | } qga_QAPIEvent; | ^ Reported-by: Markus Armbruster Signed-off-by: Phi

[PATCH v2 3/3] qapi: Generate enum count as definition

2023-03-15 Thread Philippe Mathieu-Daudé
QAPI's gen_enum() generates QAPI enum values and the number of this values (as foo__MAX). The number of entries in an enum type is not part of the enumerated values, but we generate it as such. See for example: typedef enum OnOffAuto { ON_OFF_AUTO_AUTO, ON_OFF_AUTO_ON, ON_OFF_A

[PATCH v2 1/3] scripts/git.orderfile: Display QAPI script changes before schema ones

2023-03-15 Thread Philippe Mathieu-Daudé
When modifying QAPI scripts and modifying C files along, it makes sense to display QAPI changes first. Signed-off-by: Philippe Mathieu-Daudé --- scripts/git.orderfile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/git.orderfile b/scripts/git.orderfile index 8edac0380b..70adc1a74a

Re: [PATCH] Use f-strings in python scripts

2023-03-15 Thread Daniel P . Berrangé
On Wed, Mar 15, 2023 at 08:43:33AM +0100, Philippe Mathieu-Daudé wrote: > Hi Marco, > > (+Python experts) > > On 13/3/23 18:25, Marco Liebel wrote: > > Replace python 2 format string with f-strings > > > > Signed-off-by: Marco Liebel > > --- > > target/hexagon/gen_helper_funcs.py | 54 +

Re: [PATCH v2 0/3] qapi: Simplify enum generation

2023-03-15 Thread Philippe Mathieu-Daudé
On 15/3/23 12:13, Philippe Mathieu-Daudé wrote: QAPI generating enum count as part of the enum forces handling impossible switch cases. Modify qapi/types.py to generate the enum count as a definition. Do not try to cover the unreachable 'default' case. Clean files covering unreachable foo__MAX ca

[PATCH v3 2/3] qapi: Do not generate empty enum

2023-03-15 Thread Philippe Mathieu-Daudé
Per the C++ standard, empty enum are ill-formed. Do not generate them in order to avoid: In file included from qga/qga-qapi-emit-events.c:14: qga/qga-qapi-emit-events.h:20:1: error: empty enum is invalid 20 | } qga_QAPIEvent; | ^ Reported-by: Markus Armbruster Signed-off-by: Phi

[PATCH v3 0/3] qapi: Simplify enum generation

2023-03-15 Thread Philippe Mathieu-Daudé
QAPI generating enum count as part of the enum forces handling impossible switch cases. Modify qapi/types.py to generate the enum count as a definition. Do not try to cover the unreachable 'default' case. Clean files covering unreachable foo__MAX case. Since v2: - Post correct branch generating em

[PATCH v3 1/3] scripts/git.orderfile: Display QAPI script changes before schema ones

2023-03-15 Thread Philippe Mathieu-Daudé
When modifying QAPI scripts and modifying C files along, it makes sense to display QAPI changes first. Signed-off-by: Philippe Mathieu-Daudé --- scripts/git.orderfile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/git.orderfile b/scripts/git.orderfile index 8edac0380b..70adc1a74a

[PATCH v3 3/3] qapi: Generate enum count as definition

2023-03-15 Thread Philippe Mathieu-Daudé
QAPI's gen_enum() generates QAPI enum values and the number of this values (as foo__MAX). The number of entries in an enum type is not part of the enumerated values, but we generate it as such. See for example: typedef enum OnOffAuto { ON_OFF_AUTO_AUTO, ON_OFF_AUTO_ON, ON_OFF_A

[RFC 0/2] Split padded I/O vectors exceeding IOV_MAX

2023-03-15 Thread Hanna Czenczek
Hi, We accept I/O vectors with up to 1024 (IOV_MAX) elements from guests. When a guest request does not conform to the underlying storage's alignment requirements, we pad it with head and/or tail buffers as necessary, which are simply appended to the I/O vector. As of 4c002cef, we (sensibly) chec

Re: [PATCH] Use f-strings in python scripts

2023-03-15 Thread Philippe Mathieu-Daudé
On 15/3/23 12:16, Daniel P. Berrangé wrote: On Wed, Mar 15, 2023 at 08:43:33AM +0100, Philippe Mathieu-Daudé wrote: Hi Marco, (+Python experts) On 13/3/23 18:25, Marco Liebel wrote: Replace python 2 format string with f-strings Signed-off-by: Marco Liebel --- target/hexagon/gen_helper_fu

[RFC 2/2] iotests/iov-padding: New test

2023-03-15 Thread Hanna Czenczek
Test that even vectored IO requests with 1024 vector elements that are not aligned to the device's request alignment will succeed. Signed-off-by: Hanna Czenczek --- tests/qemu-iotests/tests/iov-padding | 85 tests/qemu-iotests/tests/iov-padding.out | 59 +

[RFC 1/2] block: Split padded I/O vectors exceeding IOV_MAX

2023-03-15 Thread Hanna Czenczek
When processing vectored guest requests that are not aligned to the storage request alignment, we pad them by adding head and/or tail buffers for a read-modify-write cycle. The guest can submit I/O vectors up to IOV_MAX (1024) in length, but with this padding, the vector can exceed that limit. As

Re: [PATCH v2] Use f-strings in python scripts

2023-03-15 Thread Philippe Mathieu-Daudé
On 15/3/23 08:46, Philippe Mathieu-Daudé wrote: On 14/3/23 22:24, Marco Liebel wrote: Replace python 2 format string with f-strings Signed-off-by: Marco Liebel ---   target/hexagon/gen_analyze_funcs.py | 115 -   target/hexagon/gen_helper_funcs.py  |  54 ++--   target/hexagon/ge

Re: [PATCH 09/10] Python: Drop support for Python 3.6

2023-03-15 Thread Thomas Huth
On 13/03/2023 18.05, Daniel P. Berrangé wrote: On Wed, Feb 22, 2023 at 03:37:51PM +0100, Paolo Bonzini wrote: Python 3.6 was EOL 2021-12-31. Newer versions of upstream libraries have begun dropping support for this version and it is becoming more cumbersome to support. Avocado-framework and qemu

Re: [PATCH v6 1/4] file-posix: add tracking of the zone write pointers

2023-03-15 Thread Sam Li
Damien Le Moal 于2023年3月14日周二 11:49写道: > > On 3/14/23 11:23, Dmitry Fomichev wrote: > >> @@ -3339,10 +3473,27 @@ static int coroutine_fn > >> raw_co_zone_mgmt(BlockDriverState *bs, BlockZoneOp op, > >> len >> BDRV_SECTOR_BITS); > >> ret = raw_thread_pool_submit(bs, han

Re: [PATCH] virtio: refresh vring region cache after updating a virtqueue size

2023-03-15 Thread Cornelia Huck
On Mon, Mar 13 2023, Carlos López wrote: > On 9/3/23 11:43, Cornelia Huck wrote: >> On Thu, Mar 02 2023, Carlos López wrote: >>> Fix this by calling virtio_queue_update_rings() after >>> virtio_queue_set_num() if we are not already calling >>> virtio_queue_set_rings(). >> >> Don't we instead ne

[PATCH sr.ht-doc 0/1] converting text files to rst files

2023-03-15 Thread ~titilola
This ia a test mail, i still havent been able to figure out how to make create a project with content using sourcehut Drew DeVault (1): terms.md: correct style issues terms.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.34.7

[PATCH sr.ht-doc 1/1] terms.md: correct style issues

2023-03-15 Thread ~titilola
From: Drew DeVault Does not change the semantic or legal meaning of the terms. --- terms.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/terms.md b/terms.md index d47de99..3d51afe 100644 --- a/terms.md +++ b/terms.md @@ -85,7 +85,7 @@ When uploading content to Source

[PATCH] disas/riscv: Add support for XThead* instructions

2023-03-15 Thread Christoph Muellner
From: Christoph Müllner Support for emulating XThead* instruction has been added recently. This patch adds support for these instructions to the RISC-V disassembler. Co-developed-by: LIU Zhiwei Signed-off-by: Christoph Müllner --- disas/riscv.c | 366 ++

Re: [PATCH for-8.1 v2 16/26] target/riscv/cpu.c: split RVG code from validate_set_extensions()

2023-03-15 Thread Daniel Henrique Barboza
On 3/15/23 01:43, liweiwei wrote: On 2023/3/15 00:49, Daniel Henrique Barboza wrote: We can set all RVG related extensions during realize time, before validate_set_extensions() itself. It will also avoid re-enabling RVG via write_misa() when the CSR start to using the same validation code re

Re: [RFC 1/2] vhost-user: Add interface for virtio-fs migration

2023-03-15 Thread Stefan Hajnoczi
On Mon, Mar 13, 2023 at 06:48:32PM +0100, Hanna Czenczek wrote: > Add a virtio-fs-specific vhost-user interface to facilitate migrating > back-end-internal state. We plan to migrate the internal state simply Luckily the interface does not need to be virtiofs-specific since it only transfers opaqu

[PATCH v4 1/2] pci: avoid accessing slot_reserved_mask directly outside of pci.c

2023-03-15 Thread Chuck Zmudzinski
This patch provides accessor functions as replacements for direct access to slot_reserved_mask according to the comment at the top of include/hw/pci/pci_bus.h which advises that data structures for PCIBus should not be directly accessed but instead be accessed using accessor functions in pci.h. Th

[PATCH v4 2/2] pci: introduce slot_reserved_auto_mask and slot_reserved_manual_mask

2023-03-15 Thread Chuck Zmudzinski
Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot 2 for Intel igd-passthru") uses slot_reserved_mask to reserve slot 2 for the Intel igd for the xenfv machine when the guest is configured for igd-passthru. Prior to that commit, a single 32-bit mask was sufficient to meet the needs of the only machine

[PATCH v4 0/2] pci: slot_reserved_mask improvements

2023-03-15 Thread Chuck Zmudzinski
This patch series consists of two patches. The first provides accessor functions in pci.h to avoid direct access of slot_reserved_mask according to the comment at the top of include/hw/pci/pci_bus.h. No functional change is intended with this patch. The second patch replaces slot_reserved_mask wit

Re: [PATCH] coverity: physmem: use simple assertions instead of modelling

2023-03-15 Thread Vladimir Sementsov-Ogievskiy
On 22.02.23 18:57, Peter Maydell wrote: On Wed, 22 Feb 2023 at 14:19, Stefan Hajnoczi wrote: On Wed, 15 Feb 2023 at 15:22, Vladimir Sementsov-Ogievskiy wrote: ping [add Stefan] I'm not familiar with the Coverity models. Peter Maydell is the maintainer. We haven't run Coverity scans sin

Re: [PATCH v2 2/2] tests/tcg/s390x: Add ex-relative-long.c

2023-03-15 Thread Richard Henderson
On 3/14/23 17:11, Ilya Leoshkevich wrote: Test EXECUTE and EXECUTE RELATIVE LONG with relative long instructions as targets. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target| 1 + tests/tcg/s390x/ex-relative-long.c | 159 + 2 files changed

Re: [PATCH v2 1/2] target/s390x: Fix EXECUTE of relative long instructions

2023-03-15 Thread Richard Henderson
On 3/14/23 17:11, Ilya Leoshkevich wrote: The code uses the wrong base for relative addressing: it should use the target instruction address and not the EXECUTE's address. Fix by storing the target instruction address in the new CPUS390XState member and loading it from the code generated by gen_

[PATCH v18 05/17] s390x/cpu topology: resetting the Topology-Change-Report

2023-03-15 Thread Pierre Morel
During a subsystem reset the Topology-Change-Report is cleared by the machine. Let's ask KVM to clear the Modified Topology Change Report (MTCR) bit of the SCA in the case of a subsystem reset. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- include/hw/s390x/cpu-topology.h | 1 + targ

[PATCH v18 11/17] qapi/s390x/cpu topology: CPU_POLARIZATION_CHANGE qapi event

2023-03-15 Thread Pierre Morel
When the guest asks to change the polarization this change is forwarded to the upper layer using QAPI. The upper layer is supposed to take according decisions concerning CPU provisioning. Signed-off-by: Pierre Morel --- qapi/machine-target.json | 33 + hw/s390x/cp

[PATCH v18 16/17] tests/avocado: s390x cpu topology test dedicated CPU

2023-03-15 Thread Pierre Morel
A dedicated CPU in vertical polarization can only have a high entitlement. Let's check this. Signed-off-by: Pierre Morel --- tests/avocado/s390_topology.py | 43 +- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/tests/avocado/s390_topology.py b/test

[PATCH v18 09/17] machine: adding s390 topology to query-cpu-fast

2023-03-15 Thread Pierre Morel
S390x provides two more topology attributes, entitlement and dedication. Let's add these CPU attributes to the QAPI command query-cpu-fast. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth --- qapi/machine.json | 9 - hw/core/machine-q

[PATCH v18 01/17] s390x/cpu topology: add s390 specifics to CPU topology

2023-03-15 Thread Pierre Morel
S390 adds two new SMP levels, drawers and books to the CPU topology. The S390 CPU have specific topology features like dedication and entitlement to give to the guest indications on the host vCPUs scheduling and help the guest take the best decisions on the scheduling of threads on the vCPUs. Let

[PATCH v18 04/17] s390x/sclp: reporting the maximum nested topology entries

2023-03-15 Thread Pierre Morel
The maximum nested topology entries is used by the guest to know how many nested topology are available on the machine. Let change the MNEST value from 2 to 4 in the SCLP READ INFO structure now that we support books and drawers. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch

[PATCH 4/5] fsl-imx7: Add fec[12]-phy-connected properties

2023-03-15 Thread Guenter Roeck
Add fec[12]-phy-connected properties and use it to set phy-connected and phy-consumer properties for imx_fec. Signed-off-by: Guenter Roeck --- hw/arm/fsl-imx7.c | 20 include/hw/arm/fsl-imx7.h | 1 + 2 files changed, 21 insertions(+) diff --git a/hw/arm/fsl-imx7.c

[PATCH 5/5] arm/mcimx7d-sabre: Set fec2-phy-connected property to false

2023-03-15 Thread Guenter Roeck
On mcimx7d-sabre, the MDIO bus is connected to the first Ethernet interface. Set fec2-phy-connected to false to reflect this. Signed-off-by: Guenter Roeck --- hw/arm/mcimx7d-sabre.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/mcimx7d-sabre.c b/hw/arm/mcimx7d-sabre.c index 6182b1

[PATCH 0/5] Support both Ethernet interfaces on i.MX6UL and i.MX7

2023-03-15 Thread Guenter Roeck
The SOC on i.MX6UL and i.MX7 has 2 Ethernet interfaces. The PHY on each may be connected to separate MDIO busses, or both may be connected on the same MDIO bus using different PHY addresses. Commit 461c51ad4275 ("Add a phy-num property to the i.MX FEC emulator") added support for specifying PHY add

[PATCH 2/5] fsl-imx6ul: Add fec[12]-phy-connected properties

2023-03-15 Thread Guenter Roeck
Add fec[12]-phy-connected properties and use it to set phy-connected and phy-consumer properties for imx_fec. Signed-off-by: Guenter Roeck --- hw/arm/fsl-imx6ul.c | 20 include/hw/arm/fsl-imx6ul.h | 1 + 2 files changed, 21 insertions(+) diff --git a/hw/arm/fsl-imx

[PATCH 3/5] arm/mcimx6ul-evk: Set fec1-phy-connected property to false

2023-03-15 Thread Guenter Roeck
On mcimx6ul-evk, the MDIO bus is connected to the second Ethernet interface. Set fec1-phy-connected to false to reflect this. Signed-off-by: Guenter Roeck --- hw/arm/mcimx6ul-evk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/mcimx6ul-evk.c b/hw/arm/mcimx6ul-evk.c index d83c3c380

[PATCH 1/5] hw/net/imx_fec: Support two Ethernet interfaces connected to single MDIO bus

2023-03-15 Thread Guenter Roeck
The SOC on i.MX6UL and i.MX7 has 2 Ethernet interfaces. The PHY on each may be connected to separate MDIO busses, or both may be connected on the same MDIO bus using different PHY addresses. Commit 461c51ad4275 ("Add a phy-num property to the i.MX FEC emulator") added support for specifying PHY add

Re: [PATCH v3 2/3] qapi: Do not generate empty enum

2023-03-15 Thread Richard Henderson
On 3/15/23 04:28, Philippe Mathieu-Daudé wrote: Per the C++ standard, empty enum are ill-formed. Do not generate them in order to avoid: In file included from qga/qga-qapi-emit-events.c:14: qga/qga-qapi-emit-events.h:20:1: error: empty enum is invalid 20 | } qga_QAPIEvent; |

[PATCH v18 02/17] s390x/cpu topology: add topology entries on CPU hotplug

2023-03-15 Thread Pierre Morel
The topology information are attributes of the CPU and are specified during the CPU device creation. On hot plug we: - calculate the default values for the topology for drawers, books and sockets in the case they are not specified. - verify the CPU attributes - check that we have still room on t

Enable cross-page block chaining for user mode tcg

2023-03-15 Thread Wu, Fei
Block chaining is one of the key performance factors of tcg. Currently tcg doesn't allow chaining across page boundary, an example can be found in gen_goto_tb() in target/riscv/translate.c. For user-mode tcg, it's possible to enable cross-page chaining with careful attentions, assume there are cha

[PATCH v18 03/17] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-03-15 Thread Pierre Morel
On interception of STSI(15.1.x) the System Information Block (SYSIB) is built from the list of pre-ordered topology entries. Signed-off-by: Pierre Morel --- include/hw/s390x/cpu-topology.h | 21 +++ include/hw/s390x/sclp.h | 1 + target/s390x/cpu.h | 72 hw/s390

[PATCH v18 15/17] tests/avocado: s390x cpu topology entitlement tests

2023-03-15 Thread Pierre Morel
This test takes care to check the changes on different entitlements when the guest requests a polarization change. Signed-off-by: Pierre Morel --- tests/avocado/s390_topology.py | 56 ++ 1 file changed, 56 insertions(+) diff --git a/tests/avocado/s390_topology.py

[PATCH v18 17/17] tests/avocado: s390x cpu topology test socket full

2023-03-15 Thread Pierre Morel
This test verifies that QMP set-cpu-topology does not accept to overload a socket. Signed-off-by: Pierre Morel --- tests/avocado/s390_topology.py | 27 +++ 1 file changed, 27 insertions(+) diff --git a/tests/avocado/s390_topology.py b/tests/avocado/s390_topology.py index

Re: [PATCH v3 1/3] scripts/git.orderfile: Display QAPI script changes before schema ones

2023-03-15 Thread Philippe Mathieu-Daudé
On 15/3/23 12:28, Philippe Mathieu-Daudé wrote: When modifying QAPI scripts and modifying C files along, it makes sense to display QAPI changes first. Patch 3 of this series illustrates this (and has been produced using this orderfile). Signed-off-by: Philippe Mathieu-Daudé --- scripts/git

[PATCH v18 14/17] tests/avocado: s390x cpu topology polarisation

2023-03-15 Thread Pierre Morel
Polarization is changed on a request from the guest. Let's verify the polarization is accordingly set by QEMU. Signed-off-by: Pierre Morel --- tests/avocado/s390_topology.py | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/tests/avocado/s390_

[PATCH v18 12/17] docs/s390x/cpu topology: document s390x cpu topology

2023-03-15 Thread Pierre Morel
Add some basic examples for the definition of cpu topology in s390x. Signed-off-by: Pierre Morel --- docs/devel/index-internals.rst | 1 + docs/devel/s390-cpu-topology.rst | 146 ++ docs/system/s390x/cpu-topology.rst | 238 + docs/system/target

Re: [PATCH V3 1/2] docs: vhost-user: Define memory region separately

2023-03-15 Thread Stefan Hajnoczi
On Thu, Mar 09, 2023 at 02:21:00PM +0530, Viresh Kumar wrote: > The same layout is defined twice, once in "single memory region > description" and then in "memory regions description". > > Separate out details of memory region from these two and reuse the same > definition later on. > > While at

Re: [PATCH v2 2/3] qapi: Do not generate empty enum

2023-03-15 Thread Stefan Berger
On 3/15/23 07:13, Philippe Mathieu-Daudé wrote: Per the C++ standard, empty enum are ill-formed. Do not generate them in order to avoid: In file included from qga/qga-qapi-emit-events.c:14: qga/qga-qapi-emit-events.h:20:1: error: empty enum is invalid 20 | } qga_QAPIEvent;

Re: raspi3b - dumpdtb

2023-03-15 Thread Philippe Mathieu-Daudé
Hi Little, On 15/3/23 13:43, Little Tree wrote: I am using QEMU 6.2.0 to emulate raspi3b (Raspberry Pi 3b). I have used the following command to dump the DTB. It is neither terminating nor dumping the DTB. $ qemu-system-aarch64 -machine raspi3b,dumpdtb=test.dtb VNC server running on 127.0.0.1

Re: [PATCH V3 2/2] docs: vhost-user: Add Xen specific memory mapping support

2023-03-15 Thread Stefan Hajnoczi
On Thu, Mar 09, 2023 at 02:21:01PM +0530, Viresh Kumar wrote: > The current model of memory mapping at the back-end works fine where a > standard call to mmap() (for the respective file descriptor) is enough > before the front-end can start accessing the guest memory. > > There are other complex c

[PATCH v18 08/17] qapi/s390x/cpu topology: set-cpu-topology qmp command

2023-03-15 Thread Pierre Morel
The modification of the CPU attributes are done through a monitor command. It allows to move the core inside the topology tree to optimize the cache usage in the case the host's hypervisor previously moved the CPU. The same command allows to modify the CPU attributes modifiers like polarization e

[PATCH v18 13/17] tests/avocado: s390x cpu topology core

2023-03-15 Thread Pierre Morel
Introduction of the s390x cpu topology core functions and basic tests. We test the corelation between the command line and the QMP results in query-cpus-fast for various CPU topology. Signed-off-by: Pierre Morel --- tests/avocado/s390_topology.py | 196 + 1 file

Re: [PATCH V3 0/2] qemu: vhost-user: Support Xen memory mapping quirks

2023-03-15 Thread Stefan Hajnoczi
On Thu, Mar 09, 2023 at 02:20:59PM +0530, Viresh Kumar wrote: > Hello, > > This patchset tries to update the vhost-user protocol to make it support > special > memory mapping required in case of Xen hypervisor. > > The first patch is mostly cleanup and second one introduces a new xen specific >

[PATCH v18 10/17] machine: adding s390 topology to info hotpluggable-cpus

2023-03-15 Thread Pierre Morel
S390 topology adds books and drawers topology containers. Let's add these to the HMP information for hotpluggable cpus. Signed-off-by: Pierre Morel --- hw/core/machine-hmp-cmds.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/core/machine-hmp-cmds.c b/hw/core/machine-hmp-cmds.c ind

Re: [PATCH v2 2/3] qapi: Do not generate empty enum

2023-03-15 Thread Philippe Mathieu-Daudé
On 15/3/23 16:19, Stefan Berger wrote: On 3/15/23 07:13, Philippe Mathieu-Daudé wrote: Per the C++ standard, empty enum are ill-formed. Do not generate them in order to avoid:    In file included from qga/qga-qapi-emit-events.c:14:    qga/qga-qapi-emit-events.h:20:1: error: empty enum is invali

[PATCH v18 07/17] target/s390x/cpu topology: activate CPU topology

2023-03-15 Thread Pierre Morel
The KVM capability KVM_CAP_S390_CPU_TOPOLOGY is used to activate the S390_FEAT_CONFIGURATION_TOPOLOGY feature and the topology facility in the host CPU model for the guest in the case the topology is available in QEMU and in KVM. The feature is disabled by default and fenced for SE (secure executi

[PATCH v18 06/17] s390x/cpu topology: interception of PTF instruction

2023-03-15 Thread Pierre Morel
When the host supports the CPU topology facility, the PTF instruction with function code 2 is interpreted by the SIE, provided that the userland hypervisor activates the interpretation by using the KVM_CAP_S390_CPU_TOPOLOGY KVM extension. The PTF instructions with function code 0 and 1 are interce

Re: [RFC 0/2] Split padded I/O vectors exceeding IOV_MAX

2023-03-15 Thread Stefan Hajnoczi
On Wed, Mar 15, 2023 at 01:13:28PM +0100, Hanna Czenczek wrote: > Hi, > > We accept I/O vectors with up to 1024 (IOV_MAX) elements from guests. > When a guest request does not conform to the underlying storage's > alignment requirements, we pad it with head and/or tail buffers as > necessary, whic

Re: [PATCH 1/7] target/s390x: Fix s390_probe_access for user-only

2023-03-15 Thread Thomas Huth
On 09/01/2023 21.18, Richard Henderson wrote: In db9aab5783a2 we broke the contract of s390_probe_access, in that it no longer returned an exception code, nor set __excp_addr. Fix both. Reported-by: David Hildenbrand Signed-off-by: Richard Henderson --- target/s390x/tcg/mem_helper.c | 31 ++

[PATCH v18 00/17] s390x: CPU Topology

2023-03-15 Thread Pierre Morel
Hi, Since the respin was quite fast, what is new in the last two respin: A) shadow_entitlement stores the vertical entitlement It serves two purposes: 1) when the host specifies the entitlement, he may not be aware of the polarization and may provide entitlement which is not correct for

Re: [PULL 2/3] edk2: replace build scripts

2023-03-15 Thread Gerd Hoffmann
Hi, > The README should mention that you need to use > > . edk2setup.sh > > first. The script will do that if needed. > Also you need to be in the edk2 directory, I think. Or use the --core switch, or place the location in the config file in the [global] section. > It would be good if the

Re: [RFC 1/2] vhost-user: Add interface for virtio-fs migration

2023-03-15 Thread Hanna Czenczek
On 15.03.23 14:58, Stefan Hajnoczi wrote: On Mon, Mar 13, 2023 at 06:48:32PM +0100, Hanna Czenczek wrote: Add a virtio-fs-specific vhost-user interface to facilitate migrating back-end-internal state. We plan to migrate the internal state simply Luckily the interface does not need to be virtio

Re: [PULL 0/3] Edk2 stable202302 20230309 patches

2023-03-15 Thread Gerd Hoffmann
Hi, > ▶ 206/206 ERROR:../tests/qtest/acpi-utils.c:158:acpi_find_rsdp_address_uefi: > code should not be reached ERROR > 206/206 qemu:qtest+qtest-aarch64 / qtest-aarch64/bios-tables-test > ERROR 706.75s killed by signal 6 SIGABRT mst? laszlo? Any hints how to debug that? Tried to start qemu m

Re: [RFC 0/2] Split padded I/O vectors exceeding IOV_MAX

2023-03-15 Thread Hanna Czenczek
On 15.03.23 16:29, Stefan Hajnoczi wrote: On Wed, Mar 15, 2023 at 01:13:28PM +0100, Hanna Czenczek wrote: Hi, We accept I/O vectors with up to 1024 (IOV_MAX) elements from guests. When a guest request does not conform to the underlying storage's alignment requirements, we pad it with head and/o

Re: [PATCH v2 03/30] accel/tcg: Add cpu_in_serial_context

2023-03-15 Thread Philippe Mathieu-Daudé
On 16/2/23 03:57, Richard Henderson wrote: Like cpu_in_exclusive_context, but also true if there is no other cpu against which we could race. Use it in tb_flush as a direct replacement. Use it in cpu_loop_exit_atomic to ensure that there is no loop against cpu_exec_step_atomic. Signed-off-by: R

Re: [PULL 0/3] Edk2 stable202302 20230309 patches

2023-03-15 Thread Laszlo Ersek
On 3/15/23 16:56, Gerd Hoffmann wrote: > Hi, > >> ▶ 206/206 ERROR:../tests/qtest/acpi-utils.c:158:acpi_find_rsdp_address_uefi: >> code should not be reached ERROR >> 206/206 qemu:qtest+qtest-aarch64 / qtest-aarch64/bios-tables-test >> ERROR 706.75s killed by signal 6 SIGABRT > > mst? laszlo?

Re: [RFC 1/2] vhost-user: Add interface for virtio-fs migration

2023-03-15 Thread Stefan Hajnoczi
On Wed, 15 Mar 2023 at 11:56, Hanna Czenczek wrote: > > On 15.03.23 14:58, Stefan Hajnoczi wrote: > > On Mon, Mar 13, 2023 at 06:48:32PM +0100, Hanna Czenczek wrote: > >> Add a virtio-fs-specific vhost-user interface to facilitate migrating > >> back-end-internal state. We plan to migrate the int

Re: [PATCH v2 1/2] target/m68k: Reject immediate as destination in gen_ea_mode

2023-03-15 Thread Laurent Vivier
Le 09/03/2023 à 21:16, Richard Henderson a écrit : In theory this should never happen, as all such instructions are illegal. This is checked in e.g. gen_lea_mode and gen_ea_mode_fp but not here. In case something higher up isn't checking modes properly, return NULL_QREG. This will result in an

Re: [PATCH v2 29/30] tcg/i386: Add vex_v argument to tcg_out_vex_modrm_pool

2023-03-15 Thread Philippe Mathieu-Daudé
On 16/2/23 03:57, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c.inc | 16 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH v8] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-15 Thread Dorinda Bassey
This commit adds a new audiodev backend to allow QEMU to use Pipewire as both an audio sink and source. This backend is available on most systems Add Pipewire entry points for QEMU Pipewire audio backend Add wrappers for QEMU Pipewire audio backend in qpw_pcm_ops() qpw_write function returns the c

Re: [PATCH v2 18/30] tcg/aarch64: Detect have_lse, have_lse2 for darwin

2023-03-15 Thread Philippe Mathieu-Daudé
On 16/2/23 03:57, Richard Henderson wrote: These features are present for Apple M1. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c.inc | 28 1 file changed, 28 insertions(+) Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé

Re: [PATCH v2 17/30] tcg/aarch64: Detect have_lse, have_lse2 for linux

2023-03-15 Thread Philippe Mathieu-Daudé
On 16/2/23 03:57, Richard Henderson wrote: Notice when the host has additional atomic instructions. The new variables will also be used in generated code. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 3 +++ tcg/aarch64/tcg-target.c.inc | 12 2 files chan

  1   2   3   >