Re: [qemu-web PATCH] Announce Google Summer of Code and Outreachy 2023

2023-03-01 Thread Thomas Huth
On 27/02/2023 17.11, Thomas Huth wrote: On 24/02/2023 02.10, Stefan Hajnoczi wrote: QEMU is participating in GSoC and Outreachy again. This blog post will draw people's attention to our open source internships and increase the number of applicants. Signed-off-by: Stefan Hajnoczi ---   _posts/2

Re: [PATCH] acpi: cpuhp: fix guest-visible maximum access size to the legacy reg block

2023-03-01 Thread Laszlo Ersek
Hello Christian, On 3/1/23 08:17, Christian Ehrhardt wrote: > On Thu, Jan 5, 2023 at 8:14 AM Laszlo Ersek wrote: >> >> On 1/4/23 13:35, Michael S. Tsirkin wrote: >>> On Wed, Jan 04, 2023 at 10:01:38AM +0100, Laszlo Ersek wrote: The modern ACPI CPU hotplug interface was introduced in the foll

Re: [PATCH v2] virtio-balloon: optimize the virtio-balloon on the ARM platform

2023-03-01 Thread David Hildenbrand
On 01.03.23 07:38, Yangming wrote: Optimize the virtio-balloon feature on the ARM platform by adding a variable to keep track of the current hot-plugged pc-dimm size, instead of traversing the virtual machine's memory modules to count the current RAM size during the balloon inflation or deflation

Re: [PATCH] memory: avoid unnecessary iteration when updating ioeventfds

2023-03-01 Thread Jason Wang
On Tue, Feb 28, 2023 at 10:25 PM Longpeng(Mike) wrote: > > From: Longpeng > > When updating ioeventfds, we need to iterate all address spaces and > iterate all flat ranges of each address space. There is so much > redundant process that a FlatView would be iterated for so many times > during one

Re: [PATCH v3 1/4] crypto/luks: Initialize stack variable to silence warning

2023-03-01 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 01:48:01PM -0700, Daniel Xu wrote: > With `../configure --enable-sanitizers`, I was getting the following > build error: > > In file included from /usr/include/string.h:535, > from /home/dxu/dev/qemu/include/qemu/osdep.h:99, >

[PATCH v6 4/8] hw/net: ne2000: Remove the logic of padding short frames in the receive path

2023-03-01 Thread bmeng . cn
From: Bin Meng Now that we have implemented unified short frames padding in the QEMU networking codes, remove the same logic in the NIC codes. Signed-off-by: Bin Meng Signed-off-by: Bin Meng --- hw/net/ne2000.c | 12 1 file changed, 12 deletions(-) diff --git a/hw/net/ne2000.c

[PATCH v6 1/8] hw/net: e1000: Remove the logic of padding short frames in the receive path

2023-03-01 Thread bmeng . cn
From: Bin Meng Now that we have implemented unified short frames padding in the QEMU networking codes, remove the same logic in the NIC codes. This actually reverts commit 78aeb23eded2d0b765bf9145c71f80025b568acd. Signed-off-by: Bin Meng Signed-off-by: Bin Meng --- hw/net/e1000.c | 11 +

[PATCH v6 7/8] hw/net: sungem: Remove the logic of padding short frames in the receive path

2023-03-01 Thread bmeng . cn
From: Bin Meng Now that we have implemented unified short frames padding in the QEMU networking codes, remove the same logic in the NIC codes. Signed-off-by: Bin Meng Signed-off-by: Bin Meng --- hw/net/sungem.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/hw/net/sungem.

[PATCH v6 0/8] net: Pad short frames for network backends

2023-03-01 Thread bmeng . cn
From: Bin Meng The minimum Ethernet frame length is 60 bytes. For short frames with smaller length like ARP packets (only 42 bytes), on a real world NIC it can choose either padding its length to the minimum required 60 bytes, or sending it out directly to the wire. Such behavior can be hardcoded

[PATCH v6 8/8] hw/net: sunhme: Remove the logic of padding short frames in the receive path

2023-03-01 Thread bmeng . cn
From: Bin Meng Now that we have implemented unified short frames padding in the QEMU networking codes, remove the same logic in the NIC codes. Signed-off-by: Bin Meng Signed-off-by: Bin Meng --- hw/net/sunhme.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/hw/net/sunhme.c b

[PATCH v6 2/8] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path

2023-03-01 Thread bmeng . cn
From: Bin Meng Now that we have implemented unified short frames padding in the QEMU networking codes, remove the same logic in the NIC codes. This actually reverts commit 40a87c6c9b11ef9c14e0301f76abf0eb2582f08e. Signed-off-by: Bin Meng Signed-off-by: Bin Meng --- hw/net/vmxnet3.c | 10 ---

[PATCH v6 6/8] hw/net: rtl8139: Remove the logic of padding short frames in the receive path

2023-03-01 Thread bmeng . cn
From: Bin Meng Now that we have implemented unified short frames padding in the QEMU networking codes, remove the same logic in the NIC codes. Signed-off-by: Bin Meng Signed-off-by: Bin Meng --- hw/net/rtl8139.c | 12 1 file changed, 12 deletions(-) diff --git a/hw/net/rtl8139.

[PATCH v6 3/8] hw/net: i82596: Remove the logic of padding short frames in the receive path

2023-03-01 Thread bmeng . cn
From: Bin Meng Now that we have implemented unified short frames padding in the QEMU networking codes, remove the same logic in the NIC codes. Signed-off-by: Bin Meng Signed-off-by: Bin Meng --- hw/net/i82596.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/hw/net/i82

Re: [PATCH v3 3/4] qga: Add optional `merge-output` flag to guest-exec qapi

2023-03-01 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 01:48:03PM -0700, Daniel Xu wrote: > Currently, the captured output (via `capture-output`) is segregated into > separate GuestExecStatus fields (`out-data` and `err-data`). This means > that downstream consumers have no way to reassemble the captured data > back into the ori

[PATCH v6 5/8] hw/net: pcnet: Remove the logic of padding short frames in the receive path

2023-03-01 Thread bmeng . cn
From: Bin Meng Now that we have implemented unified short frames padding in the QEMU networking codes, remove the same logic in the NIC codes. Signed-off-by: Bin Meng Signed-off-by: Bin Meng --- hw/net/pcnet.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/net/pcnet.c b/hw/ne

Re: [PATCH v3 4/4] qga: test: Add tests for `merge-output` flag

2023-03-01 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 01:48:04PM -0700, Daniel Xu wrote: > This commit adds a test to ensure `merge-output` functions as expected. > We also add a negative test to ensure we haven't regressed previous > functionality. > > Signed-off-by: Daniel Xu > --- > tests/unit/test-qga.c | 157 +++

Re: [PATCH v3 18/24] tests/lcitool: append user setting stanza to dockerfiles

2023-03-01 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 07:06:47PM +, Alex Bennée wrote: > For the cross-compilation use-case it is important to add the host > user to the dockerfile so we can map them to the docker environment > when cross-building files. > > Signed-off-by: Alex Bennée Reviewed-by: Daniel P. Berrangé W

Re: [PATCH v6 0/8] net: Pad short frames for network backends

2023-03-01 Thread Cédric Le Goater
Hello Bin, On 3/1/23 10:01, bmeng...@gmail.com wrote: From: Bin Meng The minimum Ethernet frame length is 60 bytes. For short frames with smaller length like ARP packets (only 42 bytes), on a real world NIC it can choose either padding its length to the minimum required 60 bytes, or sending it

Re: [PATCH v5 11/12] cryptodev: Support query-stats QMP command

2023-03-01 Thread Daniel P . Berrangé
On Wed, Mar 01, 2023 at 10:51:23AM +0800, zhenwei pi wrote: > Now we can use "query-stats" QMP command to query statistics of > crypto devices. (Originally this was designed to show statistics > by '{"execute": "query-cryptodev"}'. Daniel Berrangé suggested that > querying configuration info by "qu

Re: [PATCH v3 07/10] qapi: implement conditional command arguments

2023-03-01 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 09:58:01AM -0600, Eric Blake wrote: > On Wed, Feb 22, 2023 at 11:23:03AM +0100, Markus Armbruster wrote: > > > However, I think it would be simpler, and better, if we piped the > > > generated code to clang-format (when available). I made a simple patch > > > for that too. >

Re: [PATCH 3/5] qmp: Added the helper stamp check.

2023-03-01 Thread Daniel P . Berrangé
On Tue, Feb 28, 2023 at 11:21:56PM +0100, Toke Høiland-Jørgensen wrote: > Daniel P. Berrangé writes: > > > On Tue, Feb 28, 2023 at 08:01:51PM +0100, Toke Høiland-Jørgensen wrote: > >> Daniel P. Berrangé writes: > >> > >> Just to interject a note on this here: the skeleton code is mostly a > >>

Re: [PATCH 3/5] qmp: Added the helper stamp check.

2023-03-01 Thread Daniel P . Berrangé
On Wed, Mar 01, 2023 at 08:49:42AM +0200, Yuri Benditovich wrote: > On Tue, Feb 28, 2023 at 8:05 PM Daniel P. Berrangé > wrote: > > > On Tue, Feb 28, 2023 at 11:56:27AM +0200, Yuri Benditovich wrote: > > > On Mon, Feb 20, 2023 at 11:50 AM Daniel P. Berrangé > > > > > wrote: > > > > > > > On Sun,

Re: [PATCH v5 05/12] cryptodev: Introduce 'query-cryptodev' QMP command

2023-03-01 Thread Daniel P . Berrangé
On Wed, Mar 01, 2023 at 10:51:17AM +0800, zhenwei pi wrote: > Now we have a QMP command to query crypto devices: > virsh qemu-monitor-command vm '{"execute": "query-cryptodev"}' | jq > { > "return": [ > { > "service": [ > "akcipher", > "mac", > "hash", >

Re: [PATCH v5 07/12] hmp: add cryptodev info command

2023-03-01 Thread Daniel P . Berrangé
On Wed, Mar 01, 2023 at 10:51:19AM +0800, zhenwei pi wrote: > Example of this command: > # virsh qemu-monitor-command vm --hmp info cryptodev > cryptodev1: service=[akcipher|mac|hash|cipher] > queue 0: type=builtin > cryptodev0: service=[akcipher] > queue 0: type=lkcf > > Signed-off-by: z

Re: [PATCH v5 08/12] cryptodev: Use CryptoDevBackendOpInfo for operation

2023-03-01 Thread Daniel P . Berrangé
On Wed, Mar 01, 2023 at 10:51:20AM +0800, zhenwei pi wrote: > Move queue_index, CryptoDevCompletionFunc and opaque into struct > CryptoDevBackendOpInfo, then cryptodev_backend_crypto_operation() > needs an argument CryptoDevBackendOpInfo *op_info only. And remove > VirtIOCryptoReq from cryptodev. I

Re: [PATCH v5 09/12] cryptodev: Account statistics

2023-03-01 Thread Daniel P . Berrangé
On Wed, Mar 01, 2023 at 10:51:21AM +0800, zhenwei pi wrote: > Account OPS/BPS for crypto device, this will be used for 'query-stats' > QEMU monitor command and QoS in the next step. > > Note that a crypto device may support symmetric mode, asymmetric mode, > both symmetric and asymmetric mode. So

Re: [PATCH v5 10/12] cryptodev: support QoS

2023-03-01 Thread Daniel P . Berrangé
On Wed, Mar 01, 2023 at 10:51:22AM +0800, zhenwei pi wrote: > Add 'throttle-bps' and 'throttle-ops' limitation to set QoS. The > two arguments work with both QEMU command line and QMP command. > > Example of QEMU command line: > -object cryptodev-backend-builtin,id=cryptodev1,throttle-bps=1600,\ >

Re: [PATCH v2 05/18] target/riscv: gdbstub: Do not generate CSR XML if Zicsr is disabled

2023-03-01 Thread LIU Zhiwei
On 2023/2/28 18:40, Bin Meng wrote: There is no need to generate the CSR XML if the Zicsr extension is not enabled. Should we generate the FPU XML or Vector XML when Zicsr is not enabled? Zhiwei Signed-off-by: Bin Meng Reviewed-by: Weiwei Li Reviewed-by: LIU Zhiwei --- (no changes sin

Re: [PATCH v2] qapi: Add 'acpi' field to 'query-machines' output

2023-03-01 Thread Peter Krempa
On Tue, Feb 28, 2023 at 09:12:34 +0100, Peter Krempa wrote: > Report which machine types support ACPI so that management applications > can properly use the 'acpi' property even on platforms such as ARM where > support for ACPI depends on the machine type and thus checking presence > of '-machine a

Re: [PATCH v2 05/18] target/riscv: gdbstub: Do not generate CSR XML if Zicsr is disabled

2023-03-01 Thread Bin Meng
On Wed, Mar 1, 2023 at 5:52 PM LIU Zhiwei wrote: > > > On 2023/2/28 18:40, Bin Meng wrote: > > There is no need to generate the CSR XML if the Zicsr extension > > is not enabled. > > Should we generate the FPU XML or Vector XML when Zicsr is not enabled? Good point. I think we should disable that

Re: out of CI pipeline minutes again

2023-03-01 Thread Alex Bennée
Eldon Stegall writes: > On Mon, Feb 27, 2023 at 12:43:55PM -0500, Stefan Hajnoczi wrote: >> - Personally, I don't think this should exclude other efforts like >> Eldon's. We can always add more private runners! > > Hi! > Thanks so much to Alex, Thomas, Gerd, et al for the pointers. > > Although

Re: [PATCH v3 24/24] tests/avocado: disable BootLinuxPPC64 test in CI

2023-03-01 Thread Alex Bennée
Thomas Huth writes: > On 28/02/2023 20.06, Alex Bennée wrote: >> This test is exceptionally heavyweight (nearly 330s) compared to the >> two (both endians) TuxRun baseline tests which complete in under 160s. >> The coverage is slightly reduced but a more directed test could make >> up the diffe

Re: [PATCH v3 22/24] gitlab: move the majority of artefact handling to a template

2023-03-01 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 1/3/23 07:51, Thomas Huth wrote: >> On 28/02/2023 22.41, Philippe Mathieu-Daudé wrote: >>> On 28/2/23 20:06, Alex Bennée wrote: To avoid lots of copy and paste lets deal with artefacts in a template. This way we can filter out most of the pre-binary

Re: [PULL 00/13] testing updates (gitlab, cirrus, docker, avocado, windows)

2023-03-01 Thread Alex Bennée
Peter Maydell writes: > On Fri, 24 Feb 2023 at 21:23, Philippe Mathieu-Daudé > wrote: >> >> On 24/2/23 20:52, Alex Bennée wrote: >> > >> > Peter Maydell writes: >> > >> >> On Thu, 23 Feb 2023 at 15:57, Alex Bennée wrote: >> >>> >> >>> The following changes since commit >> >>> 79b677d658d3d

Re: [PATCH v3 22/24] gitlab: move the majority of artefact handling to a template

2023-03-01 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 28/2/23 20:06, Alex Bennée wrote: >> To avoid lots of copy and paste lets deal with artefacts in a >> template. This way we can filter out most of the pre-binary object and >> library files we no longer need as we have the final binaries. >> build-system-alpi

Re: [PATCH v6 1/2] arm/kvm: add support for MTE

2023-03-01 Thread Cornelia Huck
On Tue, Feb 28 2023, Andrea Bolognani wrote: > On Tue, Feb 28, 2023 at 04:02:15PM +0100, Cornelia Huck wrote: >> Introduce a new cpu feature flag to control MTE support. To preserve >> backwards compatibility for tcg, MTE will continue to be enabled as >> long as tag memory has been provided. >>

Re: [PATCH v6 0/8] net: Pad short frames for network backends

2023-03-01 Thread Bin Meng
Hi Cédric, On Wed, Mar 1, 2023 at 5:13 PM Cédric Le Goater wrote: > > Hello Bin, > > On 3/1/23 10:01, bmeng...@gmail.com wrote: > > From: Bin Meng > > > > The minimum Ethernet frame length is 60 bytes. For short frames with > > smaller length like ARP packets (only 42 bytes), on a real world NIC

Re: Re: [PATCH v5 09/12] cryptodev: Account statistics

2023-03-01 Thread zhenwei pi
On 3/1/23 17:44, Daniel P. Berrangé wrote: On Wed, Mar 01, 2023 at 10:51:21AM +0800, zhenwei pi wrote: Account OPS/BPS for crypto device, this will be used for 'query-stats' QEMU monitor command and QoS in the next step. Note that a crypto device may support symmetric mode, asymmetric mode,

Re: [PATCH v3 23/24] tests/docker: add zstdtools to the images (!AWAITING UPSTREAM)

2023-03-01 Thread Philippe Mathieu-Daudé
On 28/2/23 20:06, Alex Bennée wrote: We need this to be able to run the tuxrun_baseline tests in CI which in turn helps us reduce overhead running other tests. [See https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/361] Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/alpine.dock

Re: [PATCH v2] qapi: Add 'acpi' field to 'query-machines' output

2023-03-01 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH v5 07/12] hmp: add cryptodev info command

2023-03-01 Thread Dr. David Alan Gilbert
* zhenwei pi (pizhen...@bytedance.com) wrote: > Example of this command: > # virsh qemu-monitor-command vm --hmp info cryptodev > cryptodev1: service=[akcipher|mac|hash|cipher] > queue 0: type=builtin > cryptodev0: service=[akcipher] > queue 0: type=lkcf > > Signed-off-by: zhenwei pi Ac

Re: [PATCH v3 22/24] gitlab: move the majority of artefact handling to a template

2023-03-01 Thread Philippe Mathieu-Daudé
On 1/3/23 11:00, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 1/3/23 07:51, Thomas Huth wrote: On 28/02/2023 22.41, Philippe Mathieu-Daudé wrote: On 28/2/23 20:06, Alex Bennée wrote: To avoid lots of copy and paste lets deal with artefacts in a template. This way we can filter out

Re: [PATCH v3 22/24] gitlab: move the majority of artefact handling to a template

2023-03-01 Thread Philippe Mathieu-Daudé
On 28/2/23 20:06, Alex Bennée wrote: To avoid lots of copy and paste lets deal with artefacts in a template. This way we can filter out most of the pre-binary object and library files we no longer need as we have the final binaries. build-system-alpine also saved .git-submodule-status so for sim

Re: [PATCH v3 22/24] gitlab: move the majority of artefact handling to a template

2023-03-01 Thread Philippe Mathieu-Daudé
On 28/2/23 22:55, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 28/2/23 20:06, Alex Bennée wrote: To avoid lots of copy and paste lets deal with artefacts in a template. This way we can filter out most of the pre-binary object and library files we no longer need as we have the final b

[PATCH] test: Check vnc enable before compiling vnc test

2023-03-01 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/qtest/meson.build | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index 29a4efb4c2..62eecf2edf 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -309,10 +309

Re: [PATCH v5 07/12] hmp: add cryptodev info command

2023-03-01 Thread Dr. David Alan Gilbert
* zhenwei pi (pizhen...@bytedance.com) wrote: > Example of this command: > # virsh qemu-monitor-command vm --hmp info cryptodev > cryptodev1: service=[akcipher|mac|hash|cipher] > queue 0: type=builtin > cryptodev0: service=[akcipher] > queue 0: type=lkcf > > Signed-off-by: zhenwei pi Ye

Re: [PATCH] test: Check vnc enable before compiling vnc test

2023-03-01 Thread Thomas Huth
On 01/03/2023 11.44, Juan Quintela wrote: Signed-off-by: Juan Quintela --- tests/qtest/meson.build | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index 29a4efb4c2..62eecf2edf 100644 --- a/tests/qtest/meson.build

Re: [PATCH] tests: Ensure TAP version is printed before other messages

2023-03-01 Thread Richard W.M. Jones
On Tue, Feb 28, 2023 at 09:30:56PM +0100, Thomas Huth wrote: > On 27/02/2023 18.40, Richard W.M. Jones wrote: > >These two tests were failing with this error: > > > > stderr: > > TAP parsing error: version number must be on the first line > > [...] > > Unknown TAP version. The first line MU

Re: [PATCH] tests: Ensure TAP version is printed before other messages

2023-03-01 Thread Thomas Huth
On 01/03/2023 11.52, Richard W.M. Jones wrote: On Tue, Feb 28, 2023 at 09:30:56PM +0100, Thomas Huth wrote: On 27/02/2023 18.40, Richard W.M. Jones wrote: These two tests were failing with this error: stderr: TAP parsing error: version number must be on the first line [...] Unknown

[PATCH v6 00/12] Refactor cryptodev

2023-03-01 Thread zhenwei pi
v6 -> v7: - Suggested by Daniel, Drop 'QCryptodevBackendSymStat' and 'QCryptodevBackendAsymStat' from QAPI, declare a normal C struct directly instead. - Other minor changes. (QCryptodevBackendSymStat -> CryptodevBackendSymStat) v5 -> v6: - Rebase code against the latest version: 627634031092e

[PATCH v6 12/12] MAINTAINERS: add myself as the maintainer for cryptodev

2023-03-01 Thread zhenwei pi
I developed the akcipher service, QoS setting, QMP/HMP commands and statistics accounting for crypto device. Making myself as the maintainer for QEMU's cryptodev. Cc: Gonglei Signed-off-by: zhenwei pi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH v6 01/12] cryptodev: Introduce cryptodev.json

2023-03-01 Thread zhenwei pi
Introduce QCryptodevBackendType in cryptodev.json, also apply this to related codes. Then we can drop 'enum CryptoDevBackendOptionsType'. Note that `CRYPTODEV_BACKEND_TYPE_NONE` is *NOT* used by anywhere, so drop it(no 'none' enum in QCryptodevBackendType). Reviewed-by: Daniel P. Berrangé Signed

[PATCH v6 11/12] cryptodev: Support query-stats QMP command

2023-03-01 Thread zhenwei pi
Now we can use "query-stats" QMP command to query statistics of crypto devices. (Originally this was designed to show statistics by '{"execute": "query-cryptodev"}'. Daniel Berrangé suggested that querying configuration info by "query-cryptodev", and querying runtime performance info by "query-stat

[PATCH v6 05/12] cryptodev: Introduce 'query-cryptodev' QMP command

2023-03-01 Thread zhenwei pi
Now we have a QMP command to query crypto devices: virsh qemu-monitor-command vm '{"execute": "query-cryptodev"}' | jq { "return": [ { "service": [ "akcipher", "mac", "hash", "cipher" ], "id": "cryptodev1", "client": [ {

[PATCH v6 03/12] cryptodev: Introduce cryptodev alg type in QAPI

2023-03-01 Thread zhenwei pi
Introduce cryptodev alg type in cryptodev.json, then apply this to related codes, and drop 'enum CryptoDevBackendAlgType'. There are two options: 1, { 'enum': 'QCryptodevBackendAlgType', 'prefix': 'CRYPTODEV_BACKEND_ALG', 'data': ['sym', 'asym']} Then we can keep 'CRYPTODEV_BACKEND_ALG_SYM' an

[PATCH v6 02/12] cryptodev: Remove 'name' & 'model' fields

2023-03-01 Thread zhenwei pi
We have already used qapi to generate crypto device types, this allows to convert type to a string 'model', so the 'model' field is not needed. And the 'name' field is not used by any backend driver, drop it. Reviewed-by: Daniel P. Berrangé Signed-off-by: zhenwei pi --- backends/cryptodev-buil

Re: [PATCH v3 23/24] tests/docker: add zstdtools to the images (!AWAITING UPSTREAM)

2023-03-01 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 28/2/23 20:06, Alex Bennée wrote: >> We need this to be able to run the tuxrun_baseline tests in CI which >> in turn helps us reduce overhead running other tests. >> [See https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/361] >> Signed-off-by: Alex Benné

[PATCH v6 07/12] hmp: add cryptodev info command

2023-03-01 Thread zhenwei pi
Example of this command: # virsh qemu-monitor-command vm --hmp info cryptodev cryptodev1: service=[akcipher|mac|hash|cipher] queue 0: type=builtin cryptodev0: service=[akcipher] queue 0: type=lkcf Acked-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrangé Signed-off-by: zhenwei pi

Re: [PATCH v3 22/24] gitlab: move the majority of artefact handling to a template

2023-03-01 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 1/3/23 11:00, Alex Bennée wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 1/3/23 07:51, Thomas Huth wrote: On 28/02/2023 22.41, Philippe Mathieu-Daudé wrote: > On 28/2/23 20:06, Alex Bennée wrote: >> To avoid lots of copy and paste lets deal

[PATCH v6 09/12] cryptodev: Account statistics

2023-03-01 Thread zhenwei pi
Account OPS/BPS for crypto device, this will be used for 'query-stats' QEMU monitor command and QoS in the next step. Note that a crypto device may support symmetric mode, asymmetric mode, both symmetric and asymmetric mode. So we use two structure to describe the statistics of a crypto device. S

Re: [PATCH] tests: Ensure TAP version is printed before other messages

2023-03-01 Thread Daniel P . Berrangé
On Wed, Mar 01, 2023 at 10:52:14AM +, Richard W.M. Jones wrote: > On Tue, Feb 28, 2023 at 09:30:56PM +0100, Thomas Huth wrote: > > On 27/02/2023 18.40, Richard W.M. Jones wrote: > > >These two tests were failing with this error: > > > > > > stderr: > > > TAP parsing error: version number mu

[PATCH v6 04/12] cryptodev: Introduce server type in QAPI

2023-03-01 Thread zhenwei pi
Introduce cryptodev service type in cryptodev.json, then apply this to related codes. Now we can remove VIRTIO_CRYPTO_SERVICE_xxx dependence from QEMU cryptodev. Reviewed-by: Daniel P. Berrangé Signed-off-by: zhenwei pi --- backends/cryptodev-builtin.c| 8 backends/cryptodev-lkcf.

[PATCH v6 06/12] cryptodev-builtin: Detect akcipher capability

2023-03-01 Thread zhenwei pi
Rather than exposing akcipher service/RSA algorithm to virtio crypto device unconditionally, detect akcipher capability from akcipher crypto framework. This avoids unsuccessful requests. Reviewed-by: Daniel P. Berrangé Signed-off-by: zhenwei pi --- backends/cryptodev-builtin.c | 18

[PATCH] test: Fix test-crypto-secret when compiling without keyring support

2023-03-01 Thread Juan Quintela
Linux keyring support is protected by CONFIG_KEYUTILS. Use CONFIG_SECRET_KEYRING. Signed-off-by: Juan Quintela --- Previous version of this patch changed the meson build rules. Daniel told me that the proper fix was to change the #ifdef test. --- tests/unit/test-crypto-secret.c | 10 +-

[PATCH v6 08/12] cryptodev: Use CryptoDevBackendOpInfo for operation

2023-03-01 Thread zhenwei pi
Move queue_index, CryptoDevCompletionFunc and opaque into struct CryptoDevBackendOpInfo, then cryptodev_backend_crypto_operation() needs an argument CryptoDevBackendOpInfo *op_info only. And remove VirtIOCryptoReq from cryptodev. It's also possible to hide VirtIOCryptoReq into virtio-crypto.c in th

[PATCH v6 10/12] cryptodev: support QoS

2023-03-01 Thread zhenwei pi
Add 'throttle-bps' and 'throttle-ops' limitation to set QoS. The two arguments work with both QEMU command line and QMP command. Example of QEMU command line: -object cryptodev-backend-builtin,id=cryptodev1,throttle-bps=1600,\ throttle-ops=100 Example of QMP command: virsh qemu-monitor-command bu

Re: [PATCH v6 09/12] cryptodev: Account statistics

2023-03-01 Thread Daniel P . Berrangé
On Wed, Mar 01, 2023 at 06:58:44PM +0800, zhenwei pi wrote: > Account OPS/BPS for crypto device, this will be used for 'query-stats' > QEMU monitor command and QoS in the next step. > > Note that a crypto device may support symmetric mode, asymmetric mode, > both symmetric and asymmetric mode. So

Re: [PATCH v3 23/24] tests/docker: add zstdtools to the images (!AWAITING UPSTREAM)

2023-03-01 Thread Philippe Mathieu-Daudé
On 1/3/23 11:59, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 28/2/23 20:06, Alex Bennée wrote: We need this to be able to run the tuxrun_baseline tests in CI which in turn helps us reduce overhead running other tests. [See https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/361]

Re: [PULL 00/62] tcg patch queue

2023-03-01 Thread Peter Maydell
On Wed, 1 Mar 2023 at 02:56, Richard Henderson wrote: > > The following changes since commit 627634031092e1514f363fd8659a579398de0f0e: > > Merge tag 'buildsys-qom-qdev-ui-20230227' of https://github.com/philmd/qemu > into staging (2023-02-28 15:09:18 +) > > are available in the Git reposito

Re: [PATCH] test: Fix test-crypto-secret when compiling without keyring support

2023-03-01 Thread Daniel P . Berrangé
On Wed, Mar 01, 2023 at 12:00:58PM +0100, Juan Quintela wrote: > Linux keyring support is protected by CONFIG_KEYUTILS. > Use CONFIG_SECRET_KEYRING. > > Signed-off-by: Juan Quintela > > --- > > Previous version of this patch changed the meson build rules. > Daniel told me that the proper fix wa

Re: [PATCH v5] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-01 Thread Marc-André Lureau
Hi Dorinda On Tue, Feb 28, 2023 at 2:01 AM Dorinda Bassey wrote: > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as > both an audio sink and source. This backend is available on most systems > > Add Pipewire entry points for QEMU Pipewire audio backend > Add wrappers for

Re: [PATCH] test: Check vnc enable before compiling vnc test

2023-03-01 Thread Marc-André Lureau
On Wed, Mar 1, 2023 at 2:45 PM Juan Quintela wrote: > > Signed-off-by: Juan Quintela Reviewed-by: Marc-André Lureau > --- > tests/qtest/meson.build | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > index 29

Re: [PATCH v3 24/24] tests/avocado: disable BootLinuxPPC64 test in CI

2023-03-01 Thread Philippe Mathieu-Daudé
On 1/3/23 10:57, Alex Bennée wrote: Thomas Huth writes: On 28/02/2023 20.06, Alex Bennée wrote: This test is exceptionally heavyweight (nearly 330s) compared to the two (both endians) TuxRun baseline tests which complete in under 160s. The coverage is slightly reduced but a more directed tes

Re: [PATCH v5 3/7] hw/isa/vt82c686: Implement PCI IRQ routing

2023-03-01 Thread BALATON Zoltan
On Wed, 1 Mar 2023, Bernhard Beschow wrote: Am 1. März 2023 00:17:09 UTC schrieb BALATON Zoltan : The real VIA south bridges implement a PCI IRQ router which is configured by the BIOS or the OS. In order to respect these configurations, QEMU needs to implement it as well. The real chip may allow

Re: [PATCH v5 2/7] Revert "hw/isa/vt82c686: Remove intermediate IRQ forwarder"

2023-03-01 Thread BALATON Zoltan
On Wed, 1 Mar 2023, Bernhard Beschow wrote: Am 1. März 2023 00:33:28 UTC schrieb BALATON Zoltan : On Wed, 1 Mar 2023, BALATON Zoltan wrote: This partially reverts commit bb98e0f59cde84d9fddc60ae74ef7ddfca17 keeping the rename of a state field but reverting other cahanges which break interru

[PATCH] Makefile: qemu-bundle is a directory

2023-03-01 Thread Juan Quintela
So make distclean should remove it with -rf, not -f alone. It has been that way since it was included. ommit cf60ccc3306ca4726cbd286a156863863b00ff4f Author: Akihiko Odaki Date: Fri Jun 24 23:50:37 2022 +0900 cutils: Introduce bundle mechanism Fixes: cf60ccc3306ca4726cbd286a156863863b00f

Re: [PATCH v5 5/7] hw/isa/vt82c686: Work around missing level sensitive irq in i8259 model

2023-03-01 Thread BALATON Zoltan
On Wed, 1 Mar 2023, Bernhard Beschow wrote: Am 1. März 2023 00:17:11 UTC schrieb BALATON Zoltan : MorphOS sets the ISA PIC to level sensitive mode but QEMU does not support that so this causes a freeze if multiple devices try to raise a shared interrupt. Work around it by lowering the interrupt

[PATCH] configure: Disable thread-safety warnings on macOS

2023-03-01 Thread Thomas Huth
The enablement of -Wthread-safety broke compilation on macOS (if -Werror is enabled, like in our CI). Disable it there by default until the problems are resolved. Signed-off-by: Thomas Huth --- configure | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configure b/configur

Re: [PATCH] plugin: fix clearing of plugin_mem_cbs before TB exit

2023-03-01 Thread Emilio Cota
On Tue, Feb 28, 2023 at 10:50:26 -1000, Richard Henderson wrote: > On 2/21/23 18:32, Emilio Cota wrote: > > Currently we are wrongly accessing plugin_tb->mem_helper at > > translation time from plugin_gen_disable_mem_helpers, which is > > called before generating a TB exit, e.g. with exit_tb. > >

Re: [PATCH v5 5/7] hw/isa/vt82c686: Work around missing level sensitive irq in i8259 model

2023-03-01 Thread David Woodhouse
On Wed, 2023-03-01 at 12:27 +0100, BALATON Zoltan wrote: > On Wed, 1 Mar 2023, Bernhard Beschow wrote: > > Am 1. März 2023 00:17:11 UTC schrieb BALATON Zoltan : > > > MorphOS sets the ISA PIC to level sensitive mode but QEMU does > > > not > > > support that so this causes a freeze if multiple devi

Re: Ping [PATCH v5] Emulate dip switch language layout settings on SUN keyboard

2023-03-01 Thread Mark Cave-Ayland
On 12/02/2023 11:31, Henrik Carlqvist wrote: Would you please consider this patch or let me know if you want me to somehow update it before it can be accepted? I've done a quick grep for similar examples for serial devices that use keyboard_layout but it looks like this would be the first.

Re: [PATCH 1/2] tcg: Clear plugin_mem_cbs on TB exit

2023-03-01 Thread Emilio Cota
As I mentioned in the patch that is being superseded here I like this approach -- it is simpler and generates less code. I'd also like to see the plugin_gen_disable_mem_helpers function go away, and a mention somewhere that now we are intentionally not clearing cpu->plugin_mem_cbs until TB exit (b

Re: [PATCH] memory: dump HPA and access type of ramblocks

2023-03-01 Thread Ted Chen
Thanks, Peter. hi Paolo, A gentle ping:) May I know what's your opinion to this patch? Any concern or further improvement required? Thanks Ted On Fri, Jan 06, 2023 at 01:01:03PM -0500, Peter Xu wrote: > Since I applied this twice already to my local trees, let me ping for Ted > to make sure it'

Re: [PATCH] Makefile: qemu-bundle is a directory

2023-03-01 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH 00/27] tcg: Simplify temporary usage

2023-03-01 Thread Emilio Cota
On Wed, Feb 15, 2023 at 20:15:37 -1000, Richard Henderson wrote: > On 2/10/23 02:35, Emilio Cota wrote: > > I ran yesterday linux-user SPEC06 benchmarks from your tcg-life branch. > > I do see perf regressions for two workloads (sjeng and xalancbmk). > > With perf(1) I see liveness_pass* are at 0.0

Re: [PATCH RESEND v7 9/9] tests/qtest: Fix tests when no KVM or TCG are present

2023-03-01 Thread Juan Quintela
Fabiano Rosas wrote: > It is possible to have a build with both TCG and KVM disabled due to > Xen requiring the i386 and x86_64 binaries to be present in an aarch64 > host. Ouch. Just curious: why are they needed? > > If we build with --disable-tcg on the aarch64 host, we will end-up > with a Q

Re: [PATCH 5/7] hw/ide/piix: Use generic ide_init_ioport()

2023-03-01 Thread Mark Cave-Ayland
On 10/02/2023 16:34, Bernhard Beschow wrote: Fishing out the ISA bus is still a hack IMO, for two reasons: First, IIUC, QOM'ified devices shall only care about its children while looking up one's parent bus violates this rule. Second, using the global machine pointer to scan for the ISA bus j

Re: hw/ppc/mac_newworld: Problem with Uninorth IRQ lines

2023-03-01 Thread Mark Cave-Ayland
On 21/02/2023 13:44, Philippe Mathieu-Daudé wrote: Hi Mark, The mac99 machines use the same PIC input IRQs for the Uninorth output IRQs: 379 if (PPC_INPUT(env) != PPC_FLAGS_INPUT_970) { 380 /* Uninorth AGP bus */ 381 for (i = 0; i < 4; i++) { 382 qdev_connect_gp

Re: [PATCH RESEND v7 9/9] tests/qtest: Fix tests when no KVM or TCG are present

2023-03-01 Thread Fabiano Rosas
Juan Quintela writes: > Fabiano Rosas wrote: >> It is possible to have a build with both TCG and KVM disabled due to >> Xen requiring the i386 and x86_64 binaries to be present in an aarch64 >> host. > > Ouch. > > Just curious: why are they needed? > >From https://wiki.xenproject.org/wiki/QEMU_

Re: [qemu-web PATCH] Announce Google Summer of Code and Outreachy 2023

2023-03-01 Thread Stefan Hajnoczi
On Wed, 1 Mar 2023 at 03:02, Thomas Huth wrote: > > On 27/02/2023 17.11, Thomas Huth wrote: > > On 24/02/2023 02.10, Stefan Hajnoczi wrote: > >> QEMU is participating in GSoC and Outreachy again. This blog post will > >> draw people's attention to our open source internships and increase the > >>

[PATCH 0/3] Migration: Make more ram_counters atomic

2023-03-01 Thread Juan Quintela
Hi On previous series we cerate ram_atomic_counters. But we basically need that all counters are atomic. So move back to only have ram_counters, just with a new type that allows the atomic counters. Once there, move update of stats out of RAM mutex. And make multifd_bytes atomic. Later, Juan.

[PATCH 2/3] migration: Update atomic stats out of the mutex

2023-03-01 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/multifd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/multifd.c b/migration/multifd.c index 7cb2326d03..f558169e37 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -433,8 +433,8 @@ static int multifd_sen

[PATCH 1/3] migration: Merge ram_counters and ram_atomic_counters

2023-03-01 Thread Juan Quintela
Using MgrationStats as type for ram_counters mean that we didn't have to re-declare each value in another struct. The need of atomic counters have make us to create MigrationAtomicStats for this atomic counters. Create RAMStats type which is a merge of MigrationStats and MigrationAtomicStats remov

[PATCH 3/3] migration: Make multifd_bytes atomic

2023-03-01 Thread Juan Quintela
In the spirit of: commit 394d323bc3451e4d07f13341cb8817fac8dfbadd Author: Peter Xu Date: Tue Oct 11 17:55:51 2022 -0400 migration: Use atomic ops properly for page accountings Signed-off-by: Juan Quintela --- migration/ram.h | 2 +- migration/migration.c | 4 ++-- migration/multif

Re: [PATCH] scsi: megasas: Internal cdbs have 16-byte length

2023-03-01 Thread Michael Tokarev
28.02.2023 20:11, Guenter Roeck wrote: Host drivers do not necessarily set cdb_len in megasas io commands. With commits 6d1511cea0 ("scsi: Reject commands if the CDB length exceeds buf_len") and fe9d8927e2 ("scsi: Add buf_len parameter to scsi_req_new()"), this results in failures to boot Linux f

Re: [PATCH RESEND v7 9/9] tests/qtest: Fix tests when no KVM or TCG are present

2023-03-01 Thread Alex Bennée
Fabiano Rosas writes: > Juan Quintela writes: > >> Fabiano Rosas wrote: >>> It is possible to have a build with both TCG and KVM disabled due to >>> Xen requiring the i386 and x86_64 binaries to be present in an aarch64 >>> host. >> >> Ouch. >> >> Just curious: why are they needed? >> > > Fro

Re: [PATCH RESEND v7 9/9] tests/qtest: Fix tests when no KVM or TCG are present

2023-03-01 Thread Thomas Huth
On 28/02/2023 20.26, Fabiano Rosas wrote: It is possible to have a build with both TCG and KVM disabled due to Xen requiring the i386 and x86_64 binaries to be present in an aarch64 host. If we build with --disable-tcg on the aarch64 host, we will end-up with a QEMU binary (x86) that does not su

Re: [PATCH RESEND v7 4/9] target/arm: move cpu_tcg to tcg/cpu32.c

2023-03-01 Thread Thomas Huth
On 28/02/2023 20.26, Fabiano Rosas wrote: From: Claudio Fontana move the module containing cpu models definitions for 32bit TCG-only CPUs to tcg/ and rename it for clarity. Signed-off-by: Claudio Fontana Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson --- ... diff --git a/test

Re: [PATCH v3 07/10] qapi: implement conditional command arguments

2023-03-01 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Feb 28, 2023 at 09:58:01AM -0600, Eric Blake wrote: >> On Wed, Feb 22, 2023 at 11:23:03AM +0100, Markus Armbruster wrote: >> > > However, I think it would be simpler, and better, if we piped the >> > > generated code to clang-format (when available). I made a

Re: [PATCH v5 5/7] hw/isa/vt82c686: Work around missing level sensitive irq in i8259 model

2023-03-01 Thread BALATON Zoltan
On Wed, 1 Mar 2023, David Woodhouse wrote: On Wed, 2023-03-01 at 12:27 +0100, BALATON Zoltan wrote: On Wed, 1 Mar 2023, Bernhard Beschow wrote: Am 1. März 2023 00:17:11 UTC schrieb BALATON Zoltan : MorphOS sets the ISA PIC to level sensitive mode but QEMU does not support that so this causes a

  1   2   3   4   5   >