Re: [PATCH 12/12] tests: ensure we export job results for some cross builds

2023-02-16 Thread Thomas Huth
On 15/02/2023 20.25, Alex Bennée wrote: We do run tests on some cross builds. Provide a template to ensure we export the testlog to the build artefacts and report the test results via the junit. Signed-off-by: Alex Bennée Reported-by: Peter Maydell --- v2 - properly format extends --- .g

Re: [PULL V2 00/10] Net patches

2023-02-16 Thread Philippe Mathieu-Daudé
Hi Jason, On 16/2/23 06:24, Jason Wang wrote: The following changes since commit 6a50f64ca01d0a7b97f14f069762bfd88160f31e: Merge tag 'pull-request-2023-02-14' of https://gitlab.com/thuth/qemu into staging (2023-02-14 14:46:10 +) are available in the git repository at: https://githu

Re: [PATCH v2 4/4] target/mips: set correct CP0.Config[4,5] values for M14K(c)

2023-02-16 Thread Philippe Mathieu-Daudé
On 16/2/23 06:17, Marcin Nowakowski wrote: Signed-off-by: Marcin Nowakowski Suggested-by: Philippe Mathieu-Daudé --- target/mips/cpu-defs.c.inc | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 05/12] gitlab: reduce default verbosity of cirrus run

2023-02-16 Thread Alex Bennée
Thomas Huth writes: > On 15/02/2023 20.25, Alex Bennée wrote: >> We also truncate the echoing of the test log if we fail. Ideally we >> would want the build aretefact to be available to gitlab but so far >> how to do this eludes me. >> Signed-off-by: Alex Bennée >> Cc: Daniel P. Berrangé >> -

Re: [PATCH v2 3/4] target/mips: implement CP0.Config7.WII bit support

2023-02-16 Thread Philippe Mathieu-Daudé
On 16/2/23 06:17, Marcin Nowakowski wrote: Some pre-release 6 cores use CP0.Config7.WII bit to indicate that a disabled interrupt should wake up a sleeping CPU. Enable this bit by default for M14K(c) and P5600. There are potentially other cores that support this feature, but I do not have a compl

Re: [PATCH v10 09/12] vfio/migration: Implement VFIO migration protocol v2

2023-02-16 Thread Avihai Horon
On 15/02/2023 22:53, Alex Williamson wrote: External email: Use caution opening links or attachments On Wed, 15 Feb 2023 20:23:12 +0200 Avihai Horon wrote: On 15/02/2023 15:01, Juan Quintela wrote: External email: Use caution opening links or attachments Avihai Horon wrote: Implement

Re: [PATCH 05/12] gitlab: reduce default verbosity of cirrus run

2023-02-16 Thread Thomas Huth
On 16/02/2023 09.02, Alex Bennée wrote: Thomas Huth writes: On 15/02/2023 20.25, Alex Bennée wrote: We also truncate the echoing of the test log if we fail. Ideally we would want the build aretefact to be available to gitlab but so far how to do this eludes me. Signed-off-by: Alex Bennée Cc

Re: [PATCH qemu 1/2] hw/at24c : modify at24c to support 1 byte address mode

2023-02-16 Thread Philippe Mathieu-Daudé
On 10/2/23 07:20, ~ssinprem wrote: From: Sittisak Sinprem --- hw/nvram/eeprom_at24c.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c index 2d4d8b952f..693212b661 100644 --- a/hw/nvram/eeprom_at24c.c +++ b/hw/nvram

[PATCH v2] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-16 Thread Dorinda Bassey
This commit adds a new audiodev backend to allow QEMU to use Pipewire as both an audio sink and source. Signed-off-by: Dorinda Bassey --- v2: * Shorten commit message * fix copyright ownership and authour * use QEMU standard of 4 space indentation * verbose use of pipewire instead pf pw audio/

Re: [RFC 08/52] machine: Add helpers to get cpu topology info from MachineState.topo

2023-02-16 Thread wangyanan (Y)
Hi Zhao, 在 2023/2/13 17:49, Zhao Liu 写道: From: Zhao Liu When MachineState.topo is introduced, the topology related structures become complicated. In the general case (hybrid or smp topology), accessing the topology information needs to determine whether it is currently smp or hybrid topology,

Re: [PATCH v3 2/2] s390x/pv: Add support for asynchronous teardown for reboot

2023-02-16 Thread Thomas Huth
On 14/02/2023 17.30, Claudio Imbrenda wrote: This patch adds support for the asynchronous teardown for reboot for protected VMs. When attempting to tear down a protected VM, try to use the new asynchronous interface first. If that fails, fall back to the classic synchronous one. The asynchronou

Re: [PATCH 1/8] m25p80: Improve error when the backend file size does not match the device

2023-02-16 Thread Philippe Mathieu-Daudé
On 15/2/23 20:52, Peter Delevoryas wrote: On Tue, Feb 14, 2023 at 06:18:23PM +0100, Cédric Le Goater wrote: Currently, when a block backend is attached to a m25p80 device and the associated file size does not match the flash model, QEMU complains with the error message "failed to read the initia

Re: [PATCH qemu 1/2] hw/at24c : modify at24c to support 1 byte address mode

2023-02-16 Thread Sittisak Sinprem
Hi Philippe, the EEPROM size less than or equal to 256 , such as 24c02 use only 1 byte to mention the memory (0 - 255) (0x00 - 0xff) write byte [ Start sAddr/W ] -> [ mem Addr ] -> [ mem data ] -> [ Stop ] read byte [ Start sAddr/W ] -> [ mem Addr ] -> [ reStart sAddr/R] -> [ mem data

[RFC PATCH v2 0/2] i386/sev: Support measured direct kernel boot on SNP

2023-02-16 Thread Dov Murik
This RFC patch series is based on AMD's RFC upmv10-snpv3 tree [1]. In order to enable measured direct kernel boot on SNP, QEMU needs to fill the hashes page when kernel-hashes=on. This relies on several changes to the SNP metadata published by OVMF (See [2] for proposed OVMF patches). Patch 1 p

[RFC PATCH v2 2/2] i386/sev: Allow measured direct kernel boot on SNP

2023-02-16 Thread Dov Murik
In SNP, the hashes page is not included in the ranges to pre-validate that appear in the SNP metadata published by AmdSev OVMF. Therefore, if the user enabled kernel hashes (for measured direct boot), QEMU should fill hashes table and encrypt the page. Note that in SNP (unlike SEV and SEV-ES) the

[RFC PATCH v2 1/2] qapi, i386: Move kernel-hashes to SevCommonProperties

2023-02-16 Thread Dov Murik
In order to enable kernel-hashes for SNP, pull it from SevGuestProperties to its parent SevCommonProperties so it will be available for both SEV and SNP. --- qapi/qom.json | 12 ++-- target/i386/sev.c | 44 ++-- 2 files changed, 24 insertions(+),

Re: Lost partition tables on ide-hd + ahci drive

2023-02-16 Thread Fiona Ebner
Am 15.02.23 um 22:47 schrieb John Snow: > Hm, I'm not sure I see any pattern that might help. Could be that AHCI > is just bugged during load, but it's tough to know in what way. If we ever get a backtrace where the bad write actually goes through QEMU, I'll let you know. We are considering provi

Re: [RFC PATCH v2 0/2] i386/sev: Support measured direct kernel boot on SNP

2023-02-16 Thread Dov Murik
On 16/02/2023 10:49, Dov Murik wrote: > This RFC patch series is based on AMD's RFC upmv10-snpv3 tree [1]. > Note that in order to test this you must use '-machine pc-q35-7.1' to circumvent the SETUP_RNG_SEED bug [1] that interferes with the measured kernel. [1] https://lore.kernel.org/qemu-d

[PATCH] hw/arm: Add missing ZynqMP ZCU102 -> USB_DWC3 Kconfig dependency

2023-02-16 Thread Philippe Mathieu-Daudé
Since commit acc0b8b05a when running the ZynqMP ZCU102 board with a QEMU configured using --without-default-devices, we get: $ qemu-system-aarch64 -M xlnx-zcu102 qemu-system-aarch64: missing object type 'usb_dwc3' Abort trap: 6 Fix by adding the missing Kconfig dependency. Fixes: acc0b8b05

Re: [RFC PATCH v2 1/2] qapi, i386: Move kernel-hashes to SevCommonProperties

2023-02-16 Thread Markus Armbruster
Dov Murik writes: > In order to enable kernel-hashes for SNP, pull it from > SevGuestProperties to its parent SevCommonProperties so > it will be available for both SEV and SNP. Missing Signed-off-by: Dov Murik Patch does not apply for me.

Re: [PATCH] hw/arm: Add missing ZynqMP ZCU102 -> USB_DWC3 Kconfig dependency

2023-02-16 Thread Philippe Mathieu-Daudé
Oops I meant this as subject: "hw/arm: Add missing XLNX_ZYNQMP_ARM -> USB_DWC3 Kconfig dependency" On 16/2/23 10:23, Philippe Mathieu-Daudé wrote: Since commit acc0b8b05a when running the ZynqMP ZCU102 board with a QEMU configured using --without-default-devices, we get: $ qemu-system-aarch6

Re: [PATCH v3 02/10] target/riscv: always allow write_misa() to write MISA

2023-02-16 Thread Andrew Jones
On Wed, Feb 15, 2023 at 03:57:18PM -0300, Daniel Henrique Barboza wrote: > At this moment, and apparently since ever, we have no way of enabling > RISCV_FEATURE_MISA. This means that all the code from write_misa(), all > the nuts and bolts that handles how to properly write this CSR, has > always b

Re: [RFC 12/52] hw/acpi: Replace MachineState.smp access with topology helpers

2023-02-16 Thread wangyanan (Y)
Hi Zhao, 在 2023/2/13 17:49, Zhao Liu 写道: From: Zhao Liu At present, in QEMU only arm needs PPTT table to build cpu topology. Before QEMU's arm supports hybrid architectures, it's enough to limit the cpu topology of PPTT to smp type through the explicit smp interface (machine_topo_get_smp_thre

Re: [RFC PATCH v2 1/2] qapi, i386: Move kernel-hashes to SevCommonProperties

2023-02-16 Thread Dov Murik
Hello Markus, On 16/02/2023 11:24, Markus Armbruster wrote: > Dov Murik writes: > >> In order to enable kernel-hashes for SNP, pull it from >> SevGuestProperties to its parent SevCommonProperties so >> it will be available for both SEV and SNP. > > Missing > > Signed-off-by: Dov Murik > O

Re: [PATCH v3 02/10] target/riscv: always allow write_misa() to write MISA

2023-02-16 Thread Bin Meng
On Thu, Feb 16, 2023 at 5:29 PM Andrew Jones wrote: > > On Wed, Feb 15, 2023 at 03:57:18PM -0300, Daniel Henrique Barboza wrote: > > At this moment, and apparently since ever, we have no way of enabling > > RISCV_FEATURE_MISA. This means that all the code from write_misa(), all > > the nuts and bo

Re: Does the page boundary check still necessary?

2023-02-16 Thread Kenneth Lee
On Wed, Feb 15, 2023 at 04:52:24PM -1000, Richard Henderson wrote: > Date: Wed, 15 Feb 2023 16:52:24 -1000 > From: Richard Henderson > To: Kenneth Lee > Cc: qemu-devel@nongnu.org > Subject: Re: Does the page boundary check still necessary? > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) G

Re: [PATCH v10 0/9] KVM: mm: fd-based approach for supporting KVM

2023-02-16 Thread David Hildenbrand
On 16.02.23 06:13, Mike Rapoport wrote: Hi, On Fri, Dec 02, 2022 at 02:13:38PM +0800, Chao Peng wrote: This patch series implements KVM guest private memory for confidential computing scenarios like Intel TDX[1]. If a TDX host accesses TDX-protected guest memory, machine check can happen which

Re: [PATCH] qemu: make version available in coredump

2023-02-16 Thread Daniel P . Berrangé
On Wed, Feb 15, 2023 at 05:05:47PM -0500, Stefan Hajnoczi wrote: > On Tue, 7 Jun 2022 at 16:33, Vladimir Sementsov-Ogievskiy > wrote: > > > > Add a variable with QEMU_FULL_VERSION definition. Then the content of > > the variable is easily searchable: > > > >strings /path/to/core | grep QEMU_FU

[RFC PATCH v11bis 23/26] hw/xen: Map guest XENSTORE_PFN grant in emulated Xenstore

2023-02-16 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_xenstore.c | 16 1 file changed, 16 insertions(+) diff --git a/hw/i386/kvm/xen_xenstore.c b/hw/i386/kvm/xen_xenstore.c index 74729cbb63..a58c89b555 100644 --- a/hw/i386/kvm/xen_xenstore.c +++ b/hw/i386/kv

[RFC PATCH v11bis 04/26] hw/xen: Implement XenStore transactions

2023-02-16 Thread David Woodhouse
From: David Woodhouse Given that the whole thing supported copy on write from the beginning, transactions end up being fairly simple. On starting a transaction, just take a ref of the existing root; swap it back in on a successful commit. The main tree has a transaction ID too, and we keep a rec

[RFC PATCH v11bis 24/26] hw/xen: Implement soft reset for emulated gnttab

2023-02-16 Thread David Woodhouse
From: David Woodhouse This is only part of it; we will also need to get the PV back end drivers to tear down their own mappings (or do it for them, but they kind of need to stop using the pointers too). Some more work on the actual PV back ends and xen-bus code is going to be needed to really ma

[RFC PATCH v11bis 06/26] xenstore perms WIP

2023-02-16 Thread David Woodhouse
From: Paul Durrant Store perms as a GList of strings, check permissions. No unit tests yet. Signed-off-by: Paul Durrant Signed-off-by: David Woodhoues --- hw/i386/kvm/xen_xenstore.c | 2 +- hw/i386/kvm/xenstore_impl.c | 239 +--- hw/i386/kvm/xenstore_impl.h

[RFC PATCH v11bis 25/26] hw/xen: Subsume xen_be_register_common() into xen_be_init()

2023-02-16 Thread David Woodhouse
From: David Woodhouse Every caller of xen_be_init() checks and exits on error, then calls xen_be_register_common(). Just make xen_be_init() abort for itself and return void, and register the common devices too. Signed-off-by: David Woodhouse --- hw/xen/xen-hvm-common.c | 18 +--

[RFC PATCH v11bis 20/26] hw/xen: Hook up emulated implementation for event channel operations

2023-02-16 Thread David Woodhouse
From: David Woodhouse We provided the backend-facing evtchn functions very early on as part of the core Xen platform support, since things like timers and xenstore need to use them. By what may or may not be an astonishing coincidence, those functions just *happen* all to have exactly the right

[RFC PATCH v11bis 08/26] hw/xen: Create initial XenStore nodes

2023-02-16 Thread David Woodhouse
From: Paul Durrant Signed-off-by: Paul Durrant Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_xenstore.c | 70 ++ 1 file changed, 70 insertions(+) diff --git a/hw/i386/kvm/xen_xenstore.c b/hw/i386/kvm/xen_xenstore.c index d15eea76c4..ff39137846 100644 -

[RFC PATCH v11bis 02/26] hw/xen: Add basic XenStore tree walk and write/read/directory support

2023-02-16 Thread David Woodhouse
From: David Woodhouse This is a fairly simple implementation of a copy-on-write tree. The node walk function starts off at the root, with 'inplace == true'. If it ever encounters a node with a refcount greater than one (including the root node), then that node is shared with other trees, and can

[RFC PATCH v11bis 12/26] hw/xen: Add foreignmem operations to allow redirection to internal emulation

2023-02-16 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Signed-off-by: Paul Durrant --- hw/char/xen_console.c| 8 ++-- hw/display/xenfb.c | 20 +- hw/xen/xen-operations.c | 63 include/hw/xen/xen_backend_ops.h | 26 +

[RFC PATCH v11bis 03/26] hw/xen: Implement XenStore watches

2023-02-16 Thread David Woodhouse
From: David Woodhouse Starts out fairly simple: a hash table of watches based on the path. Except there can be multiple watches on the same path, so the watch ends up being a simple linked list, and the head of that list is in the hash table. Which makes removal a bit of a PITA but it's not so b

[RFC PATCH v11bis 21/26] hw/xen: Add emulated implementation of grant table operations

2023-02-16 Thread David Woodhouse
From: David Woodhouse This is limited to mapping a single grant at a time, because under Xen the pages are mapped *contiguously* into qemu's address space, and that's very hard to do when those pages actually come from anonymous mappings in qemu in the first place. Eventually perhaps we can look

[RFC PATCH v11bis 16/26] hw/xen: Rename xen_common.h to xen_native.h

2023-02-16 Thread David Woodhouse
From: David Woodhouse This header is now only for native Xen code, not PV backends that may be used in Xen emulation. Since the toolstack libraries may depend on the specific version of Xen headers that they pull in (and will set the __XEN_TOOLS__ macro to enable internal definitions that they de

[RFC PATCH v11bis 14/26] hw/xen: Move xenstore_store_pv_console_info to xen_console.c

2023-02-16 Thread David Woodhouse
From: David Woodhouse There's no need for this to be in the Xen accel code, and as we want to use the Xen console support with KVM-emulated Xen we'll want to have a platform-agnostic version of it. Make it use GString to build up the path while we're at it. Signed-off-by: David Woodhouse --- a

[RFC PATCH v11bis 26/26] i386/xen: Initialize Xen backends from pc_basic_device_init() for emulation

2023-02-16 Thread David Woodhouse
From: David Woodhouse Now that all the work is done to enable the PV backends to work without actual Xen, instantiate the bus from pc_basic_device_init() for emulated mode. This allows us finally to launch an emulated Xen guest with PV disk. qemu-system-x86_64 -serial mon:stdio -M q35 -cpu h

[RFC PATCH v11bis 01/26] hw/xen: Add xenstore wire implementation and implementation stubs

2023-02-16 Thread David Woodhouse
From: David Woodhouse This implements the basic wire protocol for the XenStore commands, punting all the actual implementation to xs_impl_* functions which all just return errors for now. Signed-off-by: David Woodhouse --- hw/i386/kvm/meson.build | 1 + hw/i386/kvm/trace-events| 15

[RFC PATCH v11bis 19/26] hw/xen: Only advertise ring-page-order for xen-block if gnttab supports it

2023-02-16 Thread David Woodhouse
From: David Woodhouse Whem emulating Xen, multi-page grants are distinctly non-trivial and we have elected not to support them for the time being. Don't advertise them to the guest. Signed-off-by: David Woodhouse --- hw/block/xen-block.c | 11 --- 1 file changed, 8 insertions(+), 3 del

[RFC PATCH v11bis 00/26] Emulated XenStore and PV backend support

2023-02-16 Thread David Woodhouse
The non-RFC patch submisson¹ is just the basic platform support for Xen on KVM. This RFC series is phase 2, adding an internal XenStore and hooking up the PV back end drivers to that and the emulated grant tables and event channels. With this, we can boot a Xen guest with PV disk, under KVM. Full

[RFC PATCH v11bis 07/26] hw/xen: Implement core serialize/deserialize methods for xenstore_impl

2023-02-16 Thread David Woodhouse
From: David Woodhouse In fact I think we want to only serialize the contents of the domain's path in /local/domain/${domid} and leave the rest to be recreated? Will defer to Paul for that. Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_xenstore.c | 25 +- hw/i386/kvm/xenstore_impl.c | 53

[RFC PATCH v11bis 09/26] hw/xen: Add evtchn operations to allow redirection to internal emulation

2023-02-16 Thread David Woodhouse
From: David Woodhouse The existing implementation calling into the real libxenevtchn moves to a new file hw/xen/xen-operations.c, and is called via a function table which in a subsequent commit will also be able to invoke the emulated event channel support. Signed-off-by: David Woodhouse Signed

[RFC PATCH v11bis 18/26] hw/xen: Avoid crash when backend watch fires too early

2023-02-16 Thread David Woodhouse
From: Paul Durrant The xen-block code ends up calling aio_poll() through blkconf_geometry(), which means we see watch events during the indirect call to xendev_class->realize() in xen_device_realize(). Unfortunately this call is made before populating the initial frontend and backend device nodes

[RFC PATCH v11bis 22/26] hw/xen: Add emulated implementation of XenStore operations

2023-02-16 Thread David Woodhouse
From: David Woodhouse Now that we have an internal implementation of XenStore, we can populate the xenstore_backend_ops to allow PV backends to talk to it. Watches can't be processed with immediate callbacks because that would call back into XenBus code recursively. Defer them to a QEMUBH to be

[RFC PATCH v11bis 10/26] hw/xen: Add gnttab operations to allow redirection to internal emulation

2023-02-16 Thread David Woodhouse
From: David Woodhouse Move the existing code using libxengnttab to xen-operations.c and allow the operations to be redirected so that we can add emulation of grant table mapping for backend drivers. In emulation, mapping more than one grant ref to be virtually contiguous would be fairly difficul

[RFC PATCH v11bis 13/26] hw/xen: Add xenstore operations to allow redirection to internal emulation

2023-02-16 Thread David Woodhouse
From: Paul Durrant Signed-off-by: Paul Durrant Signed-off-by: David Woodhouse --- accel/xen/xen-all.c | 11 +- hw/char/xen_console.c | 2 +- hw/i386/kvm/xen_xenstore.c | 3 - hw/i386/kvm/xenstore_impl.h | 8 +- hw/xen/xen-bus-helper.c

[RFC PATCH v11bis 05/26] hw/xen: Watches on XenStore transactions

2023-02-16 Thread David Woodhouse
From: David Woodhouse Firing watches on the nodes that still exist is relatively easy; just walk the tree and look at the nodes with refcount of one. Firing watches on *deleted* nodes is more fun. We add 'modified_in_tx' and 'deleted_in_tx' flags to each node. Nodes with those flags cannot be sh

[RFC PATCH v11bis 17/26] hw/xen: Build PV backend drivers for CONFIG_XEN_BUS

2023-02-16 Thread David Woodhouse
From: David Woodhouse Now that we have the redirectable Xen backend operations we can build the PV backends even without the Xen libraries. Signed-off-by: David Woodhouse --- hw/9pfs/meson.build| 2 +- hw/block/dataplane/meson.build | 2 +- hw/block/meson.build | 2 +- hw

[RFC PATCH v11bis 11/26] hw/xen: Pass grant ref to gnttab unmap operation

2023-02-16 Thread David Woodhouse
From: David Woodhouse The previous commit introduced redirectable gnttab operations fairly much like-for-like, with the exception of the extra arguments to the ->open() call which were always NULL/0 anyway. This *changes* the arguments to the ->unmap() operation to include the original ref# that

[RFC PATCH v11bis 15/26] hw/xen: Use XEN_PAGE_SIZE in PV backend drivers

2023-02-16 Thread David Woodhouse
From: David Woodhouse XC_PAGE_SIZE comes from the actual Xen libraries, while XEN_PAGE_SIZE is provided by QEMU itself in xen_backend_ops.h. For backends which may be built for emulation mode, use the latter. Signed-off-by: David Woodhouse --- hw/block/dataplane/xen-block.c | 8 hw/d

Re: [PATCH v10 1/9] mm: Introduce memfd_restricted system call to create restricted user memory

2023-02-16 Thread Nikunj A. Dadhania
> +static struct file *restrictedmem_file_create(struct file *memfd) > +{ > + struct restrictedmem_data *data; > + struct address_space *mapping; > + struct inode *inode; > + struct file *file; > + > + data = kzalloc(sizeof(*data), GFP_KERNEL); > + if (!data) > +

Re: [RFC PATCH 1/2] mm: restrictedmem: Allow userspace to specify mount_path for memfd_restricted

2023-02-16 Thread Kirill A. Shutemov
On Thu, Feb 16, 2023 at 12:41:16AM +, Ackerley Tng wrote: > By default, the backing shmem file for a restrictedmem fd is created > on shmem's kernel space mount. > > With this patch, an optional tmpfs mount can be specified, which will > be used as the mountpoint for backing the shmem file ass

Re: [PATCH v3 02/10] target/riscv: always allow write_misa() to write MISA

2023-02-16 Thread Andrew Jones
On Thu, Feb 16, 2023 at 05:33:55PM +0800, Bin Meng wrote: > On Thu, Feb 16, 2023 at 5:29 PM Andrew Jones wrote: > > > > On Wed, Feb 15, 2023 at 03:57:18PM -0300, Daniel Henrique Barboza wrote: > > > At this moment, and apparently since ever, we have no way of enabling > > > RISCV_FEATURE_MISA. Thi

Re: [PATCH v2 0/7] Python: Drop support for Python 3.6

2023-02-16 Thread Peter Maydell
On Wed, 15 Feb 2023 at 19:05, Markus Armbruster wrote: > > The discussion under PATCH 6 makes me think there's a bit of confusion > about the actual impact of dropping support for Python 3.6. Possibly > because it's spelled out in the commit message of PATCH 7. Let me > summarize it in one sente

Re: [RFC PATCH 12/16] hw/arm/smmuv3: Add VMID to tlb tagging

2023-02-16 Thread Eric Auger
Hi, On 2/5/23 10:44, Mostafa Saleh wrote: > Allow TLB to be tagged with VMID. > > If stage-1 is only supported, VMID is set to -1 and ignored from STE > and CMD_TLBI_NH* cmds. > > Signed-off-by: Mostafa Saleh > --- > hw/arm/smmu-common.c | 24 +++- > hw/arm/smmu-inter

Re: Detecting qemu from guest on arm/hvf (apple arm)

2023-02-16 Thread Peter Maydell
On Thu, 16 Feb 2023 at 02:05, John-Mark Gurney wrote: > > Hello, > > I was wondering what the best way to detect that FreeBSD is running > under qemu/hvf on Apple ARM? FreeBSD doesn't see the ACPI FADT table, > so I'm wondering if keying off of something like the QEMU0002 device > in ACPI is the

Re: Future of icount discussion for next KVM call?

2023-02-16 Thread Alex Bennée
(replying all because qemu-devel rejected my email again) On Thu, 16 Feb 2023 at 10:19, Alex Bennée wrote: > Hi Juan, > > Do we have an agenda for next weeks KVM call yet? If there is space I'd > like to take some time to discuss the future direction of icount. > > Specifically I believe there m

Re: [RFC PATCH v2 0/2] i386/sev: Support measured direct kernel boot on SNP

2023-02-16 Thread Daniel P . Berrangé
On Thu, Feb 16, 2023 at 08:49:11AM +, Dov Murik wrote: > This RFC patch series is based on AMD's RFC upmv10-snpv3 tree [1]. I've seen postings of the kernel patches for SNP using the kernel UPM support, but I don't recall ever seeing these QEMU pieces posted for review. The code in that QEMU b

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-16 Thread Michael Tokarev
15.02.2023 14:26, Daniel P. Berrangé пишет: .. - choices: ['alsa', 'coreaudio', 'default', 'dsound', 'jack', 'oss', 'pa', 'sdl', 'sndio'], + choices: ['alsa', 'coreaudio', 'default', 'dsound', 'jack', 'oss', 'pa', 'pw', 'sdl', 'sndio'], I appreciate you probably just followed the

Re: [PATCH v2 6/7] CI: Stop building docs on centos8

2023-02-16 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Feb 14, 2023 at 08:40:20AM +0100, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> [...] >> >> > We don't have to drop python 3.6. It is a choice because >> > of a desire to be able to use some shiny new python >> > features without caring about

Re: [RFC 23/52] arm: Replace MachineState.smp access with topology helpers

2023-02-16 Thread wangyanan (Y)
在 2023/2/13 17:50, Zhao Liu 写道: From: Zhao Liu When MachineState.topo is introduced, the topology related structures become complicated. So we wrapped the access to topology fields of MachineState.topo into some helpers, and we are using these helpers to replace the use of MachineState.smp. Be

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-16 Thread Daniel P . Berrangé
On Thu, Feb 16, 2023 at 01:33:47PM +0300, Michael Tokarev wrote: > 15.02.2023 14:26, Daniel P. Berrangé пишет: > .. > > > - choices: ['alsa', 'coreaudio', 'default', 'dsound', 'jack', > > > 'oss', 'pa', 'sdl', 'sndio'], > > > + choices: ['alsa', 'coreaudio', 'default', 'dsound', 'jack'

[PATCH] Adding new machine Yosemitev2 in QEMU

2023-02-16 Thread Karthikeyan Pasupathi
Signed-off-by: Karthikeyan Pasupathi --- hw/arm/aspeed.c| 38 ++ hw/arm/aspeed_eeprom.c | 23 +++ hw/arm/aspeed_eeprom.h | 3 +++ 3 files changed, 64 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 27dda58338..35

Re: [RFC PATCH v11bis 00/26] Emulated XenStore and PV backend support

2023-02-16 Thread Juan Quintela
David Woodhouse wrote: > The non-RFC patch submisson¹ is just the basic platform support for Xen > on KVM. This RFC series is phase 2, adding an internal XenStore and > hooking up the PV back end drivers to that and the emulated grant tables > and event channels. > > With this, we can boot a Xen g

[PATCH v2] Adding new machine Yosemitev2 in QEMU

2023-02-16 Thread Karthikeyan Pasupathi
This patch support Yosemitev2 in QEMU environment. and introduced EEPROM BMC FRU data support "add fbyv2_bmc_fruid data" along with the machine support. Signed-off-by: Karthikeyan Pasupathi --- hw/arm/aspeed.c| 38 ++ hw/arm/aspeed_eeprom.c | 23 ++

Re: [PATCH 1/1] block: improve error logging in bdrv_reopen_prepare()

2023-02-16 Thread Kevin Wolf
Am 13.02.2023 um 11:31 hat Denis V. Lunev geschrieben: > The error generated when the option could not be changed inside > bdrv_reopen_prepare() does not give a clue about problematic > BlockDriverState as we could get very long tree of devices. > > The patch adds node name to the error report in

Re: Future of icount discussion for next KVM call?

2023-02-16 Thread Juan Quintela
Alex Bennée wrote: > (replying all because qemu-devel rejected my email again) > > On Thu, 16 Feb 2023 at 10:19, Alex Bennée wrote: > >> Hi Juan, >> >> Do we have an agenda for next weeks KVM call yet? If there is space I'd >> like to take some time to discuss the future direction of icount. For

Re: [PATCH v2 0/7] Python: Drop support for Python 3.6

2023-02-16 Thread Thomas Huth
On 15/02/2023 20.05, Markus Armbruster wrote: The discussion under PATCH 6 makes me think there's a bit of confusion about the actual impact of dropping support for Python 3.6. Possibly because it's spelled out in the commit message of PATCH 7. Let me summarize it in one sentence: *** All

Re: [PATCH] hbitmap: fix hbitmap_status() return value for first dirty bit case

2023-02-16 Thread Kevin Wolf
Am 02.02.2023 um 19:15 hat Andrey Zhadchenko via geschrieben: > The last return statement should return true, as we already evaluated that > start == next_dirty > > Also, fix hbitmap_status() description in header > > Cc: qemu-sta...@nongnu.org > Fixes: a6426475a75 ("block/dirty-bitmap: introduce

Re: [PATCH v6 3/3] multifd: Only flush once each full round of memory

2023-02-16 Thread Juan Quintela
Peter Xu wrote: > On Wed, Feb 15, 2023 at 07:02:31PM +0100, Juan Quintela wrote: >> We need to add a new flag to mean to flush at that point. >> Notice that we still flush at the end of setup and at the end of >> complete stages. >> >> Signed-off-by: Juan Quintela > > Acked-by: Peter Xu > > One

Re: [PATCH v2 6/7] CI: Stop building docs on centos8

2023-02-16 Thread Daniel P . Berrangé
On Thu, Feb 16, 2023 at 02:08:33AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > Our support policy is written from the POV of the C world, and > > merely reducing the length of time we support a distro does not > > address the different world view of Python. > > > > Should we i

Re: [PATCH v2 6/7] CI: Stop building docs on centos8

2023-02-16 Thread Daniel P . Berrangé
On Thu, Feb 16, 2023 at 02:46:18AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, Feb 14, 2023 at 09:52:44PM +0100, Paolo Bonzini wrote: > >> Il mar 14 feb 2023, 18:26 Kevin Wolf ha scritto: > >> > >> > Am 14.02.2023 um 15:03 hat Paolo Bonzini geschrieben: > >> > > I

Re: [PATCH] Adding new machine Yosemitev2 in QEMU

2023-02-16 Thread Philippe Mathieu-Daudé
Hi Pasupathi, On 16/2/23 11:48, Karthikeyan Pasupathi wrote: Signed-off-by: Karthikeyan Pasupathi --- hw/arm/aspeed.c| 38 ++ hw/arm/aspeed_eeprom.c | 23 +++ hw/arm/aspeed_eeprom.h | 3 +++ 3 files changed, 64 insertions(+)

Re: [RFC PATCH v2 0/2] i386/sev: Support measured direct kernel boot on SNP

2023-02-16 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Thu, Feb 16, 2023 at 08:49:11AM +, Dov Murik wrote: > > This RFC patch series is based on AMD's RFC upmv10-snpv3 tree [1]. > > I've seen postings of the kernel patches for SNP using the kernel > UPM support, but I don't recall ever seeing

Re: [PATCH v2 6/7] CI: Stop building docs on centos8

2023-02-16 Thread Daniel P . Berrangé
On Tue, Feb 14, 2023 at 03:03:54PM +0100, Paolo Bonzini wrote: > On Tue, Feb 14, 2023 at 12:49 PM Daniel P. Berrangé > wrote: > > [quote] > > The motivation for this series is that Python 3.6 was EOL at the end of > > 2021; upstream tools are beginning to drop support for it, including > > setupt

Re: [PATCH v6 0/4] memory: prevent dma-reentracy issues

2023-02-16 Thread Thomas Huth
On 13/02/2023 03.11, Alexander Bulekov wrote: ping I think it would be really good to finally get these dma-reentrancy issues fixed! Who's supposed to pick up these patches? Paolo? David? Peter? Thomas On 230204 2307, Alexander Bulekov wrote: These patches aim to solve two types of DMA-

Re: [PULL 0/5] Misc next patches

2023-02-16 Thread Peter Maydell
On Wed, 15 Feb 2023 at 17:48, Daniel P. Berrangé wrote: > > The following changes since commit 6a50f64ca01d0a7b97f14f069762bfd88160f31e: > > Merge tag 'pull-request-2023-02-14' of https://gitlab.com/thuth/qemu into > staging (2023-02-14 14:46:10 +) > > are available in the Git repository at

Re: [PATCH v3 01/14] hw/char/serial-pci: Replace DO_UPCAST(PCISerialState) by PCI_SERIAL()

2023-02-16 Thread Thomas Huth
On 13/02/2023 19.43, Philippe Mathieu-Daudé wrote: Use the PCI_SERIAL() QOM type-checking macro to avoid DO_UPCAST(). Signed-off-by: Philippe Mathieu-Daudé --- hw/char/serial-pci.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/char/serial-pci.c b/hw/char/seria

Re: [PATCH] qemu: make version available in coredump

2023-02-16 Thread Vladimir Sementsov-Ogievskiy
On 16.02.23 12:44, Daniel P. Berrangé wrote: On Wed, Feb 15, 2023 at 05:05:47PM -0500, Stefan Hajnoczi wrote: On Tue, 7 Jun 2022 at 16:33, Vladimir Sementsov-Ogievskiy wrote: Add a variable with QEMU_FULL_VERSION definition. Then the content of the variable is easily searchable: strings

Re: [RFC PATCH 10/16] hw/arm/smmuv3: Make TLB lookup work for stage-2

2023-02-16 Thread Eric Auger
Hi Mostafa, On 2/5/23 10:44, Mostafa Saleh wrote: > Right now, either stage-1 or stage-2 are supported, this simplifies > how we can deal with TLBs. > This patch makes TLB lookup work if stage-2 is enabled instead of > stage-1. > TLB lookup is done before a PTW, if a valid entry is found we won't

Re: [PATCH] hw/arm: Add missing ZynqMP ZCU102 -> USB_DWC3 Kconfig dependency

2023-02-16 Thread Peter Maydell
On Thu, 16 Feb 2023 at 09:27, Philippe Mathieu-Daudé wrote: > > Oops I meant this as subject: > "hw/arm: Add missing XLNX_ZYNQMP_ARM -> USB_DWC3 Kconfig dependency" > > On 16/2/23 10:23, Philippe Mathieu-Daudé wrote: > > Since commit acc0b8b05a when running the ZynqMP ZCU102 board with > > a QEMU

Re: [PATCH v5 0/3] arm: enable MTE for QEMU + kvm

2023-02-16 Thread Peter Maydell
On Fri, 3 Feb 2023 at 13:44, Cornelia Huck wrote: > > Respin of my kvm mte series; tested via check + check-tcg and on FVP. I've taken patch 1 into target-arm.next since it's a simple cleanup. thanks -- PMM

Re: [PATCH v2] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-16 Thread Christian Schoenebeck
On Thursday, February 16, 2023 9:25:44 AM CET Dorinda Bassey wrote: > This commit adds a new audiodev backend to allow QEMU to use Pipewire as both > an audio sink and source. > Please wrap commit log. > Signed-off-by: Dorinda Bassey > --- > v2: > * Shorten commit message > * fix copyright own

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-16 Thread Gerd Hoffmann
On Wed, Feb 15, 2023 at 04:09:59PM +0100, Dorinda Bassey wrote: > > > > My point is that pipewire has ALSA plugin (and also pulseaudio compat > > library etc). So why add another back in QEMU? > > > Good question. Well the pulseaudio compatibility layer adds to the runtime > overhead and dependency

Re: [PATCH v5 0/3] arm: enable MTE for QEMU + kvm

2023-02-16 Thread Cornelia Huck
On Thu, Feb 16 2023, Peter Maydell wrote: > On Fri, 3 Feb 2023 at 13:44, Cornelia Huck wrote: >> >> Respin of my kvm mte series; tested via check + check-tcg and on FVP. > > I've taken patch 1 into target-arm.next since it's a simple > cleanup. Thanks! (I plan to send a respin of the remainder

[PATCH v1 0/2] vhost: memslot handling improvements

2023-02-16 Thread David Hildenbrand
Following up on my previous work to make virtio-mem consume multiple memslots dynamically [1] that requires precise accounting between used vs. reserved memslots, I realized that vhost makes this extra hard by filtering out some memory region sections (so they don't consume a memslot) in the vhost-

[PATCH v1 2/2] vhost: Remove vhost_backend_can_merge() callback

2023-02-16 Thread David Hildenbrand
Checking whether the memory regions are equal is sufficient: if they are equal, then most certainly the contained fd is equal. The whole vhost-user memslot handling is suboptimal and overly complicated. We shouldn't have to lookup a RAM memory regions we got notified about in vhost_user_get_mr_dat

[PATCH v1 1/2] vhost: Defer filtering memory sections until building the vhost memory structure

2023-02-16 Thread David Hildenbrand
Having multiple devices, some filtering memslots and some not filtering memslots, messes up the "used_memslot" accounting. If we'd have a device the filters out less memory sections after a device that filters out more, we'd be in trouble, because our memslot checks stop working reliably. For examp

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-16 Thread Christian Schoenebeck
On Wednesday, February 15, 2023 4:59:47 PM CET Daniel P. Berrangé wrote: > On Wed, Feb 15, 2023 at 05:18:50PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey wrote: > > > > > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as

Re: [RFC PATCH 13/16] hw/arm/smmuv3: Add CMDs related to stage 2

2023-02-16 Thread Eric Auger
Hi Mostafa, On 2/5/23 10:44, Mostafa Saleh wrote: > CMD_TLBI_S2_IPA: As S1+S2 is not enabled, for now this can be the > same as CMD_TLBI_NH_VAA. > > CMD_TLBI_S12_VMALL: Added new function to invalidate TLB by VMID. > > Signed-off-by: Mostafa Saleh > --- > hw/arm/smmu-common.c | 16 ++

Re: [PATCH] qemu: make version available in coredump

2023-02-16 Thread Daniel P . Berrangé
On Thu, Feb 16, 2023 at 02:30:16PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 16.02.23 12:44, Daniel P. Berrangé wrote: > > On Wed, Feb 15, 2023 at 05:05:47PM -0500, Stefan Hajnoczi wrote: > > > On Tue, 7 Jun 2022 at 16:33, Vladimir Sementsov-Ogievskiy > > > wrote: > > > > > > > > Add a vari

Re: [PATCH v1 1/2] vhost: Defer filtering memory sections until building the vhost memory structure

2023-02-16 Thread Michael S. Tsirkin
On Thu, Feb 16, 2023 at 12:47:51PM +0100, David Hildenbrand wrote: > Having multiple devices, some filtering memslots and some not filtering > memslots, messes up the "used_memslot" accounting. If we'd have a device > the filters out less memory sections after a device that filters out more, > we'd

Re: [PATCH v1 1/2] vhost: Defer filtering memory sections until building the vhost memory structure

2023-02-16 Thread David Hildenbrand
On 16.02.23 13:04, Michael S. Tsirkin wrote: On Thu, Feb 16, 2023 at 12:47:51PM +0100, David Hildenbrand wrote: Having multiple devices, some filtering memslots and some not filtering memslots, messes up the "used_memslot" accounting. If we'd have a device the filters out less memory sections af

Re: [PATCH v1 1/2] vhost: Defer filtering memory sections until building the vhost memory structure

2023-02-16 Thread David Hildenbrand
On 16.02.23 13:10, David Hildenbrand wrote: On 16.02.23 13:04, Michael S. Tsirkin wrote: On Thu, Feb 16, 2023 at 12:47:51PM +0100, David Hildenbrand wrote: Having multiple devices, some filtering memslots and some not filtering memslots, messes up the "used_memslot" accounting. If we'd have a d

Re: [RFC PATCH v2 1/2] qapi, i386: Move kernel-hashes to SevCommonProperties

2023-02-16 Thread Markus Armbruster
Dov Murik writes: > Hello Markus, > > On 16/02/2023 11:24, Markus Armbruster wrote: >> Dov Murik writes: >> >>> In order to enable kernel-hashes for SNP, pull it from >>> SevGuestProperties to its parent SevCommonProperties so >>> it will be available for both SEV and SNP. >> >> Missing >> >>

  1   2   3   4   5   6   >