[PULL 20/32] RISC-V: Adding XTheadCondMov ISA extension

2023-02-06 Thread Alistair Francis
From: Christoph Müllner This patch adds support for the XTheadCondMov ISA extension. The patch uses the T-Head specific decoder and translation. Co-developed-by: LIU Zhiwei Reviewed-by: Alistair Francis Signed-off-by: Christoph Müllner Message-Id: <20230131202013.2541053-7-christoph.muell...@

[PULL 29/32] target/riscv: fix for virtual instr exception

2023-02-06 Thread Alistair Francis
From: Deepak Gupta commit fb3f3730e4 added mechanism to generate virtual instruction exception during instruction decode when virt is enabled. However in some situations, illegal instruction exception can be raised due to state of CPU. One such situation is implementing branch tracking. [1] An i

[PULL 25/32] RISC-V: Set minimum priv version for Zfh to 1.11

2023-02-06 Thread Alistair Francis
From: Christoph Müllner There are no differences for floating point instructions in priv version 1.11 and 1.12. There is also no dependency for Zfh to priv version 1.12. Therefore allow Zfh to be enabled for priv version 1.11. Acked-by: Alistair Francis Signed-off-by: Christoph Müllner Message

Re: [PATCH 3/3] hw/arm: Attach PSPI module to NPCM7XX SoC

2023-02-06 Thread Philippe Mathieu-Daudé
On 7/2/23 00:34, Hao Wu wrote: Signed-off-by: Hao Wu Reviewed-by: Titus Rwantare --- docs/system/arm/nuvoton.rst | 2 +- hw/arm/npcm7xx.c| 25 +++-- include/hw/arm/npcm7xx.h| 2 ++ 3 files changed, 26 insertions(+), 3 deletions(-) Reviewed-by: Philip

[PULL 32/32] hw/riscv: virt: Simplify virt_{get,set}_aclint()

2023-02-06 Thread Alistair Francis
From: Bin Meng There is no need to declare an intermediate "MachineState *ms". Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-Id: <20230206085007.3618715-1-bm...@tinylab.org> Signed-off-by: Alistair Francis --- hw/riscv/virt.c | 6 ++ 1

Re: [PATCH 1/1] hw/core/cpu: always print cpu index with cpu state

2023-02-06 Thread Philippe Mathieu-Daudé
On 7/2/23 00:42, Dongli Zhang wrote: The cpu_dump_state() does not print the cpu index. When the cpu_dump_state() is invoked due to the KVM failure, we are not able to tell from which CPU the state is. The below is an example. KVM internal error. Suberror: 764064 RAX=0002 RBX=8a9

[PULL 31/32] target/riscv: fix SBI getchar handler for KVM

2023-02-06 Thread Alistair Francis
From: Vladimir Isaev Character must be returned via ret[0] field (copied to a0 by KVM). Return value should be set to 0 to indicate successful processing. Signed-off-by: Vladimir Isaev Reviewed-by: Alistair Francis Message-Id: <20230203135155.12449-1-vladimir.is...@syntacore.com> Signed-off-b

Re: [PATCH 2/3] hw/ssi: Add Nuvoton PSPI Module

2023-02-06 Thread Philippe Mathieu-Daudé
On 7/2/23 00:34, Hao Wu wrote: Nuvoton's PSPI is a general purpose SPI module which enables connections to SPI-based peripheral devices. Signed-off-by: Hao Wu Reviewed-by: Chris Rauer --- MAINTAINERS| 6 +- hw/ssi/meson.build | 2 +- hw/ssi/npcm_pspi.c |

[PATCH 10/12] hw/core: Improve the query-hotpluggable-cpus error message

2023-02-06 Thread Markus Armbruster
The QERR_ macros are leftovers from the days of "rich" error objects. We've been trying to reduce their remaining use. Get rid of a use of QERR_FEATURE_DISABLED, and improve the slightly awkward error message (qemu) info hotpluggable-cpus Error: The feature 'query-hotpluggable-cpus' is no

[PATCH 11/12] migration/colo: Improve an x-colo-lost-heartbeat error message

2023-02-06 Thread Markus Armbruster
The QERR_ macros are leftovers from the days of "rich" error objects. We've been trying to reduce their remaining use. Get rid of a use of QERR_FEATURE_DISABLED, and improve the somewhat imprecise error message (qemu) x_colo_lost_heartbeat Error: The feature 'colo' is not enabled to

[PATCH 04/12] hw/core: Improve error message when machine doesn't provide NMIs

2023-02-06 Thread Markus Armbruster
The QERR_ macros are leftovers from the days of "rich" error objects. We've been trying to reduce their remaining use. Get rid of a use of QERR_UNSUPPORTED, and improve the rather vague error message (qemu) nmi Error: this feature or command is not currently supported to Error: mach

[PATCH 07/12] hw/acpi: Move QMP command to hw/core/

2023-02-06 Thread Markus Armbruster
The QERR_ macros are leftovers from the days of "rich" error objects. We've been trying to reduce their remaining use. qmp_query_vm_generation_id() in stubs/vmgenid.c is the last user of QERR_UNSUPPORTED outside qga/. Unlike the stubs we just dropped, it is actually reachable, namely when CONFIG_

[PATCH 06/12] hw/acpi: Dumb down acpi_table_add() stub

2023-02-06 Thread Markus Armbruster
The QERR_ macros are leftovers from the days of "rich" error objects. We've been trying to reduce their remaining use. acpi_table_add() is only ever called on behalf of CLI option -acpitable. Since qemu-options.hx sets @arch_mask to QEMU_ARCH_I386, it is reachable only for these targets. Since t

[PATCH 09/12] replay: Simplify setting replay blockers

2023-02-06 Thread Markus Armbruster
replay_add_blocker() takes an Error *. All callers pass one created like this: error_setg(&blocker, QERR_REPLAY_NOT_SUPPORTED, "some feature"); Folding this into replay_add_blocker() simplifies the callers, losing a bit of generality we haven't needed in more than six years. Since there are

[PATCH 00/12] error: Reduce qerror.h usage a bit more

2023-02-06 Thread Markus Armbruster
This series gets rid of two out of 15 remaining QERR_ macros and confines use of one more to qga/. Bonus: better error messages. Markus Armbruster (12): error: Drop superfluous #include "qapi/qmp/qerror.h" dump: Improve error message when target doesn't support memory dump dump: Assert cpu_

[PATCH 12/12] rocker: Tweak stubbed out monitor commands' error messages

2023-02-06 Thread Markus Armbruster
The QERR_ macros are leftovers from the days of "rich" error objects. We've been trying to reduce their remaining use. The stubbed out Rocker monitor commands are the last remaining users of QERR_FEATURE_DISABLED. They fail like this: (qemu) info rocker mumble Error: The feature 'rocker'

[PATCH 02/12] dump: Improve error message when target doesn't support memory dump

2023-02-06 Thread Markus Armbruster
The QERR_ macros are leftovers from the days of "rich" error objects. We've been trying to reduce their remaining use. Get rid of a use of QERR_UNSUPPORTED, and improve the rather vague error message (qemu) dump-guest-memory mumble Error: this feature or command is not currently supported

[PATCH 01/12] error: Drop superfluous #include "qapi/qmp/qerror.h"

2023-02-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- authz/listfile.c | 1 - backends/cryptodev-vhost.c | 1 - backends/rng.c | 1 - backends/vhost-user.c | 1 - block/backup.c | 1 - block/commit.c | 1 - block/mirror.c |

[PATCH 08/12] qga: Drop dangling reference to QERR_QGA_LOGGING_DISABLED

2023-02-06 Thread Markus Armbruster
slog()'s function comment advises to use QERR_QGA_LOGGING_DISABLED. This macro never existed. The reference got added in commit e3d4d25206a "guest agent: add guest agent RPCs/commands" along with QERR_QGA_LOGGING_FAILED, so maybe that one was meant. However, QERR_QGA_LOGGING_FAILED was never actu

[PATCH 03/12] dump: Assert cpu_get_note_size() can't fail

2023-02-06 Thread Markus Armbruster
The only way cpu_get_note_size() can return a negative value is integer overflow in the non-stub versions, which is a programming error. The stub version is not actually reachable, because the cpu_get_dump_info() stub will fail first. Use assert(). This gets rid of another use of QERR_UNSUPPORTE

[PATCH 05/12] hw/smbios: Dumb down smbios_entry_add() stub

2023-02-06 Thread Markus Armbruster
The QERR_ macros are leftovers from the days of "rich" error objects. We've been trying to reduce their remaining use. smbios_entry_add() is only ever called on behalf of CLI option -smbios. Since qemu-options.hx sets @arch_mask to QEMU_ARCH_I386 | QEMU_ARCH_ARM, it is reachable only for these ta

<    1   2   3   4   5