Re: [PATCH v5 3/3] qtests/arm: add some mte tests

Hi, On 2/3/23 14:44, Cornelia Huck wrote: > Acked-by: Thomas Huth > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Cornelia Huck Still as you need to respin I think adding a short commit msg wouldn't hurt ;-) Add new cpu MTE feature tests with TCG+virt tag memory and TCG-no tag memory (d

[PATCH] MAINTAINERS: Mark IDE and Floppy as "Odd Fixes"

I have not been able to give these devices the love they need for a while now. Update the maintainers file to reflect the truth of the matter. Signed-off-by: John Snow --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index fa10ecae

Re: [PATCH v5 2/3] arm/kvm: add support for MTE

On 2/6/23 03:32, Eric Auger wrote: +void kvm_arm_enable_mte(Error **errp) +{ +static bool tried_to_enable = false; +Error *mte_migration_blocker = NULL; can't you make the mte_migration_blocker static instead? +int ret; + +if (tried_to_enable) { +/* + * MTE on K

Re: [PATCH] MAINTAINERS: Mark IDE and Floppy as "Odd Fixes"

On Mon, Feb 6, 2023 at 1:25 PM John Snow wrote: > > I have not been able to give these devices the love they need for a > while now. Update the maintainers file to reflect the truth of the > matter. I have not been able to give these devices the love they need for a while now. My backlog is consi

Re: [PATCH V1] meson: fix dependency on qemu-keymap

On 2/6/2023 1:55 AM, Marc-André Lureau wrote: > Hi > > On Wed, Jan 25, 2023 at 9:28 PM Steve Sistare > wrote: > > When qemu-keymap is not available on the host, and enable-xkbcommon > is specified, parallel make fails with: > >   % make clean >

[PATCH V2] meson: fix dependency on qemu-keymap

When qemu-keymap is not available on the host, and enable-xkbcommon is specified, parallel make fails with: % make clean ... % make -j 32 ... FAILED: pc-bios/keymaps/is ./qemu-keymap -f pc-bios/keymaps/is -l is /bin/sh: ./qemu-keymap: No such file or directory ... many similar mess

Re: [PATCH v15 06/11] s390x/cpu topology: interception of PTF instruction

On Wed, 2023-02-01 at 14:20 +0100, Pierre Morel wrote: > When the host supports the CPU topology facility, the PTF > instruction with function code 2 is interpreted by the SIE, > provided that the userland hypervizor activates the interpretation > by using the KVM_CAP_S390_CPU_TOPOLOGY KVM extensio

Re: [PATCH 3/9] target/arm: Avoid resetting CPUARMState::eabi field

On 2/6/23 02:17, Philippe Mathieu-Daudé wrote: Although the 'eabi' field is only used in user emulation where CPU reset doesn't occur, it doesn't belong to the area to reset. Move it after the 'end_reset_fields' for consistency. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.h | 9 +

Re: [PATCH 2/9] target/arm: Constify ID_PFR1 on user emulation

On 2/6/23 02:17, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- target/arm/helper.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~ diff --git a/target/arm/helper.c b/target/arm/helper.c index 5dbeade787..b5

Re: [PATCH v5 4/4] scripts: add script to compare compatible properties

Ping On 1/12/23 18:28, Maksim Davydov wrote: This script run QEMU to obtain compat_props of machines and default values of different types and produce appropriate table. This table can be used to compare machine types to choose the most suitable machine. Also this table in json or csv format sho

[PATCH v2 00/17] audio: improve callback interface for audio frontends

Based-on: <0a4007dc-e11c-f16e-0e21-dbc4e60ca...@t-online.de> ([PATCH v2 00/11] audio: more improvements) The callback interface for emulated audio devices is strange. The callback function has an 'avail' parameter that passes the number of bytes that can be written or read. Unfortunately, this

Re: Call for GSoC and Outreachy project ideas for summer 2023

On Mon, Feb 6, 2023 at 6:22 PM Stefan Hajnoczi wrote: > > On Mon, 6 Feb 2023 at 11:47, Eugenio Perez Martin wrote: > > > > On Mon, Feb 6, 2023 at 3:21 PM Stefan Hajnoczi wrote: > > > > > > On Mon, 6 Feb 2023 at 06:53, Eugenio Perez Martin > > > wrote: > > > > > > > > On Sun, Feb 5, 2023 at 2:5

Re: [PATCH 1/9] target/arm: Restrict v7-M MMU helpers to sysemu TCG

On 2/6/23 02:17, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- target/arm/helper.c | 2 +- target/arm/m_helper.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) This seems like it would break linux-user with -cpu cortex-m3, which is used for gcc test

[PATCH v2 02/17] audio: change type and name of the resample buffer

Change the type of the resample buffer from struct st_sample * to STSampleBuffer. Also change the name from buf to resample_buf for better readability. The new variables resample_buf.size and resample_buf.pos will be used after the next patches. There is no functional change. Acked-by: Mark Cave-

Re: [PATCH 02/12] tests/qtest: Do not run lsi53c895a test if device is not present

On 6/2/23 18:46, Fabiano Rosas wrote: Philippe Mathieu-Daudé writes: On 6/2/23 16:04, Fabiano Rosas wrote: The tests are built once for all the targets, so as long as one QEMU binary is built with CONFIG_LSI_SCSI_PCI=y, this test will run. However some binaries might not include the device. S

[PATCH v2 11/17] audio: replace the resampling loop in audio_pcm_sw_read()

Replace the resampling loop in audio_pcm_sw_read() with the new function audio_pcm_sw_resample_in(). Unlike the old resample loop the new function will try to consume input frames even if the output buffer is full. This is necessary when downsampling to avoid reading less audio frames than calculat

[PATCH v2 01/17] audio: change type of mix_buf and conv_buf

Change the type of mix_buf in struct HWVoiceOut and conv_buf in struct HWVoiceIn from STSampleBuffer * to STSampleBuffer. However, a buffer pointer is still needed. For this reason in struct STSampleBuffer samples[] is changed to *buffer. This is a preparation for the next patch. The next patch wi

[PATCH v2 15/17] audio: handle leftover audio frame from upsampling

Upsampling may leave one remaining audio frame in the input buffer. The emulated audio playback devices are currently resposible to write this audio frame again in the next write cycle. Push that task down to audio_pcm_sw_write. This is another step towards an audio callback interface that guarant

[PATCH v2 17/17] audio: remove sw->ratio

Simplify the resample buffer size calculation. For audio playback we have sw->ratio = ((int64_t)sw->hw->info.freq << 32) / sw->info.freq; samples = ((int64_t)sw->HWBUF.size << 32) / sw->ratio; This can be simplified to samples = muldiv64(sw->HWBUF.size, sw->info.freq, sw->hw->info.freq); For aud

[PATCH v2 04/17] audio: replace the resampling loop in audio_pcm_sw_write()

Replace the resampling loop in audio_pcm_sw_write() with the new function audio_pcm_sw_resample_out(). Unlike the old resample loop the new function will try to consume input frames even if the output buffer is full. This is necessary when downsampling to avoid reading less audio frames than calcul

[PATCH v2 09/17] audio/mixeng: calculate number of input frames

Calculate the exact number of audio input frames needed to get a given number of audio output frames. The exact number of frames depends only on the difference of opos - ipos and the number of output frames. When downsampling, this function returns the maximum number of input frames needed. This f

[PATCH v2 06/17] audio: rename variables in audio_pcm_sw_write()

The audio_pcm_sw_write() function uses a lot of very unspecific variable names. Rename them for better readability. ret => total_in total => total_out size => buf_len hwsamples => hw->mix_buf.size samples => frames_in_max Acked-by: Mark Cave-Ayland Signed-off-by: Volker Rümelin --- audio/audio

[PATCH v2 13/17] audio/mixeng: calculate number of output frames

Calculate the exact number of audio output frames the resampling code can generate from a given number of audio input frames. When upsampling, this function returns the maximum number of output frames. This function will later replace the audio_frontend_frames_in() function, which calculates the a

[PATCH v2 14/17] audio: wire up st_rate_frames_out()

Wire up the st_rate_frames_out() function and replace audio_frontend_frames_in() to make audio packet length calculation exact. Acked-by: Mark Cave-Ayland Signed-off-by: Volker Rümelin --- audio/audio.c | 29 - 1 file changed, 8 insertions(+), 21 deletions(-) diff -

[PATCH v2 16/17] audio/audio_template: substitute sw->hw with hw

Substitute sw->hw with hw in the audio_pcm_sw_alloc_resources_* functions. Acked-by: Mark Cave-Ayland Signed-off-by: Volker Rümelin --- audio/audio_template.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/audio/audio_template.h b/audio/audio_template.h index 0d8aab6f

Re: [PATCH 4/9] target/arm: Restrict CPUARMState::arm_boot_info to sysemu

On 2/6/23 02:17, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index bbbcf2e153..01d478e9ce 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h

Re: [PATCH 5/9] target/arm: Restrict CPUARMState::gicv3state to sysemu

On 2/6/23 02:17, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 01d478e9ce..61681101a5 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu

[PATCH v2 12/17] audio: rename variables in audio_pcm_sw_read()

The audio_pcm_sw_read() function uses a few very unspecific variable names. Rename them for better readability. ret => total_out total => total_in size => buf_len samples => frames_out_max Acked-by: Mark Cave-Ayland Signed-off-by: Volker Rümelin --- audio/audio.c | 18 +- 1 fil

[PATCH v2 07/17] audio: don't misuse audio_pcm_sw_write()

The audio_pcm_sw_write() function is intended to convert a PCM audio stream to the internal representation, adjust the volume, and then mix it with the other audio streams with a possibly changed sample rate in mix_buf. In order for the audio_capture_mix_and_clear() function to use audio_pcm_sw_wri

[PATCH v2 10/17] audio: wire up st_rate_frames_in()

Wire up the st_rate_frames_in() function and replace audio_frontend_frames_out() to make audio packet length calculation exact. When upsampling, it's still possible that the audio frontends can't write the last audio frame. This will be fixed later. Acked-by: Mark Cave-Ayland Signed-off-by: Volke

[PATCH v2 08/17] audio: remove unused noop_conv() function

The function audio_capture_mix_and_clear() no longer uses audio_pcm_sw_write() to resample audio frames from one internal buffer to another. For this reason, the noop_conv() function is now unused. Remove it. Acked-by: Mark Cave-Ayland Signed-off-by: Volker Rümelin --- audio/audio.c | 8 ---

[PATCH v2 03/17] audio: make the resampling code greedy

Read the maximum possible number of audio frames instead of the minimum necessary number of frames when the audio stream is downsampled and the output buffer is limited. This makes the function symmetrical to upsampling when the input buffer is limited. The maximum possible number of frames is writ

Re: [PATCH 6/9] target/arm: Restrict CPUARMState::nvic to sysemu and store as NVICState*

On 2/6/23 02:17, Philippe Mathieu-Daudé wrote: There is no point in using a void pointer to access the NVIC. Use the real type to avoid casting it while debugging. Signed-off-by: Philippe Mathieu-Daudé --- This is doing several things at once. The nvic interface change needn't be done simul

[PATCH v2 05/17] audio: remove sw == NULL check

All call sites of audio_pcm_sw_write() guarantee that sw is not NULL. Remove the unnecessary NULL check. Acked-by: Mark Cave-Ayland Signed-off-by: Volker Rümelin --- audio/audio.c | 4 1 file changed, 4 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 4412b5fad8..8f1c0e77b0 1

Re: [PATCH 7/9] target/arm: Declare CPU <-> NVIC helpers in 'hw/intc/armv7m_nvic.h'

On 2/6/23 02:17, Philippe Mathieu-Daudé wrote: While dozens of files include "cpu.h", only 3 files require these NVIC helper declarations. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/intc/armv7m_nvic.h | 123 ++ target/arm/cpu.c | 4 +-

Re: [PATCH 6/9] target/arm: Restrict CPUARMState::nvic to sysemu and store as NVICState*

On 6/2/23 19:57, Richard Henderson wrote: On 2/6/23 02:17, Philippe Mathieu-Daudé wrote: There is no point in using a void pointer to access the NVIC. Use the real type to avoid casting it while debugging. Signed-off-by: Philippe Mathieu-Daudé --- This is doing several things at once.  The n

Re: [PATCH v2 12/23] vfio-user: region read/write

On Wed, 1 Feb 2023 21:55:48 -0800 John Johnson wrote: > Add support for posted writes on remote devices > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > hw/vfio/user-protocol.h | 12 + > hw/vfio/user.h|

Re: [PATCH 6/9] target/arm: Restrict CPUARMState::nvic to sysemu and store as NVICState*

On 2/6/23 09:00, Philippe Mathieu-Daudé wrote: On 6/2/23 19:57, Richard Henderson wrote: On 2/6/23 02:17, Philippe Mathieu-Daudé wrote: There is no point in using a void pointer to access the NVIC. Use the real type to avoid casting it while debugging. Signed-off-by: Philippe Mathieu-Daudé --

[PATCH 0/1] accel/tcg: Allow the second page of an instruction to be MMIO

Curious but true: two independent reports of the same issue within 24 hours, one with an x86 guest and one with an arm guest. Neither report included instructions for reproduction (and both seem to be with complex setup), therefore this is untested, but seems simple enough to be the proper fix. I

[PATCH 1/1] accel/tcg: Allow the second page of an instruction to be MMIO

If an instruction straddles a page boundary, and the first page was ram, but the second page was MMIO, we would abort. Handle this as if both pages are MMIO, by setting the ram_addr_t for the first page to -1. Reported-by: Sid Manning Reported-by: Jørgen Hansen Signed-off-by: Richard Henderson

[PATCH 0/3] PCA I2C GPIO expanders

This patch series contains a set of i2c GPIO expanders, with support for 4, 8, and 16 GPIO connections. The devices are configured as GPIO outputs by default, but can have pins configured to be inputs with qmp commands. For example, the following snippet in a board file for a system, configures a

[PATCH 3/3] hw/gpio: add PCA9536 i2c gpio expander

This device has the same register layout as the pca9538, but 4 fewer gpio pins. This commit lowers the number of pins intialised, and reuses the pca9539 logic. Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/gpio/pca_i2c_gpio.c | 22 ++ include/hw/gpio/pca_i

[PATCH 2/3] hw/gpio: add PCA9538 8-bit GPIO expander

The 8-bit expander has different register offsets than the 16-bit one, making them incompatible. Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/gpio/pca_i2c_gpio.c | 98 ++ include/hw/gpio/pca_i2c_gpio.h | 7 +++ 2 files changed, 105 insert

[PATCH 1/3] hw/gpio: add PCA6414 i2c GPIO expander

This is a simple i2c device that allows i2c capable devices to have GPIOs. Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/arm/Kconfig | 1 + hw/gpio/meson.build | 1 + hw/gpio/pca_i2c_gpio.c | 362 hw/gpio/trac

Re: Call for GSoC and Outreachy project ideas for summer 2023

On Fri, Jan 27, 2023 at 3:17 PM Stefan Hajnoczi wrote: > Dear QEMU, KVM, and rust-vmm communities, > QEMU will apply for Google Summer of Code 2023 > (https://summerofcode.withgoogle.com/) and has been accepted into > Outreachy May 2023 (https://www.outreachy.org/). You can now > submit internship

Re: [PATCH v11 2/3] hw/riscv/boot.c: consolidate all kernel init in riscv_load_kernel()

On 2/6/23 04:00, Daniel Henrique Barboza wrote: To not change the behavior of boards that aren't calling riscv_load_init(), add an 'load_initrd' flag to riscv_load_kernel() and allow these boards to opt out from initrd loading. Surely this is simply a bug for those boards. I cannot believe, fo

Re: [RFC PATCH 0/5] Deprecate/rename singlestep command line option

On 06/02/2023 18.13, Peter Maydell wrote: The command line option '-singlestep' and its HMP equivalent the 'singlestep' command are very confusingly named, because they have nothing to do with single-stepping the guest (either via the gdb stub or by emulation of guest CPU architectural debug faci

Re: [PATCH v11 2/3] hw/riscv/boot.c: consolidate all kernel init in riscv_load_kernel()

On 2/6/23 16:54, Richard Henderson wrote: On 2/6/23 04:00, Daniel Henrique Barboza wrote: To not change the behavior of boards that aren't calling riscv_load_init(), add an 'load_initrd' flag to riscv_load_kernel() and allow these boards to opt out from initrd loading. Surely this is simply

Re: [RFC PATCH 1/5] Rename the singlestep global variable to one_insn_per_tb

On 06/02/2023 18.13, Peter Maydell wrote: The 'singlestep' global variable is badly misnamed, because it has nothing to do with single-stepping the emulation either via the gdb stub or by emulation of architectural debug facilities. Instead what it does is force TCG to put only one instruction i

Re: [RFC 0/3] virtio-blk: add iothread-vq-mapping parameter

On Mon, Feb 06, 2023 at 03:11:21PM +0100, Michal Prívozník wrote: > On 1/18/23 20:47, Stefan Hajnoczi wrote: > > This is a preview of the iothread-vq-mapping parameter that assigns > > virtqueues > > to IOThreads. The syntax is implemented but multiple IOThreads are not > > actually > > supported

Re: [PATCH v2 15/23] vfio-user: forward msix BAR accesses to server

On Wed, 1 Feb 2023 21:55:51 -0800 John Johnson wrote: > Server holds device current device pending state > Use irq masking commands in socket case > > Signed-off-by: John G Johnson > Signed-off-by: Elena Ufimtseva > Signed-off-by: Jagannathan Raman > --- > hw/vfio/pci.h | 1

Re: [PATCH V2] meson: fix dependency on qemu-keymap

On Mon, Feb 6, 2023 at 10:34 PM Steve Sistare wrote: > When qemu-keymap is not available on the host, and enable-xkbcommon > is specified, parallel make fails with: > > % make clean > ... > % make -j 32 > ... > FAILED: pc-bios/keymaps/is > ./qemu-keymap -f pc-bios/keymaps/is -l is >

Re: [PATCH v2 17/23] vfio-user: dma map/unmap operations

On Wed, 1 Feb 2023 21:55:53 -0800 John Johnson wrote: > diff --git a/hw/vfio/common.c b/hw/vfio/common.c > index 6f99907..f04fd20 100644 > --- a/hw/vfio/common.c > +++ b/hw/vfio/common.c > @@ -889,6 +894,29 @@ static bool > vfio_known_safe_misalignment(MemoryRegionSection *section) > retur

Re: [PATCH v4 0/2] riscv: Add support for Zicbo[m,z,p] instructions

Hi, FYI I grabbed these patches, rebased using Alistair's riscv-to-apply.next, and I plan to re-send them as v5 in the next few days (maintaining Christoph's authorship, of course). I'll see if I can implement some of the suggestions made in the v4 one year ago as well. To keep the original pa

Re: [PATCH 1/1] accel/tcg: Allow the second page of an instruction to be MMIO

On 6/2/23 20:38, Richard Henderson wrote: If an instruction straddles a page boundary, and the first page was ram, but the second page was MMIO, we would abort. Handle this as if both pages are MMIO, by setting the ram_addr_t for the first page to -1. Reported-by: Sid Manning Reported-by: Jørg

Re: [PATCH v3 0/4] block: fix detect-zeroes= with BDRV_REQ_REGISTERED_BUF

On Wed, Feb 01, 2023 at 10:27:47AM -0500, Stefan Hajnoczi wrote: > v3: > - Restore alphabetical order in getopt strings [Eric] > v2: > - Add comment explaining unbalanced error code path in > qemu_io_alloc_from_file() [Eric] > - List options alphabetically in help output [Eric] > - Add Tested-by/

Re: vhost-user (virtio-fs) migration: back end state

Stefan Hajnoczi wrote: > On Mon, 6 Feb 2023 at 07:36, Hanna Czenczek wrote: >> >> Hi Stefan, >> >> For true virtio-fs migration, we need to migrate the daemon’s (back >> end’s) state somehow. I’m addressing you because you had a talk on this >> topic at KVM Forum 2021. :) >> >> As far as I under

Re: vhost-user (virtio-fs) migration: back end state

On Mon, 6 Feb 2023 at 16:02, Juan Quintela wrote: > > Stefan Hajnoczi wrote: > > On Mon, 6 Feb 2023 at 07:36, Hanna Czenczek wrote: > >> > >> Hi Stefan, > >> > >> For true virtio-fs migration, we need to migrate the daemon’s (back > >> end’s) state somehow. I’m addressing you because you had a

Re: Call for GSoC and Outreachy project ideas for summer 2023

On Mon, 6 Feb 2023 at 14:51, Alberto Faria wrote: > > On Fri, Jan 27, 2023 at 3:17 PM Stefan Hajnoczi wrote: > > Dear QEMU, KVM, and rust-vmm communities, > > QEMU will apply for Google Summer of Code 2023 > > (https://summerofcode.withgoogle.com/) and has been accepted into > > Outreachy May 202

Re: [PATCH v2 18/23] vfio-user: add dma_unmap_all

On Wed, 1 Feb 2023 21:55:54 -0800 John Johnson wrote: > Signed-off-by: John G Johnson > Signed-off-by: Elena Ufimtseva > Signed-off-by: Jagannathan Raman > --- > include/hw/vfio/vfio-common.h | 1 + > hw/vfio/common.c | 45 > ++- > hw/vf

Re: [PATCH v2 3/3] util/userfaultfd: Support /dev/userfaultfd

On Fri, Feb 03, 2023 at 10:01:04PM +0100, Juan Quintela wrote: > Peter Xu wrote: > > On Thu, Feb 02, 2023 at 11:52:21AM +0100, Juan Quintela wrote: > >> Peter Xu wrote: > >> > Teach QEMU to use /dev/userfaultfd when it existed and fallback to the > >> > system call if either it's not there or doe

Re: [PATCH 1/3] hw/gpio: add PCA6414 i2c GPIO expander

Hi Titus, On 6/2/23 20:49, Titus Rwantare wrote: This is a simple i2c device that allows i2c capable devices to have GPIOs. Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/arm/Kconfig | 1 + hw/gpio/meson.build | 1 + hw/gpio/pca_i2c_gpio.c

Re: [PATCH RFC 14/21] migration: Map hugetlbfs ramblocks twice, and pre-allocate

On Wed, Feb 01, 2023 at 07:53:28PM +0100, Juan Quintela wrote: > Peter Xu wrote: > > On Mon, Jan 30, 2023 at 06:24:20AM +0100, Juan Quintela wrote: > >> I would consider here: > >> > >> uint8_t *host_doublemap; > >> > >> as I have not a small name that means > >> uint8_t *host_map_smalle

Re: [PATCH 0/9] hw: Use QOM alias properties and few QOM/QDev cleanups

On 06/02/2023 15:27, Philippe Mathieu-Daudé wrote: On 6/2/23 00:29, Mark Cave-Ayland wrote: On 03/02/2023 11:36, Philippe Mathieu-Daudé wrote: These patches are extracted from a QOM/QDev refactor series, so they are preliminary cleanups noticed while working on it: - Use correct type when ca

Re: [PULL 00/26] Next patches

On Sat, Feb 04, 2023 at 10:19:34AM +, Peter Maydell wrote: > On Thu, 2 Feb 2023 at 16:07, Juan Quintela wrote: > > > > The following changes since commit deabea6e88f7c4c3c12a36ee30051c6209561165: > > > > Merge tag 'for_upstream' of > > https://git.kernel.org/pub/scm/virt/kvm/mst/qemu into s

[PULL 3/8] hw/misc/macio: Avoid some QOM casts

From: BALATON Zoltan At several places we already have the object pointer with the right type so we don't need to cast it back and forth. Avoiding these casts improves readability. Signed-off-by: BALATON Zoltan Message-Id: <67b2d4700879c3b4cd574f1faa1a0d1950b3d0ee.1674001242.git.bala...@eik.bm

[PULL 7/8] mac_nvram: Add block backend to persist NVRAM contents

From: BALATON Zoltan Add a way to set a backing store for the mac_nvram similar to what spapr_nvram or mac_via PRAM already does to allow to save its contents between runs. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Message-Id: <4b1605a9e484cc95f6e141f297487a070fd418ac.

[PULL 5/8] hw/misc/macio: Remove some single use local variables

From: BALATON Zoltan Drop some local variables that could just be substituted at the single place they were used. This makes the code shorter and simpler. Signed-off-by: BALATON Zoltan Message-Id: <165a4ea190af7c09832f50f02004fad82f704898.1674001242.git.bala...@eik.bme.hu> Reviewed-by: Philipp

[PULL 0/8] qemu-macppc queue 20230206

The following changes since commit 6661b8c7fe3f8b5687d2d90f7b4f3f23d70e3e8b: Merge tag 'pull-ppc-20230205' of https://gitlab.com/danielhb/qemu into staging (2023-02-05 16:49:09 +) are available in the Git repository at: https://github.com/mcayland/qemu.git tags/qemu-macpp

[PULL 8/8] mac_oldworld: Allow specifying nvram backing store

From: BALATON Zoltan Add a way to set a backing store for the mac_nvram. Use -drive file=nvram.img,format=raw,if=mtd to specify backing file where nvram.img must be MACIO_NVRAM_SIZE which is 8192 bytes. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé Message-Id: <1aadee8f0ca

[PULL 2/8] mac_{old, new}world: Use local variable instead of qdev_get_machine()

From: BALATON Zoltan We already have machine in a local variable so no need to use qdev_get_machine(), also remove now unneeded line break. Signed-off-by: BALATON Zoltan Message-Id: <719299533b89aa4516966065eae05c75744f50d3.1672868854.git.bala...@eik.bme.hu> Reviewed-by: Philippe Mathieu-Daudé

[PULL 1/8] input/adb: Only include header where needed

From: BALATON Zoltan The header hw/input/adb.h is included by some files that don't need it. Clean it up and include only where necessary. Signed-off-by: BALATON Zoltan Message-Id: Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland --- hw/mis

[PULL 6/8] hw/misc/macio: Return bool from functions taking errp

From: BALATON Zoltan Use the convention to return bool from functions which take an error pointer which allows for callers to pass through their error pointer without needing a local. Signed-off-by: BALATON Zoltan Message-Id: Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Mark Cave-Ayland

[PULL 4/8] hw/misc/macio: Rename sysbus_dev to sbd for consistency and brevity

From: BALATON Zoltan Some functions use sysbus_dev while others sbd name for local variable storing a sysbus device pointer. Standardise on the shorter name to be consistent and make the code easier to read as short name is less distracting and needs less line breaks. Signed-off-by: BALATON Zolt

Re: hw/misc/mos6522: What is VIA_TIMER_FREQ value?

On 06/02/2023 16:22, Philippe Mathieu-Daudé wrote: Hi Mark & Laurent, In commit d811d61fbc6 Mark defined VIA_TIMER_FREQ as 470 / 6 (78.33) and in commit 6dca62a Laurent defined it as 783360. What is the correct value? Could we define it once in include/hw/misc/mac_via.h or even in

Re: [PATCH] hw/riscv: virt: Simplify virt_{get,set}_aclint()

On Mon, Feb 6, 2023 at 6:51 PM Bin Meng wrote: > > There is no need to declare an intermediate "MachineState *ms". > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair > --- > > hw/riscv/virt.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/ri

Re: [PATCH v11 1/3] hw/riscv: handle 32 bit CPUs kernel_entry in riscv_load_kernel()

On Tue, Feb 7, 2023 at 12:04 AM Daniel Henrique Barboza wrote: > > Next patch will move all calls to riscv_load_initrd() to > riscv_load_kernel(). Machines that want to load initrd will be able to > do via an extra flag to riscv_load_kernel(). > > This change will expose a sign-extend behavior tha

Re: [PATCH 1/3] hw/gpio: add PCA6414 i2c GPIO expander

On Mon, Feb 06, 2023 at 07:49:34PM +, Titus Rwantare wrote: > This is a simple i2c device that allows i2c capable devices to have > GPIOs. > > Reviewed-by: Hao Wu > Signed-off-by: Titus Rwantare > --- > hw/arm/Kconfig | 1 + > hw/gpio/meson.build | 1 + > hw

[PATCH v2 00/11] target/arm: Housekeeping around NVIC

Missing review: 1-3, 5, 9-10 Few cleanups while using link properties between CPU/NVIC: - Simplify ID_PFR1 on useremu - Move NVIC helpers to "hw/intc/armv7m_nvic.h" Since v1: addressed Richard's reviews - Do not restrict v7-M MMU helpers to TCG sysemu since they can be used for user-emu. Hardco

[PATCH v2 07/11] target/arm: Restrict CPUARMState::gicv3state to sysemu

Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 1c1e0334f0..002082eb5b 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -769,9 +769,10

[PATCH v2 06/11] target/arm: Avoid resetting CPUARMState::eabi field

Although the 'eabi' field is only used in user emulation where CPU reset doesn't occur, it doesn't belong to the area to reset. Move it after the 'end_reset_fields' for consistency. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.h | 9 - 1 file c

[PATCH v2 02/11] target/arm: Simplify arm_v7m_mmu_idx_for_secstate() for user emulation

Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/arm/m_helper.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/target/arm/m_helper.c b/target/arm/m_helper.c index e7e746ea18..76239c9abe 100644 --- a/target/arm/m_helper.c +++ b/targ

[PATCH v2 09/11] target/arm: Restrict CPUARMState::nvic to sysemu

Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index a574e85b76..01f9566a1b 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -767,8 +767,8 @@ typedef struct CPUArchState {

[PATCH v2 10/11] target/arm: Store CPUARMState::nvic as NVICState*

There is no point in using a void pointer to access the NVIC. Use the real type to avoid casting it while debugging. Signed-off-by: Philippe Mathieu-Daudé --- hw/intc/armv7m_nvic.c | 38 --- target/arm/cpu.c | 1 + target/arm/cpu.h | 46

[PATCH v2 01/11] hw/intc/armv7m_nvic: Use OBJECT_DECLARE_SIMPLE_TYPE() macro

Manually convert to OBJECT_DECLARE_SIMPLE_TYPE() macro, similarly to automatic conversion from commit 8063396bf3 ("Use OBJECT_DECLARE_SIMPLE_TYPE when possible"). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/intc/armv7m_nvic.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) di

[PATCH v2 11/11] target/arm: Declare CPU <-> NVIC helpers in 'hw/intc/armv7m_nvic.h'

While dozens of files include "cpu.h", only 3 files require these NVIC helper declarations. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/intc/armv7m_nvic.h | 123 ++ target/arm/cpu.c | 4 +- target/arm/cpu.h

[PATCH v2 05/11] target/arm: Convert CPUARMState::eabi to boolean

Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- linux-user/arm/cpu_loop.c | 4 ++-- linux-user/user-internals.h | 2 +- target/arm/cpu.h| 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/linux-user/arm/cpu_loop.c b/linux-user/arm/cpu_lo

[PATCH v2 03/11] target/arm: Reduce arm_v7m_mmu_idx_[all/for_secstate_and_priv]() scope

arm_v7m_mmu_idx_all() and arm_v7m_mmu_idx_for_secstate_and_priv() are only used for system emulation in m_helper.c. Move the definitions to avoid prototype forward declarations. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/internals.h | 14 target/arm/m_helper.c | 74 ++

[PATCH v2 08/11] target/arm: Restrict CPUARMState::arm_boot_info to sysemu

Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 002082eb5b..a574e85b76 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -768,8 +768,8 @@

[PATCH v2 04/11] target/arm: Constify ID_PFR1 on user emulation

Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/arm/helper.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index c62ed05c12..22670c20c0 100644 --- a/target/arm/helper.c +++ b/target/arm/

Re: [RFC PATCH 01/16] hw/arm/smmuv3: Add missing fields for IDR0

On 2/4/23 23:43, Mostafa Saleh wrote: In preparation for adding stage-2 support. Add IDR0 fields related to stage-2. VMID16: 16-bit VMID supported. S2P: Stage-2 translation supported. They are described in 6.3.1 SMMU_IDR0. No functional change intended. Signed-off-by: Mostafa Saleh --- hw/a

Re: [PATCH v11 2/3] hw/riscv/boot.c: consolidate all kernel init in riscv_load_kernel()

On Tue, Feb 7, 2023 at 6:19 AM Daniel Henrique Barboza wrote: > > > > On 2/6/23 16:54, Richard Henderson wrote: > > On 2/6/23 04:00, Daniel Henrique Barboza wrote: > >> To not change the behavior of boards that aren't calling > >> riscv_load_init(), add an 'load_initrd' flag to riscv_load_kernel()

Re: [PATCH 0/9] hw: Use QOM alias properties and few QOM/QDev cleanups

On 6/2/23 22:54, Mark Cave-Ayland wrote: On 06/02/2023 15:27, Philippe Mathieu-Daudé wrote: On 6/2/23 00:29, Mark Cave-Ayland wrote: On 03/02/2023 11:36, Philippe Mathieu-Daudé wrote: These patches are extracted from a QOM/QDev refactor series, so they are preliminary cleanups noticed while

Re: [PATCH 02/10] hw/riscv/virt: Add a switch to enable/disable ACPI

Am 6. Februar 2023 11:18:06 UTC schrieb "Philippe Mathieu-Daudé" : >On 6/2/23 11:54, Andrea Bolognani wrote: >> On Thu, Feb 02, 2023 at 10:22:15AM +0530, Sunil V L wrote: >>> +object_class_property_add(oc, "acpi", "OnOffAuto", >>> + virt_get_acpi, virt_set_acpi,

Re: [PATCH v4 1/2] hw/sensor: Add SB-TSI Temperature Sensor Interface

Hi, It seems like this patch set is reviewed but never merged. Who should take this patch set? What are our next steps for them? Thanks! On Mon, Jan 31, 2022 at 2:29 PM Patrick Venture wrote: > From: Hao Wu > > SB Temperature Sensor Interface (SB-TSI) is an SMBus compatible > interface that r

Re: [PULL 00/26] Next patches

On Mon, Feb 6, 2023, 23:07 Peter Xu wrote: > On Sat, Feb 04, 2023 at 10:19:34AM +, Peter Maydell wrote: > > On Thu, 2 Feb 2023 at 16:07, Juan Quintela wrote: > > > > > > The following changes since commit > deabea6e88f7c4c3c12a36ee30051c6209561165: > > > > > > Merge tag 'for_upstream' of >

[PATCH 1/3] MAINTAINERS: Add myself to maintainers and remove Havard

Havard is no longer working on the Nuvoton systems for a while and won't be able to do any work on it in the future. So I'll take over maintaining the Nuvoton system from him. Signed-off-by: Hao Wu --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/

[PATCH 2/3] hw/ssi: Add Nuvoton PSPI Module

Nuvoton's PSPI is a general purpose SPI module which enables connections to SPI-based peripheral devices. Signed-off-by: Hao Wu Reviewed-by: Chris Rauer --- MAINTAINERS| 6 +- hw/ssi/meson.build | 2 +- hw/ssi/npcm_pspi.c | 216 +++

[PATCH 3/3] hw/arm: Attach PSPI module to NPCM7XX SoC

Signed-off-by: Hao Wu Reviewed-by: Titus Rwantare --- docs/system/arm/nuvoton.rst | 2 +- hw/arm/npcm7xx.c| 25 +++-- include/hw/arm/npcm7xx.h| 2 ++ 3 files changed, 26 insertions(+), 3 deletions(-) diff --git a/docs/system/arm/nuvoton.rst b/docs/system/ar

[PATCH 0/3] Nuvoton Peripheral SPI (PSPI) Module

This patch set adds peripheral SPI (PSPI) modules to NPCM7XX SoCs. These modules can be used to connect any SPI peripheral devices to the SoC. This module will also be used in the next generation NPCM8XX SoCs which haven't been merged yet. Thanks! Hao Wu (3): MAINTAINERS: Add myself to maintai

<    1   2   3   4   5   >