Re: [PATCH 4/6] gitlab-ci.d/buildtest: Merge the --without-default-* jobs

On 30/01/2023 14.28, Fabiano Rosas wrote: Thomas Huth writes: Let's safe some CI minutes by merging these two jobs. We can now also drop "--disable-capstone" since the capstone submodule has been removed a while ago. We should rather tes --disable-fdt now to test a compilation without the "dtc

Re: [PATCH v2] softmmu: Use memmove in flatview_write_continue

On 31.01.23 04:01, Akihiko Odaki wrote: We found a case where the source passed to flatview_write_continue() may overlap with the destination when fuzzing igb, a new proposed network device with sanitizers. igb uses pci_dma_map() to get Tx packet, and pci_dma_write() to write Rx buffer. While pc

Re: [PATCH v9 01/58] include: import Xen public headers to include/standard-headers/

On Mon, 2023-01-30 at 09:41 +0100, Thomas Huth wrote: > > The files in include/standard-headers are created automatically by the > scripts/update-linux-headers.sh script, so I was a little bit surprised that > you don't provide an update to that script first ... if you copy new headers > there

Re: [PATCH v3] migration: Remove res_compatible parameter

On 1/30/23 11:06, Juan Quintela wrote: It was only used for RAM, and in that case, it means that this amount of data was sent for memory. Just delete the field in all callers. Could you describe, why it's safe to change the behavior for RAM? Also, I think it would be a lot better to split the

Re: [PATCH v2 5/8] hw/i386/acpi: Drop duplicate _UID entry for CXL root bridge

On Fri, 27 Jan 2023 21:38:20 -0500 "Michael S. Tsirkin" wrote: > On Thu, Jan 12, 2023 at 10:26:41AM +, Jonathan Cameron wrote: > > Noticed as this prevents iASL disasembling the DSDT table. > > > > Reviewed-by: Ira Weiny > > Signed-off-by: Jonathan Cameron > > This needed but it looks l

[PATCH] target/i386: fix ADOX followed by ADCX

When ADCX is followed by ADOX or vice versa, the second instruction's carry comes from EFLAGS. This is handled by this bit of gen_ADCOX: tcg_gen_extract_tl(carry_in, cpu_cc_src, ctz32(cc_op == CC_OP_ADCX ? CC_C : CC_O), 1); Unfortunately, in this case cc_op has been overwritt

Re: [PATCH v6 32/36] target/s390x: Use tcg_gen_atomic_cmpxchg_i128 for CDSG

On 30.01.23 22:48, Richard Henderson wrote: Signed-off-by: Richard Henderson --- Cc: David Hildenbrand Cc: Ilya Leoshkevich --- Acked-by: David Hildenbrand -- Thanks, David / dhildenb

Re: [PATCH] acpi: Set maximum size to 64k for "etc/acpi/rsdp" blob

Michael S. Tsirkin 于2023年1月30日周一 23:07写道： > > On Mon, Jan 30, 2023 at 10:47:25PM +0800, Feng Sun wrote: > > Igor Mammedov 于2023年1月24日周二 18:30写道： > > > > > > On Tue, 17 Jan 2023 19:15:21 +0800 > > > Sun Feng wrote: > > > > > > > Migrate from aarch64 host with PAGE_SIZE 64k to 4k failed with > >

[PATCH v3 5/9] igb: check oversized packets for VMDq

Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 48 +++ 1 file changed, 40 insertions(+), 8 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 4a1b98bf0e..2f6f30341f 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@

[PATCH v3 4/9] igb: implement VFRE and VFTE registers

Also add checks for RXDCTL/TXDCTL queue enable bits Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 30 +- hw/net/igb_core.h | 1 + hw/net/igb_regs.h | 3 +++ 3 files changed, 29 insertions(+), 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_cor

[RFC PATCH] build: deprecate --enable-gprof builds and remove from CI

As gprof relies on instrumentation you rarely get useful data compared to a real optimised build. Lets deprecate the build option and simplify the CI configuration as a result. Signed-off-by: Alex Bennée Cc: Thomas Huth --- docs/about/deprecated.rst | 14 ++ meson.build

[PATCH v3 0/9] igb: merge changes from <20221229190817.25500-1-sriram.yagnara...@est.tech>

Based-on: <20230130140809.78262-1-akihiko.od...@daynix.com> ([PATCH v5 0/9] Introduce igb) Rebased on latest changes from Akihiko, and merged changes from my original patchset: https://lists.gnu.org/archive/html/qemu-devel/2022-12/msg04670.html Changes since v2: - Fixed more comments from Akhiko

[PATCH v3 8/9] igb: respect VT_CTL ignore MAC field

Also trace out a warning if replication mode is disabled, since we only support replication mode enabled. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 + hw/net/trace-events | 2 ++ 2 files changed, 11 insertions(+) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c inde

[PATCH v3 6/9] igb: respect E1000_VMOLR_RSSE

RSS for VFs is only enabled if VMOLR[n].RSSE is set. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 2f6f30341f..31a325d374 100644 --- a/hw/net/igb_core.c +++ b/hw/net/i

[PATCH v3 1/9] MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer

I would like to review and be informed on changes to igb device Signed-off-by: Sriram Yagnaraman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ece23b2b15..7d0e84ce37 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2224,6 +2224,7 @@ F: tests/qt

[PATCH v3 7/9] igb: implement VF Tx and Rx stats

Please note that loopback counters for VM to VM traffic is not implemented yet: VFGOTLBC, VFGPTLBC, VFGORLBC and VFGPRLBC. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/hw/net/igb_core.c b/hw

[PATCH v3 3/9] igb: add ICR_RXDW

IGB uses RXDW ICR bit to indicate that rx descriptor has been written back. This is the same as RXT0 bit in older HW. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 4 hw/net/igb_core.c| 46 +--- 2 files changed, 22 insertions(+), 28

[PATCH v3 2/9] igb: handle PF/VF reset properly

Use PFRSTD to reset RSTI bit for VFs, and raise VFLRE interrupt when VF is reset. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 33 + hw/net/igb_regs.h | 3 +++ hw/net/trace-events | 2 ++ 3 files changed, 26 insertions(+), 12 deletions(-) diff -

[PATCH v3 9/9] igb: respect VMVIR and VMOLR for VLAN

Add support for stripping/inserting VLAN for VFs. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 51 ++- 1 file changed, 42 insertions(+), 9 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 8115be2d76..a697fcf56a 100644

Re: [PATCH] vhost-user-gpio: Configure vhost_dev when connecting

Akihiko Odaki writes: > vhost_dev_cleanup(), called from vu_gpio_disconnect(), clears vhost_dev > so vhost-user-gpio must set the members of vhost_dev each time > connecting. > > do_vhost_user_cleanup() should also acquire the pointer to vqs directly > from VHostUserGPIO instead of referring to

RE: [PATCH v2 00/13] Introduce igb

> -Original Message- > From: Akihiko Odaki > Sent: Monday, 30 January 2023 15:39 > To: Sriram Yagnaraman ; Jason Wang > > Cc: Dmitry Fleytman ; Michael S. Tsirkin > ; Marcel Apfelbaum ; > Alex Bennée ; Philippe Mathieu-Daudé > ; Thomas Huth ; Wainer dos Santos > Moschetta ; Beraldo Leal

Re: [PATCH v4 3/3] hw/riscv: change riscv_compute_fdt_addr() semantics

On 1/30/23 22:00, Bin Meng wrote: On Tue, Jan 31, 2023 at 1:16 AM Daniel Henrique Barboza wrote: On 1/29/23 02:45, Bin Meng wrote: On Thu, Jan 26, 2023 at 9:54 PM Daniel Henrique Barboza wrote: As it is now, riscv_compute_fdt_addr() is receiving a dram_base, a mem_size (which is defau

Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

Hi On Tue, Jan 17, 2023 at 9:07 PM John Berberian, Jr wrote: > > Apologies for the late response, I was traveling most of yesterday. > > On 1/16/23 4:22 AM, Daniel P. Berrangé wrote: > > When we introduce a new QAPI format for migration args though, I've > > suggested we drop support for passing

Re: [PATCH v2 2/5] parallels: Split image leak handling to separate check and fix helpers

On 1/12/23 16:01, Alexander Ivanov wrote: We need to fix leak after deduplication in the next patch. Move leak fixing to a separate helper parallels_fix_leak() and add parallels_get_leak_size() helper wich used in parallels_fix_leak() and parallels_check_leak(). Signed-off-by: Alexander Ivanov

Re: [PATCH v2 0/2] audio: make audiodev introspectable by management apps

On 23/01/2023 09.39, Thomas Huth wrote: Here's a respin from Daniel's audiodev introspection patches from 2021. I've rebased them to the current master branch and addressed the review comments from v1. The Audiodev QAPI type is not introspectable via query-qmp-schema as nothing in QMP uses it. "

[PULL 00/27] qtest and misc patches

Hi Peter! The following changes since commit 13356edb87506c148b163b8c7eb0695647d00c2a: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2023-01-24 09:45:33 +) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-20

[PULL 10/27] qemu/bswap: Replace bswapXXs() by compiler __builtin_bswap()

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <2023063147.71761-3-phi...@linaro.org> Signed-off-by: Thomas Huth --- include/qemu/bswap.h | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/inc

[PULL 17/27] tests/tcg: Do not build/run TCG tests if TCG is disabled

From: Fabiano Rosas The tests under tests/tcg depend on the TCG accelerator. Do not build them if --disable-tcg was given in the configure line. Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230120184825.31626-7-faro...@suse.de>

[PULL 08/27] tests/docker/dockerfiles: Add libfdt to the i386 and to the riscv64 container

No need to recompile the dtc submodule here again and again, we can use the pre-built binary from the distribution instead. (And this will also help in case we finally get rid of the dtc submodule in QEMU one day) Message-Id: <20230124143824.844040-1-th...@redhat.com> Reviewed-by: Philippe Mathieu

[PULL 03/27] tests/qtest/bios-tables-test: Make the test less verbose by default

We are facing the issues that our test logs in the gitlab CI are too big (and thus cut off). The bios-tables-test is one of the few qtests that prints many lines of output by default when running with V=1, so it contributes to this problem. Almost all other qtests are silent with V=1 and only print

[PULL 16/27] docs/about/deprecated: Mark HAXM in QEMU as deprecated

The HAXM project has been retired (see https://github.com/intel/haxm#status), so we should mark the code in QEMU as deprecated (and finally remove it unless somebody else picks the project up again - which is quite unlikely since there are now whpx and hvf on these operating systems, too). Message

[PULL 14/27] qemu/bswap: Use compiler __builtin_bswap() on NetBSD

From: Philippe Mathieu-Daudé Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8, which supports __builtin_bswap(). Remove the NetBSD specific ifdef'ry. This reverts commit 1360677cfe3ca8f945fa1de77823df21a77e45

[PULL 20/27] tests/qtest/vnc-display-test: Disable on Darwin

From: Philippe Mathieu-Daudé This test is failing in gtk-vnc on Darwin: $ make check-qtest-aarch64 ... 19/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/vnc-display-test ERROR **: 10:42:35.488: vnc-error: Unsupported auth type 17973672 While QEMU picks the sigaltstack coroutine backend, gt

[PULL 02/27] tests/qtest/qom-test: Stop spamming the test log

We are still facing the issues that our test logs in the gitlab CI are too big (and thus cut off). A huge part is still caused by the qom-test that prints the path and name of each object it looks at by default. That's too much. Let's be silent by default, and only print the object path+name when r

[PULL 26/27] tests/qtest/display-vga-test: Add proper checks if a device is available

display-vga-test currently tries to guess the usable VGA devices according to the target architecture that is used for the test. This of course does not work if QEMU has been built with the "--without-default-devices" configure switch. To fix this, use the qtest_has_device() function for the decisi

[PULL 05/27] configs/targets/nios2-softmmu: Add TARGET_NEED_FDT=y to the nios2 config

qemu-system-nios2 uses the functions from libfdt in hw/nios2/boot.c, so this target has to be marked with TARGET_NEED_FDT=y in its config file. Message-Id: <20230119125745.2028814-1-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- configs/targets/nios2-softmm

[PULL 12/27] qemu/bswap: Use compiler __builtin_bswap() on Haiku

From: Philippe Mathieu-Daudé Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8, which supports __builtin_bswap(). Remove the Haiku specific ifdef'ry. This reverts commit 652a46ebba970017c7a23767dcc983265cdb8eb

[PULL 06/27] travis.yml: Use the libfdt from the distro instead of the submodule

No need to compile-test third party submodules over and over again if we can simply use the pre-build library from the distribution instead. By also adding --enable-fdt=system to the configure options, we can also avoid to check out the "dtc" submodule here. Message-Id: <20230120075330.2076773-1-

[PULL 24/27] qapi, audio: Make introspection reflect build configuration more closely

From: Daniel P. Berrangé Currently the -audiodev accepts any audiodev type regardless of what is built in to QEMU. An error only occurs later at runtime when a sound device tries to use the audio backend. With this change QEMU will immediately reject -audiodev args that are not compiled into the

[PULL 11/27] qemu/bswap: Remove dependency

From: Philippe Mathieu-Daudé Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8, which supports __builtin_bswap(). Drop the dependency. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé R

[PULL 22/27] docs/s390x/pcidevices: document pci devices on s390x

From: Sebastian Mitterle Add some documentation about the zpci device and how to use it with pci devices on s390x. Used source: Cornelia Huck's blog post https://people.redhat.com/~cohuck/2018/02/19/notes-on-pci-on-s390x.html Signed-off-by: Sebastian Mitterle Reviewed-by: Cédric Le Goater Mes

[PULL 18/27] tests/qtest/vnc-display-test: Suppress build warnings on Windows

From: Philippe Mathieu-Daudé While this test is skipped on Windows, we still get when building: tests/qtest/vnc-display-test.c:22:20: warning: unused function 'on_vnc_error' [-Wunused-function] static inline void on_vnc_error(VncConnection* self, ^ tests/qtest/vnc-dis

[PULL 13/27] qemu/bswap: Use compiler __builtin_bswap() on FreeBSD

From: Philippe Mathieu-Daudé Since commit efc6c070aca ("configure: Add a test for the minimum compiler version") the minimum compiler version required for GCC is 4.8, which supports __builtin_bswap(). Remove the FreeBSD specific ifdef'ry. This reverts commit de03c3164accc21311c39327601fcdd95da30

[PULL 15/27] MAINTAINERS: Abort HAXM maintenance

From: Wenchao Wang Abort the maintenance of Guest CPU Cores (HAXM). * Clean up the maintainer list of X86 HAXM CPUs * Remove the web page URL and the mailing list * Change the status to Orphan Reviewed-by: Hang Yuan Signed-off-by: Wenchao Wang Message-Id: Signed-off-by: Thomas Huth --- MA

[PULL 25/27] gitlab-ci.d/buildtest: Remove ppc-softmmu from the clang-system job

We are also compile-testing ppc64-softmmu with clang in the "tsan-build" job, and ppc64-softmmu covers pretty much the same code as ppc-softmmu, so we should not lose much test coverage here by removing ppc-softmmu from the "clang-system" job. Message-Id: <20230130104446.1286773-2-th...@redhat.com

[PULL 21/27] tests/qtest/boot-serial-test: Constify tests[] array

From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20230120082341.59913-2-phi...@linaro.org> Signed-off-by: Thomas Huth --- tests/qtest/boot-serial-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtes

[PULL 27/27] gitlab-ci.d/buildtest: Merge the --without-default-* jobs

Let's safe some CI minutes by merging these two jobs. We can now also drop "--disable-capstone" since the capstone submodule has been removed a while ago. We should rather test --disable-fdt now to check a compilation without the "dtc" submodule (for this we have to drop i386-softmmu from the targe

[PULL 19/27] tests/qtest/vnc-display-test: Use the 'none' machine

From: Philippe Mathieu-Daudé If we don't specify any machine, an architecture default might be picked. But some architectures don't provide any default, such ARM: $ make check-qtest-aarch64 ... 19/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/vnc-display-test qemu-system-aarch64: No machin

[PULL 23/27] qapi, audio: add query-audiodev command

From: Daniel P. Berrangé Way back in QEMU 4.0, the -audiodev command line option was introduced for configuring audio backends. This CLI option does not use QemuOpts so it is not visible for introspection in 'query-command-line-options', instead using the QAPI Audiodev type. Unfortunately there

[PULL 01/27] tests/qtest: netdev: test stream and dgram backends

From: Laurent Vivier Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin Message-Id: <20230118120405.1876329-1-lviv...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/netdev-socket.c | 448 tests/qtest/meson.build | 2 + 2 files changed

[PULL 04/27] hw/misc/sifive_u_otp: Remove the deprecated OTP config with '-drive if=none'

'-drive if=none' is meant for configuring back-end devices only, so this got marked as deprecated in QEMU 6.2. Users should now only use the new way with '-drive if=pflash' instead. Message-Id: <20230112083921.887828-1-th...@redhat.com> Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-

[PULL 09/27] qemu/bswap: Replace bswapXX() by compiler __builtin_bswap()

From: Philippe Mathieu-Daudé Use the compiler built-in function to byte swap values, as the compiler is clever and will fold constants. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <2023063147.71761-2-phi...@linaro.org> S

[PULL 07/27] travis.yml: Remove the generic addons section

Each job uses its own addons section nowadays, so the generic section is completely unused and outdated, thus we can remove it now. Message-Id: <20230119135914.2040853-1-th...@redhat.com> Signed-off-by: Thomas Huth --- .travis.yml | 37 - 1 file changed, 37 de

[PATCH v9 02/12] parallels: Fix high_off calculation in parallels_co_check()

Don't let high_off be more than the file size even if we don't fix the image. Signed-off-by: Alexander Ivanov Reviewed-by: Denis V. Lunev --- block/parallels.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index 4af68adc61..436b36b

[PATCH v9 03/12] parallels: Fix image_end_offset and data_end after out-of-image check

Set data_end to the end of the last cluster inside the image. In such a way we can be sure that corrupted offsets in the BAT can't affect on the image size. If there are no allocated clusters set image_end_offset by data_end. Signed-off-by: Alexander Ivanov --- block/parallels.c | 8 +++- 1

[PATCH v9 08/12] parallels: Fix statistics calculation

Exclude out-of-image clusters from allocated and fragmented clusters calculation. Signed-off-by: Alexander Ivanov --- block/parallels.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/parallels.c b/block/parallels.c index f9acee1fa8..7382c01191 100644 --- a/block/parall

[PATCH v9 00/11] parallels: Refactor the code of images checks and fix a bug

Fix image inflation when offset in BAT is out of image. Replace whole BAT syncing by flushing only dirty blocks. Move all the checks outside the main check function in separate functions Use WITH_QEMU_LOCK_GUARD for simplier code. Fix incorrect condition in out-of-image check. v9: 3: Add (high

[PATCH v9 10/12] parallels: Move statistic collection to a separate function

We will add more and more checks so we need a better code structure in parallels_co_check. Let each check performs in a separate loop in a separate helper. Signed-off-by: Alexander Ivanov Reviewed-by: Denis V. Lunev Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/parallels.c | 52 +

[PATCH v9 12/12] parallels: Incorrect condition in out-of-image check

All the offsets in the BAT must be lower than the file size. Fix the check condition for correct check. Signed-off-by: Alexander Ivanov --- block/parallels.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/parallels.c b/block/parallels.c index e4faa14add..e469fe3f78 100

[PATCH v9 11/12] parallels: Replace qemu_co_mutex_lock by WITH_QEMU_LOCK_GUARD

Replace the way we use mutex in parallels_co_check() for simplier and less error prone code. Signed-off-by: Alexander Ivanov Reviewed-by: Denis V. Lunev --- block/parallels.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/block/parallels.

[PATCH v9 07/12] parallels: Move check of cluster outside image to a separate function

We will add more and more checks so we need a better code structure in parallels_co_check. Let each check performs in a separate loop in a separate helper. Signed-off-by: Alexander Ivanov --- block/parallels.c | 81 ++- 1 file changed, 52 insertions(+)

[PATCH v9 01/12] parallels: Out of image offset in BAT leads to image inflation

data_end field in BDRVParallelsState is set to the biggest offset present in BAT. If this offset is outside of the image, any further write will create the cluster at this offset and/or the image will be truncated to this offset on close. This is definitely not correct. Raise an error in parallels

[PATCH v9 05/12] parallels: Use generic infrastructure for BAT writing in parallels_co_check()

BAT is written in the context of conventional operations over the image inside bdrv_co_flush() when it calls parallels_co_flush_to_os() callback. Thus we should not modify BAT array directly, but call parallels_set_bat_entry() helper and bdrv_co_flush() further on. After that there is no need to ma

Re: [RFC PATCH] build: deprecate --enable-gprof builds and remove from CI

On 31/1/23 10:42, Alex Bennée wrote: As gprof relies on instrumentation you rarely get useful data compared to a real optimised build. Lets deprecate the build option and simplify the CI configuration as a result. Signed-off-by: Alex Bennée Cc: Thomas Huth --- docs/about/deprecated.rst | 14

[PATCH v9 06/12] parallels: Move check of unclean image to a separate function

We will add more and more checks so we need a better code structure in parallels_co_check. Let each check performs in a separate loop in a separate helper. Signed-off-by: Alexander Ivanov Reviewed-by: Denis V. Lunev Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/parallels.c | 31 +

[PATCH v9 09/12] parallels: Move check of leaks to a separate function

We will add more and more checks so we need a better code structure in parallels_co_check. Let each check performs in a separate loop in a separate helper. Signed-off-by: Alexander Ivanov --- block/parallels.c | 85 --- 1 file changed, 50 insertions(+)

[PATCH v9 04/12] parallels: create parallels_set_bat_entry_helper() to assign BAT value

This helper will be reused in next patches during parallels_co_check rework to simplify its code. Signed-off-by: Alexander Ivanov Reviewed-by: Denis V. Lunev Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/parallels.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff

Re: [RFC PATCH] build: deprecate --enable-gprof builds and remove from CI

On 31/1/23 11:36, Philippe Mathieu-Daudé wrote: On 31/1/23 10:42, Alex Bennée wrote: As gprof relies on instrumentation you rarely get useful data compared to a real optimised build. Lets deprecate the build option and simplify the CI configuration as a result. Signed-off-by: Alex Bennée Cc: T

Re: [RFC PATCH] build: deprecate --enable-gprof builds and remove from CI

On 31/01/2023 10.42, Alex Bennée wrote: As gprof relies on instrumentation you rarely get useful data compared to a real optimised build. Lets deprecate the build option and simplify the CI configuration as a result. Signed-off-by: Alex Bennée Cc: Thomas Huth --- Thanks for tackling this! R

Re: [PATCH v2] linux-user: Improve strace output of pread64() and pwrite64()

Le 30/01/2023 à 23:11, Helge Deller a écrit : On 1/30/23 10:26, Laurent Vivier wrote: Le 27/01/2023 à 21:58, Helge Deller a écrit : Make the strace look nicer for those two syscalls. Signed-off-by: Helge Deller --- v2: Use regpairs_aligned() and target_offset64(), noticed by Laurent Vivier d

Re: RFC: towards systemd socket activation in q-s-d

Am 30.01.2023 um 15:58 hat Daniel P. Berrangé geschrieben: > > I'm at a point where I can take a shot at implementing this, but want > > some feedback on whether it is better to try to shoehorn a generic > > solution into the existing @fd member of the SocketAddressType union, > > or whether it wou

Re: RFC: towards systemd socket activation in q-s-d

On Tue, Jan 31, 2023 at 12:17:07PM +0100, Kevin Wolf wrote: > Am 30.01.2023 um 15:58 hat Daniel P. Berrangé geschrieben: > > > I'm at a point where I can take a shot at implementing this, but want > > > some feedback on whether it is better to try to shoehorn a generic > > > solution into the exist

Re: [PULL 5/5] migration: simplify migration_iteration_run()

On 30.01.23 11:03, Juan Quintela wrote: Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 594a42f085..64

Re: [PATCH v2] linux-user: Show 4th argument of rt_sigprocmask() in strace

Le 30/01/2023 à 23:20, Helge Deller a écrit : Add output for the missing 4th parameter (size_t sigsetsize). Signed-off-by: Helge Deller --- v2: Use %u instead of %d, as suggested by Laurent Vivier diff --git a/linux-user/strace.c b/linux-user/strace.c index 3157e4b420..f0f6ada8cb 100644 --- a

Re: [RFC v4 3/3] hw/cxl: Multi-Region CXL Type-3 Devices (Volatile and Persistent)

On Mon, 28 Nov 2022 10:01:57 -0500 Gregory Price wrote: > From: Gregory Price > > This commit enables each CXL Type-3 device to contain one volatile > memory region and one persistent region. > > Two new properties have been added to cxl-type3 device initialization: > [volatile-memdev] and

[PATCH v2 17/20] hw/i386/ich9: Remove redundant GSI_NUM_PINS

Most code uses IOAPIC_NUM_PINS. The only place where GSI_NUM_PINS defines the size of an array is ICH9LPCState::gsi which needs to match IOAPIC_NUM_PINS. Remove GSI_NUM_PINS for consistency. Signed-off-by: Bernhard Beschow --- include/hw/i386/ich9.h | 2 +- include/hw/i386/x86.h | 1 - hw/i386/

[PATCH v2 06/20] hw/i386/pc_{q35, piix}: Minimize usage of get_system_memory()

Signed-off-by: Bernhard Beschow --- hw/i386/pc_piix.c | 2 +- hw/i386/pc_q35.c | 7 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index ee9d9a4175..5bde4533cc 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -241,7 +241,7 @@

[PATCH v2 19/20] hw/i386/ich9: Clean up includes

Signed-off-by: Bernhard Beschow --- include/hw/i386/ich9.h | 8 +--- hw/i386/acpi-build.c | 1 + hw/isa/lpc_ich9.c | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h index d29090a9b7..3125863049 100644 --- a/include/hw

[PATCH v2 13/20] hw/i2c/smbus_ich9: Inline ich9_smb_init() and remove it

ich9_smb_init() is a legacy init function, so modernize the code. Note that the smb_io_base parameter was unused. Signed-off-by: Bernhard Beschow --- include/hw/i386/ich9.h | 1 - hw/i2c/smbus_ich9.c| 13 +++-- hw/i386/pc_q35.c | 11 --- 3 files changed, 11 insertions

[PATCH v2 01/20] hw/pci-host/i440fx: Inline sysbus_add_io()

sysbus_add_io() just wraps memory_region_add_subregion() while also obscuring where the memory is attached. So use memory_region_add_subregion() directly and attach it to the existing memory region s->bus->address_space_io which is set as an alias to get_system_io() by the pc machine. Signed-off-b

[PATCH v2 11/20] hw/isa/lpc_ich9: Reuse memory and io address space of PCI bus

In pc_q35.c the PCI host bridge's io and memory space is initialized with get_system_memory() and get_system_io() respectively. Therefore, using pci_address_space() and pci_address_space_io() is equivalent. All in all this makes the LPC function respect whatever memory spaces the PCI bus was set up

[PATCH v2 09/20] hw/isa/lpc_ich9: Unexport PIRQ functions

No need to rely on the board to wire up the ICH9 PCI IRQs. All functions access private state of the LPC device which suggests that it should wire up the IRQs. Signed-off-by: Bernhard Beschow --- include/hw/i386/ich9.h | 3 --- hw/i386/pc_q35.c | 3 --- hw/isa/lpc_ich9.c | 11 ++

[PATCH v2 15/20] hw/isa/lpc_ich9: Connect pm stuff to lpc internally

Make TYPE_ICH9_LPC_DEVICE more self-contained by moving the call to ich9_lpc_pm_init() from board code to its realize function. In order to propagate x86_machine_is_smm_enabled(), introduce an "smm-enabled" property like we have in piix4. Signed-off-by: Bernhard Beschow --- include/hw/acpi/ich9.

[PATCH v2 03/20] hw/i386/pc_q35: Reuse machine parameter

Signed-off-by: Bernhard Beschow --- hw/i386/pc_q35.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 83c57c6eb1..351ef25f69 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -218,7 +218,7 @@ static void pc_q35_init(MachineState *

Re: [PATCH v5 5/9] tests/qtest/e1000e-test: Fabricate ethernet header

On 30/01/2023 15.08, Akihiko Odaki wrote: e1000e understands ethernet header so fabricate something convincing. Signed-off-by: Akihiko Odaki --- tests/qtest/e1000e-test.c | 17 +++-- tests/qtest/libqos/e1000e.h | 2 ++ 2 files changed, 13 insertions(+), 6 deletions(-) diff -

[PATCH v2 12/20] hw/i2c/smbus_ich9: Move ich9_smb_set_irq() in front of ich9_smbus_realize()

This is a preparation for the next commit to make it cleaner. Signed-off-by: Bernhard Beschow --- hw/i2c/smbus_ich9.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/i2c/smbus_ich9.c b/hw/i2c/smbus_ich9.c index ee50ba1f2c..06d97ac942 100644 --- a

Re: [PATCH v5 6/9] tests/qtest/libqos/e1000e: Export macreg functions

On 30/01/2023 15.08, Akihiko Odaki wrote: They will be useful for igb testing. Signed-off-by: Akihiko Odaki --- tests/qtest/libqos/e1000e.c | 12 tests/qtest/libqos/e1000e.h | 12 2 files changed, 12 insertions(+), 12 deletions(-) Reviewed-by: Thomas Huth

[PATCH v2 20/20] hw: Move ich9.h to southbridge/

ICH9 is a south bridge which doesn't necessarily depend on x86, so move it into the southbridge folder, analoguous to PIIX. Signed-off-by: Bernhard Beschow --- MAINTAINERS | 1 + include/hw/{i386 => southbridge}/ich9.h | 6 +++--- hw/acpi/ich9.c

[PATCH v2 14/20] hw/i386/pc_q35: Allow for setting properties before realizing TYPE_ICH9_LPC_DEVICE

This is a preparation to make the next patch cleaner. Signed-off-by: Bernhard Beschow --- hw/i386/pc_q35.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index fab8e57913..27a1fe351d 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q3

[PATCH v2 00/20] PC and ICH9 cleanups

This series contains some cleanups I came across when working on the PC machines. It consists of reducing the usage of global variables and eliminating some redundancies. The ICH9 cleanups include further QOM'ification, making it more self-contained, and reducing its x86/pc dependencies. Testing

[PATCH v2 18/20] hw: Move ioapic*.h to intc/

The ioapic sources reside in hw/intc already. Move the headers there as well. Signed-off-by: Bernhard Beschow --- MAINTAINERS | 1 + include/hw/i386/x86.h | 2 +- include/hw/{i386 => intc}/ioapic.h | 6 +++--- include/hw/{i386 => int

[PATCH v2 16/20] hw/isa/lpc_ich9: Remove redundant ich9_lpc_reset() invocation

ich9_lpc_reset() is the dc->reset callback which is called automatically. No need to call it explicitly during k->realize. Signed-off-by: Bernhard Beschow --- hw/isa/lpc_ich9.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index 7d21857d53..b2842f27

[PATCH v2 10/20] hw/isa/lpc_ich9: Eliminate ICH9LPCState::isa_bus

By using qdev_get_child_bus() we can eliminate ICH9LPCState::isa_bus and spare the ich9_lpc variable in pc_q35, too. Signed-off-by: Bernhard Beschow --- include/hw/i386/ich9.h | 3 --- hw/i386/pc_q35.c | 4 +--- hw/isa/lpc_ich9.c | 5 + 3 files changed, 2 insertions(+), 10 deletio

[PATCH v2 04/20] hw/i386/pc_q35: Resolve redundant q35_host variable

The variable is redundant to "phb" and is never used by its real type. Signed-off-by: Bernhard Beschow --- hw/i386/pc_q35.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 351ef25f69..88324af91f 100644 ---

[PATCH v2 08/20] hw/i386/ich9: Rename Q35_MASK to ICH9_MASK

The Q35_MASK macro is already defined by TYPE_Q35_HOST_DEVICE, so let TYPE_ICH9_LPC_DEVICE have its own one to prevent potential name clash. Signed-off-by: Bernhard Beschow --- include/hw/i386/ich9.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/hw/i386/i

[PATCH v2 02/20] hw/pci-host/q35: Inline sysbus_add_io()

sysbus_add_io() just wraps memory_region_add_subregion() while also obscuring where the memory is attached. So use memory_region_add_subregion() directly and attach it to the existing memory region s->mch.address_space_io which is set as an alias to get_system_io() by the q35 machine. Signed-off-b

[PATCH v2 07/20] hw/i386/pc: Initialize ram_memory variable directly

Going through pc_memory_init() seems quite complicated for a simple assignment. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 1 - hw/i386/pc.c | 2 -- hw/i386/pc_piix.c| 4 ++-- hw/i386/pc_q35.c | 5 ++--- 4 files changed, 4 inse

Re: [PATCH v2] linux-user: Show 4th argument of rt_sigprocmask() in strace

Le 30/01/2023 à 23:20, Helge Deller a écrit : Add output for the missing 4th parameter (size_t sigsetsize). Signed-off-by: Helge Deller --- v2: Use %u instead of %d, as suggested by Laurent Vivier diff --git a/linux-user/strace.c b/linux-user/strace.c index 3157e4b420..f0f6ada8cb 100644 --- a

[PATCH v2 05/20] hw/i386/pc_{q35, piix}: Reuse MachineClass::desc as SMB product name

No need to repeat the descriptions. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/pc_piix.c | 2 +- hw/i386/pc_q35.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index df64dd8dcc..ee9d9a4175 10064

Re: [PATCH v2] linux-user: Enhance strace output for various syscalls

Le 12/12/2022 à 19:01, Helge Deller a écrit : Add appropriate strace printf formats for various Linux syscalls. Signed-off-by: Helge Deller Reviewed-by: Philippe Mathieu-Daudé --- v2: Fixed a few entries based on review by Philippe Mathieu-Daudé diff --git a/linux-user/strace.list b/linux-us

  1   2   3   4   >