[PATCH qemu 1/1] Remove a stray "@end table" marker

From: Gurjeet Singh Signed-off-by: Gurjeet Singh --- docs/system/cpu-models-x86.rst.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/cpu-models-x86.rst.inc b/docs/system/cpu-models-x86.rst.inc index 7f6368f999..261da6e21d 100644 --- a/docs/system/cpu-models-x

Re: [PATCH] docs/s390x/pcidevices: document pci devices on s390x

On 1/25/23 18:15, Sebastian Mitterle wrote: Add some documentation about the zpci device and how to use it with pci devices on s390x. Used source: Cornelia Huck's blog post https://people.redhat.com/~cohuck/2018/02/19/notes-on-pci-on-s390x.html Signed-off-by: Sebastian Mitterle --- docs/syst

[PATCH qemu] Remove a stray "@end table" marker

From: Gurjeet Singh Signed-off-by: Gurjeet Singh --- docs/system/cpu-models-x86.rst.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/cpu-models-x86.rst.inc b/docs/system/cpu-models-x86.rst.inc index 7f6368f999..261da6e21d 100644 --- a/docs/system/cpu-models-x

[PATCH qemu 0/1] Minor doc patch

PS: Sorry for the duplicate email; I forgot to CC myself the last time. I'm using Sourcehut's web-based send-email, as recommended in submitting-a-patch.html#submitting-your-patches docs. Gurjeet Singh (1): Remove a stray "@end table" marker docs/system/cpu-models-x86.rst.inc | 2 +- 1 file ch

Re: [PATCH 3/3] util/userfaultfd: Support /dev/userfaultfd

On Wed, Jan 25, 2023 at 05:40:16PM -0500, Peter Xu wrote: > Teach QEMU to use /dev/userfaultfd when it existed and fallback to the > system call if either it's not there or doesn't have enough permission. > > Firstly, as long as the app has permission to access /dev/userfaultfd, it > always have t

Re: [PATCH 3/3] util/userfaultfd: Support /dev/userfaultfd

On Thu, Jan 26, 2023 at 09:02:09AM +, Daniel P. Berrangé wrote: > On Wed, Jan 25, 2023 at 05:40:16PM -0500, Peter Xu wrote: > > Teach QEMU to use /dev/userfaultfd when it existed and fallback to the > > system call if either it's not there or doesn't have enough permission. > > > > Firstly, as

RE: [PATCH v2 00/13] Introduce igb

> -Original Message- > From: Sriram Yagnaraman > Sent: Tuesday, 24 January 2023 09:54 > To: Akihiko Odaki ; Jason Wang > > Cc: Dmitry Fleytman ; Michael S. Tsirkin > ; Marcel Apfelbaum ; > Alex Bennée ; Philippe Mathieu-Daudé > ; Thomas Huth ; Wainer dos Santos > Moschetta ; Beraldo Leal

Re: [PATCH v5 24/36] target/s390x: Use a single return for helper_divs32/u32

On 26.01.23 05:38, Richard Henderson wrote: Pack the quotient and remainder into a single uint64_t. Signed-off-by: Richard Henderson --- v2: Fix operand ordering; use tcg_extr32_i64. Cc: David Hildenbrand Cc: Ilya Leoshkevich --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb

Re: [PATCH v2 0/7] hw/cxl: RAS error emulation and injection

On Wed, 25 Jan 2023 21:42:04 -0800 Ira Weiny wrote: > Jonathan Cameron wrote: > > v2: Thanks to Mike Maslenkin for review. > > - Fix wrong parameter type to ct3d_qmp_cor_err_to_cxl() > > - Rework use of CXLError local variable in ct3d_reg_write() to improve > > code readability. > > > > CXL er

Re: [PATCH v5 30/36] target/s390x: Use Int128 for returning float128

On 26.01.23 05:38, Richard Henderson wrote: Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- v2: Remove extraneous return_low128. Cc: David Hildenbrand Cc: Ilya Leoshkevich --- Acked-by: David Hildenbrand -- Thanks, David / dhildenb

Re: [PATCH v7 6/7] mac_newworld: Deprecate mac99 "via" option

On Tue, Jan 24, 2023 at 4:33 PM BALATON Zoltan wrote: > On Tue, 24 Jan 2023, Howard Spoelstra wrote: > > On Tue, Jan 24, 2023 at 3:15 PM BALATON Zoltan > wrote: > >> I thought MacOS 8 needed old world ROM but looks like it can also load > it > >> from disk on new world machines. Then what versio

Re: [PATCH v4 0/7] AML Housekeeping

Am 25. Januar 2023 16:52:34 UTC schrieb Igor Mammedov : >On Sat, 21 Jan 2023 16:19:34 +0100 >Bernhard Beschow wrote: > >> This series factors out AcpiCpuAmlIfClass::madt_cpu from AcpiDeviceIfClass. >> By letting the (x86) CPUs implement the new interface, AML generation is >> delegated to the C

[PATCH v3 00/26] e1000x cleanups (preliminary for IGB)

We are adding a new device named igb, yet another Intel NIC. As the new implementation derives from e1000e, overhaul e1000e implementation first. e1000 has many commonalities with e1000e so we also apply the corresponding changes to the device if possible. This was spun off from: https://patchew.o

[PATCH v3 05/26] e1000: Mask registers when writing

When a register has effective bits fewer than their width, the old code inconsistently masked when writing or reading. Make the code consistent by always masking when writing, and remove some code duplication. Signed-off-by: Akihiko Odaki --- hw/net/e1000.c | 84 +++--

[PATCH v3 01/26] e1000e: Fix the code style

igb implementation first starts off by copying e1000e code. Correct the code style before that. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé --- hw/net/e1000.c | 41 hw/net/e1000e.c| 72 ++-- hw/net/e1000e_core.c |

[PATCH v3 04/26] e1000: Use hw/net/mii.h

hw/net/mii.h provides common definitions for MII. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé --- hw/net/e1000.c | 86 ++-- hw/net/e1000_regs.h| 46 hw/net/e1000e.c| 1 + hw/net/e1000e_core.c | 99 +

[PATCH v3 14/26] e1000e: Configure ResettableClass

This is part of recent efforts of refactoring e1000 and e1000e. DeviceClass's reset member is deprecated so migrate to ResettableClass. There is no behavioral difference. Signed-off-by: Akihiko Odaki Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- hw/net/e1000e.c | 10 +

[PATCH v3 15/26] e1000e: Introduce e1000_rx_desc_union

Before this change, e1000e_write_packet_to_guest() allocated the receive descriptor buffer as an array of uint8_t. This does not ensure the buffer is sufficiently aligned. Introduce e1000_rx_desc_union type, a union type of all receive descriptor types to correct this. Signed-off-by: Akihiko Odak

[PATCH v3 06/26] e1000e: Mask registers when writing

When a register has effective bits fewer than their width, the old code inconsistently masked when writing or reading. Make the code consistent by always masking when writing, and remove some code duplication. Signed-off-by: Akihiko Odaki --- hw/net/e1000e_core.c | 94 +++

[PATCH v3 02/26] hw/net: Add more MII definitions

The definitions will be used by igb. Signed-off-by: Akihiko Odaki --- include/hw/net/mii.h | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/include/hw/net/mii.h b/include/hw/net/mii.h index 4ae4dcce7e..c6a767a49a 100644 --- a/include/hw/net/mii.h +++ b/include/hw

[PATCH v3 11/26] e1000e: Remove pending interrupt flags

They are duplicate of running throttling timer flags and incomplete as the flags are not cleared when the interrupts are fired or the device is reset. Signed-off-by: Akihiko Odaki --- hw/net/e1000e.c | 5 ++--- hw/net/e1000e_core.c | 19 +++ hw/net/e1000e_core.h | 2 -- hw

[PATCH v3 12/26] e1000e: Improve software reset

This change makes e1000e reset more things when software reset was triggered. Some registers are exempted from software reset in the datasheet and this change also implements the behavior accordingly. Signed-off-by: Akihiko Odaki --- hw/net/e1000e_core.c | 24 +++- 1 file cha

[PATCH v3 03/26] fsl_etsec: Use hw/net/mii.h

hw/net/mii.h provides common definitions for MII. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé --- hw/net/fsl_etsec/etsec.c | 11 ++- hw/net/fsl_etsec/etsec.h | 17 - hw/net/fsl_etsec/miim.c | 5 +++-- include/hw/net/mii.h | 1 + 4 files change

[PATCH v3 13/26] e1000: Configure ResettableClass

This is part of recent efforts of refactoring e1000 and e1000e. DeviceClass's reset member is deprecated so migrate to ResettableClass. There is no behavioral difference. Signed-off-by: Akihiko Odaki Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé --- hw/net/e1000.c | 13 --

[PATCH v3 23/26] e1000e: Perform software segmentation for loopback

e1000e didn't perform software segmentation for loopback if virtio-net header is enabled, which is wrong. To fix the problem, introduce net_tx_pkt_send_custom(), which allows the caller to specify whether offloading should be assumed or not. net_tx_pkt_send_custom() also allows the caller to prov

[PATCH v3 08/26] e1000e: Use more constant definitions

The definitions of SW Semaphore Register were copied from: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/net/ethernet/intel/e1000e/defines.h?h=v6.0.9#n374 Signed-off-by: Akihiko Odaki --- hw/net/e1000_regs.h | 7 +++ hw/net/e1000e_core.c | 49 +++

[PATCH v3 26/26] MAINTAINERS: Add e1000e test files

Signed-off-by: Akihiko Odaki Acked-by: Thomas Huth --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 958915f227..e920d0061e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2218,6 +2218,8 @@ R: Akihiko Odaki S: Maintained F: hw/net/e1000e* F:

[PATCH v3 07/26] e1000: Use more constant definitions

The definitions for E1000_VFTA_ENTRY_SHIFT, E1000_VFTA_ENTRY_MASK, and E1000_VFTA_ENTRY_BIT_SHIFT_MASK were copied from: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/net/ethernet/intel/e1000/e1000_hw.h?h=v6.0.9#n306 The definitions for E1000_NUM_UNICAST, E1000_MC_T

[PATCH v3 22/26] hw/net/net_rx_pkt: Remove net_rx_pkt_has_virt_hdr

When virtio-net header is not set, net_rx_pkt_get_vhdr() returns zero-filled virtio_net_hdr, which is actually valid. In fact, tap device uses zero-filled virtio_net_hdr when virtio-net header is not provided by the peer. Therefore, we can just remove net_rx_pkt_has_virt_hdr() and always assume Net

[PATCH v3 17/26] e1000e: Remove extra pointer indirection

e1000e_write_packet_to_guest() passes the reference of variable ba as a pointer to an array, and that pointer indirection is just unnecessary; all functions which uses the passed reference performs no pointer operation on the pointer and they simply dereference the passed pointer. Remove the extra

[PATCH v3 25/26] MAINTAINERS: Add Akihiko Odaki as a e1000e reviewer

I want to know to be notified when there is a new change for e1000e as e1000e is similar to igb and such a change may also be applicable for igb. Signed-off-by: Akihiko Odaki --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 08ad1e5341..958915f

[PATCH v3 10/26] e1000e: Use memcpy to intialize registers

Use memcpy instead of memmove to initialize registers. The initial register templates and register table instances will never overlap. Signed-off-by: Akihiko Odaki --- hw/net/e1000e_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000

[PATCH v3 16/26] e1000e: Set MII_ANER_NWAY

This keeps Windows driver 12.18.9.23 from generating an event with ID 30. The description of the event is as follows: > Intel(R) 82574L Gigabit Network Connection > PROBLEM: The network adapter is configured for auto-negotiation but > the link partner is not. This may result in a duplex mismatch.

[PATCH v3 20/26] net: Strip virtio-net header when dumping

filter-dump specifiees Ethernet as PCAP LinkType, which does not expect virtio-net header. Having virtio-net header in such PCAP file breaks PCAP unconsumable. Unfortunately currently there is no LinkType for virtio-net so for now strip virtio-net header to convert the output to Ethernet. Signed-o

[PATCH v3 18/26] net: Check L4 header size

net_tx_pkt_build_vheader() inspects TCP header but had no check for the header size, resulting in an undefined behavior. Check the header size and drop the packet if the header is too small. Signed-off-by: Akihiko Odaki --- hw/net/e1000e_core.c | 19 ++- hw/net/net_tx_pkt.c | 13

[PATCH v3 19/26] e1000x: Alter the signature of e1000x_is_vlan_packet

e1000x_is_vlan_packet() had a pointer to uint8_t as a parameter, but it does not have to be uint8_t. Change the type to void *. Signed-off-by: Akihiko Odaki --- hw/net/e1000x_common.c | 2 +- hw/net/e1000x_common.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/e10

[PATCH v3 21/26] hw/net/net_tx_pkt: Automatically determine if virtio-net header is used

The new function qemu_get_using_vnet_hdr() allows to automatically determine if virtio-net header is used. Signed-off-by: Akihiko Odaki --- hw/net/e1000e_core.c | 3 +-- hw/net/net_tx_pkt.c | 19 ++- hw/net/net_tx_pkt.h | 3 +-- hw/net/vmxnet3.c | 6 ++ 4 files chang

[PATCH v3 24/26] hw/net/net_tx_pkt: Implement TCP segmentation

There was no proper implementation of TCP segmentation before this change, and net_tx_pkt relied solely on IPv4 fragmentation. Not only this is not aligned with the specification, but it also resulted in corrupted IPv6 packets. This is particularly problematic for the igb, a new proposed device im

[PATCH v3 09/26] e1000: Use memcpy to intialize registers

Use memcpy instead of memmove to initialize registers. The initial register templates and register table instances will never overlap. Signed-off-by: Akihiko Odaki --- hw/net/e1000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index d9d

Re: [PATCH v4 2/2] qtests/arm: add some mte tests

On Mon, Jan 23 2023, Eric Auger wrote: > Hi Connie, > On 1/11/23 17:13, Cornelia Huck wrote: >> Acked-by: Thomas Huth >> Signed-off-by: Cornelia Huck > Maybe add some extra information about what tests are run. Also you > could add an example of test invocation so that any people interested in

[PATCH v4 02/13] pcie: Introduce pcie_sriov_num_vfs

igb can use this function to change its behavior depending on the number of virtual functions currently enabled. Signed-off-by: Gal Hammer Signed-off-by: Marcel Apfelbaum Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé --- hw/pci/pcie_sriov.c | 5 + include/hw/pci

Re: [PATCH v5 31/36] target/s390x: Use Int128 for passing float128

On 26.01.23 05:38, Richard Henderson wrote: Signed-off-by: Richard Henderson --- v2: Fix SPEC_in1_x1. Cc: David Hildenbrand Cc: Ilya Leoshkevich --- Acked-by: David Hildenbrand -- Thanks, David / dhildenb

[PATCH v4 03/13] e1000: Split header files

Some definitions in the header files are invalid for igb so extract them to new header files to keep igb from referring to them. Signed-off-by: Gal Hammer Signed-off-by: Marcel Apfelbaum Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé --- hw/net/e1000.c | 1 + hw/ne

[PATCH v4 05/13] igb: Rename identifiers

Rename identifiers of definitions which will be modified later for igb. This will also allow to build igb along with e1000e. Signed-off-by: Gal Hammer Signed-off-by: Marcel Apfelbaum Signed-off-by: Akihiko Odaki --- hw/net/igb.c| 368 +- hw/net/igb_common.h |6 +- hw/net/i

[PATCH v4 11/13] tests/qtest/libqos/igb: Transform to igb tests

Signed-off-by: Akihiko Odaki --- tests/qtest/fuzz/generic_fuzz_configs.h | 5 + tests/qtest/igb-test.c | 67 ++-- tests/qtest/libqos/igb.c| 139 +--- tests/qtest/libqos/meson.build | 1 + tests/qtest/meson.build

[PATCH v4 04/13] igb: Copy e1000e code

Start off igb implementation by copying e1000e code first as igb resembles e1000e. Signed-off-by: Gal Hammer Signed-off-by: Marcel Apfelbaum Signed-off-by: Akihiko Odaki --- MAINTAINERS |5 + hw/net/igb.c| 727 + hw/net/igb_common.h | 102 ++ hw/net/igb_core.c |

[PATCH v4 09/13] tests/qtest/libqos/e1000e: Export macreg functions

They will be useful for igb testing. Signed-off-by: Akihiko Odaki --- tests/qtest/libqos/e1000e.c | 12 tests/qtest/libqos/e1000e.h | 12 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/tests/qtest/libqos/e1000e.c b/tests/qtest/libqos/e1000e.c index 28f

[PATCH v4 06/13] igb: Build igb

Currently igb functions identically with e1000e. Signed-off-by: Gal Hammer Signed-off-by: Marcel Apfelbaum Signed-off-by: Akihiko Odaki --- hw/net/Kconfig | 5 + hw/net/meson.build | 2 ++ 2 files changed, 7 insertions(+) diff --git a/hw/net/Kconfig b/hw/net/Kconfig index 1cc1c5775e..

[PATCH v4 08/13] tests/qtest/e1000e-test: Fabricate ethernet header

e1000e understands ethernet header so fabricate something convincing. Signed-off-by: Akihiko Odaki --- tests/qtest/e1000e-test.c | 17 +++-- tests/qtest/libqos/e1000e.h | 2 ++ 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/tests/qtest/e1000e-test.c b/tests/qtest/

[PATCH v4 13/13] docs/system/devices/igb: Add igb documentation

Signed-off-by: Akihiko Odaki --- MAINTAINERS | 1 + docs/system/device-emulation.rst | 1 + docs/system/devices/igb.rst | 71 3 files changed, 73 insertions(+) create mode 100644 docs/system/devices/igb.rst diff --git a/MAINTAINERS b/

[PULL 03/35] gitlab: just use plain --cc=clang for custom runner build

I think this was because older Ubuntu's didn't alias clang to whatever the latest version was. They do now so lets use that and not break. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20230124180127.1881110-4-alex.ben...@linaro.org>

[PATCH v4 01/13] hw/net/net_tx_pkt: Introduce net_tx_pkt_get_eth_hdr

Expose the ethernet header so that igb can utilize it to perform the internal routing among its SR-IOV functions. Signed-off-by: Gal Hammer Signed-off-by: Marcel Apfelbaum Signed-off-by: Akihiko Odaki --- hw/net/net_tx_pkt.c | 6 ++ hw/net/net_tx_pkt.h | 8 2 files changed, 14 ins

[PULL 02/35] gitlab: add FF_SCRIPT_SECTIONS for timings

From: Mark Cave-Ayland Suggested-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Daniel P. Berrangé Message-Id: <20230124180127.1881110-3-alex.ben...@linaro.org> diff --git a/.gitlab-c

[PULL 32/35] translator: always pair plugin_gen_insn_{start, end} calls

From: Emilio Cota Related: #1381 Signed-off-by: Emilio Cota Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20230108164731.61469-3-c...@braap.org> Signed-off-by: Alex Bennée Message-Id: <20230124180127.1881110-33-alex.ben...@linaro.org> diff --git a/accel/tcg

[PATCH v4 00/13] Introduce igb

Based-on: <20230126104705.35023-1-akihiko.od...@daynix.com> ([PATCH v3 00/26] e1000x cleanups (preliminary for IGB)) igb is a family of Intel's gigabit ethernet controllers. This series implements 82576 emulation in particular. You can see the last patch for the documentation. Note that there is

[PULL 10/35] Update lcitool and fedora to 37

From: Marc-André Lureau Fedora 35 is EOL. Update to upstream lcitool, that dropped f35 and added f37. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230110132700.833690-7-marcandre.lur...@redhat.com> Signed-off-by: Alex Bennée Me

[PATCH v4 12/13] tests/avocado: Add igb test

This automates ethtool tests for igb registers, interrupts, etc. Signed-off-by: Akihiko Odaki --- MAINTAINERS | 1 + .../org.centos/stream/8/x86_64/test-avocado | 1 + tests/avocado/igb.py | 38 +++ 3 files changed, 4

[PULL 06/35] .gitlab-ci.d/windows: do not disable opengl

From: Marc-André Lureau The previous patch should have fixed shader compilation. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230110132700.833690-3-marcandre.lur...@redhat.com> [AJB: tweak commit message] Signed-off-by: Alex Benn

[PULL 13/35] tests/docker: Install flex in debian-tricore-cross

From: Philippe Mathieu-Daudé When flex is not available, binutils sources default to the 'missing' script, but the current script available is not in the format expected by the 'configure' script: $ ./configure ... /usr/src/binutils/missing: Unknown `--run' option Try `/usr/src/binutils/

[PATCH v4 10/13] tests/qtest/libqos/igb: Copy e1000e code

Start off igb test implementation by copying e1000e code first as igb resembles e1000e. Signed-off-by: Akihiko Odaki --- MAINTAINERS | 2 + tests/qtest/igb-test.c | 242 +++ tests/qtest/libqos/igb.c | 226

[PULL 11/35] lcitool: drop perl from QEMU project/dependencies

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230110132700.833690-8-marcandre.lur...@redhat.com> Signed-off-by: Alex Bennée Message-Id: <20230124180127.1881110-12-alex.ben...@linaro.org> diff --git

[PULL 05/35] build-sys: fix crlf-ending C code

From: Marc-André Lureau On msys2, the shader-to-C script produces bad C: ./ui/shader/texture-blit-vert.h:2:5: error: missing terminating " character [-Werror] Fix it by changing the line ending from crlf to lf, and convert the script to Python (qemu build seems perl-free after that). Signed-of

[PULL 17/35] gitlab: wrap up test results for custom runners

Instead of spewing the whole log to stdout lets just define them as build artefacts so we can examine them later. Where we are running check-tcg run it first as those tests are yet to be integrated into meson. To avoid confusion we don't run multiple check-tcg tests at once. Reviewed-by: Thomas Hu

[PULL 26/35] cpu: free cpu->tb_jmp_cache with RCU

From: Emilio Cota Fixes the appended use-after-free. The root cause is that during tb invalidation we use CPU_FOREACH, and therefore to safely free a vCPU we must wait for an RCU grace period to elapse. $ x86_64-linux-user/qemu-x86_64 tests/tcg/x86_64-linux-user/munmap-pthread ==

[PULL 15/35] tests/tcg: skip the vma-pthread test on CI

We are getting a lot of failures that are not related to changes so this could be a flaky test. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20230124180127.1881110-16-alex.ben...@linaro.org> diff --git a/tests/tcg/multiarch/Makefile.target b/tests/tcg/multiarch/Makefi

[PULL 12/35] lcitool: drop texinfo from QEMU project/dependencies

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-Id: <20230110132700.833690-9-marcandre.lur...@redhat.com> Signed-off-by: Alex Bennée Message-Id: <20230124180127.1881110-13-alex.ben...@linaro.org> diff --git a/.gitlab-ci.d/cirrus/freebsd-12.vars

[PULL 18/35] MAINTAINERS: Fix the entry for tests/tcg/nios2

From: Thomas Huth tests/tcg/nios2/Makefile.target has accidentally been added to the Microblaze section. Move it into the correct nios2 section instead - and while we're at it, it should also cover the whole folder, and not only the Makefile. Fixes: 67f80eb4d0 ("tests/tcg: enable debian-nios2-cr

[PULL 20/35] docs: add a new section to outline emulation support

This affects both system and user mode emulation so we should probably list it up front. Acked-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20230124180127.1881110-21-alex.ben...@linaro.org> diff --git a/docs/about/emulation.rst b/docs/about/emulation.rst new file mode 100644 in

[PULL 28/35] thread: de-const qemu_spin_destroy

From: Emilio Cota Reviewed-by: Alex Bennée Signed-off-by: Emilio Cota Reviewed-by: Richard Henderson Message-Id: <2023051628.320011-4-c...@braap.org> Signed-off-by: Alex Bennée Message-Id: <20230124180127.1881110-29-alex.ben...@linaro.org> diff --git a/include/qemu/thread.h b/include/qem

[PULL 24/35] semihosting: add O_BINARY flag in host_open for NT compatibility

From: Evgeny Iakovlev Windows open(2) implementation opens files in text mode by default and needs a Windows-only O_BINARY flag to open files as binary. QEMU already knows about that flag in osdep and it is defined to 0 on non-Windows, so we can just add it to the host_flags for better compatibil

[PULL 09/35] gitlab: add lsan suppression file to workaround tcmalloc issues

The up-coming upgrade to Fedora 37 will bring in libtcmalloc as a dependency of libglusterfs which confuses our fuzz run. Rather than disable the build lets use LSAN's suppression mechanism to prevent the job from failing. Signed-off-by: Alex Bennée Cc: Daniel P. Berrangé Reviewed-by: Philippe M

[PULL 07/35] meson: replace Perl usage with Python

From: Marc-André Lureau Let's try to remove Perl usage during build time. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-Id: <20230110132700.833690-5-marcandre.lur...@redhat.com> Signed-off-by: Alex Bennée Message-Id: <20230124180127.1881110-8-alex.ben...@linaro.org>

[PULL 14/35] tests/docker: drop debian-tricore-cross's partial status

This image is perfectly capable of building QEMU, and indeed we do that on gitlab. Drop the DOCKER_PARTIAL_IMAGES setting so we can also test the gitlab build locally. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20230124180127.1881110-15-alex.ben...@linaro.org> d

[PULL 31/35] plugins: fix optimization in plugin_gen_disable_mem_helpers

From: Emilio Cota We were mistakenly checking tcg_ctx->plugin_insn as a canary to know whether the TB had emitted helpers that might have accessed memory. The problem is that tcg_ctx->plugin_insn gets updated on every instruction in the TB, which results in us wrongly performing the optimization

[PULL 08/35] docs: drop texinfo options

From: Marc-André Lureau It looks like this is no longer wanted, we only build the html output. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé Message-Id: <20230110132700.833690-6-marcandre.lur...@redhat.com> Signed-off-by: Alex Bennée Message-Id: <20230124180127.1881110-9-al

Re: [PATCH v5 32/36] target/s390x: Use tcg_gen_atomic_cmpxchg_i128 for CDSG

static DisasJumpType op_csst(DisasContext *s, DisasOps *o) @@ -5419,6 +5410,14 @@ static void prep_r1_P(DisasContext *s, DisasOps *o) } #define SPEC_prep_r1_P SPEC_r1_even +static void prep_r1_D64(DisasContext *s, DisasOps *o) +{ +int r1 = get_field(s, r1); +o->out_128 = tcg_temp

Re: [PATCH v5 33/36] target/s390x: Implement CC_OP_NZ in gen_op_calc_cc

On 26.01.23 05:38, Richard Henderson wrote: This case is trivial to implement inline. Signed-off-by: Richard Henderson --- Cc: David Hildenbrand Cc: Ilya Leoshkevich --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb

[PULL 29/35] util/qht: use striped locks under TSAN

From: Emilio Cota Fixes this tsan crash, easy to reproduce with any large enough program: $ tests/unit/test-qht 1..2 ThreadSanitizer: CHECK failed: sanitizer_deadlock_detector.h:67 "((n_all_locks_)) < (((sizeof(all_locks_with_contexts_)/sizeof((all_locks_with_contexts_)[0]" (0x40, 0x40) (

[PULL 30/35] plugins: make qemu_plugin_user_exit's locking order consistent with fork_start's

From: Emilio Cota To fix potential deadlocks as reported by tsan. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Emilio Cota Message-Id: <2023051628.320011-6-c...@braap.org> Signed-off-by: Alex Bennée Message-Id: <20230124180127.1881110-31-alex.ben...@l

[PULL 00/35] Testing, docs, semihosting and plugin updates

The following changes since commit 13356edb87506c148b163b8c7eb0695647d00c2a: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2023-01-24 09:45:33 +) are available in the Git repository at: https://gitlab.com/stsquad/qemu.git tags/pull-jan-omnibus-260123-1

[PULL 34/35] cpu-exec: assert that plugin_mem_cbs is NULL after execution

From: Emilio Cota Fixes: #1381 Signed-off-by: Emilio Cota Message-Id: <20230108165107.62488-1-c...@braap.org> [AJB: manually applied follow-up fix] Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20230124180127.1881110-35-alex.ben...

[PULL 04/35] tests/unit: drop hacky race avoidance in test-io-channel-command

We don't need to play timing games to ensure one socat wins over the other, just create the fifo they both can use before spawning the processes. However in the process we need to disable two tests for Windows platforms as we don't have an abstraction for mkfifo(). Resolves: https://gitlab.com/qem

[PULL 23/35] semihosting: Write back semihosting data before completion callback

From: Keith Packard 'lock_user' allocates a host buffer to shadow a target buffer, 'unlock_user' copies that host buffer back to the target and frees the host memory. If the completion function uses the target buffer, it must be called after unlock_user to ensure the data are present. This cause

Re: [PATCH v2 00/13] Introduce igb

On 2023/01/26 18:34, Sriram Yagnaraman wrote: -Original Message- From: Sriram Yagnaraman Sent: Tuesday, 24 January 2023 09:54 To: Akihiko Odaki ; Jason Wang Cc: Dmitry Fleytman ; Michael S. Tsirkin ; Marcel Apfelbaum ; Alex Bennée ; Philippe Mathieu-Daudé ; Thomas Huth ; Wainer dos San

[PULL 19/35] docs: add hotlinks to about preface text

Make it easier to navigate the documentation. Reviewed-by: Peter Maydell Acked-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230124180127.1881110-20-alex.ben...@linaro.org> diff --git a/docs/about/index.rst b/docs/about/index.rst index 5be

[PULL 27/35] util/qht: add missing atomic_set(hashes[i])

From: Emilio Cota We forgot to add this one in "a890643958 util/qht: atomically set b->hashes". Detected with tsan. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée Signed-off-by: Emilio Cota Message-Id: <2023051628.320011-3-c...@braap.org> Sig

[PULL 01/35] scripts/ci: update gitlab-runner playbook to use latest runner

We were using quite and old runner on our machines and running into issues with stalling jobs. Gitlab in the meantime now reliably provide the latest packaged versions of the runner under a stable URL. This update: - creates a per-arch subdir for builds - switches from binary tarballs to deb p

[PULL 25/35] tests/tcg: add memory-sve test for aarch64

This will be helpful in debugging problems with tracking SVE memory accesses via the TCG plugins system. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Cc: Robert Henry Cc: Aaron Lindsay Message-Id: <20230124180127.1881110-26-alex.ben...@linaro.org> diff --git a/tests/tcg/aarch64/M

[PULL 16/35] tests/tcg: Use SIGKILL for timeout

From: Richard Henderson linux-user blocks all signals while attempting to handle guest signals (e.g. ABRT), which means that the default TERM sent by timeout has no effect -- KILL instead. Signed-off-by: Richard Henderson Message-Id: <20230117035701.168514-2-richard.hender...@linaro.org> [AJB:

[PULL 35/35] plugins: Iterate on cb_lists in qemu_plugin_user_exit

From: Richard Henderson Rather than iterate over all plugins for all events, iterate over plugins that have registered a given event. Signed-off-by: Richard Henderson Message-Id: <20230117035701.168514-4-richard.hender...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Benn

[PULL 22/35] docs: add an introduction to the system docs

Drop the frankly misleading quickstart section for a more rounded introduction section. This new section gives an overview of the accelerators as well as a high level introduction to some of the key features of the emulator. We also expand on a general form for a QEMU command line with a hopefully

[PULL 33/35] tcg: exclude non-memory effecting helpers from instrumentation

From: Emilio Cota There are actually a whole bunch of helpers that don't affect memory that we shouldn't instrument. They are helpfully identified by the TCG_CALL_NO_SIDE_EFFECTS flag which marks out lookup_tb_ptr as well as a lot of the maths helpers. To avoid the string compare we introduce a n

[PULL 21/35] semihosting: add semihosting section to the docs

The main reason to do this is to document our O_BINARY implementation decision somewhere. However I've also moved some of the implementation details out of qemu-options and added links between the two. As a bonus I've highlighted the scary warnings about host access with the appropriate RST tags.

Re: [PATCH 1/2] hw/cxl: Fix event log time stamp fields

On Wed, 25 Jan 2023 21:37:27 -0800 Ira Weiny wrote: > CXL 3.0 8.2.9.4.2 Set Timestamp and 8.2.9.4.1 Get Timestamp define the > way for software to set and get the time stamp of a device. Events > should use a time stamp consistent with the Get Timestamp mailbox > command. > > In addition avoid

[PATCH] sbsa-ref: remove cortex-a76 from list of supported cpus

Cortex-A76 supports 40bits of address space. sbsa-ref's memory starts above this limit. Signed-off-by: Marcin Juszkiewicz --- hw/arm/sbsa-ref.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index 4bb444684f..67c1f68c54 100644 --- a/hw/arm/sbsa-ref.c +++

Re: [PATCH v4 1/2] arm/kvm: add support for MTE

On Mon, Jan 23 2023, Eric Auger wrote: > Hi Connie, > On 1/11/23 17:13, Cornelia Huck wrote: >> Introduce a new cpu feature flag to control MTE support. To preserve >> backwards compatibility for tcg, MTE will continue to be enabled as >> long as tag memory has been provided. >> >> If MTE has be

Re: [PATCH 2/2] hw/cxl: Remove check for g_new0() failure

On Wed, 25 Jan 2023 21:37:28 -0800 Ira Weiny wrote: > g_new0() will terminate the application if it fails. Remove the check. > > Fixes: fb64c5661d5f ("hw/cxl/events: Wire up get/clear event mailbox > commands") > Reported-by: Jonathan Cameron > Signed-off-by: Ira Weiny Squashed into origina

Re: [PATCH] hw/riscv: boot: Don't use CSRs if they are disabled

On Tue, Jan 24, 2023 at 9:42 AM Alistair Francis wrote: > > On Tue, Jan 24, 2023 at 11:24 AM Bin Meng wrote: > > > > On Mon, Jan 23, 2023 at 11:58 AM Alistair Francis > > wrote: > > > > > > From: Alistair Francis > > > > > > If the CSRs and CSR instructions are disabled because the Zicsr > > >

Re: [PATCH v7 3/3] hw/riscv: clear kernel_entry higher bits in load_elf_ram_sym()

Hi Alistair, On Mon, Jan 16, 2023 at 12:28 PM Alistair Francis wrote: > > On Sat, Jan 14, 2023 at 11:41 PM Bin Meng wrote: > > > > On Sat, Jan 14, 2023 at 1:18 AM Daniel Henrique Barboza > > wrote: > > > > > > Recent hw/risc/boot.c changes caused a regression in an use case with > > > the Xviso

[PATCH v2] docs/about/deprecated: Mark HAXM in QEMU as deprecated

The HAXM project has been retired (see https://github.com/intel/haxm#status), so we should mark the code in QEMU as deprecated (and finally remove it unless somebody else picks the project up again - which is quite unlikely since there are now whpx and hvf on these operating systems, too). Signed-

  1   2   3   >