Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
---
tests/qtest/boot-serial-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c
index b216519b62..3aef3a97a9 100644
--- a/tests/qtest/boot-s
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
---
tests/qtest/boot-serial-test.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c
index 3a854b0174..92890b409d 100644
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/migration-test.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 5271ddb868..f96c73f552 10064
Slighly modify test_machine() to simplify next commit review.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
---
tests/qtest/boot-serial-test.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/tests/qtest/boot-serial-test.c b/tests
Part 3/4: Convert accelerator options.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/migration-test.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 6700
Missing review: #7
Two test were failing on Darwin when testing Fabiano's series
which allows building ARM targets without TCG accelerator:
https://lore.kernel.org/qemu-devel/20230118193518.26433-1-faro...@suse.de/
These patches allow boot-serial / migration tests to run without
TCG / KVM.
Phili
Part 4/4: Convert rest of options.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/migration-test.c | 53 +---
1 file changed, 25 insertions(+), 28 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migratio
This slighly simplify the logic, and eases the following conversion.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
---
tests/qtest/migration-test.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migrati
For example, avoid when TCG is disabled:
$ make check-qtest-aarch64
...
18/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/boot-serial-test
qemu-system-aarch64: -accel tcg: invalid accelerator tcg
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Fabiano Rosas
Reviewed-by: Richard Henderso
Part 1/4: Convert memory & machine options.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/migration-test.c | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index f96c73f552..9cdef4fa
For example, avoid when TCG is disabled:
$ make check-qtest-aarch64
...
20/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/migration-test
qemu-system-aarch64: -accel tcg: invalid accelerator tcg
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard H
Part 2/4: Convert shmem option.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/migration-test.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 9cdef4fa65..
Add a manual new job to cross-build the aarch64 target with
only the KVM accelerator enabled (in particular, no TCG).
Re-enable running the similar job on the project Aarch64
custom runner.
Signed-off-by: Philippe Mathieu-Daudé
---
Based-on: <20230118193518.26433-1-faro...@suse.de>
tar
On 19/01/2023 19.04, Alex Bennée wrote:
Instead of spewing the whole log to stdout lets just define them as
build artefacts so we can examine them later. Where we are running
check-tcg run it first as those tests are yet to be integrated into
meson.
Signed-off-by: Alex Bennée
---
.gitlab-ci.d
On 20/01/2023 09.25, Philippe Mathieu-Daudé wrote:
Add a manual new job to cross-build the aarch64 target with
only the KVM accelerator enabled (in particular, no TCG).
Re-enable running the similar job on the project Aarch64
custom runner.
Signed-off-by: Philippe Mathieu-Daudé
---
Based-on: <
On 19/01/2023 09.56, Marc-André Lureau wrote:
Hi
On Thu, Jan 19, 2023 at 12:31 PM Thomas Huth wrote:
Hi all,
in some spare minutes, I started playing with a patch to try to remove the
dtc submodule from the QEMU git repository - according to
https://repology.org/project/dtc/versions our
On 20/1/23 08:53, Thomas Huth wrote:
No need to compile-test third party submodules over and over again if
we can simply use the pre-build library from the distribution instead.
By also adding --enable-fdt=system to the configure options, we can
also avoid to check out the "dtc" submodule here.
On 1/19/23 13:34, Cédric Le Goater wrote:
Cortex A7 CPUs with an FPU implementing VFPv4 without NEON support
have 16 64-bit FPU registers and not 32 registers. Let users set the
number of VFP registers with a CPU property.
The primary use case of this property is for the Cortex A7 of the
Aspeed
On 1/19/23 23:28, BALATON Zoltan wrote:
Add a way to set a backing store for the mac_nvram similar to what
spapr_nvram or mac_via PRAM already does to allow to save its contents
between runs. Use -drive file=nvram.img,format=raw,if=mtd to specify
backing file where nvram.img must be MACIO_NVRAM_S
On 1/20/23 02:11, Marcelo Tosatti wrote:
Before kernel commit 78db6a5037965429c04d708281f35a6e5562d31b,
kvm_guest_time_update() would use vcpu->virtual_tsc_khz to calculate
tsc_shift value in the vcpus pvclock structure written to guest memory.
To clarify, the problem is that kvm_guest_time_upd
On 19/01/2023 15.58, Philippe Mathieu-Daudé wrote:
Slighly modify test_machine() to simplify next commit review.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/boot-serial-test.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/tests/qtest/boo
We need get more migration thread information to support
migration pin, especially thread name and its pid. Add an
qmp interface to query migration thread information by its
name and report thread name when migration thread is started.
Jiang Jiacheng (3):
migration: report migration thread name
Introduce interface query-migrationthreads. The interface is use
with the migration thread name reported by qemu and returns with
migration thread name and its pid.
Introduce threadinfo.c to manage threads with migration.
Signed-off-by: Jiang Jiacheng
---
migration/meson.build | 1 +
migration
Report migration thread name to libvirt in order to
support query migration thread infomation by its name.
Signed-off-by: Jiang Jiacheng
---
migration/migration.c | 3 +++
migration/multifd.c | 5 -
qapi/migration.json | 12
3 files changed, 19 insertions(+), 1 deletion(-)
To support query migration thread infomation, save and delete
thread information at thread creation and end.
Signed-off-by: Jiang Jiacheng
---
migration/migration.c | 4
migration/multifd.c | 4
2 files changed, 8 insertions(+)
diff --git a/migration/migration.c b/migration/migratio
On 19/01/2023 15.58, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/boot-serial-test.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c
index 3a854b
On 19/01/2023 15.58, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/migration-test.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
Missing explanation in the commit description. What's the benefit of doing this?
On Thu, Jan 19, 2023 at 01:05:14PM +0100, Philippe Mathieu-Daudé wrote:
> This test is failing in gtk-vnc on Darwin:
>
> $ make check-qtest-aarch64
> ...
> 19/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/vnc-display-test
> ERROR **: 10:42:35.488: vnc-error: Unsupported auth type 17973672
>
On 20/01/2023 09.23, Philippe Mathieu-Daudé wrote:
Missing review: #7
Two test were failing on Darwin when testing Fabiano's series
which allows building ARM targets without TCG accelerator:
https://lore.kernel.org/qemu-devel/20230118193518.26433-1-faro...@suse.de/
These patches allow boot-seri
On 16/01/2023 23.36, Richard Henderson wrote:
The following changes since commit fb7e7990342e59cf67dbd895c1a1e3fb1741df7a:
tests/qtest/qom-test: Do not print tested properties by default (2023-01-16
15:00:57 +)
are available in the Git repository at:
https://gitlab.com/rth7680/qemu.
On Fri, Jan 20, 2023 at 09:46:05AM +1000, Alistair Francis wrote:
> On Thu, Jan 19, 2023 at 11:00 PM Alexandre Ghiti
> wrote:
> >
> > Hi Alistair, Andrew,
> >
> > On Thu, Jan 19, 2023 at 1:25 AM Alistair Francis
> > wrote:
> > >
> > > On Wed, Jan 18, 2023 at 10:19 PM Andrew Jones
> > > wrote:
On Fri, 20 Jan 2023, Thomas Huth wrote:
On 11/01/2023 09.39, Philippe Mathieu-Daudé wrote:
Since v1:
- Fix checkpatch style violations
- Use HWADDR_PRIx instead of HWADDR_FMT_plx (Zoltan)
Supersedes: <20230110212947.34557-1-phi...@linaro.org>
"bulk: Rename TARGET_FMT_plx -> HWADDR_
Richard Henderson writes:
> On 1/19/23 08:04, Alex Bennée wrote:
>> This image is perfectly capable of building QEMU, and indeed we do
>> that on gitlab. Drop the DOCKER_PARTIAL_IMAGES setting so we can also
>> test the gitlab build locally.
>> Signed-off-by: Alex Bennée
>> ---
>> tests/docke
Paolo Bonzini writes:
> On 1/19/23 20:35, Philippe Mathieu-Daudé wrote:
>> On 19/1/23 19:04, Alex Bennée wrote:
>>> From: Marc-André Lureau
>>>
>>> Fedora 35 is EOL.
>>>
>>> Update to upstream lcitool, that dropped f35 and added f37.
>
> If you also have time to update to commit
> 40589eed1c56
On 19/01/2023 14.54, Fabiano Rosas wrote:
Signed-off-by: Fabiano Rosas
---
tests/qtest/arm-cpu-features.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/tests/qtest/arm-cpu-features.c b/tests/qtest/arm-cpu-features.c
index 4ff2014bea..1555b0bab8 10
On 19/01/2023 14.54, Fabiano Rosas wrote:
These tests set -accel tcg, so restrict them to when TCG is present.
Signed-off-by: Fabiano Rosas
---
tests/qtest/meson.build | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/tests/qtest/meson.build b/tests/qtest/meson
Thomas Huth writes:
> On 19/01/2023 19.04, Alex Bennée wrote:
>> Instead of spewing the whole log to stdout lets just define them as
>> build artefacts so we can examine them later. Where we are running
>> check-tcg run it first as those tests are yet to be integrated into
>> meson.
>> Signed-o
On 19/01/2023 14.54, Fabiano Rosas wrote:
These tests set -accel tcg, so restrict them to when TCG is present.
Signed-off-by: Fabiano Rosas
---
tests/qtest/meson.build | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/tests/qtest/meson.build b/tests/qtest/meson
On 19/01/2023 13.05, Thomas Huth wrote:
On 19/01/2023 12.30, Philippe Mathieu-Daudé wrote:
On 19/1/23 12:24, Thomas Huth wrote:
On 19/01/2023 11.05, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
RFC: CONFIG_HVF is poisoned.
We could pass host config definitions to q
On 18.01.2023 15:45, Hanna Czenczek wrote:
On 15.01.23 16:58, Alexander Ivanov wrote:
We will add more and more checks so we need a better code structure
in parallels_co_check. Let each check performs in a separate loop
in a separate helper.
Signed-off-by: Alexander Ivanov
Reviewed-by: Deni
On 18.01.2023 15:46, Hanna Czenczek wrote:
On 15.01.23 16:58, Alexander Ivanov wrote:
All the offsets in the BAT must be lower than the file size.
Fix the check condition for correct check.
Signed-off-by: Alexander Ivanov
Reviewed-by: Denis V. Lunev
---
block/parallels.c | 2 +-
1 file
On Thu, 19 Jan 2023 23:53:53 -0500
Gregory Price wrote:
> On Thu, Jan 19, 2023 at 03:04:49PM +, Jonathan Cameron wrote:
> > Gregory, would you mind checking if
> > cxl_nvb is NULL here...
> > https://elixir.bootlin.com/linux/v6.2-rc4/source/drivers/cxl/pmem.c#L67
> > (printk before it is used
Thomas Huth writes:
> On 16/01/2023 23.36, Richard Henderson wrote:
>> The following changes since commit fb7e7990342e59cf67dbd895c1a1e3fb1741df7a:
>>tests/qtest/qom-test: Do not print tested properties by default
>> (2023-01-16 15:00:57 +)
>> are available in the Git repository at:
>>
On Fri, 2023-01-20 at 10:41 +0100, Thomas Huth wrote:
> On 16/01/2023 23.36, Richard Henderson wrote:
> > The following changes since commit
> > fb7e7990342e59cf67dbd895c1a1e3fb1741df7a:
> >
> > tests/qtest/qom-test: Do not print tested properties by default
> > (2023-01-16 15:00:57 +)
> >
On 20/1/23 10:02, Thomas Huth wrote:
On 19/01/2023 15.58, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/migration-test.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
Missing explanation in the commit description
On Thu, 19 Jan 2023 17:13:40 -0500
Gregory Price wrote:
> On Thu, Jan 19, 2023 at 05:31:12PM +, Jonathan Cameron wrote:
> > On Thu, 19 Jan 2023 12:15:45 -0500
> > Gregory Price wrote:
> >
> > > Found a bug, not sure how we missed this, probably happed with rebasing
> > > and some fixups.
On 20/1/23 09:59, Thomas Huth wrote:
On 19/01/2023 15.58, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/boot-serial-test.c | 23 +++
1 file changed, 15 insertions(+), 8 deletions(-)
diff --git a/tests/qtest/boot-serial-test.c
b/test
On 20/1/23 10:18, Thomas Huth wrote:
On 20/01/2023 09.23, Philippe Mathieu-Daudé wrote:
Missing review: #7
Two test were failing on Darwin when testing Fabiano's series
which allows building ARM targets without TCG accelerator:
https://lore.kernel.org/qemu-devel/20230118193518.26433-1-faro...@s
On 20/1/23 11:26, Thomas Huth wrote:
On 19/01/2023 13.05, Thomas Huth wrote:
On 19/01/2023 12.30, Philippe Mathieu-Daudé wrote:
On 19/1/23 12:24, Thomas Huth wrote:
On 19/01/2023 11.05, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
RFC: CONFIG_HVF is poisoned.
We c
On Thu, Jan 19, 2023 at 04:43:26PM -0500, Stefan Hajnoczi wrote:
> When an IOThread is configured, the ctrl virtqueue is processed in the
> IOThread. TMFs that reset SCSI devices are currently called directly
> from the IOThread and trigger an assertion failure in blk_drain():
>
> ../block/block
From: David Woodhouse
When running under Xen, hvmloader places a table at 0x1000 with the e820
information and BIOS tables. If this isn't present, SeaBIOS will
currently panic.
We now have support for running Xen guests natively in QEMU/KVM, which
boots SeaBIOS directly instead of via hvmloader
On 20/01/2023 12.18, Philippe Mathieu-Daudé wrote:
On 20/1/23 11:26, Thomas Huth wrote:
On 19/01/2023 13.05, Thomas Huth wrote:
On 19/01/2023 12.30, Philippe Mathieu-Daudé wrote:
On 19/1/23 12:24, Thomas Huth wrote:
On 19/01/2023 11.05, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe M
On Thu, 19 Jan 2023 at 21:57, Evgeny Iakovlev
wrote:
>
>
> On 1/19/2023 14:27, Peter Maydell wrote:
> > On Tue, 17 Jan 2023 at 22:05, Evgeny Iakovlev
> > wrote:
> >> PL011 currently lacks a reset method. Implement it.
> >>
> >> Signed-off-by: Evgeny Iakovlev
> >> ---
> >> hw/char/pl011.c | 31
On 19/01/2023 14.54, Fabiano Rosas wrote:
QEMU machines might not have a default value defined for the -cpu
option.
Which machines for example? ... I thought we'd have a default CPU everywhere?
Thomas
On 18/01/2023 18.09, Pierre Morel wrote:
On 1/12/23 12:52, Thomas Huth wrote:
On 05/01/2023 15.53, Pierre Morel wrote:
...>>> +#
+# Emitted when the guest asks to change the polarity.
+#
+# @polarity: polarity specified by the guest
Please elaborate: Where does the value come from (the PTF
On Fri, Jan 20 2023, Thomas Huth wrote:
> On 19/01/2023 14.54, Fabiano Rosas wrote:
>> QEMU machines might not have a default value defined for the -cpu
>> option.
>
> Which machines for example? ... I thought we'd have a default CPU everywhere?
There's a patch further above that removes it for
At this moment any migration with the RISC-V sifive_u machine
fails with the following error:
qemu-system-riscv64: ../hw/sd/sd.c:297: sd_ocr_powerup: Assertion
`!FIELD_EX32(sd->ocr, OCR, CARD_POWER_UP)' failed.
The assert was introduced by dd26eb43337a ("hw/sd: model a power-up
delay, as a workar
Hi,
I found this bug by accident when doing avocado tests with the RISC-V
machines. Trying to migrate the sifive_u machine, which always has a SD
card, fails every time:
qemu-system-riscv64: ../hw/sd/sd.c:297: sd_ocr_powerup: Assertion
`!FIELD_EX32(sd->ocr, OCR, CARD_POWER_UP)' failed.
I'm send
We're going to add another verification with CARD_POWER_UP. Do a helper
to make the code easier to follow.
Signed-off-by: Daniel Henrique Barboza
---
hw/sd/sd.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index da5bdd134a..bd88c1a8f0 10
On 20/01/2023 13.00, Cornelia Huck wrote:
On Fri, Jan 20 2023, Thomas Huth wrote:
On 19/01/2023 14.54, Fabiano Rosas wrote:
QEMU machines might not have a default value defined for the -cpu
option.
Which machines for example? ... I thought we'd have a default CPU everywhere?
There's a pat
On Mon, 2022-11-21 at 11:32 +0100, Gerd Hoffmann wrote:
> In case kvm emulates features of another hypervisor (for example hyperv)
> two VMM CPUID blocks will be present, one for the emulated hypervisor
> and one for kvm itself.
That isn't the case for emulating Xen on KVM, FWIW. Only for Hyper-V
Am 13. Januar 2023 17:39:45 UTC schrieb Bernhard Beschow :
>
>
>Am 13. Januar 2023 08:46:53 UTC schrieb "Philippe Mathieu-Daudé"
>:
>>Hi Bernhard,
>>
>>On 9/1/23 18:23, Bernhard Beschow wrote:
>>> This series consolidates the implementations of the PIIX3 and PIIX4 south
>>> bridges and is an ex
On Thu, Jan 19, 2023 at 10:54:12AM -0300, Fabiano Rosas wrote:
> We'd prefer if the user always had to specify the machine and cpu
> options in the command line instead of relying on defaults.
>
> Since the KVM build already doesn't work with the current default of
> cortex-a15, remove the default
From: Emanuele Giuseppe Esposito
The name is not good, not the least because we are going to convert this
to a generated co_wrapper, which adds a _co infix after the first part
of the name.
No functional change intended.
Signed-off-by: Emanuele Giuseppe Esposito
Signed-off-by: Kevin Wolf
Mess
From: Emanuele Giuseppe Esposito
bdrv_debug_event() is categorized as an I/O function, and it currently
doesn't run in a coroutine. We should let it take a graph rdlock since
it traverses the block nodes graph, which however is only possible in a
coroutine.
Therefore turn it into a co_wrapper_mi
From: Alberto Faria
Clang has a generic __annotate__ attribute that can be used by
static analyzers to understand properties of functions and
analyze the control flow. Furthermore, unlike TSA annotations, the
__annotate__ attribute applies to function pointers as well.
As a first step towards s
From: Thomas Huth
"quorum" is required by iotest 312 - if it is not compiled into the
QEMU binary, the test fails. Thus list "quorum" as required driver
so that the test gets skipped in case it is not available.
Signed-off-by: Thomas Huth
Message-Id: <20230104114601.269351-1-th...@redhat.com>
R
blk_unref() can't report any errors that happen while closing the image.
For example, if qcow2 hits an -ENOSPC error while writing out dirty
bitmaps when it's closed, it prints error messages to stderr, but
'qemu-img bitmap' won't see any error return value and will therefore
look successful with e
From: Emanuele Giuseppe Esposito
Since these functions always run in coroutine context, adjust
their name to include "_co_", just like all other BlockDriver callbacks.
No functional change intended.
Signed-off-by: Emanuele Giuseppe Esposito
Signed-off-by: Kevin Wolf
Message-Id: <2023011320421
From: Hanna Reitz
In order to let qemu-img info present a block graph, add a parameter to
bdrv_node_info_dump() and bdrv_image_info_specific_dump() so that the
information of nodes below the root level can be given an indentation.
Signed-off-by: Hanna Reitz
Message-Id: <20220620162704.80987-9-h
From: Emanuele Giuseppe Esposito
BlockDriver->bdrv_getlength is categorized as IO callback, and it
currently doesn't run in a coroutine. We should let it take a graph
rdlock since the callback traverses the block nodes graph, which however
is only possible in a coroutine.
Therefore turn it into
From: Hanna Reitz
For every node in the backing chain, collect its BlockGraphInfo struct
using bdrv_query_block_graph_info(). Print all nodes' information,
indenting child nodes and labelling them with a path constructed from
the child names leading to the node from the root (e.g. /file/file).
From: Emanuele Giuseppe Esposito
bdrv_is_inserted() is categorized as an I/O function, and it currently
doesn't run in a coroutine. We should let it take a graph rdlock since
it traverses the block nodes graph, which however is only possible in a
coroutine.
Therefore turn it into a co_wrapper to
From: Hanna Reitz
ImageInfo sometimes contains flat information, and sometimes it does
not. Split off a BlockNodeInfo struct, which only contains information
about a single node and has no link to the backing image.
We do this so we can extend BlockNodeInfo to a BlockGraphInfo struct,
which has
From: Emanuele Giuseppe Esposito
BlockDriver->bdrv_io_unplug is categorized as IO callback, and it
currently doesn't run in a coroutine. We should let it take a graph
rdlock since the callback traverses the block nodes graph, which however
is only possible in a coroutine.
The only caller of this
From: Emanuele Giuseppe Esposito
In some places we are sure we are always running in a
coroutine, therefore it's useless to call the generated_co_wrapper,
instead call directly the _co_ function.
Signed-off-by: Emanuele Giuseppe Esposito
Signed-off-by: Kevin Wolf
Message-Id: <20230113204212.35
From: Hanna Reitz
Add some (optional) information that the file driver can provide for
image files, namely the extent size hint.
Signed-off-by: Hanna Reitz
Message-Id: <20220620162704.80987-3-hre...@redhat.com>
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
qapi/block-core.json | 26 +
From: Emanuele Giuseppe Esposito
bdrv_get_allocated_file_size() is categorized as an I/O function, and it
currently doesn't run in a coroutine. We should let it take a graph
rdlock since it traverses the block nodes graph, which however is only
possible in a coroutine.
Therefore turn it into a c
The M2S-FG484 SOM uses a 16 MiB SPI flash (Spansion
S25FL128SDPBHICO). Since the test asset is bigger,
truncate it to the correct size to avoid when running
the test_arm_emcraft_sf2 test:
qemu-system-arm: device requires 16777216 bytes, block backend provides
67108864 bytes
Add comment regard
From: Hanna Reitz
qemu-img info never uses ImageInfo's backing-image field, because it
opens the backing chain one by one with BDRV_O_NO_BACKING, and prints
all backing chain nodes' information consecutively. Use BlockNodeInfo
to make it clear that we only print information about a single node,
This tests that when an error happens while writing back bitmaps to the
image file in qcow2_inactivate(), 'qemu-img bitmap/commit' actually
return an error value in their exit code instead of making the operation
look successful to scripts.
Signed-off-by: Kevin Wolf
Message-Id: <20230112191454.16
From: Xiang Zheng
Currently we fill the VIRT_FLASH memory space with two 64MB NOR images
when using persistent UEFI variables on virt board. Actually we only use
a very small(non-zero) part of the memory while the rest significant
large(zero) part of memory is wasted.
So this patch checks the bl
blk_unref() can't report any errors that happen while closing the image.
For example, if qcow2 hits an -ENOSPC error while writing out dirty
bitmaps when it's closed, it prints error messages to stderr, but
'qemu-img commit' won't see any error return value and will therefore
look successful with e
From: Hanna Reitz
VMDK's implementation of .bdrv_get_specific_info() returns information
about its extent files, ostensibly in the form of ImageInfo objects.
However, it does not get this information through
bdrv_query_image_info(), but fills only a select few fields with custom
information that
From: Hanna Reitz
Currently, when querying a qcow2 image, qemu-img info reports something
like this:
image: test.qcow2
file format: qcow2
virtual size: 64 MiB (67108864 bytes)
disk size: 196 KiB
cluster_size: 65536
Format specific information:
compat: 1.1
compression type: zlib
lazy
The M2S-FG484 SOM SPI flash is 16MiB. Truncate the file
provided with the Avocado test to avoid:
qemu-system-arm: device requires 16777216 bytes, block backend provides
67108864 bytes
before merging the "m25p80: Improve error when the backend
file size does not match the device" patch:
https://
From: Emanuele Giuseppe Esposito
BlockDriver->bdrv_io_plug is categorized as IO callback, and it
currently doesn't run in a coroutine. We should let it take a graph
rdlock since the callback traverses the block nodes graph, which however
is only possible in a coroutine.
The only caller of this f
From: Emanuele Giuseppe Esposito
The only difference is that blk_ checks if the block is available,
but this check is already performed above in blk_check_byte_request().
This is in preparation for the graph rdlock, which will be taken
by both the callers of blk_check_byte_request() and blk_getl
From: Thomas Huth
In downstream RHEL builds, we do not have "blkverify" enabled, so
iotest 262 is currently failing there. Thus let's list "blkverify"
as required item so that the test properly gets skipped instead if
"blkverify" is missing.
Signed-off-by: Thomas Huth
Message-Id: <2023010411285
The following changes since commit 239b8b0699a222fd21da1c5fdeba0a2456085a47:
Merge tag 'trivial-branch-for-8.0-pull-request' of
https://gitlab.com/laurent_vivier/qemu into staging (2023-01-19 15:05:29 +)
are available in the Git repository at:
https://repo.or.cz/qemu/kevin.git tags/for-
From: Philippe Mathieu-Daudé
The inlined nbd_readXX() functions call beXX_to_cpu(), themselves
declared in . This fixes when refactoring:
In file included from ../../block/nbd.c:44:
include/block/nbd.h: In function 'nbd_read16':
include/block/nbd.h:383:12: error: implicit declaration of fu
From: Paolo Bonzini
qemu-io's do_co_pwrite_zeroes is reinventing the coroutine wrapper
blk_pwrite_zeroes. Just use the real thing directly.
Signed-off-by: Paolo Bonzini
Message-Id: <20221215130225.476477-1-pbonz...@redhat.com>
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
qemu-io-cm
From: Emanuele Giuseppe Esposito
bdrv_get_info() is categorized as an I/O function, and it currently
doesn't run in a coroutine. We should let it take a graph rdlock since
it traverses the block nodes graph, which however is only possible in a
coroutine.
Therefore turn it into a co_wrapper to mo
From: Hanna Reitz
Before we let qemu-img info print child node information, have
common.filter, common.rc, and iotests.py filter it from the test output
so we get as few reference output changes as possible.
Signed-off-by: Hanna Reitz
Message-Id: <20220620162704.80987-10-hre...@redhat.com>
Test
Factor file_truncate() helper out of image_pow2ceil_expand()
for reuse.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/avocado/boot_linux_console.py | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/tests/avocado/boot_linux_console.py
b/tests/avocado/boot_linux
From: Hanna Reitz
There is no real reason why bdrv_query_image_info() should generally not
recurse. The ImageInfo struct has a pointer to the backing image, so it
should generally be filled, unless the caller explicitly opts out.
This moves the recursing code from bdrv_block_device_info() into
From: Emanuele Giuseppe Esposito
Just omit the various 'return' when the return type is void.
Signed-off-by: Emanuele Giuseppe Esposito
Signed-off-by: Kevin Wolf
Message-Id: <20230113204212.359076-2-kw...@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito
Signed-off-by: Kevin Wolf
---
scri
From: Paolo Bonzini
It has only one caller---inline it and remove the function.
Signed-off-by: Paolo Bonzini
Message-Id: <20221215130225.476477-2-pbonz...@redhat.com>
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
include/block/block-io.h | 5 -
block.c | 6 --
From: Alberto Faria
Add more annotations to functions, describing valid and invalid
calls from coroutine to non-coroutine context.
When applied to a function, no_coroutine_fn advertises that it should
not be called from coroutine_fn functions. This can be because the
function blocks or, in the
From: Hanna Reitz
When a block driver supports obtaining format-specific information, but
that object only contains optional fields, it is possible that none of
them are present, so that dump_qobject() (called by
bdrv_image_info_specific_dump()) will not print anything.
The callers of bdrv_image
1 - 100 of 280 matches
Mail list logo
