Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

2023-01-19 Thread Klaus Jensen
On Jan 19 08:28, Klaus Jensen wrote: > On Jan 18 21:03, Keith Busch wrote: > > On Thu, Jan 19, 2023 at 01:10:57PM +1000, Alistair Francis wrote: > > > On Thu, Jan 19, 2023 at 12:44 PM Keith Busch wrote: > > > > > > > > Further up, it says the "interrupt gateway" is responsible for > > > > forwardi

Re: [PATCH] hw: Use TYPE_PCI_BUS definition where appropriate

2023-01-19 Thread Eric Auger
Hi Philippe, On 1/17/23 20:30, Philippe Mathieu-Daudé wrote: > Use the proper QOM type definition instead of magic string. > This also helps during eventual refactor while using git-grep. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Auger Thanks Eric > --- > hw/arm/smmu-common.

MSYS2 and libfdt

2023-01-19 Thread Thomas Huth
Hi all, in some spare minutes, I started playing with a patch to try to remove the dtc submodule from the QEMU git repository - according to https://repology.org/project/dtc/versions our supported build platforms should now all provide the minimum required version. However, I'm hitting a

Re: [PATCH] hw/net/can/xlnx-zynqmp-can: fix assertion failures in transfer_fifo()

2023-01-19 Thread Jason Wang
在 2023/1/9 17:19, Qiang Liu 写道: Check fifos before poping data from and pushing data into it. Fixes: 98e5d7a2b726 ("hw/net/can: Introduce Xilinx ZynqMP CAN controller") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1425 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1427 Rep

[PATCH v2 5/5] target/avr: enable icount mode

2023-01-19 Thread Pavel Dovgalyuk
Icount mode requires correct can_do_io flag management for checking that IO operations are performed only in the last TB instruction. This patch sets this flag before every helper which can lead to virtual hardware access. It enables deterministic execution in icount mode for AVR. Signed-off-by: P

[PATCH v2 4/5] target/avr: fix interrupt processing

2023-01-19 Thread Pavel Dovgalyuk
Interrupt bit vector has 64 bits, but interrupt vector is found with ctz32 function. This patch replaces it with ctz64. Signed-off-by: Pavel Dovgalyuk --- target/avr/helper.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/avr/helper.c b/target/avr/helper.c inde

Re: reverse-{debugging,continue} not working on v7.2.0, i386 guest

2023-01-19 Thread Pavel Dovgalyuk
On 19.01.2023 07:40, Hyeonggon Yoo wrote: On Wed, Jan 18, 2023 at 12:39:16PM +0300, Pavel Dovgalyuk wrote: Sometimes replay (or reverse debugging) have problems due to incomplete or incorrect virtual device save/load implementation. Can you try removing -cpu from your command line? Or you can

Re: [PATCH 1/2] MAINTAINERS: Cover userfaultfd

2023-01-19 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Commit 0e9b5cd6b2 "migration: introduce UFFD-WP low-level interface > helpers" added util/userfaultfd.c without covering it in MAINTAINERS. > Add it to section "Migration". > > Signed-off-by: Markus Armbruster > --- > MAINTAINERS | 2 ++ > 1 file

[PATCH 1/2] MAINTAINERS: Cover userfaultfd

2023-01-19 Thread Markus Armbruster
Commit 0e9b5cd6b2 "migration: introduce UFFD-WP low-level interface helpers" added util/userfaultfd.c without covering it in MAINTAINERS. Add it to section "Migration". Signed-off-by: Markus Armbruster --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINER

Re: MSYS2 and libfdt

2023-01-19 Thread Stefan Weil via
Am 19.01.23 um 09:14 schrieb Thomas Huth:  Hi all, in some spare minutes, I started playing with a patch to try to remove the dtc submodule from the QEMU git repository - according to https://repology.org/project/dtc/versions our supported build platforms should now all provide the minimum

[PATCH 2/2] MAINTAINERS: Cover include/sysemu/accel-blocker.h

2023-01-19 Thread Markus Armbruster
Commit bd688fc931 "accel: introduce accelerator blocker API" aded include/sysemu/accel-blocker.h and accel/accel-blocker.c. MAINTAINERS covers the latter in section "Guest CPU Cores (other accelerators) / Overall", but not the former. Fix that. Signed-off-by: Markus Armbruster --- MAINTAINERS

[PATCH 0/2] MAINTAINERS: Small potatos

2023-01-19 Thread Markus Armbruster
Markus Armbruster (2): MAINTAINERS: Cover userfaultfd MAINTAINERS: Cover include/sysemu/accel-blocker.h MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.39.0

[PATCH v2 0/5] AVR target fixes

2023-01-19 Thread Pavel Dovgalyuk
This set of patches includes multiple changes for AVR target. v2 changes: - fixed instruction translation in icount mode --- Pavel Dovgalyuk (5): target/avr: fix long address calculation target/avr: implement small RAM/large RAM feature target/avr: fix avr features processing

Re: [PATCH v4 10/19] migration: Clean up includes

2023-01-19 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. That change doesn't seem to match the message; the patch is removing the osdep.h include. Dave > This commit was created with scripts/cle

Re: Who maintains util/userfaultfd.c?

2023-01-19 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> commit 0e9b5cd6b238b7ca9a3a50d957f50c37082705a0 >> Author: Andrey Gruzdev >> Date: Fri Jan 29 13:14:04 2021 +0300 >> >> migration: introduce UFFD-WP low-level interface helpers >> >> Glue code to the userfaultfd kernel implement

[PATCH v2 3/5] target/avr: fix avr features processing

2023-01-19 Thread Pavel Dovgalyuk
Bit vector for features has 64 bits. This patch fixes bit shifts in avr_feature and set_avr_feature functions to be 64-bit too. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Michael Rolnik --- target/avr/cpu.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/avr/c

Re: [PATCH v4 00/19] Clean up includes

2023-01-19 Thread Markus Armbruster
Markus Armbruster writes: > Back in 2016, we discussed[1] rules for headers, and these were > generally liked: > > 1. Have a carefully curated header that's included everywhere first. We >got that already thanks to Peter: osdep.h. > > 2. Headers should normally include everything they need b

Re: [PATCH v2 2/2] tests/avocado: Add test accessing NVMe on big-endian MIPS target

2023-01-19 Thread Klaus Jensen
On Jan 18 10:57, Philippe Mathieu-Daudé wrote: > Add a Linux-boot test accessing PCI NVMe drive on big-endian MIPS: > > $ avocado --show=app,console run -t device:nvme tests/avocado/ >(1/1) > tests/avocado/boot_linux_console.py:BootLinuxConsole.test_mips64_malta_I6400_nvme: > console: Linux

Re: [PATCH v3 2/3] hvf: implement guest debugging on Apple Silicon hosts

2023-01-19 Thread Mads Ynddal
> It seems v3 has a regression in regards to BRK instructions that I cannot > reproduce with v2. I've now observed the same messages on v2 on a co-worker's computer. Maybe it's happening in combination with another commit on master. If I can find the time, I'll try to bisect it. — Mads Ynddal

[PATCH v2 2/5] target/avr: implement small RAM/large RAM feature

2023-01-19 Thread Pavel Dovgalyuk
translate.c functions use RAMPZ for RAM access. This register is also used for ROM reads. However, in MCUs with 64k RAM support RAMPZ is used for ROM only. Therefore when RAMPZ is set, addressing the RAM becomes incorrect in the emulator. This patch adds LARGE RAM feature which can be used in xmega

Re: [PATCH v2 3/5] target/avr: fix avr features processing

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 10:22, Pavel Dovgalyuk wrote: Bit vector for features has 64 bits. This patch fixes bit shifts in avr_feature and set_avr_feature functions to be 64-bit too. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Michael Rolnik --- target/avr/cpu.h |4 ++-- 1 file changed, 2 insertions(

Re: MSYS2 and libfdt

2023-01-19 Thread Marc-André Lureau
Hi On Thu, Jan 19, 2023 at 12:31 PM Thomas Huth wrote: > > > Hi all, > > in some spare minutes, I started playing with a patch to try to remove the > dtc submodule from the QEMU git repository - according to > https://repology.org/project/dtc/versions our supported build platforms > should now

Re: [PATCH 1/2] MAINTAINERS: Cover userfaultfd

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 10:15, Markus Armbruster wrote: Commit 0e9b5cd6b2 "migration: introduce UFFD-WP low-level interface helpers" added util/userfaultfd.c without covering it in MAINTAINERS. Add it to section "Migration". Signed-off-by: Markus Armbruster --- MAINTAINERS | 2 ++ 1 file changed, 2 inser

Re: [PATCH v2] hw/net/lan9118: log [read|write]b when mode_16bit is enabled rather than abort

2023-01-19 Thread Jason Wang
On Mon, Jan 16, 2023 at 4:31 PM Philippe Mathieu-Daudé wrote: > > On 16/1/23 04:14, Qiang Liu wrote: > > This patch replaces hw_error to guest error log for [read|write]b > > accesses when mode_16bit is enabled. This avoids aborting qemu. > > > > Fixes: 1248f8d4cbc3 ("hw/lan9118: Add basic 16-bit

[PATCH 2/8] tests/qtest/boot-serial-test: Build command line using GString API

2023-01-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/boot-serial-test.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c index 3aef3a97a9..fccf706f99 100644 --- a/tests/qtest/boot-serial

[PATCH 4/8] tests/qtest/migration-test: Build command line using GString API

2023-01-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/migration-test.c | 85 ++-- 1 file changed, 42 insertions(+), 43 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index dbde726adf..36e6074653 100644 --- a/tests/qtest/migra

Re: [PATCH] target/arm: Allow users to set the number of VFP registers

2023-01-19 Thread Cédric Le Goater
@@ -1650,6 +1656,14 @@ static void arm_cpu_realizefn(DeviceState *dev, Error **errp) return; } +if (!cpu->has_vfp_d32) { +uint32_t u; + +u = cpu->isar.mvfr0; +u = FIELD_DP32(u, MVFR0, SIMDREG, 1); /* 16 registers */ +cpu->isar.mvfr0 = u; +}

Re: [PATCH v4 09/19] qga: Clean up includes

2023-01-19 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Thu, Jan 19, 2023 at 9:00 AM Markus Armbruster wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > Signed-off-by: Markus Armbruste

[PATCH v2 1/5] target/avr: fix long address calculation

2023-01-19 Thread Pavel Dovgalyuk
AVR ELPMX instruction (and some others) use three registers to form long 24-bit address from RAMPZ and two 8-bit registers. RAMPZ stores shifted 8 bits like ff to simplify address calculation. This patch fixes full address calculation in function gen_get_addr by changing the mess in offsets of

[PATCH 1/8] tests/qtest/boot-serial-test: Constify tests[] array

2023-01-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/boot-serial-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c index b216519b62..3aef3a97a9 100644 --- a/tests/qtest/boot-serial-test.c +++ b/tests/qtest/b

Re: Announcement of aborting HAXM maintenance

2023-01-19 Thread Daniel P . Berrangé
On Thu, Jan 19, 2023 at 03:56:04AM +, Wang, Wenchao wrote: > Hi, Philippe, > > Intel decided to abort the development of HAXM and the maintenance > of its QEMU part. Should we submit a patch to mark the Guest CPU > Cores (HAXM) status as Orphan and remove the maintainers from the > correspondi

Re: [PATCH v4 18/19] 9p: Drop superfluous include of linux/limits.h

2023-01-19 Thread Christian Schoenebeck
On Thursday, January 19, 2023 7:59:58 AM CET Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hw/9pfs/9p.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c > index 9621ec1341..aa736af380 100644 > --- a/hw/9pfs/9p.c > +++ b/hw/9pfs/9p.c > @

[PATCH 7/8] tests/qtest/boot-serial-test: Allow running with HVF

2023-01-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/boot-serial-test.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c index f8d0c684c2..4a2cbcf8e8 100644 --- a/tests/qtest/boot-serial-test.c +++ b/tests/qtest/boot-serial-

Re: Who maintains util/userfaultfd.c?

2023-01-19 Thread Juan Quintela
Markus Armbruster wrote: > commit 0e9b5cd6b238b7ca9a3a50d957f50c37082705a0 > Author: Andrey Gruzdev > Date: Fri Jan 29 13:14:04 2021 +0300 > > migration: introduce UFFD-WP low-level interface helpers > > Glue code to the userfaultfd kernel implementation. > Querying feature sup

[PATCH 3/8] tests/qtest/boot-serial-test: Only use available accelerators

2023-01-19 Thread Philippe Mathieu-Daudé
For example, avoid when TCG is disabled: $ make check-qtest-aarch64 ... 18/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/boot-serial-test qemu-system-aarch64: -accel tcg: invalid accelerator tcg Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/boot-serial-test.c | 14 --

[RFC PATCH 6/8] tests/qtest/libqtest: Allow checking for HVF accelerator

2023-01-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- RFC: CONFIG_HVF is poisoned. We could pass host config definitions to qtest using: diff --git a/meson.build b/meson.build @@ -2547,6 +2547,7 @@ foreach target : target_dirs accel_kconfig = [] foreach sym: accelerators +config_host_da

[PATCH 8/8] tests/qtest/migration-test: Allow running with HVF

2023-01-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/migration-test.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 1e7f1ea162..7a0fcfb81d 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@

[PATCH 0/8] tests/qtest: Allow running boot-serial / migration with TCG disabled

2023-01-19 Thread Philippe Mathieu-Daudé
Two test were failing on Darwin when testing Fabiano's series which allows building ARM targets without TCG accelerator: https://lore.kernel.org/qemu-devel/20230118193518.26433-1-faro...@suse.de/ These patches allow boot-serial / migration tests to run without TCG / KVM, then HVF. Pending: How to

[PATCH v4] net: stream: add a new option to automatically reconnect

2023-01-19 Thread Laurent Vivier
In stream mode, if the server shuts down there is currently no way to reconnect the client to a new server without removing the NIC device and the netdev backend (or to reboot). This patch introduces a reconnect option that specifies a delay to try to reconnect with the same parameters. Add a new

Re: [PATCH v4 19/19] Drop duplicate #include

2023-01-19 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Tracked down with the help of scripts/clean-includes. > > Signed-off-by: Markus Armbruster > --- > include/hw/arm/fsl-imx6ul.h | 1 - > include/hw/arm/fsl-imx7.h | 1 - > backends/tpm/tpm_emulator.c | 1 - > hw/acpi/piix4.c |

[PATCH 5/8] tests/qtest/migration-test: Only use available accelerators

2023-01-19 Thread Philippe Mathieu-Daudé
For example, avoid when TCG is disabled: $ make check-qtest-aarch64 ... 20/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/migration-test qemu-system-aarch64: -accel tcg: invalid accelerator tcg Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/migration-test.c | 17 + 1

Re: [PATCH 0/8] hw/cxl: CXL emulation cleanups and minor fixes for upstream

2023-01-19 Thread Jonathan Cameron via
On Wed, 18 Jan 2023 14:22:08 -0500 Gregory Price wrote: > 1) No stack traces present > 2) Device usage appears to work, but cxl-cli fails to create a region, i > haven't checked why yet (also tried ndctl-75, same results) > 3) There seems to be some other regression with the cxl_pmem_init > routi

Re: [PATCH 0/3] Remove C virtiofsd

2023-01-19 Thread Hanna Czenczek
On 18.01.23 16:59, Stefan Hajnoczi wrote: On Wed, 18 Jan 2023 at 10:40, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" We deprecated the C virtiofsd in commit 34deee7b6a1418f3d62a in v7.0 in favour of the Rust implementation at https://gitlab.com/virtio-fs/virtiofsd s

Re: [PATCH v2 4/5] target/avr: fix interrupt processing

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 10:23, Pavel Dovgalyuk wrote: Interrupt bit vector has 64 bits, but interrupt vector is found with ctz32 function. This patch replaces it with ctz64. Signed-off-by: Pavel Dovgalyuk --- target/avr/helper.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by:

Re: [PATCH 2/2] MAINTAINERS: Cover include/sysemu/accel-blocker.h

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 10:15, Markus Armbruster wrote: Commit bd688fc931 "accel: introduce accelerator blocker API" aded include/sysemu/accel-blocker.h and accel/accel-blocker.c. MAINTAINERS covers the latter in section "Guest CPU Cores (other accelerators) / Overall", but not the former. Fix that. Doesn

[PATCH] MAINTAINERS: Cover RCU documentation

2023-01-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0fe50d01e3..73e9cb33f5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2812,6 +2812,8 @@ F: qapi/run-state.json Read, Copy, Update (RCU) M: Paolo Bonzini

Re: [PATCH 00/20] target/arm: CONFIG_TCG=n part 1

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 08:41, Philippe Mathieu-Daudé wrote: On 18/1/23 20:34, Fabiano Rosas wrote: These are the already reviewed patches from the first half of my previous series: https://lore.kernel.org/r/20230113140419.4013-1-faro...@suse.de This unbreaks the --disable-tcg build, but there are issues in

Re: [PATCH v4 10/19] migration: Clean up includes

2023-01-19 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. > > That change doesn't seem to match the message; the patch is removing the > osdep.h include. It's

Re: [PATCH 2/2] MAINTAINERS: Cover include/sysemu/accel-blocker.h

2023-01-19 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 19/1/23 10:15, Markus Armbruster wrote: >> Commit bd688fc931 "accel: introduce accelerator blocker API" aded >> include/sysemu/accel-blocker.h and accel/accel-blocker.c. MAINTAINERS >> covers the latter in section "Guest CPU Cores (other accelerators) / >> Ove

Re: Announcement of aborting HAXM maintenance

2023-01-19 Thread Stefan Weil via
Am 19.01.23 um 11:12 schrieb Daniel P. Berrangé: On Thu, Jan 19, 2023 at 03:56:04AM +, Wang, Wenchao wrote: Hi, Philippe, Intel decided to abort the development of HAXM and the maintenance of its QEMU part. Should we submit a patch to mark the Guest CPU Cores (HAXM) status as Orphan and rem

Re: [PATCH v4 08/19] hw/tricore: Clean up includes

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 07:59, Markus Armbruster wrote: Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster --- include/hw/tricore/triboard.h | 1 - 1 file change

Re: [PATCH v4 05/19] crypto: Clean up includes

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 07:59, Markus Armbruster wrote: Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster --- crypto/block-luks-priv.h | 1 - 1 file changed, 1

Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

2023-01-19 Thread Peter Maydell
On Thu, 19 Jan 2023 at 04:03, Keith Busch wrote: > > On Thu, Jan 19, 2023 at 01:10:57PM +1000, Alistair Francis wrote: > > On Thu, Jan 19, 2023 at 12:44 PM Keith Busch wrote: > > > > > > Further up, it says the "interrupt gateway" is responsible for > > > forwarding new interrupt requests while t

Re: [PATCH v4 11/19] net: Clean up includes

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 07:59, Markus Armbruster wrote: Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster --- net/vmnet_int.h | 1 - 1 file changed, 1 deletion(

Re: [PATCH v4 15/19] accel: Clean up includes

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 07:59, Markus Armbruster wrote: Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster --- include/sysemu/accel-blocker.h | 1 - 1 file chang

Re: [PATCH v4 18/19] 9p: Drop superfluous include of linux/limits.h

2023-01-19 Thread Markus Armbruster
Christian Schoenebeck writes: > On Thursday, January 19, 2023 7:59:58 AM CET Markus Armbruster wrote: >> Signed-off-by: Markus Armbruster >> --- >> hw/9pfs/9p.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c >> index 9621ec1341..aa736af380 100644 >> -

Re: Announcement of aborting HAXM maintenance

2023-01-19 Thread Peter Maydell
On Thu, 19 Jan 2023 at 10:34, Stefan Weil via wrote: > > Am 19.01.23 um 11:12 schrieb Daniel P. Berrangé: > > On Thu, Jan 19, 2023 at 03:56:04AM +, Wang, Wenchao wrote: > >> Hi, Philippe, > >> > >> Intel decided to abort the development of HAXM and the maintenance > >> of its QEMU part. Should

Re: [PATCH v4 13/19] riscv: Clean up includes

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 07:59, Markus Armbruster wrote: Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster --- target/riscv/pmu.h | 1 - 1 file changed, 1 deleti

Re: [PATCH v4 16/19] Fix non-first inclusions of qemu/osdep.h

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 07:59, Markus Armbruster wrote: This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster --- audio/sndioaudio.c | 2 +- backends/hostmem-epc.c | 2 +- block/export/vduse-blk.c | 2 +- hw/hyperv/syndbg.c | 2 +- util/async-teardown.

Re: [PATCH] tests/qtest/bios-tables-test: Make the test less verbose by default

2023-01-19 Thread Igor Mammedov
On Wed, 18 Jan 2023 13:51:32 +0100 Thomas Huth wrote: > We are facing the issues that our test logs in the gitlab CI are > too big (and thus cut off). The bios-tables-test is one of the few > qtests that prints many lines of output by default when running with > V=1, so it contributes to this pro

Re: [PATCH 4/8] tests/qtest/migration-test: Build command line using GString API

2023-01-19 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@linaro.org) wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/qtest/migration-test.c | 85 ++-- > 1 file changed, 42 insertions(+), 43 deletions(-) > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-te

Re: tests/qtest: Is vnc-display-test supposed to work on Darwin?

2023-01-19 Thread Philippe Mathieu-Daudé
On 5/12/22 08:51, Marc-André Lureau wrote: On Fri, Dec 2, 2022 at 1:51 PM Philippe Mathieu-Daudé wrote: The vnc-display-test is failing on Darwin: tests/qtest/vnc-display-test:45038): ERROR **: 10:42:35.488: vnc-error: Unsupported auth type 17973672 It is supposed to pass. Can you share mor

Re: [PATCH v7 38/51] i386/xen: add monitor commands to test event injection

2023-01-19 Thread David Woodhouse
On Tue, 2023-01-17 at 11:08 +0100, Markus Armbruster wrote: > > > +# Since: x.xx > > "Since: 8.0.0" (with any luck).  More of the same below. Speaking of which... I guess this first series probably wants to be considered as KVM and merged via Paolo? Or at least as far as #27/51 'i386/xen: Add su

Re: [PATCH 5/8] tests/qtest/migration-test: Only use available accelerators

2023-01-19 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@linaro.org) wrote: > For example, avoid when TCG is disabled: > > $ make check-qtest-aarch64 > ... > 20/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/migration-test > qemu-system-aarch64: -accel tcg: invalid accelerator tcg > > Signed-off-by: Philippe Mathie

Re: [PATCH 8/8] tests/qtest/migration-test: Allow running with HVF

2023-01-19 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@linaro.org) wrote: > Signed-off-by: Philippe Mathieu-Daudé Does it support migration? I don't remember anyone ever mentioning it. Dave > --- > tests/qtest/migration-test.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/tests/qtest/migration-test

Re: [PATCH v10 0/9] KVM: mm: fd-based approach for supporting KVM

2023-01-19 Thread Isaku Yamahata
On Sat, Jan 14, 2023 at 12:37:59AM +, Sean Christopherson wrote: > On Fri, Dec 02, 2022, Chao Peng wrote: > > This patch series implements KVM guest private memory for confidential > > computing scenarios like Intel TDX[1]. If a TDX host accesses > > TDX-protected guest memory, machine check

Re: tests/qtest: Is vnc-display-test supposed to work on Darwin?

2023-01-19 Thread Daniel P . Berrangé
On Thu, Jan 19, 2023 at 12:01:18PM +0100, Philippe Mathieu-Daudé wrote: > On 5/12/22 08:51, Marc-André Lureau wrote: > > On Fri, Dec 2, 2022 at 1:51 PM Philippe Mathieu-Daudé > > wrote: > > > > > > The vnc-display-test is failing on Darwin: > > > > > > tests/qtest/vnc-display-test:45038): ERROR

Re: [PATCH 4/8] tests/qtest/migration-test: Build command line using GString API

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 11:59, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (phi...@linaro.org) wrote: Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/migration-test.c | 85 ++-- 1 file changed, 42 insertions(+), 43 deletions(-) diff --git a/tests/qtest/mi

Re: tests/qtest: Is vnc-display-test supposed to work on Darwin?

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 12:16, Daniel P. Berrangé wrote: On Thu, Jan 19, 2023 at 12:01:18PM +0100, Philippe Mathieu-Daudé wrote: On 5/12/22 08:51, Marc-André Lureau wrote: On Fri, Dec 2, 2022 at 1:51 PM Philippe Mathieu-Daudé wrote: The vnc-display-test is failing on Darwin: tests/qtest/vnc-display-test

Re: [RFC PATCH 6/8] tests/qtest/libqtest: Allow checking for HVF accelerator

2023-01-19 Thread Thomas Huth
On 19/01/2023 11.05, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- RFC: CONFIG_HVF is poisoned. We could pass host config definitions to qtest using: diff --git a/meson.build b/meson.build @@ -2547,6 +2547,7 @@ foreach target : target_dirs accel_kconfig =

Re: tests/qtest: Is vnc-display-test supposed to work on Darwin?

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 12:16, Daniel P. Berrangé wrote: On Thu, Jan 19, 2023 at 12:01:18PM +0100, Philippe Mathieu-Daudé wrote: On 5/12/22 08:51, Marc-André Lureau wrote: On Fri, Dec 2, 2022 at 1:51 PM Philippe Mathieu-Daudé wrote: The vnc-display-test is failing on Darwin: tests/qtest/vnc-display-test

Re: [RFC PATCH 6/8] tests/qtest/libqtest: Allow checking for HVF accelerator

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 12:24, Thomas Huth wrote: On 19/01/2023 11.05, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- RFC: CONFIG_HVF is poisoned. We could pass host config definitions to qtest using:    diff --git a/meson.build b/meson.build    @@ -2547,6 +2547,7 @@ foreach targe

Re: [PATCH 8/8] tests/qtest/migration-test: Allow running with HVF

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 12:13, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (phi...@linaro.org) wrote: Signed-off-by: Philippe Mathieu-Daudé Does it support migration? I don't remember anyone ever mentioning it. The test doesn't fail, but I have no idea what that means... --- tests/qtest/m

Re: tests/qtest: Is vnc-display-test supposed to work on Darwin?

2023-01-19 Thread Daniel P . Berrangé
On Thu, Jan 19, 2023 at 12:21:58PM +0100, Philippe Mathieu-Daudé wrote: > On 19/1/23 12:16, Daniel P. Berrangé wrote: > > On Thu, Jan 19, 2023 at 12:01:18PM +0100, Philippe Mathieu-Daudé wrote: > > > On 5/12/22 08:51, Marc-André Lureau wrote: > > > > On Fri, Dec 2, 2022 at 1:51 PM Philippe Mathieu-

Re: [PATCH v4 16/19] Fix non-first inclusions of qemu/osdep.h

2023-01-19 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 19/1/23 07:59, Markus Armbruster wrote: >> This commit was created with scripts/clean-includes. >> Signed-off-by: Markus Armbruster [...] > Up to here: > > Reviewed-by: Philippe Mathieu-Daudé > >> diff --git a/util/async-teardown.c b/util/async-teardown.c >

Re: [PATCH v4 10/19] migration: Clean up includes

2023-01-19 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> Clean up includes so that osdep.h is included first and headers > >> which it implies are not included manually. > > > > That change doesn't seem to match th

Re: [PATCH 0/8] hw/cxl: CXL emulation cleanups and minor fixes for upstream

2023-01-19 Thread Michael S. Tsirkin
On Thu, Jan 19, 2023 at 10:19:46AM +, Jonathan Cameron wrote: > On Wed, 18 Jan 2023 14:22:08 -0500 > Gregory Price wrote: > > > 1) No stack traces present > > 2) Device usage appears to work, but cxl-cli fails to create a region, i > > haven't checked why yet (also tried ndctl-75, same result

Re: tests/qtest: Is vnc-display-test supposed to work on Darwin?

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 12:33, Daniel P. Berrangé wrote: On Thu, Jan 19, 2023 at 12:21:58PM +0100, Philippe Mathieu-Daudé wrote: On 19/1/23 12:16, Daniel P. Berrangé wrote: On Thu, Jan 19, 2023 at 12:01:18PM +0100, Philippe Mathieu-Daudé wrote: On 5/12/22 08:51, Marc-André Lureau wrote: On Fri, Dec 2, 202

Re: [PATCH v4 00/19] Clean up includes

2023-01-19 Thread Michael S. Tsirkin
On Thu, Jan 19, 2023 at 07:59:40AM +0100, Markus Armbruster wrote: > Back in 2016, we discussed[1] rules for headers, and these were > generally liked: > > 1. Have a carefully curated header that's included everywhere first. We >got that already thanks to Peter: osdep.h. > > 2. Headers shoul

Re: [PATCH v4 16/19] Fix non-first inclusions of qemu/osdep.h

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 12:41, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 19/1/23 07:59, Markus Armbruster wrote: This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster [...] Up to here: Reviewed-by: Philippe Mathieu-Daudé diff --git a/util/async-tea

Re: [PULL 0/9] Testing, s390x and misc patches

2023-01-19 Thread Peter Maydell
On Wed, 18 Jan 2023 at 11:34, Thomas Huth wrote: > > Hi Peter! > > The following changes since commit 7c9236d6d61f30583d5d860097d88dbf0fe487bf: > > Merge tag 'pull-tcg-20230116' of https://gitlab.com/rth7680/qemu into > staging (2023-01-17 10:24:16 +) > > are available in the Git repositor

Re: tests/qtest: Is vnc-display-test supposed to work on Darwin?

2023-01-19 Thread Daniel P . Berrangé
On Thu, Jan 19, 2023 at 12:49:48PM +0100, Philippe Mathieu-Daudé wrote: > On 19/1/23 12:33, Daniel P. Berrangé wrote: > > On Thu, Jan 19, 2023 at 12:21:58PM +0100, Philippe Mathieu-Daudé wrote: > > > On 19/1/23 12:16, Daniel P. Berrangé wrote: > > > > On Thu, Jan 19, 2023 at 12:01:18PM +0100, Phili

Re: [PATCH v4 18/19] 9p: Drop superfluous include of linux/limits.h

2023-01-19 Thread Christian Schoenebeck
On Thursday, January 19, 2023 11:37:00 AM CET Markus Armbruster wrote: > Christian Schoenebeck writes: > > > On Thursday, January 19, 2023 7:59:58 AM CET Markus Armbruster wrote: > >> Signed-off-by: Markus Armbruster > >> --- > >> hw/9pfs/9p.c | 3 --- > >> 1 file changed, 3 deletions(-) > >>

[PATCH 0/3] tests/qtest/vnc-display-test: Silent warnings & explicit machine

2023-01-19 Thread Philippe Mathieu-Daudé
- Silent warnings on Windows - Explicit the 'none' machine - Disable on Darwin Aarch64 host Philippe Mathieu-Daudé (3): tests/qtest/vnc-display-test: Suppress build warnings on Windows tests/qtest/vnc-display-test: Use the 'none' machine tests/qtest/vnc-display-test: Disable on Darwin test

Re: [RFC PATCH 6/8] tests/qtest/libqtest: Allow checking for HVF accelerator

2023-01-19 Thread Thomas Huth
On 19/01/2023 12.30, Philippe Mathieu-Daudé wrote: On 19/1/23 12:24, Thomas Huth wrote: On 19/01/2023 11.05, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- RFC: CONFIG_HVF is poisoned. We could pass host config definitions to qtest using:    diff --git a/meson.build

[PATCH 1/3] tests/qtest/vnc-display-test: Suppress build warnings on Windows

2023-01-19 Thread Philippe Mathieu-Daudé
While this test is skipped on Windows, we still get when building: tests/qtest/vnc-display-test.c:22:20: warning: unused function 'on_vnc_error' [-Wunused-function] static inline void on_vnc_error(VncConnection* self, ^ tests/qtest/vnc-display-test.c:28:20: warning: unu

[PATCH 2/3] tests/qtest/vnc-display-test: Use the 'none' machine

2023-01-19 Thread Philippe Mathieu-Daudé
If we don't specify any machine, an architecture default might be picked. But some architectures don't provide any default, such ARM: $ make check-qtest-aarch64 ... 19/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/vnc-display-test qemu-system-aarch64: No machine specified, and there is no de

[RFC PATCH 3/3] tests/qtest/vnc-display-test: Disable on Darwin

2023-01-19 Thread Philippe Mathieu-Daudé
This test is failing in gtk-vnc on Darwin: $ make check-qtest-aarch64 ... 19/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/vnc-display-test ERROR **: 10:42:35.488: vnc-error: Unsupported auth type 17973672 While QEMU picks the sigaltstack coroutine backend, gtk-vnc uses the ucontext corouti

Re: [PATCH v4 17/19] Don't include headers already included by qemu/osdep.h

2023-01-19 Thread Christian Schoenebeck
On Thursday, January 19, 2023 7:59:57 AM CET Markus Armbruster wrote: > This commit was created with scripts/clean-includes. > > Signed-off-by: Markus Armbruster > --- For 9p changes: Acked-by: Christian Schoenebeck > backends/tpm/tpm_ioctl.h | 2 -- > fsdev/p9array.h

Re: [PATCH 00/20] target/arm: CONFIG_TCG=n part 1

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 08:41, Philippe Mathieu-Daudé wrote: On 18/1/23 20:34, Fabiano Rosas wrote: These are the already reviewed patches from the first half of my previous series: https://lore.kernel.org/r/20230113140419.4013-1-faro...@suse.de This unbreaks the --disable-tcg build, but there are issues in

Re: [PATCH 0/8] hw/cxl: CXL emulation cleanups and minor fixes for upstream

2023-01-19 Thread Jonathan Cameron via
On Thu, 19 Jan 2023 06:48:11 -0500 "Michael S. Tsirkin" wrote: > On Thu, Jan 19, 2023 at 10:19:46AM +, Jonathan Cameron wrote: > > On Wed, 18 Jan 2023 14:22:08 -0500 > > Gregory Price wrote: > > > > > 1) No stack traces present > > > 2) Device usage appears to work, but cxl-cli fails to c

Re: [PATCH 00/20] target/arm: CONFIG_TCG=n part 1

2023-01-19 Thread Philippe Mathieu-Daudé
On 19/1/23 08:41, Philippe Mathieu-Daudé wrote: On 18/1/23 20:34, Fabiano Rosas wrote: These are the already reviewed patches from the first half of my previous series: https://lore.kernel.org/r/20230113140419.4013-1-faro...@suse.de This unbreaks the --disable-tcg build, but there are issues in

Re: [PATCH 2/3] tests/qtest/vnc-display-test: Use the 'none' machine

2023-01-19 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > If we don't specify any machine, an architecture default > might be picked. But some architectures don't provide any > default, such ARM: > > $ make check-qtest-aarch64 > ... > 19/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/vnc-display-test > qemu-system-a

Re: MSYS2 and libfdt

2023-01-19 Thread Thomas Huth
On 19/01/2023 09.55, Stefan Weil wrote: Am 19.01.23 um 09:14 schrieb Thomas Huth:  Hi all, in some spare minutes, I started playing with a patch to try to remove the dtc submodule from the QEMU git repository - according to https://repology.org/project/dtc/versions our supported build platf

Re: [PATCH 0/3] tests/qtest/vnc-display-test: Silent warnings & explicit machine

2023-01-19 Thread Marc-André Lureau
On Thu, Jan 19, 2023 at 4:05 PM Philippe Mathieu-Daudé wrote: > > - Silent warnings on Windows > - Explicit the 'none' machine > - Disable on Darwin Aarch64 host > > Philippe Mathieu-Daudé (3): > tests/qtest/vnc-display-test: Suppress build warnings on Windows > tests/qtest/vnc-display-test: U

Re: [PATCH 00/20] target/arm: CONFIG_TCG=n part 1

2023-01-19 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > On 18/1/23 20:34, Fabiano Rosas wrote: >> These are the already reviewed patches from the first half of my >> previous series: >> https://lore.kernel.org/r/20230113140419.4013-1-faro...@suse.de >> >> This unbreaks the --disable-tcg build, but there are issues in

Re: [PATCH v4 6/8] Update lcitool and fedora to 37

2023-01-19 Thread Alex Bennée
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Fedora 35 is EOL. > > Update to upstream lcitool, that dropped f35 and added f37. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Thomas Huth > --- > tests/docker/dockerfiles/fedora-win32-cross.docker | 4 ++-- > tests/doc

[PATCH 01/25] m25p80: Improve error when the backend file size does not match the device

2023-01-19 Thread Cédric Le Goater
Currently, when a block backend is attached to a m25p80 device and the associated file size does not match the flash model, QEMU complains with the error message "failed to read the initial flash content". This is confusing for the user. Use blk_check_size_and_read_all() instead of blk_pread() to

[PATCH 16/25] hw/watchdog/wdt_aspeed: Rename MMIO region size as 'iosize'

2023-01-19 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé Avoid confusing two different things: - the WDT I/O region size ('iosize') - at which offset the SoC map the WDT ('offset') While it is often the same, we can map smaller region sizes at larger offsets. Here we are interested in the I/O region size, so rename as 'ios

[PATCH 15/25] target/arm: Allow users to set the number of VFP registers

2023-01-19 Thread Cédric Le Goater
Cortex A7 CPUs with an FPU implementing VFPv4 without NEON support have 16 64-bit FPU registers and not 32 registers. Let users set the number of VFP registers with a CPU property. The primary use case of this property is for the Cortex A7 of the Aspeed AST2600 SoC. Signed-off-by: Cédric Le Goate

  1   2   3   4   5   >