Re: [PATCH v3 3/3] python/qemu/machine: use socketpair() for QMP by default

2023-01-18 Thread Marc-André Lureau
Hi On Wed, Jan 18, 2023 at 2:36 AM John Snow wrote: > > On Wed, Jan 11, 2023 at 3:01 AM wrote: > > > > From: Marc-André Lureau > > > > When no monitor address is given, establish the QMP communication through > > a socketpair() (API is also supported on Windows since Python 3.5) > > > > Signed-

Re: [PATCH v10 1/9] mm: Introduce memfd_restricted system call to create restricted user memory

2023-01-18 Thread Chao Peng
On Tue, Jan 17, 2023 at 04:34:15PM +, Sean Christopherson wrote: > On Tue, Jan 17, 2023, Chao Peng wrote: > > On Fri, Jan 13, 2023 at 09:54:41PM +, Sean Christopherson wrote: > > > > + list_for_each_entry(notifier, &data->notifiers, list) { > > > > + notifier->ops->inval

Re: [PATCH v10 9/9] KVM: Enable and expose KVM_MEM_PRIVATE

2023-01-18 Thread Chao Peng
On Tue, Jan 17, 2023 at 07:35:58PM +, Sean Christopherson wrote: > On Tue, Jan 17, 2023, Chao Peng wrote: > > On Sat, Jan 14, 2023 at 12:01:01AM +, Sean Christopherson wrote: > > > On Fri, Dec 02, 2022, Chao Peng wrote: > > > > @@ -10357,6 +10364,12 @@ static int vcpu_enter_guest(struct kvm

Re: [PATCH v2 04/11] hw/arm/aspeed: Use the IEC binary prefix definitions

2023-01-18 Thread Philippe Mathieu-Daudé
On 18/1/23 08:32, Cédric Le Goater wrote: On 1/18/23 07:53, Joel Stanley wrote: On Fri, 30 Dec 2022 at 11:35, Philippe Mathieu-Daudé wrote: IEC binary prefixes ease code review: the unit is explicit. I strongly prefer the existing code; it tells you the size without having to do maths. I

Re: [PATCH v2 04/11] hw/arm/aspeed: Use the IEC binary prefix definitions

2023-01-18 Thread Cédric Le Goater
On 1/18/23 09:37, Philippe Mathieu-Daudé wrote: On 18/1/23 08:32, Cédric Le Goater wrote: On 1/18/23 07:53, Joel Stanley wrote: On Fri, 30 Dec 2022 at 11:35, Philippe Mathieu-Daudé wrote: IEC binary prefixes ease code review: the unit is explicit. I strongly prefer the existing code; it te

Re: [PATCH v2 01/11] hw/watchdog/wdt_aspeed: Rename MMIO region size as 'iosize'

2023-01-18 Thread Cédric Le Goater
Philippe, On 1/2/23 13:30, Cédric Le Goater wrote: On 12/31/22 23:43, Dong, Eddie wrote: Avoid confusing two different things: - the WDT I/O region size ('iosize') - at which offset the SoC map the WDT ('offset') While it is often the same, we can map smaller region sizes at larger offsets. H

Re: reverse-{debugging,continue} not working on v7.2.0, i386 guest

2023-01-18 Thread Hyeonggon Yoo
On Wed, Jan 18, 2023 at 10:12:48AM +0300, Pavel Dovgalyuk wrote: > As replay works well, the reverse debugging should be ok too. > But for "going back" it needs a VM snapshot that can be used for reload. > > Snapshots are saved on qcow2 images connected to QEMU. > Therefore you need to add an empt

Re: [PATCH v2 02/11] hw/watchdog/wdt_aspeed: Extend MMIO range to cover more registers

2023-01-18 Thread Cédric Le Goater
Philippe, On 1/2/23 14:31, Cédric Le Goater wrote: On 12/31/22 23:52, Dong, Eddie wrote: When booting the Zephyr demo in [1] we get:    aspeed.io: unimplemented device write (size 4, offset 0x185128, value 0x030f1ff1) <--    aspeed.io: unimplemented device write (size 4, offset 0x18512c, value

[PATCH v2] linux-user: fix strace build w/out munlockall

2023-01-18 Thread Mike Frysinger
Signed-off-by: Mike Frysinger Reviewed-by: Philippe Mathieu-Daud?? --- linux-user/strace.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index 9ae5a812cd71..11a7c3df9498 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c

Re: [PATCH] target/tricore: Remove unused fields from CPUTriCoreState

2023-01-18 Thread Bastian Koppelmann
Hi Richard, On Tue, Jan 17, 2023 at 11:01:37AM -1000, Richard Henderson wrote: > On 1/17/23 08:42, Philippe Mathieu-Daudé wrote: > > Remove dead code: > > - unused fields in CPUTriCoreState > > - (unexisting) tricore_def_t structure > > - forward declaration of tricore_boot_info structure > >(

Re: [PATCH] target/tricore: Remove unused fields from CPUTriCoreState

2023-01-18 Thread Bastian Koppelmann
On Tue, Jan 17, 2023 at 07:42:17PM +0100, Philippe Mathieu-Daudé wrote: > Remove dead code: > - unused fields in CPUTriCoreState > - (unexisting) tricore_def_t structure > - forward declaration of tricore_boot_info structure > (declared in "hw/tricore/tricore.h", used once in >hw/tricore/tric

Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-18 Thread Kevin Wolf
Am 17.01.2023 um 21:43 hat Stefan Hajnoczi geschrieben: > On Tue, 17 Jan 2023 at 12:17, Kevin Wolf wrote: > > > > Am 17.01.2023 um 17:43 hat Warner Losh geschrieben: > > > On Tue, Jan 17, 2023 at 9:25 AM Kevin Wolf wrote: > > > > > > > Am 17.01.2023 um 17:16 hat Warner Losh geschrieben: > > > > >

[PATCH v2] target/tricore: Remove unused fields from CPUTriCoreState

2023-01-18 Thread Philippe Mathieu-Daudé
Remove dead code: - unused fields in CPUTriCoreState - (unexisting) tricore_def_t structure - forward declaration of tricore_boot_info structure (declared in "hw/tricore/tricore.h", used once in hw/tricore/tricore_testboard.c). Reviewed-by: Richard Henderson Reviewed-by: Bastian Koppelmann

Re: reverse-{debugging,continue} not working on v7.2.0, i386 guest

2023-01-18 Thread Pavel Dovgalyuk
Sometimes replay (or reverse debugging) have problems due to incomplete or incorrect virtual device save/load implementation. Can you try removing -cpu from your command line? Or you can provide the files you load and I'll debug this case. On 18.01.2023 11:47, Hyeonggon Yoo wrote: On Wed, Ja

[PATCH 0/2] hw/pci-host/gt64120: Fix regression on big-endian targets

2023-01-18 Thread Philippe Mathieu-Daudé
Klauss reported a regression on big-endian targets, introduced by commit 145e2198d749 ("hw/mips/gt64xxx_pci: Endian-swap using PCI_HOST_BRIDGE MemoryRegionOps"). Fix it and add the Klauss' reproducer as Avocado test. Philippe Mathieu-Daudé (2): hw/pci-host/gt64120: Fix PCI I/O config register en

[PATCH 1/2] hw/pci-host/gt64120: Fix PCI I/O config register endianness

2023-01-18 Thread Philippe Mathieu-Daudé
The MByteSwap bit only affects the data register endianness, not the config register. Map the config register once in the gt64120_realize() handler, and only remap the data register when the mapping is updated. Fixes: 145e2198d7 ("gt64xxx: Endian-swap using PCI_HOST_BRIDGE MemoryRegionOps") Report

[PATCH 2/2] tests/avocado: Add test accessing NVMe on big-endian MIPS target

2023-01-18 Thread Philippe Mathieu-Daudé
Add a Linux-boot test accessing PCI NVMe drive on big-endian MIPS: $ avocado --show=app,console run -t device:nvme tests/avocado/ (1/1) tests/avocado/boot_linux_console.py:BootLinuxConsole.test_mips64_malta_I6400_nvme: console: Linux version 6.2.0-rc4 (kbj@butter) (mips64-buildroot-linux-gn

Re: mips, nvme/pci boot regression (commit 145e2198d749)

2023-01-18 Thread Philippe Mathieu-Daudé
On 18/1/23 08:24, Klaus Jensen wrote: On Jan 17 15:25, Philippe Mathieu-Daudé wrote: On 17/1/23 13:30, Klaus Jensen wrote: Commit 145e2198d749 ("hw/mips/gt64xxx_pci: Endian-swap using PCI_HOST_BRIDGE MemoryRegionOps") broke my mips64 nvme boot test (little-endian host, mips64 and nvme boot dev

Re: [PATCH 0/2] hw/pci-host/gt64120: Fix regression on big-endian targets

2023-01-18 Thread Philippe Mathieu-Daudé
On 18/1/23 10:40, Philippe Mathieu-Daudé wrote: Klauss reported a regression on big-endian targets, introduced by commit 145e2198d749 ("hw/mips/gt64xxx_pci: Endian-swap using PCI_HOST_BRIDGE MemoryRegionOps"). Fix it and add the Klauss' reproducer as Avocado test. Sorry Klaus for adding an extr

Re: [PATCH 2/2] hw/ppc/pegasos2: Extract via_vt8231_create() helper

2023-01-18 Thread Philippe Mathieu-Daudé
On 17/1/23 22:17, BALATON Zoltan wrote: On Tue, 17 Jan 2023, Philippe Mathieu-Daudé wrote: Simplify a bit pegasos2_init() by extracting the VIA southbridge creation code into a new via_vt8231_create() helper. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/pegasos2.c | 33

Re: [PATCH 1/2] hw/pci-host/gt64120: Fix PCI I/O config register endianness

2023-01-18 Thread Klaus Jensen
On Jan 18 10:40, Philippe Mathieu-Daudé wrote: > The MByteSwap bit only affects the data register endianness, > not the config register. Map the config register once in the > gt64120_realize() handler, and only remap the data register > when the mapping is updated. > > Fixes: 145e2198d7 ("gt64xxx:

Re: [PATCH 0/2] hw/pci-host/gt64120: Fix regression on big-endian targets

2023-01-18 Thread Klaus Jensen
On Jan 18 10:43, Philippe Mathieu-Daudé wrote: > On 18/1/23 10:40, Philippe Mathieu-Daudé wrote: > > Klauss reported a regression on big-endian targets, introduced > > by commit 145e2198d749 ("hw/mips/gt64xxx_pci: Endian-swap using > > PCI_HOST_BRIDGE MemoryRegionOps"). Fix it and add the Klauss' >

Re: [PATCH] ppc/pegasos2: Improve readability of VIA south bridge creation

2023-01-18 Thread Philippe Mathieu-Daudé
On 17/1/23 22:57, BALATON Zoltan wrote: On Tue, 17 Jan 2023, BALATON Zoltan wrote: Slightly improve readability of creating the south btidge by cnamging Still left a typo in "bridge" above... Also "naming". This is alternative, inspired by Phil's patches, maybe I'd also need to add Inspire

Re: [PATCH v14 06/11] s390x/cpu topology: interception of PTF instruction

2023-01-18 Thread Pierre Morel
On 1/16/23 19:24, Nina Schoetterl-Glausch wrote: On Thu, 2023-01-05 at 15:53 +0100, Pierre Morel wrote: When the host supports the CPU topology facility, the PTF instruction with function code 2 is interpreted by the SIE, provided that the userland hypervizor activates the interpretation by u

[PATCH v2 0/2] hw/pci-host/gt64120: Fix regression on big-endian targets

2023-01-18 Thread Philippe Mathieu-Daudé
Klaus reported a regression on big-endian targets, introduced by commit 145e2198d749 ("hw/mips/gt64xxx_pci: Endian-swap using PCI_HOST_BRIDGE MemoryRegionOps"). Fix it and add the Klaus' reproducer as Avocado test. Since v1: - Add Klaus Tested-by tag in patch #1 - Add parenthesis in "(v & b) ? x :

[PATCH v2 1/2] hw/pci-host/gt64120: Fix PCI I/O config register endianness

2023-01-18 Thread Philippe Mathieu-Daudé
The MByteSwap bit only affects the data register endianness, not the config register. Map the config register once in the gt64120_realize() handler, and only remap the data register when the mapping is updated. Fixes: 145e2198d7 ("gt64xxx: Endian-swap using PCI_HOST_BRIDGE MemoryRegionOps") Report

[PATCH v2 2/2] tests/avocado: Add test accessing NVMe on big-endian MIPS target

2023-01-18 Thread Philippe Mathieu-Daudé
Add a Linux-boot test accessing PCI NVMe drive on big-endian MIPS: $ avocado --show=app,console run -t device:nvme tests/avocado/ (1/1) tests/avocado/boot_linux_console.py:BootLinuxConsole.test_mips64_malta_I6400_nvme: console: Linux version 6.2.0-rc4 (kbj@butter) (mips64-buildroot-linux-gn

Re: [PATCH 1/2] target/arm: Introduce helper_set_rounding_mode_chkfrm

2023-01-18 Thread Daniel Henrique Barboza
s/arm/riscv in subject/commit title ^ On 1/15/23 13:06, Richard Henderson wrote: The new helper always validates the contents of FRM, even if the new rounding mode is not DYN. This is required by the vector unit. Track whether we've validated FRM separately from whether we've updated fp_status

Re: [PATCH 2/2] target/riscv: Remove helper_set_rod_rounding_mode

2023-01-18 Thread Daniel Henrique Barboza
On 1/15/23 13:06, Richard Henderson wrote: The only setting of RISCV_FRM_ROD is from the vector unit, and now handled by helper_set_rounding_mode_chkfrm. This helper is now unused. Signed-off-by: Richard Henderson --- Reviewed-by: Daniel Henrique Barboza target/riscv/helper.h | 1

Re: [PATCH v14 07/11] target/s390x/cpu topology: activating CPU topology

2023-01-18 Thread Pierre Morel
On 1/11/23 11:04, Thomas Huth wrote: On 05/01/2023 15.53, Pierre Morel wrote: The KVM capability, KVM_CAP_S390_CPU_TOPOLOGY is used to Remove the "," in above line? OK activate the S390_FEAT_CONFIGURATION_TOPOLOGY feature and the topology facility for the guest in the case the topolog

Re: [PATCH v2 0/6] Resolve TYPE_PIIX3_XEN_DEVICE

2023-01-18 Thread Michael S. Tsirkin
On Wed, Jan 04, 2023 at 03:44:31PM +0100, Bernhard Beschow wrote: > This series first renders TYPE_PIIX3_XEN_DEVICE redundant and finally removes > it. The motivation is to 1/ decouple PIIX from Xen and 2/ to make Xen in the > PC > machine agnostic to the precise southbridge being used. 2/ will be

Re: [PATCH v10 1/9] mm: Introduce memfd_restricted system call to create restricted user memory

2023-01-18 Thread Isaku Yamahata
On Wed, Jan 18, 2023 at 04:16:41PM +0800, Chao Peng wrote: > On Tue, Jan 17, 2023 at 04:34:15PM +, Sean Christopherson wrote: > > On Tue, Jan 17, 2023, Chao Peng wrote: > > > On Fri, Jan 13, 2023 at 09:54:41PM +, Sean Christopherson wrote: > > > > > + list_for_each_entry(notifier, &da

Re: [for-8.0 v2 05/11] cryptodev: Introduce 'query-cryptodev' QMP command

2023-01-18 Thread Michael S. Tsirkin
On Mon, Jan 16, 2023 at 11:18:19AM +, Daniel P. Berrangé wrote: > > +for (uint32_t i = 0; i < QCRYPTODEV_BACKEND_SERVICE__MAX; i++) { > > QEMU coding style doesn't declare types inside the for() control > conditions. I'd suggest 'size_t i', and put it at top of this > function. It's actua

Re: [PATCH v14 03/11] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-01-18 Thread Thomas Huth
On 17/01/2023 17.56, Pierre Morel wrote: On 1/10/23 15:29, Thomas Huth wrote: On 05/01/2023 15.53, Pierre Morel wrote: On interception of STSI(15.1.x) the System Information Block (SYSIB) is built from the list of pre-ordered topology entries. Signed-off-by: Pierre Morel --- ... +typedef

Re: [PATCH v4 5/5] hw/nvram/eeprom_at24c: Make reset behavior more like hardware

2023-01-18 Thread Cédric Le Goater
On 1/18/23 03:42, Peter Delevoryas wrote: EEPROM's are a form of non-volatile memory. After power-cycling an EEPROM, I would expect the I2C state machine to be reset to default values, but I wouldn't really expect the memory to change at all. The current implementation of the at24c EEPROM resets

Re: [for-8.0 v2 05/11] cryptodev: Introduce 'query-cryptodev' QMP command

2023-01-18 Thread Daniel P . Berrangé
On Wed, Jan 18, 2023 at 05:25:37AM -0500, Michael S. Tsirkin wrote: > On Mon, Jan 16, 2023 at 11:18:19AM +, Daniel P. Berrangé wrote: > > > +for (uint32_t i = 0; i < QCRYPTODEV_BACKEND_SERVICE__MAX; i++) { > > > > QEMU coding style doesn't declare types inside the for() control > > conditi

Re: [PATCH v4 4/5] hw/arm/aspeed: Add aspeed_eeprom.c

2023-01-18 Thread Cédric Le Goater
On 1/18/23 03:42, Peter Delevoryas wrote: - Create aspeed_eeprom.c and aspeed_eeprom.h - Include aspeed_eeprom.c in CONFIG_ASPEED meson source files - Include aspeed_eeprom.h in aspeed.c - Add fby35_bmc_fruid data - Use new at24c_eeprom_init_rom helper to initialize BMC FRUID EEPROM with data

Re: [PATCH 0/5] migration: Modified 'migrate' QAPI command for migration

2023-01-18 Thread Claudio Fontana
On 1/18/23 06:52, Het Gala wrote: > > On 17/01/23 4:22 pm, Claudio Fontana wrote: >> Hi, >> >> On 12/26/22 06:33, Het Gala wrote: >>> Current QAPI 'migrate' command design (for initiating a migration >>> stream) contains information regarding different migrate transport mechanism >>> (tcp / unix /

Re: [RFC PATCH v3 18/28] target/arm: Move common cpu code into cpu.c

2023-01-18 Thread Philippe Mathieu-Daudé
On 17/1/23 20:01, Fabiano Rosas wrote: Philippe Mathieu-Daudé writes: On 13/1/23 15:04, Fabiano Rosas wrote: The cpu_tcg.c file about to be moved into the tcg directory. Move the code that is needed for cpus that also work with KVM into cpu.c. Signed-off-by: Fabiano Rosas --- target/arm/

Re: [RFC PATCH v3 00/28] target/arm: Allow CONFIG_TCG=n builds

2023-01-18 Thread Philippe Mathieu-Daudé
On 13/1/23 15:03, Fabiano Rosas wrote: This series makes the necessary changes to allow the use of --disable-tcg for arm. Based on Richard's "target/arm: Introduce aarch64_set_svcr": https://lore.kernel.org/r/20230112004322.161330-1-richard.hender...@linaro.org branch here: https://github.com/f

Re: [PATCH v14 08/11] qapi/s390/cpu topology: change-topology monitor command

2023-01-18 Thread Thomas Huth
On 17/01/2023 14.31, Nina Schoetterl-Glausch wrote: On Tue, 2023-01-17 at 08:30 +0100, Thomas Huth wrote: On 16/01/2023 22.09, Nina Schoetterl-Glausch wrote: On Thu, 2023-01-05 at 15:53 +0100, Pierre Morel wrote: The modification of the CPU attributes are done through a monitor commands. It a

Re: [for-8.0 v2 05/11] cryptodev: Introduce 'query-cryptodev' QMP command

2023-01-18 Thread Thomas Huth
On 18/01/2023 11.29, Daniel P. Berrangé wrote: On Wed, Jan 18, 2023 at 05:25:37AM -0500, Michael S. Tsirkin wrote: On Mon, Jan 16, 2023 at 11:18:19AM +, Daniel P. Berrangé wrote: +for (uint32_t i = 0; i < QCRYPTODEV_BACKEND_SERVICE__MAX; i++) { QEMU coding style doesn't declare types

Re: [for-8.0 v2 05/11] cryptodev: Introduce 'query-cryptodev' QMP command

2023-01-18 Thread Daniel P . Berrangé
On Wed, Jan 18, 2023 at 11:58:19AM +0100, Thomas Huth wrote: > On 18/01/2023 11.29, Daniel P. Berrangé wrote: > > On Wed, Jan 18, 2023 at 05:25:37AM -0500, Michael S. Tsirkin wrote: > > > On Mon, Jan 16, 2023 at 11:18:19AM +, Daniel P. Berrangé wrote: > > > > > +for (uint32_t i = 0; i < QCR

Re: [PULL v4 76/83] vhost-user: Support vhost_dev_start

2023-01-18 Thread Michael S. Tsirkin
On Tue, Jan 17, 2023 at 07:21:28PM +0100, Greg Kurz wrote: > On Tue, 17 Jan 2023 18:55:24 +0100 > Greg Kurz wrote: > > > On Tue, 17 Jan 2023 16:07:00 +0100 > > Maxime Coquelin wrote: > > > > > > > > > > > On 1/17/23 13:36, Greg Kurz wrote: > > > > On Tue, 17 Jan 2023 13:12:57 +0100 > > > > Gr

Re: [PATCH v2 1/2] hw/pci-host/gt64120: Fix PCI I/O config register endianness

2023-01-18 Thread Philippe Mathieu-Daudé
On 18/1/23 10:57, Philippe Mathieu-Daudé wrote: The MByteSwap bit only affects the data register endianness, not the config register. Map the config register once in the gt64120_realize() handler, and only remap the data register when the mapping is updated. Fixes: 145e2198d7 ("gt64xxx: Endian-s

RE: [QUESTION] About virtio and eventloop

2023-01-18 Thread zhukeqian via
Hi Stefan, this indeed helps, thank you. Keqian On Mon, 16 Jan 2023 at 03:20, zhukeqian via mailto:qemu-devel@nongnu.org>> wrote: > And if IO operation is blocked, is vCPU thread will blocked when do > deactivate? Yes, blk_drain() is a synchronous function. It blocks until in-flight I/O has fi

Re: [PATCH v3 2/3] hvf: implement guest debugging on Apple Silicon hosts

2023-01-18 Thread Mads Ynddal
> On 14 Jan 2023, at 17.13, francesco.cag...@gmail.com wrote: > > From: Francesco Cagnin > > Support is added for single-stepping, software breakpoints, hardware > breakpoints and watchpoints. The code has been structured like the KVM > counterpart (and many parts are basically identical). >

Re: [RFC PATCH v3 18/28] target/arm: Move common cpu code into cpu.c

2023-01-18 Thread Claudio Fontana
On 1/18/23 11:45, Philippe Mathieu-Daudé wrote: > On 17/1/23 20:01, Fabiano Rosas wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 13/1/23 15:04, Fabiano Rosas wrote: The cpu_tcg.c file about to be moved into the tcg directory. Move the code that is needed for cpus that also work with

Re: [PATCH v3 6/7] hw/isa/isa-bus: Turn isa_build_aml() into qbus_build_aml()

2023-01-18 Thread Igor Mammedov
On Mon, 16 Jan 2023 16:29:07 +0100 Bernhard Beschow wrote: > Frees isa-bus.c from implicit ACPI dependency. > > Signed-off-by: Bernhard Beschow > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > include/hw/acpi/acpi_aml_interface.h | 3 +++ > include/hw/isa/isa.h

[PULL 4/9] MAINTAINERS: Remove bouncing mail address from Kamil Rytarowski

2023-01-18 Thread Thomas Huth
When sending mail to Kamil's address, it's bouncing with a message that the mailbox is full. This already happens since summer 2022, and the last message that Kamil sent to the qemu-devel mailing list is from November 2021 (as far as I can see), so we unfortunately have to assume that this e-mail a

[PULL 2/9] Makefile: allow 'make uninstall'

2023-01-18 Thread Thomas Huth
From: Peter Maydell Meson supports an "uninstall", so we can easily allow it to work by not suppressing the forwarding of it from Make to meson. We originally suppressed this because Meson's 'uninstall' has a hole in it: it will remove everything that is installed by a mechanism meson knows abou

[PULL 1/9] Upgrade all packages in the FreeBSD VMs to ensure the freshness

2023-01-18 Thread Thomas Huth
From: Li-Wen Hsu This (hopefully) fixes the errors that we currently see in the FreeBSD jobs in the gitlab CI: ld-elf.so.1: /usr/local/bin/bash: Undefined symbol "rl_set_timeout" Signed-off-by: Li-Wen Hsu Message-Id: [thuth: Update subject and patch description] Signed-off-by: Thomas Huth -

[PULL 3/9] bulk: Rename TARGET_FMT_plx -> HWADDR_FMT_plx

2023-01-18 Thread Thomas Huth
From: Philippe Mathieu-Daudé The 'hwaddr' type is defined in "exec/hwaddr.h" as: hwaddr is the type of a physical address (its size can be different from 'target_ulong'). All definitions use the 'HWADDR_' prefix, except TARGET_FMT_plx: $ fgrep define include/exec/hwaddr.h #define HWAD

[PULL 0/9] Testing, s390x and misc patches

2023-01-18 Thread Thomas Huth
Hi Peter! The following changes since commit 7c9236d6d61f30583d5d860097d88dbf0fe487bf: Merge tag 'pull-tcg-20230116' of https://gitlab.com/rth7680/qemu into staging (2023-01-17 10:24:16 +) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2023

[PULL 6/9] tests/qtest/e1000e-test: Fix the code style

2023-01-18 Thread Thomas Huth
From: Akihiko Odaki igb implementation first starts off by copying e1000e code. Correct the code style before that. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230114035919.35251-19-akihiko.od...@daynix.com> Signed-off-by: Thomas Huth --- tests/qtest/e1000

[PULL 7/9] tests/qtest/libqos/e1000e: Remove duplicate register definitions

2023-01-18 Thread Thomas Huth
From: Akihiko Odaki The register definitions in tests/qtest/libqos/e1000e.h had names different from hw/net/e1000_regs.h, which made it hard to understand what test codes corresponds to the implementation. Use hw/net/e1000_regs.h from tests/qtest/libqos/e1000e.c to remove these duplications. Sig

[PULL 9/9] s390x/pv: Implement a CGS check helper

2023-01-18 Thread Thomas Huth
From: Cédric Le Goater When a protected VM is started with the maximum number of CPUs (248), the service call providing information on the CPUs requires more buffer space than allocated and QEMU disgracefully aborts : LOADPARM=[] Using virtio-blk. Using SCSI scheme.

[PULL 5/9] tests/qtest: Restrict bcm2835-dma-test to CONFIG_RASPI

2023-01-18 Thread Thomas Huth
From: Fabiano Rosas We will soon enable the build without TCG, which does not support many machines, so only run the bcm2835-dma-test when the corresponding machine is present. Signed-off-by: Fabiano Rosas Message-Id: <20230113140419.4013-23-faro...@suse.de> Reviewed-by: Philippe Mathieu-Daudé

[PULL 8/9] tests/vm/haiku.x86_64: Update the Haiku VM to Beta 4

2023-01-18 Thread Thomas Huth
The old Haiku VM based on Beta 3 does not work anymore since it fails to install the additional packages now that Beta 4 has been released. Thanks to Alexander von Gluck IV for providing a new image based on Beta 4, we can now upgrade the test image in our QEMU CI, too, to get this working again.

Re: [PATCH v3 7/7] piix3, ich9: Reuse qbus_build_aml()

2023-01-18 Thread Igor Mammedov
On Mon, 16 Jan 2023 16:29:08 +0100 Bernhard Beschow wrote: > Signed-off-by: Bernhard Beschow > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov I'd squash it in previous patch, and rename that to something 'remove no longer needed isa_build_aml() isa_build_aml() doesn't do

Re: [PATCH v14 03/11] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-01-18 Thread Nina Schoetterl-Glausch
On Wed, 2023-01-18 at 11:26 +0100, Thomas Huth wrote: > On 17/01/2023 17.56, Pierre Morel wrote: > > > > > > On 1/10/23 15:29, Thomas Huth wrote: > > > On 05/01/2023 15.53, Pierre Morel wrote: > > > > On interception of STSI(15.1.x) the System Information Block > > > > (SYSIB) is built from the l

Re: [PATCH RFC 02/21] util: Include osdep.h first in util/mmap-alloc.c

2023-01-18 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Without it, we never have CONFIG_LINUX defined even if on linux, so > linux/mman.h is never really included. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > util/mmap-alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

Re: [PATCH RFC 03/21] physmem: Add qemu_ram_is_hugetlb()

2023-01-18 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Returns true for a hugetlbfs mapping, false otherwise. > > Signed-off-by: Peter Xu Yeh OK, it feels a little delecate perhaps if anything else ever allows large mappings. Reviewed-by: Dr. David Alan Gilbert > --- > include/exec/cpu-common.h | 1 + > s

[PATCH v7] tests/qtest: netdev: test stream and dgram backends

2023-01-18 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin Acked-by: Thomas Huth --- Notes: v7: - disable test_dgram_mcast() on windows - disable test_dgram_unix() on windows as it also fails (we test for unix support dynamically but the test is done with SOCK_S

Re: [PATCH RFC 04/21] madvise: Include linux/mman.h under linux-headers/

2023-01-18 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > This will allow qemu/madvise.h to always include linux/mman.h under the > linux-headers/. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > include/qemu/madvise.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/includ

Re: [RFC PATCH v3 18/28] target/arm: Move common cpu code into cpu.c

2023-01-18 Thread Fabiano Rosas
Claudio Fontana writes: > On 1/18/23 11:45, Philippe Mathieu-Daudé wrote: >> On 17/1/23 20:01, Fabiano Rosas wrote: >>> Philippe Mathieu-Daudé writes: >>> On 13/1/23 15:04, Fabiano Rosas wrote: > The cpu_tcg.c file about to be moved into the tcg directory. Move the > code that is ne

Re: [PATCH v5 2/2] riscv: Allow user to set the satp mode

2023-01-18 Thread Andrew Jones
On Wed, Jan 18, 2023 at 10:28:46AM +1000, Alistair Francis wrote: > On Wed, Jan 18, 2023 at 2:32 AM Andrew Jones wrote: > > > > On Fri, Jan 13, 2023 at 11:34:53AM +0100, Alexandre Ghiti wrote: ... > > > + > > > +/* Get rid of 32-bit/64-bit incompatibility */ > > > +for (int i = 0; i < 16;

[PATCH] tests/qtest/qom-test: Stop spamming the test log

2023-01-18 Thread Thomas Huth
We are still facing the issues that our test logs in the gitlab CI are too big (and thus cut off). A huge part is still caused by the qom-test that prints the path and name of each object it looks at by default. That's too much. Let's be silent by default, and only print the object path+name when r

[PATCH qemu 2/3] hw/intc/mt7628-intc.c: add mt7628 interrupt control support.

2023-01-18 Thread ~luhux
From: LuHui Signed-off-by: LuHui --- hw/intc/meson.build | 1 + hw/intc/mt7628-intc.c | 155 ++ include/hw/intc/mt7628-intc.h | 30 +++ 3 files changed, 186 insertions(+) create mode 100644 hw/intc/mt7628-intc.c create mode 100644 inclu

[PATCH qemu 1/3] hw/misc/mt7628-sysctrl.c: Add mt7628 system control support.

2023-01-18 Thread ~luhux
From: LuHui Signed-off-by: LuHui --- MAINTAINERS | 5 + hw/misc/meson.build | 3 + hw/misc/mt7628-sysctrl.c | 169 +++ include/hw/misc/mt7628-sysctrl.h | 66 4 files changed, 243 insertions(+) create mode 1

[PATCH qemu 3/3] hw/mips/mt7628.c: add mt7628 soc support, add a mt7628 board VoCore2.

2023-01-18 Thread ~luhux
From: LuHui Signed-off-by: LuHui --- MAINTAINERS | 1 + configs/devices/mips-softmmu/common.mak | 2 + hw/mips/Kconfig | 11 ++ hw/mips/meson.build | 2 + hw/mips/mt7628.c| 189 +++

Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-18 Thread Stefan Hajnoczi
On Wed, Jan 18, 2023, 04:15 Kevin Wolf wrote: > Am 17.01.2023 um 21:43 hat Stefan Hajnoczi geschrieben: > > On Tue, 17 Jan 2023 at 12:17, Kevin Wolf wrote: > > > > > > Am 17.01.2023 um 17:43 hat Warner Losh geschrieben: > > > > On Tue, Jan 17, 2023 at 9:25 AM Kevin Wolf wrote: > > > > > > > > >

Re: [PATCH] tests/qtest/qom-test: Stop spamming the test log

2023-01-18 Thread Daniel P . Berrangé
On Wed, Jan 18, 2023 at 01:25:57PM +0100, Thomas Huth wrote: > We are still facing the issues that our test logs in the gitlab CI > are too big (and thus cut off). A huge part is still caused by the > qom-test that prints the path and name of each object it looks at > by default. That's too much. L

Re: [PATCH v4 3/5] hw/nvram/eeprom_at24c: Add init_rom field and at24c_eeprom_init_rom helper

2023-01-18 Thread Cédric Le Goater
On 1/18/23 03:42, Peter Delevoryas wrote: Allows users to specify binary data to initialize an EEPROM, allowing users to emulate data programmed at manufacturing time. - Added init_rom and init_rom_size attributes to TYPE_AT24C_EE - Added at24c_eeprom_init_rom helper function to initialize attri

[PATCH 0/3] avocado_qemu: allow cross-arch tests

2023-01-18 Thread Daniel Henrique Barboza
Hi, In these changes I've introduced two new avocado env variables to allow users to run 'check-avocado' with different archs and machines in tests that doesn't set any arch/machine to run with. This is useful for archs that doesn't have abundance of real hardware available (e.g. RISC-V), meaning

[PATCH 3/3] avocado_qemu: add AVOCADO_DEFAULT_MACHINE

2023-01-18 Thread Daniel Henrique Barboza
Allow users to control which machine to use in tests where no particular machine is specified. This is a good way to run tests in a machine that's not the arch default, e.g. for qemu-system-x86_64 tests can be run using a machine other than pc-i440fx. This env var has greater effect when used toge

[PATCH 2/3] avocado_qemu: add AVOCADO_DEFAULT_ARCH for cross-arch tests

2023-01-18 Thread Daniel Henrique Barboza
All avocado tests that are arch agnostic (i.e. does not set an 'arch' tag) are run with arch=None in pick_default_qemu_bin(), and then 'arch' is set to os.uname()[4], meaning that it will take the arch of the running host. This means that if one compiles QEMU binaries for non-x86 targets on an x86

[PATCH 1/3] avocado_qemu: enhance CANCEL message in QemuBaseTest:setUp()

2023-01-18 Thread Daniel Henrique Barboza
Trying to run 'make check-avocado' while having only non-x86_64 QEMU binaries built, in a x86_64 host machine, will give us the following cancel message: "CANCEL: No QEMU binary defined or found in the build tree" Which is not quite what's happening here. Avocado defaults to the host arch for eve

Re: [RFC PATCH v3 18/28] target/arm: Move common cpu code into cpu.c

2023-01-18 Thread Fabiano Rosas
Richard Henderson writes: > On 1/13/23 06:04, Fabiano Rosas wrote: >> The cpu_tcg.c file about to be moved into the tcg directory. Move the >> code that is needed for cpus that also work with KVM into cpu.c. >> >> Signed-off-by: Fabiano Rosas >> --- >> target/arm/cpu.c | 76 ++

[PATCH] tests/qtest/bios-tables-test: Make the test less verbose by default

2023-01-18 Thread Thomas Huth
We are facing the issues that our test logs in the gitlab CI are too big (and thus cut off). The bios-tables-test is one of the few qtests that prints many lines of output by default when running with V=1, so it contributes to this problem. Almost all other qtests are silent with V=1 and only print

Re: [PATCH] tests/qtest/bios-tables-test: Make the test less verbose by default

2023-01-18 Thread Daniel P . Berrangé
On Wed, Jan 18, 2023 at 01:51:32PM +0100, Thomas Huth wrote: > We are facing the issues that our test logs in the gitlab CI are > too big (and thus cut off). The bios-tables-test is one of the few > qtests that prints many lines of output by default when running with > V=1, so it contributes to thi

Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

2023-01-18 Thread Thomas Huth
On 17/01/2023 11.44, Daniel P. Berrangé wrote: On Tue, Jan 17, 2023 at 11:32:42AM +0100, Thomas Huth wrote: ... - Instead of doing "cat meson-logs/testlog.txt" in the CI scripts, we switch to "tail -n 1000 meson-logs/testlog.txt" instead Tail requires that it has consumed the entire doc

Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

2023-01-18 Thread Daniel P . Berrangé
On Wed, Jan 18, 2023 at 01:55:49PM +0100, Thomas Huth wrote: > On 17/01/2023 11.44, Daniel P. Berrangé wrote: > > On Tue, Jan 17, 2023 at 11:32:42AM +0100, Thomas Huth wrote: > ... > > > - Instead of doing "cat meson-logs/testlog.txt" in the CI > > >scripts, we switch to "tail -n 1000 meson-log

float tests are too verbose (was: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default)

2023-01-18 Thread Thomas Huth
On 17/01/2023 11.44, Daniel P. Berrangé wrote: ... And what i think is test float being overly verbose >> Testing f16_le_quiet 46464 tests total. 1 2 3 4 46464 tests performed. Could be written as >> Testing f16_le_quiet: 46464 tests total

Re: [PATCH v14 08/11] qapi/s390/cpu topology: change-topology monitor command

2023-01-18 Thread Pierre Morel
On 1/12/23 13:03, Daniel P. Berrangé wrote: On Thu, Jan 05, 2023 at 03:53:10PM +0100, Pierre Morel wrote: The modification of the CPU attributes are done through a monitor commands. It allows to move the core inside the topology tree to optimise the cache usage in the case the host's hypervi

Re: [PATCH v14 08/11] qapi/s390/cpu topology: change-topology monitor command

2023-01-18 Thread Pierre Morel
On 1/16/23 22:09, Nina Schoetterl-Glausch wrote: On Thu, 2023-01-05 at 15:53 +0100, Pierre Morel wrote: The modification of the CPU attributes are done through a monitor commands. It allows to move the core inside the topology tree to optimise the cache usage in the case the host's hypervizo

Re: [PATCH v14 08/11] qapi/s390/cpu topology: change-topology monitor command

2023-01-18 Thread Pierre Morel
On 1/18/23 11:53, Thomas Huth wrote: On 17/01/2023 14.31, Nina Schoetterl-Glausch wrote: On Tue, 2023-01-17 at 08:30 +0100, Thomas Huth wrote: On 16/01/2023 22.09, Nina Schoetterl-Glausch wrote: On Thu, 2023-01-05 at 15:53 +0100, Pierre Morel wrote: The modification of the CPU attributes a

Re: [PATCH v14 08/11] qapi/s390/cpu topology: change-topology monitor command

2023-01-18 Thread Pierre Morel
On 1/11/23 11:09, Thomas Huth wrote: On 05/01/2023 15.53, Pierre Morel wrote: The modification of the CPU attributes are done through a monitor commands. s/commands/command/ thx It allows to move the core inside the topology tree to optimise the cache usage in the case the host's hype

Re: [PATCH] tests/qtest/bios-tables-test: Make the test less verbose by default

2023-01-18 Thread Philippe Mathieu-Daudé
On 18/1/23 13:51, Thomas Huth wrote: We are facing the issues that our test logs in the gitlab CI are too big (and thus cut off). The bios-tables-test is one of the few qtests that prints many lines of output by default when running with V=1, so it contributes to this problem. Almost all other qt

Re: [PATCH] tests/qtest/qom-test: Stop spamming the test log

2023-01-18 Thread Philippe Mathieu-Daudé
On 18/1/23 13:25, Thomas Huth wrote: We are still facing the issues that our test logs in the gitlab CI are too big (and thus cut off). A huge part is still caused by the qom-test that prints the path and name of each object it looks at by default. That's too much. Let's be silent by default, and

Re: [PATCH v8 07/11] parallels: Move check of cluster outside image to a separate function

2023-01-18 Thread Hanna Czenczek
On 15.01.23 16:58, Alexander Ivanov wrote: We will add more and more checks so we need a better code structure in parallels_co_check. Let each check performs in a separate loop in a separate helper. Signed-off-by: Alexander Ivanov Reviewed-by: Denis V. Lunev --- block/parallels.c | 59 ++

Re: [PATCH v8 11/11] parallels: Incorrect condition in out-of-image check

2023-01-18 Thread Hanna Czenczek
On 15.01.23 16:58, Alexander Ivanov wrote: All the offsets in the BAT must be lower than the file size. Fix the check condition for correct check. Signed-off-by: Alexander Ivanov Reviewed-by: Denis V. Lunev --- block/parallels.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [PATCH v8 08/11] parallels: Move check of leaks to a separate function

2023-01-18 Thread Hanna Czenczek
On 15.01.23 16:58, Alexander Ivanov wrote: We will add more and more checks so we need a better code structure in parallels_co_check. Let each check performs in a separate loop in a separate helper. Signed-off-by: Alexander Ivanov Reviewed-by: Denis V. Lunev --- block/parallels.c | 84 ++

Re: [PATCH v3 2/7] hw/acpi/acpi_dev_interface: Resolve AcpiDeviceIfClass::madt_cpu

2023-01-18 Thread Igor Mammedov
On Tue, 17 Jan 2023 00:30:23 + Bernhard Beschow wrote: > Am 16. Januar 2023 16:29:30 UTC schrieb Igor Mammedov : > >On Mon, 16 Jan 2023 16:29:03 +0100 > >Bernhard Beschow wrote: > > > >> This class attribute was always set to pc_madt_cpu_entry(). > >> pc_madt_cpu_entry() is architecture de

Re: completion timeouts with pin-based interrupts in QEMU hw/nvme

2023-01-18 Thread Peter Maydell
On Tue, 17 Jan 2023 at 19:21, Guenter Roeck wrote: > Anyway - any idea what to do to help figuring out what is happening ? > Add tracing support to pci interrupt handling, maybe ? For intermittent bugs, I like recording the QEMU session under rr (using its chaos mode to provoke the failure if nec

Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-18 Thread Emanuele Giuseppe Esposito
Am 17/01/2023 um 18:17 schrieb Kevin Wolf: > Am 17.01.2023 um 17:43 hat Warner Losh geschrieben: >> On Tue, Jan 17, 2023 at 9:25 AM Kevin Wolf wrote: >> >>> Am 17.01.2023 um 17:16 hat Warner Losh geschrieben: On Tue, Jan 17, 2023 at 6:52 AM Emanuele Giuseppe Esposito < eespo...@redhat

Re: [PATCH v14 08/11] qapi/s390/cpu topology: change-topology monitor command

2023-01-18 Thread Kevin Wolf
Am 18.01.2023 um 11:53 hat Thomas Huth geschrieben: > On 17/01/2023 14.31, Nina Schoetterl-Glausch wrote: > > On Tue, 2023-01-17 at 08:30 +0100, Thomas Huth wrote: > > > On 16/01/2023 22.09, Nina Schoetterl-Glausch wrote: > > > > On Thu, 2023-01-05 at 15:53 +0100, Pierre Morel wrote: > > > > > The

Re: [PATCH 1/3] avocado_qemu: enhance CANCEL message in QemuBaseTest:setUp()

2023-01-18 Thread Fabiano Rosas
Daniel Henrique Barboza writes: > Trying to run 'make check-avocado' while having only non-x86_64 QEMU > binaries built, in a x86_64 host machine, will give us the following > cancel message: > > "CANCEL: No QEMU binary defined or found in the build tree" > > Which is not quite what's happening h

Re: [PATCH 2/3] avocado_qemu: add AVOCADO_DEFAULT_ARCH for cross-arch tests

2023-01-18 Thread Fabiano Rosas
Daniel Henrique Barboza writes: > All avocado tests that are arch agnostic (i.e. does not set an 'arch' > tag) are run with arch=None in pick_default_qemu_bin(), and then 'arch' > is set to os.uname()[4], meaning that it will take the arch of the > running host. > > This means that if one compile

Re: [PATCH 2/3] bsd-user/mmap: use TSA_NO_TSA to suppress clang TSA warnings

2023-01-18 Thread Stefan Hajnoczi
On Wed, Jan 18, 2023 at 04:12:09PM +0100, Emanuele Giuseppe Esposito wrote: > > > Am 17/01/2023 um 18:17 schrieb Kevin Wolf: > > Am 17.01.2023 um 17:43 hat Warner Losh geschrieben: > >> On Tue, Jan 17, 2023 at 9:25 AM Kevin Wolf wrote: > >> > >>> Am 17.01.2023 um 17:16 hat Warner Losh geschriebe

  1   2   3   >