On 16/01/2023 18.46, Cédric Le Goater wrote:
From: Cédric Le Goater
If a secure kernel is started in a non-protected VM, the OS will hang
during boot without giving a proper error message to the user.
Perform the checks on Confidential Guest support at runtime with an
helper called from the se
On 17/1/23 00:56, Peter Delevoryas wrote:
This helper is useful in board initialization because lets users initialize and
realize an EEPROM on an I2C bus with a single function call.
Signed-off-by: Peter Delevoryas
---
hw/arm/aspeed.c | 10 +-
hw/arm/npcm7xx_boards.c
In order to create a function that allows testing of invalid command
lines, extract the parts of qtest_init_without_qmp_handshake that do
not require any successful set up of sockets.
Signed-off-by: Paolo Bonzini
---
tests/qtest/libqtest.c | 103 ++---
1 file
While QEMU catches invalid -accel command line options:
$ qemu-system-x86_64 -accel foo=bar
Accelerators supported in QEMU binary:
tcg
xen
kvm
the same is not true of configuration files, which instead crash. Patch 1
is the trivial fix, but writing a test is a bit more comple
If a test aborts after qtest_wait_qemu() is called, the SIGABRT hooks are
still in place and waitpid() is called again. The second time it is called,
the process does not exist anymore and the system call fails.
Move the s->qemu_pid = -1 assignment to qtest_wait_qemu() to make it
idempotent, and
On 17/1/23 08:39, Cédric Le Goater wrote:
On 1/17/23 00:56, Peter Delevoryas wrote:
- Create aspeed_eeprom.c and aspeed_eeprom.h
- Include aspeed_eeprom.c in CONFIG_ASPEED meson source files
- Include aspeed_eeprom.h in aspeed.c
- Add fby35_bmc_fruid data
- Use new at24c_eeprom_init_rom helper t
Test that invalid configurations do not cause a SIGSEGV, and cover a
valid configuration as well.
Signed-off-by: Paolo Bonzini
---
tests/qtest/libqtest.c| 28 +-
tests/qtest/libqtest.h| 12 ++
tests/qtest/readconfig-test.c | 45
While QEMU catches invalid -accel command line options:
$ qemu-system-x86_64 -accel foo=bar
Accelerators supported in QEMU binary:
tcg
xen
kvm
the same is not true of configuration files, which instead crash.
Avoid a SIGSEGV and return an error instead.
Reported-by: Thomas Hu
Queued, thanks.
Paolo
On 17/1/23 09:07, Paolo Bonzini wrote:
While QEMU catches invalid -accel command line options:
$ qemu-system-x86_64 -accel foo=bar
Accelerators supported in QEMU binary:
tcg
xen
kvm
the same is not true of configuration files, which instead crash.
Avoid a SIGSEGV and re
Queued, thanks.
Paolo
Philippe Mathieu-Daudé writes:
> On 16/1/23 07:40, Markus Armbruster wrote:
>> Peter Maydell writes:
>>
>>> On Mon, 9 Jan 2023 at 14:19, Philippe Mathieu-Daudé
>>> wrote:
On 9/1/23 14:33, BALATON Zoltan wrote:
> On Mon, 9 Jan 2023, Philippe Mathieu-Daudé wrote:
>> Use the sa
On 17/1/23 09:07, Paolo Bonzini wrote:
In order to create a function that allows testing of invalid command
lines, extract the parts of qtest_init_without_qmp_handshake that do
not require any successful set up of sockets.
Signed-off-by: Paolo Bonzini
---
tests/qtest/libqtest.c | 103
On 13/1/23 08:05, Philippe Mathieu-Daudé wrote:
On 13/1/23 02:05, Richard Henderson wrote:
On 1/11/23 08:31, Philippe Mathieu-Daudé wrote:
Implement Richard's suggestion to use __builtin_bswap().
Convert to __builtin_bswap() one patch per OS to simplify
maintainers review.
Since v2:
- Rebased
On 1/16/23 18:46, Cédric Le Goater wrote:
From: Cédric Le Goater
If a secure kernel is started in a non-protected VM, the OS will hang
during boot without giving a proper error message to the user.
Didn't we establish that you were missing the IOMMU flag so this
statement isn't correct anymo
On 05/01/2023 16.50, Claudio Imbrenda wrote:
This patch adds support for the asynchronous teardown for reboot for
protected VMs.
When attempting to tear down a protected VM, try to use the new
asynchronous interface first. If that fails, fall back to the classic
synchronous one.
The asynchronou
On 1/17/23 09:40, Janosch Frank wrote:
On 1/16/23 18:46, Cédric Le Goater wrote:
From: Cédric Le Goater
If a secure kernel is started in a non-protected VM, the OS will hang
during boot without giving a proper error message to the user.
Didn't we establish that you were missing the IOMMU fla
On 17/01/2023 09.40, Janosch Frank wrote:
On 1/16/23 18:46, Cédric Le Goater wrote:
From: Cédric Le Goater
If a secure kernel is started in a non-protected VM, the OS will hang
during boot without giving a proper error message to the user.
Didn't we establish that you were missing the IOMMU
Update lcitool to the latest submodule, which has improvements that
allow usage as a library.
Signed-off-by: Paolo Bonzini
---
tests/lcitool/libvirt-ci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/lcitool/libvirt-ci b/tests/lcitool/libvirt-ci
index a29b1c9925ed..d145
Using the lcitool package as a library will make it possible to
customize more of the process, for example by introducing custom
mappings.
Signed-off-by: Paolo Bonzini
---
.gitlab-ci.d/cirrus/freebsd-12.vars | 6 +-
.gitlab-ci.d/cirrus/freebsd-13.vars | 6 +-
.gitlab-ci.d/c
QEMU build and test scripts would like to use some new features that
were added to Python 3.7. Useful additions include removing the need
for OrderedDict, improved handling of default text encoding, postponed
evaluation of type annotations, and improvements to asyncio.
Using new features that wer
Python 3.6 is at end-of-life. Update the libvirt-ci module to a
version that supports overrides for targets and package mappings;
this way, QEMU can use the newer versions provided by CentOS 8 (Python
3.8) and OpenSUSE 15.3 (Python 3.9).
One unexpected issue is that sphinx-rtd-theme does not want
lcitool has generally catered to the Libvirt's needs in terms of
package versions, which are pretty conservative. For example, lcitool
is hardcoding a version of Meson equal to 0.56. QEMU on the other hand
has different needs since some features were added to Meson for the
project's benefit in vers
+#ifndef ASPEED_EEPROM_H
+#define ASPEED_EEPROM_H
+
+#include "qemu/osdep.h"
+
+extern const uint8_t fby35_bmc_fruid[];
may be define the array with an explicit size to avoid the size variable ?
I don't see any good solution.
/* Return rom_size and set rombufptr, or return 0 */
size_t aspe
On 1/17/23 10:09, Thomas Huth wrote:
On 17/01/2023 09.40, Janosch Frank wrote:
On 1/16/23 18:46, Cédric Le Goater wrote:
From: Cédric Le Goater
If a secure kernel is started in a non-protected VM, the OS will hang
during boot without giving a proper error message to the user.
Didn't we esta
Richard Henderson writes:
> There are some tests for which SIGTERM appears insufficient.
>
> Signed-off-by: Richard Henderson
> ---
> tests/tcg/Makefile.target | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target
>
On 16/01/2023 21:57, David Woodhouse wrote:
From: Joao Martins
The only thing we need to handle on KVM side is to change the
pfn from R/W to R/O.
Signed-off-by: Joao Martins
Signed-off-by: David Woodhouse
---
hw/i386/xen/meson.build| 5 -
hw/i386/xen/xen_platform.c | 39 +
On 16/01/2023 21:57, David Woodhouse wrote:
From: David Woodhouse
The xen_overlay device (and later similar devices for event channels and
grant tables) need to be instantiated. Do this from a kvm_type method on
the PC machine derivatives, since KVM is only way to support Xen emulation
for now.
Hi Yajun,
On 1/16/23 08:14, Yajun Wu wrote:
Not quite sure about the whole picture.
Seems while qemu waiting response of vhost_user_get_status, dpdk send out
VHOST_USER_SLAVE_IOTLB_MSG and trigger qemu function
vhost_backend_update_device_iotlb.
Qemu wait on reply of VHOST_USER_IOTLB_MSG but
On 1/16/23 21:34, Nina Schoetterl-Glausch wrote:
On Mon, 2023-01-16 at 18:28 +0100, Pierre Morel wrote:
On 1/13/23 17:58, Nina Schoetterl-Glausch wrote:
On Thu, 2023-01-05 at 15:53 +0100, Pierre Morel wrote:
S390 adds two new SMP levels, drawers and books to the CPU
topology.
The S390 CPU
On 16/01/2023 21:57, David Woodhouse wrote:
From: Joao Martins
Additionally set XEN_INTERFACE_VERSION to most recent in order to
exercise the "new" event_channel_op.
Signed-off-by: Joao Martins
[dwmw2: Ditch event_channel_op_compat which was never available to HVM guests]
Signed-off-by: David
* Eugenio Perez Martin (epere...@redhat.com) wrote:
> On Fri, Jan 13, 2023 at 5:55 AM Jason Wang wrote:
> >
> > On Fri, Jan 13, 2023 at 1:25 AM Eugenio Pérez wrote:
> > >
> > > This allows net to restart the device backend to configure SVQ on it.
> > >
> > > Ideally, these changes should not be n
On 17 January 2023 09:53:00 GMT, Paul Durrant wrote:
>On 16/01/2023 21:57, David Woodhouse wrote:
>> From: Joao Martins
>>
>> Additionally set XEN_INTERFACE_VERSION to most recent in order to
>> exercise the "new" event_channel_op.
>>
>> Signed-off-by: Joao Martins
>> [dwmw2: Ditch event_ch
On 16/01/2023 09.40, Thomas Huth wrote:
On 16/01/2023 09.29, Laurent Vivier wrote:
ping
On 1/5/23 10:37, Laurent Vivier wrote:
Signed-off-by: Laurent Vivier
Acked-by: Michael S. Tsirkin
---
Notes:
v5:
- disable test_stream_fd and test_dgram_fd on windows as
socketpair()
On 16/01/2023 21:57, David Woodhouse wrote:
From: David Woodhouse
Include basic support for setting HVM_PARAM_CALLBACK_IRQ to the global
vector method HVM_PARAM_CALLBACK_TYPE_VECTOR, which is handled in-kernel
by raising the vector whenever the vCPU's vcpu_info->evtchn_upcall_pending
flag is se
David Woodhouse writes:
> From: Joao Martins
>
> Specifically add listing, injection of event channels.
>
> Signed-off-by: Joao Martins
> Signed-off-by: David Woodhouse
> Acked-by: Dr. David Alan Gilbert
> ---
> hmp-commands.hx | 29
> hw/i386/kvm/meson.build | 4 ++
>
> -Original Message-
> From: Jason Wang
> Sent: Monday, 16 January 2023 09:01
> To: qemu-devel
> Subject: Re: [PATCH v2 00/13] Introduce igb
>
> On Sat, Jan 14, 2023 at 12:10 PM Akihiko Odaki
> wrote:
> >
> > Based-on: <20230114035919.35251-1-akihiko.od...@daynix.com>
> > ([PATCH 00/19]
On Tue, 17 Jan 2023 09:53:46 +0100
Thomas Huth wrote:
[...]
> > +static void *s390_pv_do_unprot_async_fn(void *p)
> > +{
> > + s390_pv_cmd_exit(KVM_PV_ASYNC_CLEANUP_PERFORM, NULL);
> > + return NULL;
> > +}
> > +
> > +bool s390_pv_vm_try_disable_async(void)
> > +{
> > +QemuThread *t;
On Tue, 2023-01-17 at 10:00 +, Paul Durrant wrote:
>
> > @@ -712,6 +717,11 @@ static int kvm_xen_soft_reset(void)
> > CPUState *cpu;
> > int err;
> >
> > + err = xen_evtchn_set_callback_param(0);
>
> Doesn't this always result in -ENOSYS?
Hm?
Even at this point in the s
On Mon, 16 Jan 2023 at 16:55, Peter Maydell wrote:
>
> On Thu, 15 Dec 2022 at 15:30, Thomas Huth wrote:
> >
> > We're still running into the problem that some logs are cut in the
> > gitlab-CI since they got too big. The biggest part of the log is
> > still the output of the qom-test. Let's stop
On Mon, 16 Jan 2023 at 09:19, Laurent Vivier wrote:
>
> The following changes since commit 886fb67020e32ce6a2cf7049c6f017acf1f0d69a:
>
> Merge tag 'pull-target-arm-20230113' of
> https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-01-13
> 14:12:43 +)
>
> are available in the
On Tue, Jan 17, 2023 at 10:58 AM Dr. David Alan Gilbert
wrote:
>
> * Eugenio Perez Martin (epere...@redhat.com) wrote:
> > On Fri, Jan 13, 2023 at 5:55 AM Jason Wang wrote:
> > >
> > > On Fri, Jan 13, 2023 at 1:25 AM Eugenio Pérez wrote:
> > > >
> > > > This allows net to restart the device back
On Mon, 16 Jan 2023 at 20:16, Richard Henderson
wrote:
>
> Ping.
What did you think of my suggestion in the other thread of hashing
the info we need to determine the cpreg set (ID regs, feature flags,
etc) and using that to look up whether we've already created a
cpreg hashtable for this config?
On 17/01/2023 11.23, Peter Maydell wrote:
On Mon, 16 Jan 2023 at 16:55, Peter Maydell wrote:
On Thu, 15 Dec 2022 at 15:30, Thomas Huth wrote:
We're still running into the problem that some logs are cut in the
gitlab-CI since they got too big. The biggest part of the log is
still the output
On Mon, 16 Jan 2023 13:00:53 -0500
Chuck Zmudzinski wrote:
> On 1/16/23 10:33, Igor Mammedov wrote:
> > On Fri, 13 Jan 2023 16:31:26 -0500
> > Chuck Zmudzinski wrote:
> >
> >> On 1/13/23 4:33 AM, Igor Mammedov wrote:
> >> > On Thu, 12 Jan 2023 23:14:26 -0500
> >> > Chuck Zmudzinski wrote:
Hi Markus, thanks for the review.
On Tue, 2023-01-17 at 11:08 +0100, Markus Armbrster wrote:
> David Woodhouse writes:
> > @@ -1059,3 +1063,137 @@ int xen_evtchn_send_op(struct evtchn_send *send)
> > return ret;
> > }
> >
> > +static const char *type_names[] = {
> > + "closed",
> > +
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Mon, Dec 26, 2022 at 05:33:25AM +, Het Gala wrote:
> > From: Author Het Gala
> >
> > Existing 'migrate' QAPI design enforces transport mechanism, ip address
> > of destination interface and corresponding port number in the form
> > of a u
On Tue, Jan 17, 2023 at 11:32:42AM +0100, Thomas Huth wrote:
> On 17/01/2023 11.23, Peter Maydell wrote:
> > On Mon, 16 Jan 2023 at 16:55, Peter Maydell
> > wrote:
> > >
> > > On Thu, 15 Dec 2022 at 15:30, Thomas Huth wrote:
> > > >
> > > > We're still running into the problem that some logs a
* Het Gala (het.g...@nutanix.com) wrote:
> From: Author Het Gala
>
> Existing 'migrate' QAPI design enforces transport mechanism, ip address
> of destination interface and corresponding port number in the form
> of a unified string 'uri' parameter. This scheme does seem to have an issue
> in it,
Hi,
On 12/26/22 06:33, Het Gala wrote:
> Current QAPI 'migrate' command design (for initiating a migration
> stream) contains information regarding different migrate transport mechanism
> (tcp / unix / exec), dest-host IP address, and binding port number in form of
> a string. Thus the design does
VHOST_BACKEND_F_IOTLB_ASID is the feature bit, not the bitmask. Since
the device under test also provided VHOST_BACKEND_F_IOTLB_MSG_V2 and
VHOST_BACKEND_F_IOTLB_BATCH, this went unnoticed.
Fixes: c1a1008685 ("vdpa: always start CVQ in SVQ mode if possible")
Signed-off-by: Eugenio Pérez
Acked-by:
On 1/17/23 11:00, Thomas Huth wrote:
On 16/01/2023 09.40, Thomas Huth wrote:
On 16/01/2023 09.29, Laurent Vivier wrote:
ping
On 1/5/23 10:37, Laurent Vivier wrote:
Signed-off-by: Laurent Vivier
Acked-by: Michael S. Tsirkin
---
Notes:
v5:
- disable test_stream_fd and test_dgram
On 17/01/2023 10:23, David Woodhouse wrote:
On Tue, 2023-01-17 at 10:00 +, Paul Durrant wrote:
@@ -712,6 +717,11 @@ static int kvm_xen_soft_reset(void)
CPUState *cpu;
int err;
+ err = xen_evtchn_set_callback_param(0);
Doesn't this always result in -ENOSYS?
Hm?
On Tue, 2023-01-17 at 10:56 +, Paul Durrant wrote:
>
> I'm just having a hard time seeing why passing 0 to
> xen_evtchn_set_callback_param() does anything useful...
>
> + switch (param >> CALLBACK_VIA_TYPE_SHIFT) {
> + case HVM_PARAM_CALLBACK_TYPE_VECTOR: {
> + struct kvm_xen_hv
On 1/17/23 11:00, Thomas Huth wrote:
On 16/01/2023 09.40, Thomas Huth wrote:
On 16/01/2023 09.29, Laurent Vivier wrote:
ping
On 1/5/23 10:37, Laurent Vivier wrote:
Signed-off-by: Laurent Vivier
Acked-by: Michael S. Tsirkin
---
Notes:
v5:
- disable test_stream_fd and test_dgram
On Mon, 16 Jan 2023 13:00:53 -0500
Chuck Zmudzinski wrote:
> On 1/16/23 10:33, Igor Mammedov wrote:
> > On Fri, 13 Jan 2023 16:31:26 -0500
> > Chuck Zmudzinski wrote:
> >
> >> On 1/13/23 4:33 AM, Igor Mammedov wrote:
> >> > On Thu, 12 Jan 2023 23:14:26 -0500
> >> > Chuck Zmudzinski wrote:
On 17/01/2023 11:02, David Woodhouse wrote:
On Tue, 2023-01-17 at 10:56 +, Paul Durrant wrote:
I'm just having a hard time seeing why passing 0 to
xen_evtchn_set_callback_param() does anything useful...
+ switch (param >> CALLBACK_VIA_TYPE_SHIFT) {
+ case HVM_PARAM_CALLBACK_TYPE_VECT
On 16/01/2023 21:57, David Woodhouse wrote:
From: David Woodhouse
The kvm_xen_inject_vcpu_callback_vector() function will either deliver
the per-vCPU local APIC vector (as an MSI), or just kick the vCPU out
of the kernel to trigger KVM's automatic delivery of the global vector.
Support for asse
On Tue, 17 Jan 2023 at 10:44, Daniel P. Berrangé wrote:
> Something random that looks like bad text data
>
> ▶ 166/619 /ptimer/oneshot
> policy=no_immediate_...snip�
I don't understand this one. The string comes from
On 17/01/2023 11.53, Laurent Vivier wrote:
On 1/17/23 11:00, Thomas Huth wrote:
On 16/01/2023 09.40, Thomas Huth wrote:
On 16/01/2023 09.29, Laurent Vivier wrote:
ping
On 1/5/23 10:37, Laurent Vivier wrote:
Signed-off-by: Laurent Vivier
Acked-by: Michael S. Tsirkin
---
Notes:
v5:
For virtio-mem, we want to have the plugged/unplugged state of memory
blocks available before migrating any actual RAM content, and perform
sanity checks before touching anything on the destination. This
information is immutable on the migration source while migration is active,
We want to use thi
Ordinary memory preallocation runs when QEMU starts up and creates the
memory backends, before processing the incoming migration stream. With
virtio-mem, we don't know which memory blocks to preallocate before
migration started. Now that we migrate the virtio-mem bitmap early, before
migrating any
Let's move more code into vmstate_save(), reducing code duplication and
preparing for reuse of vmstate_save() in qemu_savevm_state_setup(). We
have to move vmstate_save() to make the compiler happy.
We'll now also trace from qemu_save_device_state(), triggering the same
tracepoints as previously c
While playing with migration of virtio-mem with an ordinary file backing,
I realized that migration and prealloc doesn't currently work as expected
for virtio-mem. Further, Jing Qi reported that setup issues (insufficient
huge pages on the destination) result in QEMU getting killed with SIGBUS
inst
We'll make use of both next in the context of virtio-mem.
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: David Hildenbrand
---
include/migration/vmstate.h | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstat
The bitmap and the size are immutable while migration is active: see
virtio_mem_is_busy(). We can migrate this information early, before
migrating any actual RAM content. Further, all information we need for
sanity checks is immutable as well.
Having this information in place early will, for examp
... and store it in the migration state. This is a preparation for
storing selected vmds's already in qemu_savevm_state_setup().
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: David Hildenbrand
---
migration/migration.c | 2 ++
migration/migration.h | 4
migration/savevm.c| 18 ++
Let's factor out this check, to be used in virtio-mem context next.
While at it, fix a spelling error in a related comment.
Signed-off-by: David Hildenbrand
---
include/migration/misc.h | 4 +++-
migration/migration.c| 7 +++
migration/ram.c | 8 +---
3 files changed, 11 in
On 12.01.23 20:14, Kevin Wolf wrote:
This series addresses the problem described in these bug reports:
https://gitlab.com/qemu-project/qemu/-/issues/1330
https://bugzilla.redhat.com/show_bug.cgi?id=2147617
qcow2 can fail when writing back dirty bitmaps in qcow2_inactivate().
However, when the fu
"prealloc=on" for the memory backend does not work as expected, as
virtio-mem will simply discard all preallocated memory immediately again.
In the best case, it's an expensive NOP. In the worst case, it's an
unexpected allocation error.
Instead, "prealloc=on" should be specified for the virtio-me
On Tue, 2023-01-17 at 11:06 +, Paul Durrant wrote:
> On 17/01/2023 11:02, David Woodhouse wrote:
> > On Tue, 2023-01-17 at 10:56 +, Paul Durrant wrote:
> > >
> > > I'm just having a hard time seeing why passing 0 to
> > > xen_evtchn_set_callback_param() does anything useful...
> > >
> > >
Incremental patch, which I think addresses everything major? Would
still be nice to make the remote-domain field optional.
I *still* assume p->type is in the valid range, but at least if that's
wrong now it'll just put a bad value in the enum instead of crashing ;)
(In fact as I squash this I'll
On 17/1/23 12:03, Laurent Vivier wrote:
On 1/17/23 11:00, Thomas Huth wrote:
On 16/01/2023 09.40, Thomas Huth wrote:
On 16/01/2023 09.29, Laurent Vivier wrote:
ping
On 1/5/23 10:37, Laurent Vivier wrote:
Signed-off-by: Laurent Vivier
Acked-by: Michael S. Tsirkin
Acked-by: Thomas Huth
On Mon, 9 Jan 2023 at 23:18, ~dreiss-meta wrote:
>
> From: David Reiss
>
> BASEPRI, FAULTMASK, and their _NS equivalents only exist on devices with
> the Main Extension. However, the MRS instruction did not check this,
> and the MSR instruction handled it inconsistently (warning BASEPRI, but
> s
On 1/17/23 12:32, Philippe Mathieu-Daudé wrote:
On 17/1/23 12:03, Laurent Vivier wrote:
On 1/17/23 11:00, Thomas Huth wrote:
On 16/01/2023 09.40, Thomas Huth wrote:
On 16/01/2023 09.29, Laurent Vivier wrote:
ping
On 1/5/23 10:37, Laurent Vivier wrote:
Signed-off-by: Laurent Vivier
Acked-by
On 17/01/2023 11:24, David Woodhouse wrote:
On Tue, 2023-01-17 at 11:06 +, Paul Durrant wrote:
On 17/01/2023 11:02, David Woodhouse wrote:
On Tue, 2023-01-17 at 10:56 +, Paul Durrant wrote:
I'm just having a hard time seeing why passing 0 to
xen_evtchn_set_callback_param() does anythi
Before using any flatview, sanity check we're not during a memory
region transaction or the map can be invalid.
Signed-off-by: Chuang Xu
---
include/exec/memory.h | 15 +++
softmmu/memory.c | 5 +
2 files changed, 20 insertions(+)
diff --git a/include/exec/memory.h b/inclu
add rcu_read_is_locked() to detect holding of rcu lock.
Signed-off-by: Chuang Xu
---
include/qemu/rcu.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/qemu/rcu.h b/include/qemu/rcu.h
index b063c6fde8..719916d9d3 100644
--- a/include/qemu/rcu.h
+++ b/include/qemu/rcu.h
@@ -119
The duration of loading non-iterable vmstate accounts for a significant
portion of downtime (starting with the timestamp of source qemu stop and
ending with the timestamp of target qemu start). Most of the time is spent
committing memory region changes repeatedly.
This patch packs all the changes
In this version:
- rename rcu_read_locked() to rcu_read_is_locked().
- adjust the sanity check in address_space_to_flatview().
- improve some comments.
The duration of loading non-iterable vmstate accounts for a significant
portion of downtime (starting with the timestamp of source qemu stop and
On 16/01/2023 21:57, David Woodhouse wrote:
From: David Woodhouse
The kvm_xen_inject_vcpu_callback_vector() function will either deliver
the per-vCPU local APIC vector (as an MSI), or just kick the vCPU out
of the kernel to trigger KVM's automatic delivery of the global vector.
Support for asse
On Tue, Jan 17, 2023 at 11:16:32AM +, Peter Maydell wrote:
> On Tue, 17 Jan 2023 at 10:44, Daniel P. Berrangé wrote:
> > Something random that looks like bad text data
> >
> > ▶ 166/619 /ptimer/oneshot
> > policy=no_immediate_...
On Tue, Jan 17, 2023 at 12:22:35PM +, Peter Maydell wrote:
> On Tue, 17 Jan 2023 at 12:02, Daniel P. Berrangé wrote:
> >
> > On Tue, Jan 17, 2023 at 11:16:32AM +, Peter Maydell wrote:
> > > On Tue, 17 Jan 2023 at 10:44, Daniel P. Berrangé
> > > wrote:
> > > > Something random that looks
Hi Philippe,
Commit 145e2198d749 ("hw/mips/gt64xxx_pci: Endian-swap using
PCI_HOST_BRIDGE MemoryRegionOps") broke my mips64 nvme boot test
(little-endian host, mips64 and nvme boot device).
The pci device doesn't show up and the kernel panics.
qemu-system-mips64 \
-nodefaults -nographic -s
On Tue, 2023-01-17 at 11:11 +, Paul Durrant wrote:
>
> Ick. Do we really want cross-block gotos? For me it would look a lot
> nicer if you did a forward jump here and later and put the label+code
> after the `return 0`.
How's this?
static int set_vcpu_info(CPUState *cs, uint64_t gpa)
{
Install abort handlers that close the TPM control and data channels in
case an abort occurs. The purpose of this is to have QEMU terminate
under abnormal test case failures to resolve intermittent hangs on s390x
hosts running TPM tests for QEMU/x86_64.
Signed-off-by: Stefan Berger
Reviewed-by: Da
On Tue, 17 Jan 2023 13:12:57 +0100
Greg Kurz wrote:
> Hi Maxime,
>
> On Tue, 17 Jan 2023 10:49:37 +0100
> Maxime Coquelin wrote:
>
> > Hi Yajun,
> >
> > On 1/16/23 08:14, Yajun Wu wrote:
> > > Not quite sure about the whole picture.
> > >
> > > Seems while qemu waiting response of vhost_user
Hi Maxime,
On Tue, 17 Jan 2023 10:49:37 +0100
Maxime Coquelin wrote:
> Hi Yajun,
>
> On 1/16/23 08:14, Yajun Wu wrote:
> > Not quite sure about the whole picture.
> >
> > Seems while qemu waiting response of vhost_user_get_status, dpdk send out
> > VHOST_USER_SLAVE_IOTLB_MSG and trigger qemu
On Mon, Jan 16, 2023 at 07:15:08PM +0100, Laurent Vivier wrote:
> Hi Gerd,
>
> If this patch is correct I can queue it via trivial branch.
proxying tcp websocket connections to a unix socket looks like
a reasonable use case to me.
Acked-by: Gerd Hoffmann
On Tue, 2023-01-17 at 11:53 +, Paul Durrant wrote:
> On 17/01/2023 11:24, David Woodhouse wrote:
> > On Tue, 2023-01-17 at 11:06 +, Paul Durrant wrote:
> > > On 17/01/2023 11:02, David Woodhouse wrote:
> > > > On Tue, 2023-01-17 at 10:56 +, Paul Durrant wrote:
> > > > >
> > > > > I'm j
Hello,
this PR addresses issues where QEMU may hang during test runs.
Regards,
Stefan
The following changes since commit fb7e7990342e59cf67dbd895c1a1e3fb1741df7a:
tests/qtest/qom-test: Do not print tested properties by default (2023-01-16
15:00:57 +)
are available in the Git reposit
To prevent getting stuck on waitpid() in case the target process does
not terminate on SIGTERM, poll on waitpid() for 30s and if the target
process has not changed state until then send a SIGKILL to it.
Signed-off-by: Stefan Berger
Reviewed-by: Daniel P. Berrangé
Message-id: 20230112143413.39790
On Tue, 17 Jan 2023 at 12:02, Daniel P. Berrangé wrote:
>
> On Tue, Jan 17, 2023 at 11:16:32AM +, Peter Maydell wrote:
> > On Tue, 17 Jan 2023 at 10:44, Daniel P. Berrangé
> > wrote:
> > > Something random that looks like bad text data
> > >
> > > ▶ 166/619 /ptimer/oneshot
> > > policy=no_i
On Fri, Jan 13, 2023 at 09:54:41PM +, Sean Christopherson wrote:
> On Fri, Dec 02, 2022, Chao Peng wrote:
> > The system call is currently wired up for x86 arch.
>
> Building on other architectures (except for arm64 for some reason) yields:
>
> CALL/.../scripts/checksyscalls.sh
> :156
On Fri, Jan 13, 2023 at 10:37:39PM +, Sean Christopherson wrote:
> On Tue, Jan 10, 2023, Chao Peng wrote:
> > On Mon, Jan 09, 2023 at 07:32:05PM +, Sean Christopherson wrote:
> > > On Fri, Jan 06, 2023, Chao Peng wrote:
> > > > On Thu, Jan 05, 2023 at 11:23:01AM +, Jarkko Sakkinen wrote
On Tue, Jan 17, 2023 at 01:43:12PM +0100, Gerd Hoffmann wrote:
> On Mon, Jan 16, 2023 at 07:15:08PM +0100, Laurent Vivier wrote:
> > Hi Gerd,
> >
> > If this patch is correct I can queue it via trivial branch.
>
> proxying tcp websocket connections to a unix socket looks like
> a reasonable use c
* Eugenio Perez Martin (epere...@redhat.com) wrote:
> On Tue, Jan 17, 2023 at 10:58 AM Dr. David Alan Gilbert
> wrote:
> >
> > * Eugenio Perez Martin (epere...@redhat.com) wrote:
> > > On Fri, Jan 13, 2023 at 5:55 AM Jason Wang wrote:
> > > >
> > > > On Fri, Jan 13, 2023 at 1:25 AM Eugenio Pérez
Le 17/01/2023 à 13:53, Daniel P. Berrangé a écrit :
On Tue, Jan 17, 2023 at 01:43:12PM +0100, Gerd Hoffmann wrote:
On Mon, Jan 16, 2023 at 07:15:08PM +0100, Laurent Vivier wrote:
Hi Gerd,
If this patch is correct I can queue it via trivial branch.
proxying tcp websocket connections to a unix
> Please don't queue, this patch is not correct becasue it is failing
> to validate the 'websocket' parameter at all.
>
>
Hi,
Thanks for the review! I'm happy to adapt the patch to add validation,
though I am not quite sure what additional validation you would like to
see occur here.
Cheers,
Pier
From: David Woodhouse
Include basic support for setting HVM_PARAM_CALLBACK_IRQ to the global
vector method HVM_PARAM_CALLBACK_TYPE_VECTOR, which is handled in-kernel
by raising the vector whenever the vCPU's vcpu_info->evtchn_upcall_pending
flag is set.
Signed-off-by: David Woodhouse
---
hw/i3
1 - 100 of 397 matches
Mail list logo
