Re: [PATCH v10 3/9] KVM: Extend the memslot to support fd-based private memory

2022-12-19 Thread Chao Peng
On Tue, Dec 13, 2022 at 08:04:14PM +0800, Xiaoyao Li wrote: > On 12/8/2022 7:30 PM, Chao Peng wrote: > > On Thu, Dec 08, 2022 at 04:37:03PM +0800, Xiaoyao Li wrote: > > > On 12/2/2022 2:13 PM, Chao Peng wrote: > > > > > > .. > > > > > > > Together with the change, a new config HAVE_KVM_RESTRICTED

[PATCH v14 7/8] block: add some trace events for new block layer APIs

2022-12-19 Thread Sam Li
Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi --- block/file-posix.c | 3 +++ block/trace-events | 2 ++ 2 files changed, 5 insertions(+) diff --git a/block/file-posix.c b/block/file-posix.c index 091a95c1a9..517400a63b 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -3274,6 +3

[PATCH v14 6/8] qemu-iotests: test new zone operations

2022-12-19 Thread Sam Li
We have added new block layer APIs of zoned block devices. Test it as follows: Run each zone operation on a newly created null_blk device and see whether the logs show the correct zone information. By: $ ./tests/qemu-iotests/tests/zoned.sh Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi ---

[PATCH v14 8/8] docs/zoned-storage: add zoned device documentation

2022-12-19 Thread Sam Li
Add the documentation about the zoned device support to virtio-blk emulation. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi Reviewed-by: Damien Le Moal Reviewed-by: Dmitry Fomichev --- docs/devel/zoned-storage.rst | 43 ++ docs/system/qemu-block-drivers.

[RFC v5 1/3] include: update virtio_blk headers

2022-12-19 Thread Sam Li
Use scripts/update-linux-headers.sh to update virtio-blk headers from Dmitry's "virtio-blk:add support for zoned block devices" Linux patches. Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi Reviewed-by: Dmitry Fomichev --- include/standard-headers/linux/virtio_blk.h | 158 +

[RFC v5 2/3] virtio-blk: add zoned storage emulation for zoned devices

2022-12-19 Thread Sam Li
This patch extends virtio-blk emulation to handle zoned device commands by calling the new block layer APIs to perform zoned device I/O on behalf of the guest. It supports Report Zone, four zone oparations (open, close, finish, reset), and Append Zone. The VIRTIO_BLK_F_ZONED feature bit will only

[RFC v5 0/3] Add zoned storage emulation to virtio-blk driver

2022-12-19 Thread Sam Li
Note: the virtio-blk headers isn't upstream in the kernel yet therefore marked as an RFC. More information can be found here: https://patchwork.kernel.org/project/linux-block/cover/20221030043545.974223-1-dmitry.fomic...@wdc.com/ v5: - address Stefan's review comments * restore the way writing z

[RFC v5 3/3] virtio-blk: add some trace events for zoned emulation

2022-12-19 Thread Sam Li
Signed-off-by: Sam Li Reviewed-by: Stefan Hajnoczi --- hw/block/trace-events | 7 +++ hw/block/virtio-blk.c | 12 2 files changed, 19 insertions(+) diff --git a/hw/block/trace-events b/hw/block/trace-events index 2c45a62bd5..34be8b9135 100644 --- a/hw/block/trace-events +++ b/

Re: [PATCH v10 2/9] KVM: Introduce per-page memory attributes

2022-12-19 Thread Chao Peng
On Fri, Dec 16, 2022 at 04:09:06PM +0100, Borislav Petkov wrote: > On Fri, Dec 02, 2022 at 02:13:40PM +0800, Chao Peng wrote: > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > > index 1782c4555d94..7f0f5e9f2406 100644 > > --- a/virt/kvm/kvm_main.c > > +++ b/virt/kvm/kvm_main.c > > @@ -11

Re: [PATCH 1/5] target/arm: only build psci for TCG

2022-12-19 Thread Claudio Fontana
On 12/16/22 22:59, Alexander Graf wrote: > Hi Claudio, > > If the PSCI implementation becomes TCG only, can we also move to a tcg accel > directory? It slowly gets super confusing to keep track of which files are > supposed to be generic target code and which ones TCG specific> > Alex Hi Al

Re: [PATCH v2 2/2] hw/arm/smmu-common: Avoid using inlined functions with external linkage

2022-12-19 Thread Eric Auger
On 12/16/22 22:49, Philippe Mathieu-Daudé wrote: > When using Clang ("Apple clang version 14.0.0 (clang-1400.0.29.202)") > and building with -Wall we get: > > hw/arm/smmu-common.c:173:33: warning: static function > 'smmu_hash_remove_by_asid_iova' is used in an inline function with external >

Re: [PATCH v2 1/2] hw/arm/smmu-common: Reduce smmu_inv_notifiers_mr() scope

2022-12-19 Thread Eric Auger
Hi On 12/16/22 22:49, Philippe Mathieu-Daudé wrote: > This function is not used anywhere outside this file, > so we can make the function "static void". > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Auger Thanks Eric > --- > hw/arm/smmu-common.c | 2 +- > include/hw/arm/

Re: [PATCH v10 1/9] mm: Introduce memfd_restricted system call to create restricted user memory

2022-12-19 Thread Huang, Kai
On Mon, 2022-12-19 at 15:53 +0800, Chao Peng wrote: > > > > [...] > > > > > + > > > + /* > > > + * These pages are currently unmovable so don't place them into > > > movable > > > + * pageblocks (e.g. CMA and ZONE_MOVABLE). > > > + */ > > > + mapping = memfd->f_mapping; > > > + mapping_set_une

Re: [PATCH] virtio-mem: Fix the bitmap index of the section offset

2022-12-19 Thread David Hildenbrand
On 19.12.22 02:21, Chenyi Qiang wrote: On 12/16/2022 6:30 PM, David Hildenbrand wrote: On 16.12.22 09:52, David Hildenbrand wrote: On 16.12.22 07:22, Chenyi Qiang wrote: vmem->bitmap indexes the memory region of the virtio-mem backend at a granularity of block_size. To calculate the index of

RE: [PATCH] target/i386/hax: Add XCR0 support

2022-12-19 Thread Wang, Wenchao
Hi, Philippe, As Paolo did not comment with this patch, as you used to think it looks correct, could you help to merge this one-line patch as no one picked it up so far? Thanks a lot. Best Regards, Wenchao -Original Message- From: Wang, Wenchao Sent: Monday, December 5, 2022 17:10 To

[RFC 0/2] Add full zoned storage emulation support

2022-12-19 Thread Sam Li
This patch series serve as a supplement to previous zoned emulation support. It introduces a new format driver - zoned driver to enable full emulation of a block device file for a zoned block device on the host. Each zone of a zoned device makes state transitions following the zone state machine.

[RFC 1/2] block: add configs for the zoned format driver

2022-12-19 Thread Sam Li
To configure a zoned format driver, it has following arguments: device size, zoned model, zone size, number of conventional zones, number of sequential zones, max append sectors, max open zones, and max_active_zones. Signed-off-by: Sam Li --- block/meson.build| 1 + include/bloc

Re: [PATCH] target/i386/hax: Add XCR0 support

2022-12-19 Thread Philippe Mathieu-Daudé
Hi Wenchao, On 19/12/22 10:01, Wang, Wenchao wrote: Hi, Philippe, As Paolo did not comment with this patch, as you used to think it looks correct, could you help to merge this one-line patch as no one picked it up so far? Thanks a lot. I'm pretty sure Paolo is busy with KVM stuff and will t

[RFC 2/2] block: introduce the zoned format driver

2022-12-19 Thread Sam Li
The zoned format driver enables full emulation support of zoned device using a regular file. For example, commands for creating and reporting zones such a device are: $ ./build/qemu-img create -f zoned test.zoned -o size=896M -o zoned=1 -o zone_size=131072 -o zone_nr_conv=0 -o zone_nr_seq=12 -o ma

[PATCH] chardev: clean up chardev-parallel.c

2022-12-19 Thread Paolo Bonzini
Replace HAVE_CHARDEV_PARPORT with a Meson conditional, remove unnecessary defines, and close the file descriptor on FreeBSD/DragonFly. Signed-off-by: Paolo Bonzini --- chardev/char-parallel.c | 15 ++- chardev/meson.build | 5 - include/qemu/osdep.h| 5 - 3 files ch

RE: [PATCH] target/i386/hax: Add XCR0 support

2022-12-19 Thread Wang, Wenchao
Thanks for Philippe's reply and help. Best Regards, Wenchao -Original Message- From: Philippe Mathieu-Daudé Sent: Monday, December 19, 2022 17:10 To: Wang, Wenchao ; qemu-devel@nongnu.org Cc: Paolo Bonzini Subject: Re: [PATCH] target/i386/hax: Add XCR0 support Hi Wenchao, On 19/12/2

Re: [PATCH 01/32] hw/mips/malta: Introduce PIIX4_PCI_DEVFN definition

2022-12-19 Thread Igor Mammedov
On Sun, 4 Dec 2022 20:05:22 +0100 Bernhard Beschow wrote: > From: Philippe Mathieu-Daudé > > The PIIX4 PCI-ISA bridge function is always located at 10:0. > Since we want to re-use its address, add the PIIX4_PCI_DEVFN > definition. > > Signed-off-by: Philippe Mathieu-Daudé > Message-Id: <2022

Re: [PATCH] target/i386: Add SGX aex-notify and EDECCSSA support

2022-12-19 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH] chardev: clean up chardev-parallel.c

2022-12-19 Thread Philippe Mathieu-Daudé
On 19/12/22 10:17, Paolo Bonzini wrote: Replace HAVE_CHARDEV_PARPORT with a Meson conditional, remove unnecessary defines, and close the file descriptor on FreeBSD/DragonFly. Signed-off-by: Paolo Bonzini --- chardev/char-parallel.c | 15 ++- chardev/meson.build | 5 - i

Re: [PATCH 1/2] hw/arm/stm32f405: correctly describe the memory layout

2022-12-19 Thread Alistair Francis
On Mon, Dec 19, 2022 at 1:24 AM Felipe Balbi wrote: > > STM32F405 has 128K of SRAM and another 64K of CCM (Core-coupled > Memory) at a different base address. Correctly describe the memory > layout to give existing FW images have a chance to run unmodified. > > Signed-off-by: Felipe Balbi Review

Re: [PATCH 1/2] hw/arm/stm32f405: correctly describe the memory layout

2022-12-19 Thread Philippe Mathieu-Daudé
Hi Felipe, On 18/12/22 08:12, Felipe Balbi wrote: STM32F405 has 128K of SRAM and another 64K of CCM (Core-coupled Memory) at a different base address. Correctly describe the memory layout to give existing FW images have a chance to run unmodified. Signed-off-by: Felipe Balbi --- hw/arm/stm32

Re: [PATCH v2] hostmem: Honor multiple preferred nodes if possible

2022-12-19 Thread David Hildenbrand
On 16.12.22 14:47, Michal Prívozník wrote: On 12/16/22 14:41, David Hildenbrand wrote: On 15.12.22 10:55, Michal Privoznik wrote: If a memory-backend is configured with mode HOST_MEM_POLICY_PREFERRED then host_memory_backend_memory_complete() calls mbind() as:    mbind(..., MPOL_PREFERRED, no

Re: [PATCH v2] hostmem: Honor multiple preferred nodes if possible

2022-12-19 Thread Michal Prívozník
On 12/19/22 10:55, David Hildenbrand wrote: > On 16.12.22 14:47, Michal Prívozník wrote: >> On 12/16/22 14:41, David Hildenbrand wrote: >>> On 15.12.22 10:55, Michal Privoznik wrote: If a memory-backend is configured with mode HOST_MEM_POLICY_PREFERRED then host_memory_backend_memory

Re: [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver

2022-12-19 Thread Yuval Shaia
Can anyone else pick this one? Thanks, Yuval On Wed, 7 Dec 2022 at 17:05, Claudio Fontana wrote: > On 4/5/22 12:31, Marcel Apfelbaum wrote: > > Hi Yuval, > > Thank you for the changes. > > > > On Sun, Apr 3, 2022 at 11:54 AM Yuval Shaia > wrote: > >> > >> Guest driver might execute HW commands

Re: [PATCH v2] hostmem: Honor multiple preferred nodes if possible

2022-12-19 Thread David Hildenbrand
On 19.12.22 10:57, Michal Prívozník wrote: On 12/19/22 10:55, David Hildenbrand wrote: On 16.12.22 14:47, Michal Prívozník wrote: On 12/16/22 14:41, David Hildenbrand wrote: On 15.12.22 10:55, Michal Privoznik wrote: If a memory-backend is configured with mode HOST_MEM_POLICY_PREFERRED then h

Re: [PATCH 2/2] hw/arm: Add Olimex H405

2022-12-19 Thread Philippe Mathieu-Daudé
On 18/12/22 08:12, Felipe Balbi wrote: Olimex makes a series of low-cost STM32 boards. This commit introduces the minimum setup to support SMT32-H405. See [1] for details [1] https://www.olimex.com/Products/ARM/ST/STM32-H405/ Signed-off-by: Felipe Balbi --- MAINTAINERS

Re: [RFC PATCH 3/6] hw/cxl/cxl-events: Add CXL mock events

2022-12-19 Thread Jonathan Cameron via
On Mon, 10 Oct 2022 15:29:41 -0700 ira.we...@intel.com wrote: > From: Ira Weiny > > To facilitate testing of guest software add mock events and code to > support iterating through the event logs. > > Signed-off-by: Ira Weiny An FYI for the next version as I hit an issue with this when testing

Re: [PATCH v10 2/9] KVM: Introduce per-page memory attributes

2022-12-19 Thread Borislav Petkov
On Mon, Dec 19, 2022 at 04:15:32PM +0800, Chao Peng wrote: > Tamping down with error number a bit: > > if (attrs->flags) > return -ENXIO; > if (attrs->attributes & ~supported_attrs) > return -EOPNOTSUPP; > if (!PAGE_ALIGNED(attrs->address) ||

[PATCH v3 12/17] hw/9pfs: Add Linux error number definition

2022-12-19 Thread Bin Meng
From: Guohuai Shi When using 9p2000.L protocol, the errno should use the Linux errno. Currently magic numbers with comments are used. Replace these with macros for future expansion. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- (no changes since v1) hw/9pfs/9p-linux-errno.h | 151 +

[PATCH v3 02/17] hw/9pfs: Drop unnecessary *xattr wrapper API declarations

2022-12-19 Thread Bin Meng
These are not used anywhere in the source tree. Drop them. Signed-off-by: Bin Meng Reviewed-by: Greg Kurz --- (no changes since v1) hw/9pfs/9p-util.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/hw/9pfs/9p-util.h b/hw/9pfs/9p-util.h index c3526144c9..ccfc8b1cb3 100644 --- a

[PATCH v3 11/17] hw/9pfs: Update v9fs_set_fd_limit() for Windows

2022-12-19 Thread Bin Meng
From: Guohuai Shi Use _getmaxstdio() to set the fd limit on Windows. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- (no changes since v1) hw/9pfs/9p.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 2497a

[PATCH v3 07/17] hw/9pfs: Support getting current directory offset for Windows

2022-12-19 Thread Bin Meng
From: Guohuai Shi On Windows 'struct dirent' does not have current directory offset. Update qemu_dirent_off() to support Windows. While we are here, add a build time check to error out if a new host does not implement this helper. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- (no ch

[PATCH v3 00/17] hw/9pfs: Add 9pfs support for Windows

2022-12-19 Thread Bin Meng
At present there is no Windows support for 9p file system. This series adds initial Windows support for 9p file system. 'local' file system backend driver is supported on Windows, including open, read, write, close, rename, remove, etc. All security models are supported. The mapped (mapped-xattr)

[PATCH v3 17/17] meson.build: Turn on virtfs for Windows

2022-12-19 Thread Bin Meng
From: Guohuai Shi Enable virtfs configuration option for Windows host. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- (no changes since v1) meson.build | 10 +- fsdev/meson.build | 1 + hw/9pfs/meson.build | 8 +--- 3 files changed, 11 insertions(+), 8 delet

[PATCH v3 06/17] hw/9pfs: Update the local fs driver to support Windows

2022-12-19 Thread Bin Meng
From: Guohuai Shi Update the 9p 'local' file system driver to support Windows, including open, read, write, close, rename, remove, etc. All security models are supported. The mapped (mapped-xattr) security model is implemented using NTFS Alternate Data Stream (ADS) so the 9p export path shall be

[PATCH v3 08/17] hw/9pfs: update helper qemu_stat_rdev()

2022-12-19 Thread Bin Meng
As Windows host does not have stat->st_rdev field, we use the first 3 characters of the root path to build a device id. Co-developed-by: Guohuai Shi Signed-off-by: Bin Meng --- (no changes since v1) hw/9pfs/9p-util.h | 20 +--- hw/9pfs/9p-util-win32.c | 18 ++

[PATCH v3 01/17] qemu/xattr.h: Exclude for Windows

2022-12-19 Thread Bin Meng
Windows does not have . Signed-off-by: Bin Meng --- (no changes since v1) include/qemu/xattr.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/qemu/xattr.h b/include/qemu/xattr.h index f1d0f7be74..b08a934acc 100644 --- a/include/qemu/xattr.h +++ b/include/qemu/xa

[PATCH v3 16/17] tests/qtest: virtio-9p-test: Adapt the case for win32

2022-12-19 Thread Bin Meng
From: Guohuai Shi Windows does not provide the getuid() API. Let's create a local one and return a fixed value 0 as the uid for testing. Co-developed-by: Xuzhou Cheng Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng Reviewed-by: Thomas Huth --- (no changes since v1) tests/qtest/libqos/v

[PATCH v3 13/17] hw/9pfs: Translate Windows errno to Linux value

2022-12-19 Thread Bin Meng
From: Guohuai Shi Some of Windows error numbers have different value from Linux ones. For example, ENOTEMPTY is defined to 39 in Linux, but is defined to 41 in Windows. So deleting a directory from a Linux guest on top of QEMU from a Windows host complains: # rmdir tmp rmdir: 'tmp': Unknown

[PATCH v3 03/17] hw/9pfs: Replace the direct call to xxxat() APIs with a wrapper

2022-12-19 Thread Bin Meng
xxxat() APIs are only available on POSIX platforms. For future extension to Windows, let's replace the direct call to xxxat() APIs with a wrapper. Signed-off-by: Bin Meng --- (no changes since v1) hw/9pfs/9p-util.h | 15 +++ hw/9pfs/9p-local.c | 32

[PATCH v3 15/17] hw/9pfs: Update synth fs driver for Windows

2022-12-19 Thread Bin Meng
From: Guohuai Shi Adapt synth fs driver for Windows in preparation to running qtest 9p testing on Windows. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé --- (no changes since v1) hw/9pfs/9p-synth.c | 5 - 1 file changed, 4 insertions(+), 1 delet

[PATCH v3 09/17] hw/9pfs: Add a helper qemu_stat_blksize()

2022-12-19 Thread Bin Meng
As Windows host does not have stat->st_blksize field, we use the one we calculated in init_win32_root_directory(). Add a helper qemu_stat_blksize() and use it to avoid direct access to stat->st_blksize. Co-developed-by: Guohuai Shi Signed-off-by: Bin Meng --- hw/9pfs/9p-util.h | 12

Re: [PULL 00/21] Hexagon update: bug fixes, performance, idef-parser

2022-12-19 Thread Peter Maydell
On Fri, 16 Dec 2022 at 20:49, Taylor Simpson wrote: > > The following changes since commit 4208e6ae114ac8266dcacc9696a443ce5c37b04e: > > Merge tag 'pull-request-2022-12-15' of https://gitlab.com/thuth/qemu into > staging (2022-12-15 21:39:56 +) > > are available in the Git repository at: >

[PATCH v3 05/17] hw/9pfs: Implement Windows specific utilities functions for 9pfs

2022-12-19 Thread Bin Meng
From: Guohuai Shi Windows POSIX API and MinGW library do not provide the NO_FOLLOW flag, and do not allow opening a directory by POSIX open(). This causes all xxx_at() functions cannot work directly. However, we can provide Windows handle based functions to emulate xxx_at() functions (e.g.: opena

[PATCH v3 14/17] fsdev: Disable proxy fs driver on Windows

2022-12-19 Thread Bin Meng
From: Guohuai Shi We don't plan to support 'proxy' file system driver for 9pfs on Windows. Disable it for Windows build. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- (no changes since v1) fsdev/qemu-fsdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fsdev/qemu-fsdev.c b

[PATCH v3 10/17] hw/9pfs: Disable unsupported flags and features for Windows

2022-12-19 Thread Bin Meng
From: Guohuai Shi Some flags and features are not supported on Windows, like mknod, readlink, file mode, etc. Update the codes for Windows. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- (no changes since v1) hw/9pfs/9p.c | 45 ++--- 1 file ch

[PATCH v3 04/17] hw/9pfs: Add missing definitions for Windows

2022-12-19 Thread Bin Meng
From: Guohuai Shi Some definitions currently used by the 9pfs codes are only available on POSIX platforms. Let's add our own ones in preparation to adding 9pfs support for Windows. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- fsdev/file-op-9p.h | 33

Re: [PATCH 2/2] meson: Set avx512f option to auto

2022-12-19 Thread Daniel P . Berrangé
On Sat, Dec 17, 2022 at 12:08:08AM +0100, Paolo Bonzini wrote: > Because that's what configure used to do ( > https://lists.nongnu.org/archive/html/qemu-devel/2022-02/msg00650.html)... > > It can surely be changed but AVX512 is known to limit processor frequency. > I am not sure if the limitation

Re: [PULL v2 0/6] QEMU Guest Agent misc patches

2022-12-19 Thread Konstantin Kostiuk
On Sat, Dec 17, 2022 at 11:20 PM Peter Maydell wrote: > On Sat, 17 Dec 2022 at 09:07, Konstantin Kostiuk > wrote: > > > > The following changes since commit > d038d2645acabf6f52fd61baeaa021c3ebe97714: > > > > Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into > staging (2022-12-16

Re: [PATCH Trivial] hw/cxl/cxl-cdat.c: spelling: missmatch

2022-12-19 Thread Jonathan Cameron via
On Thu, 15 Dec 2022 13:59:01 +0100 Philippe Mathieu-Daudé wrote: > On 15/12/22 13:37, Michael Tokarev wrote: > > Introduced by: aba578bdace5303a441f8a37aad781b5cb06f38c > > > > Signed-off-by: Michael Tokarev > > --- > > hw/cxl/cxl-cdat.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 1/2] hw/arm/stm32f405: correctly describe the memory layout

2022-12-19 Thread Felipe Balbi
Hi, Philippe Mathieu-Daudé writes: > On 18/12/22 08:12, Felipe Balbi wrote: >> STM32F405 has 128K of SRAM and another 64K of CCM (Core-coupled >> Memory) at a different base address. Correctly describe the memory >> layout to give existing FW images have a chance to run unmodified. >> >> Signed

Re: [PATCH 2/2] hw/arm: Add Olimex H405

2022-12-19 Thread Felipe Balbi
Hi, Philippe Mathieu-Daudé writes: > On 18/12/22 08:12, Felipe Balbi wrote: >> Olimex makes a series of low-cost STM32 boards. This commit introduces >> the minimum setup to support SMT32-H405. See [1] for details >> >> [1] https://www.olimex.com/Products/ARM/ST/STM32-H405/ >> >> Signed-off-by

Re: [RFC PATCH-for-8.0 2/3] hw/ppc/spapr: Replace tswap64(HPTE) by cpu_to_be64(HPTE)

2022-12-19 Thread Peter Maydell
On Mon, 19 Dec 2022 at 06:35, David Gibson wrote: > > On Fri, Dec 16, 2022 at 09:39:19PM +, Peter Maydell wrote: > > On Fri, 16 Dec 2022 at 19:11, Daniel Henrique Barboza > > wrote: > > > > > > > > > > > > On 12/13/22 10:51, Peter Maydell wrote: > > > Yes, most if not all accesses are being h

Re: [PULL v2 0/6] QEMU Guest Agent misc patches

2022-12-19 Thread Peter Maydell
On Mon, 19 Dec 2022 at 10:34, Konstantin Kostiuk wrote: > > > > On Sat, Dec 17, 2022 at 11:20 PM Peter Maydell > wrote: >> >> On Sat, 17 Dec 2022 at 09:07, Konstantin Kostiuk wrote: >> > Andrey Drobyshev via (3): >> > qga-win: add logging to Windows event log >> > qga: map GLib log

Re: [PATCH 1/5] target/arm: only build psci for TCG

2022-12-19 Thread Alexander Graf
Hey Claudio, On 19.12.22 09:37, Claudio Fontana wrote: On 12/16/22 22:59, Alexander Graf wrote: Hi Claudio, If the PSCI implementation becomes TCG only, can we also move to a tcg accel directory? It slowly gets super confusing to keep track of which files are supposed to be generic target c

Re: [PATCH] virtio-mem: Fix the bitmap index of the section offset

2022-12-19 Thread Michael S. Tsirkin
On Fri, Dec 16, 2022 at 02:22:31PM +0800, Chenyi Qiang wrote: > vmem->bitmap indexes the memory region of the virtio-mem backend at a > granularity of block_size. To calculate the index of target section offset, > the block_size should be divided instead of the bitmap_size. > > Fixes: 2044969f0b (

Re: [PATCH 1/5] target/arm: only build psci for TCG

2022-12-19 Thread Claudio Fontana
Ciao Alex, On 12/19/22 11:47, Alexander Graf wrote: > Hey Claudio, > > On 19.12.22 09:37, Claudio Fontana wrote: >> >> On 12/16/22 22:59, Alexander Graf wrote: >>> Hi Claudio, >>> >>> If the PSCI implementation becomes TCG only, can we also move to a tcg >>> accel directory? It slowly gets super

Re: [PATCH] ebpf: fix compatibility with libbpf 1.0+

2022-12-19 Thread Daniel P . Berrangé
On Sun, Dec 18, 2022 at 08:09:27PM +0530, Shreesh Adiga wrote: > The current implementation fails to load on a system with > libbpf 1.0 and reports that legacy map definitions in 'maps' > section are not supported by libbpf v1.0+. This commit updates > the Makefile to add BTF (-g flag) and appropri

Re: [PATCH v2] hostmem: Honor multiple preferred nodes if possible

2022-12-19 Thread Michal Prívozník
On 12/19/22 10:58, David Hildenbrand wrote: > > I'll fixup. I just queued the fixed-up patch to > > https://github.com/davidhildenbrand/qemu.git mem-next > > Please double-check. Thanks! > Looks good. Sorry for not doing it properly the first time. Michal

Re: [PULL 00/21] Hexagon update: bug fixes, performance, idef-parser

2022-12-19 Thread Philippe Mathieu-Daudé
On 18/12/22 18:01, Peter Maydell wrote: On Sun, 18 Dec 2022 at 16:53, Richard Henderson wrote: On 12/18/22 05:52, Peter Maydell wrote: On Fri, 16 Dec 2022 at 20:49, Taylor Simpson wrote: The following changes since commit 4208e6ae114ac8266dcacc9696a443ce5c37b04e: Merge tag 'pull-reque

Re: [PATCH v3] hw/pvrdma: Protect against buggy or malicious guest driver

2022-12-19 Thread Marcel Apfelbaum
On Mon, Dec 19, 2022 at 10:57 AM Yuval Shaia wrote: > > Can anyone else pick this one? Adding Thomas, I dropped the ball with this one, I am sorry about that, maybe it doesn't worth a Pull Request only for it. Maybe it can go through the Misc tree? Thank you, Marcel > > Thanks, > Yuval > > O

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-19 Thread Helge Deller
Hi Paolo, On 12/17/22 14:28, Paolo Bonzini wrote: On 12/16/22 20:07, Helge Deller wrote: @@ -3581,7 +3581,7 @@ subdir('qga')   # Don't build qemu-keymap if xkbcommon is not explicitly enabled   # when we don't build tools or system -if xkbcommon.found() +if xkbcommon.found() and have_system   

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-19 Thread Peter Maydell
On Mon, 19 Dec 2022 at 11:22, Helge Deller wrote: > > Hi Paolo, > > On 12/17/22 14:28, Paolo Bonzini wrote: > > These are wrong. qemu-bridge-helper, virtiofsd, qemu-storage-daemon > > and qemu-keymap *are* tools; if they fail to build due to any > > dependencies, or due to other compilation issue

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-19 Thread Philippe Mathieu-Daudé
On 16/12/22 20:07, Helge Deller wrote: Reduce amount of compiled code and installed binaries if just the qemu utilities such as qemu-img, qemu-io and qemu-nbd have to be built. This helps to make those tools easier available on hosts where qemu-system or qemu-user isn't supported. Reason for th

[PATCH v5 0/3] Fix the virtio features negotiation flaw

2022-12-19 Thread huangy81
From: Hyman Huang(黄勇) v5: -fix the assert statement in [PATCH v4 3/3], reported by xiangdong. v4: -rebase on master -add stub function to fix build errors -code clean on [PATCH v2 1/2]: drop 'cleanup' parameter in vhost_user_save_acked_features. -code clean on [PATCH v2 2/2]: make refactor of

[PATCH v5 2/3] vhost-user: Refactor the chr_closed_bh

2022-12-19 Thread huangy81
From: Hyman Huang(黄勇) Use vhost_user_save_acked_features to implemente acked features saving. Signed-off-by: Hyman Huang(黄勇) Signed-off-by: Guoyi Tu --- net/vhost-user.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/vhost-user.c b/net/vhost-user.c index 40a2fe8.

[PATCH v5 1/3] vhost-user: Refactor vhost acked features saving

2022-12-19 Thread huangy81
From: Hyman Huang(黄勇) Abstract vhost acked features saving into vhost_user_save_acked_features, export it as util function. Signed-off-by: Hyman Huang(黄勇) Signed-off-by: Guoyi Tu --- include/net/vhost-user.h | 1 + net/vhost-user.c | 21 +++-- 2 files changed, 16 inse

[PATCH v5 3/3] vhost-user: Fix the virtio features negotiation flaw

2022-12-19 Thread huangy81
From: Hyman Huang(黄勇) This patch aims to fix unexpected negotiation features for vhost-user netdev interface. When openvswitch reconnect Qemu after an unexpected disconnection and Qemu therefore start the vhost_dev, acked_features field in vhost_dev is initialized with value fetched from acked_f

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-19 Thread Philippe Mathieu-Daudé
On 19/12/22 12:31, Peter Maydell wrote: On Mon, 19 Dec 2022 at 11:22, Helge Deller wrote: Hi Paolo, On 12/17/22 14:28, Paolo Bonzini wrote: These are wrong. qemu-bridge-helper, virtiofsd, qemu-storage-daemon and qemu-keymap *are* tools; if they fail to build due to any dependencies, or due

Re: [PATCH 1/5] target/arm: only build psci for TCG

2022-12-19 Thread Fabiano Rosas
Claudio Fontana writes: > Ciao Alex, > > On 12/19/22 11:47, Alexander Graf wrote: >> Hey Claudio, >> >> On 19.12.22 09:37, Claudio Fontana wrote: >>> >>> On 12/16/22 22:59, Alexander Graf wrote: Hi Claudio, If the PSCI implementation becomes TCG only, can we also move to a tcg >>

Re: [PATCH 3/5] target/arm: wrap semihosting and psci calls with tcg_enabled

2022-12-19 Thread Fabiano Rosas
Richard Henderson writes: > On 12/16/22 13:29, Fabiano Rosas wrote: >> -if (arm_is_psci_call(cpu, cs->exception_index)) { >> -arm_handle_psci_call(cpu); >> -qemu_log_mask(CPU_LOG_INT, "...handled as PSCI call\n"); >> -return; >> -} >> +if (tcg_enabled()) { >> +

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-19 Thread Peter Maydell
On Mon, 19 Dec 2022 at 11:40, Philippe Mathieu-Daudé wrote: > > On 19/12/22 12:31, Peter Maydell wrote: > > On Mon, 19 Dec 2022 at 11:22, Helge Deller wrote: > >> > >> Hi Paolo, > >> > >> On 12/17/22 14:28, Paolo Bonzini wrote: > >>> These are wrong. qemu-bridge-helper, virtiofsd, qemu-storage-d

Re: [PATCH] meson: Clean up some dependencies regarding qemu-system

2022-12-19 Thread Helge Deller
On 12/19/22 12:35, Philippe Mathieu-Daudé wrote: On 16/12/22 20:07, Helge Deller wrote: Reduce amount of compiled code and installed binaries if just the qemu utilities such as qemu-img, qemu-io and qemu-nbd have to be built.  This helps to make those tools easier available on hosts where qemu-s

Re: [PATCH 00/32] Consolidate PIIX south bridges

2022-12-19 Thread Bernhard Beschow
Am 18. Dezember 2022 14:17:48 UTC schrieb "Philippe Mathieu-Daudé" : >On 18/12/22 11:33, Bernhard Beschow wrote: >> >> >> Am 4. Dezember 2022 19:05:21 UTC schrieb Bernhard Beschow >> : >>> This series consolidates the implementations of the PIIX3 and PIIX4 south >>> >>> bridges and is an ex

[PATCH 03/11] contrib/gitdm: Add VRULL to the domain map

2022-12-19 Thread Alex Bennée
Philipp I assume I'm correct that the QEMU work should be shown as a corporate contribution? Signed-off-by: Alex Bennée Cc: Philipp Tomsich --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index da51c44ccb..7ff5

[PATCH 02/11] contrib/gitdm: Add Rivos Inc to the domain map

2022-12-19 Thread Alex Bennée
Whatever they are up to a number of people for the company are contributing to QEMU so lets group them together. Signed-off-by: Alex Bennée Cc: Atish Patra Cc: Dao Lu Cc: Andrew Bresticker Cc: Palmer Dabbelt Cc: Vineet Gupta --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+)

[PATCH 00/11] gitdm metadata updates

2022-12-19 Thread Alex Bennée
Hi, As Christmas approaches Santa has asked to make sure our lists are up to date so he can see who's been nice (there is no naughty when contributing to QEMU ;-). Thanks, Alex. Alex Bennée (11): contrib/gitdm: add C-Sky to the domain map contrib/gitdm: Add Rivos Inc to the domain map con

Re: [PATCH v2 3/3] hw/isa/piix4: Correct IRQRC[A:D] reset values

2022-12-19 Thread Bernhard Beschow
Am 27. Oktober 2022 20:47:20 UTC schrieb "Philippe Mathieu-Daudé" : >IRQRC[A:D] registers reset value is 0x80. We were forcing >the MIPS Malta machine routing to be able to boot a Linux >kernel without any bootloader. >We now have these registers initialized in the Malta machine >write_bootload

[PATCH 05/11] contrib/gitdm: Add Ventana Micro Systems to the domain map

2022-12-19 Thread Alex Bennée
We have a number of contributors from this domain which looks like it is a corporate endeavour. Signed-off-by: Alex Bennée Cc: Sunil V L Cc: Rahul Pathak Cc: Anup Patel --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/do

[PATCH 10/11] contrib/gitdm: add Idan to IBM's group map

2022-12-19 Thread Alex Bennée
According to LinkedIn Idan works at IBM. Please confirm if you want these contributions counted under IBM or as personal contributions. Signed-off-by: Alex Bennée Cc: Idan Horowitz --- contrib/gitdm/group-map-ibm | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/group-map-ibm b/

[PATCH 11/11] contrib/gitdm: Add SYRMIA to the domain map

2022-12-19 Thread Alex Bennée
The company website lists QEMU amongst the things they work on so I assume these are corporate contributions. Signed-off-by: Alex Bennée Cc: Milica Lazarevic --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map inde

[PATCH 08/11] contrib/gitdm: Add Facebook the domain map

2022-12-19 Thread Alex Bennée
A number of Facebook developers contribute to the project. Peter can you confirm your want pjd.dev contributions counted here or as an individual contributor? Signed-off-by: Alex Bennée Cc: Iris Chen Cc: Peter Delevoryas Cc: Peter Delevoryas Cc: Daniel Müller --- contrib/gitdm/domain-map

[PATCH 07/11] contrib/gitdm: Add ASPEED Technology to the domain map

2022-12-19 Thread Alex Bennée
We have a number of contributors from this domain which looks like it is a corporate endeavour. Signed-off-by: Alex Bennée Cc: Steven Lee Cc: Troy Lee Cc: Howard Chiu Cc: Jamin Lin --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/con

Re: [PATCH 02/14] block: Convert bdrv_io_plug() to co_wrapper

2022-12-19 Thread Emanuele Giuseppe Esposito
Am 16/12/2022 um 15:26 schrieb Vladimir Sementsov-Ogievskiy: > On 12/13/22 11:53, Kevin Wolf wrote: >> From: Emanuele Giuseppe Esposito >> >> BlockDriver->bdrv_io_plug is categorized as IO callback, and it >> currently doesn't run in a coroutine. We should let it take a graph >> rdlock since th

Re: [PATCH 02/14] block: Convert bdrv_io_plug() to co_wrapper

2022-12-19 Thread Emanuele Giuseppe Esposito
Am 16/12/2022 um 17:12 schrieb Vladimir Sementsov-Ogievskiy: > On 12/13/22 11:53, Kevin Wolf wrote: >> --- a/include/block/block_int-common.h >> +++ b/include/block/block_int-common.h >> @@ -729,7 +729,7 @@ struct BlockDriver { >>   void (*bdrv_debug_event)(BlockDriverState *bs, BlkdebugEven

[PATCH 01/11] contrib/gitdm: add C-Sky to the domain map

2022-12-19 Thread Alex Bennée
Although the majority of the recent work has been done by LIU Zhiwei it does appear to be a corporate effort. Signed-off-by: Alex Bennée Cc: Guo Ren Cc: Liu Zhiwei --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-m

Re: [PATCH 2/2] tpm: add backend for mssim

2022-12-19 Thread Stefan Berger
On 12/16/22 08:53, James Bottomley wrote: I could do a blog post, but I really don't think you want this in official documentation because that creates support expectations. We get support expectations if we don't mention it as not being supported. So, since this driver is not supported t

Re: [PATCH 06/14] block-backend: use bdrv_getlength instead of blk_getlength

2022-12-19 Thread Emanuele Giuseppe Esposito
Am 16/12/2022 um 18:22 schrieb Vladimir Sementsov-Ogievskiy: > On 12/13/22 11:53, Kevin Wolf wrote: >> From: Emanuele Giuseppe Esposito >> >> The only difference is that blk_ checks if the block is available, >> but this check is already performed above in blk_check_byte_request(). >> >> This i

[PATCH 04/11] contrib/gitdm: add a group map for SiFive

2022-12-19 Thread Alex Bennée
Some SiFive contributors use there personal emails. Add a group map for those developers. Please confirm. Signed-off-by: Alex Bennée Cc: eopXD --- contrib/gitdm/group-map-sifive | 5 + gitdm.config | 1 + 2 files changed, 6 insertions(+) create mode 100644 contrib/gitdm/g

Re: [RFC v4 3/3] hw/cxl: Multi-Region CXL Type-3 Devices (Volatile and Persistent)

2022-12-19 Thread Jonathan Cameron via
On Mon, 28 Nov 2022 10:01:57 -0500 Gregory Price wrote: > From: Gregory Price > > This commit enables each CXL Type-3 device to contain one volatile > memory region and one persistent region. > > Two new properties have been added to cxl-type3 device initialization: > [volatile-memdev] and

[PATCH 06/11] contrib/gitdm: add Tsukasa as an individual contributor

2022-12-19 Thread Alex Bennée
I wasn't sure if you want to be added as an individual contributor or an academic so please confirm. Signed-off-by: Alex Bennée Cc: Tsukasa OI --- contrib/gitdm/group-map-individuals | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/group-map-individuals b/contrib/gitdm/group-m

[PATCH 09/11] contrib/gitdm: add a group map for Google

2022-12-19 Thread Alex Bennée
Long standing community contributors often use their upstream email addresses when working on project. Signed-off-by: Alex Bennée Cc: Marc Zyngier --- contrib/gitdm/group-map-google | 5 + gitdm.config | 1 + 2 files changed, 6 insertions(+) create mode 100644 contrib/git

[PATCH] hw/arm/smmuv3: Add GBPA register

2022-12-19 Thread Mostafa Saleh
GBPA register can be used to globally abort all transactions. Only UPDATE and ABORT bits are considered in this patch. It is described in the SMMU manual in "6.3.14 SMMU_GBPA". ABORT reset value is IMPLEMENTATION DEFINED, it is chosen to be zero(Do not abort incoming transactions). Signed-off-by

[PATCH] hw/display: avoid creating empty loadable modules

2022-12-19 Thread Daniel P . Berrangé
When using --disable-virglrenderer, QEMU still creates hw-display-virtio-gpu-gl.so hw-display-virtio-vga-gl.so hw-display-virtio-gpu-pci-gl.so but when these are loaded, they provide no functionality as the code which registers types is not compiled in. Funtionally this is relatively harmle

Re: [PATCH-for-8.0 v2 3/6] hw/virtio: Guard and restrict scope of qmp_virtio_feature_map_t[]

2022-12-19 Thread Jonah Palmer
On 12/13/22 06:17, Philippe Mathieu-Daudé wrote: Commit f3034ad71f ("qmp: decode feature & status bits in virtio-status") did not guard all qmp_virtio_feature_map_t arrays with the corresponding #ifdef'ry used in qmp_decode_features(). Fix that and reduce the arrays scope by declaring them static

  1   2   3   >