Hi,
On 2022/11/22 7:37, Philippe Mathieu-Daudé wrote:
Cc'ing more UI/display contributors.
On 17/11/22 14:05, Peter Maydell wrote:
On Tue, 1 Nov 2022 at 14:17, Peter Maydell
wrote:
Hi; I'm trying to find out what the UI layer's threading and
locking strategy is, at least as far as it applie
The imsic DT binding[1] has changed and no longer require an ipi-id.
The latest IMSIC driver dynamically allocates ipi id if slow-ipi
is not defined.
Get rid of the unused dt property which may lead to confusion.
[1]
https://lore.kernel.org/lkml/2022044207.1478350-5-apa...@ventanamicro.com/
On Mon, Nov 21, 2022 at 10:11 PM Alistair Francis wrote:
>
> On Sun, Nov 13, 2022 at 7:52 PM Atish Patra wrote:
> >
> > The imsic DT binding[1] has changed and no longer require an ipi-id.
> > The latest IMSIC driver dynamically allocates ipi id if slow-ipi
> > is not defined.
> >
> > Get rid of
From: Klaus Jensen
If the zone reset operation is cancelled but the block unmap operation
completes normally, the callback will continue resetting the next zone
since it neglects to check iocb->ret which will have been set to
-ECANCELED. Make sure that this is checked and bail out if an error is
From: Klaus Jensen
Make sure that iocb->aiocb is NULL'ed when cancelling.
Fix a potential use-after-free by removing the bottom half and enqueuing
the completion directly.
Fixes: 38f4ac65ac88 ("hw/nvme: reimplement flush to allow cancellation")
Signed-off-by: Klaus Jensen
---
hw/nvme/ctrl.c |
From: Klaus Jensen
A new blktests nvme test unearthed some bad bugs in the asynchronous
cancellation handling.
Fix this for all commands that implement async_cancel(). The fix is the
same for all commands: remove the deferred enqueuing (a bottom half
scheduling) of the request completion.
Klaus
From: Klaus Jensen
Fix a potential use-after-free by removing the bottom half and enqueuing
the completion directly.
Fixes: 796d20681d9b ("hw/nvme: reimplement the copy command to allow aio
cancellation")
Signed-off-by: Klaus Jensen
---
hw/nvme/ctrl.c | 63 +++-
From: Klaus Jensen
When the DSM operation is cancelled asynchronously, we set iocb->ret to
-ECANCELED. However, the callback function only checks the return value
of the completed aio, which may have completed succesfully prior to the
cancellation and thus the callback ends up continuing the dsm
On Tue, Nov 22, 2022 at 10:45:59AM +0300, Michael Tokarev wrote:
> Historically, capstone varies in requiring either
> or include depending on version and the
> way how it has been installed. This has already been an issue
> before, and will likely become an issue again with capstone
> 5.0 which
From: Klaus Jensen
There are several bugs in the async cancel code for the Format command.
Firstly, cancelling a format operation neglects to set iocb->ret as well
as clearing the iocb->aiocb after cancelling the underlying aiocb which
causes the aio callback to ignore the cancellation. Trivial
Am 21.11.2022 um 22:19 hat Stefan Hajnoczi geschrieben:
> bdrv_*() APIs expect a valid BlockDriverState. Calling them with bs=NULL
> leads to undefined behavior.
>
> Jonathan Cameron reported this following NULL pointer dereference when a
> VM with a virtio-blk device and a memory-backend-file obj
Am 21.11.2022 um 16:52 hat Emanuele Giuseppe Esposito geschrieben:
> Am 21/11/2022 um 16:30 schrieb Kevin Wolf:
> > Am 16.11.2022 um 13:22 hat Emanuele Giuseppe Esposito geschrieben:
> >> Basically BdrvPollCo->bs is only used by bdrv_poll_co(), and the
> >> functions that it uses are both using bdr
Am 16.11.2022 um 13:22 hat Emanuele Giuseppe Esposito geschrieben:
> Call two different functions depending on whether bdrv_create
> is in coroutine or not, following the same pattern as
> generated_co_wrapper functions.
>
> This allows to also call the coroutine function directly,
> without using
On Nov 17 14:40, Cédric Le Goater wrote:
> On 11/17/22 12:58, Klaus Jensen wrote:
> > On Nov 17 09:01, Cédric Le Goater wrote:
> > > On 11/17/22 08:37, Klaus Jensen wrote:
> > > > On Nov 17 07:56, Cédric Le Goater wrote:
> > > > > On 11/17/22 07:40, Klaus Jensen wrote:
> > > > > > On Nov 16 16:58,
Am 16.11.2022 um 13:22 hat Emanuele Giuseppe Esposito geschrieben:
> It is always called in coroutine_fn callbacks, therefore
> it can directly call bdrv_co_create().
>
> Signed-off-by: Emanuele Giuseppe Esposito
> ---
> block.c| 6 --
> include/block/block-global
Thomas Huth writes:
> On 21/11/2022 17.32, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé writes:
>>
>>> On 21/11/22 15:36, Peter Maydell wrote:
On Mon, 21 Nov 2022 at 14:03, Markus Armbruster wrote:
>
> Tweak the semantic patch to drop redundant parenthesis around the
> r
On Sat, Nov 19, 2022 at 09:36:14AM +, manish.mishra wrote:
> MSG_PEEK reads from the peek of channel, The data is treated as
> unread and the next read shall still return this data. This
> support is currently added only for socket class. Extra parameter
> 'flags' is added to io_readv calls to
On Sat, Nov 19, 2022 at 09:36:15AM +, manish.mishra wrote:
> Current logic assumes that channel connections on the destination side are
> always established in the same order as the source and the first one will
> always be the main channel followed by the multifid or post-copy
> preemption cha
Am 22/11/2022 um 09:58 schrieb Kevin Wolf:
> Am 16.11.2022 um 13:22 hat Emanuele Giuseppe Esposito geschrieben:
>> It is always called in coroutine_fn callbacks, therefore
>> it can directly call bdrv_co_create().
>>
>> Signed-off-by: Emanuele Giuseppe Esposito
>> ---
>> block.c
On 11/21/22 15:13, Cédric Le Goater wrote:
+static char *s390_top_set_level2(S390Topology *topo, char *p)
+{
+ int i, origin;
+
+ for (i = 0; i < topo->nr_sockets; i++) {
+ if (!topo->socket[i].active_count) {
+ continue;
+ }
+ p = fill_container(p, 1, i);
On 22/11/22 2:30 pm, Daniel P. Berrangé wrote:
On Sat, Nov 19, 2022 at 09:36:14AM +, manish.mishra wrote:
MSG_PEEK reads from the peek of channel, The data is treated as
unread and the next read shall still return this data. This
support is currently added only for socket class. Extra para
Am 16.11.2022 um 13:22 hat Emanuele Giuseppe Esposito geschrieben:
> This function is never called in coroutine context, therefore
> instead of manually creating a new coroutine, delegate it to the
> block-coroutine-wrapper script, defining it as g_c_w_simple.
>
> Signed-off-by: Emanuele Giuseppe
On Mon, Nov 21, 2022 at 01:40:27PM +0100, Juan Quintela wrote:
> Het Gala wrote:
> > To prevent double data encoding of uris, instead of passing transport
> > mechanisms, host address and port all together in form of a single string
> > and writing different parsing functions, we intend the user t
On Mon, Nov 21, 2022 at 01:26:55PM +0100, Juan Quintela wrote:
> Markus Armbruster wrote:
> > Het Gala writes:
>
>
>
> Hi
>
> # Example:
> #
> -# -> { "execute": "migrate", "arguments": { "uri": "tcp:0:4446" } }
> +# -> { "execute": "migrate",
> +# "arguments
On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra wrote:
>
> On 22/11/22 2:30 pm, Daniel P. Berrangé wrote:
> > On Sat, Nov 19, 2022 at 09:36:14AM +, manish.mishra wrote:
> > > MSG_PEEK reads from the peek of channel, The data is treated as
> > > unread and the next read shall still retu
On 22/11/22 2:59 pm, Daniel P. Berrangé wrote:
On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra wrote:
On 22/11/22 2:30 pm, Daniel P. Berrangé wrote:
On Sat, Nov 19, 2022 at 09:36:14AM +, manish.mishra wrote:
MSG_PEEK reads from the peek of channel, The data is treated as
unread a
On 11/11/22 04:40, Richard Henderson wrote:
Replace the flat array tcg_target_call_oarg_regs[] with
a function call including the TCGCallReturnKind.
Signed-off-by: Richard Henderson
---
For ppc and common code bits:
Reviewed-by: Daniel Henrique Barboza
tcg/tcg.c
On Tue, Nov 22, 2022 at 11:01:11AM +0800, Jason Wang wrote:
> When vIOMMU is enabled, the vq->used_phys is actually the IOVA not
> GPA. So we need to translate it to GPA before the syncing otherwise we
> may hit the following crash since IOVA could be out of the scope of
> the GPA log size. This co
On 11/11/22 04:40, Richard Henderson wrote:
Implement the function for arm, i386, and s390x, which will use it.
Add stubs for all other backends.
Signed-off-by: Richard Henderson
---
For ppc and common code bits:
Reviewed-by: Daniel Henrique Barboza
tcg/tcg.c
Philippe Mathieu-Daudé writes:
> On 17/11/22 18:25, Alex Bennée wrote:
>> We don't currently have a clear place in the documentation to describe
>> the roles and responsibilities of a maintainer. Lets create one so we
>> can. I've moved a few small bits out of other files to try and keep
>> eve
On 11/11/22 04:40, Richard Henderson wrote:
Fill in the parameters for the host ABI for Int128 for
those backends which require no extra modification.
Signed-off-by: Richard Henderson
---
Reviewed-by: Daniel Henrique Barboza
tcg/aarch64/tcg-target.h | 2 ++
tcg/arm/tcg-target.h
On Tue, Nov 22, 2022 at 03:10:53PM +0530, manish.mishra wrote:
>
> On 22/11/22 2:59 pm, Daniel P. Berrangé wrote:
> > On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra wrote:
> > > On 22/11/22 2:30 pm, Daniel P. Berrangé wrote:
> > > > On Sat, Nov 19, 2022 at 09:36:14AM +, manish.mishra
On Fri, Nov 18, 2022 at 03:59:12PM +, Sean Christopherson wrote:
> On Fri, Nov 18, 2022, Alex Benn?e wrote:
> >
> > Chao Peng writes:
> >
> > > On Thu, Nov 17, 2022 at 03:08:17PM +, Alex Benn?e wrote:
> > >> >> I think this should be explicit rather than implied by the absence of
> > >>
We don't currently have a clear place in the documentation to describe
the roles and responsibilities of a maintainer. Lets create one so we
can. I've moved a few small bits out of other files to try and keep
everything in one place.
Signed-off-by: Alex Bennée
Reviewed-by: Stefan Hajnoczi
Review
The bullet points are quite long and contain process tips. Move those
bits of the bullet to the relevant sections and link to them. Use a
table for nicer formatting of the checklist.
Signed-off-by: Alex Bennée
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Paolo Bonzini
Reviewed-by: Philippe Mathieu
We welcome all sorts of patches.
Signed-off-by: Alex Bennée
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Paolo Bonzini
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20221117172532.538149-6-alex.ben...@linaro.org>
diff --git a/docs/devel/submitting-a-patch.rst
b/docs/devel/submitting-a-patch.
This should hopefully give is nice coverage information about what our
tests (or at least the subset we are running) have hit. Ideally we
would want a way to trigger coverage on tests likely to be affected by
the current commit.
Signed-off-by: Alex Bennée
Acked-by: Stefan Hajnoczi
Message-Id: <2
From: Stefan Weil
The docker probe uses "sudo -n" which can cause an e-mail with a security
warning
each time when configure is run. Therefore run docker probe only if either
docker
or podman are available.
That avoids the problematic "sudo -n" on build environments which have neither
docker n
The following changes since commit 6d71357a3b651ec9db126e4862b77e13165427f5:
rtl8139: honor large send MSS value (2022-11-21 09:28:43 -0500)
are available in the Git repository at:
https://gitlab.com/stsquad/qemu.git tags/pull-misc-for-7.2-221122-1
for you to fetch changes up to 5544d33d4b3
From: Peter Maydell
On my machine, a debug build of QEMU takes about 260 seconds to
complete this test, so with the current timeout value of 180 seconds
it always times out. Double the timeout value to 360 so the test
definitely has enough time to complete.
Signed-off-by: Peter Maydell
Signed-
From: Cédric Le Goater
The Aspeed SDK images are based on OpenBMC which starts a lot of
services. The output noise on the console can break from time to time
the test waiting for the logging prompt.
Change the U-Boot bootargs variable to add "quiet" to the kernel
command line and reduce the outp
It is important that contributors take the review process seriously
and we collaborate in a respectful way while avoiding personal
attacks. Try and make this clear in the language.
Signed-off-by: Alex Bennée
Reviewed-by: Markus Armbruster
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Paolo Bonzini
This is useful when trying to bisect a particular failing test behind
a docker run. For example:
make docker-test-clang@fedora \
TARGET_LIST=arm-softmmu \
TEST_COMMAND="meson test qtest-arm/qos-test" \
J=9 V=1
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Message-
The boot_linux tests download and run a full cloud image boot and
start a full distro. While the ability to test the full boot chain is
worthwhile it is perhaps a little too heavy weight and causes issues
in CI. Fix this by introducing a new alpine linux ISO boot in
machine_aarch64_virt.
This boot
We now have a much lighter weight test in machine_aarch64_virt which
tests the full boot chain in less time. Rename the tests while we are
at it to make it clear it is a Fedora cloud image.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20221117172532.538149-11-alex.
Am 16.11.2022 um 13:22 hat Emanuele Giuseppe Esposito geschrieben:
> bdrv_can_store_new_dirty_bitmap and bdrv_remove_persistent_dirty_bitmap
> check if they are running in a coroutine, directly calling the
> coroutine callback if it's the case.
> Except that no coroutine calls such functions, there
francesco.cag...@gmail.com writes:
> From: Francesco Cagnin
>
> These helpers will be also used for HVF. Aside from reformatting a
> couple of comments for 'checkpatch.pl' and updating meson to compile
> 'hyp_gdbstub.c', this is just code motion.
>
> Signed-off-by: Francesco Cagnin
Acked-by:
On 22/11/22 3:23 pm, Daniel P. Berrangé wrote:
On Tue, Nov 22, 2022 at 03:10:53PM +0530, manish.mishra wrote:
On 22/11/22 2:59 pm, Daniel P. Berrangé wrote:
On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra wrote:
On 22/11/22 2:30 pm, Daniel P. Berrangé wrote:
On Sat, Nov 19, 2022 at
The following changes since commit 2c8311241d1f7377bb4ff76064b1d1fe15166413:
Update VERSION for v7.2.0-rc1 (2022-11-15 18:56:38 -0500)
are available in the Git repository at:
https://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
for you to fetch changes up to b7c61789e65308
From: Ani Sinha
Adding Michael's name to the list of bios bits maintainers so that all changes
and fixes into biosbits framework can go through his tree and he is notified.
Suggested-by: Michael S. Tsirkin
Signed-off-by: Ani Sinha
Message-Id: <2022151138.36988-1-...@anisinha.ca>
Reviewed-b
From: Igor Mammedov
Commit 47a373faa6b2 (acpi: pc/q35: drop ad-hoc PCI-ISA bridge AML routines and
let bus ennumeration generate AML)
moved ISA bridge AML generation to respective devices and was using
aml_alias() to provide PRQx fields in _SB. scope. However, it turned
out that SeaBIOS was not
From: Ani Sinha
Debugging bits issue often involves running the QEMU command line manually
outside of the avocado environment with the generated ISO. Hence, its
inconvenient if the iso gets cleaned up after the test has finished. This change
makes sure that the work directory is kept after the te
From: Igor Mammedov
Expected DSDT changes,
pc:
-Field (P40C, ByteAcc, NoLock, Preserve)
+Scope (\_SB)
{
-PRQ0, 8,
-PRQ1, 8,
-PRQ2, 8,
-PRQ3, 8
+
From: Igor Mammedov
Signed-off-by: Igor Mammedov
Message-Id: <20221121153613.3972225-2-imamm...@redhat.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
tests/qtest/bios-tables-test-allowed-diff.h | 36 +
1 file changed, 36 insertions(+)
diff --gi
From: Stefano Garzarella
Commit 69e1c14aa2 ("virtio: core: vq reset feature negotation support")
enabled VIRTIO_F_RING_RESET by default for all virtio devices.
This feature is not currently emulated by QEMU, so for vhost and
vhost-user devices we need to make sure it is supported by the offloade
Virtio 1.0 is pretty clear that features have to be
negotiated before enabling VQs. Unfortunately Seabios
ignored this ever since gaining 1.0 support (UEFI is ok).
Comment the error out for now, and add a TODO.
Fixes: 3c37f8b8d1 ("virtio: introduce virtio_queue_enable()")
Cc: "Kangjie Xu"
Signed-
From: John Snow
Instead of using a hardcoded timeout, just rely on Avocado's built-in
test case timeout. This helps avoid timeout issues on machines where 60
seconds is not sufficient.
Signed-off-by: John Snow
Message-Id: <20221115212759.3095751-1-js...@redhat.com>
Reviewed-by: Michael S. Tsirk
On Tue, Nov 22, 2022 at 03:43:55PM +0530, manish.mishra wrote:
>
> On 22/11/22 3:23 pm, Daniel P. Berrangé wrote:
> > On Tue, Nov 22, 2022 at 03:10:53PM +0530, manish.mishra wrote:
> > > On 22/11/22 2:59 pm, Daniel P. Berrangé wrote:
> > > > On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra
在 2022/11/15 19:49, Xiaojuan Yang 写道:
Add "chosen" subnode into LoongArch fdt, and set it's
"stdout-path" prop to uart node.
Signed-off-by: Xiaojuan Yang
---
hw/loongarch/virt.c | 2 ++
1 file changed, 2 insertions(+)
Reviewed-by: Song Gao
Thanks.
Song Gao
diff --git a/hw/loongarch/vir
在 2022/11/15 19:50, Xiaojuan Yang 写道:
Using macro to replace the value of uart info such as addr, size
in acpi_build method.
Signed-off-by: Xiaojuan Yang
---
hw/loongarch/acpi-build.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Song Gao
Thanks.
Song Gao
diff -
在 2022/11/16 12:03, Xiaojuan Yang 写道:
Fix setprop_sized method in fdt rtc node.
Signed-off-by: Xiaojuan Yang
---
hw/loongarch/virt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Song Gao
Thanks.
Song Gao
diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c
inde
Version of patch that uses sh script to parse MAKEFLAGS and set
--nrunner-max-parallel-tasks accordingly. As already mentioned, works with Make
4.2 or newer, otherwise only single thread or all cores can be used.
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 9422ddaece..ee05
On 11/11/22 08:40, Richard Henderson wrote:
Allocate the first of a pair at the lower address, and the
second of a pair at the higher address. This will make it
easier to find the beginning of the larger memory block.
Signed-off-by: Richard Henderson
---
tcg/tcg-internal.h | 4 ++--
tcg/tc
On 11/11/22 08:40, Richard Henderson wrote:
Add a helper function for computing the size of a type.
Signed-off-by: Richard Henderson
---
include/tcg/tcg.h | 16
tcg/tcg.c | 26 --
2 files changed, 28 insertions(+), 14 deletions(-)
diff --git
On 11/11/22 08:40, Richard Henderson wrote:
Prepare to replace a bunch of separate ifdefs with a
consistent way to describe the abi of a function call.
Nitpicking, s/abi/ABI/ like in patch 40 "Fill in the parameters for the
host ABI for Int128".
Signed-off-by: Richard Henderson
---
tcg/
On Tue, 22 Nov 2022 at 08:04, Akihiko Odaki wrote:
>
> Hi,
>
> On 2022/11/22 7:37, Philippe Mathieu-Daudé wrote:
> > Cc'ing more UI/display contributors.
> >
> > On 17/11/22 14:05, Peter Maydell wrote:
> >> On Tue, 1 Nov 2022 at 14:17, Peter Maydell
> >> wrote:
> >>>
> >>> Hi; I'm trying to find
Hello,
On Mon, 21 Nov 2022, Bernhard Beschow wrote:
Am 21. November 2022 22:43:50 UTC schrieb "Philippe Mathieu-Daudé"
:
On 21/11/22 16:34, Bernhard Beschow wrote:
Am 27. Oktober 2022 20:47:19 UTC schrieb "Philippe Mathieu-Daudé"
:
Linux kernel expects the northbridge & southbridge chipsets
On Tue, 22 Nov 2022 at 08:58, Markus Armbruster wrote:
> I don't think complete detailed review is necessary or even sensible.
>
> Review should start with the Coccinelle script:
>
> // replace 'R = X; return R;' with 'return X;'
> @@
> identifier VAR;
> expression E;
> type T;
From: Xiaojuan Yang
Using macro to replace the value of uart info such as addr, size
in acpi_build method.
Signed-off-by: Xiaojuan Yang
Reviewed-by: Song Gao
Message-Id: <20221115115008.3372489-1-yangxiaoj...@loongson.cn>
Signed-off-by: Song Gao
---
hw/loongarch/acpi-build.c | 3 ++-
1 file
From: Xiaojuan Yang
Add "chosen" subnode into LoongArch fdt, and set it's
"stdout-path" prop to uart node.
Signed-off-by: Xiaojuan Yang
Reviewed-by: Song Gao
Message-Id: <20221115114923.3372414-1-yangxiaoj...@loongson.cn>
Signed-off-by: Song Gao
---
hw/loongarch/virt.c | 2 ++
1 file changed
The following changes since commit 6d71357a3b651ec9db126e4862b77e13165427f5:
rtl8139: honor large send MSS value (2022-11-21 09:28:43 -0500)
are available in the Git repository at:
https://gitlab.com/gaosong/qemu.git tags/pull-loongarch-20221122
for you to fetch changes up to
From: Xiaojuan Yang
Fix setprop_sized method in fdt rtc node.
Signed-off-by: Xiaojuan Yang
Reviewed-by: Richard Henderson
Reviewed-by: Song Gao
Message-Id: <20221116040300.3459818-1-yangxiaoj...@loongson.cn>
Signed-off-by: Song Gao
---
hw/loongarch/virt.c | 2 +-
1 file changed, 1 insertion
Am 07.11.2022 um 17:35 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Hi all!
>
> Here is 4-more simple already reviewed patches from
> "[PATCH v5 00/45] Transactional block-graph modifying API" [1]
>
> Called v8 because first part of [1] was recently merged as
> "[PATCH v7 for-7.2 00/15] bloc
On Mon, 21 Nov 2022 at 19:02, Ard Biesheuvel wrote:
>
> On Mon, 21 Nov 2022 at 19:51, Peter Maydell wrote:
> >
> > On Mon, 21 Nov 2022 at 17:43, Ard Biesheuvel wrote:
> > >
> > > The LPA2 extension implements 52-bit virtual addressing for 4k and 16k
> > > translation granules, and for the former
On Wed, 16 Nov 2022 at 13:14, Peter Maydell wrote:
>
> On Wed, 16 Nov 2022 at 06:11, Schspa Shi wrote:
> > Yes, I think we should accept this patch, because it will not affect
> > 32-bit devices, and provides support for 64-bit devices to put initrd
> > above 4GB.
>
> Yes, I agree. However since
Peter Maydell writes:
> On Tue, 22 Nov 2022 at 08:58, Markus Armbruster wrote:
>> I don't think complete detailed review is necessary or even sensible.
>>
>> Review should start with the Coccinelle script:
>>
>> // replace 'R = X; return R;' with 'return X;'
>> @@
>> identifier VAR;
On Mon, 21 Nov 2022 at 11:43, Peter Maydell wrote:
>
> On Mon, 21 Nov 2022 at 11:24, Mihai Carabas wrote:
> >
> > La 21.11.2022 13:02, Peter Maydell a scris:
> > > On Sun, 20 Nov 2022 at 17:53, Mihai Carabas
> > > wrote:
> > >> La 18.11.2022 21:11, Peter Maydell a scris:
> > >>> On Fri, 18 Nov
On Tue, 22 Nov 2022 at 13:27, Markus Armbruster wrote:
>
> Peter Maydell writes:
> > The obvious answer is "you might have got your manual tweaking
> > wrong". A purely mechanised patch I can review by looking at
> > the script and maybe eyeballing a few instances of the change;
> > a change that
Markus Armbruster (2):
cleanup: Tweak and re-run return_directly.cocci
block/vmdk: Simplify vmdk_co_create() to return directly
scripts/coccinelle/return_directly.cocci | 5 +--
include/hw/pci/pci.h | 7 +--
target/avr/cpu.h | 4 +-
block/vmdk.c
On 21/11/22 5:05 pm, Philippe Mathieu-Daudé wrote:
Hi,
On 20/11/22 23:54, Shivam Kumar wrote:
+
+void dirty_quota_migration_start(void)
+{
+ if (!kvm_state->dirty_quota_supported) {
You are accessing an accelerator-specific variable in an
accelerator-agnostic file, this doesn't sound c
La 22.11.2022 15:40, Peter Maydell a scris:
On Mon, 21 Nov 2022 at 11:43, Peter Maydell wrote:
On Mon, 21 Nov 2022 at 11:24, Mihai Carabas wrote:
La 21.11.2022 13:02, Peter Maydell a scris:
On Sun, 20 Nov 2022 at 17:53, Mihai Carabas wrote:
La 18.11.2022 21:11, Peter Maydell a scris:
On F
In CPUID registers exposed to userspace, some registers were missing
and some fields were not exposed. This patch aligns exposed ID
registers and their fields with what Linux exposes currently.
Specifically, the following new ID registers/fields are exposed to
userspace:
ID_AA64PFR1_EL1.BT:
Tweak the semantic patch to drop redundant parenthesis around the
return expression.
Coccinelle drops a comment in hw/rdma/vmw/pvrdma_cmd.c; restored
manually.
Coccinelle messes up vmdk_co_create(), not sure why. Change dropped,
will be done manually in the next commit.
Line breaks in target/av
Cc: Fam Zheng
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: qemu-bl...@nongnu.org
Signed-off-by: Markus Armbruster
---
block/vmdk.c | 28 +++-
1 file changed, 11 insertions(+), 17 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 26376352b9..bac3d8db50 100644
--- a/bloc
On Tue, 22 Nov 2022 at 13:51, Markus Armbruster wrote:
>
> Cc: Fam Zheng
> Cc: Kevin Wolf
> Cc: Hanna Reitz
> Cc: qemu-bl...@nongnu.org
> Signed-off-by: Markus Armbruster
> ---
> block/vmdk.c | 28 +++-
> 1 file changed, 11 insertions(+), 17 deletions(-)
>
Reviewed-by
* Juan Quintela (quint...@redhat.com) wrote:
> It was only used for RAM, and in that case, it means that this amount
> of data was sent for memory. Just delete the field in all callers.
>
> Signed-off-by: Juan Quintela
> ---
> include/migration/register.h | 20 ++--
> migratio
We have already used qapi to generate crypto device types, this allows
to convert type to a string 'model', so the 'model' field is not
needed.
And the 'name' field is not used by any backend driver, drop it.
Signed-off-by: zhenwei pi
---
backends/cryptodev-builtin.c| 3 +--
backends/crypt
Introduce cryptodev service type in cryptodev.json, then apply this
to related codes. Now we can remove VIRTIO_CRYPTO_SERVICE_xxx
dependence from QEMU cryptodev.
Signed-off-by: zhenwei pi
---
backends/cryptodev-builtin.c| 8
backends/cryptodev-lkcf.c | 2 +-
backends/cryptod
Now we have a QMP command to query crypto devices:
virsh qemu-monitor-command vm '{"execute": "query-cryptodev"}' | jq
{
"return": [
{
"service": [
"akcipher",
"mac",
"hash",
"cipher"
],
"id": "cryptodev1",
"client": [
{
Rather than exposing akcipher service/RSA algorithm to virtio crypto
device unconditionally, detect akcipher capability from akcipher
crypto framework. This avoids unsuccessful requests.
Signed-off-by: zhenwei pi
---
backends/cryptodev-builtin.c | 18 +++---
1 file changed, 15 insert
Signed-off-by: zhenwei pi
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3f698cb0e9..d1814f87ef 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2827,6 +2827,7 @@ T: git https://gitlab.com/ehabkost/qemu.git machine-next
Cryptodev Backends
M:
Introduce QCryptodevBackendType in cryptodev.json, also apply this to
related codes. Then we can drop 'enum CryptoDevBackendOptionsType'.
Signed-off-by: zhenwei pi
---
MAINTAINERS | 1 +
backends/cryptodev-builtin.c| 2 +-
backends/cryptodev-lkcf.c | 2 +-
backen
Introduce cryptodev statistics in QAPI, and record OPS/Bandwidth for
each crypto device.
Example of this feature:
virsh qemu-monitor-command vm '{"execute": "query-cryptodev"}' | jq
{
"return": [
{
"service": [
"akcipher",
"mac",
"hash",
"cipher"
]
Move queue_index, CryptoDevCompletionFunc and opaque into struct
CryptoDevBackendOpInfo, then cryptodev_backend_crypto_operation()
needs an argument CryptoDevBackendOpInfo *op_info only. And remove
VirtIOCryptoReq from cryptodev.
Signed-off-by: zhenwei pi
---
backends/cryptodev-builtin.c | 9 ++
Example of this command:
# virsh qemu-monitor-command vm --hmp info cryptodev
cryptodev1: service=[akcipher|mac|hash|cipher]
queue 0: type=builtin
cryptodev0: service=[akcipher]
queue 0: type=lkcf
Signed-off-by: zhenwei pi
---
hmp-commands-info.hx | 14 ++
include/monitor/h
Introduce cryptodev alg type in cryptodev.json, then apply this to
related codes, and drop 'enum CryptoDevBackendAlgType'.
There are two options:
1, { 'enum': 'QCryptodevBackendAlgType',
'prefix': 'CRYPTODEV_BACKEND_ALG',
'data': ['sym', 'asym']}
Then we can keep 'CRYPTODEV_BACKEND_ALG_SYM' an
Add 'throttle-bps' and 'throttle-ops' limitation to set QoS. The
two arguments work with both QEMU command line and QMP command.
Example of QEMU command line:
-object cryptodev-backend-builtin,id=cryptodev1,throttle-bps=1600,\
throttle-ops=100
Example of QMP command:
virsh qemu-monitor-command bu
On Tue, 22 Nov 2022, Markus Armbruster wrote:
Tweak the semantic patch to drop redundant parenthesis around the
return expression.
Coccinelle drops a comment in hw/rdma/vmw/pvrdma_cmd.c; restored
manually.
Coccinelle messes up vmdk_co_create(), not sure why. Change dropped,
will be done manual
v1 -> v2:
- fix coding style and use 'g_strjoin()' instead of 'char services[128]'
(suggested by Dr. David Alan Gilbert)
- wrapper function 'cryptodev_backend_account' to record statistics, and
allocate sym_stat/asym_stat in cryptodev base class. see patch:
'cryptodev: Support statistics'.
-
On Sat, 12 Nov 2022 at 04:26, Richard Henderson
wrote:
>
> Signed-off-by: Richard Henderson
> ---
> target/arm/helper-a64.h| 6 ---
> target/arm/helper-a64.c| 104 -
> target/arm/translate-a64.c | 60 -
> 3 files changed, 35 inse
1 - 100 of 202 matches
Mail list logo
