On Tue, Nov 08, 2022 at 05:23:24PM +0100, Claudio Fontana wrote:
> The GTK Clipboard implementation may cause guest hangs.
>
> Therefore implement a new configure switch --enable-gtk-clipboard,
> disabled by default, as a meson option.
Hmm, I was thinking about a runtime option, add 'clipboard' b
On Tue, Nov 08, 2022 at 02:23:47PM +, Alberto Faria wrote:
The nvme-io_uring BlockDriver's path option must point at the character
device of an NVMe namespace, not at an image file.
Fixes: fd66dbd424f5 ("blkio: add libblkio block driver")
Suggested-by: Stefano Garzarella
Signed-off-by: Albe
On Oct 21 16:10, clay.may...@kioxia.com wrote:
> From: Clay Mayers
>
> ZNS controllers have the option to limit the time a zone can remain in
> the active state. It begins with a background process in the controller
> setting the finish-zone-recommended FZR attribute for a zone. As part of
> se
The "query-command-line-options" command uses a hand-crafted list
of options that should be returned for the "machine" parameter.
This is pretty much out of sync with reality, for example settings
like "kvm_shadow_mem" or "accel" are not parameters for the machine
anymore. Also, there is no distinc
On 11/09/22 07:59, Michael S. Tsirkin wrote:
> On Wed, Nov 09, 2022 at 01:52:01AM -0500, Michael S. Tsirkin wrote:
>> On Wed, Nov 09, 2022 at 11:31:23AM +0800, Jason Wang wrote:
>>> On Wed, Nov 9, 2022 at 3:43 AM Stefan Hajnoczi wrote:
On Mon, 7 Nov 2022 at 18:10, Michael S. Tsirkin wro
On 11/8/22 15:37, Kevin Wolf wrote:
We want to change .bdrv_co_drained_begin() back to be a non-coroutine
callback, so in preparation, avoid yielding in its implementation.
Because we increase bs->in_flight and bdrv_drained_begin() polls, the
behaviour is unchanged.
Signed-off-by: Kevin Wolf
On 11/8/22 15:37, Kevin Wolf wrote:
int ret;
trace_qed_need_check_timer_cb(s);
@@ -310,9 +309,20 @@ static void coroutine_fn qed_need_check_timer_entry(void
*opaque)
(void) ret;
}
+static void coroutine_fn qed_need_check_timer_entry(void *opaque)
+{
+BDRVQEDState
Hi,
On Mon, Nov 7, 2022 at 7:08 PM Mauro Matteo Cascella
wrote:
>
> On Mon, Nov 7, 2022 at 11:35 AM Mauro Matteo Cascella
> wrote:
> >
> > Make sure to reset data_count if it's equal to (or exceeds) block_size.
> > This prevents an off-by-one read / write when accessing s->fifo_buffer
> > in sdh
On Tue, Nov 08, 2022 at 03:38:21PM -0500, John Snow wrote:
> On Thu, Nov 3, 2022 at 6:29 AM Maksim Davydov
> wrote:
> >
> > After modification of "query-machines" command the buffer size should be
> > more than 452kB to contain output with compat-props.
> >
> > Signed-off-by: Maksim Davydov
> > R
The subject is misleading, I'm afraid. It suggests you're changing the
default. You don't, you just fix its documentation.
Zhenyu Zhang writes:
> Since the amount of prealloc-threads to smp-cpus is
> defaulted in hostmem, so sync this information.
Covering history could be helpful.
Here's my
"Li, Kevin" writes:
> Hi qemu community,
>
>
>
> We are working on some open source project which uses qemu on mac, and we
> have some signing process to sign
> qemu-system-x86_64.
>
> If qemu-system-x86_64 is not signed, we don’t see any problem, but after sign
> it, we got the following e
Thanks a lot for the feedback and history. I understand now there are good
reasons to mandate fixed size flash. Will drop this patch.
Thanks
Sunil
On Wed, Nov 9, 2022 at 10:45 AM Siqi Chen wrote:
>
> Hi,
>
> >This reproducer does not crash my QEMU. Am I missing anything?
> I submitted the reproducer. Because the overflow is only one byte, it may not
> be detected by the host's heap allocator. Do you compile your qemu with
> sanitizer? Th
On Wed, 9 Nov 2022 at 01:53, Li, Kevin wrote:
>
> Hi qemu community,
>
>
>
> We are working on some open source project which uses qemu on mac, and we
> have some signing process to sign qemu-system-x86_64.
>
> If qemu-system-x86_64 is not signed, we don’t see any problem, but after sign
> it, w
> On 8 Nov 2022, at 12.51, Mads Ynddal wrote:
>
> I also noticed you are adding 1 to the WRPs and BRPs. As I interpret the
> documentation, you should subtract 1 instead, given the value 0 is reserved:
I tested it, and you do have to add 1. I guess it's implied that you cannot have
less than 2
On 11/8/22 15:13, Stefan Hajnoczi wrote:
On Tue, 8 Nov 2022 at 13:10, Philippe Mathieu-Daudé wrote:
On 8/11/22 18:26, Daniel Henrique Barboza wrote:
This commit caused a regression [1] that prevents machines that uses
Open Virtual Machine Firmware (OVMF) to boot.
This is a long standing b
On 11/8/22 15:37, Kevin Wolf wrote:
We want to change .bdrv_co_drained_begin/end() back to be non-coroutine
callbacks, so in preparation, avoid yielding in their implementation.
This does almost the same as the existing logic in bdrv_drain_invoke(),
by creating and entering coroutines internally
From: Klaus Jensen
Fix a couple of invalid errp usages.
Klaus Jensen (2):
hw/nvme: fix incorrect use of errp/local_err
hw/nvme: cleanup error reporting in nvme_init_pci()
hw/nvme/ctrl.c | 60 --
1 file changed, 29 insertions(+), 31 deletions(
From: Klaus Jensen
Replace the local Error variable with errp and ERRP_GUARD().
Signed-off-by: Klaus Jensen
---
hw/nvme/ctrl.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 4cc6ae753295..38eb5ec54f9d 100644
--- a/hw/nvme/
From: Klaus Jensen
Make nvme_check_constraints() return an int and fix incorrect use of
errp/local_err.
Signed-off-by: Klaus Jensen
---
hw/nvme/ctrl.c | 48 +++-
1 file changed, 23 insertions(+), 25 deletions(-)
diff --git a/hw/nvme/ctrl.c b/hw/nvme
On Tue, 8 Nov 2022 at 11:51, Mads Ynddal wrote:
> I also noticed you are adding 1 to the WRPs and BRPs. As I interpret the
> documentation, you should subtract 1 instead, given the value 0 is reserved:
>
> diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c
> index dbc3605f6d..80a583cbd1 1006
On Wed, Nov 09, 2022 at 09:39:14AM +, Daniel P. Berrangé wrote:
> On Tue, Nov 08, 2022 at 03:38:21PM -0500, John Snow wrote:
> > On Thu, Nov 3, 2022 at 6:29 AM Maksim Davydov
> > wrote:
> > >
> > > After modification of "query-machines" command the buffer size should be
> > > more than 452kB t
On Wed, Nov 09, 2022 at 09:56:40AM +0100, Laszlo Ersek wrote:
> On 11/09/22 07:59, Michael S. Tsirkin wrote:
> > On Wed, Nov 09, 2022 at 01:52:01AM -0500, Michael S. Tsirkin wrote:
> >> On Wed, Nov 09, 2022 at 11:31:23AM +0800, Jason Wang wrote:
> >>> On Wed, Nov 9, 2022 at 3:43 AM Stefan Hajnoczi
In virtio_queue_enable(), we checked virtio feature VIRTIO_F_VERSION_1.
This check is not necessary, and conflict with SeaBIOS. The problem
appeared in SeaBIOS. But we also remove this check.
Link: https://www.mail-archive.com/qemu-devel@nongnu.org/msg920538.html
Signed-off-by: Xuan Zhuo
---
hw
> In my version, I added the sw breakpoints to `hvf_vcpu_state` so they would
> follow each CPU, but it's effectively a copy of the global set of breakpoints.
Ah, I missed this field, and it seems the proper one to use. I'll switch
to this.
> Moving it to `hvf_arch_update_guest_debug` would proba
If the network between qemu and usbredirserver is temporarily disconnected,
the USB device in the VM will be unplugged. If the reconnect parameter is
configured for the backend chardev, the device will be reconnected later.
But from the inside of the VM, this USB device has experienced unplug and
r
Currently QEMU terminates if you try to hotplug pnv-phb-root-port in
an environment where it is not supported, e.g. if doing this:
echo "device_add pnv-phb-root-port" | \
./qemu-system-ppc64 -monitor stdio -M powernv9
To avoid this problem, the pnv_phb_root_port_realize() function should
not us
Am 09.11.2022 um 10:27 hat Vladimir Sementsov-Ogievskiy geschrieben:
> On 11/8/22 15:37, Kevin Wolf wrote:
> > int ret;
> > trace_qed_need_check_timer_cb(s);
> > @@ -310,9 +309,20 @@ static void coroutine_fn
> > qed_need_check_timer_entry(void *opaque)
> > (void) ret;
> > }
> >
Am 08/11/2022 um 17:19 schrieb Vladimir Sementsov-Ogievskiy:
> [add Stefan]
>
>
> On 11/8/22 18:09, Emanuele Giuseppe Esposito wrote:
>>
>>
>> Am 08/11/2022 um 15:48 schrieb Vladimir Sementsov-Ogievskiy:
>>> On 11/4/22 12:56, Emanuele Giuseppe Esposito wrote:
These functions end up callin
Am 09.11.2022 um 11:50 hat Vladimir Sementsov-Ogievskiy geschrieben:
> On 11/8/22 15:37, Kevin Wolf wrote:
> > We want to change .bdrv_co_drained_begin/end() back to be non-coroutine
> > callbacks, so in preparation, avoid yielding in their implementation.
> >
> > This does almost the same as the
Klaus Jensen writes:
> From: Klaus Jensen
>
> Make nvme_check_constraints() return an int and fix incorrect use of
> errp/local_err.
>
> Signed-off-by: Klaus Jensen
> ---
> hw/nvme/ctrl.c | 48 +++-
> 1 file changed, 23 insertions(+), 25 deletions(-)
Klaus Jensen writes:
> From: Klaus Jensen
>
> Replace the local Error variable with errp and ERRP_GUARD().
>
> Signed-off-by: Klaus Jensen
> ---
> hw/nvme/ctrl.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
> index 4cc6ae
On Nov 9 13:29, Markus Armbruster wrote:
> Klaus Jensen writes:
>
> > From: Klaus Jensen
> >
> > Make nvme_check_constraints() return an int and fix incorrect use of
> > errp/local_err.
> >
> > Signed-off-by: Klaus Jensen
> > ---
> > hw/nvme/ctrl.c | 48 +++
On Nov 9 13:33, Markus Armbruster wrote:
> Klaus Jensen writes:
>
> > From: Klaus Jensen
> >
> > Replace the local Error variable with errp and ERRP_GUARD().
> >
> > Signed-off-by: Klaus Jensen
> > ---
> > hw/nvme/ctrl.c | 12 ++--
> > 1 file changed, 6 insertions(+), 6 deletions(-)
>
Klaus Jensen writes:
> From: Klaus Jensen
>
> Make nvme_check_constraints() return an int and fix incorrect use of
> errp/local_err.
>
> Signed-off-by: Klaus Jensen
One more question: what exactly do you mean by "incorrect use of
errp/local_err"? Is it incorrect in the sense of "behaves badly
On 11/9/22 09:04, Gerd Hoffmann wrote:
> On Tue, Nov 08, 2022 at 05:23:24PM +0100, Claudio Fontana wrote:
>> The GTK Clipboard implementation may cause guest hangs.
>>
>> Therefore implement a new configure switch --enable-gtk-clipboard,
>> disabled by default, as a meson option.
>
> Hmm, I was th
On Nov 9 13:36, Markus Armbruster wrote:
> Klaus Jensen writes:
>
> > From: Klaus Jensen
> >
> > Make nvme_check_constraints() return an int and fix incorrect use of
> > errp/local_err.
> >
> > Signed-off-by: Klaus Jensen
>
> One more question: what exactly do you mean by "incorrect use of
>
> I was planning to move hypervisor-specific code to target/arm/$hypervisor/,
> but here Francesco wants to re-use the same code
> between 2 hypervisors... Maybe move it to target/arm/hyp_gdbstub.c
> and let meson add it conditionally?
Something like this?
-arm_ss.add(when: 'CONFIG_KVM', if_true
Klaus Jensen writes:
> On Nov 9 13:36, Markus Armbruster wrote:
>> Klaus Jensen writes:
>>
>> > From: Klaus Jensen
>> >
>> > Make nvme_check_constraints() return an int and fix incorrect use of
>> > errp/local_err.
>> >
>> > Signed-off-by: Klaus Jensen
>>
>> One more question: what exactly
Signed-off-by: Laurent Vivier
Acked-by: Michael S. Tsirkin
---
Notes:
v3:
- Add "-M none" to avoid error:
"No machine specified, and there is no default"
v2:
- Fix ipv6 free port allocation
- Check for IPv4, IPv6, AF_UNIX
- Use g_mkdtemp() rather than g_file_op
On 11/9/22 13:22, Thomas Huth wrote:
Currently QEMU terminates if you try to hotplug pnv-phb-root-port in
an environment where it is not supported, e.g. if doing this:
echo "device_add pnv-phb-root-port" | \
./qemu-system-ppc64 -monitor stdio -M powernv9
To avoid this problem, the pnv_phb_r
* Leonardo Bras (leob...@redhat.com) wrote:
> When multifd and postcopy-ram capabilities are enabled, if a
> migrate-start-postcopy is attempted, the migration will finish sending the
> memory pages and then crash with the following error:
How does that happen? Isn't multifd+postcopy still disable
From: Leif Lindholm
We have mainly (well, as will become clear, in fact "exclusively") been using
sbsa-ref with the "max" CPU. But sbsa-ref was created with a default CPU of
Cortex-A57, which we have not updated along the way.
However, the "max" cpu has seen a bug where Linux boot fails around U
From: Leif Lindholm
Due to a change in upstream TF-A, boot fails (in edk2) on all cpus that
don't implement FEAT_DIT. The only currently emulated cpu that "supports"
this feature is "max". So switch to using that cpu by default for
sbsa-ref.
However, it is worth noting that the "max" cpu trigger
On 11/9/22 09:22, Thomas Huth wrote:
Currently QEMU terminates if you try to hotplug pnv-phb-root-port in
an environment where it is not supported, e.g. if doing this:
echo "device_add pnv-phb-root-port" | \
./qemu-system-ppc64 -monitor stdio -M powernv9
To avoid this problem, the pnv_ph
Hello,
Sorry for the potentially naive question, but I'm not clear what the
process would be if, say, I'd like to raise the number of maximum CPUs
a q35 VM can have.
So, right now we have:
void pc_q35_2_7_machine_options(MachineClass *m) {
...
m->max_cpus = 255;
}
And:
void pc_q35_machine_
On 11/8/22 15:37, Kevin Wolf wrote:
We want to change .bdrv_co_drained_begin/end() back to be non-coroutine
callbacks, so in preparation, avoid yielding in their implementation.
This does almost the same as the existing logic in bdrv_drain_invoke(),
by creating and entering coroutines internally
On Wed, 9 Nov 2022 at 13:35, Leif Lindholm wrote:
>
> From: Leif Lindholm
>
> We have mainly (well, as will become clear, in fact "exclusively") been using
> sbsa-ref with the "max" CPU. But sbsa-ref was created with a default CPU of
> Cortex-A57, which we have not updated along the way.
So, I d
On 11/8/22 15:37, Kevin Wolf wrote:
Polling during bdrv_drained_end() can be problematic (and in the future,
we may get cases for bdrv_drained_begin() where polling is forbidden,
and we don't care about already in-flight requests, but just want to
prevent new requests from arriving).
The .bdrv_d
Hi,
>This reproducer does not crash my QEMU. Am I missing anything?
I submitted the reproducer. Because the overflow is only one byte, it may
not be detected by the host's heap allocator. Do you compile your qemu
with sanitizer? This is my build configuration: "./configure
--target-list=x86_64-s
On 11/8/22 15:37, Kevin Wolf wrote:
drained_end_counter is unused now, nobody changes its value any more. It
can be removed.
In cases where we had two almost identical functions that only differed
in whether the caller passes drained_end_counter, or whether they would
poll for a local drained_en
a66a24585f (hw/intc/arm_gic: Implement read of GICC_IIDR) implemented
this for the CPU interface register. The fact we don't implement it
shows up when running Xen with -d guest_error which is definitely
wrong because the guest is perfectly entitled to read it.
Lightly re-factor this region of reg
On Wed, Nov 09, 2022 at 07:10:21PM +0800, Xuan Zhuo wrote:
> In virtio_queue_enable(), we checked virtio feature VIRTIO_F_VERSION_1.
>
> This check is not necessary, and conflict with SeaBIOS. The problem
> appeared in SeaBIOS. But we also remove this check.
>
> Link: https://www.mail-archive.com
Daniel P. Berrangé writes:
> On Mon, Nov 07, 2022 at 06:32:01PM +0100, Andrew Jones wrote:
[...]
>> Padding is a good idea, but too much causes other problems. When building
>> lightweight VMs which may pull the firmware image from a network,
>> AArch64 VMs require 64MB of mostly zeros to be tr
On Wed, Nov 09, 2022 at 04:26:53PM +0100, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Mon, Nov 07, 2022 at 06:32:01PM +0100, Andrew Jones wrote:
>
> [...]
>
> >> Padding is a good idea, but too much causes other problems. When building
> >> lightweight VMs which may pull the
On 11/8/22 15:37, Kevin Wolf wrote:
bdrv_drain_invoke() has now two entirely separate cases that share no
code any more and are selected depending on a bool parameter. Each case
has only one caller. Just inline the function.
Signed-off-by: Kevin Wolf
Reviewed-by: Vladimir Sementsov-Ogievskiy
> -Original Message-
> From: Richard Henderson
> Sent: Tuesday, November 8, 2022 7:41 PM
> To: Taylor Simpson ; qemu-devel@nongnu.org
> Cc: phi...@linaro.org; a...@rev.ng; a...@rev.ng; Brian Cain
> ; Matheus Bernardino (QUIC)
>
> Subject: Re: [PATCH v4 10/11] Hexagon (target/hexagon) Us
From: Miroslav Rezanina
Commit cfead31326 'acpi: pc: vga: use AcpiDevAmlIf interface to build VGA
device descriptors' added
a new file - acpi-vga.c. This file (indirectly) includes pixman.h file so we
need to ensure pixman
is available when file is compiled.
Signed-off-by: Miroslav Rezanina
-
On 10/27/22 06:01, Daniel P. Berrangé wrote:
On Thu, Oct 27, 2022 at 09:46:29AM +0200, Thomas Huth wrote:
On 24/10/2022 11.02, Daniel P. Berrangé wrote:
On Sat, Oct 22, 2022 at 02:03:50PM -0300, Daniel Henrique Barboza wrote:
'make check-avocado' will download any images that aren't present
On Tue, Aug 23, 2022 at 5:58 AM Jason Wang wrote:
>
> On Fri, Aug 19, 2022 at 6:35 PM Eugenio Perez Martin
> wrote:
> >
> > On Fri, Aug 19, 2022 at 11:01 AM Jason Wang wrote:
> > >
> > > On Fri, Aug 19, 2022 at 4:30 PM Eugenio Perez Martin
> > > wrote:
> > > >
> > > > On Fri, Aug 19, 2022 at 8:
Daniel P. Berrangé writes:
> On Wed, Nov 09, 2022 at 04:26:53PM +0100, Markus Armbruster wrote:
>> Daniel P. Berrangé writes:
>>
>> > On Mon, Nov 07, 2022 at 06:32:01PM +0100, Andrew Jones wrote:
>>
>> [...]
>>
>> >> Padding is a good idea, but too much causes other problems. When building
>>
On Wed, Nov 09, 2022 at 04:45:18PM +0100, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Wed, Nov 09, 2022 at 04:26:53PM +0100, Markus Armbruster wrote:
> >> Daniel P. Berrangé writes:
> >>
> >> > On Mon, Nov 07, 2022 at 06:32:01PM +0100, Andrew Jones wrote:
> >>
> >> [...]
> >
On Mon, Nov 07, 2022 at 04:41:41PM -0800, Isaku Yamahata wrote:
> On Thu, Nov 03, 2022 at 05:43:52PM +0530,
> Vishal Annapurve wrote:
>
> > On Tue, Oct 25, 2022 at 8:48 PM Chao Peng
> > wrote:
> > >
> > > This patch series implements KVM guest private memory for confidential
> > > computing sce
From: Miroslav Rezanina
Variable n used in tulip_idblock_crc function is only incremented but never
read.
This causes 'Unused but set variable' warning on Clang 15.0.1 compiler.
Removing the variable to prevent the warning.
Signed-off-by: Miroslav Rezanina
---
hw/net/tulip.c | 4 +---
1 file
From: Miroslav Rezanina
Variable block_count used in img_dd function is only incremented but never read.
This causes 'Unused but set variable' warning on Clang 15.0.1 compiler.
Removing the variable to prevent the warning.
Signed-off-by: Miroslav Rezanina
---
qemu-img.c | 4 ++--
1 file chang
From: Miroslav Rezanina
When trying to run qemu build using clang 15.0.1 compiler with
--enable-werror option, several 'Unused but set variable' warnings
was breaking the build.
These variables show similar pattern - they are only incremented but
final value of the variable is never used.
Remo
From: Miroslav Rezanina
Variable send_count used in rtl8139_cplus_transmit_one function is only
incremented but never read. This causes 'Unused but set variable' warning
on Clang 15.0.1 compiler.
Removing the variable to prevent the warning.
Signed-off-by: Miroslav Rezanina
---
hw/net/rtl8139
From: Miroslav Rezanina
Variable unconnected used in usb_host_auto_check function is only incremented
but never read as line where it is read was disabled since introducing the code.
This causes 'Unused but set variable' warning on Clang 15.0.1 compiler.
Removing the variable and disabled code t
In subject: individual
On 11/8/22 15:37, Kevin Wolf wrote:
bdrv_reopen() and friends use subtree drains as a lazy way of covering
all the nodes they touch. Turns out that this lazy way is a lot more
complicated than just draining the nodes individually, even not
accounting for the additional com
Convert the TYPE_ARM_GIC_COMMON device to 3-phase reset. This is a
simple no-behaviour-change conversion.
Signed-off-by: Peter Maydell
---
hw/intc/arm_gic_common.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/intc/arm_gic_common.c b/hw/intc/arm_gic_common.c
inde
Hi Mirek,
On 9/11/22 16:34, mreza...@redhat.com wrote:
From: Miroslav Rezanina
Commit cfead31326 'acpi: pc: vga: use AcpiDevAmlIf interface to build VGA
device descriptors' added
a new file - acpi-vga.c. This file (indirectly) includes pixman.h file so we
need to ensure pixman
is available w
Convert the TYPE_ARM_SMMUV3 device to 3-phase reset. The legacy
reset method doesn't do anything that's invalid in the hold phase, so
the conversion only requires changing it to a hold phase method, and
using the 3-phase versions of the "save the parent reset method and
chain to it" code.
Signed-
Convert the TYPE_KVM_ARM_GICV3 device to 3-phase reset.
Signed-off-by: Peter Maydell
---
hw/intc/arm_gicv3_kvm.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c
index 3ca643ecba4..72ad916d3db 100644
--- a/hw/int
Convert the TYPE_ARM_GICV3_COMMON parent class to 3-phase reset.
Signed-off-by: Peter Maydell
---
hw/intc/arm_gicv3_common.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/intc/arm_gicv3_common.c b/hw/intc/arm_gicv3_common.c
index 351843db4aa..642a8243ed4 100644
--
This patchset converts some Arm devices to 3-phase reset. The
rationale here is that it would be nice to get rid of the
device_class_set_parent_reset() function, which is used by
legacy-reset subclasses which want to chain to their parent's reset
function. There aren't very many of these devices i
Convert the TYPE_ARM_SMMU device to 3-phase reset. The legacy method
doesn't do anything that's invalid in the hold phase, so the
conversion is simple and not a behaviour change.
Note that we must convert this base class before we can convert the
TYPE_ARM_SMMUV3 subclass -- transitional support i
Convert the TYPE_ARM_GICV3_ITS_COMMON parent class to 3-phase reset.
Signed-off-by: Peter Maydell
---
hw/intc/arm_gicv3_its_common.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/intc/arm_gicv3_its_common.c b/hw/intc/arm_gicv3_its_common.c
index 90b85f1e25c..d7532
Now we have converted TYPE_ARM_GIC_COMMON, we can convert the
TYPE_ARM_GIC_KVM subclass to 3-phase reset.
Signed-off-by: Peter Maydell
---
hw/intc/arm_gic_kvm.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/intc/arm_gic_kvm.c b/hw/intc/arm_gic_kvm.c
index
Convert the TYPE_KVM_ARM_ITS device to 3-phase reset.
Signed-off-by: Peter Maydell
---
hw/intc/arm_gicv3_its_kvm.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/intc/arm_gicv3_its_kvm.c b/hw/intc/arm_gicv3_its_kvm.c
index 529c7bd4946..7eda9fb86ea 100644
--
On 11/8/22 15:37, Kevin Wolf wrote:
Instead of using a subtree drain from the top node (which also drains
child nodes of base that we're not even interested in), use a normal
drain for base, which automatically drains all of the parents, too.
Signed-off-by: Kevin Wolf
Reviewed-by: Vladimir Sem
On Wed, Nov 9, 2022 at 6:10 PM Mauro Matteo Cascella
wrote:
>
> On Wed, Nov 9, 2022 at 10:45 AM Siqi Chen wrote:
> >
> > Hi,
> >
> > >This reproducer does not crash my QEMU. Am I missing anything?
> > I submitted the reproducer. Because the overflow is only one byte, it may
> > not be detected b
Convert the TYPE_ARM_GICV3_ITS device to 3-phase reset.
Signed-off-by: Peter Maydell
---
hw/intc/arm_gicv3_its.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c
index 2ff21ed6bbe..57c79da5c55 100644
--- a/hw/int
On Wed, Nov 9, 2022 at 6:09 PM Claudio Fontana wrote:
>
> On 11/9/22 09:04, Gerd Hoffmann wrote:
>
>
> Thanks Gerd,
>
> I think at least for our packaging purposes we'd rather have it as a
> configure time option,
> so as to not put functionality in the hands of our users that can potentially
>
On Wed, 9 Nov 2022 at 16:21, Ani Sinha wrote:
>
> On Wed, Nov 9, 2022 at 6:09 PM Claudio Fontana wrote:
> >
> > On 11/9/22 09:04, Gerd Hoffmann wrote:
> >
> >
> > Thanks Gerd,
> >
> > I think at least for our packaging purposes we'd rather have it as a
> > configure time option,
> > so as to not
On Wed, Nov 9, 2022 at 9:52 PM Peter Maydell wrote:
>
> On Wed, 9 Nov 2022 at 16:21, Ani Sinha wrote:
> >
> > On Wed, Nov 9, 2022 at 6:09 PM Claudio Fontana wrote:
> > >
> > > On 11/9/22 09:04, Gerd Hoffmann wrote:
> > >
> > >
> > > Thanks Gerd,
> > >
> > > I think at least for our packaging pur
Hi Vikram,
In the git summary s/zynqmp/versal/.
On [2022 Oct 21] Fri 22:47:44, Vikram Garhwal wrote:
> Connect CANFD0 and CANFD1 on the Versal-virt machine and update
> xlnx-versal-virt
> document with CANFD command line examples.
>
> Signed-off-by: Vikram Garhwal
> ---
> docs/system/arm/xlnx
On 11/8/22 15:37, Kevin Wolf wrote:
The subtree drain was introduced in commit b1e1af394d9 as a way to avoid
graph changes between finding the base node and changing the block graph
as necessary on completion of the image streaming job.
The block graph could change between these two points becau
Hi,
For some reason(TM), the mirror job, when in write-blocking mode, has
decided not to issue background requests while active writes are in
flight. (Or rather, it was probably me who decided that.)
The problem is that only background requests can really reliably help
you make progress. When a
mirror_wait_for_free_in_flight_slot() is the only remaining user of
mirror_wait_for_any_operation(), so inline the latter into the former.
Signed-off-by: Hanna Reitz
---
block/mirror.c | 21 -
1 file changed, 8 insertions(+), 13 deletions(-)
diff --git a/block/mirror.c b/blo
Waiting for all active writes to settle before daring to create a
background copying operation means that we will never do background
operations while the guest does anything (in write-blocking mode), and
therefore cannot converge. Yes, we also will not diverge, but actually
converging would be ev
There is a small gap in mirror_start_job() before putting the mirror
filter node into the block graph (bdrv_append() call) and the actual job
being created. Before the job is created, MirrorBDSOpaque.job is NULL.
It is possible that requests come in when bdrv_drained_end() is called,
and those re
Have write requests happen to the source node right when we start a
mirror job. The mirror filter node may encounter MirrorBDSOpaque.job
being NULL, but this should not cause a segfault.
Signed-off-by: Hanna Reitz
---
tests/qemu-iotests/151 | 53 +++---
tests
Before this series, a mirror job in write-blocking mode would pause
issuing background requests while active requests are in flight. Thus,
if the source is constantly in use by active requests, no actual
progress can be made.
This series should have fixed that, making the mirror job issue
backgro
On Wed, Nov 9, 2022 at 10:31 AM Dr. David Alan Gilbert
wrote:
>
> * Leonardo Bras (leob...@redhat.com) wrote:
> > When multifd and postcopy-ram capabilities are enabled, if a
> > migrate-start-postcopy is attempted, the migration will finish sending the
> > memory pages and then crash with the fol
Convert the child classes TYPE_PS2_KBD_DEVICE and
TYPE_PS2_MOUSE_DEVICE to the 3-phase reset system. This allows us to
stop using the old device_class_set_parent_reset() function.
We don't need to register an 'exit' phase function for the
subclasses, because they have no work to do in that phase.
Convert the parent class TYPE_PS2_DEVICE to 3-phase reset. Note that
we need an 'exit' phase function as well as the usual 'hold' phase
function, because changing outbound IRQ line state is only permitted
in 'exit'. (Strictly speaking it's not supposed to be done in a
legacy reset handler either,
This patchset converts the ps2 keyboard and mouse devices to 3-phase
reset. The rationale here is that it would be nice to get rid of the
device_class_set_parent_reset() function, which is used by
legacy-reset subclasses which want to chain to their parent's reset
function. There aren't very many o
Hello,
On behalf of the QEMU Team, I'd like to announce the availability of the
first release candidate for the QEMU 7.2 release. This release is meant
for testing purposes and should not be used in a production environment.
http://download.qemu-project.org/qemu-7.2.0-rc0.tar.xz
http://downlo
On 11/8/22 15:37, Kevin Wolf wrote:
Subtree drains are not used any more. Remove them.
After this, BdrvChildClass.attach/detach() don't poll any more.
Signed-off-by: Kevin Wolf
Reviewed-by: Vladimir Sementsov-Ogievskiy
--
Best regards,
Vladimir
Hi Peter,
We first install via homebrew and then extract the executables (qemu-img and
qemu-system-xxx) out.
We recently did this, so it should be the latest version of qemu via homebrew,
and our package is for MacOS, which needs sign and notarize.
If we extract in this way, and use it on other
1 - 100 of 191 matches
Mail list logo
