Re: [PATCH 2/2] gitlab: show configure/make args before running

2022-11-03 Thread Stefan Hajnoczi
On Thu, 3 Nov 2022 at 13:30, Daniel P. Berrangé wrote: > > When debugging failed jobs it is helpful to see the > full configure/make args used, without having to search > the gitlab config file to figure it out. > > Signed-off-by: Daniel P. Berrangé > --- > .gitlab-ci.d/buildtest-template.yml |

Re: [PATCH v4 10/22] hw/virtio: move vm_running check to virtio_device_started

2022-11-03 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Tue, Aug 02, 2022 at 10:49:58AM +0100, Alex Bennée wrote: >> All the boilerplate virtio code does the same thing (or should at >> least) of checking to see if the VM is running before attempting to >> start VirtIO. Push the logic up to the common function to av

Re: [PATCH v3] linux-user: implement execveat

2022-11-03 Thread Helge Deller
On 11/3/22 18:32, Drew DeVault wrote: References: https://gitlab.com/qemu-project/qemu/-/issues/1007 Signed-off-by: Drew DeVault --- v2 => v3: - Rebase to address the is_proc_myself fix - Drop the ifdefs linux-user/syscall.c | 203 ++- 1 file changed,

Re: [PATCH] meson: avoid unused arguments of main() in compiler tests

2022-11-03 Thread Stefan Weil via
Am 03.11.22 um 18:21 schrieb Paolo Bonzini: meson.build has one test where "main" is declared unnecessarily with argc and argv arguments, but does not use them. Because the test needs -Werror too, HAVE_BROKEN_SIZE_MAX is defined incorrectly. Fix the test and, for consistency, remove argc and a

Re: [PATCH] target/arm: Two fixes for secure ptw

2022-11-03 Thread Richard Henderson
On 11/4/22 00:19, Peter Maydell wrote: @@ -2671,6 +2671,13 @@ static bool get_phys_addr_with_struct(CPUARMState *env, S1Translate *ptw, bool is_secure = ptw->in_secure; ARMMMUIdx s1_mmu_idx; +/* + * The page table entries may downgrade secure to non-secure, but + * canno

Re: [PATCH v4 10/22] hw/virtio: move vm_running check to virtio_device_started

2022-11-03 Thread Michael S. Tsirkin
On Thu, Nov 03, 2022 at 07:18:30PM +, Alex Bennée wrote: > > "Michael S. Tsirkin" writes: > > > On Tue, Aug 02, 2022 at 10:49:58AM +0100, Alex Bennée wrote: > >> All the boilerplate virtio code does the same thing (or should at > >> least) of checking to see if the VM is running before attem

Re: [PULL v2 00/82] pci,pc,virtio: features, tests, fixes, cleanups

2022-11-03 Thread Michael S. Tsirkin
On Thu, Nov 03, 2022 at 11:14:21PM +0530, Ani Sinha wrote: > > > On Thu, Nov 3, 2022 at 23:11 Daniel P. Berrangé wrote: > > On Thu, Nov 03, 2022 at 10:26:26PM +0530, Ani Sinha wrote: > > On Thu, Nov 3, 2022 at 10:18 PM Ani Sinha wrote: > > > > > > On Thu, Nov 3, 2022 at 10:17 P

Re: [PATCH RFC] target/loongarch: Fix emulation of float-point disable exception

2022-11-03 Thread Richard Henderson
On 11/3/22 19:02, Rui Wang wrote: +static void check_fpe(DisasContext *ctx) +{ +#ifndef CONFIG_USER_ONLY +TCGLabel *skip = gen_new_label(); +TCGv tmp = tcg_temp_new(); + +tcg_gen_andi_tl(tmp, cpu_euen, R_CSR_EUEN_FPE_MASK); +tcg_gen_brcond_tl(TCG_COND_NE, tmp, ctx->zero, skip); +

Re: [PATCH v2] target/loongarch: Fix emulation of float-point disable exception

2022-11-03 Thread Richard Henderson
On 11/3/22 23:25, Rui Wang wrote: +/* + * LoongArch CPUs hardware flags. + * bit[2..0] for MMU index. + * bit[7..4] for CSR.EUEN.{ BTE, ASXE, SXE, FPE }. + */ +#define HW_FLAGS_MMU_MASK 0x07 +#define HW_FLAGS_EUEN_FPE 0x10 + static inline void cpu_get_tb_cpu_state(CPULoongArchState *env,

[PATCH] gitlab-ci: split clang-user to avoid timeout

2022-11-03 Thread Stefan Hajnoczi
GitLab CI times out when the clang-user job takes over 1 hour. Split it into parts that check various architectures. An alternative is to have one job per architecture but that clutters the pipeline view and maybe there is some sharing when multiple targets are built at once. Signed-off-by: Stefa

Re: [PULL 0/5] Misc patches for QEMU 7.2 soft freeze

2022-11-03 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/2] hw/nvme fixes

2022-11-03 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/4] Linux user for 7.2 patches

2022-11-03 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH] meson: avoid unused arguments of main() in compiler tests

2022-11-03 Thread Richard Henderson
On 11/4/22 04:21, Paolo Bonzini wrote: meson.build has one test where "main" is declared unnecessarily with argc and argv arguments, but does not use them. Because the test needs -Werror too, HAVE_BROKEN_SIZE_MAX is defined incorrectly. Fix the test and, for consistency, remove argc and argv wh

Re: [PATCH 2/2] gitlab: show configure/make args before running

2022-11-03 Thread Richard Henderson
On 11/4/22 06:06, Stefan Hajnoczi wrote: On Thu, 3 Nov 2022 at 13:30, Daniel P. Berrangé wrote: When debugging failed jobs it is helpful to see the full configure/make args used, without having to search the gitlab config file to figure it out. Signed-off-by: Daniel P. Berrangé --- .gitlab

Re: [PATCH v4 10/22] hw/virtio: move vm_running check to virtio_device_started

2022-11-03 Thread Michael S. Tsirkin
On Thu, Nov 03, 2022 at 04:30:48PM -0400, Michael S. Tsirkin wrote: > On Thu, Nov 03, 2022 at 07:18:30PM +, Alex Bennée wrote: > > > > "Michael S. Tsirkin" writes: > > > > > On Tue, Aug 02, 2022 at 10:49:58AM +0100, Alex Bennée wrote: > > >> All the boilerplate virtio code does the same thin

Re: [PULL v2 00/82] pci,pc,virtio: features, tests, fixes, cleanups

2022-11-03 Thread Michael S. Tsirkin
On Thu, Nov 03, 2022 at 09:29:56AM -0400, Stefan Hajnoczi wrote: > On Thu, 3 Nov 2022 at 08:14, Michael S. Tsirkin wrote: > > On Wed, Nov 02, 2022 at 03:47:43PM -0400, Stefan Hajnoczi wrote: > > > On Wed, Nov 02, 2022 at 12:02:14PM -0400, Michael S. Tsirkin wrote: > > > > Changes from v1: > > > >

Re: [PATCH] gitlab-ci: split clang-user to avoid timeout

2022-11-03 Thread Philippe Mathieu-Daudé
+Richard On 3/11/22 22:23, Stefan Hajnoczi wrote: GitLab CI times out when the clang-user job takes over 1 hour. Split it into parts that check various architectures. An alternative is to have one job per architecture but that clutters the pipeline view and maybe there is some sharing when mult

Re: [PATCH] gitlab-ci: split clang-user to avoid timeout

2022-11-03 Thread Richard Henderson
On 11/4/22 09:32, Philippe Mathieu-Daudé wrote: +Richard On 3/11/22 22:23, Stefan Hajnoczi wrote: GitLab CI times out when the clang-user job takes over 1 hour. Split it into parts that check various architectures. An alternative is to have one job per architecture but that clutters the pipeli

Re: [PATCH v9 5/8] KVM: Register/unregister the guest private memory regions

2022-11-03 Thread Sean Christopherson
On Tue, Oct 25, 2022, Chao Peng wrote: > @@ -4708,6 +4802,24 @@ static long kvm_vm_ioctl(struct file *filp, > r = kvm_vm_ioctl_set_memory_region(kvm, &mem); > break; > } > +#ifdef CONFIG_KVM_GENERIC_PRIVATE_MEM > + case KVM_MEMORY_ENCRYPT_REG_REGION: > + ca

Re: [PATCH 04/26] target/s390x: Use tcg_constant_* in translate_vx.c.inc

2022-11-03 Thread Richard Henderson
On 11/3/22 22:04, Ilya Leoshkevich wrote: On Wed, Oct 05, 2022 at 08:43:59PM -0700, Richard Henderson wrote: In most cases, this is a simple local allocate and free replaced by tcg_constant_*. In three cases, a variable temp was initialized with a constant value -- reorg to localize the constan

Re: [PATCH] qom.json: default the prealloc-threads to smp-cpus

2022-11-03 Thread Zhenyu Zhang
Hello Philippe I checked out this modified patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg15.html It should have been merged in 7.1 On Thu, Nov 3, 2022 at 7:00 PM Philippe Mathieu-Daudé wrote: > > On 3/11/22 11:47, Zhenyu Zhang wrote: > > Since the amount of prealloc-threads

Re: [PATCH v6 0/3] ppc/e500: Add support for eSDHC

2022-11-03 Thread BALATON Zoltan
On Thu, 3 Nov 2022, Daniel Henrique Barboza wrote: On 11/3/22 09:51, BALATON Zoltan wrote: On Wed, 2 Nov 2022, Daniel Henrique Barboza wrote: On 11/1/22 19:29, Philippe Mathieu-Daudé wrote: This is a respin of Bernhard's v4 with Freescale eSDHC implemented as an 'UNIMP' region. See v4 cover he

Re: [PATCH v9 4/8] KVM: Use gfn instead of hva for mmu_notifier_retry

2022-11-03 Thread Chao Peng
On Thu, Oct 27, 2022 at 11:29:14AM +0100, Fuad Tabba wrote: > Hi, > > On Tue, Oct 25, 2022 at 4:19 PM Chao Peng wrote: > > > > Currently in mmu_notifier validate path, hva range is recorded and then > > checked against in the mmu_notifier_retry_hva() of the page fault path. > > However, for the t

Re: [PULL v2 00/82] pci,pc,virtio: features, tests, fixes, cleanups

2022-11-03 Thread Ani Sinha
On Fri, Nov 4, 2022 at 02:02 Michael S. Tsirkin wrote: > On Thu, Nov 03, 2022 at 11:14:21PM +0530, Ani Sinha wrote: > > > > > > On Thu, Nov 3, 2022 at 23:11 Daniel P. Berrangé > wrote: > > > > On Thu, Nov 03, 2022 at 10:26:26PM +0530, Ani Sinha wrote: > > > On Thu, Nov 3, 2022 at 10:18 P

[PATCH v3 0/2] target/loongarch: Fix emulation of float-point disable exception

2022-11-03 Thread Rui Wang
v3: target/loongarch: Adjust the layout of hardware flags bit fields target/loongarch: Fix emulation of float-point disable exception target/loongarch/cpu.c| 2 ++ target/loongarch/cpu.h| 11 +- .../loongarch/insn_trans/trans_farith.c.inc

[PATCH v3 2/2] target/loongarch: Fix emulation of float-point disable exception

2022-11-03 Thread Rui Wang
We need to emulate it to generate a floating point disable exception when CSR.EUEN.FPE is zero. Reviewed-by: Richard Henderson Reviewed-by: Song Gao Signed-off-by: Rui Wang --- target/loongarch/cpu.c| 2 ++ target/loongarch/cpu.h| 2 ++ .../loo

[PATCH v3 1/2] target/loongarch: Adjust the layout of hardware flags bit fields

2022-11-03 Thread Rui Wang
Suggested-by: Richard Henderson Reviewed-by: Song Gao Signed-off-by: Rui Wang --- target/loongarch/cpu.h | 9 - target/loongarch/insn_trans/trans_privileged.c.inc | 2 +- target/loongarch/translate.c | 6 +- 3 files changed, 14 inser

Re: [PATCH] qom.json: default the prealloc-threads to smp-cpus

2022-11-03 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 3/11/22 11:47, Zhenyu Zhang wrote: >> Since the amount of prealloc-threads to smp-cpus is >> defaulted in hostmem, so sync this information. Has this always defaulted to smp-cpus, or did this change along the way? >> Signed-off-by: Zhenyu Zhang >> --- >> q

Re: [RFC v4 3/3] virtio-blk: add some trace events for zoned emulation

2022-11-03 Thread Sam Li
Philippe Mathieu-Daudé 于2022年11月3日周四 05:21写道: > > Hi, > > On 30/10/22 10:32, Sam Li wrote: > > Signed-off-by: Sam Li > > --- > > hw/block/trace-events | 7 +++ > > hw/block/virtio-blk.c | 12 > > 2 files changed, 19 insertions(+) > > > > diff --git a/hw/block/trace-events b/

Re: [RFC v4 2/3] virtio-blk: add zoned storage emulation for zoned devices

2022-11-03 Thread Sam Li
Stefan Hajnoczi 于2022年11月3日周四 04:58写道: > > On Sun, Oct 30, 2022 at 05:32:41AM -0400, Sam Li wrote: > > This patch extends virtio-blk emulation to handle zoned device commands > > by calling the new block layer APIs to perform zoned device I/O on > > behalf of the guest. It supports Report Zone, fo

Re: [PATCH] gitlab-ci: split clang-user to avoid timeout

2022-11-03 Thread Thomas Huth
On 03/11/2022 22.23, Stefan Hajnoczi wrote: GitLab CI times out when the clang-user job takes over 1 hour. Oh, that's new to me ... is that a regression? Has something become slower? Or did we just add more stuff to the user builds recently? Anyway, if it's just taking a little bit longer th

Re: [PATCH v11 01/11] s390x: Register TYPE_S390_CCW_MACHINE properties as class properties

2022-11-03 Thread Thomas Huth
On 03/11/2022 18.01, Pierre Morel wrote: Signed-off-by: Pierre Morel --- hw/s390x/s390-virtio-ccw.c | 127 + 1 file changed, 72 insertions(+), 55 deletions(-) -EMISSINGPATCHDESCRIPTION ... please add some words *why* this is a good idea / necessary. Th

Re: [PATCH v3 4/4] hw/nvme: add polling support

2022-11-03 Thread Klaus Jensen
On Nov 3 21:19, Jinhao Fan wrote: > On 11/3/2022 8:10 PM, Klaus Jensen wrote: > > I agree that the spec is a little unclear on this point. In any case, in > > Linux, when the driver has decided that the sq tail must be updated, > > it will use this check: > > > >(new_idx - event_idx - 1) < (n

Re: [PULL 02/10] pci-bridge/cxl_downstream: Add a CXL switch downstream port

2022-11-03 Thread Thomas Huth
On 16/06/2022 18.57, Michael S. Tsirkin wrote: From: Jonathan Cameron Emulation of a simple CXL Switch downstream port. The Device ID has been allocated for this use. Signed-off-by: Jonathan Cameron Message-Id: <20220616145126.8002-3-jonathan.came...@huawei.com> Signed-off-by: Michael S. Tsir

Re: [PATCH v14 16/17] tests/qtest: netdev: test stream and dgram backends

2022-11-03 Thread Jason Wang
在 2022/11/3 17:33, Laurent Vivier 写道: On 10/28/22 07:04, Jason Wang wrote: 在 2022/10/21 17:09, Laurent Vivier 写道: Signed-off-by: Laurent Vivier Acked-by: Michael S. Tsirkin --- I got this: 63/63 ERROR:../tests/qtest/netdev-socket.c:139:test_stream_inet_ipv6: assertion failed (resp ==

<    1   2   3