[PATCH 09/16] hw/9pfs: Disable unsupported flags and features for Windows

From: Guohuai Shi Some flags and features are not supported on Windows, like mknod, readlink, file mode, etc. Update the codes for Windows. Signed-off-by: Guohuai Shi Signed-off-by: Bin Meng --- hw/9pfs/9p-util.h | 6 +++- hw/9pfs/9p.c | 90 ++---

Re: [PATCH] include/hw/scsi/scsi.h: Remove unused scsi_legacy_handle_cmdline() prototype

Le 13/10/2022 à 15:05, Peter Maydell a écrit : In commit 1454509726719e0933c80 we removed the function scsi_legacy_handle_cmdline() and all of its callers, but forgot to delete the prototype from the header function. Delete the prototype too. Signed-off-by: Peter Maydell --- include/hw/scsi/

[PATCH v2 09/43] hw/usb/hcd-uhci: Introduce TYPE_ defines for device models

Suggested-by: Mark Cave-Ayland Signed-off-by: Bernhard Beschow --- hw/i386/pc_piix.c | 3 ++- hw/i386/pc_q35.c | 13 +++-- hw/isa/piix4.c| 2 +- hw/usb/hcd-uhci.c | 16 hw/usb/hcd-uhci.h | 9 + 5 files changed, 27 insertions(+), 16 deletions(-) diff --gi

[Bug 1994002] [NEW] [SRU] migration was active, but no RAM info was set

Public bug reported: While live-migrating many instances concurrently, libvirt sometimes return internal error: migration was active, but no RAM info was set: ~~~ 2022-03-30 06:08:37.197 7 WARNING nova.virt.libvirt.driver [req-5c3296cf-88ee-4af6-ae6a-ddba99935e23 - - - - -] [instance: af339c99-

Re: [PATCH v3 2/4] hw/audio: fix tab indentation

Am 21.10.22 um 18:59 schrieb Amarjargal Gundjalam: The TABs should be replaced with spaces, to make sure that we have a consistent coding style with an indentation of 4 spaces everywhere. Resolves:https://gitlab.com/qemu-project/qemu/-/issues/370 Reviewed-by: Daniel P. Berrangé Signed-off-by:

[PATCH 2/2] accel/kvm: introduce begin/commit listener callbacks

These callback make sure that all vcpus are blocked before performing memslot updates, and resumed once we are finished. They rely on kvm support for KVM_KICK_ALL_RUNNING_VCPUS and KVM_RESUME_ALL_KICKED_VCPUS ioctls to respectively pause and resume all vcpus that are in KVM_RUN state. Signed-off-

Re: [PULL 0/2] M68k for 7.2 patches

Le 22/10/2022 à 11:17, Laurent Vivier a écrit : The following changes since commit 0529245488865038344d64fff7ee05864d3d17f6: Merge tag 'pull-target-arm-20221020' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2022-10-20 14:36:12 -0400) are available in the Git repository

Re: [PATCH] tests/qtest/ac97-test: add up-/downsampling tests

Hi On Mon, Oct 24, 2022 at 9:28 AM Volker Rümelin wrote: > Test if the audio subsystem can handle extreme up- and down- > sampling ratios like 44100/1 and 1/44100. For some time these > used to trigger QEMU aborts. The test was taken from > https://gitlab.com/qemu-project/qemu/-/issues/71 where

[PULL 0/2] M68k for 7.2 patches

u-m68k.git tags/m68k-for-7.2-pull-request for you to fetch changes up to 281ac13ecedf8bfe1b83e566f39cb5683e553cb6: m68k: write bootinfo as rom section and re-randomize on reboot (2022-10-24 10:47:14 +0200) Pull request m68k branc

Re: [PATCH v2 14/43] hw/intc/i8259: Introduce i8259 proxy "isa-pic"

Hi Bernhard, On 22/10/22 17:04, Bernhard Beschow wrote: Having an i8259 proxy allows for ISA PICs to be created and wired up in southbridges. This is especially interesting for PIIX3 for two reasons: First, the southbridge doesn't need to care about the virtualization technology used (KVM, TCG,

Re: [PATCH v2 0/4] Add a new backend for cryptodev

On 2022/10/8 16:50, Lei He wrote: v1 --> v2: - Fix compile errors when neither 'nettle' nor 'gcrypt' are enabled. - Trivial changes to error codes when neither 'nettle' nor 'gcrypt' are enabled. Hi, lei: Daniel has reviewed the crypto part of this patch(thanks a lot for Daniel), can you hel

[PATCH v3] target/i386: Fix calculation of LOCK NEG eflags

In sequence: --- lock negl -0x14(%rbp) pushf pop%rax --- %rax will obtain the wrong value becasue the "lock neg" calculates the wrong eflags. The "s->T0" is updated by the wrong value. You can use this to do some test: --- #include int main() { __volatile__ unsigned test = 0x2363a; __vo

[PULL 1/2] m68k: rework BI_VIRT_RNG_SEED as BI_RNG_SEED

From: "Jason A. Donenfeld" Following a change on the kernel side (see link), pass BI_RNG_SEED instead of BI_VIRT_RNG_SEED. This should have no impact on compatibility, as there will simply be no effect if it's an old kernel, which is how things have always been. We then use this as an opportunity

Re: [RFC PATCH v2 2/8] vdpa: Save emulated features list in vhost_vdpa

On Mon, Oct 24, 2022 at 4:14 AM Jason Wang wrote: > > On Fri, Oct 21, 2022 at 4:56 PM Eugenio Perez Martin > wrote: > > > > On Fri, Oct 21, 2022 at 4:57 AM Jason Wang wrote: > > > > > > On Thu, Oct 20, 2022 at 2:34 PM Eugenio Perez Martin > > > wrote: > > > > > > > > On Thu, Oct 20, 2022 at 6:2

Re: [PATCH] treewide: Remove the unnecessary space before semicolon

Hllo Bin Meng, I ACK the change for SJA1000. On Monday 24 of October 2022 09:28:02 Bin Meng wrote: > %s/return ;/return; > > Signed-off-by: Bin Meng > --- > > include/hw/elf_ops.h | 2 +- > hw/9pfs/9p.c | 2 +- > hw/dma/pl330.c | 2 +- > hw/net/can/can_sja

[PULL 2/2] m68k: write bootinfo as rom section and re-randomize on reboot

From: "Jason A. Donenfeld" Rather than poking directly into RAM, add the bootinfo block as a proper ROM, so that it's restored when rebooting the system. This way, if the guest corrupts any of the bootinfo items, but then tries to reboot, it'll still be restored back to normal as expected. Then,

Re: [PATCH] avocado: use sha1 for fc31 imgs to avoid first time re-download

On Sat, Oct 22, 2022 at 02:03:50PM -0300, Daniel Henrique Barboza wrote: > 'make check-avocado' will download any images that aren't present in the > cache via 'get-vm-images' in tests/Makefile.include. The target that > downloads fedora 31 images, get-vm-image-fedora-31, will use 'avocado > vmimag

Re: [PATCH v10 1/9] s390x/cpu topology: core_id sets s390x CPU topology

On 10/19/22 17:39, Pierre Morel wrote: On 10/18/22 18:43, Cédric Le Goater wrote: Hello Pierre, On 10/12/22 18:20, Pierre Morel wrote: In the S390x CPU topology the core_id specifies the CPU address and the position of the core withing the topology. Let's build the topology based on the cor

[PATCH 2/2] hw/ide/piix: Ignore writes of hardwired PCI command register bits

One method to enable PCI bus mastering for IDE controllers, often used by x86 firmware, is to write 0x7 to the PCI command register. Neither the PIIX 3/4 specifications nor actual PIIX 3 hardware (a Tyan S1686D system) permit setting the Memory Space Enable (MSE) bit, thus the command register wou

[Bug 1994002] Re: [SRU] migration was active, but no RAM info was set

The attachment "lp1994002-qemu-ussuri.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" ta

Re: [PATCH v3 2/2] hw/ide/piix: Ignore writes of hardwired PCI command register bits

> I guess this cna work but what I had in mind is much > simpler. Add an internal property (name starting with "x-") > enabling the buggy behaviour and set it in hw compat array. > If set - do not touch the wmask register. > > post load hooks are harder to reason about. Thanks again for the review

Re: [PATCH] treewide: Remove the unnecessary space before semicolon

On Mon, Oct 24, 2022 at 03:28:02PM +0800, Bin Meng wrote: > %s/return ;/return; > > Signed-off-by: Bin Meng ack for virtio trivial tree pls > --- > > include/hw/elf_ops.h | 2 +- > hw/9pfs/9p.c | 2 +- > hw/dma/pl330.c | 2 +- > hw/net/can/can_sja1000.c

Re: [PATCH] accel/tcg/tcg-accel-ops-rr: fix trivial typo

On 10/21/22 19:36, Matheus Tavares Bernardino wrote: > Signed-off-by: Matheus Tavares Bernardino > --- > accel/tcg/tcg-accel-ops-rr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c > index cc8adc2380..cc912df10

Re: [PATCH v3 1/2] qpci_device_enable: Allow for command bits hardwired to 0

Michael S. Tsirkin writes: > On Sun, Sep 25, 2022 at 09:37:58AM +, Lev Kujawski wrote: >> Devices like the PIIX3/4 IDE controller do not support certain modes >> of operation, such as memory space accesses, and indicate this lack of >> support by hardwiring the applicable bits to zero. Extend

[PATCH 1/2] qpci_device_enable: Allow for command bits hardwired to 0

Devices like the PIIX3/4 IDE controller do not support certain modes of operation, such as memory space accesses, and indicate this lack of support by hardwiring the applicable bits to zero. Extend the QEMU PCI device testing framework to accommodate such devices. * tests/qtest/libqos/pci.h: Add

Re: [PATCH v2] target/i386: Fix caculation of LOCK NEG eflags

On 2022/10/24 05:02, Philippe Mathieu-Daudé wrote: Typo "calculation" in subject. Thanks for the reminder. It's my fault. I will send V3 to fix this typo. Qi On 22/10/22 08:12, Qi Hu wrote: In sequence: --- lock negl -0x14(%rbp) pushf pop    %rax --- %rax will obtain the wrong value be

Re: [PATCH] ui: remove useless typecasts

On 10/22/22 16:12, Volker Rümelin wrote: > Commit 8f9abdf586 ("chardev: src buffer const for write functions") > changed the type of the second parameter of qemu_chr_be_write() > from uint8_t * to const uint8_t *. Remove the now useless type > casts from qemu_chr_be_write() function calls in ui/con

Re: [PATCH v2 2/2] util/log: Always send errors to logfile when daemonized

Paolo Bonzini writes: >> If we want to connect stdout/err to something when daemonized >> then lets either have a dedicated option for that, or simply >> tell apps not to use -daemonize and to take care of daemonzing >> themselves, thus having full control over stdout/err. The latter >> is wha

[PATCH] treewide: Remove the unnecessary space before semicolon

%s/return ;/return; Signed-off-by: Bin Meng --- include/hw/elf_ops.h | 2 +- hw/9pfs/9p.c | 2 +- hw/dma/pl330.c | 2 +- hw/net/can/can_sja1000.c | 2 +- hw/timer/renesas_cmt.c | 2 +- hw/timer/renesas_tmr.c | 8 hw/virtio/virtio-pc

Re: [PATCH] ui/gtk: prevent ui lock up when dpy_gl_update called again before current draw event occurs

On Sat, Oct 22, 2022 at 3:31 AM Dongwon Kim wrote: > A warning, "qemu: warning: console: no gl-unblock within" followed by > guest scanout lockup can happen if dpy_gl_update is called in a row > and the second call is made before gd_draw_event scheduled by the first > call is taking place. This i

[Bug 1994002] Re: [SRU] migration was active, but no RAM info was set

** Patch added: "lp1994002-qemu-ussuri.debdiff" https://bugs.launchpad.net/cloud-archive/+bug/1994002/+attachment/5626374/+files/lp1994002-qemu-ussuri.debdiff -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.

GTK clipboard implementation causing regression, falling through the cracks?

Hi all, the GTK clipboard implementation seems to be causing some stability issues (guest CPUs stuck), Gerd can you take a look? https://gitlab.com/qemu-project/qemu/-/issues/1150 Thanks, Claudio

Re: [PATCH v14 17/17] net: stream: add QAPI events to report connection state

Laurent Vivier writes: > The netdev reports NETDEV_STREAM_CONNECTED event when the backend > is connected, and NETDEV_STREAM_DISCONNECTED when it is disconnected. > > The NETDEV_STREAM_CONNECTED event includes the destination address. > > This allows a system manager like libvirt to detect when t

Re: [PATCH] treewide: Remove the unnecessary space before semicolon

On Mon, 24 Oct 2022 at 08:28, Bin Meng wrote: > > %s/return ;/return; > > Signed-off-by: Bin Meng > --- Reviewed-by: Peter Maydell thanks -- PMM

[PULL 12/23] tests/9p: simplify callers of treaddir()

Now as treaddir() is using a declarative approach, simplify the code of callers of this function. Signed-off-by: Christian Schoenebeck Message-Id: <7cec6f2c7011a481806c34908893b7282702a7a6.1664917004.git.qemu_...@crudebyte.com> --- tests/qtest/virtio-9p-test.c | 21 +++-- 1 file

[PULL 21/23] tests/9p: merge v9fs_tlink() and do_hardlink()

As with previous patches, unify those 2 functions into a single function v9fs_tlink() by using a declarative function arguments approach. Signed-off-by: Christian Schoenebeck Message-Id: --- tests/qtest/libqos/virtio-9p-client.c | 43 ++- tests/qtest/libqos/virtio-9p-cl

[PULL 03/23] 9pfs: use GHashTable for fid table

From: Linus Heckemann The previous implementation would iterate over the fid table for lookup operations, resulting in an operation with O(n) complexity on the number of open files and poor cache locality -- for every open, stat, read, write, etc operation. This change uses a hashtable for this

Re: [PATCH v2 7/8] hw/arm/virt: Fix devicetree warnings about the virtio-iommu node

On Fri, 21 Oct 2022 at 15:33, Jean-Philippe Brucker wrote: > > On Tue, Sep 27, 2022 at 04:35:25PM +0200, Eric Auger wrote: > > >> diff --git a/hw/arm/virt.c b/hw/arm/virt.c > > >> index 2de16f6324..5e16d54bbb 100644 > > >> --- a/hw/arm/virt.c > > >> +++ b/hw/arm/virt.c > > >> @@ -1372,14 +1372,15

[PULL 04/23] tests/9p: merge *walk*() functions

Introduce declarative function calls. There are currently 4 different functions for sending a 9p 'Twalk' request: v9fs_twalk(), do_walk(), do_walk_rqids() and do_walk_expect_error(). They are all doing the same thing, just in a slightly different way and with slightly different function arguments.

[PULL 14/23] tests/9p: simplify callers of tlopen()

Now as tlopen() is using a declarative approach, simplify the code of callers of this function. Signed-off-by: Christian Schoenebeck Message-Id: --- tests/qtest/virtio-9p-test.c | 43 +--- 1 file changed, 10 insertions(+), 33 deletions(-) diff --git a/tests/qte

[PULL 22/23] tests/9p: merge v9fs_tunlinkat() and do_unlinkat()

As with previous patches, unify those 2 functions into a single function v9fs_tunlinkat() by using a declarative function arguments approach. Signed-off-by: Christian Schoenebeck Message-Id: <1dea593edd464908d92501933c068388c01f1744.1664917004.git.qemu_...@crudebyte.com> --- tests/qtest/libqos/

[PULL 08/23] tests/9p: simplify callers of tattach()

Now as tattach() is using a declarative approach, simplify the code of callers of this function. Signed-off-by: Christian Schoenebeck Message-Id: <9b50e5b89a0072e84a9191d18c19a53546a28bba.1664917004.git.qemu_...@crudebyte.com> --- tests/qtest/virtio-9p-test.c | 19 --- 1 file ch

[PULL 06/23] tests/9p: merge v9fs_tversion() and do_version()

As with previous patches, unify functions v9fs_tversion() and do_version() into a single function v9fs_tversion() by using a declarative function arguments approach. Signed-off-by: Christian Schoenebeck Message-Id: <2d253491aaffd267ec295f056dda47456692cd0c.1664917004.git.qemu_...@crudebyte.com>

[PULL 00/23] 9p queue 2022-10-24

k/qemu.git tags/pull-9p-20221024 for you to fetch changes up to 3ce77865bf813f313cf79c00fd951bfc95a50165: tests/9p: remove unnecessary g_strdup() calls (2022-10-24 12:24:32 +0200) 9pfs: performance, Windows host prep, tests r

[PULL 13/23] tests/9p: convert v9fs_tlopen() to declarative arguments

Use declarative function arguments for function v9fs_tlopen(). Signed-off-by: Christian Schoenebeck Message-Id: <765ab515353c56f88f0a163631f626a44e9565d6.1664917004.git.qemu_...@crudebyte.com> --- tests/qtest/libqos/virtio-9p-client.c | 28 +++-- tests/qtest/libqos/virtio-9p

[PULL 02/23] tests/9p: split virtio-9p-test.c into tests and 9p client part

This patch is pure refactoring, it does not change behaviour. virtio-9p-test.c grew to 1657 lines. Let's split this file up between actual 9p test cases vs. 9p test client, to make it easier to concentrate on the actual 9p tests. Move the 9p test client code to a new unit virtio-9p-client.c, whic

[PULL 05/23] tests/9p: simplify callers of twalk()

Now as twalk() is using a declarative approach, simplify the code of callers of this function. Signed-off-by: Christian Schoenebeck Message-Id: <8b9d3c656ad43b6c953d6bdacd8d9f4c8e599b2a.1664917004.git.qemu_...@crudebyte.com> --- tests/qtest/virtio-9p-test.c | 92 +---

Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state

Markus Armbruster writes: > Cc: Stefano Brivio > > Laurent Vivier writes: > >> On 10/21/22 07:48, Markus Armbruster wrote: >>> Laurent Vivier writes: >>> The netdev reports NETDEV_STREAM_CONNECTED event when the backend is connected, and NETDEV_STREAM_DISCONNECTED when it is disconne

[PULL 19/23] tests/9p: merge v9fs_tlcreate() and do_lcreate()

As with previous patches, unify those 2 functions into a single function v9fs_tlcreate() by using a declarative function arguments approach. Signed-off-by: Christian Schoenebeck Message-Id: <4c01b2caa5f5b54a2020fc92701deadd2abf0571.1664917004.git.qemu_...@crudebyte.com> --- tests/qtest/libqos/v

[PULL 20/23] tests/9p: merge v9fs_tsymlink() and do_symlink()

As with previous patches, unify those 2 functions into a single function v9fs_tsymlink() by using a declarative function arguments approach. Signed-off-by: Christian Schoenebeck Message-Id: <563f3ad04fe596ce0ae1e2654d1d08237f18c830.1664917004.git.qemu_...@crudebyte.com> --- tests/qtest/libqos/v

[PULL 07/23] tests/9p: merge v9fs_tattach(), do_attach(), do_attach_rqid()

As with previous patches, unify those 3 functions into a single function v9fs_tattach() by using a declarative function arguments approach. Signed-off-by: Christian Schoenebeck Message-Id: --- tests/qtest/libqos/virtio-9p-client.c | 40 ++--- tests/qtest/libqos/virtio-9p-client.h |

[PULL 15/23] tests/9p: convert v9fs_twrite() to declarative arguments

Use declarative function arguments for function v9fs_twrite(). Signed-off-by: Christian Schoenebeck Message-Id: --- tests/qtest/libqos/virtio-9p-client.c | 38 --- tests/qtest/libqos/virtio-9p-client.h | 31 -- tests/qtest/virtio-9p-test.c |

Re: [PATCH v7 3/5] module: add Error arguments to module_load and module_load_qom

On 9/30/22 13:50, Markus Armbruster wrote: > Claudio Fontana writes: > >> On 9/28/22 13:31, Markus Armbruster wrote: >>> Claudio Fontana writes: >>> improve error handling during module load, by changing: bool module_load(const char *prefix, const char *lib_name); void module

[PULL 09/23] tests/9p: convert v9fs_tgetattr() to declarative arguments

Use declarative function arguments for function v9fs_tgetattr(). Signed-off-by: Christian Schoenebeck Message-Id: --- tests/qtest/libqos/virtio-9p-client.c | 32 ++- tests/qtest/libqos/virtio-9p-client.h | 30 +++-- tests/qtest/virtio-9p-test.c

Re: [PATCH v7 for-7.2 00/15] block: cleanup backing and file handling

Am 26.07.2022 um 22:11 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > That's the first part of > "[PATCH v5 00/45] Transactional block-graph modifying API", > updated and is fully reviewed by Hanna. > > v7: add r-bs and rebase on master Thanks, applied to the block branch. Kevin

Re: [PATCH v2] hw/mem/nvdimm: fix error message for 'unarmed' flag

On 23.10.22 21:58, Julia Suvorova wrote: In the ACPI specification [1], the 'unarmed' bit is set when a device cannot accept a persistent write. This means that when a memdev is read-only, the 'unarmed' flag must be turned on. The logic is correct, just changing the error message. [1] ACPI NFIT

[PULL 18/23] tests/9p: merge v9fs_tmkdir() and do_mkdir()

As with previous patches, unify those 2 functions into a single function v9fs_tmkdir() by using a declarative function arguments approach. Signed-off-by: Christian Schoenebeck Message-Id: --- tests/qtest/libqos/virtio-9p-client.c | 42 ++- tests/qtest/libqos/virtio-9p-c

[PULL 10/23] tests/9p: simplify callers of tgetattr()

Now as tgetattr() is using a declarative approach, simplify the code of callers of this function. Signed-off-by: Christian Schoenebeck Message-Id: <60c6a083f320b86f3172951445df7bbc895932e2.1664917004.git.qemu_...@crudebyte.com> --- tests/qtest/virtio-9p-test.c | 22 +++--- 1 fil

Re: [PULL 00/23] 9p queue 2022-10-24

0-20 > 14:36:12 -0400) > > are available in the Git repository at: > > https://github.com/cschoenebeck/qemu.git tags/pull-9p-20221024 > > for you to fetch changes up to 3ce77865bf813f313cf79c00fd951bfc95a50165: > > tests/9p: remove unnece

Re: [PATCH] treewide: Remove the unnecessary space before semicolon

On Monday, October 24, 2022 9:28:02 AM CEST Bin Meng wrote: > %s/return ;/return; > > Signed-off-by: Bin Meng > --- Reviewed-by: Christian Schoenebeck > > include/hw/elf_ops.h | 2 +- > hw/9pfs/9p.c | 2 +- > hw/dma/pl330.c | 2 +- > hw/net/can/can_sja10

[PULL 17/23] tests/9p: convert v9fs_tflush() to declarative arguments

Use declarative function arguments for function v9fs_tflush(). Signed-off-by: Christian Schoenebeck Message-Id: <91b7b154298c500d100b05137146c2905c3acdec.1664917004.git.qemu_...@crudebyte.com> --- tests/qtest/libqos/virtio-9p-client.c | 23 +++ tests/qtest/libqos/virtio-9p-c

Re: [PATCH] accel/tcg/tcg-accel-ops-rr: fix trivial typo

Le 21/10/2022 à 19:36, Matheus Tavares Bernardino a écrit : Signed-off-by: Matheus Tavares Bernardino --- accel/tcg/tcg-accel-ops-rr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c index cc8adc2380..cc912df108 1

[PULL 01/23] fsdev/virtfs-proxy-helper: Use g_mkdir()

From: Bin Meng Use g_mkdir() to create a directory on all platforms. Signed-off-by: Bin Meng Reviewed-by: Christian Schoenebeck Message-Id: <20220927110632.1973965-27-bmeng...@gmail.com> Signed-off-by: Christian Schoenebeck --- fsdev/virtfs-proxy-helper.c | 3 ++- 1 file changed, 2 insertion

[PULL 23/23] tests/9p: remove unnecessary g_strdup() calls

This is a leftover from before the recent function merge and refactoring patches: As these functions do not return control to the caller in between, it is not necessary to duplicate strings passed to them. Signed-off-by: Christian Schoenebeck Message-Id: <0f80141cde3904ed0591354059da49d1d60bcdb

Re: [PATCH] treewide: Remove the unnecessary space before semicolon

Le 24/10/2022 à 09:28, Bin Meng a écrit : %s/return ;/return; Signed-off-by: Bin Meng --- include/hw/elf_ops.h | 2 +- hw/9pfs/9p.c | 2 +- hw/dma/pl330.c | 2 +- hw/net/can/can_sja1000.c | 2 +- hw/timer/renesas_cmt.c | 2 +- hw/timer/ren

[PULL 11/23] tests/9p: convert v9fs_treaddir() to declarative arguments

Use declarative function arguments for function v9fs_treaddir(). Signed-off-by: Christian Schoenebeck Message-Id: --- tests/qtest/libqos/virtio-9p-client.c | 32 -- tests/qtest/libqos/virtio-9p-client.h | 33 +-- tests/qtest/virtio-9p-test.c

Re: [PATCH v6 09/14] target/arm: Don't shift attrs in get_phys_addr_lpae

On 24/10/22 07:18, Richard Henderson wrote: Leave the upper and lower attributes in the place they originate from in the descriptor. Shifting them around is confusing, since one cannot read the bit numbers out of the manual. Also, new attributes have been added which would alter the shifts. Re

Re: [PATCH v2] nbd/client: Use smarter assert

On 10/17/22 22:12, Eric Blake wrote: Assigning strlen() to a uint32_t and then asserting that it isn't too large doesn't catch the case of an input string 4G in length. Thankfully, the incoming strings can never be that large: if the export name or query is reflecting a string the client got from

Re: [PATCH v3 1/8] reset: allow registering handlers that aren't called by snapshot loading

(Cc'ing Markus for a QMP related question.) On Fri, 14 Oct 2022 at 03:17, Jason A. Donenfeld wrote: > > Snapshot loading only expects to call deterministic handlers, not > non-deterministic ones. So introduce a way of registering handlers that > won't be called when reseting for snapshots. > > Si

Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state

On Mon, 24 Oct 2022 13:00:09 +0200 Markus Armbruster wrote: > Markus Armbruster writes: > > > Cc: Stefano Brivio > > > > Laurent Vivier writes: > > > >> On 10/21/22 07:48, Markus Armbruster wrote: > >>> Laurent Vivier writes: > >>> > The netdev reports NETDEV_STREAM_CONNECTED even

[PULL 16/23] tests/9p: simplify callers of twrite()

Now as twrite() is using a declarative approach, simplify the code of callers of this function. Signed-off-by: Christian Schoenebeck Message-Id: <7f280ec6a1f9d8afed46567a796562c4dc28afa9.1664917004.git.qemu_...@crudebyte.com> --- tests/qtest/virtio-9p-test.c | 9 +++-- 1 file changed, 3 ins

Re: [PATCH v3 1/8] reset: allow registering handlers that aren't called by snapshot loading

On 10/24/22, Peter Maydell wrote: > (Cc'ing Markus for a QMP related question.) > > On Fri, 14 Oct 2022 at 03:17, Jason A. Donenfeld wrote: >> >> Snapshot loading only expects to call deterministic handlers, not >> non-deterministic ones. So introduce a way of registering handlers that >> won't b

Re: [PATCH] ui: remove useless typecasts

Le 22/10/2022 à 16:12, Volker Rümelin a écrit : Commit 8f9abdf586 ("chardev: src buffer const for write functions") changed the type of the second parameter of qemu_chr_be_write() from uint8_t * to const uint8_t *. Remove the now useless type casts from qemu_chr_be_write() function calls in ui/co

Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state

Stefano Brivio writes: > On Mon, 24 Oct 2022 13:00:09 +0200 > Markus Armbruster wrote: > >> Markus Armbruster writes: >> >> > Cc: Stefano Brivio >> > >> > Laurent Vivier writes: >> > >> >> On 10/21/22 07:48, Markus Armbruster wrote: >> >>> Laurent Vivier writes: >> >>> >> The net

Re: [PATCH v3 1/8] reset: allow registering handlers that aren't called by snapshot loading

Peter Maydell writes: > (Cc'ing Markus for a QMP related question.) > > On Fri, 14 Oct 2022 at 03:17, Jason A. Donenfeld wrote: >> >> Snapshot loading only expects to call deterministic handlers, not >> non-deterministic ones. So introduce a way of registering handlers that >> won't be called wh

[PATCH v2] kset: fix memory leak when kset_register() returns error

Inject fault while loading module, kset_register() may fail. If it fails, the name allocated by kobject_set_name() which is called before kset_register() is leaked, because refcount of kobject is hold in kset_init(). As a kset may be embedded in a larger structure which needs be freed in release()

Re: [PATCH v3 1/8] reset: allow registering handlers that aren't called by snapshot loading

On Mon, 24 Oct 2022 at 13:28, Markus Armbruster wrote: > > Peter Maydell writes: > > Markus: if we add a new value to the ShutdownCause enumeration, > > how annoying is it if we decide we don't want it later? I guess > > we can just leave it in the enum unused... (In this case we're > > using it

Re: [PATCH qemu.git] target/imx: reload cmp timer outside of the reload ptimer transaction

On Mon, 24 Oct 2022 at 13:37, Peter Maydell wrote: > > On Fri, 21 Oct 2022 at 20:18, ~axelheider wrote: > > > > From: Axel Heider > > > > Signed-off-by: Axel Heider > > --- > > See https://gitlab.com/qemu-project/qemu/-/issues/1263 > > When running the seL4 tests > > (https://docs.sel4.systems/

Re: [PATCH qemu.git] target/imx: reload cmp timer outside of the reload ptimer transaction

On Fri, 21 Oct 2022 at 20:18, ~axelheider wrote: > > From: Axel Heider > > Signed-off-by: Axel Heider > --- > See https://gitlab.com/qemu-project/qemu/-/issues/1263 > When running the seL4 tests > (https://docs.sel4.systems/projects/sel4test), on the sabrelight > platform the timer test fails (a

Re: [PATCH v3 1/8] reset: allow registering handlers that aren't called by snapshot loading

Peter Maydell writes: > On Mon, 24 Oct 2022 at 13:28, Markus Armbruster wrote: >> >> Peter Maydell writes: >> > Markus: if we add a new value to the ShutdownCause enumeration, >> > how annoying is it if we decide we don't want it later? I guess >> > we can just leave it in the enum unused... (I

Re: [PATCH 5/9] target/s390x: Use Int128 for return from TRE

On 21/10/22 09:30, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/s390x/helper.h | 2 +- target/s390x/tcg/mem_helper.c | 7 +++ target/s390x/tcg/translate.c | 7 +-- 3 files changed, 9 insertions(+), 7 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 3/9] target/s390x: Use Int128 for return from CLST

On 21/10/22 09:30, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/s390x/helper.h | 2 +- target/s390x/tcg/mem_helper.c | 11 --- target/s390x/tcg/translate.c | 8 ++-- 3 files changed, 11 insertions(+), 10 deletions(-) Reviewed-by: Philippe Mat

Re: [PATCH 7/9] tests/tcg/s390x: Add long-double.c

On 21/10/22 09:30, Richard Henderson wrote: Signed-off-by: Richard Henderson --- tests/tcg/s390x/long-double.c | 24 tests/tcg/s390x/Makefile.target | 1 + 2 files changed, 25 insertions(+) create mode 100644 tests/tcg/s390x/long-double.c Reviewed-by: Philippe

Re: [PATCH v3 16/26] MAINTAINERS: add features_to_c.sh to gdbstub files

On 20/10/22 13:51, Alex Bennée wrote: Signed-off-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé

[PATCH 26/29] target/openrisc: Always exit after mtspr npc

We have called cpu_restore_state asserting will_exit. Do not go back on that promise. This affects icount. Signed-off-by: Richard Henderson --- target/openrisc/sys_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_hel

[PATCH 19/29] target/sh4: Convert to tcg_ops restore_state_to_opc

Signed-off-by: Richard Henderson --- target/sh4/cpu.c | 16 target/sh4/translate.c | 10 -- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/target/sh4/cpu.c b/target/sh4/cpu.c index 56c50530da..453268392b 100644 --- a/target/sh4/cpu.c +++ b/target/s

[PATCH 07/29] target/hppa: Convert to tcg_ops restore_state_to_opc

Signed-off-by: Richard Henderson --- target/hppa/cpu.c | 19 +++ target/hppa/translate.c | 13 - 2 files changed, 19 insertions(+), 13 deletions(-) diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index e677ca09d4..55c190280e 100644 --- a/target/hppa/cpu.c +++

[PATCH 00/29] tcg: Fix x86 TARGET_TB_PCREL (#1269)

As per #1269, this affects NetBSD installer boot. The problem is that one of the x86 acpi callbacks modifies env->eip during an mmio store, which means that the tracking that translate.c does is thrown out of whack. Introduce a method to extract unwind data without the writeback to env. This isn

[PATCH 12/29] target/mips: Convert to tcg_ops restore_state_to_opc

Signed-off-by: Richard Henderson --- target/mips/tcg/tcg-internal.h | 3 +++ target/mips/cpu.c | 1 + target/mips/tcg/translate.c| 8 ++-- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/target/mips/tcg/tcg-internal.h b/target/mips/tcg/tcg-internal.h index 1d2

[PATCH 16/29] target/riscv: Convert to tcg_ops restore_state_to_opc

Signed-off-by: Richard Henderson --- target/riscv/cpu.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index e6d9c706bb..d14e95c9dc 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -503,10 +503,14 @@ static bool risc

[PATCH 17/29] target/rx: Convert to tcg_ops restore_state_to_opc

Signed-off-by: Richard Henderson --- target/rx/cpu.c | 10 ++ target/rx/translate.c | 6 -- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/target/rx/cpu.c b/target/rx/cpu.c index 2f28099723..9003c6e9fe 100644 --- a/target/rx/cpu.c +++ b/target/rx/cpu.c @@ -47,6

Re: [PATCH 2/9] target/s390x: Use a single return for helper_divs64/u64

On 21/10/22 09:29, Richard Henderson wrote: Pack the quotient and remainder into a single Int128. Use the divu128 primitive to remove the cpu_abort on 32-bit hosts. This is the first use of Int128 as a return value. Signed-off-by: Richard Henderson --- target/s390x/helper.h | 4 ++--

[PATCH 24/29] accel/tcg: Introduce cpu_unwind_state_data

Add a way to examine the unwind data without actually restoring the data back into env. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 13 accel/tcg/translate-all.c | 68 ++- 2 files changed, 58 insertions(+), 23 deletions(-) diff -

[PATCH 21/29] target/tricore: Convert to tcg_ops restore_state_to_opc

Signed-off-by: Richard Henderson --- target/tricore/cpu.c | 11 +++ target/tricore/translate.c | 6 -- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/target/tricore/cpu.c b/target/tricore/cpu.c index ab7a1e3a6d..2c54a2825f 100644 --- a/target/tricore/cpu.c +++

[PATCH 23/29] accel/tcg: Remove restore_state_to_opc function

All targets have been updated. Use the tcg_ops target hook exclusively, which allows the compat code to be removed. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 3 --- accel/tcg/translate-all.c | 16 ++-- 2 files changed, 2 insertions(+), 17 deletions(-) diff -

[Bug 1994002] Re: [SRU] migration was active, but no RAM info was set

If you need something from upstream QEMU, please use the new bug tracker here: https://gitlab.com/qemu-project/qemu/-/issues ** No longer affects: qemu -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1

[PATCH 29/29] accel/tcg: Remove reset_icount argument from cpu_restore_state_from_tb

The value passed is always true. Signed-off-by: Richard Henderson --- accel/tcg/translate-all.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index dd439b5e3c..9e7dd41795 100644 --- a/accel/tcg/trans

[PATCH] tests/tcg/nios2: Tweak 10m50-ghrd.ld

More closely follow the default linker script for nios2. This magically fixes a problem resolving .got relocs from the toolchain's libgcc.a. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1258 Signed-off-by: Richard Henderson --- tests/tcg/nios2/10m50-ghrd.ld | 14 +- 1 file

[PATCH 02/29] target/alpha: Convert to tcg_ops restore_state_to_opc

Signed-off-by: Richard Henderson --- target/alpha/cpu.c | 9 + target/alpha/translate.c | 6 -- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c index 979a629d59..270ae787b1 100644 --- a/target/alpha/cpu.c +++ b/target/alpha/

[PATCH 25/29] target/i386: Use cpu_unwind_state_data for tpr access

Avoid cpu_restore_state, and modifying env->eip out from underneath the translator with TARGET_TB_PCREL. There is some slight duplication from x86_restore_state_to_opc, but it's just a few lines. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1269 Signed-off-by: Richard Henderson --- t

  1   2   3   >