Re: [PULL 1/1] Revert "configure: build ROMs with container-based cross compilers"

Il mar 11 ott 2022, 21:29 Alex Bennée ha scritto: > This reverts commit 730fe750fba63023e294ff0acf0f874369f1946f. > > Unconditionally building all the bios for all arches was a little too > far too fast. > I would like to understand the issue better, because chances are that it is preexisting an

Re: [PATCH v5 11/18] tests/qtest: Support libqtest to build and run on Windows

Hi Bin On Thu, Oct 6, 2022 at 8:09 PM Bin Meng wrote: > From: Bin Meng > > At present the libqtest codes were written to depend on several > POSIX APIs, including fork(), kill() and waitpid(). Unfortunately > these APIs are not available on Windows. > > This commit implements the corresponding

Re: [PATCH] gitmodules: recurse by default

On Tue, Oct 11, 2022 at 06:32:40PM -0400, Michael S. Tsirkin wrote: > On Fri, Oct 07, 2022 at 12:09:40PM +0100, Daniel P. Berrangé wrote: > > On Fri, Oct 07, 2022 at 11:45:56AM +0100, Daniel P. Berrangé wrote: > > > On Fri, Oct 07, 2022 at 06:11:25AM -0400, Michael S. Tsirkin wrote: > > > > On Fri,

Re: [PATCH v5 12/18] tests/qtest: migration-test: Make sure QEMU process "to" exited after migration is canceled

Hi On Thu, Oct 6, 2022 at 8:12 PM Bin Meng wrote: > From: Xuzhou Cheng > > Make sure QEMU process "to" exited before launching another target > for migration in the test_multifd_tcp_cancel case. > > Signed-off-by: Xuzhou Cheng > Signed-off-by: Bin Meng > --- > > (no changes since v3) > > Chan

Re: [PATCH v2 3/7] util: Introduce ThreadContext user-creatable object

David Hildenbrand writes: >>> But note that due to dynamic library loading this example will not work >>> before we actually make use of thread_context_create_thread() in QEMU >>> code, because the type will otherwise not get registered. >> >> What do you mean exactly by "not work"? It's not "C

Re: [PATCH v2 4/7] util: Add write-only "node-affinity" property for ThreadContext

David Hildenbrand writes: > On 11.10.22 08:03, Markus Armbruster wrote: >> David Hildenbrand writes: >> >>> Let's make it easier to pin threads created via a ThreadContext to >>> all CPUs currently belonging to a given set of NUMA nodes -- which is the >>> common case. >>> >>> "node-affinity" i

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

On Okt 12 08:24, Hannes Reinecke wrote: > On 10/10/22 19:01, Daniel Wagner wrote: > > On Tue, May 11, 2021 at 06:12:47PM +0200, Hannes Reinecke wrote: > > > On 5/11/21 6:03 PM, Klaus Jensen wrote: > > > > On May 11 16:54, Hannes Reinecke wrote: > > > > > On 5/11/21 3:37 PM, Klaus Jensen wrote: > >

Re: [PATCH v8 2/8] KVM: Extend the memslot to support fd-based private memory

On Mon, Oct 10, 2022 at 04:25:07PM +0800, Chao Peng wrote: > On Sat, Oct 08, 2022 at 08:35:47PM +0300, Jarkko Sakkinen wrote: > > On Sat, Oct 08, 2022 at 07:15:17PM +0300, Jarkko Sakkinen wrote: > > > On Sat, Oct 08, 2022 at 12:54:32AM +0300, Jarkko Sakkinen wrote: > > > > On Fri, Oct 07, 2022 at 0

Re: [PULL 1/1] Revert "configure: build ROMs with container-based cross compilers"

On Wed, Oct 12, 2022 at 08:46:35AM +0200, Paolo Bonzini wrote: > Il mar 11 ott 2022, 21:29 Alex Bennée ha scritto: > > > This reverts commit 730fe750fba63023e294ff0acf0f874369f1946f. > > > > Unconditionally building all the bios for all arches was a little too > > far too fast. > > > > I would l

Re: [PATCH v2 3/7] util: Introduce ThreadContext user-creatable object

Thanks Markus! I just tested again, and get the same result as you. I figure my previous test was with the complete series. PATCH 5 appears to make it work. Suggest to say something like "The commit after next will make this work". I'll phrase it like " We'll wire this up next to make it wo

Re: [PATCH v2 4/7] util: Add write-only "node-affinity" property for ThreadContext

On 12.10.22 10:03, Markus Armbruster wrote: Acked-by: Markus Armbruster Thanks, I'll similarly adjust to use "host nodes" and "host CPUs". -- Thanks, David / dhildenb

[PATCH] target/i386: Switch back XFRM value

The previous patch wrongly replaced FEAT_XSAVE_XCR0_{LO|HI} with FEAT_XSAVE_XSS_{LO|HI} in CPUID(EAX=12,ECX=1):ECX, which made SGX enclave only supported SSE and x87 feature(xfrm=0x3). Fixes: 301e90675c3f ("target/i386: Enable support for XSAVES based features") Signed-off-by: Yang Zhong --- ta

[PATCH] tests/qtest/tpm: Clean up remainders of swtpm

After running "make check", there are remainders of the tpm tests left in the /tmp directory, slowly filling it up. Seems like "swtpm" leaves a ".lock" and a "tpm2-00.permall" file behind, so that the g_rmdir() calls on the temporary directories fail. Introduce a helper function to remove those lef

Re: [PATCH v2] gtk: Add show_menubar=on|off command line option.

Cc'ing maintainers. Doing that reduces the risk of maintainers missing your patch. You can use scripts/get_maintainer.pl to find them. Bryce Mills writes: > The patch adds "show_menubar" command line option for GTK UI similar to > "show_tabs". This option allows to hide menu bar initially, it

[PATCH] tests/unit/test-image-locking: Fix handling of temporary files

test-image-locking leaves some temporary files around - clean them up. While we're at it, test-image-locking is a unit test, so it should not use "qtest.*" for temporary file names. Give them better names instead, so that it clear where the temporary files come from. Signed-off-by: Thomas Huth --

Re: [PULL 1/1] Revert "configure: build ROMs with container-based cross compilers"

On 10/12/22 10:14, Daniel P. Berrangé wrote: Daniel, does building the TCG tests work for you? If not, I think we should just disable containers by default. I've never (knowingly) tried running TCG tests. IIUC, they are strictly an opt-in test needing explicit 'make check-tcg', so any container

Re: [PATCH] cirrus_vga: fix potential memory overflow

On Thu, Sep 29, 2022 at 08:23:52PM +0800, luzhipeng wrote: > From: lu zhipeng > > Signed-off-by: lu zhipeng > -copy_count = s->cirrus_srcptr_end - end_ptr; > +copy_count = MIN(s->cirrus_srcptr_end - end_ptr, > CIRRUS_BLTBUFSIZE); Added to patch queue. thanks,

Re: [PATCH] ui/gtk-egl: egl context needs to be unbound in the end of gd_egl_switch

On Wed, Sep 28, 2022 at 02:58:05PM -0700, Dongwon Kim wrote: > A thread often fails to bind an egl context to itself after guest VM is > rebooted because the context is still owned by another thread. It is not > very clear what condition makes this happen but this can be prevented > by unbinding th

Re: [PULL 1/1] Revert "configure: build ROMs with container-based cross compilers"

On Wed, Oct 12, 2022 at 10:59:54AM +0200, Paolo Bonzini wrote: > On 10/12/22 10:14, Daniel P. Berrangé wrote: > > > Daniel, does building the TCG tests work for you? If not, I think we > > > should > > > just disable containers by default. > > > > I've never (knowingly) tried running TCG tests. I

[PATCH] qgraph: implement stack as a linked list

The stack used to visit the graph is implemented as a fixed-size array, and the array is sized according to the maximum anticipated length of a path on the graph. However, the worst case for a depth-first search is to push all nodes on the graph, and in fact stack overflows have been observed in t

[PATCH] build: disable container-based cross compilers by default

Container-based cross compilers have some issues which were overlooked when they were only used for TCG tests, but are more visible since firmware builds try to use them: - Downloading and building containers as part of make adds a very long task to the build, unless you are on a fast network.

[PATCH 0/2] tcg/loongarch64: add neg tcg_op and direct jump support

Hi, This patch series add neg tcg_op and direct jump support into loongarch tcg backend. Qi Hu (2): tcg/loongarch64: Implement INDEX_op_neg_i{32,64} tcg/loongarch64: Add direct jump support tcg/loongarch64/tcg-insn-defs.c.inc | 3 ++ tcg/loongarch64/tcg-target.c.inc| 58 +

[PATCH 2/2] tcg/loongarch64: Add direct jump support

Similar to the ARM64, LoongArch has PC-relative instructions such as PCADDU18I. These instructions can be used to support direct jump for LoongArch. Additionally, if instruction "B offset" can cover the target address, "tb_target_set_jmp_target" will only patch the "B offset". Signed-off-by: Qi Hu

[PATCH 1/2] tcg/loongarch64: Implement INDEX_op_neg_i{32,64}

Signed-off-by: Qi Hu --- tcg/loongarch64/tcg-target.c.inc | 9 + tcg/loongarch64/tcg-target.h | 4 ++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/tcg/loongarch64/tcg-target.c.inc b/tcg/loongarch64/tcg-target.c.inc index a3debf6da7..f5a214a17f 100644 --- a/tcg/loo

[PATCH] tests/qtest/cxl-test: Remove temporary directories after testing

The cxl-test leaves some temporary directories behind. Let's clean them up now! Signed-off-by: Thomas Huth --- tests/qtest/cxl-test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qtest/cxl-test.c b/tests/qtest/cxl-test.c index cbe0fb549b..61f25a72b6 100644 --- a/tests/qtest/cxl-t

Re: [PATCH] tests/unit/test-image-locking: Fix handling of temporary files

Hi On Wed, Oct 12, 2022 at 1:03 PM Thomas Huth wrote: > test-image-locking leaves some temporary files around - clean > them up. While we're at it, test-image-locking is a unit test, > so it should not use "qtest.*" for temporary file names. Give > them better names instead, so that it clear whe

Re: [PATCH 1/2] tcg/loongarch64: Implement INDEX_op_neg_i{32,64}

Hi, On 2022/10/12 17:13, Qi Hu wrote: Signed-off-by: Qi Hu --- tcg/loongarch64/tcg-target.c.inc | 9 + tcg/loongarch64/tcg-target.h | 4 ++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/tcg/loongarch64/tcg-target.c.inc b/tcg/loongarch64/tcg-target.c.inc index

Re: [PATCH] tests/unit/test-image-locking: Fix handling of temporary files

On 12/10/2022 11.21, Marc-André Lureau wrote: Hi On Wed, Oct 12, 2022 at 1:03 PM Thomas Huth > wrote: test-image-locking leaves some temporary files around - clean them up. While we're at it, test-image-locking is a unit test, so it should not use "qtest.*"

Re: [PATCH] build: disable container-based cross compilers by default

On Wed, Oct 12, 2022 at 11:08:55AM +0200, Paolo Bonzini wrote: > Container-based cross compilers have some issues which were overlooked > when they were only used for TCG tests, but are more visible since > firmware builds try to use them: > > - Downloading and building containers as part of make

Re: [PATCH] target/i386: Switch back XFRM value

On Wed, 2022-10-12 at 04:26 -0400, Yang Zhong wrote: > The previous patch wrongly replaced FEAT_XSAVE_XCR0_{LO|HI} with > FEAT_XSAVE_XSS_{LO|HI} in CPUID(EAX=12,ECX=1):ECX, which made SGX ^ Nit: both ECX and EDX are wrongly set, but not only ECX. >

Re: [PATCH 00/20] tests/9p: introduce declarative function calls

On Dienstag, 4. Oktober 2022 22:56:44 CEST Christian Schoenebeck wrote: > This series converts relevant 9p (test) client functions to use named > function arguments. For instance > > do_walk_expect_error(v9p, "non-existent", ENOENT); > > becomes > > twalk({ > .client = v9p, .path

RE: [PATCH v2 0/2] vhost-user: Support vhost_dev_start

Michael, Don't forget to merge. Thanks! -Original Message- From: Yajun Wu Sent: Monday, September 5, 2022 12:58 PM To: Michael S. Tsirkin Cc: qemu-devel@nongnu.org; Parav Pandit Subject: RE: [PATCH v2 0/2] vhost-user: Support vhost_dev_start Michael, 7.1 released, please merge.

Re: [PATCH v2 3/7] util: Introduce ThreadContext user-creatable object

David Hildenbrand writes: > Thanks Markus! > >> I just tested again, and get the same result as you. I figure my >> previous test was with the complete series. >> PATCH 5 appears to make it work. Suggest to say something like "The >> commit after next will make this work". > > I'll phrase it li

Re: [PATCH] ui/gtk: Fix the implicit mouse ungrabbing logic

On Sat, Oct 08, 2022 at 11:01:16PM +0900, Akihiko Odaki wrote: > Although the grab menu item represents the tabbed displays, the old > implicit mouse ungrabbing logic changes the grab menu item even for > an untabbed display. > > Leave the grab menu item when implicitly ungrabbing mouse for an > u

Re: [PULL 1/1] Revert "configure: build ROMs with container-based cross compilers"

On 10/12/22 03:46, Paolo Bonzini wrote: Il mar 11 ott 2022, 21:29 Alex Bennée mailto:alex.ben...@linaro.org>> ha scritto: This reverts commit 730fe750fba63023e294ff0acf0f874369f1946f. Unconditionally building all the bios for all arches was a little too far too fast. I would

[PATCH] migration/channel-block: fix return value for qio_channel_block_{readv, writev}

in the error case. The documentation in include/io/channel.h states that -1 or QIO_CHANNEL_ERR_BLOCK should be returned upon error. Simply passing along the return value from the bdrv-functions has the potential to confuse the call sides. Non-blocking mode is not implemented currently, so -1 it is.

Re: [PATCH] gitmodules: recurse by default

On Wed, Oct 12, 2022 at 08:51:51AM +0100, Daniel P. Berrangé wrote: > On Tue, Oct 11, 2022 at 06:32:40PM -0400, Michael S. Tsirkin wrote: > > On Fri, Oct 07, 2022 at 12:09:40PM +0100, Daniel P. Berrangé wrote: > > > On Fri, Oct 07, 2022 at 11:45:56AM +0100, Daniel P. Berrangé wrote: > > > > On Fri,

Re: [PATCH 2/2] tcg/loongarch64: Add direct jump support

Hi, Thanks for the improvement! Some room for improvement though... On 2022/10/12 17:13, Qi Hu wrote: Similar to the ARM64, LoongArch has PC-relative instructions such as PCADDU18I. These instructions can be used to support direct jump for LoongArch. Additionally, if instruction "B offset" can

Re: [PATCH] migration/channel-block: fix return value for qio_channel_block_{readv, writev}

Am 12.10.22 um 13:19 schrieb Fiona Ebner: > in the error case. The documentation in include/io/channel.h states > that -1 or QIO_CHANNEL_ERR_BLOCK should be returned upon error. Simply > passing along the return value from the bdrv-functions has the > potential to confuse the call sides. Non-blocki

[PATCH v2 2/2] audio: improve out.voices test

Improve readability of audio out.voices test: If 1 is logged and set after positive test, 1 should be tested. Signed-off-by: Helge Konetzka Reviewed-by: Marc-André Lureau --- audio/audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audio/audio.c b/audio/audio.c index 8a

[PATCH v2 1/2] audio: fix in.voices test

Calling qemu with valid -audiodev ...,in.voices=0 results in an obsolete warning: audio: Bogus number of capture voices 0, setting to 0 This patch fixes the in.voices test. Signed-off-by: Helge Konetzka Reviewed-by: Marc-André Lureau --- audio/audio.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH v2 0/2] Fix audio voices tests

Changes for v2: * Sent by git send-email to keep correct format Fix to remove obsolete warning on -audiodev ...,in.voices=0 and improvement for better readability of audio out.voices test Helge Konetzka (2): audio: fix in.voices test audio: improve out.voices test audio/audio.c | 4 ++-- 1

Re: [PATCH 2/2] tcg/loongarch64: Add direct jump support

On 2022/10/12 19:34, WANG Xuerui wrote: +    tcg_insn_unit i1, i2; + +    ptrdiff_t offset = addr - jmp_rx; + +    if (offset == sextreg(offset, 0, 28)) { +    i1 = OPC_B | ((offset >> 18) & 0x3ff) | ((offset << 8) & 0x3fffc00); Use encode_sd10k16_insn instead. No need to juggle the bits yo

Re: [PATCH] migration/channel-block: fix return value for qio_channel_block_{readv, writev}

On Wed, Oct 12, 2022 at 01:19:35PM +0200, Fiona Ebner wrote: > in the error case. The documentation in include/io/channel.h states > that -1 or QIO_CHANNEL_ERR_BLOCK should be returned upon error. Simply > passing along the return value from the bdrv-functions has the > potential to confuse the cal

[RFC PATCH 1/4] docs/devel: add a maintainers section to development process

We don't currently have a clear place in the documentation to describe the rolls and responsibilities of a maintainer. Lets create one so we can. I've moved a few small bits out of other files to try and keep everything in one place. Signed-off-by: Alex Bennée --- docs/devel/code-of-conduct.rst

[RFC PATCH 2/4] docs/devel: make language a little less code centric

We welcome all sorts of patches. Signed-off-by: Alex Bennée --- docs/devel/submitting-a-patch.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst index fec33ce148..fb1673e974 100644 --- a/docs/d

[RFC PATCH 3/4] docs/devel: simplify the minimal checklist

The bullet points are quite long and contain process tips. Move those bits of the bullet to the relevant sections and link to them. Use a table for nicer formatting of the checklist. Signed-off-by: Alex Bennée --- docs/devel/submitting-a-patch.rst | 75 --- roms/qboot

[RFC PATCH 4/4] docs/devel: try and improve the language around patch review

It is important that contributors take the review process seriously and we collaborate in a respectful way while avoiding personal attacks. Try and make this clear in the language. Signed-off-by: Alex Bennée --- docs/devel/submitting-a-patch.rst | 16 +++- 1 file changed, 11 insertio

Re: [RFC PATCH 3/4] docs/devel: simplify the minimal checklist

On Wed, Oct 12, 2022 at 01:11:51PM +0100, Alex Bennée wrote: > The bullet points are quite long and contain process tips. Move those > bits of the bullet to the relevant sections and link to them. Use a > table for nicer formatting of the checklist. > > Signed-off-by: Alex Bennée > --- > docs/de

[RFC PATCH 0/4] docs/devel suggestions for discussion

Hi, This is an attempt to improve our processes documentation by: - adding an explicit section on maintainers - reducing the up-front verbiage in patch submission - emphasising the importance to respectful reviews I'm sure the language could be improved further so I humbly submit this RFC for

Re: [PULL 1/1] Revert "configure: build ROMs with container-based cross compilers"

Daniel Henrique Barboza writes: > On 10/12/22 03:46, Paolo Bonzini wrote: >> Il mar 11 ott 2022, 21:29 Alex Bennée > > ha scritto: >> This reverts commit 730fe750fba63023e294ff0acf0f874369f1946f. >> Unconditionally building all the bios for all arches was

Re: [PATCH] build: disable container-based cross compilers by default

Paolo Bonzini writes: > Container-based cross compilers have some issues which were overlooked > when they were only used for TCG tests, but are more visible since > firmware builds try to use them: We seem to have dropped our gating somewhere. Previously if a user did not have docker or podma

[PATCH v2 0/2] Refactoring: expand usage of TFR() macro

At the moment, TFR() macro has a vague name and is not used where it possibly could be. In order to make it more transparent and useful, it was decided to refactor it to make it closer to the similar one in glibc: TEMP_FAILURE_RETRY(). Now, macro evaluates into an expression and is named RETRY_ON_E

Re: [PATCH v2 3/7] util: Introduce ThreadContext user-creatable object

Thanks! I'm adding "Note that the CPU affinity of previously created threads will not get adjusted." and "In general, the interface behaves like pthread_setaffinity_np(): host CPU numbers that are currently not available are ignored; only host CPU numbers that are impossible with the curren

[PATCH v2 1/2] Refactoring: refactor TFR() macro to RETRY_ON_EINTR()

Rename macro name to more transparent one and refactor it to expression. Signed-off-by: Nikita Ivanov --- chardev/char-fd.c| 2 +- chardev/char-pipe.c | 8 +--- include/qemu/osdep.h | 8 +++- net/tap-bsd.c| 6 +++--- net/tap-linux.c | 2 +- net/tap-solaris.c| 8

[PATCH v2 2/2] error handling: Use RETRY_ON_EINTR() macro where applicable

There is a defined RETRY_ON_EINTR() macro in qemu/osdep.h which handles the same while loop. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/415 Signed-off-by: Nikita Ivanov --- block/file-posix.c| 37 - chardev/char-pty.c| 4 +--- hw/

Re: [PATCH] qemu-edid: Restrict input parameter -d to avoid division by zero

On Tue, Oct 11, 2022 at 05:12:16PM +0200, Sebastian Mitterle wrote: > A zero value for dpi will lead to a division by zero in qemu_edid_dpi_to_mm(). > Tested by runnig qemu-edid -dX, X = 0, 100. > > Resolves: qemu-project/qemu#1249 > > Suggested-by: Thomas Huth > Signed-off-by: Sebastian Mitterl

[PATCH v1] s390x/tod-kvm: don't save/restore the TOD in PV guests

Under PV, the guest's TOD clock is under control of the ultravisor and the hypervisor cannot change it. With upcoming kernel changes[1], the Linux kernel will reject QEMU's request to adjust the guest's clock in this case, so don't attempt to set the clock. This avoids the following warning messa

Re: [PATCH] tests/unit/test-image-locking: Fix handling of temporary files

On Wed, Oct 12, 2022 at 4:59 PM Thomas Huth wrote: > > test-image-locking leaves some temporary files around - clean > them up. While we're at it, test-image-locking is a unit test, > so it should not use "qtest.*" for temporary file names. Give > them better names instead, so that it clear where

Re: [PULL 1/1] Revert "configure: build ROMs with container-based cross compilers"

On 10/12/22 09:13, Alex Bennée wrote: Daniel Henrique Barboza writes: On 10/12/22 03:46, Paolo Bonzini wrote: Il mar 11 ott 2022, 21:29 Alex Bennée mailto:alex.ben...@linaro.org>> ha scritto: This reverts commit 730fe750fba63023e294ff0acf0f874369f1946f. Unconditionally building a

Re: [PATCH v2 00/11] iotests: use vm.cmd()

ping On 9/19/22 20:16, Vladimir Sementsov-Ogievskiy wrote: ping On 6/6/22 10:27, Vladimir Sementsov-Ogievskiy wrote: Hi all! Let's get rid of pattern result = self.vm.qmp(...) self.assert_qmp(result, 'return', {}) And switch to just self.vm.cmd(...) Supersedes: <20220408170

Re: [PATCH v7 for-7.2 00/15] block: cleanup backing and file handling

ping On 9/19/22 20:20, Vladimir Sementsov-Ogievskiy wrote: ping. Seems, all patches are reviewed On 7/26/22 23:11, Vladimir Sementsov-Ogievskiy wrote: Hi all! That's the first part of "[PATCH v5 00/45] Transactional block-graph modifying API", updated and is fully reviewed by Hanna. v7: add

Re: [PATCH] virtio: add VIRTQUEUE_ERROR QAPI event

ping On 9/19/22 22:48, Vladimir Sementsov-Ogievskiy wrote: For now we only log the vhost device error, when virtqueue is actually stopped. Let's add a QAPI event, which makes possible: - collect statistics of such errors - make immediate actions: take coredums or do some other debugging Th

Re: [PATCH 00/20] tests/9p: introduce declarative function calls

On Wed, 12 Oct 2022 12:00:40 +0200 Christian Schoenebeck wrote: > On Dienstag, 4. Oktober 2022 22:56:44 CEST Christian Schoenebeck wrote: > > This series converts relevant 9p (test) client functions to use named > > function arguments. For instance > > > > do_walk_expect_error(v9p, "non-exis

Re: [PATCH 3/5] hw/mem/cxl_type: Generalize CDATDsmas initialization for Memory Regions

On Tue, 11 Oct 2022 17:19:14 -0400 Gregory Price wrote: > This is a preparatory commit for enabling multiple memory regions within > a single CXL Type-3 device. We will need to initialize multiple CDAT > DSMAS regions (and subsequent DSLBIS, and DSEMTS entries), so generalize > the intialization

Re: [PATCH] build: disable container-based cross compilers by default

On 10/12/22 14:17, Alex Bennée wrote: Container-based cross compilers have some issues which were overlooked when they were only used for TCG tests, but are more visible since firmware builds try to use them: We seem to have dropped our gating somewhere. Previously if a user did not have docker

Re: ublk-qcow2: ublk-qcow2 is available

On Thu, 6 Oct 2022 at 06:14, Richard W.M. Jones wrote: > > On Tue, Oct 04, 2022 at 09:53:32AM -0400, Stefan Hajnoczi wrote: > > qemu-nbd doesn't use io_uring to handle the backend IO, > > Would this be fixed by your (not yet upstream) libblkio driver for > qemu? I was wrong, qemu-nbd has syntax t

Re: [PATCH v2 1/2] Refactoring: refactor TFR() macro to RETRY_ON_EINTR()

On Wed, Oct 12, 2022 at 4:29 PM Nikita Ivanov wrote: > Rename macro name to more transparent one and refactor > it to expression. > > Signed-off-by: Nikita Ivanov > Reviewed-by: Marc-André Lureau > --- > chardev/char-fd.c| 2 +- > chardev/char-pipe.c | 8 +--- > include/qemu/osdep

Re: [PATCH 0/3] iothread and irqfd support

On Fri, 26 Aug 2022 at 07:18, Jinhao Fan wrote: > > This patch series adds support for using a seperate iothread for NVMe > IO emulation, which brings the potential of applying polling. The > first two patches implements support for irqfd, which solves thread > safety problems for interrupt emulat

[PULL 00/16] qtest patches (and one unit test and one avocado fix)

Hi Stefan! The following changes since commit 1dcdc92c72af5311666df64f5f04d6600af262ed: Merge tag 'pull-hex-20221003' of https://github.com/quic/qemu into staging (2022-10-05 10:17:32 -0400) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2022-1

[PULL 05/16] tests/x86: Refactor hot unplug hd-geo-test

From: Michael Labiuk Moving common code to function. Signed-off-by: Michael Labiuk Message-Id: <20220929223547.1429580-4-michael.lab...@virtuozzo.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/qtest/hd-geo-test.c | 110 ++ 1 file change

[PULL 03/16] tests/x86: add helper qtest_qmp_device_del_send()

From: Michael Labiuk Move sending 'device_del' command to separate function. Function can be used in case of addition action is needed to start actual removing device after sending command. Signed-off-by: Michael Labiuk Message-Id: <20220929223547.1429580-2-michael.lab...@virtuozzo.com> Reviewe

Re: [PULL 1/1] Revert "configure: build ROMs with container-based cross compilers"

On 10/12/22 11:08, Daniel P. Berrangé wrote: - Tailor downloads wrt the target list configured This is already done. Where's the patch for that, I hadn't noticed it being posted yet ? Oh, I thought it was done already before the introduction of containers but only tests/tcg is filtered.

[PULL 06/16] tests/x86: Add 'q35' machine type to override-tests in hd-geo-test

From: Michael Labiuk Signed-off-by: Michael Labiuk Message-Id: <20220929223547.1429580-5-michael.lab...@virtuozzo.com> Signed-off-by: Thomas Huth --- tests/qtest/hd-geo-test.c | 97 +++ 1 file changed, 97 insertions(+) diff --git a/tests/qtest/hd-geo-test.c

[PULL 09/16] tests/x86: replace snprint() by g_strdup_printf() in drive_del-test

From: Michael Labiuk Using g_autofree char* and g_strdup_printf(...) instead of ugly snprintf on stack array. Signed-off-by: Michael Labiuk Message-Id: <20220929223547.1429580-8-michael.lab...@virtuozzo.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/qtest/drive_del-test.

[PULL 04/16] tests/x86: Add subtest with 'q35' machine type to device-plug-test

From: Michael Labiuk Configure pci bridge setting to plug pci device and unplug. Signed-off-by: Michael Labiuk Message-Id: <20220929223547.1429580-3-michael.lab...@virtuozzo.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/qtest/device-plug-test.c | 41 +

[PULL 01/16] qtest: "-display none" is set in qtest_init()

From: Juan Quintela So we don't need to set anywhere else. Signed-off-by: Juan Quintela [thuth: Drop changes in tests/qtest/fuzz/ since the fuzzers still need this] Message-Id: <20220902165126.1482-2-quint...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/bios-tables-test.c | 2 +

[PULL 07/16] tests/x86: Add 'q35' machine type to hotplug hd-geo-test

From: Michael Labiuk Add pci bridge setting to test hotplug. Duplicate tests for plugging scsi and virtio devices for q35 machine type. Signed-off-by: Michael Labiuk Message-Id: <20220929223547.1429580-6-michael.lab...@virtuozzo.com> Signed-off-by: Thomas Huth --- tests/qtest/hd-geo-test.c |

[PULL 08/16] tests/x86: Fix comment typo in drive_del-test

From: Michael Labiuk Signed-off-by: Michael Labiuk Message-Id: <20220929223547.1429580-7-michael.lab...@virtuozzo.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/qtest/drive_del-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/drive_del

[PULL 02/16] tests/migration: remove the unused local variable

From: dinglimin Remove the unused local variable "records". Signed-off-by: dinglimin Reviewed-by: Ján Tomko Message-Id: <20220928080555.2263-1-dingli...@cmss.chinamobile.com> Signed-off-by: Thomas Huth --- tests/migration/guestperf/engine.py | 1 - 1 file changed, 1 deletion(-) diff --git a

[PULL 11/16] tests/x86: Add 'q35' machine type to ivshmem-test

From: Michael Labiuk Configure pci bridge setting to test ivshmem on 'q35'. Signed-off-by: Michael Labiuk Message-Id: <20220929223547.1429580-10-michael.lab...@virtuozzo.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/qtest/ivshmem-test.c | 18 ++ 1 file ch

[PULL 13/16] qtest: start a VNC test

From: Marc-André Lureau This is some of the simplest test we could perform, it simply connects to the VNC server via passed-in socket FDs and checks the connection can be established. Another series will make this test work on Windows as well. As always, more tests can be added later! :) Signe

[PULL 12/16] tests/avocado: Add missing require_netdev('user') checks

From: Peter Maydell Some avocado tests fail if QEMU was built without libslirp. Add require_netdev('user') checks where necessary: These tests try to ping 10.0.2.2 and expect it to succeed: boot_linux_console.py:BootLinuxConsole.test_arm_emcraft_sf2 boot_linux_console.py:BootLinuxConsole.tes

[PULL 14/16] tests/qtest: migration-test: Avoid using hardcoded /tmp

From: Bin Meng This case was written to use hardcoded /tmp directory for temporary files. Update to use g_dir_make_tmp() for a portable implementation. Signed-off-by: Bin Meng Reviewed-by: Marc-André Lureau Message-Id: <20221006151927.2079583-5-bmeng...@gmail.com> Signed-off-by: Thomas Huth -

[PULL 10/16] tests/x86: Add 'q35' machine type to drive_del-test

From: Michael Labiuk Configure pci bridge setting to run tests on 'q35' machine type. Signed-off-by: Michael Labiuk Message-Id: <20220929223547.1429580-9-michael.lab...@virtuozzo.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/qtest/drive_del-test.c | 107 +

[PULL 16/16] tests/unit/test-image-locking: Fix handling of temporary files

test-image-locking leaves some temporary files around - clean them up. While we're at it, test-image-locking is a unit test, so it should not use "qtest.*" for temporary file names. Give them better names instead, so that it clear where the temporary files come from. Message-Id: <20221012085932.79

[PULL 15/16] tests/qtest: libqtest: Install signal handler via signal()

From: Bin Meng At present the codes uses sigaction() to install signal handler with a flag SA_RESETHAND. Such usage can be covered by the signal() API that is a simplified interface to the general sigaction() facility. Update to use signal() to install the signal handler, as it is available on W

Re: [PULL 0/1] testing: revert pc-bios build patch

Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH 0/3] iothread and irqfd support

On Okt 12 10:28, Stefan Hajnoczi wrote: > On Fri, 26 Aug 2022 at 07:18, Jinhao Fan wrote: > > > > This patch series adds support for using a seperate iothread for NVMe > > IO emulation, which brings the potential of applying polling. The > > first two patches implements support for irqfd, which so

Re: [RFC PATCH 0/4] docs/devel suggestions for discussion

On Wed, Oct 12, 2022 at 01:11:48PM +0100, Alex Bennée wrote: > Hi, > > This is an attempt to improve our processes documentation by: > > - adding an explicit section on maintainers > - reducing the up-front verbiage in patch submission > - emphasising the importance to respectful reviews > >

Re: [RFC PATCH 3/4] docs/devel: simplify the minimal checklist

On Wed, Oct 12, 2022 at 01:11:51PM +0100, Alex Bennée wrote: > The bullet points are quite long and contain process tips. Move those > bits of the bullet to the relevant sections and link to them. Use a > table for nicer formatting of the checklist. > > Signed-off-by: Alex Bennée > --- > docs/de

Re: [RFC PATCH 1/4] docs/devel: add a maintainers section to development process

On Wed, Oct 12, 2022 at 01:11:49PM +0100, Alex Bennée wrote: > We don't currently have a clear place in the documentation to describe > the rolls and responsibilities of a maintainer. Lets create one so we s/roll/role/ in the commit description and the patch. > can. I've moved a few small bits ou

Re: [PATCH v4 2/6] util: make do_send_recv work with partial send/recv

On Thu, Oct 06, 2022 at 03:36:53PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > According to msdn documentation and Linux man pages, send() should try > to send as much as possible in blocking mode, while recv() may return > earlier with a smaller available amount, we s

Re: [PATCH v4 6/6] tests/unit: make test-io-channel-command work on win32

On Thu, Oct 06, 2022 at 03:36:57PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This has been tested under msys2 & windows 11. I haven't tried to make > it work with other environments yet, but that should be enough to > validate the channel-command implementation anywa

Re: [PATCH v2 2/2] error handling: Use RETRY_ON_EINTR() macro where applicable

Hi On Wed, Oct 12, 2022 at 4:32 PM Nikita Ivanov wrote: > There is a defined RETRY_ON_EINTR() macro in qemu/osdep.h which > handles the same while loop. > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/415 > > Signed-off-by: Nikita Ivanov > Reviewed-by: Marc-André Lureau > --- >

Re: [PATCH v2 2/2] error handling: Use RETRY_ON_EINTR() macro where applicable

Hi, On Wed, Oct 12, 2022 at 8:32 PM Nikita Ivanov wrote: > > There is a defined RETRY_ON_EINTR() macro in qemu/osdep.h which > handles the same while loop. > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/415 > > Signed-off-by: Nikita Ivanov > --- > block/file-posix.c| 37 +

Re: [PATCH] build: disable container-based cross compilers by default

Paolo Bonzini writes: > On 10/12/22 14:17, Alex Bennée wrote: >>> Container-based cross compilers have some issues which were overlooked >>> when they were only used for TCG tests, but are more visible since >>> firmware builds try to use them: >> We seem to have dropped our gating somewhere. P

Re: [PATCH 0/3] iothread and irqfd support

On 10/12/2022 10:39 PM, Klaus Jensen wrote: I have been meaning to pick it up, but I got side-tracked. The polling performance drop needs to be address as we discussed offline. But the v4 looks pretty good and I can pick that up without the polling support for now. I've been using the v4 witho

[PATCH 3/4] qtest: Improve error messages when property can not be set right now

When you try to set qtest property "log" while the qtest object is active, the error message blames "insufficient permission": $ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio -chardev socket,id=chrqt0,path=qtest.socket,server=on,wait=off -object qtest,id=qt0,chardev=chrqt0,l

[PATCH 4/4] qerror: QERR_PERMISSION_DENIED is no longer used, drop

Signed-off-by: Markus Armbruster --- include/qapi/qmp/qerror.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h index 596fce0c54..87ca83b155 100644 --- a/include/qapi/qmp/qerror.h +++ b/include/qapi/qmp/qerror.h @@ -50,9 +50,6 @@ #define

  1   2   >