[PATCH 21/27] qapi run-state: Elide redundant has_FOO in generated C

2022-09-15 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/run-state.json. Said commit explains the tran

[PATCH 17/27] qapi pci: Elide redundant has_FOO in generated C

2022-09-15 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/pci.json. Said commit explains the transforma

[PATCH 19/27] qapi replay: Elide redundant has_FOO in generated C

2022-09-15 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/replay.json. Said commit explains the transfo

[PATCH 10/27] qapi crypto: Elide redundant has_FOO in generated C

2022-09-15 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/crypto.json. Said commit explains the transfo

[PATCH 16/27] qapi net: Elide redundant has_FOO in generated C

2022-09-15 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/net.json. Said commit explains the transforma

[PATCH 25/27] qapi ui: Elide redundant has_FOO in generated C

2022-09-15 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/ui.json. Said commit explains the transformat

[PATCH 08/27] qapi block: Elide redundant has_FOO in generated C

2022-09-15 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/block*.json. Said commit explains the transfo

[PATCH 23/27] qapi tpm: Elide redundant has_FOO in generated C

2022-09-15 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/tpm.json. Said commit explains the transforma

Re: [PATCH 23/27] qapi tpm: Elide redundant has_FOO in generated C

2022-09-15 Thread Stefan Berger
On 9/15/22 16:43, Markus Armbruster wrote: The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qap

[PATCH 13/27] qapi machine: Elide redundant has_FOO in generated C

2022-09-15 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/machine*.json. Said commit explains the trans

[PATCH 06/27] qapi acpi: Elide redundant has_FOO in generated C

2022-09-15 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/acpi.py. Said commit explains the transformat

[PATCH 26/27] qapi qga: Elide redundant has_FOO in generated C

2022-09-15 Thread Markus Armbruster
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qga/qapi-schema.json. Said commit explains the tra

[PATCH v2] virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events.

2022-09-15 Thread Venu Busireddy
Section 5.6.6.3 of VirtIO specification states, "Events will also be reported via sense codes..." However, no sense data is sent when VIRTIO_SCSI_EVT_RESET_RESCAN or VIRTIO_SCSI_EVT_RESET_REMOVED events are reported (when disk hotplug/hotunplug events occur). SCSI layer on Solaris depends on this s

Re: [PATCH 0/7] nsis: gitlab-ci: Improve QEMU Windows installer packaging

2022-09-15 Thread Bin Meng
On Thu, Sep 8, 2022 at 9:28 PM Bin Meng wrote: > > At present packaging the required DLLs of QEMU executables is a > manual process, and error prone. > > Improve scripts/nsis.py by adding a logic to automatically package > required DLLs of QEMU executables. > > 'make installer' is tested in the cr

RE: [RFC PATCH v2] gdbstub: only send stop-reply packets when allowed to

2022-09-15 Thread Brian Cain
> -Original Message- > From: Qemu-devel > On Behalf Of Matheus Tavares Bernardino ... > On Wed, 24 Aug 2022 at 14:51, Matheus Tavares Bernardino > wrote: > > > > Instead, let's change gdb_set_stop_cpu() to send stop messages only as a > > response to a previous GDB command, also making su

Re: [PATCH v2 1/8] target/riscv: debug: Determine the trigger type from tdata1.type

2022-09-15 Thread LIU Zhiwei
Reviewed-by: LIU Zhiwei Zhiwei On 2022/9/9 21:42, Bin Meng wrote: From: Frank Chang Current RISC-V debug assumes that only type 2 trigger is supported. To allow more types of triggers to be supported in the future (e.g. type 6 trigger, which is similar to type 2 trigger with additional fu

Re: [PATCH v2 2/8] target/riscv: debug: Introduce build_tdata1() to build tdata1 register content

2022-09-15 Thread LIU Zhiwei
Reviewed-by: LIU Zhiwei Zhiwei On 2022/9/9 21:42, Bin Meng wrote: From: Frank Chang Introduce build_tdata1() to build tdata1 register content, which can be shared among all types of triggers. Signed-off-by: Frank Chang Reviewed-by: Bin Meng [bmeng: moved RV{32,64}_DATA_MASK definition to

Re: [PATCH v2 4/8] target/riscv: debug: Restrict the range of tselect value can be written

2022-09-15 Thread LIU Zhiwei
Reviewed-by: LIU Zhiwei Zhiwei On 2022/9/9 21:42, Bin Meng wrote: From: Frank Chang The value of tselect CSR can be written should be limited within the range of supported triggers number. Signed-off-by: Frank Chang Reviewed-by: Bin Meng Signed-off-by: Bin Meng --- (no changes since v1)

Re: [PATCH v2 3/8] target/riscv: debug: Introduce tdata1, tdata2, and tdata3 CSRs

2022-09-15 Thread LIU Zhiwei
On 2022/9/9 21:42, Bin Meng wrote: From: Frank Chang Replace type2_trigger_t with the real tdata1, tdata2, and tdata3 CSRs, which allows us to support more types of triggers in the future. Signed-off-by: Frank Chang Reviewed-by: Bin Meng Signed-off-by: Bin Meng --- (no changes since v1)

Re: [PATCH v3 4/5] acpi/nvdimm: Implement ACPI NVDIMM Label Methods

2022-09-15 Thread Robert Hoo
On Fri, 2022-09-09 at 15:39 +0200, Igor Mammedov wrote: ... > looks more or less fine except of excessive use of named variables > which creates global scope variables. > > I'd suggest to store temporary buffers/packages in LocalX variales, > you should be able to do that for everything modulo > a

Re: [PATCH v2 5/8] target/riscv: debug: Introduce tinfo CSR

2022-09-15 Thread LIU Zhiwei
Reviewed-by: LIU Zhiwei Zhiwei On 2022/9/9 21:42, Bin Meng wrote: From: Frank Chang tinfo.info: One bit for each possible type enumerated in tdata1. If the bit is set, then that type is supported by the currently selected trigger. Signed-off-by: Frank Chang Reviewed-by: Bin Meng

Re: [PATCH 01/11] hw/ppc/meson: Allow e500 boards to be enabled separately

2022-09-15 Thread Bin Meng
On Thu, Sep 15, 2022 at 11:25 PM Bernhard Beschow wrote: > > Gives users more fine-grained control over what should be compiled into > QEMU. > > Signed-off-by: Bernhard Beschow > --- > configs/devices/ppc-softmmu/default.mak | 3 ++- > hw/ppc/Kconfig | 8 > hw/p

Re: [PATCH 02/11] hw/gpio/meson: Introduce dedicated config switch for hw/gpio/mpc8xxx

2022-09-15 Thread Bin Meng
On Thu, Sep 15, 2022 at 11:26 PM Bernhard Beschow wrote: > > Having a dedicated config switch makes dependency handling cleaner. > > Signed-off-by: Bernhard Beschow > --- > hw/gpio/Kconfig | 3 +++ > hw/gpio/meson.build | 2 +- > hw/ppc/Kconfig | 1 + > 3 files changed, 5 insertions(+),

Re: [PATCH v2 6/8] target/riscv: debug: Create common trigger actions function

2022-09-15 Thread LIU Zhiwei
Reviewed-by: LIU Zhiwei Zhiwei On 2022/9/9 21:42, Bin Meng wrote: From: Frank Chang Trigger actions are shared among all triggers. Extract to a common function. Signed-off-by: Frank Chang Reviewed-by: Bin Meng [bmeng: handle the DBG_ACTION_NONE case] Signed-off-by: Bin Meng --- Changes

Re: [PATCH v2 1/8] target/riscv: debug: Determine the trigger type from tdata1.type

2022-09-15 Thread LIU Zhiwei
On 2022/9/9 21:42, Bin Meng wrote: From: Frank Chang Current RISC-V debug assumes that only type 2 trigger is supported. To allow more types of triggers to be supported in the future (e.g. type 6 trigger, which is similar to type 2 trigger with additional functionality), we should determine

Re: [PATCH 03/11] docs/system/ppc/ppce500: Add heading for networking chapter

2022-09-15 Thread Bin Meng
On Thu, Sep 15, 2022 at 11:29 PM Bernhard Beschow wrote: > > The sudden change of topics is slightly confusing and makes the > networking information less visible. So separate the networking chapter > to improve comprehensibility. > > Signed-off-by: Bernhard Beschow > --- > docs/system/ppc/ppce5

Re: [PATCH 02/11] RISC-V: Adding T-Head CMO instructions

2022-09-15 Thread LIU Zhiwei
Reviewed-by: LIU Zhiwei Zhiwei On 2022/9/6 20:22, Christoph Muellner wrote: From: Christoph Müllner This patch adds support for the T-Head CMO instructions. To avoid interfering with standard extensions, decoder and translation are in its own T-Head specific files. Future patches should be a

Re: [PATCH 01/11] riscv: Add privilege level to DisasContext

2022-09-15 Thread LIU Zhiwei
Reviewed-by: LIU Zhiwei Zhiwei On 2022/9/6 20:22, Christoph Muellner wrote: From: Christoph Müllner This allows privileged instructions to check the required privilege level in the translation without calling a helper. Signed-off-by: Christoph Müllner --- target/riscv/translate.c | 4 +++

Re: [PATCH] keyval: Print types on merge inconsistency

2022-09-15 Thread Markus Armbruster
"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > When 'keyval_do_merge' checks consistency of types, if they mismatch > print the types so we get a hint of what's going on. > > e.g. > qemu-system-x86_64: Parameter 'memory' used inconsistently (qstring/qdict) > > Signed

Re: [PATCH v2 4/4] scripts: add script to compare compatible properties

2022-09-15 Thread Markus Armbruster
Maksim Davydov writes: > This script run QEMU to obtain compat_props of machines and default > values of different types and produce appropriate table. This table > can be used to compare machine types to choose the most suitable > machine. Also table in json or csv format should be used to check

Re: [PATCH 01/11] riscv: Add privilege level to DisasContext

2022-09-15 Thread Richard Henderson
On 9/6/22 14:22, Christoph Muellner wrote: From: Christoph Müllner This allows privileged instructions to check the required privilege level in the translation without calling a helper. Signed-off-by: Christoph Müllner --- target/riscv/translate.c | 4 1 file changed, 4 insertions(+)

Re: [PATCH 01/11] riscv: Add privilege level to DisasContext

2022-09-15 Thread Richard Henderson
On 9/16/22 08:00, Richard Henderson wrote: Or, keep the field, because it's usage will be more self-documentary, but copy the value from ctx->mmu_idx and add a comment. Or, add an inline function like static inline int priv_level(DisasContext *ctx) { #ifdef CONFIG_USER_ONLY return PRV_U; #

Re: [PATCH 04/11] hw/ppc/mpc8544ds: Add platform bus

2022-09-15 Thread Bin Meng
On Thu, Sep 15, 2022 at 11:29 PM Bernhard Beschow wrote: > > Models the real device more closely. Please describe the source (e.g.: I assume it's MPC8544DS board manual or something like that?) that describe such memory map for the platform bus. Is this the eLBC bus range that includes the NOR f

Re: [PATCH 05/11] hw/ppc/e500: Remove if statement which is now always true

2022-09-15 Thread Bin Meng
On Thu, Sep 15, 2022 at 11:34 PM Bernhard Beschow wrote: > > Now that the MPC8544DS board also has a platform bus, the if statement > was always true. > > Signed-off-by: Bernhard Beschow > --- > hw/ppc/e500.c | 30 ++ > hw/ppc/e500.h | 1 - > hw/ppc/e500pla

Re: [PATCH 01/11] riscv: Add privilege level to DisasContext

2022-09-15 Thread LIU Zhiwei
On 2022/9/16 14:00, Richard Henderson wrote: On 9/6/22 14:22, Christoph Muellner wrote: From: Christoph Müllner This allows privileged instructions to check the required privilege level in the translation without calling a helper. Signed-off-by: Christoph Müllner ---   target/riscv/transla

Re: [PATCH 06/11] hw/block/pflash_cfi01: Error out if device length isn't a power of two

2022-09-15 Thread Bin Meng
On Thu, Sep 15, 2022 at 11:26 PM Bernhard Beschow wrote: > > According to the JEDEC standard the device length is communicated to an > OS as an exponent (power of two). > > Signed-off-by: Bernhard Beschow > --- > hw/block/pflash_cfi01.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletion

Re: [PATCH 02/11] RISC-V: Adding T-Head CMO instructions

2022-09-15 Thread LIU Zhiwei
On 2022/9/6 20:22, Christoph Muellner wrote: From: Christoph Müllner This patch adds support for the T-Head CMO instructions. To avoid interfering with standard extensions, decoder and translation are in its own T-Head specific files. Future patches should be able to easily add additional T-H

Re: [PATCH v4 for 7.2 00/22] virtio-gpio and various virtio cleanups

2022-09-15 Thread Alex Bennée
Alex Bennée writes: > Hi, > > This is an update to the previous series which fixes the last few > niggling CI failures I was seeing. > >Subject: [PATCH v3 for 7.2 00/21] virtio-gpio and various virtio cleanups >Date: Tue, 26 Jul 2022 20:21:29 +0100 >Message-Id: <20220726192150.24351

<    1   2