回复: qemu-system-aach64: A deadloop in aio_poll

2022-09-05 Thread wang...@chinatelecom.cn
# virsh version Compiled against library: libvirt 7.0.0 Using library: libvirt 7.0.0 Using API: QEMU 7.0.0 Running hypervisor: QEMU 5.2.0 # cat /etc/redhat-release CentOS Linux release 8.3.2011 # uname -a Linux HS-22 5.10.106-4 #4 SMP Sat Apr 2 11:27:09 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux

[PATCH V3 3/3] hw/riscv: virt: Enable booting S-mode firmware from pflash

2022-09-05 Thread Sunil V L
To boot S-mode firmware payload like EDK2 from persistent flash storage, qemu needs to pass the flash address as the next_addr in fw_dynamic_info to the opensbi. When both -kernel and -pflash options are provided in command line, the kernel (and initrd if -initrd) will be copied to fw_cfg table. T

qemu-system-aach64: A deadloop in aio_poll

2022-09-05 Thread wang...@chinatelecom.cn
Hi: We found a deadloop in qemu-system-aarch64, the backtrace is: (gdb) Id Target Id Frame * 1Thread 0xb4bee010 (LWP 1616556) "qemu-system-aar" 0xb5d58d64 in __lll_lock_wait () from target:/lib64/libpthread.so.0 2Thread 0xf

Re: [PATCH] tests: unit: add NULL-pointer check

2022-09-05 Thread Markus Armbruster
Paolo Bonzini writes: > In CID 1432593, Coverity complains that the result of qdict_crumple() > might leak if it is not a dictionary. This is not a practical concern > since the test would fail immediately with a NULL pointer dereference > in qdict_size(). > > However, it is not nice to depend o

Re: [PATCH] tests: unit: simplify test-visitor-serialization list tests

2022-09-05 Thread Markus Armbruster
Paolo Bonzini writes: > test-visitor-serialization list tests is using an "if" to pick either the > first > element of the list or the next one. This was done presumably to mimic the > code that creates the list, which has to fill in either the head pointer > or the next pointer of the last ele

Re: [PATCH v3 10/15] vhost-net: vhost-kernel: introduce vhost_net_virtqueue_reset()

2022-09-05 Thread Jason Wang
On Mon, Sep 5, 2022 at 6:15 PM Kangjie Xu wrote: > > > 在 2022/9/5 16:03, Jason Wang 写道: > > > > 在 2022/8/25 16:08, Kangjie Xu 写道: > >> Introduce vhost_virtqueue_reset(), which can reset the specific > >> virtqueue in the device. Then it will unmap vrings and the desc > >> of the virtqueue. > >> >

Re: [PATCH v3 13/15] virtio-net: support queue reset

2022-09-05 Thread Jason Wang
On Tue, Sep 6, 2022 at 12:25 AM Kangjie Xu wrote: > > > 在 2022/9/5 16:30, Jason Wang 写道: > > > > 在 2022/8/25 16:08, Kangjie Xu 写道: > >> From: Xuan Zhuo > >> > >> virtio-net and vhost-kernel implement queue reset. > >> Queued packets in the corresponding queue pair are flushed > >> or purged. > >>

Re: [PATCH] tests: unit: simplify test-visitor-serialization list tests

2022-09-05 Thread Stefan Weil via
Am 05.09.22 um 13:00 schrieb Paolo Bonzini: test-visitor-serialization list tests is using an "if" to pick either the first element of the list or the next one. This was done presumably to mimic the code that creates the list, which has to fill in either the head pointer or the next pointer of t

Re: [PATCH v9 02/10] s390x/cpu topology: core_id sets s390x CPU topology

2022-09-05 Thread Nico Boehr
Quoting Pierre Morel (2022-09-02 09:55:23) [...] > diff --git a/hw/s390x/cpu-topology.c b/hw/s390x/cpu-topology.c > new file mode 100644 > index 00..a6ca006ec5 > --- /dev/null > +++ b/hw/s390x/cpu-topology.c [...] > +void s390_topology_new_cpu(int core_id) > +{ [...] > +socket_id = core

Re: [PATCH] tests: unit: add NULL-pointer check

2022-09-05 Thread Paolo Bonzini
Il mar 6 set 2022, 07:01 Markus Armbruster ha scritto: > Next, permit me a few words on writing tests. For me, a unit test fails > by crashing. Crashing with a nice message is optional. The more likely > the failure, the more useful is niceness. Complete niceness is > impossible --- if we cou

Re: [PATCH v2 00/11] Introduce new acpi/smbios python tests using biosbits

2022-09-05 Thread Ani Sinha
On Thu, Jul 14, 2022 at 6:54 PM Peter Maydell wrote: > > On Mon, 11 Jul 2022 at 10:34, Michael S. Tsirkin wrote: > > > > On Sun, Jul 10, 2022 at 10:30:03PM +0530, Ani Sinha wrote: > > > Changelog: > > > v2: > > > - a new class of python based tests introduced that is separate from > > > avocado

Re: [PULL v2 00/20] tcg patch queue

2022-09-05 Thread Richard Henderson
On 9/5/22 22:58, Stefan Hajnoczi wrote: The tsan (clang) build is broken: https://gitlab.com/qemu-project/qemu/-/jobs/2982480773 clang-10 -m64 -mcx16 -Ilibqemu-x86_64-linux-user.fa.p -I. -I.. -Itarget/i386 -I../target/i386 -I../common-user/host/x86_64 -I../linux-user/include/host/x86_64 -I../lin

<    1   2   3