Re: [PATCH 12/18] i386: reimplement AVX comparison helpers

2022-08-25 Thread Richard Henderson
On 8/25/22 15:14, Paolo Bonzini wrote: From: Paul Brook AVX includes additional a more extensive set of comparison predicates, some of some of which our softfloat implementation does not expose directly. Not quite right, that wording. floatN_compare is the more general operation, directly e

Re: [PATCH 13/18] i386: Dot product AVX helper prep

2022-08-25 Thread Richard Henderson
On 8/25/22 15:14, Paolo Bonzini wrote: From: Paul Brook Make the dpps and dppd helpers AVX-ready I can't see any obvious reason why dppd shouldn't work on 256 bit ymm registers, but both AMD and Intel agree that it's xmm only. Signed-off-by: Paul Brook Message-Id:<20220424220204.2493824-17-p..

Re: [PATCH 14/18] i386: Destructive FP helpers for AVX

2022-08-25 Thread Richard Henderson
On 8/25/22 15:14, Paolo Bonzini wrote: From: Paul Brook Perpare the horizontal atithmetic vector helpers for AVX These currently use a dummy Reg typed variable to store the result then assign the whole register. This will cause 128 bit operations to corrupt the upper half of the register, so re

Re: [PATCH v3 0/2] hw/nvme: add irqfd support

2022-08-25 Thread Jinhao Fan
at 4:14 AM, Klaus Jensen wrote: > From: Klaus Jensen > > This is a re-spin of Jinhao's irqfd support series that fixes msix > vector masking/unmasking to work correctly. > > I kept being bugged out about that msi route not getting updated, so I > hit the code into submission with a hammer. >

Re: [RFC 1/2] virtio: expose used buffers

2022-08-25 Thread Guo Zhi
- Original Message - > From: "jasowang" > To: "Guo Zhi" > Cc: "eperezma" , "sgarzare" , > "Michael Tsirkin" , > "qemu-devel@nongnu.org Developers" > Sent: Thursday, August 25, 2022 2:06:11 PM > Subject: Re: [RFC 1/2] virtio: expose used buffers > On Thu, Aug 18, 2022 at 11:13 PM Guo

[PATCH v2] disas/riscv.c: rvv: Add disas support for vector instructions

2022-08-25 Thread Yang Liu
Tested with https://github.com/ksco/rvv-decoder-tests Expected checkpatch errors for consistency and brevity reasons: ERROR: line over 90 characters ERROR: trailing statements should be on next line ERROR: braces {} are necessary for all arms of this statement Signed-off-by: Yang Liu --- disas

Re: [PATCH 4/5] virtio-net: Update virtio-net curr_queue_pairs in vdpa backends

2022-08-25 Thread Si-Wei Liu
Hi Jason, On 8/24/2022 7:53 PM, Jason Wang wrote: On Thu, Aug 25, 2022 at 8:38 AM Si-Wei Liu wrote: On 8/23/2022 9:27 PM, Jason Wang wrote: 在 2022/8/20 01:13, Eugenio Pérez 写道: It was returned as error before. Instead of it, simply update the corresponding field so qemu can send it in the

Re: [PATCH 4/5] virtio-net: Update virtio-net curr_queue_pairs in vdpa backends

2022-08-25 Thread Si-Wei Liu
On 8/24/2022 8:05 PM, Jason Wang wrote: On Thu, Aug 25, 2022 at 10:53 AM Jason Wang wrote: On Thu, Aug 25, 2022 at 8:38 AM Si-Wei Liu wrote: On 8/23/2022 9:27 PM, Jason Wang wrote: 在 2022/8/20 01:13, Eugenio Pérez 写道: It was returned as error before. Instead of it, simply update the co

Re: [PATCH v1 08/40] i386/tdx: Adjust the supported CPUID based on TDX restrictions

2022-08-25 Thread Xiaoyao Li
On 8/3/2022 3:33 PM, Chenyi Qiang wrote: On 8/2/2022 3:47 PM, Xiaoyao Li wrote: According to Chapter "CPUID Virtualization" in TDX module spec, CPUID bits of TD can be classified into 6 types: 1 | As configured | configu

Re: [PATCH 4/5] virtio-net: Update virtio-net curr_queue_pairs in vdpa backends

2022-08-25 Thread Si-Wei Liu
On 8/24/2022 11:19 PM, Eugenio Perez Martin wrote: On Thu, Aug 25, 2022 at 2:38 AM Si-Wei Liu wrote: On 8/23/2022 9:27 PM, Jason Wang wrote: 在 2022/8/20 01:13, Eugenio Pérez 写道: It was returned as error before. Instead of it, simply update the corresponding field so qemu can send it in t

Re: [PATCH v1 15/40] i386/tdx: Add property sept-ve-disable for tdx-guest object

2022-08-25 Thread Gerd Hoffmann
Hi, > For TD guest kernel, it has its own reason to turn SEPT_VE on or off. E.g., > linux TD guest requires SEPT_VE to be disabled to avoid #VE on syscall gap > [1]. Why is that a problem for a TD guest kernel? Installing exception handlers is done quite early in the boot process, certainly b

Re: [PATCH v2 0/4] hw/arm/virt: Improve address assignment for high memory regions

2022-08-25 Thread Gavin Shan
Hi Eric, On 8/24/22 6:06 PM, Eric Auger wrote: On 8/24/22 05:29, Gavin Shan wrote: On 8/15/22 4:29 PM, Gavin Shan wrote: There are three high memory regions, which are VIRT_HIGH_REDIST2, VIRT_HIGH_PCIE_ECAM and VIRT_HIGH_PCIE_MMIO. Their base addresses are floating on highest RAM address. Howe

[RESEND PATCH] virtio-pci: fix vector_irqfd leak in virtio_pci_set_guest_notifiers

2022-08-25 Thread leixiang
proxy->vector_irqfd did not free when set guest notifier failed. Signed-off-by: Lei Xiang Tested-by: Zeng Chi Suggested-by: Xie Ming --- hw/virtio/virtio-pci.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index c6b47a9c..4862f83b 100

[PATCH] hcd-ohci: Drop ohci_service_iso_td() if ed->head & OHCI_DPTR_MASK is zero

2022-08-25 Thread Qiang Liu
An abort happens in ohci_frame_boundary() when ohci->done is 0 [1]. ``` c static void ohci_frame_boundary(void *opaque) { // ... if (ohci->done_count == 0 && !(ohci->intr_status & OHCI_INTR_WD)) { if (!ohci->done) abort(); <- [1]

Re: [PATCH v3 0/2] hw/nvme: add irqfd support

2022-08-25 Thread Klaus Jensen
On Aug 26 10:03, Jinhao Fan wrote: > at 4:14 AM, Klaus Jensen wrote: > > > From: Klaus Jensen > > > > This is a re-spin of Jinhao's irqfd support series that fixes msix > > vector masking/unmasking to work correctly. > > > > I kept being bugged out about that msi route not getting updated, so

<    1   2   3