Re: [PATCH 0/1] Update vfio-user module to the latest

2022-08-07 Thread John Levon
On Fri, Aug 05, 2022 at 09:24:56AM +0100, Daniel P. Berrangé wrote: > > > For the RFC QEMU user space eBPF support, > > > https://lore.kernel.org/all/20220617073630.535914-6-chen.zh...@intel.com/T/ > > > Maybe introduce the libubpf.so as a subproject like libvfio-user.so is > > > more appropriate

Re: VGA hardware cursor query

2022-08-07 Thread Elliot Nunn
>> I want to give Mac OS 9 clients access to hardware cursor support, to improve >> responsiveness in absolute-cursor mode. >> Would it be acceptable to add a hardware cursor interface to the VGA device? >> And if so, can anyone advise on an appropriate register layout? >> This is an example of suc

Re: VGA hardware cursor query

2022-08-07 Thread Mark Cave-Ayland
On 07/08/2022 12:47, Elliot Nunn wrote: I want to give Mac OS 9 clients access to hardware cursor support, to improve responsiveness in absolute-cursor mode. Would it be acceptable to add a hardware cursor interface to the VGA device? And if so, can anyone advise on an appropriate register layou

Re: VGA hardware cursor query

2022-08-07 Thread BALATON Zoltan
On Sun, 7 Aug 2022, Elliot Nunn wrote: I want to give Mac OS 9 clients access to hardware cursor support, to improve responsiveness in absolute-cursor mode. Would it be acceptable to add a hardware cursor interface to the VGA device? And if so, can anyone advise on an appropriate register layout?

Re: VGA hardware cursor query

2022-08-07 Thread BALATON Zoltan
On Sun, 7 Aug 2022, Mark Cave-Ayland wrote: On 07/08/2022 12:47, Elliot Nunn wrote: I want to give Mac OS 9 clients access to hardware cursor support, to improve responsiveness in absolute-cursor mode. Would it be acceptable to add a hardware cursor interface to the VGA device? And if so, ca

Re: [PATCH v4 11/22] hw/virtio: move vhd->started check into helper and add FIXME

2022-08-07 Thread Raphael Norwitz
On Tue, Aug 02, 2022 at 10:49:59AM +0100, Alex Bennée wrote: > The `started` field is manipulated internally within the vhost code > except for one place, vhost-user-blk via f5b22d06fb (vhost: recheck > dev state in the vhost_migration_log routine). Mark that as a FIXME > because it introduces a po

Re: [PATCH for-7.2 v2 11/20] hw/riscv: set machine->fdt in sifive_u_machine_init()

2022-08-07 Thread Alistair Francis
On Fri, Aug 5, 2022 at 7:49 PM Daniel Henrique Barboza wrote: > > This will enable support for 'dumpdtb' and 'info fdt' HMP commands for > the sifive_u machine. > > Cc: Alistair Francis > Cc: Bin Meng > Cc: Palmer Dabbelt > Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis

Re: [PATCH for-7.2 v2 12/20] hw/riscv: set machine->fdt in spike_board_init()

2022-08-07 Thread Alistair Francis
On Fri, Aug 5, 2022 at 8:08 PM Daniel Henrique Barboza wrote: > > This will enable support for 'dumpdtb' and 'info fdt' HMP commands for > the spike machine. > > Cc: Palmer Dabbelt > Cc: Alistair Francis > Cc: Bin Meng > Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis A

Re: [PATCH 1/5] target/riscv: Ignore the S and U letters when formatting ISA strings

2022-08-07 Thread Alistair Francis
On Sat, Aug 6, 2022 at 2:08 AM Conor Dooley wrote: > > From: Palmer Dabbelt > > The ISA strings we're providing from QEMU aren't actually legal RISC-V > ISA strings, as both S and U cannot exist as single-letter extensions > and must instead be multi-letter strings. We're still using the ISA > s

Re: [PATCH 3/5] hw/riscv: virt: Fix the plic's address cells

2022-08-07 Thread Alistair Francis
On Sat, Aug 6, 2022 at 2:11 AM Conor Dooley wrote: > > From: Conor Dooley > > When optional AIA PLIC support was added the to the virt machine, the > address cells property was removed leading the issues with dt-validate > on a dump from the virt machine: > /stuff/qemu/qemu.dtb: plic@c00: '#a

Re: [PATCH 2/5] hw/riscv: virt: fix uart node name

2022-08-07 Thread Alistair Francis
On Sat, Aug 6, 2022 at 2:01 AM Conor Dooley wrote: > > From: Conor Dooley > > "uart" is not a node name that complies with the dt-schema. > Change the node name to "serial" to ix warnings seen during > dt-validate on a dtbdump of the virt machine such as: > /stuff/qemu/qemu.dtb: uart@1000: $n

Re: [PATCH 4/5] hw/riscv: virt: fix syscon subnode paths

2022-08-07 Thread Alistair Francis
On Sat, Aug 6, 2022 at 2:10 AM Conor Dooley wrote: > > From: Conor Dooley > > The subnodes of the syscon have been added to the incorrect paths. > Rather than add them as subnodes, they were originally added to "/foo" > and a later patch moved them to "/soc/foo". Both are incorrect & they > shoul

Re: [PATCH 5/5] hw/core: fix platform bus node name

2022-08-07 Thread Alistair Francis
On Sat, Aug 6, 2022 at 2:02 AM Conor Dooley wrote: > > From: Conor Dooley > > "platform" is not a valid name for a bus node in dt-schema, so warnings > can be see in dt-validate on a dump of the riscv virt dtb: > > /stuff/qemu/qemu.dtb: platform@400: $nodename:0: 'platform@400' does > no

RE: [PATCH 0/2] vmgenid: add generation counter

2022-08-07 Thread Michael Kelley (LINUX)
From: Chalios, Babis Sent: Thursday, August 4, 2022 6:31 AM > > On 4/8/22 12:17, Chalios, Babis wrote: > > > > On 4/8/22 12:02, Daniel P. Berrangé wrote: > >> > >> On Thu, Aug 04, 2022 at 11:54:05AM +0200, Chalios, Babis wrote: > >>> Hi Daniel, > >>> > >>> On 3/8/22 18:26, Daniel P. Berrangé wrot

Re: [PATCH for-7.2 v2 14/20] qmp/hmp, device_tree.c: introduce dumpdtb

2022-08-07 Thread Alistair Francis
On Fri, Aug 5, 2022 at 7:59 PM Daniel Henrique Barboza wrote: > > To save the FDT blob we have the '-machine dumpdtb=' property. > With this property set, the machine saves the FDT in and exit. > The created file can then be converted to plain text dts format using > 'dtc'. > > There's nothing pa

Re: [PATCH v8 2/3] target/riscv: Add stimecmp support

2022-08-07 Thread Alistair Francis
On Thu, Aug 4, 2022 at 11:47 AM Atish Patra wrote: > > stimecmp allows the supervisor mode to update stimecmp CSR directly > to program the next timer interrupt. This CSR is part of the Sstc > extension which was ratified recently. > > Signed-off-by: Atish Patra Reviewed-by: Alistair Francis A

Re: [PATCH v8 3/3] target/riscv: Add vstimecmp support

2022-08-07 Thread Alistair Francis
On Thu, Aug 4, 2022 at 11:47 AM Atish Patra wrote: > > vstimecmp CSR allows the guest OS or to program the next guest timer > interrupt directly. Thus, hypervisor no longer need to inject the > timer interrupt to the guest if vstimecmp is used. This was ratified > as a part of the Sstc extension.

Re: [PATCH v6 4/8] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2022-08-07 Thread Sam Li
Sam Li 于2022年8月5日周五 15:58写道: > > By adding zone management operations in BlockDriver, storage controller > emulation can use the new block layer APIs including Report Zone and > four zone management operations (open, close, finish, reset). > > Add zoned storage commands of the device: zone_report(

Re: [PATCH] target/loongarch: Remove cpu_fcsr0

2022-08-07 Thread gaosong
On 2022/8/7 上午1:08, Richard Henderson wrote: All of the fpu operations are defined with TCG_CALL_NO_WG, but they all modify FCSR0. The most efficient way to fix this is to remove cpu_fcsr0, and instead use explicit load and store operations for the two instructions that manipulate that value.

Re: [PATCH v8 3/3] target/riscv: Add vstimecmp support

2022-08-07 Thread Weiwei Li
在 2022/8/4 上午9:42, Atish Patra 写道: vstimecmp CSR allows the guest OS or to program the next guest timer interrupt directly. Thus, hypervisor no longer need to inject the timer interrupt to the guest if vstimecmp is used. This was ratified as a part of the Sstc extension. Signed-off-by: Atish P

Re: [RFC] hw/nvme: Use irqfd to send interrupts

2022-08-07 Thread Jinhao Fan
at 12:35 PM, Jinhao Fan wrote: > static void nvme_irq_assert(NvmeCtrl *n, NvmeCQueue *cq) > { > if (cq->irq_enabled) { > if (msix_enabled(&(n->parent_obj))) { > +/* Initialize CQ irqfd */ > +if (!cq->irqfd_enabled && n->params.ioeventfd && cq->cqid != 0) { > +

Re: [PATCH for-7.2 v2 10/20] hw/ppc: set machine->fdt in spapr machine

2022-08-07 Thread David Gibson
On Fri, Aug 05, 2022 at 06:39:38AM -0300, Daniel Henrique Barboza wrote: > The pSeries machine never bothered with the common machine->fdt > attribute. We do all the FDT related work using spapr->fdt_blob. > > We're going to introduce HMP commands to read and save the FDT, which > will rely on set

Re: [PATCH for-7.2 v2 14/20] qmp/hmp, device_tree.c: introduce dumpdtb

2022-08-07 Thread David Gibson
On Fri, Aug 05, 2022 at 06:39:42AM -0300, Daniel Henrique Barboza wrote: > To save the FDT blob we have the '-machine dumpdtb=' property. > With this property set, the machine saves the FDT in and exit. > The created file can then be converted to plain text dts format using > 'dtc'. > > There's n

Re: [PATCH for-7.2 v2 01/20] hw/arm: do not free machine->fdt in arm_load_dtb()

2022-08-07 Thread David Gibson
On Fri, Aug 05, 2022 at 06:39:29AM -0300, Daniel Henrique Barboza wrote: > At this moment, arm_load_dtb() can free machine->fdt when > binfo->dtb_filename is NULL. If there's no 'dtb_filename', 'fdt' will be > retrieved by binfo->get_dtb(). If get_dtb() returns machine->fdt, as is > the case of mac

Re: [PATCH for-7.2 v2 09/20] hw/ppc: set machine->fdt in pnv_reset()

2022-08-07 Thread David Gibson
On Fri, Aug 05, 2022 at 09:31:11AM -0300, Daniel Henrique Barboza wrote: > > > On 8/5/22 08:03, Frederic Barrat wrote: > > > > > > On 05/08/2022 11:39, Daniel Henrique Barboza wrote: > > > This will enable support for 'dumpdtb' and 'info fdt' HMP commands for > > > all powernv machines. > > >

Re: [PATCH for-7.2 v2 17/20] device_tree.c: support remaining FDT prop types

2022-08-07 Thread David Gibson
On Fri, Aug 05, 2022 at 06:39:45AM -0300, Daniel Henrique Barboza wrote: > When printing a blob with 'dtc' using the '-O dts' option there are 3 > distinct data types being printed: strings, arrays of uint32s and > regular byte arrays. > > Previous patch added support to print strings. Let's add t

Re: [PATCH for-7.2 v2 16/20] device_tree.c: support string props in fdt_format_node()

2022-08-07 Thread David Gibson
On Fri, Aug 05, 2022 at 06:39:44AM -0300, Daniel Henrique Barboza wrote: > To support printing string properties in 'info fdt' we need to determine > whether a void data might contain a string. Oh... sorry, obviously I hadn't read these later patches when I complained about the command not printin

Re: [PATCH for-7.2 v2 15/20] qmp/hmp, device_tree.c: introduce 'info fdt' command

2022-08-07 Thread David Gibson
On Fri, Aug 05, 2022 at 06:39:43AM -0300, Daniel Henrique Barboza wrote: > Reading the FDT requires that the user saves the fdt_blob and then use > 'dtc' to read the contents. Saving the file and using 'dtc' is a strong > use case when we need to compare two FDTs, but it's a lot of steps if > you w

[PULL 1/4] pc-bios/s390-ccw: Fix booting with logical block size < physical block size

2022-08-07 Thread Thomas Huth
For accessing single blocks during boot, it's the logical block size that matters. (Physical block sizes are rather interesting e.g. for creating file systems with the correct alignment for speed reasons etc.). So the s390-ccw bios has to use the logical block size for calculating sector numbers du

[PULL 0/4] Fixes for QEMU 7.1

2022-08-07 Thread Thomas Huth
Hi! The following changes since commit c669f22f1a47897e8d1d595d6b8a59a572f9158c: Merge tag 'pull-la-20220805' of https://gitlab.com/rth7680/qemu into staging (2022-08-05 12:55:53 -0700) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2022-08-08

[PULL 3/4] tests/avocado: fix replay-linux test

2022-08-07 Thread Thomas Huth
From: Pavel Dovgalyuk Last line of the test is missing by accident. This patch fixes the script. Signed-off-by: Pavel Dovgalyuk Message-Id: <165943656662.362178.2086588841425038338.stgit@pasha-ThinkPad-X280> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- tests/avocado/rep

[PULL 4/4] tests/qemu-iotests/264: Allow up to 5s for the BLOCK_JOB_CANCEL event to arrive

2022-08-07 Thread Thomas Huth
It is possible to hit the assertTrue(delta_t < 2.0) on very loaded systems. Increase the value to 5.0 to ease the situation a little bit. Message-Id: <20220802123101.430757-1-th...@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Thomas Huth --- tests/qemu-iotests/264 | 2 +-

[PULL 2/4] pc-bios/s390-ccw: Update the s390-ccw.img with the block size fix

2022-08-07 Thread Thomas Huth
The new binary now gets the block size of virtio-blk devices right. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw.img | Bin 42608 -> 42608 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img index 39f9680a0ef1c57f8a0bac9e12ff77ce151

Re: [PATCH] vl: remove dead code in parse_memory_options()

2022-08-07 Thread Markus Armbruster
Paolo Bonzini writes: > mem_str will never be an empty string, because qemu_opt_get_size() fails > if it encounters one: > >$ ./qemu-system-x86_64 -m size= >qemu-system-x86_64: -m size=: Parameter size expects a non-negative number > below 2^64 >Optional suffix k, M, G, T, P or E mea

Re: [PATCH for-7.1] vl: fix [memory] section with -readconfig

2022-08-07 Thread Markus Armbruster
Paolo Bonzini writes: > On 8/5/22 15:40, Markus Armbruster wrote: >>> +loc_push_none(&loc); >>> +qemu_opts_loc_restore(opts); >>> + >>> prop = qdict_new(); >>> if (qemu_opt_get_size(opts, "size", 0) != 0) { >> >> This treats "size=0" like absent size. Before commit ce9d03fb

Re: [PATCH v2] vl: fix [memory] section with -readconfig

2022-08-07 Thread Markus Armbruster
Paolo Bonzini writes: > The -M memory.* options do not have magic applied to them than the -m > option, namely no "M" (for mebibytes) is tacked at the end of a > suffixless value for "-M memory.size". This sentence is confusing. Do you mean "like the -m option"? > This magic is performed by pa

Re: [PATCH] contrib/vhost-user-blk: Clean up deallocation of VuVirtqElement

2022-08-07 Thread Laurent Vivier
Le 30/06/2022 à 10:52, Markus Armbruster a écrit : We allocate VuVirtqElement with g_malloc() in virtqueue_alloc_element(), but free it with free() in vhost-user-blk.c. Harmless, but use g_free() anyway. One of the calls is guarded by a "not null" condition. Useless, because it cannot be null

Re: [PATCH 1/1] tests/qtest: add scenario for -readconfig handling

2022-08-07 Thread Thomas Huth
On 05/08/2022 13.55, Daniel P. Berrangé wrote: This test of -readconfig validates the last three regressions we have fixed with -readconfig: * Interpretation of memory size units as MiB not bytes * Allow use of [spice] * Allow use of [object] Good idea! Signed-off-by: Daniel P. Berrang

Re: [PATCH v2 2/7] multifd: modifying 'migrate' qmp command to add multifd socket on particular src and dest pair

2022-08-07 Thread Het Gala
On 02/08/22 1:23 pm, Markus Armbruster wrote: Het Gala writes: On 26/07/22 4:43 pm, Daniel P. Berrangé wrote: On Thu, Jul 21, 2022 at 07:56:15PM +, Het Gala wrote: i) Modified the format of the qemu monitor command : 'migrate' by adding a list, each element in the list consisting o

Re: [PATCH v5 5/8] blockdev: Add a new IF type IF_OTHER

2022-08-07 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Aug 04, 2022 at 05:30:40PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Thu, Aug 04, 2022 at 04:56:15PM +0200, Markus Armbruster wrote: >> >> Daniel P. Berrangé writes: >> >> >> >> > On Thu, Jul 28, 2022 at 10:46:35AM +0100, Pet

Re: [PATCH v2 12/20] ppc/ppc405: QOM'ify EBC

2022-08-07 Thread Cédric Le Goater
On 8/6/22 11:38, BALATON Zoltan wrote: On Fri, 5 Aug 2022, BALATON Zoltan wrote: On Fri, 5 Aug 2022, Peter Maydell wrote: On Fri, 5 Aug 2022 at 17:50, BALATON Zoltan wrote: This also allows to get the cpu without a link with something like: PPC4XX_MACHINE(current_machine /* or qdev_get_machi

Re: [PATCH for-7.2 v2 09/20] hw/ppc: set machine->fdt in pnv_reset()

2022-08-07 Thread Cédric Le Goater
On 8/5/22 11:39, Daniel Henrique Barboza wrote: This will enable support for 'dumpdtb' and 'info fdt' HMP commands for all powernv machines. I might have missed some emails but dumpdtb is already suppported : commit 8d4092614161 ("ppc/pnv: activate the "dumpdtb" option on the powernv machine")