Re: [PATCH v3 2/4] util/qemu-sockets: Enable unix socket support on Windows

2022-08-01 Thread Marc-André Lureau
Hi On Sat, Jul 30, 2022 at 6:52 PM Bin Meng wrote: > From: Bin Meng > > Support for the unix socket has existed both in BSD and Linux for the > longest time, but not on Windows. Since Windows 10 build 17063 [1], > the native support for the unix socket has come to Windows. Starting > this build

Re: [PATCH v4 6/7] vdpa: Add virtio-net mac address via CVQ at start

2022-08-01 Thread Eugenio Perez Martin
On Mon, Jul 25, 2022 at 11:32 AM Jason Wang wrote: > > > 在 2022/7/22 19:12, Eugenio Pérez 写道: > > This is needed so the destination vdpa device see the same state a the > > guest set in the source. > > > > Signed-off-by: Eugenio Pérez > > --- > > net/vhost-vdpa.c | 61 ++

Re: [PATCH v2 4/7] vdpa: Add asid parameter to vhost_vdpa_dma_map/unmap

2022-08-01 Thread Eugenio Perez Martin
On Mon, Jul 25, 2022 at 11:36 AM Jason Wang wrote: > > > 在 2022/7/22 21:43, Eugenio Pérez 写道: > > So the caller can choose which ASID is destined. > > > > No need to update the batch functions as they will always be called from > > memory listener updates at the moment. Memory listener updates wil

Re: [PATCH v3 3/4] chardev/char-socket: Update AF_UNIX for Windows

2022-08-01 Thread Marc-André Lureau
Hi On Sat, Jul 30, 2022 at 6:54 PM Bin Meng wrote: > From: Bin Meng > > Now that AF_UNIX has come to Windows, update the existing logic in > qemu_chr_compute_filename() and qmp_chardev_open_socket() for Windows. > > Signed-off-by: Bin Meng > Reviewed-by: Marc-André Lureau > --- > > (no change

Re: [PATCH for-7.1?] linux-user/riscv: Align signal frame to 16 bytes

2022-08-01 Thread Alistair Francis
On Sat, Jul 30, 2022 at 6:19 AM Richard Henderson wrote: > > Follow the kernel's alignment, as we already noted. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1093 > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > linux-user/riscv/signal.c | 4 +-

Re: [PATCH v3 4/4] tests/unit: Update test-io-channel-socket.c for Windows

2022-08-01 Thread Marc-André Lureau
Hi On Sat, Jul 30, 2022 at 6:53 PM Bin Meng wrote: > From: Bin Meng > > Enable the following 3 test cases for Windows when AF_UNIX is available: > > * test_io_channel_unix_sync > * test_io_channel_unix_async > * test_io_channel_unix_listen_cleanup > The test should runtime-check the avai

Re: [PATCH v4 2/7] vdpa: Extract vhost_vdpa_net_cvq_add from vhost_vdpa_net_handle_ctrl_avail

2022-08-01 Thread Eugenio Perez Martin
On Tue, Jul 26, 2022 at 4:50 AM Jason Wang wrote: > > > 在 2022/7/22 19:12, Eugenio Pérez 写道: > > So we can reuse to inject state messages. > > > > Signed-off-by: Eugenio Pérez > > --- > > net/vhost-vdpa.c | 74 ++-- > > 1 file changed, 47 insertions(

Re: [PATCH v3 2/3] job: introduce dump guest memory job

2022-08-01 Thread Marc-André Lureau
Hi On Sat, Jul 30, 2022 at 7:20 AM Hogan Wang via wrote: > There's no way to cancel the current executing dump process, lead to the > virtual machine manager daemon((e.g. libvirtd) cannot restore the dump > job after daemon restart. > > Introduce dump guest memory job type, and add an optional '

Re: [PATCH v2 7/7] vdpa: Always start CVQ in SVQ mode

2022-08-01 Thread Eugenio Perez Martin
On Tue, Jul 26, 2022 at 5:04 AM Jason Wang wrote: > > > 在 2022/7/22 21:43, Eugenio Pérez 写道: > > Isolate control virtqueue in its own group, allowing to intercept control > > commands but letting dataplane run totally passthrough to the guest. > > > > Signed-off-by: Eugenio Pérez > > --- > > hw

Re: [PATCH v4 08/17] dump: Split write of section headers and data and add a prepare step

2022-08-01 Thread Janosch Frank
On 7/29/22 19:16, Janis Schoetterl-Glausch wrote: On 7/26/22 11:22, Janosch Frank wrote: By splitting the writing of the section headers and (future) section data we prepare for the addition of a string table section and architecture sections. At the same time we move the writing of the section

Re: [PATCH v4 09/17] dump: Reorder struct DumpState

2022-08-01 Thread Janosch Frank
On 7/29/22 19:21, Janis Schoetterl-Glausch wrote: On 7/26/22 11:22, Janosch Frank wrote: Let's move ELF related members into one block and guest memory related ones into another to improve readability. Signed-off-by: Janosch Frank Reviewed-by: Richard Henderson Reviewed-by: Marc-André Lureau

Re: [PATCH v4 4/7] vdpa: add NetClientState->start() callback

2022-08-01 Thread Eugenio Perez Martin
On Tue, Jul 26, 2022 at 4:53 AM Jason Wang wrote: > > > 在 2022/7/22 19:12, Eugenio Pérez 写道: > > It allows per-net client operations right after device's successful > > start. > > > > Vhost-vdpa net will use it to add the CVQ buffers to restore the device > > status. > > > > Signed-off-by: Eugenio

[PATCH v4 3/3] dump: use jobs framework for dump guest memory

2022-08-01 Thread Hogan Wang via
There's no way to cancel the current executing dump process, lead to the virtual machine manager daemon((e.g. libvirtd) cannot restore the dump job after daemon restart. When caller pass the 'job-id' argument, create a job for dump process. And then caller can use job-cancel QMP command to cancel

[PATCH v4 1/3] dump: support cancel dump process

2022-08-01 Thread Hogan Wang via
Break saving pages or dump iterate when dump job in cancel state, make sure dump process exits as soon as possible. Signed-off-by: Hogan Wang --- dump/dump.c | 23 +++ include/sysemu/dump.h | 2 ++ 2 files changed, 25 insertions(+) diff --git a/dump/dump.c b/dump/

Re: [PATCH 2/2] docs: build-platforms: Clarify stance on minor releases and backports

2022-08-01 Thread Andrea Bolognani
On Tue, Jun 14, 2022 at 06:42:58AM -0700, Andrea Bolognani wrote: > On Wed, May 04, 2022 at 09:23:28AM +0100, Daniel P. Berrangé wrote: > > On Wed, May 04, 2022 at 01:01:03AM -0700, Andrea Bolognani wrote: > > > On Wed, Apr 20, 2022 at 09:18:47AM -0700, Andrea Bolognani wrote: > > > > On Wed, Apr 2

Re: [PATCH for-7.1 0/2] scsi-disk: fixes for block size crashes found by fuzzer

2022-08-01 Thread Paolo Bonzini
Queued, thanks. Paolo

[PATCH v4 2/3] job: introduce dump guest memory job

2022-08-01 Thread Hogan Wang via
There's no way to cancel the current executing dump process, lead to the virtual machine manager daemon((e.g. libvirtd) cannot restore the dump job after daemon restart. Introduce dump guest memory job type, and add an optional 'job-id' argument for dump-guest-memory QMP to make use of jobs framew

Re: [PATCH v3 0/2] migration-test: Allow test to run without uffd

2022-08-01 Thread Thomas Huth
On 28/07/2022 15.35, Peter Xu wrote: v2: - Fix warning in patch 1 [Thomas] - Collected R-b for Daniel Compare to v1, this added a new patch as reported by Thomas to (hopefully) allow auto-converge test to pass on some MacOS testbeds. Please review, thanks. Peter Xu (2): migration-test: Use

Re: [PATCH] ipmi:smbus: Add a check around a memcpy

2022-08-01 Thread Peter Maydell
On Mon, 1 Aug 2022 at 00:03, wrote: > > From: Corey Minyard > > In one case: > > memcpy(sid->inmsg + sid->inlen, buf, len); > > if len == 0 then sid->inmsg + sig->inlen can point to one past the inmsg > array if the array is full. We have to allow len == 0 due to some > vagueness in the spec,

Re: [PATCH] disas/nanomips: Convert nanoMIPS disassembler to C

2022-08-01 Thread Peter Maydell
On Mon, 1 Aug 2022 at 04:18, Vince Del Vecchio wrote: > > On Fri, 29 Jul 2022 at 10:18, Peter Maydell wrote: > > ... > > Is it possible to break this down into smaller pieces so it isn't one > > single enormous 5000 line patch ? > > > > I guess partial conversion is likely to run into compilatio

Re: virtio: why no full reset on virtio_set_status 0 ?

2022-08-01 Thread Alex Bennée
Claudio Fontana writes: > On 7/29/22 16:00, Claudio Fontana wrote: >> On 7/29/22 15:21, Alex Bennée wrote: >>> >>> Claudio Fontana writes: >>> On 7/29/22 12:13, Michael S. Tsirkin wrote: > On Fri, Jul 29, 2022 at 11:46:05AM +0200, Claudio Fontana wrote: @@ -2025,7 +2031,6 @@

Re: [PATCH for-7.1] hw/mips/malta: turn off x86 specific features of PIIX4_PM

2022-08-01 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On Fri, 29 Jul 2022 at 10:57, Igor Mammedov wrote: > > > > On Thu, 28 Jul 2022 16:12:34 +0100 > > Peter Maydell wrote: > > > > > On Thu, 28 Jul 2022 at 16:09, Dr. David Alan Gilbert > > > wrote: > > > > > > > > * Igor Mammedov (imamm...@redhat.

Re: [PATCH v4 11/17] dump/dump: Add section string table support

2022-08-01 Thread Janosch Frank
On 7/28/22 15:41, Marc-André Lureau wrote: Hi On Tue, Jul 26, 2022 at 6:26 PM Janosch Frank wrote: On 7/26/22 15:12, Marc-André Lureau wrote: On Tue, Jul 26, 2022 at 4:55 PM Janosch Frank wrote: On 7/26/22 13:25, Marc-André Lureau wrote: Hi On Tue, Jul 26, 2022 at 1:23 PM Janosch Fran

Re: [PATCH v3 2/4] util/qemu-sockets: Enable unix socket support on Windows

2022-08-01 Thread Daniel P . Berrangé
On Mon, Aug 01, 2022 at 11:09:24AM +0400, Marc-André Lureau wrote: > Hi > > On Sat, Jul 30, 2022 at 6:52 PM Bin Meng wrote: > > > From: Bin Meng > > > > Support for the unix socket has existed both in BSD and Linux for the > > longest time, but not on Windows. Since Windows 10 build 17063 [1],

Re: [PATCH for-7.1] hw/mips/malta: turn off x86 specific features of PIIX4_PM

2022-08-01 Thread Peter Maydell
On Mon, 1 Aug 2022 at 10:17, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.mayd...@linaro.org) wrote: > > On Fri, 29 Jul 2022 at 10:57, Igor Mammedov wrote: > > > > > > On Thu, 28 Jul 2022 16:12:34 +0100 > > > Peter Maydell wrote: > > > > Either: > > > > (1) we should be sure the vms

KVM call for 2022-08-09

2022-08-01 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: B

Re: VIRTIO_NET_F_MTU not negotiated

2022-08-01 Thread Eugenio Perez Martin
On Thu, Jul 28, 2022 at 7:51 AM Jason Wang wrote: > > On Thu, Jul 28, 2022 at 1:39 PM Eli Cohen wrote: > > > > > From: Jason Wang > > > Sent: Thursday, July 28, 2022 5:09 AM > > > To: Eli Cohen > > > Cc: Eugenio Perez Martin ; qemu-devel@nongnu.org; > > > Michael S. Tsirkin ; > > > virtualizat

[PULL for-7.1 1/3] hw/nvme: skip queue processing if notifier is cleared

2022-08-01 Thread Klaus Jensen
From: Klaus Jensen While it is safe to process the queues when they are empty, skip it if the event notifier callback was invoked spuriously. Reviewed-by: Keith Busch Reviewed-by: Jinhao Fan Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 8 ++-- 1 file changed, 6 insertions(+), 2 delet

[PULL for-7.1 0/3] hw/nvme fixes

2022-08-01 Thread Klaus Jensen
From: Klaus Jensen Hi, The following changes since commit 3916603e0c1d909e14e09d5ebcbdaa9c9e21adf3: Merge tag 'pull-la-20220729' of https://gitlab.com/rth7680/qemu into staging (2022-07-29 17:39:17 -0700) are available in the Git repository at: git://git.infradead.org/qemu-nvme.git tags/

[PULL for-7.1 3/3] hw/nvme: do not enable ioeventfd by default

2022-08-01 Thread Klaus Jensen
From: Klaus Jensen Do not enable ioeventfd by default. Let the feature mature a bit before we consider enabling it by default. Fixes: 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell updates") Reviewed-by: Keith Busch Reviewed-by: Jinhao Fan Signed-off-by: Klaus Jensen --- hw/nvme/ct

[PULL for-7.1 2/3] hw/nvme: unregister the event notifier handler on the main loop

2022-08-01 Thread Klaus Jensen
From: Klaus Jensen Make sure the notifier handler is unregistered in the main loop prior to cleaning it up. Fixes: 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell updates") Reviewed-by: Keith Busch Reviewed-by: Jinhao Fan Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 2 ++ 1 file

Re: [PATCH 0/2] migration: fix coverity nits

2022-08-01 Thread Peter Maydell
On Thu, 21 Jul 2022 at 12:52, Peter Maydell wrote: > > This patchset fixes four Coverity nits in the migration code. > The first patch is just adding an assert() to clue coverity in > that an array index must be in-bounds. The second adds an ULL > suffix to force a multiplication to be done at 64

migration test fails for aarch64 target (was: Re: [PULL 08/30] tests: Add dirty page rate limit test)

2022-08-01 Thread Thomas Huth
On 20/07/2022 13.19, Dr. David Alan Gilbert (git) wrote: From: Hyman Huang(黄勇) Add dirty page rate limit test if kernel support dirty ring, The following qmp commands are covered by this test case: "calc-dirty-rate", "query-dirty-rate", "set-vcpu-dirty-limit", "cancel-vcpu-dirty-limit" and "qu

Re: [PATCH v2 0/3] target/arm: Fix kvm probe of ID_AA64ZFR0

2022-08-01 Thread Peter Maydell
On Tue, 26 Jul 2022 at 06:03, Richard Henderson wrote: > > Our probing of this SVE register was done within an incorrect > vCPU environment, so that the id register was always RAZ. > > Changes for v2: > * Include the commit text I forgot. > * Fix svm thinko. > > > r~ Applied to target-arm.n

Re: migration test fails for aarch64 target (was: Re: [PULL 08/30] tests: Add dirty page rate limit test)

2022-08-01 Thread Peter Maydell
On Mon, 1 Aug 2022 at 11:41, Thomas Huth wrote: > > On 20/07/2022 13.19, Dr. David Alan Gilbert (git) wrote: > > From: Hyman Huang(黄勇) > > > > Add dirty page rate limit test if kernel support dirty ring, > > > > The following qmp commands are covered by this test case: > > "calc-dirty-rate", "que

Re: [PATCH v3 3/5] hw/core: use qemu_fdt_setprop_strings()

2022-08-01 Thread Peter Maydell
On Wed, 27 Jul 2022 at 23:39, Ben Dooks wrote: > > Change to using the qemu_fdt_setprop_strings() helper in > hw/core code. > > Signed-off-by: Ben Dooks > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 4/5] hw/mips: use qemu_fdt_setprop_strings()

2022-08-01 Thread Peter Maydell
On Wed, 27 Jul 2022 at 23:40, Ben Dooks wrote: > > Change to using qemu_fdt_setprop_strings() helper in hw/mips. > > Signed-off-by: Ben Dooks > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v3 5/5] hw/arm: change to use qemu_fdt_setprop_strings()

2022-08-01 Thread Peter Maydell
On Wed, 27 Jul 2022 at 23:44, Ben Dooks wrote: > > Change to using qemu_fdt_setprop_strings() instead of using > \0 separated string arrays. > > Signed-off-by: Ben Dooks > --- > hw/arm/boot.c | 8 +++--- > hw/arm/virt.c | 28 + > hw/arm/xlnx-versal-vi

Re: [PATCH] linux-user: Don't assume 0 is not a valid host timer_t value

2022-08-01 Thread Peter Maydell
On Mon, 25 Jul 2022 at 12:13, Daniel P. Berrangé wrote: > > On Mon, Jul 25, 2022 at 12:00:35PM +0100, Peter Maydell wrote: > > For handling guest POSIX timers, we currently use an array > > g_posix_timers[], whose entries are a host timer_t value, or 0 for > > "this slot is unused". When the gues

[PATCH] tests/qtest/migration-test: Run the dirty ring tests only with the x86 target

2022-08-01 Thread Thomas Huth
kvm_dirty_ring_supported() only checks whether the dirty ring support is available on the x86 host, but it ignores whether the target QEMU architecture is x86 or not. Thus the test_vcpu_dirty_limit() test currently fails with the assert((strcmp(arch, "x86_64") == 0)) statement in dirtylimit_start_v

Re: [PATCH 3/3] dump: support cancel dump process

2022-08-01 Thread Markus Armbruster
Kevin Wolf writes: > Am 28.07.2022 um 14:37 hat Marc-André Lureau geschrieben: >> Hi >> >> On Wed, Jul 27, 2022 at 6:02 PM Hogan Wang via >> wrote: >> >> > Break saving pages or dump iterate when dump job in cancel state, >> > make sure dump process exits as soon as possible. >> > >> > Signed-

Re: [PATCH for-7.1? 0/2] Re-enable ppc32 as a linux-user host

2022-08-01 Thread Lucas Mateus Martins Araujo e Castro
On 29/07/2022 17:44, Daniel Henrique Barboza wrote: On 7/29/22 14:21, Richard Henderson wrote: This is, technically, a regression from 6.2, so it's not implausible to apply before rc1.  Thoughts? In gitlab #1097 the author comments that: https://gitlab.com/qemu-project/qemu/-/issues/1097#n

Re: [PATCH v4 2/3] job: introduce dump guest memory job

2022-08-01 Thread Markus Armbruster
Hogan Wang writes: > There's no way to cancel the current executing dump process, lead to the > virtual machine manager daemon((e.g. libvirtd) cannot restore the dump > job after daemon restart. > > Introduce dump guest memory job type, and add an optional 'job-id' > argument for dump-guest-memor

Re: [PATCH] scsi-disk: support setting CD-ROM block size via device options.

2022-08-01 Thread John Millikin
Gentle ping -- this is my first time sending a patch for QEMU and it hasn't shown up in the qemu-devel mailing list web UI yet, so I can't tell whether the mail is being sent/received successfully. On Tue, Jul 26, 2022 at 12:42:06PM +0900, John Millikin wrote: > SunOS expects CD-ROM devices to hav

VGA hardware cursor query

2022-08-01 Thread Elliot Nunn
Dear all, I want to give Mac OS 9 clients access to hardware cursor support, to improve responsiveness in absolute-cursor mode. Would it be acceptable to add a hardware cursor interface to the VGA device? And if so, can anyone advise on an appropriate register layout? This is an example of such

[PATCH 00/19] ppc: QOM'ify 405 board

2022-08-01 Thread Cédric Le Goater
Hello, Here is large series QOM'ifying the PPC405 board. It introduces a new generic machine and SoC models, converts the current device models to QOM and populates the SoC. The process is quite mechanical without too much issues to handle. The noisy part is the initial patch introducing the SoC r

[PATCH 01/19] ppc/ppc405: Remove taihu machine

2022-08-01 Thread Cédric Le Goater
It has been deprecated since 7.0. Signed-off-by: Cédric Le Goater --- docs/about/deprecated.rst| 9 -- docs/system/ppc/embedded.rst | 1 - hw/ppc/ppc405_boards.c | 232 --- 3 files changed, 242 deletions(-) diff --git a/docs/about/deprecated.rst b/d

[PATCH 09/19] ppc/ppc405: QOM'ify OCM

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 18 hw/ppc/ppc405_uc.c | 73 -- 2 files changed, 63 insertions(+), 28 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index f7c0eb1d0008..e56363366cad 100644 --- a/hw/ppc

[PATCH 02/19] ppc/ppc405: Introduce a PPC405 generic machine

2022-08-01 Thread Cédric Le Goater
We will use this machine as a base to define the ref405ep and possibly the PPC405 hotfoot board as found in the Linux kernel. Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405_boards.c | 31 --- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/hw/ppc/ppc

[PATCH 03/19] ppc/ppc405: Move devices under the ref405ep machine

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405_boards.c | 31 +++ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc/ppc405_boards.c index 4c269b6526a5..24ec948d22a4 100644 --- a/hw/ppc/ppc405_boards.c +++ b/hw/ppc/ppc405

[PATCH 04/19] ppc/ppc405: Introduce a PPC405 SoC

2022-08-01 Thread Cédric Le Goater
It is an initial model to start QOMification of the PPC405 board. Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 17 ++ hw/ppc/ppc405_boards.c | 29 ++- hw/ppc/ppc405_uc.c | 53 ++ 3 files changed, 82 inser

[PATCH 14/19] ppc/ppc405: QOM'ify POB

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 14 +++ hw/ppc/ppc405_uc.c | 58 +++--- 2 files changed, 53 insertions(+), 19 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index ebff00bdad80..d39d65cc86e4 100644 --- a/hw/ppc/

[PATCH 08/19] ppc/ppc405: QOM'ify GPT

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 22 hw/ppc/ppc405_uc.c | 90 +++--- 2 files changed, 67 insertions(+), 45 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index d51fb5094e95..f7c0eb1d0008 100644 --- a/hw/ppc

[PATCH 10/19] ppc/ppc405: QOM'ify GPIO

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 21 +++ hw/ppc/ppc405_uc.c | 50 +- 2 files changed, 44 insertions(+), 27 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index e56363366cad..46366c3b8a19 100644 --- a

[PATCH 15/19] ppc/ppc405: QOM'ify PLB

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 14 ++ hw/ppc/ppc405_uc.c | 67 +- 2 files changed, 62 insertions(+), 19 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index d39d65cc86e4..4ff5cdcf5c65 100644 --- a/hw/ppc/p

[PATCH 05/19] ppc/ppc405: Start QOMification of the SoC

2022-08-01 Thread Cédric Le Goater
This moves all the code previously done in the ppc405ep_init() routine under ppc405_soc_realize(). Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 12 ++-- hw/ppc/ppc405_boards.c | 12 ++-- hw/ppc/ppc405_uc.c | 151 - 3 files changed, 84

[PATCH 07/19] ppc/ppc405: QOM'ify CPC

2022-08-01 Thread Cédric Le Goater
Since all clock settings are now handled at the CPC level, this changes the SoC "sys-clk" property to be an alias on the same property in the CPC model. Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 39 +++- hw/ppc/ppc405_uc.c | 109 +++

[PATCH 06/19] ppc/ppc405: QOM'ify CPU

2022-08-01 Thread Cédric Le Goater
Drop the use of ppc4xx_init() and duplicate a bit of code related to clocks in the SoC realize routine. We will clean that up in the following patches. ppc_dcr_init simply allocates default DCR handlers for the CPU. Maybe this could be done in model initializer of the CPU families needing it. Sig

[PATCH 13/19] ppc/ppc405: QOM'ify OPBA

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 12 hw/ppc/ppc405_uc.c | 47 +++--- 2 files changed, 40 insertions(+), 19 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index f1acb37185f5..ebff00bdad80 100644 --- a/hw/ppc

[PATCH 19/19] ppc/ppc405: QOM'ify I2C

2022-08-01 Thread Cédric Le Goater
Having an explicit I2C model object will help if one day we want to add I2C devices on the bus. Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 2 ++ hw/ppc/ppc405_uc.c | 10 -- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h in

[PATCH 12/19] ppc/ppc405: QOM'ify EBC

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 16 +++ hw/ppc/ppc405_uc.c | 71 +++--- 2 files changed, 64 insertions(+), 23 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index bd662b2444ff..f1acb37185f5 100644 --- a/hw/ppc/

[PATCH 11/19] ppc/ppc405: QOM'ify DMA

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 23 + hw/ppc/ppc405_uc.c | 80 +- 2 files changed, 73 insertions(+), 30 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index 46366c3b8a19..bd662b2444ff 100644 --- a/hw/pp

[PATCH 16/19] ppc/ppc405: QOM'ify MAL

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h | 1 + include/hw/ppc/ppc4xx.h | 28 ++ hw/ppc/ppc405_uc.c | 20 +-- hw/ppc/ppc4xx_devs.c| 120 +--- 4 files changed, 118 insertions(+), 51 deletions(-) diff --git a/hw/ppc/pp

[PATCH 18/19] ppc/ppc405: QOM'ify UIC

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 3 ++- hw/ppc/ppc405_uc.c | 27 ++- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index 0cbfd977aecf..c2cfccb9d106 100644 --- a/hw/ppc/ppc405.h +++ b/hw/ppc/ppc40

[PATCH 17/19] ppc/ppc405: QOM'ify FPGA

2022-08-01 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405_boards.c | 55 +- 1 file changed, 38 insertions(+), 17 deletions(-) diff --git a/hw/ppc/ppc405_boards.c b/hw/ppc/ppc405_boards.c index 82b51cc457fa..2900c267b7ac 100644 --- a/hw/ppc/ppc405_boards.c +++ b/hw

Re: [PULL V2 19/25] vdpa: Extract get features part from vhost_vdpa_get_max_queue_pairs

2022-08-01 Thread Eugenio Perez Martin
On Mon, Aug 1, 2022 at 5:29 AM Jason Wang wrote: > > > 在 2022/7/29 22:08, Peter Maydell 写道: > > On Wed, 20 Jul 2022 at 10:04, Jason Wang wrote: > >> From: Eugenio Pérez > >> > >> To know the device features is needed for CVQ SVQ, so SVQ knows if it > >> can handle all commands or not. Extract fr

Re: [PATCH 18/19] ppc/ppc405: QOM'ify UIC

2022-08-01 Thread Cédric Le Goater
Daniel, On 8/1/22 15:10, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- hw/ppc/ppc405.h| 3 ++- hw/ppc/ppc405_uc.c | 27 ++- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/hw/ppc/ppc405.h b/hw/ppc/ppc405.h index 0cbfd977aecf..c2cfc

race condition in display device caused by run_on_cpu() dropping the iothread lock

2022-08-01 Thread Peter Maydell
I've been debugging a segfault in the raspi3b display device, and I've tracked it down to a race condition, but I'm not sure what the right way to fix it is... The race is that a vCPU thread is handling a guest register write that says "resize the framebuffer", which it implements by calling qemu_

Re: [PATCH v2 1/1] monitor: Support specified vCPU registers

2022-08-01 Thread Markus Armbruster
zhenwei pi writes: > Originally we have to get all the vCPU registers and parse the > specified one. To improve the performance of this usage, allow user > specified vCPU id to query registers. > > Run a VM with 16 vCPU, use bcc tool to track the latency of > 'hmp_info_registers': > 'info registe

Re: [PULL 0/3] Hexagon bug fixes and test improvements

2022-08-01 Thread Richard Henderson
On 7/31/22 16:32, Taylor Simpson wrote: The following changes since commit 3916603e0c1d909e14e09d5ebcbdaa9c9e21adf3: Merge tag 'pull-la-20220729' of https://gitlab.com/rth7680/qemu into staging (2022-07-29 17:39:17 -0700) are available in the Git repository at: https://github.com/quic/q

Re: [RFC v5 05/11] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2022-08-01 Thread Eric Blake
On Mon, Aug 01, 2022 at 09:33:05AM +0800, Sam Li wrote: > By adding zone management operations in BlockDriver, storage controller > emulation can use the new block layer APIs including Report Zone and > four zone management operations (open, close, finish, reset). > > BlockDriver can get zone info

[PULL] IPMI bug fixes

2022-08-01 Thread Corey Minyard
Not a huge deal, but probably makes mainainers lives a little easier. Add a change to make Coverity happy. Corey Minyard (1): ipmi:smbus: Add a check around a memcpy hw/ipmi/smbus_ipmi.c | 4 +++- 1 file changed, 3 insertion

[RFC PATCH] util: add a qemu_backtrace utility function

2022-08-01 Thread Alex Bennée
When debugging failures in CI which can't be replicated locally it can be useful to dump a backtrace. However ad-hoc debug code is likely to fail to compile on numerous hosts so lets package up a utility function with proper compiler detection. Signed-off-by: Alex Bennée --- configure

Re: [PATCH v3 1/2] qapi: Add exit-failure PanicAction

2022-08-01 Thread Markus Armbruster
Ilya Leoshkevich writes: > Currently QEMU exits with code 0 on both panic an shutdown. For tests > it is useful to return 1 on panic, so that it counts as a test > failure. > > Introduce a new exit-failure PanicAction that makes main() return > EXIT_FAILURE. Tests can use -action panic=exit-failu

Re: [RFC v5 01/11] include: add zoned device structs

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:32, Sam Li wrote: > > Signed-off-by: Sam Li > --- > include/block/block-common.h | 43 > 1 file changed, 43 insertions(+) > > diff --git a/include/block/block-common.h b/include/block/block-common.h > index fdb7306e78..c9d28b1c51 100

Re: [RFC v5 02/11] include: import virtio_blk headers from linux with zoned storage support

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:33, Sam Li wrote: > > Add file from Dmitry's "virtio-blk:add support for zoned block devices" > linux patch using scripts/update-linux-headers.sh. There is a link for > more information: https://github.com/dmitry-fomichev/virtblk-zbd > > Signed-off-by: Sam Li > --- > in

Re: [PATCH v4 11/17] dump/dump: Add section string table support

2022-08-01 Thread Janosch Frank
On 7/29/22 21:35, Janis Schoetterl-Glausch wrote: On 7/26/22 11:22, Janosch Frank wrote: As sections don't have a type like the notes do we need another way to Having a string table seems like a good idea to me, as we don't know the requirements any architecture might have, but sections do hav

[PATCH] tpm_emulator: Avoid double initialization during migration

2022-08-01 Thread Ross Lagerwall via
When resuming after a migration, the backend sends CMD_INIT to the emulator from the startup callback, then it sends the migration state from the vmstate to the emulator, then it sends CMD_INIT again. Skip the first CMD_INIT during a migration to avoid initializing the TPM twice. Signed-off-by: Ro

Re: [RFC v5 03/11] file-posix: introduce get_sysfs_long_val for the long sysfs attribute

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:39, Sam Li wrote: > > Use sysfs attribute files to get the long value of zoned device > information. > > Signed-off-by: Sam Li > --- > block/file-posix.c | 23 --- > 1 file changed, 16 insertions(+), 7 deletions(-) > > diff --git a/block/file-posix.c

Re: [PATCH] tests/qtest/migration-test: Run the dirty ring tests only with the x86 target

2022-08-01 Thread Dr. David Alan Gilbert
* Thomas Huth (th...@redhat.com) wrote: > kvm_dirty_ring_supported() only checks whether the dirty ring support > is available on the x86 host, but it ignores whether the target QEMU > architecture is x86 or not. Thus the test_vcpu_dirty_limit() test > currently fails with the assert((strcmp(arch,

Re: [PATCH] tpm_emulator: Avoid double initialization during migration

2022-08-01 Thread Marc-André Lureau
Hi On Mon, Aug 1, 2022 at 6:28 PM Ross Lagerwall via wrote: > When resuming after a migration, the backend sends CMD_INIT to the > emulator from the startup callback, then it sends the migration state > from the vmstate to the emulator, then it sends CMD_INIT again. Skip the > first CMD_INIT dur

Re: [PATCH v7 14/14] memfd_create.2: Describe MFD_INACCESSIBLE flag

2022-08-01 Thread Dave Hansen
This patch does not belong in this series. It's not a patch to the kernel. This is a kernel series. It would be much more appropriate to put a link to a separately posted manpage patch in the cover letter.

Re: [RFC v5 04/11] file-posix: introduce get_sysfs_str_val for device zoned model

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:34, Sam Li wrote: > > Use sysfs attribute files to get the string value of device > zoned model. Then get_sysfs_zoned_model can convert it to > BlockZoneModel type in QEMU. > > Signed-off-by: Sam Li > --- > block/file-posix.c | 86 +

[PATCH] vdpa: Fix file descriptor leak on get features error

2022-08-01 Thread Eugenio Pérez
File descriptor vdpa_device_fd is not free in the case of returning error from vhost_vdpa_get_features. Fixing it by making all errors go to the same error path. Resolves: Coverity CID 1490785 Fixes: 8170ab3f43 ("vdpa: Extract get features part from vhost_vdpa_get_max_queue_pairs") Signed-off-by

Re: [RFC v5 05/11] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:34, Sam Li wrote: > > By adding zone management operations in BlockDriver, storage controller > emulation can use the new block layer APIs including Report Zone and > four zone management operations (open, close, finish, reset). > > BlockDriver can get zone information fr

Re: [RFC v5 06/11] raw-format: add zone operations to pass through requests

2022-08-01 Thread Stefan Hajnoczi
Reviewed-by: Stefan Hajnoczi

Re: [RFC v5 07/11] config: add check to block layer

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:39, Sam Li wrote: > > Putting zoned/non-zoned BlockDrivers on top of each other is not > allowed. > > Signed-off-by: Sam Li > --- > block.c | 13 + > block/file-posix.c | 2 ++ > block/raw-format.c | 1 +

[PULL 0/3] target-arm queue

2022-08-01 Thread Peter Maydell
Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20220801 for you to fetch changes up to 5265d24c981dfdda8d29b44f7e84a514da75eedc: target/arm: Move sve probe inside kvm >= 4.15 branch (2022-08-

[PULL 3/3] target/arm: Move sve probe inside kvm >= 4.15 branch

2022-08-01 Thread Peter Maydell
From: Richard Henderson The test for the IF block indicates no ID registers are exposed, much less host support for SVE. Move the SVE probe into the ELSE block. Signed-off-by: Richard Henderson Message-id: 20220726045828.53697-4-richard.hender...@linaro.org Reviewed-by: Peter Maydell Signed-o

[PULL 2/3] target/arm: Set KVM_ARM_VCPU_SVE while probing the host

2022-08-01 Thread Peter Maydell
From: Richard Henderson Because we weren't setting this flag, our probe of ID_AA64ZFR0 was always returning zero. This also obviates the adjustment of ID_AA64PFR0, which had sanitized the SVE field. The effects of the bug are not visible, because the only thing that ID_AA64ZFR0 is used for with

[PULL 1/3] target/arm: Use kvm_arm_sve_supported in kvm_arm_get_host_cpu_features

2022-08-01 Thread Peter Maydell
From: Richard Henderson Indication for support for SVE will not depend on whether we perform the query on the main kvm_state or the temp vcpu. Signed-off-by: Richard Henderson Message-id: 20220726045828.53697-2-richard.hender...@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydel

Re: [RFC v5 08/11] virtio-blk: add zoned storage APIs for zoned devices

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:43, Sam Li wrote: > > This patch extends virtio-blk emulation to handle zoned device commands > by calling the new block layer APIs to perform zoned device I/O on > behalf of the guest. It supports Report Zone, and four zone oparations (open, > close, finish, reset). The

Re: [RFC v5 09/11] qemu-io: add zoned block device operations.

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:42, Sam Li wrote: > > Add zoned storage commands of the device: zone_report(zrp), zone_open(zo), > zone_close(zc), zone_reset(zrs), zone_finish(zf). > > For example, to test zone_report, use following command: > $ ./build/qemu-io --image-opts driver=zoned_host_device, fil

Re: [PULL for-7.1 0/3] hw/nvme fixes

2022-08-01 Thread Richard Henderson
On 8/1/22 03:05, Klaus Jensen wrote: From: Klaus Jensen Hi, The following changes since commit 3916603e0c1d909e14e09d5ebcbdaa9c9e21adf3: Merge tag 'pull-la-20220729' of https://gitlab.com/rth7680/qemu into staging (2022-07-29 17:39:17 -0700) are available in the Git repository at: gi

[PULL 2/7] migration-test: Use migrate_ensure_converge() for auto-converge

2022-08-01 Thread Thomas Huth
From: Peter Xu Thomas reported that auto-converge test will timeout on MacOS CI gatings. Use the migrate_ensure_converge() helper too in the auto-converge as when Daniel reworked the other test cases. Since both max_bandwidth / downtime_limit will not be used for converge calculations, make it s

[PULL 1/7] tests/tcg/linux-test: Fix random hangs in test_socket

2022-08-01 Thread Thomas Huth
From: Ilya Leoshkevich test_socket hangs randomly in connect(), especially when run without qemu. Apparently the reason is that linux started treating backlog value of 0 literally instead of rounding it up since v4.4 (commit ef547f2ac16b). So set it to 1 instead. Signed-off-by: Ilya Leoshkevich

Re: [RFC v5 10/11] qemu-iotests: test new zone operations

2022-08-01 Thread Stefan Hajnoczi
On Sun, 31 Jul 2022 at 21:39, Sam Li wrote: > > We have added new block layer APIs of zoned block devices. Test it with: > Create a null_blk device, run each zone operation on it and see > whether reporting right zone information. > > Signed-off-by: Sam Li > --- > tests/qemu-iotests/tests/zoned.

[PULL 4/7] tests/unit/test-qga: Replace the word 'blacklist' in the guest agent unit test

2022-08-01 Thread Thomas Huth
Let's use better, more inclusive wording here. Message-Id: <20220727092135.302915-4-th...@redhat.com> Reviewed-by: Konstantin Kostiuk Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/unit/test-qga.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t

[PULL 3/7] migration-test: Allow test to run without uffd

2022-08-01 Thread Thomas Huth
From: Peter Xu We used to stop running all tests if uffd is not detected. However logically that's only needed for postcopy not the rest of tests. Keep running the rest when still possible. Signed-off-by: Peter Xu Tested-by: Thomas Huth Message-Id: <20220728133516.92061-3-pet...@redhat.com>

[PULL 6/7] trivial: Fix duplicated words

2022-08-01 Thread Thomas Huth
Some files wrongly contain the same word twice in a row. One of them should be removed or replaced. Message-Id: <20220722145859.1952732-1-th...@redhat.com> Signed-off-by: Thomas Huth --- hw/arm/omap2.c| 2 +- hw/misc/mac_via.c | 2 +- t

  1   2   >