RE: VIRTIO_NET_F_MTU not negotiated

2022-07-27 Thread Eli Cohen
I found out that the reason why I could not enforce the mtu stems from the fact that I did not configure max mtu for the net device (e.g. through libvirt ). Libvirt does not allow this configuration for vdpa devices and probably for a reason. The vdpa backend driver has the freedom to do it using

Re: [PATCH v15 00/10] vhost-vdpa: add support for configure interrupt

2022-07-27 Thread Cindy Lu
On Tue, 26 Jul 2022 at 21:45, Michael S. Tsirkin wrote: > > Hi! > So I don't think this will make it in 7.1. > I'll tag this to be merged afterwards, but just to make sure > please ping me right after the release. > > Thanks! > Got it, thanks Michael, I will ping you that time. Thanks Cindy > On

[PATCH v11 5/6] target/riscv: Update the privilege field for sscofpmf CSRs

2022-07-27 Thread Atish Patra
The sscofpmf extension was ratified as a part of priv spec v1.12. Mark the csr_ops accordingly. Reviewed-by: Alistair Francis Signed-off-by: Atish Patra --- target/riscv/csr.c | 90 ++ 1 file changed, 60 insertions(+), 30 deletions(-) diff --git a/ta

Re: [PATCH] hw/nvme: add trace events for ioeventfd

2022-07-27 Thread Klaus Jensen
On Jul 20 10:47, Jinhao Fan wrote: > at 10:41 PM, Jinhao Fan wrote: > > > at 1:34 PM, Klaus Jensen wrote: > > > >> From: Klaus Jensen > >> > >> While testing Jinhaos ioeventfd patch I found it useful with a couple of > >> additional trace events since we no longer see the mmio events. > >> >

Re: [PATCH 07/16] virtio-net: support queue reset

2022-07-27 Thread Jason Wang
On Wed, Jul 27, 2022 at 2:25 PM Kangjie Xu wrote: > > > 在 2022/7/27 13:00, Jason Wang 写道: > > On Tue, Jul 26, 2022 at 3:02 PM Kangjie Xu > > wrote: > >> > >> 在 2022/7/26 11:43, Jason Wang 写道: > >>> 在 2022/7/18 19:17, Kangjie Xu 写道: > From: Xuan Zhuo > > virtio-net implements queu

Re: [PATCH] hw/nvme: Add iothread support

2022-07-27 Thread Klaus Jensen
On Jul 26 16:55, Jinhao Fan wrote: > > Hi Klaus and Keith, > > I just added support for interrupt masking. How can I test interrupt > masking? > I wondered if this might be possible to test this with a user-space VFIO-based driver, but VFIO does not export masking/unmasking on MSI/MSI-X through

Re: [PATCH 07/16] virtio-net: support queue reset

2022-07-27 Thread Kangjie Xu
在 2022/7/27 14:59, Jason Wang 写道: On Wed, Jul 27, 2022 at 2:25 PM Kangjie Xu wrote: 在 2022/7/27 13:00, Jason Wang 写道: On Tue, Jul 26, 2022 at 3:02 PM Kangjie Xu wrote: 在 2022/7/26 11:43, Jason Wang 写道: 在 2022/7/18 19:17, Kangjie Xu 写道: From: Xuan Zhuo virtio-net implements queue reset

Re: [PATCH v4] hw/nvme: Use ioeventfd to handle doorbell updates

2022-07-27 Thread Klaus Jensen
On Jul 26 14:08, Klaus Jensen wrote: > > Alright. Forget about the iommu, that was just a coincidence. > > This patch seems to fix it. I guess it is the > event_notifier_set_handler(..., NULL) that does the trick, but I'd like > to understand why ;) > > > diff --git i/hw/nvme/ctrl.c w/hw/nvme/c

Re: [PATCH 08/16] vhost: add op to enable or disable a single vring

2022-07-27 Thread Kangjie Xu
在 2022/7/27 12:55, Jason Wang 写道: On Tue, Jul 26, 2022 at 2:39 PM Kangjie Xu wrote: 在 2022/7/26 11:49, Jason Wang 写道: 在 2022/7/18 19:17, Kangjie Xu 写道: The interface to set enable status for a single vring is lacked in VhostOps, since the vhost_set_vring_enable_op will manipulate all virtq

Re: VIRTIO_NET_F_MTU not negotiated

2022-07-27 Thread Michael S. Tsirkin
On Wed, Jul 27, 2022 at 06:51:56AM +, Eli Cohen wrote: > I found out that the reason why I could not enforce the mtu stems from the > fact that I did not configure max mtu for the net device (e.g. through > libvirt ). > Libvirt does not allow this configuration for vdpa devices and probably f

Re: [RFC] hw/nvme: Use irqfd to send interrupts

2022-07-27 Thread Klaus Jensen
On Jul 21 09:29, Stefan Hajnoczi wrote: > On Wed, Jul 20, 2022, 22:36 Jinhao Fan wrote: > > > Hi Stefan, > > > > Thanks for the detailed explanation! > > > > at 6:21 PM, Stefan Hajnoczi wrote: > > > > > Hi Jinhao, > > > Thanks for working on this! > > > > > > irqfd is not necessarily faster than

[PATCH 1/5] util/qemu-sockets: Replace the call to close a socket with closesocket()

2022-07-27 Thread Bin Meng
From: Bin Meng close() is a *nix function. It works on any file descriptor, and sockets in *nix are an example of a file descriptor. closesocket() is a Windows-specific function, which works only specifically with sockets. Sockets on Windows do not use *nix-style file descriptors, and socket() r

[PATCH 0/5] Enable unix socket support on Windows

2022-07-27 Thread Bin Meng
Support for the unix socket has existed both in BSD and Linux for the longest time, but not on Windows. Since Windows 10 build 17063 [1], the native support for the unix socket has came to Windows. Starting this build, two Win32 processes can use the AF_UNIX address family over Winsock API to commu

[PATCH 3/5] qga/commands-win32: Use os_get_win_version()

2022-07-27 Thread Bin Meng
From: Bin Meng Drop its own ga_get_win_version() implementation, and use the one provided in oslib-win32 instead. Signed-off-by: Bin Meng --- qga/commands-win32.c | 27 +-- 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/qga/commands-win32.c b/qga/command

[PATCH 2/5] util/oslib-win32: Add a helper to get the Windows version

2022-07-27 Thread Bin Meng
From: Bin Meng This adds a helper to get the Windows version via the RtlGetVersion call, for QEMU codes to determine the Windows version at run-time. Signed-off-by: Xuzhou Cheng Signed-off-by: Bin Meng --- include/sysemu/os-win32.h | 2 ++ util/oslib-win32.c| 15 +++ 2 f

Re: [PATCH] hw/intc: sifive_plic: Fix multi-socket plic configuraiton

2022-07-27 Thread Alistair Francis
On Tue, Jul 26, 2022 at 8:30 AM Atish Kumar Patra wrote: > > > > > On Sun, Jul 24, 2022 at 6:14 PM Alistair Francis wrote: >> >> On Sat, Jul 23, 2022 at 7:22 PM Atish Patra wrote: >> > >> > Since commit 40244040a7ac, multi-socket configuration with plic is >> > broken as the hartid for second so

[PATCH 5/5] chardev/char-socket: Update AF_UNIX for Windows

2022-07-27 Thread Bin Meng
From: Bin Meng Now that AF_UNIX has come to Windows, update the existing logic in qemu_chr_compute_filename() and qmp_chardev_open_socket() for Windows. Signed-off-by: Bin Meng --- chardev/char-socket.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/chardev/char-so

[PATCH 4/5] util/qemu-sockets: Enable unix socket support on Windows

2022-07-27 Thread Bin Meng
From: Bin Meng Support for the unix socket has existed both in BSD and Linux for the longest time, but not on Windows. Since Windows 10 build 17063 [1], the native support for the unix socket has came to Windows. Starting this build, two Win32 processes can use the AF_UNIX address family over Win

Re: [PATCH] hw/nvme: add trace events for ioeventfd

2022-07-27 Thread Jinhao Fan
at 3:10 PM, Klaus Jensen wrote: > On Jul 20 10:47, Jinhao Fan wrote: >> at 10:41 PM, Jinhao Fan wrote: >> >>> at 1:34 PM, Klaus Jensen wrote: >>> From: Klaus Jensen While testing Jinhaos ioeventfd patch I found it useful with a couple of additional trace events since we

Re: [PATCH v11 4/6] hw/riscv: virt: Add PMU DT node to the device tree

2022-07-27 Thread Atish Kumar Patra
On Wed, Jul 27, 2022 at 12:27 AM Sunil V L wrote: > Hi Atish, > > On Tue, Jul 26, 2022 at 11:49:11PM -0700, Atish Patra wrote: > > Qemu virt machine can support few cache events and cycle/instret > counters. > > It also supports counter overflow for these events. > > > > Add a DT node so that Ope

Re: [PATCH v11 1/6] target/riscv: Add sscofpmf extension support

2022-07-27 Thread Weiwei Li
在 2022/7/27 下午2:49, Atish Patra 写道: The Sscofpmf ('Ss' for Privileged arch and Supervisor-level extensions, and 'cofpmf' for Count OverFlow and Privilege Mode Filtering) extension allows the perf to handle overflow interrupts and filtering support. This patch provides a framework for programmab

Re: [PATCH v4] hw/nvme: Use ioeventfd to handle doorbell updates

2022-07-27 Thread Jinhao Fan
at 3:06 PM, Klaus Jensen wrote: > On Jul 26 14:08, Klaus Jensen wrote: >> Alright. Forget about the iommu, that was just a coincidence. >> >> This patch seems to fix it. I guess it is the >> event_notifier_set_handler(..., NULL) that does the trick, but I'd like >> to understand why ;) >> >> >

Re: Question to mem-path support at QEMU for Xen

2022-07-27 Thread Igor Mammedov
On Tue, 26 Jul 2022 15:27:07 +0800 Huang Rui wrote: > Hi Anthony and other Qemu/Xen guys, > > We are trying to enable venus on Xen virtualization platform. And we would > like to use the backend memory with memory-backend-memfd,id=mem1,size=4G > options on QEMU, however, the QEMU will tell us th

Re: [PATCH v4] hw/nvme: Use ioeventfd to handle doorbell updates

2022-07-27 Thread Klaus Jensen
On Jul 27 16:16, Jinhao Fan wrote: > at 3:06 PM, Klaus Jensen wrote: > > > On Jul 26 14:08, Klaus Jensen wrote: > >> Alright. Forget about the iommu, that was just a coincidence. > >> > >> This patch seems to fix it. I guess it is the > >> event_notifier_set_handler(..., NULL) that does the tric

Re: [PATCH v11 6/6] target/riscv: Remove additional priv version check for mcountinhibit

2022-07-27 Thread Weiwei Li
在 2022/7/27 下午2:49, Atish Patra 写道: With .min_priv_version, additiona priv version check is uncessary for mcountinhibit read/write functions. Reviewed-by: Heiko Stuebner Tested-by: Heiko Stuebner Signed-off-by: Atish Patra --- target/riscv/csr.c | 8 1 file changed, 8 deletions(

Re: [PATCH v11 5/6] target/riscv: Update the privilege field for sscofpmf CSRs

2022-07-27 Thread Weiwei Li
在 2022/7/27 下午2:49, Atish Patra 写道: The sscofpmf extension was ratified as a part of priv spec v1.12. Mark the csr_ops accordingly. Reviewed-by: Alistair Francis Signed-off-by: Atish Patra --- target/riscv/csr.c | 90 ++ 1 file changed, 60 inser

Re: [PATCH 11/16] vhost: introduce restart and release for vhost_dev's vqs

2022-07-27 Thread Kangjie Xu
在 2022/7/27 12:47, Jason Wang 写道: On Tue, Jul 26, 2022 at 1:13 PM Kangjie Xu wrote: 在 2022/7/26 12:13, Jason Wang 写道: 在 2022/7/18 19:17, Kangjie Xu 写道: Introduce vhost_dev_virtqueue_restart(), which can restart the virtqueue when the vhost has already started running. Meanwhile, vhost_dev

Re: [RFC 0/2] Fix Coverity and other errors in ppc440_uc DMA

2022-07-27 Thread Cédric Le Goater
On 7/26/22 20:23, Peter Maydell wrote: This patchset is mainly trying to fix a problem that Coverity spotted in the dcr_write_dma() function in hw/ppc/ppc440_uc.c, where the code is not correctly using the cpu_physical_memory_map() function. While I was fixing that I noticed a second problem in t

Re: [PATCH v3] hw/pci/pci_bridge: ensure PCIe slots have only one slot

2022-07-27 Thread Igor Mammedov
On Mon, 25 Jul 2022 16:59:21 +0300 Vladimir Sementsov-Ogievskiy wrote: > On 7/20/22 14:04, Daniel P. Berrangé wrote: > > On Wed, Jul 20, 2022 at 02:00:16PM +0300, Roman Kagan wrote: > >> On Wed, Jul 20, 2022 at 11:44:26AM +0100, Daniel P. Berrangé wrote: > >>> On Wed, Jul 20, 2022 at 01:25:55

Re: [PATCH v11 2/6] target/riscv: Simplify counter predicate function

2022-07-27 Thread Weiwei Li
在 2022/7/27 下午2:49, Atish Patra 写道: All the hpmcounters and the fixed counters (CY, IR, TM) can be represented as a unified counter. Thus, the predicate function doesn't need handle each case separately. Simplify the predicate function so that we just handle things differently between RV32/RV6

Re: [PATCH 2/5] util/oslib-win32: Add a helper to get the Windows version

2022-07-27 Thread Yan Vugenfirer
On Wed, Jul 27, 2022 at 10:43 AM Bin Meng wrote: > > From: Bin Meng > > This adds a helper to get the Windows version via the RtlGetVersion > call, for QEMU codes to determine the Windows version at run-time. > > Signed-off-by: Xuzhou Cheng > Signed-off-by: Bin Meng > --- > > include/sysemu/os

Re: [PATCH 4/5] util/qemu-sockets: Enable unix socket support on Windows

2022-07-27 Thread Konstantin Kostiuk
On Wed, Jul 27, 2022 at 10:47 AM Bin Meng wrote: > From: Bin Meng > > Support for the unix socket has existed both in BSD and Linux for the > longest time, but not on Windows. Since Windows 10 build 17063 [1], > the native support for the unix socket has came to Windows. Starting > this build, t

Re: [PATCH] .gitlab-ci.d/windows.yml: Enable native Windows symlink

2022-07-27 Thread Daniel P . Berrangé
On Wed, Jul 27, 2022 at 02:02:48PM +0800, Bin Meng wrote: > On Tue, Jul 26, 2022 at 9:38 AM Bin Meng wrote: > > > > On Mon, Jul 25, 2022 at 9:48 PM Alex Bennée wrote: > > > > > > > > > Bin Meng writes: > > > > > > > From: Bin Meng > > > > > > > > The following error message was seen during the

Re: [PATCH 4/5] util/qemu-sockets: Enable unix socket support on Windows

2022-07-27 Thread Yan Vugenfirer
On Wed, Jul 27, 2022 at 10:46 AM Bin Meng wrote: > > From: Bin Meng > > Support for the unix socket has existed both in BSD and Linux for the > longest time, but not on Windows. Since Windows 10 build 17063 [1], > the native support for the unix socket has came to Windows. Starting > this build,

Re: [PATCH 3/5] qga/commands-win32: Use os_get_win_version()

2022-07-27 Thread Konstantin Kostiuk
On Wed, Jul 27, 2022 at 10:36 AM Bin Meng wrote: > From: Bin Meng > > Drop its own ga_get_win_version() implementation, and use the one > provided in oslib-win32 instead. > > Signed-off-by: Bin Meng > --- > > qga/commands-win32.c | 27 +-- > 1 file changed, 1 insertion(

Re: [PATCH] .gitlab-ci.d/windows.yml: Enable native Windows symlink

2022-07-27 Thread Thomas Huth
On 27/07/2022 10.54, Daniel P. Berrangé wrote: On Wed, Jul 27, 2022 at 02:02:48PM +0800, Bin Meng wrote: On Tue, Jul 26, 2022 at 9:38 AM Bin Meng wrote: On Mon, Jul 25, 2022 at 9:48 PM Alex Bennée wrote: Bin Meng writes: From: Bin Meng The following error message was seen during the

RE: VIRTIO_NET_F_MTU not negotiated

2022-07-27 Thread Eli Cohen
> -Original Message- > From: Michael S. Tsirkin > Sent: Wednesday, July 27, 2022 10:25 AM > To: Eli Cohen > Cc: Eugenio Perez Martin ; qemu-devel@nongnu.org; Jason > Wang ; > virtualizat...@lists.linux-foundation.org > Subject: Re: VIRTIO_NET_F_MTU not negotiated > > On Wed, Jul 27, 202

Re: [PATCH 0/5] Enable unix socket support on Windows

2022-07-27 Thread Daniel P . Berrangé
On Wed, Jul 27, 2022 at 03:35:37PM +0800, Bin Meng wrote: > Support for the unix socket has existed both in BSD and Linux for the > longest time, but not on Windows. Since Windows 10 build 17063 [1], > the native support for the unix socket has came to Windows. Starting > this build, two Win32 proc

Re: [PATCH] .gitlab-ci.d/windows.yml: Enable native Windows symlink

2022-07-27 Thread Yonggang Luo
I've seen the cirrus ci always succeed, maybe using cirrus instead? On Wed, Jul 27, 2022 at 5:03 PM Thomas Huth wrote: > > On 27/07/2022 10.54, Daniel P. Berrangé wrote: > > On Wed, Jul 27, 2022 at 02:02:48PM +0800, Bin Meng wrote: > >> On Tue, Jul 26, 2022 at 9:38 AM Bin Meng wrote: > >>> > >>>

Re: [PATCH] .gitlab-ci.d/windows.yml: Enable native Windows symlink

2022-07-27 Thread Thomas Huth
On 27/07/2022 11.11, 罗勇刚(Yonggang Luo) wrote: I've seen the cirrus ci always succeed, maybe using cirrus instead? IIRC the free tier of Cirrus only allows two jobs in parallel, and we're using that for FreeBSD and macOS already - we could maybe add another manual job like we do it for NetBSD

[PATCH 1/3] qga: Replace 'blacklist' command line and config file options by 'block-rpcs'

2022-07-27 Thread Thomas Huth
Let's use a more appropriate wording for this command line and config file option. The old ones are still accepted for compatibility reasons, but marked as deprecated now so that it could be removed in a future version of QEMU. This change is based on earlier patches from Philippe Mathieu-Daudé, w

[PATCH 2/3] qga: Replace 'blacklist' and 'whitelist' in the guest agent sources

2022-07-27 Thread Thomas Huth
Let's use better, more inclusive wording here. Signed-off-by: Thomas Huth --- qga/qapi-schema.json | 4 +-- qga/guest-agent-core.h | 2 +- qga/commands-posix.c | 16 ++-- qga/commands-win32.c | 10 +++ qga/main.c | 59 +- 5

[PATCH for-7.2 0/3] Replace 'blacklist' and 'whitelist' in the guest agent

2022-07-27 Thread Thomas Huth
Let's use more appropriate words here - the feature in the guest agent is about blocking RPCs, so we should talk about that instead of using the term "blacklist" here. The patches are based on earlier work by Philippe Mathieu-Daudé, with the idea for the new option name suggested by BALATON Zoltan

[PATCH 3/3] tests/unit/test-qga: Replace the word 'blacklist' in the guest agent unit test

2022-07-27 Thread Thomas Huth
Let's use better, more inclusive wording here. Signed-off-by: Thomas Huth --- tests/unit/test-qga.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/unit/test-qga.c b/tests/unit/test-qga.c index c398866f46..80bb6b0866 100644 --- a/tests/unit/test-qga.c +++ b/tests/

Re: [PATCH 1/3] qga: Replace 'blacklist' command line and config file options by 'block-rpcs'

2022-07-27 Thread Daniel P . Berrangé
On Wed, Jul 27, 2022 at 11:21:33AM +0200, Thomas Huth wrote: > Let's use a more appropriate wording for this command line and config > file option. The old ones are still accepted for compatibility reasons, > but marked as deprecated now so that it could be removed in a future > version of QEMU. >

Re: [PATCH 2/3] qga: Replace 'blacklist' and 'whitelist' in the guest agent sources

2022-07-27 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Wed, Jul 27, 2022 at 12:21 PM Thomas Huth wrote: > Let's use better, more inclusive wording here. > > Signed-off-by: Thomas Huth > --- > qga/qapi-schema.json | 4 +-- > qga/guest-agent-core.h | 2 +- > qga/commands-posix.c | 16 ++-- > qga/comm

Re: [PATCH 3/3] tests/unit/test-qga: Replace the word 'blacklist' in the guest agent unit test

2022-07-27 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Wed, Jul 27, 2022 at 12:21 PM Thomas Huth wrote: > Let's use better, more inclusive wording here. > > Signed-off-by: Thomas Huth > --- > tests/unit/test-qga.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/unit/test-qga.

Re: [PATCH 3/3] tests/unit/test-qga: Replace the word 'blacklist' in the guest agent unit test

2022-07-27 Thread Daniel P . Berrangé
On Wed, Jul 27, 2022 at 11:21:35AM +0200, Thomas Huth wrote: > Let's use better, more inclusive wording here. > > Signed-off-by: Thomas Huth > --- > tests/unit/test-qga.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |:

Re: [PATCH 1/3] qga: Replace 'blacklist' command line and config file options by 'block-rpcs'

2022-07-27 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Wed, Jul 27, 2022 at 12:29 PM Daniel P. Berrangé wrote: > On Wed, Jul 27, 2022 at 11:21:33AM +0200, Thomas Huth wrote: > > Let's use a more appropriate wording for this command line and config > > file option. The old ones are still accepted for compatibilit

Re: VIRTIO_NET_F_MTU not negotiated

2022-07-27 Thread Michael S. Tsirkin
On Wed, Jul 27, 2022 at 09:04:47AM +, Eli Cohen wrote: > > -Original Message- > > From: Michael S. Tsirkin > > Sent: Wednesday, July 27, 2022 10:25 AM > > To: Eli Cohen > > Cc: Eugenio Perez Martin ; qemu-devel@nongnu.org; > > Jason Wang ; > > virtualizat...@lists.linux-foundation.or

Re: [PATCH 2/3] qga: Replace 'blacklist' and 'whitelist' in the guest agent sources

2022-07-27 Thread Daniel P . Berrangé
On Wed, Jul 27, 2022 at 11:21:34AM +0200, Thomas Huth wrote: > Let's use better, more inclusive wording here. > > Signed-off-by: Thomas Huth > --- > qga/qapi-schema.json | 4 +-- > qga/guest-agent-core.h | 2 +- > qga/commands-posix.c | 16 ++-- > qga/commands-win32.c | 10 +++---

Re: [PATCH 2/5] util/oslib-win32: Add a helper to get the Windows version

2022-07-27 Thread Bin Meng
On Wed, Jul 27, 2022 at 4:50 PM Yan Vugenfirer wrote: > > On Wed, Jul 27, 2022 at 10:43 AM Bin Meng wrote: > > > > From: Bin Meng > > > > This adds a helper to get the Windows version via the RtlGetVersion > > call, for QEMU codes to determine the Windows version at run-time. > > > > Signed-off-

Re: [PATCH 4/5] util/qemu-sockets: Enable unix socket support on Windows

2022-07-27 Thread Bin Meng
On Wed, Jul 27, 2022 at 4:51 PM Yan Vugenfirer wrote: > > On Wed, Jul 27, 2022 at 10:46 AM Bin Meng wrote: > > > > From: Bin Meng > > > > Support for the unix socket has existed both in BSD and Linux for the > > longest time, but not on Windows. Since Windows 10 build 17063 [1], > > the native s

Re: [PATCH 2/5] util/oslib-win32: Add a helper to get the Windows version

2022-07-27 Thread Daniel P . Berrangé
On Wed, Jul 27, 2022 at 05:38:27PM +0800, Bin Meng wrote: > On Wed, Jul 27, 2022 at 4:50 PM Yan Vugenfirer wrote: > > > > On Wed, Jul 27, 2022 at 10:43 AM Bin Meng wrote: > > > > > > From: Bin Meng > > > > > > This adds a helper to get the Windows version via the RtlGetVersion > > > call, for QE

Re: [PATCH 4/5] util/qemu-sockets: Enable unix socket support on Windows

2022-07-27 Thread Bin Meng
On Wed, Jul 27, 2022 at 4:53 PM Konstantin Kostiuk wrote: > > > > > > On Wed, Jul 27, 2022 at 10:47 AM Bin Meng wrote: >> >> From: Bin Meng >> >> Support for the unix socket has existed both in BSD and Linux for the >> longest time, but not on Windows. Since Windows 10 build 17063 [1], >> the na

Re: [PATCH v2 6/9] aspeed: Add AST2600 (BMC) to fby35

2022-07-27 Thread Cédric Le Goater
On 7/5/22 21:13, Peter Delevoryas wrote: You can test booting the BMC with both '-device loader' and '-drive file'. This is necessary because of how the fb-openbmc boot sequence works (jump to 0x2000 after U-Boot SPL). wget https://github.com/facebook/openbmc/releases/download/openbmc-

Re: [PATCH 0/5] Enable unix socket support on Windows

2022-07-27 Thread Bin Meng
On Wed, Jul 27, 2022 at 5:06 PM Daniel P. Berrangé wrote: > > On Wed, Jul 27, 2022 at 03:35:37PM +0800, Bin Meng wrote: > > Support for the unix socket has existed both in BSD and Linux for the > > longest time, but not on Windows. Since Windows 10 build 17063 [1], > > the native support for the u

RE: VIRTIO_NET_F_MTU not negotiated

2022-07-27 Thread Eli Cohen
> -Original Message- > From: Michael S. Tsirkin > Sent: Wednesday, July 27, 2022 12:35 PM > To: Eli Cohen > Cc: Eugenio Perez Martin ; qemu-devel@nongnu.org; Jason > Wang ; > virtualizat...@lists.linux-foundation.org > Subject: Re: VIRTIO_NET_F_MTU not negotiated > > On Wed, Jul 27, 202

Re: [PATCH 0/5] Enable unix socket support on Windows

2022-07-27 Thread Daniel P . Berrangé
On Wed, Jul 27, 2022 at 06:15:50PM +0800, Bin Meng wrote: > On Wed, Jul 27, 2022 at 5:06 PM Daniel P. Berrangé > wrote: > > > > On Wed, Jul 27, 2022 at 03:35:37PM +0800, Bin Meng wrote: > > > Support for the unix socket has existed both in BSD and Linux for the > > > longest time, but not on Wind

Re: [PATCH 2/2] pci: Sanity check mask argument to pci_set_*_by_mask()

2022-07-27 Thread Peter Maydell
On Tue, 26 Jul 2022 at 23:30, Richard Henderson wrote: > > On 7/26/22 09:32, Peter Maydell wrote: > > Coverity complains that in functions like pci_set_word_by_mask() > > we might end up shifting by more than 31 bits. This is true, > > but only if the caller passes in a zero mask. Help Coverity ou

[PATCH for 7.1 0/2] aspeed: QOM fixes

2022-07-27 Thread Cédric Le Goater
Hello, Compiling with CONFIG_QOM_CAST_DEBUG caught a QOM issue in the fby35 machine. The series also includes a trivial cleanup of unused code. Thanks, C. Cédric Le Goater (2): aspeed: Remove unused fields from AspeedMachineState aspeed/fby35: Fix owner of the BMC RAM memory region hw/ar

[PATCH for 7.1 1/2] aspeed: Remove unused fields from AspeedMachineState

2022-07-27 Thread Cédric Le Goater
Fixes: 346160cbf2af ("aspeed: Set the dram container at the SoC level") Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 4193a3d23d1d..b3bbe06f8fa4 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@

[PATCH for 7.1 2/2] aspeed/fby35: Fix owner of the BMC RAM memory region

2022-07-27 Thread Cédric Le Goater
A MachineState object is used as a owner of the RAM region and this asserts in memory_region_init_ram() when QEMU is built with CONFIG_QOM_CAST_DEBUG : /* This will assert if owner is neither NULL nor a DeviceState. * We only want the owner here for the purposes of defining a * uniqu

Re: [PATCH v10 05/21] job.c: add job_lock/unlock while keeping job.h intact

2022-07-27 Thread Vladimir Sementsov-Ogievskiy
On 7/25/22 10:38, Emanuele Giuseppe Esposito wrote: With "intact" we mean that all job.h functions implicitly take the lock. Therefore API callers are unmodified. This means that: - many static functions that will be always called with job lock held become _locked, and call _locked functions

Re: [PATCH v4 02/17] dump: Introduce GuestPhysBlock offset and length filter functions

2022-07-27 Thread Janis Schoetterl-Glausch
On 7/26/22 11:22, Janosch Frank wrote: > The iteration over the memblocks is hard to understand so it's about > time to clean it up. Instead of manually grabbing the next memblock we > can use QTAILQ_FOREACH to iterate over all memblocks. This got out of sync with the patch, didn't it? With that a

virtio: why no full reset on virtio_set_status 0 ?

2022-07-27 Thread Claudio Fontana
Hi Michael and all, I have started researching a qemu / ovs / dpdk bug: https://inbox.dpdk.org/dev/322122fb-619d-96f6-5c3e-9eabdbf38...@redhat.com/T/ that seems to be affecting multiple parties in the telco space, and during this process I noticed that qemu/hw/virtio/virtio.c does not do a ful

Re: [PATCH 2/5] util/oslib-win32: Add a helper to get the Windows version

2022-07-27 Thread Yan Vugenfirer
On Wed, Jul 27, 2022 at 1:00 PM Daniel P. Berrangé wrote: > > On Wed, Jul 27, 2022 at 05:38:27PM +0800, Bin Meng wrote: > > On Wed, Jul 27, 2022 at 4:50 PM Yan Vugenfirer wrote: > > > > > > On Wed, Jul 27, 2022 at 10:43 AM Bin Meng wrote: > > > > > > > > From: Bin Meng > > > > > > > > This adds

Re: updates for designware pci-host

2022-07-27 Thread Ben Dooks
On Wed, Jul 13, 2022 at 05:54:42PM +0100, Ben Dooks wrote: > As part of a project we have been looking at using the DesignWare > PCIe host. We found a few issues of missing features or small bugs > when using this with a recent Linux kernel (v5.17.x) > > Whilst doing this we also made a start on s

When create a new qemu fork, can not run pipeline, what I need to do?

2022-07-27 Thread Yonggang Luo
··· Pipeline cannot be run. No stages / jobs for this pipeline. The form contains the following warning: 121 warnings found: showing first 25 jobs:amd64-centos8-container may allow multiple pipelines to run for a single action due to `rules:when` clause with no `workflow:rules` - read more: htt

Re: [PATCH 0/5] Enable unix socket support on Windows

2022-07-27 Thread Bin Meng
On Wed, Jul 27, 2022 at 6:24 PM Daniel P. Berrangé wrote: > > On Wed, Jul 27, 2022 at 06:15:50PM +0800, Bin Meng wrote: > > On Wed, Jul 27, 2022 at 5:06 PM Daniel P. Berrangé > > wrote: > > > > > > On Wed, Jul 27, 2022 at 03:35:37PM +0800, Bin Meng wrote: > > > > Support for the unix socket has

Re: [PATCH 0/5] Enable unix socket support on Windows

2022-07-27 Thread Stefan Weil via
Am 27.07.22 um 13:37 schrieb Bin Meng: On Wed, Jul 27, 2022 at 6:24 PM Daniel P. Berrangé wrote: That isn't qtest, that is basic unit tests. I would expect those to be able to work with this series Ah, I see. Agreed, will do in v2. Regards, Bin In v2 you might also call RtlGetVersion dire

Re: [PATCH] hw/microblaze: pass random seed to fdt

2022-07-27 Thread Jason A. Donenfeld
Hi Richard, On Tue, Jul 26, 2022 at 08:13:09PM -0700, Richard Henderson wrote: > On 7/26/22 18:49, Jason A. Donenfeld wrote: > > Hi Edgar, > > > > On Thu, Jul 21, 2022 at 8:43 PM Edgar E. Iglesias > > wrote: > >> Ah OK, Paolo, it would be great if you would take this via your tree! > > > > It l

Re: [PATCH 2/5] util/oslib-win32: Add a helper to get the Windows version

2022-07-27 Thread Bin Meng
On Wed, Jul 27, 2022 at 6:00 PM Daniel P. Berrangé wrote: > > On Wed, Jul 27, 2022 at 05:38:27PM +0800, Bin Meng wrote: > > On Wed, Jul 27, 2022 at 4:50 PM Yan Vugenfirer wrote: > > > > > > On Wed, Jul 27, 2022 at 10:43 AM Bin Meng wrote: > > > > > > > > From: Bin Meng > > > > > > > > This adds

Re: [RFC 0/2] Fix Coverity and other errors in ppc440_uc DMA

2022-07-27 Thread BALATON Zoltan
On Wed, 27 Jul 2022, Cédric Le Goater wrote: On 7/26/22 20:23, Peter Maydell wrote: This patchset is mainly trying to fix a problem that Coverity spotted in the dcr_write_dma() function in hw/ppc/ppc440_uc.c, where the code is not correctly using the cpu_physical_memory_map() function. Likely

Re: [PATCH v3] target/s390x: support PRNO_TRNG instruction

2022-07-27 Thread Jason A. Donenfeld
Hey Thomas, On Wed, Jul 27, 2022 at 08:32:22AM +0200, Thomas Huth wrote: > On 27/07/2022 03.35, Jason A. Donenfeld wrote: > > Hey David, > > > > On Wed, Jul 20, 2022 at 08:41:48PM +0200, David Hildenbrand wrote: > >> I did not review the doc in detail once again, maybe I get to that later > >> th

Re: [PATCH V9 41/46] python/machine: QEMUMachine reopen_qmp_connection

2022-07-27 Thread Steven Sistare
On 7/26/2022 2:04 PM, John Snow wrote: > On Tue, Jul 26, 2022 at 12:12 PM Steve Sistare > wrote: >> >> Provide reopen_qmp_connection() to reopen a closed monitor connection. >> This is needed by cpr, because qemu exec closes the monitor socket. >> >> Signed-off-by: Steve Sistare >> --- >> python

Re: [PATCH 0/5] Enable unix socket support on Windows

2022-07-27 Thread Bin Meng
On Wed, Jul 27, 2022 at 7:45 PM Stefan Weil wrote: > > Am 27.07.22 um 13:37 schrieb Bin Meng: > > > On Wed, Jul 27, 2022 at 6:24 PM Daniel P. Berrangé > > wrote: > >> That isn't qtest, that is basic unit tests. I would expect those to > >> be able to work with this series > > Ah, I see. Agreed,

[PATCH for-7.2] hw: Add compat machines for 7.2

2022-07-27 Thread Cornelia Huck
Add 7.2 machine types for arm/i440fx/m68k/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw/i386/pc.c | 3 +++ hw/i386/pc_piix.c | 14 +- hw/i386/pc_q35.c | 13 +++

Re: [PATCH] hw/intc: sifive_plic: Fix multi-socket plic configuraiton

2022-07-27 Thread Alistair Francis
On Sat, Jul 23, 2022 at 7:22 PM Atish Patra wrote: > > Since commit 40244040a7ac, multi-socket configuration with plic is > broken as the hartid for second socket is calculated incorrectly. > The hartid stored in addr_config already includes the offset > for the base hartid for that socket. Adding

Re: [PATCH 2/5] util/oslib-win32: Add a helper to get the Windows version

2022-07-27 Thread Daniel P . Berrangé
On Wed, Jul 27, 2022 at 07:55:40PM +0800, Bin Meng wrote: > On Wed, Jul 27, 2022 at 6:00 PM Daniel P. Berrangé > wrote: > > > > On Wed, Jul 27, 2022 at 05:38:27PM +0800, Bin Meng wrote: > > > On Wed, Jul 27, 2022 at 4:50 PM Yan Vugenfirer > > > wrote: > > > > > > > > On Wed, Jul 27, 2022 at 10:

Re: updates for designware pci-host

2022-07-27 Thread Peter Maydell
On Wed, 27 Jul 2022 at 12:15, Ben Dooks wrote: > > On Wed, Jul 13, 2022 at 05:54:42PM +0100, Ben Dooks wrote: > > As part of a project we have been looking at using the DesignWare > > PCIe host. We found a few issues of missing features or small bugs > > when using this with a recent Linux kernel

Re: [PATCH v2 0/9] Add Cortex-R52

2022-07-27 Thread Peter Maydell
On Wed, 27 Jul 2022 at 12:43, Tobias Roehmel wrote: > > On 18.07.22 13:54, Tobias Roehmel wrote: > ping > > https://patchew.org/QEMU/20220718115433.802-1-quic._5ftroh...@quicinc.com/ > https://lore.kernel.org/qemu-devel/20220718115433.802-1-quic_troh...@quicinc.com/ > > I didn't reply to the previ

Re: [RFC patch 0/1] block: vhost-blk backend

2022-07-27 Thread Stefano Garzarella
On Tue, Jul 26, 2022 at 04:15:48PM +0200, Denis V. Lunev wrote: On 26.07.2022 15:51, Michael S. Tsirkin wrote: On Mon, Jul 25, 2022 at 11:55:26PM +0300, Andrey Zhadchenko wrote: Although QEMU virtio-blk is quite fast, there is still some room for improvements. Disk latency can be reduced if we

Re: [RFC 0/2] Fix Coverity and other errors in ppc440_uc DMA

2022-07-27 Thread Peter Maydell
On Wed, 27 Jul 2022 at 12:55, BALATON Zoltan wrote: > > On Wed, 27 Jul 2022, Cédric Le Goater wrote: > > On 7/26/22 20:23, Peter Maydell wrote: > >> This patchset is mainly trying to fix a problem that Coverity spotted > >> in the dcr_write_dma() function in hw/ppc/ppc440_uc.c, where the code > >>

Re: [RFC 0/2] Fix Coverity and other errors in ppc440_uc DMA

2022-07-27 Thread Peter Maydell
On Wed, 27 Jul 2022 at 14:01, Peter Maydell wrote: > > On Wed, 27 Jul 2022 at 12:55, BALATON Zoltan wrote: > > > > On Wed, 27 Jul 2022, Cédric Le Goater wrote: > > > On 7/26/22 20:23, Peter Maydell wrote: > > >> This patchset is mainly trying to fix a problem that Coverity spotted > > >> in the d

Re: [PATCH 2/5] util/oslib-win32: Add a helper to get the Windows version

2022-07-27 Thread Bin Meng
On Wed, Jul 27, 2022 at 8:53 PM Daniel P. Berrangé wrote: > > On Wed, Jul 27, 2022 at 07:55:40PM +0800, Bin Meng wrote: > > On Wed, Jul 27, 2022 at 6:00 PM Daniel P. Berrangé > > wrote: > > > > > > On Wed, Jul 27, 2022 at 05:38:27PM +0800, Bin Meng wrote: > > > > On Wed, Jul 27, 2022 at 4:50 PM

Re: [PATCH 2/5] util/oslib-win32: Add a helper to get the Windows version

2022-07-27 Thread Konstantin Kostiuk
On Wed, Jul 27, 2022 at 2:58 PM Bin Meng wrote: > On Wed, Jul 27, 2022 at 6:00 PM Daniel P. Berrangé > wrote: > > > > On Wed, Jul 27, 2022 at 05:38:27PM +0800, Bin Meng wrote: > > > On Wed, Jul 27, 2022 at 4:50 PM Yan Vugenfirer > wrote: > > > > > > > > On Wed, Jul 27, 2022 at 10:43 AM Bin Meng

Re: updates for designware pci-host

2022-07-27 Thread Ben Dooks
On 27/07/2022 13:56, Peter Maydell wrote: On Wed, 27 Jul 2022 at 12:15, Ben Dooks wrote: On Wed, Jul 13, 2022 at 05:54:42PM +0100, Ben Dooks wrote: As part of a project we have been looking at using the DesignWare PCIe host. We found a few issues of missing features or small bugs when using t

Re: [PATCH 2/5] util/oslib-win32: Add a helper to get the Windows version

2022-07-27 Thread Bin Meng
On Wed, Jul 27, 2022 at 9:18 PM Konstantin Kostiuk wrote: > > > > On Wed, Jul 27, 2022 at 2:58 PM Bin Meng wrote: >> >> On Wed, Jul 27, 2022 at 6:00 PM Daniel P. Berrangé >> wrote: >> > >> > On Wed, Jul 27, 2022 at 05:38:27PM +0800, Bin Meng wrote: >> > > On Wed, Jul 27, 2022 at 4:50 PM Yan Vug

[PATCH v2 1/6] util/qemu-sockets: Replace the call to close a socket with closesocket()

2022-07-27 Thread Bin Meng
From: Bin Meng close() is a *nix function. It works on any file descriptor, and sockets in *nix are an example of a file descriptor. closesocket() is a Windows-specific function, which works only specifically with sockets. Sockets on Windows do not use *nix-style file descriptors, and socket() r

[PATCH v2 0/6] Enable unix socket support on Windows

2022-07-27 Thread Bin Meng
Support for the unix socket has existed both in BSD and Linux for the longest time, but not on Windows. Since Windows 10 build 17063 [1], the native support for the unix socket has came to Windows. Starting this build, two Win32 processes can use the AF_UNIX address family over Winsock API to commu

[PATCH v2 3/6] qga/commands-win32: Use os_get_win_version()

2022-07-27 Thread Bin Meng
From: Bin Meng Drop its own ga_get_win_version() implementation, and use the one provided in oslib-win32 instead. Signed-off-by: Bin Meng --- (no changes since v1) qga/commands-win32.c | 27 +-- 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/qga/command

[PATCH v2 2/6] util/oslib-win32: Add a helper to get the Windows version

2022-07-27 Thread Bin Meng
From: Bin Meng This adds a helper to get the Windows version via the RtlGetVersion call, for QEMU codes to determine the Windows version at run-time. Signed-off-by: Xuzhou Cheng Signed-off-by: Bin Meng --- (no changes since v1) include/sysemu/os-win32.h | 2 ++ util/oslib-win32.c|

[PATCH v2 4/6] util/qemu-sockets: Enable unix socket support on Windows

2022-07-27 Thread Bin Meng
From: Bin Meng Support for the unix socket has existed both in BSD and Linux for the longest time, but not on Windows. Since Windows 10 build 17063 [1], the native support for the unix socket has came to Windows. Starting this build, two Win32 processes can use the AF_UNIX address family over Win

[PATCH v2 5/6] chardev/char-socket: Update AF_UNIX for Windows

2022-07-27 Thread Bin Meng
From: Bin Meng Now that AF_UNIX has come to Windows, update the existing logic in qemu_chr_compute_filename() and qmp_chardev_open_socket() for Windows. Signed-off-by: Bin Meng --- Changes in v2: - drop #include as it is now already included in osdep.h chardev/char-socket.c | 4 +++- 1 file

Re: updates for designware pci-host

2022-07-27 Thread Ben Dooks
On 27/07/2022 13:56, Peter Maydell wrote: On Wed, 27 Jul 2022 at 12:15, Ben Dooks wrote: On Wed, Jul 13, 2022 at 05:54:42PM +0100, Ben Dooks wrote: As part of a project we have been looking at using the DesignWare PCIe host. We found a few issues of missing features or small bugs when using t

[PATCH v2 6/6] tests/unit: Update test-io-channel-socket.c for Windows

2022-07-27 Thread Bin Meng
From: Bin Meng Enable the following 3 test cases for Windows when AF_UNIX is available: * test_io_channel_unix_sync * test_io_channel_unix_async * test_io_channel_unix_listen_cleanup Signed-off-by: Bin Meng --- Changes in v2: - new patch: tests/unit: Update test-io-channel-socket.c for

Re: [PATCH v3] target/ppc: Implement new wait variants

2022-07-27 Thread Daniel Henrique Barboza
On 7/20/22 10:33, Nicholas Piggin wrote: ISA v2.06 adds new variations of wait, specified by the WC field. These are not all compatible with the prior wait implementation, because they add additional conditions that cause the processor to resume, which can cause software to hang or run very sl

[PATCH v2] s390x/cpumodel: add stfl197 processor-activity-instrumentation extension 1

2022-07-27 Thread Christian Borntraeger
Add stfle 197 (processor-activity-instrumentation extension 1) to the gen16 default model and fence it off for 7.1 and older. Signed-off-by: Christian Borntraeger Reviewed-by: David Hildenbrand --- v1->v2: - this is on top of "hw: Add compat machines for 7.2" from Cornelia Huck (please queue aft

[PATCH 3/3] dump: support cancel dump process

2022-07-27 Thread Hogan Wang via
Break saving pages or dump iterate when dump job in cancel state, make sure dump process exits as soon as possible. Signed-off-by: Hogan Wang --- dump/dump.c | 24 include/sysemu/dump.h | 2 ++ 2 files changed, 26 insertions(+) diff --git a/dump/dump.c b/dump

  1   2   3   >